Message ID | 1606896236-62780-1-git-send-email-yash.shah@sifive.com |
---|---|
Headers | show |
Series | arch: riscv: add board and SoC DT file support | expand |
On Wed, Dec 02, 2020 at 01:33:53PM +0530, Yash Shah wrote: > --- > Documentation/devicetree/bindings/gpio/sifive,gpio.yaml | 4 +++- > Documentation/devicetree/bindings/i2c/i2c-ocores.txt | 6 ++++-- > Documentation/devicetree/bindings/pwm/pwm-sifive.yaml | 9 ++++++--- > Documentation/devicetree/bindings/riscv/cpus.yaml | 6 ++++++ > Documentation/devicetree/bindings/serial/sifive-serial.yaml | 4 +++- > Documentation/devicetree/bindings/spi/spi-sifive.yaml | 10 ++++++---- > 6 files changed, 28 insertions(+), 11 deletions(-) The driver bindings for the various subsystems would normally be sent as independent patches to those subsystems. Driver changes mostly get reviewed by subsystem maintainers rather than architecture maintainers.
> diff --git a/Documentation/devicetree/bindings/i2c/i2c-ocores.txt b/Documentation/devicetree/bindings/i2c/i2c-ocores.txt > index 6b25a80..1966b2c 100644 > --- a/Documentation/devicetree/bindings/i2c/i2c-ocores.txt > +++ b/Documentation/devicetree/bindings/i2c/i2c-ocores.txt > @@ -3,9 +3,11 @@ Device tree configuration for i2c-ocores > Required properties: > - compatible : "opencores,i2c-ocores" > "aeroflexgaisler,i2cmst" > - "sifive,fu540-c000-i2c", "sifive,i2c0" > + "sifive,<chip>-i2c", "sifive,i2c0" Please make this a full list. At some point, this file will get turned into yaml, at which point substitution like this will need expanding. It is better to do that now. Andrew
> -----Original Message----- > From: Andrew Lunn <andrew@lunn.ch> > Sent: 02 December 2020 20:28 > To: Yash Shah <yash.shah@openfive.com> > Cc: linux-spi@vger.kernel.org; linux-serial@vger.kernel.org; linux- > pwm@vger.kernel.org; linux-i2c@vger.kernel.org; linux- > kernel@vger.kernel.org; linux-riscv@lists.infradead.org; > devicetree@vger.kernel.org; linux-gpio@vger.kernel.org; > broonie@kernel.org; gregkh@linuxfoundation.org; aou@eecs.berkeley.edu; > lee.jones@linaro.org; u.kleine-koenig@pengutronix.de; > thierry.reding@gmail.com; peter@korsgaard.com; Paul Walmsley ( Sifive) > <paul.walmsley@sifive.com>; palmer@dabbelt.com; robh+dt@kernel.org; > bgolaszewski@baylibre.com; linus.walleij@linaro.org; Sachin Ghadi > <sachin.ghadi@openfive.com> > Subject: Re: [PATCH 1/4] dt-bindings: riscv: Update DT binding docs to > support SiFive FU740 SoC > > [External Email] Do not click links or attachments unless you recognize the > sender and know the content is safe > > > diff --git a/Documentation/devicetree/bindings/i2c/i2c-ocores.txt > > b/Documentation/devicetree/bindings/i2c/i2c-ocores.txt > > index 6b25a80..1966b2c 100644 > > --- a/Documentation/devicetree/bindings/i2c/i2c-ocores.txt > > +++ b/Documentation/devicetree/bindings/i2c/i2c-ocores.txt > > @@ -3,9 +3,11 @@ Device tree configuration for i2c-ocores Required > > properties: > > - compatible : "opencores,i2c-ocores" > > "aeroflexgaisler,i2cmst" > > - "sifive,fu540-c000-i2c", "sifive,i2c0" > > + "sifive,<chip>-i2c", "sifive,i2c0" > > Please make this a full list. At some point, this file will get turned into yaml, at > which point substitution like this will need expanding. It is better to do that > now. Ok sure, will do that in patch v2. - Yash > > Andrew