diff mbox series

[v2,3/9] dt-bindings: pwm: Update DT binding docs to support SiFive FU740 SoC

Message ID 1607403341-57214-4-git-send-email-yash.shah@sifive.com
State Accepted
Commit b1f592d5c1e31dfa46a161c52740f3bff1b1e963
Headers show
Series [v2,1/9] dt-bindings: riscv: Update DT binding docs to support SiFive FU740 SoC | expand

Commit Message

Yash Shah Dec. 8, 2020, 4:55 a.m. UTC
Add new compatible strings to the DT binding documents to support SiFive
FU740-C000.

Signed-off-by: Yash Shah <yash.shah@sifive.com>
---
 Documentation/devicetree/bindings/pwm/pwm-sifive.yaml | 9 ++++++---
 1 file changed, 6 insertions(+), 3 deletions(-)

Comments

Rob Herring (Arm) Dec. 10, 2020, 3:56 a.m. UTC | #1
On Tue, Dec 08, 2020 at 10:25:35AM +0530, Yash Shah wrote:
> Add new compatible strings to the DT binding documents to support SiFive

> FU740-C000.

> 

> Signed-off-by: Yash Shah <yash.shah@sifive.com>

> ---

>  Documentation/devicetree/bindings/pwm/pwm-sifive.yaml | 9 ++++++---

>  1 file changed, 6 insertions(+), 3 deletions(-)

> 

> diff --git a/Documentation/devicetree/bindings/pwm/pwm-sifive.yaml b/Documentation/devicetree/bindings/pwm/pwm-sifive.yaml

> index 5ac2527..84e6691 100644

> --- a/Documentation/devicetree/bindings/pwm/pwm-sifive.yaml

> +++ b/Documentation/devicetree/bindings/pwm/pwm-sifive.yaml

> @@ -25,12 +25,15 @@ description:

>  properties:

>    compatible:

>      items:

> -      - const: sifive,fu540-c000-pwm

> +      - enum:

> +          - sifive,fu540-c000-pwm

> +          - sifive,fu740-c000-pwm

>        - const: sifive,pwm0

>      description:

>        Should be "sifive,<chip>-pwm" and "sifive,pwm<version>". Supported

> -      compatible strings are "sifive,fu540-c000-pwm" for the SiFive PWM v0

> -      as integrated onto the SiFive FU540 chip, and "sifive,pwm0" for the

> +      compatible strings are "sifive,fu540-c000-pwm" and

> +      "sifive,fu740-c000-pwm" for the SiFive PWM v0 as integrated onto the

> +      SiFive FU540 and FU740 chip respectively, and "sifive,pwm0" for the


Better if you reword this so we don't have to update it for every new 
compatible.

>        SiFive PWM v0 IP block with no chip integration tweaks.

>        Please refer to sifive-blocks-ip-versioning.txt for details.

>  

> -- 

> 2.7.4

>
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/pwm/pwm-sifive.yaml b/Documentation/devicetree/bindings/pwm/pwm-sifive.yaml
index 5ac2527..84e6691 100644
--- a/Documentation/devicetree/bindings/pwm/pwm-sifive.yaml
+++ b/Documentation/devicetree/bindings/pwm/pwm-sifive.yaml
@@ -25,12 +25,15 @@  description:
 properties:
   compatible:
     items:
-      - const: sifive,fu540-c000-pwm
+      - enum:
+          - sifive,fu540-c000-pwm
+          - sifive,fu740-c000-pwm
       - const: sifive,pwm0
     description:
       Should be "sifive,<chip>-pwm" and "sifive,pwm<version>". Supported
-      compatible strings are "sifive,fu540-c000-pwm" for the SiFive PWM v0
-      as integrated onto the SiFive FU540 chip, and "sifive,pwm0" for the
+      compatible strings are "sifive,fu540-c000-pwm" and
+      "sifive,fu740-c000-pwm" for the SiFive PWM v0 as integrated onto the
+      SiFive FU540 and FU740 chip respectively, and "sifive,pwm0" for the
       SiFive PWM v0 IP block with no chip integration tweaks.
       Please refer to sifive-blocks-ip-versioning.txt for details.