From patchwork Tue Mar 13 13:14:09 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arnd Bergmann X-Patchwork-Id: 131466 Delivered-To: patch@linaro.org Received: by 10.46.84.17 with SMTP id i17csp722170ljb; Tue, 13 Mar 2018 06:14:41 -0700 (PDT) X-Google-Smtp-Source: AG47ELv95IpTfCbeAl22qyJTyq79xZtahE4j4GCCXzIEF/4w4b8UGAlYBJcCrEIPutrBU6BZlsd2 X-Received: by 10.99.3.144 with SMTP id 138mr486840pgd.364.1520946881508; Tue, 13 Mar 2018 06:14:41 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1520946881; cv=none; d=google.com; s=arc-20160816; b=cnbRu77DamFDRYNC+jKuBZ8uHXI0R2iZupEU1kmoSHtgsn2B8j0tdoxzi+kHK0rtm2 /OkEFI52AAimFkRzyk6zzDJIYBXSVTw8by+99zVCB+OJyn5L3kVFwEC5cZozbx3pMcZa Yd8JvKC4Gg6t0HBhakULtsSbZ5Io+HxreIYB+JTcEKqgrEQRnulR8FWJZVmXvtKSTBZu 1NZF6AL5zWEWpGcMwwb5+N2sHV7QBE3jFhgLgSAnR2rPQaPNMj4i4ybG/0KPDCzZKhEC 1i0zQ+eLaGSt+ZYvEJocKlZ809IdbtBVYmNrMtRq0nkPhWPUymZqepfW0qmboLrjBXLR ynqA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:date:subject:cc:to:from :arc-authentication-results; bh=Ql7nAEkHCKPhiYlevkkDNEZpL12orRPX0VV6Zl2dhVM=; b=msuPnIbGIe2oV+ZYdEVwMt6OfZ8CYOq4rVcSIe1PPOUVo/U93yLjJ8QEvSktCbSPtV 9x3jFGuhqWfMUWqEkrynXZ6/GMgVfL1ZsO/VyUlVhLu8WnCbUA957oL1rs998TtlDM6D oaiIoXjFoFfeI0xKSPV799PUdkRTK73/lxzbaPKATVORKT1vp8ETvdzIYmBMhop8VSWg bLZF0RgrfSaPr4Kno6X/JNh5xLnYY5NfEVPcdIRa510KBgP8SY2QBV5/+dyLV5G/a+Li 1d6TOue3U1BYmUci5fUBxQI9JofpRoucYYa5MZKrvJ8/N2u26SBmvRjYuC4ZJr9LPlxi Pz+w== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id t1si105821pgp.480.2018.03.13.06.14.41; Tue, 13 Mar 2018 06:14:41 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932242AbeCMNOg (ORCPT + 28 others); Tue, 13 Mar 2018 09:14:36 -0400 Received: from mout.kundenserver.de ([212.227.126.134]:54783 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751852AbeCMNOe (ORCPT ); Tue, 13 Mar 2018 09:14:34 -0400 Received: from wuerfel.lan ([95.208.111.237]) by mrelayeu.kundenserver.de (mreue004 [212.227.15.129]) with ESMTPA (Nemesis) id 0MLTGA-1evBWk2A7u-000eAv; Tue, 13 Mar 2018 14:14:24 +0100 From: Arnd Bergmann To: Steve Longerbeam , Philipp Zabel , Mauro Carvalho Chehab , Greg Kroah-Hartman Cc: Arnd Bergmann , Hans Verkuil , Russell King , linux-media@vger.kernel.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: [PATCH] media: imx: work around false-positive warning Date: Tue, 13 Mar 2018 14:14:09 +0100 Message-Id: <20180313131422.40710-1-arnd@arndb.de> X-Mailer: git-send-email 2.9.0 X-Provags-ID: V03:K0:lwgeH8CYbjofM9DV/o1EmbQj3gPLA75y4SaqkfjMdCulfsc/oZj lE1xNKLLgvJOhsb2IemsGnyMw/9a+5p6hK/fhYdHo5EYvakoVf5VdVJpADXFeMXMuMhvUnt t2mP076VIzvkn9KTw8gFi8WgW65IEm8BLDcQwRiralJGV3jPE2yFVzMY+9niy62jxRqb2hU xRd7/Q8YwzLTxBbS7ReiA== X-UI-Out-Filterresults: notjunk:1; V01:K0:BjZm+/uAie8=:dl9ltLvt+GRUXrSO/CkcnV 8VHrlRSnm5tVZt4ODuV7MOIx8nyGcH8QuQlhWPV+p2BcsO1k6s50en5XdzcJy/ZS/GkqX/YwT 9GJZjtn2IJAtZQE+Pk5VhJFkD62Xg+P4IFwOQ3HdXeoHK85aG91mQhR0wwsGx96k5d696qi6n 7jaeA9kIbG4mdOOaAP6toKkVnDNWPQTQGd+1iiSgFzI25ty8qicmG4KtR48Vuvef7Hhiz3BE4 /UlSgM4Y2XgWURJGW0FXaqBztmdI/4WsDW9ukpryGrgaOI6dAvZTV4y7FWuGQXyduvPIlZ17j 7dbYk5/jgb0Oh5sIVrSW7I5rqA9eqIxFP2u7qo5EZciX6GF6Vx/Nn5e2faMYbKEgGZSm7bPkw +E+zM15uP7Em+dw/3mULgzNkAQsy3AoYYAT1rgjhB1bmL5IxKRpl/jPEZEEbJonr01361SPaL EMJ3I6S+GgSzJ+ELwXTFYEhgnBCbHMjFV9bOCKC0oybonR6FNgFY+46Wi5ojRal0ioFxwNeoV ePwVaLQuhqJSZVVdJ0Ddpu/b+wU3VkgOTzhew+aKyy5Ui1SPCkPigtnO848ax0qBNnkZoR3YE hjQHGbzRKV5F/U0TuBkYuF+j+PQ8hMg7L2l/VIGr76f1lj98+QOtjwCMhKmlubjN9cOESuev7 mENYAmK0/px3WVnLca/kxhmPtY6WNBEfHAWI8rVDz8XmOjwIo6uzoTb266RUUJLbsDd2FSDop egCzENiNyUXChelC1BFgpOdux79jBwGfadx3VA== Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The IS_ERR()/PTR_ERR() combination confuses gcc to the point that it cannot prove the upstream_ep variable to be initialized: drivers/staging/media/imx/imx-media-csi.c: In function 'csi_link_validate': drivers/staging/media/imx/imx-media-csi.c:1025:20: error: 'upstream_ep' may be used uninitialized in this function [-Werror=maybe-uninitialized] priv->upstream_ep = upstream_ep; ~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~ drivers/staging/media/imx/imx-media-csi.c:1026:24: error: 'upstream_ep.bus_type' may be used uninitialized in this function [-Werror=maybe-uninitialized] is_csi2 = (upstream_ep.bus_type == V4L2_MBUS_CSI2); ~~~~~~~~~~~^~~~~~~~~ drivers/staging/media/imx/imx-media-csi.c:127:19: error: 'upstream_ep.bus.parallel.bus_width' may be used uninitialized in this function [-Werror=maybe-uninitialized] I could come up with no good way to rewrite this function, as a last resort, this adds an explicit zero-intialization of the structure. Fixes: 52e17089d185 ("media: imx: Don't initialize vars that won't be used") Signed-off-by: Arnd Bergmann --- drivers/staging/media/imx/imx-media-csi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.9.0 diff --git a/drivers/staging/media/imx/imx-media-csi.c b/drivers/staging/media/imx/imx-media-csi.c index 5a195f80a24d..887fed0c3ce0 100644 --- a/drivers/staging/media/imx/imx-media-csi.c +++ b/drivers/staging/media/imx/imx-media-csi.c @@ -1004,7 +1004,7 @@ static int csi_link_validate(struct v4l2_subdev *sd, struct v4l2_subdev_format *sink_fmt) { struct csi_priv *priv = v4l2_get_subdevdata(sd); - struct v4l2_fwnode_endpoint upstream_ep; + struct v4l2_fwnode_endpoint upstream_ep = {}; const struct imx_media_pixfmt *incc; bool is_csi2; int ret;