From patchwork Mon Feb 1 23:26:06 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alex Elder X-Patchwork-Id: 374294 Delivered-To: patch@linaro.org Received: by 2002:a17:906:24d5:0:0:0:0 with SMTP id f21csp4333829ejb; Mon, 1 Feb 2021 15:28:29 -0800 (PST) X-Google-Smtp-Source: ABdhPJxTqGosUGs7HhWGxVgbI/dqMPNFVQUEVhz3xLNhUVxGwgfJYzHIu5IIwn7xLxpcXKNg8cRP X-Received: by 2002:a17:906:8053:: with SMTP id x19mr9986221ejw.470.1612222109113; Mon, 01 Feb 2021 15:28:29 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1612222109; cv=none; d=google.com; s=arc-20160816; b=UcWg1zpqvaIx0qFd2Uarx5Twzdl+JpFshC38jOGEUaLH3KpVAicK9/FdRdpoIH+Yh2 0Nmy59WbT4kf0K1SJFgRwNk2kY9jflqxAWuaaA9HzQoDuQO/DjHkdUBUD+VMse4gwWof 4pRwcKkesuNjLZAjbfK0+B0OkD+5UgTyE8I16k0AtWqNfc/QOwlPxa8k8SjUs7c2MdfU s3xYl2LmiZIo5gIJbKm0otm1U1IAh2AOvVgfDUO5fght64te5IX6GRiL7PYJMxAosIMi xSWfJz/uzExV5W1J23T1KwIQH/J3xDMZAqiKfl67hPaAuF5tDHL1it/NG40qSE4LeF2b XXfA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=Lc/k5K9QUyP48nZxgWZukJoyJ65VbtFetvLAJEaMjJg=; b=IPVYvTW710EeQbHxX68+s0knSZpvkyGQqy7aJl9KI5G3cWO0nsAnrPuBf8Ne1k1nig zJZ2xMtQzvNrJC2kEjzm6mrr20uDOu7d5f6CU6nXnRq3ljso23EOj/fssl6lMmrQsh3x GLZXmYqNyBmGCFbGa6pbwGfpvZpsJRCrRpd8YdR/F/s3Af/YWw2XQRQWbtBTkdRSRNSN V9USyeP0Vyr4R83FOINYOenx1wIdLGw8ht9ZZtyIkU7mYpI0qwDAdeT4q3NjqKBIDmqX +0er8Yjr5kliUEGw33oZ1YhuTfc8h4t9mhZZvdqdJKWNZzJOerdPG0nFVT6UE5u39xc1 stEQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=QS+709Ti; spf=pass (google.com: domain of netdev-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=netdev-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id q8si230299edg.20.2021.02.01.15.28.28; Mon, 01 Feb 2021 15:28:29 -0800 (PST) Received-SPF: pass (google.com: domain of netdev-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=QS+709Ti; spf=pass (google.com: domain of netdev-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=netdev-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231335AbhBAX11 (ORCPT + 7 others); Mon, 1 Feb 2021 18:27:27 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59766 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231258AbhBAX0y (ORCPT ); Mon, 1 Feb 2021 18:26:54 -0500 Received: from mail-io1-xd2d.google.com (mail-io1-xd2d.google.com [IPv6:2607:f8b0:4864:20::d2d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B0E1DC061756 for ; Mon, 1 Feb 2021 15:26:14 -0800 (PST) Received: by mail-io1-xd2d.google.com with SMTP id h11so19316825ioh.11 for ; Mon, 01 Feb 2021 15:26:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=Lc/k5K9QUyP48nZxgWZukJoyJ65VbtFetvLAJEaMjJg=; b=QS+709Ti8z2gOlzrId8etHfiB6R62SANk4U1CHSaRcCSJdHGaWF8H5D4ZVNL7LwxlD 8U/AMcARtH4vh6q6k6DbR5ut/Kbg4upYgeY2SCSS8JotI6JcYnUkikr375tUilMM8NwC TInh2poMgo76eVbV0XrsXPe3uJbET31f8c9hqM8rwmDesQF8Z5wwSXte2oeCvqgnUwlI xmyCW8ll23UGYs1HkBfIFHkrM4HXNS6ZRcbkAX61c3RihXUVJO60iq5r/9mZO9FzHMS5 iHC7ln/zUAmTUrJJQbYJrGMHNC3FME8nq1Bbgci2Q2ZZtOukNVDG+qFb0jcjnCsMk0p7 3ZSQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=Lc/k5K9QUyP48nZxgWZukJoyJ65VbtFetvLAJEaMjJg=; b=M9f1YhxgQ5wzfebP1Thb+TmxGjLqpbsc7NIaakAFkARDp1WYyyC45Ah4OStNeT3rKm HqTk4XKSrR29VPVWnK6jgqK1I2ZGaRP/cch4JQjEUwtPyyJW3wOtK3polY+X2F+bKIfa gNVFkQGd4uVBl00r6lbxr8Cj6evgsshVPaOJX7rVPl2FP7O0XftRkk8+VX0IAVWXJY31 kYufZClDh+WGddz3oaryzP2yAwa3m/4uq+ZNDCcIPNJ2Y9kDHMRHEB0EW/809phVc3Do soEpKZqtxQ7TEHNjbXLabzg9UMR9fgDmvyBXsf9bYh2Cw8WEENKtQJKqRoK/adlvmhmx EpHw== X-Gm-Message-State: AOAM532zazNYxWAAcPW7FL4qlIutHRAF7EPWkaNmdmYlEJacnWr+8p3i u3ct+s3Qe898KH/EQB3oCEEraw== X-Received: by 2002:a02:caaa:: with SMTP id e10mr16083799jap.102.1612221974236; Mon, 01 Feb 2021 15:26:14 -0800 (PST) Received: from presto.localdomain (c-73-185-129-58.hsd1.mn.comcast.net. [73.185.129.58]) by smtp.gmail.com with ESMTPSA id v18sm10359588ila.29.2021.02.01.15.26.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 01 Feb 2021 15:26:13 -0800 (PST) From: Alex Elder To: davem@davemloft.net, kuba@kernel.org Cc: elder@kernel.org, evgreen@chromium.org, bjorn.andersson@linaro.org, cpratapa@codeaurora.org, subashab@codeaurora.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH net 1/4] net: ipa: add a missing __iomem attribute Date: Mon, 1 Feb 2021 17:26:06 -0600 Message-Id: <20210201232609.3524451-2-elder@linaro.org> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20210201232609.3524451-1-elder@linaro.org> References: <20210201232609.3524451-1-elder@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org The virt local variable in gsi_channel_state() does not have an __iomem attribute but should. Fix this. Signed-off-by: Alex Elder --- drivers/net/ipa/gsi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.27.0 Reviewed-by: Amy Parker diff --git a/drivers/net/ipa/gsi.c b/drivers/net/ipa/gsi.c index 14d9a791924bf..e2e77f09077a9 100644 --- a/drivers/net/ipa/gsi.c +++ b/drivers/net/ipa/gsi.c @@ -440,7 +440,7 @@ static void gsi_evt_ring_de_alloc_command(struct gsi *gsi, u32 evt_ring_id) static enum gsi_channel_state gsi_channel_state(struct gsi_channel *channel) { u32 channel_id = gsi_channel_id(channel); - void *virt = channel->gsi->virt; + void __iomem *virt = channel->gsi->virt; u32 val; val = ioread32(virt + GSI_CH_C_CNTXT_0_OFFSET(channel_id)); From patchwork Mon Feb 1 23:26:07 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alex Elder X-Patchwork-Id: 374293 Delivered-To: patch@linaro.org Received: by 2002:a17:906:24d5:0:0:0:0 with SMTP id f21csp4333823ejb; Mon, 1 Feb 2021 15:28:28 -0800 (PST) X-Google-Smtp-Source: ABdhPJzQKZmv7wb+si08/buBqExm1GmzJXp8GaGaYGYrGSWtybeexQcj0guCdNtTJ6qnyojznoKX X-Received: by 2002:a17:906:a669:: with SMTP id en9mr20275928ejb.353.1612222108069; Mon, 01 Feb 2021 15:28:28 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1612222108; cv=none; d=google.com; s=arc-20160816; b=RRkevyklZMe8Bbz1Qc62TvuMfGMTjQwEFGMtHkzEWDPUDZjyQpCk+4c8Otfy/IdN/p idIK11ZyAuIkqg84DFp/Xhx1WDtyNBKNK/uS5BA80NS4IH6l+eGwHbgN/XnPxzvUbewq yw/NvKYD3+6qtA34bv8AtUp/n1OxdJx5HvwFrmROfAulYBFVMQ77hz43PBfW4avLC+WW pgoQUqFHqpn2oaTYOXw77zjCVxp/GtPcdscMq+mmzR/Z29XfGkNnYuCB1UKUbMhx6OYS trn/QosKnD15WJ6GAE/4vfnu1a+/HbnrE3DWuO8Q+dWQBJk+ykv1+ezjlLR7CrkPK7wl 4Rdw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=TZynBD22K6qpzM6Yh76qjCwf3pTBe5alSzNft0NWoIQ=; b=OkjJAFM/MJfXz3mqcGfTGhU3drqVeFsM+VnzcwOXLXheXlg83WEmM9YoPNsqWtq98w D+qMY9DYXQIcxAAOMjTYXzSZPCGEz5JpO0IW2v+AtbWf0P0XrD0PCKEcumuQtovnwg0K qkSb7mlZcVoLycRmWQZ7s8EEHysIxZ5W8EOHYq42j10cYuOI6CII4WQ5FZKrRtvFptVM eaNgqzxtO7TGEnezSojwKFQgFCPXJt/lYgjwdW49sI65OFnSL6C59qj4XE3RiPQ8A4s6 YUu8b9NLh+BJxUq6RFrqNuLm6orY9wnAjADwZwSTNS+WGAmovrG2DdiafKwCI+9pww57 8i6w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=NIHr2Aq+; spf=pass (google.com: domain of netdev-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=netdev-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id q8si230299edg.20.2021.02.01.15.28.27; Mon, 01 Feb 2021 15:28:28 -0800 (PST) Received-SPF: pass (google.com: domain of netdev-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=NIHr2Aq+; spf=pass (google.com: domain of netdev-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=netdev-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231321AbhBAX1N (ORCPT + 7 others); Mon, 1 Feb 2021 18:27:13 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59776 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231273AbhBAX04 (ORCPT ); Mon, 1 Feb 2021 18:26:56 -0500 Received: from mail-il1-x12d.google.com (mail-il1-x12d.google.com [IPv6:2607:f8b0:4864:20::12d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E1257C0613ED for ; Mon, 1 Feb 2021 15:26:15 -0800 (PST) Received: by mail-il1-x12d.google.com with SMTP id m20so9835949ilj.13 for ; Mon, 01 Feb 2021 15:26:15 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=TZynBD22K6qpzM6Yh76qjCwf3pTBe5alSzNft0NWoIQ=; b=NIHr2Aq+gAUuQ+bMAHQM1WU4q2DPkL+sVGYZEN1OnIFVyZkBbEKCpftjUDCAqITBsf RP8hEazoRxKh7FvP1o8SlpNPTxBy6gLs6679bosgwNgpv3i8TTC3pooIAHKE9oKojkum cFBXvH1eCxC0DiPkT1VIanRe7sM5MHjxq4uDCF7NyZ2TSCxj2GM8yQ0txihq6/KXkJVx vxo3QpeG4kZdtFQwVEov7QMseUB2hOvrKJx+VPTTkee3n4r617mJMRxXTjRuXciwGb/P MGjISQq3R+SLUKimd2S7k71O0pQ7YLvrNC8DfxltWasAXrpVq0Xc/T2/OzlJLmBywZyM YdXQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=TZynBD22K6qpzM6Yh76qjCwf3pTBe5alSzNft0NWoIQ=; b=hiUlagVpiyMcvLMNv6dlADYHmz7yIjKDneNf0ymAcS9isY4CRbW6gdtyo2GjFOVefY dLJZIa0fI1LRNUUdCbI07iQ/rafARquKjdUDRZ1UmUOChyGg3VVQg2HzXAx1gcNUHqog 00iaK5wh4NC8XTysbyPrbNBYYHqK8Z+0650MayfRigfrRbohIQ30020N+4b6+esXCmlG Ju9tZbmqScVkMDVj0NEP0tYEFdcY+6hOttFVL/PD7El6a5E0BNyU1QfMpmRhv6Z9ezJ7 ci/UAZimGdGk+vJ39+Iy5llqYjOyoFQcyMMiysKttdjaOhVI0S3mhTCk+mIALhEXtvdR Giyg== X-Gm-Message-State: AOAM533aO9Qc3az56MSJm7UliJxi1yNTaQu3IGu/EurhSo9FLvsVypiL Iopz3+/YFHFcA7+5VdtpB5znkg== X-Received: by 2002:a05:6e02:1a89:: with SMTP id k9mr13620271ilv.68.1612221975432; Mon, 01 Feb 2021 15:26:15 -0800 (PST) Received: from presto.localdomain (c-73-185-129-58.hsd1.mn.comcast.net. [73.185.129.58]) by smtp.gmail.com with ESMTPSA id v18sm10359588ila.29.2021.02.01.15.26.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 01 Feb 2021 15:26:14 -0800 (PST) From: Alex Elder To: davem@davemloft.net, kuba@kernel.org Cc: elder@kernel.org, evgreen@chromium.org, bjorn.andersson@linaro.org, cpratapa@codeaurora.org, subashab@codeaurora.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH net 2/4] net: ipa: be explicit about endianness Date: Mon, 1 Feb 2021 17:26:07 -0600 Message-Id: <20210201232609.3524451-3-elder@linaro.org> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20210201232609.3524451-1-elder@linaro.org> References: <20210201232609.3524451-1-elder@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Sparse warns that the assignment of the metadata mask for a QMAP endpoint in ipa_endpoint_init_hdr_metadata_mask() is a bad assignment. We know we want the mask value to be big endian, even though the value we write is in host byte order. Use a __force tag to indicate we really mean it. Signed-off-by: Alex Elder --- drivers/net/ipa/ipa_endpoint.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.27.0 diff --git a/drivers/net/ipa/ipa_endpoint.c b/drivers/net/ipa/ipa_endpoint.c index 9f4be9812a1f3..448d89da1e456 100644 --- a/drivers/net/ipa/ipa_endpoint.c +++ b/drivers/net/ipa/ipa_endpoint.c @@ -588,7 +588,7 @@ static void ipa_endpoint_init_hdr_metadata_mask(struct ipa_endpoint *endpoint) /* Note that HDR_ENDIANNESS indicates big endian header fields */ if (endpoint->data->qmap) - val = cpu_to_be32(IPA_ENDPOINT_QMAP_METADATA_MASK); + val = (__force u32)cpu_to_be32(IPA_ENDPOINT_QMAP_METADATA_MASK); iowrite32(val, endpoint->ipa->reg_virt + offset); } From patchwork Mon Feb 1 23:26:08 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alex Elder X-Patchwork-Id: 374296 Delivered-To: patch@linaro.org Received: by 2002:a17:906:24d5:0:0:0:0 with SMTP id f21csp4333847ejb; Mon, 1 Feb 2021 15:28:31 -0800 (PST) X-Google-Smtp-Source: ABdhPJyBwYAste8DIKkDBmbT7L3/0iHg5mHI/tTRBcnCeE515YNsM8p1y9FBWHyIaq1Wp+RPoL2Z X-Received: by 2002:a17:906:1a11:: with SMTP id i17mr7457820ejf.278.1612222111058; Mon, 01 Feb 2021 15:28:31 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1612222111; cv=none; d=google.com; s=arc-20160816; b=dyRdihX3tiSAMjPUxESq1PR3jWy9xToax+UAgg5RnmpbOS3PFWrBj1xZBfYJnWSDyw x/0L3wBcUcCEQ9H7pYwa2phnPzh0kkTxHr3zcE1e2y+GpM1ks+j+h0b80CXVePX5JVxq xHkUQVCJmXzHXo2vzBL3Nd9ZCVnJcfGr1JjtAPV46CdhfEYrs02QDJNJ74BpC7jvy1tI w/ZThVttcoESAey5E1dBo0hqGKX7UTNax8icSzVmEsPQ0x2Q3h6lbMj85NY/PmAH8q21 nzYlSsKNQYGxYEGBKACIyggDiI0jdMm64rONri+ZpUHVmSJsMnqMlRP3PQ8p4zbrQ4am ayaA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=4p3cO0YhU77yiKrmXUdqUneMp2jPhjqG6jsuBLPBK3I=; b=0askDjkDSo0DB0TvI8DKPdG3nMZWA+wDfpzSeg/N3G1VOmcO12JDgB7tAWiRc+69e0 NHrTvk1IX63ptlPIjOOOn+0/U15ccixG/HtGDideET5l3jlzJlzEeLgT/JxhheyY/rqV DN1Ocx+vZEUeMjvCZZrcHdULKeiZFSRZ7Gg0hcCuKXJiga9gFxANbp6NSpwNO+bSVIw1 lxmrATpaML4+Yy7W8CYf2DpSOAJ+SevjmNp87i0qgFHZ9mG7lJ4Xvc46eSeM0RLW49E1 raS8cr6mNKy9SFayj+ceJxoZ4jsYaUGWugJEITGVvQSEXbqZ+b+NIZIzejaqgTzZLkOG Zkxg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=fzhtc7G1; spf=pass (google.com: domain of netdev-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=netdev-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id q8si230299edg.20.2021.02.01.15.28.30; Mon, 01 Feb 2021 15:28:31 -0800 (PST) Received-SPF: pass (google.com: domain of netdev-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=fzhtc7G1; spf=pass (google.com: domain of netdev-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=netdev-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231365AbhBAX1o (ORCPT + 7 others); Mon, 1 Feb 2021 18:27:44 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59914 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231337AbhBAX1f (ORCPT ); Mon, 1 Feb 2021 18:27:35 -0500 Received: from mail-il1-x133.google.com (mail-il1-x133.google.com [IPv6:2607:f8b0:4864:20::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EEC40C061788 for ; Mon, 1 Feb 2021 15:26:16 -0800 (PST) Received: by mail-il1-x133.google.com with SMTP id y5so17351201ilg.4 for ; Mon, 01 Feb 2021 15:26:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=4p3cO0YhU77yiKrmXUdqUneMp2jPhjqG6jsuBLPBK3I=; b=fzhtc7G12o7cHQ/MNxt58fASJM++yTIgQXR2x/P9wu6V2kwj0XRPFgzlqmWSeDM6mx Tx3an9GGlh1C6/EimXvEuqw/Qepskh6UMcU5YpKwSJTGFtjvPTffqv8z03Laq02QmCBl rtacQ3zeR8qBBUGsHGV2HYqupXFUDYiCDTNHcAJtJkOQldKz7alS7HtCDEnIXYubmG/i vu77DKOSnGBfCoPH8BZkEIE3FEF55H8D6gkflW9wSkB4MgUlqzdmvFqw2QXui1kaqALM LEbPEMF3nJiQkVUadJwU6avT30b7TCXVHqEwqRsomfMHD5/fA4bJAVfYQ+DpON38ugKT HK2w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=4p3cO0YhU77yiKrmXUdqUneMp2jPhjqG6jsuBLPBK3I=; b=U5rd/s+EmTgZVHtaSLbHXpZHwJ6KYPwWvkDCpPaPyA8e1t3dbQMl348dDLDRsw+bPU u0/EXLSY5fEQOKsmFzb3zHrgfkXHvXuoZIpxqf8Ne2OIBoNH9VD3Xy57wzbvgxmPvJ3/ EtE5BrrH7x4A1tjin6NFuHjctpSgo8raJCCqTNf65rXO3T4GIwX+SEqv7shZhjl6f9mx nqCQ3OLNB5eEOZ9yefW0ZOoPWHwiSDcZeAK5cjWJTN/7q4eOXGYLHkibvtuinC26YXMf 9NLdpM1h+8+BkDX7Ynsf7q4d2YpcdjETWqsUgMnw1mhBvEDZ0FjcIZn/PVvkacCoToYn mQaw== X-Gm-Message-State: AOAM533dWxNXhKZqanL9alb7G4mlQTZwszIulifUJJF7UOBHOV2gGAfd HhIh+EkTJ+JpAELEujkP3lNBXg== X-Received: by 2002:a92:cccb:: with SMTP id u11mr14751002ilq.44.1612221976467; Mon, 01 Feb 2021 15:26:16 -0800 (PST) Received: from presto.localdomain (c-73-185-129-58.hsd1.mn.comcast.net. [73.185.129.58]) by smtp.gmail.com with ESMTPSA id v18sm10359588ila.29.2021.02.01.15.26.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 01 Feb 2021 15:26:15 -0800 (PST) From: Alex Elder To: davem@davemloft.net, kuba@kernel.org Cc: elder@kernel.org, evgreen@chromium.org, bjorn.andersson@linaro.org, cpratapa@codeaurora.org, subashab@codeaurora.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH net 3/4] net: ipa: use the right accessor in ipa_endpoint_status_skip() Date: Mon, 1 Feb 2021 17:26:08 -0600 Message-Id: <20210201232609.3524451-4-elder@linaro.org> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20210201232609.3524451-1-elder@linaro.org> References: <20210201232609.3524451-1-elder@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org When extracting the destination endpoint ID from the status in ipa_endpoint_status_skip(), u32_get_bits() is used. This happens to work, but it's wrong: the structure field is only 8 bits wide instead of 32. Fix this by using u8_get_bits() to get the destination endpoint ID. Signed-off-by: Alex Elder --- drivers/net/ipa/ipa_endpoint.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) -- 2.27.0 diff --git a/drivers/net/ipa/ipa_endpoint.c b/drivers/net/ipa/ipa_endpoint.c index 448d89da1e456..612afece303f3 100644 --- a/drivers/net/ipa/ipa_endpoint.c +++ b/drivers/net/ipa/ipa_endpoint.c @@ -1164,8 +1164,8 @@ static bool ipa_endpoint_status_skip(struct ipa_endpoint *endpoint, return true; if (!status->pkt_len) return true; - endpoint_id = u32_get_bits(status->endp_dst_idx, - IPA_STATUS_DST_IDX_FMASK); + endpoint_id = u8_get_bits(status->endp_dst_idx, + IPA_STATUS_DST_IDX_FMASK); if (endpoint_id != endpoint->endpoint_id) return true; From patchwork Mon Feb 1 23:26:09 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alex Elder X-Patchwork-Id: 374295 Delivered-To: patch@linaro.org Received: by 2002:a17:906:24d5:0:0:0:0 with SMTP id f21csp4333836ejb; Mon, 1 Feb 2021 15:28:30 -0800 (PST) X-Google-Smtp-Source: ABdhPJy1Zrt2lsNXtwp9R05iuzWy/db8smfC9gVSVqditiXTO8G64Q6KDlhR3+wfNat14P5AwPjK X-Received: by 2002:a17:906:3b8e:: with SMTP id u14mr6160152ejf.179.1612222109932; Mon, 01 Feb 2021 15:28:29 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1612222109; cv=none; d=google.com; s=arc-20160816; b=XPwwEwBXRQABKqwN5K+DhOMJyoH76qLI70+QrLxiKa/VGLdg9l0MaR7OXoVWyiz5IJ uTDnToJOWxlk+xV7GEsf5sjFHy/EdaKjgJTj4fymCK99qZ/MhhHfmwOURcu+MXHsGowJ QLlccR2eViYsu2e0U00tiUSgR+FW/wL6tSQusiQVE/Gmh9G/LhWTCaBxXIEOIBv81TlG 9AAKVSxufsD/N07Gekgq/+hOZtor//o0e139u/mYrpqbOepXhtwHJj9h8jelb82dJryk vcAvjkrT2SMMHvpnW2L5ISokgPjH53daot7rK2BylLXHlcJBiJjr5GyCQZXG6EBDyDEi ar4Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=Zd7FyycW3KcctLd6KYXPpMsa8mRy7OXVhvVd96yduhE=; b=HYgM08KvuRCN7Cbs1ce33ytVQ5CpdHgPzYziMfksYv2UHrjlkoTJeWXTZjzNAbNCCZ E39V+Q1aecPhZv7otedy3FPC1KShzIREIgfP5FIJM9SoFRU17bSysSfX3ovgVRe1zqHu HVcqEn3Wwt17nJv3tPAsLlaaFwPBupSRUe2lhzP/BKts+w6SwAoLFdZD5LDBwnPmGuei neqfOCUNqWI6vQiI78c6oxergy1fAyjSZTb61vmisYcU5PgcYI6My3O3DCpeO8BF5FWC JffnHCRHhmulkESduxlCkQdP8W3AFEeKq4C+VkNdu1ePK04dfdAseKybkPGUvjlutM41 SBaQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=x6Zx5mmO; spf=pass (google.com: domain of netdev-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=netdev-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id q8si230299edg.20.2021.02.01.15.28.29; Mon, 01 Feb 2021 15:28:29 -0800 (PST) Received-SPF: pass (google.com: domain of netdev-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=x6Zx5mmO; spf=pass (google.com: domain of netdev-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=netdev-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231378AbhBAX1u (ORCPT + 7 others); Mon, 1 Feb 2021 18:27:50 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59924 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231341AbhBAX1f (ORCPT ); Mon, 1 Feb 2021 18:27:35 -0500 Received: from mail-io1-xd2d.google.com (mail-io1-xd2d.google.com [IPv6:2607:f8b0:4864:20::d2d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id F0670C06178C for ; Mon, 1 Feb 2021 15:26:17 -0800 (PST) Received: by mail-io1-xd2d.google.com with SMTP id s24so7786409iob.6 for ; Mon, 01 Feb 2021 15:26:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=Zd7FyycW3KcctLd6KYXPpMsa8mRy7OXVhvVd96yduhE=; b=x6Zx5mmOYLrYqyolEVeWMSSoYaHG8qWQD7O50XB1xDGSL2PrfJEyowmL6U6r+cgUKq lDYmDHt6c9ReVyZeuBO9n7AaUpr5FE3ZOX22gCjqC2yeiS/cYPPfabOqg6L7+FbGpMaJ CtTVONvHCKzHsjLYtY/z6//NHB62Kv4LhoppEUR4543w2/Dtd5CFkHNFSq1ezrfLizqn IX9YlmtntIZXVM6ZDll+7wQEMasn1VA3ZTLfSIYx9XGfpyW7rfy3VctuLQ8WAe7RRKXm GCx8AKZ4fFQb3DLsw4dVNzp7LBFYGL2xk68PKiC7HCBLjVpRIo3/5jdrffbvkf1v54kt bsdQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=Zd7FyycW3KcctLd6KYXPpMsa8mRy7OXVhvVd96yduhE=; b=VGdLjOAKCJzbp+B1P/TQsZVlIjGQqlGJf2hf71oTUIXgNjB27st6CAxzpygl4vseNP ObyqyXYcrVg18cCVa+anRz5W26OJn23NNC6JX60QZBgyrO+AjT3GQiZq0GMQJnEE8e4Z ficSbrR28hee91CSuXSGSHahAL6zGSJj2ahhZQEmx1Y5jUzp6VRci4OfzVDKhQ7tnPEe V0vOlLkjDW74jvUOMplUziD2s7uO/YDj5el9zi1/gs3IM5f8nfjIwM0BphCInAbfjFPo QLldPuDcQxbuLycnBDdEDpa1Jrw1DY7+0wzTJQkjb+bJSPazVkjdNzQMmxrAAkKvR9om 8JaQ== X-Gm-Message-State: AOAM532vULClq1a0TDG8fCMuMVGDdPEhSttk7Loonq2Tae3ktJ16vNjv cKw0ecHfK+ng9xz3oyeTD0KwfQ== X-Received: by 2002:a5d:9041:: with SMTP id v1mr14086354ioq.155.1612221977473; Mon, 01 Feb 2021 15:26:17 -0800 (PST) Received: from presto.localdomain (c-73-185-129-58.hsd1.mn.comcast.net. [73.185.129.58]) by smtp.gmail.com with ESMTPSA id v18sm10359588ila.29.2021.02.01.15.26.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 01 Feb 2021 15:26:16 -0800 (PST) From: Alex Elder To: davem@davemloft.net, kuba@kernel.org Cc: elder@kernel.org, evgreen@chromium.org, bjorn.andersson@linaro.org, cpratapa@codeaurora.org, subashab@codeaurora.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH net 4/4] net: ipa: fix two format specifier errors Date: Mon, 1 Feb 2021 17:26:09 -0600 Message-Id: <20210201232609.3524451-5-elder@linaro.org> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20210201232609.3524451-1-elder@linaro.org> References: <20210201232609.3524451-1-elder@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Fix two format specifiers that used %lu for a size_t in "ipa_mem.c". Signed-off-by: Alex Elder --- drivers/net/ipa/ipa_mem.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) -- 2.27.0 diff --git a/drivers/net/ipa/ipa_mem.c b/drivers/net/ipa/ipa_mem.c index 0cc3a3374caa2..f25029b9ec857 100644 --- a/drivers/net/ipa/ipa_mem.c +++ b/drivers/net/ipa/ipa_mem.c @@ -336,7 +336,7 @@ static void ipa_imem_exit(struct ipa *ipa) size = iommu_unmap(domain, ipa->imem_iova, ipa->imem_size); if (size != ipa->imem_size) - dev_warn(dev, "unmapped %zu IMEM bytes, expected %lu\n", + dev_warn(dev, "unmapped %zu IMEM bytes, expected %zu\n", size, ipa->imem_size); } else { dev_err(dev, "couldn't get IPA IOMMU domain for IMEM\n"); @@ -440,7 +440,7 @@ static void ipa_smem_exit(struct ipa *ipa) size = iommu_unmap(domain, ipa->smem_iova, ipa->smem_size); if (size != ipa->smem_size) - dev_warn(dev, "unmapped %zu SMEM bytes, expected %lu\n", + dev_warn(dev, "unmapped %zu SMEM bytes, expected %zu\n", size, ipa->smem_size); } else {