From patchwork Mon Mar 5 14:48:49 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: John Garry X-Patchwork-Id: 130637 Delivered-To: patch@linaro.org Received: by 10.46.66.2 with SMTP id p2csp2771400lja; Mon, 5 Mar 2018 06:49:54 -0800 (PST) X-Google-Smtp-Source: AG47ELtTE9ZD27WdZyV3Ws1Yov+gDiSvrpSrFYvjo0gvbn/8P1U3SNmqR++SOu/5iwkrNe2vOKCQ X-Received: by 10.99.125.78 with SMTP id m14mr12452931pgn.391.1520261394383; Mon, 05 Mar 2018 06:49:54 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1520261394; cv=none; d=google.com; s=arc-20160816; b=qO9SgWLPPF7gdfVOilHsnKoUOWdotQGk2lmaFzuhW0QsFgA2aZWVyLWN4lekM2Fja8 js1qrgG6JQag7XJPrGHijMWt9FHGqW1GwAX3KIcWzhDdhuAMHAE3FwO4f/ua8saMvLTV CP/xSmVA0zA1F+oD+FEvD/b5dXsdI3tobJ4K0TgJqQ2lQuOlybcGbotyjkx55V+p5lGN 1MssWNRHOTkd8bTC2ynfqqu+6aprziTH80twJ9g6nhwXwgc8d3uUElP8PljGu+DHbD47 JP0fMF55h3J3aQjSRMazlw0x4ATJhjKY1+44RVD5nzBAG/+1aqArk+hs34aQjpoWxhkv YInQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:arc-authentication-results; bh=0ETw5fAlDkCnm8cnZ0iQKy9sMW0cGFmGGH49oXnzhUE=; b=orFrXRGHlZVfXuD6ti1Zg+7NexwxxV37EiC6CSwescCvhA0nWC3LcllGri+JRfIDvl i0/GEAV2GQYNQac/0ORtrugShgG2+cuuv30M7gI64CbAI9yTbBl5Ce9eHN7XLX3MhVFT uH+wEjsnrIDbg5z6j+DPuQZlqU5SKYqIFkAGnMnJ7Ug69h6EMWAZQur2nloEZGaVMV5s U0PNQcYBiOgkRMbpYgEgUedw/42n8mcaeYaDHOXcJ/LnYLtX2I8EhXIIaXCUiuc9EyUt 7zobSNH/YSUwcQeX0SxZzP4HbTfntFBR704w2nYE49SpS5ztBsDiMPLObBz28dvuZbiW +yiw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of devicetree-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=devicetree-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id t192si8305847pgc.594.2018.03.05.06.49.54; Mon, 05 Mar 2018 06:49:54 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of devicetree-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of devicetree-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=devicetree-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752313AbeCEOtw (ORCPT + 6 others); Mon, 5 Mar 2018 09:49:52 -0500 Received: from szxga04-in.huawei.com ([45.249.212.190]:6141 "EHLO huawei.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752438AbeCEOts (ORCPT ); Mon, 5 Mar 2018 09:49:48 -0500 Received: from DGGEMS412-HUB.china.huawei.com (unknown [172.30.72.59]) by Forcepoint Email with ESMTP id 23AD113FD1C96; Mon, 5 Mar 2018 22:49:34 +0800 (CST) Received: from localhost.localdomain (10.67.212.75) by DGGEMS412-HUB.china.huawei.com (10.3.19.212) with Microsoft SMTP Server id 14.3.361.1; Mon, 5 Mar 2018 22:49:28 +0800 From: John Garry To: , , , CC: , , , , Xiaofei Tan , John Garry Subject: [PATCH v3 7/8] scsi: hisi_sas: fix return value of hisi_sas_task_prep() Date: Mon, 5 Mar 2018 22:48:49 +0800 Message-ID: <1520261330-204596-8-git-send-email-john.garry@huawei.com> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1520261330-204596-1-git-send-email-john.garry@huawei.com> References: <1520261330-204596-1-git-send-email-john.garry@huawei.com> MIME-Version: 1.0 X-Originating-IP: [10.67.212.75] X-CFilter-Loop: Reflected Sender: devicetree-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org From: Xiaofei Tan It is an implicit regulation that error code that function returned should be negative. But hisi_sas_task_prep() doesn't follow this. This may cause problems in the upper layer code. For example, in sas_expander.c of libsas, smp_execute_task_sg() may return the number of bytes of underrun. It will be conflicted with the scenaio lldd_execute_task() return an positive error code. This patch change the return value from SAS_PHY_DOWN to -ECOMM in hisi_sas_task_prep(). Signed-off-by: Xiaofei Tan Signed-off-by: John Garry --- drivers/scsi/hisi_sas/hisi_sas_main.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) -- 1.9.1 -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/drivers/scsi/hisi_sas/hisi_sas_main.c b/drivers/scsi/hisi_sas/hisi_sas_main.c index 88ad8d4..dff9723 100644 --- a/drivers/scsi/hisi_sas/hisi_sas_main.c +++ b/drivers/scsi/hisi_sas/hisi_sas_main.c @@ -316,7 +316,7 @@ static int hisi_sas_task_prep(struct sas_task *task, struct hisi_sas_dq */ if (device->dev_type != SAS_SATA_DEV) task->task_done(task); - return SAS_PHY_DOWN; + return -ECOMM; } if (DEV_IS_GONE(sas_dev)) { @@ -327,7 +327,7 @@ static int hisi_sas_task_prep(struct sas_task *task, struct hisi_sas_dq dev_info(dev, "task prep: device %016llx not ready\n", SAS_ADDR(device->sas_addr)); - return SAS_PHY_DOWN; + return -ECOMM; } port = to_hisi_sas_port(sas_port); @@ -337,7 +337,7 @@ static int hisi_sas_task_prep(struct sas_task *task, struct hisi_sas_dq "SATA/STP" : "SAS", device->port->id); - return SAS_PHY_DOWN; + return -ECOMM; } if (!sas_protocol_ata(task->task_proto)) {