From patchwork Thu Mar 1 18:06:40 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mark Brown X-Patchwork-Id: 130359 Delivered-To: patch@linaro.org Received: by 10.80.172.228 with SMTP id x91csp3112224edc; Thu, 1 Mar 2018 10:07:10 -0800 (PST) X-Google-Smtp-Source: AG47ELtY7ieh4G7ElTyYhvQ/JV6pceN/YmowSL1sfFpQ6cbzicJyqIpTuRU2RUcv07pORK9+Y59Z X-Received: by 10.28.196.200 with SMTP id u191mr2612055wmf.17.1519927630623; Thu, 01 Mar 2018 10:07:10 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1519927630; cv=none; d=google.com; s=arc-20160816; b=GGNZrUoVhV+98DicpO9QXMSaZGxMHfd3bBmKAWLfbqyF0TDWaBSPvqlxYpZHw+2nnU pSVjN7siCMaT/oY0dlBwwQdZ3rMT3V7KpOOZVVUj4Sm1PGEvIXOj/2OuX74N6Ls9cyth /6ITNBn+EKOiOE3XOqxpJYMzzj7mL8DAAUAVu76qe494vNQ2bNpmWf9db8dIeibi+N+o BYPeWo9tsh++brsbFVyF1a9XVs7EeriofeFQS1OyVxzBZVKyR2xHDFSum0NHkox2+E9C 7c+dcvbUGzOUdly9QVntbdhleYIstgrDiwqHLDNO0EPbD0pxzM2TlvQUxXs8n4Slrplh lgRA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:mime-version :list-subscribe:list-help:list-post:list-archive:list-unsubscribe :list-id:precedence:subject:cc:date:message-id:in-reply-to:to:from :dkim-signature:delivered-to:arc-authentication-results; bh=UrtM14bMIGLBW2mvl4L7EwFsA3QcHnXX2T9hW5lqu+o=; b=WOfsoWTYMaNeYV9wFXR1XrH8/2woYuOPVA0/lezmWBY59iYfYNe6u8fhDDKv5EyFv9 YzFu+k3r9LjGzLqa6YV7Z277GBcJ8+tFDAmw9jZKR82dhKzV17usax/4bqGukvaV2wri gQI64//NZrizpiaZFX7tWlUwl/DpVjJRZ8cEXXy2nFOKS3fUshb67JETR0k4WoIRKbIS cbyLHDmNx7v5Ou4Gk0V7GmRleLs4ZVlikCelo8GgZPvEuntfzJQ2AVL3E6Ej8cvsknQq 9DW1a5OkB4160fKnYlGZa0TXmEAjCvVnz211UqCN9sBgodP+wbYwdmJJA74wkiYGX/no GoKg== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@sirena.org.uk header.s=20170815-heliosphere header.b=Yb+0aRSR; spf=pass (google.com: domain of alsa-devel-bounces@alsa-project.org designates 77.48.224.243 as permitted sender) smtp.mailfrom=alsa-devel-bounces@alsa-project.org Return-Path: Received: from alsa0.perex.cz (alsa0.perex.cz. [77.48.224.243]) by mx.google.com with ESMTP id b11si3309917wrd.87.2018.03.01.10.07.10; Thu, 01 Mar 2018 10:07:10 -0800 (PST) Received-SPF: pass (google.com: domain of alsa-devel-bounces@alsa-project.org designates 77.48.224.243 as permitted sender) client-ip=77.48.224.243; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@sirena.org.uk header.s=20170815-heliosphere header.b=Yb+0aRSR; spf=pass (google.com: domain of alsa-devel-bounces@alsa-project.org designates 77.48.224.243 as permitted sender) smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa0.perex.cz (localhost [127.0.0.1]) by alsa0.perex.cz (Postfix) with ESMTP id F281E267B2F; Thu, 1 Mar 2018 19:06:45 +0100 (CET) X-Original-To: alsa-devel@alsa-project.org Delivered-To: alsa-devel@alsa-project.org Received: by alsa0.perex.cz (Postfix, from userid 1000) id 27C1726798F; Thu, 1 Mar 2018 19:06:43 +0100 (CET) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on mail1.perex.cz X-Spam-Level: X-Spam-Status: No, score=0.2 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS, SPF_PASS, T_RP_MATCHES_RCVD autolearn=disabled version=3.4.0 Received: from heliosphere.sirena.org.uk (heliosphere.sirena.org.uk [172.104.155.198]) by alsa0.perex.cz (Postfix) with ESMTP id 9983C26798F for ; Thu, 1 Mar 2018 19:06:41 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sirena.org.uk; s=20170815-heliosphere; h=Date:Message-Id:In-Reply-To: Subject:Cc:To:From:Sender:Reply-To:MIME-Version:Content-Type: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:References: List-Id:List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner: List-Archive; bh=MSL04QOL1hXEHEgdy9Tjdp70+7l7HFCZcxSGHhVxoRk=; b=Yb+0aRSREosz eJoixT1t4HXpFeftibEXmKqoTFVH6700wFG31AeMqDmqiYs0FBW/N/L7+bxiCJRMjWvK4XwzmsxYD Luxhh1wN3EZ+3Tc2CCLcc8KKJRyZzyOitIbKQbJYaRoO3hOZuE4mU+XLYNkkmmXO6+DXxrPO3J5Zd hfDk0=; Received: from debutante.sirena.org.uk ([2001:470:1f1d:6b5::3] helo=debutante) by heliosphere.sirena.org.uk with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1erSbJ-0005W2-3H; Thu, 01 Mar 2018 18:06:41 +0000 Received: from broonie by debutante with local (Exim 4.90_1) (envelope-from ) id 1erSbI-0005n3-Kk; Thu, 01 Mar 2018 18:06:40 +0000 From: Mark Brown To: Ladislav Michl In-Reply-To: <20180301141953.GD30722@lenoch> Message-Id: Date: Thu, 01 Mar 2018 18:06:40 +0000 Cc: alsa-devel@alsa-project.org, Mark Brown , Alexandre Belloni Subject: [alsa-devel] Applied "ASoC: max9867: Improve error logging" to the asoc tree X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org The patch ASoC: max9867: Improve error logging has been applied to the asoc tree at https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted. You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed. If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced. Please add any relevant lists and maintainers to the CCs when replying to this mail. Thanks, Mark >From 8b9c716aada77e72e2fe82320aba5a95b75ca400 Mon Sep 17 00:00:00 2001 From: Ladislav Michl Date: Thu, 1 Mar 2018 15:19:53 +0100 Subject: [PATCH] ASoC: max9867: Improve error logging Tell user what are clock rate limits and reindent log messages. Signed-off-by: Ladislav Michl Signed-off-by: Mark Brown --- sound/soc/codecs/max9867.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) -- 2.16.2 _______________________________________________ Alsa-devel mailing list Alsa-devel@alsa-project.org http://mailman.alsa-project.org/mailman/listinfo/alsa-devel diff --git a/sound/soc/codecs/max9867.c b/sound/soc/codecs/max9867.c index 2f60924fe919..ac30213deac4 100644 --- a/sound/soc/codecs/max9867.c +++ b/sound/soc/codecs/max9867.c @@ -291,7 +291,9 @@ static int max9867_set_dai_sysclk(struct snd_soc_dai *codec_dai, value |= MAX9867_PSCLK_40_60; max9867->pclk = freq/4; } else { - pr_err("bad clock frequency %d", freq); + dev_err(component->dev, + "Invalid clock frequency %uHz (required 10-60MHz)\n", + freq); return -EINVAL; } value = value << MAX9867_PSCLK_SHIFT; @@ -486,8 +488,7 @@ static int max9867_i2c_probe(struct i2c_client *i2c, max9867->regmap = devm_regmap_init_i2c(i2c, &max9867_regmap); if (IS_ERR(max9867->regmap)) { ret = PTR_ERR(max9867->regmap); - dev_err(&i2c->dev, - "Failed to allocate regmap: %d\n", ret); + dev_err(&i2c->dev, "Failed to allocate regmap: %d\n", ret); return ret; } ret = regmap_read(max9867->regmap,