From patchwork Wed Feb 28 15:14:54 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Liviu Dudau X-Patchwork-Id: 129997 Delivered-To: patch@linaro.org Received: by 10.80.172.228 with SMTP id x91csp1651177edc; Wed, 28 Feb 2018 07:14:59 -0800 (PST) X-Google-Smtp-Source: AH8x226iLiHobLJQ8yCeD8Ijhp5+FWLY4gbmS1/dIwPC3xTxBj7dpoukvc5kDQEdYpirpF0bfj+M X-Received: by 2002:a17:902:968e:: with SMTP id n14-v6mr18525797plp.21.1519830899539; Wed, 28 Feb 2018 07:14:59 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1519830899; cv=none; d=google.com; s=arc-20160816; b=KSxc77u9DHDctMOqof2fZ1vYrf+wRZQdfT+Rh5O2FeVEe+V1OgXx5m+dJCnjkIHVci Rp+7z7wA5GzvyJ16JmVytbVIwAQlgFFyIgKv5+QqFhuO4NhV7k0YjhDDwKfWArvPZPgV 2LrQukNJ8WLJXN7Op8Efpo7Vd9ZH44uSDVaEen4ERgWUbbDJBXbayICXTbj0L1MjHIz+ 22LvygAQ9LKiMVskX7XPEa0sr+07X1MZMTzw6gEmqqJ39yKOmDkMgstKcTKrhe2BKPX2 Nxa2sm1HtIUZCRW4DqoUHnmT7To5m8MPddjOgDnF3/KoFMdI5yL1ZPwukVp8cynNjCqd qVVg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:mime-version:cc :list-subscribe:list-help:list-post:list-archive:list-unsubscribe :list-id:precedence:message-id:date:subject:to:from:delivered-to :arc-authentication-results; bh=eTnB7KQxlfsjUbHLUooLF50X0MM2/lWzDilXqyYAo/I=; b=PH0lUKh2ClrTHFLdtmqE8e/Oh47ezzIFjduMmMcXGKnhFiZS2hqDmtrn+2t6N9mWPy z/+2gkSaINiQmQepcaP7xZSemQo8YXUVMI3WQQrGujEfrTIs5LimYA+iP3VGUsFYNp21 jlYv4/9dSXObdZqpjdIm0h3caHWpnOoq3p22F/nPX5D3r40pqPyEn/zazwUPixqQ1dVF rinekQwz+Eq9OssNwzJXJQYdZHSGIKXbyQx+tPNn2rqv3IGbI7ctqx2mURfZKSOAm4kK Yp3MDZbqkJGFKKQkr6StbEmx6ul5h2XK/9VDKp5PKpSnbcA+CY1hN66cEM8E9rPeVxGC MxUw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 131.252.210.177 as permitted sender) smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Return-Path: Received: from gabe.freedesktop.org (gabe.freedesktop.org. [131.252.210.177]) by mx.google.com with ESMTPS id s24si1131329pgv.779.2018.02.28.07.14.59 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 28 Feb 2018 07:14:59 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 131.252.210.177 as permitted sender) client-ip=131.252.210.177; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 131.252.210.177 as permitted sender) smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 75D3E6E980; Wed, 28 Feb 2018 15:14:58 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from cam-smtp0.cambridge.arm.com (fw-tnat.cambridge.arm.com [217.140.96.140]) by gabe.freedesktop.org (Postfix) with ESMTPS id 628F86E980 for ; Wed, 28 Feb 2018 15:14:57 +0000 (UTC) Received: from e110455-lin.cambridge.arm.com (e110455-lin.cambridge.arm.com [10.2.131.15]) by cam-smtp0.cambridge.arm.com (8.13.8/8.13.8) with ESMTP id w1SFEsqK009393; Wed, 28 Feb 2018 15:14:54 GMT From: Liviu Dudau To: DRI-devel Subject: [PATCH] drm: mali-dp: Turn off CRTC vblank when removing module. Date: Wed, 28 Feb 2018 15:14:54 +0000 Message-Id: <20180228151454.21972-1-Liviu.Dudau@arm.com> X-Mailer: git-send-email 2.16.2 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Ayan Halder , Liviu Dudau , Alexandru-Cosmin Gheorghe , Mali DP Maintainers MIME-Version: 1.0 Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" When unbinding the mali-dp driver the drm_vblank_cleanup() function warns us that the vblanks are still enabled. Fix that by calling drm_crtc_vblank_off() in the malidp_unbind() function. Signed-off-by: Liviu Dudau --- drivers/gpu/drm/arm/malidp_drv.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/gpu/drm/arm/malidp_drv.c b/drivers/gpu/drm/arm/malidp_drv.c index 1d2b1c1c83aa..5c2e8260cfa1 100644 --- a/drivers/gpu/drm/arm/malidp_drv.c +++ b/drivers/gpu/drm/arm/malidp_drv.c @@ -673,8 +673,10 @@ static void malidp_unbind(struct device *dev) drm_fb_cma_fbdev_fini(drm); drm_kms_helper_poll_fini(drm); pm_runtime_get_sync(dev); + drm_crtc_vblank_off(&malidp->crtc); malidp_se_irq_fini(drm); malidp_de_irq_fini(drm); + drm->irq_enabled = false; component_unbind_all(dev, drm); of_node_put(malidp->crtc.port); malidp->crtc.port = NULL;