From patchwork Wed Feb 28 10:14:23 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Masahiro Yamada X-Patchwork-Id: 129931 Delivered-To: patch@linaro.org Received: by 10.80.172.228 with SMTP id x91csp1346677edc; Wed, 28 Feb 2018 02:16:18 -0800 (PST) X-Google-Smtp-Source: AG47ELvOx3397BX3KdhoQNFkCFauMTfS9GXrxb6u0qFBRAoNFOMGsAG/O+7+BKpLnAcIRXpSbFbZ X-Received: by 2002:a17:902:538f:: with SMTP id c15-v6mr9277962pli.90.1519812977899; Wed, 28 Feb 2018 02:16:17 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1519812977; cv=none; d=google.com; s=arc-20160816; b=DMRL9qP4kSe36HLRdR6aNttgiYDJYMUiqM+lI/L+1uhXvybo8K+s77/b8t64t61UcO 6Vgdxk93zMd/rPiYotf9nFCA1vLYwM1MX7zhhaX6f+2cjIGXuyEnvW4qPuIlyA5xUfK7 dZjvDm5Huo3M+uRxGMZM/AHx3mECbwpltwr4X32JhSrhKzEV3jr8wP1Kvd2EJB732SYx fecs/LlqXrX8RL05aDg9qEHFrgdVoTCflOOvGmCYFoxCHeWfvMmyNSWiWdnDECETds66 ujpQAc07c8kOkfOyz8NPf2jWCSXDUuxs8MXfOuqvHdwm/RfPzxWUWt340Xzf7BdbbXKy rTCg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:date:subject:cc:to:from :dkim-signature:dkim-filter:arc-authentication-results; bh=SWOT+eynSLf3+J5k2VQq1wuDS4SqgPOnsp9kv5sDXzk=; b=d/MIg6hqYuf2FvJWpqHUP32Kov9FbmaMzP3fEm2KtMu9FZhcZEbLwPRoEGc2LQebBo ZHDQPVlsw8f2mYwWOwE6s+S8gaoFJaEKFq60yZNSx4kPpaMsJ/kywmslwqTItUgtH/6u gv0SV3vUCGJdIP5kvYGpmkihBLwx7T8TlbdL9xDer7ttWU7XjE0OJOKAPK7xkRRB4Y0a 7R/htz+7zLgAA+8rMuLLZRRaU7j+Ql98vxAx6J3zMw0I/WYgEZZmN7SE9T4lvvSfdUGP xZ5mWcEmvZYmDiHF/rt/+3ioDmUGIxSyGyvNp1uPEefYxU+/1foSPL4rTHZj0dz22PBy deog== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@nifty.com header.s=dec2015msa header.b=Phc1qlbz; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id q12-v6si1070730plr.434.2018.02.28.02.16.17; Wed, 28 Feb 2018 02:16:17 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@nifty.com header.s=dec2015msa header.b=Phc1qlbz; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752447AbeB1KQC (ORCPT + 28 others); Wed, 28 Feb 2018 05:16:02 -0500 Received: from conuserg-07.nifty.com ([210.131.2.74]:57329 "EHLO conuserg-07.nifty.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752138AbeB1KQA (ORCPT ); Wed, 28 Feb 2018 05:16:00 -0500 Received: from pug.e01.socionext.com (p14092-ipngnfx01kyoto.kyoto.ocn.ne.jp [153.142.97.92]) (authenticated) by conuserg-07.nifty.com with ESMTP id w1SAEVbx029479; Wed, 28 Feb 2018 19:14:31 +0900 DKIM-Filter: OpenDKIM Filter v2.10.3 conuserg-07.nifty.com w1SAEVbx029479 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nifty.com; s=dec2015msa; t=1519812871; bh=SWOT+eynSLf3+J5k2VQq1wuDS4SqgPOnsp9kv5sDXzk=; h=From:To:Cc:Subject:Date:From; b=Phc1qlbzO94Gz1fAXWa91xPR9P49JV34RSTfX1XKwXEnM2syto1ye0TEVjpdpzm++ TBKj6WupBZlnJi8CFzx4+KlwPkjh4J/Gum7DyX/v51TW/dv0nZS5MXHt2dX16AdF2A YiATYZqfggm5RB3ceWwyQ3YWukmK6hovBkSMbFJ5UlN5MocpS6iBQSA8uDuGX40Yyz KKXcj9JenX6oHs3SsYif4V7QtomeptvTVvHhWpXMomb7gdFJ/ObAOAr6tX0a2FCW+D /sdXuitts8dIyH9RwCzqpaVaD4ZrJ8+JqHb7kyITUhDILmrP1uB0BjBFQpttBYMbXP W3VwkYwTGSJMA== X-Nifty-SrcIP: [153.142.97.92] From: Masahiro Yamada To: linux-kbuild@vger.kernel.org Cc: Sam Ravnborg , Randy Dunlap , Josh Poimboeuf , Robin Jarry , Masahiro Yamada , linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, Jonathan Corbet , Michal Marek Subject: [PATCH 1/2] kbuild: remove command line interface LDFLAGS_MODULE from makefiles.txt Date: Wed, 28 Feb 2018 19:14:23 +0900 Message-Id: <1519812864-852-1-git-send-email-yamada.masahiro@socionext.com> X-Mailer: git-send-email 2.7.4 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Documentation/kbuild/makefiles.txt lists variables used in Makefile whereas Documentation/kbuild/kbuild.txt describes user assignable parameters given via environments or the command line. LDFLAGS_MODULE is a command line interface, so it should be dropped from makefiles.txt. Some lines below in this file, it is clearly explained that KBUILD_LDFLAGS_MODULE is the right one for the internal use: KBUILD_LDFLAGS_MODULE Options for $(LD) when linking modules $(KBUILD_LDFLAGS_MODULE) is used to add arch-specific options used when linking modules. This is often a linker script. From commandline LDFLAGS_MODULE shall be used (see kbuild.txt). Then, kbuild.txt explains LDFLAGS_MODULE, like follows: LDFLAGS_MODULE -------------------------------------------------- Additional options used for $(LD) when linking modules. Signed-off-by: Masahiro Yamada --- Documentation/kbuild/makefiles.txt | 6 ------ 1 file changed, 6 deletions(-) -- 2.7.4 diff --git a/Documentation/kbuild/makefiles.txt b/Documentation/kbuild/makefiles.txt index 667cd899..048fc39 100644 --- a/Documentation/kbuild/makefiles.txt +++ b/Documentation/kbuild/makefiles.txt @@ -837,12 +837,6 @@ When kbuild executes, the following steps are followed (roughly): Note: ldflags-y can be used to further customise the flags used. See chapter 3.7. - LDFLAGS_MODULE Options for $(LD) when linking modules - - LDFLAGS_MODULE is used to set specific flags for $(LD) when - linking the .ko files used for modules. - Default is "-r", for relocatable output. - LDFLAGS_vmlinux Options for $(LD) when linking vmlinux LDFLAGS_vmlinux is used to specify additional flags to pass to From patchwork Wed Feb 28 10:14:24 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Masahiro Yamada X-Patchwork-Id: 129930 Delivered-To: patch@linaro.org Received: by 10.80.172.228 with SMTP id x91csp1346530edc; Wed, 28 Feb 2018 02:16:08 -0800 (PST) X-Google-Smtp-Source: AH8x224YZavBaDEmw2qt91cBkQIGuAkrRR0vEb2uJyK9VLUImuxx4KbIZ1NaCtUr1NBzBtvsKyib X-Received: by 2002:a17:902:536a:: with SMTP id b97-v6mr17370963pli.421.1519812968049; Wed, 28 Feb 2018 02:16:08 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1519812968; cv=none; d=google.com; s=arc-20160816; b=q3J8M8856pSwcEnV2E0Gkws78s6hUxozE8pvxwiI6v1fqTQu+gv9Km+qbbYzOMwuIv CIDHe0+p1J7eVIsrLOepzo56NEd0+DaVQFpHmbkttrA499+HXPNESjVQMd7TVmJ7SWva PUnHPEmt8Aqzl58SpaBrwwAxpCwSc7fWdqtRbXzhAR5v870v+YWVRTcAmPW35nyo6kZW cyUPW5dFdc0UwJz5DgnPJzu+33wZeGMnT2uHNMCbGYR/HqjXiTD64XwD2O7rAB2O3E1K rnNQyfat4avfiJZ5WpSbaxYr6lDbLPnzyoLPFRjEicZbfbj62bXvB1q1qN9eLEUTBryJ 3C6w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from:dkim-signature:dkim-filter :arc-authentication-results; bh=18Ycl5yXwIPtz6JO6KosMKaR4PoicO3cRfrUQ9YPdDE=; b=CVev59m+AzjnJqCF3msNv5b/YJlYq2tRr+l0vpd244S4DUOJjkVfumOL3X44gCAJTv Ck2dNTIl19dvTOLI3LZxQFqVG+IWj9UAT1nMsbCKYW1NgxTJewRRnyHoRIiE6Gd/okQS XGPivnRwJxRhDYX5Tl26qmOVGiIBlfmVFVbrZ454JiBIBlntg1c6+gXORBQCMoCV4lRZ 64KWyCbsdCiK3DKniLPgASZmBXwIO8/a9irnb5OYESujkJe2XplsKB6U5JRHMh+rHqwR K+tQL21Qi4ZsySfc3xm/eILN98Ob8+cvxqbSuCg98Y5lsUKWs3PD3fw2uybo3Av7JXnr Cp4g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@nifty.com header.s=dec2015msa header.b=T1/XmLL+; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id q12-v6si1070730plr.434.2018.02.28.02.16.07; Wed, 28 Feb 2018 02:16:08 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@nifty.com header.s=dec2015msa header.b=T1/XmLL+; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752485AbeB1KQE (ORCPT + 28 others); Wed, 28 Feb 2018 05:16:04 -0500 Received: from conuserg-07.nifty.com ([210.131.2.74]:57349 "EHLO conuserg-07.nifty.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752150AbeB1KQA (ORCPT ); Wed, 28 Feb 2018 05:16:00 -0500 Received: from pug.e01.socionext.com (p14092-ipngnfx01kyoto.kyoto.ocn.ne.jp [153.142.97.92]) (authenticated) by conuserg-07.nifty.com with ESMTP id w1SAEVc0029479; Wed, 28 Feb 2018 19:14:32 +0900 DKIM-Filter: OpenDKIM Filter v2.10.3 conuserg-07.nifty.com w1SAEVc0029479 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nifty.com; s=dec2015msa; t=1519812872; bh=18Ycl5yXwIPtz6JO6KosMKaR4PoicO3cRfrUQ9YPdDE=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=T1/XmLL+nfpXepmGrHRgRjqZ/UmNlyQJzyYw84ErM+cfpE7scJsUhXTmtUTlTiXan tisNK1vnvqb6nFKZHVB4BUWOp8IYexhf6xTrd0RABRDFwquOAoDluKuBY5UBbPkE7j LUn+ynVjL7E6TdbMYkcnBjvfHcCTDxTI+NtGYLpxB3gPXLMAiQIWtI92bSFCnefHl+ CUwb+Fj70bUL5z+H6wiRXnbgxPpzhqqCpeBp0l4ncbvfqNfZldaOOP4gr7uTgp19ZS DWdNpzI3N2cxm+BvIMG8tXZC82wxUp1nBrDbX0onyd4d2JGYd/sncWDXYdT+XblBlh PfCE2R0VAu8Fg== X-Nifty-SrcIP: [153.142.97.92] From: Masahiro Yamada To: linux-kbuild@vger.kernel.org Cc: Sam Ravnborg , Randy Dunlap , Josh Poimboeuf , Robin Jarry , Masahiro Yamada , linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, Jonathan Corbet , Michal Marek Subject: [PATCH 2/2] kbuild: remove internally used LDFLAGS_vmlinux from kbuild.txt Date: Wed, 28 Feb 2018 19:14:24 +0900 Message-Id: <1519812864-852-2-git-send-email-yamada.masahiro@socionext.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1519812864-852-1-git-send-email-yamada.masahiro@socionext.com> References: <1519812864-852-1-git-send-email-yamada.masahiro@socionext.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Documentation/kbuild/makefiles.txt lists variables used in Makefile whereas Documentation/kbuild/kbuild.txt describes user assignable parameters given via environments or the command line. The top Makefile and arch/*/Makefile accumulate proper linker flags to LDFLAGS_vmlinux. So, users can not override it from the command line. Generally, per-file options are not supposed to be user-assignable. Remove the misleading entry from kbuild.txt. If we need a way to append user-specific flags for linking the kernel, LDFLAGS_KERNEL would be a consistent choice because we already expose LDFLAGS_MODULE counter-part to users. Signed-off-by: Masahiro Yamada --- Documentation/kbuild/kbuild.txt | 4 ---- 1 file changed, 4 deletions(-) -- 2.7.4 diff --git a/Documentation/kbuild/kbuild.txt b/Documentation/kbuild/kbuild.txt index ac2363e..6c9c69e 100644 --- a/Documentation/kbuild/kbuild.txt +++ b/Documentation/kbuild/kbuild.txt @@ -50,10 +50,6 @@ LDFLAGS_MODULE -------------------------------------------------- Additional options used for $(LD) when linking modules. -LDFLAGS_vmlinux --------------------------------------------------- -Additional options passed to final link of vmlinux. - KBUILD_VERBOSE -------------------------------------------------- Set the kbuild verbosity. Can be assigned same values as "V=...".