From patchwork Fri Jan 15 19:30:12 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Jason A. Donenfeld" X-Patchwork-Id: 363741 Delivered-To: patch@linaro.org Received: by 2002:a02:ccad:0:0:0:0:0 with SMTP id t13csp144766jap; Fri, 15 Jan 2021 11:31:56 -0800 (PST) X-Google-Smtp-Source: ABdhPJyEmUnJz0GkQo+yYwLsplQAiz3SMM/aiZkKZOzlk0DCgT1ihik6PMDIp/pZpHqiitGF2J87 X-Received: by 2002:a05:6402:524a:: with SMTP id t10mr11011172edd.270.1610739116788; Fri, 15 Jan 2021 11:31:56 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1610739116; cv=none; d=google.com; s=arc-20160816; b=b+MU8hIUSuN/de3OzocQZHT7bd3KWoCWVNAWWyMht0gDQpYBBZ3BQMVOS8GmPX207J M0RMwILZPhoClFnPiSuVVQHTYIVUaRdZD0d5kha+IirEfTwnvApEjtVlm6XwtcUZjbzn s1BjUCWVcPmywFJUfE+VfDTx5qvMCDvBNDVhrDrrGh1cs4/3ldrAZDKald5qggicToKc qNNblLpPh0K4kFdTVianxEHkrnH47UtLPAcZGl0pmBSQmHtXGhY8accmJgLP1Ll/4Fbt 4zS+FR4kON+kv9WnARW1ukgB7mtYQ5aKTINaVozSTRoeZGDJ9ncoL7imqDOr3T8/HpsN ux/w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=7BaNXWOkaA65p8n11dAlACCraC+MzlfwCOIG3MhWrHk=; b=DNvEYhgvaBk+DzI0uhaz4iacYJSxjeh+54EKynSIDtOTbsT+KclCosjmksCCCIdl1F IQszkZh/rP+EymHLoON3ZFzrTSic2BzyjOLCnEfJ3CSwBMUWmh939SN0OldmiTk3ci5S 20Q/vdDQkmUIpfqQY/Zvu8EnZzmkPCvCjU4dRFPQbSoe7KeSZxgbjr3NGR/3G3sjlvAf 9d4POkhq1fC6FHqj20Gj4Tzqa/CxnlExdM22N3YreDICjbjKa3FHSEzGA7rlrc6zOVpd Rwm8NYzOAHNmdXR/5kfJK5ZjX+MyAvncQXMLDIXqGdMHoPrmLM40is/JFNH3+CIgpg61 RpeQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@zx2c4.com header.s=20210105 header.b=Mg1YiCm4; spf=pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=zx2c4.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id d3si4858373edj.258.2021.01.15.11.31.56; Fri, 15 Jan 2021 11:31:56 -0800 (PST) Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@zx2c4.com header.s=20210105 header.b=Mg1YiCm4; spf=pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=zx2c4.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1733119AbhAOTbK (ORCPT + 2 others); Fri, 15 Jan 2021 14:31:10 -0500 Received: from mail.zx2c4.com ([167.71.246.149]:36304 "EHLO mail.zx2c4.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727639AbhAOTbK (ORCPT ); Fri, 15 Jan 2021 14:31:10 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=zx2c4.com; s=20210105; t=1610739026; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=7BaNXWOkaA65p8n11dAlACCraC+MzlfwCOIG3MhWrHk=; b=Mg1YiCm4JcgjRFChNaaTX1xOutjzCMiMfe6UdC1ymN0INqS2gdRXk3i562QDly4ePWcGq6 zr5iDy/4l/lPVOP4IvB2mpCW5T0dC+C8MfRlO06SxKxshGM+oG6AnPOA7kIcQkQXR3qHbt uGD8OMPsRFOwHWhW71Ps14jr54Dn2JY= Received: by mail.zx2c4.com (ZX2C4 Mail Server) with ESMTPSA id 9d76af42 (TLSv1.3:AEAD-AES256-GCM-SHA384:256:NO); Fri, 15 Jan 2021 19:30:26 +0000 (UTC) From: "Jason A. Donenfeld" To: linux-crypto@vger.kernel.org, ardb@kernel.org, herbert@gondor.apana.org.au Cc: "Jason A. Donenfeld" , John Donnelly Subject: [PATCH v2] crypto: lib/chacha20poly1305 - define empty module exit function Date: Fri, 15 Jan 2021 20:30:12 +0100 Message-Id: <20210115193012.3059929-1-Jason@zx2c4.com> In-Reply-To: <20210115171743.1559595-1-Jason@zx2c4.com> References: <20210115171743.1559595-1-Jason@zx2c4.com> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org With no mod_exit function, users are unable to unload the module after use. I'm not aware of any reason why module unloading should be prohibited for this one, so this commit simply adds an empty exit function. Reported-and-tested-by: John Donnelly Acked-by: Ard Biesheuvel Signed-off-by: Jason A. Donenfeld --- v1->v2: - Fix typo in commit message. lib/crypto/chacha20poly1305.c | 5 +++++ 1 file changed, 5 insertions(+) -- 2.30.0 diff --git a/lib/crypto/chacha20poly1305.c b/lib/crypto/chacha20poly1305.c index 5850f3b87359..c2fcdb98cc02 100644 --- a/lib/crypto/chacha20poly1305.c +++ b/lib/crypto/chacha20poly1305.c @@ -362,7 +362,12 @@ static int __init mod_init(void) return 0; } +static void __exit mod_exit(void) +{ +} + module_init(mod_init); +module_exit(mod_exit); MODULE_LICENSE("GPL v2"); MODULE_DESCRIPTION("ChaCha20Poly1305 AEAD construction"); MODULE_AUTHOR("Jason A. Donenfeld ");