From patchwork Wed Jan 13 16:41:17 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 362165 Delivered-To: patch@linaro.org Received: by 2002:a02:ccad:0:0:0:0:0 with SMTP id t13csp692683jap; Wed, 13 Jan 2021 08:42:48 -0800 (PST) X-Google-Smtp-Source: ABdhPJyylySp9kinFd0eF+1S7pOfOaJXxWOXHUtty1Zx4Kn0pQeilvPv3yWG8JRO4q/TORyP6/i5 X-Received: by 2002:a17:906:90d6:: with SMTP id v22mr2192083ejw.88.1610556168648; Wed, 13 Jan 2021 08:42:48 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1610556168; cv=none; d=google.com; s=arc-20160816; b=tct95suIuF11bSj5ZR2awp5rd62DXyAOlJ8zWjbhR5ibzXVwXLSuiQ9wyjUitQlpQr cO0JcZL7tRhC6Dl2XyI+1tOQVVEUmc5MQZEzmj0yPVfaUaKFvZ228Z+/uYION2rebca/ eTYuk81HeXJ+aUU+HNPlO3FpVKM6uwviZBTu6BiyuhuJ2MogPllbazrudXb4PeF59XvT dXEMIKWQCBpprD+HxLFJQwhCKRR0hAWMiudnTZk/btD3hCdjKgMfgPSIUUMVFPPI3M62 VB+jAyc+NmxCl9img9YoX6n96Bep3tGhhhHsqn2l6QMTRW9wM2SpQioI/6UU2e3d3EyC n5bw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=eNUEY9r+/kJx3A9XN2sXZ9yQ1dazqcofsQCJKx0aAEk=; b=jG00c9SSOEUI4fPUIcyyVOoP51tJIbvILrWH8KgEipUUA2Cmc4/S5hQtX+vwVf1ADf p7kPjtVw9f7yzQIh2NAJ0INitbBhGyPoKu+uZpUU912P806UAuaRLhm92UXjkipO6PZo XwX+Hq+oLk2NnRYemQKjPhMpe1/Sitj0D3J2JmZCeZL6HnHi/UL+AuZ+bv+jhV5h/fqv nJuP1YP2acEljbm5fHzpwW+tT5RfAyIGrxif8CfsAe8r+fPNCft50fBFRdo8h0N04hDC FvFbEbHjPvgHxsPiuaJJtxb9gwiq+2AW50uWfxGMLWL41o8fSoxqWnyiOV7A82Y+HEhF nkRQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=lKnNESII; spf=pass (google.com: domain of netdev-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=netdev-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id c6si1093652ejb.666.2021.01.13.08.42.48; Wed, 13 Jan 2021 08:42:48 -0800 (PST) Received-SPF: pass (google.com: domain of netdev-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=lKnNESII; spf=pass (google.com: domain of netdev-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=netdev-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727825AbhAMQmM (ORCPT + 7 others); Wed, 13 Jan 2021 11:42:12 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37858 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727753AbhAMQmK (ORCPT ); Wed, 13 Jan 2021 11:42:10 -0500 Received: from mail-wr1-x432.google.com (mail-wr1-x432.google.com [IPv6:2a00:1450:4864:20::432]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5B9A7C061795 for ; Wed, 13 Jan 2021 08:41:30 -0800 (PST) Received: by mail-wr1-x432.google.com with SMTP id d13so2792290wrc.13 for ; Wed, 13 Jan 2021 08:41:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=eNUEY9r+/kJx3A9XN2sXZ9yQ1dazqcofsQCJKx0aAEk=; b=lKnNESIIN0ln8gRM/0Nd7xLqt0+rBUXIRfPuzMUHQwXW/FmZO+cyC3/G7slwyDbB/p I3u7zQHEW3OP93YTNVN6q8N3MnEg163SRUz4gyiccytEpv+G+n6sxr8LNPlfdk901TBU DCecTXblcXx0Z0UePkMlkNLGGAo92jEDqvK4rBztzRGDIT46PmqpgEBd8VIRidIUJh0R 5PN46ZA24585MQ5Q09uMDQQV8/BQ6VPMtexKnVebSdIYwaXvcvyFYqtSMkkZJ2EVziNC sgymPz4bssn66yyEMmFcbMWI90UuCBr7Qza8rweqmmL9YdPQSA6BUoHIpAg6zQlE822g GFSg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=eNUEY9r+/kJx3A9XN2sXZ9yQ1dazqcofsQCJKx0aAEk=; b=pWcjXKbdasNbrJ7IC1HlHvH7HX+DINxZvGUll15pAb5qvwbsAVN9O9jAVSLcSmO+QK 4+8RWjaVpIs9GDHQcAWqUHAkWL93zT94LtzYt+iVXpp8CTUdLxplSdhhq+qnkE9VUnzY 9RLk+3w9rxRvq1cC32ELENK/4QF68Iw6O0cp4Vx7jxLX5nsqdcYmqv4qqtnlIEkaFdGy plZCxXVXufMz2Tn78HcrWlfp681nQm0rcfWvpMe2bba/abWWMPXydoHoD3r2zrI28H7M QWr5BA53Kdx4NDapIaTswKmmq8mgojt2ti9D5fXzzWIKjTW5eERxOfSeGegBwt/BI4Dm pSGQ== X-Gm-Message-State: AOAM532b7MF76u4VfCtP2C31mJ6JGVxRY9+66OG0mdUULAXuM4IoIOvt 3WiXtXSrLWj9pVqEkEsAcI4Dxw== X-Received: by 2002:a5d:4307:: with SMTP id h7mr3529307wrq.353.1610556089109; Wed, 13 Jan 2021 08:41:29 -0800 (PST) Received: from dell.default ([91.110.221.229]) by smtp.gmail.com with ESMTPSA id t16sm3836510wmi.3.2021.01.13.08.41.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 13 Jan 2021 08:41:28 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, Nicolas Pitre , "David S. Miller" , Jakub Kicinski , Erik Stahlman , Peter Cammaert , Daris A Nevil , Russell King , netdev@vger.kernel.org Subject: [PATCH 1/7] net: ethernet: smsc: smc91x: Fix function name in kernel-doc header Date: Wed, 13 Jan 2021 16:41:17 +0000 Message-Id: <20210113164123.1334116-2-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210113164123.1334116-1-lee.jones@linaro.org> References: <20210113164123.1334116-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/net/ethernet/smsc/smc91x.c:2200: warning: Function parameter or member 'dev' not described in 'try_toggle_control_gpio' drivers/net/ethernet/smsc/smc91x.c:2200: warning: Function parameter or member 'desc' not described in 'try_toggle_control_gpio' drivers/net/ethernet/smsc/smc91x.c:2200: warning: Function parameter or member 'name' not described in 'try_toggle_control_gpio' drivers/net/ethernet/smsc/smc91x.c:2200: warning: Function parameter or member 'index' not described in 'try_toggle_control_gpio' drivers/net/ethernet/smsc/smc91x.c:2200: warning: Function parameter or member 'value' not described in 'try_toggle_control_gpio' drivers/net/ethernet/smsc/smc91x.c:2200: warning: Function parameter or member 'nsdelay' not described in 'try_toggle_control_gpio' Cc: Nicolas Pitre Cc: "David S. Miller" Cc: Jakub Kicinski Cc: Erik Stahlman Cc: Peter Cammaert Cc: Daris A Nevil Cc: Russell King Cc: netdev@vger.kernel.org Signed-off-by: Lee Jones --- drivers/net/ethernet/smsc/smc91x.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.25.1 diff --git a/drivers/net/ethernet/smsc/smc91x.c b/drivers/net/ethernet/smsc/smc91x.c index 56c36798cb111..abd083efbfd74 100644 --- a/drivers/net/ethernet/smsc/smc91x.c +++ b/drivers/net/ethernet/smsc/smc91x.c @@ -2192,7 +2192,7 @@ MODULE_DEVICE_TABLE(of, smc91x_match); #if defined(CONFIG_GPIOLIB) /** - * of_try_set_control_gpio - configure a gpio if it exists + * try_toggle_control_gpio - configure a gpio if it exists * @dev: net device * @desc: where to store the GPIO descriptor, if it exists * @name: name of the GPIO in DT From patchwork Wed Jan 13 16:41:19 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 362167 Delivered-To: patch@linaro.org Received: by 2002:a02:ccad:0:0:0:0:0 with SMTP id t13csp693632jap; Wed, 13 Jan 2021 08:44:11 -0800 (PST) X-Google-Smtp-Source: ABdhPJy5bpw10AEB1OwlhWFxzRuDVje3XEHCaCcFGf9+hzdw54NganOrG1/e9Doi5WgeJxaW0+3G X-Received: by 2002:a05:6402:310f:: with SMTP id dc15mr2456429edb.225.1610556251651; Wed, 13 Jan 2021 08:44:11 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1610556251; cv=none; d=google.com; s=arc-20160816; b=nMY+9xVuXpDExr42gqQtZqFIRCRkJ+weIHQMrxRnXVWg2U2a8hdUdZWYJRzQjqKB10 5FrmAQMsaUJuZC5HK5LL1FAQ6tUn7r4aEepGU+fIARqhWYScevOmv2H06FZmnxRpU50l 5kjpYsxaVrmexY/FuXX5dTy9Sc2Xj33BUHGJh1528lcDOlhjAVsF+98WscjjEn1ejwm7 p8R+93013w25jO7zJAbVcpSu/dgva4sRbresoTVypKp3O2f/XXghrd7ITVlIrgSsbA/P lOnJM3i1Ae55HBpSYPekD4yvslYqG81qR/6bCwhRwnJ/Kv0pzlCcmBpRiwBj1Nt8GQDQ ab7Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=G08JJuzSVjauD2w7RKeXQ1nSbD1Rkjm71UkTsB/zD7Y=; b=aJFMqgIucsL4Sm4Q8It8MrFXPjtXSj8KDK32cHIout8GfjMorTHCh3Te1u6wTPVTOP fKW3cOdzffEIF1ZCJdQXaqIvvAamRAkvu6eg2bgZSPVhXUqgKjEGfOiUgW+GVY4aTa2R JCqW9uqN8KOtGspI4my8Q9313nrRXXPEvYykBQ+MJEf9C0ahx+13I7Ius6qzfIjOU630 5yetZLylSYekakn1wvqJJ7NxNN0f3JVIS/EeG2K6z9j8frz/e9qNZkLbaBqYygdFfS8u N/csHtplgf2g+eV87gQ3rRTmYHwin5IwYRzbQzabr7Uke/C94mvR5kHOro8L7EoIu+6n j32A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b="h/F2lxdr"; spf=pass (google.com: domain of netdev-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=netdev-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id f1si435506ejh.593.2021.01.13.08.44.11; Wed, 13 Jan 2021 08:44:11 -0800 (PST) Received-SPF: pass (google.com: domain of netdev-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b="h/F2lxdr"; spf=pass (google.com: domain of netdev-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=netdev-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727893AbhAMQmv (ORCPT + 7 others); Wed, 13 Jan 2021 11:42:51 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38006 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727827AbhAMQmu (ORCPT ); Wed, 13 Jan 2021 11:42:50 -0500 Received: from mail-wr1-x431.google.com (mail-wr1-x431.google.com [IPv6:2a00:1450:4864:20::431]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 68302C0617A5 for ; Wed, 13 Jan 2021 08:41:33 -0800 (PST) Received: by mail-wr1-x431.google.com with SMTP id r3so2833884wrt.2 for ; Wed, 13 Jan 2021 08:41:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=G08JJuzSVjauD2w7RKeXQ1nSbD1Rkjm71UkTsB/zD7Y=; b=h/F2lxdrgroIq/ZY7feq74qrpGnTA61pXLA+1K6ZxQ4xipHdZsKQabxegXx/fXVZG4 go40xzp75VsUfMVjfaRWDi6ePQT9ag/KyKPlFeepMaqsszt6RS2A46MIpjyjjmer7Tof e5ah/aAqTMoVBQH4kUIgCfiIwfZfBpaHIoUJHGbtX4aI3TXdOHnnPSFXko8YvLfwyzCA I7Y66gaM0frkk6LaXymZ1PVFXETc9mv2q4r33HTYdefp1Avrn+e76kVEPeIrKT04ya5H JJHneE3/j586mxObhvRBA1AFdzsAzX2zm5NDznfNB132gdFEShcVMO3tuhKsdiYdjcsf zRvA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=G08JJuzSVjauD2w7RKeXQ1nSbD1Rkjm71UkTsB/zD7Y=; b=ij5kWDyablPf7B6mudhJBdtsrVUxVse4GiYuD+cVnV3UY4FkwzTm0zNXuOH5j2r5M0 T+SOaLSfQBYMMoBM/+S+5tNIpk1R4Xv9mCEMReYRf0aiNP1phGUb34L9U950c2X4FFFx zciwM+Jd6MN6fILZluigiBWO4IztU38cTwm4qlDMJRmTjiDvRMHAi9myyKN9C9rXmN1V 70D/ARCubOJIkMQ3ydn5bCPET+KQzmkxHFzmxP4jWqIt87O0KATMX7y+xYqDfIgwoQ1I tI5nmMuQsQehPR8J8aCX9YxprELLnGjEwslOvJzkJzQXUdsrD7sQ2cY+pI6oINaytkJ/ FwIg== X-Gm-Message-State: AOAM530c0fr7PRg4ls+xgsbTOhStcS5Io2o7iWnxsqPYu1RNg2tFIsk9 k7Q1hanCDLnFEBHgwi0d1Ty4vg== X-Received: by 2002:adf:e60f:: with SMTP id p15mr3502133wrm.60.1610556092215; Wed, 13 Jan 2021 08:41:32 -0800 (PST) Received: from dell.default ([91.110.221.229]) by smtp.gmail.com with ESMTPSA id t16sm3836510wmi.3.2021.01.13.08.41.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 13 Jan 2021 08:41:31 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, "David S. Miller" , Jakub Kicinski , Ivan Khoronzhuk , "Gustavo A. R. Silva" , netdev@vger.kernel.org, Andrew Lunn Subject: [PATCH 3/7] net: ethernet: ti: am65-cpsw-qos: Demote non-conformant function header Date: Wed, 13 Jan 2021 16:41:19 +0000 Message-Id: <20210113164123.1334116-4-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210113164123.1334116-1-lee.jones@linaro.org> References: <20210113164123.1334116-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/net/ethernet/ti/am65-cpsw-qos.c:364: warning: Function parameter or member 'ndev' not described in 'am65_cpsw_timer_set' drivers/net/ethernet/ti/am65-cpsw-qos.c:364: warning: Function parameter or member 'est_new' not described in 'am65_cpsw_timer_set' Cc: "David S. Miller" Cc: Jakub Kicinski Cc: Ivan Khoronzhuk Cc: "Gustavo A. R. Silva" Cc: netdev@vger.kernel.org Reviewed-by: Andrew Lunn Signed-off-by: Lee Jones --- drivers/net/ethernet/ti/am65-cpsw-qos.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.25.1 diff --git a/drivers/net/ethernet/ti/am65-cpsw-qos.c b/drivers/net/ethernet/ti/am65-cpsw-qos.c index 3bdd4dbcd2ff1..ebcc6386cc34a 100644 --- a/drivers/net/ethernet/ti/am65-cpsw-qos.c +++ b/drivers/net/ethernet/ti/am65-cpsw-qos.c @@ -356,7 +356,7 @@ static void am65_cpsw_est_set_sched_list(struct net_device *ndev, writel(~all_fetch_allow & AM65_CPSW_FETCH_ALLOW_MSK, ram_addr); } -/** +/* * Enable ESTf periodic output, set cycle start time and interval. */ static int am65_cpsw_timer_set(struct net_device *ndev, From patchwork Wed Jan 13 16:41:20 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 362168 Delivered-To: patch@linaro.org Received: by 2002:a02:ccad:0:0:0:0:0 with SMTP id t13csp693637jap; Wed, 13 Jan 2021 08:44:12 -0800 (PST) X-Google-Smtp-Source: ABdhPJy1AVdPLc4cDr+pAXMGIQ8mlP1cFdTcrlbEKpkhKy0I5tB4DNTOjYzTlpkVBye2IJpfXybE X-Received: by 2002:a17:906:d0c2:: with SMTP id bq2mr2180700ejb.1.1610556252511; Wed, 13 Jan 2021 08:44:12 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1610556252; cv=none; d=google.com; s=arc-20160816; b=wcYxaXqfdUsGB5l+PvTy65kzJAOTfU1GEguUr4Ci+D8g+9gEj6jMpsl+aJj4ztVtYh eNdUBK5iVw2bU4yDEF4W+Qp5Jj4Q3Y67ovlJKvryzhvgy1chnbM8Nx4Ikeky9i86Kepd IiJu07wP26X7tMN1aKe1N+4xLujCn6ebHLwvBL7EA9Ag4pKQP4uRFadB/Uu1gBBWk8Xe 7CSxiej02t72NdOKxHdLoQRqONkKMU5EtYtEawXtDsZNIXapiBDsT8ZJXAE9TIdJ7JJ4 dghHIn0Pd9J5KsBWsQLL16wYCoxCHmrYBsEUod29g87CESEcFBujydYWS0VpBXBUUteU KqOg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=Z1CB49mzZZUw/61JRz0eEUr9QqVKx7SA3GZtjiem/4A=; b=gO2uv61DHT1mbsF+mrxD1bZstX2/pcvjUbQ9xHVEo9ACm2FqVy867gHoRfuC9aNRSB BQHJfFGMxRa3zILmp5iEt0t1KNW004A9dh23cpDeOo7E94YDyBAcQiEeWVcbx6HquSsI iQfq/Zw/deOuTcDk0+/k2g+jsDqrCI2jIex13LYMIFgVYOY6ADejFvJbMbJKjr0NrW9A QvQdgXux+PfFxM0QLdrCALCe68YtAjuHgd0QQYwgIgx1dIm9qjZew9sIgnfXj7NVPHkV wZ74LGp/uoq+R+/ay/X5rOO50rmlJuEt2p/Ta6y48Tn0me8348X4nrupjYjzYZTcDF7f j06w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=nsTL5Y+o; spf=pass (google.com: domain of netdev-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=netdev-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id f1si435506ejh.593.2021.01.13.08.44.11; Wed, 13 Jan 2021 08:44:12 -0800 (PST) Received-SPF: pass (google.com: domain of netdev-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=nsTL5Y+o; spf=pass (google.com: domain of netdev-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=netdev-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727980AbhAMQnD (ORCPT + 7 others); Wed, 13 Jan 2021 11:43:03 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38014 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727883AbhAMQmv (ORCPT ); Wed, 13 Jan 2021 11:42:51 -0500 Received: from mail-wm1-x32d.google.com (mail-wm1-x32d.google.com [IPv6:2a00:1450:4864:20::32d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B8B41C0617A9 for ; Wed, 13 Jan 2021 08:41:34 -0800 (PST) Received: by mail-wm1-x32d.google.com with SMTP id k10so2170269wmi.3 for ; Wed, 13 Jan 2021 08:41:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=Z1CB49mzZZUw/61JRz0eEUr9QqVKx7SA3GZtjiem/4A=; b=nsTL5Y+oaK1QH7nxgpklm0OSpU6gbsvQj/NJeARHrT0Yr7gMgwtpKOO5KN0eg52RSo WhXHXUwoDssQdiMnyDK662RZt0upBfAn5BFnVriHbCZxIO9RycB1mfXzwFYCHNodgTfw Dx7JH2ZWUIfz7SyWa97EEUCtWBz3JbZenS1TElJkfHpDUlhxoJtpYx9+YOauwogNVRxC iTndn1zdVcdLYh4CTJRiJwCoxukKpSj3okUEVrsQ2ds2J68jKmajkh3HXHv+Zj8KIISR JxrOuQhIEzmcDMOOuy7BhoqrcNEu/6Y8BsSugbGEdWHbsqMkKDd6Xtr76GGikS/Rqz4Q 1dpA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=Z1CB49mzZZUw/61JRz0eEUr9QqVKx7SA3GZtjiem/4A=; b=RYgAbhICMNss7Jbnp3HvLdDuNwDBafTBoUB99YYKhuVolZ1xnYF/jh1nbmExEhPn8C qXJn47p2VCcx+wxxg/G15vVJ3dGQtlbq/TOeuuzjhQzZjOZ8szMN0jhMq0B/a2Xa8gKK sqvX3E6TJu5Vd7RLKhTiHVScSrbW/i+41YX6eif7wGbXlPkFOdqBrDJ9L6DdXJUC3jSU PvlLxUzqhVnaZXP6cAUsD/CyNKxmMqZvlIE0nPscb4EHDudxvWj6ndHGZKdXs//LxFBs UArH3JypCf+JQk3NaEKdtFrsXKg1rDFHvciRL227ww93ZLMsnoFeAmfJwc65kxrXVZMV 1hyA== X-Gm-Message-State: AOAM5312Ci90i022u4Cop7kQV1ZQ+5tKYth98Wj/Nci+1jNJyMQ4Bbqf ppPDZfOaXv2vGOazZbptTy1eEw== X-Received: by 2002:a1c:7c03:: with SMTP id x3mr108276wmc.17.1610556093439; Wed, 13 Jan 2021 08:41:33 -0800 (PST) Received: from dell.default ([91.110.221.229]) by smtp.gmail.com with ESMTPSA id t16sm3836510wmi.3.2021.01.13.08.41.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 13 Jan 2021 08:41:32 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, "David S. Miller" , Jakub Kicinski , Grygorii Strashko , Kurt Kanzenbach , netdev@vger.kernel.org, Andrew Lunn Subject: [PATCH 4/7] net: ethernet: ti: am65-cpts: Document am65_cpts_rx_enable()'s 'en' parameter Date: Wed, 13 Jan 2021 16:41:20 +0000 Message-Id: <20210113164123.1334116-5-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210113164123.1334116-1-lee.jones@linaro.org> References: <20210113164123.1334116-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/net/ethernet/ti/am65-cpts.c:736: warning: Function parameter or member 'en' not described in 'am65_cpts_rx_enable' drivers/net/ethernet/ti/am65-cpts.c:736: warning: Excess function parameter 'skb' description in 'am65_cpts_rx_enable' Cc: "David S. Miller" Cc: Jakub Kicinski Cc: Grygorii Strashko Cc: Kurt Kanzenbach Cc: netdev@vger.kernel.org Reviewed-by: Andrew Lunn Signed-off-by: Lee Jones --- drivers/net/ethernet/ti/am65-cpts.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.25.1 diff --git a/drivers/net/ethernet/ti/am65-cpts.c b/drivers/net/ethernet/ti/am65-cpts.c index 5dc60ecabe561..9caaae79fc957 100644 --- a/drivers/net/ethernet/ti/am65-cpts.c +++ b/drivers/net/ethernet/ti/am65-cpts.c @@ -727,7 +727,7 @@ static long am65_cpts_ts_work(struct ptp_clock_info *ptp) /** * am65_cpts_rx_enable - enable rx timestamping * @cpts: cpts handle - * @skb: packet + * @en: enable * * This functions enables rx packets timestamping. The CPTS can timestamp all * rx packets. From patchwork Wed Jan 13 16:41:21 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 362171 Delivered-To: patch@linaro.org Received: by 2002:a02:ccad:0:0:0:0:0 with SMTP id t13csp693661jap; Wed, 13 Jan 2021 08:44:14 -0800 (PST) X-Google-Smtp-Source: ABdhPJzB1xyvZi8knwNnL4iXkVlB+SoJiKrOqd8vyfqbhwnV74U6v8eLhO267aSrAv6XkwJehTkd X-Received: by 2002:a05:6402:379:: with SMTP id s25mr2607215edw.367.1610556254503; Wed, 13 Jan 2021 08:44:14 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1610556254; cv=none; d=google.com; s=arc-20160816; b=V5xwi6bPQDw/Rk5pt6gNT8QdNI5Td6OBgiPLNAjLo5trgY8/VcG/2D4RN655H7Z2gf InfBB3WKFO7Cr+mPHshpR6qESrhkBWUP7kkHrBHsNaJy7kuMTxLAcA7QttfsszmT4TTf RnAwJAOydoA3fnLIzXHfiB9Q88BwnLaseiDS1GsugRWL//GnhRv81S2XbZ6I1BC+mGhA yJNG4pa0nSkGw3EYkxyEAZOdbwLdzsiqAsHTR11Hnmeb09cPjXqcKgP3ey4U3asTiGR4 NR2MgFjN0GY3PU6LIbbMNaHOkHALe8rUnOBUtLgwY88XzDL8ffrVBuBTE1PE8JKUPiHN 3q1A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=F0dvH29ffi2i4F8zScMsXrCXjoLq5dAgU1ImPQgyxOk=; b=iK7QcKwQhFkKBDaaU5h54+VKhvaaV0F7CsjTSaqEiHuNcUsb/Cr7UW6KfoZ2o+xrmY 9Iz6LpLEULJcevl307BkW56QQPi4SdYT282htqbpqLPIt3yQZl6mKsvpxs+Rhqh4EKNc rJib5Ufv5ngtQcCMlU/+xsXrypRtoJg822+QBBFMa0MJL/9vqnh3IeFhp5Lh0YIZ+n5t r3doFdOlUJREWfZ/3RIpQRb+apYc/+yBh1C8++tGfh3ZU8zIzUfYOfpvhKgb+KD+MFMO tO+RMdo5c8jnC9zd0m/zTWSmlk5b5KhF7JKn+Oz1mL2irbixaUyNz2PFhU1x8yIzQN0N qL8A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=wibdpcpc; spf=pass (google.com: domain of netdev-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=netdev-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id f1si435506ejh.593.2021.01.13.08.44.14; Wed, 13 Jan 2021 08:44:14 -0800 (PST) Received-SPF: pass (google.com: domain of netdev-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=wibdpcpc; spf=pass (google.com: domain of netdev-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=netdev-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727963AbhAMQnC (ORCPT + 7 others); Wed, 13 Jan 2021 11:43:02 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38016 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727884AbhAMQmv (ORCPT ); Wed, 13 Jan 2021 11:42:51 -0500 Received: from mail-wr1-x435.google.com (mail-wr1-x435.google.com [IPv6:2a00:1450:4864:20::435]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 02B9BC0617AA for ; Wed, 13 Jan 2021 08:41:36 -0800 (PST) Received: by mail-wr1-x435.google.com with SMTP id i9so2827944wrc.4 for ; Wed, 13 Jan 2021 08:41:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=F0dvH29ffi2i4F8zScMsXrCXjoLq5dAgU1ImPQgyxOk=; b=wibdpcpcVpqQHxtGL4Ai5SGD5EVrLUQO5Ly9cf7Aq2JcCEh4zDIybpj/dPs65Do5kI gvz7nkcYf4edgF5Ik8Isyw5YYiQTjT6troPEqGhyeEXTuaq01Pi+6R9+rpjyl/cGsfCc Ceh4jbARCc/OvZeoE6YplRkf9iZtmCaAQwb0aCZyNQWVNohTpORK3ZIz50vUYRGWgEob csr1PcBK3/glDfNEXOE9EjJOlbAnXW39VC4Ur2WuD4kH+cWSa3/AAt67BTDxRZ+Z1Pps rC82FPnTMc3T8zlTSaNytt2bEdMrf5s3H/F5QJfW21qJP3Fdp6D0rjvTRT54JKqIORoe HyZg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=F0dvH29ffi2i4F8zScMsXrCXjoLq5dAgU1ImPQgyxOk=; b=gwNceOiGJBsv4Pl4e9jgveTwcDRS17I0rr0QRDoQSvFt8MsPmSY6k05FWFCAWJ3eo7 2o5CHnj7qYHPMVYFNXvVRaohsCmpvTMP5FvZF/kLQfZXp9obGrxwVq6ecg8rhy6QgE4r 3KTkeILqHG/74wZzwRVKaYj+w1yx9q5Q6fS1vas9e/42YIAh2k9APzKO9o31EN52inJ0 wTqmuUr1tBtWcLSE62w+lPkjaTdJTyirHv6ef+FCi9P2ZaD+iI2y9qRaylOh/D7NnO73 hpVl3HZIS2mOVb5ws4JqbudTTIPxBDxxNjGD0Rh+1crJFS5wd+u2fJ+GkrhrzpH8Gk6A XlXQ== X-Gm-Message-State: AOAM530R1gojyEZWEGLHsMmSqv38pKdhtRN/s+XxegSq7s7UOLFOwc8/ m2kWQtyHW1KRZsPpLHVWLJSetA== X-Received: by 2002:adf:82c8:: with SMTP id 66mr3473869wrc.420.1610556094790; Wed, 13 Jan 2021 08:41:34 -0800 (PST) Received: from dell.default ([91.110.221.229]) by smtp.gmail.com with ESMTPSA id t16sm3836510wmi.3.2021.01.13.08.41.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 13 Jan 2021 08:41:34 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, Dany Madden , Lijun Pan , Sukadev Bhattiprolu , Michael Ellerman , Benjamin Herrenschmidt , Paul Mackerras , "David S. Miller" , Jakub Kicinski , Santiago Leon , Thomas Falcon , John Allen , netdev@vger.kernel.org, linuxppc-dev@lists.ozlabs.org Subject: [PATCH 5/7] net: ethernet: ibm: ibmvnic: Fix some kernel-doc misdemeanours Date: Wed, 13 Jan 2021 16:41:21 +0000 Message-Id: <20210113164123.1334116-6-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210113164123.1334116-1-lee.jones@linaro.org> References: <20210113164123.1334116-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Fixes the following W=1 kernel build warning(s): from drivers/net/ethernet/ibm/ibmvnic.c:35: inlined from ‘handle_vpd_rsp’ at drivers/net/ethernet/ibm/ibmvnic.c:4124:3: drivers/net/ethernet/ibm/ibmvnic.c:1362: warning: Function parameter or member 'hdr_field' not described in 'build_hdr_data' drivers/net/ethernet/ibm/ibmvnic.c:1362: warning: Function parameter or member 'skb' not described in 'build_hdr_data' drivers/net/ethernet/ibm/ibmvnic.c:1362: warning: Function parameter or member 'hdr_len' not described in 'build_hdr_data' drivers/net/ethernet/ibm/ibmvnic.c:1362: warning: Function parameter or member 'hdr_data' not described in 'build_hdr_data' drivers/net/ethernet/ibm/ibmvnic.c:1423: warning: Function parameter or member 'hdr_field' not described in 'create_hdr_descs' drivers/net/ethernet/ibm/ibmvnic.c:1423: warning: Function parameter or member 'hdr_data' not described in 'create_hdr_descs' drivers/net/ethernet/ibm/ibmvnic.c:1423: warning: Function parameter or member 'len' not described in 'create_hdr_descs' drivers/net/ethernet/ibm/ibmvnic.c:1423: warning: Function parameter or member 'hdr_len' not described in 'create_hdr_descs' drivers/net/ethernet/ibm/ibmvnic.c:1423: warning: Function parameter or member 'scrq_arr' not described in 'create_hdr_descs' drivers/net/ethernet/ibm/ibmvnic.c:1474: warning: Function parameter or member 'txbuff' not described in 'build_hdr_descs_arr' drivers/net/ethernet/ibm/ibmvnic.c:1474: warning: Function parameter or member 'num_entries' not described in 'build_hdr_descs_arr' drivers/net/ethernet/ibm/ibmvnic.c:1474: warning: Function parameter or member 'hdr_field' not described in 'build_hdr_descs_arr' drivers/net/ethernet/ibm/ibmvnic.c:1832: warning: Function parameter or member 'adapter' not described in 'do_change_param_reset' drivers/net/ethernet/ibm/ibmvnic.c:1832: warning: Function parameter or member 'rwi' not described in 'do_change_param_reset' drivers/net/ethernet/ibm/ibmvnic.c:1832: warning: Function parameter or member 'reset_state' not described in 'do_change_param_reset' drivers/net/ethernet/ibm/ibmvnic.c:1911: warning: Function parameter or member 'adapter' not described in 'do_reset' drivers/net/ethernet/ibm/ibmvnic.c:1911: warning: Function parameter or member 'rwi' not described in 'do_reset' drivers/net/ethernet/ibm/ibmvnic.c:1911: warning: Function parameter or member 'reset_state' not described in 'do_reset' Cc: Dany Madden Cc: Lijun Pan Cc: Sukadev Bhattiprolu Cc: Michael Ellerman Cc: Benjamin Herrenschmidt Cc: Paul Mackerras Cc: "David S. Miller" Cc: Jakub Kicinski Cc: Santiago Leon Cc: Thomas Falcon Cc: John Allen Cc: netdev@vger.kernel.org Cc: linuxppc-dev@lists.ozlabs.org Signed-off-by: Lee Jones --- drivers/net/ethernet/ibm/ibmvnic.c | 27 +++++++++++++-------------- drivers/net/xen-netfront.c | 6 +++--- 2 files changed, 16 insertions(+), 17 deletions(-) -- 2.25.1 diff --git a/drivers/net/ethernet/ibm/ibmvnic.c b/drivers/net/ethernet/ibm/ibmvnic.c index aed985e08e8ad..4c4252e68de5a 100644 --- a/drivers/net/ethernet/ibm/ibmvnic.c +++ b/drivers/net/ethernet/ibm/ibmvnic.c @@ -1384,10 +1384,10 @@ static int ibmvnic_close(struct net_device *netdev) /** * build_hdr_data - creates L2/L3/L4 header data buffer - * @hdr_field - bitfield determining needed headers - * @skb - socket buffer - * @hdr_len - array of header lengths - * @tot_len - total length of data + * @hdr_field: bitfield determining needed headers + * @skb: socket buffer + * @hdr_len: array of header lengths + * @hdr_data: buffer to write the header to * * Reads hdr_field to determine which headers are needed by firmware. * Builds a buffer containing these headers. Saves individual header @@ -1444,11 +1444,11 @@ static int build_hdr_data(u8 hdr_field, struct sk_buff *skb, /** * create_hdr_descs - create header and header extension descriptors - * @hdr_field - bitfield determining needed headers - * @data - buffer containing header data - * @len - length of data buffer - * @hdr_len - array of individual header lengths - * @scrq_arr - descriptor array + * @hdr_field: bitfield determining needed headers + * @hdr_data: buffer containing header data + * @len: length of data buffer + * @hdr_len: array of individual header lengths + * @scrq_arr: descriptor array * * Creates header and, if needed, header extension descriptors and * places them in a descriptor array, scrq_arr @@ -1496,10 +1496,9 @@ static int create_hdr_descs(u8 hdr_field, u8 *hdr_data, int len, int *hdr_len, /** * build_hdr_descs_arr - build a header descriptor array - * @skb - socket buffer - * @num_entries - number of descriptors to be sent - * @subcrq - first TX descriptor - * @hdr_field - bit field determining which headers will be sent + * @txbuff: tx buffer + * @num_entries: number of descriptors to be sent + * @hdr_field: bit field determining which headers will be sent * * This function will build a TX descriptor array with applicable * L2/L3/L4 packet header descriptors to be sent by send_subcrq_indirect. @@ -1925,7 +1924,7 @@ static int ibmvnic_set_mac(struct net_device *netdev, void *p) return rc; } -/** +/* * do_reset returns zero if we are able to keep processing reset events, or * non-zero if we hit a fatal error and must halt. */ diff --git a/drivers/net/xen-netfront.c b/drivers/net/xen-netfront.c index c20b78120bb42..6ef2adbd283a3 100644 --- a/drivers/net/xen-netfront.c +++ b/drivers/net/xen-netfront.c @@ -1580,7 +1580,7 @@ static struct net_device *xennet_create_dev(struct xenbus_device *dev) return ERR_PTR(err); } -/** +/* * Entry point to this code when a new device is created. Allocate the basic * structures and the ring buffers for communication with the backend, and * inform the backend of the appropriate details for those. @@ -1657,7 +1657,7 @@ static void xennet_disconnect_backend(struct netfront_info *info) } } -/** +/* * We are reconnecting to the backend, due to a suspend/resume, or a backend * driver restart. We tear down our netif structure and recreate it, but * leave the device-layer structures intact so that this is transparent to the @@ -2303,7 +2303,7 @@ static int xennet_connect(struct net_device *dev) return 0; } -/** +/* * Callback received when the backend's state changes. */ static void netback_changed(struct xenbus_device *dev, From patchwork Wed Jan 13 16:41:22 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 362170 Delivered-To: patch@linaro.org Received: by 2002:a02:ccad:0:0:0:0:0 with SMTP id t13csp693658jap; Wed, 13 Jan 2021 08:44:14 -0800 (PST) X-Google-Smtp-Source: ABdhPJwbliPTtJ/QKJKJYKaqRiWCg+ELQxQzD/DKu/f1VuOKU3nJrvCSmrKrSvcl8W3BWygwhVT6 X-Received: by 2002:a17:907:c01:: with SMTP id ga1mr2122964ejc.488.1610556254151; Wed, 13 Jan 2021 08:44:14 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1610556254; cv=none; d=google.com; s=arc-20160816; b=XwSzUDb7c93h+Vbh0ZfCg5DCYHBTL/7C0dlAbiXElwoH7gjuqmwS9xP3EeDwRu2UW5 rQ47WAgmJgmEf1GcZpdegjL+9xE/wapxsqINAR/tFqUU9WiE3Xy+rMMLrAneP9MYh4ks QOu/cBV2khHIc0xcfeXTV0m4Q5hQiSJk+CFHk+56RWyXMsSz7RF+SCPYFR+ZlhUDnCoN xqX6B1g5WW5iMV2W5iGAS8zIZ/lk+wRjAzM9KtcXzZXItMu+YWRtuj3Gc65dyCwRYZga 3kcXZm361I+WIBBVididrVdtiWvAbHEdo9bpml6E7Vb/ZZM1va5l0Ws4RPSLyGQAgadp Jzew== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=+qXCFwBbPWtbGR33uyQvB+16QfHJsg8zQueyUlEuj0c=; b=A04RewCVXsQlwvfDM10E9VSdqESPczIS/a5IstW910pO6d2yo6hD0z8wdUHGlZOXzT bTUK3A0ffMLrXyxudJM4nS0032M1dlkOvRBvU0AbKsGY0UanEZ3aXvVPKHbEJw5Z1uX+ GdcLfsMoVHpvuYSd5zKInQ6C3U5FIQFksiN6EKkeLgZfZliUXQ8DwYlXy9ectKOrtjgd Bl9OReqvwOrnBdaX3rmupvGg68oi84nGJczcEEoIz9JpWrVBskBIkJiHZlXmNZdoZepq V4rfuTbCEuIwnkj0z1nNzbbtGqNAHms8IW3sGcuVXoaQK3TDqwn89kiGHbC69sAphG2z tOnQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b="rIamJQ5/"; spf=pass (google.com: domain of netdev-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=netdev-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id f1si435506ejh.593.2021.01.13.08.44.14; Wed, 13 Jan 2021 08:44:14 -0800 (PST) Received-SPF: pass (google.com: domain of netdev-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b="rIamJQ5/"; spf=pass (google.com: domain of netdev-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=netdev-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727998AbhAMQnH (ORCPT + 7 others); Wed, 13 Jan 2021 11:43:07 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37994 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726544AbhAMQnF (ORCPT ); Wed, 13 Jan 2021 11:43:05 -0500 Received: from mail-wr1-x429.google.com (mail-wr1-x429.google.com [IPv6:2a00:1450:4864:20::429]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 60897C0617B1 for ; Wed, 13 Jan 2021 08:41:37 -0800 (PST) Received: by mail-wr1-x429.google.com with SMTP id q18so2841586wrn.1 for ; Wed, 13 Jan 2021 08:41:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=+qXCFwBbPWtbGR33uyQvB+16QfHJsg8zQueyUlEuj0c=; b=rIamJQ5/O9hXkJ8XV2Qoa49nIlK/UCnw1dPZbM1yTQe0gWuyYEkLbLMoqCSttZ3SvF NVZCqAkOlEdu6kvDZ5i16teL5uv0tNMcqyuPa2g+yBVR5/vNCg8f5cid6BPfoqb6Nbs9 dmyJTRYuHMxbemXAl+cjgrqPQ+etMSJf3lzEVyREWL9unc69uINsTW/B/Jzd99C9xDh/ RbRgrafutQWccR4an6CigbITNw3AL5qMMQHVnZySXP4c412om23Ykm1soyq8xB1eXjNh SY0Wuvh3mSuTA6RP3M0PI4k8t2rCrSRNpj0C0SWZvrEEyoYzSNcupk923IWGDZHCZ2sB 2EoA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=+qXCFwBbPWtbGR33uyQvB+16QfHJsg8zQueyUlEuj0c=; b=GTWB4vamopQmsRv/DZadydMbmJFjaGbiuTSD0jp6ak3+pm24VEUwElaks/UStFfswP uNNbSNYXC6VsDYGj8ExfcrdFHZoaeLmiGuEpGR5sjwH0k1++XeVhiO0Vhs3OLh3qy7f+ 4T1sFF4rXwR9jWgSlnEr6FOLn/mESrBcwG+JQcE0S7N8DBMDr5PLoK2U83piZRjHvsLq 1LJm2Z0/4VH7yLSMFmrOW3ce3Rrf9AbTqHuLSziZsVwKD/7IULsxn2R+kZlbhcN7wD7T OpLQFW8LVmolcezj1wMAbddDygkMNGd78h1iULQBOQUN8Szd8eiU5im5/WdKrmJkBMlz UdCQ== X-Gm-Message-State: AOAM530as578J/HvnjTWgXr8OW0nXe7Qij0FSF3eBKN6Y6TDEzKFbCVH hjwmWn26rcMG3/wVJEH1ilJYrw== X-Received: by 2002:a5d:4307:: with SMTP id h7mr3529768wrq.353.1610556096162; Wed, 13 Jan 2021 08:41:36 -0800 (PST) Received: from dell.default ([91.110.221.229]) by smtp.gmail.com with ESMTPSA id t16sm3836510wmi.3.2021.01.13.08.41.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 13 Jan 2021 08:41:35 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, Geoff Levand , "David S. Miller" , Jakub Kicinski , Michael Ellerman , Benjamin Herrenschmidt , Paul Mackerras , Utz Bacher , Jens Osterkamp , netdev@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, Andrew Lunn Subject: [PATCH 6/7] net: ethernet: toshiba: ps3_gelic_net: Fix some kernel-doc misdemeanours Date: Wed, 13 Jan 2021 16:41:22 +0000 Message-Id: <20210113164123.1334116-7-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210113164123.1334116-1-lee.jones@linaro.org> References: <20210113164123.1334116-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/net/ethernet/toshiba/ps3_gelic_net.c:1107: warning: Function parameter or member 'irq' not described in 'gelic_card_interrupt' drivers/net/ethernet/toshiba/ps3_gelic_net.c:1107: warning: Function parameter or member 'ptr' not described in 'gelic_card_interrupt' drivers/net/ethernet/toshiba/ps3_gelic_net.c:1407: warning: Function parameter or member 'txqueue' not described in 'gelic_net_tx_timeout' drivers/net/ethernet/toshiba/ps3_gelic_net.c:1439: warning: Function parameter or member 'napi' not described in 'gelic_ether_setup_netdev_ops' drivers/net/ethernet/toshiba/ps3_gelic_net.c:1639: warning: Function parameter or member 'dev' not described in 'ps3_gelic_driver_probe' drivers/net/ethernet/toshiba/ps3_gelic_net.c:1795: warning: Function parameter or member 'dev' not described in 'ps3_gelic_driver_remove' Cc: Geoff Levand Cc: "David S. Miller" Cc: Jakub Kicinski Cc: Michael Ellerman Cc: Benjamin Herrenschmidt Cc: Paul Mackerras Cc: Utz Bacher Cc: Jens Osterkamp Cc: netdev@vger.kernel.org Cc: linuxppc-dev@lists.ozlabs.org Reviewed-by: Andrew Lunn Signed-off-by: Lee Jones --- drivers/net/ethernet/toshiba/ps3_gelic_net.c | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) -- 2.25.1 diff --git a/drivers/net/ethernet/toshiba/ps3_gelic_net.c b/drivers/net/ethernet/toshiba/ps3_gelic_net.c index 3d1fc8d2ca667..55e652624bd76 100644 --- a/drivers/net/ethernet/toshiba/ps3_gelic_net.c +++ b/drivers/net/ethernet/toshiba/ps3_gelic_net.c @@ -1100,7 +1100,7 @@ static int gelic_net_poll(struct napi_struct *napi, int budget) return packets_done; } -/** +/* * gelic_card_interrupt - event handler for gelic_net */ static irqreturn_t gelic_card_interrupt(int irq, void *ptr) @@ -1400,6 +1400,7 @@ static void gelic_net_tx_timeout_task(struct work_struct *work) /** * gelic_net_tx_timeout - called when the tx timeout watchdog kicks in. * @netdev: interface device structure + * @txqueue: unused * * called, if tx hangs. Schedules a task that resets the interface */ @@ -1431,6 +1432,7 @@ static const struct net_device_ops gelic_netdevice_ops = { /** * gelic_ether_setup_netdev_ops - initialization of net_device operations * @netdev: net_device structure + * @napi: napi structure * * fills out function pointers in the net_device structure */ @@ -1632,7 +1634,7 @@ static void gelic_card_get_vlan_info(struct gelic_card *card) dev_info(ctodev(card), "internal vlan %s\n", card->vlan_required? "enabled" : "disabled"); } -/** +/* * ps3_gelic_driver_probe - add a device to the control of this driver */ static int ps3_gelic_driver_probe(struct ps3_system_bus_device *dev) @@ -1787,7 +1789,7 @@ static int ps3_gelic_driver_probe(struct ps3_system_bus_device *dev) return result; } -/** +/* * ps3_gelic_driver_remove - remove a device from the control of this driver */ From patchwork Wed Jan 13 16:41:23 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 362169 Delivered-To: patch@linaro.org Received: by 2002:a02:ccad:0:0:0:0:0 with SMTP id t13csp693654jap; Wed, 13 Jan 2021 08:44:13 -0800 (PST) X-Google-Smtp-Source: ABdhPJzakUKOJv1O6uxavsiw8VeAMzwh0QSdanl8OmCpkkr3SKUNVVMvJUiKDoL2hyHsgO/ijD4C X-Received: by 2002:aa7:c78c:: with SMTP id n12mr2504095eds.363.1610556253762; Wed, 13 Jan 2021 08:44:13 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1610556253; cv=none; d=google.com; s=arc-20160816; b=CB0AUX0Uiah81NgrT3Xqo6lZyqR2UC8B3AcVeEsaWdIOXZjsuB94zvKDKh8kq6s7ST n1gqNKbtLj+63XuqVYWlP5OViK9ZXCvIhrIDcKMons7J9B4NopuqGabRfXH0CxI4oyvE M7qVWUeTdc3duJLbJIcKpT0NHHacyrJE4awvu5fUDtMH6ra2NcVhnbwezzyDoeje+9xM WX1/kj9+9WB9HcpUr24R2w45R0lwWSgkoepF4VxOja7hq0npApKS7CDPnDNVfMdZHx36 bZQFY4P61f8gdppDyjOaKUwH/bEN6DTb0HpM6a7gRXXNJtxW2sbmyJocj0s1lRrZnwAK HL0g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=ChGB+JX2oknD3GU9F+oPlQzChiJ0MNf1JzMjKC1b9JA=; b=pV9Xa7aZS6BfqvKou+71I5593wiTJOBjbynnD91sPEuABWyRFNOCOF63OgWlo8T00A i+Epk+b/MsDDnuAansEJjnJxqccdmrE9Jvd3YQSpBOjJ/SwC/7VmGlwuDvtQB7MDKysr 8TSpIi9o/IINhiTopykDSypO1PT+1OQbpCUoNBBJEMB9g78A3MxqpYNj+KGaHgjAvqDD vlwGeWtrcp17x9DoODDTUkxt+KxUF49fdlOd5dKNqoVd4mruqXVwBugARnnZUQwelc6M 19Hy34GwAO9FdjtNwKLuCqS3iunVsxiNJ2Wy7bI/2u70HVGw6sry+Q/t58zXQgjY3PBr M1vg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=FWA9LG+n; spf=pass (google.com: domain of netdev-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=netdev-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id f1si435506ejh.593.2021.01.13.08.44.13; Wed, 13 Jan 2021 08:44:13 -0800 (PST) Received-SPF: pass (google.com: domain of netdev-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=FWA9LG+n; spf=pass (google.com: domain of netdev-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=netdev-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727990AbhAMQnF (ORCPT + 7 others); Wed, 13 Jan 2021 11:43:05 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37996 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727959AbhAMQnF (ORCPT ); Wed, 13 Jan 2021 11:43:05 -0500 Received: from mail-wr1-x42c.google.com (mail-wr1-x42c.google.com [IPv6:2a00:1450:4864:20::42c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E48C2C0617B9 for ; Wed, 13 Jan 2021 08:41:38 -0800 (PST) Received: by mail-wr1-x42c.google.com with SMTP id t30so2844153wrb.0 for ; Wed, 13 Jan 2021 08:41:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=ChGB+JX2oknD3GU9F+oPlQzChiJ0MNf1JzMjKC1b9JA=; b=FWA9LG+nduuvOiPy7qbwmuuoFpDSfcuJf4CIGNPTHPKLag9L8f8PSQTVLTxEvNOFj3 x8bvGUm2lcL53dta+xNOQCjwO1ELeQE/HHZqS4GtxSRUMcTtcDNKEwAoDJmSQB7QRy3E 70yVJWp7JPSps93FHROwL6LzmD5bMZFIpA/kx05SsxrsWszuLKZ2EMBJoOSCgGZvI8hf SX5Qq+hB7tq6xeduYNRHnNpeSc5cZP1965GFGAUrPoz0ziBXBQnYIo3/IKMvsUz11lkq ZTxaMx4OYfKXDpFNweVVc83/V4U10Z9yXQ0WsfmNIzrQG5kmi52ZZ+B9HYe1yy1M+jNT nNtA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=ChGB+JX2oknD3GU9F+oPlQzChiJ0MNf1JzMjKC1b9JA=; b=rktRqRYmG5XjQTd7Qus8cof27Q1ft0Tg7z/umNFw0iUfop6mv6l2tksLM2R7FVNpEe f3Hf7L9WfhidP+Hoxt11imV62YBiOq/8cfbMgY788g5S5DSohlist4HaMlQLKqSkImxf Uo1SfowNPmfg2Fk4DNeVn7JP+EkFPUocyr+z3O96z+isNNXL7B4vxWYKdz2C3Uu2M61W +CHvOiBv8Hk5Bcw1GIJnbl+J3dBKttSd6MKDCOEI3AH8QZH9ye/ACWD8WAPYAOzdTIYq 3a8n5Hd7AYmX0UCmMfTmm7ILvDwDuRnkWE9IZACHyAiq8OAg1XiUYhDGhur597LA0Kyc dulw== X-Gm-Message-State: AOAM531qKLElktIouU8IcsKEknfikMmmDMV3iQ79DdQ4gHPnswmr/gpy YD1H89omdowevQU9/nzUxtZ08g== X-Received: by 2002:adf:f10f:: with SMTP id r15mr3593887wro.302.1610556097638; Wed, 13 Jan 2021 08:41:37 -0800 (PST) Received: from dell.default ([91.110.221.229]) by smtp.gmail.com with ESMTPSA id t16sm3836510wmi.3.2021.01.13.08.41.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 13 Jan 2021 08:41:36 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, Ishizaki Kou , "David S. Miller" , Jakub Kicinski , Utz Bacher , Jens Osterkamp , netdev@vger.kernel.org, Andrew Lunn Subject: [PATCH 7/7] net: ethernet: toshiba: spider_net: Document a whole bunch of function parameters Date: Wed, 13 Jan 2021 16:41:23 +0000 Message-Id: <20210113164123.1334116-8-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210113164123.1334116-1-lee.jones@linaro.org> References: <20210113164123.1334116-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/net/ethernet/toshiba/spider_net.c:263: warning: Function parameter or member 'hwdescr' not described in 'spider_net_get_descr_status' drivers/net/ethernet/toshiba/spider_net.c:263: warning: Excess function parameter 'descr' description in 'spider_net_get_descr_status' drivers/net/ethernet/toshiba/spider_net.c:554: warning: Function parameter or member 'netdev' not described in 'spider_net_get_multicast_hash' drivers/net/ethernet/toshiba/spider_net.c:902: warning: Function parameter or member 't' not described in 'spider_net_cleanup_tx_ring' drivers/net/ethernet/toshiba/spider_net.c:902: warning: Excess function parameter 'card' description in 'spider_net_cleanup_tx_ring' drivers/net/ethernet/toshiba/spider_net.c:1074: warning: Function parameter or member 'card' not described in 'spider_net_resync_head_ptr' drivers/net/ethernet/toshiba/spider_net.c:1234: warning: Function parameter or member 'napi' not described in 'spider_net_poll' drivers/net/ethernet/toshiba/spider_net.c:1234: warning: Excess function parameter 'netdev' description in 'spider_net_poll' drivers/net/ethernet/toshiba/spider_net.c:1278: warning: Function parameter or member 'p' not described in 'spider_net_set_mac' drivers/net/ethernet/toshiba/spider_net.c:1278: warning: Excess function parameter 'ptr' description in 'spider_net_set_mac' drivers/net/ethernet/toshiba/spider_net.c:1350: warning: Function parameter or member 'error_reg1' not described in 'spider_net_handle_error_irq' drivers/net/ethernet/toshiba/spider_net.c:1350: warning: Function parameter or member 'error_reg2' not described in 'spider_net_handle_error_irq' drivers/net/ethernet/toshiba/spider_net.c:1968: warning: Function parameter or member 't' not described in 'spider_net_link_phy' drivers/net/ethernet/toshiba/spider_net.c:1968: warning: Excess function parameter 'data' description in 'spider_net_link_phy' drivers/net/ethernet/toshiba/spider_net.c:2149: warning: Function parameter or member 'work' not described in 'spider_net_tx_timeout_task' drivers/net/ethernet/toshiba/spider_net.c:2149: warning: Excess function parameter 'data' description in 'spider_net_tx_timeout_task' drivers/net/ethernet/toshiba/spider_net.c:2182: warning: Function parameter or member 'txqueue' not described in 'spider_net_tx_timeout' Cc: Ishizaki Kou Cc: "David S. Miller" Cc: Jakub Kicinski Cc: Utz Bacher Cc: Jens Osterkamp Cc: netdev@vger.kernel.org Reviewed-by: Andrew Lunn Signed-off-by: Lee Jones --- drivers/net/ethernet/toshiba/spider_net.c | 18 +++++++++++------- 1 file changed, 11 insertions(+), 7 deletions(-) -- 2.25.1 diff --git a/drivers/net/ethernet/toshiba/spider_net.c b/drivers/net/ethernet/toshiba/spider_net.c index 5f5b33e6653b2..d5a75ef7e3ca9 100644 --- a/drivers/net/ethernet/toshiba/spider_net.c +++ b/drivers/net/ethernet/toshiba/spider_net.c @@ -254,7 +254,7 @@ spider_net_set_promisc(struct spider_net_card *card) /** * spider_net_get_descr_status -- returns the status of a descriptor - * @descr: descriptor to look at + * @hwdescr: descriptor to look at * * returns the status as in the dmac_cmd_status field of the descriptor */ @@ -542,6 +542,7 @@ spider_net_alloc_rx_skbs(struct spider_net_card *card) /** * spider_net_get_multicast_hash - generates hash for multicast filter table + * @netdev: interface device structure * @addr: multicast address * * returns the hash value. @@ -890,7 +891,7 @@ spider_net_xmit(struct sk_buff *skb, struct net_device *netdev) /** * spider_net_cleanup_tx_ring - cleans up the TX ring - * @card: card structure + * @t: timer context used to obtain the pointer to net card data structure * * spider_net_cleanup_tx_ring is called by either the tx_timer * or from the NAPI polling routine. @@ -1063,6 +1064,7 @@ static void show_rx_chain(struct spider_net_card *card) /** * spider_net_resync_head_ptr - Advance head ptr past empty descrs + * @card: card structure * * If the driver fails to keep up and empty the queue, then the * hardware wil run out of room to put incoming packets. This @@ -1220,7 +1222,7 @@ spider_net_decode_one_descr(struct spider_net_card *card) /** * spider_net_poll - NAPI poll function called by the stack to return packets - * @netdev: interface device structure + * @napi: napi device structure * @budget: number of packets we can pass to the stack at most * * returns 0 if no more packets available to the driver/stack. Returns 1, @@ -1268,7 +1270,7 @@ static int spider_net_poll(struct napi_struct *napi, int budget) /** * spider_net_set_mac - sets the MAC of an interface * @netdev: interface device structure - * @ptr: pointer to new MAC address + * @p: pointer to new MAC address * * Returns 0 on success, <0 on failure. Currently, we don't support this * and will always return EOPNOTSUPP. @@ -1340,6 +1342,8 @@ spider_net_link_reset(struct net_device *netdev) * spider_net_handle_error_irq - handles errors raised by an interrupt * @card: card structure * @status_reg: interrupt status register 0 (GHIINT0STS) + * @error_reg1: interrupt status register 1 (GHIINT1STS) + * @error_reg2: interrupt status register 2 (GHIINT2STS) * * spider_net_handle_error_irq treats or ignores all error conditions * found when an interrupt is presented @@ -1961,8 +1965,7 @@ spider_net_open(struct net_device *netdev) /** * spider_net_link_phy - * @data: used for pointer to card structure - * + * @t: timer context used to obtain the pointer to net card data structure */ static void spider_net_link_phy(struct timer_list *t) { @@ -2140,7 +2143,7 @@ spider_net_stop(struct net_device *netdev) /** * spider_net_tx_timeout_task - task scheduled by the watchdog timeout * function (to be called not under interrupt status) - * @data: data, is interface device structure + * @work: work context used to obtain the pointer to net card data structure * * called as task when tx hangs, resets interface (if interface is up) */ @@ -2174,6 +2177,7 @@ spider_net_tx_timeout_task(struct work_struct *work) /** * spider_net_tx_timeout - called when the tx timeout watchdog kicks in. * @netdev: interface device structure + * @txqueue: unused * * called, if tx hangs. Schedules a task that resets the interface */