From patchwork Wed Jan 13 14:49:40 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 362413 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER, INCLUDES_PATCH, MAILING_LIST_MULTI, SPF_HELO_NONE, SPF_PASS, URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 05125C433E6 for ; Wed, 13 Jan 2021 14:51:14 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B5C1123619 for ; Wed, 13 Jan 2021 14:51:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726900AbhAMOvC (ORCPT ); Wed, 13 Jan 2021 09:51:02 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41624 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726893AbhAMOvB (ORCPT ); Wed, 13 Jan 2021 09:51:01 -0500 Received: from mail-wr1-x42f.google.com (mail-wr1-x42f.google.com [IPv6:2a00:1450:4864:20::42f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8BADAC0617A3 for ; Wed, 13 Jan 2021 06:50:18 -0800 (PST) Received: by mail-wr1-x42f.google.com with SMTP id t30so2433904wrb.0 for ; Wed, 13 Jan 2021 06:50:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=9f2BPaI0FPEfwHACkMCkRxYDyaBt02TKR4D8xELwApI=; b=zc9ZOpEUI+Nh6Qla1WDfrb2vnRL2q84hQM50XEQXQr0xU371apuDwreUQOZKKSgAr5 g7a1pROIkw2JAlYrfbUiig2HWLqwWHy8HZ/XWWBHtiDNKwj55UxEgroLjJuCBw18hlHe 92MAeh9s6TSYlS6N3UHBcggv18NhVPSGxCug7FAilAYfafpZsRbkQDlYTKiORivlccUP 9LS1k+4OMMbCziBfn3XobchtVgfVFJZSPwFyAo4AnK1qxUYR+KRpOnUOlfLckY0T7SBh WIy1YBvftA/oJxDxlPln0TX3wEE3MMUxIU12tVxKSgY+5mviYsZit9GALu0OnFxLsu+0 HhzQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=9f2BPaI0FPEfwHACkMCkRxYDyaBt02TKR4D8xELwApI=; b=bGkb9cyLc+qT7CkQp2K1CbobeU7S0oYg2HZXTIDJLQwM54yv/WPF1i7PNmtVyIG6+g WupG9vUKoMVK9BeStwqIhiq1aZw7zpjkGA6F+ciCXQ/yXAseA6HJHjGwcqbLERCAEA/O GD+MiVg35fWv1gPswpQOqtQPO69J741KqbFVJlSq6O61i7uZRGQOChlnc9nuRyXgzL6l iBUDbpxHIqlmlYDobEdZv8fS/medmbHwsVIBrS0EZiocT6leQPWG17hTvXnNg4n4vH2p DK5OZjWFwh9G9SoKBNY08LCohigWjsCOURGd1CSsDXGG6G807VxDcjyNF4UMPIP+a07C Se0g== X-Gm-Message-State: AOAM533zzNsUDkqQ6Jn2tqk9wNRUSnYhPl2BPCp/0w+nvhfSuv3FGg4j 2PJhWrTQpHRKdtSO+6Nhzz3A3g== X-Google-Smtp-Source: ABdhPJzvNk0my33Gw7zgd1XA3cpG4wONGFNN2ELceKXzyI59SQd9sR/5sbIBr/pV5XoFHhHHEN2b3g== X-Received: by 2002:adf:f4d0:: with SMTP id h16mr3060914wrp.30.1610549416231; Wed, 13 Jan 2021 06:50:16 -0800 (PST) Received: from dell.default ([91.110.221.229]) by smtp.gmail.com with ESMTPSA id t188sm3273433wmf.9.2021.01.13.06.50.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 13 Jan 2021 06:50:15 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, Steffen Trumtrar , Sascha Hauer , dri-devel@lists.freedesktop.org, linux-fbdev@vger.kernel.org Subject: [PATCH 02/31] video: of_display_timing: Provide missing description for 'dt' Date: Wed, 13 Jan 2021 14:49:40 +0000 Message-Id: <20210113145009.1272040-3-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210113145009.1272040-1-lee.jones@linaro.org> References: <20210113145009.1272040-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-fbdev@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/video/of_display_timing.c:58: warning: Function parameter or member 'dt' not described in 'of_parse_display_timing' Cc: Steffen Trumtrar Cc: Sascha Hauer Cc: dri-devel@lists.freedesktop.org Cc: linux-fbdev@vger.kernel.org Signed-off-by: Lee Jones --- drivers/video/of_display_timing.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/video/of_display_timing.c b/drivers/video/of_display_timing.c index abc9ada798ee8..9f21f7dc85292 100644 --- a/drivers/video/of_display_timing.c +++ b/drivers/video/of_display_timing.c @@ -52,6 +52,7 @@ static int parse_timing_property(const struct device_node *np, const char *name, /** * of_parse_display_timing - parse display_timing entry from device_node * @np: device_node with the properties + * @dt: Display timing information **/ static int of_parse_display_timing(const struct device_node *np, struct display_timing *dt) From patchwork Wed Jan 13 14:49:41 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 362399 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER, INCLUDES_PATCH, MAILING_LIST_MULTI, SPF_HELO_NONE, SPF_PASS, URIBL_BLOCKED, USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 94117C43381 for ; Wed, 13 Jan 2021 14:55:05 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 48A0A235FF for ; Wed, 13 Jan 2021 14:55:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727278AbhAMOvh (ORCPT ); Wed, 13 Jan 2021 09:51:37 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41750 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727106AbhAMOvg (ORCPT ); Wed, 13 Jan 2021 09:51:36 -0500 Received: from mail-wm1-x336.google.com (mail-wm1-x336.google.com [IPv6:2a00:1450:4864:20::336]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A15C1C0617A6 for ; Wed, 13 Jan 2021 06:50:18 -0800 (PST) Received: by mail-wm1-x336.google.com with SMTP id 190so1850490wmz.0 for ; Wed, 13 Jan 2021 06:50:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=z+Wneugk0qlue2K4+v5y/OOFUzDsbbip7TVziVpxlQg=; b=IrAuQ7STah/wSU3pxyHJvgSYn2RFJdHG53sANMcOvFWEelHr6MWbdgH0ILose47Zot Z7KuINVRHXAMOA906n8OR8iFtf4Nj4LcjAyitSzAalDlz9HRtVPGlTQdbmekRtEQvGci mwZQ7Bb/HQ3c6/5luRJ3paeeu2VckReWTpFW7IRFzHAedOHDtIquldPM8aztOfgvKxxD s6M1i1MfLLNqZIHLouLNp+LTtcAhj/vFkE7Sl4+oIe3REJUFHIDtu/tkOMeXBy2FAK74 x/2MlHNNGii/IG81iFi1rPP9oiZBxGa2SQxXcMDTHrLT+hIaHOP1bEfVoE+Viqsap5Ze aNlA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=z+Wneugk0qlue2K4+v5y/OOFUzDsbbip7TVziVpxlQg=; b=OXd1oHlr2WCnqm5ruX4mu01HfBPo4VgAwJS6EV16Kuk8uUc4bT6OxhxWqtQ8R4BU3h ew7hAaD3GK7Uxk3OGVIBaYUXVCUkPIRtzUWqbzyVjY/6MV7ofdawvR1//MtZ4yVrzOe4 SReSD5HdhzJribVtW54SDR2/k/YvrW34b2o/eiWmYkY9JQVux8oTNd5UXM4/PdcuYA/p Jn/4vvQ6cYR/846C4dfUBNXSJnkdncYf/DmLmPEWvYH+jTWaw6lNFtbobTxIJcT+hz6q 5WriOXfVykNaszpJSLFf4MxRqadIoHn83fhNgSLV1LCl6ByxXn9xhRMzbhlSuyd65V+E 7ueA== X-Gm-Message-State: AOAM53158PiBuU4a3SAVwHI4bMjMVdL0nHoXS9ZdPBCEfYu3YRw5fTzM /N9rEEtSXG5NzIup6HMEJA853A== X-Google-Smtp-Source: ABdhPJwjKCL09Sc77kIICMVKTnbILEqHPsQQ1uMvyk6hJHaNqRVyJKhV6HK5PA5SegcO2ZY3WnDx2Q== X-Received: by 2002:a7b:c24b:: with SMTP id b11mr2562890wmj.168.1610549417412; Wed, 13 Jan 2021 06:50:17 -0800 (PST) Received: from dell.default ([91.110.221.229]) by smtp.gmail.com with ESMTPSA id t188sm3273433wmf.9.2021.01.13.06.50.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 13 Jan 2021 06:50:16 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, Bartlomiej Zolnierkiewicz , Vaibhav Gupta , Alex Kern , "Eddie C. Dost" , Anthony Tong , dri-devel@lists.freedesktop.org, linux-fbdev@vger.kernel.org Subject: [PATCH 03/31] video: fbdev: aty: atyfb_base: Remove superfluous code surrounding 'dac_type' Date: Wed, 13 Jan 2021 14:49:41 +0000 Message-Id: <20210113145009.1272040-4-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210113145009.1272040-1-lee.jones@linaro.org> References: <20210113145009.1272040-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-fbdev@vger.kernel.org If used, 'dac_type' is overwritten in the '#ifdef CONFIG_ATARI' clause. It's also not used after the last assignment, so we'll rid that too. Cc: Bartlomiej Zolnierkiewicz Cc: Vaibhav Gupta Cc: Alex Kern Cc: "Eddie C. Dost" Cc: Anthony Tong Cc: dri-devel@lists.freedesktop.org Cc: linux-fbdev@vger.kernel.org Signed-off-by: Lee Jones --- drivers/video/fbdev/aty/atyfb_base.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/video/fbdev/aty/atyfb_base.c b/drivers/video/fbdev/aty/atyfb_base.c index c8feff0ee8da9..11c328f0585ce 100644 --- a/drivers/video/fbdev/aty/atyfb_base.c +++ b/drivers/video/fbdev/aty/atyfb_base.c @@ -2365,8 +2365,6 @@ static int aty_init(struct fb_info *info) par->bus_type = (stat0 >> 0) & 0x07; par->ram_type = (stat0 >> 3) & 0x07; ramname = aty_gx_ram[par->ram_type]; - /* FIXME: clockchip/RAMDAC probing? */ - dac_type = (aty_ld_le32(DAC_CNTL, par) >> 16) & 0x07; #ifdef CONFIG_ATARI clk_type = CLK_ATI18818_1; dac_type = (stat0 >> 9) & 0x07; @@ -2375,7 +2373,6 @@ static int aty_init(struct fb_info *info) else dac_subtype = (aty_ld_8(SCRATCH_REG1 + 1, par) & 0xF0) | dac_type; #else - dac_type = DAC_IBMRGB514; dac_subtype = DAC_IBMRGB514; clk_type = CLK_IBMRGB514; #endif From patchwork Wed Jan 13 14:49:43 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 362400 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER, INCLUDES_PATCH, MAILING_LIST_MULTI, SPF_HELO_NONE, SPF_PASS, URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 240D2C433E0 for ; Wed, 13 Jan 2021 14:55:05 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id DD42B235FF for ; Wed, 13 Jan 2021 14:55:04 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727290AbhAMOvi (ORCPT ); Wed, 13 Jan 2021 09:51:38 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41756 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727265AbhAMOvg (ORCPT ); Wed, 13 Jan 2021 09:51:36 -0500 Received: from mail-wr1-x42f.google.com (mail-wr1-x42f.google.com [IPv6:2a00:1450:4864:20::42f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D59B2C061575 for ; Wed, 13 Jan 2021 06:50:21 -0800 (PST) Received: by mail-wr1-x42f.google.com with SMTP id t16so2416098wra.3 for ; Wed, 13 Jan 2021 06:50:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=jVSUjkIjXEkNiZ9bYl2AvQwRUk7bSgmr726se0qdSGE=; b=S6pjMri1LooUzVebsMKl5L/qXAXXf0BQaNWI9zUwzK+jMt6eB9Qc4oOTGepufIBfid w8BOqqJSqOTlO1AaMZ2c97EUxzPgYgwXzlP38xgFZHdc5f5/8pnliirr015cmXT5P/6C bmXz//hqWY6WZtaLsnyk9w3DTs/zx93zvqMGjgmGEz1ltpAcWFoGUuZTLcV3oaXDRWzg TsHN1MtRbF4DsoU67oqGthJ9CyD102ea6PWM8nSeKWwLjDVQYDQOynMxGeM3eMYyzuVy k+RwnCTE6vvqOECHhK+/HT1+C06vWU2p6IumxaB4VEqq3egwhncHh1sL8BXGgsKHUjzx Jyrw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=jVSUjkIjXEkNiZ9bYl2AvQwRUk7bSgmr726se0qdSGE=; b=OtZRUa6hrrklHf/bJtbrXGCrqwVYP4VZMNyC7fQPOi61O3baxdg51Lc8HTsRK9ngIw 5woHhjSWMjd7gs2sfQGc7DBERaMJA2zs20rk3SCfTolKZ+pAVPDQTsA8nuHYu7kK65iA RwpU45FnjVSXdZzWW6UwvYNC3yYTNk9/R0JgZAgDe/Kc/9Mc2kWaO3+wgAnTdzDkWdvY diuotRF252O+pMnm1ccg4pp92RJz1bKS9Z3GwVK0MsNe/ipXsfj1ZCKW/Ydlf88iAJJk unX5jiuV5soBGf9Tm+8j3kft9cHR9fHuDj1P8P9+khHFwXX+fr7uO4derEZtFs4040QV 609A== X-Gm-Message-State: AOAM533CIRxFwcp1A4chHingL1+0pZChKwo3lIPREwgdTNYYnf0vnt7l /j7QdbDOhy55OyIEMlTIkzKjYw== X-Google-Smtp-Source: ABdhPJwQS7eakiW5Ymk7Te1CVRoqQilV5MyqcK9JOS6lfWXJfPo5U8VaTE2R9c7aaPoPlmXHPb50DQ== X-Received: by 2002:adf:ec86:: with SMTP id z6mr2994233wrn.17.1610549420622; Wed, 13 Jan 2021 06:50:20 -0800 (PST) Received: from dell.default ([91.110.221.229]) by smtp.gmail.com with ESMTPSA id t188sm3273433wmf.9.2021.01.13.06.50.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 13 Jan 2021 06:50:19 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, Steffen Trumtrar , dri-devel@lists.freedesktop.org, linux-fbdev@vger.kernel.org Subject: [PATCH 05/31] video: of_videomode: Fix formatting in kernel-doc header Date: Wed, 13 Jan 2021 14:49:43 +0000 Message-Id: <20210113145009.1272040-6-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210113145009.1272040-1-lee.jones@linaro.org> References: <20210113145009.1272040-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-fbdev@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/video/of_videomode.c:32: warning: Function parameter or member 'np' not described in 'of_get_videomode' drivers/video/of_videomode.c:32: warning: Function parameter or member 'vm' not described in 'of_get_videomode' drivers/video/of_videomode.c:32: warning: Function parameter or member 'index' not described in 'of_get_videomode' Cc: Steffen Trumtrar Cc: dri-devel@lists.freedesktop.org Cc: linux-fbdev@vger.kernel.org Signed-off-by: Lee Jones --- drivers/video/of_videomode.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/video/of_videomode.c b/drivers/video/of_videomode.c index 67aff2421c29e..97a220852977f 100644 --- a/drivers/video/of_videomode.c +++ b/drivers/video/of_videomode.c @@ -14,11 +14,11 @@ /** * of_get_videomode - get the videomode # from devicetree - * @np - devicenode with the display_timings - * @vm - set to return value - * @index - index into list of display_timings - * (Set this to OF_USE_NATIVE_MODE to use whatever mode is - * specified as native mode in the DT.) + * @np: devicenode with the display_timings + * @vm: set to return value + * @index: index into list of display_timings + * (Set this to OF_USE_NATIVE_MODE to use whatever mode is + * specified as native mode in the DT.) * * DESCRIPTION: * Get a list of all display timings and put the one From patchwork Wed Jan 13 14:49:46 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 362412 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER, INCLUDES_PATCH, MAILING_LIST_MULTI, SPF_HELO_NONE, SPF_PASS, URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2DBE3C43381 for ; Wed, 13 Jan 2021 14:51:34 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 0C3E823600 for ; Wed, 13 Jan 2021 14:51:34 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727228AbhAMOvc (ORCPT ); Wed, 13 Jan 2021 09:51:32 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41622 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726238AbhAMOvc (ORCPT ); Wed, 13 Jan 2021 09:51:32 -0500 Received: from mail-wr1-x432.google.com (mail-wr1-x432.google.com [IPv6:2a00:1450:4864:20::432]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 18276C0617BB for ; Wed, 13 Jan 2021 06:50:27 -0800 (PST) Received: by mail-wr1-x432.google.com with SMTP id r3so2426127wrt.2 for ; Wed, 13 Jan 2021 06:50:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=xVuJfuGZFscYbOy1MUiffPVpTle7WgNo/eVkJwf7WNU=; b=q+MZOwcKb62nI3dDtefjHxCD1svvGR60Jf4GADTHbVCFSZk5ahffVs42713RFmCF3M hhNPD9AVosxvdPh3Z8yE2EAX9AIqiNvXNvlrh/+KWS1FF0B5BjXeeykrTfib5131sKFj mn2tgU4dkCSlErK842cyu7HwusDnIaakfzs1I7cSnM4yplICdcp2mBAJcvH34TWQSDE0 Dng1yBz0vV3j29G56BqJw78ZGoOyPY6hhoK+WPjPT+6lUPxLOPjPUWuXCAoeTfdRwhJo a9h437HEm5yNmdhcoLqG033+xaunKcJYY/dyF8W3QR8fqLXStt350nJ0m0HkPZgnnZIh 3SRw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=xVuJfuGZFscYbOy1MUiffPVpTle7WgNo/eVkJwf7WNU=; b=DjTuwtxfmqDwphUhpGj59/EwNS9e5mCsHVY9JTOhBSlUncomlUn4IWUNQHyAZh5i1X spa+S3ESckZVcsqeUIRO60362gIaG3NLsuijLyBnAJTVqpDoAHqcsDtXPB84ItL3uyz3 IISEQbORrW7H/3M3AoVqIrkYXpFPQQVNxuwZMnYoHlfEY3BmDWXSpXnIUEgzGWKohPud giBf6JSDahMkRKWWzHWEb7dP+Lex2zFkv1efMAO8tlG5N+cDEDqFltAkRaPGDcGuBYEv qcBHQin1F1nbmHemaS1lrz77Wux2TIxk/X43heWp6CVYb9wNwQkXGYWe+UCo58k/aMb1 vzWg== X-Gm-Message-State: AOAM530AJYN2n4Sewg6p1wE7vzY2k9NPGfvsLs2cv13KypRQn+pCEjfX fTZkGMIJSS+ckCye/FB64+L/lA== X-Google-Smtp-Source: ABdhPJwVCTsByjCEjav6tW14+5dv7xLsxBc5Eorij361Ct+VXeRJyY7s7OCdf+rGi3SgUVSd2g+Hog== X-Received: by 2002:a5d:4d50:: with SMTP id a16mr2925284wru.43.1610549425879; Wed, 13 Jan 2021 06:50:25 -0800 (PST) Received: from dell.default ([91.110.221.229]) by smtp.gmail.com with ESMTPSA id t188sm3273433wmf.9.2021.01.13.06.50.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 13 Jan 2021 06:50:24 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, Thomas Winischhofer , Gerd Knorr , dri-devel@lists.freedesktop.org, linux-fbdev@vger.kernel.org Subject: [PATCH 08/31] video: fbdev: sis: sis_main: Remove unused variable 'reg' Date: Wed, 13 Jan 2021 14:49:46 +0000 Message-Id: <20210113145009.1272040-9-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210113145009.1272040-1-lee.jones@linaro.org> References: <20210113145009.1272040-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-fbdev@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/video/fbdev/sis/sis_main.c: In function ‘sisfb_post_xgi_ddr2’: drivers/video/fbdev/sis/sis_main.c:5032:5: warning: variable ‘reg’ set but not used [-Wunused-but-set-variable] Cc: Thomas Winischhofer Cc: Gerd Knorr Cc: dri-devel@lists.freedesktop.org Cc: linux-fbdev@vger.kernel.org Signed-off-by: Lee Jones --- drivers/video/fbdev/sis/sis_main.c | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/drivers/video/fbdev/sis/sis_main.c b/drivers/video/fbdev/sis/sis_main.c index 03c736f6f3d08..266a5582f94d3 100644 --- a/drivers/video/fbdev/sis/sis_main.c +++ b/drivers/video/fbdev/sis/sis_main.c @@ -5029,7 +5029,6 @@ static void sisfb_post_xgi_ddr2(struct sis_video_info *ivideo, u8 regb) static const u8 cs168[8] = { 0x48, 0x78, 0x88, 0x00, 0x00, 0x00, 0x00, 0x00 }; - u8 reg; u8 v1; u8 v2; u8 v3; @@ -5037,9 +5036,9 @@ static void sisfb_post_xgi_ddr2(struct sis_video_info *ivideo, u8 regb) SiS_SetReg(SISCR, 0xb0, 0x80); /* DDR2 dual frequency mode */ SiS_SetReg(SISCR, 0x82, 0x77); SiS_SetReg(SISCR, 0x86, 0x00); - reg = SiS_GetReg(SISCR, 0x86); + SiS_GetReg(SISCR, 0x86); SiS_SetReg(SISCR, 0x86, 0x88); - reg = SiS_GetReg(SISCR, 0x86); + SiS_GetReg(SISCR, 0x86); v1 = cs168[regb]; v2 = cs160[regb]; v3 = cs158[regb]; if (ivideo->haveXGIROM) { v1 = bios[regb + 0x168]; @@ -5049,9 +5048,9 @@ static void sisfb_post_xgi_ddr2(struct sis_video_info *ivideo, u8 regb) SiS_SetReg(SISCR, 0x86, v1); SiS_SetReg(SISCR, 0x82, 0x77); SiS_SetReg(SISCR, 0x85, 0x00); - reg = SiS_GetReg(SISCR, 0x85); + SiS_GetReg(SISCR, 0x85); SiS_SetReg(SISCR, 0x85, 0x88); - reg = SiS_GetReg(SISCR, 0x85); + SiS_GetReg(SISCR, 0x85); SiS_SetReg(SISCR, 0x85, v2); SiS_SetReg(SISCR, 0x82, v3); SiS_SetReg(SISCR, 0x98, 0x01); From patchwork Wed Jan 13 14:49:47 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 362409 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER, INCLUDES_PATCH, MAILING_LIST_MULTI, SPF_HELO_NONE, SPF_PASS, URIBL_BLOCKED, USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 90FE0C4332B for ; Wed, 13 Jan 2021 14:52:22 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 55AE823602 for ; Wed, 13 Jan 2021 14:52:22 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727560AbhAMOv6 (ORCPT ); Wed, 13 Jan 2021 09:51:58 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41838 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727534AbhAMOv5 (ORCPT ); Wed, 13 Jan 2021 09:51:57 -0500 Received: from mail-wr1-x42e.google.com (mail-wr1-x42e.google.com [IPv6:2a00:1450:4864:20::42e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5493FC0617BC for ; Wed, 13 Jan 2021 06:50:29 -0800 (PST) Received: by mail-wr1-x42e.google.com with SMTP id r7so2408351wrc.5 for ; Wed, 13 Jan 2021 06:50:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=9Pf7w6hja2pyQaiiphc9339t7wWdI+GqQadABJm8g7Y=; b=sst9frRzW/IJefwutBUvPoGyyHkMdmNCE2/2cJ1SvAob/HspH1X56uzjWNN7XPuilz wdKSM/9Hqj3XNtAA/hBuaE7G/g9i5BxwEMY6nf9eunFCXOpEAB+tkTQ53x6HPpg6jtJ5 4/CwTTvIH5eIMy9CUXAYqkwetX52U5C8J5iXu+ftxRcgI6ioB4TaWFUZokVU0jMRv4go iVThPqkc16K5jm14VkBnPxRc0KOF1l7502J6ctNsR0SVyVrAujPyJcOPpNmjUaQa0T2D QXsr/aNolpDchgMH7vINY63kaYmkDnVOFM9EKwvSgcfdyGaw5+y6o1AKmnSdmQwT2uZv +w6g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=9Pf7w6hja2pyQaiiphc9339t7wWdI+GqQadABJm8g7Y=; b=SePMincq7t0s4yKgT4+GuGTvRsprFIqZ7cn7pmKSreCUa5OBh8gJc7e8DO2jpaXw9m gOh3qoL+607U2Wk152/1ziq0ugXAEb3ztPgZmHNTEffXLWHT++Z9c1NWdI1I/THdTdLQ z1g39U6mbiFddXKzVZ6hYpMGjamnl9SC1NkcDD3zWqOMN3zK5mAnjwm7J3nUK7lX+X0u H7sCJ1gFGMZsy9jyVsf7fMH9kJBssl94LLMu1tpid8gzZGr59Dzv7idYO32hc7m3Unwe Wfjsgxynf2loGdzKWtwVl3BasALUD4gWUnLQsGFDcvHMr34JAZV4D9UVwd1qSHJpBGrt BxoA== X-Gm-Message-State: AOAM532hglk5UjE3If7/X+TMyuqdVpxUP+qwFLeuw8TDSyazpxaBVtqF 5QGQ5xMcWjJTAicMV4THGVkp2Q== X-Google-Smtp-Source: ABdhPJw7YBO0Y3mdZUBWXhnPmv13OWbKuieV4zDqiFanxqcxWiLlKLymFuWigA/Hr4jjfIkyPRZuxQ== X-Received: by 2002:adf:f58a:: with SMTP id f10mr3137113wro.338.1610549428139; Wed, 13 Jan 2021 06:50:28 -0800 (PST) Received: from dell.default ([91.110.221.229]) by smtp.gmail.com with ESMTPSA id t188sm3273433wmf.9.2021.01.13.06.50.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 13 Jan 2021 06:50:26 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, Thomas Winischhofer , dri-devel@lists.freedesktop.org, linux-fbdev@vger.kernel.org Subject: [PATCH 09/31] video: fbdev: sis: Remove superfluous include of 'init.h' Date: Wed, 13 Jan 2021 14:49:47 +0000 Message-Id: <20210113145009.1272040-10-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210113145009.1272040-1-lee.jones@linaro.org> References: <20210113145009.1272040-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-fbdev@vger.kernel.org Neither 'sis.h' nor any of its consumers uses these tables. Fixes the following W=1 kernel build warning(s): drivers/video/fbdev/sis/init.h:144:28: warning: ‘SiS_VGA_DAC’ defined but not used [-Wunused-const-variable=] drivers/video/fbdev/sis/init.h:132:28: warning: ‘SiS_EGA_DAC’ defined but not used [-Wunused-const-variable=] drivers/video/fbdev/sis/init.h:120:28: warning: ‘SiS_CGA_DAC’ defined but not used [-Wunused-const-variable=] drivers/video/fbdev/sis/init.h:108:28: warning: ‘SiS_MDA_DAC’ defined but not used [-Wunused-const-variable=] drivers/video/fbdev/sis/init.h:106:29: warning: ‘ModeIndex_310_2048x1536’ defined but not used [-Wunused-const-variable drivers/video/fbdev/sis/init.h:105:29: warning: ‘ModeIndex_300_2048x1536’ defined but not used [-Wunused-const-variable drivers/video/fbdev/sis/init.h:104:29: warning: ‘ModeIndex_1920x1440’ defined but not used [-Wunused-const-variable=] drivers/video/fbdev/sis/init.h:103:29: warning: ‘ModeIndex_1920x1080’ defined but not used [-Wunused-const-variable=] drivers/video/fbdev/sis/init.h:102:29: warning: ‘ModeIndex_1600x1200’ defined but not used [-Wunused-const-variable=] drivers/video/fbdev/sis/init.h:101:29: warning: ‘ModeIndex_1680x1050’ defined but not used [-Wunused-const-variable=] drivers/video/fbdev/sis/init.h:100:29: warning: ‘ModeIndex_1400x1050’ defined but not used [-Wunused-const-variable=] NB: Snipped - there are 277 of these! Cc: Thomas Winischhofer Cc: dri-devel@lists.freedesktop.org Cc: linux-fbdev@vger.kernel.org Signed-off-by: Lee Jones --- drivers/video/fbdev/sis/sis.h | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/video/fbdev/sis/sis.h b/drivers/video/fbdev/sis/sis.h index 9f4c3093ccb36..d632f096083b3 100644 --- a/drivers/video/fbdev/sis/sis.h +++ b/drivers/video/fbdev/sis/sis.h @@ -15,7 +15,6 @@ #include "vgatypes.h" #include "vstruct.h" -#include "init.h" #define VER_MAJOR 1 #define VER_MINOR 8 From patchwork Wed Jan 13 14:49:53 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 362404 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER, INCLUDES_PATCH, MAILING_LIST_MULTI, SPF_HELO_NONE, SPF_PASS, URIBL_BLOCKED, USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A6F19C43331 for ; Wed, 13 Jan 2021 14:53:12 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 751E623741 for ; Wed, 13 Jan 2021 14:53:12 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727170AbhAMOw7 (ORCPT ); Wed, 13 Jan 2021 09:52:59 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41922 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727703AbhAMOwR (ORCPT ); Wed, 13 Jan 2021 09:52:17 -0500 Received: from mail-wm1-x332.google.com (mail-wm1-x332.google.com [IPv6:2a00:1450:4864:20::332]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B26C3C061389 for ; Wed, 13 Jan 2021 06:50:38 -0800 (PST) Received: by mail-wm1-x332.google.com with SMTP id h17so1654487wmq.1 for ; Wed, 13 Jan 2021 06:50:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=GZEx6Psm5kmVFzQRuV4hKShFUTuX59E1ZZSqS64lTO4=; b=qCaU5/PwjTYjtfnriB60Z9oLOr+vFl/C6eE9S2SqWRzje404GBkmpQhafug/AkVxOy cQQpoF2TPpvHLZ2G0WwI0m9I3+iSy5mECHxCRPxdVQEqbEaiQAKEQ21H2Puw7RerAiVE wFP15HZbbxQs2PH85CQiCco+76nv2mFTwq9YLxfrDpX1dbHfhcDj5xFdWbHJisbQiGp9 gXFKfd2QUbQryXwNq3Wq2jJyOgsjiru7oncOJDfA+X11+HkluVlV1zwafJGTb/u8E2G8 MRaYmLZI/XB7G9OUxyfbsMCiS30QwhZAVeTDBJWC+SfdIRLhSlZ+MEl7DCFddFc+gJo3 s87Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=GZEx6Psm5kmVFzQRuV4hKShFUTuX59E1ZZSqS64lTO4=; b=gRYM7eAz28xkGAhyo10bKZWg7TeNPTT6mv/zQCmztXOennS6nAN5g3tYswmBG0CYAp F/yqMvvhX+d6YrtWWJCDTt0OQgcKCtwAyi/+KadU+oS4fXtVWtPdc1oMHzhfOHcHFlXI YyiCvSUd/yN4KmwFs7+RsSaPpUoKA1/G3u+EG2XR2xSsvuyW2UUIqYMKKN7KUQq33JbE hjd5guuHkN3J8KFyt7Ly3upVQZIthwZNJlQecLLlaI3as4DNrWghkioCrNuku5Cbs/1C pfWOofyPmymvd45oQqEKbMkHH5ldA4O+RpBVVbXVQzg3OnLEaHtqApiH0DCUG5KmwdFa YARQ== X-Gm-Message-State: AOAM532A70Saha3NfSdRnIgt+UD26kvktWwv8KuxKdbkNjFsCO0e4dC3 vIsDKAOlEVDYg91IZy2LVbN08Q== X-Google-Smtp-Source: ABdhPJzXGlHjQWCGWlwH0MsHBEeXn1e8tUGwLxoT/K65Pbdak+HaHN+93bMx8dcQNJlERhqlDPiH6w== X-Received: by 2002:a1c:40d6:: with SMTP id n205mr2609520wma.0.1610549437515; Wed, 13 Jan 2021 06:50:37 -0800 (PST) Received: from dell.default ([91.110.221.229]) by smtp.gmail.com with ESMTPSA id t188sm3273433wmf.9.2021.01.13.06.50.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 13 Jan 2021 06:50:36 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, Florian Tobias Schandinat , linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org Subject: [PATCH 15/31] video: fbdev: via: lcd: Remove unused variable 'mode_crt_table' Date: Wed, 13 Jan 2021 14:49:53 +0000 Message-Id: <20210113145009.1272040-16-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210113145009.1272040-1-lee.jones@linaro.org> References: <20210113145009.1272040-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-fbdev@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/video/fbdev/via/lcd.c: In function ‘viafb_lcd_set_mode’: drivers/video/fbdev/via/lcd.c:540:29: warning: variable ‘mode_crt_table’ set but not used [-Wunused-but-set-variable] Cc: Florian Tobias Schandinat Cc: linux-fbdev@vger.kernel.org Cc: dri-devel@lists.freedesktop.org Signed-off-by: Lee Jones --- drivers/video/fbdev/via/lcd.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/video/fbdev/via/lcd.c b/drivers/video/fbdev/via/lcd.c index 4a869402d120d..088b962076b51 100644 --- a/drivers/video/fbdev/via/lcd.c +++ b/drivers/video/fbdev/via/lcd.c @@ -537,11 +537,9 @@ void viafb_lcd_set_mode(const struct fb_var_screeninfo *var, u16 cxres, u32 clock; struct via_display_timing timing; struct fb_var_screeninfo panel_var; - const struct fb_videomode *mode_crt_table, *panel_crt_table; + const struct fb_videomode *panel_crt_table; DEBUG_MSG(KERN_INFO "viafb_lcd_set_mode!!\n"); - /* Get mode table */ - mode_crt_table = viafb_get_best_mode(set_hres, set_vres, 60); /* Get panel table Pointer */ panel_crt_table = viafb_get_best_mode(panel_hres, panel_vres, 60); viafb_fill_var_timing_info(&panel_var, panel_crt_table); From patchwork Wed Jan 13 14:49:54 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 362407 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER, INCLUDES_PATCH, MAILING_LIST_MULTI, SPF_HELO_NONE, SPF_PASS, URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 73085C43333 for ; Wed, 13 Jan 2021 14:52:23 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 4130A235FF for ; Wed, 13 Jan 2021 14:52:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727633AbhAMOwS (ORCPT ); Wed, 13 Jan 2021 09:52:18 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41924 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727706AbhAMOwR (ORCPT ); Wed, 13 Jan 2021 09:52:17 -0500 Received: from mail-wm1-x336.google.com (mail-wm1-x336.google.com [IPv6:2a00:1450:4864:20::336]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D6FB2C06138B for ; Wed, 13 Jan 2021 06:50:39 -0800 (PST) Received: by mail-wm1-x336.google.com with SMTP id y23so1857553wmi.1 for ; Wed, 13 Jan 2021 06:50:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=DB5ZhlcS73D7+78VKV5C4ED9gkOhY09FF/WaEagoeZU=; b=AONsu4c49jYlWKZxIV71Fh+XZdaNm/Vzg4dgCbN9JbxTF4zXdk0hxy5yUAjRqlY1Xp nIupPjhqoIDmU9VkNJPtK0bN3YDe0f2AqkiUUwaqnLI5f/UzmCGOhingAiMylna4SnJ7 hLXn2MQXPU6i1MKuVELPGT8kK+K/FZOJI4dUhj0jPoBZq2Enr9vntVzkeQDu+4qMmsGJ v9PLkQKSiH7g77yfRhELqhLTHFPLU2Zj+6aaz97t1aI4q7b6mzr8jI36fIERyEk5M18O pFAOSj+Sqvp1t7uHTA6T4HOtbxb08KOCHlGCDgPp2Qf5TW3Vp2vXs9ztiYrfKzPx/xqZ 1DRw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=DB5ZhlcS73D7+78VKV5C4ED9gkOhY09FF/WaEagoeZU=; b=o3+RqW+3T6266f5F66TCCpUSH7q2KEGeJBEZwcnj/LNnNRl0ZtCsmNpI7uUIPNOM2l Hd6bfofnTG35VRZOg7tgNgqqg5cO53UuIkKgM3VolAYq+VfHysmFZvJKBtYjpLjhzjch s62f71bEfGMM9fWIasvuJKUcEZS4DxuYmAy/PYBA1OLNyzz+oJrW+u89nFKMMyXf+nzc rR3wOeB3ZS7CZUgbQy49/6tzpDtR0xzORK+/FvK3sj96YVlVxeID9+s13geWo6lRBFQN T09cjbKyakjYHbQ4uquM6oS35SM3wYbvzSoiJD18Odjr0z4zt6OFSbiVcJ5NpIKb1wJG DrtQ== X-Gm-Message-State: AOAM532C4AFzNxZLkUy5hLUjEL01bCHKyz8dcw3ALRP1Oojm20tXqlkl Ot0XU6IfC4+5/9W06JZirguRew== X-Google-Smtp-Source: ABdhPJwgYTdZ2SuZ1GC/GjtSB8bSmqwzQcGAszf80Fej8Y4hpcF1LKJ1kwg1EITnZXMFsMy/JoGVCg== X-Received: by 2002:a1c:4843:: with SMTP id v64mr2570638wma.186.1610549438672; Wed, 13 Jan 2021 06:50:38 -0800 (PST) Received: from dell.default ([91.110.221.229]) by smtp.gmail.com with ESMTPSA id t188sm3273433wmf.9.2021.01.13.06.50.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 13 Jan 2021 06:50:38 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, "Gustavo A. R. Silva" , Jim Hague , Ilario Nardinocchi , Jakub Jelinek , dri-devel@lists.freedesktop.org, linux-fbdev@vger.kernel.org Subject: [PATCH 16/31] video: fbdev: pm2fb: Fix some kernel-doc formatting issues Date: Wed, 13 Jan 2021 14:49:54 +0000 Message-Id: <20210113145009.1272040-17-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210113145009.1272040-1-lee.jones@linaro.org> References: <20210113145009.1272040-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-fbdev@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/video/fbdev/pm2fb.c:1515: warning: Function parameter or member 'pdev' not described in 'pm2fb_probe' drivers/video/fbdev/pm2fb.c:1515: warning: Function parameter or member 'id' not described in 'pm2fb_probe' drivers/video/fbdev/pm2fb.c:1721: warning: Function parameter or member 'pdev' not described in 'pm2fb_remove' drivers/video/fbdev/pm2fb.c:1765: warning: Function parameter or member 'options' not described in 'pm2fb_setup' Cc: "Gustavo A. R. Silva" Cc: Jim Hague Cc: Ilario Nardinocchi Cc: Jakub Jelinek Cc: dri-devel@lists.freedesktop.org Cc: linux-fbdev@vger.kernel.org Signed-off-by: Lee Jones --- drivers/video/fbdev/pm2fb.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/video/fbdev/pm2fb.c b/drivers/video/fbdev/pm2fb.c index 27893fa139b08..6a30096676374 100644 --- a/drivers/video/fbdev/pm2fb.c +++ b/drivers/video/fbdev/pm2fb.c @@ -1504,12 +1504,12 @@ static const struct fb_ops pm2fb_ops = { /** - * Device initialisation + * pm2fb_probe - Device initialisation * * Initialise and allocate resource for PCI device. * - * @param pdev PCI device. - * @param id PCI device ID. + * @pdev: PCI device. + * @id: PCI device ID. */ static int pm2fb_probe(struct pci_dev *pdev, const struct pci_device_id *id) { @@ -1711,11 +1711,11 @@ static int pm2fb_probe(struct pci_dev *pdev, const struct pci_device_id *id) } /** - * Device removal. + * pm2fb_remove - Device removal. * * Release all device resources. * - * @param pdev PCI device to clean up. + * @pdev: PCI device to clean up. */ static void pm2fb_remove(struct pci_dev *pdev) { @@ -1756,7 +1756,7 @@ MODULE_DEVICE_TABLE(pci, pm2fb_id_table); #ifndef MODULE -/** +/* * Parse user specified options. * * This is, comma-separated options following `video=pm2fb:'. From patchwork Wed Jan 13 14:49:55 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 362401 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER, INCLUDES_PATCH, MAILING_LIST_MULTI, SPF_HELO_NONE, SPF_PASS, URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 83B57C43331 for ; Wed, 13 Jan 2021 14:54:03 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 4A107236F9 for ; Wed, 13 Jan 2021 14:54:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727943AbhAMOyA (ORCPT ); Wed, 13 Jan 2021 09:54:00 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41692 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727487AbhAMOvw (ORCPT ); Wed, 13 Jan 2021 09:51:52 -0500 Received: from mail-wm1-x331.google.com (mail-wm1-x331.google.com [IPv6:2a00:1450:4864:20::331]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0BEBEC06138E for ; Wed, 13 Jan 2021 06:50:41 -0800 (PST) Received: by mail-wm1-x331.google.com with SMTP id c124so1837584wma.5 for ; Wed, 13 Jan 2021 06:50:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=fDDpX4Tq8YbOoBzLmaAPLoJ0FkV3kIft9xiJt5MwHsk=; b=P/TckwyC+Zpm96Xw3jhnQcTPN4yEDByRSGHhaDy4FTUtGMu06Iu1Lz1wyjqkxnYGD8 Ka0UeFrgp+iGG7nEK9sOqDisiaFpLSK1hp1DISbHIQX8TDn4GphpHRUfABx50dTEboH0 qeaFWlT7UN/Vu7aoSNXpYCaMFlK+DfSHuhMJjBshrb8gKl2yGkzp7JIUWGPZphFnEfly 608DGRjP7K/CPR0c/OxOSedMrPcUuDd1OSXearvHBAU6PUJXtpFKR1uPWbedCfsb9D0l VZxN7mXIKLzNxEZYF8QgplqX7VbOWBfbEy/IEpStDEkkgxcfNRAH9CcHckNWX7BTHpf7 EMTA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=fDDpX4Tq8YbOoBzLmaAPLoJ0FkV3kIft9xiJt5MwHsk=; b=WCwPZHXk5C9IxYQIM0SwT+7QpmlFmdg+5cw5pYv1HuuORZwOmJ4FR05gQCImVAUQUF EtmkDfF48E5m9uEVXNAVaGFC2OS9kofvgjpgzbNy0KksAS14wTVHdA3Cqp6FHeu+R6V5 s2n3yAxdO0FHqIUGeN1tUG8+3weda1MU7esvpIV3TgatlWONhDR4ChjaPoS//RgEunDi LB+LaELyR8iboxwT5+KEIR8pNJ/vFkIxKgraWfpS6Y+1K8RMnd1sJz185n11qrt6qLc9 PRHtdq49Vso0TPAfA4svWpt6TU96TehMgtOYYYJP7Ir4ZV0quuA4iOjXkL3AMEbreTLB mo0A== X-Gm-Message-State: AOAM532xpLmq2z1vDgMAAIlnMjetRdtqVLVoYmFwEHUePzrgCN7kIalF folXql+nLArzcP+xBjCAYDvUOw== X-Google-Smtp-Source: ABdhPJzYqXQr0JAQFjeee0qoDpAYIIkOJfbnlgTUbeOjt6+QKL+q1AvPdGMRRUWutIMa4sTg1X4bsA== X-Received: by 2002:a1c:a5d8:: with SMTP id o207mr2598878wme.30.1610549439832; Wed, 13 Jan 2021 06:50:39 -0800 (PST) Received: from dell.default ([91.110.221.229]) by smtp.gmail.com with ESMTPSA id t188sm3273433wmf.9.2021.01.13.06.50.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 13 Jan 2021 06:50:39 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, Benjamin Herrenschmidt , linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org Subject: [PATCH 17/31] video: fbdev: aty: radeon_monitor: Remove unused variable 'mon_types' Date: Wed, 13 Jan 2021 14:49:55 +0000 Message-Id: <20210113145009.1272040-18-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210113145009.1272040-1-lee.jones@linaro.org> References: <20210113145009.1272040-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-fbdev@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/video/fbdev/aty/radeon_monitor.c: In function ‘radeon_probe_screens’: drivers/video/fbdev/aty/radeon_monitor.c:491:8: warning: variable ‘mon_types’ set but not used [-Wunused-but-set-variable] Cc: Benjamin Herrenschmidt Cc: linux-fbdev@vger.kernel.org Cc: dri-devel@lists.freedesktop.org Signed-off-by: Lee Jones --- drivers/video/fbdev/aty/radeon_monitor.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/video/fbdev/aty/radeon_monitor.c b/drivers/video/fbdev/aty/radeon_monitor.c index 9966c58aa26cd..5ff01aa389381 100644 --- a/drivers/video/fbdev/aty/radeon_monitor.c +++ b/drivers/video/fbdev/aty/radeon_monitor.c @@ -488,12 +488,10 @@ void radeon_probe_screens(struct radeonfb_info *rinfo, #if defined(DEBUG) && defined(CONFIG_FB_RADEON_I2C) { u8 *EDIDs[4] = { NULL, NULL, NULL, NULL }; - int mon_types[4] = {MT_NONE, MT_NONE, MT_NONE, MT_NONE}; int i; for (i = 0; i < 4; i++) - mon_types[i] = radeon_probe_i2c_connector(rinfo, - i+1, &EDIDs[i]); + radeon_probe_i2c_connector(rinfo, i+1, &EDIDs[i]); } #endif /* DEBUG */ /* From patchwork Wed Jan 13 14:49:57 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 362138 Delivered-To: patch@linaro.org Received: by 2002:a02:ccad:0:0:0:0:0 with SMTP id t13csp599712jap; Wed, 13 Jan 2021 06:52:43 -0800 (PST) X-Google-Smtp-Source: ABdhPJxDUkcIfB3rwikKRBcU22YluA0bPxYlBE1XbEhlorMVWkfJupvLIFfmD7++XHwcdzEHWOxu X-Received: by 2002:a17:907:d8d:: with SMTP id go13mr1805942ejc.520.1610549563076; Wed, 13 Jan 2021 06:52:43 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1610549563; cv=none; d=google.com; s=arc-20160816; b=c3eM1CDHiI/MQ6mlkDJGubo2E0piQfQ6gBPGoQU3o3TzTVEefqZcQG3mFD+pFYPz/A QWHEzqT0Sd/EY5mm9+tDnYTMYrtMeKKDnLXNqUJWHUurq9Zv/HtlwKfxPGmCQOhiwuTl TphycOoByTP3r31VDQP1b2ZomELUqska5o8ezM01vgQ3ZaYL3QSksF7JXXAMvNBDjJq3 CNEWi2GlUk9UTJlIUKgprvDkL0pH4wrd45PzfRwMm7xkL34eH/itDOPYnwOsTVCt/RLs MclvuzflRsfDC0ZCKesrxbqJCm3xYtwzOT9VNSZDcZ9+80Ad9VTvvUyBY8lZdVBbgZvs +ROQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=ZRcivOWCu86KtmbW2EK6Np9SsvS7JZY4Xqa/qkwVtkE=; b=VTfG4kwBzo9NZtE8JYjFXztO5whViNulFRbo7uOtZqx4MkAvZd2RCK7IiNA+BDCHS1 yTJOFfV05gf4H3vDEFj7fCJTGlEYJQEi5DgBZ+gapdVucLS7Hp5GKXUKJR1OEWZDKMez ++FePnLWb4u2L9Qqw7enBfC6aaSKz/7SzRS1QfahRy3bNM/85sO/m9+P9Z/BUCfn0Ha8 qb2iP+lJCwN/kbzXrCrER80xfZdqYYGsAXi8k1w0v+AjAZlYoS+rsIpCqyL3LFXPlFel yq/gSROPDjwEGdCPR/Olv0od0SPsJej9oqLOz9hDkgDIZufnM5EnKqYddEYvsO+Ylb9K sBiw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=t1ER4nwN; spf=pass (google.com: domain of linux-fbdev-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-fbdev-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id v19si1086582eds.239.2021.01.13.06.52.42 for ; Wed, 13 Jan 2021 06:52:43 -0800 (PST) Received-SPF: pass (google.com: domain of linux-fbdev-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=t1ER4nwN; spf=pass (google.com: domain of linux-fbdev-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-fbdev-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727424AbhAMOvy (ORCPT ); Wed, 13 Jan 2021 09:51:54 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41760 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727494AbhAMOvx (ORCPT ); Wed, 13 Jan 2021 09:51:53 -0500 Received: from mail-wr1-x435.google.com (mail-wr1-x435.google.com [IPv6:2a00:1450:4864:20::435]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 59FACC061342 for ; Wed, 13 Jan 2021 06:50:43 -0800 (PST) Received: by mail-wr1-x435.google.com with SMTP id t30so2435605wrb.0 for ; Wed, 13 Jan 2021 06:50:43 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=ZRcivOWCu86KtmbW2EK6Np9SsvS7JZY4Xqa/qkwVtkE=; b=t1ER4nwN/WPM6fNnm/Mdum0Pojlr01P78z/COYqJ1z5HyIHjWoDRfik8SQHtBQqxQK YmiySxijr8E0W29ccNGw29mWFYTILvz8yqxd4Jhjz4xgCEkubT+0KFcPLzD/bqSuhqOv bwbne25dLdz4tncYRuqLl24YT+dNFgIwqI2SBJY9J4cgkiSXbIrT5qKhC9+mgB4yvQc0 udbu5Cayvxz6NRQyXKyHcIRbULqdBiGQkpmclevO2khhsi+G7TZ0owLOrYnOEnlNsCCt PsWXGjmGYEWJlNT1uNBNNRB3QkWWj1iQNibwkHhjoWky2+41zMmhl3Ve1ioMsvWRW5MO 3aKQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=ZRcivOWCu86KtmbW2EK6Np9SsvS7JZY4Xqa/qkwVtkE=; b=SBbbOuTNvBE7pw9yR77hAMlWZy/+Yt3gXP9F9vrM58iNMC+wTk1y9uqRxTZmTShZeY ICSrfAWdzyXm80335xIs+7UDSozgkSkOVS2lsQCJ3hnqyCXfEqiMBejF4qCIq+OKwQY7 z1NrjnxRvZPL/pCvoS7QbNvAqxMDLuClbzKB+pEZ7aryOuaVe82LIB+O9wHRNZW27HCw UtHabtpn1hCwQ2Fi5WIofUK6CX59sf3Ot8DsTGZudghNw8RurzLP5KuQpOmKDAYxs1Hj 5lCWHUi7W4oefloUqd1a/ye8Vi5HRWQc7gTaJMJdbBGT1PGB0U6XBFtmR1hWiKHvw+Nh YmZQ== X-Gm-Message-State: AOAM533flWwt2V1Lj9M5cCyThDBtf1h7GVuJzaPmoMfGkhfLmEN0vO4D 92XNNF342FFyEwrTIfXNcH4NpQ== X-Received: by 2002:a5d:530c:: with SMTP id e12mr3033393wrv.54.1610549442170; Wed, 13 Jan 2021 06:50:42 -0800 (PST) Received: from dell.default ([91.110.221.229]) by smtp.gmail.com with ESMTPSA id t188sm3273433wmf.9.2021.01.13.06.50.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 13 Jan 2021 06:50:41 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, "Gustavo A. R. Silva" , Hannu Mallat , Frodo Looijaard , Philip Edelbrock , Ralph Metzler , "Mark D. Studebaker" , dri-devel@lists.freedesktop.org, linux-fbdev@vger.kernel.org Subject: [PATCH 19/31] video: fbdev: tdfxfb: Remove unused variable 'tmp' Date: Wed, 13 Jan 2021 14:49:57 +0000 Message-Id: <20210113145009.1272040-20-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210113145009.1272040-1-lee.jones@linaro.org> References: <20210113145009.1272040-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-fbdev@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/video/fbdev/tdfxfb.c: In function ‘att_outb’: drivers/video/fbdev/tdfxfb.c:209:16: warning: variable ‘tmp’ set but not used [-Wunused-but-set-variable] Cc: "Gustavo A. R. Silva" Cc: Hannu Mallat Cc: Frodo Looijaard Cc: Philip Edelbrock Cc: Ralph Metzler Cc: "Mark D. Studebaker" Cc: dri-devel@lists.freedesktop.org Cc: linux-fbdev@vger.kernel.org Signed-off-by: Lee Jones --- drivers/video/fbdev/tdfxfb.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) -- 2.25.1 diff --git a/drivers/video/fbdev/tdfxfb.c b/drivers/video/fbdev/tdfxfb.c index f056d80f6359f..67e37a62b07c3 100644 --- a/drivers/video/fbdev/tdfxfb.c +++ b/drivers/video/fbdev/tdfxfb.c @@ -206,9 +206,7 @@ static inline u8 crt_inb(struct tdfx_par *par, u32 idx) static inline void att_outb(struct tdfx_par *par, u32 idx, u8 val) { - unsigned char tmp; - - tmp = vga_inb(par, IS1_R); + vga_inb(par, IS1_R); vga_outb(par, ATT_IW, idx); vga_outb(par, ATT_IW, val); } From patchwork Wed Jan 13 14:49:59 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 362410 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER, INCLUDES_PATCH, MAILING_LIST_MULTI, SPF_HELO_NONE, SPF_PASS, URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 67B2EC43381 for ; Wed, 13 Jan 2021 14:52:22 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 2C56A23600 for ; Wed, 13 Jan 2021 14:52:22 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727624AbhAMOwE (ORCPT ); Wed, 13 Jan 2021 09:52:04 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41624 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727633AbhAMOwD (ORCPT ); Wed, 13 Jan 2021 09:52:03 -0500 Received: from mail-wr1-x433.google.com (mail-wr1-x433.google.com [IPv6:2a00:1450:4864:20::433]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C02F6C061346 for ; Wed, 13 Jan 2021 06:50:45 -0800 (PST) Received: by mail-wr1-x433.google.com with SMTP id d13so2384811wrc.13 for ; Wed, 13 Jan 2021 06:50:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=kdRuSJvii4mKY/Efrp+W2ecV3k/kYMixGrJ5X2aYPPE=; b=h7CCOaMRu/KwDp4FkMru0iAXzhcqDT8Zgx3TFkmqeQ+lFmQabkd31QQ+lufeDRUy3X LtVPTgu8/Zqp1FSR8BAvO7dZtJzfFJCxlVtW1Nocwnb68P37FSE+be5cVVaNK5Tt8JCU 9w0Ph8RfNh92LMTOPQay3rdqNK2k+J9YHe1s4Pc7Cfwul+RTcoi4Ud5EHifbnQv/CgAl HXLZdEt7o50147fxcADWLOPX90H4PF4f7epdHBvT72f7b/PpYAha9w6yexNN/IIcz2uN fnQb+ZapvvgV5yFNpXtWjyjgqG+ixxGtM9qn4DjB5lbBlmDCcef1Kbvt5M9KefOQMbJJ FfRw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=kdRuSJvii4mKY/Efrp+W2ecV3k/kYMixGrJ5X2aYPPE=; b=iULB/bH9bezFpMhZJmQHjbAJn887M5GfW+iYDKzEzI5jkTjVJWg7KZL9s1G8Z5yZO8 Zlyu6WjtHge3tD6r8bFMQwzz+/vqbw+PSlwCVdswhKltX1zgr2RoWzacsqzHOIuIundb VTtKoYi8WoXhB5Vm9zArZcwAv1bght96RvFYyE8iJW50zALR94CuUCeT48bEl56AavZF hZzsOa5FhNGUEIQwutZPFBPJDMOkWQDanO/sg27MibmgdmP8hupDgYBAgyYe+I7eWKvY p2qHSwIPqDkPqhjH4e8WZXL/cAAM4ihkAZ5pv2RBqTuzGj2lV69SGPqNvfex7uGHLDJz YRuw== X-Gm-Message-State: AOAM5312tHNcJjHRK6Ppo/UdLFts0e8kWnhPKXj8wcFXLFNQY6mNOE7N W5726+/OhFrP/ruqO8J4tbnPeg== X-Google-Smtp-Source: ABdhPJyuIlFTIENDUMPlw5lomJPJtWMdNwJG+DPzaqlFIAPWPUczY5LQd4LCs7FSNVgCvZWujNH+Hw== X-Received: by 2002:a05:6000:108b:: with SMTP id y11mr2937092wrw.379.1610549444578; Wed, 13 Jan 2021 06:50:44 -0800 (PST) Received: from dell.default ([91.110.221.229]) by smtp.gmail.com with ESMTPSA id t188sm3273433wmf.9.2021.01.13.06.50.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 13 Jan 2021 06:50:43 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, Alex Dewar , Bartlomiej Zolnierkiewicz , Ghozlane Toumi , James Simmons , Paul Mundt , Urs Ganse , Helge Deller , Alan Cox , dri-devel@lists.freedesktop.org, linux-fbdev@vger.kernel.org Subject: [PATCH 21/31] video: fbdev: sstfb: Mark 3 debug variables as __maybe_unused Date: Wed, 13 Jan 2021 14:49:59 +0000 Message-Id: <20210113145009.1272040-22-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210113145009.1272040-1-lee.jones@linaro.org> References: <20210113145009.1272040-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-fbdev@vger.kernel.org These are only used if SST_DEBUG_FUNC is set. Declare them under the same clause as their use. Fixes the following W=1 kernel build warning(s): drivers/video/fbdev/sstfb.c: In function ‘sst_detect_ics’: drivers/video/fbdev/sstfb.c:934:26: warning: variable ‘n_clk1_b’ set but not used [-Wunused-but-set-variable] drivers/video/fbdev/sstfb.c:934:16: warning: variable ‘n_clk0_7’ set but not used [-Wunused-but-set-variable] drivers/video/fbdev/sstfb.c:934:6: warning: variable ‘n_clk0_1’ set but not used [-Wunused-but-set-variable] Cc: Alex Dewar Cc: Bartlomiej Zolnierkiewicz Cc: Ghozlane Toumi Cc: James Simmons Cc: Paul Mundt Cc: Urs Ganse Cc: Helge Deller Cc: Alan Cox Cc: dri-devel@lists.freedesktop.org Cc: linux-fbdev@vger.kernel.org Signed-off-by: Lee Jones --- drivers/video/fbdev/sstfb.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/video/fbdev/sstfb.c b/drivers/video/fbdev/sstfb.c index c05cdabeb11c2..b8813a0b63b1d 100644 --- a/drivers/video/fbdev/sstfb.c +++ b/drivers/video/fbdev/sstfb.c @@ -931,7 +931,7 @@ static int sst_detect_ics(struct fb_info *info) { struct sstfb_par *par = info->par; int m_clk0_1, m_clk0_7, m_clk1_b; - int n_clk0_1, n_clk0_7, n_clk1_b; + int __maybe_unused n_clk0_1, __maybe_unused n_clk0_7, __maybe_unused n_clk1_b; int i; for (i = 0; i<5; i++ ) { From patchwork Wed Jan 13 14:50:00 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 362402 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER, INCLUDES_PATCH, MAILING_LIST_MULTI, SPF_HELO_NONE, SPF_PASS, URIBL_BLOCKED, USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 34870C433DB for ; Wed, 13 Jan 2021 14:53:36 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 066B8235FF for ; Wed, 13 Jan 2021 14:53:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727652AbhAMOwJ (ORCPT ); Wed, 13 Jan 2021 09:52:09 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41754 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727630AbhAMOwI (ORCPT ); Wed, 13 Jan 2021 09:52:08 -0500 Received: from mail-wr1-x433.google.com (mail-wr1-x433.google.com [IPv6:2a00:1450:4864:20::433]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id F2E5CC061349 for ; Wed, 13 Jan 2021 06:50:46 -0800 (PST) Received: by mail-wr1-x433.google.com with SMTP id q18so2432036wrn.1 for ; Wed, 13 Jan 2021 06:50:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=GoUfRt23bqbKPl1TGglCjWozG44qym29OpcwnZGK6kU=; b=DVx9RGOhwl5u8ldZy5VrfBB5nqUBSa6oCbOAtc/naAE4if9nM+qG1VzCKee+LVG+3B pYMHjLmmVhejEEkmBIU3VqOIbS0QbervpRSbvt8RbrJ65WI6sdAQJIFHQBuqYquGY9sm C0BoNNBF1vlcU19yuj0aroZuKk5XVtUWIzVX0dv3Fl5+wU5eXqndsETD1SuasAlFPapO Ndex26m6UwPr44hJ1bIN/A68qcXyyjbFTxYEWrG/wLv+f8ePNT5PGN0tbNcfIJ6tyYVQ 66n2l1NmCju3l+XV3FxP/N8a/cWJvm9uSD3UZcReTj1OIqHd9zRtoKkjQOixv9hbaPDF TjNw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=GoUfRt23bqbKPl1TGglCjWozG44qym29OpcwnZGK6kU=; b=NWUMPBGrY75PIccMdoPaOzAje+mUFOq+V5pD7b3GEIZaJjee1ycvLzofFH5wEOuBQ3 igzxUd3d88WIwIZOkEKo845mtc+bCKIehS9Hsuk+7RYF9SIBTCj01fdFy0I6ZUCbF/RN M5Xx+Peg3R2r21d49MhLr31zg2fdC8FPOnnC7ySpCcugLTAfpZFyfW+NTMq07drO5v5x r8JHhxTPxW/hNTHZ6WF1I0F3bIzJBQ8qPoG3hKmhVSP7cO9vBZ+zsCoJM2FhY16Cynmi 5zhQpOypBvY8r7P+wq2EvFTA3VZ+fBME/qKqwcFRcB2PXq0a9J77JqTxRRUJ9kFAzXsx SjHQ== X-Gm-Message-State: AOAM532jFuEOUO5q0vQDHbeljtPdnJ4uS03E5JCz/FuqCqjmpt+9Pxcx ib6sjbi+UY/Nb643kFV4N7Rdsw== X-Google-Smtp-Source: ABdhPJzAZpIkSU3ZuxYWodWKq2E4apdvM/gowpmYALF9g0lHHwu0yWyxlERCrNd/IkX0NEsPk4cbEg== X-Received: by 2002:a5d:6852:: with SMTP id o18mr2897319wrw.371.1610549445789; Wed, 13 Jan 2021 06:50:45 -0800 (PST) Received: from dell.default ([91.110.221.229]) by smtp.gmail.com with ESMTPSA id t188sm3273433wmf.9.2021.01.13.06.50.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 13 Jan 2021 06:50:45 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, Jeff Garzik , dri-devel@lists.freedesktop.org, linux-fbdev@vger.kernel.org Subject: [PATCH 22/31] video: fbdev: cirrusfb: Remove unused variable 'dummy' from 'WHDR()' Date: Wed, 13 Jan 2021 14:50:00 +0000 Message-Id: <20210113145009.1272040-23-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210113145009.1272040-1-lee.jones@linaro.org> References: <20210113145009.1272040-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-fbdev@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/video/fbdev/cirrusfb.c: In function ‘WHDR’: drivers/video/fbdev/cirrusfb.c:2466:16: warning: variable ‘dummy’ set but not used [-Wunused-but-set-variable] Cc: Jeff Garzik Cc: dri-devel@lists.freedesktop.org Cc: linux-fbdev@vger.kernel.org Signed-off-by: Lee Jones --- drivers/video/fbdev/cirrusfb.c | 14 ++++++-------- 1 file changed, 6 insertions(+), 8 deletions(-) diff --git a/drivers/video/fbdev/cirrusfb.c b/drivers/video/fbdev/cirrusfb.c index e9027172c0f55..f05160fa34da9 100644 --- a/drivers/video/fbdev/cirrusfb.c +++ b/drivers/video/fbdev/cirrusfb.c @@ -2463,8 +2463,6 @@ static void AttrOn(const struct cirrusfb_info *cinfo) */ static void WHDR(const struct cirrusfb_info *cinfo, unsigned char val) { - unsigned char dummy; - if (is_laguna(cinfo)) return; if (cinfo->btype == BT_PICASSO) { @@ -2473,18 +2471,18 @@ static void WHDR(const struct cirrusfb_info *cinfo, unsigned char val) WGen(cinfo, VGA_PEL_MSK, 0x00); udelay(200); /* next read dummy from pixel address (3c8) */ - dummy = RGen(cinfo, VGA_PEL_IW); + RGen(cinfo, VGA_PEL_IW); udelay(200); } /* now do the usual stuff to access the HDR */ - dummy = RGen(cinfo, VGA_PEL_MSK); + RGen(cinfo, VGA_PEL_MSK); udelay(200); - dummy = RGen(cinfo, VGA_PEL_MSK); + RGen(cinfo, VGA_PEL_MSK); udelay(200); - dummy = RGen(cinfo, VGA_PEL_MSK); + RGen(cinfo, VGA_PEL_MSK); udelay(200); - dummy = RGen(cinfo, VGA_PEL_MSK); + RGen(cinfo, VGA_PEL_MSK); udelay(200); WGen(cinfo, VGA_PEL_MSK, val); @@ -2492,7 +2490,7 @@ static void WHDR(const struct cirrusfb_info *cinfo, unsigned char val) if (cinfo->btype == BT_PICASSO) { /* now first reset HDR access counter */ - dummy = RGen(cinfo, VGA_PEL_IW); + RGen(cinfo, VGA_PEL_IW); udelay(200); /* and at the end, restore the mask value */ From patchwork Wed Jan 13 14:50:02 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 362408 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER, INCLUDES_PATCH, MAILING_LIST_MULTI, SPF_HELO_NONE, SPF_PASS, URIBL_BLOCKED, USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EA666C43331 for ; Wed, 13 Jan 2021 14:52:22 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id AB45223600 for ; Wed, 13 Jan 2021 14:52:22 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727634AbhAMOwJ (ORCPT ); Wed, 13 Jan 2021 09:52:09 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41758 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727646AbhAMOwI (ORCPT ); Wed, 13 Jan 2021 09:52:08 -0500 Received: from mail-wr1-x42a.google.com (mail-wr1-x42a.google.com [IPv6:2a00:1450:4864:20::42a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3BF80C06134E for ; Wed, 13 Jan 2021 06:50:49 -0800 (PST) Received: by mail-wr1-x42a.google.com with SMTP id 91so2407408wrj.7 for ; Wed, 13 Jan 2021 06:50:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=DvtlGdT5MHeh268WloE5stTLPTvRDEZ8rCCQAdX9t84=; b=k1fbqp18yv8PIWF/VtBZ1OCxmUUxm3DEuDCdGpp/1lf2Qusjjl6Jr0LbNjCDkAYjum 1/wwNHwC2fYs6yOsRNYBp7G/0/6EKBrI0OVlE9krnhPcy8pLZI8vfx7yCAVMlSMwGOA+ hnp7cTdcUMYNnIJqWcxy66Lo1P3xlU9yPVOVU+OePlvMmIh7A0BSVnlshSywJYQQwzbU 5uukjwiQHWY6GeoO+bNuzYazh3MQdjtKvFY6BEa2ztaEJRUBzfF1uDCo9++RfRW+OfdJ ZYE/I/DDBlwjWjQBrwAXZdAbnCrtVk//3HRL1I6mCpS4vkKtNu8uXUKBPssO/APhiy0t CkPw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=DvtlGdT5MHeh268WloE5stTLPTvRDEZ8rCCQAdX9t84=; b=d2hNDK2XStgThYDbpvfolUkV35vJ27AzcqB77lXLcrRZGtDEHgRQpNpbvjNF6relSM FzxUfOOGyDSMLm+Ql9WLyMtpR0CJLK5JJlIjCkF+5p5ffmkbhBi88Ich2isK688Pc9HA YKipVQAEVp5y78pcWUnkqy9rZ8P63igj8X9CvbWfhJaQ1vnFVTRrNSoSiGAtFO6t4p0v BTjs9HKw3a3uoGopSOD2BT3FS/57VJZY1S/yH4OOiJ1mB3urbhB3umqCCyDNuok71P6C Ydrwq1hig4K8uGfbvy0h5ooZdQVGBiQQmcpY38gWMWfA1iFjIYo90P2RwivyIwUlg6T7 HFQQ== X-Gm-Message-State: AOAM530862eqNvRa8SAztG3HSkjrRaVeD2Q2DelBCtrpzjsRLNDfAyba wTIyNIdpEXMekPZbcluIagqR7g== X-Google-Smtp-Source: ABdhPJzm7B7r7YLa6vfZWKXo9/XfNaBJsRwMRh4mKywkyucObHWaPSbUoL8ihPPgUVWu5+GcPhFQvw== X-Received: by 2002:adf:eec6:: with SMTP id a6mr2949891wrp.239.1610549448015; Wed, 13 Jan 2021 06:50:48 -0800 (PST) Received: from dell.default ([91.110.221.229]) by smtp.gmail.com with ESMTPSA id t188sm3273433wmf.9.2021.01.13.06.50.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 13 Jan 2021 06:50:47 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, Jingoo Han , Ben Dooks , linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org Subject: [PATCH 24/31] video: fbdev: s3c-fb: Fix some kernel-doc misdemeanours Date: Wed, 13 Jan 2021 14:50:02 +0000 Message-Id: <20210113145009.1272040-25-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210113145009.1272040-1-lee.jones@linaro.org> References: <20210113145009.1272040-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-fbdev@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/video/fbdev/s3c-fb.c:104: warning: Function parameter or member 'osd_stride' not described in 's3c_fb_variant' drivers/video/fbdev/s3c-fb.c:174: warning: Function parameter or member 'variant' not described in 's3c_fb_win' drivers/video/fbdev/s3c-fb.c:345: warning: Function parameter or member 'pixclk' not described in 's3c_fb_calc_pixclk' drivers/video/fbdev/s3c-fb.c:345: warning: Excess function parameter 'pixclock' description in 's3c_fb_calc_pixclk' drivers/video/fbdev/s3c-fb.c:742: warning: Function parameter or member 'transp' not described in 's3c_fb_setcolreg' drivers/video/fbdev/s3c-fb.c:742: warning: Excess function parameter 'trans' description in 's3c_fb_setcolreg' drivers/video/fbdev/s3c-fb.c:1142: warning: Function parameter or member 'sfb' not described in 's3c_fb_release_win' drivers/video/fbdev/s3c-fb.c:1172: warning: Function parameter or member 'win_no' not described in 's3c_fb_probe_win' Cc: Jingoo Han Cc: Ben Dooks Cc: linux-fbdev@vger.kernel.org Cc: dri-devel@lists.freedesktop.org Signed-off-by: Lee Jones Acked-by: Jingoo Han --- drivers/video/fbdev/s3c-fb.c | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/drivers/video/fbdev/s3c-fb.c b/drivers/video/fbdev/s3c-fb.c index ba316bd56efd7..d33d7df77a6a5 100644 --- a/drivers/video/fbdev/s3c-fb.c +++ b/drivers/video/fbdev/s3c-fb.c @@ -75,6 +75,7 @@ struct s3c_fb; * @buf_size: Offset of buffer size registers. * @buf_end: Offset of buffer end registers. * @osd: The base for the OSD registers. + * @osd_stride: The OSD stride value. * @palette: Address of palette memory, or 0 if none. * @has_prtcon: Set if has PRTCON register. * @has_shadowcon: Set if has SHADOWCON register. @@ -155,7 +156,7 @@ struct s3c_fb_palette { * @windata: The platform data supplied for the window configuration. * @parent: The hardware that this window is part of. * @fbinfo: Pointer pack to the framebuffer info for this window. - * @varint: The variant information for this window. + * @variant: The variant information for this window. * @palette_buffer: Buffer/cache to hold palette entries. * @pseudo_palette: For use in TRUECOLOUR modes for entries 0..15/ * @index: The window number of this window. @@ -336,7 +337,7 @@ static int s3c_fb_check_var(struct fb_var_screeninfo *var, /** * s3c_fb_calc_pixclk() - calculate the divider to create the pixel clock. * @sfb: The hardware state. - * @pixclock: The pixel clock wanted, in picoseconds. + * @pixclk: The pixel clock wanted, in picoseconds. * * Given the specified pixel clock, work out the necessary divider to get * close to the output frequency. @@ -733,7 +734,7 @@ static inline unsigned int chan_to_field(unsigned int chan, * @red: The red field for the palette data. * @green: The green field for the palette data. * @blue: The blue field for the palette data. - * @trans: The transparency (alpha) field for the palette data. + * @transp: The transparency (alpha) field for the palette data. * @info: The framebuffer being changed. */ static int s3c_fb_setcolreg(unsigned regno, @@ -1133,6 +1134,7 @@ static void s3c_fb_free_memory(struct s3c_fb *sfb, struct s3c_fb_win *win) /** * s3c_fb_release_win() - release resources for a framebuffer window. + * @sfb: The base resources for the hardware. * @win: The window to cleanup the resources for. * * Release the resources that where claimed for the hardware window, @@ -1160,6 +1162,7 @@ static void s3c_fb_release_win(struct s3c_fb *sfb, struct s3c_fb_win *win) /** * s3c_fb_probe_win() - register an hardware window * @sfb: The base resources for the hardware + * @win_no: The ID of the window to be registered * @variant: The variant information for this window. * @res: Pointer to where to place the resultant window. * From patchwork Wed Jan 13 14:50:03 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 362403 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER, INCLUDES_PATCH, MAILING_LIST_MULTI, SPF_HELO_NONE, SPF_PASS, URIBL_BLOCKED, USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F215EC433E0 for ; Wed, 13 Jan 2021 14:53:35 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id AB13223600 for ; Wed, 13 Jan 2021 14:53:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727693AbhAMOxI (ORCPT ); Wed, 13 Jan 2021 09:53:08 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41782 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727687AbhAMOwN (ORCPT ); Wed, 13 Jan 2021 09:52:13 -0500 Received: from mail-wr1-x432.google.com (mail-wr1-x432.google.com [IPv6:2a00:1450:4864:20::432]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 80297C061350 for ; Wed, 13 Jan 2021 06:50:50 -0800 (PST) Received: by mail-wr1-x432.google.com with SMTP id r7so2409673wrc.5 for ; Wed, 13 Jan 2021 06:50:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=cx+Lvpr+opVztxwCrpEEue+3ZpAhdFGYil/Lm2hEOBU=; b=ClTWBKea4vm3y9ZVGUdkzqdOECtwhR9PudkWuiyjwsis41BqC493w/zvDp2ojr1Xuc ZKnKrxsByJZR0AsZRzPwnncxKrIpJo8q/JxnXgt5uVjgHffxSyJ/m/GiYYZFr0k/fKPF mAUTMzojahcDs+ltW3aBgJgY0pUiUSDu1uCQsHcM5514XCdauiHH8Frr9ruELCw0BD/E FTVVet0fiPEihuRkcU9+1jE680PoB0pOR4Fx8MdQ56p1l1lAxW4F53kcOf3dMgFbW0wD nLFBJyF35Zz+nr0o3nFYMPOFbn8EmarY0vsbpWCUmYqEvxpBpYIoiNLTuo7DHxfJGp22 4RYA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=cx+Lvpr+opVztxwCrpEEue+3ZpAhdFGYil/Lm2hEOBU=; b=F7lhjmfDQ6BM5+eilNcKvFbQRGlxYJeFwDo5UzGSK/N2vozv5sOjyu3cVZdNEAKJZp HoyOPoIbeFZtHg/XlUJNQ/BShCoBulXE1rT08L6ZnuRNqlSN7aMxQWMf3N5p/L5+U7EB 54MsEYEUm5NNOOJgEWq+RPkxkgcOjTSl09FYNvICTO/4LArasbgty2SzQRiyeP4TBAES IUs3d2vbYczFF4HJFRo0OfpYLNzvwTBTfBy0zx46vLr+DyUxDxLl4d2j5IbquVqYoRvV UjHjsp8W9GBmcf0syM/SpiveLe29qL4QHmNaFS6ETr5uWPLnrHBm9N2/f4MMarWxp34p JqHQ== X-Gm-Message-State: AOAM5313mzOuLHZv9dVtHGQeIW0+KgujQ7Zw1cP5eMyzqP62FfRoyL04 +HrjC2o4ddfmxHTepr6NaafHyQ== X-Google-Smtp-Source: ABdhPJy85VePePA0CqsKm5siGrKpak6OmOYMGqGLRupA7S/S8zgvi5kBWxRpHIlYj831TLmAru4Taw== X-Received: by 2002:a5d:674b:: with SMTP id l11mr3094653wrw.247.1610549449265; Wed, 13 Jan 2021 06:50:49 -0800 (PST) Received: from dell.default ([91.110.221.229]) by smtp.gmail.com with ESMTPSA id t188sm3273433wmf.9.2021.01.13.06.50.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 13 Jan 2021 06:50:48 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, Sam Ravnborg , Arnd Bergmann , Software Engineering , dri-devel@lists.freedesktop.org, linux-fbdev@vger.kernel.org Subject: [PATCH 25/31] video: fbdev: mx3fb: Remove unused variable 'enabled' Date: Wed, 13 Jan 2021 14:50:03 +0000 Message-Id: <20210113145009.1272040-26-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210113145009.1272040-1-lee.jones@linaro.org> References: <20210113145009.1272040-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-fbdev@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/video/fbdev/mx3fb.c: In function ‘sdc_disable_channel’: drivers/video/fbdev/mx3fb.c:448:11: warning: variable ‘enabled’ set but not used [-Wunused-but-set-variable] Cc: Sam Ravnborg Cc: Arnd Bergmann Cc: Software Engineering Cc: dri-devel@lists.freedesktop.org Cc: linux-fbdev@vger.kernel.org Signed-off-by: Lee Jones --- drivers/video/fbdev/mx3fb.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/video/fbdev/mx3fb.c b/drivers/video/fbdev/mx3fb.c index 894617ddabcb6..d1c8f7a969ac3 100644 --- a/drivers/video/fbdev/mx3fb.c +++ b/drivers/video/fbdev/mx3fb.c @@ -445,7 +445,6 @@ static void sdc_enable_channel(struct mx3fb_info *mx3_fbi) static void sdc_disable_channel(struct mx3fb_info *mx3_fbi) { struct mx3fb_data *mx3fb = mx3_fbi->mx3fb; - uint32_t enabled; unsigned long flags; if (mx3_fbi->txd == NULL) @@ -453,7 +452,7 @@ static void sdc_disable_channel(struct mx3fb_info *mx3_fbi) spin_lock_irqsave(&mx3fb->lock, flags); - enabled = sdc_fb_uninit(mx3_fbi); + sdc_fb_uninit(mx3_fbi); spin_unlock_irqrestore(&mx3fb->lock, flags); From patchwork Wed Jan 13 14:50:05 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 362141 Delivered-To: patch@linaro.org Received: by 2002:a02:ccad:0:0:0:0:0 with SMTP id t13csp599970jap; Wed, 13 Jan 2021 06:53:00 -0800 (PST) X-Google-Smtp-Source: ABdhPJx1ASHfxrUbZPVzDjWQAoIXykekpOmjPOJZUIV7qHaL4FyYnVuX2UmeUjMPEcCLwqRuyN7w X-Received: by 2002:aa7:db14:: with SMTP id t20mr2051421eds.158.1610549580188; Wed, 13 Jan 2021 06:53:00 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1610549580; cv=none; d=google.com; s=arc-20160816; b=uAwG8P7WHTnVxhsFXimlS3MP+Exv0kXTccdbr1Z0vjELv42jGdNO4IhhV0RT37l1Sf 1fmEL7F7nNvVzwJvA0j3A6zbQbHVNDQwFxKhO9GqaTVy+T5DxSiVjNcdANZpr9/+uSMJ MetKpaklM8tc2mkU4oVkdZnm9EyVVpLvMLaup7xQjfH0Iy2XOa9gY6p2N6wJUG/hzrsL jKy33dJrVkHcgUHPUyhW8dN5aC3fWqYACAr9Lo/0SZ2UtGAuGn9Z8gPz2JcIRNcKSxnF QCd2FjjBE1dAuF4WUK4MhCWDCkg1ndzFjIxgsPfXlTI41asNWg+G0cUaa58kVGi0xU/z ONIg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=RvwJoM6XPaTXW+swhyuXIxTf/L820o0O05r3Nn2BahU=; b=TsdXNk0JOCthXqW2JgWp1YYXLRClcwMjwClH+2i9KbY3Wd2YIIh8KqJPXy/f/hqWwF vx0PAn0GLtRJaQo3wm/3bKgtUc0zAEk94p6LvfI3/LJ0lwsKQdnSXWT9THlYReN9UoPT fMJjWhbhXWkJ4ng+RxrAWUAfDCO9OVV+IV6e9rKAp13K9jwBQfoXpMpeviS0Ba0rdWsA uRWykyiN+uBrUpEgqlOZZZspBibbb4in2ieh9zU4Nd2k5nUg3MKx4GU1UpNwuA4JEIGf 3x0ISQwNvmATW/O0PUEw5jrslcZX7yxp/RS13kwDmiKHM4jZZqpvY7mJlN1ldYYvelPL p1ZQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=nid9QSSJ; spf=pass (google.com: domain of linux-fbdev-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-fbdev-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id v19si1086582eds.239.2021.01.13.06.52.59 for ; Wed, 13 Jan 2021 06:53:00 -0800 (PST) Received-SPF: pass (google.com: domain of linux-fbdev-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=nid9QSSJ; spf=pass (google.com: domain of linux-fbdev-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-fbdev-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727721AbhAMOwT (ORCPT ); Wed, 13 Jan 2021 09:52:19 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41622 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727714AbhAMOwS (ORCPT ); Wed, 13 Jan 2021 09:52:18 -0500 Received: from mail-wm1-x333.google.com (mail-wm1-x333.google.com [IPv6:2a00:1450:4864:20::333]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 46C50C06135B for ; Wed, 13 Jan 2021 06:50:53 -0800 (PST) Received: by mail-wm1-x333.google.com with SMTP id n16so3770066wmc.0 for ; Wed, 13 Jan 2021 06:50:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=RvwJoM6XPaTXW+swhyuXIxTf/L820o0O05r3Nn2BahU=; b=nid9QSSJw0nnYpdBxWNfeDxySbsTdIoMqZnUcmEnH52+LjrzqEPdVxtuCSQU+wNDQp 62FqX/weiPQySDiuQC9amofCPbG5004lDcrdnsnbkZYpzAuZJWvH09KtuoWBDRa2aWSO AocjLmQI+CLfzX2ZsW6YPb2EJJtPlz/GlBtg1LtWbQlVwwHB11QS8Mte86K91VCLTbrK fFJLvGRnloBApapS2VcH6Q1I7KdGDGhrjWmsEMB+WKoFpwYMTT3bIWKLWXdKJxr7Xn8w cAkIudEJcSr3GiCxwMMFUlqXuSrqw8ck0D0hkmDyZxfdnSB9sa3sIlBp8zjyERLJw0nR orsA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=RvwJoM6XPaTXW+swhyuXIxTf/L820o0O05r3Nn2BahU=; b=bqaX4xHIzPFlJkXaqKV93ZqyGi3ZOdIW1XAuVNsyJOPRqweb3SF5ZKY0DQx0IRXrM/ WaxurL9zZKg5k/W82q95VvYdONAzvbFQSYqUW+uuhbi/rpLvwcbVpKmQ0UnLjkxvJTaZ 5GLWREa8Jq89q52lGEECZsKCtKWZotI6adlEu7MOvtZ6MuFSzNov5GUzNukTvcvSHOJb EFbjE34RN3N8F/KeWgsHXdp8gp8ZJkATvvI2jTsPj4eUEGV2ljCxB92WsAmy6zYaWOfA 41uvdPuSlIHMf3k100Yxgk9oEXB2W2IH7kzerNKAK8x3OKujydBTvztUdx/krPfNRs6z 4Sng== X-Gm-Message-State: AOAM5304xGNSc3aK2lv7slRwby48HLFU5YRwLqQun47vwXDnHxn1Jzpb x6XdGTMEtwzf7eg8A2AHnUw1akpklVjIiOxF X-Received: by 2002:a7b:c85a:: with SMTP id c26mr2464833wml.160.1610549452072; Wed, 13 Jan 2021 06:50:52 -0800 (PST) Received: from dell.default ([91.110.221.229]) by smtp.gmail.com with ESMTPSA id t188sm3273433wmf.9.2021.01.13.06.50.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 13 Jan 2021 06:50:51 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, Thomas Winischhofer , dri-devel@lists.freedesktop.org, linux-fbdev@vger.kernel.org Subject: [PATCH 27/31] video: fbdev: sis: init: Remove unused variables 'cr_data2', 'VT' and 'HT' Date: Wed, 13 Jan 2021 14:50:05 +0000 Message-Id: <20210113145009.1272040-28-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210113145009.1272040-1-lee.jones@linaro.org> References: <20210113145009.1272040-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-fbdev@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/video/fbdev/sis/init.c: In function ‘SiS_Generic_ConvertCRData’: drivers/video/fbdev/sis/init.c:3543:37: warning: variable ‘cr_data2’ set but not used [-Wunused-but-set-variable] drivers/video/fbdev/sis/init.c:3542:39: warning: variable ‘VT’ set but not used [-Wunused-but-set-variable] drivers/video/fbdev/sis/init.c:3541:39: warning: variable ‘HT’ set but not used [-Wunused-but-set-variable] Cc: Thomas Winischhofer Cc: dri-devel@lists.freedesktop.org Cc: linux-fbdev@vger.kernel.org Signed-off-by: Lee Jones --- drivers/video/fbdev/sis/init.c | 17 +++-------------- 1 file changed, 3 insertions(+), 14 deletions(-) -- 2.25.1 diff --git a/drivers/video/fbdev/sis/init.c b/drivers/video/fbdev/sis/init.c index 4510272ad297a..b77ea1a8825a5 100644 --- a/drivers/video/fbdev/sis/init.c +++ b/drivers/video/fbdev/sis/init.c @@ -3538,16 +3538,13 @@ SiS_Generic_ConvertCRData(struct SiS_Private *SiS_Pr, unsigned char *crdata, struct fb_var_screeninfo *var, bool writeres ) { - unsigned short HRE, HBE, HRS, HDE, HT; - unsigned short VRE, VBE, VRS, VDE, VT; - unsigned char sr_data, cr_data, cr_data2; + unsigned short HRE, HBE, HRS, HDE; + unsigned short VRE, VBE, VRS, VDE; + unsigned char sr_data, cr_data; int B, C, D, E, F, temp; sr_data = crdata[14]; - /* Horizontal total */ - HT = crdata[0] | ((unsigned short)(sr_data & 0x03) << 8); - /* Horizontal display enable end */ HDE = crdata[1] | ((unsigned short)(sr_data & 0x0C) << 6); E = HDE + 1; @@ -3584,12 +3581,6 @@ SiS_Generic_ConvertCRData(struct SiS_Private *SiS_Pr, unsigned char *crdata, sr_data = crdata[13]; cr_data = crdata[7]; - /* Vertical total */ - VT = crdata[6] | - ((unsigned short)(cr_data & 0x01) << 8) | - ((unsigned short)(cr_data & 0x20) << 4) | - ((unsigned short)(sr_data & 0x01) << 10); - /* Vertical display enable end */ VDE = crdata[10] | ((unsigned short)(cr_data & 0x02) << 7) | @@ -3604,8 +3595,6 @@ SiS_Generic_ConvertCRData(struct SiS_Private *SiS_Pr, unsigned char *crdata, ((unsigned short)(sr_data & 0x08) << 7); F = VRS + 1 - E; - cr_data2 = (crdata[16] & 0x01) << 5; - /* Vertical blank end */ VBE = crdata[12] | ((unsigned short)(sr_data & 0x10) << 4); temp = VBE - ((E - 1) & 511); From patchwork Wed Jan 13 14:50:07 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 362405 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.0 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, UNWANTED_LANGUAGE_BODY, URIBL_BLOCKED, USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B8264C433E0 for ; Wed, 13 Jan 2021 14:53:11 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 6F6D223600 for ; Wed, 13 Jan 2021 14:53:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727812AbhAMOwq (ORCPT ); Wed, 13 Jan 2021 09:52:46 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41752 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727734AbhAMOwX (ORCPT ); Wed, 13 Jan 2021 09:52:23 -0500 Received: from mail-wr1-x432.google.com (mail-wr1-x432.google.com [IPv6:2a00:1450:4864:20::432]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AB22BC06135E for ; Wed, 13 Jan 2021 06:50:55 -0800 (PST) Received: by mail-wr1-x432.google.com with SMTP id w5so2387847wrm.11 for ; Wed, 13 Jan 2021 06:50:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=BzS3qZvHYgaPOU1XJ8pzaZK9gKJ87LqYUfVBvla6rAk=; b=r5T8a1xoDb37mL9jIaJql8CuqF65c13F0JN0BADlmBJtoOSiLcHLQQE0zXy42jaISG L+mOCdoDYshlaFwezWabUiL61Rpla5d4FFyMQCCDUECkUNO1e6hFSngniGnbMl3TwRw+ 0YBTdOFYXyzAsLFnu8j9xEbDQHDJuqj6YN1tK1TxHEmTQvc5vFrEV8J9bQUUCzhlQc/L uEKFperGkCjqCYYjupjJDiL5O1pf0WMWVTyoYuZMKqCrDTJBlNsucq2nS6FxjcouMcm8 ZJnYRxOZO/pAbljJIw7+ZWc1fEo6pqh7BSCCdYtMIEOpTqkl93Az01qWCSLh9dnj+3/e 0yYQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=BzS3qZvHYgaPOU1XJ8pzaZK9gKJ87LqYUfVBvla6rAk=; b=QddTVf3lr9OOq38qIkphofpN+ycGTnbMk3qmEBoEFU0262tpCIEFsXBpFkfX7IaSYS yoLcVw8aTZmJqNZODH5zI5HmI1o1f/wpog1gmcSYhf4/Tp8ZAb1MaZeEO2/O7jT2jHvB pRd0W7FQYB9x1wrTfQGRiPvqFCIay/OoM1U9qZgfiSrNZQQ4wAD4Yy60sVMIcPEsQqiP 6LrE2Y2US3hQRsf1BXiiNEor/zd1v7j7jAdWZGVoyK4tsy9PeAlYiI1mWi8YXpKmMRoM 5tXNiFAv/pM5nO9XPHKSoueDwa87ILGj5+2DP4E+AUoWDS/JV/98tC5+ebRAEXkL03MI BPZg== X-Gm-Message-State: AOAM530anki7RsUj8iK8jmeZN+kdL246m+L1hQGZmk9RmXyvF6mD7sbJ RYy8fgL19ujYiCs1pW+K6rhSdA== X-Google-Smtp-Source: ABdhPJwWW8Mh0VQz40rTJwa/0e7kE/8p2NvxyZJuFij95jhV38CZu46wo+9mK5ByYWZwB9G7KRUEhQ== X-Received: by 2002:a5d:5227:: with SMTP id i7mr3134555wra.68.1610549454505; Wed, 13 Jan 2021 06:50:54 -0800 (PST) Received: from dell.default ([91.110.221.229]) by smtp.gmail.com with ESMTPSA id t188sm3273433wmf.9.2021.01.13.06.50.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 13 Jan 2021 06:50:53 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, Kristoffer Ericson , Thibaut VARENE , Ben Dooks , dri-devel@lists.freedesktop.org, linux-fbdev@vger.kernel.org Subject: [PATCH 29/31] video: fbdev: s1d13xxxfb: Function name must be on the 2nd line in kernel-doc Date: Wed, 13 Jan 2021 14:50:07 +0000 Message-Id: <20210113145009.1272040-30-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210113145009.1272040-1-lee.jones@linaro.org> References: <20210113145009.1272040-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-fbdev@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/video/fbdev/s1d13xxxfb.c:515: warning: Cannot understand * Cc: Kristoffer Ericson Cc: Thibaut VARENE Cc: Ben Dooks Cc: dri-devel@lists.freedesktop.org Cc: linux-fbdev@vger.kernel.org Signed-off-by: Lee Jones --- drivers/video/fbdev/s1d13xxxfb.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/video/fbdev/s1d13xxxfb.c b/drivers/video/fbdev/s1d13xxxfb.c index e6e8bc74412c6..b21627c07f8d0 100644 --- a/drivers/video/fbdev/s1d13xxxfb.c +++ b/drivers/video/fbdev/s1d13xxxfb.c @@ -512,7 +512,6 @@ s1d13xxxfb_bitblt_copyarea(struct fb_info *info, const struct fb_copyarea *area) } /** - * * s1d13xxxfb_bitblt_solidfill - accelerated solidfill function * @info : framebuffer structure * @rect : fb_fillrect structure From patchwork Wed Jan 13 14:50:08 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 362140 Delivered-To: patch@linaro.org Received: by 2002:a02:ccad:0:0:0:0:0 with SMTP id t13csp599935jap; Wed, 13 Jan 2021 06:52:57 -0800 (PST) X-Google-Smtp-Source: ABdhPJz8KdtCMDWrpE73dv3yqe56j0/BXM5g27Q1GlU2lX/ElHENlZpcMpoAJ7e4QbZvgU4xgR2h X-Received: by 2002:a17:907:2131:: with SMTP id qo17mr1783911ejb.546.1610549577657; Wed, 13 Jan 2021 06:52:57 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1610549577; cv=none; d=google.com; s=arc-20160816; b=GUvTIcFEzPiLGwyI/Ei/NJIORa99fic9Mi0XkzJOteh6jECXuZzUUvN2sl2ubPJ4WL rnKfp/p+hGvM22oI0ty0cf1d4mNAZPWNrLUW25ky2TwjfoJwuQSSGBZk+SBhydQXVLK3 aeqnz6h6luCmYCUp72d5qxZ2AusRyCsMObhadnikUZsBG/AWpjlFDldEefMrClsBEFv0 +lOGTLl87ZTq4VaFwbCaEU9s9GZdLKoCHv+QEvvbjwrV3ZY6c8DXpSl/YAoIMpRaQ6vJ AHPYzvNn/C/kyEnyKOoPWjnWGyXk2gXSdGaNzrEVWEW/dT0pciOLnT+e4g+DKCvy6WXE kLfg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=5kBvB4NkQBZ34V2o1ex42K5vSl0rdRhcvGCTff/v+VQ=; b=KANJth/cYQF9TWIHn8xPU7yf3cxijXHHzBU/9PdDZCbQpQb0Ad3zio5RJemjgRtKOL zrtcnBhnZdWv+9dzb0zsz2KSKZVvLHRr0Px11V/7Nn5y9PNF4QwNULlYwZqsNVBnNZOB hiMPYyMgQ0WXJqbnTXB9eo4cI/8TMloAFiU1sNOaho5H/+Nwzx1zxBMRum7p2mNFJNGu VYFnfJkvrx6QgblVfM/Bo6ZOSZ5NAK5F3igNxoLJsoRPm0BX88yL9HgFKJ7JEVs1mbX3 rUvPtgjlHoqIzKy7VpTAnQETCqk4YnRxZqcZDTtHPBF9JsLAj8glJorfsBeK89oG9tTi fVdA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=CX3P+S9L; spf=pass (google.com: domain of linux-fbdev-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-fbdev-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id v19si1086582eds.239.2021.01.13.06.52.57 for ; Wed, 13 Jan 2021 06:52:57 -0800 (PST) Received-SPF: pass (google.com: domain of linux-fbdev-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=CX3P+S9L; spf=pass (google.com: domain of linux-fbdev-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-fbdev-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727767AbhAMOwp (ORCPT ); Wed, 13 Jan 2021 09:52:45 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41692 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727738AbhAMOwY (ORCPT ); Wed, 13 Jan 2021 09:52:24 -0500 Received: from mail-wr1-x431.google.com (mail-wr1-x431.google.com [IPv6:2a00:1450:4864:20::431]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0B795C061795 for ; Wed, 13 Jan 2021 06:50:57 -0800 (PST) Received: by mail-wr1-x431.google.com with SMTP id m4so2391130wrx.9 for ; Wed, 13 Jan 2021 06:50:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=5kBvB4NkQBZ34V2o1ex42K5vSl0rdRhcvGCTff/v+VQ=; b=CX3P+S9L4wGYuGSks00quxfFpZEPOVPivW0r/M9EjGfhtOTkdgaF5aDbimCQt5ON7+ ArYJ0aOzuZ3UQN/A8k7aMly33N16m2n25UqGKwjTU66wrXGcVp4c5o146iISuqMXolOE WHoahwD7dLOGZnK8I/aajIntcVornbKvK8GVcqxWXPCDEJzONy6QEKkTDIVeQ8br91/B RLFAOAbBTU2oZTL9ZOn/+bu+v4ss+ptf8QatATZZ/Qx5NWvYLhjlLcrxcQuf9r+tNcWM SmKKOt26cZHRlMc5SPNWHLCaCXTz35T5oJO8GK2T9EC+lLSv5P25KG/huKlSGIoTohQG tmUg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=5kBvB4NkQBZ34V2o1ex42K5vSl0rdRhcvGCTff/v+VQ=; b=XEnzOmr2I+ZWMKezdPzP1u1yEa2igOHtWkjvalRBlTaeESDjkMPDjc/DK3CSwvdNc8 2mR8pscnT9SFrK04V+R1yGG+nxAXm29rpcHK1qpIg42hsSieqUkAu8yJOXslqIefvUV/ l+0FcoEKQt194Xx+EIbq0vw3HSbwLT9eSCsksxkXDh/JYbdB+6D+1rVWgRq0BGGO4g+a QuuW+BL3Ut5C05XByPJopZEKecnul7oykbWHJIi0RLjt+QITbRIcbHH3ptN+SnkeqVIT DjCuh27UPPL/5wtFV+3P5AtCAYodDEzzdDqUoT2NLZJ/4ybi+JCVXyBmPX5b9qxNJbbF PTxQ== X-Gm-Message-State: AOAM532QI1jIXArSF8TmTeh1+2snVCV0GxE3JIKWjJLIFHzGSAdIjUy/ WXOGhsXnA1+1JtpqqWOolDQIVA== X-Received: by 2002:adf:f18a:: with SMTP id h10mr3189875wro.244.1610549455814; Wed, 13 Jan 2021 06:50:55 -0800 (PST) Received: from dell.default ([91.110.221.229]) by smtp.gmail.com with ESMTPSA id t188sm3273433wmf.9.2021.01.13.06.50.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 13 Jan 2021 06:50:55 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, Jingoo Han , Ben Dooks , linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org Subject: [PATCH 30/31] video: fbdev: s3c-fb: Remove unused variable 'var' from 's3c_fb_probe_win()' Date: Wed, 13 Jan 2021 14:50:08 +0000 Message-Id: <20210113145009.1272040-31-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210113145009.1272040-1-lee.jones@linaro.org> References: <20210113145009.1272040-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-fbdev@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/video/fbdev/s3c-fb.c: In function ‘s3c_fb_probe_win’: drivers/video/fbdev/s3c-fb.c:1176:28: warning: variable ‘var’ set but not used [-Wunused-but-set-variable] Cc: Jingoo Han Cc: Ben Dooks Cc: linux-fbdev@vger.kernel.org Cc: dri-devel@lists.freedesktop.org Signed-off-by: Lee Jones --- drivers/video/fbdev/s3c-fb.c | 2 -- 1 file changed, 2 deletions(-) -- 2.25.1 diff --git a/drivers/video/fbdev/s3c-fb.c b/drivers/video/fbdev/s3c-fb.c index d33d7df77a6a5..91daeca5ca392 100644 --- a/drivers/video/fbdev/s3c-fb.c +++ b/drivers/video/fbdev/s3c-fb.c @@ -1173,7 +1173,6 @@ static int s3c_fb_probe_win(struct s3c_fb *sfb, unsigned int win_no, struct s3c_fb_win_variant *variant, struct s3c_fb_win **res) { - struct fb_var_screeninfo *var; struct fb_videomode initmode; struct s3c_fb_pd_win *windata; struct s3c_fb_win *win; @@ -1201,7 +1200,6 @@ static int s3c_fb_probe_win(struct s3c_fb *sfb, unsigned int win_no, win = fbinfo->par; *res = win; - var = &fbinfo->var; win->variant = *variant; win->fbinfo = fbinfo; win->parent = sfb; From patchwork Wed Jan 13 14:50:09 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 362406 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER, INCLUDES_PATCH, MAILING_LIST_MULTI, SPF_HELO_NONE, SPF_PASS, URIBL_BLOCKED, USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CB243C4332E for ; Wed, 13 Jan 2021 14:52:49 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9801723600 for ; Wed, 13 Jan 2021 14:52:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727766AbhAMOwp (ORCPT ); Wed, 13 Jan 2021 09:52:45 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41690 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727742AbhAMOwY (ORCPT ); Wed, 13 Jan 2021 09:52:24 -0500 Received: from mail-wr1-x42c.google.com (mail-wr1-x42c.google.com [IPv6:2a00:1450:4864:20::42c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6C301C06179F for ; Wed, 13 Jan 2021 06:50:58 -0800 (PST) Received: by mail-wr1-x42c.google.com with SMTP id w5so2388016wrm.11 for ; Wed, 13 Jan 2021 06:50:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=ruS/5Q88or74bT1MGQpJfhS5CAkw8vidMq7dDib2fZs=; b=dw+awuMm/xszxko06x1zbZDXJLrY8h9w46Ii0r1I8t7M23qIokSEWF+lctfR7ifEG+ 10hTw/DwZRUnEFPhAVSO68dOG3xRMSECzOqgPEZGcaXkIwEZpNzwO47CVeLh022fRJlH jDBbte4+oRAEKQsXCuHQ59dmP92NSYRrJJV3l5taYJRqGkZfD+TVnytK3qk0j65GJPKu 2f+mh5IUw8l2pURTp/2Vx0/xKSO+Pb15iZss30ox0FSMT0+dZ7zRgUjqCFkx8UoasarG 0QTSmkjRG6zgnWk6plq18kDAdy0dxgi5AzQNxp96r0OLZ3jhu/aqmtWdmf/vSBNmKOFD AtZw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=ruS/5Q88or74bT1MGQpJfhS5CAkw8vidMq7dDib2fZs=; b=RmgbXUZI6qXVll87FfnJ6ZAzyahiYI996OnQv3ZNqwxPbtpM5O4amxF5Y81SsuvYvT 72aNDed59bq8To9Njej1QXZm3hKgq8ZimLd9yzt0jlksIcCedUAkHvTW2Bk3O+/JitDO Y1HRLba1NFNAGbJrThFhRMsJ0rinw4nqEbkpRwlcrhVSPckaOfiV+jb2fpnWFZo+D/LD wdJBJf80wEa/nqitjJwn7X6aSKsosSzBypuX8dtC5S88WcNPjgjbq0cxtYE/9OmRxHvf iIk3xpxBIRZcjzRO7tSOFV71ye3XrCefX9872fQ1AH6YxLnhCC6KKMvL0qSA7TOvCdes 5h9A== X-Gm-Message-State: AOAM532TWRhkKtV/geRhV2cS1LCIZiOA/IzQXlw/3ONaAo99lPh4Etxa Cxn8eJUKab0DrlezemyxencR/w== X-Google-Smtp-Source: ABdhPJxI76cMcy6SPfmM5W3HPZ9oHq45qLxC2KpwnypdTX8IGDVuElLlSdIgg82G0B9F5jmQLXJfmQ== X-Received: by 2002:a5d:530c:: with SMTP id e12mr3034474wrv.54.1610549457244; Wed, 13 Jan 2021 06:50:57 -0800 (PST) Received: from dell.default ([91.110.221.229]) by smtp.gmail.com with ESMTPSA id t188sm3273433wmf.9.2021.01.13.06.50.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 13 Jan 2021 06:50:56 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, Sam Ravnborg , Arnd Bergmann , Software Engineering , dri-devel@lists.freedesktop.org, linux-fbdev@vger.kernel.org Subject: [PATCH 31/31] video: fbdev: mx3fb: Fix some kernel-doc issues Date: Wed, 13 Jan 2021 14:50:09 +0000 Message-Id: <20210113145009.1272040-32-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210113145009.1272040-1-lee.jones@linaro.org> References: <20210113145009.1272040-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-fbdev@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/video/fbdev/mx3fb.c:738: warning: Function parameter or member 'fbi' not described in 'mx3fb_set_fix' drivers/video/fbdev/mx3fb.c:738: warning: Excess function parameter 'info' description in 'mx3fb_set_fix' drivers/video/fbdev/mx3fb.c:1109: warning: Function parameter or member 'blank' not described in 'mx3fb_blank' drivers/video/fbdev/mx3fb.c:1109: warning: Function parameter or member 'fbi' not described in 'mx3fb_blank' drivers/video/fbdev/mx3fb.c:1134: warning: Function parameter or member 'fbi' not described in 'mx3fb_pan_display' drivers/video/fbdev/mx3fb.c:1134: warning: Excess function parameter 'info' description in 'mx3fb_pan_display' drivers/video/fbdev/mx3fb.c:1393: warning: Function parameter or member 'dev' not described in 'mx3fb_init_fbinfo' drivers/video/fbdev/mx3fb.c:1393: warning: Function parameter or member 'ops' not described in 'mx3fb_init_fbinfo' Cc: Sam Ravnborg Cc: Arnd Bergmann Cc: Software Engineering Cc: dri-devel@lists.freedesktop.org Cc: linux-fbdev@vger.kernel.org Signed-off-by: Lee Jones --- drivers/video/fbdev/mx3fb.c | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/drivers/video/fbdev/mx3fb.c b/drivers/video/fbdev/mx3fb.c index d1c8f7a969ac3..a0fad25136fe5 100644 --- a/drivers/video/fbdev/mx3fb.c +++ b/drivers/video/fbdev/mx3fb.c @@ -731,7 +731,7 @@ static int mx3fb_unmap_video_memory(struct fb_info *fbi); /** * mx3fb_set_fix() - set fixed framebuffer parameters from variable settings. - * @info: framebuffer information pointer + * @fbi: framebuffer information pointer * @return: 0 on success or negative error code on failure. */ static int mx3fb_set_fix(struct fb_info *fbi) @@ -1104,6 +1104,8 @@ static void __blank(int blank, struct fb_info *fbi) /** * mx3fb_blank() - blank the display. + * @blank: blank mode (unblank, normal, {v,h}sync_suspend, powerdown) + * @fbi: framebuffer information pointer */ static int mx3fb_blank(int blank, struct fb_info *fbi) { @@ -1125,7 +1127,7 @@ static int mx3fb_blank(int blank, struct fb_info *fbi) /** * mx3fb_pan_display() - pan or wrap the display * @var: variable screen buffer information. - * @info: framebuffer information pointer. + * @fbi: framebuffer information pointer. * * We look only at xoffset, yoffset and the FB_VMODE_YWRAP flag */ @@ -1384,7 +1386,7 @@ static int mx3fb_unmap_video_memory(struct fb_info *fbi) return 0; } -/** +/* * mx3fb_init_fbinfo() - initialize framebuffer information object. * @return: initialized framebuffer structure. */