From patchwork Wed Jan 13 14:49:39 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 362112 Delivered-To: patch@linaro.org Received: by 2002:a02:ccad:0:0:0:0:0 with SMTP id t13csp597851jap; Wed, 13 Jan 2021 06:50:26 -0800 (PST) X-Google-Smtp-Source: ABdhPJw5cEaLvG+cFdhrGjTPhzwUvqJ57/oINS3F+USqrruOKBCwkeQbpYz5+HqKBxU/o4P5V58c X-Received: by 2002:a65:5bc8:: with SMTP id o8mr2379261pgr.100.1610549426460; Wed, 13 Jan 2021 06:50:26 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1610549426; cv=none; d=google.com; s=arc-20160816; b=cN0PvFBkttKfkJW4LkeBuo+zwdr3F7VIcaBdh7i0hgmWFft33MCSYzSMKxlnw4F4EX /FXf6TPPauvu+CDmlYphwrWgXusR2Sj0t+aGUfK7ZHJsCU2VR1Wj0v749KCiRod8+9hz nvIqJgzZU7414stXc62y2iqTCN6M+t4u1x44ttj0uXebGc9vExq9hvsvUOvua06ryhmp kF0FB+9d0Mn8S9bAJKoKrVwTvVBQEn+jUJs8XLfgvmqUkvLPK5GpWy2eNLsdtiXATSd/ Vc3M+7D2hOo1dJ9c1CtYZftyQbk1t6xR7Tg3zzd7vsKO5dYucwSi53lJVMz3HdhVS4sX r4Qw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:cc:list-subscribe :list-help:list-post:list-archive:list-unsubscribe:list-id :precedence:mime-version:references:in-reply-to:message-id:date :subject:to:from:dkim-signature:delivered-to; bh=DMNisapWwR04+AkNcuFwRY2k6DCHBrB3APHCxKcwyHg=; b=MvQpdA/hAnrrM19SjYlvrSbqHa3o+4gPfReQVniFZpPOStXkwJBm6pUCQqSJwH58sZ oW0zyXF6GUOTIKo9+3WR+iDWA2cbxxn/dt9n3/5uF6tzYkSRblaJqvYfDsaNEGur0GPF QgYPmEpEVn0M1pQ3q5omBr//oMtYjUPDVvchw4lzFma7PMMudxJXCKid3D9pMTNWO4eI ZDeV3jUlFqJVZjVX7FQeW5N+sZjQUWfGFO43WSr2hmtAjIQm9VSjbxCeuaYtDZvFE9rT qd8BVKv2UCIUVZOPn/VZm2a+Emy+muq79l1uUILV9y6jzzdxB7/v95VQI/NBlAUqKFAv 8Z0Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=s5iALxr3; spf=pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 131.252.210.177 as permitted sender) smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from gabe.freedesktop.org (gabe.freedesktop.org. [131.252.210.177]) by mx.google.com with ESMTPS id r2si2584285pls.206.2021.01.13.06.50.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 13 Jan 2021 06:50:26 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 131.252.210.177 as permitted sender) client-ip=131.252.210.177; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=s5iALxr3; spf=pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 131.252.210.177 as permitted sender) smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id EBF956EA4A; Wed, 13 Jan 2021 14:50:18 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mail-wm1-x32e.google.com (mail-wm1-x32e.google.com [IPv6:2a00:1450:4864:20::32e]) by gabe.freedesktop.org (Postfix) with ESMTPS id 2E55E6EA09 for ; Wed, 13 Jan 2021 14:50:16 +0000 (UTC) Received: by mail-wm1-x32e.google.com with SMTP id e25so1863706wme.0 for ; Wed, 13 Jan 2021 06:50:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=AGeTlHRvpAdPio9vRmuctbq8OFArXLtHb/g2TDArOrk=; b=s5iALxr3dobAkBUTpXGoBoDm/4QIM6hPqOgnFBeyOPMxE44pJLX408VkWwnjf9EKr7 cV7kywVBFk+BvK0rYKNvHfyqBUdb5WnuXOYKKGcbdNXTqGP8wzzNaWscr3GVpl5L+3e9 59GwpRAnSZw8YR3uzHvOELb7YNB+MK3VqThmnI/SPsJGojvBSlVXx9pEChrkKe/NOSnL ISS27W14Wk79/qU5wLB7QGSr1xGvvu+viv/ZtzaO16hfIiOOc82jkjWv9QBVdfjnSd7c DsTks38v32N1wxNwz0nDYPs9DmW7h7iY6aRdoTTFZx6zjR6CxixctRYRVpRPsYNSW6i4 aExw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=AGeTlHRvpAdPio9vRmuctbq8OFArXLtHb/g2TDArOrk=; b=bM9EZ2zrSY5lGbiBtDP11cQCxr1tESdJGmSv3b9r++GmN8VkP/biH5gRb8L72KBAym Y7d1lnQqaIxfBbgHkoiEnfo7lWTkEEd8ODyBQ1EVVS4F4oQmU+TK8Uq1dP2rqMtUfxqN 9BCnkApDO23ZPp4DRpQ7djldigsxbFVWF3JTwg35CwMxfFG0z8lqN2ONc7bWlQVo8Y98 7Vnrre1iW5NIGSZUk6yrX86bQFA9LPOSMJdf4IKsYN28jexR6l12e2VSQqOJLR+aNr9l /moF8MNi4uT/9+bLrecREuXIfgWDKzkDGI9+OH+fpEgX3DddEvQ1eBn3j7swITCulDU9 5i0g== X-Gm-Message-State: AOAM530iY6EyHgZWyKNYXXU2roQ7ZXGtYatn8ICrTmtCjzxSZeDtdvt+ TNunv8lmPgmPO49pnhIn8HrTXw== X-Received: by 2002:a1c:cc19:: with SMTP id h25mr2579994wmb.124.1610549414900; Wed, 13 Jan 2021 06:50:14 -0800 (PST) Received: from dell.default ([91.110.221.229]) by smtp.gmail.com with ESMTPSA id t188sm3273433wmf.9.2021.01.13.06.50.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 13 Jan 2021 06:50:14 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Subject: [PATCH 01/31] video: fbdev: core: fbmon: Add missing description for 'specs' Date: Wed, 13 Jan 2021 14:49:39 +0000 Message-Id: <20210113145009.1272040-2-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210113145009.1272040-1-lee.jones@linaro.org> References: <20210113145009.1272040-1-lee.jones@linaro.org> MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-fbdev@vger.kernel.org, Egbert Eich , John Fremlin , Ani Joshi , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, James Simmons Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Also fix a formatting issue Fixes the following W=1 kernel build warning(s): drivers/video/fbdev/core/fbmon.c:617: warning: Function parameter or member 'specs' not described in 'fb_create_modedb' drivers/video/fbdev/core/fbmon.c:1103: warning: bad line: Cc: James Simmons Cc: Egbert Eich Cc: John Fremlin Cc: Ani Joshi Cc: dri-devel@lists.freedesktop.org Cc: linux-fbdev@vger.kernel.org Signed-off-by: Lee Jones --- drivers/video/fbdev/core/fbmon.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.25.1 _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel diff --git a/drivers/video/fbdev/core/fbmon.c b/drivers/video/fbdev/core/fbmon.c index 1bf82dbc9e3cf..82f856fe3919f 100644 --- a/drivers/video/fbdev/core/fbmon.c +++ b/drivers/video/fbdev/core/fbmon.c @@ -605,6 +605,7 @@ static void get_detailed_timing(unsigned char *block, * fb_create_modedb - create video mode database * @edid: EDID data * @dbsize: database size + * @specs: framebuffer montior specifications * * RETURNS: struct fb_videomode, @dbsize contains length of database * @@ -1100,7 +1101,6 @@ static u32 fb_get_hblank_by_hfreq(u32 hfreq, u32 xres) * 2 * M * M = 300; * C = 30; - */ static u32 fb_get_hblank_by_dclk(u32 dclk, u32 xres) { From patchwork Wed Jan 13 14:49:40 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 362111 Delivered-To: patch@linaro.org Received: by 2002:a02:ccad:0:0:0:0:0 with SMTP id t13csp597797jap; Wed, 13 Jan 2021 06:50:23 -0800 (PST) X-Google-Smtp-Source: ABdhPJyDJp7DQVey3eG59bi6bS4ABuR+lv8ijdbex7RqkAEzmIjhGwaepGLRwwPZ8T1xqBDfBZ14 X-Received: by 2002:a63:f80f:: with SMTP id n15mr2346254pgh.415.1610549423219; Wed, 13 Jan 2021 06:50:23 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1610549423; cv=none; d=google.com; s=arc-20160816; b=IAKgb1IX1bnBNp9hiXNtmiX0gwrs0l5PsmY0NJA8X7tzUDmBhmJWqtWludWeE2VPIm aAOcya6XR3duJtxwSyJAfftsJEgfbt5vzZG5M+hlKOEGaT0nQ7/JJuY4t9e2ECQZMHuI 3AyAQWyFEKccSd3UFuaXHzdmqh6eCMP4Y6B6EYXPLvgkma83KHO7YkguKDUvVaBnQ/ws EjFdAb0TAW9IdPsDV9XbH+kcYErMB+9KJy2co7qftyMiBfP9wSLeGnw8/ocTLv0H9mHz fMMx5AewRqOUKrNVfI0oLm95be9n6w5zlwbWs+QqjpHiztz4clrPudfz2AG1EKevORQX lFSQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:cc:list-subscribe :list-help:list-post:list-archive:list-unsubscribe:list-id :precedence:mime-version:references:in-reply-to:message-id:date :subject:to:from:dkim-signature:delivered-to; bh=+bGxwcU+daLJr1hqMYqGU8SpKAfpaS61y8tUjNteHOg=; b=o7M8xxBO/IvgsJopbLlziUFU+hSe6Vkr1H1jc5fsUVgK6Z0c0E0EdjTMOuEaFY4vZc WRLKwdfOoZHOk/nPnEzHPWaj9THGym0Zv5IoTj48ZoQtutgZjZCNOBhB+OIDhcqbSN6b zLRLzggY/1kD4u+5rOYxSnF0H3ppO7MZglkSxAk4mB877eioY4OEiDiv57XGMKqBNcwV BeXBebg32NduW4mMOcY1Z6djXReZfuTlH6lv7LGDOwCd5xisOHMzD4BBhfzUVDmvfi4Z EhhlxrO9tquwazdbPox+8KipkUC96woUnvJzjf8lKRybIPpnvktQqfAkJcRsj4IqsHnI k+fA== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=zc9ZOpEU; spf=pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 2610:10:20:722:a800:ff:fe36:1795 as permitted sender) smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from gabe.freedesktop.org (gabe.freedesktop.org. [2610:10:20:722:a800:ff:fe36:1795]) by mx.google.com with ESMTPS id g13si2478591pgg.374.2021.01.13.06.50.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 13 Jan 2021 06:50:23 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 2610:10:20:722:a800:ff:fe36:1795 as permitted sender) client-ip=2610:10:20:722:a800:ff:fe36:1795; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=zc9ZOpEU; spf=pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 2610:10:20:722:a800:ff:fe36:1795 as permitted sender) smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 709466EA12; Wed, 13 Jan 2021 14:50:18 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mail-wr1-x430.google.com (mail-wr1-x430.google.com [IPv6:2a00:1450:4864:20::430]) by gabe.freedesktop.org (Postfix) with ESMTPS id 6AFED6EA4A for ; Wed, 13 Jan 2021 14:50:17 +0000 (UTC) Received: by mail-wr1-x430.google.com with SMTP id a12so2391149wrv.8 for ; Wed, 13 Jan 2021 06:50:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=9f2BPaI0FPEfwHACkMCkRxYDyaBt02TKR4D8xELwApI=; b=zc9ZOpEUI+Nh6Qla1WDfrb2vnRL2q84hQM50XEQXQr0xU371apuDwreUQOZKKSgAr5 g7a1pROIkw2JAlYrfbUiig2HWLqwWHy8HZ/XWWBHtiDNKwj55UxEgroLjJuCBw18hlHe 92MAeh9s6TSYlS6N3UHBcggv18NhVPSGxCug7FAilAYfafpZsRbkQDlYTKiORivlccUP 9LS1k+4OMMbCziBfn3XobchtVgfVFJZSPwFyAo4AnK1qxUYR+KRpOnUOlfLckY0T7SBh WIy1YBvftA/oJxDxlPln0TX3wEE3MMUxIU12tVxKSgY+5mviYsZit9GALu0OnFxLsu+0 HhzQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=9f2BPaI0FPEfwHACkMCkRxYDyaBt02TKR4D8xELwApI=; b=LDSQlpwt13xktI1vkYMDDN8lY3Af6TYpxPOlpnxH1fgNL7b/HdVqgaqiyy3101BAGI HdocZ1Fa0FVbkxcv1yUb9CdkhRWfPAUPf9T3PGEbhXoT39rfmuePr/RwrG4BAVcqtdDx vo6/Hz+AmDt7E8WNS25TvpGdYnbn4PtaTaTxcbl9LFAlwiSGpVn6EJFdHCrJkwrEP2xr gpowk11n0WzrvyIMgoQWgH611cQKmrbujxpYrck4Y6FqKzQn4CboE/yVXwDzz80OwtPt ZX2j1U2TGeVKv7j//8A7iYQnQFC4N7g4BblUwdA9CjK12IJbRqb2r3t0WXedJC/ieD/2 g8fg== X-Gm-Message-State: AOAM530D5xlliO/bnFJtM6gkYFzt206cPsZTXIJZInex6qFtpLG63vyq zUx3z/fvLQqQpRsOzXr5ciIWzg== X-Received: by 2002:adf:f4d0:: with SMTP id h16mr3060914wrp.30.1610549416231; Wed, 13 Jan 2021 06:50:16 -0800 (PST) Received: from dell.default ([91.110.221.229]) by smtp.gmail.com with ESMTPSA id t188sm3273433wmf.9.2021.01.13.06.50.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 13 Jan 2021 06:50:15 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Subject: [PATCH 02/31] video: of_display_timing: Provide missing description for 'dt' Date: Wed, 13 Jan 2021 14:49:40 +0000 Message-Id: <20210113145009.1272040-3-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210113145009.1272040-1-lee.jones@linaro.org> References: <20210113145009.1272040-1-lee.jones@linaro.org> MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Sascha Hauer , Steffen Trumtrar , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-fbdev@vger.kernel.org Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Fixes the following W=1 kernel build warning(s): drivers/video/of_display_timing.c:58: warning: Function parameter or member 'dt' not described in 'of_parse_display_timing' Cc: Steffen Trumtrar Cc: Sascha Hauer Cc: dri-devel@lists.freedesktop.org Cc: linux-fbdev@vger.kernel.org Signed-off-by: Lee Jones --- drivers/video/of_display_timing.c | 1 + 1 file changed, 1 insertion(+) -- 2.25.1 _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel diff --git a/drivers/video/of_display_timing.c b/drivers/video/of_display_timing.c index abc9ada798ee8..9f21f7dc85292 100644 --- a/drivers/video/of_display_timing.c +++ b/drivers/video/of_display_timing.c @@ -52,6 +52,7 @@ static int parse_timing_property(const struct device_node *np, const char *name, /** * of_parse_display_timing - parse display_timing entry from device_node * @np: device_node with the properties + * @dt: Display timing information **/ static int of_parse_display_timing(const struct device_node *np, struct display_timing *dt) From patchwork Wed Jan 13 14:49:41 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 362115 Delivered-To: patch@linaro.org Received: by 2002:a02:ccad:0:0:0:0:0 with SMTP id t13csp597943jap; Wed, 13 Jan 2021 06:50:32 -0800 (PST) X-Google-Smtp-Source: ABdhPJwjG8a5hbeYLh/RN1kHO/axBEE9v2NJZz3Ex1YuGQ4DoX5BikDlbCopWgYQPq6uhS3Mfq4B X-Received: by 2002:a17:90a:d249:: with SMTP id o9mr2895072pjw.196.1610549432043; Wed, 13 Jan 2021 06:50:32 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1610549432; cv=none; d=google.com; s=arc-20160816; b=OK70sUUpESnTpAS9qRVktn7OZ9OrGJsQVt3g1ev18/7VePF4LFfeh04NTEEKiYA8So hw3+H0flGUwA4xKMw99Auab2TPfFses/NYwC6Gjmfbppv6yRlf1oq2wiFlo7rTW1pOHZ svWC2ApqxNx8ofV109WaHQ2z/g6lToDJoqp8Nbf2INUTm5yHg1co29Ue1c9cXFdG8+91 EbT9u+8fgy6krafcjsrDiBPcXQfIvIquhXkmiL8PO+19Ak1RlGXN/V8GKwktWP/qIUoX OmGnaH01jg2wkqQbdvipn32tfBzldyf1SIxEkSIU0U9YpHUw/QWNUjSHH09hkCap0tC4 Oevg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:cc:list-subscribe :list-help:list-post:list-archive:list-unsubscribe:list-id :precedence:mime-version:references:in-reply-to:message-id:date :subject:to:from:dkim-signature:delivered-to; bh=eCxmGfnRA8z4rpQCx2XMsValWyB5+CVxa+9RvHW70RY=; b=bk8VdU/uYD1wE9RVjspPAyKl0Z9/Upwsyq8puWBzw5pyjABRFLIV7ag2qGvjfYAkB2 OTRBFJuAD2MDOu+g1FVbEOq9cD7Ec0L61I6RFWgMvwqS/LtmJ8sBGHQDkbjkfeZONgMd h5U0FYYAc6HVqkVdicyTAfY3MJWwnS9ugZgo/Yvx+mmZKfyPgFXqvGlp/rZM8+i3nTFv cZa+w+Ddvw54oZLOWsjA3zMd/1TBouAVGM7/zCGgQOUwZ7kkib/tIjP4yw5C24HAZK5t 6KQgVR+frpyH7XL4tGf2UCL+9TPxCHcu7UZKCWrqrDAX1YOF1Dguy7lXT13eWmfZheow SYdA== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=IrAuQ7ST; spf=pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 131.252.210.177 as permitted sender) smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from gabe.freedesktop.org (gabe.freedesktop.org. [131.252.210.177]) by mx.google.com with ESMTPS id r132si2323671pfc.274.2021.01.13.06.50.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 13 Jan 2021 06:50:32 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 131.252.210.177 as permitted sender) client-ip=131.252.210.177; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=IrAuQ7ST; spf=pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 131.252.210.177 as permitted sender) smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 383D66EA59; Wed, 13 Jan 2021 14:50:25 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mail-wm1-x32f.google.com (mail-wm1-x32f.google.com [IPv6:2a00:1450:4864:20::32f]) by gabe.freedesktop.org (Postfix) with ESMTPS id ADDBA6EA4A for ; Wed, 13 Jan 2021 14:50:18 +0000 (UTC) Received: by mail-wm1-x32f.google.com with SMTP id c124so1836506wma.5 for ; Wed, 13 Jan 2021 06:50:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=z+Wneugk0qlue2K4+v5y/OOFUzDsbbip7TVziVpxlQg=; b=IrAuQ7STah/wSU3pxyHJvgSYn2RFJdHG53sANMcOvFWEelHr6MWbdgH0ILose47Zot Z7KuINVRHXAMOA906n8OR8iFtf4Nj4LcjAyitSzAalDlz9HRtVPGlTQdbmekRtEQvGci mwZQ7Bb/HQ3c6/5luRJ3paeeu2VckReWTpFW7IRFzHAedOHDtIquldPM8aztOfgvKxxD s6M1i1MfLLNqZIHLouLNp+LTtcAhj/vFkE7Sl4+oIe3REJUFHIDtu/tkOMeXBy2FAK74 x/2MlHNNGii/IG81iFi1rPP9oiZBxGa2SQxXcMDTHrLT+hIaHOP1bEfVoE+Viqsap5Ze aNlA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=z+Wneugk0qlue2K4+v5y/OOFUzDsbbip7TVziVpxlQg=; b=Sa7Dx0sE0nvL/pdNPqjSgl02/nu6GikR44NWlltx6b/qN9b8rwo8Yqo0qOd8Bz5Az8 VCRWd1ogkP2kTIjMxKe5Vs0SZkzPG0BjlOMsnFJvSu31/+THVa48QS4vTd/HU28TkrG1 s/uCEqh+OSj56c7KFicU77YzNx2hK/uWDCc+LckSzM9QQCKKHcpthEfyEHzlNS4XQS5i 907D3noMSIYD7/pz6BsTZddIjXAjXhBwTSmZqLgO79euGqNWCLM4s/J2sJ+BlD3sbxa4 Js4nsM+LdhoUo+IX2HOkRX/eGPhXkSg+rIOSzmH4mXzc7ZilRr0pJ+NAl0SV7v4FcAdz TW9g== X-Gm-Message-State: AOAM531BAIoGUD4oUTv2exYyXELR4PhiAskZaOJGPeWg+1eWK/u5KVAQ VUxnoUS3jgKpR7EKliyPzg7Qeg== X-Received: by 2002:a7b:c24b:: with SMTP id b11mr2562890wmj.168.1610549417412; Wed, 13 Jan 2021 06:50:17 -0800 (PST) Received: from dell.default ([91.110.221.229]) by smtp.gmail.com with ESMTPSA id t188sm3273433wmf.9.2021.01.13.06.50.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 13 Jan 2021 06:50:16 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Subject: [PATCH 03/31] video: fbdev: aty: atyfb_base: Remove superfluous code surrounding 'dac_type' Date: Wed, 13 Jan 2021 14:49:41 +0000 Message-Id: <20210113145009.1272040-4-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210113145009.1272040-1-lee.jones@linaro.org> References: <20210113145009.1272040-1-lee.jones@linaro.org> MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "Eddie C. Dost" , linux-fbdev@vger.kernel.org, Vaibhav Gupta , Alex Kern , Anthony Tong , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Bartlomiej Zolnierkiewicz Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" If used, 'dac_type' is overwritten in the '#ifdef CONFIG_ATARI' clause. It's also not used after the last assignment, so we'll rid that too. Cc: Bartlomiej Zolnierkiewicz Cc: Vaibhav Gupta Cc: Alex Kern Cc: "Eddie C. Dost" Cc: Anthony Tong Cc: dri-devel@lists.freedesktop.org Cc: linux-fbdev@vger.kernel.org Signed-off-by: Lee Jones --- drivers/video/fbdev/aty/atyfb_base.c | 3 --- 1 file changed, 3 deletions(-) -- 2.25.1 _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel diff --git a/drivers/video/fbdev/aty/atyfb_base.c b/drivers/video/fbdev/aty/atyfb_base.c index c8feff0ee8da9..11c328f0585ce 100644 --- a/drivers/video/fbdev/aty/atyfb_base.c +++ b/drivers/video/fbdev/aty/atyfb_base.c @@ -2365,8 +2365,6 @@ static int aty_init(struct fb_info *info) par->bus_type = (stat0 >> 0) & 0x07; par->ram_type = (stat0 >> 3) & 0x07; ramname = aty_gx_ram[par->ram_type]; - /* FIXME: clockchip/RAMDAC probing? */ - dac_type = (aty_ld_le32(DAC_CNTL, par) >> 16) & 0x07; #ifdef CONFIG_ATARI clk_type = CLK_ATI18818_1; dac_type = (stat0 >> 9) & 0x07; @@ -2375,7 +2373,6 @@ static int aty_init(struct fb_info *info) else dac_subtype = (aty_ld_8(SCRATCH_REG1 + 1, par) & 0xF0) | dac_type; #else - dac_type = DAC_IBMRGB514; dac_subtype = DAC_IBMRGB514; clk_type = CLK_IBMRGB514; #endif From patchwork Wed Jan 13 14:49:42 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 362113 Delivered-To: patch@linaro.org Received: by 2002:a02:ccad:0:0:0:0:0 with SMTP id t13csp597892jap; Wed, 13 Jan 2021 06:50:29 -0800 (PST) X-Google-Smtp-Source: ABdhPJzgKNgAMRjMK6nMOogsJiCXtLnZr6NDfrQbGfd9vC32uV3lc4DD12S+YSilI/1sd4JZQnAQ X-Received: by 2002:a63:50a:: with SMTP id 10mr2398765pgf.273.1610549428519; Wed, 13 Jan 2021 06:50:28 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1610549428; cv=none; d=google.com; s=arc-20160816; b=APgVe5+TcyhtB6a6skNKCzVmTeootFUYb/XzHeeErqLE3X9dxSaq8CECKQ5JN0H6Jo /lFyFkEweW42NXQm2or4oS+0qPVTtTVRESddB6G3TTyTqrcNZhkLJaZh9KCD6kcIas3W 2HYz/gHfcje1g20RFrkDLXC67lKF/ONqXGIzdOBYh0yZaBYQdHk6cloWvZISDG2sJpTY 0Fn2FH6CvyLo3CkGVE45WP2qDoywp2IkxfAJrwPi5shulWqchgXyASdw6J2Rfi7xFGkS c98kOEm0H/bXGZTw9PxTOGdXh1jM7sjP0tyJ1D8YEJpW3ImkJGV4iZQneZjO6wGz3f8Y Xnuw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:cc:list-subscribe :list-help:list-post:list-archive:list-unsubscribe:list-id :precedence:mime-version:references:in-reply-to:message-id:date :subject:to:from:dkim-signature:delivered-to; bh=C2yXBCYCSd265Ecj8RTRY25I5NDT8ffHDT+47FWD5ec=; b=otIvVQOszFYRz3ot+3S+VMu982iLDeDaunKylQlSrtnkC0q8WFgSOL3EyEBrr54tB2 2ps/ZL29w+ZxR84GUTSWiVDxpfOA5zvloG2accPBvDDSzASrtYL6ehTDt9OURhTPVA0U folWi8HJ+M/iYHnuANDRLGX1XOYyGrnPPwI7RMt8GaNdJERYhVds4YCX8w4ntIn322+h CZX/JRcR/ZkxlCDb38BcWkDUAVFsEnlb9O4oRj31UUCe5X04QVjyT6udpq4JzgengHre Nkf32111U4xXtcYy3Jn6nqNxVmq+eh/GqHhidFPDCMP8hP0OnmBiONtRJRjKxnP85j/M 27eA== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=U7XZpCyn; spf=pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 2610:10:20:722:a800:ff:fe36:1795 as permitted sender) smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from gabe.freedesktop.org (gabe.freedesktop.org. [2610:10:20:722:a800:ff:fe36:1795]) by mx.google.com with ESMTPS id c15si3037486pgn.211.2021.01.13.06.50.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 13 Jan 2021 06:50:28 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 2610:10:20:722:a800:ff:fe36:1795 as permitted sender) client-ip=2610:10:20:722:a800:ff:fe36:1795; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=U7XZpCyn; spf=pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 2610:10:20:722:a800:ff:fe36:1795 as permitted sender) smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 8D4726EA54; Wed, 13 Jan 2021 14:50:22 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mail-wr1-x42a.google.com (mail-wr1-x42a.google.com [IPv6:2a00:1450:4864:20::42a]) by gabe.freedesktop.org (Postfix) with ESMTPS id 7F1256EA4B for ; Wed, 13 Jan 2021 14:50:20 +0000 (UTC) Received: by mail-wr1-x42a.google.com with SMTP id i9so2417752wrc.4 for ; Wed, 13 Jan 2021 06:50:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=qvE9T1Sdi1RAuyfyFAKYPhv+PIZJRg/gdw+xAA12HNM=; b=U7XZpCynbw9Y5AThFO42Dm2JoFqWJsr9KG6TgiBESTQlNc3fAWqvrv/vV8/bWuW37L 5Fjmhghbx5eL6EY4Moqeeu/yko+J0D69QRMZW6dhXQ+Nm9vDb4yEtKNNPUG+swW/GUbD nAaRi2O/qE3tCVsaODzksTZRhF5TfWSJtIznTgVmbKSYSnmBQqobEUxuFMK2YTYRo0L7 5w6ysuaaYARhRutz78Bmdnh6Kc8gc9Z/V8eH/apGCKxMK7Ke/jwJuBK4NTtqahNEJg7W TA2E0XY8ZoQAjFera38Ev01dBrJEDrnnCeyVsmeOs34OMOGtHvVAEe9zC9dc+VdMb3Ui iGGg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=qvE9T1Sdi1RAuyfyFAKYPhv+PIZJRg/gdw+xAA12HNM=; b=m5LS+s18cDIdewop85viIN2e8c46Z5kexVMrzrCta6URJ6sJv3MPdD/tHLBATPxFqA XzzT5bq2EmBspme6dx6iQ0s2hNRhILierVuaovyIn8xKZwNn5eWBci1mM6du28DEC7fN xXrjUSMa2Ua4LfwnuV3m6kzBZgJTXtW9MlQeef/pumun56F4mpWtqxa/t3C0IS7jJmXw AprpCVkP2xDI6ZOy4+THR4oiHaTsvz0LEfk0kL76k/7nr1PvAsPsmCjI8zvJC/qcyJjX arp9JQco8wV4n6YgZBfXu6GPg6AMFSU4TgqAMwyRqms9G5UwGX1qnxvsMgq+L4JE3MYm b/9w== X-Gm-Message-State: AOAM530BmjULUzOqyGuOPtnFZaAuYEYBD9oCFNWQmeyqyktVeBZ5zo34 bpDtKUx1bJNlzzWFP55+YeBbfA== X-Received: by 2002:adf:f18a:: with SMTP id h10mr3187110wro.244.1610549419211; Wed, 13 Jan 2021 06:50:19 -0800 (PST) Received: from dell.default ([91.110.221.229]) by smtp.gmail.com with ESMTPSA id t188sm3273433wmf.9.2021.01.13.06.50.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 13 Jan 2021 06:50:18 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Subject: [PATCH 04/31] video: fbdev: aty: atyfb_base: Mark 'dac_type' as __maybe_unused Date: Wed, 13 Jan 2021 14:49:42 +0000 Message-Id: <20210113145009.1272040-5-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210113145009.1272040-1-lee.jones@linaro.org> References: <20210113145009.1272040-1-lee.jones@linaro.org> MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "Eddie C. Dost" , linux-fbdev@vger.kernel.org, Anthony Tong , Alex Kern , Vaibhav Gupta , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" 'dac_type' is only used in the '#ifdef CONFIG_ATARI' clause. Fixes the following W=1 kernel build warning(s): drivers/video/fbdev/aty/atyfb_base.c: In function ‘aty_init’: drivers/video/fbdev/aty/atyfb_base.c:2363:6: warning: variable ‘dac_type’ set but not used [-Wunused-but-set-variable] Cc: Vaibhav Gupta Cc: Alex Kern Cc: "Eddie C. Dost" Cc: Anthony Tong Cc: dri-devel@lists.freedesktop.org Cc: linux-fbdev@vger.kernel.org Signed-off-by: Lee Jones --- drivers/video/fbdev/aty/atyfb_base.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/video/fbdev/aty/atyfb_base.c b/drivers/video/fbdev/aty/atyfb_base.c index 11c328f0585ce..9b056b49f2807 100644 --- a/drivers/video/fbdev/aty/atyfb_base.c +++ b/drivers/video/fbdev/aty/atyfb_base.c @@ -2360,7 +2360,7 @@ static int aty_init(struct fb_info *info) #ifdef CONFIG_FB_ATY_GX if (!M64_HAS(INTEGRATED)) { u32 stat0; - u8 dac_type, dac_subtype, clk_type; + u8 __maybe_unused dac_type, dac_subtype, clk_type; stat0 = aty_ld_le32(CNFG_STAT0, par); par->bus_type = (stat0 >> 0) & 0x07; par->ram_type = (stat0 >> 3) & 0x07; From patchwork Wed Jan 13 14:49:43 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 362116 Delivered-To: patch@linaro.org Received: by 2002:a02:ccad:0:0:0:0:0 with SMTP id t13csp597969jap; Wed, 13 Jan 2021 06:50:34 -0800 (PST) X-Google-Smtp-Source: ABdhPJy4l+ISuEiDzuGCSqZHpENJAHgnF1MD/9no2OWLoouWMiaRNkHyvYCSpKZdwkyuz+iVcbSO X-Received: by 2002:a62:ee0c:0:b029:1a8:db14:927e with SMTP id e12-20020a62ee0c0000b02901a8db14927emr2524774pfi.14.1610549433940; Wed, 13 Jan 2021 06:50:33 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1610549433; cv=none; d=google.com; s=arc-20160816; b=nyJkI1FivY+dBXaYLWbqRNBY7Dkg3Kd2tkOSI279M3dru3GRSYnQjpzKt8ib4e3n0V 5Fg/PXcGzazXfW1/Jjyx3u1ZLOByFdyJ2FIWTShv7vNWdAtJ1f+KgjItnnzluPHXTYOe vthxU5jDSK5APB2x1FTQINWWHG04gUpvAN6r5LufoaQjWDuLcOToAW5txxUTvZT9ig9B gXRTwoFrF2dzzwyydBjFrnr/cvECfXNtmtRRwFVVLUEx38Y+EsOj+UVqIALibDBmIXB8 IxmOAxif/vdzReB4WP15Kdzyrt7Y4dYKdsEZmQ8jRi/FgrKiE8yYIhXk/t8xyDkkxBBI PehA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:cc:list-subscribe :list-help:list-post:list-archive:list-unsubscribe:list-id :precedence:mime-version:references:in-reply-to:message-id:date :subject:to:from:dkim-signature:delivered-to; bh=Oy3iE3BbDx8YFd88Is8hi7AcuoUSlRbqjJSgOMoGeBY=; b=trTQdnuplPvhDI3wSg/RC76JtTd8CRyX3KKnuwDYd3/rpY5lxscvAcJ3KpAMthhTyh jUkQ5MWJqgEh6wHTTlbOBCmgKIqzlRMgFGu8/9r/qQuv6vqKJFXited7aX31qzVHDMEb d4pGij+1pLDj92ytf9y0f6VkLjHwpnraA8ytSz/NLkFJNHCcCB3mTbR0DEwn6L01a3Fw F4ovLSwoqC4F/KtuMxR2cVTmks9D19rasfY4LsclMLQ2Ga+aMf8uxxGovTFDbm1BwMJZ UIBPGr+ruuLCzY+9qGE4fRcAbN0B2rwZJosbOqyU4q6njGhHcR0Hu4EJRdXAg14xEjDW wVAw== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=S6pjMri1; spf=pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 131.252.210.177 as permitted sender) smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from gabe.freedesktop.org (gabe.freedesktop.org. [131.252.210.177]) by mx.google.com with ESMTPS id j3si2350663pgj.518.2021.01.13.06.50.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 13 Jan 2021 06:50:33 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 131.252.210.177 as permitted sender) client-ip=131.252.210.177; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=S6pjMri1; spf=pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 131.252.210.177 as permitted sender) smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 3CA036EA4E; Wed, 13 Jan 2021 14:50:28 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mail-wr1-x430.google.com (mail-wr1-x430.google.com [IPv6:2a00:1450:4864:20::430]) by gabe.freedesktop.org (Postfix) with ESMTPS id E1E8C6EA50 for ; Wed, 13 Jan 2021 14:50:21 +0000 (UTC) Received: by mail-wr1-x430.google.com with SMTP id m4so2388813wrx.9 for ; Wed, 13 Jan 2021 06:50:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=jVSUjkIjXEkNiZ9bYl2AvQwRUk7bSgmr726se0qdSGE=; b=S6pjMri1LooUzVebsMKl5L/qXAXXf0BQaNWI9zUwzK+jMt6eB9Qc4oOTGepufIBfid w8BOqqJSqOTlO1AaMZ2c97EUxzPgYgwXzlP38xgFZHdc5f5/8pnliirr015cmXT5P/6C bmXz//hqWY6WZtaLsnyk9w3DTs/zx93zvqMGjgmGEz1ltpAcWFoGUuZTLcV3oaXDRWzg TsHN1MtRbF4DsoU67oqGthJ9CyD102ea6PWM8nSeKWwLjDVQYDQOynMxGeM3eMYyzuVy k+RwnCTE6vvqOECHhK+/HT1+C06vWU2p6IumxaB4VEqq3egwhncHh1sL8BXGgsKHUjzx Jyrw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=jVSUjkIjXEkNiZ9bYl2AvQwRUk7bSgmr726se0qdSGE=; b=lzpEaY7c1Z2k1v0xtkxKZyC5x8/rASyU1ogwqvSCT+d1a4UtdYHIbsLOamATDZiycF ioll2KbzaG6HSnPMAv0TfdkIWGytKbs+W8YTjFd1/iWVCL+BPAlH4XX8PjotR92a8Ye9 MJRVtTRC9Uao121SKpv7bKVWhjkeVt7W6VaevERpQjHTrfZAAuWpVUGJIkpHvk2eMbCU kz8tO+NbEaIpvPU3uewjnu1ewP8TkfQ2Uj53rMm13mRfwZi1hWlMVtnuOE6qLej+qPzp UwH81sBMdb4xYK0ZESHv9CAHvaUeaCbsUYoEmV1wJjF24h4k0g2YSxv5wXBMGedsIrwC GA3A== X-Gm-Message-State: AOAM5325svgn6z6/Kn4g4IeH+tkcWrlgEDC23mKKQVN5fvnQFSqlxhvA ov0YauT0Rycu37BQbO41WlPtoQ== X-Received: by 2002:adf:ec86:: with SMTP id z6mr2994233wrn.17.1610549420622; Wed, 13 Jan 2021 06:50:20 -0800 (PST) Received: from dell.default ([91.110.221.229]) by smtp.gmail.com with ESMTPSA id t188sm3273433wmf.9.2021.01.13.06.50.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 13 Jan 2021 06:50:19 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Subject: [PATCH 05/31] video: of_videomode: Fix formatting in kernel-doc header Date: Wed, 13 Jan 2021 14:49:43 +0000 Message-Id: <20210113145009.1272040-6-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210113145009.1272040-1-lee.jones@linaro.org> References: <20210113145009.1272040-1-lee.jones@linaro.org> MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-fbdev@vger.kernel.org, Steffen Trumtrar , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Fixes the following W=1 kernel build warning(s): drivers/video/of_videomode.c:32: warning: Function parameter or member 'np' not described in 'of_get_videomode' drivers/video/of_videomode.c:32: warning: Function parameter or member 'vm' not described in 'of_get_videomode' drivers/video/of_videomode.c:32: warning: Function parameter or member 'index' not described in 'of_get_videomode' Cc: Steffen Trumtrar Cc: dri-devel@lists.freedesktop.org Cc: linux-fbdev@vger.kernel.org Signed-off-by: Lee Jones --- drivers/video/of_videomode.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) -- 2.25.1 _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel diff --git a/drivers/video/of_videomode.c b/drivers/video/of_videomode.c index 67aff2421c29e..97a220852977f 100644 --- a/drivers/video/of_videomode.c +++ b/drivers/video/of_videomode.c @@ -14,11 +14,11 @@ /** * of_get_videomode - get the videomode # from devicetree - * @np - devicenode with the display_timings - * @vm - set to return value - * @index - index into list of display_timings - * (Set this to OF_USE_NATIVE_MODE to use whatever mode is - * specified as native mode in the DT.) + * @np: devicenode with the display_timings + * @vm: set to return value + * @index: index into list of display_timings + * (Set this to OF_USE_NATIVE_MODE to use whatever mode is + * specified as native mode in the DT.) * * DESCRIPTION: * Get a list of all display timings and put the one From patchwork Wed Jan 13 14:49:44 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 362114 Delivered-To: patch@linaro.org Received: by 2002:a02:ccad:0:0:0:0:0 with SMTP id t13csp597916jap; Wed, 13 Jan 2021 06:50:30 -0800 (PST) X-Google-Smtp-Source: ABdhPJxVgdsSR9oTGa2dR3oYaCB7hpPp++PTR3bq0ydK1Jj/qfLAmhEXTWZrAU6S1nKX0Ip/5TKb X-Received: by 2002:a63:ea4b:: with SMTP id l11mr2346283pgk.61.1610549430479; Wed, 13 Jan 2021 06:50:30 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1610549430; cv=none; d=google.com; s=arc-20160816; b=MHAcFtHUdXEoXYjsmuo9SPc7bAJdpF8ksQ5gfQz7vp5XU3RuwcbPusTpOowfL4RBCx 4477CaG6OEFRdT04+a0Ug8DqBm6dx42uLTVEa9mtRXvBEyTVNxjRJA+5Qf0nqmt+lpnu BxpjOTflhloOCCKzT0dVJLWVTiSe2nbEDdI3RUD3bGUbzGLeE8cst/k4BXj8bNbNrsMq etscrjfQoSTSCc6456joXn87nzqB9F6ooB6afNUaS5pRbSQBrLJSO/eMDcHAoeRoqczk a9e7SMquuBlKhm81FEjZXDAMsh0Wa5ppEedFb1S3O1mU4xXbMaAMXLim7ngpIsZq4ipM wyFQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:cc:list-subscribe :list-help:list-post:list-archive:list-unsubscribe:list-id :precedence:mime-version:references:in-reply-to:message-id:date :subject:to:from:dkim-signature:delivered-to; bh=+Z2PD1MUN5yIGRa+xS/NcevGmGUYJQhyQdR2/3YuBLk=; b=evFe8m5BiQZzetilsowiqVS3Q20AV+OSFxVANIPDKKae/u4/YBOQTSaWjBIbtQTnPV Q3CgoOoNIgQbToSmbeJ3clp3xQYWHHeIcCQyiTlYSengkiEEsaKHwyNhV34/C9CyLb6u 40xs42BfaJMzhhWw4Cgjy/88vRQd78d3M+FdGRcLvOrLyo2+nUMNZJkwCgX9dqElSdzW xUUwLshIQxFM7XHNm4Cp9CEAOqLXWNCmzy37hKqCw9sQePb359ELHlgnswCaLpj/heY5 NH8Td+L+SGppPNyA9BU49B2K3I9CXslnJ29RhydGZuzjn8bRRlvkXWNaH5Yn6sJhCKsk EZhg== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=YtqFI8RD; spf=pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 2610:10:20:722:a800:ff:fe36:1795 as permitted sender) smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from gabe.freedesktop.org (gabe.freedesktop.org. [2610:10:20:722:a800:ff:fe36:1795]) by mx.google.com with ESMTPS id s1si2392348pgs.535.2021.01.13.06.50.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 13 Jan 2021 06:50:30 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 2610:10:20:722:a800:ff:fe36:1795 as permitted sender) client-ip=2610:10:20:722:a800:ff:fe36:1795; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=YtqFI8RD; spf=pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 2610:10:20:722:a800:ff:fe36:1795 as permitted sender) smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id D770A6EA50; Wed, 13 Jan 2021 14:50:24 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mail-wr1-x430.google.com (mail-wr1-x430.google.com [IPv6:2a00:1450:4864:20::430]) by gabe.freedesktop.org (Postfix) with ESMTPS id 9A59F6EA50 for ; Wed, 13 Jan 2021 14:50:23 +0000 (UTC) Received: by mail-wr1-x430.google.com with SMTP id q18so2430580wrn.1 for ; Wed, 13 Jan 2021 06:50:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=9ZA26LGPctNuqP7mpV6XCcQsQZ+HB0XmYF1B/7L0jYA=; b=YtqFI8RDxxpW9mdQOUk2m2f1SEWXkWNA5Pijok8cpdh3D28yUmkArEeHKDJHaMEw2D PdgSAP9Q4tLae/SkYSJ5eTZDO+n6pFatwv/TqUUoiuB320K732eTGq0iXq8oR/tNfkIH 9Y7pMmU2dnvUJlE7Cdikh+7Q8gG1oq1Nl7lwW/RGcLXR8b/1SFcPKGDY/yVn+9vcaOw5 ZsO4KDnuoqv4twTiAyGApWz9SY9RChb3/M/q2nVmM21sVoOCVxHdSCQemO93T1g3lrAj 3Lx+99Zkwfs70d4L1iYYRAQVeIVTso9ON+bmqWt1gSMmPn5bt/vIUtmLPizMCW6GT2UM qWZA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=9ZA26LGPctNuqP7mpV6XCcQsQZ+HB0XmYF1B/7L0jYA=; b=czj4MDMsfBViwZYhuGKNT8MHTMp4+AI8Kdb/y0FyfiY3pGmR59SKoGTh8bmMesEUUm eT6wHFgkueGy352HQh8E8JaoMgedcQ0budH95U9JwS5M9eKqqUjAHo/oNNsuNVQI85RV 6KxjVdtZvzUAkCX6/fQ0hfuJyEzSvytIvjNz3Wc4L3iZn4tyiKN1fbk1LXNHWmN9YgCa V+nl32RxdMOMDL7NJvMqjlPtfUsYo3AUBICuwRpy9VAHXClTTev7F0Y74TkYAKEoJn51 zBLAFJFdzSNbvC8CZRDdmm4fDZQOey0DFpwuaDPWyIT2wgmcsbZw7mPe3BrEhN39LrIX Yhfg== X-Gm-Message-State: AOAM532qvCwzq4Ti4NVaWtFNxFoGWnXKWYf6zHxdQT17c5d/md/hHIb3 NOxlpcMUrFsxME0HeOeELKPcRxgTeUOuQmec X-Received: by 2002:a05:6000:108b:: with SMTP id y11mr2935428wrw.379.1610549422311; Wed, 13 Jan 2021 06:50:22 -0800 (PST) Received: from dell.default ([91.110.221.229]) by smtp.gmail.com with ESMTPSA id t188sm3273433wmf.9.2021.01.13.06.50.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 13 Jan 2021 06:50:21 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Subject: [PATCH 06/31] video: fbdev: core: fb_notify: Demote non-conformant kernel-doc header Date: Wed, 13 Jan 2021 14:49:44 +0000 Message-Id: <20210113145009.1272040-7-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210113145009.1272040-1-lee.jones@linaro.org> References: <20210113145009.1272040-1-lee.jones@linaro.org> MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Antonino Daplas , linux-fbdev@vger.kernel.org, Brad Douglas , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Fixes the following W=1 kernel build warning(s): drivers/video/fbdev/core/fb_notify.c:44: warning: Function parameter or member 'val' not described in 'fb_notifier_call_chain' drivers/video/fbdev/core/fb_notify.c:44: warning: Function parameter or member 'v' not described in 'fb_notifier_call_chain' Cc: Antonino Daplas Cc: Brad Douglas Cc: dri-devel@lists.freedesktop.org Cc: linux-fbdev@vger.kernel.org Signed-off-by: Lee Jones --- drivers/video/fbdev/core/fb_notify.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) -- 2.25.1 _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel diff --git a/drivers/video/fbdev/core/fb_notify.c b/drivers/video/fbdev/core/fb_notify.c index 74c2da5288848..1f142182fb40e 100644 --- a/drivers/video/fbdev/core/fb_notify.c +++ b/drivers/video/fbdev/core/fb_notify.c @@ -36,9 +36,8 @@ int fb_unregister_client(struct notifier_block *nb) } EXPORT_SYMBOL(fb_unregister_client); -/** +/* * fb_notifier_call_chain - notify clients of fb_events - * */ int fb_notifier_call_chain(unsigned long val, void *v) { From patchwork Wed Jan 13 14:49:45 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 362117 Delivered-To: patch@linaro.org Received: by 2002:a02:ccad:0:0:0:0:0 with SMTP id t13csp597989jap; Wed, 13 Jan 2021 06:50:35 -0800 (PST) X-Google-Smtp-Source: ABdhPJy/U9gwRouXUvpfVqUrkBYGKQEX5yCUMasSh0OPRBW8Ju0CA27lNCGLtwK5ftT+wEX4no1H X-Received: by 2002:aa7:9722:0:b029:19e:2832:4f63 with SMTP id k2-20020aa797220000b029019e28324f63mr2539333pfg.58.1610549435509; Wed, 13 Jan 2021 06:50:35 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1610549435; cv=none; d=google.com; s=arc-20160816; b=Gt9ewjFfeGxgUQH/yJazNDNqstFwAIn/SrRMrH6+pigRnikljVxdU8qgVesByfx6mJ 3n9i5NXVh14zsdHK5qUXGN//NADMwTPF88NhkZJpdAA/ulQeqIIfKGGk6mAaHjvXgHjO +Mol1WABIftKXuzT/aFm+cuHp6Q7Jz3xJcrjKDJ8ebzKJykFkpm8l9CYc6bhBSTYdWez y7SaVN0yLAmpFx+bqoWql9dD7idNdDLvTU+L2C3qKOyuazA0SeNqAh37SpiVyfR/066t /yenQTDvbvgSJfxZK3WVmpephNEf9Q8Ziuegmmg5BjUKKTOrQgr/O6A037AsDUc1b+gn Ipqg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:cc:list-subscribe :list-help:list-post:list-archive:list-unsubscribe:list-id :precedence:mime-version:references:in-reply-to:message-id:date :subject:to:from:dkim-signature:delivered-to; bh=UIfaXB9A54GBKkoCzS6tTD7EwLzw6fENg5NDLpkARGk=; b=BUFrwQskTADhRi0T4gCMrt8LSRbZoXJOBMRgSkJoumExp9WcFezdUsppgSzhXtQEwq 5Ub//oGTDr2V9ziKkaDJJ9y3zA/ebRpwHnd7aOLqpOSIBbQx63D/sLbKQD+4cHmUV5+d r5pMu0JXh1Fhj12+USIzhgk034/RCDjCmlwIQBpcGWd0DHGA8Q+uviNhDeMRwxRhum3T Fdh+nF687ADiFBTfuvcvRX3mE/Zm5g9KUv/827JCmi7JcJINHDoLg/xzzPJQFwDUFeEJ RyWFCmbojrw30dFcnRh3j+6hzV1l7i2I9YkqLXum7VMOrtn8DIFbK3MJPmc4Fjj6j2Om GkxA== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b="pafm/yTu"; spf=pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 2610:10:20:722:a800:ff:fe36:1795 as permitted sender) smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from gabe.freedesktop.org (gabe.freedesktop.org. [2610:10:20:722:a800:ff:fe36:1795]) by mx.google.com with ESMTPS id i66si2566747pfe.325.2021.01.13.06.50.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 13 Jan 2021 06:50:35 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 2610:10:20:722:a800:ff:fe36:1795 as permitted sender) client-ip=2610:10:20:722:a800:ff:fe36:1795; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b="pafm/yTu"; spf=pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 2610:10:20:722:a800:ff:fe36:1795 as permitted sender) smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id F003E6EA4F; Wed, 13 Jan 2021 14:50:30 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mail-wm1-x32f.google.com (mail-wm1-x32f.google.com [IPv6:2a00:1450:4864:20::32f]) by gabe.freedesktop.org (Postfix) with ESMTPS id 2A3476EA58 for ; Wed, 13 Jan 2021 14:50:25 +0000 (UTC) Received: by mail-wm1-x32f.google.com with SMTP id e25so1864152wme.0 for ; Wed, 13 Jan 2021 06:50:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=41nyWegGgkKSptjKwd6Aeq/y24rv95GTAFlb1D5g4Jo=; b=pafm/yTul1VI6VgZ+awVR07fmX3mqTQQWpRtjlYSoHGu/InZpKlZn+TF3rRl17XSwP nVwCaHHy9o1NrbzI5Kqe7jaZlv2VbjcglCPPckq0exelBS2rP9Xphp3ItgG6M8CLTIda FwhjulzLUtcgvHitUQ8ektKlAMQXC7BiliexBGYJjJwdb+W/YgPFIvtHlO2IzbtQIst3 2lSsdNd4+01TS9ZC+VwxrTVSuKXlQqv7Nl4gEzF2GdRsihWAM07i9laFCMuZ/apY4wep urDKWRfnc3vXE09BZNPfdVc8mjTIaiELGUowzaRoZqOiyF9oz78MBZlpqlJsYGj2kyLL xurg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=41nyWegGgkKSptjKwd6Aeq/y24rv95GTAFlb1D5g4Jo=; b=L9WUAE8Ha3Zq59/4zbNmERJ6P1jm/o5Ma9e9HIfKiYS92t92JroYojG8ey5c+5RlBG iUgTePoc8coEpyHO1NkwSYV5iMBVB8+wGFaIsY1sM2NmDxpDoCEhFBV1Sh8ySG3xQPxi UVf7wR3nRy7lf7JXcwwWwVsnyWxn6QQWb2nFDU3OmLRt63+4jQvA20PI67mG1mZRaQzh NcXGtX+UCX1ksOrFNx/rjqedTpoBo+FwHAt4UvJvrDGk/TTg/Ou9rdgDagDTa2rPXOev Gx/RK6VWoTMm0y6Xe4o3G7BJERK7CQ+dH6j9vfpBZEAbwc4dZLp6LJ0QYzyezZZRsNbf Yf/A== X-Gm-Message-State: AOAM532pblcJBygMt4E5om2dCjHsrWtrnyxH8da/dDGJ6mDFQhIgagBS 84C2ZFs8OUc6Eo61e+Qg+f1mTQ== X-Received: by 2002:a1c:a145:: with SMTP id k66mr2551920wme.18.1610549423835; Wed, 13 Jan 2021 06:50:23 -0800 (PST) Received: from dell.default ([91.110.221.229]) by smtp.gmail.com with ESMTPSA id t188sm3273433wmf.9.2021.01.13.06.50.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 13 Jan 2021 06:50:22 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Subject: [PATCH 07/31] video: fbdev: riva: fbdev: Fix some kernel-doc misdemeanours Date: Wed, 13 Jan 2021 14:49:45 +0000 Message-Id: <20210113145009.1272040-8-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210113145009.1272040-1-lee.jones@linaro.org> References: <20210113145009.1272040-1-lee.jones@linaro.org> MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: dri-devel@lists.freedesktop.org, Ani Joshi , linux-kernel@vger.kernel.org, linux-fbdev@vger.kernel.org Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Fixes the following W=1 kernel build warning(s): drivers/video/fbdev/riva/fbdev.c:485: warning: Function parameter or member 'data8' not described in 'rivafb_load_cursor_image' drivers/video/fbdev/riva/fbdev.c:485: warning: Excess function parameter 'data' description in 'rivafb_load_cursor_image' drivers/video/fbdev/riva/fbdev.c:863: warning: Function parameter or member 'var' not described in 'rivafb_do_maximize' drivers/video/fbdev/riva/fbdev.c:863: warning: Function parameter or member 'nom' not described in 'rivafb_do_maximize' drivers/video/fbdev/riva/fbdev.c:1229: warning: Excess function parameter 'con' description in 'rivafb_pan_display' Cc: Antonino Daplas Cc: Ani Joshi Cc: linux-fbdev@vger.kernel.org Cc: dri-devel@lists.freedesktop.org Signed-off-by: Lee Jones --- drivers/video/fbdev/riva/fbdev.c | 15 +++++---------- 1 file changed, 5 insertions(+), 10 deletions(-) -- 2.25.1 _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel diff --git a/drivers/video/fbdev/riva/fbdev.c b/drivers/video/fbdev/riva/fbdev.c index ce55b9d2e862b..8adf9cf353410 100644 --- a/drivers/video/fbdev/riva/fbdev.c +++ b/drivers/video/fbdev/riva/fbdev.c @@ -464,12 +464,12 @@ static inline void reverse_order(u32 *l) /** * rivafb_load_cursor_image - load cursor image to hardware - * @data: address to monochrome bitmap (1 = foreground color, 0 = background) + * @data8: address to monochrome bitmap (1 = foreground color, 0 = background) * @par: pointer to private data - * @w: width of cursor image in pixels - * @h: height of cursor image in scanlines * @bg: background color (ARGB1555) - alpha bit determines opacity * @fg: foreground color (ARGB1555) + * @w: width of cursor image in pixels + * @h: height of cursor image in scanlines * * DESCRIPTiON: * Loads cursor image based on a monochrome source and mask bitmap. The @@ -840,19 +840,15 @@ static void riva_update_var(struct fb_var_screeninfo *var, NVTRACE_LEAVE(); } -/** - * rivafb_do_maximize - +/* + * rivafb_do_maximize * @info: pointer to fb_info object containing info for current riva board - * @var: - * @nom: - * @den: * * DESCRIPTION: * . * * RETURNS: * -EINVAL on failure, 0 on success - * * * CALLED FROM: * rivafb_check_var() @@ -1214,7 +1210,6 @@ static int rivafb_set_par(struct fb_info *info) /** * rivafb_pan_display * @var: standard kernel fb changeable data - * @con: TODO * @info: pointer to fb_info object containing info for current riva board * * DESCRIPTION: From patchwork Wed Jan 13 14:49:46 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 362119 Delivered-To: patch@linaro.org Received: by 2002:a02:ccad:0:0:0:0:0 with SMTP id t13csp598010jap; Wed, 13 Jan 2021 06:50:38 -0800 (PST) X-Google-Smtp-Source: ABdhPJwQvLlOgh1Zg++sQAWk+eSnMTTzglydWyAha1JJavKzSpzpwJ0rdaNHUGFk5TK0jKiSYFdG X-Received: by 2002:a17:90a:bd12:: with SMTP id y18mr2897846pjr.146.1610549438779; Wed, 13 Jan 2021 06:50:38 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1610549438; cv=none; d=google.com; s=arc-20160816; b=XrW3R8JzHPZmeyl3TlrwJVirp7wUVRzgOdeI1zr+Oq5TWS5CY/yX6LqBtacQ5KL+9v 3+NhWxXyJChzQo3YTfPBRlbA6AVkJcmuUI2wI6Sl+3xXNVX2C5hD3eTwqodY1jDykLGX BFj0Ew08RJ6vEi7iXep2puLAxAbI7fQsG2ToaN+7kKlD4EA6hU4qSMNLoU4V8/sbQmrP hdLFVFcCdjzQpxPZEuBwXdj9R9L9mZPZSfDJQfHZN6LsW/C7qeq2kd8BvoqB3aMR7CnR 95H6Wf2xUqA7vftD4Kcq3l0YUZixvQl3brx35ypwMVSyEpH1C8VLN2b+N4HVg0gdSiRg +SXw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:cc:list-subscribe :list-help:list-post:list-archive:list-unsubscribe:list-id :precedence:mime-version:references:in-reply-to:message-id:date :subject:to:from:dkim-signature:delivered-to; bh=KzpkUo6jZ3kBil/3T4y1KZOGk+Wo84lMZOhrtJBbuVM=; b=Rl8Nt5wCQRbFi9fqGoz+yO1adsK78xmIeiex5CYEm96oFY94Xpx/CP/huIEhoX8wps xiGFuQ1PCKcl74rAxfrWpvAJKRg28D6CaqB3+Ei1nmFoPPVT+1U85oDe/KLRL5yLdSOQ tokkruXmFd9xuW2DkNZgeNcxq2my/1Qtp/O4/wQUZf7JLJAyvPDIxX15Rbafb+W/lQES v3NZHtieJbTfoMJFlifNH6PAaGXHMGrsyK2PluynQ5SzRRIn6tS+ZjMwNP+Cw9BcK/17 aLlWaSBt+oSlvpBOuz5yguTvTIVbvv7lHYOL0Qrw8nO8FBISIlKJ/tp+ICIgbdjhMXN9 yg+A== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=q+MZOwcK; spf=pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 131.252.210.177 as permitted sender) smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from gabe.freedesktop.org (gabe.freedesktop.org. [131.252.210.177]) by mx.google.com with ESMTPS id i18si2884450pgg.404.2021.01.13.06.50.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 13 Jan 2021 06:50:38 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 131.252.210.177 as permitted sender) client-ip=131.252.210.177; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=q+MZOwcK; spf=pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 131.252.210.177 as permitted sender) smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 0FD956EA53; Wed, 13 Jan 2021 14:50:31 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mail-wr1-x42f.google.com (mail-wr1-x42f.google.com [IPv6:2a00:1450:4864:20::42f]) by gabe.freedesktop.org (Postfix) with ESMTPS id 26C366EA58 for ; Wed, 13 Jan 2021 14:50:27 +0000 (UTC) Received: by mail-wr1-x42f.google.com with SMTP id i9so2418162wrc.4 for ; Wed, 13 Jan 2021 06:50:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=xVuJfuGZFscYbOy1MUiffPVpTle7WgNo/eVkJwf7WNU=; b=q+MZOwcKb62nI3dDtefjHxCD1svvGR60Jf4GADTHbVCFSZk5ahffVs42713RFmCF3M hhNPD9AVosxvdPh3Z8yE2EAX9AIqiNvXNvlrh/+KWS1FF0B5BjXeeykrTfib5131sKFj mn2tgU4dkCSlErK842cyu7HwusDnIaakfzs1I7cSnM4yplICdcp2mBAJcvH34TWQSDE0 Dng1yBz0vV3j29G56BqJw78ZGoOyPY6hhoK+WPjPT+6lUPxLOPjPUWuXCAoeTfdRwhJo a9h437HEm5yNmdhcoLqG033+xaunKcJYY/dyF8W3QR8fqLXStt350nJ0m0HkPZgnnZIh 3SRw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=xVuJfuGZFscYbOy1MUiffPVpTle7WgNo/eVkJwf7WNU=; b=tnnxANOUwjZxjy3B3kKKlI466zb5bvwItjp7OcuCMNhM1OPhCFTjeC15+DKZV1rlDm 0DhMBoX6EToaGkCtC8RHNq5PiZnnLmqfWgzNnwmX6UHNe+euNjus8eouitHQ6izpyXng uTLaHdBiLHtaPqFeMVJj6Oz4GlcN4AVugzOmN0uZrMENrF/yc4izfkcx8vgypzS4OFqg ZupKBnGAC64so1yfDcL4RpC/oxDoOYPyrQqTTp5+OsfjnqH/kp0B69ilwHo2uf9ws5h0 Y/bpjM7O5VpeJR5T7J6+GHKsuVjeDhlNOL2A9t8G6kJPWloOXZu4z0ws0gsGaPRUeNU0 7m+Q== X-Gm-Message-State: AOAM531bUsVELt4YQMfhoGPtRJ6yC3U7SYJKfGY4U5VUWzK0jKfFIiS7 /U579Y9U/yAULZC6l/rFhfIUwg== X-Received: by 2002:a5d:4d50:: with SMTP id a16mr2925284wru.43.1610549425879; Wed, 13 Jan 2021 06:50:25 -0800 (PST) Received: from dell.default ([91.110.221.229]) by smtp.gmail.com with ESMTPSA id t188sm3273433wmf.9.2021.01.13.06.50.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 13 Jan 2021 06:50:24 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Subject: [PATCH 08/31] video: fbdev: sis: sis_main: Remove unused variable 'reg' Date: Wed, 13 Jan 2021 14:49:46 +0000 Message-Id: <20210113145009.1272040-9-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210113145009.1272040-1-lee.jones@linaro.org> References: <20210113145009.1272040-1-lee.jones@linaro.org> MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Gerd Knorr , linux-fbdev@vger.kernel.org, Thomas Winischhofer , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Fixes the following W=1 kernel build warning(s): drivers/video/fbdev/sis/sis_main.c: In function ‘sisfb_post_xgi_ddr2’: drivers/video/fbdev/sis/sis_main.c:5032:5: warning: variable ‘reg’ set but not used [-Wunused-but-set-variable] Cc: Thomas Winischhofer Cc: Gerd Knorr Cc: dri-devel@lists.freedesktop.org Cc: linux-fbdev@vger.kernel.org Signed-off-by: Lee Jones --- drivers/video/fbdev/sis/sis_main.c | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/drivers/video/fbdev/sis/sis_main.c b/drivers/video/fbdev/sis/sis_main.c index 03c736f6f3d08..266a5582f94d3 100644 --- a/drivers/video/fbdev/sis/sis_main.c +++ b/drivers/video/fbdev/sis/sis_main.c @@ -5029,7 +5029,6 @@ static void sisfb_post_xgi_ddr2(struct sis_video_info *ivideo, u8 regb) static const u8 cs168[8] = { 0x48, 0x78, 0x88, 0x00, 0x00, 0x00, 0x00, 0x00 }; - u8 reg; u8 v1; u8 v2; u8 v3; @@ -5037,9 +5036,9 @@ static void sisfb_post_xgi_ddr2(struct sis_video_info *ivideo, u8 regb) SiS_SetReg(SISCR, 0xb0, 0x80); /* DDR2 dual frequency mode */ SiS_SetReg(SISCR, 0x82, 0x77); SiS_SetReg(SISCR, 0x86, 0x00); - reg = SiS_GetReg(SISCR, 0x86); + SiS_GetReg(SISCR, 0x86); SiS_SetReg(SISCR, 0x86, 0x88); - reg = SiS_GetReg(SISCR, 0x86); + SiS_GetReg(SISCR, 0x86); v1 = cs168[regb]; v2 = cs160[regb]; v3 = cs158[regb]; if (ivideo->haveXGIROM) { v1 = bios[regb + 0x168]; @@ -5049,9 +5048,9 @@ static void sisfb_post_xgi_ddr2(struct sis_video_info *ivideo, u8 regb) SiS_SetReg(SISCR, 0x86, v1); SiS_SetReg(SISCR, 0x82, 0x77); SiS_SetReg(SISCR, 0x85, 0x00); - reg = SiS_GetReg(SISCR, 0x85); + SiS_GetReg(SISCR, 0x85); SiS_SetReg(SISCR, 0x85, 0x88); - reg = SiS_GetReg(SISCR, 0x85); + SiS_GetReg(SISCR, 0x85); SiS_SetReg(SISCR, 0x85, v2); SiS_SetReg(SISCR, 0x82, v3); SiS_SetReg(SISCR, 0x98, 0x01); From patchwork Wed Jan 13 14:49:47 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 362118 Delivered-To: patch@linaro.org Received: by 2002:a02:ccad:0:0:0:0:0 with SMTP id t13csp597999jap; Wed, 13 Jan 2021 06:50:37 -0800 (PST) X-Google-Smtp-Source: ABdhPJwSBboImlaEmbZ9CbbZp1CZCmPlVBx6P/e+6qnBsRTH9KHqoRpYTvWlvSUGZ/6QhaIh8DRh X-Received: by 2002:a63:5014:: with SMTP id e20mr2395612pgb.152.1610549437240; Wed, 13 Jan 2021 06:50:37 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1610549437; cv=none; d=google.com; s=arc-20160816; b=XvIUKGrx9/dAcY3idTMfLDfdSXw3MYTa32eSusM+Vj/MZHb5JjWjS5xhaAsVSp9twT 5IpRWGbIGRR1xo8BeIXbi4yYDEXWPkAnUbqU4OzAlX2KTrtlQASX9uT2rcNIO7FDNQUx XLtkhHo/ddSJT7uxDJwZA9za/0OgmyT+eRQ+/3crTtJtlmzR9Zi6Tddoj/O+MhdFMtbK aGo+qRpAunTXu7E3DdVWgZ7TB4Ww7udynNN7CJOf1VJf+ISyiTzOqxL5NZo+I5Lb4XsV X3+qCwfUXuRawM3LDcI3P3Oqgr/8de0QcreYHPSt+oLn4mUyYr+guSIGaD7o84EBWx0z 5ECQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:cc:list-subscribe :list-help:list-post:list-archive:list-unsubscribe:list-id :precedence:mime-version:references:in-reply-to:message-id:date :subject:to:from:dkim-signature:delivered-to; bh=Ljqmj3rA9UMh5Lh19rfCTuUkG/7iIlZWaoxvHvM3Of4=; b=R6+vp7KYkkCdgnKcma1smHC0Z+9BfgDiyeuNNzolZGMEzYrx3+oHrS988fKWZnJNjQ 5NxoA1unhlPbQO4opcffgHpHqTInZ/vRKXUCEW8pDXX4yt9C5zJXGD0FOiRK3bAq+YNB J/QaZvXc71k+zckKMlIqfxqlO3xzoN38DAYaty+G5ZwXO+meQbvEZ85YayIqq4SleEtA 8adOzMx0Zar26kINWW+vICWIz/Tl4+Vv2GHEhnkcUNyazy5wri5gvEmm0IwxX6hEhwGl dGD9/K4OYKAq+4estEe4LUkuyYRLzCe4dyvxURasGHXskKjWLgP6zlYs2G26/jU80onr 389g== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=sst9frRz; spf=pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 2610:10:20:722:a800:ff:fe36:1795 as permitted sender) smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from gabe.freedesktop.org (gabe.freedesktop.org. [2610:10:20:722:a800:ff:fe36:1795]) by mx.google.com with ESMTPS id j20si2460395pfr.164.2021.01.13.06.50.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 13 Jan 2021 06:50:37 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 2610:10:20:722:a800:ff:fe36:1795 as permitted sender) client-ip=2610:10:20:722:a800:ff:fe36:1795; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=sst9frRz; spf=pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 2610:10:20:722:a800:ff:fe36:1795 as permitted sender) smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 552936EA4C; Wed, 13 Jan 2021 14:50:31 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mail-wr1-x436.google.com (mail-wr1-x436.google.com [IPv6:2a00:1450:4864:20::436]) by gabe.freedesktop.org (Postfix) with ESMTPS id 5ECC36EA52 for ; Wed, 13 Jan 2021 14:50:29 +0000 (UTC) Received: by mail-wr1-x436.google.com with SMTP id a12so2391917wrv.8 for ; Wed, 13 Jan 2021 06:50:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=9Pf7w6hja2pyQaiiphc9339t7wWdI+GqQadABJm8g7Y=; b=sst9frRzW/IJefwutBUvPoGyyHkMdmNCE2/2cJ1SvAob/HspH1X56uzjWNN7XPuilz wdKSM/9Hqj3XNtAA/hBuaE7G/g9i5BxwEMY6nf9eunFCXOpEAB+tkTQ53x6HPpg6jtJ5 4/CwTTvIH5eIMy9CUXAYqkwetX52U5C8J5iXu+ftxRcgI6ioB4TaWFUZokVU0jMRv4go iVThPqkc16K5jm14VkBnPxRc0KOF1l7502J6ctNsR0SVyVrAujPyJcOPpNmjUaQa0T2D QXsr/aNolpDchgMH7vINY63kaYmkDnVOFM9EKwvSgcfdyGaw5+y6o1AKmnSdmQwT2uZv +w6g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=9Pf7w6hja2pyQaiiphc9339t7wWdI+GqQadABJm8g7Y=; b=DR+rtkr2T85YbDq2Xp8tN5gn0UjTgXWls3SntR1ew+HfvRjskaQgP46v5iAE6DsTUh yinqfVCKPCtFrz6A5alGdAepzcLadGy5eDR3pUuXFJ5oegfG0WMI3XjywyMWbdCF4iLs pKq3J0L11kbY1pwsO1/Ej6n9yVbc4FfU+z7XOGK3iyRPeqPwSx2DH1Irt4MjNVNd7luO zPGr1frQqJeMY42gzpsxFCuzMY+JcuuVZpT6mhDD67pkfBD5blQOLLkFlXoFp4/9cXPd KRHtzwvqDyNZyjgyjziogTUx6t96KD2v7MuQcQMZg6B6LvJTTUBOyOx5IBawHMqByGb3 IoOw== X-Gm-Message-State: AOAM5309PS/5Cb+u3t4/r2E5SYruALIKpvCv1HIiCOXcnMccNDzbkK81 odsAUzIyjvmCvEcEkTAs8BzexrT0k4riKEYH X-Received: by 2002:adf:f58a:: with SMTP id f10mr3137113wro.338.1610549428139; Wed, 13 Jan 2021 06:50:28 -0800 (PST) Received: from dell.default ([91.110.221.229]) by smtp.gmail.com with ESMTPSA id t188sm3273433wmf.9.2021.01.13.06.50.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 13 Jan 2021 06:50:26 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Subject: [PATCH 09/31] video: fbdev: sis: Remove superfluous include of 'init.h' Date: Wed, 13 Jan 2021 14:49:47 +0000 Message-Id: <20210113145009.1272040-10-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210113145009.1272040-1-lee.jones@linaro.org> References: <20210113145009.1272040-1-lee.jones@linaro.org> MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-fbdev@vger.kernel.org, Thomas Winischhofer , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Neither 'sis.h' nor any of its consumers uses these tables. Fixes the following W=1 kernel build warning(s): drivers/video/fbdev/sis/init.h:144:28: warning: ‘SiS_VGA_DAC’ defined but not used [-Wunused-const-variable=] drivers/video/fbdev/sis/init.h:132:28: warning: ‘SiS_EGA_DAC’ defined but not used [-Wunused-const-variable=] drivers/video/fbdev/sis/init.h:120:28: warning: ‘SiS_CGA_DAC’ defined but not used [-Wunused-const-variable=] drivers/video/fbdev/sis/init.h:108:28: warning: ‘SiS_MDA_DAC’ defined but not used [-Wunused-const-variable=] drivers/video/fbdev/sis/init.h:106:29: warning: ‘ModeIndex_310_2048x1536’ defined but not used [-Wunused-const-variable drivers/video/fbdev/sis/init.h:105:29: warning: ‘ModeIndex_300_2048x1536’ defined but not used [-Wunused-const-variable drivers/video/fbdev/sis/init.h:104:29: warning: ‘ModeIndex_1920x1440’ defined but not used [-Wunused-const-variable=] drivers/video/fbdev/sis/init.h:103:29: warning: ‘ModeIndex_1920x1080’ defined but not used [-Wunused-const-variable=] drivers/video/fbdev/sis/init.h:102:29: warning: ‘ModeIndex_1600x1200’ defined but not used [-Wunused-const-variable=] drivers/video/fbdev/sis/init.h:101:29: warning: ‘ModeIndex_1680x1050’ defined but not used [-Wunused-const-variable=] drivers/video/fbdev/sis/init.h:100:29: warning: ‘ModeIndex_1400x1050’ defined but not used [-Wunused-const-variable=] NB: Snipped - there are 277 of these! Cc: Thomas Winischhofer Cc: dri-devel@lists.freedesktop.org Cc: linux-fbdev@vger.kernel.org Signed-off-by: Lee Jones --- drivers/video/fbdev/sis/sis.h | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/video/fbdev/sis/sis.h b/drivers/video/fbdev/sis/sis.h index 9f4c3093ccb36..d632f096083b3 100644 --- a/drivers/video/fbdev/sis/sis.h +++ b/drivers/video/fbdev/sis/sis.h @@ -15,7 +15,6 @@ #include "vgatypes.h" #include "vstruct.h" -#include "init.h" #define VER_MAJOR 1 #define VER_MINOR 8 From patchwork Wed Jan 13 14:49:48 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 362120 Delivered-To: patch@linaro.org Received: by 2002:a02:ccad:0:0:0:0:0 with SMTP id t13csp598038jap; Wed, 13 Jan 2021 06:50:40 -0800 (PST) X-Google-Smtp-Source: ABdhPJy2yq8cTQ2V1Nv70sec39wzngZwlHPCxaQj44L+cvYEn0NGaZ620XbSQ6qQigc3fAdtazqE X-Received: by 2002:a17:902:b587:b029:de:23ed:88b1 with SMTP id a7-20020a170902b587b02900de23ed88b1mr2712463pls.61.1610549440343; Wed, 13 Jan 2021 06:50:40 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1610549440; cv=none; d=google.com; s=arc-20160816; b=uJEnQ3rH8OID6wAjvSW0OejD+l+iFBH2MlfghIKqKjZVT9QInnfJBv61lN9a/g4aTl /bSLcQkQkX7q94vpUUzuxt5qB662lNaGjB5MKEJcf+CslzXPBMUu/ZocWPjLqH0F+MqZ 5S8/OSyW23Cn4ijDhQndgb4zuflxrNhXhnylWYW0jBBSGJXZCCOL4kaNu/NOelo46jpg 6y+ZkONQ6OgQbV6tOvjzS0YWDyqTtc5kscLdwo5l4cqk4KlpKMs3LL0SYsKLJID4lSuh 1PlVA4BdYD2TXDIrbAGg3p7/2nQ7gOFf1AaFCEBq11AOKugzrooOSg46OlSd1uhXEJK8 UK5A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:cc:list-subscribe :list-help:list-post:list-archive:list-unsubscribe:list-id :precedence:mime-version:references:in-reply-to:message-id:date :subject:to:from:dkim-signature:delivered-to; bh=Po2g87EBiKvsF3C7yqZTUH9UrAHflgNM+7t3RVa2I38=; b=K4l7L0hJn0KTSMTNryIBDdtvBAEYv+X4c2J9t/ulANgebsblVrsYm2VxM6CtMRJRSj NAZ+64QEgv6P7IgnBzgsbHGE+wepWIKA8XolJqUda4BcjVvtlBmFb5pCvE6YM6hqgAoI nafUhFR/B9Wai2zpWl8mAD3Z2IPHK6pVEB3tnzx0xDkB5RTMDAYxurKIVKlQy053YONc XQUVqGDgDzbs8whRPBYYYVS3yeehYKGFrRk7Ucn3AdAtoXfov3o6ujv/EutA68EW0t4Q v22Qmlg88HDQS0kd+t+qKybDWvbZc95ruUJ+/2/20Mu0WGefR3KdezY/GY/FalzmohEm 5NaQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=EJcbDkfK; spf=pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 2610:10:20:722:a800:ff:fe36:1795 as permitted sender) smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from gabe.freedesktop.org (gabe.freedesktop.org. [2610:10:20:722:a800:ff:fe36:1795]) by mx.google.com with ESMTPS id d3si2606356pjj.157.2021.01.13.06.50.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 13 Jan 2021 06:50:40 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 2610:10:20:722:a800:ff:fe36:1795 as permitted sender) client-ip=2610:10:20:722:a800:ff:fe36:1795; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=EJcbDkfK; spf=pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 2610:10:20:722:a800:ff:fe36:1795 as permitted sender) smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id E48CD6EA52; Wed, 13 Jan 2021 14:50:34 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mail-wm1-x329.google.com (mail-wm1-x329.google.com [IPv6:2a00:1450:4864:20::329]) by gabe.freedesktop.org (Postfix) with ESMTPS id 0FB7A6EA52 for ; Wed, 13 Jan 2021 14:50:31 +0000 (UTC) Received: by mail-wm1-x329.google.com with SMTP id y23so1857150wmi.1 for ; Wed, 13 Jan 2021 06:50:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=akZkn4hii3ygwpUSWjXzvWKSUmmw5HI5L5N5wIekgQ0=; b=EJcbDkfKRG16dlT8xRjZ2F6tm3CWsp8WqmfprIForTO/9Y2JsYYNwS4yJL/okHccdL rfFTr0ZxW+4KF1FLysPYPNS/5SpSbjq6qLF+qf8QQszV05GlO7M8iQ6PEmExS8y0nIg/ sXKq7t7hD+h4zaMRifhvTSDH5Hdr8NcJnaksMh1Ba9J0+3WsIZOR3AdDg0zNFFyAxMq3 3m3VnwwWhpB/6kSBEAN7ThxVncEhpfkBGoxPJwk7xzxy9b6Nmo2FutbwW08hTxYU1W9B sx8byNENSxrpQ60i3f4xICBSBhsYi8qdXOOmXcJnE7uFyNJ8w242AIOWEoe7QKSKVv1G 7X2w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=akZkn4hii3ygwpUSWjXzvWKSUmmw5HI5L5N5wIekgQ0=; b=FAWR6Y4he63CstgDBB3yD1YhLmgVLqlorW4QR+yfoLpO6WBQ1iyKOFDB0zpAAzH7xr ZF6flo2dyQ8rhPrrnoPv4yWjUwEGxx+ngm1izyIyPx3IPTqT5jCtuyBn3XeNGGLynzmK eSuxnNiLej3TO2l+fSTisVviuZCdKYC/Bi/1ZWqUlUP8fl2rsEg5Y+GMucFt9ZnE7jWZ xytH8jmSoDnqOh2VuO4UEBe9o1zPZahGaZ3WuBC2Q1H/qQctvV7v4C1PzwbOEeF1eEV0 PLDGzP1Jboamhq9LZ3yyrpYvFctQjNgVDLyERRsWhlonsR4W+2kERJ0UkVVy/06A4Qg5 lGOw== X-Gm-Message-State: AOAM532Q5cYTUq4HoMRMQ3Yr3fAx/+yAAZcj4E2TMbkNTQMOLeYGV78E nrgalspcKlJgzKShYiTHHBI7og== X-Received: by 2002:a7b:c246:: with SMTP id b6mr2582589wmj.154.1610549429735; Wed, 13 Jan 2021 06:50:29 -0800 (PST) Received: from dell.default ([91.110.221.229]) by smtp.gmail.com with ESMTPSA id t188sm3273433wmf.9.2021.01.13.06.50.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 13 Jan 2021 06:50:28 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Subject: [PATCH 10/31] video: fbdev: riva: riva_hw: Remove a bunch of unused variables Date: Wed, 13 Jan 2021 14:49:48 +0000 Message-Id: <20210113145009.1272040-11-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210113145009.1272040-1-lee.jones@linaro.org> References: <20210113145009.1272040-1-lee.jones@linaro.org> MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: dri-devel@lists.freedesktop.org, linux-fbdev@vger.kernel.org, Jeff Garzik , linux-kernel@vger.kernel.org Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Fixes the following W=1 kernel build warning(s): drivers/video/fbdev/riva/riva_hw.c: In function ‘nv10CalcArbitration’: drivers/video/fbdev/riva/riva_hw.c:849:9: warning: variable ‘pclks_2_top_fifo’ set but not used [-Wunused-but-set-variable] drivers/video/fbdev/riva/riva_hw.c:848:43: warning: variable ‘vus_pipe’ set but not used [-Wunused-but-set-variable] drivers/video/fbdev/riva/riva_hw.c:848:21: warning: variable ‘us_pipe’ set but not used [-Wunused-but-set-variable] drivers/video/fbdev/riva/riva_hw.c:848:9: warning: variable ‘craw’ set but not used [-Wunused-but-set-variable] drivers/video/fbdev/riva/riva_hw.c:846:27: warning: variable ‘vlwm’ set but not used [-Wunused-but-set-variable] drivers/video/fbdev/riva/riva_hw.c:844:37: warning: variable ‘video_drain_rate’ set but not used [-Wunused-but-set-variable] drivers/video/fbdev/riva/riva_hw.c:841:21: warning: variable ‘us_extra’ set but not used [-Wunused-but-set-variable] drivers/video/fbdev/riva/riva_hw.c:840:55: warning: variable ‘vbs’ set but not used [-Wunused-but-set-variable] drivers/video/fbdev/riva/riva_hw.c:839:25: warning: variable ‘cas’ set but not used [-Wunused-but-set-variable] Cc: Antonino Daplas Cc: Jeff Garzik Cc: linux-fbdev@vger.kernel.org Cc: dri-devel@lists.freedesktop.org Signed-off-by: Lee Jones --- drivers/video/fbdev/riva/riva_hw.c | 26 ++++++++------------------ 1 file changed, 8 insertions(+), 18 deletions(-) diff --git a/drivers/video/fbdev/riva/riva_hw.c b/drivers/video/fbdev/riva/riva_hw.c index bcf9c4b4de311..4ee63f7d84d3e 100644 --- a/drivers/video/fbdev/riva/riva_hw.c +++ b/drivers/video/fbdev/riva/riva_hw.c @@ -836,17 +836,17 @@ static void nv10CalcArbitration nv10_sim_state *arb ) { - int data, pagemiss, cas,width, video_enable, bpp; - int nvclks, mclks, pclks, vpagemiss, crtpagemiss, vbs; - int nvclk_fill, us_extra; + int data, pagemiss, width, video_enable, bpp; + int nvclks, mclks, pclks, vpagemiss, crtpagemiss; + int nvclk_fill; int found, mclk_extra, mclk_loop, cbs, m1; int mclk_freq, pclk_freq, nvclk_freq, mp_enable; - int us_m, us_m_min, us_n, us_p, video_drain_rate, crtc_drain_rate; + int us_m, us_m_min, us_n, us_p, crtc_drain_rate; int vus_m, vus_n, vus_p; - int vpm_us, us_video, vlwm, cpm_us, us_crt,clwm; + int vpm_us, us_video, cpm_us, us_crt,clwm; int clwm_rnd_down; - int craw, m2us, us_pipe, us_pipe_min, vus_pipe, p1clk, p2; - int pclks_2_top_fifo, min_mclk_extra; + int m2us, us_pipe_min, p1clk, p2; + int min_mclk_extra; int us_min_mclk_extra; fifo->valid = 1; @@ -854,16 +854,13 @@ static void nv10CalcArbitration mclk_freq = arb->mclk_khz; nvclk_freq = arb->nvclk_khz; pagemiss = arb->mem_page_miss; - cas = arb->mem_latency; width = arb->memory_width/64; video_enable = arb->enable_video; bpp = arb->pix_bpp; mp_enable = arb->enable_mp; clwm = 0; - vlwm = 1024; cbs = 512; - vbs = 512; pclks = 4; /* lwm detect. */ @@ -924,17 +921,13 @@ static void nv10CalcArbitration us_min_mclk_extra = min_mclk_extra *1000*1000 / mclk_freq; us_n = nvclks*1000*1000 / nvclk_freq;/* nvclk latency in us */ us_p = pclks*1000*1000 / pclk_freq;/* nvclk latency in us */ - us_pipe = us_m + us_n + us_p; us_pipe_min = us_m_min + us_n + us_p; - us_extra = 0; vus_m = mclk_loop *1000*1000 / mclk_freq; /* Mclk latency in us */ vus_n = (4)*1000*1000 / nvclk_freq;/* nvclk latency in us */ vus_p = 0*1000*1000 / pclk_freq;/* pclk latency in us */ - vus_pipe = vus_m + vus_n + vus_p; if(video_enable) { - video_drain_rate = pclk_freq * 4; /* MB/s */ crtc_drain_rate = pclk_freq * bpp/8; /* MB/s */ vpagemiss = 1; /* self generating page miss */ @@ -993,7 +986,6 @@ static void nv10CalcArbitration else if(crtc_drain_rate * 100 >= nvclk_fill * 98) { clwm = 1024; cbs = 512; - us_extra = (cbs * 1000 * 1000)/ (8*width)/mclk_freq ; } } } @@ -1010,7 +1002,6 @@ static void nv10CalcArbitration m1 = clwm + cbs - 1024; /* Amount of overfill */ m2us = us_pipe_min + us_min_mclk_extra; - pclks_2_top_fifo = (1024-clwm)/(8*width); /* pclk cycles to drain */ p1clk = m2us * pclk_freq/(1000*1000); @@ -1038,14 +1029,13 @@ static void nv10CalcArbitration min_mclk_extra--; } } - craw = clwm; if(clwm < (1024-cbs+8)) clwm = 1024-cbs+8; data = (int)(clwm); /* printf("CRT LWM: %f bytes, prog: 0x%x, bs: 256\n", clwm, data ); */ fifo->graphics_lwm = data; fifo->graphics_burst_size = cbs; - /* printf("VID LWM: %f bytes, prog: 0x%x, bs: %d\n, ", vlwm, data, vbs ); */ + /* printf("VID LWM: 1024 bytes, prog: 0x%x, bs: 512\n, ", data); */ fifo->video_lwm = 1024; fifo->video_burst_size = 512; } } From patchwork Wed Jan 13 14:49:49 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 362121 Delivered-To: patch@linaro.org Received: by 2002:a02:ccad:0:0:0:0:0 with SMTP id t13csp598062jap; Wed, 13 Jan 2021 06:50:42 -0800 (PST) X-Google-Smtp-Source: ABdhPJzkq3mb2w8gSabCRgU2anHER8e/oyu0YxvPEcJZ7Vic+asmG1n+dCNr1Q7c3TX0zWX5rZEy X-Received: by 2002:a63:c908:: with SMTP id o8mr2377732pgg.124.1610549441927; Wed, 13 Jan 2021 06:50:41 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1610549441; cv=none; d=google.com; s=arc-20160816; b=nGGra1s5OomxtMmIROLeVY9nL4WROiPFgSekeVKg1V/Arr0s3czcPAsmGUxsN91/8q p9nUMtryviYGrLlebKX7+G697AKdhG0UU0Rt+Z4yyreMDHwKoRZ+dPXJRKgajiVE8KUZ hM8s4NTtInCbxLnYydAGY9SHsuTa2ytkOLyIyl04h7RgvIFVTqkwKW/1ZSgKUdGSZUmv g78sQkWgPviY3ZPgf5Rx8B6Sq4VTMizSi3tcINJJFR3TNyMZVXR9HGY8XQsY772c65/2 V2mse72T14IDO5WNXRziKtowJOZsl/9LQc32PY/a8b8RxE0tWyZzYy6p9m+Hj4b55bps kfZg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:cc:list-subscribe :list-help:list-post:list-archive:list-unsubscribe:list-id :precedence:mime-version:references:in-reply-to:message-id:date :subject:to:from:dkim-signature:delivered-to; bh=nHtRi31qCoro5f5wEviDJXZWLlKJWdbu+oKne/AXAnk=; b=av7kFlS9LoRe8Fr9GjiZwPZzDr+zoK4r51fJjdmLa2sw9a6SIoIlDGbYTX7/pUw9Lh JUXPRrRZ6dqkZvl1cqOdXwHWuCh7hgkRXPLYP7rfvIVnxtZInXmm40zfzkSzDhSNuqfX /YNAT1XLk75GzyCfFAlTVb6PE3vQJ/uQwIwsWUDdzfCCMsbL5MiEc3xXikmgv3S6/FgE 1/1jEvaQhyp7OPKa7r9WG3o5Xx9vXISGcKZ1nvCss/Ap9rTmGpjMLtNu5TM+u0DueXmH feo0gdO4GA2NUEuttNeJDqogGHijRD6uVuAZEYjrA7Hci3/QVRMgJdgHkRGOp76vhmc8 5cbA== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=akpdEhMJ; spf=pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 131.252.210.177 as permitted sender) smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from gabe.freedesktop.org (gabe.freedesktop.org. [131.252.210.177]) by mx.google.com with ESMTPS id i66si2567028pfe.325.2021.01.13.06.50.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 13 Jan 2021 06:50:41 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 131.252.210.177 as permitted sender) client-ip=131.252.210.177; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=akpdEhMJ; spf=pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 131.252.210.177 as permitted sender) smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id E55EE6EA58; Wed, 13 Jan 2021 14:50:34 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mail-wm1-x331.google.com (mail-wm1-x331.google.com [IPv6:2a00:1450:4864:20::331]) by gabe.freedesktop.org (Postfix) with ESMTPS id 89DFA6EA51 for ; Wed, 13 Jan 2021 14:50:32 +0000 (UTC) Received: by mail-wm1-x331.google.com with SMTP id h17so1654152wmq.1 for ; Wed, 13 Jan 2021 06:50:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=UBertLrO50IMon3TZ4gj0CSxI3Yqy8ksl/8MP2cv2iw=; b=akpdEhMJh2ARCHyoNNx9VPJuhAoo9/Y4QVqEYnbUJ0Hy/4xwAFnitREVMt08+c+3Qu Kc2u8TwF4caPKUyn75DQBoHuu3wGDMO0r2V3p0Yo+d9smk9uBH9HBLge1hMCGnifQUR9 JjsszdKmG43arb7E46nkyyLFqd/tXDE7Y7P9jv3oeKYHpCIPG8OOt+aQ4sR1/nWloE2f 51Wwa7J/1t45aqUrswNJxn0kk2k4+oGZ23ac7biP9+idnJfOmRnbqPHH2PwdliX+83OH bnrAP/8D7ucxpARodtDBgI/9O7O5s2Vfm3AXS7vGGur65NmXvY4JTtIa3YxDSPJQGQVk BZgw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=UBertLrO50IMon3TZ4gj0CSxI3Yqy8ksl/8MP2cv2iw=; b=AXqxA70rPPA9N+DrzEHa2+g4L0cQ1lKnteuD4VHVb+IYvXgnQOh1tA3AtEfRd10HEv dF5q0Ie/rUDlM/IMcfG3fP4cFfDvq6Uwq03ouEty8jFX8o91pBE3wXxzE3SmPRXqtOEq 74fa+xLVT5y+yAxEIvUDSt9dhMM9crhZf5UIX9l5QX5n2KbqdTfB5MdSnCBI5NMMId/w D9Im+hjqNVhrByt6oQ7qtPwOJpsDJJEcQciQLDjLYnMwGJHSUlVeSiXeiVqtV836tKAL AXVmvtVXRYLahiiWvjBLReirVKWc93aIruFtyK4mwMjvNLpIrDRDYB0ANZyEqDI7wS1p 5UOw== X-Gm-Message-State: AOAM530117+2buHq35+iCZmbkFrw3uhcobj5zGAebt9U25/4e0Sx+dxe u9f429p4UYg6RJiJAtmsP4nrrQ== X-Received: by 2002:a7b:c10e:: with SMTP id w14mr2520321wmi.161.1610549431282; Wed, 13 Jan 2021 06:50:31 -0800 (PST) Received: from dell.default ([91.110.221.229]) by smtp.gmail.com with ESMTPSA id t188sm3273433wmf.9.2021.01.13.06.50.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 13 Jan 2021 06:50:30 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Subject: [PATCH 11/31] video: fbdev: sis: init: Remove four unused variables Date: Wed, 13 Jan 2021 14:49:49 +0000 Message-Id: <20210113145009.1272040-12-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210113145009.1272040-1-lee.jones@linaro.org> References: <20210113145009.1272040-1-lee.jones@linaro.org> MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-fbdev@vger.kernel.org, Thomas Winischhofer , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Fixes the following W=1 kernel build warning(s): drivers/video/fbdev/sis/init.c: In function ‘SiS_SetCRT1ModeRegs’: drivers/video/fbdev/sis/init.c:2651:49: warning: variable ‘resindex’ set but not used [-Wunused-but-set-variable] drivers/video/fbdev/sis/init.c: In function ‘SiS_Generic_ConvertCRData’: drivers/video/fbdev/sis/init.c:3544:19: warning: variable ‘A’ set but not used [-Wunused-but-set-variable] drivers/video/fbdev/sis/init.c:3542:34: warning: variable ‘VBS’ set but not used [-Wunused-but-set-variable] drivers/video/fbdev/sis/init.c:3541:34: warning: variable ‘HBS’ set but not used [-Wunused-but-set-variable] Cc: Thomas Winischhofer Cc: dri-devel@lists.freedesktop.org Cc: linux-fbdev@vger.kernel.org Signed-off-by: Lee Jones --- drivers/video/fbdev/sis/init.c | 21 +++++---------------- 1 file changed, 5 insertions(+), 16 deletions(-) diff --git a/drivers/video/fbdev/sis/init.c b/drivers/video/fbdev/sis/init.c index fde27feae5d0c..4510272ad297a 100644 --- a/drivers/video/fbdev/sis/init.c +++ b/drivers/video/fbdev/sis/init.c @@ -2648,7 +2648,7 @@ static void SiS_SetCRT1ModeRegs(struct SiS_Private *SiS_Pr, unsigned short ModeNo, unsigned short ModeIdIndex, unsigned short RRTI) { - unsigned short data, infoflag = 0, modeflag, resindex; + unsigned short data, infoflag = 0, modeflag; #ifdef CONFIG_FB_SIS_315 unsigned char *ROMAddr = SiS_Pr->VirtualRomBase; unsigned short data2, data3; @@ -2659,7 +2659,7 @@ SiS_SetCRT1ModeRegs(struct SiS_Private *SiS_Pr, unsigned short ModeNo, if(SiS_Pr->UseCustomMode) { infoflag = SiS_Pr->CInfoFlag; } else { - resindex = SiS_GetResInfo(SiS_Pr, ModeNo, ModeIdIndex); + SiS_GetResInfo(SiS_Pr, ModeNo, ModeIdIndex); if(ModeNo > 0x13) { infoflag = SiS_Pr->SiS_RefIndex[RRTI].Ext_InfoFlag; } @@ -3538,16 +3538,15 @@ SiS_Generic_ConvertCRData(struct SiS_Private *SiS_Pr, unsigned char *crdata, struct fb_var_screeninfo *var, bool writeres ) { - unsigned short HRE, HBE, HRS, HBS, HDE, HT; - unsigned short VRE, VBE, VRS, VBS, VDE, VT; + unsigned short HRE, HBE, HRS, HDE, HT; + unsigned short VRE, VBE, VRS, VDE, VT; unsigned char sr_data, cr_data, cr_data2; - int A, B, C, D, E, F, temp; + int B, C, D, E, F, temp; sr_data = crdata[14]; /* Horizontal total */ HT = crdata[0] | ((unsigned short)(sr_data & 0x03) << 8); - A = HT + 5; /* Horizontal display enable end */ HDE = crdata[1] | ((unsigned short)(sr_data & 0x0C) << 6); @@ -3557,9 +3556,6 @@ SiS_Generic_ConvertCRData(struct SiS_Private *SiS_Pr, unsigned char *crdata, HRS = crdata[4] | ((unsigned short)(sr_data & 0xC0) << 2); F = HRS - E - 3; - /* Horizontal blank start */ - HBS = crdata[2] | ((unsigned short)(sr_data & 0x30) << 4); - sr_data = crdata[15]; cr_data = crdata[5]; @@ -3593,7 +3589,6 @@ SiS_Generic_ConvertCRData(struct SiS_Private *SiS_Pr, unsigned char *crdata, ((unsigned short)(cr_data & 0x01) << 8) | ((unsigned short)(cr_data & 0x20) << 4) | ((unsigned short)(sr_data & 0x01) << 10); - A = VT + 2; /* Vertical display enable end */ VDE = crdata[10] | @@ -3611,12 +3606,6 @@ SiS_Generic_ConvertCRData(struct SiS_Private *SiS_Pr, unsigned char *crdata, cr_data2 = (crdata[16] & 0x01) << 5; - /* Vertical blank start */ - VBS = crdata[11] | - ((unsigned short)(cr_data & 0x08) << 5) | - ((unsigned short)(cr_data2 & 0x20) << 4) | - ((unsigned short)(sr_data & 0x04) << 8); - /* Vertical blank end */ VBE = crdata[12] | ((unsigned short)(sr_data & 0x10) << 4); temp = VBE - ((E - 1) & 511); From patchwork Wed Jan 13 14:49:50 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 362123 Delivered-To: patch@linaro.org Received: by 2002:a02:ccad:0:0:0:0:0 with SMTP id t13csp598100jap; Wed, 13 Jan 2021 06:50:44 -0800 (PST) X-Google-Smtp-Source: ABdhPJy7KRYZxtUmX4oJW9P2CxwXRr6mx5cWwpJDoktWR8ciGru1CBWThMlEXQkCi+z5b6/Weic6 X-Received: by 2002:a17:90b:228e:: with SMTP id kx14mr2931667pjb.210.1610549444545; Wed, 13 Jan 2021 06:50:44 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1610549444; cv=none; d=google.com; s=arc-20160816; b=a8Mto0T4uPBS730mSFXSGV6hKXkS624or4ZaxciOzI7mfPKnCsHvAX2K12TZL2YA+I sud7QJbgOuXHvaj9U6C7hTyAeLWQArw8FknyvQpAuqXUWRrlQrmjTAaCCCNS6yDk4YFE rRNSwad92i+KHlnEAH6EfvcEDzEsdTsfYrFcA5WqskGMc4CElPp6fi9kUaYaD/6GEs9r E5TfZZltYkKrXqcsaZwfObLGKn5CNAJryjItv39/4lrjGvlevcT5Y7aVGtIsCRdUI6Pa vwX/DM7so7P+TYtV+8OkXaAJD4NrNS6UiCJF6ANJiuR7mkXf8eO6M1odQpa0k5Iu+Wrt PwZQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:cc:list-subscribe :list-help:list-post:list-archive:list-unsubscribe:list-id :precedence:mime-version:references:in-reply-to:message-id:date :subject:to:from:dkim-signature:delivered-to; bh=122zy1Leapu33F833YqexILY56/HpQ7MohJf8FHvtH0=; b=IZP7Z3WbtH2hWfZNSUsPV+6x5K+iY6ZgMjRnwkIDaDsuKPLHoqobyG66G/THBNqcTn ga+wymsJSLqj5e1gA79ZD83xxe1tkisxmCv3GNv3391NNE6/857jEYXlFXoD3TaqeATG KP2MnjmOR1WuPdKxkhor6c3hg/VWEVGhGXejjRvEQNN3iMBQzCC9/A+3x173Tzj5Lg1s RlfyMBkDDdnui+8d4+hbqEtsg/xAB9oWVLyy1DiQbcMenvpDzi4hs0QlpX7+YozVIlck Mt41Q4qe00kn5kFH7gOwi//TAZNo7BrGb7nKhrJ7+KxAi8TXgpe2KbF6I6IBFhnokbf8 ooZg== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=wkKY3gUV; spf=pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 2610:10:20:722:a800:ff:fe36:1795 as permitted sender) smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from gabe.freedesktop.org (gabe.freedesktop.org. [2610:10:20:722:a800:ff:fe36:1795]) by mx.google.com with ESMTPS id bd3si2543847plb.303.2021.01.13.06.50.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 13 Jan 2021 06:50:44 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 2610:10:20:722:a800:ff:fe36:1795 as permitted sender) client-ip=2610:10:20:722:a800:ff:fe36:1795; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=wkKY3gUV; spf=pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 2610:10:20:722:a800:ff:fe36:1795 as permitted sender) smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id B530E6EA5B; Wed, 13 Jan 2021 14:50:38 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mail-wm1-x336.google.com (mail-wm1-x336.google.com [IPv6:2a00:1450:4864:20::336]) by gabe.freedesktop.org (Postfix) with ESMTPS id AFD9B6EA51 for ; Wed, 13 Jan 2021 14:50:34 +0000 (UTC) Received: by mail-wm1-x336.google.com with SMTP id g10so1855229wmh.2 for ; Wed, 13 Jan 2021 06:50:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=j7fOAdOMSh9+aZXnWVlTBiJqXaPtT0tmJFJgVlyDPug=; b=wkKY3gUVpw4qP/WuQzc8XjrzRncVeSuZ6NzeUbALePTgU3Yrbw7YLTdHcXZj56nxVU 5Jh4wNloszsqH/vVqJxDDwBSRrJ2OCTzKTPcd5JzNVT5XIiv2M5crt5y5UskqbNAQTBB KvR9s7UwwCew+cXB1M/8JHMnIwXdbQxIScTfFklRChWJUy40Q3CuOodobSh9Um18qIvs FEHYZzDJPaKk06OPv4/h1Mi2+ufc5Xt/BqkVcO0w1K9kWocAZk5NMITW/2XtGYuEHFGY KaZnlzcDkLV1OrVCrmMpjQPrdUpM4TmeGqpdDN4K+fWyND84c6a9egSMvCEW1eojZ/Tv wkMw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=j7fOAdOMSh9+aZXnWVlTBiJqXaPtT0tmJFJgVlyDPug=; b=Uvozc5ph6J3v8VkwZP5FC+ZRbpdY2cc/Xo+6R6gbbxk5JycLbMgdYj9w3dfX1hRROz 9aBgCwRCz/jJwOO2jZj8rWqdOUdeq9xfl5g0m0gQHz/zSuVbjpe6aTbFhHBXcdHFKOWr ZfUdCQnV2NNsu23N00Qt8PwpXQwQVAGbJ/FZF8ecd88mRHJ8M8jQSuiKuLz5rOKnGPGB JsDy7f6aYusHHCkCBQNvfea1mKuLjtDJJaQxjkbSxyohKRV7Y38ZqeX4S/wpGDUEgmmh p1M2vFEPjbsU38GaXKiy8qibpFp65m74Y6fl1Woqm2nVhRW5FduBqWJdFOLsp+pMB12r vO7A== X-Gm-Message-State: AOAM532xNHPJKcG68Gb6db1IXnvR9d06qdG2K3e4OIgqFjiBdWqijSCp 48Daeq9hgE3ZIboM3pYGUWgdeA== X-Received: by 2002:a1c:cc14:: with SMTP id h20mr2564071wmb.180.1610549433405; Wed, 13 Jan 2021 06:50:33 -0800 (PST) Received: from dell.default ([91.110.221.229]) by smtp.gmail.com with ESMTPSA id t188sm3273433wmf.9.2021.01.13.06.50.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 13 Jan 2021 06:50:32 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Subject: [PATCH 12/31] video: fbdev: sis: oem310: Remove some unused static const tables Date: Wed, 13 Jan 2021 14:49:50 +0000 Message-Id: <20210113145009.1272040-13-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210113145009.1272040-1-lee.jones@linaro.org> References: <20210113145009.1272040-1-lee.jones@linaro.org> MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-fbdev@vger.kernel.org, Thomas Winischhofer , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Fixes the following W=1 kernel build warning(s): drivers/video/fbdev/sis/oem310.h:213:28: warning: ‘SiS_TVDelay661_301B’ defined but not used [-Wunused-const-variable=] drivers/video/fbdev/sis/oem310.h:203:28: warning: ‘SiS_TVDelay661_301’ defined but not used [-Wunused-const-variable=] Cc: Thomas Winischhofer Cc: dri-devel@lists.freedesktop.org Cc: linux-fbdev@vger.kernel.org Signed-off-by: Lee Jones --- drivers/video/fbdev/sis/oem310.h | 20 -------------------- 1 file changed, 20 deletions(-) diff --git a/drivers/video/fbdev/sis/oem310.h b/drivers/video/fbdev/sis/oem310.h index 8fce56e4482c0..5f7b503ed2a06 100644 --- a/drivers/video/fbdev/sis/oem310.h +++ b/drivers/video/fbdev/sis/oem310.h @@ -200,26 +200,6 @@ static const unsigned char SiS310_TVDelayCompensation_651302LV[] = /* M650, 651, 0x33,0x33 }; -static const unsigned char SiS_TVDelay661_301[] = /* 661, 301 */ -{ - 0x44,0x44, - 0x44,0x44, - 0x00,0x00, - 0x44,0x44, - 0x44,0x44, - 0x44,0x44 -}; - -static const unsigned char SiS_TVDelay661_301B[] = /* 661, 301B et al */ -{ - 0x44,0x44, - 0x44,0x44, - 0x00,0x00, - 0x44,0x44, - 0x44,0x44, - 0x44,0x44 -}; - static const unsigned char SiS310_TVDelayCompensation_LVDS[] = /* LVDS */ { 0x0a,0x0a, From patchwork Wed Jan 13 14:49:51 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 362122 Delivered-To: patch@linaro.org Received: by 2002:a02:ccad:0:0:0:0:0 with SMTP id t13csp598079jap; Wed, 13 Jan 2021 06:50:43 -0800 (PST) X-Google-Smtp-Source: ABdhPJwqhL2tceV6xm79+YDg6BARp42fvTe9knKYHhtpOq+8T6vldiWAYT4TVX2XRlpH9GCWDpS6 X-Received: by 2002:a17:90a:a44:: with SMTP id o62mr2838525pjo.209.1610549443235; Wed, 13 Jan 2021 06:50:43 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1610549443; cv=none; d=google.com; s=arc-20160816; b=kEFC1FHS5mUlPANNc8771Rz7uYV6xjrXsQPQRvbz30PCR0F4qZmEzeUeITfe2/eg8H ee3secjEU8jDlgigy3ZvADSA0NmGcKzuN4elHm5tYu9N7ioaY9QlN1PJCvYP+I4xMdpe 3H5LZLgep5DBZcdIYRj/7rnSZtlb6qrMHosQoSEWra0Nt6gZBwxxVqHE307Wy5LAXZit qJ2csKt0x3XFGFeYK5JyFBMNuEJGLV7jRPvqLdLyoe4fb7rD6jz09p0n4gT/mUN+6O+h S/U4McZC4nMY4y3Jcb2w7xe/we/MfMgw7CXlFAg2c5PdjD7CbUFc3FivVIZ25x3L3WZa LpdQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:cc:list-subscribe :list-help:list-post:list-archive:list-unsubscribe:list-id :precedence:mime-version:references:in-reply-to:message-id:date :subject:to:from:dkim-signature:delivered-to; bh=juO5k1R/qklidPlekz4+c5KqtLfSSKDtXeBPGwtpCD4=; b=D3MShSTERtSrCEAi9lNeRZlyNdeRM+/eiVj/lyYzwhKCMtByR/+XGnwMFpuQ9cebHO 81JpbPOVHmz7s83oXCsotto9UfSN4jAvEI9CRKCsRBQdoi1f3qRGTU5iONqLe0iqCyBU 5FslMv+bdLAv7tjgiCfdFm6HbDdEflaB/JjdOgtcU0A5lkjMVSh0Z8Gf+5vIXbJeENWl 10ORecBh4JOoWAe+RfoQ1fHKj5ku1ADdTgb6YpdXTvn2OKaw4ptu8ol7C4pd33WTH5a3 lL6Tq/JyCF7uzY/i5S6oyG3qy5Vj3qL9e7sRHEnsqbiAwkdat/QzygNKKEEumd/JiW83 J8LQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=WKJOrwZ9; spf=pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 2610:10:20:722:a800:ff:fe36:1795 as permitted sender) smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from gabe.freedesktop.org (gabe.freedesktop.org. [2610:10:20:722:a800:ff:fe36:1795]) by mx.google.com with ESMTPS id p14si2368426pjj.161.2021.01.13.06.50.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 13 Jan 2021 06:50:43 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 2610:10:20:722:a800:ff:fe36:1795 as permitted sender) client-ip=2610:10:20:722:a800:ff:fe36:1795; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=WKJOrwZ9; spf=pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 2610:10:20:722:a800:ff:fe36:1795 as permitted sender) smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 09A9C6EA5A; Wed, 13 Jan 2021 14:50:38 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mail-wm1-x32a.google.com (mail-wm1-x32a.google.com [IPv6:2a00:1450:4864:20::32a]) by gabe.freedesktop.org (Postfix) with ESMTPS id 2BF2A6EA5A for ; Wed, 13 Jan 2021 14:50:36 +0000 (UTC) Received: by mail-wm1-x32a.google.com with SMTP id c124so1837356wma.5 for ; Wed, 13 Jan 2021 06:50:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=hcCYDUMcS26jDuM5+gRx+fiSHXa/31pKXfkIX189fZc=; b=WKJOrwZ97W06sGNe/8643fsBAhUrIy3pw+p8/Z4nnVsXP2eywnUTF/fuu6aqQ7IqnV 6bqyAhBD4abY+s60Rl5IZigMaAmPXz8Uw2c1DpBJK4PQxmaJxmh9tA+R2LxW1BhiiZTk yiuf3i9VtB5gHvfNiYKnHs1w8ffM0OURr8SS6DOOcwdI/uLEYMkd3eiV0TcMkLorYNz2 63JkGhf4cM01/SzrmAxd+HQf+HPnQA/eQoOZlRp6Lb9kAQGSlV4OiRy91CNfm/Ap5ieG bufuyVkbrh7vj7Mtxphu1YXK2MYICuU0icBn09Vb30KwCkk8oOWznjZavOmb2Rr1w40u CRDw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=hcCYDUMcS26jDuM5+gRx+fiSHXa/31pKXfkIX189fZc=; b=kzWIEhcvNznKrlmxVhVHqvkJp3bRAC9/F5K6S9zcuUTN/E0TsD9qrSemOSX0axFLjh eeckPHDsU5TQrOFD1G29W8qs7o1lxoEOtD+Ki+zcnPr/GpVjZAqdd686RNa/3L1Lk9WV 8At89pno3GffwXyVbXRlpgxz/zZRXPG2esF/a1SXIlRlnvuUhEa0KvfmJfTqmaM47b+9 OvRoV7ZhZ5KrkR2ZGgAYMbe8zoz/7znnrrIjai2/r8gQ00i0RGFF+haeuh7/9SsKEgQs ohRr1vNi8TZOPKQWm2wnBb5xSlxMpDpgVOdQI8iaIlFvDBeKeUZ9DVNzO417xd4s6G8n 3SLw== X-Gm-Message-State: AOAM530lxeIxn0kYJvSYgxQi13IUZsIbVK2AOSQOKzaNWNCy+e7jOEgD XVCKMttUJKSQl08A9HTCSwy8/Q== X-Received: by 2002:a1c:2d92:: with SMTP id t140mr2585614wmt.114.1610549434915; Wed, 13 Jan 2021 06:50:34 -0800 (PST) Received: from dell.default ([91.110.221.229]) by smtp.gmail.com with ESMTPSA id t188sm3273433wmf.9.2021.01.13.06.50.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 13 Jan 2021 06:50:34 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Subject: [PATCH 13/31] video: fbdev: nvidia: nv_setup: Remove a couple of unused 'tmp' variables Date: Wed, 13 Jan 2021 14:49:51 +0000 Message-Id: <20210113145009.1272040-14-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210113145009.1272040-1-lee.jones@linaro.org> References: <20210113145009.1272040-1-lee.jones@linaro.org> MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: dri-devel@lists.freedesktop.org, linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Fixes the following W=1 kernel build warning(s): drivers/video/fbdev/nvidia/nv_setup.c: In function ‘NVWriteAttr’: drivers/video/fbdev/nvidia/nv_setup.c:92:14: warning: variable ‘tmp’ set but not used [-Wunused-but-set-variable] drivers/video/fbdev/nvidia/nv_setup.c: In function ‘NVReadAttr’: drivers/video/fbdev/nvidia/nv_setup.c:104:14: warning: variable ‘tmp’ set but not used [-Wunused-but-set-variable] Cc: Antonino Daplas Cc: linux-fbdev@vger.kernel.org Cc: dri-devel@lists.freedesktop.org Signed-off-by: Lee Jones --- drivers/video/fbdev/nvidia/nv_setup.c | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/drivers/video/fbdev/nvidia/nv_setup.c b/drivers/video/fbdev/nvidia/nv_setup.c index 2fa68669613af..47a96a066f998 100644 --- a/drivers/video/fbdev/nvidia/nv_setup.c +++ b/drivers/video/fbdev/nvidia/nv_setup.c @@ -89,9 +89,7 @@ u8 NVReadSeq(struct nvidia_par *par, u8 index) } void NVWriteAttr(struct nvidia_par *par, u8 index, u8 value) { - volatile u8 tmp; - - tmp = VGA_RD08(par->PCIO, par->IOBase + 0x0a); + VGA_RD08(par->PCIO, par->IOBase + 0x0a); if (par->paletteEnabled) index &= ~0x20; else @@ -101,9 +99,7 @@ void NVWriteAttr(struct nvidia_par *par, u8 index, u8 value) } u8 NVReadAttr(struct nvidia_par *par, u8 index) { - volatile u8 tmp; - - tmp = VGA_RD08(par->PCIO, par->IOBase + 0x0a); + VGA_RD08(par->PCIO, par->IOBase + 0x0a); if (par->paletteEnabled) index &= ~0x20; else From patchwork Wed Jan 13 14:49:52 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 362124 Delivered-To: patch@linaro.org Received: by 2002:a02:ccad:0:0:0:0:0 with SMTP id t13csp598116jap; Wed, 13 Jan 2021 06:50:45 -0800 (PST) X-Google-Smtp-Source: ABdhPJyx+P5W1hlYx6NOOI7fw7TzXK/kYMFzPXhxm+xezcOwaO78g6VdW4AyWc8vyHPkVQWONpoQ X-Received: by 2002:a63:b66:: with SMTP id a38mr2354778pgl.331.1610549445743; Wed, 13 Jan 2021 06:50:45 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1610549445; cv=none; d=google.com; s=arc-20160816; b=dmDnBaONOdZs72Oq7io8ZBKxNUvbnbQEjnQb1G6wUF7DKPnNSnTQVf/oiYwTtLoopl 7ZKP0PE4PelIJIA5vkCvzANZcPfDCogq6nf6FLreKJV1e5fZkNq8UAzB4CKQ1PtzJy5x oeqtZexw0QRSythfsGocDowi3ZdWQdtlCnQKXyqh9SYUXy087q7IcFTxuEWciumTQQY7 LiOphEEBk+Qhi6I91efXw31eRVIi7+ZAsVKvLpyPogPinFShNUs5v1xoFvyMMMrnkfrF 1bZ9PCxoGEeFIJRaydjAF+CTkpqfPWw0b/iFRUZxThDGVIRhfycFKWn3UMOo1kPaqDaH 4JAg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:cc:list-subscribe :list-help:list-post:list-archive:list-unsubscribe:list-id :precedence:mime-version:references:in-reply-to:message-id:date :subject:to:from:dkim-signature:delivered-to; bh=m4yNBoLl3WNYHTm9PkdMWPF1Y9zS49kCruZXpSMN1uo=; b=JFHGRSG7HGls4mmZpgtYJRBbubLsb8NOeTAnHLDlr2pX4bFeW9/x9+ltAS40tbZ11b UAt16ti0NEvGwCLCTR8weLLLQptYE7QbawHJbM2MBek1lNHLKaZyUOv1dtiMAo+jtpO3 CTJ78Qt+l6Xw1wNQ/CnriFBNTRqDF6j3unCLlWMKi6w4XTmnMoxPN/136zV4/wtZtDjd /zIPOSNMi592Tv+3Wy1Mc6geXLaH1ZP8KuGZVKkyvjLGUvcchuHZPeQLwBgly9l4Utrh C6u3aYhOXCnZODV4F3YD//hGHFdn+dcyFLGfvQLQMnnP+wwbmmdlWaje6PEhvFsvqcHF DErA== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=S9AVj327; spf=pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 131.252.210.177 as permitted sender) smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from gabe.freedesktop.org (gabe.freedesktop.org. [131.252.210.177]) by mx.google.com with ESMTPS id b10si2600400plk.165.2021.01.13.06.50.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 13 Jan 2021 06:50:45 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 131.252.210.177 as permitted sender) client-ip=131.252.210.177; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=S9AVj327; spf=pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 131.252.210.177 as permitted sender) smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 4832B6EA5C; Wed, 13 Jan 2021 14:50:39 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mail-wm1-x32d.google.com (mail-wm1-x32d.google.com [IPv6:2a00:1450:4864:20::32d]) by gabe.freedesktop.org (Postfix) with ESMTPS id B4CC36EA5A for ; Wed, 13 Jan 2021 14:50:37 +0000 (UTC) Received: by mail-wm1-x32d.google.com with SMTP id c124so1837426wma.5 for ; Wed, 13 Jan 2021 06:50:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=dqYcKMvvBegfm3VenU/QB6olxRoFuHKFr2cjTUmqS/8=; b=S9AVj327o2YowF2UVDBy78wryMVcbl0h9+66FkKjsJ6i8WFxR9bdMBpvD09HQSKrBK vo1ZGwrQgRIbO8nXV14mGFMY7xN/8efJxg72LA+jGfLxFGqANW5Hq1Sp7x03fIgx6wh9 GIQHviMB4xL7Ezvs1yhHlV4tpH+kRDmAfbGsmQRRzOL0kTysvdv5asLys1CLRMxMQw3j KSElJsxQsL2ag8A2zAltelJHGfRZI0Wa5LkJq72Dlg5v5NEk61ys0mgDyU45DAojoCL2 n+AyXgib6ItiEzC+zdVYwT+v/wpNd5HLgmYqxPkzAM1ka3F9mHglqwUXvhnOweZ6cRBz nA+A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=dqYcKMvvBegfm3VenU/QB6olxRoFuHKFr2cjTUmqS/8=; b=VBzHgHYj4KezCRJfzW7vYsEV7F4idqeYXjbPcAry5oU+HjXR8Q9NoZXNihNur4aM6B ziF7FaIBgAwsCYdeOa2aTQSK6kZhkElLLAb2/jRgj4VcQAj35C4sasGBWTpG5Q5RsCqp FlcW8Pv00ISwsOrYuuXiB9lVYe5u5xRJDb3CFqUUM2lf088z39QzcGmb13IUShKV76yr zABr4NUbR8o6rZGJX5k8SuWHB2V1+Rp4u7IubnPX/uUS4ZhQPcsHS5JIpGws5+faQwLy j4mk2fB3bvlGsCOBddG62PESoG1FpwKZFLtbWt/0liT+zMqhAYK3uvHragqK3nUmXjpN xEhg== X-Gm-Message-State: AOAM531T9Zk9KMlw/zaelrIkEyzSZbxGJbdDcu+kxXUsFZV3Kxh1lJGi 9T5uC9qNIpeeAvcE5IkWUp7JX2+B9VK4u2Ul X-Received: by 2002:a05:600c:2255:: with SMTP id a21mr2599659wmm.122.1610549436394; Wed, 13 Jan 2021 06:50:36 -0800 (PST) Received: from dell.default ([91.110.221.229]) by smtp.gmail.com with ESMTPSA id t188sm3273433wmf.9.2021.01.13.06.50.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 13 Jan 2021 06:50:35 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Subject: [PATCH 14/31] video: fbdev: aty: mach64_ct: Remove some set but unused variables Date: Wed, 13 Jan 2021 14:49:52 +0000 Message-Id: <20210113145009.1272040-15-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210113145009.1272040-1-lee.jones@linaro.org> References: <20210113145009.1272040-1-lee.jones@linaro.org> MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: daniel.mantione@freepascal.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-fbdev@vger.kernel.org Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Fixes the following W=1 kernel build warning(s): drivers/video/fbdev/aty/mach64_ct.c: In function ‘aty_init_pll_ct’: drivers/video/fbdev/aty/mach64_ct.c:405:46: warning: variable ‘vga_dsp_on_off’ set but not used [-Wunused-but-set-variable] drivers/video/fbdev/aty/mach64_ct.c:405:30: warning: variable ‘vga_dsp_config’ set but not used [-Wunused-but-set-variable] drivers/video/fbdev/aty/mach64_ct.c:405:18: warning: variable ‘dsp_on_off’ set but not used [-Wunused-but-set-variable] Cc: daniel.mantione@freepascal.org Cc: dri-devel@lists.freedesktop.org Cc: linux-fbdev@vger.kernel.org Signed-off-by: Lee Jones --- drivers/video/fbdev/aty/mach64_ct.c | 19 ++----------------- 1 file changed, 2 insertions(+), 17 deletions(-) diff --git a/drivers/video/fbdev/aty/mach64_ct.c b/drivers/video/fbdev/aty/mach64_ct.c index f87cc81f4fa2b..23eececa1e9d7 100644 --- a/drivers/video/fbdev/aty/mach64_ct.c +++ b/drivers/video/fbdev/aty/mach64_ct.c @@ -402,7 +402,7 @@ static int aty_init_pll_ct(const struct fb_info *info, union aty_pll *pll) struct atyfb_par *par = (struct atyfb_par *) info->par; u8 mpost_div, xpost_div, sclk_post_div_real; u32 q, memcntl, trp; - u32 dsp_config, dsp_on_off, vga_dsp_config, vga_dsp_on_off; + u32 dsp_config; #ifdef DEBUG int pllmclk, pllsclk; #endif @@ -488,25 +488,10 @@ static int aty_init_pll_ct(const struct fb_info *info, union aty_pll *pll) /* Allow BIOS to override */ dsp_config = aty_ld_le32(DSP_CONFIG, par); - dsp_on_off = aty_ld_le32(DSP_ON_OFF, par); - vga_dsp_config = aty_ld_le32(VGA_DSP_CONFIG, par); - vga_dsp_on_off = aty_ld_le32(VGA_DSP_ON_OFF, par); if (dsp_config) pll->ct.dsp_loop_latency = (dsp_config & DSP_LOOP_LATENCY) >> 16; -#if 0 - FIXME: is it relevant for us? - if ((!dsp_on_off && !M64_HAS(RESET_3D)) || - ((dsp_on_off == vga_dsp_on_off) && - (!dsp_config || !((dsp_config ^ vga_dsp_config) & DSP_XCLKS_PER_QW)))) { - vga_dsp_on_off &= VGA_DSP_OFF; - vga_dsp_config &= VGA_DSP_XCLKS_PER_QW; - if (ATIDivide(vga_dsp_on_off, vga_dsp_config, 5, 1) > 24) - pll->ct.fifo_size = 32; - else - pll->ct.fifo_size = 24; - } -#endif + /* Exit if the user does not want us to tamper with the clock rates of her chip. */ if (par->mclk_per == 0) { From patchwork Wed Jan 13 14:49:53 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 362126 Delivered-To: patch@linaro.org Received: by 2002:a02:ccad:0:0:0:0:0 with SMTP id t13csp598154jap; Wed, 13 Jan 2021 06:50:49 -0800 (PST) X-Google-Smtp-Source: ABdhPJy0/36EOJACX5JAFsFF0bndLCZ69Ttlh9Frt6jc5XxbClgYm7EEriM5eTtb0Wy9sn57grcP X-Received: by 2002:a17:90a:7c08:: with SMTP id v8mr2737080pjf.135.1610549448487; Wed, 13 Jan 2021 06:50:48 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1610549448; cv=none; d=google.com; s=arc-20160816; b=vtvFjs6K8zduUOkbNTByKmkDF6ohQazicaflH+L+Q1KYefNyknYER5l03waskVUf8T TaJfScrIcxfAAk/Mj45r2DyMJW67lEM/RV0dwYMwJIpcjgXkRwc2hXb2W9i1419mozb9 1QcBQcr7wg5IQNansqAKGkLNPT/542we0SvgECOWkNXXyZTMclWtPABNBU02sJ1hQjxj 0szhd1ZJjg8a5JyTWkk27N6Ht7WxWlKTO20+Xi81MLjX2rSNw9bdX7gnwbveVc2/bI0R OVlNcz4q66/E4k+qz0o3g0M66vJNSPWeT1y4a113qfZS+AExMDNRf8Sh9L6Cwk0eVqU7 aaAQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:cc:list-subscribe :list-help:list-post:list-archive:list-unsubscribe:list-id :precedence:mime-version:references:in-reply-to:message-id:date :subject:to:from:dkim-signature:delivered-to; bh=PgdRpz+blTrF5JGu5CSF0hzjqN+iFj2R8yrDTnJ5oDI=; b=M6yG42uzVrcbfW6zAlQW/tUmokeh4K5Hxv/wTfAksMeJwOz/GiIXgGuZu2QlwsqWmB jX42IB6Dm7uCFvKzQ0j+ip9DPuJ3dp2vnn6ZV5jla2V/RHD4Oaf8NiWHrXCv9ctThqiO 10PE9PwGaKRG+R1ZLRBwYwgFDJ3oq4RI4PVG1Oq63ysMZ8ist190come0RZvgpHwnEeR Igl4/OuB0r/JKvUu5fnpWLvUu3bNTsDEQ9cBSSkcaMuKuPyBxdNKVqaM9P535nFoc6RJ C13YrL9LrsYDmfFXsa2Km/HVUc2f5I+W0LXjArEvJJlmMKXjTKii/5LtfREPnLEczl2m H00A== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b="qCaU5/Pw"; spf=pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 2610:10:20:722:a800:ff:fe36:1795 as permitted sender) smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from gabe.freedesktop.org (gabe.freedesktop.org. [2610:10:20:722:a800:ff:fe36:1795]) by mx.google.com with ESMTPS id fy5si2641698pjb.16.2021.01.13.06.50.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 13 Jan 2021 06:50:48 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 2610:10:20:722:a800:ff:fe36:1795 as permitted sender) client-ip=2610:10:20:722:a800:ff:fe36:1795; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b="qCaU5/Pw"; spf=pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 2610:10:20:722:a800:ff:fe36:1795 as permitted sender) smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 30B356EA5E; Wed, 13 Jan 2021 14:50:40 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mail-wm1-x330.google.com (mail-wm1-x330.google.com [IPv6:2a00:1450:4864:20::330]) by gabe.freedesktop.org (Postfix) with ESMTPS id BC3DF6EA5C for ; Wed, 13 Jan 2021 14:50:38 +0000 (UTC) Received: by mail-wm1-x330.google.com with SMTP id g10so1855460wmh.2 for ; Wed, 13 Jan 2021 06:50:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=GZEx6Psm5kmVFzQRuV4hKShFUTuX59E1ZZSqS64lTO4=; b=qCaU5/PwjTYjtfnriB60Z9oLOr+vFl/C6eE9S2SqWRzje404GBkmpQhafug/AkVxOy cQQpoF2TPpvHLZ2G0WwI0m9I3+iSy5mECHxCRPxdVQEqbEaiQAKEQ21H2Puw7RerAiVE wFP15HZbbxQs2PH85CQiCco+76nv2mFTwq9YLxfrDpX1dbHfhcDj5xFdWbHJisbQiGp9 gXFKfd2QUbQryXwNq3Wq2jJyOgsjiru7oncOJDfA+X11+HkluVlV1zwafJGTb/u8E2G8 MRaYmLZI/XB7G9OUxyfbsMCiS30QwhZAVeTDBJWC+SfdIRLhSlZ+MEl7DCFddFc+gJo3 s87Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=GZEx6Psm5kmVFzQRuV4hKShFUTuX59E1ZZSqS64lTO4=; b=IW+hwG++pXNdYwyAUaVE3IrwZ50KwIH48sDyRcOsNLp4/YcqRsJDSVhFupV8pJ255+ 17YfUHEuqYb+C8nOv9bJbyUNi0CjlfLzLeXPgN9v88/OjQBnWPJBHwJRo4sml07A/zHI Xe4ShWjuyhOODNcz87reOFcLGGQye3yIcT3pfNK92UsudYm3v4lqYm7OiMfgGfG3q1Xd lDH4RU7P5Q9xKxnd0efx60dX4uipgJ4c07uLfejySooNJI4YpBV1kJdI5MMYQMKD+Hym +GbnHuBLrxAcTWCq+2+ZvycpIcE3RdaKH9RR5v74TfHAkLj/GHyN25XTko94/mD1hgSr U9Fg== X-Gm-Message-State: AOAM533o2vhAHfFq9sxJwyzREm/ky8VyxxgyzXDTBxlitUGxHIa+Spn6 kxvX7iW+w8QbWef/x+RMLrZVILzzmEzSIFe7 X-Received: by 2002:a1c:40d6:: with SMTP id n205mr2609520wma.0.1610549437515; Wed, 13 Jan 2021 06:50:37 -0800 (PST) Received: from dell.default ([91.110.221.229]) by smtp.gmail.com with ESMTPSA id t188sm3273433wmf.9.2021.01.13.06.50.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 13 Jan 2021 06:50:36 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Subject: [PATCH 15/31] video: fbdev: via: lcd: Remove unused variable 'mode_crt_table' Date: Wed, 13 Jan 2021 14:49:53 +0000 Message-Id: <20210113145009.1272040-16-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210113145009.1272040-1-lee.jones@linaro.org> References: <20210113145009.1272040-1-lee.jones@linaro.org> MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Florian Tobias Schandinat Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Fixes the following W=1 kernel build warning(s): drivers/video/fbdev/via/lcd.c: In function ‘viafb_lcd_set_mode’: drivers/video/fbdev/via/lcd.c:540:29: warning: variable ‘mode_crt_table’ set but not used [-Wunused-but-set-variable] Cc: Florian Tobias Schandinat Cc: linux-fbdev@vger.kernel.org Cc: dri-devel@lists.freedesktop.org Signed-off-by: Lee Jones --- drivers/video/fbdev/via/lcd.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/video/fbdev/via/lcd.c b/drivers/video/fbdev/via/lcd.c index 4a869402d120d..088b962076b51 100644 --- a/drivers/video/fbdev/via/lcd.c +++ b/drivers/video/fbdev/via/lcd.c @@ -537,11 +537,9 @@ void viafb_lcd_set_mode(const struct fb_var_screeninfo *var, u16 cxres, u32 clock; struct via_display_timing timing; struct fb_var_screeninfo panel_var; - const struct fb_videomode *mode_crt_table, *panel_crt_table; + const struct fb_videomode *panel_crt_table; DEBUG_MSG(KERN_INFO "viafb_lcd_set_mode!!\n"); - /* Get mode table */ - mode_crt_table = viafb_get_best_mode(set_hres, set_vres, 60); /* Get panel table Pointer */ panel_crt_table = viafb_get_best_mode(panel_hres, panel_vres, 60); viafb_fill_var_timing_info(&panel_var, panel_crt_table); From patchwork Wed Jan 13 14:49:54 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 362125 Delivered-To: patch@linaro.org Received: by 2002:a02:ccad:0:0:0:0:0 with SMTP id t13csp598153jap; Wed, 13 Jan 2021 06:50:48 -0800 (PST) X-Google-Smtp-Source: ABdhPJyd20IVBQkwic9vce3Om/hljXP2A+acQb6ZH9glbVYSEJtkLXM+IlpQksoVNubNt+OYoykx X-Received: by 2002:a17:90a:68cc:: with SMTP id q12mr2869401pjj.234.1610549448676; Wed, 13 Jan 2021 06:50:48 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1610549448; cv=none; d=google.com; s=arc-20160816; b=vSdAW32hkEJIgoiDu8Au30/cgzCgZnADWSF+78BCetlfUMrfD/JM1FiUrNeeK2hUoo MbJoy6XvviuKnH+vT12CR1nOo3/3Adxvp/e+kpHIrw95cTQq9nYBw7dw33KSLAtAvM1o ePme9iJwMjjWhwC7/RBQ/LgwlwWGToXz0t4gLKiy9tIm2Sa7OyZmBZj3m7+SZemDeNpw JSnC577OtY+zIpARXjvkeKq1EIffTaimLUpcMWYySqJMKLHfp6uRtGuwd7wXQp4LSime Y5vqw9c/p1n7pEhkVwPtRuxEQ0ajxkANymRua4hMcMga1q8i3ccFfyWCD4q6NeoHNh/n o6kg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:cc:list-subscribe :list-help:list-post:list-archive:list-unsubscribe:list-id :precedence:mime-version:references:in-reply-to:message-id:date :subject:to:from:dkim-signature:delivered-to; bh=eRcIHD0EUq13csU7HFsiJQAYeOu7FEewVt8lKte4KOw=; b=nEZvd+fcVBcb0EshL0W5x6ZyXiFxp1UheprIcUkzq5drGhf/hjzz3wsc1WSf9H/klO aXxwxa8KCvNvc2C1B+UQPYXKsapu/FL1ixqakYLuYN6AIJYeALNsDRMjxh7rtv1Rrmfy 6mdlSDRO0V2DTJmKxPO4C9gnmTm07225kbC8QyTLJYxota6FG8kTtkkOIllHtlBIVobM cyLZWbm0+Zk8ZE1b7r3eDNEjSf1lWGXKnJAMGrxRE+7JALqza+asGwII1TBd+CnfgKNP hzP8HuFFNWzhI15re6rWmjFmF/JbD9l/X6W5eETxOEvxQ4JGicr4lnBZujCG+I49M1eE jp8w== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=AONsu4c4; spf=pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 2610:10:20:722:a800:ff:fe36:1795 as permitted sender) smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from gabe.freedesktop.org (gabe.freedesktop.org. [2610:10:20:722:a800:ff:fe36:1795]) by mx.google.com with ESMTPS id 29si2578846pgv.292.2021.01.13.06.50.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 13 Jan 2021 06:50:48 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 2610:10:20:722:a800:ff:fe36:1795 as permitted sender) client-ip=2610:10:20:722:a800:ff:fe36:1795; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=AONsu4c4; spf=pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 2610:10:20:722:a800:ff:fe36:1795 as permitted sender) smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 0E1226EA5F; Wed, 13 Jan 2021 14:50:45 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mail-wm1-x332.google.com (mail-wm1-x332.google.com [IPv6:2a00:1450:4864:20::332]) by gabe.freedesktop.org (Postfix) with ESMTPS id EC8846EA60 for ; Wed, 13 Jan 2021 14:50:39 +0000 (UTC) Received: by mail-wm1-x332.google.com with SMTP id g10so1855516wmh.2 for ; Wed, 13 Jan 2021 06:50:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=DB5ZhlcS73D7+78VKV5C4ED9gkOhY09FF/WaEagoeZU=; b=AONsu4c49jYlWKZxIV71Fh+XZdaNm/Vzg4dgCbN9JbxTF4zXdk0hxy5yUAjRqlY1Xp nIupPjhqoIDmU9VkNJPtK0bN3YDe0f2AqkiUUwaqnLI5f/UzmCGOhingAiMylna4SnJ7 hLXn2MQXPU6i1MKuVELPGT8kK+K/FZOJI4dUhj0jPoBZq2Enr9vntVzkeQDu+4qMmsGJ v9PLkQKSiH7g77yfRhELqhLTHFPLU2Zj+6aaz97t1aI4q7b6mzr8jI36fIERyEk5M18O pFAOSj+Sqvp1t7uHTA6T4HOtbxb08KOCHlGCDgPp2Qf5TW3Vp2vXs9ztiYrfKzPx/xqZ 1DRw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=DB5ZhlcS73D7+78VKV5C4ED9gkOhY09FF/WaEagoeZU=; b=IMCmo18BzMw8qT49PmVE1E6nPCX0YAv8wVhsfZD7qW1QCIPCvka9hLZVJsTJx9TapZ gSTKTPt+c9xRzZnxaiVs7yCCfQhBHjCQ4yYFTtm/rj+s8OQeAuTBlRZg7yxYJsinpA4l rxRtvWNP15oLSDi3PtqCypEijDjxuYIeJthpvvuhJyM3ew8DU285jqaGcK39E3Of3I/n 2Vr2tBTg7I4tjZWN8muAGZV7BTqsi13vmnQYPEazeKsRxPE8vpK03e5kSyDv4OtYF/5Y 48WnlwOK+qzyGZFuJs0HEj22dZewqhCJFYekTGbBBbOX9n7uu9cpIgHi2nVM1Q17xdZP /qEg== X-Gm-Message-State: AOAM5328eNfu+lgP9wSNKnHo+PxAQmHb5In++Bk2k2pjO6gnQVhZzn9N K5w1kNuJssu1q5eSOWwMoWeUWA== X-Received: by 2002:a1c:4843:: with SMTP id v64mr2570638wma.186.1610549438672; Wed, 13 Jan 2021 06:50:38 -0800 (PST) Received: from dell.default ([91.110.221.229]) by smtp.gmail.com with ESMTPSA id t188sm3273433wmf.9.2021.01.13.06.50.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 13 Jan 2021 06:50:38 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Subject: [PATCH 16/31] video: fbdev: pm2fb: Fix some kernel-doc formatting issues Date: Wed, 13 Jan 2021 14:49:54 +0000 Message-Id: <20210113145009.1272040-17-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210113145009.1272040-1-lee.jones@linaro.org> References: <20210113145009.1272040-1-lee.jones@linaro.org> MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Jim Hague , Jakub Jelinek , linux-fbdev@vger.kernel.org, Ilario Nardinocchi , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, "Gustavo A. R. Silva" Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Fixes the following W=1 kernel build warning(s): drivers/video/fbdev/pm2fb.c:1515: warning: Function parameter or member 'pdev' not described in 'pm2fb_probe' drivers/video/fbdev/pm2fb.c:1515: warning: Function parameter or member 'id' not described in 'pm2fb_probe' drivers/video/fbdev/pm2fb.c:1721: warning: Function parameter or member 'pdev' not described in 'pm2fb_remove' drivers/video/fbdev/pm2fb.c:1765: warning: Function parameter or member 'options' not described in 'pm2fb_setup' Cc: "Gustavo A. R. Silva" Cc: Jim Hague Cc: Ilario Nardinocchi Cc: Jakub Jelinek Cc: dri-devel@lists.freedesktop.org Cc: linux-fbdev@vger.kernel.org Signed-off-by: Lee Jones --- drivers/video/fbdev/pm2fb.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) -- 2.25.1 _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel diff --git a/drivers/video/fbdev/pm2fb.c b/drivers/video/fbdev/pm2fb.c index 27893fa139b08..6a30096676374 100644 --- a/drivers/video/fbdev/pm2fb.c +++ b/drivers/video/fbdev/pm2fb.c @@ -1504,12 +1504,12 @@ static const struct fb_ops pm2fb_ops = { /** - * Device initialisation + * pm2fb_probe - Device initialisation * * Initialise and allocate resource for PCI device. * - * @param pdev PCI device. - * @param id PCI device ID. + * @pdev: PCI device. + * @id: PCI device ID. */ static int pm2fb_probe(struct pci_dev *pdev, const struct pci_device_id *id) { @@ -1711,11 +1711,11 @@ static int pm2fb_probe(struct pci_dev *pdev, const struct pci_device_id *id) } /** - * Device removal. + * pm2fb_remove - Device removal. * * Release all device resources. * - * @param pdev PCI device to clean up. + * @pdev: PCI device to clean up. */ static void pm2fb_remove(struct pci_dev *pdev) { @@ -1756,7 +1756,7 @@ MODULE_DEVICE_TABLE(pci, pm2fb_id_table); #ifndef MODULE -/** +/* * Parse user specified options. * * This is, comma-separated options following `video=pm2fb:'. From patchwork Wed Jan 13 14:49:55 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 362127 Delivered-To: patch@linaro.org Received: by 2002:a02:ccad:0:0:0:0:0 with SMTP id t13csp598170jap; Wed, 13 Jan 2021 06:50:50 -0800 (PST) X-Google-Smtp-Source: ABdhPJyZqNSA6whgkPjesS4D5vDlyHtIYJOV/Vgqj/CmCynSQNgWOMN7zGp5W3c6wfUAhSMz631P X-Received: by 2002:a17:90a:43e2:: with SMTP id r89mr2886060pjg.38.1610549449896; Wed, 13 Jan 2021 06:50:49 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1610549449; cv=none; d=google.com; s=arc-20160816; b=TCx3WVCMMInH8r46gb1vK7k1fQC6yrCN7yKXDvrZvs6PFhjgs6rC4CIDCSMG/uMmk1 PV/kICf2nfk2ulE6/N+eWPoTGNuI7cBLjNL9tJ+Qdwh0ODTCgPP95+fkjziiyMvQhmD8 iBDb1e1DQcjB7J3oJ8z4v9nVytVMQp5I5sHObtWLU8SSK/KsCZTgCqWx4GnNjss189LH ZzygLa7qjD1jRGwqyxd6Oht2HBO2H+4PfP5TsFt+7Ur+hA/OnEoZSB2lXgDqSFwwVIUa thIgA2JXZT2FeNqKVHR7VWdN6anqWrZUr9THrca6M7v4nBpIte926fg0lWFncIEfEQXu AYIg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:cc:list-subscribe :list-help:list-post:list-archive:list-unsubscribe:list-id :precedence:mime-version:references:in-reply-to:message-id:date :subject:to:from:dkim-signature:delivered-to; bh=+JYzbnKZ/P2/Se89DEeQV9fMn4q6cVzoKuBfqzFy1Zo=; b=aUfB6SBhSKman9zhEF3k6GbXwhP4j8h8JNeGB02Ap287rtMyQ6QylF3ZITZaEczupo 0eDAnRkOozEEYAJXQJp8+D33cJK3cwARQDwILeeAutYJ7Nbk9LM7A6EAPeTXnpTd87Xk 55n5wZ2d+K0ChuAz4bgBzSih2s8Ga6sSoB5wxAiVagUscSD3xezLMY3rvUhqJz9yxvlr aoKjkgcvFWI1pTGTXanDcP2MydwR+ofHhQPm/M+pzhUygjKEQJcxMz9QyDGXS9tGLxU/ 88wj+cVyZVq6LOwqBDtwUYLpgAaVZWvfm5A483u3LLW+UoCbSgFeGh6wyZTXhxlQta27 lwDw== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b="P/TckwyC"; spf=pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 131.252.210.177 as permitted sender) smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from gabe.freedesktop.org (gabe.freedesktop.org. [131.252.210.177]) by mx.google.com with ESMTPS id s8si2285290pgp.84.2021.01.13.06.50.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 13 Jan 2021 06:50:49 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 131.252.210.177 as permitted sender) client-ip=131.252.210.177; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b="P/TckwyC"; spf=pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 131.252.210.177 as permitted sender) smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 57CEE6EA60; Wed, 13 Jan 2021 14:50:45 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mail-wm1-x32c.google.com (mail-wm1-x32c.google.com [IPv6:2a00:1450:4864:20::32c]) by gabe.freedesktop.org (Postfix) with ESMTPS id 1D4226EA5F for ; Wed, 13 Jan 2021 14:50:41 +0000 (UTC) Received: by mail-wm1-x32c.google.com with SMTP id i63so1846011wma.4 for ; Wed, 13 Jan 2021 06:50:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=fDDpX4Tq8YbOoBzLmaAPLoJ0FkV3kIft9xiJt5MwHsk=; b=P/TckwyC+Zpm96Xw3jhnQcTPN4yEDByRSGHhaDy4FTUtGMu06Iu1Lz1wyjqkxnYGD8 Ka0UeFrgp+iGG7nEK9sOqDisiaFpLSK1hp1DISbHIQX8TDn4GphpHRUfABx50dTEboH0 qeaFWlT7UN/Vu7aoSNXpYCaMFlK+DfSHuhMJjBshrb8gKl2yGkzp7JIUWGPZphFnEfly 608DGRjP7K/CPR0c/OxOSedMrPcUuDd1OSXearvHBAU6PUJXtpFKR1uPWbedCfsb9D0l VZxN7mXIKLzNxEZYF8QgplqX7VbOWBfbEy/IEpStDEkkgxcfNRAH9CcHckNWX7BTHpf7 EMTA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=fDDpX4Tq8YbOoBzLmaAPLoJ0FkV3kIft9xiJt5MwHsk=; b=XiOzTXQxRXkT+TxEIqVzEX4DZZvy6PM1C3Up6OiDU1Sc7RGP+LqZyxmkEB4GyGvN00 Y/blPYy2awy7dh9Y4xEc2/3zbSqoPtHste+7mqZbv/C/LoMrO+DCiUnpYfF8/YqdyGGZ 11xCV/FIlSLcOQXzisGmQ/geGDh95ky0Z3rGqBAWV68CUflbYXjjVFcox/v2f5jC76pU te2mOGiomusO0Zr3nBpvhRj6MH86j0ctnDV9Pk7wuBieS3kmgnnoDCLWtgXuC9MCceSA u8s5VEm9ZdccQ4bF7Slm6r1hhSVmGlp+knakonpnqUROem9pC6tNdsDhSudlXTuZbY+x wqoQ== X-Gm-Message-State: AOAM53288IZ03pW7nm5cp3mTaB/SF8Xcwg8po1XaQ/o9n5hO+Cm0QNwI BTNbTmeuTBkV935pjv/YSpusgw== X-Received: by 2002:a1c:a5d8:: with SMTP id o207mr2598878wme.30.1610549439832; Wed, 13 Jan 2021 06:50:39 -0800 (PST) Received: from dell.default ([91.110.221.229]) by smtp.gmail.com with ESMTPSA id t188sm3273433wmf.9.2021.01.13.06.50.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 13 Jan 2021 06:50:39 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Subject: [PATCH 17/31] video: fbdev: aty: radeon_monitor: Remove unused variable 'mon_types' Date: Wed, 13 Jan 2021 14:49:55 +0000 Message-Id: <20210113145009.1272040-18-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210113145009.1272040-1-lee.jones@linaro.org> References: <20210113145009.1272040-1-lee.jones@linaro.org> MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Fixes the following W=1 kernel build warning(s): drivers/video/fbdev/aty/radeon_monitor.c: In function ‘radeon_probe_screens’: drivers/video/fbdev/aty/radeon_monitor.c:491:8: warning: variable ‘mon_types’ set but not used [-Wunused-but-set-variable] Cc: Benjamin Herrenschmidt Cc: linux-fbdev@vger.kernel.org Cc: dri-devel@lists.freedesktop.org Signed-off-by: Lee Jones --- drivers/video/fbdev/aty/radeon_monitor.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/video/fbdev/aty/radeon_monitor.c b/drivers/video/fbdev/aty/radeon_monitor.c index 9966c58aa26cd..5ff01aa389381 100644 --- a/drivers/video/fbdev/aty/radeon_monitor.c +++ b/drivers/video/fbdev/aty/radeon_monitor.c @@ -488,12 +488,10 @@ void radeon_probe_screens(struct radeonfb_info *rinfo, #if defined(DEBUG) && defined(CONFIG_FB_RADEON_I2C) { u8 *EDIDs[4] = { NULL, NULL, NULL, NULL }; - int mon_types[4] = {MT_NONE, MT_NONE, MT_NONE, MT_NONE}; int i; for (i = 0; i < 4; i++) - mon_types[i] = radeon_probe_i2c_connector(rinfo, - i+1, &EDIDs[i]); + radeon_probe_i2c_connector(rinfo, i+1, &EDIDs[i]); } #endif /* DEBUG */ /* From patchwork Wed Jan 13 14:49:56 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 362128 Delivered-To: patch@linaro.org Received: by 2002:a02:ccad:0:0:0:0:0 with SMTP id t13csp598208jap; Wed, 13 Jan 2021 06:50:52 -0800 (PST) X-Google-Smtp-Source: ABdhPJxJXsJxWPTScdgs+I9PtQXP7uYg1DbTZH0NCNALOjNL4wTsZVmx35xx1NJgtDb3AcE/1RE+ X-Received: by 2002:a63:1261:: with SMTP id 33mr2345741pgs.213.1610549452733; Wed, 13 Jan 2021 06:50:52 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1610549452; cv=none; d=google.com; s=arc-20160816; b=fgJZdYTLz8kA1A3ONOXOIDLbrBoF/vG+PWMHW1l17PIFHcQnvYZG9hcPANPqHuQu+Y H9gTYXxdCtcTb6g1e2oesIHs0uoWLcjZHwxKDEOdjCMQXOJuXy5fRXVwcbMZWcuHFEo+ gubzyGKhxYJ6FpDirsfZu3MsB8sAlWcL1LoRcYraOj8of1ETe9AnjsDjsRV2nL6jzRoL L8tPR793d7xjD8debK+yvqUAF8D0HYKtH0KsrB9rjYaaxwN5wP44advaugVCrRHIsYc2 O249V25jhWbEPzxKaC+xrADOiJilsQBHqajs89RMOA7tf0mm3TFshxn6HZJyyefKpwYU vhUg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:cc:list-subscribe :list-help:list-post:list-archive:list-unsubscribe:list-id :precedence:mime-version:references:in-reply-to:message-id:date :subject:to:from:dkim-signature:delivered-to; bh=BH2hp+Y8ef4FQhDixHj8iUBNrwP8dMsbqM6CbLJ1GGU=; b=OLT35MskMEF/rS3YK8DrUnH9ur7wDdHBqIpIBBtSM8QjZ1wtpPiWFoevBx/tQ5qQod 7SM+W2KORjqzKkN73IK+uwC5vs697vuCTGzB/S37EXzLGYjJir1WIoovzLmiHneFTIXJ ltmF917K6vVI0GAxO/PUtsQzmq3x75vcE/wKdxwN/VVtv4uqo3afAAl6lUuwd8ppRqhw bMOPePyKHRsKKMxfL2KHQKQs0bYmJLp6GGkvFqUbMaCS4T3DQk6xoqiKGf9W6tdG59cG 6ctGb3e/uI4owExpAkOPrsx4NF1R/TMhwmbGc8vMqQwyJd2WA8f1T2YNo3saWBpaTxSa ddXg== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=vlfUbYCa; spf=pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 2610:10:20:722:a800:ff:fe36:1795 as permitted sender) smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from gabe.freedesktop.org (gabe.freedesktop.org. [2610:10:20:722:a800:ff:fe36:1795]) by mx.google.com with ESMTPS id i6si2691630pju.133.2021.01.13.06.50.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 13 Jan 2021 06:50:52 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 2610:10:20:722:a800:ff:fe36:1795 as permitted sender) client-ip=2610:10:20:722:a800:ff:fe36:1795; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=vlfUbYCa; spf=pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 2610:10:20:722:a800:ff:fe36:1795 as permitted sender) smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 520D56EA67; Wed, 13 Jan 2021 14:50:49 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mail-wr1-x42c.google.com (mail-wr1-x42c.google.com [IPv6:2a00:1450:4864:20::42c]) by gabe.freedesktop.org (Postfix) with ESMTPS id 586206EA5F for ; Wed, 13 Jan 2021 14:50:42 +0000 (UTC) Received: by mail-wr1-x42c.google.com with SMTP id d26so2386070wrb.12 for ; Wed, 13 Jan 2021 06:50:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=K8LGsHawy1FykMfSNgFdlsHpkSijq6aQuT4rYUHFPB4=; b=vlfUbYCaI8nbSGsNOrvP4jNkRNNQft4Td7Q/qK7df3eMXHJiNDMJ7WqrL+lctbGzof irvEGx52lUUHqOlSxdne5KYtvcv637NvMYUh46CWn0hYxBYGrnYgpxsFeL+hxHB7aXZz nKEugO/vNXJaQpOyOYQD1cz7XxScABklnzNnXh+KI5q1rPET24SGQL0t9lgX19e+C7fR eFsxphGPTVhjYYo/VvE2TbVEkj/Dq8F69zcFARqN+rtlR6zQXNuUSLhFlkcsV/wpyhQh 1eMd62z5eauJMxNi8y0gGmRjshelxQz5tkvi3VyP8GGcTFLF5ZpE7yXf3E7Hveu5aQgK 93FA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=K8LGsHawy1FykMfSNgFdlsHpkSijq6aQuT4rYUHFPB4=; b=YaCeUaJYoqxSG7G7snDPyD4tT1c4x4NVjoCcQ1IkHWjOD/dV3RENwRBcwTD3G7ur+N s/+Zsu4S8hNh84QmgIKUFEm720DxYpTNbRTty0dWff72N7oLqy3d+XF8OHKlwY9GGWgb byWRp+fjjTMsybkjY2q6XZrQkoy8WzODMNYJEV414CxA5KjSuXVdCX5/PH4veVitoI60 F+l3ASSmZVR8eFTSrX+sAZcVGjxjJplAv0u7gP/DJOYggO4KWh43D9dEKexU4l862K2s wJ1Q8SVMJsWouOZDN+1KJHbC3B7fNH74t3hE3O1ZwGDxp2ptooq7BEgEnk+cm6rjXLJ+ 0hFg== X-Gm-Message-State: AOAM533glzDVvIoBiFywsWlBW/8AtSVDeQFayqkFhzCthVRb45L61Fq0 hJb0TTGGUYRiMC4SS96Qhrq0s7nxa8PNADq0 X-Received: by 2002:adf:f18a:: with SMTP id h10mr3188792wro.244.1610549441019; Wed, 13 Jan 2021 06:50:41 -0800 (PST) Received: from dell.default ([91.110.221.229]) by smtp.gmail.com with ESMTPSA id t188sm3273433wmf.9.2021.01.13.06.50.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 13 Jan 2021 06:50:40 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Subject: [PATCH 18/31] video: fbdev: neofb: Remove unused variable 'CursorMem' Date: Wed, 13 Jan 2021 14:49:56 +0000 Message-Id: <20210113145009.1272040-19-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210113145009.1272040-1-lee.jones@linaro.org> References: <20210113145009.1272040-1-lee.jones@linaro.org> MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-fbdev@vger.kernel.org, "Thomas J. Moore" , Evgeny Novikov , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Oliver Kropp , Mike Rapoport Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Fixes the following W=1 kernel build warning(s): drivers/video/fbdev/neofb.c: In function ‘neo_init_hw’: drivers/video/fbdev/neofb.c:1846:6: warning: variable ‘CursorMem’ set but not used [-Wunused-but-set-variable] Cc: Evgeny Novikov Cc: Mike Rapoport Cc: Oliver Kropp Cc: "Thomas J. Moore" Cc: dri-devel@lists.freedesktop.org Cc: linux-fbdev@vger.kernel.org Signed-off-by: Lee Jones --- drivers/video/fbdev/neofb.c | 5 ----- 1 file changed, 5 deletions(-) diff --git a/drivers/video/fbdev/neofb.c b/drivers/video/fbdev/neofb.c index 09a20d4ab35f2..bec199a34037e 100644 --- a/drivers/video/fbdev/neofb.c +++ b/drivers/video/fbdev/neofb.c @@ -1843,7 +1843,6 @@ static int neo_init_hw(struct fb_info *info) struct neofb_par *par = info->par; int videoRam = 896; int maxClock = 65000; - int CursorMem = 1024; int CursorOff = 0x100; DBG("neo_init_hw"); @@ -1895,26 +1894,22 @@ static int neo_init_hw(struct fb_info *info) case FB_ACCEL_NEOMAGIC_NM2070: case FB_ACCEL_NEOMAGIC_NM2090: case FB_ACCEL_NEOMAGIC_NM2093: - CursorMem = 2048; CursorOff = 0x100; break; case FB_ACCEL_NEOMAGIC_NM2097: case FB_ACCEL_NEOMAGIC_NM2160: - CursorMem = 1024; CursorOff = 0x100; break; case FB_ACCEL_NEOMAGIC_NM2200: case FB_ACCEL_NEOMAGIC_NM2230: case FB_ACCEL_NEOMAGIC_NM2360: case FB_ACCEL_NEOMAGIC_NM2380: - CursorMem = 1024; CursorOff = 0x1000; par->neo2200 = (Neo2200 __iomem *) par->mmio_vbase; break; } /* - info->sprite.size = CursorMem; info->sprite.scan_align = 1; info->sprite.buf_align = 1; info->sprite.flags = FB_PIXMAP_IO; From patchwork Wed Jan 13 14:49:58 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 362134 Delivered-To: patch@linaro.org Received: by 2002:a02:ccad:0:0:0:0:0 with SMTP id t13csp599407jap; Wed, 13 Jan 2021 06:52:20 -0800 (PST) X-Google-Smtp-Source: ABdhPJyoVl4D0KDvLHAJWhY0VPOVLwYpuB0hSkDW+cQDFNZ0aXpQ3twPqLN3I+2IvVMCjOrx8GuY X-Received: by 2002:a62:dd94:0:b029:19e:92ec:722a with SMTP id w142-20020a62dd940000b029019e92ec722amr2492584pff.50.1610549456838; Wed, 13 Jan 2021 06:50:56 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1610549456; cv=none; d=google.com; s=arc-20160816; b=qD+d0SXqNsQCfMLaBfidvDwXi9DLLxsxRig6u5wmtI5jMb5LZ4Y6BgFqSSTzjSFe93 DRieMPCeD1ZAMZ8apdkwkbLIzFAxovjJ0ug8hJqG9V+okDE9T3mjMuVn4qvLSdNgf4V9 Fw7RbmHyNaquDf6ieUULstX6QpqKtThw5ETbv7kcvh70HaIFHey6ju6sSL4Vf4D/YQkN o05U+dyrbbmsYjvwq/OH7NBnCZnwcpnEUL+U/b92a68jV8Z5mmvl4KG11Hi9hHwzf3bc kPvP2EXWzqLgu3TC/QQ/2pQ9oSakv1lgBA4beT4APjUMKEmVyVt3+pRZiKZpELQBByPG EtgA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:cc:list-subscribe :list-help:list-post:list-archive:list-unsubscribe:list-id :precedence:mime-version:references:in-reply-to:message-id:date :subject:to:from:dkim-signature:delivered-to; bh=w4t75V4YhAMkpMQeSrRJ6s2iXm/9iUEZWIBPUbTuubU=; b=nr0/gqRcRcM4bCdYYyaWC2mjXO8DxLHAeRboPdjv2hxDX7KpjpYyD4HYfvDCiMa4lT ce7ixLeNvRBwobH13uEf9IsIF3j4+Gg2Ek09WPFwkkVqWfEhlUrfMv3d0WQYGg/ZqQqj 9LvvmgmQsLg8rj6y71mlLkZQEJlpofQ2TBK/zT40Ki5nvWxikV4uZf2VjS378wTEOF93 0rFTzTZnxvR+5kLILw1hUFs0JY9VoQuQtEFItJs8H7APpTRF8BsksXjMQ79T3jaI7QQD 4ykjFu5ug2vtchVP0QMReonTWFO6cBOfkzWTkfoQwYSRjrQzNWyP9PxyOCiCbHaViUS1 TpAA== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=MweOdz1m; spf=pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 131.252.210.177 as permitted sender) smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from gabe.freedesktop.org (gabe.freedesktop.org. [131.252.210.177]) by mx.google.com with ESMTPS id f31si2450716pgb.39.2021.01.13.06.50.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 13 Jan 2021 06:50:56 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 131.252.210.177 as permitted sender) client-ip=131.252.210.177; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=MweOdz1m; spf=pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 131.252.210.177 as permitted sender) smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id C30D96EA6A; Wed, 13 Jan 2021 14:50:52 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mail-wr1-x431.google.com (mail-wr1-x431.google.com [IPv6:2a00:1450:4864:20::431]) by gabe.freedesktop.org (Postfix) with ESMTPS id 9C2546EA5F for ; Wed, 13 Jan 2021 14:50:44 +0000 (UTC) Received: by mail-wr1-x431.google.com with SMTP id d13so2384746wrc.13 for ; Wed, 13 Jan 2021 06:50:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=8AKZe0pvPLHu3x895juPn/Z4GbXtcqzxxje+6pz86KU=; b=MweOdz1mBiZ3YANYAenthalC1RAZ2L7YBzcfY2mxwBScLf0FZ7dfPLhGVCYJ3wStLt C3s1vvBrFa415Wr1aCWWYyc6yuvzFexaNiSTEv/rsPJ+qSMCxbo/gkIkbK6PkL7+YYiN j4X4qJFw6IVfKE3+eKxdcIPKq3uf/B3BN8WWKumhwaTV44EooXi7ZrrsGRMN/hPU9R9g aM2d+N3S2d8PdXVSrkZFhnz4GytrdOwPuh2vbjAk7nR/Um1bObWFqsibjGktJZnkTX2+ LSnF9sH+yRTO8ixzJlE682O8bs4obJ1NQRctXzq69GkYjy20O7QmRaSjmdm9hW95TO4e 51pQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=8AKZe0pvPLHu3x895juPn/Z4GbXtcqzxxje+6pz86KU=; b=ila38zexkNwRpGNl0t79I9dEPhmRPQEn86XqxtyJ4ctQvhkWSMWUOEF2dpZBWJ086/ YvLuPnno9SSkHdxDRn/hCDsbkecZqXUUaMCPJOTcAYcnUtNF2QvSVwqr7zdaehmE0dIm FBkQyuDRU8Blqukpoi6I+i57m3n7wPs3JW/Za+lS31avP3AjarNuA+WyLLxKY2fJie3G 9r41w9M4iJQp28sEiq3qk+64dhDWaDZWXfnBAKBlpuKN5S4Hjv3WP8GuDH3BcGpEaCEU GYgoI/UwuinhfgHz8huxCagQQpFLcO2E1FdqsLt01P+ENKgKyjS3mgSVgTMuRVwrhaR+ Mxug== X-Gm-Message-State: AOAM532l1rFInmhaCi3sccWZ8228/GwqCdbGWdbnUmDP+68SsRcs1rjb eVul080fptuNWD+hw0MJw0LE9A== X-Received: by 2002:a05:6000:124e:: with SMTP id j14mr3073602wrx.310.1610549443321; Wed, 13 Jan 2021 06:50:43 -0800 (PST) Received: from dell.default ([91.110.221.229]) by smtp.gmail.com with ESMTPSA id t188sm3273433wmf.9.2021.01.13.06.50.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 13 Jan 2021 06:50:42 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Subject: [PATCH 20/31] video: fbdev: core: fbcon: Mark 'pending' as __maybe_unused Date: Wed, 13 Jan 2021 14:49:58 +0000 Message-Id: <20210113145009.1272040-21-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210113145009.1272040-1-lee.jones@linaro.org> References: <20210113145009.1272040-1-lee.jones@linaro.org> MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-fbdev@vger.kernel.org, Jes Sorensen , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, William Rucklidge , Emmanuel Marty , carter@compsci.bristol.ac.uk, Martin Mares , Jakub Jelinek , Brad Douglas Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" 'pending' is only used if FBCONDEBUG is defined. Fixes the following W=1 kernel build warning(s): drivers/video/fbdev/core/fbcon.c: In function ‘fbcon_exit’: drivers/video/fbdev/core/fbcon.c:3295:7: warning: variable ‘pending’ set but not used [-Wunused-but-set-variable] Cc: carter@compsci.bristol.ac.uk Cc: William Rucklidge Cc: Jes Sorensen Cc: Emmanuel Marty Cc: Jakub Jelinek Cc: Martin Mares Cc: Brad Douglas Cc: dri-devel@lists.freedesktop.org Cc: linux-fbdev@vger.kernel.org Signed-off-by: Lee Jones --- drivers/video/fbdev/core/fbcon.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/video/fbdev/core/fbcon.c b/drivers/video/fbdev/core/fbcon.c index bf61598bf1c39..f3d628fd07dc1 100644 --- a/drivers/video/fbdev/core/fbcon.c +++ b/drivers/video/fbdev/core/fbcon.c @@ -3292,7 +3292,7 @@ static void fbcon_exit(void) #endif for_each_registered_fb(i) { - int pending = 0; + int __maybe_unused pending = 0; mapped = 0; info = registered_fb[i]; From patchwork Wed Jan 13 14:49:59 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 362137 Delivered-To: patch@linaro.org Received: by 2002:a02:ccad:0:0:0:0:0 with SMTP id t13csp599657jap; Wed, 13 Jan 2021 06:52:39 -0800 (PST) X-Google-Smtp-Source: ABdhPJw2/yoL0LISTz58wKFMaR01sLudyUmYySZdeyDmtevusfaiW594SeWIh0acu9QJgJ5aaEEV X-Received: by 2002:a17:902:f686:b029:de:18c7:41f8 with SMTP id l6-20020a170902f686b02900de18c741f8mr2706441plg.65.1610549454141; Wed, 13 Jan 2021 06:50:54 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1610549454; cv=none; d=google.com; s=arc-20160816; b=tfQi2dfx+qlpkimG2M+pdV3dttn37cTumkfpQ2O8BLLvxXVGbDIeCeJvPumjQimMtQ rQkIIY5b8Q8eJ5CNh89NcxJhjKRXBh/N/JM+qxo9EuQDHEbNrrYXTJp1t+EAmhWk8dkU A1JZsicsrK94+8Q5QC0K70opX5vDzQRlsqL297xaFL/T3V54d0FXfV5kCa27KUBtMBzU nPicRRR9YKqCtNCmKTgjsYoFQNyCMHKNC1JHDWXonryPP5T5ZsrfCdLolU/dFBB8mddU C0Iu74rRXqLp/OlJqtfR+yuwbp2EjX+XVWiA+JXLAbG2IqkbcGbCymMION/z4SvzaTqt VcZg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:cc:list-subscribe :list-help:list-post:list-archive:list-unsubscribe:list-id :precedence:mime-version:references:in-reply-to:message-id:date :subject:to:from:dkim-signature:delivered-to; bh=6tOxi4i7IftlDZCAc+ih/GJrUd2vSspfIFJOSbyOUNI=; b=h/XocqtfVBhAYEzd4H9OcXspdi21PLOsyVYjTHhFB02WKMtDRcf8Cd+4607sDr/aBI G1NXng8CK+u8TyBMjqhXKSDyzAhMoHfE1GZRAyt/7gurJckNae3jRyuEFqG9DtVenItE 0A/qtuO4j1mXgZ7oknNs9Lbc9MzMIQL11h1yzsfkMj5Z2HFMFu+hn66ldHa0RGll4uGg 27Ax7EZCngnKxB8DGyCr2Fd72vYGWyhRxFqzvzHJ+rGjBNSVKEunBbd9wFX8JQuqTbZd iRyBrFXQfyYv1EN3yPyxzXF5RhmGfWOMB999nrtJL920wVNGtvzCkO49CWreUfIEoo90 uJyQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=h7CCOaMR; spf=pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 131.252.210.177 as permitted sender) smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from gabe.freedesktop.org (gabe.freedesktop.org. [131.252.210.177]) by mx.google.com with ESMTPS id f1si2588770pjo.106.2021.01.13.06.50.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 13 Jan 2021 06:50:54 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 131.252.210.177 as permitted sender) client-ip=131.252.210.177; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=h7CCOaMR; spf=pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 131.252.210.177 as permitted sender) smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id C76C06EA62; Wed, 13 Jan 2021 14:50:49 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mail-wr1-x435.google.com (mail-wr1-x435.google.com [IPv6:2a00:1450:4864:20::435]) by gabe.freedesktop.org (Postfix) with ESMTPS id DE5D66EA62 for ; Wed, 13 Jan 2021 14:50:45 +0000 (UTC) Received: by mail-wr1-x435.google.com with SMTP id a12so2392953wrv.8 for ; Wed, 13 Jan 2021 06:50:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=kdRuSJvii4mKY/Efrp+W2ecV3k/kYMixGrJ5X2aYPPE=; b=h7CCOaMRu/KwDp4FkMru0iAXzhcqDT8Zgx3TFkmqeQ+lFmQabkd31QQ+lufeDRUy3X LtVPTgu8/Zqp1FSR8BAvO7dZtJzfFJCxlVtW1Nocwnb68P37FSE+be5cVVaNK5Tt8JCU 9w0Ph8RfNh92LMTOPQay3rdqNK2k+J9YHe1s4Pc7Cfwul+RTcoi4Ud5EHifbnQv/CgAl HXLZdEt7o50147fxcADWLOPX90H4PF4f7epdHBvT72f7b/PpYAha9w6yexNN/IIcz2uN fnQb+ZapvvgV5yFNpXtWjyjgqG+ixxGtM9qn4DjB5lbBlmDCcef1Kbvt5M9KefOQMbJJ FfRw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=kdRuSJvii4mKY/Efrp+W2ecV3k/kYMixGrJ5X2aYPPE=; b=cJAxdU2kqecmfgFAYtddy9+o62Um1rwHRzsXdkbpcjgKlTUpJ0UiDX8pCbqRDD0Xg7 2e+bw+vYT9RznnULogSjQU2vVL7eziS1bGw4og2fPCXQ++wwkwrKaaCrOC7a0YG6P/Ei NFRj4L6KYyQTHdZir7LSlj72wQWhNIlCytsmdVIv64kvKgvpStUkc1qRbQaAmE5Ki2Mn o5ppb0poEkBTqMOSQrRPISoanpPrYCwsHaCc8iLva9EgHRLd0LlR7jGABItySWB/RfxZ +LDLDU/Q8c55XV4+iAjVh1AEZPH6Tr/LNdzHkmsB3dPQMD6eseFACfPQsGfcfBVflSS9 2TwA== X-Gm-Message-State: AOAM532gPu/yHqRz/KYKf2s7Rd619l9A6GaZaf19CFKZf/ZjrL/KGbil SA43bgU/0dNF1dmP9l4vkrq+jg== X-Received: by 2002:a05:6000:108b:: with SMTP id y11mr2937092wrw.379.1610549444578; Wed, 13 Jan 2021 06:50:44 -0800 (PST) Received: from dell.default ([91.110.221.229]) by smtp.gmail.com with ESMTPSA id t188sm3273433wmf.9.2021.01.13.06.50.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 13 Jan 2021 06:50:43 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Subject: [PATCH 21/31] video: fbdev: sstfb: Mark 3 debug variables as __maybe_unused Date: Wed, 13 Jan 2021 14:49:59 +0000 Message-Id: <20210113145009.1272040-22-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210113145009.1272040-1-lee.jones@linaro.org> References: <20210113145009.1272040-1-lee.jones@linaro.org> MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-fbdev@vger.kernel.org, Urs Ganse , Bartlomiej Zolnierkiewicz , Helge Deller , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Alan Cox , Paul Mundt , Ghozlane Toumi , Alex Dewar Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" These are only used if SST_DEBUG_FUNC is set. Declare them under the same clause as their use. Fixes the following W=1 kernel build warning(s): drivers/video/fbdev/sstfb.c: In function ‘sst_detect_ics’: drivers/video/fbdev/sstfb.c:934:26: warning: variable ‘n_clk1_b’ set but not used [-Wunused-but-set-variable] drivers/video/fbdev/sstfb.c:934:16: warning: variable ‘n_clk0_7’ set but not used [-Wunused-but-set-variable] drivers/video/fbdev/sstfb.c:934:6: warning: variable ‘n_clk0_1’ set but not used [-Wunused-but-set-variable] Cc: Alex Dewar Cc: Bartlomiej Zolnierkiewicz Cc: Ghozlane Toumi Cc: James Simmons Cc: Paul Mundt Cc: Urs Ganse Cc: Helge Deller Cc: Alan Cox Cc: dri-devel@lists.freedesktop.org Cc: linux-fbdev@vger.kernel.org Signed-off-by: Lee Jones --- drivers/video/fbdev/sstfb.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/video/fbdev/sstfb.c b/drivers/video/fbdev/sstfb.c index c05cdabeb11c2..b8813a0b63b1d 100644 --- a/drivers/video/fbdev/sstfb.c +++ b/drivers/video/fbdev/sstfb.c @@ -931,7 +931,7 @@ static int sst_detect_ics(struct fb_info *info) { struct sstfb_par *par = info->par; int m_clk0_1, m_clk0_7, m_clk1_b; - int n_clk0_1, n_clk0_7, n_clk1_b; + int __maybe_unused n_clk0_1, __maybe_unused n_clk0_7, __maybe_unused n_clk1_b; int i; for (i = 0; i<5; i++ ) { From patchwork Wed Jan 13 14:50:00 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 362132 Delivered-To: patch@linaro.org Received: by 2002:a02:ccad:0:0:0:0:0 with SMTP id t13csp598429jap; Wed, 13 Jan 2021 06:51:06 -0800 (PST) X-Google-Smtp-Source: ABdhPJzjox62r5D8EO9a9xLPh33UJfSIb8fgqZeQla/d51hGKE0JnUNB3kYPGnn6XA6QscUXx1kw X-Received: by 2002:a17:90a:bb8c:: with SMTP id v12mr2834976pjr.227.1610549466390; Wed, 13 Jan 2021 06:51:06 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1610549466; cv=none; d=google.com; s=arc-20160816; b=HPE9Abua6VlZte6k2NhT454OtPIHY59/YedXkjqe6j79kBdFm3khfUyc0H79UoP3MY giD4T4WmMPA8x/NAegC+n4Ecz4VEWA0QfrSgfaUuVtoEXRuNLuPpzk9tdEFUdAJ3Y+V0 uF5uTOSDDyhfd482QN1/ydqewpKY6CGq013eO5bLrJdjXR/HZ3jivh3Zgs2I28VV4oV8 TGfn4Gk2gbOPvFvQneFcOZPyOVIIuSm4l5Mf80/XOt2b67XoCVcJwjUGYuXqoCCtGo0u xUOAdt3aNy0T5eeh0j9gA5QXMVWFGzeDHvaiyTFRwwPRcrsRIm+D2DV+Let2Izc0X/Nd KAOw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:cc:list-subscribe :list-help:list-post:list-archive:list-unsubscribe:list-id :precedence:mime-version:references:in-reply-to:message-id:date :subject:to:from:dkim-signature:delivered-to; bh=qjhstJDxZzRg1PCTSUN4/Q9/Fdu+r2H3vA1tLc/QbcY=; b=qIEQ2f9lk5LFopuvqsK7EcmNxL41tNqgo2cR07gLKIs3pP2aIwxus3GAOwcR1PqiJ8 1GWRmiRGRhgK6rNBu/auJ17vxpEVBQ3/OOoJk0lKnUsXVXUrquAZgKWh1FS75iN5Y2xX 3QBV3hvvGxEl0CU4hJv47wZhcxt9kK7W43PnTkwUlb1reMpc9OWFcMmgfT4+WvLzZ4O4 2NYTIIKnPLAAh1rhZ88ggXkV4FOsLHiwuxr38KvrWfhlSeCF00nbVj+SNjBZjyXww6nl mxK5gdApwfffAcczAKMc+oT/cI1B+lKnnEpsWFzlhB2zL157k2ZM86vj4BMjWPMIDD4e 35tg== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=DVx9RGOh; spf=pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 131.252.210.177 as permitted sender) smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from gabe.freedesktop.org (gabe.freedesktop.org. [131.252.210.177]) by mx.google.com with ESMTPS id 12si2529103pll.58.2021.01.13.06.51.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 13 Jan 2021 06:51:06 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 131.252.210.177 as permitted sender) client-ip=131.252.210.177; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=DVx9RGOh; spf=pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 131.252.210.177 as permitted sender) smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 1C15F6EA65; Wed, 13 Jan 2021 14:50:58 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mail-wr1-x42d.google.com (mail-wr1-x42d.google.com [IPv6:2a00:1450:4864:20::42d]) by gabe.freedesktop.org (Postfix) with ESMTPS id 539A46EA62 for ; Wed, 13 Jan 2021 14:50:47 +0000 (UTC) Received: by mail-wr1-x42d.google.com with SMTP id t16so2417462wra.3 for ; Wed, 13 Jan 2021 06:50:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=GoUfRt23bqbKPl1TGglCjWozG44qym29OpcwnZGK6kU=; b=DVx9RGOhwl5u8ldZy5VrfBB5nqUBSa6oCbOAtc/naAE4if9nM+qG1VzCKee+LVG+3B pYMHjLmmVhejEEkmBIU3VqOIbS0QbervpRSbvt8RbrJ65WI6sdAQJIFHQBuqYquGY9sm C0BoNNBF1vlcU19yuj0aroZuKk5XVtUWIzVX0dv3Fl5+wU5eXqndsETD1SuasAlFPapO Ndex26m6UwPr44hJ1bIN/A68qcXyyjbFTxYEWrG/wLv+f8ePNT5PGN0tbNcfIJ6tyYVQ 66n2l1NmCju3l+XV3FxP/N8a/cWJvm9uSD3UZcReTj1OIqHd9zRtoKkjQOixv9hbaPDF TjNw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=GoUfRt23bqbKPl1TGglCjWozG44qym29OpcwnZGK6kU=; b=TKyK2xm2iEPjCQohGLGiVxC6nnOxP0hIn8sa18WhOQ4dFvjwjb5FGHsbJ7vsjGqaZ0 RD/QQriswi4pLPBWgty0RYrsc6hsDwFjWvEBq3Et8dybJ/9NR0IqWLHJ8W+cj5lEectR IdqltW2bN3oMwuRce0ag4wfmv8q2iBNtSP/0XMEdBeFXQzAh6FgqoJCthuYQzMYiJjls Rfe59O5w2KeLJPRgWKGwzNSkn4nDwFEgLwZAAyCDrLSfFoWzLN9/yXxXJf4HJ+cvpNK5 yMYrlK4rZeLzLfEZK/HaO1fmgDJJMwfSkNphKvtca0FHB5LJeNOzjoZccYlEHec952+z 7SoQ== X-Gm-Message-State: AOAM533mZ5TgZ249eRY1+tyITlbNiuW0EFRaU21YXt0ZkEHynHeqkZIN h1WeGX7meDY7HHchTDb9hvMDVQ== X-Received: by 2002:a5d:6852:: with SMTP id o18mr2897319wrw.371.1610549445789; Wed, 13 Jan 2021 06:50:45 -0800 (PST) Received: from dell.default ([91.110.221.229]) by smtp.gmail.com with ESMTPSA id t188sm3273433wmf.9.2021.01.13.06.50.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 13 Jan 2021 06:50:45 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Subject: [PATCH 22/31] video: fbdev: cirrusfb: Remove unused variable 'dummy' from 'WHDR()' Date: Wed, 13 Jan 2021 14:50:00 +0000 Message-Id: <20210113145009.1272040-23-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210113145009.1272040-1-lee.jones@linaro.org> References: <20210113145009.1272040-1-lee.jones@linaro.org> MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-fbdev@vger.kernel.org, Jeff Garzik , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Fixes the following W=1 kernel build warning(s): drivers/video/fbdev/cirrusfb.c: In function ‘WHDR’: drivers/video/fbdev/cirrusfb.c:2466:16: warning: variable ‘dummy’ set but not used [-Wunused-but-set-variable] Cc: Jeff Garzik Cc: dri-devel@lists.freedesktop.org Cc: linux-fbdev@vger.kernel.org Signed-off-by: Lee Jones --- drivers/video/fbdev/cirrusfb.c | 14 ++++++-------- 1 file changed, 6 insertions(+), 8 deletions(-) diff --git a/drivers/video/fbdev/cirrusfb.c b/drivers/video/fbdev/cirrusfb.c index e9027172c0f55..f05160fa34da9 100644 --- a/drivers/video/fbdev/cirrusfb.c +++ b/drivers/video/fbdev/cirrusfb.c @@ -2463,8 +2463,6 @@ static void AttrOn(const struct cirrusfb_info *cinfo) */ static void WHDR(const struct cirrusfb_info *cinfo, unsigned char val) { - unsigned char dummy; - if (is_laguna(cinfo)) return; if (cinfo->btype == BT_PICASSO) { @@ -2473,18 +2471,18 @@ static void WHDR(const struct cirrusfb_info *cinfo, unsigned char val) WGen(cinfo, VGA_PEL_MSK, 0x00); udelay(200); /* next read dummy from pixel address (3c8) */ - dummy = RGen(cinfo, VGA_PEL_IW); + RGen(cinfo, VGA_PEL_IW); udelay(200); } /* now do the usual stuff to access the HDR */ - dummy = RGen(cinfo, VGA_PEL_MSK); + RGen(cinfo, VGA_PEL_MSK); udelay(200); - dummy = RGen(cinfo, VGA_PEL_MSK); + RGen(cinfo, VGA_PEL_MSK); udelay(200); - dummy = RGen(cinfo, VGA_PEL_MSK); + RGen(cinfo, VGA_PEL_MSK); udelay(200); - dummy = RGen(cinfo, VGA_PEL_MSK); + RGen(cinfo, VGA_PEL_MSK); udelay(200); WGen(cinfo, VGA_PEL_MSK, val); @@ -2492,7 +2490,7 @@ static void WHDR(const struct cirrusfb_info *cinfo, unsigned char val) if (cinfo->btype == BT_PICASSO) { /* now first reset HDR access counter */ - dummy = RGen(cinfo, VGA_PEL_IW); + RGen(cinfo, VGA_PEL_IW); udelay(200); /* and at the end, restore the mask value */ From patchwork Wed Jan 13 14:50:01 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 362131 Delivered-To: patch@linaro.org Received: by 2002:a02:ccad:0:0:0:0:0 with SMTP id t13csp598388jap; Wed, 13 Jan 2021 06:51:05 -0800 (PST) X-Google-Smtp-Source: ABdhPJziDDHp/Sobv5fkw1hYLCCNztymN40TB3WrOsAb9RiKBbEL+ldP72ekJGz1JUHEe3q9N4GM X-Received: by 2002:a63:174f:: with SMTP id 15mr2411785pgx.49.1610549464914; Wed, 13 Jan 2021 06:51:04 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1610549464; cv=none; d=google.com; s=arc-20160816; b=XF2mUE7cgHReBOtMoo5bj7Ti2Fusp+1+VjNTXu72yytTyY5lOPgtQhznQhcu2bbTWG qL1kQ5ro7YOM892MlPysG7VNTOwZKrcQhEM3r6330XUcroIRSBziMFAEbZB/Uvwft3Is MDtlcz+ujiC8B6D2Zy7QzeHdVRzVghyrKVA2DEvKl22e1L7uK4RMNw/uSV1+oiOj5wbk d6C5fe/0VejkijmWADCWM6i61i52dfxIF1v3ZemEMUfWtwfJb4B7XkWijPgEWwIrYbER t4dALpS31nbLmwR67Pkz5BvjG7rbMQ2wC5oXgW1bh5U2S0r+jMZSIpCFLhx4YDunhwIg i1Ug== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:cc:list-subscribe :list-help:list-post:list-archive:list-unsubscribe:list-id :precedence:mime-version:references:in-reply-to:message-id:date :subject:to:from:dkim-signature:delivered-to; bh=Vveo/vbN03J4pu602XY+LCT1eZ/st3MVZV90VrCA3E0=; b=xcW/R4wxJQgE/76VQ1E/WRdYgPiq+yaW0yBTmkdTfIpLx+lN7z4ttzyJpNAWvrrDaa vKo6j1jGLrPFrrFi/Ag/vdjO1jIVUSYJzlzM7xWvovK2pL1YO+XRaFUBzopG+smVvZ65 2a0+NawV+oe8IDBNcva+tXMXqnYONOQgBERNOE4Jmg+tlUbD0DAiADMNnnb2fggHIpul qUh1UAFT6ngBkiKPCghblDEpZh1iowpQfSptDxUTcMFqaYD1YKJOmDctDQRncWHefuaP J3gKT5PqhepR8RogM/FMnIUjG9gGOCRMr6rL1SDVBvL5/AawGTEEXkuDeqLLQtndtfsf hbYQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=q1+kp8rl; spf=pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 2610:10:20:722:a800:ff:fe36:1795 as permitted sender) smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from gabe.freedesktop.org (gabe.freedesktop.org. [2610:10:20:722:a800:ff:fe36:1795]) by mx.google.com with ESMTPS id c8si2592080pgw.214.2021.01.13.06.51.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 13 Jan 2021 06:51:04 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 2610:10:20:722:a800:ff:fe36:1795 as permitted sender) client-ip=2610:10:20:722:a800:ff:fe36:1795; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=q1+kp8rl; spf=pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 2610:10:20:722:a800:ff:fe36:1795 as permitted sender) smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id B67F96EA6D; Wed, 13 Jan 2021 14:50:55 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mail-wr1-x42c.google.com (mail-wr1-x42c.google.com [IPv6:2a00:1450:4864:20::42c]) by gabe.freedesktop.org (Postfix) with ESMTPS id 32A956EA62 for ; Wed, 13 Jan 2021 14:50:48 +0000 (UTC) Received: by mail-wr1-x42c.google.com with SMTP id r3so2427416wrt.2 for ; Wed, 13 Jan 2021 06:50:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=8R8CrMmu7yuBA/ZNIQZlAyfMprfiOkPW3GpI5ayBsWg=; b=q1+kp8rlc5YHssN6Eq89+XBI9+3PExs7mtj+vKpE1TFKE1rjX2///yzy+zDTZKSmOo veDWfzfkp2jlcqkWf6hyrhxd4ZIDNoNqF9HS7ddPt4booh+FDzx3O5uQ2G8rdhZHcVp3 PA1ZgIYstzQ14gHP1p8JOg40/+Qe5fqobxdt9bJb49f5X37fSTQnByGZCt6BqgU83z6p QzAtbnYyN0YvKG7g442YVr2E98ZQvzgo4BnA5yP33ogF0/EDLppn6AMEy+q/dBx0eQ5f Im6lCkgNGn1IZSkhzSUaYdClRbl34RHO4jN1MiOjnXDBZW66eOJRiiEjwIv769RVoAR7 qlfA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=8R8CrMmu7yuBA/ZNIQZlAyfMprfiOkPW3GpI5ayBsWg=; b=GQ1lQN5CN3t9N/nXuruGJoYAdWYGOY79rmAytG/C0SfoOcGyeNYZ4m10yqdDs7sLfw wdFoSB/Reg3bFTOfKRSstbYGfPwsBKITY5DJzPuD7xLuo3jd8tW77JlH9o8SxfY84SCM MLZodTCW75uMn1ILiok170Aq2v0Kb0u1VBL5q1uKV9gieh51DOcUETslAwI6wT2AU7Wq Rm8msV+CwUyqaA3HX2T57tLm0D+mSV3JUyGEQvGXaPWELWswJwr2Hy1Ow0vFAWAVLk1A 4b65RonXvFx0YxYBV3wx7vILMR5OfIAco9kb2KBhcJZCg6qk4nHlBXScC0ye87UcYj14 sYtg== X-Gm-Message-State: AOAM5318xAsc9vOz2FApyJmedyy8DGpvJHy2L0Ti26qeZ+FQjXkx/P8T bEOcX52EzY6zHj3V58qCK9mimA== X-Received: by 2002:a5d:4d50:: with SMTP id a16mr2926797wru.43.1610549446928; Wed, 13 Jan 2021 06:50:46 -0800 (PST) Received: from dell.default ([91.110.221.229]) by smtp.gmail.com with ESMTPSA id t188sm3273433wmf.9.2021.01.13.06.50.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 13 Jan 2021 06:50:46 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Subject: [PATCH 23/31] video: fbdev: s1d13xxxfb: Mark debug variables as __maybe_unused Date: Wed, 13 Jan 2021 14:50:01 +0000 Message-Id: <20210113145009.1272040-24-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210113145009.1272040-1-lee.jones@linaro.org> References: <20210113145009.1272040-1-lee.jones@linaro.org> MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-fbdev@vger.kernel.org, Thibaut VARENE , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Ben Dooks , Kristoffer Ericson Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Can't declare these under the same clause as their use, since debugging is enabled manually with an '#if {0,1}', so mark them as __maybe_unused instead to notify the compiler that this behaviour is expected. Fixes the following W=1 kernel build warning(s): drivers/video/fbdev/s1d13xxxfb.c: In function ‘s1d13xxxfb_fetch_hw_state’: drivers/video/fbdev/s1d13xxxfb.c:644:16: warning: variable ‘is_dual’ set but not used [-Wunused-but-set-variable] drivers/video/fbdev/s1d13xxxfb.c:643:11: warning: variable ‘lcd_bpp’ set but not used [-Wunused-but-set-variable] Cc: Kristoffer Ericson Cc: Thibaut VARENE Cc: Ben Dooks Cc: dri-devel@lists.freedesktop.org Cc: linux-fbdev@vger.kernel.org Signed-off-by: Lee Jones --- drivers/video/fbdev/s1d13xxxfb.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/video/fbdev/s1d13xxxfb.c b/drivers/video/fbdev/s1d13xxxfb.c index 4541afcf9386e..e6e8bc74412c6 100644 --- a/drivers/video/fbdev/s1d13xxxfb.c +++ b/drivers/video/fbdev/s1d13xxxfb.c @@ -640,8 +640,8 @@ static void s1d13xxxfb_fetch_hw_state(struct fb_info *info) u16 offset; u32 xres, yres; u32 xres_virtual, yres_virtual; - int bpp, lcd_bpp; - int is_color, is_dual, is_tft; + int bpp, __maybe_unused lcd_bpp; + int is_color, __maybe_unused is_dual, is_tft; int lcd_enabled, crt_enabled; fix->type = FB_TYPE_PACKED_PIXELS; From patchwork Wed Jan 13 14:50:02 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 362130 Delivered-To: patch@linaro.org Received: by 2002:a02:ccad:0:0:0:0:0 with SMTP id t13csp598345jap; Wed, 13 Jan 2021 06:51:02 -0800 (PST) X-Google-Smtp-Source: ABdhPJy715IAEQPTblG6UcOgSKRpMfXKJPxFH8oLxOyHTkoTsga+s5GXXPSz09Ritq14TdsG7a5+ X-Received: by 2002:a17:902:ed14:b029:da:9da4:3091 with SMTP id b20-20020a170902ed14b02900da9da43091mr2580405pld.29.1610549461926; Wed, 13 Jan 2021 06:51:01 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1610549461; cv=none; d=google.com; s=arc-20160816; b=FQs0QqAfORBJc5T4mUCz8sIhCxqR3SKDzhJg7BHBWmxGrgm0Ds5zMdm4+URA1r7gpo ZjD1ofJbBkdAN77W4Rid1TDElDDkzHnAddGfWZ8+HjHztD57P7JfxlbvNxNc57eEDkS+ YI5LFY0t3Fovszn8FlP/pJepbQ20tplujL07Bxi/JohKnDjGzg5yVhD705bcHmyu+yKw Q/cD6I50ocG85Qb4q9AUu4dT3ih/EEeOzB0e0vYwxIx3GyXLOvp9xBFN7+IpXxkBC5tA lR36Pba0w0A+ybE/ZdY4AqA0Jt4i2rOJp7S/H0eVbfAJFIA2lpVIzuJmSeU+VQEiOOC3 avvA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:cc:list-subscribe :list-help:list-post:list-archive:list-unsubscribe:list-id :precedence:mime-version:references:in-reply-to:message-id:date :subject:to:from:dkim-signature:delivered-to; bh=WzI/lAoUWzFaQvYen/OnpeaG7R2v7xtni0hSTQU5Yek=; b=ZTEXl3JZVbXPlx0K1p5Rz9BkNgazPz8GPF/vlSXGn2gRQufYoKkHncEBS2fulJL0hv CiltA6kVB+o9idibIId+w90qwFG4rtOQuKbpR7YEcyr2Fo+xoEcwMFh/k0aMeXJofHxv yiUe2qw7kTXtTOFidSBgojdrqCWtkDZ7sWP6srjMKTdyrhClux+zViQ5nhWTGYwQDRTd j8pV5ovr9wt5CouxhIHTtU5qWCMSEGnXm57mOfZmA9UshyBg2XL3S0cCN1y3GKRyqz16 Jd8E0ZXP09cpSgvza1MVe0gMx1nopUkiOiRQl7bADNJXby0U/Z5hFiKHUk9f/UEJn4ad h2pA== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=k1fbqp18; spf=pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 2610:10:20:722:a800:ff:fe36:1795 as permitted sender) smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from gabe.freedesktop.org (gabe.freedesktop.org. [2610:10:20:722:a800:ff:fe36:1795]) by mx.google.com with ESMTPS id z36si2820762pjj.67.2021.01.13.06.51.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 13 Jan 2021 06:51:01 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 2610:10:20:722:a800:ff:fe36:1795 as permitted sender) client-ip=2610:10:20:722:a800:ff:fe36:1795; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=k1fbqp18; spf=pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 2610:10:20:722:a800:ff:fe36:1795 as permitted sender) smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id CFF776EA6E; Wed, 13 Jan 2021 14:50:55 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mail-wr1-x436.google.com (mail-wr1-x436.google.com [IPv6:2a00:1450:4864:20::436]) by gabe.freedesktop.org (Postfix) with ESMTPS id 505516EA66 for ; Wed, 13 Jan 2021 14:50:49 +0000 (UTC) Received: by mail-wr1-x436.google.com with SMTP id d26so2386549wrb.12 for ; Wed, 13 Jan 2021 06:50:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=DvtlGdT5MHeh268WloE5stTLPTvRDEZ8rCCQAdX9t84=; b=k1fbqp18yv8PIWF/VtBZ1OCxmUUxm3DEuDCdGpp/1lf2Qusjjl6Jr0LbNjCDkAYjum 1/wwNHwC2fYs6yOsRNYBp7G/0/6EKBrI0OVlE9krnhPcy8pLZI8vfx7yCAVMlSMwGOA+ hnp7cTdcUMYNnIJqWcxy66Lo1P3xlU9yPVOVU+OePlvMmIh7A0BSVnlshSywJYQQwzbU 5uukjwiQHWY6GeoO+bNuzYazh3MQdjtKvFY6BEa2ztaEJRUBzfF1uDCo9++RfRW+OfdJ ZYE/I/DDBlwjWjQBrwAXZdAbnCrtVk//3HRL1I6mCpS4vkKtNu8uXUKBPssO/APhiy0t CkPw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=DvtlGdT5MHeh268WloE5stTLPTvRDEZ8rCCQAdX9t84=; b=hRIko46Y7ASkijs1r1XYF2Cebs9oJIhkwjK0w2oykWagyFCC8MSydU5J7VJ3Zvm4kf fD8yiPi2iJeesF9gbIfL3CfJT6/V0GDy/3eExOETn63bdA0t8QK0tt6SfT64I+SwvUU7 NIxhVpTcHE/rUjEndUhShBWZMjH8GT6znLqvDavxbfUgSkL2qgx6UCl9pfeP0OpkrbGt cJrSgt4h/Oua0EtJDxPQD/eNKMFDKQ32SmvIzIQZvNr9Mdbru0xSGRZKJFNnIhHvdAUw JdgSvh8rbMv+2tpwDwUAoNB2slrApAlhwwAOsuQfKKBgvrtgP5DvGVCZjoLYL03im9E/ uqig== X-Gm-Message-State: AOAM530Z48EFRcRyfhKqNrgDEC8IQiblhZWhN9paqe5Mq5lv5QWYiCSH LyfkTJS33wki+nJzNio6WBFHsQ== X-Received: by 2002:adf:eec6:: with SMTP id a6mr2949891wrp.239.1610549448015; Wed, 13 Jan 2021 06:50:48 -0800 (PST) Received: from dell.default ([91.110.221.229]) by smtp.gmail.com with ESMTPSA id t188sm3273433wmf.9.2021.01.13.06.50.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 13 Jan 2021 06:50:47 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Subject: [PATCH 24/31] video: fbdev: s3c-fb: Fix some kernel-doc misdemeanours Date: Wed, 13 Jan 2021 14:50:02 +0000 Message-Id: <20210113145009.1272040-25-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210113145009.1272040-1-lee.jones@linaro.org> References: <20210113145009.1272040-1-lee.jones@linaro.org> MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Ben Dooks , Jingoo Han , linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Fixes the following W=1 kernel build warning(s): drivers/video/fbdev/s3c-fb.c:104: warning: Function parameter or member 'osd_stride' not described in 's3c_fb_variant' drivers/video/fbdev/s3c-fb.c:174: warning: Function parameter or member 'variant' not described in 's3c_fb_win' drivers/video/fbdev/s3c-fb.c:345: warning: Function parameter or member 'pixclk' not described in 's3c_fb_calc_pixclk' drivers/video/fbdev/s3c-fb.c:345: warning: Excess function parameter 'pixclock' description in 's3c_fb_calc_pixclk' drivers/video/fbdev/s3c-fb.c:742: warning: Function parameter or member 'transp' not described in 's3c_fb_setcolreg' drivers/video/fbdev/s3c-fb.c:742: warning: Excess function parameter 'trans' description in 's3c_fb_setcolreg' drivers/video/fbdev/s3c-fb.c:1142: warning: Function parameter or member 'sfb' not described in 's3c_fb_release_win' drivers/video/fbdev/s3c-fb.c:1172: warning: Function parameter or member 'win_no' not described in 's3c_fb_probe_win' Cc: Jingoo Han Cc: Ben Dooks Cc: linux-fbdev@vger.kernel.org Cc: dri-devel@lists.freedesktop.org Signed-off-by: Lee Jones --- drivers/video/fbdev/s3c-fb.c | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) -- 2.25.1 _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel Acked-by: Jingoo Han diff --git a/drivers/video/fbdev/s3c-fb.c b/drivers/video/fbdev/s3c-fb.c index ba316bd56efd7..d33d7df77a6a5 100644 --- a/drivers/video/fbdev/s3c-fb.c +++ b/drivers/video/fbdev/s3c-fb.c @@ -75,6 +75,7 @@ struct s3c_fb; * @buf_size: Offset of buffer size registers. * @buf_end: Offset of buffer end registers. * @osd: The base for the OSD registers. + * @osd_stride: The OSD stride value. * @palette: Address of palette memory, or 0 if none. * @has_prtcon: Set if has PRTCON register. * @has_shadowcon: Set if has SHADOWCON register. @@ -155,7 +156,7 @@ struct s3c_fb_palette { * @windata: The platform data supplied for the window configuration. * @parent: The hardware that this window is part of. * @fbinfo: Pointer pack to the framebuffer info for this window. - * @varint: The variant information for this window. + * @variant: The variant information for this window. * @palette_buffer: Buffer/cache to hold palette entries. * @pseudo_palette: For use in TRUECOLOUR modes for entries 0..15/ * @index: The window number of this window. @@ -336,7 +337,7 @@ static int s3c_fb_check_var(struct fb_var_screeninfo *var, /** * s3c_fb_calc_pixclk() - calculate the divider to create the pixel clock. * @sfb: The hardware state. - * @pixclock: The pixel clock wanted, in picoseconds. + * @pixclk: The pixel clock wanted, in picoseconds. * * Given the specified pixel clock, work out the necessary divider to get * close to the output frequency. @@ -733,7 +734,7 @@ static inline unsigned int chan_to_field(unsigned int chan, * @red: The red field for the palette data. * @green: The green field for the palette data. * @blue: The blue field for the palette data. - * @trans: The transparency (alpha) field for the palette data. + * @transp: The transparency (alpha) field for the palette data. * @info: The framebuffer being changed. */ static int s3c_fb_setcolreg(unsigned regno, @@ -1133,6 +1134,7 @@ static void s3c_fb_free_memory(struct s3c_fb *sfb, struct s3c_fb_win *win) /** * s3c_fb_release_win() - release resources for a framebuffer window. + * @sfb: The base resources for the hardware. * @win: The window to cleanup the resources for. * * Release the resources that where claimed for the hardware window, @@ -1160,6 +1162,7 @@ static void s3c_fb_release_win(struct s3c_fb *sfb, struct s3c_fb_win *win) /** * s3c_fb_probe_win() - register an hardware window * @sfb: The base resources for the hardware + * @win_no: The ID of the window to be registered * @variant: The variant information for this window. * @res: Pointer to where to place the resultant window. * From patchwork Wed Jan 13 14:50:03 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 362135 Delivered-To: patch@linaro.org Received: by 2002:a02:ccad:0:0:0:0:0 with SMTP id t13csp599454jap; Wed, 13 Jan 2021 06:52:24 -0800 (PST) X-Google-Smtp-Source: ABdhPJwJJVM2sIqssW8qfx9uBYWNvMuA4Y9X0fn74A/LhZdCcXeJU94+fJisdmDxemfoLBEPB4PF X-Received: by 2002:a17:902:fe08:b029:de:36a1:9f12 with SMTP id g8-20020a170902fe08b02900de36a19f12mr1954779plj.30.1610549463217; Wed, 13 Jan 2021 06:51:03 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1610549463; cv=none; d=google.com; s=arc-20160816; b=LHJCcam+bkMVNqjIbBadAWZv219V1u3IQwmhxAtHuF29Mdrmh1c6+XRTBEGP96pU5P ImFqojy1SepgAtyi7zWn5U2IG1xh5S7jqSjvRZS9ELqLglZfYmxJ5l+LZWGRrPZs5hXm 6LgGjyYN/ZST/TxOpisNISLFf3NellapIb4VG7Txg4143HBVrPEkdrXQx1u1XS9I4etG Zh7fYPYujCgyJLmBBzvzQZnLJSd06wOEPa41d+nCjp9TKrRkd2xUhFziUdfljacEVr+T JxSsA3T7gBDLmDjXJMqOl2W9uVLgnRuBmqu/r8nAvGGBQsuHo5bmwfHaGRwnmpJjTpYG Wk3A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:cc:list-subscribe :list-help:list-post:list-archive:list-unsubscribe:list-id :precedence:mime-version:references:in-reply-to:message-id:date :subject:to:from:dkim-signature:delivered-to; bh=VuwO2+c8IegemHXNVDRaBLXIlxP/LTMJk5M3wcQ16+4=; b=DeJPy8naYHw/geuPXRth+ulk+nQUyRstbeagHz9nyjnRJXoK4uhmpfZJxYtFJdaNkn QdHvlr7PTU6VNsabzyISgwUtxaxkNiMlNM7VVfn+NM0b4J7DL386cvbTK7UFruJ920v4 BK1i3izWuetbFK6awslVC7xDGwg3D7CxmNPCNJt/YP5sIwKQmyU1O0A4nyeZYiFSfZMD wudqEvbBzilwR13vafARdZtzu21F5KFNfte60HDwE/ueuEnuiBpsclxl9/rFbFaFY8wy poae3PXseIVHLaGufNEFWGFTdzwoOTY6qGKUxS1vz8AXKAqJp2nEDmt+uK+VATQOgAMs WWFw== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=ClTWBKea; spf=pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 2610:10:20:722:a800:ff:fe36:1795 as permitted sender) smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from gabe.freedesktop.org (gabe.freedesktop.org. [2610:10:20:722:a800:ff:fe36:1795]) by mx.google.com with ESMTPS id c68si2537377pfc.230.2021.01.13.06.51.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 13 Jan 2021 06:51:03 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 2610:10:20:722:a800:ff:fe36:1795 as permitted sender) client-ip=2610:10:20:722:a800:ff:fe36:1795; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=ClTWBKea; spf=pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 2610:10:20:722:a800:ff:fe36:1795 as permitted sender) smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 53BD36EA64; Wed, 13 Jan 2021 14:50:57 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mail-wr1-x429.google.com (mail-wr1-x429.google.com [IPv6:2a00:1450:4864:20::429]) by gabe.freedesktop.org (Postfix) with ESMTPS id 8ED436EA6E for ; Wed, 13 Jan 2021 14:50:50 +0000 (UTC) Received: by mail-wr1-x429.google.com with SMTP id c5so2409744wrp.6 for ; Wed, 13 Jan 2021 06:50:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=cx+Lvpr+opVztxwCrpEEue+3ZpAhdFGYil/Lm2hEOBU=; b=ClTWBKea4vm3y9ZVGUdkzqdOECtwhR9PudkWuiyjwsis41BqC493w/zvDp2ojr1Xuc ZKnKrxsByJZR0AsZRzPwnncxKrIpJo8q/JxnXgt5uVjgHffxSyJ/m/GiYYZFr0k/fKPF mAUTMzojahcDs+ltW3aBgJgY0pUiUSDu1uCQsHcM5514XCdauiHH8Frr9ruELCw0BD/E FTVVet0fiPEihuRkcU9+1jE680PoB0pOR4Fx8MdQ56p1l1lAxW4F53kcOf3dMgFbW0wD nLFBJyF35Zz+nr0o3nFYMPOFbn8EmarY0vsbpWCUmYqEvxpBpYIoiNLTuo7DHxfJGp22 4RYA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=cx+Lvpr+opVztxwCrpEEue+3ZpAhdFGYil/Lm2hEOBU=; b=m92Hj37/sgWizPZQza2PDa2Z4HtWBjf4UtZKUv846QO1D7VBh6pGp2SMFgcjJacswn bc3g9hs1/u/KnZy1uACFENNYlI6fmAlUjgCpAjM0wXRht73U6GXsL2EZ0myqqR+h6UwN hkH8oW+khulKQkvCa9Rr9OoGQu3w9f6C/OEJnMOEHnKJdNyJTkpyFOJT8SCkYnoJ5kOM rp+DwrZFCmqrohpkCtLA8XjTgHT1Il6Qu21AR3IXvPEoHlub9i9GRh7DG5MFSpfg9Yda 44B8x0aLFAi0Qy//hsTcF6dx67TP8E48obxlhxYYjxatt0OLd5/QHl6KKdP2XTgOPXfo DM1w== X-Gm-Message-State: AOAM533pnlkgN2AgV1N90GNGGs91dAHOqstyCf4OQMQFD32mkZJaME5S ZREm/hSYYer0faA1LZ4nr31xAQ== X-Received: by 2002:a5d:674b:: with SMTP id l11mr3094653wrw.247.1610549449265; Wed, 13 Jan 2021 06:50:49 -0800 (PST) Received: from dell.default ([91.110.221.229]) by smtp.gmail.com with ESMTPSA id t188sm3273433wmf.9.2021.01.13.06.50.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 13 Jan 2021 06:50:48 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Subject: [PATCH 25/31] video: fbdev: mx3fb: Remove unused variable 'enabled' Date: Wed, 13 Jan 2021 14:50:03 +0000 Message-Id: <20210113145009.1272040-26-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210113145009.1272040-1-lee.jones@linaro.org> References: <20210113145009.1272040-1-lee.jones@linaro.org> MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-fbdev@vger.kernel.org, Arnd Bergmann , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Software Engineering , Sam Ravnborg Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Fixes the following W=1 kernel build warning(s): drivers/video/fbdev/mx3fb.c: In function ‘sdc_disable_channel’: drivers/video/fbdev/mx3fb.c:448:11: warning: variable ‘enabled’ set but not used [-Wunused-but-set-variable] Cc: Sam Ravnborg Cc: Arnd Bergmann Cc: Software Engineering Cc: dri-devel@lists.freedesktop.org Cc: linux-fbdev@vger.kernel.org Signed-off-by: Lee Jones --- drivers/video/fbdev/mx3fb.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/video/fbdev/mx3fb.c b/drivers/video/fbdev/mx3fb.c index 894617ddabcb6..d1c8f7a969ac3 100644 --- a/drivers/video/fbdev/mx3fb.c +++ b/drivers/video/fbdev/mx3fb.c @@ -445,7 +445,6 @@ static void sdc_enable_channel(struct mx3fb_info *mx3_fbi) static void sdc_disable_channel(struct mx3fb_info *mx3_fbi) { struct mx3fb_data *mx3fb = mx3_fbi->mx3fb; - uint32_t enabled; unsigned long flags; if (mx3_fbi->txd == NULL) @@ -453,7 +452,7 @@ static void sdc_disable_channel(struct mx3fb_info *mx3_fbi) spin_lock_irqsave(&mx3fb->lock, flags); - enabled = sdc_fb_uninit(mx3_fbi); + sdc_fb_uninit(mx3_fbi); spin_unlock_irqrestore(&mx3fb->lock, flags); From patchwork Wed Jan 13 14:50:04 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 362136 Delivered-To: patch@linaro.org Received: by 2002:a02:ccad:0:0:0:0:0 with SMTP id t13csp599579jap; Wed, 13 Jan 2021 06:52:33 -0800 (PST) X-Google-Smtp-Source: ABdhPJz8k62OypzCYjmJRsPADjxqglBpo1Mc60ymLJsx9IPyvDkJi4SLbE7khM1tfk3begvR8RkP X-Received: by 2002:a65:4542:: with SMTP id x2mr2416182pgr.90.1610549455589; Wed, 13 Jan 2021 06:50:55 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1610549455; cv=none; d=google.com; s=arc-20160816; b=qQVieYF7jYM4Tme6Nv2jCoTGEsSiyTuzt1FbaqGqC8zvjoroP0AYimmrJ9UsvQsaER Pu3jwLmxEecl6qHXmifxTC9Xx5WoCQtPluPt9Oho5eDO+EafJjgYFr1qv3zuEAEzHKm1 O9cS1mc4WhSrKdCcD2uVQme8O2U+FFhqgsT1oT7TxqoDbTv32jLswh5JGfb1pz/sdt/8 Uc3TAADMbdTgRnb7Mx4DtwpCNUejFxzKpmOcJopZskLL6vkRYAEi3NQDT8njsMSgsvyf di3cTZy5axcbd3ukm2BakFINJAwVKK146WKRbIU4MRzI9q3IFPJ+AHp5AuipCl7ovaBi 8ntg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:cc:list-subscribe :list-help:list-post:list-archive:list-unsubscribe:list-id :precedence:mime-version:references:in-reply-to:message-id:date :subject:to:from:dkim-signature:delivered-to; bh=KHZjDRHAEakhyZQ77R7NXlnxY1w5QfYt6qh+tS4lvZg=; b=y7mCFdgxqyR8QxIcx/LMX2k+PAdheEvWJ+z8FNgwWqnSCMNHS/614Kb8KKFEUSaF7G zxpwWbqpYf99BclQCnfWTP52TRzBff2tjrdTgC7AzvasFI2S6uYUQwsNxoXrd7+rZCJo AwljcYt1fI/sGX3IyJJiFaxOaPQ8xgJuUUCz/4kc4lVfspbZHQZzYpicHm0xSPGvQe1g To/ocqj6HeL0SSj1GHExPKCeoCoRIcGBb3g56qG20RvgXn72J6QS1PfVJ2jjSYxWnYt3 Sgd3I0v+Vxa53rnXuy8o9PPSJ/6FKYUq9DNNQVJ95lxcMbpVT6v61gqNDkfulFpjXBWk ZOgg== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=IDza5YLi; spf=pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 2610:10:20:722:a800:ff:fe36:1795 as permitted sender) smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from gabe.freedesktop.org (gabe.freedesktop.org. [2610:10:20:722:a800:ff:fe36:1795]) by mx.google.com with ESMTPS id s78si2661023pgs.166.2021.01.13.06.50.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 13 Jan 2021 06:50:55 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 2610:10:20:722:a800:ff:fe36:1795 as permitted sender) client-ip=2610:10:20:722:a800:ff:fe36:1795; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=IDza5YLi; spf=pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 2610:10:20:722:a800:ff:fe36:1795 as permitted sender) smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id D70996EA63; Wed, 13 Jan 2021 14:50:52 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mail-wm1-x332.google.com (mail-wm1-x332.google.com [IPv6:2a00:1450:4864:20::332]) by gabe.freedesktop.org (Postfix) with ESMTPS id B2EB36EA75 for ; Wed, 13 Jan 2021 14:50:51 +0000 (UTC) Received: by mail-wm1-x332.google.com with SMTP id h17so1655136wmq.1 for ; Wed, 13 Jan 2021 06:50:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=fiTAiO1+djM4LYXjGKueW16bvgv2sBtNiLbtIOEARdk=; b=IDza5YLilamkwPDT+g2/a0lofmuncKNpAv/y/6ZQX7PTgZHHrzIscPArIaLwzgGk21 +PTQkWm+NELC+KC9BFDcWCwiEBGUoc7D99iVhf/b8Zau/fF4+imDj62ocQwZfhj48s7p G301bdVxqdgcGdeZ0mOu5lmhiQU2WC/WPRGqNZpFfUOiJAjYflnQOI3iCRme45LwRAT5 UA87z3v5OeC740plgM+jScryysn9swGK41grynXPhZPBHzL1uyI195awHeRx0r0D+KV6 M3YDyk1IDQxUtVgKliH+QZdMV6naG94aZh3W2EpFGPxDHMNQ6+AhIUIbY31cyP7lq5uP Fxpw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=fiTAiO1+djM4LYXjGKueW16bvgv2sBtNiLbtIOEARdk=; b=rneRT7ri/RTMWCtOSg7OhjsZrFRRh49Wnpqutk3HDzl+ojmUxL9aF0t1lkLCPEjTgx ONwJCL0CzgCBneuXb12y8xV33nbj31OCTqfkrBqOPzj9NcgBELWMHMzD8922do009kAm OHSDekLujc0I4GooXF7JecdknudzaxMntKeqEaNwp95ctZi+q2zlnKW6B5W9tJ3EmgnE YReGkt1kjeBZbc9wGm4EslDPkHBmoYLq1yx1n+xSqxfoAS/vuk8+LPe3GFJzJE/RuALH QMEaHnQEw+mXuPF9FHAoJus1vXgdsia8B04rkRU4cqiNx+4sZDooCj5V0p1FJjpBj+qS r5mQ== X-Gm-Message-State: AOAM531n9i+1lMbqHAh0kL6SwipylXuwhg5JlktlQ7z6dJx02Uqo0On6 oq8um7t2qw2JZq8Pp8lLqHKEow== X-Received: by 2002:a1c:988f:: with SMTP id a137mr2554157wme.130.1610549450459; Wed, 13 Jan 2021 06:50:50 -0800 (PST) Received: from dell.default ([91.110.221.229]) by smtp.gmail.com with ESMTPSA id t188sm3273433wmf.9.2021.01.13.06.50.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 13 Jan 2021 06:50:49 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Subject: [PATCH 26/31] video: fbdev: riva: riva_hw: Remove set but unused variables 'vus_p' and 'vus_n' Date: Wed, 13 Jan 2021 14:50:04 +0000 Message-Id: <20210113145009.1272040-27-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210113145009.1272040-1-lee.jones@linaro.org> References: <20210113145009.1272040-1-lee.jones@linaro.org> MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: dri-devel@lists.freedesktop.org, linux-fbdev@vger.kernel.org, Jeff Garzik , linux-kernel@vger.kernel.org Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Fixes the following W=1 kernel build warning(s): drivers/video/fbdev/riva/riva_hw.c: In function ‘nv10CalcArbitration’: drivers/video/fbdev/riva/riva_hw.c:845:23: warning: variable ‘vus_p’ set but not used [-Wunused-but-set-variable] drivers/video/fbdev/riva/riva_hw.c:845:16: warning: variable ‘vus_n’ set but not used [-Wunused-but-set-variable] Cc: Antonino Daplas Cc: Jeff Garzik Cc: linux-fbdev@vger.kernel.org Cc: dri-devel@lists.freedesktop.org Signed-off-by: Lee Jones --- drivers/video/fbdev/riva/riva_hw.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/video/fbdev/riva/riva_hw.c b/drivers/video/fbdev/riva/riva_hw.c index 4ee63f7d84d3e..2bc510c24aa9e 100644 --- a/drivers/video/fbdev/riva/riva_hw.c +++ b/drivers/video/fbdev/riva/riva_hw.c @@ -842,7 +842,7 @@ static void nv10CalcArbitration int found, mclk_extra, mclk_loop, cbs, m1; int mclk_freq, pclk_freq, nvclk_freq, mp_enable; int us_m, us_m_min, us_n, us_p, crtc_drain_rate; - int vus_m, vus_n, vus_p; + int vus_m; int vpm_us, us_video, cpm_us, us_crt,clwm; int clwm_rnd_down; int m2us, us_pipe_min, p1clk, p2; @@ -924,8 +924,6 @@ static void nv10CalcArbitration us_pipe_min = us_m_min + us_n + us_p; vus_m = mclk_loop *1000*1000 / mclk_freq; /* Mclk latency in us */ - vus_n = (4)*1000*1000 / nvclk_freq;/* nvclk latency in us */ - vus_p = 0*1000*1000 / pclk_freq;/* pclk latency in us */ if(video_enable) { crtc_drain_rate = pclk_freq * bpp/8; /* MB/s */ From patchwork Wed Jan 13 14:50:06 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 362129 Delivered-To: patch@linaro.org Received: by 2002:a02:ccad:0:0:0:0:0 with SMTP id t13csp598306jap; Wed, 13 Jan 2021 06:50:59 -0800 (PST) X-Google-Smtp-Source: ABdhPJyNbFOHHzSSvqdwiUgGbSo3OMU9/6oVsRZM9D3W7RRkwrVdTLqw1xjT+4bq3531oiYj97UT X-Received: by 2002:a17:90a:e28c:: with SMTP id d12mr2823565pjz.236.1610549459662; Wed, 13 Jan 2021 06:50:59 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1610549459; cv=none; d=google.com; s=arc-20160816; b=sLe2v8RuU23z96ZA2h66cMGihb9XqjHKuir9JOxWC40vDAigbor5BIAdgqiShjqazH 1c760D3rpevZN484dCCe0qf5iwUOe9H1zueU79VCozd3tsdR2FDcfZJokyEFrczdekly QKyxusqVScveD/q4JikRubXmeQI/Mj69+qXHczE4BXNkILIiGR8Ui3kKDBw5tv8AP2rf wxTsp35pvIYmoKiI7L2FQQ3LRdqZJcONgZn0+ro1WEWdNiVabLYp9p05z5Ho97NKsuef 66gocDlPiFKb1Hc+xDeE8XTQApW38ATfnlmWTJo0w5pSDPni/wZzgjwmwf/s2eM1nIr7 ZTzQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:cc:list-subscribe :list-help:list-post:list-archive:list-unsubscribe:list-id :precedence:mime-version:references:in-reply-to:message-id:date :subject:to:from:dkim-signature:delivered-to; bh=AIuORTiejd22GATnX2MTz7YUZ8IOuLrrhDyGk+xgGwU=; b=w+stSWpcfQcAomg708jWeAmiYPMP2mrW6hPR/uoB8VCeN14mZN3DppgnsuHrQZOfVE 6c76/wfuXUd7PvmiHIv4SMT1FRzP7b0Vpmayl8d+608iO21zPTgM4QLKxjAsfjqM1xxo WzMrzK6AzviEbefBkjeq5x0GXYHJFPlj8jxYr3o+jTAT2+vheJk1K9g5BIGs85u5W8M1 3aZfMysYaW2pmkYMb/r4TXJQtwWhz2q+06FVYygLIg+u+vK2LGxIrX+c31NG9GAs8AWc 0Tnv9dzwUzIkpByW+pw3IWvSz6E6JkbIifvyBa7vhiLMSq7Ir9oMsDB5Q/n76ZlfV+KK lsQA== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=MymSG+nX; spf=pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 2610:10:20:722:a800:ff:fe36:1795 as permitted sender) smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from gabe.freedesktop.org (gabe.freedesktop.org. [2610:10:20:722:a800:ff:fe36:1795]) by mx.google.com with ESMTPS id t19si2604047pgi.249.2021.01.13.06.50.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 13 Jan 2021 06:50:59 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 2610:10:20:722:a800:ff:fe36:1795 as permitted sender) client-ip=2610:10:20:722:a800:ff:fe36:1795; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=MymSG+nX; spf=pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 2610:10:20:722:a800:ff:fe36:1795 as permitted sender) smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 93BF96EA6B; Wed, 13 Jan 2021 14:50:55 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mail-wm1-x32b.google.com (mail-wm1-x32b.google.com [IPv6:2a00:1450:4864:20::32b]) by gabe.freedesktop.org (Postfix) with ESMTPS id 9B5AA6EA64 for ; Wed, 13 Jan 2021 14:50:54 +0000 (UTC) Received: by mail-wm1-x32b.google.com with SMTP id 3so1854229wmg.4 for ; Wed, 13 Jan 2021 06:50:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=9xOmpZJSJcGjkWdwzXh/1wdxHxk1qdbTp529iSzZw+A=; b=MymSG+nXTdHHBzQGPOze7DAAa+ej555u1BcqPgKwDdULmCR+9lifj/RBMgwbwLjlyt elvEBNHzvmvW/yms4fg79Qi5WzxgrFr7YClQKZgIpcNwnQ6ljdR5HdRdcTX3fA10rdIO aO30H/7nbBKrI5hxOWH6sSs6sEMtOANO1pinWzByh2d2GV3m/EpoTjowTDqX+0kZ8xaX liF75WImH8LTXSQqNUBp9HlqfewIAHFYh7spBcCRwDuq6cWAwda7+vnAqeuvQNX58v7P 03COI9tjDj1PG/ZMJxlUk7Sxq24UPa6mvTMs6nk8c9qwdcBQeIG7i50znWEf+3nSQ5RB JzdQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=9xOmpZJSJcGjkWdwzXh/1wdxHxk1qdbTp529iSzZw+A=; b=jKVuVopLCL3udHgA3+xINnolXvglvSG182iR4eZucMKfUf11y6neoNobjOweJZ3Ly/ KOILGB6soaRAv0DXXcl06smpvn92JO/m4IinTgOblXzBO6d7bmuUyWZ1rK6KN2lg86CG zNPDN9traY56KRAfprM8J+q8b/qwfYXmuNZ4mxiD9z4/iS9ktDAusQEnjXjmcwHjfrt+ GWd9acoBs15yEY/eWAiLCQfdYDqyrtWCil3qOGtl9UI2ZDHGCFQXvLjklSNwK/b43Jlf qtagPeao0BXkYNT1rekI2YDerWI/4cjyLisCyvifxFAVdGjUxxO4xIGF4wlKy18JzPvq Mbag== X-Gm-Message-State: AOAM532IGYqlYY+hfGyNQySbP0HgDuhKQFJfoiBqmm49BCqNOxekvgF2 T6g5g8I/eKVyfIL+PPBmCu6MGA== X-Received: by 2002:a05:600c:29cc:: with SMTP id s12mr1724821wmd.180.1610549453390; Wed, 13 Jan 2021 06:50:53 -0800 (PST) Received: from dell.default ([91.110.221.229]) by smtp.gmail.com with ESMTPSA id t188sm3273433wmf.9.2021.01.13.06.50.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 13 Jan 2021 06:50:52 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Subject: [PATCH 28/31] video: fbdev: cirrusfb: Add description for 'info' and correct spelling of 'regbase' Date: Wed, 13 Jan 2021 14:50:06 +0000 Message-Id: <20210113145009.1272040-29-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210113145009.1272040-1-lee.jones@linaro.org> References: <20210113145009.1272040-1-lee.jones@linaro.org> MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-fbdev@vger.kernel.org, Jeff Garzik , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Fixes the following W=1 kernel build warning(s): drivers/video/fbdev/cirrusfb.c:2815: warning: Function parameter or member 'info' not described in 'cirrusfb_dbg_print_regs' drivers/video/fbdev/cirrusfb.c:2815: warning: Function parameter or member 'regbase' not described in 'cirrusfb_dbg_print_regs' drivers/video/fbdev/cirrusfb.c:2815: warning: Excess function parameter 'base' description in 'cirrusfb_dbg_print_regs' drivers/video/fbdev/cirrusfb.c:2859: warning: Function parameter or member 'info' not described in 'cirrusfb_dbg_reg_dump' drivers/video/fbdev/cirrusfb.c:2859: warning: Function parameter or member 'regbase' not described in 'cirrusfb_dbg_reg_dump' drivers/video/fbdev/cirrusfb.c:2859: warning: Excess function parameter 'base' description in 'cirrusfb_dbg_reg_dump' Cc: Jeff Garzik Cc: dri-devel@lists.freedesktop.org Cc: linux-fbdev@vger.kernel.org Signed-off-by: Lee Jones --- drivers/video/fbdev/cirrusfb.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) -- 2.25.1 _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel diff --git a/drivers/video/fbdev/cirrusfb.c b/drivers/video/fbdev/cirrusfb.c index f05160fa34da9..bb2cc753c1cf5 100644 --- a/drivers/video/fbdev/cirrusfb.c +++ b/drivers/video/fbdev/cirrusfb.c @@ -2800,7 +2800,8 @@ static void bestclock(long freq, int *nom, int *den, int *div) /** * cirrusfb_dbg_print_regs - * @base: If using newmmio, the newmmio base address, otherwise %NULL + * @info: frame buffer info structure + * @regbase: If using newmmio, the newmmio base address, otherwise %NULL * @reg_class: type of registers to read: %CRT, or %SEQ * * DESCRIPTION: @@ -2847,7 +2848,8 @@ static void cirrusfb_dbg_print_regs(struct fb_info *info, /** * cirrusfb_dbg_reg_dump - * @base: If using newmmio, the newmmio base address, otherwise %NULL + * @info: frame buffer info structure + * @regbase: If using newmmio, the newmmio base address, otherwise %NULL * * DESCRIPTION: * Dumps a list of interesting VGA and CIRRUSFB registers. If @base is %NULL, From patchwork Wed Jan 13 14:50:07 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 362139 Delivered-To: patch@linaro.org Received: by 2002:a02:ccad:0:0:0:0:0 with SMTP id t13csp599837jap; Wed, 13 Jan 2021 06:52:51 -0800 (PST) X-Google-Smtp-Source: ABdhPJwsvmHAkx6F5pgpz0slIPjZHhnR9Q9FMDSoZXqEptn99IkCkXSGW89AQ5DP6d5/sJIMh1Ny X-Received: by 2002:a17:90a:f288:: with SMTP id fs8mr2769491pjb.184.1610549469393; Wed, 13 Jan 2021 06:51:09 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1610549469; cv=none; d=google.com; s=arc-20160816; b=Wp/1puNp/NVzar7DcqX+FXUnxpBUdhhTfy4LIJhBilvID/u+cZxkFEaCQOsUsv/DYB w5lMMNTzWqRii7OxHZvRhouNavh4Ou8Jvrbzwa0We5esvsLFpYdrmwP4rDxy0FH4BIi2 Jx8uJJdhp5g3zuY6jrru1RPVDVPgtcNXJPR3T8BoJOCxHR5kTGJbDRpB+rShPzo7EXNt Om8Hd22HiFuwvnE27E9j1jA8f2gMgrOPNhrWb3wOHSFrFDJAmOxOSJF92hSYG4wVkgEp MPUOumpHPWQyw36SPmIsrMUw2b2NTEd+CIFKrqV2QJkg2MB5LsOmsHjwh8QCrDLYdKg1 j0iw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:cc:list-subscribe :list-help:list-post:list-archive:list-unsubscribe:list-id :precedence:mime-version:references:in-reply-to:message-id:date :subject:to:from:dkim-signature:delivered-to; bh=dZd0dMq79kDkzQr6E0oOFabClJcMWMX69kZxq6avxds=; b=KWW0SJtWFU/H0bwLwPJh1051QmoZCzJ+qu9Irh4DAZbnUTu8bVJ5z7hDIN3e/YaipD 6qWvjPY7A+WsV5XOVjZGXGORo8dP6WgDePU9swrMLa1+QYF6HkcBMHfRXy2oX1ZZ1jT6 ISwdOVnXGi1BJY4iO2FfpbtuOZoiEfeaNUueHCqcfYoMxTKuK8V0ot5GNwBQJd40OmvC 9zaXDBVR2zOaNigabD7qJKJJ/iDUHT04SCofHag2qHldmZr88aAWZaC/lFBiRb6JPzAD wZ+W97v6TPfNwp0im1iFQQGiJgLlTULRk+8yghN5wOGM6ZO/qi7dYoaHKfWWlN1XVEqx eb3A== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=r5T8a1xo; spf=pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 2610:10:20:722:a800:ff:fe36:1795 as permitted sender) smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from gabe.freedesktop.org (gabe.freedesktop.org. [2610:10:20:722:a800:ff:fe36:1795]) by mx.google.com with ESMTPS id o9si2794734pgl.13.2021.01.13.06.51.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 13 Jan 2021 06:51:09 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 2610:10:20:722:a800:ff:fe36:1795 as permitted sender) client-ip=2610:10:20:722:a800:ff:fe36:1795; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=r5T8a1xo; spf=pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 2610:10:20:722:a800:ff:fe36:1795 as permitted sender) smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id B010E6EA74; Wed, 13 Jan 2021 14:51:05 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mail-wr1-x42d.google.com (mail-wr1-x42d.google.com [IPv6:2a00:1450:4864:20::42d]) by gabe.freedesktop.org (Postfix) with ESMTPS id B4BED6EA64 for ; Wed, 13 Jan 2021 14:50:55 +0000 (UTC) Received: by mail-wr1-x42d.google.com with SMTP id c5so2410076wrp.6 for ; Wed, 13 Jan 2021 06:50:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=BzS3qZvHYgaPOU1XJ8pzaZK9gKJ87LqYUfVBvla6rAk=; b=r5T8a1xoDb37mL9jIaJql8CuqF65c13F0JN0BADlmBJtoOSiLcHLQQE0zXy42jaISG L+mOCdoDYshlaFwezWabUiL61Rpla5d4FFyMQCCDUECkUNO1e6hFSngniGnbMl3TwRw+ 0YBTdOFYXyzAsLFnu8j9xEbDQHDJuqj6YN1tK1TxHEmTQvc5vFrEV8J9bQUUCzhlQc/L uEKFperGkCjqCYYjupjJDiL5O1pf0WMWVTyoYuZMKqCrDTJBlNsucq2nS6FxjcouMcm8 ZJnYRxOZO/pAbljJIw7+ZWc1fEo6pqh7BSCCdYtMIEOpTqkl93Az01qWCSLh9dnj+3/e 0yYQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=BzS3qZvHYgaPOU1XJ8pzaZK9gKJ87LqYUfVBvla6rAk=; b=ftlRTnABwAVZ3vvFYlD5lebN8VnHli8DzsLBMukl7FIAfg+yLSpeyHLwEHOj/MV58h Ibfx/dtUUoCehYQNXlqJ/isHrMXJpyVekqFxAmXnN+VfcFVKC3HViBqFuDQ/jhb0qTrV tOee41a2NRpKdYU/60rdzLz0xZZw13970p8TvdSBTox04NxepS+2VWpYoERpnae9nuIV iUpo2mgPxAhyCpd2TPaspRrHHt9JBpAOAHiphVF+JlTI6bNeS7KbgguwdaPiQMlHUBbf F+R4T+mGe6Ir5w6b4TZsUJ1mgnDcBzdhboBuOXFiQ9TeCFWI1/z5+IJrzOJm1CkqDPUw MM5A== X-Gm-Message-State: AOAM531SAqBfSxJbyx5wufPDmtVQoZGezJlpvKrsf84SMB5mGoUVm94v OsFfqzRJCP2ViBCiFOvN/ocW6w== X-Received: by 2002:a5d:5227:: with SMTP id i7mr3134555wra.68.1610549454505; Wed, 13 Jan 2021 06:50:54 -0800 (PST) Received: from dell.default ([91.110.221.229]) by smtp.gmail.com with ESMTPSA id t188sm3273433wmf.9.2021.01.13.06.50.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 13 Jan 2021 06:50:53 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Subject: [PATCH 29/31] video: fbdev: s1d13xxxfb: Function name must be on the 2nd line in kernel-doc Date: Wed, 13 Jan 2021 14:50:07 +0000 Message-Id: <20210113145009.1272040-30-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210113145009.1272040-1-lee.jones@linaro.org> References: <20210113145009.1272040-1-lee.jones@linaro.org> MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-fbdev@vger.kernel.org, Thibaut VARENE , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Ben Dooks , Kristoffer Ericson Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Fixes the following W=1 kernel build warning(s): drivers/video/fbdev/s1d13xxxfb.c:515: warning: Cannot understand * Cc: Kristoffer Ericson Cc: Thibaut VARENE Cc: Ben Dooks Cc: dri-devel@lists.freedesktop.org Cc: linux-fbdev@vger.kernel.org Signed-off-by: Lee Jones --- drivers/video/fbdev/s1d13xxxfb.c | 1 - 1 file changed, 1 deletion(-) -- 2.25.1 _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel diff --git a/drivers/video/fbdev/s1d13xxxfb.c b/drivers/video/fbdev/s1d13xxxfb.c index e6e8bc74412c6..b21627c07f8d0 100644 --- a/drivers/video/fbdev/s1d13xxxfb.c +++ b/drivers/video/fbdev/s1d13xxxfb.c @@ -512,7 +512,6 @@ s1d13xxxfb_bitblt_copyarea(struct fb_info *info, const struct fb_copyarea *area) } /** - * * s1d13xxxfb_bitblt_solidfill - accelerated solidfill function * @info : framebuffer structure * @rect : fb_fillrect structure From patchwork Wed Jan 13 14:50:09 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 362133 Delivered-To: patch@linaro.org Received: by 2002:a02:ccad:0:0:0:0:0 with SMTP id t13csp598469jap; Wed, 13 Jan 2021 06:51:08 -0800 (PST) X-Google-Smtp-Source: ABdhPJx8xBtA1cNMaEPRlhXaWhn3Wn4Fp0cHMxQ4KPfjdlpq576eJ5gyHK/tizvHu93d0Iuc7kbe X-Received: by 2002:a17:902:b416:b029:dc:3657:9265 with SMTP id x22-20020a170902b416b02900dc36579265mr2769032plr.24.1610549467918; Wed, 13 Jan 2021 06:51:07 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1610549467; cv=none; d=google.com; s=arc-20160816; b=E+5tbDNlgzxB8BuC9VHMtouKL9I3Qq2eiZe4wDDWCi5BkU37zPlFp9iNRGfSBTnLMH IAuVinFFTyVFXLalLceQtH9XohR+PMAnfRsnVr4mJfwmlfqhZP5TVPF8BQ/7ywOyuHV/ Ih2wvCyxaJktQttw1f+WxYGmqOz9b9pHQ3cfjqTrbC2Smcsw30ygkpWSgySLvbJfpAnp 3h+B3ZMBUEFlxw72SMaHMibEDS50yJ4vo9KJ0wpnWMASTgaQJD028At9+N8E5R/4El1C Qw6oPSe6RjraRzrSfKj+q/xrHLjYDgtiVCzAPiA1IE3aKpWLgkKxC9MCDL1cMFgluakJ 00gA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:cc:list-subscribe :list-help:list-post:list-archive:list-unsubscribe:list-id :precedence:mime-version:references:in-reply-to:message-id:date :subject:to:from:dkim-signature:delivered-to; bh=42cRb3Uq4gARpBD0k7iufVmFWAYtQDotTs5JUr3jHwQ=; b=X5PbYlANeivt5AicMOuAUnKCfUYoIafRLc46MfZPoV/15XWn69TvcvnBNWAf/xg+5U ti6vYXgoYL37n58nhYtSaCe+5nCezD73bR4ZsePZJoQJfoAR36obLGaTwObSm8g5Nqar mR2MVpow0a26Wut/geP7ihco8Y5WR4WBcpm6IkV1b8S99b5YMXHOqB3fPiTETUtsFYnN KWaEREyUTZiuk8YRVdmfUmWGiIdjeNn1Hd0fGc6TUdm9NndhN0IiTbCRxew5AErNTgLh g0bEIEoTgVMbW7yp0UzOQo5UlYA1vIeUHcBiA0f6ToKEkhKFcPe1asvx6l39Im5R/1o2 tJpw== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=dw+awuMm; spf=pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 2610:10:20:722:a800:ff:fe36:1795 as permitted sender) smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from gabe.freedesktop.org (gabe.freedesktop.org. [2610:10:20:722:a800:ff:fe36:1795]) by mx.google.com with ESMTPS id c16si2465796pgg.507.2021.01.13.06.51.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 13 Jan 2021 06:51:07 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 2610:10:20:722:a800:ff:fe36:1795 as permitted sender) client-ip=2610:10:20:722:a800:ff:fe36:1795; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=dw+awuMm; spf=pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 2610:10:20:722:a800:ff:fe36:1795 as permitted sender) smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id A81576EA6F; Wed, 13 Jan 2021 14:51:04 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mail-wr1-x42d.google.com (mail-wr1-x42d.google.com [IPv6:2a00:1450:4864:20::42d]) by gabe.freedesktop.org (Postfix) with ESMTPS id 7CDEC6EA66 for ; Wed, 13 Jan 2021 14:50:58 +0000 (UTC) Received: by mail-wr1-x42d.google.com with SMTP id d13so2385665wrc.13 for ; Wed, 13 Jan 2021 06:50:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=ruS/5Q88or74bT1MGQpJfhS5CAkw8vidMq7dDib2fZs=; b=dw+awuMm/xszxko06x1zbZDXJLrY8h9w46Ii0r1I8t7M23qIokSEWF+lctfR7ifEG+ 10hTw/DwZRUnEFPhAVSO68dOG3xRMSECzOqgPEZGcaXkIwEZpNzwO47CVeLh022fRJlH jDBbte4+oRAEKQsXCuHQ59dmP92NSYRrJJV3l5taYJRqGkZfD+TVnytK3qk0j65GJPKu 2f+mh5IUw8l2pURTp/2Vx0/xKSO+Pb15iZss30ox0FSMT0+dZ7zRgUjqCFkx8UoasarG 0QTSmkjRG6zgnWk6plq18kDAdy0dxgi5AzQNxp96r0OLZ3jhu/aqmtWdmf/vSBNmKOFD AtZw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=ruS/5Q88or74bT1MGQpJfhS5CAkw8vidMq7dDib2fZs=; b=TOpuJtOkEAOoV0JBuzB+dnj3xaBNReqSpPEVx8BJIeUwhKR7KH030jWezuCqrnA+Tt f40AaYfpfAYnpxRNk++zblPVYrSHYlPswV+Qu62uzG++faaglfpIKYvSmFOj6A9fzTuL FvR04RVgqIqUgUBcplVUL+uodyEqK18p5WyuaisF2bpoLyWdUPDl1CbVL8c7bdRA3Npw bEJu1RUxWZv8LrUl6UtTXynUI5Z5j2PuvX+CBEln5sSCxK86AI5MQXA2pfYRmJO5iBLg C0Yc52luql7OJudP8sGZ3Oi9kTwYbcpYKf9kha2MAHxUE/Mpz0Q7kJmETAITmMf6Zaz1 gwaw== X-Gm-Message-State: AOAM530IiiH5kSm1qUCVE5gA4sAqjCudbjTvg3R3QLHPzO/N5P8hlZLE gscI3OXplfs+OhPBocO/OZYwmg== X-Received: by 2002:a5d:530c:: with SMTP id e12mr3034474wrv.54.1610549457244; Wed, 13 Jan 2021 06:50:57 -0800 (PST) Received: from dell.default ([91.110.221.229]) by smtp.gmail.com with ESMTPSA id t188sm3273433wmf.9.2021.01.13.06.50.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 13 Jan 2021 06:50:56 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Subject: [PATCH 31/31] video: fbdev: mx3fb: Fix some kernel-doc issues Date: Wed, 13 Jan 2021 14:50:09 +0000 Message-Id: <20210113145009.1272040-32-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210113145009.1272040-1-lee.jones@linaro.org> References: <20210113145009.1272040-1-lee.jones@linaro.org> MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-fbdev@vger.kernel.org, Arnd Bergmann , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Software Engineering , Sam Ravnborg Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Fixes the following W=1 kernel build warning(s): drivers/video/fbdev/mx3fb.c:738: warning: Function parameter or member 'fbi' not described in 'mx3fb_set_fix' drivers/video/fbdev/mx3fb.c:738: warning: Excess function parameter 'info' description in 'mx3fb_set_fix' drivers/video/fbdev/mx3fb.c:1109: warning: Function parameter or member 'blank' not described in 'mx3fb_blank' drivers/video/fbdev/mx3fb.c:1109: warning: Function parameter or member 'fbi' not described in 'mx3fb_blank' drivers/video/fbdev/mx3fb.c:1134: warning: Function parameter or member 'fbi' not described in 'mx3fb_pan_display' drivers/video/fbdev/mx3fb.c:1134: warning: Excess function parameter 'info' description in 'mx3fb_pan_display' drivers/video/fbdev/mx3fb.c:1393: warning: Function parameter or member 'dev' not described in 'mx3fb_init_fbinfo' drivers/video/fbdev/mx3fb.c:1393: warning: Function parameter or member 'ops' not described in 'mx3fb_init_fbinfo' Cc: Sam Ravnborg Cc: Arnd Bergmann Cc: Software Engineering Cc: dri-devel@lists.freedesktop.org Cc: linux-fbdev@vger.kernel.org Signed-off-by: Lee Jones --- drivers/video/fbdev/mx3fb.c | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) -- 2.25.1 _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel diff --git a/drivers/video/fbdev/mx3fb.c b/drivers/video/fbdev/mx3fb.c index d1c8f7a969ac3..a0fad25136fe5 100644 --- a/drivers/video/fbdev/mx3fb.c +++ b/drivers/video/fbdev/mx3fb.c @@ -731,7 +731,7 @@ static int mx3fb_unmap_video_memory(struct fb_info *fbi); /** * mx3fb_set_fix() - set fixed framebuffer parameters from variable settings. - * @info: framebuffer information pointer + * @fbi: framebuffer information pointer * @return: 0 on success or negative error code on failure. */ static int mx3fb_set_fix(struct fb_info *fbi) @@ -1104,6 +1104,8 @@ static void __blank(int blank, struct fb_info *fbi) /** * mx3fb_blank() - blank the display. + * @blank: blank mode (unblank, normal, {v,h}sync_suspend, powerdown) + * @fbi: framebuffer information pointer */ static int mx3fb_blank(int blank, struct fb_info *fbi) { @@ -1125,7 +1127,7 @@ static int mx3fb_blank(int blank, struct fb_info *fbi) /** * mx3fb_pan_display() - pan or wrap the display * @var: variable screen buffer information. - * @info: framebuffer information pointer. + * @fbi: framebuffer information pointer. * * We look only at xoffset, yoffset and the FB_VMODE_YWRAP flag */ @@ -1384,7 +1386,7 @@ static int mx3fb_unmap_video_memory(struct fb_info *fbi) return 0; } -/** +/* * mx3fb_init_fbinfo() - initialize framebuffer information object. * @return: initialized framebuffer structure. */