From patchwork Fri Jan 8 20:14:18 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 359027 Delivered-To: patch@linaro.org Received: by 2002:a02:85a7:0:0:0:0:0 with SMTP id d36csp855427jai; Fri, 8 Jan 2021 12:15:13 -0800 (PST) X-Google-Smtp-Source: ABdhPJzkRc22WwDmftIhU6PrWi5xjSoB5QTkPvjaydTA7w6hVjdkyoosiffb932qkLkvWrkOx7oW X-Received: by 2002:a17:90a:4e47:: with SMTP id t7mr5601440pjl.13.1610136913297; Fri, 08 Jan 2021 12:15:13 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1610136913; cv=none; d=google.com; s=arc-20160816; b=MWuvobWQTZ2EcwL+2HuHoZ0+3bfD6neUJw1LZm8236uUjIvKqoJcuVZdTCuDDmFATD bERX+XP3lCRRxLQ/RcvJSZopzADgiQzzW0p3+cOg3bedOtPFfAGqmkL2HtGv+DF9NJEz gY1H3rKTdD+XewidyBT+kM8y8OEmfMdHLhXUzH+eZPUzR8cgKQl9iU0FZhxC003GKFZ8 a4f4C1y3Lhrk0lgHx+abcwP05R7igLQEK6hHYu0IC7hXsGbF2cbCkIehgfkcsVgImBy8 XE+ipIUQGJsscnt5y4tQIQT9MNglNis4/E4ov9jFXs/iPMo2vePwjLcdXCG9Ju25/yMo 99+g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:cc:list-subscribe :list-help:list-post:list-archive:list-unsubscribe:list-id :precedence:mime-version:references:in-reply-to:message-id:date :subject:to:from:dkim-signature:delivered-to; bh=2TS/hJo/fWGv0sFIIWg3dMU/Eapys3InB/2wDqhTE9s=; b=o2XuF82L7rrWWnC9dzfVnrs32D+bx564HouBaWjdb/FKrlpl1Efd+WmMw3vU1Fy1Yi XboJwUf2GRbOzONoFYvZGavTGp43USh3radW+DEJ32F8ShdS+T2zto2kwpaWAC+kLvHd I1DAJAewY1+6yopdBJU9moeju5/YfmSYrWBnTG9onPRvp23rENt+/XNVLHi9oaeYyBu7 //F4mD9W6b41oiu3XYZfJw5AqbY8DTkfyYQDeG8CYvVJnT+mE0i2HlnSIB0us1yakAjX KvRwwjSTnk+kknbT1rb52xXIW9YCSe+y5las+tvfONOT+x/9M455Wx+GH0nMZ8776dJ4 8Ltw== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=S3bxMD82; spf=pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 131.252.210.177 as permitted sender) smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from gabe.freedesktop.org (gabe.freedesktop.org. [131.252.210.177]) by mx.google.com with ESMTPS id h20si9907209pgb.377.2021.01.08.12.15.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 08 Jan 2021 12:15:13 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 131.252.210.177 as permitted sender) client-ip=131.252.210.177; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=S3bxMD82; spf=pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 131.252.210.177 as permitted sender) smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 8F0E46E8C6; Fri, 8 Jan 2021 20:15:08 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mail-wm1-x32a.google.com (mail-wm1-x32a.google.com [IPv6:2a00:1450:4864:20::32a]) by gabe.freedesktop.org (Postfix) with ESMTPS id 410876E8C3 for ; Fri, 8 Jan 2021 20:15:07 +0000 (UTC) Received: by mail-wm1-x32a.google.com with SMTP id a6so8731080wmc.2 for ; Fri, 08 Jan 2021 12:15:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=Fiuzme89Ha1gFIX5TYoxx7reahVwymZ2zttK6hYzwGc=; b=S3bxMD82Q/1aNG8TdFey29UpOjZ++Kdc4qMrfThlwB3Q3fP9dB9TCTW2wImqmdX6pa rvBzqOuNt8FdG+VjCh3zmOZx40boYOi01A8hUp6wH2huQEwQwgE9TyIuDLvaAAUcuEMM 94JnIeFTayPMIEBVwrtKMbtnXTZxlqsxVCs74PwVWVgln1c+ytmMJ2QWvzPzG/5DuG0t 0fdd5y/iassFqzPTW1NMQ39Y+3VUz2CyoqPqFtZBkXFPFA2obV9b7y6GvE4fbAKsIse3 wXgLdpNhr4qwry0t7V9BTK2nJvCSoH8g7wALzkPff78+61EtEN/nKC368DfQze6+hU3y eIew== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=Fiuzme89Ha1gFIX5TYoxx7reahVwymZ2zttK6hYzwGc=; b=bQ2OvmGH1c97TXJ+0lTOWQsgwKaGcM7x3DEUc58xGL++z/CKRSMKSpJRn8BdF/RkcM nUAVy8sXLkC4//Dh8K0RjdeB33G2659uayjY40SwQpuYDG7gudy05PXP+6ZkH6uXq1/j gC01H1KnLwOBOndjfiYI30o+XifjzKXG7OwiRuKfu1NyddVr6HoOL+rD0owQ54112VV6 4YetDvBEJpg4Rr36SIAHheKNIfjvPg8V12stMN6xOggf2sb8MmrFKFJIP/ZPDf9Seym/ uvzhTBV3U2DSO2F7hHeMwWXxJpWTuum3H1olqXAOByMWwvZvcYDyTO+0tsXc69pVGi0G vxsQ== X-Gm-Message-State: AOAM532AT6bZqLXDf+31Jf0psf9SwfYVY+OE7I9ELrqm4BgzoTcdxcSf f1a0oVZqTAeHhN685/KUihSTAw== X-Received: by 2002:a1c:6208:: with SMTP id w8mr4514080wmb.96.1610136905813; Fri, 08 Jan 2021 12:15:05 -0800 (PST) Received: from dell.default ([91.110.221.229]) by smtp.gmail.com with ESMTPSA id l8sm15598671wrb.73.2021.01.08.12.15.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 08 Jan 2021 12:15:05 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Subject: [PATCH 01/40] drm/nouveau/nvkm/subdev/bios/init: Demote obvious abuse of kernel-doc Date: Fri, 8 Jan 2021 20:14:18 +0000 Message-Id: <20210108201457.3078600-2-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210108201457.3078600-1-lee.jones@linaro.org> References: <20210108201457.3078600-1-lee.jones@linaro.org> MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: David Airlie , nouveau@lists.freedesktop.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Ben Skeggs Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/nouveau/nvkm/subdev/bios/init.c:584: warning: Function parameter or member 'init' not described in 'init_reserved' drivers/gpu/drm/nouveau/nvkm/subdev/bios/init.c:611: warning: Function parameter or member 'init' not described in 'init_done' drivers/gpu/drm/nouveau/nvkm/subdev/bios/init.c:622: warning: Function parameter or member 'init' not described in 'init_io_restrict_prog' drivers/gpu/drm/nouveau/nvkm/subdev/bios/init.c:659: warning: Function parameter or member 'init' not described in 'init_repeat' drivers/gpu/drm/nouveau/nvkm/subdev/bios/init.c:685: warning: Function parameter or member 'init' not described in 'init_io_restrict_pll' drivers/gpu/drm/nouveau/nvkm/subdev/bios/init.c:725: warning: Function parameter or member 'init' not described in 'init_end_repeat' NB: Trimmed for brevity (lots of these!) Cc: Ben Skeggs Cc: David Airlie Cc: Daniel Vetter Cc: dri-devel@lists.freedesktop.org Cc: nouveau@lists.freedesktop.org Signed-off-by: Lee Jones --- .../gpu/drm/nouveau/nvkm/subdev/bios/init.c | 204 ++++++------------ 1 file changed, 68 insertions(+), 136 deletions(-) -- 2.25.1 _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel diff --git a/drivers/gpu/drm/nouveau/nvkm/subdev/bios/init.c b/drivers/gpu/drm/nouveau/nvkm/subdev/bios/init.c index 9de74f41dcd2a..5a91dc4e5c8ec 100644 --- a/drivers/gpu/drm/nouveau/nvkm/subdev/bios/init.c +++ b/drivers/gpu/drm/nouveau/nvkm/subdev/bios/init.c @@ -575,9 +575,8 @@ init_tmds_reg(struct nvbios_init *init, u8 tmds) * init opcode handlers *****************************************************************************/ -/** +/* * init_reserved - stub for various unknown/unused single-byte opcodes - * */ static void init_reserved(struct nvbios_init *init) @@ -602,9 +601,8 @@ init_reserved(struct nvbios_init *init) init->offset += length; } -/** +/* * INIT_DONE - opcode 0x71 - * */ static void init_done(struct nvbios_init *init) @@ -613,9 +611,8 @@ init_done(struct nvbios_init *init) init->offset = 0x0000; } -/** +/* * INIT_IO_RESTRICT_PROG - opcode 0x32 - * */ static void init_io_restrict_prog(struct nvbios_init *init) @@ -650,9 +647,8 @@ init_io_restrict_prog(struct nvbios_init *init) trace("}]\n"); } -/** +/* * INIT_REPEAT - opcode 0x33 - * */ static void init_repeat(struct nvbios_init *init) @@ -676,9 +672,8 @@ init_repeat(struct nvbios_init *init) init->repeat = repeat; } -/** +/* * INIT_IO_RESTRICT_PLL - opcode 0x34 - * */ static void init_io_restrict_pll(struct nvbios_init *init) @@ -716,9 +711,8 @@ init_io_restrict_pll(struct nvbios_init *init) trace("}]\n"); } -/** +/* * INIT_END_REPEAT - opcode 0x36 - * */ static void init_end_repeat(struct nvbios_init *init) @@ -732,9 +726,8 @@ init_end_repeat(struct nvbios_init *init) } } -/** +/* * INIT_COPY - opcode 0x37 - * */ static void init_copy(struct nvbios_init *init) @@ -759,9 +752,8 @@ init_copy(struct nvbios_init *init) init_wrvgai(init, port, index, data); } -/** +/* * INIT_NOT - opcode 0x38 - * */ static void init_not(struct nvbios_init *init) @@ -771,9 +763,8 @@ init_not(struct nvbios_init *init) init_exec_inv(init); } -/** +/* * INIT_IO_FLAG_CONDITION - opcode 0x39 - * */ static void init_io_flag_condition(struct nvbios_init *init) @@ -788,9 +779,8 @@ init_io_flag_condition(struct nvbios_init *init) init_exec_set(init, false); } -/** +/* * INIT_GENERIC_CONDITION - opcode 0x3a - * */ static void init_generic_condition(struct nvbios_init *init) @@ -840,9 +830,8 @@ init_generic_condition(struct nvbios_init *init) } } -/** +/* * INIT_IO_MASK_OR - opcode 0x3b - * */ static void init_io_mask_or(struct nvbios_init *init) @@ -859,9 +848,8 @@ init_io_mask_or(struct nvbios_init *init) init_wrvgai(init, 0x03d4, index, data &= ~(1 << or)); } -/** +/* * INIT_IO_OR - opcode 0x3c - * */ static void init_io_or(struct nvbios_init *init) @@ -878,9 +866,8 @@ init_io_or(struct nvbios_init *init) init_wrvgai(init, 0x03d4, index, data | (1 << or)); } -/** +/* * INIT_ANDN_REG - opcode 0x47 - * */ static void init_andn_reg(struct nvbios_init *init) @@ -895,9 +882,8 @@ init_andn_reg(struct nvbios_init *init) init_mask(init, reg, mask, 0); } -/** +/* * INIT_OR_REG - opcode 0x48 - * */ static void init_or_reg(struct nvbios_init *init) @@ -912,9 +898,8 @@ init_or_reg(struct nvbios_init *init) init_mask(init, reg, 0, mask); } -/** +/* * INIT_INDEX_ADDRESS_LATCHED - opcode 0x49 - * */ static void init_idx_addr_latched(struct nvbios_init *init) @@ -942,9 +927,8 @@ init_idx_addr_latched(struct nvbios_init *init) } } -/** +/* * INIT_IO_RESTRICT_PLL2 - opcode 0x4a - * */ static void init_io_restrict_pll2(struct nvbios_init *init) @@ -977,9 +961,8 @@ init_io_restrict_pll2(struct nvbios_init *init) trace("}]\n"); } -/** +/* * INIT_PLL2 - opcode 0x4b - * */ static void init_pll2(struct nvbios_init *init) @@ -994,9 +977,8 @@ init_pll2(struct nvbios_init *init) init_prog_pll(init, reg, freq); } -/** +/* * INIT_I2C_BYTE - opcode 0x4c - * */ static void init_i2c_byte(struct nvbios_init *init) @@ -1025,9 +1007,8 @@ init_i2c_byte(struct nvbios_init *init) } } -/** +/* * INIT_ZM_I2C_BYTE - opcode 0x4d - * */ static void init_zm_i2c_byte(struct nvbios_init *init) @@ -1051,9 +1032,8 @@ init_zm_i2c_byte(struct nvbios_init *init) } } -/** +/* * INIT_ZM_I2C - opcode 0x4e - * */ static void init_zm_i2c(struct nvbios_init *init) @@ -1085,9 +1065,8 @@ init_zm_i2c(struct nvbios_init *init) } } -/** +/* * INIT_TMDS - opcode 0x4f - * */ static void init_tmds(struct nvbios_init *init) @@ -1111,9 +1090,8 @@ init_tmds(struct nvbios_init *init) init_wr32(init, reg + 0, addr); } -/** +/* * INIT_ZM_TMDS_GROUP - opcode 0x50 - * */ static void init_zm_tmds_group(struct nvbios_init *init) @@ -1138,9 +1116,8 @@ init_zm_tmds_group(struct nvbios_init *init) } } -/** +/* * INIT_CR_INDEX_ADDRESS_LATCHED - opcode 0x51 - * */ static void init_cr_idx_adr_latch(struct nvbios_init *init) @@ -1168,9 +1145,8 @@ init_cr_idx_adr_latch(struct nvbios_init *init) init_wrvgai(init, 0x03d4, addr0, save0); } -/** +/* * INIT_CR - opcode 0x52 - * */ static void init_cr(struct nvbios_init *init) @@ -1188,9 +1164,8 @@ init_cr(struct nvbios_init *init) init_wrvgai(init, 0x03d4, addr, val | data); } -/** +/* * INIT_ZM_CR - opcode 0x53 - * */ static void init_zm_cr(struct nvbios_init *init) @@ -1205,9 +1180,8 @@ init_zm_cr(struct nvbios_init *init) init_wrvgai(init, 0x03d4, addr, data); } -/** +/* * INIT_ZM_CR_GROUP - opcode 0x54 - * */ static void init_zm_cr_group(struct nvbios_init *init) @@ -1229,9 +1203,8 @@ init_zm_cr_group(struct nvbios_init *init) } } -/** +/* * INIT_CONDITION_TIME - opcode 0x56 - * */ static void init_condition_time(struct nvbios_init *init) @@ -1256,9 +1229,8 @@ init_condition_time(struct nvbios_init *init) init_exec_set(init, false); } -/** +/* * INIT_LTIME - opcode 0x57 - * */ static void init_ltime(struct nvbios_init *init) @@ -1273,9 +1245,8 @@ init_ltime(struct nvbios_init *init) mdelay(msec); } -/** +/* * INIT_ZM_REG_SEQUENCE - opcode 0x58 - * */ static void init_zm_reg_sequence(struct nvbios_init *init) @@ -1298,9 +1269,8 @@ init_zm_reg_sequence(struct nvbios_init *init) } } -/** +/* * INIT_PLL_INDIRECT - opcode 0x59 - * */ static void init_pll_indirect(struct nvbios_init *init) @@ -1317,9 +1287,8 @@ init_pll_indirect(struct nvbios_init *init) init_prog_pll(init, reg, freq); } -/** +/* * INIT_ZM_REG_INDIRECT - opcode 0x5a - * */ static void init_zm_reg_indirect(struct nvbios_init *init) @@ -1336,9 +1305,8 @@ init_zm_reg_indirect(struct nvbios_init *init) init_wr32(init, addr, data); } -/** +/* * INIT_SUB_DIRECT - opcode 0x5b - * */ static void init_sub_direct(struct nvbios_init *init) @@ -1362,9 +1330,8 @@ init_sub_direct(struct nvbios_init *init) init->offset += 3; } -/** +/* * INIT_JUMP - opcode 0x5c - * */ static void init_jump(struct nvbios_init *init) @@ -1380,9 +1347,8 @@ init_jump(struct nvbios_init *init) init->offset += 3; } -/** +/* * INIT_I2C_IF - opcode 0x5e - * */ static void init_i2c_if(struct nvbios_init *init) @@ -1407,9 +1373,8 @@ init_i2c_if(struct nvbios_init *init) init_exec_force(init, false); } -/** +/* * INIT_COPY_NV_REG - opcode 0x5f - * */ static void init_copy_nv_reg(struct nvbios_init *init) @@ -1433,9 +1398,8 @@ init_copy_nv_reg(struct nvbios_init *init) init_mask(init, dreg, ~dmask, (data & smask) ^ sxor); } -/** +/* * INIT_ZM_INDEX_IO - opcode 0x62 - * */ static void init_zm_index_io(struct nvbios_init *init) @@ -1451,9 +1415,8 @@ init_zm_index_io(struct nvbios_init *init) init_wrvgai(init, port, index, data); } -/** +/* * INIT_COMPUTE_MEM - opcode 0x63 - * */ static void init_compute_mem(struct nvbios_init *init) @@ -1469,9 +1432,8 @@ init_compute_mem(struct nvbios_init *init) init_exec_force(init, false); } -/** +/* * INIT_RESET - opcode 0x65 - * */ static void init_reset(struct nvbios_init *init) @@ -1496,9 +1458,8 @@ init_reset(struct nvbios_init *init) init_exec_force(init, false); } -/** +/* * INIT_CONFIGURE_MEM - opcode 0x66 - * */ static u16 init_configure_mem_clk(struct nvbios_init *init) @@ -1555,9 +1516,8 @@ init_configure_mem(struct nvbios_init *init) init_exec_force(init, false); } -/** +/* * INIT_CONFIGURE_CLK - opcode 0x67 - * */ static void init_configure_clk(struct nvbios_init *init) @@ -1589,9 +1549,8 @@ init_configure_clk(struct nvbios_init *init) init_exec_force(init, false); } -/** +/* * INIT_CONFIGURE_PREINIT - opcode 0x68 - * */ static void init_configure_preinit(struct nvbios_init *init) @@ -1615,9 +1574,8 @@ init_configure_preinit(struct nvbios_init *init) init_exec_force(init, false); } -/** +/* * INIT_IO - opcode 0x69 - * */ static void init_io(struct nvbios_init *init) @@ -1655,9 +1613,8 @@ init_io(struct nvbios_init *init) init_wrport(init, port, data | value); } -/** +/* * INIT_SUB - opcode 0x6b - * */ static void init_sub(struct nvbios_init *init) @@ -1682,9 +1639,8 @@ init_sub(struct nvbios_init *init) init->offset += 2; } -/** +/* * INIT_RAM_CONDITION - opcode 0x6d - * */ static void init_ram_condition(struct nvbios_init *init) @@ -1701,9 +1657,8 @@ init_ram_condition(struct nvbios_init *init) init_exec_set(init, false); } -/** +/* * INIT_NV_REG - opcode 0x6e - * */ static void init_nv_reg(struct nvbios_init *init) @@ -1719,9 +1674,8 @@ init_nv_reg(struct nvbios_init *init) init_mask(init, reg, ~mask, data); } -/** +/* * INIT_MACRO - opcode 0x6f - * */ static void init_macro(struct nvbios_init *init) @@ -1743,9 +1697,8 @@ init_macro(struct nvbios_init *init) init->offset += 2; } -/** +/* * INIT_RESUME - opcode 0x72 - * */ static void init_resume(struct nvbios_init *init) @@ -1755,9 +1708,8 @@ init_resume(struct nvbios_init *init) init_exec_set(init, true); } -/** +/* * INIT_STRAP_CONDITION - opcode 0x73 - * */ static void init_strap_condition(struct nvbios_init *init) @@ -1773,9 +1725,8 @@ init_strap_condition(struct nvbios_init *init) init_exec_set(init, false); } -/** +/* * INIT_TIME - opcode 0x74 - * */ static void init_time(struct nvbios_init *init) @@ -1794,9 +1745,8 @@ init_time(struct nvbios_init *init) } } -/** +/* * INIT_CONDITION - opcode 0x75 - * */ static void init_condition(struct nvbios_init *init) @@ -1811,9 +1761,8 @@ init_condition(struct nvbios_init *init) init_exec_set(init, false); } -/** +/* * INIT_IO_CONDITION - opcode 0x76 - * */ static void init_io_condition(struct nvbios_init *init) @@ -1828,9 +1777,8 @@ init_io_condition(struct nvbios_init *init) init_exec_set(init, false); } -/** +/* * INIT_ZM_REG16 - opcode 0x77 - * */ static void init_zm_reg16(struct nvbios_init *init) @@ -1845,9 +1793,8 @@ init_zm_reg16(struct nvbios_init *init) init_wr32(init, addr, data); } -/** +/* * INIT_INDEX_IO - opcode 0x78 - * */ static void init_index_io(struct nvbios_init *init) @@ -1867,9 +1814,8 @@ init_index_io(struct nvbios_init *init) init_wrvgai(init, port, index, data | value); } -/** +/* * INIT_PLL - opcode 0x79 - * */ static void init_pll(struct nvbios_init *init) @@ -1884,9 +1830,8 @@ init_pll(struct nvbios_init *init) init_prog_pll(init, reg, freq); } -/** +/* * INIT_ZM_REG - opcode 0x7a - * */ static void init_zm_reg(struct nvbios_init *init) @@ -1904,9 +1849,8 @@ init_zm_reg(struct nvbios_init *init) init_wr32(init, addr, data); } -/** +/* * INIT_RAM_RESTRICT_PLL - opcde 0x87 - * */ static void init_ram_restrict_pll(struct nvbios_init *init) @@ -1934,9 +1878,8 @@ init_ram_restrict_pll(struct nvbios_init *init) } } -/** +/* * INIT_RESET_BEGUN - opcode 0x8c - * */ static void init_reset_begun(struct nvbios_init *init) @@ -1945,9 +1888,8 @@ init_reset_begun(struct nvbios_init *init) init->offset += 1; } -/** +/* * INIT_RESET_END - opcode 0x8d - * */ static void init_reset_end(struct nvbios_init *init) @@ -1956,9 +1898,8 @@ init_reset_end(struct nvbios_init *init) init->offset += 1; } -/** +/* * INIT_GPIO - opcode 0x8e - * */ static void init_gpio(struct nvbios_init *init) @@ -1972,9 +1913,8 @@ init_gpio(struct nvbios_init *init) nvkm_gpio_reset(gpio, DCB_GPIO_UNUSED); } -/** +/* * INIT_RAM_RESTRICT_ZM_GROUP - opcode 0x8f - * */ static void init_ram_restrict_zm_reg_group(struct nvbios_init *init) @@ -2010,9 +1950,8 @@ init_ram_restrict_zm_reg_group(struct nvbios_init *init) } } -/** +/* * INIT_COPY_ZM_REG - opcode 0x90 - * */ static void init_copy_zm_reg(struct nvbios_init *init) @@ -2027,9 +1966,8 @@ init_copy_zm_reg(struct nvbios_init *init) init_wr32(init, dreg, init_rd32(init, sreg)); } -/** +/* * INIT_ZM_REG_GROUP - opcode 0x91 - * */ static void init_zm_reg_group(struct nvbios_init *init) @@ -2049,9 +1987,8 @@ init_zm_reg_group(struct nvbios_init *init) } } -/** +/* * INIT_XLAT - opcode 0x96 - * */ static void init_xlat(struct nvbios_init *init) @@ -2077,9 +2014,8 @@ init_xlat(struct nvbios_init *init) init_mask(init, daddr, ~dmask, data); } -/** +/* * INIT_ZM_MASK_ADD - opcode 0x97 - * */ static void init_zm_mask_add(struct nvbios_init *init) @@ -2098,9 +2034,8 @@ init_zm_mask_add(struct nvbios_init *init) init_wr32(init, addr, data); } -/** +/* * INIT_AUXCH - opcode 0x98 - * */ static void init_auxch(struct nvbios_init *init) @@ -2122,9 +2057,8 @@ init_auxch(struct nvbios_init *init) } } -/** +/* * INIT_AUXCH - opcode 0x99 - * */ static void init_zm_auxch(struct nvbios_init *init) @@ -2144,9 +2078,8 @@ init_zm_auxch(struct nvbios_init *init) } } -/** +/* * INIT_I2C_LONG_IF - opcode 0x9a - * */ static void init_i2c_long_if(struct nvbios_init *init) @@ -2183,9 +2116,8 @@ init_i2c_long_if(struct nvbios_init *init) init_exec_set(init, false); } -/** +/* * INIT_GPIO_NE - opcode 0xa9 - * */ static void init_gpio_ne(struct nvbios_init *init) From patchwork Fri Jan 8 20:14:19 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 359028 Delivered-To: patch@linaro.org Received: by 2002:a02:85a7:0:0:0:0:0 with SMTP id d36csp855451jai; Fri, 8 Jan 2021 12:15:16 -0800 (PST) X-Google-Smtp-Source: ABdhPJwN6quXEe67OuS0O7QXj30ZFqn8NJBkF7UVusxsh6hd8QD2Tn5lyQ8SbATL7tKVz6RomvUV X-Received: by 2002:a17:90a:8b08:: with SMTP id y8mr5394310pjn.42.1610136916248; Fri, 08 Jan 2021 12:15:16 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1610136916; cv=none; d=google.com; s=arc-20160816; b=QWJZ5APHpm+FQt8cYdRrT2nnxhisVbE0DR2xStc5wQ8ym3E852njj3BndJ0wK5Q8eu rWSL7Q+mPqJG8+Ytxu2M/NsgK43SB3L4mWMIOH4GIIsS2QFaVNVZvVEkdWXXhRlEiE5N FLDVWAd6CWaWL65WVS7+8z5fZKC0e7Gf6nB6rf/H6JbuZ8kANUBp9na+RfTGdYRDtaLg lIjzc4JKDpzg+wrWhzllh+ABfrFM2Nd4+0j/+KHUY1L8qOCRAFPmiaWDpk5EBE6vIxf/ vQQnJv1xjE1NabYZFa8DtWJumqmODu8oe/0zVti3wXK9i4Fh2HyAlp1vk0NVTwjr2HFL oc6g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:cc:list-subscribe :list-help:list-post:list-archive:list-unsubscribe:list-id :precedence:mime-version:references:in-reply-to:message-id:date :subject:to:from:dkim-signature:delivered-to; bh=FB8n563SoEtWMJrJ19rH+V3wbJMWqG0woY/a/PkINgk=; b=jPVyZBPy6zIQ/AMQxAdck6Ow/EfQPqEYNSUO2LIi+xn36/2oOlWXfEW3QwC+P6T77c 1HtHlckPGuqtTIAU3BN4JNvNYpMQP1MUnf6/H1A9grIL0YRcczHLSD0HB+joVv+WdSwl lt6wkU90feGBTuKE1BpVa0ahl6oee4cS0Bh2EO5ABSWN7wi0b1ZMoueKd5rQLCzG+3Vz v1JrlQPMPiMLizV9xztZgi2NbXkyExm3teRlST2Ey+d5M7HvP1l6JnrCoIPG0ZyniCBk VivjKrnB1hfkrMAeDWJf9AHQQG2jiiMRSWjFIFk5XkLnueYOKxFBfxFiFaXAhi50mRis WfNA== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=yAbWapUq; spf=pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 2610:10:20:722:a800:ff:fe36:1795 as permitted sender) smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from gabe.freedesktop.org (gabe.freedesktop.org. [2610:10:20:722:a800:ff:fe36:1795]) by mx.google.com with ESMTPS id be11si5333007plb.394.2021.01.08.12.15.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 08 Jan 2021 12:15:16 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 2610:10:20:722:a800:ff:fe36:1795 as permitted sender) client-ip=2610:10:20:722:a800:ff:fe36:1795; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=yAbWapUq; spf=pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 2610:10:20:722:a800:ff:fe36:1795 as permitted sender) smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 329446E8C9; Fri, 8 Jan 2021 20:15:10 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mail-wr1-x42d.google.com (mail-wr1-x42d.google.com [IPv6:2a00:1450:4864:20::42d]) by gabe.freedesktop.org (Postfix) with ESMTPS id BC8DD6E8C7 for ; Fri, 8 Jan 2021 20:15:08 +0000 (UTC) Received: by mail-wr1-x42d.google.com with SMTP id y17so10128692wrr.10 for ; Fri, 08 Jan 2021 12:15:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=CLC3wxlYHWQ6PZsMNQdNLlm9sisuncKTa88XLx3zSUE=; b=yAbWapUqHe8VBH9G3KF49EDy/sQO6m+wgwLul50t3CREipW6GSC25Q0XUGNXI+5XDS cAMwcDsYmksX5DAN6QjkNeVu+KSWOoBaiMbvkUIXK9OlK14JbvaAtWtCGg8QIHPRyxjV e7YVrUJHXqnL8JE6wvQIBqXddGl+TU/O0ne7C55/pIRN5Pw1te6MlvwclqB2a3wyJYxt ZSUwUtFgjcXdYIpYfvOCe9W9jeLF6WARUmrw91MnBu2qdIVBQrtRZ5rP43ChK0k87CYf Pgj99VtP3blz3INbhrXCSedTTuvz/tA64m63/vAtY0NWtL67rDl7yraJ/QLw0A/4GyhL o/zQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=CLC3wxlYHWQ6PZsMNQdNLlm9sisuncKTa88XLx3zSUE=; b=ckrqjevdUfYc/wSu0ei+GajZIlO0SnWzODXPGCSiv6mq5/YbKcQ3Y4zSqsVxVjSUol M7CTNqrk+QlYIokduz8GZhogYFzrD1ZSDutOoflfpYrI9JvRn7Y1QWDmCT0BRAnMi16n 6Eh2nrErrJdNOu2UxGwF6AsDRAI9DSdkSfCYrQG/EfrHWWKcRv4pdydx8xpzS+CXtmvI nfmPuG0XHlOL7qQqBlyBryPeo49EF0CY4UTKhvSOQH9M1Z1yddz2agTeUWcMfq8fEYMS gsyVVa5F5lI7Myo3acKeAcp56NBL4GSyBScyn6NU40HDuE0Q+Gq5QNsdv77/5oYhvnUf rw3w== X-Gm-Message-State: AOAM531w9O5TW+FWLp0G+ijw1z6xMtnOnTFaJL17ldq7ZhXUazFNlDB+ WrLsfCRGU23UQljXDS5Cpfk/EQ== X-Received: by 2002:a5d:69cf:: with SMTP id s15mr5214417wrw.372.1610136907434; Fri, 08 Jan 2021 12:15:07 -0800 (PST) Received: from dell.default ([91.110.221.229]) by smtp.gmail.com with ESMTPSA id l8sm15598671wrb.73.2021.01.08.12.15.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 08 Jan 2021 12:15:06 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Subject: [PATCH 02/40] drm/nouveau/dispnv50/disp: Remove unused variable 'ret' Date: Fri, 8 Jan 2021 20:14:19 +0000 Message-Id: <20210108201457.3078600-3-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210108201457.3078600-1-lee.jones@linaro.org> References: <20210108201457.3078600-1-lee.jones@linaro.org> MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: David Airlie , nouveau@lists.freedesktop.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Ben Skeggs Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/nouveau/dispnv50/disp.c:1381:6: warning: variable ‘ret’ set but not used [-Wunused-but-set-variable] Cc: Ben Skeggs Cc: David Airlie Cc: Daniel Vetter Cc: dri-devel@lists.freedesktop.org Cc: nouveau@lists.freedesktop.org Signed-off-by: Lee Jones --- drivers/gpu/drm/nouveau/dispnv50/disp.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/gpu/drm/nouveau/dispnv50/disp.c b/drivers/gpu/drm/nouveau/dispnv50/disp.c index 33fff388dd83c..b615204c2cba6 100644 --- a/drivers/gpu/drm/nouveau/dispnv50/disp.c +++ b/drivers/gpu/drm/nouveau/dispnv50/disp.c @@ -1378,10 +1378,9 @@ nv50_mstm_prepare(struct nv50_mstm *mstm) { struct nouveau_drm *drm = nouveau_drm(mstm->outp->base.base.dev); struct drm_encoder *encoder; - int ret; NV_ATOMIC(drm, "%s: mstm prepare\n", mstm->outp->base.base.name); - ret = drm_dp_update_payload_part1(&mstm->mgr); + drm_dp_update_payload_part1(&mstm->mgr); drm_for_each_encoder(encoder, mstm->outp->base.base.dev) { if (encoder->encoder_type == DRM_MODE_ENCODER_DPMST) { From patchwork Fri Jan 8 20:14:20 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 359029 Delivered-To: patch@linaro.org Received: by 2002:a02:85a7:0:0:0:0:0 with SMTP id d36csp855474jai; Fri, 8 Jan 2021 12:15:18 -0800 (PST) X-Google-Smtp-Source: ABdhPJzJZ8EbwHnn9/rAMlsMrWMP59posAsGhzgiUCSEKtmWaf17hAB1kcdDPaoNVY2xYni6Rn2a X-Received: by 2002:a17:90a:a24:: with SMTP id o33mr5449890pjo.191.1610136918471; Fri, 08 Jan 2021 12:15:18 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1610136918; cv=none; d=google.com; s=arc-20160816; b=omYy75IqY+lMpE+aQIYBk+4Yb7fOMbQmHFlvlWgmpgad6lOPRD25/J0BAkQQeJlBGs hxvaVa1Mu3P/K6WL95G9EJYFfBME/XAUx2DVuGJK8t/XlOkNLS8GmtYlzpHRxQtiIwvt 7uhubFKV45FajtUx7z68dMEYg9Qs7gTv7J9EJ8R0pEbtnxVBYR+ANDgLwZklELiMHbL/ qn4ZlugqVyTxCSJQ8j6mBrsZlMj49ZPI9zTjL6OoNjSalpgyFZXqe8IlU13HJqQHTYS/ +YO66g9SjdQXRyZoto5N8euClzGFtZRD/U4//kdcsGAQV+gZkGBUidCTJkVWRafF1DCq vV9A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:cc:list-subscribe :list-help:list-post:list-archive:list-unsubscribe:list-id :precedence:mime-version:references:in-reply-to:message-id:date :subject:to:from:dkim-signature:delivered-to; bh=Ee84oNdX6vw+pGd4iJ0f61L6Kychrq4sIW1ECuFkFv0=; b=IuRW+87LlfH26Ecwykf60t7KwNHeJjY1JnYycuI8btEVLkItKsdswwPigRY7UMy1t8 waA/9kBhbK/sKe7QLAhdzXbajXfL4e3G/ZJDkXcSjhWyByARuGxJKyKfz5QbF+veihMV X5WF5ZuNve+KRCNV7jAdmLXoxjKyYggTwLoEqpicKHBzL3ibf+c76eEKu8xHMvEfRFx3 8THE1BLk2l+1MsC6p0NZ1yITCKaro2LozBEUQvrlXZWjk0tj4HShgr440RP6rBTbrizJ 7/eJ8j6Kf5iIz7d9KE8PLCROVM+CEjRyTOq5+imGc93oqqq+pzGhmT94hsyJ2bbI/CJo x01A== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=wBSjRd6h; spf=pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 131.252.210.177 as permitted sender) smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from gabe.freedesktop.org (gabe.freedesktop.org. [131.252.210.177]) by mx.google.com with ESMTPS id s23si8899332pju.30.2021.01.08.12.15.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 08 Jan 2021 12:15:18 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 131.252.210.177 as permitted sender) client-ip=131.252.210.177; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=wBSjRd6h; spf=pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 131.252.210.177 as permitted sender) smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 295FC6E8C4; Fri, 8 Jan 2021 20:15:12 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mail-wr1-x42a.google.com (mail-wr1-x42a.google.com [IPv6:2a00:1450:4864:20::42a]) by gabe.freedesktop.org (Postfix) with ESMTPS id 2EC9C6E8C8 for ; Fri, 8 Jan 2021 20:15:10 +0000 (UTC) Received: by mail-wr1-x42a.google.com with SMTP id a12so10119847wrv.8 for ; Fri, 08 Jan 2021 12:15:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=O/JKS4Z9qKDOKy5sO9nbCc5XSxxopAD1h4qHJfgSdqg=; b=wBSjRd6hUt3BDerrolAnKVhQ503TF7vDvG8dtbt/o8U9vNcsSGQEhFuSmNBOZGNp10 PIzT2j7v23x8tNl3mkHGXOcF+GrbyDeTlpsSGDgKmSEcKYq0dab/m2KdmmOB57EVyCpI r/A8Jpxw89BpPtpwDjyN5aPAuMZ6s/KjgVgcsFPBXl9ioick3mKTDMbOEZOEwxasDz6g kl+0YEl+Xa46pYow7bex/TCbi1vZ4ecASb12ivzYiyc1CtI38PubzyDvHvhdXqR3IFIm 7hlsKs/zBlnsTrpiIEgwVdlZk1DB0zjTg9F3/sQC5vQghrwIso0dr5KcEZBs+6wROCj1 YPSQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=O/JKS4Z9qKDOKy5sO9nbCc5XSxxopAD1h4qHJfgSdqg=; b=oDsRTjSVTxwt29r7PxLIu0/j0ZG5HEtkLzn+tYMsOpaCpM/wv7Qjg+Lg1AWdW73U7w uWVjKigVCCPZeccn1CooWlrnjSq//8SpH2yTWXnzU5Lsug2PY1PiGWEdvhxhiPXVG/ra C29YBPBa/ufyyZpMZfPT+PT/MM2NIBUR0TJuElTsLPcgYyZGOlHKm00tlIqvkPIF6BNX OmF6Rg9tpCo255VjxR895etZHPYPWedslXV6dX/7jO9Xge+F0EL8OB7poVNBA5bjV4P8 WWECl3ELwNjonmBS8iXPhJOe2bD/qgI6eRIHdO07Ge/niri042bUAD2OMK0YIudXy/Sm mJ7Q== X-Gm-Message-State: AOAM5333UDJKsoU5ZyhCCTf8lBmunTiYA1NQL6tDalQjhPF1Yxb2d7bn rORQ0kLon4QlGLgXkTIpmX2EaQ== X-Received: by 2002:adf:ee10:: with SMTP id y16mr5306753wrn.296.1610136908812; Fri, 08 Jan 2021 12:15:08 -0800 (PST) Received: from dell.default ([91.110.221.229]) by smtp.gmail.com with ESMTPSA id l8sm15598671wrb.73.2021.01.08.12.15.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 08 Jan 2021 12:15:08 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Subject: [PATCH 03/40] drm/msm/dp/dp_display: Remove unused variable 'hpd' Date: Fri, 8 Jan 2021 20:14:20 +0000 Message-Id: <20210108201457.3078600-4-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210108201457.3078600-1-lee.jones@linaro.org> References: <20210108201457.3078600-1-lee.jones@linaro.org> MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: freedreno@lists.freedesktop.org, David Airlie , linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Kuogee Hsieh , Sean Paul Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/msm/dp/dp_display.c: In function ‘dp_display_usbpd_attention_cb’: drivers/gpu/drm/msm/dp/dp_display.c:496:19: warning: variable ‘hpd’ set but not used [-Wunused-but-set-variable] Cc: Rob Clark Cc: Sean Paul Cc: David Airlie Cc: Daniel Vetter Cc: Kuogee Hsieh Cc: linux-arm-msm@vger.kernel.org Cc: dri-devel@lists.freedesktop.org Cc: freedreno@lists.freedesktop.org Signed-off-by: Lee Jones --- drivers/gpu/drm/msm/dp/dp_display.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/gpu/drm/msm/dp/dp_display.c b/drivers/gpu/drm/msm/dp/dp_display.c index 6e971d552911f..637a5585c2fd8 100644 --- a/drivers/gpu/drm/msm/dp/dp_display.c +++ b/drivers/gpu/drm/msm/dp/dp_display.c @@ -493,7 +493,6 @@ static int dp_display_usbpd_attention_cb(struct device *dev) int rc = 0; u32 sink_request; struct dp_display_private *dp; - struct dp_usbpd *hpd; if (!dev) { DRM_ERROR("invalid dev\n"); @@ -507,8 +506,6 @@ static int dp_display_usbpd_attention_cb(struct device *dev) return -ENODEV; } - hpd = dp->usbpd; - /* check for any test request issued by sink */ rc = dp_link_process_request(dp->link); if (!rc) { From patchwork Fri Jan 8 20:14:21 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 359030 Delivered-To: patch@linaro.org Received: by 2002:a02:85a7:0:0:0:0:0 with SMTP id d36csp855516jai; Fri, 8 Jan 2021 12:15:20 -0800 (PST) X-Google-Smtp-Source: ABdhPJwBsNkC5i3G1WOcXYxRj2+XaJ7FXflkY/t93A3BI5iqRuUtFgg60I0Qwv65oR1mK0hQ0jeS X-Received: by 2002:a63:ef14:: with SMTP id u20mr3139886pgh.93.1610136920390; Fri, 08 Jan 2021 12:15:20 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1610136920; cv=none; d=google.com; s=arc-20160816; b=NZHHILqz0/0o6L0pegCACwMzE2/7NHU4MIwAcNAPZ9eU7A6I0VEyn9SKPRLVqEU74q XJhVYTHOBYabdgaZ3q6AXd01Fegwzy0gPJ2yKSrT26WaFo+cLnZMWaFcHWh9MNyS7STV Et1TykrAFF8jzV5ZsnfO/Lx0ykAM+0Gt/BnIKupGP6l2o4kidGAib+1Ij78UbCpy4uPZ /TMVbvUg9qGs8Hw3wadZBA+BSzizrRBAKtli133Vq/gBL3CoMxgVSawXvP0BObt69YUQ a2KdE8yhvz9VkqXUHBE3ddFLwNWJrIU5sTsHWja0/WcFA8zAwImOyLApag/5uj3e+X7K gw8A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:cc:list-subscribe :list-help:list-post:list-archive:list-unsubscribe:list-id :precedence:mime-version:references:in-reply-to:message-id:date :subject:to:from:dkim-signature:delivered-to; bh=0KkGM2mWjVPSvLlZjC49j+YE8C/5ws0+LqXVuouVC0o=; b=E3te+U4QwvuvuqvNTha/c2Bz+39stTVrlHwiBSQukm2M6dGN/7alyldGqFc6Qs0CXa BFOv87QIKUQ+lg6Q2Oq0kNTQSuZGg3+f66l3qiuLcPN/Jfn3ggyA+TIq+6wBAS8GnDrQ ZVhV0iBuSunfl3C0hTqZQCcVzxQSH5777J9sAAdB/nqgqCb5FX4n/x/woak9YjmUDN78 DH3vtnVjZqZkpSbGwiHS1lH1SkSmQ6v9pjVcZ1mx7DRa8zn0Brr3ozQgak3/LZaMaDXW xJc6v0cojjE86lh754NMru1kvgTwaS8lG+JVO4hihiz3y32gUVfhz6AQwm3aH/rvmHtJ nRTQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=C8oQ5FPc; spf=pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 131.252.210.177 as permitted sender) smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from gabe.freedesktop.org (gabe.freedesktop.org. [131.252.210.177]) by mx.google.com with ESMTPS id z7si6179777pgz.556.2021.01.08.12.15.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 08 Jan 2021 12:15:20 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 131.252.210.177 as permitted sender) client-ip=131.252.210.177; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=C8oQ5FPc; spf=pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 131.252.210.177 as permitted sender) smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 631EC6E8CD; Fri, 8 Jan 2021 20:15:13 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mail-wm1-x32d.google.com (mail-wm1-x32d.google.com [IPv6:2a00:1450:4864:20::32d]) by gabe.freedesktop.org (Postfix) with ESMTPS id 7B7F76E8C3 for ; Fri, 8 Jan 2021 20:15:11 +0000 (UTC) Received: by mail-wm1-x32d.google.com with SMTP id v14so8749926wml.1 for ; Fri, 08 Jan 2021 12:15:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=2u/LayQzAWY4TNKfG7PHD7/3//FK6Zy4l1U89GrL1AU=; b=C8oQ5FPceqRzS1vcOvfKUF5XvX1ZAR7TWwHJd/zeta8nGuC7Y8Rxdc1VrQ9hg3sTj9 Z+AJxpC37ZuIHfp6IEGutLehSN1RS71qWCfc41gtEvSu44qkydWWUx6irE68vDUaj6ZN KyBk+FsGVTte1VzCr0gEuPR3jZfzmd/zGs36S9ssPC/9rmfbEV+h70t+i20ZbGr54lwk uE29yLlehTcswauyv6jRU2EZHCGseExxnpFbO+bid4hzfxJw2Y30IwaAUdHkaryLylZV OfDWoiXw8s05ynAKqCBvqi9ekzulnXtGu2ZGD2K5Jj4VEs8GNOW/3H56k+mIelFljEN6 VScg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=2u/LayQzAWY4TNKfG7PHD7/3//FK6Zy4l1U89GrL1AU=; b=PaDGC8yssE8NU70MIKMVtN1RrFLXkC43KSLqYI7NkPdInRsfTRssEjuRqS1FP1QFIz fVpQCQGBIONJoAGveXREtPhYZ5uBvb1AuBcyDZ5FEdikw++HIEmphK4fHQowgXSD2gla D4omEMa94L0lmCN4B6BNUPQjOXjiuM00/NdDQDoBeWWkQOexdoLtcPukhxUnhB7HJdri fY9102tJQ2apln8PtjW3wh301V90bFRKk1Wky7WTH7e6uE/wnYixRxt3KD9Qq5FzerqJ sJ9D9ghWorz0ikcUAbMjKW3rwUK5i+d24lC3Tc9qwC6PpFgIcykSiCS2H2E8IG2VkuHT S7gw== X-Gm-Message-State: AOAM531qTL5wkB/kduUEszG6ShIK98w8GDZeqDFRlaSZ1mSy5kxRmJ0w PVSJE1MICpa6vpm3keDBx2K07g== X-Received: by 2002:a1c:3b46:: with SMTP id i67mr4349396wma.108.1610136910141; Fri, 08 Jan 2021 12:15:10 -0800 (PST) Received: from dell.default ([91.110.221.229]) by smtp.gmail.com with ESMTPSA id l8sm15598671wrb.73.2021.01.08.12.15.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 08 Jan 2021 12:15:09 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Subject: [PATCH 04/40] drm/amd/amdgpu/amdgpu_ih: Update 'amdgpu_ih_decode_iv_helper()'s function header Date: Fri, 8 Jan 2021 20:14:21 +0000 Message-Id: <20210108201457.3078600-5-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210108201457.3078600-1-lee.jones@linaro.org> References: <20210108201457.3078600-1-lee.jones@linaro.org> MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: David Airlie , Felix Kuehling , linux-kernel@vger.kernel.org, amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, Alex Deucher , =?utf-8?q?Christian_K=C3=B6?= =?utf-8?q?nig?= Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/amd/amdgpu/amdgpu_ih.c:220: warning: Function parameter or member 'ih' not described in 'amdgpu_ih_decode_iv_helper' drivers/gpu/drm/amd/amdgpu/amdgpu_ih.c:220: warning: Function parameter or member 'entry' not described in 'amdgpu_ih_decode_iv_helper' Cc: Alex Deucher Cc: "Christian König" Cc: David Airlie Cc: Daniel Vetter Cc: Felix Kuehling Cc: amd-gfx@lists.freedesktop.org Cc: dri-devel@lists.freedesktop.org Signed-off-by: Lee Jones --- drivers/gpu/drm/amd/amdgpu/amdgpu_ih.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_ih.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_ih.c index 725a9c73d51f0..dc852af4f3b76 100644 --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_ih.c +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_ih.c @@ -209,6 +209,8 @@ int amdgpu_ih_process(struct amdgpu_device *adev, struct amdgpu_ih_ring *ih) * amdgpu_ih_decode_iv_helper - decode an interrupt vector * * @adev: amdgpu_device pointer + * @ih: ih ring to process + * @entry: IV entry * * Decodes the interrupt vector at the current rptr * position and also advance the position for for Vega10 From patchwork Fri Jan 8 20:14:22 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 359031 Delivered-To: patch@linaro.org Received: by 2002:a02:85a7:0:0:0:0:0 with SMTP id d36csp855549jai; Fri, 8 Jan 2021 12:15:22 -0800 (PST) X-Google-Smtp-Source: ABdhPJwxqKU768WrtgLX9HSh+UbB+oYSBae2zeszqCaSxbXoqCtSiBQaz72sXWPRaYP4HUrQAJqr X-Received: by 2002:a17:902:ac98:b029:da:cd0f:b6a4 with SMTP id h24-20020a170902ac98b02900dacd0fb6a4mr5544951plr.71.1610136922491; Fri, 08 Jan 2021 12:15:22 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1610136922; cv=none; d=google.com; s=arc-20160816; b=A1D0u8fF8FSs0FsrJd3oMpbUjCzGwn9aLacMGhD2X/BZ0woWySxYvStSvtlMih0BoH X0cgWASHgOEEtIc0xTfsxUi04j8VJB+sUtocq6Ud/42suzVEBewl4Snf36wGYNRxgmFr wxmTA9bxJLQTsmuJ18PQOvlb2XyOsslQ0FO0ssDUQ9NAiwuiPzdVCpkBA1kT4Ejfy9Rf 36l29y0bW86/+EZRtsJ9J9xYSK1TbKV9BHsgCdOejrfYPPAT73CUYAEOO4jFpv+4605L YY02ZCXMpaW8O7Kwdqi6zXlmGoQzHuQdX22ij1I1yGTefJyAUTGLPlqNtmRWssdkktyd kv0g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:cc:list-subscribe :list-help:list-post:list-archive:list-unsubscribe:list-id :precedence:mime-version:references:in-reply-to:message-id:date :subject:to:from:dkim-signature:delivered-to; bh=ZIgYkTuO6ZU7hBSErUWBD0lQtW1Nv1pnOX0s3dv/ZR8=; b=fmscW2My1REvJdrhR0kEro3GDiuFAga2dyPEOWubPiFyOTUNbc+QxF8XNszDaM1VPn WAzrKKWX0yKMAPumJoezOOEEhljP3I1TUdc1INbiEwgu6Jy0LkztyZQy867YCkpiFX36 3t8V+VEKOiUH7wyL0iqM2OvaxZ65GPuRGQzJ6gWvExBqkJUBYGfqxMgs4kgR48PW/OIY vI4js0BhD+9HrQY9QEh+2IJ+eDM9MtM0EdXV3TKH86TYw5/qyKzGFsFIXp/7XsCK7IGQ ebhbVeO/UYB2bXeREI3NDmj2mc86ESmkc2CcqTjPZjc6XFuaZjF+HT8zdEgDUgGhjiiG FW9Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=nPDEIclv; spf=pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 2610:10:20:722:a800:ff:fe36:1795 as permitted sender) smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from gabe.freedesktop.org (gabe.freedesktop.org. [2610:10:20:722:a800:ff:fe36:1795]) by mx.google.com with ESMTPS id y8si10229055pfe.319.2021.01.08.12.15.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 08 Jan 2021 12:15:22 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 2610:10:20:722:a800:ff:fe36:1795 as permitted sender) client-ip=2610:10:20:722:a800:ff:fe36:1795; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=nPDEIclv; spf=pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 2610:10:20:722:a800:ff:fe36:1795 as permitted sender) smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id C2C916E8CB; Fri, 8 Jan 2021 20:15:14 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mail-wm1-x336.google.com (mail-wm1-x336.google.com [IPv6:2a00:1450:4864:20::336]) by gabe.freedesktop.org (Postfix) with ESMTPS id BC0986E8C7 for ; Fri, 8 Jan 2021 20:15:12 +0000 (UTC) Received: by mail-wm1-x336.google.com with SMTP id e25so9468842wme.0 for ; Fri, 08 Jan 2021 12:15:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=/ToVqtfELMjein9lDL+03lGe+1Pl1kI6Nuvl2V02OQw=; b=nPDEIclvcchArGWcIIvap7p0tV/Rf2lx9TgJnp2hWX/nn04pew9eH1DzQvuV0oY5dO uYlPu7t+/BwZmmgpIRvGBX6xDjVNdvmLl+T2XbI2y544GNEB6poJK2wXefPMvuaFj0LP 1bCfmVawsAnd5iffgC8cCaUk23jdkFMPX+hldzpdztsaQnGn2D8TM1pnYc4PdJ6sTXk3 P1sqHnU5kzx2HnlGpQuZsYJ+pxTCkn5kn6mPH3fPIPc1QO5y/Xrw6NNIr/Q1c7Xnw8aQ r9Pdv/WXBOoNMt3BNY+r7SM95gZeSzHHPx7Kev1iki8AutO6xe2Cz9US+Kdjr5TXZeoz MdEQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=/ToVqtfELMjein9lDL+03lGe+1Pl1kI6Nuvl2V02OQw=; b=QjojQ/h0yAmvxdzjAcbWqpTwoNpyo4OanaskwBVezYudyxXBvC99DVBC6Xq3lOcfKN 0vwNajiIahj4MIVds9c3ohN0NHPn0G7Iy5o+sxtkfxp040eXc0VV0XjO3f4YV5nih+SF xRTxhoG/HQQrm/VNDJmhh4z8JJ6+UFE2pbfUVBEvV3jBEgLkjxxrpXnW7IqQDxzi53SA Q/jxhdd6Pd9vN23O/5sxjmtH67relu/k3Wjexo8wzR2IpNyFtc734OSGSkz6zVnyjH6D D0xF7Ds08OebY/gQpWAGTSn9lqoCOTLEWRn7/yQvH9nDEOA4lnVaopOnn+y1L9+IzYU2 4gQA== X-Gm-Message-State: AOAM531PUuTevKunSSv5KNnMM/ZVo+ikASLUa/8YuB9t7xoGv/xapKQq TQcYFoLqsbM08e/R/95Ex9gePw== X-Received: by 2002:a1c:1d08:: with SMTP id d8mr4586040wmd.159.1610136911373; Fri, 08 Jan 2021 12:15:11 -0800 (PST) Received: from dell.default ([91.110.221.229]) by smtp.gmail.com with ESMTPSA id l8sm15598671wrb.73.2021.01.08.12.15.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 08 Jan 2021 12:15:10 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Subject: [PATCH 05/40] drm/amd/amdgpu/vega20_ih: Add missing descriptions for 'ih' and fix spelling error Date: Fri, 8 Jan 2021 20:14:22 +0000 Message-Id: <20210108201457.3078600-6-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210108201457.3078600-1-lee.jones@linaro.org> References: <20210108201457.3078600-1-lee.jones@linaro.org> MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: David Airlie , Feifei Xu , linux-kernel@vger.kernel.org, amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, Alex Deucher , =?utf-8?q?Christian_K=C3=B6?= =?utf-8?q?nig?= , Hawking Zhang Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/amd/amdgpu/vega20_ih.c:378: warning: Function parameter or member 'ih' not described in 'vega20_ih_get_wptr' drivers/gpu/drm/amd/amdgpu/vega20_ih.c:421: warning: Function parameter or member 'ih' not described in 'vega20_ih_irq_rearm' drivers/gpu/drm/amd/amdgpu/vega20_ih.c:447: warning: Function parameter or member 'ih' not described in 'vega20_ih_set_rptr' Cc: Alex Deucher Cc: "Christian König" Cc: David Airlie Cc: Daniel Vetter Cc: Hawking Zhang Cc: Feifei Xu Cc: amd-gfx@lists.freedesktop.org Cc: dri-devel@lists.freedesktop.org Signed-off-by: Lee Jones --- drivers/gpu/drm/amd/amdgpu/vega20_ih.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/amdgpu/vega20_ih.c b/drivers/gpu/drm/amd/amdgpu/vega20_ih.c index 42032ca380ccf..5a3c867d58811 100644 --- a/drivers/gpu/drm/amd/amdgpu/vega20_ih.c +++ b/drivers/gpu/drm/amd/amdgpu/vega20_ih.c @@ -88,7 +88,7 @@ static void vega20_ih_init_register_offset(struct amdgpu_device *adev) * vega20_ih_toggle_ring_interrupts - toggle the interrupt ring buffer * * @adev: amdgpu_device pointer - * @ih: amdgpu_ih_ring pointet + * @ih: amdgpu_ih_ring pointer * @enable: true - enable the interrupts, false - disable the interrupts * * Toggle the interrupt ring buffer (VEGA20) @@ -367,6 +367,7 @@ static void vega20_ih_irq_disable(struct amdgpu_device *adev) * vega20_ih_get_wptr - get the IH ring buffer wptr * * @adev: amdgpu_device pointer + * @ih: amdgpu_ih_ring pointer * * Get the IH ring buffer wptr from either the register * or the writeback memory buffer (VEGA20). Also check for @@ -414,6 +415,7 @@ static u32 vega20_ih_get_wptr(struct amdgpu_device *adev, * vega20_ih_irq_rearm - rearm IRQ if lost * * @adev: amdgpu_device pointer + * @ih: amdgpu_ih_ring pointer * */ static void vega20_ih_irq_rearm(struct amdgpu_device *adev, @@ -439,6 +441,7 @@ static void vega20_ih_irq_rearm(struct amdgpu_device *adev, * vega20_ih_set_rptr - set the IH ring buffer rptr * * @adev: amdgpu_device pointer + * @ih: amdgpu_ih_ring pointer * * Set the IH ring buffer rptr. */ From patchwork Fri Jan 8 20:14:23 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 359032 Delivered-To: patch@linaro.org Received: by 2002:a02:85a7:0:0:0:0:0 with SMTP id d36csp855563jai; Fri, 8 Jan 2021 12:15:24 -0800 (PST) X-Google-Smtp-Source: ABdhPJwHPQpCgjsxAYb6IpWOBL5jSOdQ7dGMjyUHoIhbK1mt7ekEFOLWjViveG3dsByHN365CqS5 X-Received: by 2002:a63:3111:: with SMTP id x17mr8612046pgx.329.1610136923954; Fri, 08 Jan 2021 12:15:23 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1610136923; cv=none; d=google.com; s=arc-20160816; b=YgUgF6Oa4vtecMrZbz+hFVRjEPR2K8uQwt2qvmhz56lvrRWNVSLregPO1G/UwhdzEp nlgZfSFZmMUCb2WYKKtUeCZCT8yAEttCYkrdLgLLlxG5Wn+iyV3GUZ1SzLcM0IU9HtZQ JRzA+HrIm2zmbbk0k6qqS+KTx1V6YvFVih2x2L9QQGU5Q3zOQKxduRRNXUOBf9Z1QD5q dLagv7Kxix87YkVy1K+4EVsABD1EWCOZGuafwFw902dNCNOjdraM57d5kK5/qsIVS4uq GD1bKSyG8L1vzGkWHrkbaiRnoPmJf4fw4abLaEnf0aCTw5P09OGrvJig+Cp0Fh3qfGow FRVA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:cc:list-subscribe :list-help:list-post:list-archive:list-unsubscribe:list-id :precedence:mime-version:references:in-reply-to:message-id:date :subject:to:from:dkim-signature:delivered-to; bh=m4afjirXl/toCtmgY6jLsBDQYV/2lEEH5cOFu9Xbop8=; b=rrMVPwwuTSRBqBkcLelcy6y8k9TbQDJcLdpH+8eagmXhXhhlVwRjUCfqXlqetbTjSN my8VDaDGQsxCnddNSUmBwQFxK25Vk9hDktsk+Zyh8bLaBtKjWJvRvaLBqGS+CMHk9yo8 3Tnj8SfzZFsiFzF7fkG1xjgZJGMMtpnkD7HPJRpMxMIpdgkCRpQtQ1XePGP+IrW9dtIW u5EqkkQgRvLsQYuPgTVr0VghQVMrDVOq/wdQUJXYHpBqcKchQn3Xw02xoazQDM6Aepj7 NxUP+LhV+2P+WD7acnzRTnAiUrJHMYN1K5HXfS5ygx5542yQHzDMINBbdemu//QVq2iC Pmug== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=RobXHiCa; spf=pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 2610:10:20:722:a800:ff:fe36:1795 as permitted sender) smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from gabe.freedesktop.org (gabe.freedesktop.org. [2610:10:20:722:a800:ff:fe36:1795]) by mx.google.com with ESMTPS id h8si9649909pgs.293.2021.01.08.12.15.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 08 Jan 2021 12:15:23 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 2610:10:20:722:a800:ff:fe36:1795 as permitted sender) client-ip=2610:10:20:722:a800:ff:fe36:1795; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=RobXHiCa; spf=pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 2610:10:20:722:a800:ff:fe36:1795 as permitted sender) smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 68B3A6E8C3; Fri, 8 Jan 2021 20:15:16 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mail-wm1-x32a.google.com (mail-wm1-x32a.google.com [IPv6:2a00:1450:4864:20::32a]) by gabe.freedesktop.org (Postfix) with ESMTPS id D66986E8CF for ; Fri, 8 Jan 2021 20:15:13 +0000 (UTC) Received: by mail-wm1-x32a.google.com with SMTP id n16so7358010wmc.0 for ; Fri, 08 Jan 2021 12:15:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=Q1ACHhoDM3J5dELVH57xIAQUcf34vzdyN5ALWF0ycEQ=; b=RobXHiCalmxUMxBiwWjqlom0EWAsiBTcsj1Ei8+x90LUZCySBXgpU8xTX9j2i46Rr3 KSEcIB2YfsMjrstXrKYwkRG9S1If6LX4l2XOFGd7hNeAZrjH6sXILEd0IAS6XiFAQOgP oPfRfGEI174ndsVXFXEAz/OemllVs6/5jWzo3rBlLT0dR2vnoBtSk5InuOzokUvtH8RJ MbVPJkJv5LWD4s19zLMoylEtumeVPqUuJaIuxcUHvNwlTm6fgh+SlhRWIRYdDDGerMJF vmL8H/PY2X2kTd3fyJBMupz9k0C8eoN5qBx+vAeLkglLl/mqFwST4u7pA+1GkBiup3HT zhMg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=Q1ACHhoDM3J5dELVH57xIAQUcf34vzdyN5ALWF0ycEQ=; b=FvcRNxmsAm8yA+Ty8REEC6O/h8c4jVLJwDw7SjvBAhbYm6oXZ0L7xj+yeMa2nClOua s/xGIFL8P3mmW/6QcdVtK3Oq8wnWQ71x0cWpB2RcN6iInZiHDIpb3cHqZJQGW6Q/QiLH ByN6gK2wjtH+4626cE4WkLkr5K0L9PjhoJjEczCT2ZhUcrSx0TlZKHd/+bULTHUtyO3S kXcDg5i86bnLPJINksE8qhM1LrevBfBBTaAarOhS3zoV7wUhCIa+EL3zbUcH55Iq7wtP Asolivscg/1nMXREkfO8SeRQhPgYkV9Ps3m6HQQsMfcXCOKU7jewhA4KE3y/xzDg73KI MrqA== X-Gm-Message-State: AOAM530DZ11XQDB7C4xoaulKONd3Ex9l+EVsL0MyErHkUisJbEF/cRpE sGyMsGc6zj8s9gn2AOIdCHhvag== X-Received: by 2002:a1c:f604:: with SMTP id w4mr4578911wmc.39.1610136912570; Fri, 08 Jan 2021 12:15:12 -0800 (PST) Received: from dell.default ([91.110.221.229]) by smtp.gmail.com with ESMTPSA id l8sm15598671wrb.73.2021.01.08.12.15.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 08 Jan 2021 12:15:11 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Subject: [PATCH 06/40] drm/amd/pm/powerplay/hwmgr/process_pptables_v1_0: Provide description of 'call_back_func' Date: Fri, 8 Jan 2021 20:14:23 +0000 Message-Id: <20210108201457.3078600-7-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210108201457.3078600-1-lee.jones@linaro.org> References: <20210108201457.3078600-1-lee.jones@linaro.org> MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: David Airlie , linux-kernel@vger.kernel.org, amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, Alex Deucher , Evan Quan , =?utf-8?q?Christian_K=C3=B6nig?= Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/amd/amdgpu/../pm/powerplay/hwmgr/process_pptables_v1_0.c:1371: warning: Function parameter or member 'call_back_func' not described in 'get_powerplay_table_entry_v1_0' Cc: Evan Quan Cc: Alex Deucher Cc: "Christian König" Cc: David Airlie Cc: Daniel Vetter Cc: amd-gfx@lists.freedesktop.org Cc: dri-devel@lists.freedesktop.org Signed-off-by: Lee Jones --- drivers/gpu/drm/amd/pm/powerplay/hwmgr/process_pptables_v1_0.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/amd/pm/powerplay/hwmgr/process_pptables_v1_0.c b/drivers/gpu/drm/amd/pm/powerplay/hwmgr/process_pptables_v1_0.c index 741e03ad5311f..f2a55c1413f59 100644 --- a/drivers/gpu/drm/amd/pm/powerplay/hwmgr/process_pptables_v1_0.c +++ b/drivers/gpu/drm/amd/pm/powerplay/hwmgr/process_pptables_v1_0.c @@ -1362,6 +1362,7 @@ static int ppt_get_vce_state_table_entry_v1_0(struct pp_hwmgr *hwmgr, uint32_t i * @hwmgr: Pointer to the hardware manager. * @entry_index: The index of the entry to be extracted from the table. * @power_state: The address of the PowerState instance being created. + * @call_back_func: The function to call into to fill power state * Return: -1 if the entry cannot be retrieved. */ int get_powerplay_table_entry_v1_0(struct pp_hwmgr *hwmgr, From patchwork Fri Jan 8 20:14:24 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 359033 Delivered-To: patch@linaro.org Received: by 2002:a02:85a7:0:0:0:0:0 with SMTP id d36csp855574jai; Fri, 8 Jan 2021 12:15:25 -0800 (PST) X-Google-Smtp-Source: ABdhPJyBaw/bU+89gqU2rmZk7MSKfhS+8h/JaUdB24oCZXt7cOOAG5hrCLfrascYvrYgFLZEOg/g X-Received: by 2002:a65:4906:: with SMTP id p6mr8575010pgs.173.1610136925316; Fri, 08 Jan 2021 12:15:25 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1610136925; cv=none; d=google.com; s=arc-20160816; b=lSX0KjVfi2juIMdofZNnTLwcZP++JcoJa81YdHa6FzSYtoZ0UMBUIMhBgaopgLYcOp qdb8bh0K9jmfApZCgfa4Xs4EykOixrLoskwE5IK2QM+QxjK9U0Oy8wQyxcP8c+HQIdih Ve/50PAr1UKr2uodcyPY0BKI345pVpDWzXmS9X5W8iFDOJhZwYPzj8nQc116m3lBlEK7 mboSZeRYY8JnjRcI1k5nqHV0X4h1q7pWVwlXji98ENZnOVvpkcRKnJs5eldS0l6d+cge cDcFCnhfyHfHvcwgkyjxzb/Ex/ZAnCwdRhTVOvP6RBRzR27P+qkJNzXQpVA9i10/xzYj Rh5w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:cc:list-subscribe :list-help:list-post:list-archive:list-unsubscribe:list-id :precedence:mime-version:references:in-reply-to:message-id:date :subject:to:from:dkim-signature:delivered-to; bh=7EpqDYI0QhhnU/zInARAhKsftVxeeN46/lDEmZmrSUw=; b=sZr0eqJmPShS1YNYWdgVd14Yef+VSwNmmQ1OnQ3yCK9SRbX7MP/mIo8JcqHrCuc78R D2WSCw6qBgkk1oYFSCpBahYpizmPPVQor2pWzK610vFQ3j7IupNwnS+p+DtPCMACEeqo qCYWy0PawFayhq7EUgi22+vfWLBSGLVynXt2DLWCyDdfjBmCzI71H156uRXifB9Mfefx QZ/yEX2bvA3b+56YwWApiU9lwArG8gmOSdNGMvxaSuOGW0UG/aKTbdtGUVVdVmFZqwuR 1I5B4LbUqvgyhEeLRWkl6HeoKeZzD0bhpIU7lMEqziuhnwYoXEUNpbjBqh0KcFXngLmw hQbg== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=j5gRi8kb; spf=pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 131.252.210.177 as permitted sender) smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from gabe.freedesktop.org (gabe.freedesktop.org. [131.252.210.177]) by mx.google.com with ESMTPS id j9si10209405pgb.430.2021.01.08.12.15.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 08 Jan 2021 12:15:25 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 131.252.210.177 as permitted sender) client-ip=131.252.210.177; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=j5gRi8kb; spf=pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 131.252.210.177 as permitted sender) smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 2BCAE6E8CA; Fri, 8 Jan 2021 20:15:17 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mail-wm1-x335.google.com (mail-wm1-x335.google.com [IPv6:2a00:1450:4864:20::335]) by gabe.freedesktop.org (Postfix) with ESMTPS id 11CEC6E8CF for ; Fri, 8 Jan 2021 20:15:15 +0000 (UTC) Received: by mail-wm1-x335.google.com with SMTP id k10so8748814wmi.3 for ; Fri, 08 Jan 2021 12:15:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=Ynto/MZpBe5G42s9vReiED0PRGKZttvk/p9R7rGmhMU=; b=j5gRi8kb1z9r9v0Wmdcr1/+GgOq0BvFyxJd3BMOSmd4YTFM9odpHw4ntJ7o8srreTK S+xjPLLW6HLRvT3SnpwpcsrZ6FjgNgB9VKnHAMH+LkkNEPfWTGHknUnph7WJ+0t402qx lZVdInz3sXRPqLHWXmm6oPdMFtEm0C41JiZYtbEdkuSbsa44LvSHR2DR/G5EEKK+Z8nN fPmxUsaC/tqeOXjSV9F3HDn81aNwuhIdvjg2dDQM3HQHU+YpmYvr5SbxP0Gjpb5wxsl5 orEaLRKjsqCfTCOsLh2r/OzNDWUTWM6P63onC+JtQKk2z0ulnnB6/Owyd1hvoNIy6478 rJNw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=Ynto/MZpBe5G42s9vReiED0PRGKZttvk/p9R7rGmhMU=; b=QokktH5vRQBMHnytOCwWC0DckYJk3tjoACEQKXN+Se8g389u97Sn2/lKKyq0iHMWhC lhD4VewieC4uefwq4WKOrDzUtQE32HoWA0hSAwDxlA/u/ZG32hxw8jgaINDymYXmy0Xp pWDP930W/H+Zg/uKD7GthclCzG704A5r+gBYEBaSZFYfhK3fLb3CUg5Qnn9Kyx4Is6JE Hbo6f4KKl/bH+IXbRRZLE+xuRpCtzB2vrQcBvxK4vviVv0q+aU43W5XdLoBhf0tE20oa YEDBSc1VzIYBdaFaHNGU5aKLriil+x2O/muAoaKSoWgS16ertv/t7oPbjC7u6ddPohwI sryQ== X-Gm-Message-State: AOAM533upYm5zRdsCTi39ZL9pnJfUR9xxNy5EmhUNRz25nSmYnY52jM5 eMND/16fRG9B2RDAmBzIv2rSLA== X-Received: by 2002:a1c:2b46:: with SMTP id r67mr4489592wmr.162.1610136913799; Fri, 08 Jan 2021 12:15:13 -0800 (PST) Received: from dell.default ([91.110.221.229]) by smtp.gmail.com with ESMTPSA id l8sm15598671wrb.73.2021.01.08.12.15.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 08 Jan 2021 12:15:13 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Subject: [PATCH 07/40] drm/amd/pm/powerplay/hwmgr/ppatomctrl: Fix documentation for 'mpll_param' Date: Fri, 8 Jan 2021 20:14:24 +0000 Message-Id: <20210108201457.3078600-8-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210108201457.3078600-1-lee.jones@linaro.org> References: <20210108201457.3078600-1-lee.jones@linaro.org> MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: David Airlie , linux-kernel@vger.kernel.org, amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, Alex Deucher , Evan Quan , =?utf-8?q?Christian_K=C3=B6nig?= Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/amd/amdgpu/../pm/powerplay/hwmgr/ppatomctrl.c:290: warning: Function parameter or member 'mpll_param' not described in 'atomctrl_get_memory_pll_dividers_si' drivers/gpu/drm/amd/amdgpu/../pm/powerplay/hwmgr/ppatomctrl.c:290: warning: Excess function parameter 'dividers' description in 'atomctrl_get_memory_pll_dividers_si' drivers/gpu/drm/amd/amdgpu/../pm/powerplay/hwmgr/ppatomctrl.c:339: warning: Function parameter or member 'mpll_param' not described in 'atomctrl_get_memory_pll_dividers_vi' drivers/gpu/drm/amd/amdgpu/../pm/powerplay/hwmgr/ppatomctrl.c:339: warning: Excess function parameter 'dividers' description in 'atomctrl_get_memory_pll_dividers_vi' Cc: Evan Quan Cc: Alex Deucher Cc: "Christian König" Cc: David Airlie Cc: Daniel Vetter Cc: amd-gfx@lists.freedesktop.org Cc: dri-devel@lists.freedesktop.org Signed-off-by: Lee Jones --- drivers/gpu/drm/amd/pm/powerplay/hwmgr/ppatomctrl.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/amd/pm/powerplay/hwmgr/ppatomctrl.c b/drivers/gpu/drm/amd/pm/powerplay/hwmgr/ppatomctrl.c index 83a6504e093cb..b1038d30c8dcc 100644 --- a/drivers/gpu/drm/amd/pm/powerplay/hwmgr/ppatomctrl.c +++ b/drivers/gpu/drm/amd/pm/powerplay/hwmgr/ppatomctrl.c @@ -279,7 +279,7 @@ static const ATOM_VOLTAGE_OBJECT_V3 *atomctrl_lookup_voltage_type_v3( * * @hwmgr: input parameter: pointer to HwMgr * @clock_value: input parameter: memory clock - * @dividers: output parameter: memory PLL dividers + * @mpll_param: output parameter: memory clock parameters * @strobe_mode: input parameter: 1 for strobe mode, 0 for performance mode */ int atomctrl_get_memory_pll_dividers_si( @@ -332,7 +332,7 @@ int atomctrl_get_memory_pll_dividers_si( * * @hwmgr: input parameter: pointer to HwMgr * @clock_value: input parameter: memory clock - * @dividers: output parameter: memory PLL dividers + * @mpll_param: output parameter: memory clock parameters */ int atomctrl_get_memory_pll_dividers_vi(struct pp_hwmgr *hwmgr, uint32_t clock_value, pp_atomctrl_memory_clock_param *mpll_param) From patchwork Fri Jan 8 20:14:25 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 359034 Delivered-To: patch@linaro.org Received: by 2002:a02:85a7:0:0:0:0:0 with SMTP id d36csp855601jai; Fri, 8 Jan 2021 12:15:26 -0800 (PST) X-Google-Smtp-Source: ABdhPJwRw3PRh7vI55mUG/GVcl88kuPyrn3EpT/4AjRRNBOPWEX7rFQwm7CA8t6dBKY5WHMRQikZ X-Received: by 2002:a17:902:c583:b029:da:b32c:cf9f with SMTP id p3-20020a170902c583b02900dab32ccf9fmr5440430plx.44.1610136926747; Fri, 08 Jan 2021 12:15:26 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1610136926; cv=none; d=google.com; s=arc-20160816; b=0jyXLxwmDl4HAnBxjviIvXzMfvrVttkfjHz0k/m+xzU78Oh0L09QFxKXYIYEN9p2Qo e2q8M359RXkNJxCyQTRMRiq5NDaMteaMK8SeWDdLh9aKQ9fgo3C7uvhIks54oLuUtbEn fWq55A0eM83nuXQiArJ3cgJErQqNBfmh3xecfwLoDEzWQxDMSDOMFw4deMMX/gTKLMtf dd4Ozcxdg8/xpKF5nABOSGE+zMby4VKTU5MBhJg0eZ4GTL7K5etFXzYA2IqQ3cu764Uk Br3bPikRxo79/aQjQjlKT2t5RlI22OdslF+ROcr766R/ou2wis6DZVyIL0i8HqdChMhj 0gmg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:cc:list-subscribe :list-help:list-post:list-archive:list-unsubscribe:list-id :precedence:mime-version:references:in-reply-to:message-id:date :subject:to:from:dkim-signature:delivered-to; bh=ZvG/cTdbz+M+5FpQujVz4YJm4wa5eMbfvWwSM8ugm+4=; b=DTSLaEHh0c0vXJKykr8YmaP1OINO54xyCOdedDLhUbe6hV2imNQEwx95ohVPu+oaRF w6rkGkDHXgW+fQxQvKZsdTT8HJBqlcpC1oC5v1D9qDFHHwEfcu6eDuu04l6xUXY8uUx1 zvorfbbwdRGxk3AStkuk9KMN4W+eSP5762AWPebO1b+jxyYZJYFyPgLLgP6WfVzU/fJK OFalkFd2iPSLzC+Zi+lBNi4srRIlNXm5btO1UufThGRq76SP1JTvoVtXnYuD85VpZxnY QHv6+ujzguZDrAVSoZyu39w8liK1NX1Y2JUASRoTcTNuolc0fhHuy7GW2roGt96rpnYY 8qAQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=F0x9Z4fM; spf=pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 2610:10:20:722:a800:ff:fe36:1795 as permitted sender) smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from gabe.freedesktop.org (gabe.freedesktop.org. [2610:10:20:722:a800:ff:fe36:1795]) by mx.google.com with ESMTPS id w19si10462405plq.151.2021.01.08.12.15.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 08 Jan 2021 12:15:26 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 2610:10:20:722:a800:ff:fe36:1795 as permitted sender) client-ip=2610:10:20:722:a800:ff:fe36:1795; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=F0x9Z4fM; spf=pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 2610:10:20:722:a800:ff:fe36:1795 as permitted sender) smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 657646E8CF; Fri, 8 Jan 2021 20:15:18 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mail-wm1-x336.google.com (mail-wm1-x336.google.com [IPv6:2a00:1450:4864:20::336]) by gabe.freedesktop.org (Postfix) with ESMTPS id 6EEB86E8C7 for ; Fri, 8 Jan 2021 20:15:16 +0000 (UTC) Received: by mail-wm1-x336.google.com with SMTP id v14so8750097wml.1 for ; Fri, 08 Jan 2021 12:15:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=In1Q+qm5MHof1cMenavqGuBcxDO1piRqNKsllQjE02s=; b=F0x9Z4fMGLhfw4n1u93Uhq62eitL0BqRg63/OQZI2nqJtMtnb9XFw10b/oNSbZ/Cc0 q31JJtFD6ZTSRwnAx4cJeg4an6vd/rYODFPbszdZtF93dGSF1MRSxMcgIEJOX6vMwZX+ EqyACqU4CLHmNULkAudqGDWMnThQDuoKmVRbS7LWZW+kxv8MP4xtylC6wA+JIKcVlkdy 7PKpzIU37QV483rrhKqjjM1TFYouFh0iiXuRKQm4l+0NVaAIecM2G1PIps8vSmApgcFQ 0NeVx4QXyNmRNjJZyPvJjFrytki1lBlcvL3D6nGE1jt8TKEJRI4f6Ab0SIhiTiu8K+gJ iwyw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=In1Q+qm5MHof1cMenavqGuBcxDO1piRqNKsllQjE02s=; b=cxF0+HBXSPhMClN1iOzcwmhKLvi973f+rmtSrt2QVqsn+tJ/Ti/FMABqYGQQJrai95 lZ17mkFVABFyUovL1zDz+79cI0ICLwBqHoOoLResJdrR/p/huUzr012udut8HHaq2Dl2 3o5CPaNawBVBf/eqIkMMXtq8via/YRxoAZOiNDV+na+ozY9/VMzIeOIxyBGE4ZsD8bPh piaW0oUy/k+nxw481E/vBT4oBl2Kvx9CZiVAnmLuk4YrxzbcPL03EiPoKSD+U1yZrVwq ftTw6UGmzZmpZEBJ8okgxUkcFiJcgBknc8kWPIdZONHEDdwkFkDZjjnlnN5t1bGv9clE ZXbQ== X-Gm-Message-State: AOAM532sDLYR6/kIWoKHer3SzwkHDuzXcCLtmedeunDt/H1USz6MrfX1 Bpio3dPPbjOzv6nJm6ZZOoUsmA== X-Received: by 2002:a7b:c306:: with SMTP id k6mr4479570wmj.52.1610136915105; Fri, 08 Jan 2021 12:15:15 -0800 (PST) Received: from dell.default ([91.110.221.229]) by smtp.gmail.com with ESMTPSA id l8sm15598671wrb.73.2021.01.08.12.15.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 08 Jan 2021 12:15:14 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Subject: [PATCH 08/40] drm/amd/pm/powerplay/hwmgr/vega12_hwmgr: Fix legacy function header formatting Date: Fri, 8 Jan 2021 20:14:25 +0000 Message-Id: <20210108201457.3078600-9-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210108201457.3078600-1-lee.jones@linaro.org> References: <20210108201457.3078600-1-lee.jones@linaro.org> MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: David Airlie , linux-kernel@vger.kernel.org, amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, Alex Deucher , Evan Quan , =?utf-8?q?Christian_K=C3=B6nig?= Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/amd/amdgpu/../pm/powerplay/hwmgr/vega12_hwmgr.c:728: warning: Function parameter or member 'hwmgr' not described in 'vega12_init_smc_table' Cc: Evan Quan Cc: Alex Deucher Cc: "Christian König" Cc: David Airlie Cc: Daniel Vetter Cc: amd-gfx@lists.freedesktop.org Cc: dri-devel@lists.freedesktop.org Signed-off-by: Lee Jones --- drivers/gpu/drm/amd/pm/powerplay/hwmgr/vega12_hwmgr.c | 11 +++++------ 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/drivers/gpu/drm/amd/pm/powerplay/hwmgr/vega12_hwmgr.c b/drivers/gpu/drm/amd/pm/powerplay/hwmgr/vega12_hwmgr.c index dc206fa88c5e5..c0753029a8e2a 100644 --- a/drivers/gpu/drm/amd/pm/powerplay/hwmgr/vega12_hwmgr.c +++ b/drivers/gpu/drm/amd/pm/powerplay/hwmgr/vega12_hwmgr.c @@ -718,12 +718,11 @@ static int vega12_save_default_power_profile(struct pp_hwmgr *hwmgr) #endif /** -* Initializes the SMC table and uploads it -* -* @param hwmgr the address of the powerplay hardware manager. -* @param pInput the pointer to input data (PowerState) -* @return always 0 -*/ + * Initializes the SMC table and uploads it + * + * @hwmgr: the address of the powerplay hardware manager. + * return: always 0 + */ static int vega12_init_smc_table(struct pp_hwmgr *hwmgr) { int result; From patchwork Fri Jan 8 20:14:26 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 359035 Delivered-To: patch@linaro.org Received: by 2002:a02:85a7:0:0:0:0:0 with SMTP id d36csp855618jai; Fri, 8 Jan 2021 12:15:28 -0800 (PST) X-Google-Smtp-Source: ABdhPJzdEd+RNTA1/Jm7skIao9mqoLNgofWKrssozG4wHELl0E1lkqBQOOlHm4JcNVVCgwhroKIS X-Received: by 2002:a63:4563:: with SMTP id u35mr8520217pgk.162.1610136928101; Fri, 08 Jan 2021 12:15:28 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1610136928; cv=none; d=google.com; s=arc-20160816; b=JUoDMNhIA4AZbI/ogRsDS3RI3s7+gGTyx3SVn1FEkskDmYxr0+it86XY90UnptaDeY rOJeFtOa9FcRjbjTi8beNtKFBdVTc4YHywNrKT427UY6h3+uaD4QoNJK832j9eWHUMwS C+EAh6JNPvVFwtDSSdETXn99OXW6I/Y0Bxzdngff6gLSxuPjB4kAf+syjeEEzZKdqcsf +P9ZXMkwiPXWVZAtgyHGasf/78Z/HrOb8n4xco3uyUznu4bilFWAQ0XFOEw9QlMcVqPD OCcmL/DgjA2hRZMAHmM3c62DPnYs6VbjnJO0zc78yCB8XST2D97Rz/ilVhkW0+2D31fw NLIg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:cc:list-subscribe :list-help:list-post:list-archive:list-unsubscribe:list-id :precedence:mime-version:references:in-reply-to:message-id:date :subject:to:from:dkim-signature:delivered-to; bh=wXnF2lizNfKeS6MDP77rDJNiMiob1mLycA5zWr4L00Q=; b=zLH0KmtsCNkY6ICUzxX++MJ/8KCQOX/opTyqcsqEqlPT9I/eK8J6J7eFtKBjTJnJ0U eT3UFWGhrGfCv90jX2jGChT5qDviznJOvA/SrYuPl4zlY6Yuzw/GP101U7j0jrJIyCIA yqxZ977xtsW4slLaEgDWNf94Ns38qRtoYRfb3d6SuqIE/Hl6LzbuhfE0h33FXDwewl0y OpAqRDUhtWQGQkJSUeGItYjXXrF5Uoa5CeayLn6Vo+XDY8gNu4ZUGaWle2VKQi09L6EL kepXjp0pJgNlaHH1EUx0Tp6DlAVcF8ljt2ruBS2P8yzXLlI0dbOuiSffzwuTQlQRtIk0 vojA== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=xLshuzqR; spf=pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 131.252.210.177 as permitted sender) smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from gabe.freedesktop.org (gabe.freedesktop.org. [131.252.210.177]) by mx.google.com with ESMTPS id r8si10077370pgb.325.2021.01.08.12.15.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 08 Jan 2021 12:15:28 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 131.252.210.177 as permitted sender) client-ip=131.252.210.177; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=xLshuzqR; spf=pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 131.252.210.177 as permitted sender) smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 860D36E8C7; Fri, 8 Jan 2021 20:15:19 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mail-wm1-x32c.google.com (mail-wm1-x32c.google.com [IPv6:2a00:1450:4864:20::32c]) by gabe.freedesktop.org (Postfix) with ESMTPS id B74BA6E8D2 for ; Fri, 8 Jan 2021 20:15:17 +0000 (UTC) Received: by mail-wm1-x32c.google.com with SMTP id k10so8748891wmi.3 for ; Fri, 08 Jan 2021 12:15:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=4m+UfJ8aX5WLjKwBG1Xu8sQ5BNsQhd/cnOc6646uVLM=; b=xLshuzqR1S5leuYqYt+i5O0pzH6SK7237sKx76ydZAZ12/sCmWGMaKpZAn5ORm5VxA b7AM62dLqUYFa3QkxepEi2Glma4JBkROyGwMzVvdYsXkkMaw3Sgda6nSa6R/FaF31Dpm ZiX7Q7jWTDA32xLpGC0RqCfHNihxlDNszP5NaU/LTHZ0sULnT8MXDlKC4miJYJIs4C3X 7UFv+/hFIZWuQxni+OkJp+bCWx2MOgrkuvoeByqrNPXePBhFcRcz6Mix2yTuGTBFwC9f jIbx6kAGiVERht+t17b65sHTRyNoCN2dT3DF3NTdbtSk17MqvxIcY2afNbxf8gFeFwwY YJ1Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=4m+UfJ8aX5WLjKwBG1Xu8sQ5BNsQhd/cnOc6646uVLM=; b=h/FLjY3VPFWk2lRFeYHx3RAILpeOQsEqOykyM3gy1tMJ/R1j+sCFL6+/EuGBhzAxf0 fL795EruwLW4nxnD1EGwkA468hWE2UOhiCFdOE85r/i97w6pAI9eeIjZxYDqWa4xMPIw P7p9/Bf3TESK/lERMADpPQxg6myyiJc+HUPK0iO+GehRiEnkc66YemBW1ntGMC6o8xqi h+mBVo6lGJ6CtUaz2a17RlEfcUIS2X+1W0r/8a1miGfOJtb+VwrRBoRqYyrdzH+rVTrS eVDN0XT2LUzEZF38HAZzUvmsMiGPVCgSniWLN7uBT9wsNm1YQfxuTZO395tJ/0hHv7c5 LwCw== X-Gm-Message-State: AOAM5319JzJRgLpnVx3Qm2efCFpwxW7P7iIx2SfNNHnx74jnc0YjUfe8 0yimr/mS5A80cz6MFWfqgQ+h/Q== X-Received: by 2002:a05:600c:313:: with SMTP id q19mr4477223wmd.126.1610136916383; Fri, 08 Jan 2021 12:15:16 -0800 (PST) Received: from dell.default ([91.110.221.229]) by smtp.gmail.com with ESMTPSA id l8sm15598671wrb.73.2021.01.08.12.15.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 08 Jan 2021 12:15:15 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Subject: [PATCH 09/40] drm/amd/pm/powerplay/hwmgr/vega20_hwmgr: Fix legacy function header formatting Date: Fri, 8 Jan 2021 20:14:26 +0000 Message-Id: <20210108201457.3078600-10-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210108201457.3078600-1-lee.jones@linaro.org> References: <20210108201457.3078600-1-lee.jones@linaro.org> MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: David Airlie , linux-kernel@vger.kernel.org, amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, Alex Deucher , Evan Quan , =?utf-8?q?Christian_K=C3=B6nig?= Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/amd/amdgpu/../pm/powerplay/hwmgr/vega20_hwmgr.c:781: warning: Function parameter or member 'hwmgr' not described in 'vega20_init_smc_table' Cc: Evan Quan Cc: Alex Deucher Cc: "Christian König" Cc: David Airlie Cc: Daniel Vetter Cc: amd-gfx@lists.freedesktop.org Cc: dri-devel@lists.freedesktop.org Signed-off-by: Lee Jones --- drivers/gpu/drm/amd/pm/powerplay/hwmgr/vega20_hwmgr.c | 11 +++++------ 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/drivers/gpu/drm/amd/pm/powerplay/hwmgr/vega20_hwmgr.c b/drivers/gpu/drm/amd/pm/powerplay/hwmgr/vega20_hwmgr.c index da84012b7fd51..87811b005b85f 100644 --- a/drivers/gpu/drm/amd/pm/powerplay/hwmgr/vega20_hwmgr.c +++ b/drivers/gpu/drm/amd/pm/powerplay/hwmgr/vega20_hwmgr.c @@ -771,12 +771,11 @@ static int vega20_setup_default_dpm_tables(struct pp_hwmgr *hwmgr) } /** -* Initializes the SMC table and uploads it -* -* @param hwmgr the address of the powerplay hardware manager. -* @param pInput the pointer to input data (PowerState) -* @return always 0 -*/ + * Initializes the SMC table and uploads it + * + * @hwmgr: the address of the powerplay hardware manager. + * return: always 0 + */ static int vega20_init_smc_table(struct pp_hwmgr *hwmgr) { int result; From patchwork Fri Jan 8 20:14:27 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 359036 Delivered-To: patch@linaro.org Received: by 2002:a02:85a7:0:0:0:0:0 with SMTP id d36csp855634jai; Fri, 8 Jan 2021 12:15:29 -0800 (PST) X-Google-Smtp-Source: ABdhPJyGFxRsMW7iUHzpGBrvQkFoImLXnC1E1S07mMMt/1Yk4rLYvW3cESrEXCS9HHJXNZ+g62qL X-Received: by 2002:a63:357:: with SMTP id 84mr8573965pgd.13.1610136929383; Fri, 08 Jan 2021 12:15:29 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1610136929; cv=none; d=google.com; s=arc-20160816; b=xyGKjSLxaVQKZSc8QMp+ekEqxd9x7PwoiOFwcYj/5XVk/hZM0Py4ZevWI/8GsryKXf Lvv7gP4cp4pIJLiHCt2BauZsjcVHCLjV9FEVF3Fd5zTG/srWmsUW0ZAyCa4KXCo1fFbI 9A8GnY1dV81VjVJDVNxJmd8S+9IBrHWfCaidt469GI4P9pS6YCCBp29cEPnyR4RJiN8Z s0mVHQ/w6rUO7TE+AJW52sVJ5hEvgNRKcuasvRFuQihZBMj69DqqtIVVfDH6MWwP27nN MIN57rw7VtrUj/HtiSi9W6Kjkibr5tcAmYv1eQtazpWpZj3ES/XshA5USjSFqSlm0BEg WFyw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:cc:list-subscribe :list-help:list-post:list-archive:list-unsubscribe:list-id :precedence:mime-version:references:in-reply-to:message-id:date :subject:to:from:dkim-signature:delivered-to; bh=1Qvol1ceYxceOkhnEhgXigaC4BD537wNPzl7Ee1Z+14=; b=ti0O+fDi/UrMsOVSBhrX3MYQ3MgsV04Ot6IW0QjmI+iwH1T9Ne8NdZvFdPHiotmKlq 33dLE+DSyYUeKzygydRDGJB1RFFdUq28ix8ueQcTmwf48vqsdKPasId6zcY7nEbxkeJG wBjQTV+nfTeJuOwleeyllGmGDlvtjQSzzK4f4b6GkTUQ5oBqTSauAEXvhVFRLd2th+iO 8eiR9W7hlzxv06fC1qfv5UAu4gBma+PcUpyM6TTUHb2CfqtloFkH6i4wx359JJ9AOBHH WYNZv42T+x/YhHhTERZNSTTQTDEtTCOuIMJtLZ70JjUsv9gIuRIRA65CvHG62i48ECUZ 6J+Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=pne4rAbZ; spf=pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 131.252.210.177 as permitted sender) smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from gabe.freedesktop.org (gabe.freedesktop.org. [131.252.210.177]) by mx.google.com with ESMTPS id w13si10244766ply.113.2021.01.08.12.15.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 08 Jan 2021 12:15:29 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 131.252.210.177 as permitted sender) client-ip=131.252.210.177; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=pne4rAbZ; spf=pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 131.252.210.177 as permitted sender) smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 857FB6E8D1; Fri, 8 Jan 2021 20:15:20 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mail-wm1-x32e.google.com (mail-wm1-x32e.google.com [IPv6:2a00:1450:4864:20::32e]) by gabe.freedesktop.org (Postfix) with ESMTPS id 0CFBE6E8D3 for ; Fri, 8 Jan 2021 20:15:19 +0000 (UTC) Received: by mail-wm1-x32e.google.com with SMTP id k10so8748931wmi.3 for ; Fri, 08 Jan 2021 12:15:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=SuCvcfeQ9OZsudnyJmzZpphQ6g8eEGgjPIsQH1HjJMU=; b=pne4rAbZBHxNVygLejDzerI+GyLe4DR8+s+f+EwFJCm7dbYva47u/bhXWYGv9Kqj6F 1J+ii3YummtSTnKiXqsYDG7xCGZYoWur28Mb0N2tyOdgYE2VrSNLkGGAmzWqJoCSd3ue qmKQ7WIf3Wrgi4mrILRD/f/wJfLd4v98OBmYeHDwQU11lsNI11wulKXu6Glm56eyWrar 4xfZbbue2cQ/9bfdessylAChzygEP7o7u3hOubC+oV+D2q3ETllTIihbF/wdvGtJk/21 entgOPhY820LPhWkMD/4Jme5U33tuCIMo9w4xv5KngXws94s++vfKojaZgcnJdoiCYLe tsHg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=SuCvcfeQ9OZsudnyJmzZpphQ6g8eEGgjPIsQH1HjJMU=; b=XH9zwvl4fTiQzp5ObtcEEFshxgzcohz9h7DGMmdwKqit7cu0RrQrZXfNENNZmGg8j2 +K/YmsB6Tjoixyxw1y+rNsG7yebuLpbnBWdkqUgVqt5US28CowXk4jgzf8d0ZUhmeqc7 FjWAtUlt3ipKg4P6YiJ6dYC0B6VhkavxbyfrA8xh2OCEzSoXS525GJ7icEvJ6aq6qolq nhZ8GyOknjf/1R1Jxxe26/lxRqevu/UiHQdWRvdertqPdNFZwO6gpygSJMj+IQcQsaZy sbMl4snPh8dedzluZFWm7sT1Zmh5ThRJkXdyx9KfYmTl2dBMEy3BXbR+E0os0Ynbd3EO AdMA== X-Gm-Message-State: AOAM533ubyFaQbR4Y6z2pew+Jz2cSmFm25YQta4GRyJjqEjK05F4KKbr nN228WZMwR+9ocf68nFOBSaQpQ== X-Received: by 2002:a1c:730f:: with SMTP id d15mr4459541wmb.135.1610136917730; Fri, 08 Jan 2021 12:15:17 -0800 (PST) Received: from dell.default ([91.110.221.229]) by smtp.gmail.com with ESMTPSA id l8sm15598671wrb.73.2021.01.08.12.15.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 08 Jan 2021 12:15:17 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Subject: [PATCH 10/40] drm/amd/pm/powerplay/hwmgr/smu7_hwmgr: Fix formatting and spelling issues Date: Fri, 8 Jan 2021 20:14:27 +0000 Message-Id: <20210108201457.3078600-11-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210108201457.3078600-1-lee.jones@linaro.org> References: <20210108201457.3078600-1-lee.jones@linaro.org> MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: David Airlie , linux-kernel@vger.kernel.org, amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, Alex Deucher , Evan Quan , =?utf-8?q?Christian_K=C3=B6nig?= Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/amd/amdgpu/../pm/powerplay/hwmgr/smu7_hwmgr.c:242: warning: Function parameter or member 'hwmgr' not described in 'smu7_enable_smc_voltage_controller' drivers/gpu/drm/amd/amdgpu/../pm/powerplay/hwmgr/smu7_hwmgr.c:4508: warning: Function parameter or member 'us_max_fan_rpm' not described in 'smu7_set_max_fan_rpm_output' drivers/gpu/drm/amd/amdgpu/../pm/powerplay/hwmgr/smu7_hwmgr.c:4508: warning: Excess function parameter 'usMaxFanRpm' description in 'smu7_set_max_fan_rpm_output' Cc: Evan Quan Cc: Alex Deucher Cc: "Christian König" Cc: David Airlie Cc: Daniel Vetter Cc: amd-gfx@lists.freedesktop.org Cc: dri-devel@lists.freedesktop.org Signed-off-by: Lee Jones --- drivers/gpu/drm/amd/pm/powerplay/hwmgr/smu7_hwmgr.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/amd/pm/powerplay/hwmgr/smu7_hwmgr.c b/drivers/gpu/drm/amd/pm/powerplay/hwmgr/smu7_hwmgr.c index 82676c086ce46..c57dc9ae81f2f 100644 --- a/drivers/gpu/drm/amd/pm/powerplay/hwmgr/smu7_hwmgr.c +++ b/drivers/gpu/drm/amd/pm/powerplay/hwmgr/smu7_hwmgr.c @@ -235,7 +235,7 @@ static int smu7_get_current_pcie_lane_number(struct pp_hwmgr *hwmgr) /** * smu7_enable_smc_voltage_controller - Enable voltage control * - * @hwmgr the address of the powerplay hardware manager. + * @hwmgr: the address of the powerplay hardware manager. * Return: always PP_Result_OK */ static int smu7_enable_smc_voltage_controller(struct pp_hwmgr *hwmgr) @@ -4501,7 +4501,7 @@ static int smu7_display_configuration_changed_task(struct pp_hwmgr *hwmgr) * smu7_set_max_fan_rpm_output - Set maximum target operating fan output RPM * * @hwmgr: the address of the powerplay hardware manager. - * @usMaxFanRpm: max operating fan RPM value. + * @us_max_fan_rpm: max operating fan RPM value. * Return: The response that came from the SMC. */ static int smu7_set_max_fan_rpm_output(struct pp_hwmgr *hwmgr, uint16_t us_max_fan_rpm) From patchwork Fri Jan 8 20:14:28 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 359037 Delivered-To: patch@linaro.org Received: by 2002:a02:85a7:0:0:0:0:0 with SMTP id d36csp855659jai; Fri, 8 Jan 2021 12:15:31 -0800 (PST) X-Google-Smtp-Source: ABdhPJz16GbVLjWjkhns16Ccz4G/Tterk53S2YEpZD0Gbd90mXfdqDGVf4olrLxekIj4YNxVSbeT X-Received: by 2002:a62:1506:0:b029:19e:aca2:4ed8 with SMTP id 6-20020a6215060000b029019eaca24ed8mr5317081pfv.27.1610136930892; Fri, 08 Jan 2021 12:15:30 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1610136930; cv=none; d=google.com; s=arc-20160816; b=T5nY31fd439BpjMZpA7gcwgHkO/7UB96VRTp9+wcCPVh4wE09WJLlijihHp+YNPUMv 9H7YgW/oNG1iLod3RCa347OhWIS9iIy5hk9rF6yMBjFJDoLf7R6FP1SlrINKhN7v11OF fz3MyWwcvA6BqPGnSN27N0pC1u0orRGjfuHgOB9WAvgtUUN9aS3atgD3N/HM5FAi6pdF y+YO8+iArrG9QgzXVXCOFkzH9OgGvbCeUghkafJuRiM68+qXr5FFoHR26racP3bW+RSp u2ESZ4cJIM2Y+TvR1JOd9aJTB79CZfmabZuuWDAYURr3R10pCbw2+C/ch7izmeknLT4P vnYQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:cc:list-subscribe :list-help:list-post:list-archive:list-unsubscribe:list-id :precedence:mime-version:references:in-reply-to:message-id:date :subject:to:from:dkim-signature:delivered-to; bh=lqG+5A1wvsAbClNE2Vd/g9S9kgHsnIGH/aMpp3kUkdo=; b=pp923wefBO7n+cd8Hu+8agldajBLOjDk9vk0hjbDEoxw6nubNC0if3FeembRTIK+sV NyfaXG05m5RVHZRCic8yCJGnarASVsuy9kAmZbj5Hg8oc3+pe6Dpi/k47uxrz458hbS2 YW2ykJYC0MQVRzjbx7AUkdKYR5jUnx1gu+0uAEm3ITmbISdEPoDvkv8LK0ZjYdGfIxGn DhlrosZyt+Sk5dj1MDBiMIUFW0Xq7pjI2miYJr/qQacqgKa0JQJiNQZP1Pj9X1IGSkgW T+ZRCyQjUV7fydj+JF0pIWjldqcfxRTPtx2AC81h2x5ZEBwLakuX2J/5P+RK35EstZ3o Y5jw== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=k7hMmuN9; spf=pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 2610:10:20:722:a800:ff:fe36:1795 as permitted sender) smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from gabe.freedesktop.org (gabe.freedesktop.org. [2610:10:20:722:a800:ff:fe36:1795]) by mx.google.com with ESMTPS id q1si9760909pgt.173.2021.01.08.12.15.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 08 Jan 2021 12:15:30 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 2610:10:20:722:a800:ff:fe36:1795 as permitted sender) client-ip=2610:10:20:722:a800:ff:fe36:1795; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=k7hMmuN9; spf=pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 2610:10:20:722:a800:ff:fe36:1795 as permitted sender) smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id D61436E8BF; Fri, 8 Jan 2021 20:15:22 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mail-wm1-x330.google.com (mail-wm1-x330.google.com [IPv6:2a00:1450:4864:20::330]) by gabe.freedesktop.org (Postfix) with ESMTPS id 958266E8D2 for ; Fri, 8 Jan 2021 20:15:20 +0000 (UTC) Received: by mail-wm1-x330.google.com with SMTP id e25so9469095wme.0 for ; Fri, 08 Jan 2021 12:15:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=k4SPpSIEaIrZDfJcedbk8KPV+52H3SX44Cb4d3Gm68s=; b=k7hMmuN9Mb+20/4OO7wQuc1oKHtEPsh/19e+lUDbPYvmWJu/srmWM995pmehzaT1Nt ng+E2Mkj79EDdVAn6pxmRY36XYlU15z00rRXqJsXSGOgkEI2km/GkIE1xJUqPHf2TF2n mX90IH/olI2G7GcXXszjf7zSuhid43l7s0KKKFO92GGL4LmtgDn8yS3tn5xNAcqG9BQU B08ApRr5fNmTgp8gxDyf3n8qWDXBIp1pmHBUv7s6ICuqnPOSsSxxJb0yGvYmA84qXuGP JQuKUN4IrFvyrkCI8n0O90r2WgluMSsVuRVWSyMmle7TrSzhSUdGEhT+URBE3mZyj7r+ YM4w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=k4SPpSIEaIrZDfJcedbk8KPV+52H3SX44Cb4d3Gm68s=; b=Xlq/NjSZylDcahm7zWh2aD4HRvp6ag4hiaD3Sqb35K+X11+ZBKFAQkMM1NWhOGHlTc J1ULa9XcnO2kufGuPRXNYtAtcUh0Hqu1ki8Y0vJk5y/3daVwDGgNe7X4bIPZjNtdr97Q Svkbg05DR9l19pGA3NnhZv1j4+FoT4RjYwIqNEgMzHB1pbHMFCkhWHZFN4GzHZNqS+mW weDd3NBxk4jKV8APSN7EikgvX6LLtqoUNSaCFye9FwZO71g34Ah1oBuP7CyP+w6Dfs0U kuVQyoI7OSJgxbFbRp49QVJ5aPwDERyOrq/E+wk0GSFsinoyWSAMipDzBiBtPp4k/pmJ D2Hg== X-Gm-Message-State: AOAM531l4mzzUkl2O/3wCbNvTnE2xJD3OPyoUfNw+drh0vLzkbCaGDI9 9UYfDCQo0LpuRt0jBv1cTVLtCg== X-Received: by 2002:a7b:c45a:: with SMTP id l26mr4501753wmi.91.1610136919275; Fri, 08 Jan 2021 12:15:19 -0800 (PST) Received: from dell.default ([91.110.221.229]) by smtp.gmail.com with ESMTPSA id l8sm15598671wrb.73.2021.01.08.12.15.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 08 Jan 2021 12:15:18 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Subject: [PATCH 11/40] drm/amd/pm/powerplay/hwmgr/hwmgr: Move prototype into shared header Date: Fri, 8 Jan 2021 20:14:28 +0000 Message-Id: <20210108201457.3078600-12-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210108201457.3078600-1-lee.jones@linaro.org> References: <20210108201457.3078600-1-lee.jones@linaro.org> MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: David Airlie , linux-kernel@vger.kernel.org, amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, Alex Deucher , Evan Quan , =?utf-8?q?Christian_K=C3=B6nig?= Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/amd/amdgpu/../pm/powerplay/hwmgr/vega10_hwmgr.c:5474:5: warning: no previous prototype for ‘vega10_hwmgr_init’ [-Wmissing-prototypes] Cc: Evan Quan Cc: Alex Deucher Cc: "Christian König" Cc: David Airlie Cc: Daniel Vetter Cc: amd-gfx@lists.freedesktop.org Cc: dri-devel@lists.freedesktop.org Signed-off-by: Lee Jones --- drivers/gpu/drm/amd/pm/powerplay/hwmgr/hwmgr.c | 2 +- drivers/gpu/drm/amd/pm/powerplay/hwmgr/vega10_hwmgr.h | 1 + 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/pm/powerplay/hwmgr/hwmgr.c b/drivers/gpu/drm/amd/pm/powerplay/hwmgr/hwmgr.c index 6a7de8b898faf..f2cef0930aa96 100644 --- a/drivers/gpu/drm/amd/pm/powerplay/hwmgr/hwmgr.c +++ b/drivers/gpu/drm/amd/pm/powerplay/hwmgr/hwmgr.c @@ -33,6 +33,7 @@ #include "ppsmc.h" #include "amd_acpi.h" #include "pp_psm.h" +#include "vega10_hwmgr.h" extern const struct pp_smumgr_func ci_smu_funcs; extern const struct pp_smumgr_func smu8_smu_funcs; @@ -46,7 +47,6 @@ extern const struct pp_smumgr_func vega12_smu_funcs; extern const struct pp_smumgr_func smu10_smu_funcs; extern const struct pp_smumgr_func vega20_smu_funcs; -extern int vega10_hwmgr_init(struct pp_hwmgr *hwmgr); extern int smu10_init_function_pointers(struct pp_hwmgr *hwmgr); static int polaris_set_asic_special_caps(struct pp_hwmgr *hwmgr); diff --git a/drivers/gpu/drm/amd/pm/powerplay/hwmgr/vega10_hwmgr.h b/drivers/gpu/drm/amd/pm/powerplay/hwmgr/vega10_hwmgr.h index f752b4ad0c8ae..07c06f8c90b09 100644 --- a/drivers/gpu/drm/amd/pm/powerplay/hwmgr/vega10_hwmgr.h +++ b/drivers/gpu/drm/amd/pm/powerplay/hwmgr/vega10_hwmgr.h @@ -442,5 +442,6 @@ int vega10_update_uvd_dpm(struct pp_hwmgr *hwmgr, bool bgate); int vega10_update_samu_dpm(struct pp_hwmgr *hwmgr, bool bgate); int vega10_update_acp_dpm(struct pp_hwmgr *hwmgr, bool bgate); int vega10_enable_disable_vce_dpm(struct pp_hwmgr *hwmgr, bool enable); +int vega10_hwmgr_init(struct pp_hwmgr *hwmgr); #endif /* _VEGA10_HWMGR_H_ */ From patchwork Fri Jan 8 20:14:29 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 359038 Delivered-To: patch@linaro.org Received: by 2002:a02:85a7:0:0:0:0:0 with SMTP id d36csp855678jai; Fri, 8 Jan 2021 12:15:32 -0800 (PST) X-Google-Smtp-Source: ABdhPJy1vFxi2fRlckNALljIOAxbPBp/tXmFz5x/QkLv9dYuS8aGMxDAK+9nDN+F7MX1A0pTG6h7 X-Received: by 2002:a17:90a:8a82:: with SMTP id x2mr5493151pjn.107.1610136932293; Fri, 08 Jan 2021 12:15:32 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1610136932; cv=none; d=google.com; s=arc-20160816; b=r7kw9+iYA3brcpZazfgOtkFFkavhRSN3fctG6wqh/gTtu0qx7/DGNUiRQovBxsref8 znxbjDpUL1MvoiDmYCT5/0y6SVliJKml+scqoewNyA9wZWpzv82eNy6gTcmvGSxwomlZ MbgISbtnsud7p7t8fLpJNFBS70UZBO832/KkMszyjuA+3+ka7waxRcBbMnCFCVqxbE5y UPdFDtyJ4banyjtBuMrfK9U3S8dtfZz+l52MWVcZbejlKvh0AOYN7KmV7hL89oRDumPK C5ph0uhg5R0vULkBqvniiYF6YMLa56bC0u92g+g3FuQysmDGRswqLscMZhIXV42sBAMm R9Lg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:cc:list-subscribe :list-help:list-post:list-archive:list-unsubscribe:list-id :precedence:mime-version:references:in-reply-to:message-id:date :subject:to:from:dkim-signature:delivered-to; bh=tXvUuMZlEK/Oir1v1tiynsFAQKLl3Ralvfc6P+wsMms=; b=fPFathR3bcIp8PLaQ2onBKwM9C37XnDNzQTVrLr7OCqZsCuSQFVETlOQxOLT1iJ2IL qLHD+xwWp7bhdH6begeZDRjF2CPlYx9voSuhdghJgh09DRiL7bcdls8mogGD3Kev3WeD Yc/7Pgo9mQZrY4HYyUV28p+cXzc21UqUh22x4cSkOI4LGCZzojWm7FfEhOfDxUo0cz6F SHOH30HbZ6SYSCoNG3RxNx1swd08IXfd/PWoRcakJe84xV9Oiob/gUwyUk/tNAkmvIkU mTzt3kOc1rKYdBnZDq3OrSPKX7UjXatcodsJb40UI4gk84FTvJrgjnv4LqPPdU2cUs21 zp9Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=EnziY0oF; spf=pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 2610:10:20:722:a800:ff:fe36:1795 as permitted sender) smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from gabe.freedesktop.org (gabe.freedesktop.org. [2610:10:20:722:a800:ff:fe36:1795]) by mx.google.com with ESMTPS id i36si9795094pgl.455.2021.01.08.12.15.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 08 Jan 2021 12:15:32 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 2610:10:20:722:a800:ff:fe36:1795 as permitted sender) client-ip=2610:10:20:722:a800:ff:fe36:1795; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=EnziY0oF; spf=pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 2610:10:20:722:a800:ff:fe36:1795 as permitted sender) smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 60A176E8D4; Fri, 8 Jan 2021 20:15:24 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mail-wm1-x329.google.com (mail-wm1-x329.google.com [IPv6:2a00:1450:4864:20::329]) by gabe.freedesktop.org (Postfix) with ESMTPS id 59CA56E8D3 for ; Fri, 8 Jan 2021 20:15:22 +0000 (UTC) Received: by mail-wm1-x329.google.com with SMTP id y23so9442404wmi.1 for ; Fri, 08 Jan 2021 12:15:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=Tk22DenAmDkMMxXi1ktqbOBBAMA+I8bi06CmprsDwTY=; b=EnziY0oFmP0ZQxhRlc63iBN7uO95GKJp8AuIUC8zfeC4UYwppl+P+eHzDhPS/m9z38 ciwzsJ4l+bqZM72huH5j8Fn8/8Zok7ZLwYefe0uYueNIuAULw0Plu9mbCiAxrnOlD29U 7mdWrYeXndFXaMI2cUDDvCQ86k/j+AVpfRcJBPQEEsn+cTBfQsF6+AxD/shWlGMCCmc+ HsZFRXso9u7Y3ciaUkACzA0FgrBi20q2u6lVeomZjmAQg/DDARuAlZy0HUECE6YG+uOn yyHSEuuHRqRJnwKqzDZURomfGBV6JbiUgelPh/acs1PqgpUxeVt2gMXRtIX7hY6y9LGV 8LUQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=Tk22DenAmDkMMxXi1ktqbOBBAMA+I8bi06CmprsDwTY=; b=PDVbohNpy4iYEEmckawqOjtgAJLF8OIEjnlKIQkfrjUst9S5IjetHYST1JOADI90Qr i1IzabiKKbfYyNv1QKMSkr2UVhhHpmqzV4iEu8pAlSzHU5gVj2vc1vKOz6rwPwX8+qjP 5pt/NepKQr+YM+GwrXvR6xzOW6RUwWP/btqX++OcfsAAl0bh167L326glYNqNQaHh6Fx jdPjs8fqTvVTFq4gSF/rvBrhN2r0LKzdJ7a0D0sQRShEPMxMMJowQEcixlWxYGmP9Gwy 1qCIB/m5PGZsW1LDkC2G8qRpvC0r13vO9hkxIeObRRFmTQiNbAQg9vP8OMQFdyR+IQ+S x1Mg== X-Gm-Message-State: AOAM532q/cTREDEZB6ktx9sMqyCWC2l2KAVhhdN63ISyMotahrL2Yu3S OYZwth21Vep3mqfwr4S9m2LipA== X-Received: by 2002:a1c:6208:: with SMTP id w8mr4514809wmb.96.1610136920975; Fri, 08 Jan 2021 12:15:20 -0800 (PST) Received: from dell.default ([91.110.221.229]) by smtp.gmail.com with ESMTPSA id l8sm15598671wrb.73.2021.01.08.12.15.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 08 Jan 2021 12:15:19 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Subject: [PATCH 12/40] drm/amd/pm/powerplay/hwmgr/vega10_hwmgr: Fix a bunch of kernel-doc formatting issues Date: Fri, 8 Jan 2021 20:14:29 +0000 Message-Id: <20210108201457.3078600-13-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210108201457.3078600-1-lee.jones@linaro.org> References: <20210108201457.3078600-1-lee.jones@linaro.org> MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: David Airlie , linux-kernel@vger.kernel.org, amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, Alex Deucher , Evan Quan , =?utf-8?q?Christian_K=C3=B6nig?= Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/amd/amdgpu/../pm/powerplay/hwmgr/vega10_hwmgr.c:5474:5: warning: no previous prototype for ‘vega10_hwmgr_init’ [-Wmissing-prototypes] drivers/gpu/drm/amd/amdgpu/../pm/powerplay/hwmgr/vega10_hwmgr.c:551: warning: Function parameter or member 'hwmgr' not described in 'vega10_get_evv_voltages' drivers/gpu/drm/amd/amdgpu/../pm/powerplay/hwmgr/vega10_hwmgr.c:609: warning: Function parameter or member 'hwmgr' not described in 'vega10_patch_with_vdd_leakage' drivers/gpu/drm/amd/amdgpu/../pm/powerplay/hwmgr/vega10_hwmgr.c:609: warning: Function parameter or member 'voltage' not described in 'vega10_patch_with_vdd_leakage' drivers/gpu/drm/amd/amdgpu/../pm/powerplay/hwmgr/vega10_hwmgr.c:609: warning: Function parameter or member 'leakage_table' not described in 'vega10_patch_with_vdd_leakage' drivers/gpu/drm/amd/amdgpu/../pm/powerplay/hwmgr/vega10_hwmgr.c:637: warning: Function parameter or member 'hwmgr' not described in 'vega10_patch_lookup_table_with_leakage' drivers/gpu/drm/amd/amdgpu/../pm/powerplay/hwmgr/vega10_hwmgr.c:637: warning: Function parameter or member 'lookup_table' not described in 'vega10_patch_lookup_table_with_leakage' drivers/gpu/drm/amd/amdgpu/../pm/powerplay/hwmgr/vega10_hwmgr.c:637: warning: Function parameter or member 'leakage_table' not described in 'vega10_patch_lookup_table_with_leakage' drivers/gpu/drm/amd/amdgpu/../pm/powerplay/hwmgr/vega10_hwmgr.c:1013: warning: Function parameter or member 'hwmgr' not described in 'vega10_trim_voltage_table' drivers/gpu/drm/amd/amdgpu/../pm/powerplay/hwmgr/vega10_hwmgr.c:1013: warning: Function parameter or member 'vol_table' not described in 'vega10_trim_voltage_table' drivers/gpu/drm/amd/amdgpu/../pm/powerplay/hwmgr/vega10_hwmgr.c:1160: warning: Function parameter or member 'hwmgr' not described in 'vega10_construct_voltage_tables' drivers/gpu/drm/amd/amdgpu/../pm/powerplay/hwmgr/vega10_hwmgr.c:1558: warning: Function parameter or member 'hwmgr' not described in 'vega10_populate_single_gfx_level' drivers/gpu/drm/amd/amdgpu/../pm/powerplay/hwmgr/vega10_hwmgr.c:1558: warning: Function parameter or member 'gfx_clock' not described in 'vega10_populate_single_gfx_level' drivers/gpu/drm/amd/amdgpu/../pm/powerplay/hwmgr/vega10_hwmgr.c:1558: warning: Function parameter or member 'current_gfxclk_level' not described in 'vega10_populate_single_gfx_level' drivers/gpu/drm/amd/amdgpu/../pm/powerplay/hwmgr/vega10_hwmgr.c:1558: warning: Function parameter or member 'acg_freq' not described in 'vega10_populate_single_gfx_level' drivers/gpu/drm/amd/amdgpu/../pm/powerplay/hwmgr/vega10_hwmgr.c:1613: warning: Cannot understand * @brief Populates single SMC SOCCLK structure using the provided clock. drivers/gpu/drm/amd/amdgpu/../pm/powerplay/hwmgr/vega10_hwmgr.c:1667: warning: Function parameter or member 'hwmgr' not described in 'vega10_populate_all_graphic_levels' drivers/gpu/drm/amd/amdgpu/../pm/powerplay/hwmgr/vega10_hwmgr.c:1750: warning: Cannot understand * @brief Populates single SMC GFXCLK structure using the provided clock. drivers/gpu/drm/amd/amdgpu/../pm/powerplay/hwmgr/vega10_hwmgr.c:1811: warning: Cannot understand * @brief Populates all SMC MCLK levels' structure based on the trimmed allowed dpm memory clock states. drivers/gpu/drm/amd/amdgpu/../pm/powerplay/hwmgr/vega10_hwmgr.c:2496: warning: Function parameter or member 'hwmgr' not described in 'vega10_init_smc_table' drivers/gpu/drm/amd/amdgpu/../pm/powerplay/hwmgr/vega10_hwmgr.c:2867: warning: Cannot understand * @brief Tell SMC to enabled the supported DPMs. Cc: Evan Quan Cc: Alex Deucher Cc: "Christian König" Cc: David Airlie Cc: Daniel Vetter Cc: amd-gfx@lists.freedesktop.org Cc: dri-devel@lists.freedesktop.org Signed-off-by: Lee Jones --- .../drm/amd/pm/powerplay/hwmgr/vega10_hwmgr.c | 133 +++++++++--------- 1 file changed, 65 insertions(+), 68 deletions(-) diff --git a/drivers/gpu/drm/amd/pm/powerplay/hwmgr/vega10_hwmgr.c b/drivers/gpu/drm/amd/pm/powerplay/hwmgr/vega10_hwmgr.c index 1b47f94e03317..da470462d6e2c 100644 --- a/drivers/gpu/drm/amd/pm/powerplay/hwmgr/vega10_hwmgr.c +++ b/drivers/gpu/drm/amd/pm/powerplay/hwmgr/vega10_hwmgr.c @@ -542,11 +542,11 @@ static int vega10_get_socclk_for_voltage_evv(struct pp_hwmgr *hwmgr, #define ATOM_VIRTUAL_VOLTAGE_ID0 0xff01 /** -* Get Leakage VDDC based on leakage ID. -* -* @param hwmgr the address of the powerplay hardware manager. -* @return always 0. -*/ + * Get Leakage VDDC based on leakage ID. + * + * @hwmgr: the address of the powerplay hardware manager. + * return: always 0. + */ static int vega10_get_evv_voltages(struct pp_hwmgr *hwmgr) { struct vega10_hwmgr *data = hwmgr->backend; @@ -600,9 +600,9 @@ static int vega10_get_evv_voltages(struct pp_hwmgr *hwmgr) /** * Change virtual leakage voltage to actual value. * - * @param hwmgr the address of the powerplay hardware manager. - * @param pointer to changing voltage - * @param pointer to leakage table + * @hwmgr: the address of the powerplay hardware manager. + * @voltage: pointer to changing voltage + * @leakage_table: pointer to leakage table */ static void vega10_patch_with_vdd_leakage(struct pp_hwmgr *hwmgr, uint16_t *voltage, struct vega10_leakage_voltage *leakage_table) @@ -624,13 +624,13 @@ static void vega10_patch_with_vdd_leakage(struct pp_hwmgr *hwmgr, } /** -* Patch voltage lookup table by EVV leakages. -* -* @param hwmgr the address of the powerplay hardware manager. -* @param pointer to voltage lookup table -* @param pointer to leakage table -* @return always 0 -*/ + * Patch voltage lookup table by EVV leakages. + * + * @hwmgr: the address of the powerplay hardware manager. + * @lookup_table: pointer to voltage lookup table + * @leakage_table: pointer to leakage table + * return: always 0 + */ static int vega10_patch_lookup_table_with_leakage(struct pp_hwmgr *hwmgr, phm_ppt_v1_voltage_lookup_table *lookup_table, struct vega10_leakage_voltage *leakage_table) @@ -1001,13 +1001,12 @@ static int vega10_setup_asic_task(struct pp_hwmgr *hwmgr) } /** -* Remove repeated voltage values and create table with unique values. -* -* @param hwmgr the address of the powerplay hardware manager. -* @param vol_table the pointer to changing voltage table -* @return 0 in success -*/ - + * Remove repeated voltage values and create table with unique values. + * + * @hwmgr: the address of the powerplay hardware manager. + * @vol_table: the pointer to changing voltage table + * return: 0 in success + */ static int vega10_trim_voltage_table(struct pp_hwmgr *hwmgr, struct pp_atomfwctrl_voltage_table *vol_table) { @@ -1151,11 +1150,11 @@ static void vega10_trim_voltage_table_to_fit_state_table( } /** -* Create Voltage Tables. -* -* @param hwmgr the address of the powerplay hardware manager. -* @return always 0 -*/ + * Create Voltage Tables. + * + * @hwmgr: the address of the powerplay hardware manager. + * return: always 0 + */ static int vega10_construct_voltage_tables(struct pp_hwmgr *hwmgr) { struct vega10_hwmgr *data = hwmgr->backend; @@ -1212,11 +1211,11 @@ static int vega10_construct_voltage_tables(struct pp_hwmgr *hwmgr) } /* - * @fn vega10_init_dpm_state - * @brief Function to initialize all Soft Min/Max and Hard Min/Max to 0xff. + * vega10_init_dpm_state + * Function to initialize all Soft Min/Max and Hard Min/Max to 0xff. * - * @param dpm_state - the address of the DPM Table to initiailize. - * @return None. + * @dpm_state: - the address of the DPM Table to initiailize. + * return: None. */ static void vega10_init_dpm_state(struct vega10_dpm_state *dpm_state) { @@ -1460,11 +1459,11 @@ static int vega10_setup_default_dpm_tables(struct pp_hwmgr *hwmgr) } /* - * @fn vega10_populate_ulv_state - * @brief Function to provide parameters for Utral Low Voltage state to SMC. + * vega10_populate_ulv_state + * Function to provide parameters for Utral Low Voltage state to SMC. * - * @param hwmgr - the address of the hardware manager. - * @return Always 0. + * @hwmgr: - the address of the hardware manager. + * return: Always 0. */ static int vega10_populate_ulv_state(struct pp_hwmgr *hwmgr) { @@ -1545,13 +1544,12 @@ static int vega10_populate_smc_link_levels(struct pp_hwmgr *hwmgr) } /** -* Populates single SMC GFXSCLK structure using the provided engine clock -* -* @param hwmgr the address of the hardware manager -* @param gfx_clock the GFX clock to use to populate the structure. -* @param current_gfxclk_level location in PPTable for the SMC GFXCLK structure. -*/ - + * Populates single SMC GFXSCLK structure using the provided engine clock + * + * @hwmgr: the address of the hardware manager + * @gfx_clock: the GFX clock to use to populate the structure. + * @current_gfxclk_level: location in PPTable for the SMC GFXCLK structure. + */ static int vega10_populate_single_gfx_level(struct pp_hwmgr *hwmgr, uint32_t gfx_clock, PllSetting_t *current_gfxclk_level, uint32_t *acg_freq) @@ -1610,12 +1608,12 @@ static int vega10_populate_single_gfx_level(struct pp_hwmgr *hwmgr, } /** - * @brief Populates single SMC SOCCLK structure using the provided clock. + * Populates single SMC SOCCLK structure using the provided clock. * - * @param hwmgr - the address of the hardware manager. - * @param soc_clock - the SOC clock to use to populate the structure. - * @param current_socclk_level - location in PPTable for the SMC SOCCLK structure. - * @return 0 on success.. + * @hwmgr: the address of the hardware manager. + * @soc_clock: the SOC clock to use to populate the structure. + * @current_socclk_level: location in PPTable for the SMC SOCCLK structure. + * return: 0 on success */ static int vega10_populate_single_soc_level(struct pp_hwmgr *hwmgr, uint32_t soc_clock, uint8_t *current_soc_did, @@ -1659,10 +1657,10 @@ static int vega10_populate_single_soc_level(struct pp_hwmgr *hwmgr, } /** -* Populates all SMC SCLK levels' structure based on the trimmed allowed dpm engine clock states -* -* @param hwmgr the address of the hardware manager -*/ + * Populates all SMC SCLK levels' structure based on the trimmed allowed dpm engine clock states + * + * @hwmgr: the address of the hardware manager + */ static int vega10_populate_all_graphic_levels(struct pp_hwmgr *hwmgr) { struct vega10_hwmgr *data = hwmgr->backend; @@ -1747,11 +1745,11 @@ static void vega10_populate_vddc_soc_levels(struct pp_hwmgr *hwmgr) } /** - * @brief Populates single SMC GFXCLK structure using the provided clock. + * Populates single SMC GFXCLK structure using the provided clock. * - * @param hwmgr - the address of the hardware manager. - * @param mem_clock - the memory clock to use to populate the structure. - * @return 0 on success.. + * @hwmgr: the address of the hardware manager. + * @mem_clock: the memory clock to use to populate the structure. + * return: 0 on success.. */ static int vega10_populate_single_memory_level(struct pp_hwmgr *hwmgr, uint32_t mem_clock, uint8_t *current_mem_vid, @@ -1808,10 +1806,10 @@ static int vega10_populate_single_memory_level(struct pp_hwmgr *hwmgr, } /** - * @brief Populates all SMC MCLK levels' structure based on the trimmed allowed dpm memory clock states. + * Populates all SMC MCLK levels' structure based on the trimmed allowed dpm memory clock states. * - * @param pHwMgr - the address of the hardware manager. - * @return PP_Result_OK on success. + * @hwmgr: the address of the hardware manager. + * return: PP_Result_OK on success. */ static int vega10_populate_all_memory_levels(struct pp_hwmgr *hwmgr) { @@ -2486,12 +2484,11 @@ static void vega10_check_dpm_table_updated(struct pp_hwmgr *hwmgr) } /** -* Initializes the SMC table and uploads it -* -* @param hwmgr the address of the powerplay hardware manager. -* @param pInput the pointer to input data (PowerState) -* @return always 0 -*/ + * Initializes the SMC table and uploads it + * + * @hwmgr: the address of the powerplay hardware manager. + * return: always 0 + */ static int vega10_init_smc_table(struct pp_hwmgr *hwmgr) { int result; @@ -2864,11 +2861,11 @@ static int vega10_stop_dpm(struct pp_hwmgr *hwmgr, uint32_t bitmap) } /** - * @brief Tell SMC to enabled the supported DPMs. + * Tell SMC to enabled the supported DPMs. * - * @param hwmgr - the address of the powerplay hardware manager. - * @Param bitmap - bitmap for the features to enabled. - * @return 0 on at least one DPM is successfully enabled. + * @hwmgr: the address of the powerplay hardware manager. + * @bitmap bitmap for the features to enabled. + * return: 0 on at least one DPM is successfully enabled. */ static int vega10_start_dpm(struct pp_hwmgr *hwmgr, uint32_t bitmap) { From patchwork Fri Jan 8 20:14:30 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 359039 Delivered-To: patch@linaro.org Received: by 2002:a02:85a7:0:0:0:0:0 with SMTP id d36csp855689jai; Fri, 8 Jan 2021 12:15:33 -0800 (PST) X-Google-Smtp-Source: ABdhPJxgkzimS6g1c5Z3hmXLQG5xk5aKd/psEeMsiYCJ+7NRUx6lncp9KdNuP92nZaIciQZWDZeK X-Received: by 2002:a17:90b:203:: with SMTP id fy3mr5593234pjb.231.1610136933661; Fri, 08 Jan 2021 12:15:33 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1610136933; cv=none; d=google.com; s=arc-20160816; b=o3N9VT0EweISrXMhNiQ4AyX2Q/Y9sQnz1NEXZNTZ94VY/NHRurVbxQZOd4i7jjpAIA rdu3OQps0f8gbhm/TTN80OuyNlzabDzgdMawj6g5ciuytt5EMYWwlBZwknK6ehqMFV5T C1501zZXD+YfGbJTFz6LEV3Qyb/H6kXr7NnD9Q/Wiq+4I76pWbgantBqzl3YyGzOmIA5 WL0XkcapCtW4JCfxbIhqO4apix70iY1VhC3bYYCFnA+UB6LPKwMXSZNOq8Viq6I+wMdc 8rs2o1qUHQd8EFPcRLsqL0/FELv7lMAnwU1fnLZCs24nktyXfIHyLb6rze6xzX/SFN3G J65g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:cc:list-subscribe :list-help:list-post:list-archive:list-unsubscribe:list-id :precedence:mime-version:references:in-reply-to:message-id:date :subject:to:from:dkim-signature:delivered-to; bh=75lCaPIdamgAMdtxfUwjCoLPlYzgew2TyVv3XnyCxdQ=; b=zGd0fD0bNEaejouXgYlfXJ5Io8h7a0ch883mGwlMJ/oNjCVE/o7LX1gr9LQn/QO2RC wv4VPz3zI28iL17MaZRlmbHL9AikAZ/nqOt2kJEtDva/m1L/MsFytm8wMC65b62RULHO vgT01O+74g+Jjss00KL5NUQzDh2ahb8a1ZxsEWRnwrElsyCu6VQauMAOtInM7p/DXcBk yediOO2gQAxgjmUlVP5YNH+LTqobTycGdETPk3tkFyUje2xJ8HL+2Egjj9ZEg85L+qub bBuPCssVX1i9khTkBtYzfpMcwOYwIl2QBkV1eXxcUQa5xh249ZuDq1W0dHUtPB6Gfgqz 0aVQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=eWMH5So3; spf=pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 2610:10:20:722:a800:ff:fe36:1795 as permitted sender) smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from gabe.freedesktop.org (gabe.freedesktop.org. [2610:10:20:722:a800:ff:fe36:1795]) by mx.google.com with ESMTPS id h11si10473354pja.87.2021.01.08.12.15.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 08 Jan 2021 12:15:33 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 2610:10:20:722:a800:ff:fe36:1795 as permitted sender) client-ip=2610:10:20:722:a800:ff:fe36:1795; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=eWMH5So3; spf=pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 2610:10:20:722:a800:ff:fe36:1795 as permitted sender) smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id B72CF6E8D6; Fri, 8 Jan 2021 20:15:25 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mail-wr1-x435.google.com (mail-wr1-x435.google.com [IPv6:2a00:1450:4864:20::435]) by gabe.freedesktop.org (Postfix) with ESMTPS id 3C3916E8D0 for ; Fri, 8 Jan 2021 20:15:24 +0000 (UTC) Received: by mail-wr1-x435.google.com with SMTP id y17so10129286wrr.10 for ; Fri, 08 Jan 2021 12:15:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=Ch2gYAE2vDuTmkFhr3daFGk6qkpCbvS5cnZ4t3WwTr8=; b=eWMH5So3djuul8qB47/3pj9n9lXtnPj8xRPt9BjaVXr7omscVJhIB4YxEbAeWG+kVU V523YJopK++IkvFlH40/ocBNKEE2KCzUFsXZ0acwbVrjjcZE+vmVs6wcpIwM+lUH/TWE UGvwUmNRSZ2SXHtSNNkw+HlzMeX1+JmaaOV7SXPjUcI9jfmdroTxKE9uyW52BcyHNRcr Fd1/Ewe7GlTTC+mkHhelgArACGCH3CX9bsBdJWFtx+AtspM2pDGmxvUQo5eNd9HRSfef O/sIm9IVFTencRTxkmeiCoxBIA/tlAeVeCAzhZr2WZiz43T+nJLkvEXeP2Ch9JztHmSa /pCQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=Ch2gYAE2vDuTmkFhr3daFGk6qkpCbvS5cnZ4t3WwTr8=; b=XEf50Ud0g45MIgq05wy9I95eNHU2Lra8C36LSDlgrFFG40GRoA1UwSwsU4Oy1MhqxG 2SPsfsWhF9fzE9DU9jPCAsLD6kdqXGcVAcxVIHdcVhPSzMhUl2sbXdF3Mfae+PqfhwRq vKQYvXbuVV9lCirEYTeeGzqP2iCjaCpFGXBvcGNF4w3OzEKgNgX3jelIIVzlurpKmLRi X92EldxEK6lnvEY5pqvmj347EZ2Wk+xcW91rSLBuh6CLo4tfUG04uiVXP6DmnMGnSK7p fdyXVOL6aIEid+Fnuw/JvsrqEV+9UY/xaD96PVxY07w/5x73O9uapxv7D2UkgFXW6L3L nfaw== X-Gm-Message-State: AOAM533LUVQmDwl+SVr71fyn23rKP0dNtabmvp6KpDPMQ2MW4qxeWYvl WM+UEG5UELL/WzhMCcuE8+P4xg== X-Received: by 2002:a5d:54cc:: with SMTP id x12mr5300851wrv.132.1610136922870; Fri, 08 Jan 2021 12:15:22 -0800 (PST) Received: from dell.default ([91.110.221.229]) by smtp.gmail.com with ESMTPSA id l8sm15598671wrb.73.2021.01.08.12.15.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 08 Jan 2021 12:15:21 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Subject: [PATCH 13/40] drm/amd/display/dc/basics/conversion: Demote obvious kernel-doc abuse Date: Fri, 8 Jan 2021 20:14:30 +0000 Message-Id: <20210108201457.3078600-14-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210108201457.3078600-1-lee.jones@linaro.org> References: <20210108201457.3078600-1-lee.jones@linaro.org> MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Leo Li , linux-kernel@vger.kernel.org, amd-gfx@lists.freedesktop.org, David Airlie , dri-devel@lists.freedesktop.org, Alex Deucher , =?utf-8?q?Christian_K=C3=B6nig?= Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/amd/amdgpu/../display/dc/basics/conversion.c:86: warning: Function parameter or member 'matrix' not described in 'convert_float_matrix' drivers/gpu/drm/amd/amdgpu/../display/dc/basics/conversion.c:86: warning: Function parameter or member 'flt' not described in 'convert_float_matrix' drivers/gpu/drm/amd/amdgpu/../display/dc/basics/conversion.c:86: warning: Function parameter or member 'buffer_size' not described in 'convert_float_matrix' drivers/gpu/drm/amd/amdgpu/../display/dc/basics/conversion.c:86: warning: Excess function parameter 'param' description in 'convert_float_matrix' Cc: Harry Wentland Cc: Leo Li Cc: Alex Deucher Cc: "Christian König" Cc: David Airlie Cc: Daniel Vetter Cc: Lee Jones Cc: amd-gfx@lists.freedesktop.org Cc: dri-devel@lists.freedesktop.org Signed-off-by: Lee Jones --- drivers/gpu/drm/amd/display/dc/basics/conversion.c | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/drivers/gpu/drm/amd/display/dc/basics/conversion.c b/drivers/gpu/drm/amd/display/dc/basics/conversion.c index 24ed03d8cda74..6767fab55c260 100644 --- a/drivers/gpu/drm/amd/display/dc/basics/conversion.c +++ b/drivers/gpu/drm/amd/display/dc/basics/conversion.c @@ -73,12 +73,9 @@ uint16_t fixed_point_to_int_frac( return result; } -/** -* convert_float_matrix -* This converts a double into HW register spec defined format S2D13. -* @param : -* @return None -*/ +/* + * convert_float_matrix - This converts a double into HW register spec defined format S2D13. + */ void convert_float_matrix( uint16_t *matrix, struct fixed31_32 *flt, From patchwork Fri Jan 8 20:14:31 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 359040 Delivered-To: patch@linaro.org Received: by 2002:a02:85a7:0:0:0:0:0 with SMTP id d36csp855711jai; Fri, 8 Jan 2021 12:15:35 -0800 (PST) X-Google-Smtp-Source: ABdhPJypScufyv9Lb7pV9i2/bmyESS6F0dbuj1d/5t/EeuE5z7bE3IlsKpU4zepbtI7IY3exE6gj X-Received: by 2002:aa7:963c:0:b029:19d:dcd3:b2ae with SMTP id r28-20020aa7963c0000b029019ddcd3b2aemr5282593pfg.76.1610136935118; Fri, 08 Jan 2021 12:15:35 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1610136935; cv=none; d=google.com; s=arc-20160816; b=nHUM9EED7r0S/eg4U2e4xTl9MjgUsKyCyUhlSRBYoFUHJVhXT60XlzmpUC6M50M3bY b9FSEtd4EV/Xn+tjvBAiG57jx7HOAZ7hDvhOuUVKR051xMjG8v25jAGhl2DeHKikg0ip kTloijbYNbhGtRmypuXCwfu0pL61bsfbBFvuo0KAALaCqyB7vROMBmynvrENhjm85jRO aOkRCpflM0Ct/agiMSeRDHq6h5iUdfPtjplP3Bi4q3u8N6d8+ECYS3soXV2BqGncIWks sNrRqDKNWmi2DkT3cYa66eGVAjZStb0eZt+WP21y3RlApmpiC5j5COoEDXRthA4tLVp+ ZKqQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:cc:list-subscribe :list-help:list-post:list-archive:list-unsubscribe:list-id :precedence:mime-version:references:in-reply-to:message-id:date :subject:to:from:dkim-signature:delivered-to; bh=qVxG0zFedfuzs89pDzEnrfzevVNQ6ZJkuec94UTjSRk=; b=iFPBq0DAlZGq5eFPniU+SPCYzFt6C5IoKYNhhhYY3Pqtgt7Nbz6K5mY1muKOmgp8ss QS5UfCN74Bfz78LpsMPFQ34ozzuaoVCNqz7zmvai9nYR4pA5IlM5DeLWqlmEhy/LDgxF e8lu6OC0JBJWE64/p4891yH+ppo48oCalu0AfQITzmMBEXUyyNbqDwoIOlVBQ00YCDqs KjUmQNLvCDGW+Hnsg2PajXJ1Aioh8eWqmaxB179lwDKT1whEGZdw9DeRuycWBkwZ9iRU oifIBym+1k7ppQJAg0i1nuxfpLUPr8omQ45ruwOdM9CXITDfSqSmBmxLjuXd6uKwQ1DO 8mqg== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=QgbTBp7N; spf=pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 131.252.210.177 as permitted sender) smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from gabe.freedesktop.org (gabe.freedesktop.org. [131.252.210.177]) by mx.google.com with ESMTPS id t73si10521167pgc.206.2021.01.08.12.15.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 08 Jan 2021 12:15:35 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 131.252.210.177 as permitted sender) client-ip=131.252.210.177; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=QgbTBp7N; spf=pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 131.252.210.177 as permitted sender) smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id B9E4C6E8D0; Fri, 8 Jan 2021 20:15:27 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mail-wr1-x436.google.com (mail-wr1-x436.google.com [IPv6:2a00:1450:4864:20::436]) by gabe.freedesktop.org (Postfix) with ESMTPS id 99DE26E8D3 for ; Fri, 8 Jan 2021 20:15:26 +0000 (UTC) Received: by mail-wr1-x436.google.com with SMTP id a12so10120439wrv.8 for ; Fri, 08 Jan 2021 12:15:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=EprdkygQQeeC3xFfzaC8MU1I4kxvwWaMs/mQ4lWUqWY=; b=QgbTBp7NIQ6cMjQpN9ajxDDhoxzEh3uB8E0xPXcX72UNdYf3NJAQMX2HmAolEzEQCl APJ9C/UfuCn5kvTUIkCcN3eOgy3d0WNKC4zdca3c0tNvyoDo5vpp31Bviol4UInGfPWM sIACr/f+bwjh+pKNVXolQnElxLlEcLNhIKmYhXOvo+Rgp6qz6rF6zXuIievOaQUMY8oD Ot7ptexOlSpzw+tA4Gvu9OKRvIz+CxeRf8y9hkBWePe9ACdGkaiKJmuI7oC5/CzVt/c/ iqSdtGROS+v1QFwtpLBeBnUYJ2/Nydb+q208F74w1qbwtz0/kiZqxOvkI+To3yVcw6nM ewXg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=EprdkygQQeeC3xFfzaC8MU1I4kxvwWaMs/mQ4lWUqWY=; b=lt379FF4EXVSvTakiz3lqwqdK2ateUaL+B9fWgy7JvaYj9TniRInwT5Jj4tH45HBer SNLkMVy4TEBbSnCeHhY2+ful2ykZIdRzz1FUtX4GHCpXYKSKch92u3AcJ0KQ1Qmj4xzJ sapVu9g3Ui6VABbrqpcLRjBHE9yGrRnqZaj4ygbJeU4wMfOZm4Tpq0lQxBOlhY39/cv8 9AT99qnz9ZwjSeU+9mIv9Q1PtvKjhr4z08sTRpvNwdQdRMCXPvCy9Baa/tabxrE3YQTO aPX4gZtXXrwFOtkamkHLxAVtxStYL1B8IY7F2jQTZ0uNtaV3qu1TRjyE91yzsAOp42ny hrKA== X-Gm-Message-State: AOAM5319n8bJ+ro1uWBaB3Rn+osSWGxPOjVGjhQ06vVuQj3lXnae1ZF0 JLAXVyj4ngyq5UbemIm6TquT8Q== X-Received: by 2002:adf:e688:: with SMTP id r8mr5166369wrm.20.1610136925233; Fri, 08 Jan 2021 12:15:25 -0800 (PST) Received: from dell.default ([91.110.221.229]) by smtp.gmail.com with ESMTPSA id l8sm15598671wrb.73.2021.01.08.12.15.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 08 Jan 2021 12:15:24 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Subject: [PATCH 14/40] drm/amd/display/amdgpu_dm/amdgpu_dm_debugfs: Demote non-kernel-doc comment blocks Date: Fri, 8 Jan 2021 20:14:31 +0000 Message-Id: <20210108201457.3078600-15-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210108201457.3078600-1-lee.jones@linaro.org> References: <20210108201457.3078600-1-lee.jones@linaro.org> MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Eryk Brol , Leo Li , linux-kernel@vger.kernel.org, amd-gfx@lists.freedesktop.org, David Airlie , dri-devel@lists.freedesktop.org, Alex Deucher , Mikita Lipski , =?utf-8?q?Christian_K=C3=B6nig?= Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm_debugfs.c:699: warning: Function parameter or member 'm' not described in 'dmub_tracebuffer_show' drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm_debugfs.c:699: warning: Function parameter or member 'data' not described in 'dmub_tracebuffer_show' drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm_debugfs.c:743: warning: Function parameter or member 'm' not described in 'dmub_fw_state_show' drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm_debugfs.c:743: warning: Function parameter or member 'data' not described in 'dmub_fw_state_show' Cc: Harry Wentland Cc: Leo Li Cc: Alex Deucher Cc: "Christian König" Cc: David Airlie Cc: Daniel Vetter Cc: Mikita Lipski Cc: Eryk Brol Cc: amd-gfx@lists.freedesktop.org Cc: dri-devel@lists.freedesktop.org Signed-off-by: Lee Jones --- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_debugfs.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_debugfs.c b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_debugfs.c index 11459fb09a372..d645f3e4610eb 100644 --- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_debugfs.c +++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_debugfs.c @@ -691,7 +691,7 @@ static ssize_t dp_phy_test_pattern_debugfs_write(struct file *f, const char __us return size; } -/** +/* * Returns the DMCUB tracebuffer contents. * Example usage: cat /sys/kernel/debug/dri/0/amdgpu_dm_dmub_tracebuffer */ @@ -735,7 +735,7 @@ static int dmub_tracebuffer_show(struct seq_file *m, void *data) return 0; } -/** +/* * Returns the DMCUB firmware state contents. * Example usage: cat /sys/kernel/debug/dri/0/amdgpu_dm_dmub_fw_state */ From patchwork Fri Jan 8 20:14:32 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 359042 Delivered-To: patch@linaro.org Received: by 2002:a02:85a7:0:0:0:0:0 with SMTP id d36csp855750jai; Fri, 8 Jan 2021 12:15:37 -0800 (PST) X-Google-Smtp-Source: ABdhPJwI7qgzeeozVUeF6iZxcvVh1yBTEjQ5sIOuScJy2Td/VrhAjbwH1ayiUmjvWdwEH31rsYGt X-Received: by 2002:aa7:8d12:0:b029:1ae:4344:3b4f with SMTP id j18-20020aa78d120000b02901ae43443b4fmr5268955pfe.16.1610136937797; Fri, 08 Jan 2021 12:15:37 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1610136937; cv=none; d=google.com; s=arc-20160816; b=08fVbQtjhUoDfNC70vjN4RtoJE7hblcqkSi9FGQZKnVGiA57btdfpzzMg8TtlnfMiB UHyqBkebiPJNfjVRJISv1SyLlY+5dOhHYlTXJA4W921IiiTOwIei6tCwILr+CTfSJ69G r9nGwTheMQ91pYGfADr/2hASNYxQeCCT76EaYkbCQu6d1j7nX+7PNQl5vuXXX2ZztOQt BG0mFKCSU2GShjZM1Y1gJOQsp2fyy6+fGMLfRXpW4/e8t6TPXcJcTV1XskUlgNdcGG3h wvIY7OTuOh+xjshLYPrg+6tV7KUajS3182fG95QB487b90gwMxznj2Br+PjQUiV3Hvza bfyQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:cc:list-subscribe :list-help:list-post:list-archive:list-unsubscribe:list-id :precedence:mime-version:references:in-reply-to:message-id:date :subject:to:from:dkim-signature:delivered-to; bh=mgymJSsa1+U1NYm0CAm+vSbYlGJH2Lt13qIVxLnRDYQ=; b=DdiN+exvkJ/pc3B6ptZjNL5Rvh/6XaAyWNVQHAYiaX1r+C/8XzTlm1VGWsepxtpaSB c7gmmHPeh5e2uFyAJHfrAUXnPsTAIjhfUg4pH0G/VpnMIHzNNU69kfizReyKNg3lbA2T nqqXutLER/YgLjTQlzGf41UkaR/NGga0dJ2jVmC0fEjkSpiw1zKibweyaEO8/Vju9xn0 GZ25uiaBgDf1NXBHG+qm5OGxpFURjklk8GoT0GChNK1f1jDNcpkB3R4w3I5GqQ6CIlAP S/z2CPPLtAZtBpmflAG0SDSQPRrpkrviq/bH5BOvyPlWs/Q/YGuXFfdpjJkXwsW9lXJ8 IZlw== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=PoNsSs56; spf=pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 131.252.210.177 as permitted sender) smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from gabe.freedesktop.org (gabe.freedesktop.org. [131.252.210.177]) by mx.google.com with ESMTPS id q145si1945759pfq.310.2021.01.08.12.15.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 08 Jan 2021 12:15:37 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 131.252.210.177 as permitted sender) client-ip=131.252.210.177; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=PoNsSs56; spf=pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 131.252.210.177 as permitted sender) smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 4EE186E8D5; Fri, 8 Jan 2021 20:15:31 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mail-wm1-x32f.google.com (mail-wm1-x32f.google.com [IPv6:2a00:1450:4864:20::32f]) by gabe.freedesktop.org (Postfix) with ESMTPS id D77C06E8D3 for ; Fri, 8 Jan 2021 20:15:27 +0000 (UTC) Received: by mail-wm1-x32f.google.com with SMTP id a6so8731690wmc.2 for ; Fri, 08 Jan 2021 12:15:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=mGH9J7vG9w88diVL7S4q4GpxhT0ewyJTldBss+diQXU=; b=PoNsSs56+BhMbOp3HWwYXgMD2QalVIqugoJIccivvlUXtTK6KydRosDvXV2ZMuK/j6 V6deq3qJNwDrJvTtxb7rjmxTFTbONrxIeNL/zfclyDWG6Fn3P7ALgSPgu3EF4Cs7h1gO QZxb/a0xh4i64xWfdI1wyCJhnaWHq7gvEWk5XBusIVSbcBRJeaVcaKPSyAjQcin6JAsX e3aD9yBqliYSPffaP0lhXjbatKqzhsO3cZn/JuwGPbJUBYgkcGg9pspsR7XYLAjAezOQ trOtfe1OF81CcTOBCg2m0rxWecucTjnZDHJ1PtOw0qT/qF9F4x0mLHsKgtc6B4gxw12G HsCA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=mGH9J7vG9w88diVL7S4q4GpxhT0ewyJTldBss+diQXU=; b=RLfvDYBZ8ejm0u7yykKr81xrn7CeLlAIWiOvz3MTSuhAkcgSq4Z1NJLnO/8rcuElUA 1cVYE6T57VrR8gKlbxVB8lan4V6mBmPtbQ2GsE3nFV4KcSzjKQ9cRG7N6JcqphpE4jef kY+X7bBFKFpS5KXGxPm7FdTpNBL1RwgPiq3mUruTx+Fl4CacBIdxK58y8XYbONiHZYXA UMHOmcAt4sqXEIog4frBTjapKn31U+oPUer1CkP5E6BJYUkuDZk8SENDkDtnf+a1mYeQ z4BHMd5vUEdg7z+HyxK62YyZ3x99um0Zrkr3yWnjyIgTU7KGgy0MNFUa9RIHVVn3whV7 Z/Lg== X-Gm-Message-State: AOAM5333EDc3itz/fvAqTMc7I5H3oi2+oErCiDeQaqlD6rvegaLvh0Ni vI7OnyPEgTM4LfLkM/WvO9B33g== X-Received: by 2002:a1c:1d08:: with SMTP id d8mr4586785wmd.159.1610136926583; Fri, 08 Jan 2021 12:15:26 -0800 (PST) Received: from dell.default ([91.110.221.229]) by smtp.gmail.com with ESMTPSA id l8sm15598671wrb.73.2021.01.08.12.15.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 08 Jan 2021 12:15:25 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Subject: [PATCH 15/40] drm/amd/display/dc/bios/command_table_helper: Fix kernel-doc formatting Date: Fri, 8 Jan 2021 20:14:32 +0000 Message-Id: <20210108201457.3078600-16-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210108201457.3078600-1-lee.jones@linaro.org> References: <20210108201457.3078600-1-lee.jones@linaro.org> MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Leo Li , Mauro Rossi , linux-kernel@vger.kernel.org, amd-gfx@lists.freedesktop.org, David Airlie , dri-devel@lists.freedesktop.org, Alex Deucher , =?utf-8?q?Christian_K=C3=B6nig?= Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/amd/amdgpu/../display/dc/bios/command_table_helper.c:131: warning: Function parameter or member 't' not described in 'dal_cmd_table_helper_transmitter_bp_to_atom' Cc: Harry Wentland Cc: Leo Li Cc: Alex Deucher Cc: "Christian König" Cc: David Airlie Cc: Daniel Vetter Cc: Mauro Rossi Cc: amd-gfx@lists.freedesktop.org Cc: dri-devel@lists.freedesktop.org Signed-off-by: Lee Jones --- .../display/dc/bios/command_table_helper.c | 20 ++++++++----------- 1 file changed, 8 insertions(+), 12 deletions(-) diff --git a/drivers/gpu/drm/amd/display/dc/bios/command_table_helper.c b/drivers/gpu/drm/amd/display/dc/bios/command_table_helper.c index 48b4ef03fc8f8..5b77251e05909 100644 --- a/drivers/gpu/drm/amd/display/dc/bios/command_table_helper.c +++ b/drivers/gpu/drm/amd/display/dc/bios/command_table_helper.c @@ -114,18 +114,14 @@ bool dal_cmd_table_helper_controller_id_to_atom( } /** -* translate_transmitter_bp_to_atom -* -* @brief -* Translate the Transmitter to the corresponding ATOM BIOS value -* -* @param -* input transmitter -* output digitalTransmitter -* // =00: Digital Transmitter1 ( UNIPHY linkAB ) -* // =01: Digital Transmitter2 ( UNIPHY linkCD ) -* // =02: Digital Transmitter3 ( UNIPHY linkEF ) -*/ + * translate_transmitter_bp_to_atom - Translate the Transmitter to the + * corresponding ATOM BIOS value + * @t: transmitter + * returns: output digitalTransmitter + * // =00: Digital Transmitter1 ( UNIPHY linkAB ) + * // =01: Digital Transmitter2 ( UNIPHY linkCD ) + * // =02: Digital Transmitter3 ( UNIPHY linkEF ) + */ uint8_t dal_cmd_table_helper_transmitter_bp_to_atom( enum transmitter t) { From patchwork Fri Jan 8 20:14:33 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 359041 Delivered-To: patch@linaro.org Received: by 2002:a02:85a7:0:0:0:0:0 with SMTP id d36csp855731jai; Fri, 8 Jan 2021 12:15:36 -0800 (PST) X-Google-Smtp-Source: ABdhPJyjSA8Bul5ZW81AEYLyhSdNkI75z16Cf6ene+ce6D5PVG8F1fhI+BhhxXm/R5pYU48YkCm5 X-Received: by 2002:a17:90a:ca93:: with SMTP id y19mr5588774pjt.71.1610136936542; Fri, 08 Jan 2021 12:15:36 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1610136936; cv=none; d=google.com; s=arc-20160816; b=rue87eOsY6NvbgpBG8h9yYz39Af0MqcvIrOg2oli3rltbyMak0NHvTySRWZksHQM1Z tFCXeyi2ItHNBE+rnwrVQF3R70YueD0yj7tNHbL/VuZdGAdcZfyQ00aNzOA00dhzm+p8 scq6ycNweE0BjRqDtGLic0IVLOUb1uQmQvEA8TsW/iVrRGYntP/UaAxTIFHZO7RVyWtA QWEHabOfF5AZZuaPVBSkLUzacrf2tqpzRoJTJym77Vr8en0co0GXyJqcqz6sPVUdaeIZ o6LW+B+1TVWHJ1FuzW94zHRbvlt8ru6gJ3D6NIUmZU7FAF6UYkwLNBFmYgZHjCMStlBg GpuQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:cc:list-subscribe :list-help:list-post:list-archive:list-unsubscribe:list-id :precedence:mime-version:references:in-reply-to:message-id:date :subject:to:from:dkim-signature:delivered-to; bh=IalG8L6WNvAR4BCCqELWHbHB+7IqfXNahJpvbENFWz8=; b=eH3JI4xnITe1/c3vqP9N/bObOwYW9kUl+KbYdxjM5WtDnnujPP3nV9HbbXyWfq86tR 582QT3hdew9Z1zLLBmZLf4RQJq5Q0Zcg+mPqgcwt5Dr1HIL00A2Y1OGKVV2LCvSW9OOb 13jdIT/oZaEhHaq/MbE0KTQVDPlqiAIaUc+vfFJD/kIYcO2mXrE4q3oyuJ8HIalYN9nb ap63RvsRjsEp/o+v/Z56JgfUdhQ5EGxqd4DYeXGLOCsuxRtRYwyM7eXsrRszYy5rOKmx gBXBuVaWNLQ/XZOyRx02Hmpg5eb6cJ3J+vFNAIFdrZ8RPZaDcoKO1nEaJuA+wKQq925F ynPA== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=j4HTaC5t; spf=pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 131.252.210.177 as permitted sender) smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from gabe.freedesktop.org (gabe.freedesktop.org. [131.252.210.177]) by mx.google.com with ESMTPS id r11si10018385pgg.505.2021.01.08.12.15.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 08 Jan 2021 12:15:36 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 131.252.210.177 as permitted sender) client-ip=131.252.210.177; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=j4HTaC5t; spf=pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 131.252.210.177 as permitted sender) smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id D754E6E8D7; Fri, 8 Jan 2021 20:15:30 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mail-wr1-x42b.google.com (mail-wr1-x42b.google.com [IPv6:2a00:1450:4864:20::42b]) by gabe.freedesktop.org (Postfix) with ESMTPS id 6E0AB6E8CE for ; Fri, 8 Jan 2021 20:15:29 +0000 (UTC) Received: by mail-wr1-x42b.google.com with SMTP id r3so10171933wrt.2 for ; Fri, 08 Jan 2021 12:15:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=8pCWTLh6pUKUhVwO0TotxP6oyBluQlcMqNIDaPfcM14=; b=j4HTaC5teLJEWSrAqsMlehCTa/mrh1JvnNZigcfcW2Jv35J5T8GWVT4ZgZsX6LEscY QED6g9o4ceQ8RoCri7MtZd0Ew+XQLnuspak171c5bLYoG0e2UFlddvWCwiINRxdVHeTo g+WZSYoI1lYoJ78oS08z1p/OCBxFDiEEofnAbNtlpzywGkIQfnTJXobArUqLtU6QlqNT /ykGtHidoKH0olRRP7iKOrT3KMqLGcxYjSqj8zLn5rUIULqqVX/slgvoSl1uBFxtzGV1 ejamhodQxeGIsV7CwOI6ke/S1yoHU9jdtTdkKxg0z51QnvH1Qwz8mqH9gn4dityIug9q qfQQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=8pCWTLh6pUKUhVwO0TotxP6oyBluQlcMqNIDaPfcM14=; b=XLScoEXK0ss7KIlpIs7laa5jq1jDpOj5Uhuc6bi10g2oDddoMcmgsCilkPF4DIzfC0 MPvzEEs+CUOYKkBWqNwKLh60TUqjjW/DV5kCaVWyVLqnIpYTMw/YHP+DsBUa/Xw3WKpa mV41RsFNsE/se3H4QA04myyzlypDZu6MyqmubMRdRSppzGpj/Tbl9UhHlywWYLy6KLPU /49ksw6Q04mOUwFtZlPvoH4QGTh1/yq0/Mv4fU+C85dgD59bp3hToZnS15Q1z6yIWp/Z hArDtnZAa3y41BKOxOn7Mobd3yEcOqb8W09OKwmuzsxBhvXOMq39fBy9vlHgxkL3/oJK bHKg== X-Gm-Message-State: AOAM531j3tAozsQYKf9p5pPpc9yDkZbXKtPQhCpVYp68+su9Vt7jYl5E d2O4zWWGFc/HYuLjYRf2sTAhQA== X-Received: by 2002:a5d:650f:: with SMTP id x15mr5265127wru.332.1610136927993; Fri, 08 Jan 2021 12:15:27 -0800 (PST) Received: from dell.default ([91.110.221.229]) by smtp.gmail.com with ESMTPSA id l8sm15598671wrb.73.2021.01.08.12.15.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 08 Jan 2021 12:15:27 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Subject: [PATCH 16/40] drm/amd/display/dc/bios/command_table_helper2: Fix legacy formatting problems Date: Fri, 8 Jan 2021 20:14:33 +0000 Message-Id: <20210108201457.3078600-17-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210108201457.3078600-1-lee.jones@linaro.org> References: <20210108201457.3078600-1-lee.jones@linaro.org> MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Leo Li , linux-kernel@vger.kernel.org, amd-gfx@lists.freedesktop.org, David Airlie , dri-devel@lists.freedesktop.org, Alex Deucher , =?utf-8?q?Christian_K=C3=B6nig?= Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/amd/amdgpu/../display/dc/bios/command_table_helper2.c:145: warning: Function parameter or member 't' not described in 'dal_cmd_table_helper_transmitter_bp_to_atom2' Cc: Harry Wentland Cc: Leo Li Cc: Alex Deucher Cc: "Christian König" Cc: David Airlie Cc: Daniel Vetter Cc: amd-gfx@lists.freedesktop.org Cc: dri-devel@lists.freedesktop.org Signed-off-by: Lee Jones --- .../display/dc/bios/command_table_helper2.c | 20 ++++++++----------- 1 file changed, 8 insertions(+), 12 deletions(-) diff --git a/drivers/gpu/drm/amd/display/dc/bios/command_table_helper2.c b/drivers/gpu/drm/amd/display/dc/bios/command_table_helper2.c index 7736c92d55c40..455ee2be15a36 100644 --- a/drivers/gpu/drm/amd/display/dc/bios/command_table_helper2.c +++ b/drivers/gpu/drm/amd/display/dc/bios/command_table_helper2.c @@ -128,18 +128,14 @@ bool dal_cmd_table_helper_controller_id_to_atom2( } /** -* translate_transmitter_bp_to_atom -* -* @brief -* Translate the Transmitter to the corresponding ATOM BIOS value -* -* @param -* input transmitter -* output digitalTransmitter -* // =00: Digital Transmitter1 ( UNIPHY linkAB ) -* // =01: Digital Transmitter2 ( UNIPHY linkCD ) -* // =02: Digital Transmitter3 ( UNIPHY linkEF ) -*/ + * translate_transmitter_bp_to_atom2 - Translate the Transmitter to the + * corresponding ATOM BIOS value + * @t: transmitter + * returns: digitalTransmitter + * // =00: Digital Transmitter1 ( UNIPHY linkAB ) + * // =01: Digital Transmitter2 ( UNIPHY linkCD ) + * // =02: Digital Transmitter3 ( UNIPHY linkEF ) + */ uint8_t dal_cmd_table_helper_transmitter_bp_to_atom2( enum transmitter t) { From patchwork Fri Jan 8 20:14:34 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 359043 Delivered-To: patch@linaro.org Received: by 2002:a02:85a7:0:0:0:0:0 with SMTP id d36csp855764jai; Fri, 8 Jan 2021 12:15:39 -0800 (PST) X-Google-Smtp-Source: ABdhPJyAkYU+aFcoBAHTviTTnxMkne7PQTwC09v26P2pvppYjlgfInLienSuR99VdKqlS2Fv1Fh/ X-Received: by 2002:a17:90a:5513:: with SMTP id b19mr5542322pji.99.1610136939076; Fri, 08 Jan 2021 12:15:39 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1610136939; cv=none; d=google.com; s=arc-20160816; b=hkF03yAGCUMpK0vnyp/VdSGBj9yVe6IfyAs4ILwninbQ6v0Oqn0olvU3WqjGb25g2g Kt1w7m6VDH7EMKW2lSSkil8VO7YRac6m1+YX0gAhIf60iLKVIhV2gdjSQsW0xNKq9uW7 M5UbEw0IoBhetpQsnyqvZPsePHwef+puhFJ1F2Vh9Gy7VIh6e6nVrOq7MXZBTnkKaitc 06gKscmsrXTQTglD2xnSWFsX8iSlcoEGvd5bVmjmWNuAd92Cj3vBylZCvchphAtpwq1R G2HrEFvDkISkNjY5mNXgLtbPP+At9zeop2l8Yv6N75V1PRfjoHwdPn/Hm70PA3jp2Qdm kvog== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:cc:list-subscribe :list-help:list-post:list-archive:list-unsubscribe:list-id :precedence:mime-version:references:in-reply-to:message-id:date :subject:to:from:dkim-signature:delivered-to; bh=dHcz+7yilTo+CaXHYQ6B0oCqQsq06A34HOw+EFP9hiQ=; b=XzCDOGqM7J+uCxrTOmRIXWXD68p0yyzTPLtbfSTfFFusv2jGTHCpS0LRgO0CeE8lek 2KlvicWsGy9YpNhMRQm0jZE4yyrApgv1FiKvvDNdTDZFGsJNH20PxcXoFFlgO4jK1SLE UAGwq+fk1xtQ2p3B8DgBgt5cpkLcx6eqCkTwJ4K4jFzmyA24IEeYTxN7mSaJR/HF2He8 jIZpz35bx6Ep0DoNwqx1Ng6yi8nQQgYfsjqP8z2tGoh0kPXwQfSpQcF2gWBkd/c9V0Kl VLI1kAS9vNrLM1OCHydzi6r7xEa7PeScR1pq3/eS5TFJNA08wj5EnCjx4iU6uEU3sIxw hySA== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=UjObcNpL; spf=pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 131.252.210.177 as permitted sender) smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from gabe.freedesktop.org (gabe.freedesktop.org. [131.252.210.177]) by mx.google.com with ESMTPS id lt7si10409646pjb.139.2021.01.08.12.15.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 08 Jan 2021 12:15:39 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 131.252.210.177 as permitted sender) client-ip=131.252.210.177; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=UjObcNpL; spf=pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 131.252.210.177 as permitted sender) smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 5E06A6E8D9; Fri, 8 Jan 2021 20:15:33 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mail-wm1-x336.google.com (mail-wm1-x336.google.com [IPv6:2a00:1450:4864:20::336]) by gabe.freedesktop.org (Postfix) with ESMTPS id CEEA86E8D5 for ; Fri, 8 Jan 2021 20:15:30 +0000 (UTC) Received: by mail-wm1-x336.google.com with SMTP id a6so8731801wmc.2 for ; Fri, 08 Jan 2021 12:15:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=w+rKqjsgsMRrWlbR0mS6qqZSklymAWueG82I2hOJ6Ds=; b=UjObcNpLmHgcVOeAiK1W8DH7qr/VTvKYYZvqwqgnSssxmyVRRzsJZmTvoKlwdQs01J NH7S9Mex2LrJ2/AaEUzm3rNqG8I12C/Xpj1PsvDO1wyi8oGualF6qkSrVPunrDULTTom xWhM/2mwjk08/4+J6spoCMxRTl9G0Gw/r0h4588xd8hz4X9VkBA/dx45Yd8tNUUewq6e zPICIlZTExobP1md8Ivtbr/c55KpzqTHL5gUtGhOv3CbcwSOfFoXTfvsHz6wLvTGD+4T 4JJku0UmibFovBql4Ll+pwP24pQJS2iS/Ra4slhfru8dhDevYzSAhuUjzHo1VmJinivG 6x0w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=w+rKqjsgsMRrWlbR0mS6qqZSklymAWueG82I2hOJ6Ds=; b=OtjHu0q8qrs0xPu1BQme4j5RR7y3wydamfaLv7q9L5ynC8P5mHDQA9ga2p6rGmb8oL gAzRjSPyo+8wzWGz5t+kivlrCPd6NMf0ii1tX/StzEHi9ym+HPlJgSPqFm3mJqKHTQLk IH0tKrL75BknjBRfCurNiN4Gr7BQU7P1lDBVxQUpr/pQpsZwoqAD4Pul1+X1otsbrrzB gEvzDLpSKvbyvWDYlHsc6FJSbP9++NKBCvpIXbUJJDyX62lDaq84/nsI7mW03i7sl6i5 m7u8Oa1zIU7LVExrDk6hZhFsm22CNIbN+jrluFLZwod7LnJx7rpn8yNbxL2WWEQnL0Id gPHA== X-Gm-Message-State: AOAM533YLwP807Av2jtqf6rhJi9hBYDpgjEATeDOIs4En4gZ2RlYqOiI FNQkmtW1seQBjy2tHLuf9sekaA== X-Received: by 2002:a1c:7218:: with SMTP id n24mr4508553wmc.186.1610136929497; Fri, 08 Jan 2021 12:15:29 -0800 (PST) Received: from dell.default ([91.110.221.229]) by smtp.gmail.com with ESMTPSA id l8sm15598671wrb.73.2021.01.08.12.15.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 08 Jan 2021 12:15:28 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Subject: [PATCH 17/40] drm/amd/display/dc/bios/bios_parser: Make local functions static Date: Fri, 8 Jan 2021 20:14:34 +0000 Message-Id: <20210108201457.3078600-18-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210108201457.3078600-1-lee.jones@linaro.org> References: <20210108201457.3078600-1-lee.jones@linaro.org> MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Leo Li , linux-kernel@vger.kernel.org, amd-gfx@lists.freedesktop.org, Igor Kravchenko , David Airlie , dri-devel@lists.freedesktop.org, Alex Deucher , =?utf-8?q?Christian_K=C3=B6nig?= Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/amd/amdgpu/../display/dc/bios/bios_parser.c:2588:16: warning: no previous prototype for ‘update_slot_layout_info’ [-Wmissing-prototypes] drivers/gpu/drm/amd/amdgpu/../display/dc/bios/bios_parser.c:2692:16: warning: no previous prototype for ‘get_bracket_layout_record’ [-Wmissing-prototypes] Cc: Harry Wentland Cc: Leo Li Cc: Alex Deucher Cc: "Christian König" Cc: David Airlie Cc: Daniel Vetter Cc: Igor Kravchenko Cc: amd-gfx@lists.freedesktop.org Cc: dri-devel@lists.freedesktop.org Signed-off-by: Lee Jones --- drivers/gpu/drm/amd/display/dc/bios/bios_parser.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/amd/display/dc/bios/bios_parser.c b/drivers/gpu/drm/amd/display/dc/bios/bios_parser.c index 23a373ca94b5c..f054c5872c619 100644 --- a/drivers/gpu/drm/amd/display/dc/bios/bios_parser.c +++ b/drivers/gpu/drm/amd/display/dc/bios/bios_parser.c @@ -2585,7 +2585,7 @@ static struct integrated_info *bios_parser_create_integrated_info( return NULL; } -enum bp_result update_slot_layout_info( +static enum bp_result update_slot_layout_info( struct dc_bios *dcb, unsigned int i, struct slot_layout_info *slot_layout_info, @@ -2689,7 +2689,7 @@ enum bp_result update_slot_layout_info( } -enum bp_result get_bracket_layout_record( +static enum bp_result get_bracket_layout_record( struct dc_bios *dcb, unsigned int bracket_layout_id, struct slot_layout_info *slot_layout_info) From patchwork Fri Jan 8 20:14:35 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 359044 Delivered-To: patch@linaro.org Received: by 2002:a02:85a7:0:0:0:0:0 with SMTP id d36csp855790jai; Fri, 8 Jan 2021 12:15:40 -0800 (PST) X-Google-Smtp-Source: ABdhPJzfcEyIQXE9shs2BVXu/X4lrcifIwhAIcukz+KHWEBEfgFC04zoc+imzNXZ7KUHgioy47Yk X-Received: by 2002:a63:5c18:: with SMTP id q24mr8592443pgb.411.1610136940525; Fri, 08 Jan 2021 12:15:40 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1610136940; cv=none; d=google.com; s=arc-20160816; b=avdFGBZlql0G2HPU6gw/qa90BiX09Gt+PkP7fD0hJQWwuPmA8NaM3ZA0oSKs3owjIo ueVP6DrXoTnb21h+nYnAIJvcIYT5psDUL/tAy3weBGExDnutLcbmFw8pHq9KqianU7fg E9ZpX9K/5EEH6/EjuJBhGFWv0xKtW8e3+CuievA40+N+/+Hpfo4rqu4jykZX95bFsOLz WPi7USyTHUFIRnAiDAUYh2Ec8hEqJI7steuG4Ju55CoAGSLrCzdUmvKcnRXz0ZsQBEPJ tZFiAjdkEnrf8iTiOU6N9PN6Gc2POuVG9PMMOupQxNakIOg0hJAKqcoF6Qhd5zJ/yfMQ hMtw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:cc:list-subscribe :list-help:list-post:list-archive:list-unsubscribe:list-id :precedence:mime-version:references:in-reply-to:message-id:date :subject:to:from:dkim-signature:delivered-to; bh=9j2pdMoOif9ax+94w4cjrdCN2Cp5y0NCrzV6KoEbwLg=; b=yIgbqkDHc1imZZxkFlckUSCyxgv+guWtuImxOuwb5vNESHsDeiQnBGHyKycFBTWcEx v3y8EG5bnQepq+9vOfOs9zIFvVINuQtc6+CwnSaBn47AATdQGkFHpQIg0PaVa5R5zqmi Vs4NVKdU04n2rpFoKvUJ0+1l4bocmpp3dJWYoA2kPQUdqfsZsxdEz8FiHSipk4qYATeB 8gXFg98nBkhIPfTss40fdmW7acKNJBDpHQlU3NKOynrTUIWvAJNvraeSVbCY9kmek8pP uS05e+nCwwK2mH1WRQkitRgrRTd53HtAwWkmLB7dRyERoUEcgwo/AfG3D8jwqZ+zSDJf TvQw== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=SEVv9CDR; spf=pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 2610:10:20:722:a800:ff:fe36:1795 as permitted sender) smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from gabe.freedesktop.org (gabe.freedesktop.org. [2610:10:20:722:a800:ff:fe36:1795]) by mx.google.com with ESMTPS id j10si10250881pfr.206.2021.01.08.12.15.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 08 Jan 2021 12:15:40 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 2610:10:20:722:a800:ff:fe36:1795 as permitted sender) client-ip=2610:10:20:722:a800:ff:fe36:1795; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=SEVv9CDR; spf=pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 2610:10:20:722:a800:ff:fe36:1795 as permitted sender) smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id C1FB96E8C8; Fri, 8 Jan 2021 20:15:33 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mail-wr1-x430.google.com (mail-wr1-x430.google.com [IPv6:2a00:1450:4864:20::430]) by gabe.freedesktop.org (Postfix) with ESMTPS id 4957F6E8D9 for ; Fri, 8 Jan 2021 20:15:32 +0000 (UTC) Received: by mail-wr1-x430.google.com with SMTP id i9so10169051wrc.4 for ; Fri, 08 Jan 2021 12:15:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=tBgi+TtCPp/XvYlN4nRx8jEUcrOm4gQPVN4cT7HQvug=; b=SEVv9CDRWxF1yk6kuCe/HD3vJIxGpMD5w0Vv6WQP6QnoNpvbnDmFxHNoV7DVwKwUoI zrVcBYwmh5ViXB18xebafqCsCQK13HtyXASqB/b/Lb/685iNgw2aNDEuv5gra6AGyFXy pyrmDd/YQHo5zi3kvzalBwcvNtDioPD4A20rdkfNGTc7bubibVkwEKH/Mzr/sTJs56g1 MDw+Yfn4oWlOZKer5V0x+XXSLOv8HBSjgSW2ThVqmgFYF3nUg860jPq3G+ouJbpfWneE 30XvyS64+XIOn5VcQKU032KwJvYgsw6pKUemL4NsmV5XRQLV4kuQpcK0NKbUPU8uvwAq 6hRA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=tBgi+TtCPp/XvYlN4nRx8jEUcrOm4gQPVN4cT7HQvug=; b=rxEfxjKV3xW3KTI16XJd5chsqqJK+dFv4qCSPHkDol8R+i2VCWUuTqb7flub4uVc7I zlHhP2roFbJYsfgw5JN6oibcOvjrnlWbrBNmZDX9azCQkflc8vPNa6gHyM72OK9o6dEC 847/d9YOOtFbO53ZHTtyLMYQQiTh74/nolQVD93GV7ozkjAOCg3jwPhTG3oi7dcIzfc8 nIVB4jIF+myHEwy2p/RZPHBwF8HECVucznBeGiA7FHXoTtnbY8r9gjbBjIbCiTAjQjfl zDYpTDnS42c/jwqhRbmWQj9bnepiCg/6nmZnx2TroZ84hmIMyJlWbcHtE4Kdo5oC6fJp oW7g== X-Gm-Message-State: AOAM533aKZ/4sQ7g6eS0C3vncAY6GcKBNU/zx/lX1QihONMIEZfX+Ohg d+OWdk1tx+8jORa4qNDX/FGEYA== X-Received: by 2002:adf:fa02:: with SMTP id m2mr5161402wrr.130.1610136930880; Fri, 08 Jan 2021 12:15:30 -0800 (PST) Received: from dell.default ([91.110.221.229]) by smtp.gmail.com with ESMTPSA id l8sm15598671wrb.73.2021.01.08.12.15.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 08 Jan 2021 12:15:30 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Subject: [PATCH 18/40] drm/amd/display/dc/bios/bios_parser: Fix a whole bunch of legacy doc formatting Date: Fri, 8 Jan 2021 20:14:35 +0000 Message-Id: <20210108201457.3078600-19-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210108201457.3078600-1-lee.jones@linaro.org> References: <20210108201457.3078600-1-lee.jones@linaro.org> MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Leo Li , linux-kernel@vger.kernel.org, amd-gfx@lists.freedesktop.org, David Airlie , dri-devel@lists.freedesktop.org, Alex Deucher , =?utf-8?q?Christian_K=C3=B6nig?= Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/amd/amdgpu/../display/dc/bios/bios_parser.c:2588:16: warning: no previous prototype for ‘update_slot_layout_info’ [-Wmissing-prototypes] drivers/gpu/drm/amd/amdgpu/../display/dc/bios/bios_parser.c:2692:16: warning: no previous prototype for ‘get_bracket_layout_record’ [-Wmissing-prototypes] drivers/gpu/drm/amd/amdgpu/../display/dc/bios/bios_parser.c:925: warning: Function parameter or member 'dcb' not described in 'bios_parser_get_spread_spectrum_info' drivers/gpu/drm/amd/amdgpu/../display/dc/bios/bios_parser.c:925: warning: Function parameter or member 'signal' not described in 'bios_parser_get_spread_spectrum_info' drivers/gpu/drm/amd/amdgpu/../display/dc/bios/bios_parser.c:925: warning: Function parameter or member 'index' not described in 'bios_parser_get_spread_spectrum_info' drivers/gpu/drm/amd/amdgpu/../display/dc/bios/bios_parser.c:925: warning: Function parameter or member 'ss_info' not described in 'bios_parser_get_spread_spectrum_info' drivers/gpu/drm/amd/amdgpu/../display/dc/bios/bios_parser.c:997: warning: Function parameter or member 'bp' not described in 'get_ss_info_from_tbl' drivers/gpu/drm/amd/amdgpu/../display/dc/bios/bios_parser.c:997: warning: Function parameter or member 'id' not described in 'get_ss_info_from_tbl' drivers/gpu/drm/amd/amdgpu/../display/dc/bios/bios_parser.c:997: warning: Function parameter or member 'ss_info' not described in 'get_ss_info_from_tbl' drivers/gpu/drm/amd/amdgpu/../display/dc/bios/bios_parser.c:1022: warning: Function parameter or member 'bp' not described in 'get_ss_info_from_internal_ss_info_tbl_V2_1' drivers/gpu/drm/amd/amdgpu/../display/dc/bios/bios_parser.c:1022: warning: Function parameter or member 'id' not described in 'get_ss_info_from_internal_ss_info_tbl_V2_1' drivers/gpu/drm/amd/amdgpu/../display/dc/bios/bios_parser.c:1022: warning: Function parameter or member 'info' not described in 'get_ss_info_from_internal_ss_info_tbl_V2_1' drivers/gpu/drm/amd/amdgpu/../display/dc/bios/bios_parser.c:1087: warning: Function parameter or member 'bp' not described in 'get_ss_info_from_ss_info_table' drivers/gpu/drm/amd/amdgpu/../display/dc/bios/bios_parser.c:1087: warning: Function parameter or member 'id' not described in 'get_ss_info_from_ss_info_table' drivers/gpu/drm/amd/amdgpu/../display/dc/bios/bios_parser.c:1087: warning: Function parameter or member 'ss_info' not described in 'get_ss_info_from_ss_info_table' drivers/gpu/drm/amd/amdgpu/../display/dc/bios/bios_parser.c:1469: warning: Function parameter or member 'dcb' not described in 'bios_parser_get_encoder_cap_info' drivers/gpu/drm/amd/amdgpu/../display/dc/bios/bios_parser.c:1469: warning: Function parameter or member 'object_id' not described in 'bios_parser_get_encoder_cap_info' drivers/gpu/drm/amd/amdgpu/../display/dc/bios/bios_parser.c:1469: warning: Function parameter or member 'info' not described in 'bios_parser_get_encoder_cap_info' drivers/gpu/drm/amd/amdgpu/../display/dc/bios/bios_parser.c:1508: warning: Function parameter or member 'bp' not described in 'get_encoder_cap_record' drivers/gpu/drm/amd/amdgpu/../display/dc/bios/bios_parser.c:1508: warning: Function parameter or member 'object' not described in 'get_encoder_cap_record' drivers/gpu/drm/amd/amdgpu/../display/dc/bios/bios_parser.c:1566: warning: Function parameter or member 'dcb' not described in 'bios_parser_get_ss_entry_number' drivers/gpu/drm/amd/amdgpu/../display/dc/bios/bios_parser.c:1566: warning: Function parameter or member 'signal' not described in 'bios_parser_get_ss_entry_number' drivers/gpu/drm/amd/amdgpu/../display/dc/bios/bios_parser.c:1619: warning: Function parameter or member 'bp' not described in 'get_ss_entry_number_from_ss_info_tbl' drivers/gpu/drm/amd/amdgpu/../display/dc/bios/bios_parser.c:1619: warning: Function parameter or member 'id' not described in 'get_ss_entry_number_from_ss_info_tbl' drivers/gpu/drm/amd/amdgpu/../display/dc/bios/bios_parser.c:1686: warning: Function parameter or member 'bp' not described in 'get_ss_entry_number' drivers/gpu/drm/amd/amdgpu/../display/dc/bios/bios_parser.c:1686: warning: Function parameter or member 'id' not described in 'get_ss_entry_number' drivers/gpu/drm/amd/amdgpu/../display/dc/bios/bios_parser.c:1705: warning: Function parameter or member 'bp' not described in 'get_ss_entry_number_from_internal_ss_info_tbl_v2_1' drivers/gpu/drm/amd/amdgpu/../display/dc/bios/bios_parser.c:1705: warning: Function parameter or member 'id' not described in 'get_ss_entry_number_from_internal_ss_info_tbl_v2_1' drivers/gpu/drm/amd/amdgpu/../display/dc/bios/bios_parser.c:1740: warning: Function parameter or member 'bp' not described in 'get_ss_entry_number_from_internal_ss_info_tbl_V3_1' drivers/gpu/drm/amd/amdgpu/../display/dc/bios/bios_parser.c:1740: warning: Function parameter or member 'id' not described in 'get_ss_entry_number_from_internal_ss_info_tbl_V3_1' drivers/gpu/drm/amd/amdgpu/../display/dc/bios/bios_parser.c:1783: warning: Function parameter or member 'dcb' not described in 'bios_parser_get_gpio_pin_info' drivers/gpu/drm/amd/amdgpu/../display/dc/bios/bios_parser.c:1783: warning: Function parameter or member 'gpio_id' not described in 'bios_parser_get_gpio_pin_info' drivers/gpu/drm/amd/amdgpu/../display/dc/bios/bios_parser.c:1783: warning: Function parameter or member 'info' not described in 'bios_parser_get_gpio_pin_info' drivers/gpu/drm/amd/amdgpu/../display/dc/bios/bios_parser.c:2211: warning: Function parameter or member 'dcb' not described in 'bios_parser_set_scratch_critical_state' drivers/gpu/drm/amd/amdgpu/../display/dc/bios/bios_parser.c:2211: warning: Function parameter or member 'state' not described in 'bios_parser_set_scratch_critical_state' Cc: Harry Wentland Cc: Leo Li Cc: Alex Deucher Cc: "Christian König" Cc: David Airlie Cc: Daniel Vetter Cc: Lee Jones Cc: amd-gfx@lists.freedesktop.org Cc: dri-devel@lists.freedesktop.org Signed-off-by: Lee Jones --- .../gpu/drm/amd/display/dc/bios/bios_parser.c | 115 +++++++++--------- 1 file changed, 56 insertions(+), 59 deletions(-) diff --git a/drivers/gpu/drm/amd/display/dc/bios/bios_parser.c b/drivers/gpu/drm/amd/display/dc/bios/bios_parser.c index f054c5872c619..d2654c50b0b20 100644 --- a/drivers/gpu/drm/amd/display/dc/bios/bios_parser.c +++ b/drivers/gpu/drm/amd/display/dc/bios/bios_parser.c @@ -911,11 +911,11 @@ static enum bp_result get_ss_info_from_tbl( * ver 2.1 can co-exist with SS_Info table. Expect ASIC_InternalSS_Info ver 3.1, * there is only one entry for each signal /ss id. However, there is * no planning of supporting multiple spread Sprectum entry for EverGreen - * @param [in] this - * @param [in] signal, ASSignalType to be converted to info index - * @param [in] index, number of entries that match the converted info index - * @param [out] ss_info, sprectrum information structure, - * @return Bios parser result code + * @dcb: pointer to the DC BIOS + * @signal: ASSignalType to be converted to info index + * @index: number of entries that match the converted info index + * @ss_info: sprectrum information structure, + * return: Bios parser result code */ static enum bp_result bios_parser_get_spread_spectrum_info( struct dc_bios *dcb, @@ -985,10 +985,10 @@ static enum bp_result get_ss_info_from_internal_ss_info_tbl_V2_1( * There can not be more than 1 entry for ASIC_InternalSS_Info Ver 2.1 or * SS_Info. * - * @param this - * @param id, spread sprectrum info index - * @param pSSinfo, sprectrum information structure, - * @return Bios parser result code + * @bp: pointer to the BIOS parser + * @id: spread sprectrum info index + * @ssinfo: sprectrum information structure, + * return:: BIOS parser result code */ static enum bp_result get_ss_info_from_tbl( struct bios_parser *bp, @@ -1011,9 +1011,10 @@ static enum bp_result get_ss_info_from_tbl( * from the VBIOS * There will not be multiple entry for Ver 2.1 * - * @param id, spread sprectrum info index - * @param pSSinfo, sprectrum information structure, - * @return Bios parser result code + * @bp: pointer to the Bios parser + * @id: spread sprectrum info index + * @info: sprectrum information structure, + * return: Bios parser result code */ static enum bp_result get_ss_info_from_internal_ss_info_tbl_V2_1( struct bios_parser *bp, @@ -1076,9 +1077,10 @@ static enum bp_result get_ss_info_from_internal_ss_info_tbl_V2_1( * of entries that matches the id * for, the SS_Info table, there should not be more than 1 entry match. * - * @param [in] id, spread sprectrum id - * @param [out] pSSinfo, sprectrum information structure, - * @return Bios parser result code + * @bp: pointer to the Bios parser + * @id: spread sprectrum id + * @ss_info: sprectrum information structure, + * return: Bios parser result code */ static enum bp_result get_ss_info_from_ss_info_table( struct bios_parser *bp, @@ -1451,16 +1453,14 @@ static enum bp_result get_embedded_panel_info_v1_3( } /** - * bios_parser_get_encoder_cap_info + * bios_parser_get_encoder_cap_info - get encoder capability + * information of input object id * - * @brief - * Get encoder capability information of input object id - * - * @param object_id, Object id - * @param object_id, encoder cap information structure - * - * @return Bios parser result code + * @dcb: pointer to the DC BIOS + * @object_id: object id + * @info: encoder cap information structure * + * return: Bios parser result code */ static enum bp_result bios_parser_get_encoder_cap_info( struct dc_bios *dcb, @@ -1490,17 +1490,12 @@ static enum bp_result bios_parser_get_encoder_cap_info( } /** - * get_encoder_cap_record - * - * @brief - * Get encoder cap record for the object - * - * @param object, ATOM object + * get_encoder_cap_record - Get encoder cap record for the object * - * @return atom encoder cap record - * - * @note - * search all records to find the ATOM_ENCODER_CAP_RECORD_V2 record + * @bp: pointer to the BIOS parser + * @object: ATOM object + * return: atom encoder cap record + * note: search all records to find the ATOM_ENCODER_CAP_RECORD_V2 record */ static ATOM_ENCODER_CAP_RECORD_V2 *get_encoder_cap_record( struct bios_parser *bp, @@ -1557,8 +1552,9 @@ static uint32_t get_ss_entry_number_from_ss_info_tbl( * Get Number of SpreadSpectrum Entry from the ASIC_InternalSS_Info table from * the VBIOS that match the SSid (to be converted from signal) * - * @param[in] signal, ASSignalType to be converted to SSid - * @return number of SS Entry that match the signal + * @dcb: pointer to the DC BIOS + * @signal: ASSignalType to be converted to SSid + * return: number of SS Entry that match the signal */ static uint32_t bios_parser_get_ss_entry_number( struct dc_bios *dcb, @@ -1608,10 +1604,10 @@ static uint32_t bios_parser_get_ss_entry_number( * get_ss_entry_number_from_ss_info_tbl * Get Number of spread spectrum entry from the SS_Info table from the VBIOS. * - * @note There can only be one entry for each id for SS_Info Table - * - * @param [in] id, spread spectrum id - * @return number of SS Entry that match the id + * @bp: pointer to the BIOS parser + * @id: spread spectrum id + * return: number of SS Entry that match the id + * note: There can only be one entry for each id for SS_Info Table */ static uint32_t get_ss_entry_number_from_ss_info_tbl( struct bios_parser *bp, @@ -1679,8 +1675,9 @@ static uint32_t get_ss_entry_number_from_ss_info_tbl( * There can not be more than 1 entry for ASIC_InternalSS_Info Ver 2.1 or * SS_Info. * - * @param id, spread sprectrum info index - * @return Bios parser result code + * @bp: pointer to the BIOS parser + * @id: spread sprectrum info index + * return: Bios parser result code */ static uint32_t get_ss_entry_number(struct bios_parser *bp, uint32_t id) { @@ -1696,8 +1693,9 @@ static uint32_t get_ss_entry_number(struct bios_parser *bp, uint32_t id) * Ver 2.1 from the VBIOS * There will not be multiple entry for Ver 2.1 * - * @param id, spread sprectrum info index - * @return number of SS Entry that match the id + * @bp: pointer to the BIOS parser + * @id: spread sprectrum info index + * return: number of SS Entry that match the id */ static uint32_t get_ss_entry_number_from_internal_ss_info_tbl_v2_1( struct bios_parser *bp, @@ -1731,8 +1729,9 @@ static uint32_t get_ss_entry_number_from_internal_ss_info_tbl_v2_1( * Get Number of SpreadSpectrum Entry from the ASIC_InternalSS_Info table of * the VBIOS that matches id * - * @param[in] id, spread sprectrum id - * @return number of SS Entry that match the id + * @bp: pointer to the BIOS parser + * @id: spread sprectrum id + * return: number of SS Entry that match the id */ static uint32_t get_ss_entry_number_from_internal_ss_info_tbl_V3_1( struct bios_parser *bp, @@ -1767,10 +1766,11 @@ static uint32_t get_ss_entry_number_from_internal_ss_info_tbl_V3_1( * bios_parser_get_gpio_pin_info * Get GpioPin information of input gpio id * - * @param gpio_id, GPIO ID - * @param info, GpioPin information structure - * @return Bios parser result code - * @note + * @dcb: pointer to the DC BIOS + * @gpio_id: GPIO ID + * @info: GpioPin information structure + * return: Bios parser result code + * note: * to get the GPIO PIN INFO, we need: * 1. get the GPIO_ID from other object table, see GetHPDInfo() * 2. in DATA_TABLE.GPIO_Pin_LUT, search all records, to get the registerA @@ -2197,13 +2197,10 @@ static uint32_t get_support_mask_for_device_id(struct device_id device_id) } /** - * bios_parser_set_scratch_critical_state - * - * @brief - * update critical state bit in VBIOS scratch register - * - * @param - * bool - to set or reset state + * bios_parser_set_scratch_critical_state - update critical state + * bit in VBIOS scratch register + * @dcb: pointer to the DC BIOS + * @state: set or reset state */ static void bios_parser_set_scratch_critical_state( struct dc_bios *dcb, @@ -2222,7 +2219,7 @@ static void bios_parser_set_scratch_critical_state( * bios_parser *bp - [in]BIOS parser handler to get master data table * integrated_info *info - [out] store and output integrated info * - * @return + * return: * enum bp_result - BP_RESULT_OK if information is available, * BP_RESULT_BADBIOSTABLE otherwise. */ @@ -2372,7 +2369,7 @@ static enum bp_result get_integrated_info_v8( * bios_parser *bp - [in]BIOS parser handler to get master data table * integrated_info *info - [out] store and output integrated info * - * @return + * return: * enum bp_result - BP_RESULT_OK if information is available, * BP_RESULT_BADBIOSTABLE otherwise. */ @@ -2509,7 +2506,7 @@ static enum bp_result get_integrated_info_v9( * bios_parser *bp - [in]BIOS parser handler to get master data table * integrated_info *info - [out] store and output integrated info * - * @return + * return: * enum bp_result - BP_RESULT_OK if information is available, * BP_RESULT_BADBIOSTABLE otherwise. */ From patchwork Fri Jan 8 20:14:36 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 359045 Delivered-To: patch@linaro.org Received: by 2002:a02:85a7:0:0:0:0:0 with SMTP id d36csp855812jai; Fri, 8 Jan 2021 12:15:41 -0800 (PST) X-Google-Smtp-Source: ABdhPJz993avX+aMSFmqip5xkPtQMyBkyol17DnG7zZjvGiKd7V5OR8nhdXTwtsLPEZtym9FqQmm X-Received: by 2002:a63:205a:: with SMTP id r26mr8719306pgm.197.1610136941745; Fri, 08 Jan 2021 12:15:41 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1610136941; cv=none; d=google.com; s=arc-20160816; b=YXqxMOL+SQBbDKMfMgSx2zJVi5P1SjoAGHwkINnfz7Svd/qUxttuAi2vvbI6LqRAlg bdpAn9YZqVqkBBz4RgRBf503I3KMuR4vWaDATPAoHoCQAaO4/pfEn4V9xEkzrKw7r7De IW4Isp7IkUGcKrM4FeblV7w/tCIagIsDkmkOwh2F8c8Znr+auRWFXW5lanMte+TgUCxA R0iZaCU8soXexMmDN5IhlI4KOTCvJlJVeolty7C1BM7pky/1gr8tvUEk7DJJVL+Is53/ 8zr80SNndQnPv3nr++1i0gU5yhwpyCirz/cROXfmuoTKPRKI0k7wkQaUr2YDuLf9gOMq b8sQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:cc:list-subscribe :list-help:list-post:list-archive:list-unsubscribe:list-id :precedence:mime-version:references:in-reply-to:message-id:date :subject:to:from:dkim-signature:delivered-to; bh=8mPxauD3EBom/q9CcHgpBEp6LX9Sq7Ynwlaq3jfInyE=; b=cg0PhWG3Ra4Fm13Vl2nQZfpTO7/KhA6+hPHOTx2dQYAaWG0Tcj8m1evv1s9InF8i4s THz5sS16Vntf11hTXvFlgmvxBCuDQPRZZw993OZ9c69zMtqJJPHThFyK5u+NyDS2uy5X CeCV0ImqG5hhX42Y876NT6fnFSkClfvYjNkNWT0jEKUYVbygg5J2qPpyONuDm8RYzvyQ eC6PXyRo4lYPSdaz13HsyUVPo9vRr9+7U0NELn1l6pBbEdM+Chg/fCrcrXAAl3l57xMs JLj0EmoKew8pufQA/BsZNbzIhOg+wOysfkXVkZXLODDqSY9bMRoFikOB8KWyNVLcSzHw pidA== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=DtMvMixh; spf=pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 2610:10:20:722:a800:ff:fe36:1795 as permitted sender) smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from gabe.freedesktop.org (gabe.freedesktop.org. [2610:10:20:722:a800:ff:fe36:1795]) by mx.google.com with ESMTPS id f11si10380053pjj.17.2021.01.08.12.15.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 08 Jan 2021 12:15:41 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 2610:10:20:722:a800:ff:fe36:1795 as permitted sender) client-ip=2610:10:20:722:a800:ff:fe36:1795; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=DtMvMixh; spf=pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 2610:10:20:722:a800:ff:fe36:1795 as permitted sender) smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 8B4156E8D8; Fri, 8 Jan 2021 20:15:37 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mail-wr1-x431.google.com (mail-wr1-x431.google.com [IPv6:2a00:1450:4864:20::431]) by gabe.freedesktop.org (Postfix) with ESMTPS id C3A8D6E8CE for ; Fri, 8 Jan 2021 20:15:33 +0000 (UTC) Received: by mail-wr1-x431.google.com with SMTP id d13so10097302wrc.13 for ; Fri, 08 Jan 2021 12:15:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=3AW/x7qxQXiLCGUIcY4DJLhUKMXcrKT9KQcLhFyNk1w=; b=DtMvMixhiP2jW+geu9bD4kDHGmsl5fl9Ja2iKoo/LWSz7Wl951aSjbLSw7RaBTX442 5F1atJsNaPHQOiYyQ5JoAbxAGynP+OLyjIBw/6HjYyZ18ZGwtucTOW04jU/NV80E5MZC +Md0dnOHAWBBWc8NefwjYCKd1nN5gcIgzNwFcAf0yKfQMO2DFkx0n7Lu2dVB+nkuyXMB 1jK7/AZdcvFiBBMlUUAYoQyJ29i2/apa8PfE2CdkSUDxkV9hBzOzr+rCJ1TQbuasdFnf NDDwcxDGe/vPoVSHlox8EURoSw2ntqNRkPsfJVL8IGlGr9+QzLY4xZtjqiMm4bFAN+4m p+4w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=3AW/x7qxQXiLCGUIcY4DJLhUKMXcrKT9KQcLhFyNk1w=; b=VuuRGu8IPBZcMUfik9xdMfwSxDKaFGSpf65hZ6VY4Y4PvwVzMt7BYXbpSEI/p5BoZ2 tEI6Ncj4UyevwVQ7iER4xj1gEFft2gGgnH/EUkYmQZ0pAZejpyXdAwb0IruphebAEPsO 1TiFC0QyKR4I1WUhCQ7nOJqCbHR+FIbXtEdK2IvWJsiIbjmH7rdOxMaxFwCv0otPy0Kr G3//hC2+ZQuIXG7NnHfprXCev4xGG9E4RouGBxgsKC9l7d1jaB5bvu04EEikuSfrwPy+ Bv8mGJNu0Vma91X9cZ4uMD9whoLIYvg9UGE+kwNQ/Hn1YfcHSBLn5Ag+gqAJMB9c+50Q ta7g== X-Gm-Message-State: AOAM532PbAzuqoT6L8AnABAWip1vEnBYaZAuESnoo/eqWfgqLSPI2f7g 0Mpy3UrvwBqv9b1PbQU3OYQ+wQ== X-Received: by 2002:a5d:6106:: with SMTP id v6mr5129705wrt.173.1610136932414; Fri, 08 Jan 2021 12:15:32 -0800 (PST) Received: from dell.default ([91.110.221.229]) by smtp.gmail.com with ESMTPSA id l8sm15598671wrb.73.2021.01.08.12.15.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 08 Jan 2021 12:15:31 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Subject: [PATCH 19/40] drm/amd/display/dc/bios/command_table: Remove unused variable Date: Fri, 8 Jan 2021 20:14:36 +0000 Message-Id: <20210108201457.3078600-20-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210108201457.3078600-1-lee.jones@linaro.org> References: <20210108201457.3078600-1-lee.jones@linaro.org> MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Leo Li , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Qinglang Miao , David Airlie , amd-gfx@lists.freedesktop.org, Alex Deucher , =?utf-8?q?Christian_K=C3=B6?= =?utf-8?q?nig?= Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" None of the surrounding code was removed just in case even a small fraction of it was functional. Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/amd/amdgpu/../display/dc/bios/command_table.c: In function ‘adjust_display_pll_v2’: drivers/gpu/drm/amd/amdgpu/../display/dc/bios/command_table.c:1459:35: warning: variable ‘params’ set but not used [-Wunused-but-set-variable] Cc: Harry Wentland Cc: Leo Li Cc: Alex Deucher Cc: "Christian König" Cc: David Airlie Cc: Daniel Vetter Cc: Qinglang Miao Cc: amd-gfx@lists.freedesktop.org Cc: dri-devel@lists.freedesktop.org Signed-off-by: Lee Jones --- drivers/gpu/drm/amd/display/dc/bios/command_table.c | 12 +++--------- 1 file changed, 3 insertions(+), 9 deletions(-) diff --git a/drivers/gpu/drm/amd/display/dc/bios/command_table.c b/drivers/gpu/drm/amd/display/dc/bios/command_table.c index 070459e3e4070..dd893a1176979 100644 --- a/drivers/gpu/drm/amd/display/dc/bios/command_table.c +++ b/drivers/gpu/drm/amd/display/dc/bios/command_table.c @@ -1456,20 +1456,14 @@ static enum bp_result adjust_display_pll_v2( struct bp_adjust_pixel_clock_parameters *bp_params) { enum bp_result result = BP_RESULT_FAILURE; - ADJUST_DISPLAY_PLL_PS_ALLOCATION params = { 0 }; /* We need to convert from KHz units into 10KHz units and then convert * output pixel clock back 10KHz-->KHz */ uint32_t pixel_clock_10KHz_in = bp_params->pixel_clock / 10; - params.usPixelClock = cpu_to_le16((uint16_t)(pixel_clock_10KHz_in)); - params.ucTransmitterID = - bp->cmd_helper->encoder_id_to_atom( - dal_graphics_object_id_get_encoder_id( - bp_params->encoder_object_id)); - params.ucEncodeMode = - (uint8_t)bp->cmd_helper->encoder_mode_bp_to_atom( - bp_params->signal_type, false); + bp->cmd_helper->encoder_id_to_atom( + dal_graphics_object_id_get_encoder_id(bp_params->encoder_object_id)); + bp->cmd_helper->encoder_mode_bp_to_atom(bp_params->signal_type, false); return result; } From patchwork Fri Jan 8 20:14:37 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 359047 Delivered-To: patch@linaro.org Received: by 2002:a02:85a7:0:0:0:0:0 with SMTP id d36csp855851jai; Fri, 8 Jan 2021 12:15:44 -0800 (PST) X-Google-Smtp-Source: ABdhPJzRRoDkXzvdr4mzoWcE4UxysLbFjeIP/BN4WIecS2dzxpvDJ4YbtRnD4pVq4uzrpuB00H/O X-Received: by 2002:aa7:8b05:0:b029:1aa:122b:4368 with SMTP id f5-20020aa78b050000b02901aa122b4368mr5164373pfd.25.1610136944538; Fri, 08 Jan 2021 12:15:44 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1610136944; cv=none; d=google.com; s=arc-20160816; b=fxW1WYVzV+zpaNyb5U5PqWeW/AmykOx4N9HaS6pPfHQTId3qMJyGY7ji4SLGYjIngt jhoj7RaenlX+sOSr+v7m5p7hTqCxWJ2Yh84mtwuWgJUMHhYE2K9EnOZZiYDVh5hXYGYb z97dS1PCE9sRihGUkLM6xV3oVJb6Gm6fjJVz93966Gb/P9ipD6Gps86h+/6QADVWRBN2 6b0G33knsZEsk0sEQrD50lPZTKzv2H6DcKaa8ARWdB5ErFx0xE2DifCMXQpR7vi3mbUX CoJIMmmFkHQiMCw7jKBt2uGSAcqTP/0caPlvKga1yvf/oGm7kcaHPVIMe1aHwqnAHOzn TvLg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:cc:list-subscribe :list-help:list-post:list-archive:list-unsubscribe:list-id :precedence:mime-version:references:in-reply-to:message-id:date :subject:to:from:dkim-signature:delivered-to; bh=BX5y68iv9tz/w1nsZr3OKWT/XVprBuwVFYJV/hT4M0g=; b=mnJn7ou7K4rhoDDE5z9vuKn1EeMzOnFp7WMHOeOGH07p6zhelosEVbzr8ad7MT1Qsm doBZvG2lqzOqAC4SNvGjyR8PLwRKfXsejFeYKSdGw/2AhwYObmwS5LRIWf1NA+fspF/t fmrJ5PsKdjUZ/VWF1dOrAzVePXq/TMtrscWCzjoqX79xCvAq93aQYM/mnkDkrRAr6N94 P7Qcui3cFjg6ZIowV/vo6HZN1hMVDeEFM6dFUdRSqwLzqac7iwbEw1j3Aphd5Ybjl5lS dmBk5y5ZrBNsngWb9XDXsO19VqzA2rgldLXJZ9jUFEhJ4FmgslDBBmhtTKGmMjZznIZy iZvQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b="SqJbv6z/"; spf=pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 2610:10:20:722:a800:ff:fe36:1795 as permitted sender) smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from gabe.freedesktop.org (gabe.freedesktop.org. [2610:10:20:722:a800:ff:fe36:1795]) by mx.google.com with ESMTPS id 13si10000164pfi.149.2021.01.08.12.15.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 08 Jan 2021 12:15:44 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 2610:10:20:722:a800:ff:fe36:1795 as permitted sender) client-ip=2610:10:20:722:a800:ff:fe36:1795; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b="SqJbv6z/"; spf=pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 2610:10:20:722:a800:ff:fe36:1795 as permitted sender) smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 250526E8CE; Fri, 8 Jan 2021 20:15:37 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mail-wr1-x433.google.com (mail-wr1-x433.google.com [IPv6:2a00:1450:4864:20::433]) by gabe.freedesktop.org (Postfix) with ESMTPS id 2EB256E8D8 for ; Fri, 8 Jan 2021 20:15:35 +0000 (UTC) Received: by mail-wr1-x433.google.com with SMTP id c5so10131203wrp.6 for ; Fri, 08 Jan 2021 12:15:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=5gaclGYPTxeR7WBpYSGtVJvFJoT+8qY5x3DkdzDetH8=; b=SqJbv6z/H/h280tKiGBaUND1On2N5BCO4srcqVAHaTgcNtV7jTozwCRnj4CHVMkOUa hwMmdG80+qYFg7oT+DYhrpWzZ2CifvdrKfhMenuiFXpC0TyuJfb2jTby9FLrOF7E6E9d r4OIe6PSFoLIJvJKD14l8vN2kr3wcW6855SxatxD7IgJmsrcUPMCL3pA/qshHfneN1b2 gqJK74bskfTblQATgZFm7+u6+PvytMZNaEh6y5TrI1If+L63a3PCQeByFRzEunJz/lud DjKVXydiJxhmQDCkT8dz8+SUfLB66A2MrIrPEVIMwREIctYSfOqDT445cHOLpewGSEML 7zOA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=5gaclGYPTxeR7WBpYSGtVJvFJoT+8qY5x3DkdzDetH8=; b=n5q0AR5mtxVHwblm1G+3jN3xhGTUeQN8ZsR2ZPu++0EOYmseZt8zwQ9xUG7gDHkf2j sAyATRTzTuKT526s0DAUhZMQu0vvJEUVyJz1rRHhaXe3JcGGRnkU+nvCujiQmYBkS3hK QT9EtCEU9CmjLNqo7FXfGd7t7PdCOWjiUNrA07INQIgvv50dX3+ziPQhEPs4HuSnqGj6 TincL5WDGr1UsjjKusTBW2ImT/wfK+WoVWMXBL22CN8+lgIgU3Zw/D/K3yTow9YJJJ06 WJPIn8IyNoop+I4512vlLJfmO+iqfYLw2NtkD07kNj6AWanGLVFHEdA7kddG+Ga9pV+h 1WoA== X-Gm-Message-State: AOAM533V86lyE26RRs4tnz+J4yXP/Je9daxgVBR/7yLD/pM0jCQXdhOn SeBUyfNz9qQVd9sltS+fXb3ljQ== X-Received: by 2002:adf:e512:: with SMTP id j18mr5227504wrm.52.1610136933894; Fri, 08 Jan 2021 12:15:33 -0800 (PST) Received: from dell.default ([91.110.221.229]) by smtp.gmail.com with ESMTPSA id l8sm15598671wrb.73.2021.01.08.12.15.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 08 Jan 2021 12:15:33 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Subject: [PATCH 20/40] include: drm: drm_atomic: Make use of 'new_plane_state' Date: Fri, 8 Jan 2021 20:14:37 +0000 Message-Id: <20210108201457.3078600-21-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210108201457.3078600-1-lee.jones@linaro.org> References: <20210108201457.3078600-1-lee.jones@linaro.org> MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: David Airlie , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Thomas Zimmermann Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" In the macro for_each_oldnew_plane_in_state() 'new_plane_state' is provided as a container for state->planes[i].new_state, but is not utilised in some use-cases, so we fake-use it instead. Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm.c: In function ‘amdgpu_dm_commit_cursors’: drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm.c:7649:44: warning: variable ‘new_plane_state’ set but not used [-Wunused-but-set-variable] Cc: Maarten Lankhorst Cc: Maxime Ripard Cc: Thomas Zimmermann Cc: David Airlie Cc: Daniel Vetter Cc: Rob Clark Cc: dri-devel@lists.freedesktop.org Signed-off-by: Lee Jones --- include/drm/drm_atomic.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/include/drm/drm_atomic.h b/include/drm/drm_atomic.h index 54e051a957dfc..866daba4c4a55 100644 --- a/include/drm/drm_atomic.h +++ b/include/drm/drm_atomic.h @@ -847,7 +847,8 @@ void drm_state_dump(struct drm_device *dev, struct drm_printer *p); ((plane) = (__state)->planes[__i].ptr, \ (void)(plane) /* Only to avoid unused-but-set-variable warning */, \ (old_plane_state) = (__state)->planes[__i].old_state,\ - (new_plane_state) = (__state)->planes[__i].new_state, 1)) + (new_plane_state) = (__state)->planes[__i].new_state, \ + (void)(new_plane_state) /* Only to avoid unused-but-set-variable warning */, 1)) /** * for_each_oldnew_plane_in_state_reverse - iterate over all planes in an atomic From patchwork Fri Jan 8 20:14:38 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 359046 Delivered-To: patch@linaro.org Received: by 2002:a02:85a7:0:0:0:0:0 with SMTP id d36csp855834jai; Fri, 8 Jan 2021 12:15:43 -0800 (PST) X-Google-Smtp-Source: ABdhPJzlWTMi+ctab0TFcVpJrVebyqOuNyDGoYGK6aI7BXjlmaFmqVGd7ATlcDYfqwSjaxHu6erI X-Received: by 2002:aa7:8d98:0:b029:1a5:929c:1bb2 with SMTP id i24-20020aa78d980000b02901a5929c1bb2mr5396628pfr.4.1610136943120; Fri, 08 Jan 2021 12:15:43 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1610136943; cv=none; d=google.com; s=arc-20160816; b=QWW8E2hQxVQ7YxW9sQDSoFLiyGdhpX1T7eq5ZtEjKy0+4PkoMDtC3oQWrZtBEca3XM JowfTULqJks4v7WIZ60zhhcQufMQWQ5Lo2TvgqQC2czkj7vfdC3lmkSFTI4J/NK9hgui PkxRHc5KhZXxWRfuePT7lXxxf3a0cPBVITwTAYpmJ7yv7IWI1WBDGOKYqis4TxzB+WzU ZpF6B02pXPd1SoLu+0jIYyt9DbWjPHd8+FfRmRB/iheL65wRbsI85DmCrKg81jSdU2c0 LKLPkt0q7c5tw0jKfZVv9rwdl0SMA0P7j1bUvAhImrPODrNO6e7Hbxh4Ts3pXgO+DQKL LH2Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:cc:list-subscribe :list-help:list-post:list-archive:list-unsubscribe:list-id :precedence:mime-version:references:in-reply-to:message-id:date :subject:to:from:dkim-signature:delivered-to; bh=HU6YfES3kzl1vKeUtIUALZOPjL093cd51BUGU+iZ1T0=; b=wI0fzPy1Avi0q4kgxJIIleTw1oCpqZ+ZFIVWrI2f5w20kcPvei6lLBt8E2rXlSudXD GJ3UA/yjAa1/evyCAw0jl5sNqv/Uqi5/MXKyx8Uv95QaJ7MmGgiJ2I5tN1kskiwlhEyQ ltNnDsfQ29IPdkexJO+cI6SM6KbqwPdfy8JpmOLq49m973ZQYvGQn4/q1EgYlRCRrgN0 TKPsuL5zU9dl4GlWniqjkPLmwryf6y+YmcTYHj7Pn8N9KNo+o+W2oYvxgg0Kl5sfJnLc 7I+OrlnZy1BaHzJg8gDWOUuUblgNy7IsgtCdX0v9JckXIadDD31U9mTtJFOebvkVjW3W zAZQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=ojEBT5Rs; spf=pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 2610:10:20:722:a800:ff:fe36:1795 as permitted sender) smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from gabe.freedesktop.org (gabe.freedesktop.org. [2610:10:20:722:a800:ff:fe36:1795]) by mx.google.com with ESMTPS id j24si10131470pll.116.2021.01.08.12.15.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 08 Jan 2021 12:15:43 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 2610:10:20:722:a800:ff:fe36:1795 as permitted sender) client-ip=2610:10:20:722:a800:ff:fe36:1795; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=ojEBT5Rs; spf=pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 2610:10:20:722:a800:ff:fe36:1795 as permitted sender) smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 02DBF6E8DE; Fri, 8 Jan 2021 20:15:38 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mail-wr1-x42d.google.com (mail-wr1-x42d.google.com [IPv6:2a00:1450:4864:20::42d]) by gabe.freedesktop.org (Postfix) with ESMTPS id B6D4B6E8CE for ; Fri, 8 Jan 2021 20:15:36 +0000 (UTC) Received: by mail-wr1-x42d.google.com with SMTP id m5so10133440wrx.9 for ; Fri, 08 Jan 2021 12:15:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=/no+Onyy5XrK9PB3hyGhFGC7i5BsGoibiINOqxq12AQ=; b=ojEBT5RsN2ItOnq+5hnf27mTpPMgt5HIEpJPbKe+3Zbl9lekg8pVMBTuRv540cHs4Q Tb786eVXAWGOwbyelL9uKyuNmGa2SyOXXZFPpId6DC9pDz0zEMopFAyEsoGH9Ko0N6/b Ub3sMjADxRs1gr0OfoAQdrQrlnoMCYbktSRB6O+/21I/8I2BC9Veblt10uMGncXyY+No Utiitfn6+E8oKxjbI2NCxpWw2s3r7b48u/BQRDA47oZtG8HDS+NQlWzlrgr1yJQi3VA2 PmwuWx0kJpmQT4Rrwft9zA9na/2WeMHyt4gmXpnyipPfAYTPgrVoNsLJRxgqx71P8V8a 8isg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=/no+Onyy5XrK9PB3hyGhFGC7i5BsGoibiINOqxq12AQ=; b=Jhfiub6rCzc/CLEbVL/lqzJ/X6DcUh2CGJnMAjdGo2WKK32zx5a6VMXjQOKjRJs3+n fQmavqWC4uvoJ1el4XxXz1jAsJyx11GklmGmA1oI1mgUbHVgqryuax5BwF37VuCF+9uY 2pOeP8Qv//8SMRStCH62/T4wCb1oQqtC1gZngY7Jqfy6asSf3VG7qBktWJwQnkgIHXCH IjbLtRrj7FWkWXBpNvlgDe0PhA+PhlLsBVVpsm4px9eqG2+TVaqAg3n3AJyXLveMFUWU K+b5TtJvwPdhqTTyj0GZNxPulxBlopRUaTZomMEqygkUjoWPvF/XxMqBl+QuCLKT6Dw7 Qxgw== X-Gm-Message-State: AOAM532GOLzMovbzadE3VZNMtUIUWfjCmZzAqkOLc4lLLI3GaOnbCXg5 FIfyx4jvPVa2r7XcsWPw7/Tr2w== X-Received: by 2002:a5d:44c6:: with SMTP id z6mr5259451wrr.306.1610136935433; Fri, 08 Jan 2021 12:15:35 -0800 (PST) Received: from dell.default ([91.110.221.229]) by smtp.gmail.com with ESMTPSA id l8sm15598671wrb.73.2021.01.08.12.15.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 08 Jan 2021 12:15:34 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Subject: [PATCH 21/40] drm/amd/display/dc/calcs/dce_calcs: Remove unused variables 'v_filter_init_mode' and 'sclk_lvl' Date: Fri, 8 Jan 2021 20:14:38 +0000 Message-Id: <20210108201457.3078600-22-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210108201457.3078600-1-lee.jones@linaro.org> References: <20210108201457.3078600-1-lee.jones@linaro.org> MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Leo Li , linux-kernel@vger.kernel.org, amd-gfx@lists.freedesktop.org, David Airlie , dri-devel@lists.freedesktop.org, Alex Deucher , =?utf-8?q?Christian_K=C3=B6nig?= Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/amd/amdgpu/../display/dc/calcs/dce_calcs.c: In function ‘calculate_bandwidth’: drivers/gpu/drm/amd/amdgpu/../display/dc/calcs/dce_calcs.c:109:18: warning: variable ‘v_filter_init_mode’ set but not used [-Wunused-but-set-variable] drivers/gpu/drm/amd/amdgpu/../display/dc/calcs/dce_calcs.c: In function ‘bw_calcs’: drivers/gpu/drm/amd/amdgpu/../display/dc/calcs/dce_calcs.c:3031:21: warning: variable ‘sclk_lvl’ set but not used [-Wunused-but-set-variable] Cc: Harry Wentland Cc: Leo Li Cc: Alex Deucher Cc: "Christian König" Cc: David Airlie Cc: Daniel Vetter Cc: amd-gfx@lists.freedesktop.org Cc: dri-devel@lists.freedesktop.org Signed-off-by: Lee Jones --- drivers/gpu/drm/amd/display/dc/calcs/dce_calcs.c | 8 +------- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/drivers/gpu/drm/amd/display/dc/calcs/dce_calcs.c b/drivers/gpu/drm/amd/display/dc/calcs/dce_calcs.c index ef41b287cbe23..158d927c03e55 100644 --- a/drivers/gpu/drm/amd/display/dc/calcs/dce_calcs.c +++ b/drivers/gpu/drm/amd/display/dc/calcs/dce_calcs.c @@ -106,7 +106,6 @@ static void calculate_bandwidth( bool lpt_enabled; enum bw_defines sclk_message; enum bw_defines yclk_message; - enum bw_defines v_filter_init_mode[maximum_number_of_surfaces]; enum bw_defines tiling_mode[maximum_number_of_surfaces]; enum bw_defines surface_type[maximum_number_of_surfaces]; enum bw_defines voltage; @@ -792,12 +791,8 @@ static void calculate_bandwidth( data->v_filter_init[i] = bw_add(data->v_filter_init[i], bw_int_to_fixed(1)); } if (data->stereo_mode[i] == bw_def_top_bottom) { - v_filter_init_mode[i] = bw_def_manual; data->v_filter_init[i] = bw_min2(data->v_filter_init[i], bw_int_to_fixed(4)); } - else { - v_filter_init_mode[i] = bw_def_auto; - } if (data->stereo_mode[i] == bw_def_top_bottom) { data->num_lines_at_frame_start = bw_int_to_fixed(1); } @@ -3028,7 +3023,7 @@ bool bw_calcs(struct dc_context *ctx, calcs_output->all_displays_in_sync = false; if (data->number_of_displays != 0) { - uint8_t yclk_lvl, sclk_lvl; + uint8_t yclk_lvl; struct bw_fixed high_sclk = vbios->high_sclk; struct bw_fixed mid1_sclk = vbios->mid1_sclk; struct bw_fixed mid2_sclk = vbios->mid2_sclk; @@ -3049,7 +3044,6 @@ bool bw_calcs(struct dc_context *ctx, calculate_bandwidth(dceip, vbios, data); yclk_lvl = data->y_clk_level; - sclk_lvl = data->sclk_level; calcs_output->nbp_state_change_enable = data->nbp_state_change_enable; From patchwork Fri Jan 8 20:14:39 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 359048 Delivered-To: patch@linaro.org Received: by 2002:a02:85a7:0:0:0:0:0 with SMTP id d36csp855865jai; Fri, 8 Jan 2021 12:15:45 -0800 (PST) X-Google-Smtp-Source: ABdhPJzRtu8nC2hncYkIVNlCv3SG+Gww445gSGKJDF88osi05F4UQ1JXuHQiomm+jmStYqvXZ8A1 X-Received: by 2002:a63:f21:: with SMTP id e33mr8904543pgl.84.1610136945688; Fri, 08 Jan 2021 12:15:45 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1610136945; cv=none; d=google.com; s=arc-20160816; b=quE/anbqxRh2oBgpySbfwJr3VI++QdQloESlYfyH8+9FWdRO7QF/QaCoqR22bUKQ1z aV2PYaPQt6J6xP0o8GCWMFX8fhcHjWH2M0MqxWkVgZElapvrO91YvQc+26NKpokxniwE 0IHwvdNKmvezTWw/+UetUd4R3T8w3hqX0V+faDePmsVUmdf007u9ELhGUae/xxjQPuLg 0Ej8lO4lCcyX3c6Ua3FxmjoPQhWpyuC9LsQq4QXDItxtagib0vZl6/OOFClq34adBRG4 FeHQYTNHILwDZT2ggJDd7j2bhj2W+z2ae8CocQG5/vr7G8LlmFH/fdbykoqH2pVYmdQV 1tLA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:cc:list-subscribe :list-help:list-post:list-archive:list-unsubscribe:list-id :precedence:mime-version:references:in-reply-to:message-id:date :subject:to:from:dkim-signature:delivered-to; bh=OCaodT+Hf0JO5ZQAl9poNXR2UglbXeWQTG5ZtIBTcBU=; b=ddrGEL1jTiSGHz/ie7PDCg+llaQOTsCQwbu3fUOMdzjr5UzhOBfnpthlPDqNeMSuLX rZiQ3ok2jIZEaDjexhlnR4OZep0Qq3KuYJMq3dpT/nWNAdy73I3u3eV+LIiHF/d4NWoh zaJScpmDb2PwQlvLuBnLWQQ6qpFvA+T328VE/xj+j0NqttG/mwDsrSbhYdOS0ycomfkj 9mG8fTdvpvkJ9iL2qkpzlf2C+w8XoZ3DS3NCOolzQoLMCcPope1My1SpjJUGgaqUMn2q GUTUtsQON1/vm/8sR0wL7JPk4l20dRErxhORVTU5/H3KCkqc2fc9KVernNFMbs+Mf6KB pH1A== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=l0LVv8Yv; spf=pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 131.252.210.177 as permitted sender) smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from gabe.freedesktop.org (gabe.freedesktop.org. [131.252.210.177]) by mx.google.com with ESMTPS id w16si10072104pfi.219.2021.01.08.12.15.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 08 Jan 2021 12:15:45 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 131.252.210.177 as permitted sender) client-ip=131.252.210.177; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=l0LVv8Yv; spf=pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 131.252.210.177 as permitted sender) smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id D6DA56E8DB; Fri, 8 Jan 2021 20:15:40 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mail-wm1-x32e.google.com (mail-wm1-x32e.google.com [IPv6:2a00:1450:4864:20::32e]) by gabe.freedesktop.org (Postfix) with ESMTPS id E98C06E8DB for ; Fri, 8 Jan 2021 20:15:37 +0000 (UTC) Received: by mail-wm1-x32e.google.com with SMTP id q75so9454166wme.2 for ; Fri, 08 Jan 2021 12:15:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=R1cIGcueVpiwKXCsXAGeLOrVeaRuSdzc2IFkwmNetFo=; b=l0LVv8Yv2qqohE+nDbzioDjwD7IumU3x0mYo0uB5VLZL4cfV3nC1+PdifOuff89qz3 WBcqrZJc0UxjoiglM15XpESfKjFG9UtPvNDMIoflEAsBeMJibYgpd4gebN/tASO3ncme 9zY3Wwt3gC6Lss/3zX/gE1z6x3mvKqC/W5ebaBBbSiRJ0LahhPvFcxkb1gj2xAfeQ5xa lon5sbPe+45qR9l6juUzf/JmQ/aOJyAidvclSUOZtTTxnZi5Wu3locXDnSeq+R4XWUbP Mru96URrGOFc3ri9j7RrGYKAvUcGQAvyWv9m9ciIxq+jCERzMETtgm5KddxjOnIb6WGb QEsQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=R1cIGcueVpiwKXCsXAGeLOrVeaRuSdzc2IFkwmNetFo=; b=GGAGoQv5rXDFekNqQrNkv3mZoYrkxkkcVkql8sPbeGwAftSmBiuJQLWNgTRnRU2Izp 88LE5P/ZYf7KQzBz0+FiePl0fVUBu2ZtSspRNjF6E6wsBjw5VLyaQDGun2sGWdUtMhfv PjHvnFx7oxbdw1RTJQQzPVNE/AUPK28Od418gK7GPSV9U45nHHY1xfAT9EW/JHaJpJ0M osU3pNemjeFk3iPlD8g5ONs4uvDzz0nM7y4n1KEcBm1gAyinlZbSFETUc+0Fb9nfGrlL X/0tFtJ2WenM1VuaffH8thhEURsatYHwgM/jPzN8P9WCVyHtllbOb8ZrZ/u+IQvbNqMx 2vww== X-Gm-Message-State: AOAM531z5FJ+8dcfAZop+iet+tGg3uXk9Oi4sjoAZsvTnXHLU3VVvNwf nM1n27Annch5UD5efRLaWWUnug== X-Received: by 2002:a1c:c308:: with SMTP id t8mr4595425wmf.22.1610136936655; Fri, 08 Jan 2021 12:15:36 -0800 (PST) Received: from dell.default ([91.110.221.229]) by smtp.gmail.com with ESMTPSA id l8sm15598671wrb.73.2021.01.08.12.15.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 08 Jan 2021 12:15:36 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Subject: [PATCH 22/40] drm/amd/display/dc/bios/bios_parser2: Fix some formatting issues and missing parameter docs Date: Fri, 8 Jan 2021 20:14:39 +0000 Message-Id: <20210108201457.3078600-23-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210108201457.3078600-1-lee.jones@linaro.org> References: <20210108201457.3078600-1-lee.jones@linaro.org> MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Leo Li , linux-kernel@vger.kernel.org, amd-gfx@lists.freedesktop.org, David Airlie , dri-devel@lists.freedesktop.org, Alex Deucher , =?utf-8?q?Christian_K=C3=B6nig?= Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/amd/amdgpu/../display/dc/bios/bios_parser2.c:501: warning: Function parameter or member 'dcb' not described in 'bios_parser_get_gpio_pin_info' drivers/gpu/drm/amd/amdgpu/../display/dc/bios/bios_parser2.c:501: warning: Function parameter or member 'gpio_id' not described in 'bios_parser_get_gpio_pin_info' drivers/gpu/drm/amd/amdgpu/../display/dc/bios/bios_parser2.c:501: warning: Function parameter or member 'info' not described in 'bios_parser_get_gpio_pin_info' drivers/gpu/drm/amd/amdgpu/../display/dc/bios/bios_parser2.c:815: warning: Function parameter or member 'dcb' not described in 'bios_parser_get_spread_spectrum_info' drivers/gpu/drm/amd/amdgpu/../display/dc/bios/bios_parser2.c:815: warning: Function parameter or member 'signal' not described in 'bios_parser_get_spread_spectrum_info' drivers/gpu/drm/amd/amdgpu/../display/dc/bios/bios_parser2.c:815: warning: Function parameter or member 'index' not described in 'bios_parser_get_spread_spectrum_info' drivers/gpu/drm/amd/amdgpu/../display/dc/bios/bios_parser2.c:815: warning: Function parameter or member 'ss_info' not described in 'bios_parser_get_spread_spectrum_info' drivers/gpu/drm/amd/amdgpu/../display/dc/bios/bios_parser2.c:1210: warning: Function parameter or member 'dcb' not described in 'bios_parser_set_scratch_critical_state' drivers/gpu/drm/amd/amdgpu/../display/dc/bios/bios_parser2.c:1210: warning: Function parameter or member 'state' not described in 'bios_parser_set_scratch_critical_state' Cc: Harry Wentland Cc: Leo Li Cc: Alex Deucher Cc: "Christian König" Cc: David Airlie Cc: Daniel Vetter Cc: amd-gfx@lists.freedesktop.org Cc: dri-devel@lists.freedesktop.org Signed-off-by: Lee Jones --- .../drm/amd/display/dc/bios/bios_parser2.c | 29 +++++++++---------- 1 file changed, 14 insertions(+), 15 deletions(-) diff --git a/drivers/gpu/drm/amd/display/dc/bios/bios_parser2.c b/drivers/gpu/drm/amd/display/dc/bios/bios_parser2.c index 670c265838178..9f9fda3118d1f 100644 --- a/drivers/gpu/drm/amd/display/dc/bios/bios_parser2.c +++ b/drivers/gpu/drm/amd/display/dc/bios/bios_parser2.c @@ -485,10 +485,11 @@ static struct atom_hpd_int_record *get_hpd_record( * bios_parser_get_gpio_pin_info * Get GpioPin information of input gpio id * - * @param gpio_id, GPIO ID - * @param info, GpioPin information structure - * @return Bios parser result code - * @note + * @dcb: pointer to the DC BIOS + * @gpio_id: GPIO ID + * @info: GpioPin information structure + * return: Bios parser result code + * note: * to get the GPIO PIN INFO, we need: * 1. get the GPIO_ID from other object table, see GetHPDInfo() * 2. in DATA_TABLE.GPIO_Pin_LUT, search all records, @@ -801,11 +802,11 @@ static enum bp_result get_ss_info_v4_2( * ver 3.1, * there is only one entry for each signal /ss id. However, there is * no planning of supporting multiple spread Sprectum entry for EverGreen - * @param [in] this - * @param [in] signal, ASSignalType to be converted to info index - * @param [in] index, number of entries that match the converted info index - * @param [out] ss_info, sprectrum information structure, - * @return Bios parser result code + * @dcb: pointer to the DC BIOS + * @signal: ASSignalType to be converted to info index + * @index: number of entries that match the converted info index + * @ss_info: sprectrum information structure, + * return: Bios parser result code */ static enum bp_result bios_parser_get_spread_spectrum_info( struct dc_bios *dcb, @@ -1196,13 +1197,11 @@ static bool bios_parser_is_accelerated_mode( } /** - * bios_parser_set_scratch_critical_state + * bios_parser_set_scratch_critical_state - update critical state bit + * in VBIOS scratch register * - * @brief - * update critical state bit in VBIOS scratch register - * - * @param - * bool - to set or reset state + * @dcb: pointer to the DC BIO + * @state: set or reset state */ static void bios_parser_set_scratch_critical_state( struct dc_bios *dcb, From patchwork Fri Jan 8 20:14:40 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 359050 Delivered-To: patch@linaro.org Received: by 2002:a02:85a7:0:0:0:0:0 with SMTP id d36csp855894jai; Fri, 8 Jan 2021 12:15:48 -0800 (PST) X-Google-Smtp-Source: ABdhPJwAO9gyKPXeMXYmt0+r23pf/R3yW9EJaOHHZY7vJWtnrCf5PKu1OcDEo9RFHvWO3jyQwPHI X-Received: by 2002:a17:90a:b010:: with SMTP id x16mr5456237pjq.74.1610136948274; Fri, 08 Jan 2021 12:15:48 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1610136948; cv=none; d=google.com; s=arc-20160816; b=pjoMAo1KmKvcOkcpEJ1eqW169RZBjNce+gHE0HhXch8B/7hMIeSXK8aW1cXRT+bFPe UYFKn6zXiHRxWAUcMYYoUajcBA/7uErysT528jE4B/dBc7+6A6G62ZlNJtfiBLhvIolA ZEKHKiYdUP/PYGNwTz3l65lZv0EUkWamiDj/S5FJADmDoGtsQt9b/58qaKvbVpYa+gEF 0dls9PkAUG9l+Cs/y4/qLPCu/zGhfNEDpXSiWAqnfWoA0xWo1Ga+9/KrNy2e5h534pFe 6+W8kAOLSIiu02zuM0IPGpsbVlN+Pb/YDN5/hP2TkHLJQl0w7fSsiGdgk/2VTaiNnF3Q BQWA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:cc:list-subscribe :list-help:list-post:list-archive:list-unsubscribe:list-id :precedence:mime-version:references:in-reply-to:message-id:date :subject:to:from:dkim-signature:delivered-to; bh=QmSuu+sVDHvVzQ8t6JTrvtuWCq+rFrnDrsz3M4+CRUA=; b=A+hJR4XX2SmV+ra7Kc/qL/zNda/OFIjlKMhGkscIK61D46L5Vu64LwoSpsO3eCLfk/ 4xLPM3OPgKtF5G4DcUibRc2QpFKxPeMbd4P9EyDfpasdf8ZPiNfFf7cY+uyhoP6rZezu PGxDOWwO4HKbiXhP1vUMCTYPeTXppbLf8U2J56Me815+U2piDyE/FbvhHOrjVhZU5Kuz tQrZj675Y8u9AMUBqOXX4Zyloj857KjitEyK2KqjQQOPDZO0E6hCz/rEEAhsoD/9FOc8 jkU1uS9KzJXlBV81Ml8PzrdDVoVnB4sgGjXrk2VrzL5oHaH+eKeoDiG3D/I171/g//8E 9T/A== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=hEJFVXCV; spf=pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 2610:10:20:722:a800:ff:fe36:1795 as permitted sender) smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from gabe.freedesktop.org (gabe.freedesktop.org. [2610:10:20:722:a800:ff:fe36:1795]) by mx.google.com with ESMTPS id c10si9967356pfi.143.2021.01.08.12.15.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 08 Jan 2021 12:15:48 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 2610:10:20:722:a800:ff:fe36:1795 as permitted sender) client-ip=2610:10:20:722:a800:ff:fe36:1795; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=hEJFVXCV; spf=pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 2610:10:20:722:a800:ff:fe36:1795 as permitted sender) smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 4E26E6E8E5; Fri, 8 Jan 2021 20:15:43 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mail-wr1-x435.google.com (mail-wr1-x435.google.com [IPv6:2a00:1450:4864:20::435]) by gabe.freedesktop.org (Postfix) with ESMTPS id 9B8F66E8DB for ; Fri, 8 Jan 2021 20:15:39 +0000 (UTC) Received: by mail-wr1-x435.google.com with SMTP id t16so10168842wra.3 for ; Fri, 08 Jan 2021 12:15:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=J9hwKoCUKPkAVEJG7PdvhZlNWecZ9XZq8Q6EZdE3uyc=; b=hEJFVXCVtwgK4Ggr5Yq+CnblBWyx906VjOGVxfnc2I9GwMfjxBlYdIufR3N0PgPmBh XzeWu1y/95DEw+MOBpoPJmeUkjIhV59SsQ5YxzenvG+XvqtqIm9DYK5uwVwZrkNxwvaZ NKLeliZDCZwVeb+sL1YknAuu5Yl58Xur2WNTqAvK9qCl2Ah4T8B89/oNpVFMdiFAjujM 4NYnKhCsW75iuMfCwW+XALsrF5a2GYVf8fileLh0IXeaofih5iiHhDxa4h9uis5rYEc1 yloX+0Z9EgB6LqnVve8JF5u9cDXP/Ol28Ax5Xno8C5kNyHSO2N0AzqVZPpSBsMxQ7sGQ 1YdQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=J9hwKoCUKPkAVEJG7PdvhZlNWecZ9XZq8Q6EZdE3uyc=; b=spEle6EJlbzdDxfGdjqBh6ozArJCUBV2F4WMK4HNtRwXJIQyqoKo47+mRqeFcXEo0d txRrzKxiMdW+7zF36qdd6JmjzZYA7PHSa98dzJ7vOGWShUOahgioMZseKJzXXzvsEuhv nCni4dsmuuTJU1/WviVobQ7Pm9YLth3FwynC/MBUs6M9DmY5KHTgAwlS/GMQpeASqIyu dx+/pYGrBLwnxYAN7JcQIpqa7VQaGK28GomY5cRr8/wpxK/4n/wfi1PjkcZI2Fw8OQgm kV7eMBWTzUgW52333K8VhPNZ1/mUbDxmIh0QCFyFWNXkSQligx9GSmoP/VvPi2QiBPLF AzeQ== X-Gm-Message-State: AOAM53039vvSBgdhcj1YPE19s6wvN5cjCMVLeIgJbl7Sgyqv00g4OVP2 dDLtuEGqGoENf5cqOuGfZAqnXA== X-Received: by 2002:adf:dec7:: with SMTP id i7mr5279212wrn.373.1610136938211; Fri, 08 Jan 2021 12:15:38 -0800 (PST) Received: from dell.default ([91.110.221.229]) by smtp.gmail.com with ESMTPSA id l8sm15598671wrb.73.2021.01.08.12.15.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 08 Jan 2021 12:15:37 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Subject: [PATCH 23/40] drm/amd/display/dc/dce/dce_audio: Make function invoked by reference static Date: Fri, 8 Jan 2021 20:14:40 +0000 Message-Id: <20210108201457.3078600-24-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210108201457.3078600-1-lee.jones@linaro.org> References: <20210108201457.3078600-1-lee.jones@linaro.org> MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Charlene Liu , Leo Li , Mauro Rossi , linux-kernel@vger.kernel.org, amd-gfx@lists.freedesktop.org, David Airlie , dri-devel@lists.freedesktop.org, Alex Deucher , =?utf-8?q?Christian_K=C3=B6nig?= Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/amd/amdgpu/../display/dc/dce/dce_audio.c:871:6: warning: no previous prototype for ‘dce60_aud_wall_dto_setup’ [-Wmissing-prototypes] Cc: Harry Wentland Cc: Leo Li Cc: Alex Deucher Cc: "Christian König" Cc: David Airlie Cc: Daniel Vetter Cc: Mauro Rossi Cc: Charlene Liu Cc: amd-gfx@lists.freedesktop.org Cc: dri-devel@lists.freedesktop.org Signed-off-by: Lee Jones --- drivers/gpu/drm/amd/display/dc/dce/dce_audio.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/display/dc/dce/dce_audio.c b/drivers/gpu/drm/amd/display/dc/dce/dce_audio.c index 2a2a0fdb92539..7866cf2a668fa 100644 --- a/drivers/gpu/drm/amd/display/dc/dce/dce_audio.c +++ b/drivers/gpu/drm/amd/display/dc/dce/dce_audio.c @@ -868,7 +868,7 @@ void dce_aud_wall_dto_setup( } #if defined(CONFIG_DRM_AMD_DC_SI) -void dce60_aud_wall_dto_setup( +static void dce60_aud_wall_dto_setup( struct audio *audio, enum signal_type signal, const struct audio_crtc_info *crtc_info, From patchwork Fri Jan 8 20:14:41 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 359049 Delivered-To: patch@linaro.org Received: by 2002:a02:85a7:0:0:0:0:0 with SMTP id d36csp855886jai; Fri, 8 Jan 2021 12:15:47 -0800 (PST) X-Google-Smtp-Source: ABdhPJz7vVsZAuM5pz6nspIyEbCmV/xD6TDNJ8aXnFRPRqtFSDAQX/lNSbO7ilU/whjHbt8livW5 X-Received: by 2002:aa7:8d12:0:b029:1ae:4344:3b4f with SMTP id j18-20020aa78d120000b02901ae43443b4fmr5269552pfe.16.1610136947057; Fri, 08 Jan 2021 12:15:47 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1610136947; cv=none; d=google.com; s=arc-20160816; b=WnLgx9poZksOtg1EC39ycSJEFwNJzRHKTOpdFO/3/S7CVUy+pGQ4rF6b+t0ihEy33x 2MXGk+4mOmhhzBdHuUR+K7+NxEQtD451esvzFCc6dNwyGTrAmXhO9SXEKJ1ACx7NtplE AX/IuEYr2p0/qAvkK4CUq12yjJrPiwlOYLJoTlazoG9gyJkrVGapYNpLx3DwG7QayPvN vynpsaPFLchX27LL2b5PdHvhyIP7dh3j2lIPIEUqLTGGNj9etI9U00BNQG9I8UXB3IlN wX9TcNRgG6E7dqm2OAQIbCR3Q+3xBy2n0/ReZRLAY51cWqzxKaZ6Vy8Q8FmhvQeKNT2E UqBQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:cc:list-subscribe :list-help:list-post:list-archive:list-unsubscribe:list-id :precedence:mime-version:references:in-reply-to:message-id:date :subject:to:from:dkim-signature:delivered-to; bh=UwQz7nXCPnpFcgC4u4J5aZ+4VkEFdno9DCB58C9pzSQ=; b=j3RlwZbrgFclqL1V13eH+Pn9Lx9WCmc0n1jQCQ8Li54AL45tquwvuvOtJtkP0yz0Ih sMYIMXL1v0hYTDYeiD0UuBoTS1A3nvkPuPg5lH1zioIuL+oGaqJ2Y1MWl5gb3FbphUBa CBJGgsRg+FrUVd/93soh/KmDsfmj7ULwUWHEhylpyHNPYlacejXYKClD3sIE9PjZfs64 H6BAal8OR/hTabF0iPR93J8PXiE0ZBnGMg+VuSq6LFdPykwfq9pHWtAQunmdG8xfZbCI QKUp7JYmnse/UvzHCQvhO3/B+usX484VvRa8I2yCGQK6OqXdVJ/KhnSXEaDlYX5FAl+C W/yw== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b="oLM/pC+r"; spf=pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 131.252.210.177 as permitted sender) smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from gabe.freedesktop.org (gabe.freedesktop.org. [131.252.210.177]) by mx.google.com with ESMTPS id w191si5303188pfd.105.2021.01.08.12.15.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 08 Jan 2021 12:15:47 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 131.252.210.177 as permitted sender) client-ip=131.252.210.177; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b="oLM/pC+r"; spf=pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 131.252.210.177 as permitted sender) smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 1FEC96E8E1; Fri, 8 Jan 2021 20:15:43 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mail-wr1-x431.google.com (mail-wr1-x431.google.com [IPv6:2a00:1450:4864:20::431]) by gabe.freedesktop.org (Postfix) with ESMTPS id 327916E8E1 for ; Fri, 8 Jan 2021 20:15:41 +0000 (UTC) Received: by mail-wr1-x431.google.com with SMTP id i9so10169355wrc.4 for ; Fri, 08 Jan 2021 12:15:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=B0vgdR8naA6iZCQ4IL55g07H1SHyqDXPDametYwo0Pg=; b=oLM/pC+rSUDP4ZUfp3a6s6i/HWBsHp9Du8iTI2RGZXxY1NVI07AaFBnwpdJlHwG0ri VQWy/Y4lQ4XMyQj7vkEB2ONHZswhsBNlxrWqZDqKyDwMCsD0tvwyuGX5oCvKMYmbJvDb K39uYXCmZbZuRkO4RkxnD88hGmVCmzqPdBvnFKoWaghzSw40LfLtM0F52BlernQZy5A7 0+LUMRcbxP334bSPiCN3m1gjS8U5YoMbdS1BgCd6DO48LnFmd+Q+V4szxYZkFUmqmOix BGN6f5dDtv1T46Dye2RikAAdhcILtMNFQNof7yhedF7tFiwrW4S39SWbEhIwsG5JY1Mu bfog== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=B0vgdR8naA6iZCQ4IL55g07H1SHyqDXPDametYwo0Pg=; b=fvlQ2Vl8ii9W+aS8FNqDtkSANJ4m+BVLUIU8lBIPK+1h4jpbvMfUJ8JiMu0XnlvGV7 6KC/FQI1R/HGAc2sDkvwQOhWrpnvLUhpjHhZJLZW+aKhNiIzsLLfjlP8mZP4yXpgHgGJ 9P5X5p+5zA70wewkSgHUNsGNJqdjSI4w9fnbSNMwCtAWyYsgkvDdf+RlHAkXzF/nhtn1 05ZpCjdCw93+QkF8BdJf02ezGakb9biONIh7CDtp+fqNO9ikBfqXbC45XwHnMb5mcQcE AkBhofE3caEGBcDpwaIOBywiocuymxH00b6r47lFlru3UsP0uhP4qG8327cA/tSY/ZUT mYow== X-Gm-Message-State: AOAM530w80myiQF9Q3a+RWxnPXXqk3ZJWZlYtG1GnU4yvOJboIVJFPe/ MnYLKgi56tLouYoHxfEFXwoZKQ== X-Received: by 2002:a5d:6751:: with SMTP id l17mr5243954wrw.73.1610136939823; Fri, 08 Jan 2021 12:15:39 -0800 (PST) Received: from dell.default ([91.110.221.229]) by smtp.gmail.com with ESMTPSA id l8sm15598671wrb.73.2021.01.08.12.15.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 08 Jan 2021 12:15:39 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Subject: [PATCH 24/40] drm/amd/display/dc/dce/dce_stream_encoder: Remove unused variable 'regval' Date: Fri, 8 Jan 2021 20:14:41 +0000 Message-Id: <20210108201457.3078600-25-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210108201457.3078600-1-lee.jones@linaro.org> References: <20210108201457.3078600-1-lee.jones@linaro.org> MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Leo Li , linux-kernel@vger.kernel.org, amd-gfx@lists.freedesktop.org, David Airlie , Eric Bernstein , dri-devel@lists.freedesktop.org, George Shen , Alex Deucher , =?utf-8?q?Christian_K=C3=B6?= =?utf-8?q?nig?= Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/amd/amdgpu/../display/dc/dce/dce_stream_encoder.c: In function ‘dce110_update_generic_info_packet’: drivers/gpu/drm/amd/amdgpu/../display/dc/dce/dce_stream_encoder.c:70:11: warning: variable ‘regval’ set but not used [-Wunused-but-set-variable] Cc: Harry Wentland Cc: Leo Li Cc: Alex Deucher Cc: "Christian König" Cc: David Airlie Cc: Daniel Vetter Cc: George Shen Cc: Eric Bernstein Cc: amd-gfx@lists.freedesktop.org Cc: dri-devel@lists.freedesktop.org Signed-off-by: Lee Jones --- drivers/gpu/drm/amd/display/dc/dce/dce_stream_encoder.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/gpu/drm/amd/display/dc/dce/dce_stream_encoder.c b/drivers/gpu/drm/amd/display/dc/dce/dce_stream_encoder.c index ada57f745fd76..265eaef30a519 100644 --- a/drivers/gpu/drm/amd/display/dc/dce/dce_stream_encoder.c +++ b/drivers/gpu/drm/amd/display/dc/dce/dce_stream_encoder.c @@ -67,7 +67,6 @@ static void dce110_update_generic_info_packet( uint32_t packet_index, const struct dc_info_packet *info_packet) { - uint32_t regval; /* TODOFPGA Figure out a proper number for max_retries polling for lock * use 50 for now. */ @@ -99,7 +98,7 @@ static void dce110_update_generic_info_packet( } /* choose which generic packet to use */ { - regval = REG_READ(AFMT_VBI_PACKET_CONTROL); + REG_READ(AFMT_VBI_PACKET_CONTROL); REG_UPDATE(AFMT_VBI_PACKET_CONTROL, AFMT_GENERIC_INDEX, packet_index); } From patchwork Fri Jan 8 20:14:42 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 359051 Delivered-To: patch@linaro.org Received: by 2002:a02:85a7:0:0:0:0:0 with SMTP id d36csp855918jai; Fri, 8 Jan 2021 12:15:50 -0800 (PST) X-Google-Smtp-Source: ABdhPJyhv8tguvlKM7XBiWLiNVB5cMvPMZU0OWSd92jciTTadGdguQNXRuHGU3IMMzGFDFp39TH5 X-Received: by 2002:a65:4105:: with SMTP id w5mr8729015pgp.52.1610136950676; Fri, 08 Jan 2021 12:15:50 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1610136950; cv=none; d=google.com; s=arc-20160816; b=js0QB/sKkKkzVPP8dGMIJkk/yxNuPZXTVlxbcdHYQl+kW96fGvMnfxbvz7ROLglRAE CELYQPKGKu8H3FTFHrLDbsH0pjn0mhCoU/zawyfqK3mLOIeASfYmRgsvhdoZn7etTc+X K4W+8npByLxNgBNqIxZqotgLerfHx+E2mmQZrGhkjRJ9P9p63NMjqRAn1u7cFkfohRee ZRiYNywmOpEU//ZbVlmvL+H6RMQWHN6n9eErBZqHoO3eEQxeqhByDKm2PSBnrWFnoRJZ wt/o/O2glPBKn7TQ8WTd4MoWYyT56D9CscAlDmxxuXnRN8xPuTpPfkbaGep3w9CpQ4jN j6bw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:cc:list-subscribe :list-help:list-post:list-archive:list-unsubscribe:list-id :precedence:mime-version:references:in-reply-to:message-id:date :subject:to:from:dkim-signature:delivered-to; bh=dFi2pql5NyNI8rQVsiAgbHCbD9mGPiAPSmfIzOJaLT4=; b=kRFROTyIva74Dc/L+RdFOJpEmVtqw5m/xPEuSsz2vpVFo8+NlMBijAuSSpjmi7bmTT qHVjn1ltVwIWh8/JbSUPveT3RKLPpuYvMZ9/HpBS2yr2Rs6swTKrN8BF6dLL/B+p8m6W SRaMjVV4W3A+vTf5fwMRDhx/7g32aA/jAdFrRiKdipRn/gs0bEIwgqj0ImgyqlzMUctb ncGo68LFFbzR1zgcmx2MHu064NEVzMS0SzcgRVPERTWLtCsgjlL6hBdRyaI8av90+Sg2 0GQ/6sVfn9HkACp+gqVt80DxrWYrazFycFYuYW0B8V+QFq7SnjJ6EMtRs+v1/yEdxceE 5NuQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=DWuALbOh; spf=pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 131.252.210.177 as permitted sender) smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from gabe.freedesktop.org (gabe.freedesktop.org. [131.252.210.177]) by mx.google.com with ESMTPS id d12si10374356pgi.443.2021.01.08.12.15.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 08 Jan 2021 12:15:50 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 131.252.210.177 as permitted sender) client-ip=131.252.210.177; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=DWuALbOh; spf=pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 131.252.210.177 as permitted sender) smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 33D516E8E4; Fri, 8 Jan 2021 20:15:46 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mail-wm1-x335.google.com (mail-wm1-x335.google.com [IPv6:2a00:1450:4864:20::335]) by gabe.freedesktop.org (Postfix) with ESMTPS id 7B7026E8DF for ; Fri, 8 Jan 2021 20:15:42 +0000 (UTC) Received: by mail-wm1-x335.google.com with SMTP id g185so9442006wmf.3 for ; Fri, 08 Jan 2021 12:15:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=gUGfQYc+R1dSwJCy8EOZsDxk+j22XvGXIhAmHcCe5cw=; b=DWuALbOhM66Bs4VwVlyplT5ynHt8NzU3loaaZxKRM42BP/MjWrJmNNyXEDNQAWWUgJ AVVbyPb8jiDbNhUJkj4Gmsg7VzT3+WI261d/9SWtCnnkvlsZNNbXp0ehTrZASSv6Rrkv xiAVooMmLYM8rmb8ZwAnTu6rPmRD9O1kjkhFONkNcdyv22UeNWhpzZQJwZtq11T+Q/UR emEiXSKaK8tShQ2wut5xKFCiNJ+IKcYdMGxp3TkIsfzVueHbBGvpxrnmZ2nVdeC6X1vV dDC9x2dPQxojVJcxAbk2qGprHLHKrqdzLejDbibsn2hUTXEt+V5wuL2hydI5G1bhoXxX Oc7g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=gUGfQYc+R1dSwJCy8EOZsDxk+j22XvGXIhAmHcCe5cw=; b=ljJCZxP5V/EEwfVN4LmlrPwjwycXHngoV2OUhr1wAGs7ZpPdwYu1EIDkURqkI6AEn4 WogJuSqa81RceDi//+zE0Zs83/ezOwTwlcoST4R/vDafSm10qJy3cpq5NeM35sdWY3DK gQ2Aw8BDkwVDHPgXNcdjNcgO2fxbfrV2avCtEM8TZ8oR0G8bi5P01PXJeneery53qvH8 S2RnNBEV/pOSeYcYt8dBduOu0pX+fiy/VZ7KQcugjk/UBfUKYAFYrfcvAlnCUAVutzxl ItDVMuqrTBM0iy6vaGCksA8jNM71i3uurKdUj0tdX3O9PdfO7OoKnqYo/KL7PVFj62Rv W/Vw== X-Gm-Message-State: AOAM5306L0WMOK3Hhs2FhK/krrUXSP9GZT4n74f869HdVIoJGk7W12pe CEmYxAup2+EaEi5C+7VhCl1UTg== X-Received: by 2002:a1c:9a57:: with SMTP id c84mr4347583wme.183.1610136941141; Fri, 08 Jan 2021 12:15:41 -0800 (PST) Received: from dell.default ([91.110.221.229]) by smtp.gmail.com with ESMTPSA id l8sm15598671wrb.73.2021.01.08.12.15.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 08 Jan 2021 12:15:40 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Subject: [PATCH 25/40] drm/amd/display/dc/dce/dce_link_encoder: Make functions invoked by reference static Date: Fri, 8 Jan 2021 20:14:42 +0000 Message-Id: <20210108201457.3078600-26-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210108201457.3078600-1-lee.jones@linaro.org> References: <20210108201457.3078600-1-lee.jones@linaro.org> MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Leo Li , Mauro Rossi , linux-kernel@vger.kernel.org, amd-gfx@lists.freedesktop.org, David Airlie , dri-devel@lists.freedesktop.org, Alex Deucher , =?utf-8?q?Christian_K=C3=B6nig?= Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/amd/amdgpu/../display/dc/dce/dce_link_encoder.c:1200:6: warning: no previous prototype for ‘dce60_link_encoder_enable_dp_output’ [-Wmissing-prototypes] drivers/gpu/drm/amd/amdgpu/../display/dc/dce/dce_link_encoder.c:1239:6: warning: no previous prototype for ‘dce60_link_encoder_enable_dp_mst_output’ [-Wmissing-prototypes] drivers/gpu/drm/amd/amdgpu/../display/dc/dce/dce_link_encoder.c:1429:6: warning: no previous prototype for ‘dce60_link_encoder_dp_set_phy_pattern’ [-Wmissing-prototypes] Cc: Harry Wentland Cc: Leo Li Cc: Alex Deucher Cc: "Christian König" Cc: David Airlie Cc: Daniel Vetter Cc: Mauro Rossi Cc: amd-gfx@lists.freedesktop.org Cc: dri-devel@lists.freedesktop.org Signed-off-by: Lee Jones --- drivers/gpu/drm/amd/display/dc/dce/dce_link_encoder.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/amd/display/dc/dce/dce_link_encoder.c b/drivers/gpu/drm/amd/display/dc/dce/dce_link_encoder.c index 210466b2d8631..0ef2f4d9d8bf3 100644 --- a/drivers/gpu/drm/amd/display/dc/dce/dce_link_encoder.c +++ b/drivers/gpu/drm/amd/display/dc/dce/dce_link_encoder.c @@ -1197,7 +1197,7 @@ void dce110_link_encoder_enable_dp_mst_output( #if defined(CONFIG_DRM_AMD_DC_SI) /* enables DP PHY output */ -void dce60_link_encoder_enable_dp_output( +static void dce60_link_encoder_enable_dp_output( struct link_encoder *enc, const struct dc_link_settings *link_settings, enum clock_source_id clock_source) @@ -1236,7 +1236,7 @@ void dce60_link_encoder_enable_dp_output( } /* enables DP PHY output in MST mode */ -void dce60_link_encoder_enable_dp_mst_output( +static void dce60_link_encoder_enable_dp_mst_output( struct link_encoder *enc, const struct dc_link_settings *link_settings, enum clock_source_id clock_source) @@ -1426,7 +1426,7 @@ void dce110_link_encoder_dp_set_phy_pattern( #if defined(CONFIG_DRM_AMD_DC_SI) /* set DP PHY test and training patterns */ -void dce60_link_encoder_dp_set_phy_pattern( +static void dce60_link_encoder_dp_set_phy_pattern( struct link_encoder *enc, const struct encoder_set_dp_phy_pattern_param *param) { From patchwork Fri Jan 8 20:14:43 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 359052 Delivered-To: patch@linaro.org Received: by 2002:a02:85a7:0:0:0:0:0 with SMTP id d36csp855928jai; Fri, 8 Jan 2021 12:15:51 -0800 (PST) X-Google-Smtp-Source: ABdhPJzqtugyrxspT5fvg6sZEi1p8UluUwDchA9wTtPNRjCL4vjAia8vDcpa/B1MOCcOWbjR9McB X-Received: by 2002:a63:987:: with SMTP id 129mr8652808pgj.251.1610136951490; Fri, 08 Jan 2021 12:15:51 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1610136951; cv=none; d=google.com; s=arc-20160816; b=u+7+hT1hJGLIzq2d/V3S2fREd7h0gFPtZIqDkmrSbl6rmSkuFmQybZw6SwfosadavH DXe2PM3Yq1m0mmhDVOYRamqDh0423Aral9J7QAt/DB35EUc97JCj+Cn893I4yy02Btt3 FZFcJy+hvKU9lJnXH3Buuio/tLdA87QgDNpufWujTiczN10otasf2C1N9uKilTvPOy3+ Sfnn1YSN+et8hFQGNPL9b6PngrMFCkltXOkGJa4JPmic0cJsNw96dhK25Guf+sKoE3dv orBaP8PRx2e7E1rH2kgdtkn+R68tvz5bHxqlzQCZJevw/SmaRyFQvmLOpDWB83hVaxe7 sgew== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:cc:list-subscribe :list-help:list-post:list-archive:list-unsubscribe:list-id :precedence:mime-version:references:in-reply-to:message-id:date :subject:to:from:dkim-signature:delivered-to; bh=029SmJDyxOgIurhcovC12aIiikM6nActaicpgfa8Pg8=; b=NbjbJ1/XOYn1gVrTLmygjk03FZCWGEu4Crv3e3+Xw39CjMZTfpMhcjJprcrHsmZ8s3 U9Wyz8R83hh5WbwQSMV2UIg7Qy1MweHzYBlI3Dy+k/3ZNpM/J+QBW/uNNyCsroL2pocK KbnsQODRYyQfIT7w4JsFGcaY+n9Xy6msPi9FtdLRtRUNaMWh9epFbTiGXI1DT6zdu0Dj fVjVv8ZZA9b9APq7nLBEk5N2iAct23n2glzyV9Q14FwGyz94JBP/Aa2bWNAYp51SwN2q 73aN7tloEmjpVb30ewjKcD/2I4Z1tmb3i8dku1u/yqU1xQ1WqMXdKOAyFi37X7G/mJMH c5aw== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=Xy31cYvB; spf=pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 131.252.210.177 as permitted sender) smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from gabe.freedesktop.org (gabe.freedesktop.org. [131.252.210.177]) by mx.google.com with ESMTPS id c10si9967512pfi.143.2021.01.08.12.15.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 08 Jan 2021 12:15:51 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 131.252.210.177 as permitted sender) client-ip=131.252.210.177; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=Xy31cYvB; spf=pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 131.252.210.177 as permitted sender) smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id BCB5B6E8E7; Fri, 8 Jan 2021 20:15:46 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mail-wr1-x42d.google.com (mail-wr1-x42d.google.com [IPv6:2a00:1450:4864:20::42d]) by gabe.freedesktop.org (Postfix) with ESMTPS id C4AC86E8E3 for ; Fri, 8 Jan 2021 20:15:43 +0000 (UTC) Received: by mail-wr1-x42d.google.com with SMTP id 91so10154005wrj.7 for ; Fri, 08 Jan 2021 12:15:43 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=pblAeFWzmcS2QjfKQcW4YzpdGFQhCgUQwjxDwmXWZWw=; b=Xy31cYvBZTa7wJ1AwNUqIzABwROlfQfrASnc5CTUU081n4VYSnlDIaJAc21aaE+eWx 8Ux4vVwgMYkbOuZ1bXU/h+qbLVBFN5564/w1AT1hrGktaGQJcMFovbEaR51iRcy6atHQ w0tIx2ZCcnJzTPYP3lZ/jEvrd+457uEkr1i1voZClrunnwQyMLA0wv1XJ2Ho5BiMnSb4 9WmbTG/OO7FoDPt0+ULwXPcOYlOd5xuGi4gGEfGEFMrCQX1erOpB3+qtS6QEMT/T46ZT U4gIigaDRgZ6AzJKcAF2A5Ktgq8NRtyYj686vz5UgfdAe5z9n1JMZ/ThH7y7PYkCTIOO moTg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=pblAeFWzmcS2QjfKQcW4YzpdGFQhCgUQwjxDwmXWZWw=; b=lxuB0nBSu27OGWMI8SLKeRKU7KygQChMjcHQsk5gNSPrxrZhwkGrk0I0StPBkEw02n TB2SAoSbIZ8S2TVRvkI2nUmIlRLPyzBd1ABCnpldr0rcHRuSvPMOyRCPrfB5F2qLxniO KQzdbCghiOgg0vb1BvuvvbyueFW+K6MQ7cmCKB9bnCWCi9q/hc47QKOBrYTwD20KcFdx eNa8R/zJzDtEtNmnoVf7057D3vFj5TJyaY6YFUrVs4eNdjCkHAz/NJKeHOfPpQ16Qjk3 WIPcQuL5XMjn1A7053+m5WfWmemy5apM/ErkglyjvdZIwA9R32UTDGrk6cDVOrYYgxTw 4j1A== X-Gm-Message-State: AOAM532rrQ7AzO3uHOxvDBb4BvQ0jgh9vH1poHSC5jRSglCIdKGkf8b6 8FRhx4RXKSfnMUtejzMbXostYqy4ULaWLCeO X-Received: by 2002:a05:6000:1188:: with SMTP id g8mr5413367wrx.111.1610136942484; Fri, 08 Jan 2021 12:15:42 -0800 (PST) Received: from dell.default ([91.110.221.229]) by smtp.gmail.com with ESMTPSA id l8sm15598671wrb.73.2021.01.08.12.15.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 08 Jan 2021 12:15:41 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Subject: [PATCH 26/40] drm/amd/display/dc/dce/dce_clock_source: Fix formatting/spelling of worthy function headers Date: Fri, 8 Jan 2021 20:14:43 +0000 Message-Id: <20210108201457.3078600-27-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210108201457.3078600-1-lee.jones@linaro.org> References: <20210108201457.3078600-1-lee.jones@linaro.org> MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Leo Li , Bhawanpreet Lakha , linux-kernel@vger.kernel.org, amd-gfx@lists.freedesktop.org, David Airlie , dri-devel@lists.freedesktop.org, Alex Deucher , =?utf-8?q?Christian_K=C3=B6nig?= Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Demote the one that provides no param descriptions. Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/amd/amdgpu/../display/dc/dce/dce_clock_source.c:142: warning: Function parameter or member 'calc_pll_cs' not described in 'calculate_fb_and_fractional_fb_divider' drivers/gpu/drm/amd/amdgpu/../display/dc/dce/dce_clock_source.c:142: warning: Function parameter or member 'target_pix_clk_100hz' not described in 'calculate_fb_and_fractional_fb_divider' drivers/gpu/drm/amd/amdgpu/../display/dc/dce/dce_clock_source.c:142: warning: Function parameter or member 'ref_divider' not described in 'calculate_fb_and_fractional_fb_divider' drivers/gpu/drm/amd/amdgpu/../display/dc/dce/dce_clock_source.c:142: warning: Function parameter or member 'post_divider' not described in 'calculate_fb_and_fractional_fb_divider' drivers/gpu/drm/amd/amdgpu/../display/dc/dce/dce_clock_source.c:142: warning: Function parameter or member 'feedback_divider_param' not described in 'calculate_fb_and_fractional_fb_divider' drivers/gpu/drm/amd/amdgpu/../display/dc/dce/dce_clock_source.c:142: warning: Function parameter or member 'fract_feedback_divider_param' not described in 'calculate_fb_and_fractional_fb_divider' drivers/gpu/drm/amd/amdgpu/../display/dc/dce/dce_clock_source.c:200: warning: Function parameter or member 'calc_pll_cs' not described in 'calc_fb_divider_checking_tolerance' drivers/gpu/drm/amd/amdgpu/../display/dc/dce/dce_clock_source.c:200: warning: Function parameter or member 'pll_settings' not described in 'calc_fb_divider_checking_tolerance' drivers/gpu/drm/amd/amdgpu/../display/dc/dce/dce_clock_source.c:200: warning: Function parameter or member 'ref_divider' not described in 'calc_fb_divider_checking_tolerance' drivers/gpu/drm/amd/amdgpu/../display/dc/dce/dce_clock_source.c:200: warning: Function parameter or member 'post_divider' not described in 'calc_fb_divider_checking_tolerance' drivers/gpu/drm/amd/amdgpu/../display/dc/dce/dce_clock_source.c:200: warning: Function parameter or member 'tolerance' not described in 'calc_fb_divider_checking_tolerance' drivers/gpu/drm/amd/amdgpu/../display/dc/dce/dce_clock_source.c:478: warning: Function parameter or member 'clk_src' not described in 'dce110_get_pix_clk_dividers_helper' drivers/gpu/drm/amd/amdgpu/../display/dc/dce/dce_clock_source.c:478: warning: Function parameter or member 'pll_settings' not described in 'dce110_get_pix_clk_dividers_helper' drivers/gpu/drm/amd/amdgpu/../display/dc/dce/dce_clock_source.c:478: warning: Function parameter or member 'pix_clk_params' not described in 'dce110_get_pix_clk_dividers_helper' Cc: Harry Wentland Cc: Leo Li Cc: Alex Deucher Cc: "Christian König" Cc: David Airlie Cc: Daniel Vetter Cc: Bhawanpreet Lakha Cc: amd-gfx@lists.freedesktop.org Cc: dri-devel@lists.freedesktop.org Signed-off-by: Lee Jones --- .../drm/amd/display/dc/dce/dce_clock_source.c | 57 +++++++++---------- 1 file changed, 28 insertions(+), 29 deletions(-) diff --git a/drivers/gpu/drm/amd/display/dc/dce/dce_clock_source.c b/drivers/gpu/drm/amd/display/dc/dce/dce_clock_source.c index fb733f573715e..10938a8c9500a 100644 --- a/drivers/gpu/drm/amd/display/dc/dce/dce_clock_source.c +++ b/drivers/gpu/drm/amd/display/dc/dce/dce_clock_source.c @@ -113,20 +113,19 @@ static const struct spread_spectrum_data *get_ss_data_entry( } /** - * Function: calculate_fb_and_fractional_fb_divider + * calculate_fb_and_fractional_fb_divider - Calculates feedback and fractional + * feedback dividers values * - * * DESCRIPTION: Calculates feedback and fractional feedback dividers values + * @calc_pll_cs: Pointer to clock source information + * @target_pix_clk_100hz: Desired frequency in 100 Hz + * @ref_divider: Reference divider (already known) + * @post_divider: Post Divider (already known) + * @feedback_divider_param: Pointer where to store + * calculated feedback divider value + * @fract_feedback_divider_param: Pointer where to store + * calculated fract feedback divider value * - *PARAMETERS: - * targetPixelClock Desired frequency in 100 Hz - * ref_divider Reference divider (already known) - * postDivider Post Divider (already known) - * feedback_divider_param Pointer where to store - * calculated feedback divider value - * fract_feedback_divider_param Pointer where to store - * calculated fract feedback divider value - * - *RETURNS: + * return: * It fills the locations pointed by feedback_divider_param * and fract_feedback_divider_param * It returns - true if feedback divider not 0 @@ -175,22 +174,22 @@ static bool calculate_fb_and_fractional_fb_divider( } /** -*calc_fb_divider_checking_tolerance -* -*DESCRIPTION: Calculates Feedback and Fractional Feedback divider values -* for passed Reference and Post divider, checking for tolerance. -*PARAMETERS: -* pll_settings Pointer to structure -* ref_divider Reference divider (already known) -* postDivider Post Divider (already known) -* tolerance Tolerance for Calculated Pixel Clock to be within -* -*RETURNS: -* It fills the PLLSettings structure with PLL Dividers values -* if calculated values are within required tolerance -* It returns - true if error is within tolerance -* - false if error is not within tolerance -*/ + * calc_fb_divider_checking_tolerance - Calculates Feedback and + * Fractional Feedback divider values + * for passed Reference and Post divider, + * checking for tolerance. + * @calc_pll_cs: Pointer to clock source information + * @pll_settings: Pointer to PLL settings + * @ref_divider: Reference divider (already known) + * @post_divider: Post Divider (already known) + * @tolerance: Tolerance for Calculated Pixel Clock to be within + * + * return: + * It fills the PLLSettings structure with PLL Dividers values + * if calculated values are within required tolerance + * It returns - true if error is within tolerance + * - false if error is not within tolerance + */ static bool calc_fb_divider_checking_tolerance( struct calc_pll_clock_source *calc_pll_cs, struct pll_settings *pll_settings, @@ -460,7 +459,7 @@ static bool pll_adjust_pix_clk( return false; } -/** +/* * Calculate PLL Dividers for given Clock Value. * First will call VBIOS Adjust Exec table to check if requested Pixel clock * will be Adjusted based on usage. From patchwork Fri Jan 8 20:14:44 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 359053 Delivered-To: patch@linaro.org Received: by 2002:a02:85a7:0:0:0:0:0 with SMTP id d36csp855941jai; Fri, 8 Jan 2021 12:15:53 -0800 (PST) X-Google-Smtp-Source: ABdhPJzTEbVIm10+puxCurEdabu2HfNYKiOsTpr2yxzamto52wQqkjLBPNRt4E28hNwt9FY3TydK X-Received: by 2002:a62:64d2:0:b029:19e:662e:5e99 with SMTP id y201-20020a6264d20000b029019e662e5e99mr5382243pfb.17.1610136953193; Fri, 08 Jan 2021 12:15:53 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1610136953; cv=none; d=google.com; s=arc-20160816; b=kONqpw+VTmZ/AjQCliXrA5aejImx7SyL2egeOMaGBTlxMPgfw8owZtYSPrfVvbsNNm A8OlVdtHfWdwY++G4Ysuwugg8UvUZbz8WO2A514WxP87WT/XTXTP/SSnNENcxikVNUOh Djph/xmPi0Z0HTeqejxofSowBgwS4bcQUga0O0+V/+tKlJ1Jk0JtW0bgEDr4ehOcyXkQ AIcN70AgtXq6gRNET99y90+UaKB9fxVbidDshhHK1JV53psjdTxock/q6+gYHV9Oz1eX IcvRbf/V2oNcTIaamI4yOFQLDoC0pEmmhbC2DHNfpRbwbemZfcss5BRFMFYcF66QFNhh LAlA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:cc:list-subscribe :list-help:list-post:list-archive:list-unsubscribe:list-id :precedence:mime-version:references:in-reply-to:message-id:date :subject:to:from:dkim-signature:delivered-to; bh=YSqgLJO5jqjgL4jNGUDFkEwjqTcukPLKsD4rp8hfbWM=; b=YTH1jUmTpjeTfkgt81qvkxLkNoNBwe4lak2O3RVAjMFAj4gY8b8YvyrJButw+txD4V FqhOP7LwBWPzdnGJhZI2n9K6UPdybd9JsAiJw4uJYqP1ztDLZ8+hvW47sLSJuatuJZo6 0xaKLrUHAmkag9kw7K4jvksNOtmRgtsbN1baLd6iWrG9ZGks8rxX1rCNROGWQjV2Pi4o EfX6ZGJ4gUp1CQY8RassfP5Y1HevcaY/gOQexWWILmRDf4AKeB9irRiN+O2s0BCxDOpI aMs69UzB3qsdGrst/WZ6ayAbsnTXMntQnog4xF6c2pOykTgTNAYIFx/f9y6IGkp5Razw DI6A== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=oLEvSIqH; spf=pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 2610:10:20:722:a800:ff:fe36:1795 as permitted sender) smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from gabe.freedesktop.org (gabe.freedesktop.org. [2610:10:20:722:a800:ff:fe36:1795]) by mx.google.com with ESMTPS id r12si6832024pjl.78.2021.01.08.12.15.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 08 Jan 2021 12:15:53 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 2610:10:20:722:a800:ff:fe36:1795 as permitted sender) client-ip=2610:10:20:722:a800:ff:fe36:1795; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=oLEvSIqH; spf=pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 2610:10:20:722:a800:ff:fe36:1795 as permitted sender) smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 3A2646E8DA; Fri, 8 Jan 2021 20:15:48 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mail-wr1-x430.google.com (mail-wr1-x430.google.com [IPv6:2a00:1450:4864:20::430]) by gabe.freedesktop.org (Postfix) with ESMTPS id 137456E8DC for ; Fri, 8 Jan 2021 20:15:45 +0000 (UTC) Received: by mail-wr1-x430.google.com with SMTP id r3so10172536wrt.2 for ; Fri, 08 Jan 2021 12:15:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=vzX6stkngwwfosiTDTeki05QJAI1C4v60xYRYKZFrg4=; b=oLEvSIqHjbOXHRWvR10iZ3YSOuwgLDV8XxlXiKg1BZBYPqZduYOnq1anLUPunI6Ktf 8Y456l+zeFwcCMIwYjpAKkYSlADDKtJEPyXd0HUhJl/GnFo7vqHUWPLWrGg5Mx0Kwrcu 9AldNwx2QRb11OuI3fmQqIHimTBFlO7UzKXOgRt+fxrs7nTDJrRqbseDUvUTsC40x23x cDVegAomw3UfPKPK+Wh+wb5/mXquJVNJiygcPGvnJHub9Scfw789l4JGRSxjMSfzcNhC ozB+WIuMQziRzb7tiOfsBxeH8bZmY+sSgM/axuqXucL2NK/VJ2CI1KbFxMFsYyDwhDyx 1oSw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=vzX6stkngwwfosiTDTeki05QJAI1C4v60xYRYKZFrg4=; b=oh0TwWh56WaUr/sZSwyCzpqsFYTyNsB9HdE3BbtQzVvh43C52XgiqSZzdqYT2Aa+ZF S1CissG8vc7sMPqwNC5KdKBsyuQcklhs2+Jy1lxOwjQkLjN6l6/X9ln6rEHOEXIIDnSI D4CcU2DTjgOGBlzkFWrIMTxHTgnqFZNp88JMVOuzA7Nyl1+5z6e4Q/P/8nS92B/mp74/ F/ZN8siKgahImHJAKKWJU5DbtpOwDkbeQgEFwi2nIR+IUcBB/W7xyEHp2DJcUBuJZ4MU qsppOev7trWtlXy/fUd2HhWjtF5tUDaxrWO5gdIB8g57+qN+sXe6JKnXVf5GALVknGxK TP2Q== X-Gm-Message-State: AOAM530EhTF5A5wjPRz2fhjkpMQvI2SK2fScg3nBnMNdh4XljWoemJQ8 Kd5ATFdpMiBoS3XthppnmPJx/w== X-Received: by 2002:adf:d843:: with SMTP id k3mr5259529wrl.346.1610136943773; Fri, 08 Jan 2021 12:15:43 -0800 (PST) Received: from dell.default ([91.110.221.229]) by smtp.gmail.com with ESMTPSA id l8sm15598671wrb.73.2021.01.08.12.15.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 08 Jan 2021 12:15:43 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Subject: [PATCH 27/40] drm/amd/pm/powerplay/hwmgr/vega10_hwmgr: Fix worthy function headers, demote barely documented one Date: Fri, 8 Jan 2021 20:14:44 +0000 Message-Id: <20210108201457.3078600-28-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210108201457.3078600-1-lee.jones@linaro.org> References: <20210108201457.3078600-1-lee.jones@linaro.org> MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: David Airlie , linux-kernel@vger.kernel.org, amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, Alex Deucher , Evan Quan , =?utf-8?q?Christian_K=C3=B6nig?= Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/amd/amdgpu/../pm/powerplay/hwmgr/vega10_hwmgr.c:1556: warning: Function parameter or member 'acg_freq' not described in 'vega10_populate_single_gfx_level' drivers/gpu/drm/amd/amdgpu/../pm/powerplay/hwmgr/vega10_hwmgr.c:1621: warning: Function parameter or member 'current_soc_did' not described in 'vega10_populate_single_soc_level' drivers/gpu/drm/amd/amdgpu/../pm/powerplay/hwmgr/vega10_hwmgr.c:1621: warning: Function parameter or member 'current_vol_index' not described in 'vega10_populate_single_soc_level' drivers/gpu/drm/amd/amdgpu/../pm/powerplay/hwmgr/vega10_hwmgr.c:1621: warning: Excess function parameter 'current_socclk_level' description in 'vega10_populate_single_soc_level' drivers/gpu/drm/amd/amdgpu/../pm/powerplay/hwmgr/vega10_hwmgr.c:1757: warning: Function parameter or member 'current_mem_vid' not described in 'vega10_populate_single_memory_level' drivers/gpu/drm/amd/amdgpu/../pm/powerplay/hwmgr/vega10_hwmgr.c:1757: warning: Function parameter or member 'current_memclk_level' not described in 'vega10_populate_single_memory_level' drivers/gpu/drm/amd/amdgpu/../pm/powerplay/hwmgr/vega10_hwmgr.c:1757: warning: Function parameter or member 'current_mem_soc_vind' not described in 'vega10_populate_single_memory_level' drivers/gpu/drm/amd/amdgpu/../pm/powerplay/hwmgr/vega10_hwmgr.c:2871: warning: Function parameter or member 'bitmap' not described in 'vega10_start_dpm' Cc: Evan Quan Cc: Alex Deucher Cc: "Christian König" Cc: David Airlie Cc: Daniel Vetter Cc: amd-gfx@lists.freedesktop.org Cc: dri-devel@lists.freedesktop.org Signed-off-by: Lee Jones --- drivers/gpu/drm/amd/pm/powerplay/hwmgr/vega10_hwmgr.c | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/amd/pm/powerplay/hwmgr/vega10_hwmgr.c b/drivers/gpu/drm/amd/pm/powerplay/hwmgr/vega10_hwmgr.c index da470462d6e2c..29c99642d22d4 100644 --- a/drivers/gpu/drm/amd/pm/powerplay/hwmgr/vega10_hwmgr.c +++ b/drivers/gpu/drm/amd/pm/powerplay/hwmgr/vega10_hwmgr.c @@ -1549,6 +1549,7 @@ static int vega10_populate_smc_link_levels(struct pp_hwmgr *hwmgr) * @hwmgr: the address of the hardware manager * @gfx_clock: the GFX clock to use to populate the structure. * @current_gfxclk_level: location in PPTable for the SMC GFXCLK structure. + * @acg_freq: ACG frequenty to return (MHz) */ static int vega10_populate_single_gfx_level(struct pp_hwmgr *hwmgr, uint32_t gfx_clock, PllSetting_t *current_gfxclk_level, @@ -1612,7 +1613,8 @@ static int vega10_populate_single_gfx_level(struct pp_hwmgr *hwmgr, * * @hwmgr: the address of the hardware manager. * @soc_clock: the SOC clock to use to populate the structure. - * @current_socclk_level: location in PPTable for the SMC SOCCLK structure. + * @current_soc_did: DFS divider to pass back to caller + * @current_vol_index: index of current VDD to pass back to caller * return: 0 on success */ static int vega10_populate_single_soc_level(struct pp_hwmgr *hwmgr, @@ -1744,7 +1746,7 @@ static void vega10_populate_vddc_soc_levels(struct pp_hwmgr *hwmgr) } } -/** +/* * Populates single SMC GFXCLK structure using the provided clock. * * @hwmgr: the address of the hardware manager. @@ -2863,8 +2865,8 @@ static int vega10_stop_dpm(struct pp_hwmgr *hwmgr, uint32_t bitmap) /** * Tell SMC to enabled the supported DPMs. * - * @hwmgr: the address of the powerplay hardware manager. - * @bitmap bitmap for the features to enabled. + * @hwmgr: the address of the powerplay hardware manager. + * @bitmap: bitmap for the features to enabled. * return: 0 on at least one DPM is successfully enabled. */ static int vega10_start_dpm(struct pp_hwmgr *hwmgr, uint32_t bitmap) From patchwork Fri Jan 8 20:14:45 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 359054 Delivered-To: patch@linaro.org Received: by 2002:a02:85a7:0:0:0:0:0 with SMTP id d36csp855955jai; Fri, 8 Jan 2021 12:15:54 -0800 (PST) X-Google-Smtp-Source: ABdhPJxFqOsia2zhLEYwsbdCAhttLMze+4UXi8qJCXu2KvthBd3i4N7nYZZlbMN0KYJeJo0iorur X-Received: by 2002:aa7:87d2:0:b029:1a5:43da:b93c with SMTP id i18-20020aa787d20000b02901a543dab93cmr5214702pfo.6.1610136954582; Fri, 08 Jan 2021 12:15:54 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1610136954; cv=none; d=google.com; s=arc-20160816; b=iIMJUnpZLhEG8ky2NiyccYAtaFR+fiNYxm+GzdQHRIKEmYlDzflD0b7gp+TpQhbzUc wdyBlFHXiruIaaOEwlH0pJeGVLBcyk/gWBn6c64futfNLq7Cb0zykWHDd4nDXJmsgJoY RJFfMC8NTFJu0b8yXrWQJ1uSkaXj8IyxjkmYVgvlXf0uJMUjImBK7mjLBLD4I4FbuC5B QFH0QKdE+/2NlwD4nMNcwoJGQZ/VlzKbmpSCHQvQG1GNY27+Xd+833M+4Tf0bXVF6W2V wihJh6XILG8ztWckZgB4sUKHGA9rxepT6wtgLSsrScxGN36UZIJUTlP/i0EO4F7lPkYS wwQA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:cc:list-subscribe :list-help:list-post:list-archive:list-unsubscribe:list-id :precedence:mime-version:references:in-reply-to:message-id:date :subject:to:from:dkim-signature:delivered-to; bh=PCXhkoEhv/wT+wBadDhpogW5sGiwDh00w4IwkRIUfaM=; b=AI0B1q1Uyi2ANru8GGY4pu+vHOZbJPHh9A7jymlDP964mdSpUQ4O14Hen9iIaBQrOo ROQnWglzQRKJhFj5gltLlPP9GiuSkN58FvBILodRK7jrqsIfXL+Uo5yGtkZSP5m4C6nP rEKyDx/WidHDoBzH5BtWoqGo5SKpOUSF150Gx1AAK4SKLnnKjM7peQVVg8MWO/lgP3ZL HGdQtqpVBE5FLgnfsxNNOEUREirel80UPsCVw5LeA1F7IvJwqQRLc0Gx0dK6kofhiWl6 QSqSN1evy103hDRfXb4V2ObudlqN+zkDpIUY7dX0xfhXc6JYBNE/I8Lpkjd/zmcx7BWQ iswA== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=wbg5je7F; spf=pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 2610:10:20:722:a800:ff:fe36:1795 as permitted sender) smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from gabe.freedesktop.org (gabe.freedesktop.org. [2610:10:20:722:a800:ff:fe36:1795]) by mx.google.com with ESMTPS id o37si9978268pgl.473.2021.01.08.12.15.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 08 Jan 2021 12:15:54 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 2610:10:20:722:a800:ff:fe36:1795 as permitted sender) client-ip=2610:10:20:722:a800:ff:fe36:1795; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=wbg5je7F; spf=pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 2610:10:20:722:a800:ff:fe36:1795 as permitted sender) smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id A5C186E8E6; Fri, 8 Jan 2021 20:15:48 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mail-wm1-x331.google.com (mail-wm1-x331.google.com [IPv6:2a00:1450:4864:20::331]) by gabe.freedesktop.org (Postfix) with ESMTPS id A85946E8DC for ; Fri, 8 Jan 2021 20:15:46 +0000 (UTC) Received: by mail-wm1-x331.google.com with SMTP id 190so8768143wmz.0 for ; Fri, 08 Jan 2021 12:15:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=4ytR3fqWZwqVYBK3RsUcXcI3WQSuSAKiurJIlwb7LgU=; b=wbg5je7FZsTgpIt6O9urrAylcwuurXSWEq/h3em25fF38r83Wa9EOq3Db9eo7QsSk9 xwCRNYNRj/HLDKQWdrdE8TtwKeaffhNaIpi6nqRIGPVhppSmMflAaIIQH3Fn0I+ceMkh 4fYv2+yBgTyo1WcrjJkbhFjC/1l+GZEtkMHjeRldDTYSvdfqYUlJ+BZnw5geAXBmz9Kt Kw5FQ7yrlP4d6g5ycACgBF+bzlCUiu2T7klLeCQ/8q0Goa4cAXvZFBTeALZvDFP8+dTg K7nwLezl8va5JyslPwJjMB2o3u+zpgwll+AaOccnV+dIaNxAY/MUgouPKgWFlhRTYSbe GMqg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=4ytR3fqWZwqVYBK3RsUcXcI3WQSuSAKiurJIlwb7LgU=; b=YdEJekYmLDbO2jpNgVhV0g5jAOL+fFNdxFGtIinunZ8FNFky+Yy+91YJa36n2wV7tz 6SDlFZRAA+F/asy7rhrlXQ2h70YMYxB+AUZWB1SShSvgkXuayOn58sc+M+pjIKoYhxAA 4JywJiLqoA43GlatxRnGWywT16h9c/UJBjPvQUAdP6nB8VT3bPsbmQnJ9d1VT+JtCt4p 3u6tJ1J9vxHYuP6yNOtsOPXMYyMqyBlzRsN5hX8j0/1+YL+1SWADprsWOSR44y9JqYe+ 5LMPJ/HfuUJCZZmvhjKb4GkKuZyWkjiJJ5xdUfTFvmJj3Mn4qsFd9P0iAJlEwMGxuB7m 6jcA== X-Gm-Message-State: AOAM531IvjNgwDllrOIFORFBMvkyVTO/Y3K0XeMwmF/CD45z4l75mWHF myuq614J0V4Zaen1+TNjF/zNIg== X-Received: by 2002:a1c:234d:: with SMTP id j74mr4503783wmj.18.1610136945272; Fri, 08 Jan 2021 12:15:45 -0800 (PST) Received: from dell.default ([91.110.221.229]) by smtp.gmail.com with ESMTPSA id l8sm15598671wrb.73.2021.01.08.12.15.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 08 Jan 2021 12:15:44 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Subject: [PATCH 28/40] drm/amd/display/dc/dce/dce_transform: Remove 3 unused/legacy variables Date: Fri, 8 Jan 2021 20:14:45 +0000 Message-Id: <20210108201457.3078600-29-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210108201457.3078600-1-lee.jones@linaro.org> References: <20210108201457.3078600-1-lee.jones@linaro.org> MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Leo Li , Mauro Rossi , linux-kernel@vger.kernel.org, amd-gfx@lists.freedesktop.org, David Airlie , dri-devel@lists.freedesktop.org, Alex Deucher , =?utf-8?q?Christian_K=C3=B6nig?= Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/amd/amdgpu/../display/dc/dce/dce_transform.c: In function ‘dce60_transform_set_scaler’: drivers/gpu/drm/amd/amdgpu/../display/dc/dce/dce_transform.c:496:7: warning: variable ‘filter_updated’ set but not used [-Wunused-but-set-variable] drivers/gpu/drm/amd/amdgpu/../display/dc/dce/dce_transform.c: In function ‘dce60_transform_set_pixel_storage_depth’: drivers/gpu/drm/amd/amdgpu/../display/dc/dce/dce_transform.c:1040:19: warning: variable ‘expan_mode’ set but not used [-Wunused-but-set-variable] drivers/gpu/drm/amd/amdgpu/../display/dc/dce/dce_transform.c:1040:6: warning: variable ‘pixel_depth’ set but not used [-Wunused-but-set-variable] Cc: Harry Wentland Cc: Leo Li Cc: Alex Deucher Cc: "Christian König" Cc: David Airlie Cc: Daniel Vetter Cc: Mauro Rossi Cc: amd-gfx@lists.freedesktop.org Cc: dri-devel@lists.freedesktop.org Signed-off-by: Lee Jones --- drivers/gpu/drm/amd/display/dc/dce/dce_transform.c | 13 ------------- 1 file changed, 13 deletions(-) diff --git a/drivers/gpu/drm/amd/display/dc/dce/dce_transform.c b/drivers/gpu/drm/amd/display/dc/dce/dce_transform.c index 130a0a0c83329..6121bb7b009b8 100644 --- a/drivers/gpu/drm/amd/display/dc/dce/dce_transform.c +++ b/drivers/gpu/drm/amd/display/dc/dce/dce_transform.c @@ -493,7 +493,6 @@ static void dce60_transform_set_scaler( { struct dce_transform *xfm_dce = TO_DCE_TRANSFORM(xfm); bool is_scaling_required; - bool filter_updated = false; const uint16_t *coeffs_v, *coeffs_h; /*Use whole line buffer memory always*/ @@ -558,7 +557,6 @@ static void dce60_transform_set_scaler( xfm_dce->filter_v = coeffs_v; xfm_dce->filter_h = coeffs_h; - filter_updated = true; } } @@ -1037,34 +1035,23 @@ static void dce60_transform_set_pixel_storage_depth( const struct bit_depth_reduction_params *bit_depth_params) { struct dce_transform *xfm_dce = TO_DCE_TRANSFORM(xfm); - int pixel_depth, expan_mode; enum dc_color_depth color_depth; switch (depth) { case LB_PIXEL_DEPTH_18BPP: color_depth = COLOR_DEPTH_666; - pixel_depth = 2; - expan_mode = 1; break; case LB_PIXEL_DEPTH_24BPP: color_depth = COLOR_DEPTH_888; - pixel_depth = 1; - expan_mode = 1; break; case LB_PIXEL_DEPTH_30BPP: color_depth = COLOR_DEPTH_101010; - pixel_depth = 0; - expan_mode = 1; break; case LB_PIXEL_DEPTH_36BPP: color_depth = COLOR_DEPTH_121212; - pixel_depth = 3; - expan_mode = 0; break; default: color_depth = COLOR_DEPTH_101010; - pixel_depth = 0; - expan_mode = 1; BREAK_TO_DEBUGGER(); break; } From patchwork Fri Jan 8 20:14:46 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 359055 Delivered-To: patch@linaro.org Received: by 2002:a02:85a7:0:0:0:0:0 with SMTP id d36csp855974jai; Fri, 8 Jan 2021 12:15:56 -0800 (PST) X-Google-Smtp-Source: ABdhPJwAHmVSK0tpg8DJWmoQQqTCZV2773YXLI2jykgSkWg69PXYWTJTEVVJfHziaB7u/mpRxQgo X-Received: by 2002:a17:90a:ba84:: with SMTP id t4mr5490309pjr.110.1610136956462; Fri, 08 Jan 2021 12:15:56 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1610136956; cv=none; d=google.com; s=arc-20160816; b=hmy+PkM7538md0DhXBWMe86xQA74h2eRaEFEV5RmPFAkxauJdtAJGxa2fBZ70Oodm8 YIBRjVqFLaFORi8tS0j4bvwuwl/hU7MHrqx9lz8JM3PmUo6BR1c+zMUpoDmF8B0bMUsJ qEv6Q0KrZF9Kfep7RoaaVBVSUYYtJOt2snagGSQXt1jjlWni+vtnm5Fs+L05vhl7BLvy xUsi823l+LvEQxbPbnq2po50goV5KFAKoVEDWZ7qn44ClmWfOd0b/0IUqJ5f9DZpqh+0 LacQni44gnzWeCkaHLCzFrkVWDEyhOkmKTN9d1dRMIrk4LGiUv5W9/weEYwVJ5aN3f2+ 0Pdw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:cc:list-subscribe :list-help:list-post:list-archive:list-unsubscribe:list-id :precedence:mime-version:references:in-reply-to:message-id:date :subject:to:from:dkim-signature:delivered-to; bh=DGJfPMn5sgcz5c07BMX5+sZuXnLO6Ky15lFKK0CqEXU=; b=q2cdmFjinlj9I+jixdUn3ldVlMOkx1+QMK6MV5WUgCL/kiLQiGFGDVQeUuth7cu0M1 4vefD4HIKElS8oQMEg6tspeleLlGtnpAwwGHnh/g4iac6SUhNpRidPk8LEgC08k7yMgF +IZZxipIWJajKfBz+CSPQOqLUzktYMPS9cHyrecnz0AglVx729HJz9cVfIy3xwEneLIU tTc3tOcQ2AfPdYoZUGoiYLoDhxl48Z4K9LJwpB57G/azlcRSuLL3+KbMe0lDE7FVhcDq 4CUaqepbVtHlt+L1FvDzOwNwTUOUNanx9571/ndg3TSXyj2tq4eRh+0E0eakikI4/B1K DoMg== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=qrFDHa6U; spf=pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 131.252.210.177 as permitted sender) smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from gabe.freedesktop.org (gabe.freedesktop.org. [131.252.210.177]) by mx.google.com with ESMTPS id b23si9989735pgs.426.2021.01.08.12.15.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 08 Jan 2021 12:15:56 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 131.252.210.177 as permitted sender) client-ip=131.252.210.177; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=qrFDHa6U; spf=pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 131.252.210.177 as permitted sender) smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 963DA6E8E8; Fri, 8 Jan 2021 20:15:50 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mail-wm1-x335.google.com (mail-wm1-x335.google.com [IPv6:2a00:1450:4864:20::335]) by gabe.freedesktop.org (Postfix) with ESMTPS id E67CE6E8DC for ; Fri, 8 Jan 2021 20:15:47 +0000 (UTC) Received: by mail-wm1-x335.google.com with SMTP id n16so7358777wmc.0 for ; Fri, 08 Jan 2021 12:15:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=YEfovM2NKT8ag9TvqZ5TvTpEztKPhuBS/BnjHfStf3g=; b=qrFDHa6UMrCuOW/PtBirv0Ncr1vLCDJC57MzIwvydzI8tYtfDhmCZvdRcq+JEaYKFj j7lHElH8pycb5tVBNhvAACygNyfntQryXRiD4cAGiUtrML6OGIBkIDaIUyn/bH1pT3Nk mbEUKAeUZDcLk7U/O4lCYCQ20NPOfui8QBFwVFHzmaRu0QeeN2Og9A741HgBzdhG8grL 0Fa4ls1CABD03p++A9w9y1DX1LB3k/YCpqruWCGpbWMhT8gYBlG0FkPBdY7CY2TJ6Rv7 zdjgfbCO6oeuAuaxBG8OZL7CZTm5vMaWRgC+QgxY4dNb3Qyr3OJHAc71TYnJp9bl2noX xv7Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=YEfovM2NKT8ag9TvqZ5TvTpEztKPhuBS/BnjHfStf3g=; b=bXhSqFzlKx/xjvnqNbcbpC0nyooZ5igGs4INdf9i9B7pLGGshPu4MsTVFqEZ/HUL8k L2hEllWSsU2eu+FN+KNqTxmc2LpU1Wc61Dkvr+mrm6jITMDVFs8SEYe5bXEgwQQxznHL duVJmHxWTHfYPGIKxvk5+M5zhd0G2E97ilXZ5BJSqGIMLcxQ6KmXBjhCU0iNRN946dHQ g/SKHgX8Sr3T6JTmEu03u5Xo/Wa4EzJbELkp9lLFvuudNFBARdoPtKgZuP22ssaXQGle ulzYE4ziTEmw1gzW8zM8UEeHeLaW+GzM4qAYuvbQDCM0Omo1dJmRA1jv51dknxbmwzib Kcgg== X-Gm-Message-State: AOAM533mLHBATZiSA32YgafOYgRYurJ4J9vC/vcEKvMb6DDhquvLIkex JmDQPhFA0w0ZnhVq68WL89n0jw== X-Received: by 2002:a1c:87:: with SMTP id 129mr4460111wma.183.1610136946590; Fri, 08 Jan 2021 12:15:46 -0800 (PST) Received: from dell.default ([91.110.221.229]) by smtp.gmail.com with ESMTPSA id l8sm15598671wrb.73.2021.01.08.12.15.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 08 Jan 2021 12:15:45 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Subject: [PATCH 29/40] drm/amd/display/dc/dce/dce_dmcu: Staticify local function call 'dce_dmcu_load_iram' Date: Fri, 8 Jan 2021 20:14:46 +0000 Message-Id: <20210108201457.3078600-30-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210108201457.3078600-1-lee.jones@linaro.org> References: <20210108201457.3078600-1-lee.jones@linaro.org> MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Krunoslav Kovac , Leo Li , linux-kernel@vger.kernel.org, amd-gfx@lists.freedesktop.org, David Airlie , dri-devel@lists.freedesktop.org, Alex Deucher , =?utf-8?q?Christian_K=C3=B6nig?= Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/amd/amdgpu/../display/dc/dce/dce_dmcu.c:74:6: warning: no previous prototype for ‘dce_dmcu_load_iram’ [-Wmissing-prototypes] In file included from drivers/gpu/drm/amd/amdgpu/../display/dc/dce/dce_dmcu.c:31: Cc: Harry Wentland Cc: Leo Li Cc: Alex Deucher Cc: "Christian König" Cc: David Airlie Cc: Daniel Vetter Cc: Krunoslav Kovac Cc: amd-gfx@lists.freedesktop.org Cc: dri-devel@lists.freedesktop.org Signed-off-by: Lee Jones --- drivers/gpu/drm/amd/display/dc/dce/dce_dmcu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/display/dc/dce/dce_dmcu.c b/drivers/gpu/drm/amd/display/dc/dce/dce_dmcu.c index f3ed8b619cafd..fa2b47d41ee2f 100644 --- a/drivers/gpu/drm/amd/display/dc/dce/dce_dmcu.c +++ b/drivers/gpu/drm/amd/display/dc/dce/dce_dmcu.c @@ -71,7 +71,7 @@ static bool dce_dmcu_init(struct dmcu *dmcu) return true; } -bool dce_dmcu_load_iram(struct dmcu *dmcu, +static bool dce_dmcu_load_iram(struct dmcu *dmcu, unsigned int start_offset, const char *src, unsigned int bytes) From patchwork Fri Jan 8 20:14:47 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 359057 Delivered-To: patch@linaro.org Received: by 2002:a02:85a7:0:0:0:0:0 with SMTP id d36csp856000jai; Fri, 8 Jan 2021 12:15:59 -0800 (PST) X-Google-Smtp-Source: ABdhPJxCKmMlhIloCv1LEC9X+Kg3Ssl/Aa/kXsrGUziqsfG4nWuAkg3Q6vLmtVNCDgkv/5sW4SJC X-Received: by 2002:a63:5124:: with SMTP id f36mr8483793pgb.106.1610136958901; Fri, 08 Jan 2021 12:15:58 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1610136958; cv=none; d=google.com; s=arc-20160816; b=FqfwNZXc7nNeDtUmLnic8jpXaaoz8BUA/1K/seH0w3s/R1Tzj39mMx88tV2gcCEBJk ECwjH32EEQ01lhaRhqo8s8HYdrXaE1EqC/qBk0NxxHvYH+5kmmfwtZJZOVM485s6I1JY SGbZqiGVQJ0a1u9DOLIWqiHlj8bSHQXmDIs+by8Y+u7IHpVouPHzi5fW7iP2WXlh273I jl5Vb4oSdfmS+UMYHfM34yvpA436Ae6skD5hX5JfycFBN7Iok9hZM6SN8zCHyMmkws5P rz4USMxTZk8NrBx1mPAF5T2JWypGBz0dEOTWebCiYVEuHNyB2J9yg7Kola64rfmNcwA3 X+XA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:cc:list-subscribe :list-help:list-post:list-archive:list-unsubscribe:list-id :precedence:mime-version:references:in-reply-to:message-id:date :subject:to:from:dkim-signature:delivered-to; bh=GEUKOa4LrCrO/Y0lPS6xKfsH+q4KSXPCpUud0fpCb5Y=; b=zosgCKeqiUcO/Xt5qMlE8Wq2zF9C5IV9ofIhUQlPMl3zAVI8wZrda1dcCh10XyY77G niVt8LW+gWTnaU4PMZTMoLBdrznpx7qE3aMC3i4ZRlyN0L9auWm6iUbwJGBz5AXGhDGO C1Gu2VKhkN/LveevAfI+f05aKsAnpQNxrkOjvFcw2khUM9pGkI/Gd5UmLZdqN2ylkanx XfOIRNAcglg/L8EqExHjF/Gwwn1d4HxgJDfR266wsfZFg2HtK3fOZ9F/3x6dm+0Sg6fG 0rLjNWK0vWQqj0gt+uQekZGIRzTj7MJ8aukuYqP9tbRMv6s5+tAFWjOyHM3Hkg70sVT+ OOsA== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=LF0DUdko; spf=pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 2610:10:20:722:a800:ff:fe36:1795 as permitted sender) smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from gabe.freedesktop.org (gabe.freedesktop.org. [2610:10:20:722:a800:ff:fe36:1795]) by mx.google.com with ESMTPS id w125si10038634pfb.32.2021.01.08.12.15.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 08 Jan 2021 12:15:58 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 2610:10:20:722:a800:ff:fe36:1795 as permitted sender) client-ip=2610:10:20:722:a800:ff:fe36:1795; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=LF0DUdko; spf=pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 2610:10:20:722:a800:ff:fe36:1795 as permitted sender) smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id E16506E8E2; Fri, 8 Jan 2021 20:15:52 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mail-wr1-x435.google.com (mail-wr1-x435.google.com [IPv6:2a00:1450:4864:20::435]) by gabe.freedesktop.org (Postfix) with ESMTPS id 3C99B6E8DC for ; Fri, 8 Jan 2021 20:15:49 +0000 (UTC) Received: by mail-wr1-x435.google.com with SMTP id m5so10133889wrx.9 for ; Fri, 08 Jan 2021 12:15:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=2YbZqZMpXxFWUfLfazawHX6Ul5l98eF2j1+JdfYq+I0=; b=LF0DUdkoHdmvzblDhce37V9TWsLDe1dZxIxHP/4mt1D85NHvxbmxWWFNmay9mC0Anm +fH5Rwe0O2yf+zgF/VUlOw9Tmo7+cNs1Jtkf0U8SXp1rRQcDCzePm/cF5MzshIn253wB D96pZSPhRi7PfxFyz/KxNaBO5MYrKdpX7nWcyOoMC30hZX/Ze71Rm/b2RJfh+nF5/303 xZz/GpqBv9yIKyYzQUy5PeKKCvNiD4YcxZiGK4DUpi0C0RPPViCNf0nX3haG7pfr5JXh W9DcQGuPGcp4MDnI5hxDlQAL0z37BfAcQjLlnLkJHYIf4jEFDypcBec0Xm5SHbJeiqna Wypg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=2YbZqZMpXxFWUfLfazawHX6Ul5l98eF2j1+JdfYq+I0=; b=bAPN6QUUTa2WNUdLdBl8fAU50X7fwP9pJMDwRb33wmrpUv3ORa1PtP0gQbe/Ze85Ov vIH141HwNR3BssNF1nfRdmJTEly4ZbJ3CNScfRUAtQSwO2JS6iZi07MIfIpPM4J88cQf YKiabgb7pa4oU4CKswyjhBZQtT3gXNZwM50IzFIVEIc88I9nUjf3wWSYgqSq7yZtkbTu m7TM1AQjEPIa2Q7553jEtLChq4/2tf00JnaEROcHfpUcM4aEF5+9BXAaYxR0nSmvbgHa ooMb1lopIX8c2afAGUy4S/VaUjiZ8UBlw0ItUbG6eDdNO8m6rGofVdHCsmEQYKIBOkRE 53kQ== X-Gm-Message-State: AOAM530RGKDc59qNE0LwC6YxQ1P3hUQHYGSMei5LSMB4ip30ECexRAuO 0BeX0LMHTmQ3V/B/GgbcNuswag== X-Received: by 2002:adf:c18d:: with SMTP id x13mr5165454wre.128.1610136947898; Fri, 08 Jan 2021 12:15:47 -0800 (PST) Received: from dell.default ([91.110.221.229]) by smtp.gmail.com with ESMTPSA id l8sm15598671wrb.73.2021.01.08.12.15.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 08 Jan 2021 12:15:47 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Subject: [PATCH 30/40] drm/amd/display/dc/dce/dce_dmcu: Move 'abm_gain_stepsize' to only source file it's used in Date: Fri, 8 Jan 2021 20:14:47 +0000 Message-Id: <20210108201457.3078600-31-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210108201457.3078600-1-lee.jones@linaro.org> References: <20210108201457.3078600-1-lee.jones@linaro.org> MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Leo Li , Mauro Rossi , linux-kernel@vger.kernel.org, amd-gfx@lists.freedesktop.org, David Airlie , dri-devel@lists.freedesktop.org, Alex Deucher , =?utf-8?q?Christian_K=C3=B6nig?= Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" And only declare it if it's to be used. Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/amd/amdgpu/../display/dc/dce/dce_dmcu.h:320:23: warning: ‘abm_gain_stepsize’ defined but not used [-Wunused-const-variable=] drivers/gpu/drm/amd/amdgpu/../display/dc/dce/dce_dmcu.h:320:23: warning: ‘abm_gain_stepsize’ defined but not used [-Wunused-const-variable=] drivers/gpu/drm/amd/amdgpu/../display/dc/dce/dce_dmcu.h:320:23: warning: ‘abm_gain_stepsize’ defined but not used [-Wunused-const-variable=] drivers/gpu/drm/amd/amdgpu/../display/dc/dce/dce_dmcu.h:320:23: warning: ‘abm_gain_stepsize’ defined but not used [-Wunused-const-variable=] drivers/gpu/drm/amd/amdgpu/../display/dc/dce/dce_dmcu.h:320:23: warning: ‘abm_gain_stepsize’ defined but not used [-Wunused-const-variable=] drivers/gpu/drm/amd/amdgpu/../display/dc/dce/dce_dmcu.h:320:23: warning: ‘abm_gain_stepsize’ defined but not used [-Wunused-const-variable=] drivers/gpu/drm/amd/amdgpu/../display/dc/dce/dce_dmcu.h:320:23: warning: ‘abm_gain_stepsize’ defined but not used [-Wunused-const-variable=] Cc: Harry Wentland Cc: Leo Li Cc: Alex Deucher Cc: "Christian König" Cc: David Airlie Cc: Daniel Vetter Cc: Mauro Rossi Cc: amd-gfx@lists.freedesktop.org Cc: dri-devel@lists.freedesktop.org Signed-off-by: Lee Jones --- drivers/gpu/drm/amd/display/dc/dce/dce_dmcu.c | 4 ++++ drivers/gpu/drm/amd/display/dc/dce/dce_dmcu.h | 2 -- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/amd/display/dc/dce/dce_dmcu.c b/drivers/gpu/drm/amd/display/dc/dce/dce_dmcu.c index fa2b47d41ee2f..30264fc151a2b 100644 --- a/drivers/gpu/drm/amd/display/dc/dce/dce_dmcu.c +++ b/drivers/gpu/drm/amd/display/dc/dce/dce_dmcu.c @@ -65,6 +65,10 @@ //Register access policy version #define mmMP0_SMN_C2PMSG_91 0x1609B +#if defined(CONFIG_DRM_AMD_DC_DCN) +static const uint32_t abm_gain_stepsize = 0x0060; +#endif + static bool dce_dmcu_init(struct dmcu *dmcu) { // Do nothing diff --git a/drivers/gpu/drm/amd/display/dc/dce/dce_dmcu.h b/drivers/gpu/drm/amd/display/dc/dce/dce_dmcu.h index 93e7f34d4775e..cefb7f5bf42cc 100644 --- a/drivers/gpu/drm/amd/display/dc/dce/dce_dmcu.h +++ b/drivers/gpu/drm/amd/display/dc/dce/dce_dmcu.h @@ -317,6 +317,4 @@ struct dmcu *dcn21_dmcu_create( void dce_dmcu_destroy(struct dmcu **dmcu); -static const uint32_t abm_gain_stepsize = 0x0060; - #endif /* _DCE_ABM_H_ */ From patchwork Fri Jan 8 20:14:48 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 359056 Delivered-To: patch@linaro.org Received: by 2002:a02:85a7:0:0:0:0:0 with SMTP id d36csp855985jai; Fri, 8 Jan 2021 12:15:57 -0800 (PST) X-Google-Smtp-Source: ABdhPJxxoPKQP1qWUO1Mo/WAOhxzDfqBdAkU6fQOXaobyiycPk6oc1b4hM/0eArUqVl/JSsGGsmu X-Received: by 2002:a17:90a:b110:: with SMTP id z16mr5348487pjq.167.1610136957606; Fri, 08 Jan 2021 12:15:57 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1610136957; cv=none; d=google.com; s=arc-20160816; b=HDFIGj231AS58vV+N07YrQZh6wjtTbCTH3e2raJ+4yHTa6gRLbfFsY6Sq/DEtrJtMS LjgKVKsQH6I+SGkFk3fkeMTS4nvC6omcWj9u0z21HKZDZCtKislkydqddeagqPKgjd6R G4+HulO2ThGGqAFxW8sY6nV8ADv/PHCf2oybvdwyBYf1c+EEuVbNem5F14NlMjlbZwM9 XIxXk+u3y1V6A+oYNQ8paKMxFeEhqL3vwoVNgovDGz1z816C5aceUmby4w40tP7pwB2o cUiz7g6e8CPk27rSCxYYRFVOXRjcgsTi+IBqrVrtFVHM2aSm1kCEBQAzToyhFArFD8vX Dv+A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:cc:list-subscribe :list-help:list-post:list-archive:list-unsubscribe:list-id :precedence:mime-version:references:in-reply-to:message-id:date :subject:to:from:dkim-signature:delivered-to; bh=lVOxdDOEIrJ9Z7ZbDJ+S/3SaWd0+5dZLY5jpvSrCSvs=; b=UEIi0/XSDtUAs++kz9JhrCVq1zFj1ml4e10opCx08AvCHqePlkbliWlNeD7HaOUIL2 2sgkAJsS1g+MbrEq1BONugVdNlTQ1EjBxzKULZappROkDDCNuMQxTFODp6OJooDRHy8R Hba4zbwgc+XXPpfKfuA0KrqMPCVllSDDV1Kdz+Tt5NeBUsS34hPKhqmZrJJoBamG56zt UER3zsURZ3arhgnjDWeZPc/PZAx1U2NB3NAlV0zL/u0vDpKOw9Fu1/vK5GVdBFJe/B4f Qz7w4FVYgP+bjDbO5aModRPDnORHI2SCpy/+IHH4glatmUMa6fwLLHF0SkAPo+u1Og40 Yshw== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b="o3+1v//I"; spf=pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 131.252.210.177 as permitted sender) smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from gabe.freedesktop.org (gabe.freedesktop.org. [131.252.210.177]) by mx.google.com with ESMTPS id t11si9875467plr.343.2021.01.08.12.15.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 08 Jan 2021 12:15:57 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 131.252.210.177 as permitted sender) client-ip=131.252.210.177; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b="o3+1v//I"; spf=pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 131.252.210.177 as permitted sender) smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 857646E8C5; Fri, 8 Jan 2021 20:15:53 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mail-wm1-x330.google.com (mail-wm1-x330.google.com [IPv6:2a00:1450:4864:20::330]) by gabe.freedesktop.org (Postfix) with ESMTPS id 844A66E8E2 for ; Fri, 8 Jan 2021 20:15:50 +0000 (UTC) Received: by mail-wm1-x330.google.com with SMTP id 3so9431613wmg.4 for ; Fri, 08 Jan 2021 12:15:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=zW3ufI7pY7JKZ5jgf9PFOiorHzk8Ikn536vctwi0D0o=; b=o3+1v//IuiO8OWf1LsRbjZv/Xs6WgdkPiA0liTKkThpPTBjfWe46BeDVSY32inCCQr ipNhPObHC4cpO9eg3wFEcYD4IkaSKkd0DwOj2e1mllIpDfTF4f7hUlU29AANQ9RJDYe/ hxT5H7cx6tbtdM72Oq51SIdiuL8P4vQ6OEU300+iwQEHxGWipdoNLvPXoVAK4XGdJDnS pUikoZhdHW1KTDHclPBwb2FLIinrwM07ZMcGAQtC5eDawXjDNoNrXLXOhRntsxiIwhe+ jMbiszhFMrXF/EBDYGL9bFTO1UnUxx+55azoVqpmoyaoxaemhPWP9X4DG/JkoQoDwO43 BZSw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=zW3ufI7pY7JKZ5jgf9PFOiorHzk8Ikn536vctwi0D0o=; b=YAnrrgq5OWDkbwm8NIu4vzJl8ytARQj5RyTEmYtvThrO3+8P0rO9dLYflDH9QOHKAL onYWdljwWwzl9wujNb4YMRdFfImVh8eAi1YMMIJ5TudXj1oeztUmFaGNbrpiquCagXd9 j9GENKku3PSd+J18o+qRCR/t+wgherfF79qiWaPBPQcgxTSSQYfZB3VTVQtZflvR48C3 7RRLjzW4qYvzb4wffGjl76S9HPJUWKYxExX9DE66DV7IJGlekIq0lyHDdiPwIGb4IqaZ ma+14ssUg1oOtqj4KKinGfXzmoY3YN/ZQ7ozXf8QN3rmulLuhaKNsIREysP0pc+Kdjjv VMiw== X-Gm-Message-State: AOAM5320FKtKuzgpwmqidPrxtCKKuqTD8y4+ho8RnNFvNjIFX4ROrBoL gVk/ueisGy45OwGhqhYtxNgfLw== X-Received: by 2002:a1c:f604:: with SMTP id w4mr4580747wmc.39.1610136949189; Fri, 08 Jan 2021 12:15:49 -0800 (PST) Received: from dell.default ([91.110.221.229]) by smtp.gmail.com with ESMTPSA id l8sm15598671wrb.73.2021.01.08.12.15.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 08 Jan 2021 12:15:48 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Subject: [PATCH 31/40] drm/amd/display/dc/dce/dce_opp: Make local functions and ones invoked by reference static Date: Fri, 8 Jan 2021 20:14:48 +0000 Message-Id: <20210108201457.3078600-32-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210108201457.3078600-1-lee.jones@linaro.org> References: <20210108201457.3078600-1-lee.jones@linaro.org> MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Leo Li , Mauro Rossi , linux-kernel@vger.kernel.org, amd-gfx@lists.freedesktop.org, David Airlie , dri-devel@lists.freedesktop.org, Alex Deucher , =?utf-8?q?Christian_K=C3=B6nig?= Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/amd/amdgpu/../display/dc/dce/dce_opp.c:427:6: warning: no previous prototype for ‘dce60_opp_set_clamping’ [-Wmissing-prototypes] drivers/gpu/drm/amd/amdgpu/../display/dc/dce/dce_opp.c:548:6: warning: no previous prototype for ‘dce60_opp_program_bit_depth_reduction’ [-Wmissing-prototypes] drivers/gpu/drm/amd/amdgpu/../display/dc/dce/dce_opp.c:571:6: warning: no previous prototype for ‘dce60_opp_program_clamping_and_pixel_encoding’ [-Wmissing-prototypes] drivers/gpu/drm/amd/amdgpu/../display/dc/dce/dce_opp.c:681:6: warning: no previous prototype for ‘dce60_opp_program_fmt’ [-Wmissing-prototypes] Cc: Harry Wentland Cc: Leo Li Cc: Alex Deucher Cc: "Christian König" Cc: David Airlie Cc: Daniel Vetter Cc: Mauro Rossi Cc: amd-gfx@lists.freedesktop.org Cc: dri-devel@lists.freedesktop.org Signed-off-by: Lee Jones --- drivers/gpu/drm/amd/display/dc/dce/dce_opp.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/amd/display/dc/dce/dce_opp.c b/drivers/gpu/drm/amd/display/dc/dce/dce_opp.c index e459ae65aaf76..2bf8f5a2e0c22 100644 --- a/drivers/gpu/drm/amd/display/dc/dce/dce_opp.c +++ b/drivers/gpu/drm/amd/display/dc/dce/dce_opp.c @@ -424,7 +424,7 @@ void dce110_opp_set_clamping( * 7 for programable * 2) Enable clamp if Limited range requested */ -void dce60_opp_set_clamping( +static void dce60_opp_set_clamping( struct dce110_opp *opp110, const struct clamping_and_pixel_encoding_params *params) { @@ -545,7 +545,7 @@ void dce110_opp_program_bit_depth_reduction( } #if defined(CONFIG_DRM_AMD_DC_SI) -void dce60_opp_program_bit_depth_reduction( +static void dce60_opp_program_bit_depth_reduction( struct output_pixel_processor *opp, const struct bit_depth_reduction_params *params) { @@ -568,7 +568,7 @@ void dce110_opp_program_clamping_and_pixel_encoding( } #if defined(CONFIG_DRM_AMD_DC_SI) -void dce60_opp_program_clamping_and_pixel_encoding( +static void dce60_opp_program_clamping_and_pixel_encoding( struct output_pixel_processor *opp, const struct clamping_and_pixel_encoding_params *params) { @@ -678,7 +678,7 @@ void dce110_opp_program_fmt( } #if defined(CONFIG_DRM_AMD_DC_SI) -void dce60_opp_program_fmt( +static void dce60_opp_program_fmt( struct output_pixel_processor *opp, struct bit_depth_reduction_params *fmt_bit_depth, struct clamping_and_pixel_encoding_params *clamping) From patchwork Fri Jan 8 20:14:49 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 359059 Delivered-To: patch@linaro.org Received: by 2002:a02:85a7:0:0:0:0:0 with SMTP id d36csp856033jai; Fri, 8 Jan 2021 12:16:01 -0800 (PST) X-Google-Smtp-Source: ABdhPJyZG0pfymuu+s0MnGBo3irtFEnkx1nDjUp6n6iUn18D5nCRVMU82/WTxr24zS2ojyJ9imyh X-Received: by 2002:a17:902:26a:b029:da:af47:77c7 with SMTP id 97-20020a170902026ab02900daaf4777c7mr8758341plc.10.1610136961631; Fri, 08 Jan 2021 12:16:01 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1610136961; cv=none; d=google.com; s=arc-20160816; b=fbAEPJkt95i69hCZEltIibK32adLp109FKVHsUcGsyihF15l1yjv/tdTSwXBImn0oS sHU/cnHVy0brPazPHqqfuDwdVlgtyioh/JL8tMFUL1G8MTCPPXqXgVdMxrxwSvPsFSXL rQeMpZe6pkfsnD9tGHnKZ+xpXCHMSIq5Gx5M628RmQGADBdSACgILAaxHQtK521xOrwk gY+CEuyGJJp0D+NxepxYSmh+wymezn47oLlqLG7MR5gHOVgmadV4IrrgEU/TC6qMhEDS 4vWYKoGMpEVnL0VdeXbOF7l5ww7WzHJ8lE17w4RLvxcPR2ENAv+ghgIvVcMUUwRpC92d NYgw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:cc:list-subscribe :list-help:list-post:list-archive:list-unsubscribe:list-id :precedence:mime-version:references:in-reply-to:message-id:date :subject:to:from:dkim-signature:delivered-to; bh=tEMHoEV3JgPNzP6AsbU15jye94fkDyciUt66774RBU4=; b=BZPjhvWWplcjFFG/DM48KslxX9/hiPbyMscrppyb18PRqUbxoWiAonBLWC5i00irn7 zFsQRBeuOZGGQmWVkC9qiVvpPS5seBGdH32BNe8P4gR6oR4vRgZZ0ITdN1ZXD9vwnfRY 8JnMvg/T3wFsCRFt65agwR+tW9YfcBknAJ00jBLYtMaiBQOlOmMEWtyevRPeU0t5Kaga EMn+M9JVzTiDSqvw7I+5X8RDVWWvEN12n8vd1GpMPBJDLfMECuoiIr5S5ONMuFeQDHaB /HP3IwQKImm6mTiiJFV54y97wAeyTp7t1/iyZQbq4nI5Ge32veEbdcCvgCUn/3XjYApo v+8A== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=mCIOoMf7; spf=pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 2610:10:20:722:a800:ff:fe36:1795 as permitted sender) smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from gabe.freedesktop.org (gabe.freedesktop.org. [2610:10:20:722:a800:ff:fe36:1795]) by mx.google.com with ESMTPS id c24si10380606pls.221.2021.01.08.12.16.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 08 Jan 2021 12:16:01 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 2610:10:20:722:a800:ff:fe36:1795 as permitted sender) client-ip=2610:10:20:722:a800:ff:fe36:1795; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=mCIOoMf7; spf=pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 2610:10:20:722:a800:ff:fe36:1795 as permitted sender) smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id A06E16E8C2; Fri, 8 Jan 2021 20:15:54 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mail-wm1-x32e.google.com (mail-wm1-x32e.google.com [IPv6:2a00:1450:4864:20::32e]) by gabe.freedesktop.org (Postfix) with ESMTPS id F19CB6E8C2 for ; Fri, 8 Jan 2021 20:15:51 +0000 (UTC) Received: by mail-wm1-x32e.google.com with SMTP id g25so7364631wmh.1 for ; Fri, 08 Jan 2021 12:15:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=rwsQ4P/R4DdLdAB3mC1JWRMOEYxyTXQ+mvrg/Opzxxc=; b=mCIOoMf78yv6vZZRz9P4wRu711vAOmJTwcFZoHf9+OnpmMqUsDtTYQIRLbXprNM/2H 4UfuwGilLCVSnL0T33A638w9j5Plzpi5879F8q0wGGeRbuXHv0g3Mc5tBd5TyblfbsHZ 7a0sEXSkfnc2IwoIsWbQgXKSJWupcPEyeD8QaKNxMSonEX6o1yjMoRMbb9DHohKA/wiK Bk+bXH5mp0I9WKSr/u7LGmoYrJWvVuUDHMMrEFUPRI2MMhnnJVNzCl4eAAgVZW6f29fu M+DxM1w1qHWhwYyNjb7nHLliZ6TWEeRMvqCoMYvv86Z4/hpX2Vj23HE9Ii5cJ+rAcOoO 9Vag== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=rwsQ4P/R4DdLdAB3mC1JWRMOEYxyTXQ+mvrg/Opzxxc=; b=WFXaZNltEcg412tdDQqzJz8x0D/Uo9rDor/NvnrxX/PNxdwBFKHDwUoG1AM6qmzwip K5s5moIhq2uE0NV4+2RIJwpOg/KOpbvee+fe7PN/0pTgRUrLCJDDNVhxgI9z6t+EfMGg hZI8A/5UkMdW94MEGdxC6DaqloJlUHYpl5lRaAPQhh3lz38qtXbfz7ddyVCVV40FMrBe rF+MEhI/7NYSkBFt8V9tOIJ/1h/A8hifDthzkuihwO8ndMtoWPB75yQLeY0mqqvHEzA7 9UsdI/AOcBerwNGIkc3ASFT51Bt1iCmCacvKMS+ptr57p8Eht3scmm+Jc4FucLZEdxAH kPhg== X-Gm-Message-State: AOAM533UaukHLraOYh2Gvk0tkl/PEbLdRkiDW0Ez0yGc/QgPVeHoxzea FPy3tpKSUfz2sBfdh/lYrP2Z0A== X-Received: by 2002:a1c:2b46:: with SMTP id r67mr4491346wmr.162.1610136950667; Fri, 08 Jan 2021 12:15:50 -0800 (PST) Received: from dell.default ([91.110.221.229]) by smtp.gmail.com with ESMTPSA id l8sm15598671wrb.73.2021.01.08.12.15.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 08 Jan 2021 12:15:50 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Subject: [PATCH 32/40] drm/amd/display/dc/dce/dce_aux: Remove unused function 'get_engine_type' Date: Fri, 8 Jan 2021 20:14:49 +0000 Message-Id: <20210108201457.3078600-33-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210108201457.3078600-1-lee.jones@linaro.org> References: <20210108201457.3078600-1-lee.jones@linaro.org> MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Leo Li , linux-kernel@vger.kernel.org, amd-gfx@lists.freedesktop.org, David Airlie , dri-devel@lists.freedesktop.org, Alex Deucher , =?utf-8?q?Christian_K=C3=B6nig?= Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/amd/amdgpu/../display/dc/dce/dce_aux.c:391:25: warning: no previous prototype for ‘get_engine_type’ [-Wmissing-prototypes] Cc: Harry Wentland Cc: Leo Li Cc: Alex Deucher Cc: "Christian König" Cc: David Airlie Cc: Daniel Vetter Cc: amd-gfx@lists.freedesktop.org Cc: dri-devel@lists.freedesktop.org Signed-off-by: Lee Jones --- drivers/gpu/drm/amd/display/dc/dce/dce_aux.c | 6 ------ 1 file changed, 6 deletions(-) diff --git a/drivers/gpu/drm/amd/display/dc/dce/dce_aux.c b/drivers/gpu/drm/amd/display/dc/dce/dce_aux.c index cda5fd0464bc5..3204292a5aeae 100644 --- a/drivers/gpu/drm/amd/display/dc/dce/dce_aux.c +++ b/drivers/gpu/drm/amd/display/dc/dce/dce_aux.c @@ -388,12 +388,6 @@ static enum aux_channel_operation_result get_channel_status( } } -enum i2caux_engine_type get_engine_type( - const struct dce_aux *engine) -{ - return I2CAUX_ENGINE_TYPE_AUX; -} - static bool acquire( struct dce_aux *engine, struct ddc *ddc) From patchwork Fri Jan 8 20:14:50 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 359058 Delivered-To: patch@linaro.org Received: by 2002:a02:85a7:0:0:0:0:0 with SMTP id d36csp856012jai; Fri, 8 Jan 2021 12:16:00 -0800 (PST) X-Google-Smtp-Source: ABdhPJzGey8fgF5akXQa0eSPl2eBU8HVtTCWZgF2aT4qLHJ1YhMckzPWpw/WApGZug411i7oS9Cm X-Received: by 2002:a62:b410:0:b029:1a4:7868:7e4e with SMTP id h16-20020a62b4100000b02901a478687e4emr5366558pfn.62.1610136960399; Fri, 08 Jan 2021 12:16:00 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1610136960; cv=none; d=google.com; s=arc-20160816; b=OGbI/+wACnn42umsHtD3u/NN44TY40o8HGlGENAoJyQQFfQfONi6XBTNHpJdriw2hm LU2pH2Tkkomj1MKgXU4l13pAq3iIO2yWZ7aoO41Rvxfg+846BWekzq8sLQiE89ldR/4O se8gZFUrNm+GJgW4M0FZ+SQFpjsZ5tXVtWxhCaQn6v0+L1q8Lf4+8eMY27RU+3SSacCj bpygfb7E4aYczxd+5RI/HqiASB5NZ59LFOeCoRSjYnzoESvnmblVfbm2Hs5yIgH/USjB /qJ3mBBZcS8myuqE4XssYK4UBBha8szAwcnmwbx46fZdq4rYYRrIlmijp8HenLg/DfH1 vCGQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:cc:list-subscribe :list-help:list-post:list-archive:list-unsubscribe:list-id :precedence:mime-version:references:in-reply-to:message-id:date :subject:to:from:dkim-signature:delivered-to; bh=Qb76jhtwGojk7rstB4SzonGiHiOzYhoouVk2kq7OFBw=; b=C8xzpFropK/rz6FIFeHrB7Yt8Sg0IS750uG7j4IgS1pqU2IgP+DMiS1gYvtlIV1pil g/zBDj10hF+goPUFfX2p2qqu3b4/9rYD4rf5OdsgYe8ocB6/MkLXY/v3U3SSVKKCkeer ePSYu4O4NBAxaWkv3a6KNGQI27EkZ+Qvh4MfrR7qascLUUsdI5Du5WyMq9hVhszWe8/P jVTRIjb/T0dY3dLQ9wUYrmsb6zg4UrCG0F/5SottqVCN1WswapzcdMdn43T7HKow5Bmu wQt0nnBQ0eK7n7jrgFGn6HsjwpaYRafDvdCEVcFBmtpxL6hubqjpKd3QIedXgVDas22N iR8g== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=b+8BELUy; spf=pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 2610:10:20:722:a800:ff:fe36:1795 as permitted sender) smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from gabe.freedesktop.org (gabe.freedesktop.org. [2610:10:20:722:a800:ff:fe36:1795]) by mx.google.com with ESMTPS id b4si10382318pgg.291.2021.01.08.12.16.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 08 Jan 2021 12:16:00 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 2610:10:20:722:a800:ff:fe36:1795 as permitted sender) client-ip=2610:10:20:722:a800:ff:fe36:1795; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=b+8BELUy; spf=pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 2610:10:20:722:a800:ff:fe36:1795 as permitted sender) smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 2AAE76E8EE; Fri, 8 Jan 2021 20:15:55 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mail-wm1-x333.google.com (mail-wm1-x333.google.com [IPv6:2a00:1450:4864:20::333]) by gabe.freedesktop.org (Postfix) with ESMTPS id 5E9106E8E3 for ; Fri, 8 Jan 2021 20:15:53 +0000 (UTC) Received: by mail-wm1-x333.google.com with SMTP id g185so9442330wmf.3 for ; Fri, 08 Jan 2021 12:15:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=0meb7DEluI5lCKKHhFh+KkZgGQmTED8UYQgsHtPH9AI=; b=b+8BELUy6TYHrFE+ojlTD5o+vZ/tEQjDu8czZAvyrxub0pcI6chJUoZ2lCPjCPjABv 9+quXXFHdgT6Fpuo23j3qGFJi++XkryIYAjEaiCDSGXtAvRT9g1+Br7tew2FKxP4QU07 gLqxjq5/JKGeu+mhZHe5oN34VfOToSNyGQZvfc3QyL3AhJpOP2PyMwkzdeDcf3JXETdM +H/AiCaoEElkLOGti7xyPj7B/4lLWROEMkhiKh6Nzrryo1rOp18oWdsPR1pU6AukN/Qa Xukv2856sxNpzczu/PirBr3Ic93WgRUohpIWkUXjlu+/FzLwF2/0auSZoWOC7qcY0LVT IPhA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=0meb7DEluI5lCKKHhFh+KkZgGQmTED8UYQgsHtPH9AI=; b=o1MekUoVCZmzJaDM2c8sJ6OzXFKk7vFLDm/iCdEajeKnt0J1d7lsfMTuo72X6AOAQM phKGNSDhJ14ItYdDRucfYEmpGb7yOsNvgpFtWz1Ydk889rmGoiGgTBQvCwlX6LW68p9e ZePN5WOhSkSwT0m6NKPgd6HhnTu6fghJedEP/FEJhaJYR6qUjRDy+qXTrEctvWhzUoc0 LSz4Xj5pHfea7rmUeiR2AHlRRqZNttVoSXR5nIgpP7qOtqqQ+tRRkOC47ZL7+A3QrOgD P8dSML5/wtPKMofkGBTNpljt73BgkAwXPk1QEy0Y5/sCiudVFR8EoENT1ge+OK2+lyfZ 4zCQ== X-Gm-Message-State: AOAM533JQxg8Ey9ZvDC8j0rfGP5m2vlejThODGUPOgZODdWVm6RlLU5k hJumSGNX5S1b9YuM/e5b6F2ARw== X-Received: by 2002:a1c:1fc2:: with SMTP id f185mr4612278wmf.134.1610136952039; Fri, 08 Jan 2021 12:15:52 -0800 (PST) Received: from dell.default ([91.110.221.229]) by smtp.gmail.com with ESMTPSA id l8sm15598671wrb.73.2021.01.08.12.15.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 08 Jan 2021 12:15:51 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Subject: [PATCH 33/40] drm/nouveau/nvkm/subdev/volt/gk20a: Demote non-conformant kernel-doc headers Date: Fri, 8 Jan 2021 20:14:50 +0000 Message-Id: <20210108201457.3078600-34-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210108201457.3078600-1-lee.jones@linaro.org> References: <20210108201457.3078600-1-lee.jones@linaro.org> MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: David Airlie , nouveau@lists.freedesktop.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Ben Skeggs Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/nouveau/nvkm/subdev/volt/gk20a.c:53: warning: Function parameter or member 'speedo' not described in 'gk20a_volt_get_cvb_voltage' drivers/gpu/drm/nouveau/nvkm/subdev/volt/gk20a.c:53: warning: Function parameter or member 's_scale' not described in 'gk20a_volt_get_cvb_voltage' drivers/gpu/drm/nouveau/nvkm/subdev/volt/gk20a.c:53: warning: Function parameter or member 'coef' not described in 'gk20a_volt_get_cvb_voltage' drivers/gpu/drm/nouveau/nvkm/subdev/volt/gk20a.c:69: warning: Function parameter or member 'speedo' not described in 'gk20a_volt_get_cvb_t_voltage' drivers/gpu/drm/nouveau/nvkm/subdev/volt/gk20a.c:69: warning: Function parameter or member 'temp' not described in 'gk20a_volt_get_cvb_t_voltage' drivers/gpu/drm/nouveau/nvkm/subdev/volt/gk20a.c:69: warning: Function parameter or member 's_scale' not described in 'gk20a_volt_get_cvb_t_voltage' drivers/gpu/drm/nouveau/nvkm/subdev/volt/gk20a.c:69: warning: Function parameter or member 't_scale' not described in 'gk20a_volt_get_cvb_t_voltage' drivers/gpu/drm/nouveau/nvkm/subdev/volt/gk20a.c:69: warning: Function parameter or member 'coef' not described in 'gk20a_volt_get_cvb_t_voltage' Cc: Ben Skeggs Cc: David Airlie Cc: Daniel Vetter Cc: dri-devel@lists.freedesktop.org Cc: nouveau@lists.freedesktop.org Signed-off-by: Lee Jones --- drivers/gpu/drm/nouveau/nvkm/subdev/volt/gk20a.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) -- 2.25.1 _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel diff --git a/drivers/gpu/drm/nouveau/nvkm/subdev/volt/gk20a.c b/drivers/gpu/drm/nouveau/nvkm/subdev/volt/gk20a.c index ce5d83cdc7cf7..207e5278b37ed 100644 --- a/drivers/gpu/drm/nouveau/nvkm/subdev/volt/gk20a.c +++ b/drivers/gpu/drm/nouveau/nvkm/subdev/volt/gk20a.c @@ -45,7 +45,7 @@ static const struct cvb_coef gk20a_cvb_coef[] = { /* 852 */ { 1608418, -21643, -269, 0, 763, -48}, }; -/** +/* * cvb_mv = ((c2 * speedo / s_scale + c1) * speedo / s_scale + c0) */ static inline int @@ -58,7 +58,7 @@ gk20a_volt_get_cvb_voltage(int speedo, int s_scale, const struct cvb_coef *coef) return mv; } -/** +/* * cvb_t_mv = * ((c2 * speedo / s_scale + c1) * speedo / s_scale + c0) + * ((c3 * speedo / s_scale + c4 + c5 * T / t_scale) * T / t_scale) From patchwork Fri Jan 8 20:14:51 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 359063 Delivered-To: patch@linaro.org Received: by 2002:a02:85a7:0:0:0:0:0 with SMTP id d36csp856101jai; Fri, 8 Jan 2021 12:16:07 -0800 (PST) X-Google-Smtp-Source: ABdhPJz+DpXXjPJfrlDa+Xttdj/+C628fKlc9WUwJKUZ3xqQ/F51gsCxp5ZzKFWT37yXowdrie7r X-Received: by 2002:a17:90a:e513:: with SMTP id t19mr5388184pjy.85.1610136967691; Fri, 08 Jan 2021 12:16:07 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1610136967; cv=none; d=google.com; s=arc-20160816; b=FPYXQbclyvV1JjRokLcMxfmpHijfDZGkLsTsD44FTuheihKkD1K9yc3W1n/iW422hm wp92DWv5C1U5/m1N5wEZa0ZbZ6/LyDPZH6Xer+XUPH16d295fR3hiVEJzIdSshwj6i7S q1Wjw0s6izA5Yf6SKp+QcwIHoA1rIlz2yvLIHuaBe6fIZIGCHLOfVuD5iOw0E8g257WX ndf1o5PrcqdmqIHZNr9naNt+/dpqgUStQyLIzt8sF/6P1vpT/n2WB7FMPtzYGhQp+dev u/YebqYTBzBdXeKpebcT30K25S1lyTW2oPJVl3gvTxkgSku51GvOqkJaX0DHh5bY8pZv 9ugw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:cc:list-subscribe :list-help:list-post:list-archive:list-unsubscribe:list-id :precedence:mime-version:references:in-reply-to:message-id:date :subject:to:from:dkim-signature:delivered-to; bh=oJmP84UlJHo3GqlxRko9g+EuWfKyjMpk9jo0SZtkq9M=; b=TKdx9Efd9JAVGprpPl5D51aMSi0KbW5b6dYmuuunO+pBvu/IGn7JK219jDoS+6O4lq mDw6bnWASWbNbUJ90xTB+lMqv+tV1HTC1I0d4l23L/tTU+peFzK4Irpz3ugIiyPUL+gq BS4veTpZKpLKZXvOllhjfpBxbq+mFyjuHpFHum/197VbKtqm6fOCHMUaWGwTMflbFYIN bV/LIOycGaYWFBVR9qT3nZG/h4OV4FPYt0yuZh7AlD0sSYnT6wQriHVHbCdSIiI++qVo Fj4oUyfweNvxWUWu/qElNOI6uQjtdoPql+D30cM1B7NoYcX6e28jg+vT0nzU+lRwOqdM FR6A== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=eR0e+bPT; spf=pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 2610:10:20:722:a800:ff:fe36:1795 as permitted sender) smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from gabe.freedesktop.org (gabe.freedesktop.org. [2610:10:20:722:a800:ff:fe36:1795]) by mx.google.com with ESMTPS id z7si6182562pgz.556.2021.01.08.12.16.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 08 Jan 2021 12:16:07 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 2610:10:20:722:a800:ff:fe36:1795 as permitted sender) client-ip=2610:10:20:722:a800:ff:fe36:1795; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=eR0e+bPT; spf=pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 2610:10:20:722:a800:ff:fe36:1795 as permitted sender) smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 17A686E8DC; Fri, 8 Jan 2021 20:16:02 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mail-wr1-x433.google.com (mail-wr1-x433.google.com [IPv6:2a00:1450:4864:20::433]) by gabe.freedesktop.org (Postfix) with ESMTPS id C3DFF6E8E3 for ; Fri, 8 Jan 2021 20:15:54 +0000 (UTC) Received: by mail-wr1-x433.google.com with SMTP id d13so10097995wrc.13 for ; Fri, 08 Jan 2021 12:15:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=ltlvlK446O5/kBCmREtmpcuBIIBe0mrhh4gHbZyrmLA=; b=eR0e+bPTMpDaQ5oVw+vorFfL18IIvsq9WMtJycz42nqe7lxrgpYAG+NnSqXEbvEPi8 VS8S6QvbmXY4DPgbH94+g8zc924maSiO9NmbgYltoBkVxN1f2D9fpIwVo7iGozb/ic86 R3wNL6C+wYq21lo0a6RGpG/We0wBq/no3/33xHyZ0I5G9cBZ10CDxQNUkE7nrutviyoX g6nEgtqpjZM7Fei3hvQDT2w7dyEFEmxPNoDLO2Oo9Qjd0XacLjqQBA5gJXQerw8m8LoY k3pMqPeXeo6pPh7ItawXSn1KL07TrqeD7nEcVbxfJs9/EJ0g5lBh96lDFF0oFIL7u9xv bb8g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=ltlvlK446O5/kBCmREtmpcuBIIBe0mrhh4gHbZyrmLA=; b=eZkqPiNUZjvCoAo0W+G94f5ihGoJzNuWHrwp33JWt78V9tQH8TP94xcnom7Lli/mv6 sUCvXS3RrfUGZl/prFjdzpJfOz03apty1X7LgGv7VwSEDsRjNBDOjoqVKCOYA1mPhAWN LfMxAs0167r+m43zfrhQ3kt6lLyPUbolUjDFwiBPArlkalYUba7RzgPVxmPer2YGkYNy sGAvK0FGnoPDaSqN+Bt7qsjhK7Y+Ad5a94OVFDAveGPNG6HCId60y/rHdem4MtjFmC5A 3tPKG71E/7PBGATUKKGdAXAqMijcFqxoe6xn1z/a6tzpFVePDilRq+iQEhQxvHJVioKA 3jrQ== X-Gm-Message-State: AOAM533wL4zb8UAp/KhYvkAVRq63ia3pqXQcHX8XI/ZkUC3L3Nwh/5lr NhSmbaV8IhguxJvSGhkSupniJQ== X-Received: by 2002:adf:9467:: with SMTP id 94mr5370698wrq.235.1610136953419; Fri, 08 Jan 2021 12:15:53 -0800 (PST) Received: from dell.default ([91.110.221.229]) by smtp.gmail.com with ESMTPSA id l8sm15598671wrb.73.2021.01.08.12.15.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 08 Jan 2021 12:15:52 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Subject: [PATCH 34/40] drm/amd/display/dc/bios/bios_parser: Fix misspelling of function parameter Date: Fri, 8 Jan 2021 20:14:51 +0000 Message-Id: <20210108201457.3078600-35-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210108201457.3078600-1-lee.jones@linaro.org> References: <20210108201457.3078600-1-lee.jones@linaro.org> MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Leo Li , linux-kernel@vger.kernel.org, amd-gfx@lists.freedesktop.org, David Airlie , dri-devel@lists.freedesktop.org, Alex Deucher , =?utf-8?q?Christian_K=C3=B6nig?= Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/amd/amdgpu/../display/dc/bios/bios_parser.c:997: warning: Function parameter or member 'ss_info' not described in 'get_ss_info_from_tbl' drivers/gpu/drm/amd/amdgpu/../display/dc/bios/bios_parser.c:997: warning: Excess function parameter 'ssinfo' description in 'get_ss_info_from_tbl' Cc: Harry Wentland Cc: Leo Li Cc: Alex Deucher Cc: "Christian König" Cc: David Airlie Cc: Daniel Vetter Cc: Lee Jones Cc: amd-gfx@lists.freedesktop.org Cc: dri-devel@lists.freedesktop.org Signed-off-by: Lee Jones --- drivers/gpu/drm/amd/display/dc/bios/bios_parser.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/amd/display/dc/bios/bios_parser.c b/drivers/gpu/drm/amd/display/dc/bios/bios_parser.c index d2654c50b0b20..c67d21a5ee52f 100644 --- a/drivers/gpu/drm/amd/display/dc/bios/bios_parser.c +++ b/drivers/gpu/drm/amd/display/dc/bios/bios_parser.c @@ -987,8 +987,8 @@ static enum bp_result get_ss_info_from_internal_ss_info_tbl_V2_1( * * @bp: pointer to the BIOS parser * @id: spread sprectrum info index - * @ssinfo: sprectrum information structure, - * return:: BIOS parser result code + * @ss_info: sprectrum information structure, + * return: BIOS parser result code */ static enum bp_result get_ss_info_from_tbl( struct bios_parser *bp, From patchwork Fri Jan 8 20:14:52 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 359060 Delivered-To: patch@linaro.org Received: by 2002:a02:85a7:0:0:0:0:0 with SMTP id d36csp856051jai; Fri, 8 Jan 2021 12:16:03 -0800 (PST) X-Google-Smtp-Source: ABdhPJxBtk4bBaTPf2sHxDNDwKQ0BfDLsFj7IMU6Nl+T1+7R0E+ohHmpmfsqaRN0GeGY9qekazg6 X-Received: by 2002:a17:90a:6708:: with SMTP id n8mr5547586pjj.35.1610136963518; Fri, 08 Jan 2021 12:16:03 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1610136963; cv=none; d=google.com; s=arc-20160816; b=EN+hoCBzEoNHgeeUEr7clz2B+kf/HkSWLQr23s14j5dRpNw1IoGrdUsLOpHD8x8eTB M83/ThG+jyvMZL83qPHlT2EpsGC/qitb+RVjoBxiR/iEW2+VbTkvlfdgjGKQfV/h7OLW 1Tu3RDmiB7n+5/N5Fjo9nF/sweQTZwQBvAhdEVnM++JZ0w1BkSD+wP0KedQRWGGP9O/e GtMmjzEEiWTZyeA6ZOSdBlsAkWhaGyV0LVRcdT5Wsftb4IlGRRI9JWlEU2Ke2co5U9t4 5gXdOro9oPOA8PbVgQpDEIR7jRdlhbuVLihRYhvSnKESgQjuFM/8CQcndTpA8CVu777F fJ/Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:cc:list-subscribe :list-help:list-post:list-archive:list-unsubscribe:list-id :precedence:mime-version:references:in-reply-to:message-id:date :subject:to:from:dkim-signature:delivered-to; bh=tOh+1MICNILh20HIZEQItdUxz82TYtaSrIcezRhOKFo=; b=z4QvZhNBzlWV1nOfysQe4nZrhsvjXN7B85G6F2yTocpod7w+H9pag29TKRhQluKaQ9 1mJwI8rVnO1CzYbGPIELPy9y8OZiPsLeteQJJTMJKtWqAmhsfJ2v0ihA4vwcj/S4TSTK 5yrSJ6xox7RxCPnvObCRAC3nYFIZhprPTek8mKsQZFJ1cVyMILMIIEarwxLIv+1MXlss u4IpF0UkzkGjp4NoZt7TANxofFEK8QRT3OboWBAaJ1rDJNmz6dTExSimurF85U+aDUk4 OlC9NGlQ+rlYOL4X8GH99c+qP3wq3Guo5Llb1xdkSJj8WZKDhXe6Pe80xliZILOiYjUp IDgg== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=i15bgqSq; spf=pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 2610:10:20:722:a800:ff:fe36:1795 as permitted sender) smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from gabe.freedesktop.org (gabe.freedesktop.org. [2610:10:20:722:a800:ff:fe36:1795]) by mx.google.com with ESMTPS id s1si6583463pjg.123.2021.01.08.12.16.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 08 Jan 2021 12:16:03 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 2610:10:20:722:a800:ff:fe36:1795 as permitted sender) client-ip=2610:10:20:722:a800:ff:fe36:1795; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=i15bgqSq; spf=pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 2610:10:20:722:a800:ff:fe36:1795 as permitted sender) smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 9CC796E8C6; Fri, 8 Jan 2021 20:15:58 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mail-wm1-x32f.google.com (mail-wm1-x32f.google.com [IPv6:2a00:1450:4864:20::32f]) by gabe.freedesktop.org (Postfix) with ESMTPS id 1C84E6E8E9 for ; Fri, 8 Jan 2021 20:15:56 +0000 (UTC) Received: by mail-wm1-x32f.google.com with SMTP id 190so8768437wmz.0 for ; Fri, 08 Jan 2021 12:15:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=qIhMmTlrgLqGKZHl8cf8zzphKFqEw09UTmu2NuirXK8=; b=i15bgqSq9ykGyz3gETyCT7w+EtHlx00MftV3j03IlIh377fbzIy+8wNbC6kfg0Txi6 MVyYPJhXGEOWYgkShWn/U2+kiLs9a1CXSRknF3aZeUg6F2AJI7WFtapb4NoNF59k3+IY pHJ3u7G9Ytbq7xjqL80iGO2CxSF6zikmkWHaZhwnsMdPwp+4hHUj8dJe84C3u9XjsSqI zVBLkvbRa/EBuAsT4KBWrk/fL2Fupd7vj9HgeeoC0KYkR+hZQWvmq1hDw/U9JY6IS6pG IbRGIRUn+cTUiwoT/c9lNtoqm7qDm9V2gkvsUS5Qy4CfKVfoH/z+X0pKBz4xwGHzOUXo +kug== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=qIhMmTlrgLqGKZHl8cf8zzphKFqEw09UTmu2NuirXK8=; b=e+Qa2KwlwFBiDWoNEOTS7EwvqJZTcwCcCxPrb5WTvCXc0BSpXZL3s4+TPnpPeyY4qh Aj8nMQKMaDFQUWWaIVih6LS5xX7uCgfSa8dfRgqNliNzXWiVFUEY33yx0qlyuTTD4whB RfwRewyN7X9cz5Cy2ATRVUdDkFs7Db8YwF1d/be3/uXEe0RdhmGzwQye5DQVMesiUOrw AvWiy2i5RnZ4KntXzC3t7DBwadnXgUnVv76FwKJD/8/vWh+Y9jBvXvJDT0Vzq9PViO/J SVfrY28/mUubVyIm1rCOFZCqh6qCdIbOXzcprVJerpIzr+zyYBHZCtaU0YgjeVXeJQG4 ldkQ== X-Gm-Message-State: AOAM530/bihcaw5ofkQPQGE8h/YXGevU7N23up2zRzr74rUQJh+/R651 JYWShs0KBqFRywaFm6L/ugCOZA== X-Received: by 2002:a1c:61c3:: with SMTP id v186mr4496283wmb.146.1610136954798; Fri, 08 Jan 2021 12:15:54 -0800 (PST) Received: from dell.default ([91.110.221.229]) by smtp.gmail.com with ESMTPSA id l8sm15598671wrb.73.2021.01.08.12.15.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 08 Jan 2021 12:15:54 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Subject: [PATCH 35/40] drm/amd/display/dc/bios/command_table: Remove unused variable and associated comment Date: Fri, 8 Jan 2021 20:14:52 +0000 Message-Id: <20210108201457.3078600-36-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210108201457.3078600-1-lee.jones@linaro.org> References: <20210108201457.3078600-1-lee.jones@linaro.org> MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Leo Li , linux-kernel@vger.kernel.org, amd-gfx@lists.freedesktop.org, David Airlie , dri-devel@lists.freedesktop.org, Alex Deucher , =?utf-8?q?Christian_K=C3=B6nig?= Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/amd/amdgpu/../display/dc/bios/command_table.c: In function ‘adjust_display_pll_v2’: drivers/gpu/drm/amd/amdgpu/../display/dc/bios/command_table.c:1462:11: warning: unused variable ‘pixel_clock_10KHz_in’ [-Wunused-variable] Cc: Harry Wentland Cc: Leo Li Cc: Alex Deucher Cc: "Christian König" Cc: David Airlie Cc: Daniel Vetter Cc: Lee Jones Cc: amd-gfx@lists.freedesktop.org Cc: dri-devel@lists.freedesktop.org Signed-off-by: Lee Jones --- drivers/gpu/drm/amd/display/dc/bios/command_table.c | 4 ---- 1 file changed, 4 deletions(-) diff --git a/drivers/gpu/drm/amd/display/dc/bios/command_table.c b/drivers/gpu/drm/amd/display/dc/bios/command_table.c index dd893a1176979..66fe1d1810789 100644 --- a/drivers/gpu/drm/amd/display/dc/bios/command_table.c +++ b/drivers/gpu/drm/amd/display/dc/bios/command_table.c @@ -1457,10 +1457,6 @@ static enum bp_result adjust_display_pll_v2( { enum bp_result result = BP_RESULT_FAILURE; - /* We need to convert from KHz units into 10KHz units and then convert - * output pixel clock back 10KHz-->KHz */ - uint32_t pixel_clock_10KHz_in = bp_params->pixel_clock / 10; - bp->cmd_helper->encoder_id_to_atom( dal_graphics_object_id_get_encoder_id(bp_params->encoder_object_id)); bp->cmd_helper->encoder_mode_bp_to_atom(bp_params->signal_type, false); From patchwork Fri Jan 8 20:14:53 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 359061 Delivered-To: patch@linaro.org Received: by 2002:a02:85a7:0:0:0:0:0 with SMTP id d36csp856064jai; Fri, 8 Jan 2021 12:16:04 -0800 (PST) X-Google-Smtp-Source: ABdhPJw0Q/CNRymd0L7oYcFxsUC1FrMgelUPfWN6KzdYgX4fwrArgZBUcQQwl3k4K/7HfxVAn7yu X-Received: by 2002:a17:902:c193:b029:da:ea4f:af79 with SMTP id d19-20020a170902c193b02900daea4faf79mr8757415pld.14.1610136964572; Fri, 08 Jan 2021 12:16:04 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1610136964; cv=none; d=google.com; s=arc-20160816; b=uanvDZJhOj3pUhyaX/YOYyr/p1X3uk9bJS81XaprgjhZC6elngsXXS1Pb/RIj+zDp8 7395qNMQng4YjYh8tpyYqvcGjgU62fxDi9zOV1+A4hEaFgAy2JhyNcaX28KtxJ02C3qL IFHlP1LSwOBA58V8H0UwSutZZ+7wCyk3EiD+flZnOrKUWfUKAJKxXrerkF37bK+hxkE4 TT2MtdM5Ctb4siUGnBZdzm0IgvhU9H2rIJuV+BligPm+VmQolH+S4bhnXAqXMakUGHN+ gxLorw4UJub3kq6cPeySOsT4hY3Z6s3g9tGw5WwY1Sm3rTY7wH9JNnwPAnEmMiDZYsJQ Tx6A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:cc:list-subscribe :list-help:list-post:list-archive:list-unsubscribe:list-id :precedence:mime-version:references:in-reply-to:message-id:date :subject:to:from:dkim-signature:delivered-to; bh=HVxQuFzSG4w+oquQzJPibjTL+pnk5Ivuz2FsxRPoVzI=; b=w29glzeeYTxyrEnB1OpiLn/xj0Ux3GAXv9FQxXTvj2WL24mkDV9chhTtsLyq0Lx2cF NmrMulDiGsqi5OwD9ON50fHcSyPLwSqsT4Vy7CO98Ay1l0Wsy4fKZvXxsd6uRnYkPAIr zGZFZWjUNLydabhbcZYp3ZHeLnnfSQdRLrM+ZnbMZk04E62YRY2RxOTE3o5bh9vcbTuB 6N1BTv/Mx+KDEyuvwn2SzaYwnwPWQBjtBQErXz4dP5Om+MQiuGC4jxExLbo19muJMKh3 AgabNF5JffpuIfFQcpzeCsbQlBoM9KcONlucj5e9tT21tNByFgmdrP7g4Y8TmRQ/ilFQ MRNw== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=xw+bWeaE; spf=pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 2610:10:20:722:a800:ff:fe36:1795 as permitted sender) smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from gabe.freedesktop.org (gabe.freedesktop.org. [2610:10:20:722:a800:ff:fe36:1795]) by mx.google.com with ESMTPS id k5si10276726pgl.494.2021.01.08.12.16.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 08 Jan 2021 12:16:04 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 2610:10:20:722:a800:ff:fe36:1795 as permitted sender) client-ip=2610:10:20:722:a800:ff:fe36:1795; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=xw+bWeaE; spf=pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 2610:10:20:722:a800:ff:fe36:1795 as permitted sender) smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id C5C296E8CC; Fri, 8 Jan 2021 20:15:59 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mail-wr1-x435.google.com (mail-wr1-x435.google.com [IPv6:2a00:1450:4864:20::435]) by gabe.freedesktop.org (Postfix) with ESMTPS id C0A066E8C9 for ; Fri, 8 Jan 2021 20:15:57 +0000 (UTC) Received: by mail-wr1-x435.google.com with SMTP id t16so10169438wra.3 for ; Fri, 08 Jan 2021 12:15:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=tI0M520Tgf6Y/taglfeuNx5F4TLLe4OwvIOR0TyXZnU=; b=xw+bWeaEAWYrLVo8JxLnuBuwmxbi1iNsGy74mXZlvGNQ6Azts3YZMI9w5upfCOF1Tv ueejiFcYOTXV6jCZekcU8peSlcaVLVQR40i6N5WOK9qCJDOKgh6i5k+Ga3zjF4FmDOh7 YJT9ZbCtfyjv1dNcHC3TxSyqBmoN65o2gglwSmZAUODShuenX/YQTTDETct5ct6hQf2h 5YqNt9G1X9GUf8AmiY5eYEEW2GiZcPuiwUDJFHVOS6tCpZoWjAOOOHanmL9q2j2LyUGD R/vhENw9F8tYjeE7VhfKmnFgFBaK1ft6esGzXdO3uvtaj2eBjk6SEYx4KZc3erYgr6nd c4vg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=tI0M520Tgf6Y/taglfeuNx5F4TLLe4OwvIOR0TyXZnU=; b=kr4mN2IHMMRAfuS+9gMqPaQfYVjABLKZ72sIkAiCJo2YnECfrJMG1hgTINn5ng8xl6 9oZ5MRit29Svu4sD3Req1NObCz9uXsbX+X16YJoYmL86hu8ywgKy9bDE6L75rCVATEgp SBStBkOzMmxvmSQhmIeYiJxPUsb4LtFfEzDsT4Ozl/0dF3gtRyQTWTunGoJ823+s7g2k vFCpCoB4seTDajGv4NrQADu0SmFNoziHW6voX9xMb97UV1o5owZp9/mH4NQ2WOhGbbvT +PWjr/P5/gff7c/5TdMh69Zgrp8T9LK2evtmePvE5EQFYTuahlut74KvqrcxOlczFttS I9Zg== X-Gm-Message-State: AOAM530S0zxbPMrXlv+ZyBG0TCKdDQZel/B7ypnxutE9q1Ik/lF6OeCT WOEZKNR7PJr0b7S+//hE3GD0EA== X-Received: by 2002:adf:e590:: with SMTP id l16mr5282481wrm.294.1610136956461; Fri, 08 Jan 2021 12:15:56 -0800 (PST) Received: from dell.default ([91.110.221.229]) by smtp.gmail.com with ESMTPSA id l8sm15598671wrb.73.2021.01.08.12.15.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 08 Jan 2021 12:15:55 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Subject: [PATCH 36/40] drm/amd/display/dc/dce/dce_i2c_hw: Make functions called by reference static Date: Fri, 8 Jan 2021 20:14:53 +0000 Message-Id: <20210108201457.3078600-37-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210108201457.3078600-1-lee.jones@linaro.org> References: <20210108201457.3078600-1-lee.jones@linaro.org> MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Lewis Huang , Leo Li , linux-kernel@vger.kernel.org, amd-gfx@lists.freedesktop.org, David Airlie , dri-devel@lists.freedesktop.org, Alex Deucher , =?utf-8?q?Christian_K=C3=B6nig?= Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/amd/amdgpu/../display/dc/dce/dce_i2c_hw.c:438:35: warning: no previous prototype for ‘dce_i2c_hw_engine_wait_on_operation_result’ [-Wmissing-prototypes] drivers/gpu/drm/amd/amdgpu/../display/dc/dce/dce_i2c_hw.c:505:6: warning: no previous prototype for ‘dce_i2c_hw_engine_submit_payload’ [-Wmissing-prototypes] Cc: Harry Wentland Cc: Leo Li Cc: Alex Deucher Cc: "Christian König" Cc: David Airlie Cc: Daniel Vetter Cc: Lewis Huang Cc: amd-gfx@lists.freedesktop.org Cc: dri-devel@lists.freedesktop.org Signed-off-by: Lee Jones --- drivers/gpu/drm/amd/display/dc/dce/dce_i2c_hw.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/amd/display/dc/dce/dce_i2c_hw.c b/drivers/gpu/drm/amd/display/dc/dce/dce_i2c_hw.c index 7fbd92fbc63a9..a524f471e0d75 100644 --- a/drivers/gpu/drm/amd/display/dc/dce/dce_i2c_hw.c +++ b/drivers/gpu/drm/amd/display/dc/dce/dce_i2c_hw.c @@ -435,7 +435,7 @@ struct dce_i2c_hw *acquire_i2c_hw_engine( return dce_i2c_hw; } -enum i2c_channel_operation_result dce_i2c_hw_engine_wait_on_operation_result( +static enum i2c_channel_operation_result dce_i2c_hw_engine_wait_on_operation_result( struct dce_i2c_hw *dce_i2c_hw, uint32_t timeout, enum i2c_channel_operation_result expected_result) @@ -502,7 +502,7 @@ static uint32_t get_transaction_timeout_hw( return period_timeout * num_of_clock_stretches; } -bool dce_i2c_hw_engine_submit_payload( +static bool dce_i2c_hw_engine_submit_payload( struct dce_i2c_hw *dce_i2c_hw, struct i2c_payload *payload, bool middle_of_transaction, From patchwork Fri Jan 8 20:14:54 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 359064 Delivered-To: patch@linaro.org Received: by 2002:a02:85a7:0:0:0:0:0 with SMTP id d36csp856118jai; Fri, 8 Jan 2021 12:16:09 -0800 (PST) X-Google-Smtp-Source: ABdhPJzX/0S2umy+OoKm7a4IaQpnrSfysCxmU1iXYHChMZnvB9Wc6xTrU1Y0kB84+8GhKlvesCiI X-Received: by 2002:aa7:95a4:0:b029:19e:abd2:4a88 with SMTP id a4-20020aa795a40000b029019eabd24a88mr8644186pfk.2.1610136969148; Fri, 08 Jan 2021 12:16:09 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1610136969; cv=none; d=google.com; s=arc-20160816; b=m1BgNYE6eNUk6gT2eWjwIl8E4ZXazJftgVJMzSXN+aoboleEcukGnXwhV/+yelV7EJ cgbnM/Of7prl0rkF4WfiltM9rz1KHyzcECL02EetQQ8t22mQ8dNWEDDRc4cqH+dtjsZ5 pmTlsEXZlr8DmI8srvau3DaPpH+MFfTCv5nRsxE/AygVJZ6sM5xHjasq0sS4t94tuPFq ID+fLIiuEIwPd0wTNJjGBajICOnkxoyHV5CgEBd85d97VMa4LxNAdTd/BWZV4RFpOa0Z 7ONjxve+g9XJJ0vZiOi7LQ3aXnABS/inECXuzOaV3pVoRiG5wAm2KeEDdJR3WKO994Q2 MUiA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:cc:list-subscribe :list-help:list-post:list-archive:list-unsubscribe:list-id :precedence:mime-version:references:in-reply-to:message-id:date :subject:to:from:dkim-signature:delivered-to; bh=WTW6rBnp+mYpCymZKaQrvR9JWbAnQBByZkrFOJzLiZI=; b=RLhUJbt2ure4Sul7ZB5HVdPE800BRNG8s8x1RyhaetKpm7mq/t3iZUOxwO8lCcXtPt gikFKtYHwFZ3yW2Iz83JQGxIkQrP4PLYWMf6KowUUm1AM9bYpa4bpGO5dF4O8eP9H8Ef 6j5qyPIq0NexHA5lsN/fPWz0vkYAHoVv3uDsJDcCfeVvd4BIQDIc30hN/ZzczL+jo0Z0 71Ws2kXCRj3FKXvRCfCM0OZedvwNnVen+oJ4mXaCIZfBF0ysiGIoirLtTH8qo1TpuKmS Psp6ZJQN3lrTVKcRFxr6+WkVUMRKcYVqHZZtIydGwEX116RYUre3oNR8vwLY/ADWTuLi JI6w== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=ii7134gA; spf=pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 2610:10:20:722:a800:ff:fe36:1795 as permitted sender) smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from gabe.freedesktop.org (gabe.freedesktop.org. [2610:10:20:722:a800:ff:fe36:1795]) by mx.google.com with ESMTPS id t18si6975168pjw.24.2021.01.08.12.16.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 08 Jan 2021 12:16:09 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 2610:10:20:722:a800:ff:fe36:1795 as permitted sender) client-ip=2610:10:20:722:a800:ff:fe36:1795; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=ii7134gA; spf=pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 2610:10:20:722:a800:ff:fe36:1795 as permitted sender) smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id ED6526E8EC; Fri, 8 Jan 2021 20:16:03 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mail-wr1-x42d.google.com (mail-wr1-x42d.google.com [IPv6:2a00:1450:4864:20::42d]) by gabe.freedesktop.org (Postfix) with ESMTPS id 1CC126E8CC for ; Fri, 8 Jan 2021 20:15:59 +0000 (UTC) Received: by mail-wr1-x42d.google.com with SMTP id 91so10154470wrj.7 for ; Fri, 08 Jan 2021 12:15:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=Q0Y2D14a+N1/DuGk1xLenDRRTJldnnwxnydDJYRlWZ0=; b=ii7134gA7Vw7PgBW2x9F5/fqdzcg9nwOHhEMgmTAPmloKouSet+Yv0Eh112bhn7tC8 TsDFdsCmlo+upGbISJMmApS5v1F75lRJVXN/zBKixEhYHpU1ypv6LYXY7uKFXgz4hepX 7MUTHY7finxZpnnkLpsLtHwGg3W4F5uah003asbdtFKBjR49ndtHUMOaGmzR7WKXkScz seeNxJKr3QNgQsJOsLOL+0eQb3NSDpD7LOfZuPb1p/pjFXQOSpGjFbk7/UM4Un6rAmPm bmL9pQ+p4ZIPy/wf00QO8fA+JT3rzOpDgjfbOGxNc09wvJJhZVLi7c67wJ80NU3LrqOC fqEQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=Q0Y2D14a+N1/DuGk1xLenDRRTJldnnwxnydDJYRlWZ0=; b=N9cG3xJ+XfRCi1DMDws6V7EgHv1JlGhQbs8H0d+tPtSoGw7OEGtOv8npjbcNbtloEG Mmhg1JwCBgEjKvVJ7lfHTXU8d/VIlPdsX1rTJ2+w3EoQ9hNjli833H+oiJdy+70mgS7u yj9tsMHrEIV3Yyw1IdFTeYALvO27fFP/b8A+Rk6/UQqUXMv8nIgRuHl2pznCTMc+3PaE nHU6OPv0VoY7T2YzYY6tvJ5uDrK6njoR58chQxzqpzFprUArjmdmlixv+uB16UvFwxMA HakhSVbVSfWRxVujs3ChcB+GkvpiLsENAXRvFudB7yx991h8I0kZqoBfhL3wRHgu/dA2 af0w== X-Gm-Message-State: AOAM531BwkuJaF47zIJIhZLjuIMhDsQQ7B2A9Q4gidTBijnEEt9HefUX 6oVnPv+lhLgJ7xYBw8lMINCYXQ== X-Received: by 2002:adf:a3c1:: with SMTP id m1mr5461472wrb.28.1610136957815; Fri, 08 Jan 2021 12:15:57 -0800 (PST) Received: from dell.default ([91.110.221.229]) by smtp.gmail.com with ESMTPSA id l8sm15598671wrb.73.2021.01.08.12.15.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 08 Jan 2021 12:15:57 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Subject: [PATCH 37/40] drm/amd/display/dc/dce/dce_i2c_sw: Make a bunch of local functions static Date: Fri, 8 Jan 2021 20:14:54 +0000 Message-Id: <20210108201457.3078600-38-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210108201457.3078600-1-lee.jones@linaro.org> References: <20210108201457.3078600-1-lee.jones@linaro.org> MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Leo Li , linux-kernel@vger.kernel.org, amd-gfx@lists.freedesktop.org, David Airlie , dri-devel@lists.freedesktop.org, Alex Deucher , =?utf-8?q?Christian_K=C3=B6nig?= Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/amd/amdgpu/../display/dc/dce/dce_i2c_sw.c:342:6: warning: no previous prototype for ‘dce_i2c_sw_engine_set_speed’ [-Wmissing-prototypes] drivers/gpu/drm/amd/amdgpu/../display/dc/dce/dce_i2c_sw.c:356:6: warning: no previous prototype for ‘dce_i2c_sw_engine_acquire_engine’ [-Wmissing-prototypes] drivers/gpu/drm/amd/amdgpu/../display/dc/dce/dce_i2c_sw.c:400:6: warning: no previous prototype for ‘dce_i2c_sw_engine_submit_channel_request’ [-Wmissing-prototypes] drivers/gpu/drm/amd/amdgpu/../display/dc/dce/dce_i2c_sw.c:443:6: warning: no previous prototype for ‘dce_i2c_sw_engine_submit_payload’ [-Wmissing-prototypes] Cc: Harry Wentland Cc: Leo Li Cc: Alex Deucher Cc: "Christian König" Cc: David Airlie Cc: Daniel Vetter Cc: amd-gfx@lists.freedesktop.org Cc: dri-devel@lists.freedesktop.org Signed-off-by: Lee Jones --- drivers/gpu/drm/amd/display/dc/dce/dce_i2c_sw.c | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/amd/display/dc/dce/dce_i2c_sw.c b/drivers/gpu/drm/amd/display/dc/dce/dce_i2c_sw.c index 87d8428df6c46..6846afd83701b 100644 --- a/drivers/gpu/drm/amd/display/dc/dce/dce_i2c_sw.c +++ b/drivers/gpu/drm/amd/display/dc/dce/dce_i2c_sw.c @@ -339,7 +339,7 @@ static bool start_sync_sw( return false; } -void dce_i2c_sw_engine_set_speed( +static void dce_i2c_sw_engine_set_speed( struct dce_i2c_sw *engine, uint32_t speed) { @@ -353,7 +353,7 @@ void dce_i2c_sw_engine_set_speed( engine->clock_delay = 12; } -bool dce_i2c_sw_engine_acquire_engine( +static bool dce_i2c_sw_engine_acquire_engine( struct dce_i2c_sw *engine, struct ddc *ddc) { @@ -397,7 +397,7 @@ bool dce_i2c_engine_acquire_sw( -void dce_i2c_sw_engine_submit_channel_request( +static void dce_i2c_sw_engine_submit_channel_request( struct dce_i2c_sw *engine, struct i2c_request_transaction_data *req) { @@ -440,7 +440,8 @@ void dce_i2c_sw_engine_submit_channel_request( I2C_CHANNEL_OPERATION_SUCCEEDED : I2C_CHANNEL_OPERATION_FAILED; } -bool dce_i2c_sw_engine_submit_payload( + +static bool dce_i2c_sw_engine_submit_payload( struct dce_i2c_sw *engine, struct i2c_payload *payload, bool middle_of_transaction) From patchwork Fri Jan 8 20:14:55 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 359062 Delivered-To: patch@linaro.org Received: by 2002:a02:85a7:0:0:0:0:0 with SMTP id d36csp856080jai; Fri, 8 Jan 2021 12:16:06 -0800 (PST) X-Google-Smtp-Source: ABdhPJwO3/Ix2vGGzOimDyKSge/NRfRajE+2GYgsgWHwd67FPfC0q/YNTKVcX3QgctQiOb2cvbIj X-Received: by 2002:a63:c64c:: with SMTP id x12mr8861644pgg.293.1610136966017; Fri, 08 Jan 2021 12:16:06 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1610136966; cv=none; d=google.com; s=arc-20160816; b=FRbmAB03g2sU/WLNxrwfFdK/jJCufYcPbc1M0Lu4KwmmDEK20qxlhI9AK0zllKn3HY O4R+Q78rtix3GThBRIxbLd1tFFjBmjUD76pZfuDeywnoYEzL0y6juBmtC8cC995XZYuk B0jqHSf5ZMYdp/5zEJw5Myak+pAMd6d7gmxTNtAMVCubPdReZDGfNmn1jYEN+OCuh7Ag hIcd2yy04EkB+cQB44LJkQQYV73iGaRyzYt1rJjsJhf1uRH2+kD79DIR1YWTj6yj7ecL pJlVBp1PeaUp6r/8foWQ+FEvZvb2xJmDOQgEY3EsYW/wBDrMLwu70i7ubCNte8K0q48c mwAg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:cc:list-subscribe :list-help:list-post:list-archive:list-unsubscribe:list-id :precedence:mime-version:references:in-reply-to:message-id:date :subject:to:from:dkim-signature:delivered-to; bh=sWLN8AI2cQu8LhrSQBW16mBdOKLtMFxHwsBO8C+HN4Q=; b=ACQBPrX9oQIHOS2k/cr9mCPHesL3hnGrbcFaz9bu9BHpE6rRW3ku9pflBBWfEIq5Sl rtl6SvzJjhZ8kg6Topfvbj93PgjMtrw0uSY1gQiZ74OTWlPCtnOtBF+ktLP3qPOtjglR xtpr17W8hDOE5kfAfhjJ9TuVhYusutFVx+GenySfis2tpDtxNc/HaQdW9XirW0hrD7Fm k0rkvmgC1Y8AhwNNfNzyaJ7sTAIhYDGFmffpNxG5XTEbBgvFXPT4l1YRfAlhw7b0LutN R4Q6XfOf6YYnW168od1PD+1oF37ABJG27u4SHBGKdDpIu/lDLRzGn5NAQjun+P9xgcFs Ybtg== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=G8ruob3u; spf=pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 131.252.210.177 as permitted sender) smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from gabe.freedesktop.org (gabe.freedesktop.org. [131.252.210.177]) by mx.google.com with ESMTPS id o9si9884041plx.34.2021.01.08.12.16.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 08 Jan 2021 12:16:06 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 131.252.210.177 as permitted sender) client-ip=131.252.210.177; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=G8ruob3u; spf=pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 131.252.210.177 as permitted sender) smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 8BF696E8C4; Fri, 8 Jan 2021 20:16:01 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mail-wm1-x32d.google.com (mail-wm1-x32d.google.com [IPv6:2a00:1450:4864:20::32d]) by gabe.freedesktop.org (Postfix) with ESMTPS id 7A37D6E8DC for ; Fri, 8 Jan 2021 20:16:00 +0000 (UTC) Received: by mail-wm1-x32d.google.com with SMTP id v14so8751418wml.1 for ; Fri, 08 Jan 2021 12:16:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=TsGB1GbRM0lE0DyQTr0kdLB4zVZuV/mNjcQ+anLlZ8k=; b=G8ruob3uLWUoFGkXg2GA/wzh7YN3To9pFFqngX5lh6jb6ZP9fzcDMAWNtCSRMw0EJI ohAQAqhBbi7T7wkgQHXylQTgplUVDEbTlp08mvRxQzKt1Wv27/kJ12a0pJoYJYGYGUIH Vxd1p29aXq8Eo8L7IZ8M8Aa5x2upHls1cXhgf7hp67wDXkwFgiTd4GSceUNYdVJLGKEJ Gv+ZJB4i/GW//bkLwhkEQ87maDacEv19mt7dOsic8lCQnPaiqcDa+OwmNOYcm4iEk0AS Un+AiOhhi7OBWMPkB0i6OXUtl+noOlMnqhpL2mtwAuC1J2158geqv+1Lbns0tTZhK0Q8 mVrA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=TsGB1GbRM0lE0DyQTr0kdLB4zVZuV/mNjcQ+anLlZ8k=; b=djBq5H0epYAE+l0qm/jgWetz6zWGbLzcJ62bL1D1zmlflwZYerrpJL3+4lFcbNXipT f1cC6kxXQBKy73hxjJ9um4/MErTOqCVWRLA1jmBkqs5pFR8plDl0qQEcDqXaJrm+U/jd FAkMUxCM590rUPf/Q4QkyL03Llyxu3NaNryQkbUVKHa095wjAz1c1BH/UUa6F95rDcB3 jpe9oIgOzUqzmLM3zhqdMwHbOoaqQ577FHEK3ofZOv1GEJWGrFv14CWbvuUnCmQ3P+Lm 7DSthfWdnFCMmcFiTqTZrYtb6tOBSNoP5aVkEomNhMvxwuQIiYEXiCmQSO4tmcc5qc35 TJ5g== X-Gm-Message-State: AOAM531Xv/Va8TkQ8UrnThnw5pMi530rQs52dhBQ+NEMubtvQwnasFpz PEkXap4sXJAzY+AOkdwQauUOrA== X-Received: by 2002:a05:600c:1552:: with SMTP id f18mr4492260wmg.125.1610136959036; Fri, 08 Jan 2021 12:15:59 -0800 (PST) Received: from dell.default ([91.110.221.229]) by smtp.gmail.com with ESMTPSA id l8sm15598671wrb.73.2021.01.08.12.15.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 08 Jan 2021 12:15:58 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Subject: [PATCH 38/40] drm/amd/display/dc/dce/dce_panel_cntl: Remove unused variables 'bl_pwm_cntl' and 'pwm_period_cntl' Date: Fri, 8 Jan 2021 20:14:55 +0000 Message-Id: <20210108201457.3078600-39-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210108201457.3078600-1-lee.jones@linaro.org> References: <20210108201457.3078600-1-lee.jones@linaro.org> MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Leo Li , Anthony Koo , linux-kernel@vger.kernel.org, amd-gfx@lists.freedesktop.org, David Airlie , dri-devel@lists.freedesktop.org, Alex Deucher , =?utf-8?q?Christian_K=C3=B6nig?= Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/amd/amdgpu/../display/dc/dce/dce_panel_cntl.c: In function ‘dce_get_16_bit_backlight_from_pwm’: drivers/gpu/drm/amd/amdgpu/../display/dc/dce/dce_panel_cntl.c:54:11: warning: variable ‘bl_pwm_cntl’ set but not used [-Wunused-but-set-variable] drivers/gpu/drm/amd/amdgpu/../display/dc/dce/dce_panel_cntl.c:53:11: warning: variable ‘pwm_period_cntl’ set but not used [-Wunused-but-set-variable] Cc: Harry Wentland Cc: Leo Li Cc: Alex Deucher Cc: "Christian König" Cc: David Airlie Cc: Daniel Vetter Cc: Anthony Koo Cc: amd-gfx@lists.freedesktop.org Cc: dri-devel@lists.freedesktop.org Signed-off-by: Lee Jones --- drivers/gpu/drm/amd/display/dc/dce/dce_panel_cntl.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/amd/display/dc/dce/dce_panel_cntl.c b/drivers/gpu/drm/amd/display/dc/dce/dce_panel_cntl.c index 761fdfc1f5bd0..e923392358631 100644 --- a/drivers/gpu/drm/amd/display/dc/dce/dce_panel_cntl.c +++ b/drivers/gpu/drm/amd/display/dc/dce/dce_panel_cntl.c @@ -50,16 +50,16 @@ static unsigned int dce_get_16_bit_backlight_from_pwm(struct panel_cntl *panel_c { uint64_t current_backlight; uint32_t round_result; - uint32_t pwm_period_cntl, bl_period, bl_int_count; - uint32_t bl_pwm_cntl, bl_pwm, fractional_duty_cycle_en; + uint32_t bl_period, bl_int_count; + uint32_t bl_pwm, fractional_duty_cycle_en; uint32_t bl_period_mask, bl_pwm_mask; struct dce_panel_cntl *dce_panel_cntl = TO_DCE_PANEL_CNTL(panel_cntl); - pwm_period_cntl = REG_READ(BL_PWM_PERIOD_CNTL); + REG_READ(BL_PWM_PERIOD_CNTL); REG_GET(BL_PWM_PERIOD_CNTL, BL_PWM_PERIOD, &bl_period); REG_GET(BL_PWM_PERIOD_CNTL, BL_PWM_PERIOD_BITCNT, &bl_int_count); - bl_pwm_cntl = REG_READ(BL_PWM_CNTL); + REG_READ(BL_PWM_CNTL); REG_GET(BL_PWM_CNTL, BL_ACTIVE_INT_FRAC_CNT, (uint32_t *)(&bl_pwm)); REG_GET(BL_PWM_CNTL, BL_PWM_FRACTIONAL_EN, &fractional_duty_cycle_en); From patchwork Fri Jan 8 20:14:56 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 359065 Delivered-To: patch@linaro.org Received: by 2002:a02:85a7:0:0:0:0:0 with SMTP id d36csp856138jai; Fri, 8 Jan 2021 12:16:10 -0800 (PST) X-Google-Smtp-Source: ABdhPJzTe9qJ0MkKt30pGhXLqXkBLGv8daQSQne2ZraP+HNV0XICodz29/dQ2vlVC+xKF0rA5xgq X-Received: by 2002:a17:90a:f00f:: with SMTP id bt15mr5522176pjb.209.1610136970518; Fri, 08 Jan 2021 12:16:10 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1610136970; cv=none; d=google.com; s=arc-20160816; b=fGyf+WxwVRBVkxJlQZT2buNaWHQZAWPIhhsoYQ7CFTX5PngkXItUHx70e+i18dgLu0 TVZaUefyQUGr4DwUHCcTC8iWM/32cw5s2CURPeg/p3pfOZkT6G4YQCYpBRgKGDW8B9fK Ky+RhvUSqa13IwdjoBaQwfsHM7E5aORWaYdX1fxRecXmKCoLHYiJjzhQUx2ydkH0Ul4q SVsxB46xw95MGbiJH7n1Z5Tt7+Ri5b+CYQMjb2ezaXnOpuGmCC6AR6tY/y59WH7e4jcp S+UEh6QGQ3vTyPVXlpszZzLjjhSUPjshl4C8buRJ9JCKbn5X2iGVtJIxFlDedVB9kNQR +/fw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:cc:list-subscribe :list-help:list-post:list-archive:list-unsubscribe:list-id :precedence:mime-version:references:in-reply-to:message-id:date :subject:to:from:dkim-signature:delivered-to; bh=IauQM5HjwR6aU3Wmw3ndLSEf39mtFmKh8BDj0jmr3AI=; b=aGvShle1rVWG9ceXi1aD+T8X0SYQ9HVdeh9usmDg4ianDrvQ1cvAZj6cJhjj6JDLyC MCDVeHwvqRRNae4gSS/G1yQGAyJICkUNNjDAEwlAaojnLyHC9KW2/TdivSjnEaO9gfIq 3VrM0YCH1Rc/LHRfxvNnOgbU87FAQaxwGLR1KrHXo5/5ayTfkCsoM8wgYMT+tsMa7eIn eiW0MpJQ7sn/nKXCJ8k1yiUUDV9KeMQ8Wfed79SOlqsHv8u0pEBaHH+5YSsYHR1HNdww AGAmizw2HkZDCEESQTBFQze5GjJ84rvOCKBGNe/yaHnXQwC3pH/va24xoITdaHbQdd3c ZXZA== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=UgwKrpQj; spf=pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 131.252.210.177 as permitted sender) smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from gabe.freedesktop.org (gabe.freedesktop.org. [131.252.210.177]) by mx.google.com with ESMTPS id c17si2751731pfn.327.2021.01.08.12.16.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 08 Jan 2021 12:16:10 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 131.252.210.177 as permitted sender) client-ip=131.252.210.177; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=UgwKrpQj; spf=pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 131.252.210.177 as permitted sender) smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 250756E8D2; Fri, 8 Jan 2021 20:16:06 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mail-wm1-x336.google.com (mail-wm1-x336.google.com [IPv6:2a00:1450:4864:20::336]) by gabe.freedesktop.org (Postfix) with ESMTPS id 96CF56E8EC for ; Fri, 8 Jan 2021 20:16:02 +0000 (UTC) Received: by mail-wm1-x336.google.com with SMTP id 190so8768638wmz.0 for ; Fri, 08 Jan 2021 12:16:02 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=3eWoKxxHh/jIScLnS2QAr46PBCZJOD2Raq8YJ5NQrCs=; b=UgwKrpQj8bI7j36cfQXc3ja3wLCuYNWWeh1QOGINun8I9cI3ipS1TdZ1r+JxJvIkln J2FC1Gro3x2D8HUtUNcnF4ArUwEMcdM2dvZB7fwyTB2yd7K0tFjnIds/fGs0SuxeWAZZ lJrHUGhb2gCxYxqQHczSAhBhInAOO+j2mTmgqS+vdgPW88BQfWPhdYzNECNNbVKZB1mA d+VP6aaHpIKPrjDOw85/gLmOppJ4RZvz4W3n0/LI6KG0DDqsbIwXqLvWPqJ5OIKkEjyZ pvDrl3Brwx05UpHLrWqNsH7vHXaKFgP1YqToxsuwyscSQyxWc/TQYELWFyTgxQBehiYk QXhw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=3eWoKxxHh/jIScLnS2QAr46PBCZJOD2Raq8YJ5NQrCs=; b=ji/i7atK6phObQziuu2vkNKmAqS3PAtioi6HIQ39pj2DFP81MxPXrzDkheQg0p892d 7wyETEnM7x2Ny/pXbyJ9qyg9pMz9BWsDAOC36x4SCk7lsRTkZChlXYrOzqK2UKoK/x4J tPihQNf5klGKeJPsl+yws94zmmFp7+QOJ9G0EWKVdGrF0kHNtgQN6RLOwSBAf/RXK403 FI9hNcg8h2El7VVsTi9eVCIGuKGvBq7N/CDqW8+fCGbICZGzRVyt/jFPHDzQHvQ6UD7F ytcX4JIDNxFjf0BjZJ3Z4gxRG0UVQzapLkg7hNH4G/OuHRhrDvcEK6UvuoZgwoPL+aIs gcqQ== X-Gm-Message-State: AOAM530qDrur67xihdZmorq6H0qt4EyGE7NoZlKfx8gk7kLPOE14FWXw gM+F3fvRN70XJnBgofHLqUwPUg== X-Received: by 2002:a7b:c45a:: with SMTP id l26mr4503703wmi.91.1610136961199; Fri, 08 Jan 2021 12:16:01 -0800 (PST) Received: from dell.default ([91.110.221.229]) by smtp.gmail.com with ESMTPSA id l8sm15598671wrb.73.2021.01.08.12.15.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 08 Jan 2021 12:16:00 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Subject: [PATCH 39/40] drm/amd/display/dc/dce/dmub_psr: Demote non-conformant kernel-doc headers Date: Fri, 8 Jan 2021 20:14:56 +0000 Message-Id: <20210108201457.3078600-40-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210108201457.3078600-1-lee.jones@linaro.org> References: <20210108201457.3078600-1-lee.jones@linaro.org> MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Leo Li , linux-kernel@vger.kernel.org, amd-gfx@lists.freedesktop.org, David Airlie , dri-devel@lists.freedesktop.org, Wyatt Wood , Alex Deucher , =?utf-8?q?Christian_K=C3=B6nig?= Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/amd/amdgpu/../display/dc/dce/dmub_psr.c:38: warning: Function parameter or member 'raw_state' not described in 'convert_psr_state' drivers/gpu/drm/amd/amdgpu/../display/dc/dce/dmub_psr.c:81: warning: Function parameter or member 'dmub' not described in 'dmub_psr_get_state' drivers/gpu/drm/amd/amdgpu/../display/dc/dce/dmub_psr.c:81: warning: Function parameter or member 'state' not described in 'dmub_psr_get_state' drivers/gpu/drm/amd/amdgpu/../display/dc/dce/dmub_psr.c:97: warning: Function parameter or member 'dmub' not described in 'dmub_psr_set_version' drivers/gpu/drm/amd/amdgpu/../display/dc/dce/dmub_psr.c:97: warning: Function parameter or member 'stream' not described in 'dmub_psr_set_version' drivers/gpu/drm/amd/amdgpu/../display/dc/dce/dmub_psr.c:128: warning: Function parameter or member 'dmub' not described in 'dmub_psr_enable' drivers/gpu/drm/amd/amdgpu/../display/dc/dce/dmub_psr.c:128: warning: Function parameter or member 'enable' not described in 'dmub_psr_enable' drivers/gpu/drm/amd/amdgpu/../display/dc/dce/dmub_psr.c:128: warning: Function parameter or member 'wait' not described in 'dmub_psr_enable' drivers/gpu/drm/amd/amdgpu/../display/dc/dce/dmub_psr.c:177: warning: Function parameter or member 'dmub' not described in 'dmub_psr_set_level' drivers/gpu/drm/amd/amdgpu/../display/dc/dce/dmub_psr.c:177: warning: Function parameter or member 'psr_level' not described in 'dmub_psr_set_level' drivers/gpu/drm/amd/amdgpu/../display/dc/dce/dmub_psr.c:203: warning: Function parameter or member 'dmub' not described in 'dmub_psr_copy_settings' drivers/gpu/drm/amd/amdgpu/../display/dc/dce/dmub_psr.c:203: warning: Function parameter or member 'link' not described in 'dmub_psr_copy_settings' drivers/gpu/drm/amd/amdgpu/../display/dc/dce/dmub_psr.c:203: warning: Function parameter or member 'psr_context' not described in 'dmub_psr_copy_settings' drivers/gpu/drm/amd/amdgpu/../display/dc/dce/dmub_psr.c:284: warning: Function parameter or member 'dmub' not described in 'dmub_psr_force_static' drivers/gpu/drm/amd/amdgpu/../display/dc/dce/dmub_psr.c:301: warning: Function parameter or member 'dmub' not described in 'dmub_psr_get_residency' drivers/gpu/drm/amd/amdgpu/../display/dc/dce/dmub_psr.c:301: warning: Function parameter or member 'residency' not described in 'dmub_psr_get_residency' drivers/gpu/drm/amd/amdgpu/../display/dc/dce/dmub_psr.c:323: warning: Function parameter or member 'psr' not described in 'dmub_psr_construct' drivers/gpu/drm/amd/amdgpu/../display/dc/dce/dmub_psr.c:323: warning: Function parameter or member 'ctx' not described in 'dmub_psr_construct' drivers/gpu/drm/amd/amdgpu/../display/dc/dce/dmub_psr.c:332: warning: Function parameter or member 'ctx' not described in 'dmub_psr_create' drivers/gpu/drm/amd/amdgpu/../display/dc/dce/dmub_psr.c:349: warning: Function parameter or member 'dmub' not described in 'dmub_psr_destroy' Cc: Harry Wentland Cc: Leo Li Cc: Alex Deucher Cc: "Christian König" Cc: David Airlie Cc: Daniel Vetter Cc: Wyatt Wood Cc: amd-gfx@lists.freedesktop.org Cc: dri-devel@lists.freedesktop.org Signed-off-by: Lee Jones --- drivers/gpu/drm/amd/display/dc/dce/dmub_psr.c | 22 +++++++++---------- 1 file changed, 11 insertions(+), 11 deletions(-) diff --git a/drivers/gpu/drm/amd/display/dc/dce/dmub_psr.c b/drivers/gpu/drm/amd/display/dc/dce/dmub_psr.c index 17e84f34ceba1..4228caa741193 100644 --- a/drivers/gpu/drm/amd/display/dc/dce/dmub_psr.c +++ b/drivers/gpu/drm/amd/display/dc/dce/dmub_psr.c @@ -31,7 +31,7 @@ #define MAX_PIPES 6 -/** +/* * Convert dmcub psr state to dmcu psr state. */ static enum dc_psr_state convert_psr_state(uint32_t raw_state) @@ -74,7 +74,7 @@ static enum dc_psr_state convert_psr_state(uint32_t raw_state) return state; } -/** +/* * Get PSR state from firmware. */ static void dmub_psr_get_state(struct dmub_psr *dmub, enum dc_psr_state *state) @@ -90,7 +90,7 @@ static void dmub_psr_get_state(struct dmub_psr *dmub, enum dc_psr_state *state) *state = convert_psr_state(raw_state); } -/** +/* * Set PSR version. */ static bool dmub_psr_set_version(struct dmub_psr *dmub, struct dc_stream_state *stream) @@ -121,7 +121,7 @@ static bool dmub_psr_set_version(struct dmub_psr *dmub, struct dc_stream_state * return true; } -/** +/* * Enable/Disable PSR. */ static void dmub_psr_enable(struct dmub_psr *dmub, bool enable, bool wait) @@ -170,7 +170,7 @@ static void dmub_psr_enable(struct dmub_psr *dmub, bool enable, bool wait) } } -/** +/* * Set PSR level. */ static void dmub_psr_set_level(struct dmub_psr *dmub, uint16_t psr_level) @@ -194,7 +194,7 @@ static void dmub_psr_set_level(struct dmub_psr *dmub, uint16_t psr_level) dc_dmub_srv_wait_idle(dc->dmub_srv); } -/** +/* * Setup PSR by programming phy registers and sending psr hw context values to firmware. */ static bool dmub_psr_copy_settings(struct dmub_psr *dmub, @@ -277,7 +277,7 @@ static bool dmub_psr_copy_settings(struct dmub_psr *dmub, return true; } -/** +/* * Send command to PSR to force static ENTER and ignore all state changes until exit */ static void dmub_psr_force_static(struct dmub_psr *dmub) @@ -294,7 +294,7 @@ static void dmub_psr_force_static(struct dmub_psr *dmub) dc_dmub_srv_wait_idle(dc->dmub_srv); } -/** +/* * Get PSR residency from firmware. */ static void dmub_psr_get_residency(struct dmub_psr *dmub, uint32_t *residency) @@ -316,7 +316,7 @@ static const struct dmub_psr_funcs psr_funcs = { .psr_get_residency = dmub_psr_get_residency, }; -/** +/* * Construct PSR object. */ static void dmub_psr_construct(struct dmub_psr *psr, struct dc_context *ctx) @@ -325,7 +325,7 @@ static void dmub_psr_construct(struct dmub_psr *psr, struct dc_context *ctx) psr->funcs = &psr_funcs; } -/** +/* * Allocate and initialize PSR object. */ struct dmub_psr *dmub_psr_create(struct dc_context *ctx) @@ -342,7 +342,7 @@ struct dmub_psr *dmub_psr_create(struct dc_context *ctx) return psr; } -/** +/* * Deallocate PSR object. */ void dmub_psr_destroy(struct dmub_psr **dmub) From patchwork Fri Jan 8 20:14:57 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 359066 Delivered-To: patch@linaro.org Received: by 2002:a02:85a7:0:0:0:0:0 with SMTP id d36csp856156jai; Fri, 8 Jan 2021 12:16:12 -0800 (PST) X-Google-Smtp-Source: ABdhPJyaTVj8VbR7ov6MIsSetK4fXjSfhIp3MLF55MJhWF64XwKIP/HzuRgzRw5xu3Uu2KhXQ+Az X-Received: by 2002:a63:d62:: with SMTP id 34mr8728849pgn.276.1610136971952; Fri, 08 Jan 2021 12:16:11 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1610136971; cv=none; d=google.com; s=arc-20160816; b=lc04fMcky4EqGB1K4rtDa2N2tz0bPqqeuZFzpjPYFWPJeCg/VqG8nsYoaJZAE6ISlc MdwRZI8O7cM0MlKo64KVPLB8VmLOPBndNHcWn7VEUHf3owRt1WrKnLzI4rpp5XfgXzVk yj7wtn5i7rCos0DSFFwBRp5u/LR2NuuEJcKaeZngudigg2snOB1sgaEQkg7sc6N8E+m1 2iHGe6ecnfm5KJK2Ck8sD7DGZnS45LZ0f70hSvgA8ytsnzYvwyQBS1Dv2it0B8EepbTT 8dUDhDcJWFaGlCt97vyOTJmwJPnn9pLljTUo4F0W3OgFFCz0SQOAJ70Ht1D+hJelWvYI ewPw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:cc:list-subscribe :list-help:list-post:list-archive:list-unsubscribe:list-id :precedence:mime-version:references:in-reply-to:message-id:date :subject:to:from:dkim-signature:delivered-to; bh=f5sSxpSIjCwpGMKmY/Y5JNHI9cuqYM34Ph9XfK9cisQ=; b=D3lBjSNVKh90FuRD4VW3+3OYYGkRPaOMmmujqtcOt9gXMJ3nOFG1SYMRhtd9LRO1kX qWt10/D8YnHdGxHhdMjJG/3GOR635J/a7GzKAB1emLTgclZndAtdquzgtU21dFDe8RgO G64L9M2GTQ+hKS2mucU2ctkBmS2TepxWZM1mTYlUmIQbiYicSHUcZCSiy0a+IpoIgKAZ qEVKBu1IyGCCleP/zRdYF4bzdqzApQip7cZVUayy+kZBTjwSZNQ9eQRpO9WDDP8jimQQ ICKTAYew/dFcKnevcVVnjk2gumOWc6d+ZVV0I1uRnCr8SKG1oGdV0wPKE2vTYoJtk/Fj jiaw== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=homuTJBM; spf=pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 131.252.210.177 as permitted sender) smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from gabe.freedesktop.org (gabe.freedesktop.org. [131.252.210.177]) by mx.google.com with ESMTPS id r1si9819073pgv.302.2021.01.08.12.16.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 08 Jan 2021 12:16:11 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 131.252.210.177 as permitted sender) client-ip=131.252.210.177; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=homuTJBM; spf=pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 131.252.210.177 as permitted sender) smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 670466E8EA; Fri, 8 Jan 2021 20:16:07 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mail-wm1-x331.google.com (mail-wm1-x331.google.com [IPv6:2a00:1450:4864:20::331]) by gabe.freedesktop.org (Postfix) with ESMTPS id D3D436E8EA for ; Fri, 8 Jan 2021 20:16:03 +0000 (UTC) Received: by mail-wm1-x331.google.com with SMTP id g25so7364846wmh.1 for ; Fri, 08 Jan 2021 12:16:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=rP7mCQegZrZliKSNOE9HhwYeP/t/E6ng+qbUeSsHO9Y=; b=homuTJBMLHVxCdzu4xZUN8TgcpEBe07I94kMyeGYMSl7Qgq1qQUc6vh772KKH/7CE4 jZX7owmzqV8sN9KKvFWA6BrOu0vo3LI9MCr8+l9YCM6aXjuZAs/zkym4Z1S77ihJxS84 Ly21nzv+rhn4a5PZP837gJI+vKJCphVrU2OMYvLeNravR3zu74QNKK94KT4dLF+W/9dp +WBS/y3XlVzEsOYfoAWk69kPFPH+33qM/VxzJsen0OcLde4/9SYtQjKIrV+Ox+nUTgRG if8rEJarsSzEx3PAfevqPkBc+Cu5/tDIYkHh7o3JbqTg0vfC5Qqw7CvmQqG98S9qoPKU L50A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=rP7mCQegZrZliKSNOE9HhwYeP/t/E6ng+qbUeSsHO9Y=; b=cEY8JhJKi8HeXfQEQp2ELnAAoNAW08BGPnqMU7f8tAEf6t06P+OQgTjkW6Zj2g2mWz brYjX0sfe0rA5X1ewF6ZWQ8KqLvbJrfJ9ZFv30kFx+QnioyMFFgJNxV5CPEh7lulsTiK SSOhbf+JKcvP5gnB/tDmaG4u095i/HlANUSyaYbmKziznmdthCFf4qhSAmQH3gLNwcaR pHx2ggvUYtZurfJ3Hwnp+GQquljfSYgPbIgK+PsDef4JLHsNrYYp+rx8UZDhta86tsq7 3zqeQFs05WoII6+Pouh7vglB4rsR/Ac78NKLtgQ9ygZsymtsbQrn8yx8lCq9TFy3IYgY xwIg== X-Gm-Message-State: AOAM533j06E69rSZDErNBEtDmj1vSrPxAJSfZ0gAApDvcdoupP0YndFg NVms3MwP4M1tgHO5YqDHx2DykA== X-Received: by 2002:a1c:bc41:: with SMTP id m62mr4606670wmf.46.1610136962529; Fri, 08 Jan 2021 12:16:02 -0800 (PST) Received: from dell.default ([91.110.221.229]) by smtp.gmail.com with ESMTPSA id l8sm15598671wrb.73.2021.01.08.12.16.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 08 Jan 2021 12:16:01 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Subject: [PATCH 40/40] drm/amd/display/dc/gpio/hw_factory: Delete unused function 'dal_hw_factory_destroy' Date: Fri, 8 Jan 2021 20:14:57 +0000 Message-Id: <20210108201457.3078600-41-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210108201457.3078600-1-lee.jones@linaro.org> References: <20210108201457.3078600-1-lee.jones@linaro.org> MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Leo Li , linux-kernel@vger.kernel.org, amd-gfx@lists.freedesktop.org, David Airlie , dri-devel@lists.freedesktop.org, Alex Deucher , =?utf-8?q?Christian_K=C3=B6nig?= Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/amd/amdgpu/../display/dc/gpio/hw_factory.c:123:6: warning: no previous prototype for ‘dal_hw_factory_destroy’ [-Wmissing-prototypes] Cc: Harry Wentland Cc: Leo Li Cc: Alex Deucher Cc: "Christian König" Cc: David Airlie Cc: Daniel Vetter Cc: amd-gfx@lists.freedesktop.org Cc: dri-devel@lists.freedesktop.org Signed-off-by: Lee Jones --- drivers/gpu/drm/amd/display/dc/gpio/hw_factory.c | 14 -------------- 1 file changed, 14 deletions(-) diff --git a/drivers/gpu/drm/amd/display/dc/gpio/hw_factory.c b/drivers/gpu/drm/amd/display/dc/gpio/hw_factory.c index da73bfb3cacd0..92c65d2fa7d71 100644 --- a/drivers/gpu/drm/amd/display/dc/gpio/hw_factory.c +++ b/drivers/gpu/drm/amd/display/dc/gpio/hw_factory.c @@ -119,17 +119,3 @@ bool dal_hw_factory_init( return false; } } - -void dal_hw_factory_destroy( - struct dc_context *ctx, - struct hw_factory **factory) -{ - if (!factory || !*factory) { - BREAK_TO_DEBUGGER(); - return; - } - - kfree(*factory); - - *factory = NULL; -}