From patchwork Fri Jan 8 08:23:28 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arnd Bergmann X-Patchwork-Id: 358926 Delivered-To: patch@linaro.org Received: by 2002:a17:906:4755:0:0:0:0 with SMTP id j21csp143352ejs; Fri, 8 Jan 2021 00:25:56 -0800 (PST) X-Google-Smtp-Source: ABdhPJyFH1qxGrgX0xRf6o8Ytn6F7GzFe+61EM66TXRYTJoNGb8iEC9eupvR/hO99hGEjesGbYuB X-Received: by 2002:aa7:d593:: with SMTP id r19mr4581131edq.246.1610094356236; Fri, 08 Jan 2021 00:25:56 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1610094356; cv=none; d=google.com; s=arc-20160816; b=x2HvROVPZMAflEYDDjxT6B3kowtU83sxTDIh5NlPTket8GkzFQzeKF/z70Emsn6niS EXsPMS7oN6jNSHzRBKDJOLNLWrpqEZdqm2cOOx5n6furpozuy6605/w8GM6/4b74BnT1 0/L6H+JnEvcW4QHOpzPwCkoLqpAgqFdo0MgwTWEZLlDJ70hSNjhd+3A72jpx2SwtOSMV N3j1EvB9QHINz8VSkKbVi3usq0NCt8RH8WNktAWvnmaL+ELVIffwXWQslyxg+e+MLvdo ecHnEMPjYywAOrr2bEmO8MAtCj0+J08X8ZzUcjJYoE/RIY2998nC6yH2Tq561iiCwoNG 0xtA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=DOOKe8UkVvJ9V4goXY8xZm/178WZ3Fb+sp5XXnHlDEw=; b=kN/vFUZ/FUro82oq21WMl7Vj2+gXvvVLtSa0pWuS+PAdYgbFNcvL+OOdi5cei0gKSb Yo+Z/CFtK/IZVrJVuPxcxVtehHihBIXbLqR++sNSH1Q/rQE3hSMcYnq5RWGAyjVwopBs XNp9ecKHB8yxlLoBGhXJ3Wpx2mAFKA/P/eLjMAbGCBxjcPrDVY2CXKI2GdQivx5p4R1V +aWHc7nEey2rTJnPd3VP4zEhppBbxzt5VLDqWNwo5hq/0BAh0/d4+qARDwd/phtFgpIq C391Q6A+m6kQv8qt8N9JmReIBJfnMgaOioerOK6CBZaJnCOknUg8A5F2TP+AczmmB+Qx d7hg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=WamJreZb; spf=pass (google.com: domain of linux-media-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-media-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id q16si3273817ejd.199.2021.01.08.00.25.56; Fri, 08 Jan 2021 00:25:56 -0800 (PST) Received-SPF: pass (google.com: domain of linux-media-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=WamJreZb; spf=pass (google.com: domain of linux-media-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-media-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727767AbhAHIYX (ORCPT + 3 others); Fri, 8 Jan 2021 03:24:23 -0500 Received: from mail.kernel.org ([198.145.29.99]:59022 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727396AbhAHIYW (ORCPT ); Fri, 8 Jan 2021 03:24:22 -0500 Received: by mail.kernel.org (Postfix) with ESMTPSA id 907DB2343B; Fri, 8 Jan 2021 08:23:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1610094222; bh=Kb16w298kZTAlEWpzqllvq2hovbvuFFho6Aectf+P2Q=; h=From:To:Cc:Subject:Date:From; b=WamJreZb+aHOCvWYMI4fEqI0PlJQZ8fbipCb3x7HG2ff1xkqKyTazUHc63vjUQFC2 TieFRi213IHgRdBymssxUlqO2qHmocTOqOigzhktw+QqeKraljxk4UbgVS3Zs2yWwQ BV5j9DaKfC7N3GINFqM9Kfxc6QHIWG4OcoqoaEEtSesJmV164OAIgR/t02AnNREbcx LEu4aT6jYoXEQbvusL6PRBD3eT+UFx361idz170TYzlR1JnGkK3gAiqg26vdxZmRRQ a9wXynGOPx9+JRob6sYUj2jnT3YigRcR4H4WlkIUAtmW9a4xRQLdn4W59OvzpXmtBe qBtvpyc30e2oA== From: Arnd Bergmann To: Mauro Carvalho Chehab Cc: Arnd Bergmann , Sakari Ailus , Greg Kroah-Hartman , linux-media@vger.kernel.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: [PATCH] media: atomisp: fix Wvisiblity warning Date: Fri, 8 Jan 2021 09:23:28 +0100 Message-Id: <20210108082337.2305938-1-arnd@kernel.org> X-Mailer: git-send-email 2.29.2 MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org From: Arnd Bergmann Some randconfig builds include ia_css_firmware.h without first including linux/device.h: In file included from atomisp/pci/mmu/sh_mmu_mrfld.c:23: In file included from atomisp/pci/atomisp_compat.h:22: In file included from atomisp/pci/atomisp_compat_css20.h:24: In file included from atomisp/pci/ia_css.h:28: In file included from atomisp/pci/ia_css_control.h:25: drivers/staging/media/atomisp//pci/ia_css_firmware.h:52:29: error: declaration of 'struct device' will not be visible outside of this function [-Werror,-Wvisibility] Add a forward declaration to avoid the warning. Signed-off-by: Arnd Bergmann --- drivers/staging/media/atomisp/pci/ia_css_firmware.h | 2 ++ 1 file changed, 2 insertions(+) -- 2.29.2 diff --git a/drivers/staging/media/atomisp/pci/ia_css_firmware.h b/drivers/staging/media/atomisp/pci/ia_css_firmware.h index edab72256494..38f0408947d1 100644 --- a/drivers/staging/media/atomisp/pci/ia_css_firmware.h +++ b/drivers/staging/media/atomisp/pci/ia_css_firmware.h @@ -30,6 +30,8 @@ struct ia_css_fw { unsigned int bytes; /** length in bytes of firmware data */ }; +struct device; + /* @brief Loads the firmware * @param[in] env Environment, provides functions to access the * environment in which the CSS code runs. This is