From patchwork Mon Feb 19 23:54:15 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Denys Dmytriyenko X-Patchwork-Id: 128848 Delivered-To: patch@linaro.org Received: by 10.46.124.24 with SMTP id x24csp4054995ljc; Mon, 19 Feb 2018 15:58:33 -0800 (PST) X-Google-Smtp-Source: AH8x225haDYWn/eMa2ng7E6dhgHvFh6hdwJfSfppOLf+AxaWF6zyyCsSIZhY2CymmQpkH9+NgiZW X-Received: by 10.99.183.5 with SMTP id t5mr13861588pgf.416.1519084713798; Mon, 19 Feb 2018 15:58:33 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1519084713; cv=none; d=google.com; s=arc-20160816; b=Uk2pSE8PoqNWQryLheTs20iLqQHrNAPfcK0VNrKhY0npl3ExWLzsuqF4+gGnIOA6ZR DESk/CkJ8tGeI66BxypxlG+JO1/ncnHJkhdAl1XFKJyl3Y/vUyQEskaoCgr/QA41nKWm 3lFtVRjyqsqrVT5ZHZe1COXSwph+wlVkHMPI0phO7GrGJ6jARlTQXJKzFztAq2k9fAY+ ENgd29okZS/oHgtNVXjeFi0pqBZOItLX5Ba6rMJXV2j22/JXN5nrEqLwsGAo8sTOV19/ j8kplfhDrQRtUFo4DpzPeSCO+1BNrnMKZg/xE+Ayne1r7cuN+vpr6cNNHJRKqOQG+yuV fELQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=errors-to:sender:content-transfer-encoding:mime-version :list-subscribe:list-help:list-post:list-archive:list-unsubscribe :list-id:precedence:subject:cc:message-id:date:to:from:delivered-to :arc-authentication-results; bh=VF92qJE7mcHAwxBAWoogzYyqOqv2z4+kv8PAK0pILrg=; b=HKFC0csLTPe6ej6gX4aw4/y8hpdeDihccxigZNMk4KF1lFcWapIiZBhh+wpJ4iNcW2 M9YrpCZkVh4BghDh9SBy5GlJ4afVv3QBkK0iI67wWOpUZxYynkkBMx68Q32iWj112wU3 zJUtF0OOw+ZRWtzqt9+ZHNmDeoCkmZUv0mTbv1RQ7rxN6+0nULMbHIjIQjq4KFm8oGsk fVOwbgjxrCpC2b4XkX6t9gd8bysyk3bOxOk5Z0Xf0oqCZ0wXSXS/+RptTRGcBWh2xRr2 Y5Xs40xiDyjg0ZVT18wyr72J0AzYekJzTGdRPdlBYQiFy6Oa8F8q/K9AnWnz9/kWsakz PpcA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of openembedded-core-bounces@lists.openembedded.org designates 140.211.169.62 as permitted sender) smtp.mailfrom=openembedded-core-bounces@lists.openembedded.org Return-Path: Received: from mail.openembedded.org (mail.openembedded.org. [140.211.169.62]) by mx.google.com with ESMTP id 101-v6si4894411ple.263.2018.02.19.15.58.33; Mon, 19 Feb 2018 15:58:33 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of openembedded-core-bounces@lists.openembedded.org designates 140.211.169.62 as permitted sender) client-ip=140.211.169.62; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of openembedded-core-bounces@lists.openembedded.org designates 140.211.169.62 as permitted sender) smtp.mailfrom=openembedded-core-bounces@lists.openembedded.org Received: from layers.openembedded.org (localhost [127.0.0.1]) by mail.openembedded.org (Postfix) with ESMTP id 0673978812; Mon, 19 Feb 2018 23:58:29 +0000 (UTC) X-Original-To: openembedded-core@lists.openembedded.org Delivered-To: openembedded-core@lists.openembedded.org Received: from mailout4.zoneedit.com (mailout4.zoneedit.com [64.68.198.17]) by mail.openembedded.org (Postfix) with ESMTP id 72A0C71ADD for ; Mon, 19 Feb 2018 23:54:16 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by mailout4.zoneedit.com (Postfix) with ESMTP id A296520B15; Mon, 19 Feb 2018 23:54:17 +0000 (UTC) Received: from mailout4.zoneedit.com ([127.0.0.1]) by localhost (zmo03-pco.easydns.vpn [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 3g83vsPHX1pj; Mon, 19 Feb 2018 23:54:17 +0000 (UTC) Received: from mail.denix.org (pool-100-15-85-143.washdc.fios.verizon.net [100.15.85.143]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mailout4.zoneedit.com (Postfix) with ESMTPSA id 7F7012073F; Mon, 19 Feb 2018 23:54:16 +0000 (UTC) Received: from gimli.denix (gimli [192.168.0.6]) by mail.denix.org (Postfix) with ESMTP id 0B27E1632C0; Mon, 19 Feb 2018 18:54:16 -0500 (EST) From: Denys Dmytriyenko To: openembedded-core@lists.openembedded.org Date: Mon, 19 Feb 2018 18:54:15 -0500 Message-Id: <1519084455-3915-1-git-send-email-denis@denix.org> X-Mailer: git-send-email 2.7.4 Cc: Denys Dmytriyenko Subject: [OE-core] [PATCH] kernel.bbclass: explicitly depend on bison-native for deterministic builds X-BeenThere: openembedded-core@lists.openembedded.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: Patches and discussions about the oe-core layer List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: openembedded-core-bounces@lists.openembedded.org Errors-To: openembedded-core-bounces@lists.openembedded.org From: Denys Dmytriyenko Explicitly depend on bison-native for deterministic builds, as it is required for the build: | HOSTCC scripts/basic/fixdep | GEN ./Makefile | HOSTCC scripts/kconfig/conf.o | YACC scripts/kconfig/zconf.tab.c | /bin/sh: bison: command not found | scripts/Makefile.lib:217: recipe for target 'scripts/kconfig/zconf.tab.c' failed In most cases, this dependency comes indirectly via toolchain dependencies, specifically binutils-cross, which pulls bison-native. Different setups, such as with external toolchain, would expose this problem, since correct dependency is not marked explicitly. Signed-off-by: Denys Dmytriyenko --- I'm seeing this now on 4.16-rc2 with external toolchain. meta/classes/kernel.bbclass | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.7.4 -- _______________________________________________ Openembedded-core mailing list Openembedded-core@lists.openembedded.org http://lists.openembedded.org/mailman/listinfo/openembedded-core diff --git a/meta/classes/kernel.bbclass b/meta/classes/kernel.bbclass index 943938d..321c0a4 100644 --- a/meta/classes/kernel.bbclass +++ b/meta/classes/kernel.bbclass @@ -4,7 +4,7 @@ KERNEL_PACKAGE_NAME ??= "kernel" KERNEL_DEPLOYSUBDIR ??= "${@ "" if (d.getVar("KERNEL_PACKAGE_NAME") == "kernel") else d.getVar("KERNEL_PACKAGE_NAME") }" PROVIDES += "${@ "virtual/kernel" if (d.getVar("KERNEL_PACKAGE_NAME") == "kernel") else "" }" -DEPENDS += "virtual/${TARGET_PREFIX}binutils virtual/${TARGET_PREFIX}gcc kmod-native bc-native lzop-native" +DEPENDS += "virtual/${TARGET_PREFIX}binutils virtual/${TARGET_PREFIX}gcc kmod-native bc-native lzop-native bison-native" PACKAGE_WRITE_DEPS += "depmodwrapper-cross" do_deploy[depends] += "depmodwrapper-cross:do_populate_sysroot"