From patchwork Tue Jan 5 14:47:19 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Paul Kocialkowski X-Patchwork-Id: 357193 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A6258C433DB for ; Tue, 5 Jan 2021 14:48:28 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 7666C22B49 for ; Tue, 5 Jan 2021 14:48:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728121AbhAEOsM (ORCPT ); Tue, 5 Jan 2021 09:48:12 -0500 Received: from relay2-d.mail.gandi.net ([217.70.183.194]:56461 "EHLO relay2-d.mail.gandi.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726076AbhAEOsM (ORCPT ); Tue, 5 Jan 2021 09:48:12 -0500 X-Originating-IP: 93.29.109.196 Received: from localhost.localdomain (196.109.29.93.rev.sfr.net [93.29.109.196]) (Authenticated sender: paul.kocialkowski@bootlin.com) by relay2-d.mail.gandi.net (Postfix) with ESMTPSA id 1A0DA40010; Tue, 5 Jan 2021 14:47:29 +0000 (UTC) From: Paul Kocialkowski To: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Mauro Carvalho Chehab , Sakari Ailus , Paul Kocialkowski Subject: [PATCH v2] media: i2c: ov5648/ov8865: Minor cosmetic fixes Date: Tue, 5 Jan 2021 15:47:19 +0100 Message-Id: <20210105144720.9578-1-paul.kocialkowski@bootlin.com> X-Mailer: git-send-email 2.30.0 MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org This solves a few minor cosmetic issues picked up by checkpatch for the OV5648 and OV8865 drivers. Signed-off-by: Paul Kocialkowski --- drivers/media/i2c/ov5648.c | 3 ++- drivers/media/i2c/ov8865.c | 8 ++++---- 2 files changed, 6 insertions(+), 5 deletions(-) diff --git a/drivers/media/i2c/ov5648.c b/drivers/media/i2c/ov5648.c index 609aa67b54ce..110190b322e2 100644 --- a/drivers/media/i2c/ov5648.c +++ b/drivers/media/i2c/ov5648.c @@ -496,7 +496,8 @@ container_of(s, struct ov5648_sensor, subdev) #define ov5648_ctrl_subdev(c) \ - (&container_of(c->handler, struct ov5648_sensor, ctrls.handler)->subdev) + (&container_of((c)->handler, struct ov5648_sensor, \ + ctrls.handler)->subdev) /* Data structures */ diff --git a/drivers/media/i2c/ov8865.c b/drivers/media/i2c/ov8865.c index fda5a55979aa..ab4804d5b285 100644 --- a/drivers/media/i2c/ov8865.c +++ b/drivers/media/i2c/ov8865.c @@ -223,7 +223,6 @@ #define OV8865_FORMAT2_FLIP_HORZ_SENSOR_EN BIT(1) #define OV8865_FORMAT2_SYNC_HBIN_EN BIT(0) - #define OV8865_INC_Y_ODD_REG 0x382a #define OV8865_INC_Y_ODD(v) ((v) & GENMASK(4, 0)) #define OV8865_INC_Y_EVEN_REG 0x382b @@ -460,7 +459,8 @@ container_of(s, struct ov8865_sensor, subdev) #define ov8865_ctrl_subdev(c) \ - (&container_of(c->handler, struct ov8865_sensor, ctrls.handler)->subdev) + (&container_of((c)->handler, struct ov8865_sensor, \ + ctrls.handler)->subdev) /* Data structures */ @@ -1598,8 +1598,8 @@ static int ov8865_mode_pll1_configure(struct ov8865_sensor *sensor, return ret; ret = ov8865_update_bits(sensor, OV8865_PCLK_SEL_REG, - OV8865_PCLK_SEL_PCLK_DIV_MASK, - OV8865_PCLK_SEL_PCLK_DIV(config->pclk_div)); + OV8865_PCLK_SEL_PCLK_DIV_MASK, + OV8865_PCLK_SEL_PCLK_DIV(config->pclk_div)); if (ret) return ret;