From patchwork Sun Jan 3 21:42:17 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arnd Bergmann X-Patchwork-Id: 356167 Delivered-To: patch@linaro.org Received: by 2002:a02:85a7:0:0:0:0:0 with SMTP id d36csp14486087jai; Sun, 3 Jan 2021 13:44:26 -0800 (PST) X-Google-Smtp-Source: ABdhPJzzOvRuE2C0pVYaKUejjNBRxgVHTKqoTpnuEmrhd4fTUXCZMImIT42wJzwJ3DlQ9c8Or7Wy X-Received: by 2002:a17:906:16d6:: with SMTP id t22mr64352977ejd.154.1609710266395; Sun, 03 Jan 2021 13:44:26 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1609710266; cv=none; d=google.com; s=arc-20160816; b=bGiiB5J1MjVgS78hvpbFj7lVj/+j7/r8+aUERFIZTjmT/OXv46/kw9cacb+dRyvF8B dKuBQRcQhpuRSrWPwcpG47Ss/8xrTOud+Zh+5nM04d7KNkDAFDGAoFSiNPpD+L03m5Ux +flhrpy0EFFE+9nPVVxGhkZu8kQQ0RjxyZy2O5KFMgbq4L4J4ge03KtRfsNxus1FpVPM 5VKjSVLzgIoJA6Zeox4fbutfKbUlGoCFvvttA1Ykvqu3u+/nThG8SHfMnsFILakD96St mFE3W/yJntdE9jVbFSprSzJn6og0Yqhn4H71M7mkCB7cAwC01ApkLSoQN9pu0Z6/+8// 0eWg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=BQgkddGwWZ1Uz+Kzn1r6FHa+uSlPJtj+76dxo6kAYhM=; b=P3V2+YJ6ObH46ys9RbQYgsz1h48H1/YtktR4++B2z7rQu6o6On7IRnlh4JXH7jkEO/ 2jdxQirTGw5/qakvhjl9lZq6G6c1JfIvbi20gdGWOlVHvVW1bbg+t1qR/e+h/AQK2sjF WZBZ/HHfSq2RuwO+p16rMiEATOGmQlAVFuMOesOj6pJIFs9oSxC2HlBm3QGNzrK/Kp+m LfzBQ1G4C0chtpK0t6sPye54o9WiTWcF0x+udy/Wp2UGX17/Tdns1BzZcKamkCX6pDMU JqQJfD+zgd3a15qhng5xoM0StqTtSbh5bJiqQcTwNToLY6x/APBpauhuImPiyAM9hmjv ZnbQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=Zn5AtAEj; spf=pass (google.com: domain of linux-usb-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-usb-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id g1si28280437ejz.557.2021.01.03.13.44.26; Sun, 03 Jan 2021 13:44:26 -0800 (PST) Received-SPF: pass (google.com: domain of linux-usb-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=Zn5AtAEj; spf=pass (google.com: domain of linux-usb-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-usb-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727911AbhACVnJ (ORCPT + 4 others); Sun, 3 Jan 2021 16:43:09 -0500 Received: from mail.kernel.org ([198.145.29.99]:37668 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727884AbhACVnI (ORCPT ); Sun, 3 Jan 2021 16:43:08 -0500 Received: by mail.kernel.org (Postfix) with ESMTPSA id 504A42080D; Sun, 3 Jan 2021 21:42:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1609710148; bh=0k7+YMlmmuoKnr0VdYaRCOF9Xor5RNVXi4oJ3cdQ/Cg=; h=From:To:Cc:Subject:Date:From; b=Zn5AtAEj4yUkE+OtNW55qQNv+2Z/E70A4ckIUMGV+tczzeezEQpfoXqbNztx8CKHE k+D9EWlKadcCLjl5Z2i43eDTs+4rMNnWV6GqUk11pSmML00ULOraVjE5djY2gYDqxa DRoSVolSz7bSGhr5xpY/Yw+9ya8GXd/PsFhWz/c/FmRhAhei8/G1UVAA9O0ZCeY3ur tSplGcaL9IpzHA9iHRsJbvUh2GKi5V+RHJZbLBMEypxZdal7vfIZXgumRxKXuVqg+U pmBT6KaKRyqbro9H+dd2qNZj62uyHKabQCQfOywNgHGKgjPAzRUr1wpBBQo+9iShuf miOAsqbM16HRA== From: Arnd Bergmann To: Felipe Balbi , Greg Kroah-Hartman , Jim Baxter Cc: Arnd Bergmann , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] usb: gadget: select CONFIG_CRC32 Date: Sun, 3 Jan 2021 22:42:17 +0100 Message-Id: <20210103214224.1996535-1-arnd@kernel.org> X-Mailer: git-send-email 2.29.2 MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org From: Arnd Bergmann Without crc32 support, this driver fails to link: arm-linux-gnueabi-ld: drivers/usb/gadget/function/f_eem.o: in function `eem_unwrap': f_eem.c:(.text+0x11cc): undefined reference to `crc32_le' arm-linux-gnueabi-ld: drivers/usb/gadget/function/f_ncm.o:f_ncm.c:(.text+0x1e40): more undefined references to `crc32_le' follow Fixes: 6d3865f9d41f ("usb: gadget: NCM: Add transmit multi-frame.") Signed-off-by: Arnd Bergmann --- drivers/usb/gadget/Kconfig | 2 ++ 1 file changed, 2 insertions(+) -- 2.29.2 Acked-by: Felipe Balbi diff --git a/drivers/usb/gadget/Kconfig b/drivers/usb/gadget/Kconfig index 7e47e6223089..2d152571a7de 100644 --- a/drivers/usb/gadget/Kconfig +++ b/drivers/usb/gadget/Kconfig @@ -265,6 +265,7 @@ config USB_CONFIGFS_NCM depends on NET select USB_U_ETHER select USB_F_NCM + select CRC32 help NCM is an advanced protocol for Ethernet encapsulation, allows grouping of several ethernet frames into one USB transfer and @@ -314,6 +315,7 @@ config USB_CONFIGFS_EEM depends on NET select USB_U_ETHER select USB_F_EEM + select CRC32 help CDC EEM is a newer USB standard that is somewhat simpler than CDC ECM and therefore can be supported by more hardware. Technically ECM and