From patchwork Sun Jan 3 14:03:04 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arnd Bergmann X-Patchwork-Id: 356154 Delivered-To: patch@linaro.org Received: by 2002:a02:85a7:0:0:0:0:0 with SMTP id d36csp14274167jai; Sun, 3 Jan 2021 06:05:27 -0800 (PST) X-Google-Smtp-Source: ABdhPJyd9ixJGZM7soGnyeq/DNBlVq5NiDSmVeC3hoPWsZEiQ2iwOn+pSGg2K4Xxn2JsFfxqr7jC X-Received: by 2002:a05:6402:1592:: with SMTP id c18mr13482206edv.181.1609682726902; Sun, 03 Jan 2021 06:05:26 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1609682726; cv=none; d=google.com; s=arc-20160816; b=yq960V1sg861WkBKYLXEdYBvvDb0GR9ZaTMn/qjLNFGSN9ZaB2bBu4gI13250voHMx nz0KYiKe/m+Swkm325P6f+cSf30DL1JOLdjLUTZP9sX2jE1CRaK7rRJegTbd9WKYgtg7 gMeLLT5jjOC8QDOgKHKVUmNo+UbaahxYaoizpc11uGTCjgFo+f4LDDbRAuRlY3y/CeGs lr5m81yCQ1wuK8KELZsXVwrCY5Lmh1tag0hTbnDeLCxlqBCgJ+hXE/nkTRoTILUlMQ0m s+R5tNXePhQezey2sVJrRLbhflP8e7U7U4+ja7nTKeElBtPicbBA1O8oS84wfrhJj+PQ kvsQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=BMQsqpNAL4R0U6xCG8a8dWDcQMZ31lTTViCneje5ldk=; b=wrs+UtQ27S1rZuoSJLYYpkK61a9Wg36Y3wyrAre3/G1On5uC2VRUoewHxr9FUtUA1s /AOLIV3g5DEKkzH8fSUSsul9ppUUkrUTK/hbfAqaSVbKEeybKIAPumat0WiQ/QhbvelO AZQmuJjNVWX/EVJtxEp+5yNvH2y/di6cZmIUoKhIOyDEXqP+KegwjZZCiozu/+YXM5c6 h9Ng13jbCHC+D8a7trMmxS4GBuryZ+4DFi8V0I+qxOt9peZsn95wFFJDxfYPJu4cFvPZ nyS5A6R/4MJgOf6yIsX8cyV3S03S1Vqvv8RvGEhqamNvDgyXoFhq9cSoLG/f2ASDV+XK ZcrA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=NFIcH122; spf=pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id q4si29343751edg.1.2021.01.03.06.05.26; Sun, 03 Jan 2021 06:05:26 -0800 (PST) Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=NFIcH122; spf=pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727247AbhACOEE (ORCPT + 2 others); Sun, 3 Jan 2021 09:04:04 -0500 Received: from mail.kernel.org ([198.145.29.99]:35946 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726829AbhACOEE (ORCPT ); Sun, 3 Jan 2021 09:04:04 -0500 Received: by mail.kernel.org (Postfix) with ESMTPSA id 118712080D; Sun, 3 Jan 2021 14:03:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1609682603; bh=dqHNyAKkpwyLmYZD5yeeB+ZjQZwdnDmtsYc8E0Z0vfE=; h=From:To:Cc:Subject:Date:From; b=NFIcH122ai3m5hUWP6QvxVgAMGxb3kIkIh5Jo6RtGsYshsvv9Uv2VdnZh0eOrNAsk vdfwiOo0oSAnXnTYxqUd0vWaguhpijijj53zJm9UHhNqr7WKFR9N9sMBb12Cj+I7Zf NZ0PEDa2Z43xVBt7pc10EUh9nqxfq8P/8GLnRbPxrQNqhBK597h5Co+VCvVHstxjjc b+msh48wSdGPavmQTrZeHOJaEluzzN9QimIfYUcD0XWPLDqQx0BGBmKXmMuDkgp+ky ZU0XZSAJ1jJxZvethaiUIUjZvOX2d7aFmvkurB4TsCZEaEneCzfKvQ6BuFcmPjCDiS Y+r1Ff7/94beA== From: Arnd Bergmann To: Herbert Xu , "David S. Miller" , Tero Kristo Cc: Arnd Bergmann , linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] crypto: omap-sham - Fix link error without crypto-engine Date: Sun, 3 Jan 2021 15:03:04 +0100 Message-Id: <20210103140318.3902174-1-arnd@kernel.org> X-Mailer: git-send-email 2.29.2 MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org From: Arnd Bergmann The driver was converted to use the crypto engine helper but is missing the corresponding Kconfig statement to ensure it is available: arm-linux-gnueabi-ld: drivers/crypto/omap-sham.o: in function `omap_sham_probe': omap-sham.c:(.text+0x374): undefined reference to `crypto_engine_alloc_init' arm-linux-gnueabi-ld: omap-sham.c:(.text+0x384): undefined reference to `crypto_engine_start' arm-linux-gnueabi-ld: omap-sham.c:(.text+0x510): undefined reference to `crypto_engine_exit' arm-linux-gnueabi-ld: drivers/crypto/omap-sham.o: in function `omap_sham_finish_req': omap-sham.c:(.text+0x98c): undefined reference to `crypto_finalize_hash_request' arm-linux-gnueabi-ld: omap-sham.c:(.text+0x9a0): undefined reference to `crypto_transfer_hash_request_to_engine' arm-linux-gnueabi-ld: drivers/crypto/omap-sham.o: in function `omap_sham_update': omap-sham.c:(.text+0xf24): undefined reference to `crypto_transfer_hash_request_to_engine' arm-linux-gnueabi-ld: drivers/crypto/omap-sham.o: in function `omap_sham_final': omap-sham.c:(.text+0x1020): undefined reference to `crypto_transfer_hash_request_to_engine' Fixes: 133c3d434d91 ("crypto: omap-sham - convert to use crypto engine") Signed-off-by: Arnd Bergmann --- drivers/crypto/Kconfig | 1 + 1 file changed, 1 insertion(+) -- 2.29.2 diff --git a/drivers/crypto/Kconfig b/drivers/crypto/Kconfig index 8fa6d71a6da1..21abeb19f1eb 100644 --- a/drivers/crypto/Kconfig +++ b/drivers/crypto/Kconfig @@ -368,6 +368,7 @@ if CRYPTO_DEV_OMAP config CRYPTO_DEV_OMAP_SHAM tristate "Support for OMAP MD5/SHA1/SHA2 hw accelerator" depends on ARCH_OMAP2PLUS + select CRYPTO_ENGINE select CRYPTO_SHA1 select CRYPTO_MD5 select CRYPTO_SHA256