From patchwork Wed Feb 14 10:30:02 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: gaurav jindal X-Patchwork-Id: 128328 Delivered-To: patch@linaro.org Received: by 10.46.124.24 with SMTP id x24csp452717ljc; Wed, 14 Feb 2018 02:30:13 -0800 (PST) X-Google-Smtp-Source: AH8x226slRj9OKRnxV0vAJ6K5pC+3df2uVT/hQyTqWySuTv3bgrlbEnUI1584mv5bepof3yQMu3s X-Received: by 10.99.53.193 with SMTP id c184mr3467723pga.180.1518604213387; Wed, 14 Feb 2018 02:30:13 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1518604213; cv=none; d=google.com; s=arc-20160816; b=ukRt1XZE8GTt6vwWYDVsz/2O8OiOTTwvBuUiHNAfc8CPREy8QbVKv0kBbDWuwm0f8n B2qKWfL529UnOZOXTDEI/CRWKR/w0VoZikbhoYZtPpIonH1o0Iq62igbZsmYWK0jPkDh vXeXJ8DW0RwJjT56ptd87dGIKfDkPNQWhDsV3pHAVuRiH2B50KFbGKLTVh0FkWaapBB5 zYliUHOEzU6UcZJ8gNmHIDvEJsrt0iAsNzjRzaG2R8i4vt2yYgbkkdqm5NLyHBfU85YO MucZWYCIuZwgurvfWYQNa1sBcNTjS9EoTs2igB2woM1FMthCDpT9yT9gqXvjEoj/Pkpv Ls3w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:content-disposition :mime-version:message-id:subject:cc:to:from:date:dkim-signature :arc-authentication-results; bh=AL641IAHhq8Li6o94GQZKQ8yO2lrtLhv37jr/E9QH/8=; b=EMtYNoUDcleDykVi3LwIuFJm/JjQRFt7Q150VbNU3FdpglWBzDIT6d4E+BAVpFLUMb 0eyOn0J3yio+GqHAeRdtPge/tzfZn4zjtPKwrejnL+zzfPBz8wmW/1z6xxFjpzpxywBE o8kKwiNmWuLxs2S+24DxQRUVWUWy9g8HOjz7RIchkGTdD3xGotObcA8gRewBGVawtdzH Gi31tJiQBdPKBUm7+8h0Imm+V3Ac8xu+7ZR6MHXsiBB/YpeAgRg7h9dk/Tw74nrPaVHC EDAzjOy6wCytYA2UGREExQLIHNvkw7XlZRViPAzBGze4fxPfrTt/16VKvBKumWL37xgM YXVQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=TFoA5UOB; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id t1si3274551pgv.668.2018.02.14.02.30.13; Wed, 14 Feb 2018 02:30:13 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=TFoA5UOB; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S967185AbeBNKaI (ORCPT + 28 others); Wed, 14 Feb 2018 05:30:08 -0500 Received: from mail-pl0-f65.google.com ([209.85.160.65]:40283 "EHLO mail-pl0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S967052AbeBNKaH (ORCPT ); Wed, 14 Feb 2018 05:30:07 -0500 Received: by mail-pl0-f65.google.com with SMTP id g18so8296825plo.7 for ; Wed, 14 Feb 2018 02:30:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:mime-version:content-disposition :user-agent; bh=AL641IAHhq8Li6o94GQZKQ8yO2lrtLhv37jr/E9QH/8=; b=TFoA5UOBNG1GLGRknQPI/1V0kiOEc9Oy8+mP258pYNaqsH9EI/8GBrheCGErfHmaxe RjPsjPu8vz1+GV1+oNP3KoE4ZQvgd/1AIiR6uyVO1t2/HVicI+jrPVgqhYeLurKnc++K BQyAMn4VHR9ATMWTQ01500yYpw2uvSRyUMH37hk6obyqHvJW1YxQFQO3F84o/FfSEc0a S8NxWiURaz1sFtN5VZzE76+tXLKuORVp01Ny2SW/BkIbfcztRtAf/w+74E3HblbyANTw iA2ab9n2ohY9wdkuyV2R1JLXj8ta2BNri8DnsP4hFawH/7Lk19vLqjHsFmtifZ/9NLBR D+fg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:mime-version :content-disposition:user-agent; bh=AL641IAHhq8Li6o94GQZKQ8yO2lrtLhv37jr/E9QH/8=; b=VEQtnSVznlgajbLlpLw/Pb3GnXdWz7RzU2S/96L3iqb453rjz7NfIEPT7UC1WvrzO3 W1egtI8rQqUuvrXki0rD7rxpWRcQKsy3qVgh8Ic0rWguFxrSrOamcOIdHQmMyOEqTF9S wrU5VWp7sxI7kByvbdjbHk5FTlkShsm/Z+AyJDN6JJ2KdkVofeXUzyeuz1qLhuDq1x5s g7f+5cuzp/bCXDKrmZ61VwL/M+9e9BMM28hLH/L85jrhy6D96t0sklSBcdNW49ldOMGO xmxKSHAg5nnQmzVR0PXdwfs/BNrb+2QSfGLl1M61nhvgkGixDGMzG7XGTfDOUpmc3SdH Ma2A== X-Gm-Message-State: APf1xPDO8aQdVJUDybw6MUOH5jESHq6LCTx9TYov3NWwpXPb5RIJZECI aQBKc/RwDGQfLq33V0s78VM= X-Received: by 2002:a17:902:6946:: with SMTP id k6-v6mr4059223plt.205.1518604207374; Wed, 14 Feb 2018 02:30:07 -0800 (PST) Received: from localhost ([182.73.133.58]) by smtp.gmail.com with ESMTPSA id h11sm31138108pgq.91.2018.02.14.02.30.05 (version=TLS1_2 cipher=AES128-SHA bits=128/128); Wed, 14 Feb 2018 02:30:06 -0800 (PST) Date: Wed, 14 Feb 2018 16:00:02 +0530 From: gaurav jindal To: peterz@infradead.org, mingo@redhat.com Cc: linux-kernel@vger.kernel.org Subject: [PATCH]sched: completion: use bool in try_wait_for_completion Message-ID: <20180214103002.GA15068@gmail.com> MIME-Version: 1.0 Content-Disposition: inline User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Use bool in place of int in the function try_wait_for_completion. Signed-off-by: Gaurav Jindal diff --git a/kernel/sched/completion.c b/kernel/sched/completion.c index 0926aef..3e15e8d 100644 --- a/kernel/sched/completion.c +++ b/kernel/sched/completion.c @@ -283,7 +283,7 @@ int __sched wait_for_completion_killable(struct completion *x) bool try_wait_for_completion(struct completion *x) { unsigned long flags; - int ret = 1; + bool ret = true; /* * Since x->done will need to be locked only @@ -292,11 +292,11 @@ bool try_wait_for_completion(struct completion *x) * return early in the blocking case. */ if (!READ_ONCE(x->done)) - return 0; + return false; spin_lock_irqsave(&x->wait.lock, flags); if (!x->done) - ret = 0; + ret = false; else if (x->done != UINT_MAX) x->done--; spin_unlock_irqrestore(&x->wait.lock, flags);