From patchwork Mon Dec 14 11:01:45 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Philipp Gerlesberger X-Patchwork-Id: 343751 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.7 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI, SPF_HELO_NONE, SPF_PASS, URIBL_BLOCKED, USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1A46CC4361B for ; Mon, 14 Dec 2020 11:15:48 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C2E84229C5 for ; Mon, 14 Dec 2020 11:15:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2394908AbgLNLDu (ORCPT ); Mon, 14 Dec 2020 06:03:50 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41540 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728159AbgLNLDY (ORCPT ); Mon, 14 Dec 2020 06:03:24 -0500 Received: from faui03.informatik.uni-erlangen.de (faui03.informatik.uni-erlangen.de [IPv6:2001:638:a000:4130:131:188:30:103]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 326C1C0613CF; Mon, 14 Dec 2020 03:02:44 -0800 (PST) Received: from cipterm0.informatik.uni-erlangen.de (cipterm0.cip.cs.fau.de [131.188.30.90]) by faui03.informatik.uni-erlangen.de (Postfix) with ESMTP id 42989240B54; Mon, 14 Dec 2020 12:02:42 +0100 (CET) Received: by cipterm0.informatik.uni-erlangen.de (Postfix, from userid 67858) id 4055B3280146; Mon, 14 Dec 2020 12:02:42 +0100 (CET) From: Philipp Gerlesberger To: linux-kernel@vger.kernel.org Cc: Philipp Gerlesberger , ij72uhux@stud.informatik.uni-erlangen.de, linux-media@vger.kernel.org, devel@driverdev.osuosl.org, linux-kernel@i4.cs.fau.de, gregkh@linuxfoundation.org, sakari.ailus@linux.intel.com, mchehab@kernel.org Subject: [PATCH v2 01/12] media: atomisp: Convert comments to C99 initializers Date: Mon, 14 Dec 2020 12:01:45 +0100 Message-Id: <20201214110156.6152-2-Philipp.Gerlesberger@fau.de> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20201214110156.6152-1-Philipp.Gerlesberger@fau.de> References: <20201214110156.6152-1-Philipp.Gerlesberger@fau.de> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org The struct initalizers have been changed as recommended on https://kernelnewbies.org/KernelJanitors/Todo Also remove all the false, 0, and NULL members. Co-developed-by: Andrey Khlopkov Signed-off-by: Andrey Khlopkov Signed-off-by: Philipp Gerlesberger --- .../atomisp/pci/runtime/rmgr/src/rmgr_vbuf.c | 22 +++++-------------- 1 file changed, 5 insertions(+), 17 deletions(-) diff --git a/drivers/staging/media/atomisp/pci/runtime/rmgr/src/rmgr_vbuf.c b/drivers/staging/media/atomisp/pci/runtime/rmgr/src/rmgr_vbuf.c index b4f53be18e7f..834b07e2cd9b 100644 --- a/drivers/staging/media/atomisp/pci/runtime/rmgr/src/rmgr_vbuf.c +++ b/drivers/staging/media/atomisp/pci/runtime/rmgr/src/rmgr_vbuf.c @@ -30,34 +30,22 @@ static struct ia_css_rmgr_vbuf_handle handle_table[NUM_HANDLES]; /* * @brief VBUF resource pool - refpool */ -static struct ia_css_rmgr_vbuf_pool refpool = { - false, /* copy_on_write */ - false, /* recycle */ - 0, /* size */ - 0, /* index */ - NULL, /* handles */ -}; +static struct ia_css_rmgr_vbuf_pool refpool; /* * @brief VBUF resource pool - writepool */ static struct ia_css_rmgr_vbuf_pool writepool = { - true, /* copy_on_write */ - false, /* recycle */ - 0, /* size */ - 0, /* index */ - NULL, /* handles */ + .copy_on_write = true, }; /* * @brief VBUF resource pool - hmmbufferpool */ static struct ia_css_rmgr_vbuf_pool hmmbufferpool = { - true, /* copy_on_write */ - true, /* recycle */ - 32, /* size */ - 0, /* index */ - NULL, /* handles */ + .copy_on_write = true, + .recycle = true, + .size = 32, }; struct ia_css_rmgr_vbuf_pool *vbuf_ref = &refpool; From patchwork Mon Dec 14 11:01:46 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Philipp Gerlesberger X-Patchwork-Id: 343755 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.7 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI, SPF_HELO_NONE, SPF_PASS, URIBL_BLOCKED, USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 82363C4361B for ; Mon, 14 Dec 2020 11:11:12 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 4C7D0229C5 for ; Mon, 14 Dec 2020 11:11:12 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2405383AbgLNLE1 (ORCPT ); Mon, 14 Dec 2020 06:04:27 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41676 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2404547AbgLNLEP (ORCPT ); Mon, 14 Dec 2020 06:04:15 -0500 Received: from faui03.informatik.uni-erlangen.de (faui03.informatik.uni-erlangen.de [IPv6:2001:638:a000:4130:131:188:30:103]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 27D45C0613CF; Mon, 14 Dec 2020 03:03:35 -0800 (PST) Received: from cipterm0.informatik.uni-erlangen.de (cipterm0.cip.cs.fau.de [131.188.30.90]) by faui03.informatik.uni-erlangen.de (Postfix) with ESMTP id 8A977240B55; Mon, 14 Dec 2020 12:02:45 +0100 (CET) Received: by cipterm0.informatik.uni-erlangen.de (Postfix, from userid 67858) id 8867A3280146; Mon, 14 Dec 2020 12:02:45 +0100 (CET) From: Philipp Gerlesberger To: linux-kernel@vger.kernel.org Cc: Philipp Gerlesberger , ij72uhux@stud.informatik.uni-erlangen.de, linux-media@vger.kernel.org, devel@driverdev.osuosl.org, linux-kernel@i4.cs.fau.de, gregkh@linuxfoundation.org, sakari.ailus@linux.intel.com, mchehab@kernel.org Subject: [PATCH v2 02/12] media: atomisp: Fix Block Comments Date: Mon, 14 Dec 2020 12:01:46 +0100 Message-Id: <20201214110156.6152-3-Philipp.Gerlesberger@fau.de> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20201214110156.6152-1-Philipp.Gerlesberger@fau.de> References: <20201214110156.6152-1-Philipp.Gerlesberger@fau.de> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org Block comments should use * on subsequent lines and should use a trailing */ on a separate line. Co-developed-by: Andrey Khlopkov Signed-off-by: Andrey Khlopkov Signed-off-by: Philipp Gerlesberger --- .../staging/media/atomisp/pci/runtime/rmgr/src/rmgr_vbuf.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/staging/media/atomisp/pci/runtime/rmgr/src/rmgr_vbuf.c b/drivers/staging/media/atomisp/pci/runtime/rmgr/src/rmgr_vbuf.c index 834b07e2cd9b..2e5c9addd9c5 100644 --- a/drivers/staging/media/atomisp/pci/runtime/rmgr/src/rmgr_vbuf.c +++ b/drivers/staging/media/atomisp/pci/runtime/rmgr/src/rmgr_vbuf.c @@ -86,7 +86,7 @@ void ia_css_rmgr_refcount_retain_vbuf(struct ia_css_rmgr_vbuf_handle **handle) } } /* if the loop dus not break and *handle == NULL - this is an error handle and report it. + * this is an error handle and report it. */ if (!*handle) { ia_css_debug_dtrace(IA_CSS_DEBUG_ERROR, @@ -241,7 +241,8 @@ void rmgr_pop_handle(struct ia_css_rmgr_vbuf_pool *pool, *handle = pool->handles[i]; pool->handles[i] = NULL; /* dont release, we are returning it... - ia_css_rmgr_refcount_release_vbuf(handle); */ + * ia_css_rmgr_refcount_release_vbuf(handle); + */ return; } } From patchwork Mon Dec 14 11:01:48 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Philipp Gerlesberger X-Patchwork-Id: 343757 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.7 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI, SPF_HELO_NONE, SPF_PASS, URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CBB56C1B0E3 for ; Mon, 14 Dec 2020 11:05:08 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 7629622C7B for ; Mon, 14 Dec 2020 11:05:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2394830AbgLNLEw (ORCPT ); Mon, 14 Dec 2020 06:04:52 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41726 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2406700AbgLNLEc (ORCPT ); Mon, 14 Dec 2020 06:04:32 -0500 Received: from faui03.informatik.uni-erlangen.de (faui03.informatik.uni-erlangen.de [IPv6:2001:638:a000:4130:131:188:30:103]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 63417C0617A6; Mon, 14 Dec 2020 03:03:52 -0800 (PST) Received: from cipterm0.informatik.uni-erlangen.de (cipterm0.cip.cs.fau.de [131.188.30.90]) by faui03.informatik.uni-erlangen.de (Postfix) with ESMTP id 7092B240B5A; Mon, 14 Dec 2020 12:02:49 +0100 (CET) Received: by cipterm0.informatik.uni-erlangen.de (Postfix, from userid 67858) id 6E9D13280146; Mon, 14 Dec 2020 12:02:49 +0100 (CET) From: Philipp Gerlesberger To: linux-kernel@vger.kernel.org Cc: Philipp Gerlesberger , ij72uhux@stud.informatik.uni-erlangen.de, linux-media@vger.kernel.org, devel@driverdev.osuosl.org, linux-kernel@i4.cs.fau.de, gregkh@linuxfoundation.org, sakari.ailus@linux.intel.com, mchehab@kernel.org Subject: [PATCH v2 04/12] media: atomisp: Fix OPEN_ENDED_LINE Date: Mon, 14 Dec 2020 12:01:48 +0100 Message-Id: <20201214110156.6152-5-Philipp.Gerlesberger@fau.de> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20201214110156.6152-1-Philipp.Gerlesberger@fau.de> References: <20201214110156.6152-1-Philipp.Gerlesberger@fau.de> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org Lines should not end with a '(' Co-developed-by: Andrey Khlopkov Signed-off-by: Andrey Khlopkov Signed-off-by: Philipp Gerlesberger --- drivers/staging/media/atomisp/pci/runtime/rmgr/src/rmgr_vbuf.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/staging/media/atomisp/pci/runtime/rmgr/src/rmgr_vbuf.c b/drivers/staging/media/atomisp/pci/runtime/rmgr/src/rmgr_vbuf.c index 92d67557e516..75e2d3da5969 100644 --- a/drivers/staging/media/atomisp/pci/runtime/rmgr/src/rmgr_vbuf.c +++ b/drivers/staging/media/atomisp/pci/runtime/rmgr/src/rmgr_vbuf.c @@ -178,8 +178,7 @@ void ia_css_rmgr_uninit_vbuf(struct ia_css_rmgr_vbuf_pool *pool) /* free memory */ hmm_free(pool->handles[i]->vptr); /* remove from refcount admin */ - ia_css_rmgr_refcount_release_vbuf( - &pool->handles[i]); + ia_css_rmgr_refcount_release_vbuf(&pool->handles[i]); } } /* now free the pool handles list */ From patchwork Mon Dec 14 11:01:49 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Philipp Gerlesberger X-Patchwork-Id: 343758 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.7 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI, SPF_HELO_NONE, SPF_PASS, URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 00E4AC4361B for ; Mon, 14 Dec 2020 11:04:28 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C031F22BEF for ; Mon, 14 Dec 2020 11:04:27 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2405695AbgLNLEW (ORCPT ); Mon, 14 Dec 2020 06:04:22 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41658 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726640AbgLNLEN (ORCPT ); Mon, 14 Dec 2020 06:04:13 -0500 Received: from faui03.informatik.uni-erlangen.de (faui03.informatik.uni-erlangen.de [IPv6:2001:638:a000:4130:131:188:30:103]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AB61DC0613D6; Mon, 14 Dec 2020 03:03:58 -0800 (PST) Received: from cipterm0.informatik.uni-erlangen.de (cipterm0.cip.cs.fau.de [IPv6:2001:638:a000:4130:131:188:30:90]) by faui03.informatik.uni-erlangen.de (Postfix) with ESMTP id 3E3AA240ABF; Mon, 14 Dec 2020 12:02:51 +0100 (CET) Received: by cipterm0.informatik.uni-erlangen.de (Postfix, from userid 67858) id 3C3193280146; Mon, 14 Dec 2020 12:02:51 +0100 (CET) From: Philipp Gerlesberger To: linux-kernel@vger.kernel.org Cc: Philipp Gerlesberger , ij72uhux@stud.informatik.uni-erlangen.de, linux-media@vger.kernel.org, devel@driverdev.osuosl.org, linux-kernel@i4.cs.fau.de, gregkh@linuxfoundation.org, sakari.ailus@linux.intel.com, mchehab@kernel.org Subject: [PATCH v2 05/12] media: atomisp: Fix overlong line Date: Mon, 14 Dec 2020 12:01:49 +0100 Message-Id: <20201214110156.6152-6-Philipp.Gerlesberger@fau.de> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20201214110156.6152-1-Philipp.Gerlesberger@fau.de> References: <20201214110156.6152-1-Philipp.Gerlesberger@fau.de> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org Line length of 105 exceeds 100 columns. Co-developed-by: Andrey Khlopkov Signed-off-by: Andrey Khlopkov Signed-off-by: Philipp Gerlesberger --- drivers/staging/media/atomisp/pci/runtime/rmgr/src/rmgr_vbuf.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/staging/media/atomisp/pci/runtime/rmgr/src/rmgr_vbuf.c b/drivers/staging/media/atomisp/pci/runtime/rmgr/src/rmgr_vbuf.c index 75e2d3da5969..d96aaa4bc75d 100644 --- a/drivers/staging/media/atomisp/pci/runtime/rmgr/src/rmgr_vbuf.c +++ b/drivers/staging/media/atomisp/pci/runtime/rmgr/src/rmgr_vbuf.c @@ -282,7 +282,8 @@ void ia_css_rmgr_acq_vbuf(struct ia_css_rmgr_vbuf_pool *pool, } if ((*handle)->vptr == 0x0) { /* we need to allocate */ - (*handle)->vptr = hmm_alloc((*handle)->size, HMM_BO_PRIVATE, 0, NULL, 0); + (*handle)->vptr = hmm_alloc((*handle)->size, + HMM_BO_PRIVATE, 0, NULL, 0); } else { /* we popped a buffer */ return; From patchwork Mon Dec 14 11:01:50 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Philipp Gerlesberger X-Patchwork-Id: 343756 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.7 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI, SPF_HELO_NONE, SPF_PASS, URIBL_BLOCKED, USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EE8DBC1B0E3 for ; Mon, 14 Dec 2020 11:10:37 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B20C9229C6 for ; Mon, 14 Dec 2020 11:10:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729091AbgLNLFA (ORCPT ); Mon, 14 Dec 2020 06:05:00 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41742 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2407268AbgLNLEj (ORCPT ); Mon, 14 Dec 2020 06:04:39 -0500 Received: from faui03.informatik.uni-erlangen.de (faui03.informatik.uni-erlangen.de [IPv6:2001:638:a000:4130:131:188:30:103]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1B3C3C061794; Mon, 14 Dec 2020 03:03:59 -0800 (PST) Received: from cipterm0.informatik.uni-erlangen.de (cipterm0.cip.cs.fau.de [IPv6:2001:638:a000:4130:131:188:30:90]) by faui03.informatik.uni-erlangen.de (Postfix) with ESMTP id 19366240B99; Mon, 14 Dec 2020 12:02:52 +0100 (CET) Received: by cipterm0.informatik.uni-erlangen.de (Postfix, from userid 67858) id 1727C3280146; Mon, 14 Dec 2020 12:02:52 +0100 (CET) From: Philipp Gerlesberger To: linux-kernel@vger.kernel.org Cc: Philipp Gerlesberger , ij72uhux@stud.informatik.uni-erlangen.de, linux-media@vger.kernel.org, devel@driverdev.osuosl.org, linux-kernel@i4.cs.fau.de, gregkh@linuxfoundation.org, sakari.ailus@linux.intel.com, mchehab@kernel.org Subject: [PATCH v2 06/12] media: atomisp: Remove defines Date: Mon, 14 Dec 2020 12:01:50 +0100 Message-Id: <20201214110156.6152-7-Philipp.Gerlesberger@fau.de> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20201214110156.6152-1-Philipp.Gerlesberger@fau.de> References: <20201214110156.6152-1-Philipp.Gerlesberger@fau.de> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org Remov defines, they don't make sense. The programmer should know what things need to be static and what not. Also leave "inline" out and let the compiler decide Co-developed-by: Andrey Khlopkov Signed-off-by: Andrey Khlopkov Signed-off-by: Philipp Gerlesberger --- .../media/atomisp/pci/runtime/rmgr/interface/ia_css_rmgr.h | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/staging/media/atomisp/pci/runtime/rmgr/interface/ia_css_rmgr.h b/drivers/staging/media/atomisp/pci/runtime/rmgr/interface/ia_css_rmgr.h index 9cd3d92b34c9..45b72e98bc9f 100644 --- a/drivers/staging/media/atomisp/pci/runtime/rmgr/interface/ia_css_rmgr.h +++ b/drivers/staging/media/atomisp/pci/runtime/rmgr/interface/ia_css_rmgr.h @@ -21,10 +21,7 @@ #ifndef __INLINE_RMGR__ #define STORAGE_CLASS_RMGR_H extern #define STORAGE_CLASS_RMGR_C -#else /* __INLINE_RMGR__ */ -#define STORAGE_CLASS_RMGR_H static inline -#define STORAGE_CLASS_RMGR_C static inline -#endif /* __INLINE_RMGR__ */ +#endif /** * @brief Initialize resource manager (host/common) From patchwork Mon Dec 14 11:03:55 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Philipp Gerlesberger X-Patchwork-Id: 343754 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.7 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI, SPF_HELO_NONE, SPF_PASS, URIBL_BLOCKED, USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9E81AC1B0D8 for ; Mon, 14 Dec 2020 11:12:35 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 69675229C6 for ; Mon, 14 Dec 2020 11:12:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388111AbgLNLLe (ORCPT ); Mon, 14 Dec 2020 06:11:34 -0500 Received: from faui03.informatik.uni-erlangen.de ([131.188.30.103]:36556 "EHLO faui03.informatik.uni-erlangen.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729479AbgLNLLV (ORCPT ); Mon, 14 Dec 2020 06:11:21 -0500 X-Greylist: delayed 483 seconds by postgrey-1.27 at vger.kernel.org; Mon, 14 Dec 2020 06:11:06 EST Received: from cipterm0.informatik.uni-erlangen.de (cipterm0.cip.cs.fau.de [IPv6:2001:638:a000:4130:131:188:30:90]) by faui03.informatik.uni-erlangen.de (Postfix) with ESMTP id 7D615240B55; Mon, 14 Dec 2020 12:10:20 +0100 (CET) Received: by cipterm0.informatik.uni-erlangen.de (Postfix, from userid 67858) id D1D893280440; Mon, 14 Dec 2020 12:05:05 +0100 (CET) From: Philipp Gerlesberger To: linux-kernel@vger.kernel.org Cc: Philipp Gerlesberger , ij72uhux@stud.informatik.uni-erlangen.de, linux-media@vger.kernel.org, devel@driverdev.osuosl.org, linux-kernel@i4.cs.fau.de, gregkh@linuxfoundation.org, sakari.ailus@linux.intel.com, mchehab@kernel.org Subject: [PATCH v2 09/12] media: atomisp: Fix PARENTHESIS_ALIGNMENT Date: Mon, 14 Dec 2020 12:03:55 +0100 Message-Id: <20201214110358.7102-10-Philipp.Gerlesberger@fau.de> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org You can sum up the two lines, because the maximum line length of 100 columns is not exceeded. Co-developed-by: Andrey Khlopkov Signed-off-by: Andrey Khlopkov Signed-off-by: Philipp Gerlesberger --- drivers/staging/media/atomisp/pci/runtime/spctrl/src/spctrl.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/staging/media/atomisp/pci/runtime/spctrl/src/spctrl.c b/drivers/staging/media/atomisp/pci/runtime/spctrl/src/spctrl.c index 753a99703f1e..38f86764ccfc 100644 --- a/drivers/staging/media/atomisp/pci/runtime/spctrl/src/spctrl.c +++ b/drivers/staging/media/atomisp/pci/runtime/spctrl/src/spctrl.c @@ -37,8 +37,7 @@ static struct spctrl_context_info spctrl_cofig_info[N_SP_ID]; static bool spctrl_loaded[N_SP_ID] = {0}; /* Load firmware */ -int ia_css_spctrl_load_fw(sp_ID_t sp_id, - ia_css_spctrl_cfg *spctrl_cfg) +int ia_css_spctrl_load_fw(sp_ID_t sp_id, ia_css_spctrl_cfg *spctrl_cfg) { ia_css_ptr code_addr = mmgr_NULL; struct ia_css_sp_init_dmem_cfg *init_dmem_cfg; From patchwork Mon Dec 14 11:01:54 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Philipp Gerlesberger X-Patchwork-Id: 343753 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.7 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI, SPF_HELO_NONE, SPF_PASS, URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7D429C4361B for ; Mon, 14 Dec 2020 11:13:18 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 45A6F229C5 for ; Mon, 14 Dec 2020 11:13:18 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2404657AbgLNLMh (ORCPT ); Mon, 14 Dec 2020 06:12:37 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42756 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730967AbgLNLLU (ORCPT ); Mon, 14 Dec 2020 06:11:20 -0500 Received: from faui03.informatik.uni-erlangen.de (faui03.informatik.uni-erlangen.de [IPv6:2001:638:a000:4130:131:188:30:103]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 43A10C0613D6; Mon, 14 Dec 2020 03:10:22 -0800 (PST) Received: from cipterm0.informatik.uni-erlangen.de (cipterm0.cip.cs.fau.de [IPv6:2001:638:a000:4130:131:188:30:90]) by faui03.informatik.uni-erlangen.de (Postfix) with ESMTP id 7D43A240B54; Mon, 14 Dec 2020 12:10:20 +0100 (CET) Received: by cipterm0.informatik.uni-erlangen.de (Postfix, from userid 67858) id 5BBAC3280228; Mon, 14 Dec 2020 12:02:57 +0100 (CET) From: Philipp Gerlesberger To: linux-kernel@vger.kernel.org Cc: Philipp Gerlesberger , ij72uhux@stud.informatik.uni-erlangen.de, linux-media@vger.kernel.org, devel@driverdev.osuosl.org, linux-kernel@i4.cs.fau.de, gregkh@linuxfoundation.org, sakari.ailus@linux.intel.com, mchehab@kernel.org Subject: [PATCH v2 10/12] media: atomisp: Fix BLOCK_COMMENT_STYLE Date: Mon, 14 Dec 2020 12:01:54 +0100 Message-Id: <20201214110156.6152-11-Philipp.Gerlesberger@fau.de> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20201214110156.6152-1-Philipp.Gerlesberger@fau.de> References: <20201214110156.6152-1-Philipp.Gerlesberger@fau.de> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org Block comments should align the * on each line Co-developed-by: Andrey Khlopkov Signed-off-by: Andrey Khlopkov Signed-off-by: Philipp Gerlesberger --- drivers/staging/media/atomisp/pci/runtime/spctrl/src/spctrl.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/media/atomisp/pci/runtime/spctrl/src/spctrl.c b/drivers/staging/media/atomisp/pci/runtime/spctrl/src/spctrl.c index 38f86764ccfc..7f4592565af6 100644 --- a/drivers/staging/media/atomisp/pci/runtime/spctrl/src/spctrl.c +++ b/drivers/staging/media/atomisp/pci/runtime/spctrl/src/spctrl.c @@ -105,8 +105,8 @@ int ia_css_spctrl_load_fw(sp_ID_t sp_id, ia_css_spctrl_cfg *spctrl_cfg) void sh_css_spctrl_reload_fw(sp_ID_t sp_id) { /* now we program the base address into the icache and - * invalidate the cache. - */ + * invalidate the cache. + */ sp_ctrl_store(sp_id, SP_ICACHE_ADDR_REG, (hrt_data)spctrl_cofig_info[sp_id].code_addr); sp_ctrl_setbit(sp_id, SP_ICACHE_INV_REG, SP_ICACHE_INV_BIT); From patchwork Mon Dec 14 11:01:55 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Philipp Gerlesberger X-Patchwork-Id: 343752 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.7 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI, SPF_HELO_NONE, SPF_PASS, URIBL_BLOCKED, USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AFD6DC4361B for ; Mon, 14 Dec 2020 11:14:56 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 658DA22C97 for ; Mon, 14 Dec 2020 11:14:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729500AbgLNLMg (ORCPT ); Mon, 14 Dec 2020 06:12:36 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42752 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730519AbgLNLLU (ORCPT ); Mon, 14 Dec 2020 06:11:20 -0500 Received: from faui03.informatik.uni-erlangen.de (faui03.informatik.uni-erlangen.de [IPv6:2001:638:a000:4130:131:188:30:103]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E90FEC0613CF; Mon, 14 Dec 2020 03:10:21 -0800 (PST) Received: from cipterm0.informatik.uni-erlangen.de (cipterm0.cip.cs.fau.de [IPv6:2001:638:a000:4130:131:188:30:90]) by faui03.informatik.uni-erlangen.de (Postfix) with ESMTP id 77CBE240AC7; Mon, 14 Dec 2020 12:10:20 +0100 (CET) Received: by cipterm0.informatik.uni-erlangen.de (Postfix, from userid 67858) id 28C22328043C; Mon, 14 Dec 2020 12:02:59 +0100 (CET) From: Philipp Gerlesberger To: linux-kernel@vger.kernel.org Cc: Philipp Gerlesberger , ij72uhux@stud.informatik.uni-erlangen.de, linux-media@vger.kernel.org, devel@driverdev.osuosl.org, linux-kernel@i4.cs.fau.de, gregkh@linuxfoundation.org, sakari.ailus@linux.intel.com, mchehab@kernel.org Subject: [PATCH v2 11/12] media: atomisp: Write function decleration in one line Date: Mon, 14 Dec 2020 12:01:55 +0100 Message-Id: <20201214110156.6152-12-Philipp.Gerlesberger@fau.de> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20201214110156.6152-1-Philipp.Gerlesberger@fau.de> References: <20201214110156.6152-1-Philipp.Gerlesberger@fau.de> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org CHECK:OPEN_ENDED_LINE: Lines should not end with a '(' WARNING:LEADING_SPACE: please, no spaces at the start of a line Avoid these errors by writing the function decleration in one line. Co-developed-by: Andrey Khlopkov Signed-off-by: Andrey Khlopkov Signed-off-by: Philipp Gerlesberger --- .../atomisp/pci/runtime/queue/src/queue.c | 44 +++++-------------- 1 file changed, 11 insertions(+), 33 deletions(-) diff --git a/drivers/staging/media/atomisp/pci/runtime/queue/src/queue.c b/drivers/staging/media/atomisp/pci/runtime/queue/src/queue.c index aea6c66a3cee..2f1c2df59f71 100644 --- a/drivers/staging/media/atomisp/pci/runtime/queue/src/queue.c +++ b/drivers/staging/media/atomisp/pci/runtime/queue/src/queue.c @@ -22,9 +22,7 @@ /***************************************************************************** * Queue Public APIs *****************************************************************************/ -int ia_css_queue_local_init( - ia_css_queue_t *qhandle, - ia_css_queue_local_t *desc) +int ia_css_queue_local_init(ia_css_queue_t *qhandle, ia_css_queue_local_t *desc) { if (NULL == qhandle || NULL == desc || NULL == desc->cb_elems || NULL == desc->cb_desc) { @@ -43,9 +41,7 @@ int ia_css_queue_local_init( return 0; } -int ia_css_queue_remote_init( - ia_css_queue_t *qhandle, - ia_css_queue_remote_t *desc) +int ia_css_queue_remote_init(ia_css_queue_t *qhandle, ia_css_queue_remote_t *desc) { if (NULL == qhandle || NULL == desc) { /* Invalid parameters, return error*/ @@ -69,8 +65,7 @@ int ia_css_queue_remote_init( return 0; } -int ia_css_queue_uninit( - ia_css_queue_t *qhandle) +int ia_css_queue_uninit(ia_css_queue_t *qhandle) { if (!qhandle) return -EINVAL; @@ -84,9 +79,7 @@ int ia_css_queue_uninit( return 0; } -int ia_css_queue_enqueue( - ia_css_queue_t *qhandle, - uint32_t item) +int ia_css_queue_enqueue(ia_css_queue_t *qhandle, uint32_t item) { int error = 0; @@ -143,9 +136,7 @@ int ia_css_queue_enqueue( return 0; } -int ia_css_queue_dequeue( - ia_css_queue_t *qhandle, - uint32_t *item) +int ia_css_queue_dequeue(ia_css_queue_t *qhandle, uint32_t *item) { int error = 0; @@ -200,9 +191,7 @@ int ia_css_queue_dequeue( return 0; } -int ia_css_queue_is_full( - ia_css_queue_t *qhandle, - bool *is_full) +int ia_css_queue_is_full(ia_css_queue_t *qhandle, bool *is_full) { int error = 0; @@ -234,9 +223,7 @@ int ia_css_queue_is_full( return -EINVAL; } -int ia_css_queue_get_free_space( - ia_css_queue_t *qhandle, - uint32_t *size) +int ia_css_queue_get_free_space(ia_css_queue_t *qhandle, uint32_t *size) { int error = 0; @@ -268,9 +255,7 @@ int ia_css_queue_get_free_space( return -EINVAL; } -int ia_css_queue_get_used_space( - ia_css_queue_t *qhandle, - uint32_t *size) +int ia_css_queue_get_used_space(ia_css_queue_t *qhandle, uint32_t *size) { int error = 0; @@ -302,10 +287,7 @@ int ia_css_queue_get_used_space( return -EINVAL; } -int ia_css_queue_peek( - ia_css_queue_t *qhandle, - u32 offset, - uint32_t *element) +int ia_css_queue_peek(ia_css_queue_t *qhandle, u32 offset, uint32_t *element) { u32 num_elems = 0; int error = 0; @@ -354,9 +336,7 @@ int ia_css_queue_peek( return -EINVAL; } -int ia_css_queue_is_empty( - ia_css_queue_t *qhandle, - bool *is_empty) +int ia_css_queue_is_empty(ia_css_queue_t *qhandle, bool *is_empty) { int error = 0; @@ -388,9 +368,7 @@ int ia_css_queue_is_empty( return -EINVAL; } -int ia_css_queue_get_size( - ia_css_queue_t *qhandle, - uint32_t *size) +int ia_css_queue_get_size(ia_css_queue_t *qhandle, uint32_t *size) { int error = 0;