From patchwork Tue Feb 6 23:52:05 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Daniel_D=C3=ADaz?= X-Patchwork-Id: 127102 Delivered-To: patch@linaro.org Received: by 10.46.124.24 with SMTP id x24csp3382757ljc; Tue, 6 Feb 2018 15:54:34 -0800 (PST) X-Google-Smtp-Source: AH8x227XAi481iPixraDK1GEiQ6vO3/dpG96HHcgeqZoY5v3EBWjHvB5PpYttw905PV+RI1vlf/2 X-Received: by 10.101.80.69 with SMTP id k5mr3181456pgo.439.1517961273884; Tue, 06 Feb 2018 15:54:33 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1517961273; cv=none; d=google.com; s=arc-20160816; b=uTsG1Fjjb2Z4y3HmqxXH2yxqrdSxwKaac+Uw9XB8DUaweJfVxY9iFbfnJ+vEAh5rDh ZcbFAZS7piWSwpCp0s+wCak/8cLyb+FqaW2LT/wk5+o63RIBc+encnmd4zWyWVbq9/CE OlEizOGDgKnHBmPrcuE07dMwCIHoXNnkwdDp+7neapbvy12VaT9sWsx9aTcGOG7z2KV+ v19HYlCmDQVGBQ0ix/msnTYhComKDZsl7q+c/Eg9mfRhyeNYNIyHTSqG2RPGTAQ10Mir +5tvu2GcAN6NZtj8//UdOvuBS9N7zKBth5BACUABb2mmd2GVsRH7AagvLtKTfCsXpwn3 81IA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature :arc-authentication-results; bh=7aCWYerlux4ttemZHbU5bv+aMfjSx5ZhV4g02sA0R/c=; b=ho6b34ynhFl2KU1QLYbFi68KhpOqf4Xvzh3UbhctAEUKhSlm6oKgnUs1t4vKGuFZ1w GrGt1DCfUSdtd0kb8ADudG1oaWO/N3RxQfZTxES8NPf/+yYrt7dcyl9XiGw6biUzV84u eQS1JRaAvUs2eY2kv04IiiycojnImzhShopxBD6a1O8qdj7mzwHHLTW/4rdfcUW8+ErZ 5YvY/88N2UKVeoK2HRGKmqLF6m5INOhyJ2xHIZpnE2o4ITY04NoCmmn3SepmF0ONkhuz V4eN9AxKK5fV6MCfBb7u3e8A704WuHqIktqlKE/DDaWVj7mok8QHzWxmx4rQc/uzOuE+ 6ClQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=PY5q8Fjy; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id bb10-v6si118962plb.290.2018.02.06.15.54.33; Tue, 06 Feb 2018 15:54:33 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=PY5q8Fjy; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754190AbeBFXyP (ORCPT + 14 others); Tue, 6 Feb 2018 18:54:15 -0500 Received: from mail-oi0-f67.google.com ([209.85.218.67]:45688 "EHLO mail-oi0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754149AbeBFXyO (ORCPT ); Tue, 6 Feb 2018 18:54:14 -0500 Received: by mail-oi0-f67.google.com with SMTP id c189so2706317oib.12 for ; Tue, 06 Feb 2018 15:54:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=7aCWYerlux4ttemZHbU5bv+aMfjSx5ZhV4g02sA0R/c=; b=PY5q8FjytK528VNVnXKWJVTxS6ARofDMZiuZrsxSqHE3KGxJwnz5V5pOFi8PJh0V8E jVwnnuTXc0nFpOqOdDgtK2e4S10MIr4CTy8m4u9Kia8S7p+ZpFuXg6jXr0XvGjBoVE2r zj98VjdgyE5jl4MTO+bHONJdKAN/PL/YBUVXQ= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=7aCWYerlux4ttemZHbU5bv+aMfjSx5ZhV4g02sA0R/c=; b=CW+t2R9JvrGJD2X8fyxv2IZV3RVFP11di5zIPNd7qRFRgkX2iz5m3nd9cbcP3/qkW1 q7AwMtB57i6XnLdDP0D4XIQiF/2qK/zB3C8UPoc96j24et97BKeJZoJyPtym1hF2VlJz Fcd7qGo00Iq7+UdhVhgQGuQTHKS1/t8xKlm6PMS+kgMNSXEFbpy/LeMPf0LeWdsrGwa5 E+VOQUA482+TvCcWT58omS4v5PMo/ysia2TauTgK/aWbeIS+oUiCILyR8MI8+mrH2lju EPBnGo5+GsNNLSlTQ3eb6iAcFhjwKxuETH/9u5Vc+UEGxNbAgldH2QNU7tTc9UWBqL3k Z0mg== X-Gm-Message-State: APf1xPARFsNaQ3MU3U3Sz0qa+LNHVCpXPsjVRzDs1g7NRtcAAVKDqdqY fStj7i1tguhNyXQYt8kds33nZw== X-Received: by 10.84.64.14 with SMTP id x14mr2528306oie.280.1517961253585; Tue, 06 Feb 2018 15:54:13 -0800 (PST) Received: from aura.cortijodelrio.net (CableLink-187-161-113-185.PCs.InterCable.net. [187.161.113.185]) by smtp.googlemail.com with ESMTPSA id u37sm103340otc.34.2018.02.06.15.54.11 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Tue, 06 Feb 2018 15:54:12 -0800 (PST) From: =?utf-8?q?Daniel_D=C3=ADaz?= To: shuahkh@osg.samsung.com, linux-kselftest@vger.kernel.org Cc: =?utf-8?q?Daniel_D=C3=ADaz?= , Shuah Khan , Darren Hart , Kate Stewart , Greg Kroah-Hartman , Thomas Gleixner , Pintu Agarwal , linux-kernel@vger.kernel.org (open list) Subject: [PATCH] selftests/android: Fix line continuation in Makefile Date: Tue, 6 Feb 2018 17:52:05 -0600 Message-Id: <1517961219-17700-1-git-send-email-daniel.diaz@linaro.org> X-Mailer: git-send-email 2.7.4 MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The Makefile lacks a couple of line continuation backslashes in an `if' clause, which can make the subsequent rsync command go awry over the whole filesystem (`rsync -a / /`). /bin/sh: -c: line 5: syntax error: unexpected end of file make[1]: [all] Error 1 (ignored) TEST=$DIR"_test.sh"; \ if [ -e $DIR/$TEST ]; then /bin/sh: -c: line 2: syntax error: unexpected end of file make[1]: [all] Error 1 (ignored) rsync -a $DIR/$TEST $BUILD_TARGET/; [...a myriad of:] [ rsync: readlink_stat("...") failed: Permission denied (13)] [ skipping non-regular file "..."] [ rsync: opendir "..." failed: Permission denied (13)] [and many other errors...] fi make[1]: fi: Command not found make[1]: [all] Error 127 (ignored) done make[1]: done: Command not found make[1]: [all] Error 127 (ignored) Signed-off-by: Daniel Díaz --- tools/testing/selftests/android/Makefile | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) -- 2.7.4 Acked-by: Pintu Agarwal diff --git a/tools/testing/selftests/android/Makefile b/tools/testing/selftests/android/Makefile index 1a74922..f6304d2 100644 --- a/tools/testing/selftests/android/Makefile +++ b/tools/testing/selftests/android/Makefile @@ -11,11 +11,11 @@ all: BUILD_TARGET=$(OUTPUT)/$$DIR; \ mkdir $$BUILD_TARGET -p; \ make OUTPUT=$$BUILD_TARGET -C $$DIR $@;\ - #SUBDIR test prog name should be in the form: SUBDIR_test.sh + #SUBDIR test prog name should be in the form: SUBDIR_test.sh \ TEST=$$DIR"_test.sh"; \ - if [ -e $$DIR/$$TEST ]; then - rsync -a $$DIR/$$TEST $$BUILD_TARGET/; - fi + if [ -e $$DIR/$$TEST ]; then \ + rsync -a $$DIR/$$TEST $$BUILD_TARGET/; \ + fi \ done override define RUN_TESTS