From patchwork Fri Dec 11 12:39:38 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Zhen Lei X-Patchwork-Id: 341966 Delivered-To: patch@linaro.org Received: by 2002:a02:85a7:0:0:0:0:0 with SMTP id d36csp493629jai; Fri, 11 Dec 2020 04:46:48 -0800 (PST) X-Google-Smtp-Source: ABdhPJxTdqwAtdnv4lNez+ViEdJf5MXMA0HhBNOeANEXs8naMHmCZJe7LCRfYZ5Zd+beQlUXEne0 X-Received: by 2002:a17:906:7fca:: with SMTP id r10mr10863861ejs.24.1607690808016; Fri, 11 Dec 2020 04:46:48 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1607690808; cv=none; d=google.com; s=arc-20160816; b=ufRySuS5LXivA5GgYOumT2O0JcX//HGnWCTDmNHtjdNO2Pnvgv+AELlJBI/6vRycUZ cQaI5wXIsf9B4mXR/S5WSFeAYAiSb/eL/XRDf2g6cc/4v0XuHNRVMUHfQ7wiLenCNJ4r TbBclVMYksC0Jf1qdEDDhE+uO+syoRe+j660SQoylovbo0+Zc9dkCnP7OnrGs5kooX+w VvE43OUlEpHMmo9t0W095MbwKtLwCACLSWej3BqYOGSYq2b109bYrwfDuoY3oWBaV7BF e7LaXF6mvz566b6Uq2asI+b7faeoG8mHXUKkgy6Q3RKezZHxi3Obn91tDfF5WiXe3k+u wUNA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=0FQl/27h3rVQZEvr6crO6uQJ+p/bQGjRlX/gcmKo/JY=; b=umUyrGDwUwva9sN63NnkvhovBlAOwrQvRhb0tga+d/GpDH0Ltwt0xHJrt4XHg9IbOc AHIOfKellf0aoUhL+fzfbkYhjv8MVsIoMsUXAfP//2kn9LjLf/J35FdL21hCoEcvP+y0 QcT/w3Hn0Up7BV6uS85W7va09IxNuI50BZ1weTkXEvddtPOynHx5ETwDjLt+NDiAtYH/ WmLRveOWpXkTM8ZG9Cug2YAFmUpzmdiZxHHg1OZBjwF8wL8eLeihi/bs22MV5jWaMWNB kztRgodEGuGYqXtsXfUEgFWXzxlCV1zq9dL+FNvKQw96MEipeVW9b7aGjgDHO9lGqIMo eNhg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-i2c-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-i2c-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id d3si4884143edo.149.2020.12.11.04.46.47; Fri, 11 Dec 2020 04:46:48 -0800 (PST) Received-SPF: pass (google.com: domain of linux-i2c-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-i2c-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-i2c-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2404071AbgLKMpZ (ORCPT + 2 others); Fri, 11 Dec 2020 07:45:25 -0500 Received: from szxga04-in.huawei.com ([45.249.212.190]:9195 "EHLO szxga04-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2436543AbgLKMpA (ORCPT ); Fri, 11 Dec 2020 07:45:00 -0500 Received: from DGGEMS404-HUB.china.huawei.com (unknown [172.30.72.58]) by szxga04-in.huawei.com (SkyGuard) with ESMTP id 4Csr6C488Dzkk54; Fri, 11 Dec 2020 20:42:43 +0800 (CST) Received: from thunder-town.china.huawei.com (10.174.177.9) by DGGEMS404-HUB.china.huawei.com (10.3.19.204) with Microsoft SMTP Server id 14.3.487.0; Fri, 11 Dec 2020 20:43:17 +0800 From: Zhen Lei To: Rob Herring , Serge Semin , Wolfram Sang , linux-i2c , devicetree , linux-kernel CC: Zhen Lei Subject: [PATCH 1/1] dt-bindings: i2c: dw: don't set "#address-cells" and "#size-cells" as required Date: Fri, 11 Dec 2020 20:39:38 +0800 Message-ID: <20201211123938.2020-1-thunder.leizhen@huawei.com> X-Mailer: git-send-email 2.26.0.windows.1 MIME-Version: 1.0 X-Originating-IP: [10.174.177.9] X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-i2c@vger.kernel.org "#address-cells" and "#size-cells" is required only when the I2C controller has subnodes. Of the four examples given in this document, only the third has a child node "eeprom@64". Ohterwise, false positives similar to the following are reported: /root/linux-next/arch/arm64/boot/dts/hisilicon/hi6220-hikey.dt.yaml: \ i2c@f7100000: '#address-cells' is a required property /root/linux-next/arch/arm64/boot/dts/hisilicon/hi6220-hikey.dt.yaml: \ i2c@f7100000: '#size-cells' is a required property In fact, the predecessor of this document: i2c-designware.txt, does not list "#address-cells" and "#size-cells" as "Required properties" also. Signed-off-by: Zhen Lei --- Documentation/devicetree/bindings/i2c/snps,designware-i2c.yaml | 8 -------- 1 file changed, 8 deletions(-) -- 1.8.3 diff --git a/Documentation/devicetree/bindings/i2c/snps,designware-i2c.yaml b/Documentation/devicetree/bindings/i2c/snps,designware-i2c.yaml index 4f746bef23742e9..c22b66b6219eaa3 100644 --- a/Documentation/devicetree/bindings/i2c/snps,designware-i2c.yaml +++ b/Documentation/devicetree/bindings/i2c/snps,designware-i2c.yaml @@ -101,8 +101,6 @@ unevaluatedProperties: false required: - compatible - reg - - "#address-cells" - - "#size-cells" - interrupts examples: @@ -110,8 +108,6 @@ examples: i2c@f0000 { compatible = "snps,designware-i2c"; reg = <0xf0000 0x1000>; - #address-cells = <1>; - #size-cells = <0>; interrupts = <11>; clock-frequency = <400000>; }; @@ -119,8 +115,6 @@ examples: i2c@1120000 { compatible = "snps,designware-i2c"; reg = <0x1120000 0x1000>; - #address-cells = <1>; - #size-cells = <0>; interrupts = <12 1>; clock-frequency = <400000>; i2c-sda-hold-time-ns = <300>; @@ -148,8 +142,6 @@ examples: reg = <0x100400 0x100>, <0x198 0x8>; pinctrl-0 = <&i2c_pins>; pinctrl-names = "default"; - #address-cells = <1>; - #size-cells = <0>; interrupts = <8>; clocks = <&ahb_clk>; };