From patchwork Tue Dec 8 09:32:04 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Enrico Weigelt, metux IT consult" X-Patchwork-Id: 340195 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI, SPF_HELO_NONE, SPF_PASS, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A30B9C433FE for ; Tue, 8 Dec 2020 09:35:01 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 4A4BF23A52 for ; Tue, 8 Dec 2020 09:35:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727771AbgLHJfA (ORCPT ); Tue, 8 Dec 2020 04:35:00 -0500 Received: from mout.kundenserver.de ([212.227.126.130]:55307 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726584AbgLHJe7 (ORCPT ); Tue, 8 Dec 2020 04:34:59 -0500 Received: from orion.localdomain ([95.117.39.192]) by mrelayeu.kundenserver.de (mreue011 [212.227.15.167]) with ESMTPSA (Nemesis) id 1M8hlZ-1kqiDJ1wwb-004mb7; Tue, 08 Dec 2020 10:32:08 +0100 From: "Enrico Weigelt, metux IT consult" To: linux-kernel@vger.kernel.org Cc: duncan.sands@free.fr, accessrunner-general@lists.sourceforge.net, linux-usb@vger.kernel.org Subject: [PATCH 1/3] drivers: usb: atm: reduce noise Date: Tue, 8 Dec 2020 10:32:04 +0100 Message-Id: <20201208093206.24780-1-info@metux.net> X-Mailer: git-send-email 2.11.0 X-Provags-ID: V03:K1:iSgMJMzCNUTd221b4ZZkoUHSLM4f7iwwAPT7Elb1vOnULyrJnNr 3bazwtfUVGsfuSO0cSygFbaTm6cajstD8lMNd/JmBPt4DpC9uf/WMtWEZd4MNguqkn6vGh9 kLZ9t1Xn4gkACfSKgCar+//SOGDOClxV7SY8rzG/SZzltKnAawbYMUt3svgcvV4QsNpPvL5 O9VcNumL/0tpNQSeBbCrw== X-UI-Out-Filterresults: notjunk:1; V03:K0:7XLfjbf7OQ0=:7zc+8I1V8VTU6ktfQyvqu7 5lcISjwfr+iumYsKiR/YsehQseA7WtANLNQrLIUjXpIYM9Cg9MSRE8rj8flsrG6esdAC0zi+4 UR5CWGUvv4qghaG4dL6ecMAMsaiHJMz8Rv9iNhGv/MWUVgxUFCzThqPVyyrLm7B+HXfnCAjY3 QPk2GhVw6Q27BFbUC9EyqsQUu00Xttu16Q0uJmSO+YTu/IDPkuM4FIhwakKnTuYUfCUj2fn6C EDihV2S/Ry0+8XSWScr2PUA98o0Ps+r9j8QuXfofjIWa6aKhrUaFUOi3BsudC1aSUazN/Tfuw z6nDdhSeCpSV/dhQGMmQaqBMczBxqtKonxmuuu1VYYQOm7gvRdcc4FQOwJlzkS1PSRLFxHHp5 DiiKowD5KpTFyBrdkzHtiB04B6oi0NcJwb8sEi5A8RMX+VwffUleMUOqpUMlL Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org If drivers work correctly, they should remain silent. Signed-off-by: Enrico Weigelt, metux IT consult --- drivers/usb/atm/cxacru.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/usb/atm/cxacru.c b/drivers/usb/atm/cxacru.c index e62a770a5d3b..0114cc54e622 100644 --- a/drivers/usb/atm/cxacru.c +++ b/drivers/usb/atm/cxacru.c @@ -810,9 +810,6 @@ static int cxacru_atm_start(struct usbatm_data *usbatm_instance, mutex_unlock(&instance->poll_state_serialize); mutex_unlock(&instance->adsl_state_serialize); - printk(KERN_INFO "%s%d: %s %pM\n", atm_dev->type, atm_dev->number, - usbatm_instance->description, atm_dev->esi); - if (start_polling) cxacru_poll_status(&instance->poll_work.work); return 0; From patchwork Tue Dec 8 09:32:06 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Enrico Weigelt, metux IT consult" X-Patchwork-Id: 340194 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.7 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI, SPF_HELO_NONE, SPF_PASS, URIBL_BLOCKED, USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D1A09C1B0D9 for ; Tue, 8 Dec 2020 09:35:34 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 93E8A23A52 for ; Tue, 8 Dec 2020 09:35:34 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728699AbgLHJfB (ORCPT ); Tue, 8 Dec 2020 04:35:01 -0500 Received: from mout.kundenserver.de ([212.227.126.131]:47375 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727482AbgLHJfA (ORCPT ); Tue, 8 Dec 2020 04:35:00 -0500 Received: from orion.localdomain ([95.117.39.192]) by mrelayeu.kundenserver.de (mreue011 [212.227.15.167]) with ESMTPSA (Nemesis) id 1MDhQt-1ktUBK0RVv-00AoTj; Tue, 08 Dec 2020 10:32:09 +0100 From: "Enrico Weigelt, metux IT consult" To: linux-kernel@vger.kernel.org Cc: duncan.sands@free.fr, accessrunner-general@lists.sourceforge.net, linux-usb@vger.kernel.org Subject: [PATCH 3/3] drivers: usb: atm: use pr_err() and pr_warn() instead of raw printk() Date: Tue, 8 Dec 2020 10:32:06 +0100 Message-Id: <20201208093206.24780-3-info@metux.net> X-Mailer: git-send-email 2.11.0 In-Reply-To: <20201208093206.24780-1-info@metux.net> References: <20201208093206.24780-1-info@metux.net> X-Provags-ID: V03:K1:MmyerTd2PpR2Z6zqetbr9VnuqB7jfj2Aq2+ftbj5b6kC3eQIVeu 7d26a0rA1zLDCHdQ3SGbT88WgDRZvu8MNw8D4CNpu7T7B0LEdbP4z/dbCBXTy1fLT/gxSOv O3f5+OHRIJVEf4NZvbICGJA+BJmlBZ+tYbYWBxSX8BZE6DEyrQNV6xF7kEIkV0stP9uD4rt zzybvbZ4M8ZnlzmZjSZPg== X-UI-Out-Filterresults: notjunk:1; V03:K0:GAEp16o9VWk=:EfpMJ1HqMj/DZqe+yxrE/+ 6I72SeZLrLcSS0oY4uzrv452BWQiEGw7ozIebcsKaQ0Dq23ryGUEC4wSrKrogFDbkMWrXaf2f VeFqQlHZ3JsTMaRk9mdS26f4F6fCNNXOIt91NzvNWOJr2ftnK+mgasM4qLeVdS3vNKjL0zPdT V5g65FpTxJT4W9dKv51TrtmZrGIxC1+xnwsjvG+tV2sIgV7+mHXIjnUi9S6T/dGar1VeHQQs2 n5BdpKBHADOLf5Wti2eKjka4wf6ONmAJdVSdYxyHiQUtgMv/73pbqcci9ohTeIa7pIeeSfb7r cztuk9qGu0Aq6+Pr1vctxKmZ41gBHk4rAOPFFkL7iREvkbPIp5d0gAopnEBJapw/lxz3WzG76 1ycO45OeG94LrOKz2MEr5zpWD/ZTzpGmc/oA2VhSkOGaLBd5AVa92PW3YPaA5 Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org Since we have the nice helpers pr_err() and pr_warn(), use them instead of raw printk(). Signed-off-by: Enrico Weigelt, metux IT consult --- drivers/usb/atm/usbatm.c | 2 +- drivers/usb/atm/xusbatm.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/usb/atm/usbatm.c b/drivers/usb/atm/usbatm.c index 56fe30d247da..1c90aa273a41 100644 --- a/drivers/usb/atm/usbatm.c +++ b/drivers/usb/atm/usbatm.c @@ -1278,7 +1278,7 @@ EXPORT_SYMBOL_GPL(usbatm_usb_disconnect); static int __init usbatm_usb_init(void) { if (sizeof(struct usbatm_control) > sizeof_field(struct sk_buff, cb)) { - printk(KERN_ERR "%s unusable with this kernel!\n", usbatm_driver_name); + pr_err("%s unusable with this kernel!\n", usbatm_driver_name); return -EIO; } diff --git a/drivers/usb/atm/xusbatm.c b/drivers/usb/atm/xusbatm.c index ffc9810070a3..0befbf63d1cc 100644 --- a/drivers/usb/atm/xusbatm.c +++ b/drivers/usb/atm/xusbatm.c @@ -179,7 +179,7 @@ static int __init xusbatm_init(void) num_vendor != num_product || num_vendor != num_rx_endpoint || num_vendor != num_tx_endpoint) { - printk(KERN_WARNING "xusbatm: malformed module parameters\n"); + pr_warn("xusbatm: malformed module parameters\n"); return -EINVAL; }