From patchwork Sun Jan 28 22:26:09 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sasha Levin X-Patchwork-Id: 126088 Delivered-To: patch@linaro.org Received: by 10.46.84.92 with SMTP id y28csp1973854ljd; Sun, 28 Jan 2018 15:15:02 -0800 (PST) X-Google-Smtp-Source: AH8x227quXvNmG1lFw1uHD+BphjPLyMj/Y6xuatpzWwe7KosFztwAS6nQNFcftNkIVZVVt1LqQmv X-Received: by 2002:a17:902:8497:: with SMTP id c23-v6mr10266150plo.357.1517181302703; Sun, 28 Jan 2018 15:15:02 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1517181302; cv=none; d=google.com; s=arc-20160816; b=I55G3bhAQcNbdhzYAM9UlaBV1VgTAwhwUkEip+5/UEMlNGWiC9KwDvxnZ1m+2r+BEY BnCQOdXn/ti35MaxrTRQbTdvkWQEBi0A6E32N8dQMMUFqPxhUidZ37SAv2QtwFG10L5R ULRGtNnJrd6K4ke3J22UkEkoFe1SauWAOmv0wfaH86FrD7eNpQFNP0+nhPuiznFwn2Li mJ1stGKqjm9D81wZ4ba3pK8/P9xfZmZyKVKxmU4CGRGYmDzTy8MMQb+4PG5VXhlw/X2O JAWpFRff+XlvXj9lpos/M//xQnu6P+q1xrA/RPoSRYJFctCBGvQak9gn97DVhdzu5XXv 7INQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:content-transfer-encoding :spamdiagnosticmetadata:spamdiagnosticoutput:content-language :accept-language:in-reply-to:references:message-id:date:thread-index :thread-topic:subject:cc:to:from:dkim-signature :arc-authentication-results; bh=hkfjggIuVmcZXAGK0vgtpnT5mfQwoTAM/s+3o0UY5cU=; b=M5Jktc8wGpxxXgbGLw3GguElDhypk/WkhUo6LuMUC60ntgSK/d4u4LDf7KodM7S+fX ofkpIBW4cZZuWBYVeEgPMSbtkTiK9eXp1nU+AOrPljYxMuB75I9Cbk3O1OLO0Da3QNUg IXL25uf9ZsF5o/ao9s8lMq51xjmGun2mp17TppKx4sEf+zV1pWHT4tW8wiStX4EN6hDo CCm93bzKYAVpriv11RGpgmLT5Xdo3BTulMty3FptT7VIsKJ32lhy1sPzrW/LtGHHGULv 9B9kBjtlw5E6gWlKUwoBR3+A2I3MgNhrQwi6pk62uRfG3XzTyRaK+4vK3UIDzJmRupok 9N9Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@microsoft.com header.s=selector1 header.b=eZQ3n9+M; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=microsoft.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 3-v6si7804988plr.247.2018.01.28.15.15.02; Sun, 28 Jan 2018 15:15:02 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@microsoft.com header.s=selector1 header.b=eZQ3n9+M; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=microsoft.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754221AbeA1XPA (ORCPT + 24 others); Sun, 28 Jan 2018 18:15:00 -0500 Received: from mail-by2nam01on0099.outbound.protection.outlook.com ([104.47.34.99]:35296 "EHLO NAM01-BY2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752215AbeA1W0R (ORCPT ); Sun, 28 Jan 2018 17:26:17 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=hkfjggIuVmcZXAGK0vgtpnT5mfQwoTAM/s+3o0UY5cU=; b=eZQ3n9+MEn8pHPVaM3Kv5o/hR8fwyeuacV7UD+Q5ETFL8Vp3KgjGl7rkBOPdzn8i7ZmkMF10LCJeaoDRZw+qB2KUQLgOciFTLyL0ugkEPNIOVZ7JDkY++R7dbJkWImGkqJhYVp+eYeT9wM8F3kw2phKL3uY0/mgDYBSRAgzLVdI= Received: from MW2PR2101MB1034.namprd21.prod.outlook.com (52.132.149.10) by MW2PR2101MB1004.namprd21.prod.outlook.com (52.132.146.29) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.485.0; Sun, 28 Jan 2018 22:26:11 +0000 Received: from MW2PR2101MB1034.namprd21.prod.outlook.com ([fe80::e153:81e1:bbc3:3c22]) by MW2PR2101MB1034.namprd21.prod.outlook.com ([fe80::e153:81e1:bbc3:3c22%2]) with mapi id 15.20.0485.000; Sun, 28 Jan 2018 22:26:11 +0000 From: Sasha Levin To: "linux-kernel@vger.kernel.org" , "stable@vger.kernel.org" CC: Ard Biesheuvel , Christoffer Dall , Sasha Levin Subject: [PATCH AUTOSEL for 4.14 019/100] kvm: arm: don't treat unavailable HYP mode as an error Thread-Topic: [PATCH AUTOSEL for 4.14 019/100] kvm: arm: don't treat unavailable HYP mode as an error Thread-Index: AQHTmIb/tBnnKoDxyU2Sxx6ZlB0npg== Date: Sun, 28 Jan 2018 22:26:09 +0000 Message-ID: <20180128222547.7398-19-alexander.levin@microsoft.com> References: <20180128222547.7398-1-alexander.levin@microsoft.com> In-Reply-To: <20180128222547.7398-1-alexander.levin@microsoft.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [52.168.54.252] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; MW2PR2101MB1004; 7:HF8mAJpRTi2bc6YlxEunCnhKhtREvekClvTe6y/biB2vJRM9o9CrS+vUfbiv4l+qvHeQTepR8AUJTwBt5/JWVE72GsuDrzNV7J2XOg/ud7nVOFYpk/uJTF5rUT82qr5nn0LU4yaBmYeMmT27y9Q70+RHThrhafphej6dYEICeCdRBbfkbbhagg4IByd1J8SmAb6SRLFvue43pgB8PeKOVkEbFMTNjezzBCyHugWBRqALR0CPiXsHOxTBr9dZGmJd x-ms-exchange-antispam-srfa-diagnostics: SSOS;SSOR; x-forefront-antispam-report: SFV:SKI; SCL:-1; SFV:NSPM; SFS:(10019020)(346002)(396003)(376002)(39380400002)(39860400002)(366004)(199004)(189003)(2501003)(6486002)(186003)(110136005)(5660300001)(106356001)(97736004)(68736007)(6512007)(5250100002)(316002)(53936002)(66066001)(99286004)(2950100002)(575784001)(86362001)(54906003)(22452003)(6436002)(26005)(102836004)(59450400001)(25786009)(10090500001)(76176011)(8676002)(10290500003)(14454004)(6506007)(86612001)(8936002)(81156014)(2900100001)(81166006)(1076002)(107886003)(478600001)(3280700002)(2906002)(72206003)(7736002)(305945005)(105586002)(36756003)(3846002)(3660700001)(6116002)(4326008)(22906009)(217873001); DIR:OUT; SFP:1102; SCL:1; SRVR:MW2PR2101MB1004; H:MW2PR2101MB1034.namprd21.prod.outlook.com; FPR:; SPF:None; PTR:InfoNoRecords; A:1; MX:1; LANG:en; x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: f1b666e0-c7e7-4324-5444-08d5669e22b7 x-microsoft-antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(4534165)(4627221)(201703031133081)(201702281549075)(48565401081)(5600026)(4604075)(3008032)(2017052603307)(7193020); SRVR:MW2PR2101MB1004; x-ms-traffictypediagnostic: MW2PR2101MB1004: authentication-results: spf=none (sender IP is ) smtp.mailfrom=Alexander.Levin@microsoft.com; x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(28532068793085)(180628864354917)(89211679590171); x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(61425038)(6040501)(2401047)(5005006)(8121501046)(10201501046)(93006095)(93001095)(3002001)(3231101)(944501161)(6055026)(61426038)(61427038)(6041288)(20161123564045)(20161123560045)(20161123558120)(20161123562045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(6072148)(201708071742011); SRVR:MW2PR2101MB1004; BCL:0; PCL:0; RULEID:; SRVR:MW2PR2101MB1004; x-forefront-prvs: 05669A7924 received-spf: None (protection.outlook.com: microsoft.com does not designate permitted sender hosts) x-microsoft-antispam-message-info: 8DTtDryaxn8QdQh5oqWc4NR3vRyuwcBf7nkFs5tTuChAntGdnzD5GymiKE6JJ8PT+l68oSlHB5qUHT36kSBEow== spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM MIME-Version: 1.0 X-OriginatorOrg: microsoft.com X-MS-Exchange-CrossTenant-Network-Message-Id: f1b666e0-c7e7-4324-5444-08d5669e22b7 X-MS-Exchange-CrossTenant-originalarrivaltime: 28 Jan 2018 22:26:09.9887 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 72f988bf-86f1-41af-91ab-2d7cd011db47 X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW2PR2101MB1004 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Ard Biesheuvel [ Upstream commit 58d0d19a204604ca0da26058828a53558b265da3 ] Since it is perfectly legal to run the kernel at EL1, it is not actually an error if HYP mode is not available when attempting to initialize KVM, given that KVM support cannot be built as a module. So demote the kvm_err() to kvm_info(), which prevents the error from appearing on an otherwise 'quiet' console. Acked-by: Marc Zyngier Acked-by: Christoffer Dall Signed-off-by: Ard Biesheuvel Signed-off-by: Christoffer Dall Signed-off-by: Sasha Levin --- virt/kvm/arm/arm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.11.0 diff --git a/virt/kvm/arm/arm.c b/virt/kvm/arm/arm.c index 95cba0799828..5fdd19e28904 100644 --- a/virt/kvm/arm/arm.c +++ b/virt/kvm/arm/arm.c @@ -1448,7 +1448,7 @@ int kvm_arch_init(void *opaque) bool in_hyp_mode; if (!is_hyp_mode_available()) { - kvm_err("HYP mode not available\n"); + kvm_info("HYP mode not available\n"); return -ENODEV; } From patchwork Sun Jan 28 22:26:26 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sasha Levin X-Patchwork-Id: 126087 Delivered-To: patch@linaro.org Received: by 10.46.84.92 with SMTP id y28csp1971498ljd; Sun, 28 Jan 2018 15:10:43 -0800 (PST) X-Google-Smtp-Source: AH8x227sa9DXT8DtjQeSqpC5qtBC0qg/k13FEcMIPU3sWjGH/hBVs2FHVOkC+7z1cbWRdMnnhuI8 X-Received: by 10.98.217.28 with SMTP id s28mr25120557pfg.69.1517181042865; Sun, 28 Jan 2018 15:10:42 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1517181042; cv=none; d=google.com; s=arc-20160816; b=iWh2CKED9Oy7TYq5Kus8hY9kA/9IC4rulbmg0Bsbau3AXQtm+SIOSXP6sj51/s66EW S6Lu1ju4pl8UipPyC00Pr5Zq3s8gTF2Nw659jfcs1C7X7YSmuRzvFqOZEnkxVhYwOBQN rWq5U6C0jmb2+XXM1c0zCJnlutxVPfU+vHl0Zcf2TooVi9bIPf0hmyhwF5lRC6A7ryUF LziRnOA9EBWmyGBB6n21cq4mEByXEZkE4CvMbFt/1VBA2tohcTu24CMnUw2WRpefetoa Byvw8paopnX1SvJpKsn3POK8OIOBeL62PHX0zbJEnfWyyBxiVk+nBZZags5MTdEh+DOH PUqA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:content-transfer-encoding :spamdiagnosticmetadata:spamdiagnosticoutput:content-language :accept-language:in-reply-to:references:message-id:date:thread-index :thread-topic:subject:cc:to:from:dkim-signature :arc-authentication-results; bh=wAVDeBs6DORkyzB1al0EKu6ljsjtDD4vUuWcZeGQtP0=; b=PS4bafbTegyMZkUzisWpF2xCJ9t8lXuGo5QAS3v7lBcrGyncDClcrjHWC4xHfffN5z EScVJ5YQ8VMptEvsR/fEKcT2GHDBUPUQtcw7ARKFK/GCmuIXZ8EAZ7BwtUMA3kLaik8D 7S3YuBfaotUlX8KZhhyNz7C4SHjXu2kZZv/9zimThQsthv7zp3J4y/FG0hNpN0WaFIdv ge/jKAGEiASIA9XMWV7WkZuhhvGEoKN8R2f8CcE5x2GJwCq2HSkHsE4G7H7swof+J6Pb nbbAg/9a78sOoR9JglOo4mQqXFsb5I/3HZsc76bYld0MgEZSEtyOW1N/cbXdJ7FspOZM 5Lww== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@microsoft.com header.s=selector1 header.b=WrnGSg0F; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=microsoft.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id i13-v6si1838456plr.187.2018.01.28.15.10.42; Sun, 28 Jan 2018 15:10:42 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@microsoft.com header.s=selector1 header.b=WrnGSg0F; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=microsoft.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754050AbeA1XJM (ORCPT + 24 others); Sun, 28 Jan 2018 18:09:12 -0500 Received: from mail-by2nam03on0099.outbound.protection.outlook.com ([104.47.42.99]:57621 "EHLO NAM03-BY2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753324AbeA1W1A (ORCPT ); Sun, 28 Jan 2018 17:27:00 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=wAVDeBs6DORkyzB1al0EKu6ljsjtDD4vUuWcZeGQtP0=; b=WrnGSg0FSBFy/S/zl+0CUWHURqynflYABr+xOSHIpe7rDxvMab1Mlv09ZARauce0pq7Jt8CANBW37XFHUuklA6jmf1X7NPQmYOFcLQ0A17LY3tunconK1PqDRSbvbYyShOlNaCosnY/w7jyvasXXe+0yv94tFLeDoiH4VmLL458= Received: from MW2PR2101MB1034.namprd21.prod.outlook.com (52.132.149.10) by MWHSPR01MB344.namprd21.prod.outlook.com (10.174.251.167) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.464.7; Sun, 28 Jan 2018 22:26:55 +0000 Received: from MW2PR2101MB1034.namprd21.prod.outlook.com ([fe80::e153:81e1:bbc3:3c22]) by MW2PR2101MB1034.namprd21.prod.outlook.com ([fe80::e153:81e1:bbc3:3c22%2]) with mapi id 15.20.0485.000; Sun, 28 Jan 2018 22:26:55 +0000 From: Sasha Levin To: "linux-kernel@vger.kernel.org" , "stable@vger.kernel.org" CC: Will Deacon , Matthew Wilcox , Jonathan Corbet , Sasha Levin Subject: [PATCH AUTOSEL for 4.14 043/100] scripts/kernel-doc: Don't fail with status != 0 if error encountered with -none Thread-Topic: [PATCH AUTOSEL for 4.14 043/100] scripts/kernel-doc: Don't fail with status != 0 if error encountered with -none Thread-Index: AQHTmIcJ48dQfGVOs0uGdCtZah5Mlw== Date: Sun, 28 Jan 2018 22:26:26 +0000 Message-ID: <20180128222547.7398-43-alexander.levin@microsoft.com> References: <20180128222547.7398-1-alexander.levin@microsoft.com> In-Reply-To: <20180128222547.7398-1-alexander.levin@microsoft.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [52.168.54.252] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; MWHSPR01MB344; 7:R4Yp/ydkP19hd6PUiMlp3d6qE1A4U/BDxDZPka1OiKMpKVAYJz09fUi71WmRTeNty6SY9PhQRWRys7EMcUF8NLWMaPUpGgZ1dyFf1Rep1WKzNXUdvGGDpN8wQKJxCVXwV2T3pl8ZQX4jniarXJ2N63uS+QW3sFSUBKnPtEY0i91dudpqbJ69sdetGTlPiXJ+6oHHy+1W1pjT98ZK9I/0kmGf9JWMexhMiqkX4oFTrujCFmiDveYSEFmUUarA1U3x x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: 5c77aec1-c1ab-428c-f586-08d5669e3cb4 x-microsoft-antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(4534165)(4627221)(201703031133081)(201702281549075)(48565401081)(5600026)(4604075)(3008032)(2017052603307)(7193020); SRVR:MWHSPR01MB344; x-ms-traffictypediagnostic: MWHSPR01MB344: authentication-results: spf=none (sender IP is ) smtp.mailfrom=Alexander.Levin@microsoft.com; x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(28532068793085)(180628864354917)(89211679590171); x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(61425038)(6040501)(2401047)(8121501046)(5005006)(93006095)(93001095)(3002001)(10201501046)(3231101)(944501161)(6055026)(61426038)(61427038)(6041288)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123562045)(20161123564045)(20161123558120)(20161123560045)(6072148)(201708071742011); SRVR:MWHSPR01MB344; BCL:0; PCL:0; RULEID:; SRVR:MWHSPR01MB344; x-forefront-prvs: 05669A7924 x-forefront-antispam-report: SFV:NSPM; SFS:(10019020)(346002)(39860400002)(366004)(396003)(376002)(39380400002)(189003)(199004)(10090500001)(86362001)(36756003)(99286004)(2900100001)(6486002)(6512007)(7736002)(1076002)(6436002)(3846002)(76176011)(2906002)(8676002)(86612001)(81156014)(105586002)(316002)(5250100002)(81166006)(66066001)(102836004)(478600001)(3280700002)(6116002)(14454004)(2501003)(4326008)(110136005)(10290500003)(26005)(54906003)(107886003)(53936002)(6666003)(186003)(25786009)(59450400001)(68736007)(6506007)(305945005)(5660300001)(106356001)(22452003)(2950100002)(8936002)(97736004)(3660700001)(72206003)(22906009)(217873001); DIR:OUT; SFP:1102; SCL:1; SRVR:MWHSPR01MB344; H:MW2PR2101MB1034.namprd21.prod.outlook.com; FPR:; SPF:None; PTR:InfoNoRecords; MX:1; A:1; LANG:en; received-spf: None (protection.outlook.com: microsoft.com does not designate permitted sender hosts) x-microsoft-antispam-message-info: vxdstUa4wjc9CBpBVgEBkcmaAnoPikEk+aZEA/dF5GfPw/wBS51MsGhtyKHLRcdLUTee24szh1U08E/OLee1fA== spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM MIME-Version: 1.0 X-OriginatorOrg: microsoft.com X-MS-Exchange-CrossTenant-Network-Message-Id: 5c77aec1-c1ab-428c-f586-08d5669e3cb4 X-MS-Exchange-CrossTenant-originalarrivaltime: 28 Jan 2018 22:26:26.3444 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 72f988bf-86f1-41af-91ab-2d7cd011db47 X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHSPR01MB344 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Will Deacon [ Upstream commit e814bccbafece52a24e152d2395b5d49eef55841 ] My bisect scripts starting running into build failures when trying to compile 4.15-rc1 with the builds failing with things like: drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.c:2078: error: Cannot parse struct or union! The line in question is actually just a #define, but after some digging it turns out that my scripts pass W=1 and since commit 3a025e1d1c2ea ("Add optional check for bad kernel-doc comments") that results in kernel-doc running on each source file. The file in question has a badly formatted comment immediately before the #define: /** * struct brcmf_skbuff_cb reserves first two bytes in sk_buff::cb for * bus layer usage. */ which causes the regex in dump_struct to fail (lack of braces following struct declaration) and kernel-doc returns 1, which causes the build to fail. Fix the issue by always returning 0 from kernel-doc when invoked with -none. It successfully generates no documentation, and prints out any issues. Cc: Matthew Wilcox Cc: Jonathan Corbet Signed-off-by: Will Deacon Signed-off-by: Jonathan Corbet Signed-off-by: Sasha Levin --- scripts/kernel-doc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.11.0 diff --git a/scripts/kernel-doc b/scripts/kernel-doc index 9d3eafea58f0..94dce2233503 100755 --- a/scripts/kernel-doc +++ b/scripts/kernel-doc @@ -3218,4 +3218,4 @@ if ($verbose && $warnings) { print STDERR "$warnings warnings\n"; } -exit($errors); +exit($output_mode eq "none" ? 0 : $errors);