From patchwork Sun Jan 28 22:28:30 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sasha Levin X-Patchwork-Id: 126085 Delivered-To: patch@linaro.org Received: by 10.46.84.92 with SMTP id y28csp1957066ljd; Sun, 28 Jan 2018 14:38:33 -0800 (PST) X-Google-Smtp-Source: AH8x225SJCJwOw4oXobB8fCPyQ6WaATasF7Oid66Bmz/1EEKzazzA1hYfEigUEOckl3GfkEiv2fS X-Received: by 10.98.63.214 with SMTP id z83mr24660740pfj.95.1517179113443; Sun, 28 Jan 2018 14:38:33 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1517179113; cv=none; d=google.com; s=arc-20160816; b=ou5iLMmGkbTNkvatXFx03pwy7BwdCxZjqGYk6FWncOvjzPaQfl84k4QHqGurYgXYFB IB9Ma66c2IP97b7UwtNnXZH64JhrxiR+UAqT9FD8bqc4m7/dY8kiVhuO3MKnm7KoZB5F FOYq1MCpqqJHLckQhgHKPoNLH2+B2rqLunmcA30M+Re5qCGEXHGMYP2CF1wGK+yMCm0l qJZ4/E6Gj2kB1MNsK08pTnDqhYeEvfkq4hNEkB5we8TQA1M8lvIRWEqA8SPjlRwVf1Be faaave/ED6YWTfNSlYfYZqd2GFBE6V0wKWwyeSqRjqwckdjfxEIqdm0gqDwaaEeDpZF/ 7sOw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:content-transfer-encoding :spamdiagnosticmetadata:spamdiagnosticoutput:content-language :accept-language:in-reply-to:references:message-id:date:thread-index :thread-topic:subject:cc:to:from:dkim-signature :arc-authentication-results; bh=GQTdhKznRDAPsc7UTFrYh5wO8YeDbcQ39kX0w9hPEZQ=; b=WA2JiMvbRbWJjrNZMYp4uDWh8C3xcdIGgW7pkNIzrw33D+xk7jdNlVStDuIp2mKqNl 6hp/HtY0humc/6pZRIyGEWqvTnwaKooYtcpy3m809bTlsawjmqcjjR6VD4XIgEK7UI7a DrI9FBdsKlTkozg/hTSR1iKrYct9nPwI4/UjzKF3tYP0CBHTWXc+lDa2PEgSWGG/U45l cHwaiS+FaNhvmJlWIhSZ+2qitFJVQVy1n6Ch6pNWwhb/KEMogW80VmzgG/lCQIqdSjlP gcLHm1uJydubOgEErqE2BGsfDqAQ6Se2IdsSH/HtG1CNHnOxmmI+MYNBlGUeTGqJ8Su8 tCRg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@microsoft.com header.s=selector1 header.b=WtspOxS9; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=microsoft.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id p7si10503191pfk.8.2018.01.28.14.38.33; Sun, 28 Jan 2018 14:38:33 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@microsoft.com header.s=selector1 header.b=WtspOxS9; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=microsoft.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932540AbeA1WaJ (ORCPT + 24 others); Sun, 28 Jan 2018 17:30:09 -0500 Received: from mail-bn3nam01on0127.outbound.protection.outlook.com ([104.47.33.127]:53399 "EHLO NAM01-BN3-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753789AbeA1W3x (ORCPT ); Sun, 28 Jan 2018 17:29:53 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=GQTdhKznRDAPsc7UTFrYh5wO8YeDbcQ39kX0w9hPEZQ=; b=WtspOxS9N10qTXU10W/CaeoDJcPJXqK3KxVgdS8XLBAt3UYTSrvfSjHzyKs+m9e50nzK6jAKbvPvfnm9v00TMuJQSzl+cJ6aBUfnLdNxsHuGcLEsjDDo+L9z6ZV3oLCu/lUkKottMqVfBnRoHC0MzpebEMSfp0BsGqo7NR0XwRw= Received: from MW2PR2101MB1034.namprd21.prod.outlook.com (52.132.149.10) by MW2PR2101MB1115.namprd21.prod.outlook.com (52.132.149.32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.485.0; Sun, 28 Jan 2018 22:29:45 +0000 Received: from MW2PR2101MB1034.namprd21.prod.outlook.com ([fe80::e153:81e1:bbc3:3c22]) by MW2PR2101MB1034.namprd21.prod.outlook.com ([fe80::e153:81e1:bbc3:3c22%2]) with mapi id 15.20.0485.000; Sun, 28 Jan 2018 22:29:45 +0000 From: Sasha Levin To: "linux-kernel@vger.kernel.org" , "stable@vger.kernel.org" CC: Will Deacon , Matthew Wilcox , Jonathan Corbet , Sasha Levin Subject: [PATCH AUTOSEL for 4.4 11/36] scripts/kernel-doc: Don't fail with status != 0 if error encountered with -none Thread-Topic: [PATCH AUTOSEL for 4.4 11/36] scripts/kernel-doc: Don't fail with status != 0 if error encountered with -none Thread-Index: AQHTmIdSkyTyYhKfikeTA41Tkm3baQ== Date: Sun, 28 Jan 2018 22:28:30 +0000 Message-ID: <20180128222815.29479-11-alexander.levin@microsoft.com> References: <20180128222815.29479-1-alexander.levin@microsoft.com> In-Reply-To: <20180128222815.29479-1-alexander.levin@microsoft.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [52.168.54.252] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; MW2PR2101MB1115; 7:8wjD3Y0u6TykIrhR5CS1LlUlgqxhi9eFjX4LP3pttqzGQ0Wlu+pjUasVQm613u1h/UtS44TIuZDUfDVrFDZLuX9XlcEGlMdFeDtlGRvCetBsrs7YN54HdOCck9KPhFn/YcwTzS+TgGpZEg5WZFSMcLV83BhqLGTtSGmbqNEPbnsYQQ2MT9vXix/aZbNyknpvlPfnKql3H6ftSK/A+IGWqnZHNkhuXA3XGUnfuelis1OA4qeyS1x/sBjh0wSsgz/7 x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: 614349ef-4746-4cdd-fb50-08d5669ea23f x-microsoft-antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(4534165)(4627221)(201703031133081)(201702281549075)(48565401081)(5600026)(4604075)(3008032)(2017052603307)(7193020); SRVR:MW2PR2101MB1115; x-ms-traffictypediagnostic: MW2PR2101MB1115: authentication-results: spf=none (sender IP is ) smtp.mailfrom=Alexander.Levin@microsoft.com; x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(28532068793085)(180628864354917)(89211679590171); x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(61425038)(6040501)(2401047)(5005006)(8121501046)(93006095)(93001095)(3002001)(10201501046)(3231101)(944501161)(6055026)(61426038)(61427038)(6041288)(20161123560045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123558120)(20161123564045)(20161123562045)(6072148)(201708071742011); SRVR:MW2PR2101MB1115; BCL:0; PCL:0; RULEID:; SRVR:MW2PR2101MB1115; x-forefront-prvs: 05669A7924 x-forefront-antispam-report: SFV:NSPM; SFS:(10019020)(376002)(346002)(39860400002)(396003)(366004)(39380400002)(199004)(189003)(3280700002)(2906002)(4326008)(6486002)(6512007)(102836004)(53936002)(97736004)(1076002)(3660700001)(105586002)(3846002)(54906003)(110136005)(186003)(66066001)(25786009)(26005)(305945005)(6116002)(99286004)(107886003)(6436002)(81156014)(5250100002)(81166006)(8676002)(22452003)(86362001)(2950100002)(36756003)(316002)(478600001)(106356001)(8936002)(2501003)(5660300001)(7736002)(6666003)(72206003)(10090500001)(68736007)(10290500003)(86612001)(2900100001)(14454004)(76176011)(59450400001)(6506007)(22906009)(217873001); DIR:OUT; SFP:1102; SCL:1; SRVR:MW2PR2101MB1115; H:MW2PR2101MB1034.namprd21.prod.outlook.com; FPR:; SPF:None; PTR:InfoNoRecords; A:1; MX:1; LANG:en; received-spf: None (protection.outlook.com: microsoft.com does not designate permitted sender hosts) x-microsoft-antispam-message-info: Qha8DE+YrytgD4wBmUkGUu+BGh9vVCoLKi8Ys7J05uKtGNHPeC7YZT3fB99CXc2UDzEQqB6+AZKbhwVEPK5Xyw== spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM MIME-Version: 1.0 X-OriginatorOrg: microsoft.com X-MS-Exchange-CrossTenant-Network-Message-Id: 614349ef-4746-4cdd-fb50-08d5669ea23f X-MS-Exchange-CrossTenant-originalarrivaltime: 28 Jan 2018 22:28:30.2376 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 72f988bf-86f1-41af-91ab-2d7cd011db47 X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW2PR2101MB1115 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Will Deacon [ Upstream commit e814bccbafece52a24e152d2395b5d49eef55841 ] My bisect scripts starting running into build failures when trying to compile 4.15-rc1 with the builds failing with things like: drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.c:2078: error: Cannot parse struct or union! The line in question is actually just a #define, but after some digging it turns out that my scripts pass W=1 and since commit 3a025e1d1c2ea ("Add optional check for bad kernel-doc comments") that results in kernel-doc running on each source file. The file in question has a badly formatted comment immediately before the #define: /** * struct brcmf_skbuff_cb reserves first two bytes in sk_buff::cb for * bus layer usage. */ which causes the regex in dump_struct to fail (lack of braces following struct declaration) and kernel-doc returns 1, which causes the build to fail. Fix the issue by always returning 0 from kernel-doc when invoked with -none. It successfully generates no documentation, and prints out any issues. Cc: Matthew Wilcox Cc: Jonathan Corbet Signed-off-by: Will Deacon Signed-off-by: Jonathan Corbet Signed-off-by: Sasha Levin --- scripts/kernel-doc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.11.0 diff --git a/scripts/kernel-doc b/scripts/kernel-doc index 638a38e1b419..bba8ad9c4f2c 100755 --- a/scripts/kernel-doc +++ b/scripts/kernel-doc @@ -2742,4 +2742,4 @@ if ($verbose && $warnings) { print STDERR "$warnings warnings\n"; } -exit($errors); +exit($output_mode eq "none" ? 0 : $errors);