From patchwork Thu Dec 3 22:29:43 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arnd Bergmann X-Patchwork-Id: 336951 Delivered-To: patch@linaro.org Received: by 2002:a92:5e16:0:0:0:0:0 with SMTP id s22csp674355ilb; Thu, 3 Dec 2020 14:32:25 -0800 (PST) X-Google-Smtp-Source: ABdhPJyZDG5DVcqmHqQ93INV/fApwBMBQitwNKkBdSx9zd8E8+pqCeLD13luUQbeZVr8CsgQ8g2R X-Received: by 2002:a17:906:17d1:: with SMTP id u17mr4421176eje.6.1607034745165; Thu, 03 Dec 2020 14:32:25 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1607034745; cv=none; d=google.com; s=arc-20160816; b=jOh588xz6HxRNwb4IsU/YXTUJIXXt/aHESZzbDNAN34ilHbGP5xdOPT8yG4PUqbWJn d3dY2ukljTaNDXxdD3/ngdm+9fvqtW9MgoUlqxl5ZJ1cRRUBLonba3bATzTIJMAuMtbA W2zEZuGsjN/JE/83iEziiINS/SLi4LL6XfqWadgCSOTqbathidSlT+G+r50Bg+PvTlxC CauvUVsbulmWyx3W9ZaJ171yJKQeP6tlhUbTRkuAudATzun0nbuzx1j0sCciTkvPmn9K IWthW68Ua+GwYAN0ouP7vWNhUAtsBHb/cZ1MIFfA56uMDnz6a1ETBVLo81LntH1dWvt9 L+9g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=+Rjn4jXEjXuUE1fPtvBwfTHZcUH/SkAFYUYJZMZnNyY=; b=gJI1uyxazr6kkTKPHhLd0rCoGUqtaslCMI8t43v5jphxFV/Ac2VI16cxbLiRPgtedr 3ZsA5UKzG7jvHxrcfHglPY2g2pJFRj2LPqSjNH7bFrIuJxtzwP3ctE32lYO8YLMrRulP bzti0mlfPvdGvihk5S2FsgFAGjd/rk2whGIEhvYoQH6bGG9RwGBdu0uwTIOOO6EGtOUm 5VA/rIwurzaBp9poH7U677hqVIDGoz4ngxe9Tw+dHFbQztaygz1n1BiYFMM+vdSZcLfM xldSLxHVO1pA0CjMsUe0UB3wuQi7I+nHnuiN30G0pDeq4rVperpC7pNarGCC+zqLKM24 UDqQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-media-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-media-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id x60si1782756ede.80.2020.12.03.14.32.23; Thu, 03 Dec 2020 14:32:25 -0800 (PST) Received-SPF: pass (google.com: domain of linux-media-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-media-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-media-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729127AbgLCWam (ORCPT + 4 others); Thu, 3 Dec 2020 17:30:42 -0500 Received: from mail.kernel.org ([198.145.29.99]:54798 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725885AbgLCWal (ORCPT ); Thu, 3 Dec 2020 17:30:41 -0500 From: Arnd Bergmann Authentication-Results: mail.kernel.org; dkim=permerror (bad message/signature format) To: Dongchun Zhu , Mauro Carvalho Chehab , Nathan Chancellor , Nick Desaulniers , Andy Shevchenko , Sakari Ailus Cc: Arnd Bergmann , linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, clang-built-linux@googlegroups.com Subject: [PATCH] media: i2c: fix an uninitialized error code Date: Thu, 3 Dec 2020 23:29:43 +0100 Message-Id: <20201203222956.1091606-1-arnd@kernel.org> X-Mailer: git-send-email 2.27.0 MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org From: Arnd Bergmann Clang points out that the error handling in ov02a10_s_stream() is broken, and just returns a random error code: drivers/media/i2c/ov02a10.c:537:6: warning: variable 'ret' is used uninitialized whenever 'if' condition is true [-Wsometimes-uninitialized] if (ov02a10->streaming == on) ^~~~~~~~~~~~~~~~~~~~~~~~ drivers/media/i2c/ov02a10.c:568:9: note: uninitialized use occurs here return ret; ^~~ drivers/media/i2c/ov02a10.c:537:2: note: remove the 'if' if its condition is always false if (ov02a10->streaming == on) ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~ drivers/media/i2c/ov02a10.c:533:9: note: initialize the variable 'ret' to silence this warning int ret; I assume that -EBUSY is the intended error code, so use that. Fixes: 91807efbe8ec ("media: i2c: add OV02A10 image sensor driver") Signed-off-by: Arnd Bergmann --- drivers/media/i2c/ov02a10.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) -- 2.27.0 diff --git a/drivers/media/i2c/ov02a10.c b/drivers/media/i2c/ov02a10.c index 391718136ade..7ee9c904d9b5 100644 --- a/drivers/media/i2c/ov02a10.c +++ b/drivers/media/i2c/ov02a10.c @@ -534,8 +534,10 @@ static int ov02a10_s_stream(struct v4l2_subdev *sd, int on) mutex_lock(&ov02a10->mutex); - if (ov02a10->streaming == on) + if (ov02a10->streaming == on) { + ret = -EBUSY; goto unlock_and_return; + } if (on) { ret = pm_runtime_get_sync(&client->dev);