From patchwork Sat Nov 28 22:40:47 2020
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
X-Patchwork-Submitter: Sam Ravnborg <sam@ravnborg.org>
X-Patchwork-Id: 334267
Return-Path: <linux-fbdev-owner@kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
 aws-us-west-2-korg-lkml-1.web.codeaurora.org
X-Spam-Level: 
X-Spam-Status: No, score=-16.7 required=3.0 tests=BAYES_00,DKIM_SIGNED,
 DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,
 INCLUDES_PATCH, 
 MAILING_LIST_MULTI, SPF_HELO_NONE, SPF_PASS, URIBL_BLOCKED,
 USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0
Received: from mail.kernel.org (mail.kernel.org [198.145.29.99])
 by smtp.lore.kernel.org (Postfix) with ESMTP id 893BEC64E8A
 for <linux-fbdev@archiver.kernel.org>;
 Sat, 28 Nov 2020 22:42:19 +0000 (UTC)
Received: from vger.kernel.org (vger.kernel.org [23.128.96.18])
 by mail.kernel.org (Postfix) with ESMTP id 4B4CE221FD
 for <linux-fbdev@archiver.kernel.org>;
 Sat, 28 Nov 2020 22:42:19 +0000 (UTC)
Authentication-Results: mail.kernel.org;
 dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com
 header.b="D1FrkInr"
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
 id S2387679AbgK1WmO (ORCPT <rfc822; linux-fbdev@archiver.kernel.org>);
 Sat, 28 Nov 2020 17:42:14 -0500
Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49186 "EHLO
 lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by
 vger.kernel.org with ESMTP id S2387681AbgK1WmM (ORCPT
 <rfc822;linux-fbdev@vger.kernel.org>);
 Sat, 28 Nov 2020 17:42:12 -0500
Received: from mail-lj1-x242.google.com (mail-lj1-x242.google.com
 [IPv6:2a00:1450:4864:20::242])
 by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6EEA8C0613D2
 for <linux-fbdev@vger.kernel.org>;
 Sat, 28 Nov 2020 14:41:26 -0800 (PST)
Received: by mail-lj1-x242.google.com with SMTP id r18so10598494ljc.2
 for <linux-fbdev@vger.kernel.org>;
 Sat, 28 Nov 2020 14:41:26 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;
 h=sender:from:to:cc:subject:date:message-id:in-reply-to:references
 :mime-version:content-transfer-encoding;
 bh=gw87Y4IiQJRQFmGErQUGgzYt7CqBei5ZQnPlbru6PWM=;
 b=D1FrkInrUH9DKh9fBfCgXd8dBK46ZCmcALKbGOKNCiK+J9hf4uOuz98FBOxfEXnucr
 +yylo65m4rrV2di8RnAgj5Y3xtMIVWmwHK0r4kWr8QqQyyYycl969jJnWwZQSs5JHn3U
 wpJ+39OsTa2yXN2ZFeLVX1D1iZKKh7eXpE4Qebgnf6Q2PCSKV36TTz10/Q/Qo9cct1YC
 3DCHIYsu0/XEo74ZCp7ArxmjnsfRRPkh6RJl0kWdqHF7Ynq6yBnXnACAnjLVH1Lyp8zr
 niO+HMd0wJ2ntb9UDdh1rVKc91e//OPtykv5hCMzix3yLvonvcYyhjdjznACbj+w1bDE
 x8dw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20161025;
 h=x-gm-message-state:sender:from:to:cc:subject:date:message-id
 :in-reply-to:references:mime-version:content-transfer-encoding;
 bh=gw87Y4IiQJRQFmGErQUGgzYt7CqBei5ZQnPlbru6PWM=;
 b=cCAsHzjd4+4wtEqYWZMFVcBbR4k7hhf9ffstgF+KxC3mUfwfZnw2kGPbLC63bBCWMY
 J0i294V0qfVpe4e6xx3L/+4m2nf7om1rHQzoV6BnaCUAtR9QYKg8TCD31BoPuOBVAdwG
 Jvz4yhQ/nDLf0T5TQwzae0ytmV6qAizJWbNjq+6/U+orFY+ChA0NtABpnA/3tM/+OyZY
 EWco40VpHcIDw+DDzEFYg4SnCr9PJB6pkbeo17iBWOb/m4ljiF/6DECYlIhcof8wK1RA
 NIvPOIuGjKsXMndOwfhMM37ggbhViGylCniQAKQFUpugBtnlW/U6AhC4hS0XOHHtHs9r
 KSxA==
X-Gm-Message-State: AOAM533dP8BR+73zFduxKbPiaDXQFcEF6FADh9htV1vVoeIJ9oUvaJ3f
 oiX6GxQbK70vdVzkPJWyXRoau3wPqyPE6Q==
X-Google-Smtp-Source: ABdhPJwHtAja16Il25CYWJK9GBsVfOJBjtSMVre8TMUl/j8LWRHFKxCZY9K1/6bDzlvVdCzO3dScqw==
X-Received: by 2002:a2e:6e06:: with SMTP id j6mr6627173ljc.282.1606603284768; 
 Sat, 28 Nov 2020 14:41:24 -0800 (PST)
Received: from saturn.localdomain ([2a00:fd00:8060:1c00:a4c7:9ff9:a160:aad0])
 by smtp.gmail.com with ESMTPSA id
 w21sm1236857lff.280.2020.11.28.14.41.22
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Sat, 28 Nov 2020 14:41:24 -0800 (PST)
Sender: Sam Ravnborg <sam.ravnborg@gmail.com>
From: Sam Ravnborg <sam@ravnborg.org>
To: linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org,
 Lee Jones <lee.jones@linaro.org>
Cc: Aditya Pakki <pakki001@umn.edu>,
 Alexander Klimov <grandmaster@al2klimov.de>,
 Alex Dewar <alex.dewar90@gmail.com>, Antonino Daplas <adaplas@gmail.com>,
 Arnd Bergmann <arnd@arndb.de>,
 Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
 Benjamin Herrenschmidt <benh@kernel.crashing.org>,
 Daniel Vetter <daniel.vetter@ffwll.ch>, Evgeny Novikov <novikov@ispras.ru>,
 Florian Tobias Schandinat <FlorianSchandinat@gmx.de>,
 George Kennedy <george.kennedy@oracle.com>,
 Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
 Gustavo Silva <gustavoars@kernel.org>,
 Jani Nikula <jani.nikula@intel.com>, Jason Yan <yanaijie@huawei.com>,
 Jingoo Han <jingoohan1@gmail.com>, Jiri Slaby <jirislaby@kernel.org>,
 Joe Perches <joe@perches.com>,
 Kristoffer Ericson <kristoffer.ericson@gmail.com>,
 Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
 Mike Rapoport <rppt@kernel.org>,
 Nathan Chancellor <natechancellor@gmail.com>,
 Peilin Ye <yepeilin.cs@gmail.com>, Peter Rosin <peda@axentia.se>,
 Qilong Zhang <zhangqilong3@huawei.com>,
 Randy Dunlap <rdunlap@infradead.org>,
 Saeed Mirzamohammadi <saeed.mirzamohammadi@oracle.com>,
 Sam Ravnborg <sam@ravnborg.org>,
 Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>,
 Thomas Winischhofer <thomas@winischhofer.net>,
 Thomas Zimemrmann <tzimmermann@suse.de>,
 Vaibhav Gupta <vaibhavgupta40@gmail.com>,
 Xiaofei Tan <tanxiaofei@huawei.com>
Subject: [PATCH v2 01/28] video: Fix kernel-doc warnings in
 of_display_timing + of_videomode
Date: Sat, 28 Nov 2020 23:40:47 +0100
Message-Id: <20201128224114.1033617-2-sam@ravnborg.org>
X-Mailer: git-send-email 2.27.0
In-Reply-To: <20201128224114.1033617-1-sam@ravnborg.org>
References: <20201128224114.1033617-1-sam@ravnborg.org>
MIME-Version: 1.0
Precedence: bulk
List-ID: <linux-fbdev.vger.kernel.org>
X-Mailing-List: linux-fbdev@vger.kernel.org

Fix kernel-doc warnings reported when using W=1.

v2:
  - Improve subject (Lee)

Signed-off-by: Sam Ravnborg <sam@ravnborg.org>
Cc: Lee Jones <lee.jones@linaro.org>
Cc: linux-fbdev@vger.kernel.org
---
 drivers/video/of_display_timing.c | 1 +
 drivers/video/of_videomode.c      | 8 ++++----
 2 files changed, 5 insertions(+), 4 deletions(-)

diff --git a/drivers/video/of_display_timing.c b/drivers/video/of_display_timing.c
index abc9ada798ee..f93b6abbe258 100644
--- a/drivers/video/of_display_timing.c
+++ b/drivers/video/of_display_timing.c
@@ -52,6 +52,7 @@ static int parse_timing_property(const struct device_node *np, const char *name,
 /**
  * of_parse_display_timing - parse display_timing entry from device_node
  * @np: device_node with the properties
+ * @dt: display_timing that contains the result. I may be partially written in case of errors
  **/
 static int of_parse_display_timing(const struct device_node *np,
 		struct display_timing *dt)
diff --git a/drivers/video/of_videomode.c b/drivers/video/of_videomode.c
index 67aff2421c29..a5bb02f02b44 100644
--- a/drivers/video/of_videomode.c
+++ b/drivers/video/of_videomode.c
@@ -13,10 +13,10 @@
 #include <video/videomode.h>
 
 /**
- * of_get_videomode - get the videomode #<index> from devicetree
- * @np - devicenode with the display_timings
- * @vm - set to return value
- * @index - index into list of display_timings
+ * of_get_videomode: get the videomode #<index> from devicetree
+ * @np: devicenode with the display_timings
+ * @vm: set to return value
+ * @index: index into list of display_timings
  *	    (Set this to OF_USE_NATIVE_MODE to use whatever mode is
  *	     specified as native mode in the DT.)
  *

From patchwork Sat Nov 28 22:40:48 2020
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
X-Patchwork-Submitter: Sam Ravnborg <sam@ravnborg.org>
X-Patchwork-Id: 334553
Return-Path: <linux-fbdev-owner@kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
 aws-us-west-2-korg-lkml-1.web.codeaurora.org
X-Spam-Level: 
X-Spam-Status: No, score=-16.7 required=3.0 tests=BAYES_00,DKIM_SIGNED,
 DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,
 INCLUDES_PATCH, 
 MAILING_LIST_MULTI, SPF_HELO_NONE, SPF_PASS, URIBL_BLOCKED,
 USER_AGENT_GIT
 autolearn=unavailable autolearn_force=no version=3.4.0
Received: from mail.kernel.org (mail.kernel.org [198.145.29.99])
 by smtp.lore.kernel.org (Postfix) with ESMTP id 2B096C63798
 for <linux-fbdev@archiver.kernel.org>;
 Sat, 28 Nov 2020 22:42:19 +0000 (UTC)
Received: from vger.kernel.org (vger.kernel.org [23.128.96.18])
 by mail.kernel.org (Postfix) with ESMTP id E8B58221FD
 for <linux-fbdev@archiver.kernel.org>;
 Sat, 28 Nov 2020 22:42:18 +0000 (UTC)
Authentication-Results: mail.kernel.org;
 dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com
 header.b="lpRWLtnU"
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
 id S1732690AbgK1WmJ (ORCPT <rfc822; linux-fbdev@archiver.kernel.org>);
 Sat, 28 Nov 2020 17:42:09 -0500
Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49194 "EHLO
 lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by
 vger.kernel.org with ESMTP id S1729856AbgK1WmI (ORCPT
 <rfc822;linux-fbdev@vger.kernel.org>);
 Sat, 28 Nov 2020 17:42:08 -0500
Received: from mail-lj1-x244.google.com (mail-lj1-x244.google.com
 [IPv6:2a00:1450:4864:20::244])
 by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6CAF5C0613D3
 for <linux-fbdev@vger.kernel.org>;
 Sat, 28 Nov 2020 14:41:28 -0800 (PST)
Received: by mail-lj1-x244.google.com with SMTP id 142so10557551ljj.10
 for <linux-fbdev@vger.kernel.org>;
 Sat, 28 Nov 2020 14:41:28 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;
 h=sender:from:to:cc:subject:date:message-id:in-reply-to:references
 :mime-version:content-transfer-encoding;
 bh=zz+KNh/9JyMd3kn8YmCOwv7AijkhcR05hHUDJe6/qKc=;
 b=lpRWLtnUZVJogSjTFPoLRElm3AFWwS8Z1SXL/LOx65VzchjutIU1KBAJynonSnuboN
 u1/s24DjJCkNITKEr+uaKsF62sRBiotsOhskJShgB6NXB+aixblONp2CQI6jcXJniY2L
 vII4wT8soxgCpyDAWnhL0yc1yWPa/w+VaH84kNXJJLg+OZE2c7JnVeia9fb/fgxwvS+D
 RjX85tPOCEQtqUFws97IRBx5V2gqbkIWOsMQ+7QLgCu5Qxge/TfcNSTCo5aipa3n2U3S
 LnvjUTgQ0XJISHDe6OrmqU6lJpnTsiaP8e5IL14ra71dor8RoukacGJ+QVmd/ZDv1UPy
 GiaA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20161025;
 h=x-gm-message-state:sender:from:to:cc:subject:date:message-id
 :in-reply-to:references:mime-version:content-transfer-encoding;
 bh=zz+KNh/9JyMd3kn8YmCOwv7AijkhcR05hHUDJe6/qKc=;
 b=b0EnPGlWAc4AEhvQZH775LsD5mUlUIOreO9YioEglcXswZHtn7+i7eRiTKh31qZSpt
 jkFiJzPn7EAmWzpxFjzWCrD9mOeoqMfRtJ2XunyC62niMU75n6hi3E04ZT5pLwlazmnd
 p7wgP9P96w8RTiWfj89uXQaiN7QzB65tgeApQlgLB8zAAXi5YmBPrLGnDpms2O0E9eWd
 OsZuHmH9zUdFLUVI79n7T7gCAUtQCgdNcLh+Fi/+dep6pnTEZ9vywAUlmjTHS3gWiSdh
 gttsDLGL62xCSrvvpKnZAwC3jAelOgKEJealAA3Zq/iPPS1I8oztfedk4klP+4UMA4S9
 76lA==
X-Gm-Message-State: AOAM532JN75revV/5hqd7g1MTg4Ro78NKsH2zYyGe4OEzgq5PGargz/2
 Yrks3+fsAiSz/kvoDpgpAiEAWleHFDzWow==
X-Google-Smtp-Source: ABdhPJz8UR5SyutdhYJr8/GasxQH3JX/eBxv59llfsuusbiLxoWjCHxswDvuGDD4yr+pCne/+Kytkg==
X-Received: by 2002:a2e:9915:: with SMTP id v21mr6287385lji.460.1606603286769; 
 Sat, 28 Nov 2020 14:41:26 -0800 (PST)
Received: from saturn.localdomain ([2a00:fd00:8060:1c00:a4c7:9ff9:a160:aad0])
 by smtp.gmail.com with ESMTPSA id
 w21sm1236857lff.280.2020.11.28.14.41.25
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Sat, 28 Nov 2020 14:41:26 -0800 (PST)
Sender: Sam Ravnborg <sam.ravnborg@gmail.com>
From: Sam Ravnborg <sam@ravnborg.org>
To: linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org,
 Lee Jones <lee.jones@linaro.org>
Cc: Aditya Pakki <pakki001@umn.edu>,
 Alexander Klimov <grandmaster@al2klimov.de>,
 Alex Dewar <alex.dewar90@gmail.com>, Antonino Daplas <adaplas@gmail.com>,
 Arnd Bergmann <arnd@arndb.de>,
 Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
 Benjamin Herrenschmidt <benh@kernel.crashing.org>,
 Daniel Vetter <daniel.vetter@ffwll.ch>, Evgeny Novikov <novikov@ispras.ru>,
 Florian Tobias Schandinat <FlorianSchandinat@gmx.de>,
 George Kennedy <george.kennedy@oracle.com>,
 Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
 Gustavo Silva <gustavoars@kernel.org>,
 Jani Nikula <jani.nikula@intel.com>, Jason Yan <yanaijie@huawei.com>,
 Jingoo Han <jingoohan1@gmail.com>, Jiri Slaby <jirislaby@kernel.org>,
 Joe Perches <joe@perches.com>,
 Kristoffer Ericson <kristoffer.ericson@gmail.com>,
 Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
 Mike Rapoport <rppt@kernel.org>,
 Nathan Chancellor <natechancellor@gmail.com>,
 Peilin Ye <yepeilin.cs@gmail.com>, Peter Rosin <peda@axentia.se>,
 Qilong Zhang <zhangqilong3@huawei.com>,
 Randy Dunlap <rdunlap@infradead.org>,
 Saeed Mirzamohammadi <saeed.mirzamohammadi@oracle.com>,
 Sam Ravnborg <sam@ravnborg.org>,
 Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>,
 Thomas Winischhofer <thomas@winischhofer.net>,
 Thomas Zimemrmann <tzimmermann@suse.de>,
 Vaibhav Gupta <vaibhavgupta40@gmail.com>,
 Xiaofei Tan <tanxiaofei@huawei.com>
Subject: [PATCH v2 02/28] video: fbcon: Fix warnings by using pr_debug() in
 fbcon
Date: Sat, 28 Nov 2020 23:40:48 +0100
Message-Id: <20201128224114.1033617-3-sam@ravnborg.org>
X-Mailer: git-send-email 2.27.0
In-Reply-To: <20201128224114.1033617-1-sam@ravnborg.org>
References: <20201128224114.1033617-1-sam@ravnborg.org>
MIME-Version: 1.0
Precedence: bulk
List-ID: <linux-fbdev.vger.kernel.org>
X-Mailing-List: linux-fbdev@vger.kernel.org

Replacing DPRINTK() statements with pr_debug fixes set but not used
warnings.  And moves to a more standard logging setup at the same time.

v2:
  - Fix indent (Joe)

Signed-off-by: Sam Ravnborg <sam@ravnborg.org>
Cc: Joe Perches <joe@perches.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
Cc: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
Cc: Sam Ravnborg <sam@ravnborg.org>
Cc: Jiri Slaby <jirislaby@kernel.org>
Cc: Peilin Ye <yepeilin.cs@gmail.com>
Cc: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>
Cc: George Kennedy <george.kennedy@oracle.com>
Cc: Nathan Chancellor <natechancellor@gmail.com>
Cc: Peter Rosin <peda@axentia.se>
Acked-by: Thomas Zimmermann <tzimmermann@suse.de>
---
 drivers/video/fbdev/core/fbcon.c | 25 ++++++++-----------------
 1 file changed, 8 insertions(+), 17 deletions(-)

diff --git a/drivers/video/fbdev/core/fbcon.c b/drivers/video/fbdev/core/fbcon.c
index bf61598bf1c3..44a5cd2f54cc 100644
--- a/drivers/video/fbdev/core/fbcon.c
+++ b/drivers/video/fbdev/core/fbcon.c
@@ -56,8 +56,6 @@
  *  more details.
  */
 
-#undef FBCONDEBUG
-
 #include <linux/module.h>
 #include <linux/types.h>
 #include <linux/fs.h>
@@ -82,12 +80,6 @@
 
 #include "fbcon.h"
 
-#ifdef FBCONDEBUG
-#  define DPRINTK(fmt, args...) printk(KERN_DEBUG "%s: " fmt, __func__ , ## args)
-#else
-#  define DPRINTK(fmt, args...)
-#endif
-
 /*
  * FIXME: Locking
  *
@@ -1015,11 +1007,11 @@ static const char *fbcon_startup(void)
 	rows /= vc->vc_font.height;
 	vc_resize(vc, cols, rows);
 
-	DPRINTK("mode:   %s\n", info->fix.id);
-	DPRINTK("visual: %d\n", info->fix.visual);
-	DPRINTK("res:    %dx%d-%d\n", info->var.xres,
-		info->var.yres,
-		info->var.bits_per_pixel);
+	pr_debug("mode:   %s\n", info->fix.id);
+	pr_debug("visual: %d\n", info->fix.visual);
+	pr_debug("res:    %dx%d-%d\n", info->var.xres,
+		 info->var.yres,
+		 info->var.bits_per_pixel);
 
 	fbcon_add_cursor_timer(info);
 	return display_desc;
@@ -2013,7 +2005,7 @@ static int fbcon_resize(struct vc_data *vc, unsigned int width,
 	    y_diff < 0 || y_diff > virt_fh) {
 		const struct fb_videomode *mode;
 
-		DPRINTK("attempting resize %ix%i\n", var.xres, var.yres);
+		pr_debug("attempting resize %ix%i\n", var.xres, var.yres);
 		mode = fb_find_best_mode(&var, &info->modelist);
 		if (mode == NULL)
 			return -EINVAL;
@@ -2023,7 +2015,7 @@ static int fbcon_resize(struct vc_data *vc, unsigned int width,
 		if (virt_w > var.xres/virt_fw || virt_h > var.yres/virt_fh)
 			return -EINVAL;
 
-		DPRINTK("resize now %ix%i\n", var.xres, var.yres);
+		pr_debug("resize now %ix%i\n", var.xres, var.yres);
 		if (con_is_visible(vc)) {
 			var.activate = FB_ACTIVATE_NOW |
 				FB_ACTIVATE_FORCE;
@@ -3299,8 +3291,7 @@ static void fbcon_exit(void)
 
 		if (info->queue.func)
 			pending = cancel_work_sync(&info->queue);
-		DPRINTK("fbcon: %s pending work\n", (pending ? "canceled" :
-			"no"));
+		pr_debug("fbcon: %s pending work\n", (pending ? "canceled" : "no"));
 
 		for (j = first_fb_vc; j <= last_fb_vc; j++) {
 			if (con2fb_map[j] == i) {

From patchwork Sat Nov 28 22:40:49 2020
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
X-Patchwork-Submitter: Sam Ravnborg <sam@ravnborg.org>
X-Patchwork-Id: 334552
Return-Path: <linux-fbdev-owner@kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
 aws-us-west-2-korg-lkml-1.web.codeaurora.org
X-Spam-Level: 
X-Spam-Status: No, score=-16.7 required=3.0 tests=BAYES_00,DKIM_SIGNED,
 DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,
 INCLUDES_PATCH, 
 MAILING_LIST_MULTI, SPF_HELO_NONE, SPF_PASS, URIBL_BLOCKED,
 USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0
Received: from mail.kernel.org (mail.kernel.org [198.145.29.99])
 by smtp.lore.kernel.org (Postfix) with ESMTP id BD032C64E7D
 for <linux-fbdev@archiver.kernel.org>;
 Sat, 28 Nov 2020 22:42:19 +0000 (UTC)
Received: from vger.kernel.org (vger.kernel.org [23.128.96.18])
 by mail.kernel.org (Postfix) with ESMTP id 7B07F20702
 for <linux-fbdev@archiver.kernel.org>;
 Sat, 28 Nov 2020 22:42:19 +0000 (UTC)
Authentication-Results: mail.kernel.org;
 dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com
 header.b="cFk6UHh1"
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
 id S2387754AbgK1WmR (ORCPT <rfc822; linux-fbdev@archiver.kernel.org>);
 Sat, 28 Nov 2020 17:42:17 -0500
Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49200 "EHLO
 lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by
 vger.kernel.org with ESMTP id S2387681AbgK1WmQ (ORCPT
 <rfc822;linux-fbdev@vger.kernel.org>);
 Sat, 28 Nov 2020 17:42:16 -0500
Received: from mail-lj1-x243.google.com (mail-lj1-x243.google.com
 [IPv6:2a00:1450:4864:20::243])
 by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 62095C0613D4
 for <linux-fbdev@vger.kernel.org>;
 Sat, 28 Nov 2020 14:41:30 -0800 (PST)
Received: by mail-lj1-x243.google.com with SMTP id f18so10578627ljg.9
 for <linux-fbdev@vger.kernel.org>;
 Sat, 28 Nov 2020 14:41:30 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;
 h=sender:from:to:cc:subject:date:message-id:in-reply-to:references
 :mime-version:content-transfer-encoding;
 bh=LdDgNuGgErPdHu+TCAPas4kKOuFU9UdpBETdmvhEYm8=;
 b=cFk6UHh1GPx3ccPWrUSUTZuavAngx+GlFcO+u6qQ9SB9tnO1bmHZ7C3rX0xsm3mdPN
 CkYFdR4SCPcCFdQTFTqiuu7IHelMz//Ys4aoH5Jl08cTsrz24RaA+k/KIZOqq/Ve8L4L
 CX0VXRluAh22kjNDNjEEgukilQsoHa0wsmVMjPxFFdeMIJujLzBi/2AueavSTFZHf1qZ
 ezK2jT8IGOfaJ4ldPKBFxkV8scEqNN1jKwGoYvgpgMRAfcMsi1Tj2M7JVuIpxfPwKA/e
 /TwTI5P61P47P9uTBWyL3VVBm13QK/sfQePvUUE0z1v49r4H6WXdPCzHMWn5o8mJPgdK
 cdFA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20161025;
 h=x-gm-message-state:sender:from:to:cc:subject:date:message-id
 :in-reply-to:references:mime-version:content-transfer-encoding;
 bh=LdDgNuGgErPdHu+TCAPas4kKOuFU9UdpBETdmvhEYm8=;
 b=emYh9edmafOFDV3Uo78HcJ4BS6CPY8NPbfbftRjib+bZlk4Mp5S5Ix1MJt+qQrP7cQ
 Gnmiu2w7cqm9hGLRRiXJIiWT6cigl9hn1hE3ucVB6qle6E6Gq4KULmWmAQMaYHgipzAo
 eKXyqs6tILqhaiWRsTVIzOr0Q2dBQFd5zX7yAvLAsUYITgIcONt/0reGGL/bRGSF1hK/
 o/D3JPWO8UjjxYsmkMayJYsV3zdDlNaBGaL4Wp6MK8+Z5kIT+dEDgYeGUEgvRtqfk8vv
 qzHz1OeI3VPFzjB1RGvDlzSrrMmbc9EYpBDyoWMuJlTNdceaiUyFum8CLA3T7qk0FYC6
 QiVQ==
X-Gm-Message-State: AOAM5328ob0Qz8QXNynVv9CMSu9WaT5qHNeFtKdGyMIcXru/u0oI7Cta
 8b2UEyCKElLK/9Bj4vVNCUMm3h05t1fuDg==
X-Google-Smtp-Source: ABdhPJwKqTgycGtvqKEd9497HZCekzPHQbsM9lUTpAxPO6FfM5xjyn3DOkE8grANkPTZdwdkHUHNIQ==
X-Received: by 2002:a2e:b4af:: with SMTP id q15mr3800772ljm.273.1606603288637; 
 Sat, 28 Nov 2020 14:41:28 -0800 (PST)
Received: from saturn.localdomain ([2a00:fd00:8060:1c00:a4c7:9ff9:a160:aad0])
 by smtp.gmail.com with ESMTPSA id
 w21sm1236857lff.280.2020.11.28.14.41.26
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Sat, 28 Nov 2020 14:41:28 -0800 (PST)
Sender: Sam Ravnborg <sam.ravnborg@gmail.com>
From: Sam Ravnborg <sam@ravnborg.org>
To: linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org,
 Lee Jones <lee.jones@linaro.org>
Cc: Aditya Pakki <pakki001@umn.edu>,
 Alexander Klimov <grandmaster@al2klimov.de>,
 Alex Dewar <alex.dewar90@gmail.com>, Antonino Daplas <adaplas@gmail.com>,
 Arnd Bergmann <arnd@arndb.de>,
 Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
 Benjamin Herrenschmidt <benh@kernel.crashing.org>,
 Daniel Vetter <daniel.vetter@ffwll.ch>, Evgeny Novikov <novikov@ispras.ru>,
 Florian Tobias Schandinat <FlorianSchandinat@gmx.de>,
 George Kennedy <george.kennedy@oracle.com>,
 Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
 Gustavo Silva <gustavoars@kernel.org>,
 Jani Nikula <jani.nikula@intel.com>, Jason Yan <yanaijie@huawei.com>,
 Jingoo Han <jingoohan1@gmail.com>, Jiri Slaby <jirislaby@kernel.org>,
 Joe Perches <joe@perches.com>,
 Kristoffer Ericson <kristoffer.ericson@gmail.com>,
 Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
 Mike Rapoport <rppt@kernel.org>,
 Nathan Chancellor <natechancellor@gmail.com>,
 Peilin Ye <yepeilin.cs@gmail.com>, Peter Rosin <peda@axentia.se>,
 Qilong Zhang <zhangqilong3@huawei.com>,
 Randy Dunlap <rdunlap@infradead.org>,
 Saeed Mirzamohammadi <saeed.mirzamohammadi@oracle.com>,
 Sam Ravnborg <sam@ravnborg.org>,
 Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>,
 Thomas Winischhofer <thomas@winischhofer.net>,
 Thomas Zimemrmann <tzimmermann@suse.de>,
 Vaibhav Gupta <vaibhavgupta40@gmail.com>,
 Xiaofei Tan <tanxiaofei@huawei.com>
Subject: [PATCH v2 03/28] video: fbdev: core: Fix kernel-doc warnings in
 fbmon + fb_notify
Date: Sat, 28 Nov 2020 23:40:49 +0100
Message-Id: <20201128224114.1033617-4-sam@ravnborg.org>
X-Mailer: git-send-email 2.27.0
In-Reply-To: <20201128224114.1033617-1-sam@ravnborg.org>
References: <20201128224114.1033617-1-sam@ravnborg.org>
MIME-Version: 1.0
Precedence: bulk
List-ID: <linux-fbdev.vger.kernel.org>
X-Mailing-List: linux-fbdev@vger.kernel.org

Fix kernel-doc warnings reported when using W=1

v2:
  - Improve subject (Lee)

Signed-off-by: Sam Ravnborg <sam@ravnborg.org>
Cc: Lee Jones <lee.jones@linaro.org>
Cc: Sam Ravnborg <sam@ravnborg.org>
Cc: Randy Dunlap <rdunlap@infradead.org>
Cc: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
Cc: "Alexander A. Klimov" <grandmaster@al2klimov.de>
---
 drivers/video/fbdev/core/fb_notify.c | 3 ++-
 drivers/video/fbdev/core/fbmon.c     | 2 +-
 2 files changed, 3 insertions(+), 2 deletions(-)

diff --git a/drivers/video/fbdev/core/fb_notify.c b/drivers/video/fbdev/core/fb_notify.c
index 74c2da528884..d85717b6e14a 100644
--- a/drivers/video/fbdev/core/fb_notify.c
+++ b/drivers/video/fbdev/core/fb_notify.c
@@ -38,7 +38,8 @@ EXPORT_SYMBOL(fb_unregister_client);
 
 /**
  * fb_notifier_call_chain - notify clients of fb_events
- *
+ * @val: value passed to callback
+ * @v: pointer passed to callback
  */
 int fb_notifier_call_chain(unsigned long val, void *v)
 {
diff --git a/drivers/video/fbdev/core/fbmon.c b/drivers/video/fbdev/core/fbmon.c
index 1bf82dbc9e3c..b0e690f41025 100644
--- a/drivers/video/fbdev/core/fbmon.c
+++ b/drivers/video/fbdev/core/fbmon.c
@@ -605,6 +605,7 @@ static void get_detailed_timing(unsigned char *block,
  * fb_create_modedb - create video mode database
  * @edid: EDID data
  * @dbsize: database size
+ * @specs: monitor specifications, may be NULL
  *
  * RETURNS: struct fb_videomode, @dbsize contains length of database
  *
@@ -1100,7 +1101,6 @@ static u32 fb_get_hblank_by_hfreq(u32 hfreq, u32 xres)
  *                                    2 * M
  *        M = 300;
  *        C = 30;
-
  */
 static u32 fb_get_hblank_by_dclk(u32 dclk, u32 xres)
 {

From patchwork Sat Nov 28 22:40:50 2020
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
X-Patchwork-Submitter: Sam Ravnborg <sam@ravnborg.org>
X-Patchwork-Id: 334266
Return-Path: <linux-fbdev-owner@kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
 aws-us-west-2-korg-lkml-1.web.codeaurora.org
X-Spam-Level: 
X-Spam-Status: No, score=-16.7 required=3.0 tests=BAYES_00,DKIM_SIGNED,
 DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,
 INCLUDES_PATCH, 
 MAILING_LIST_MULTI, SPF_HELO_NONE, SPF_PASS, URIBL_BLOCKED,
 USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0
Received: from mail.kernel.org (mail.kernel.org [198.145.29.99])
 by smtp.lore.kernel.org (Postfix) with ESMTP id 5C8B4C64E7B
 for <linux-fbdev@archiver.kernel.org>;
 Sat, 28 Nov 2020 22:42:19 +0000 (UTC)
Received: from vger.kernel.org (vger.kernel.org [23.128.96.18])
 by mail.kernel.org (Postfix) with ESMTP id 1CC5820702
 for <linux-fbdev@archiver.kernel.org>;
 Sat, 28 Nov 2020 22:42:19 +0000 (UTC)
Authentication-Results: mail.kernel.org;
 dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com
 header.b="S0c68Zk+"
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
 id S2387716AbgK1WmN (ORCPT <rfc822; linux-fbdev@archiver.kernel.org>);
 Sat, 28 Nov 2020 17:42:13 -0500
Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49206 "EHLO
 lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by
 vger.kernel.org with ESMTP id S2387679AbgK1WmM (ORCPT
 <rfc822;linux-fbdev@vger.kernel.org>);
 Sat, 28 Nov 2020 17:42:12 -0500
Received: from mail-lj1-x241.google.com (mail-lj1-x241.google.com
 [IPv6:2a00:1450:4864:20::241])
 by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 17C40C0617A7
 for <linux-fbdev@vger.kernel.org>;
 Sat, 28 Nov 2020 14:41:32 -0800 (PST)
Received: by mail-lj1-x241.google.com with SMTP id f18so10578706ljg.9
 for <linux-fbdev@vger.kernel.org>;
 Sat, 28 Nov 2020 14:41:32 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;
 h=sender:from:to:cc:subject:date:message-id:in-reply-to:references
 :mime-version:content-transfer-encoding;
 bh=kZ9ZgHWmJyOywbHzVVtwWtTG6YhIEQd9QstxbodpcBQ=;
 b=S0c68Zk+pF34kAn1jifJ7j61hFiv24XXgHlCdXnCscJJaMe3DhkHymeJf31QSOWTZt
 w23t3x4hST+caW1FOsEXWM4cxQR9p3lqbEh01FmIhxTzm9IO0NoPvqNRsYy/7Qi9QRw/
 Kpwq1matftd2bCkk8fwc8H8+ZiQ5416y39eY8V1Pp9zZuxf2DW5K7r4Y3/6owZGkNFZf
 ZPUyUwqQZ+kAOZPuAahXFeTK8ifShm5ehxN++I6tZFO2+TUI1UXymRVycWkTtFsBL2B4
 MZEhjNIiM3C4MnnHsJjjIXUu4VAz3pKDuRWlgFvwMqdhkUC0UO7hdRVwB7sCK8YQzG/f
 bN1Q==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20161025;
 h=x-gm-message-state:sender:from:to:cc:subject:date:message-id
 :in-reply-to:references:mime-version:content-transfer-encoding;
 bh=kZ9ZgHWmJyOywbHzVVtwWtTG6YhIEQd9QstxbodpcBQ=;
 b=DfbpuRAlW3OgNf0frfzoxsd/oKgY2IY0i3/DIK5/s+/6GPYrrn44Gsk0oQv0CzWplm
 CuEbSr1aujnqfWmMwQ5ms30avmGGakJUsLmj9BNYhb8QQnEuOtkMKML1J/C1I/vfCW8g
 HCb9peCWODVi3R71D+Im9kWWVm9Sobz1D8IzAsK6Q+XFcB9OCF9+xUlP/A/LQuGkPCvy
 aqvZzbBguIy8h3yRMMDO85wuuaT70wEnLjogipI25K45K43BpzoNxC1Uy/3cZ2IBtH1v
 RRdhzZZAvo85dbz1hEUbOS/p1/wB+lKjM0GNAYhEpLMy8EE2ZFveGfWM7gINbJclWSGt
 AFvg==
X-Gm-Message-State: AOAM532TukQRWI0Ut9xWf95B7uFoVtiKM75ut1u4Se7Qz4mJdIO9ABxp
 tRHAEYGIQmNriiRmeJD22X0JAh3p1R4gig==
X-Google-Smtp-Source: ABdhPJx4ymyjTnrmJSY6wFWclm51YzQlOTykubVxGPg/z9CJJLqHiLChQ9ZhrpimkKUPyuqHo1PtyQ==
X-Received: by 2002:a2e:161b:: with SMTP id w27mr6607806ljd.429.1606603290409; 
 Sat, 28 Nov 2020 14:41:30 -0800 (PST)
Received: from saturn.localdomain ([2a00:fd00:8060:1c00:a4c7:9ff9:a160:aad0])
 by smtp.gmail.com with ESMTPSA id
 w21sm1236857lff.280.2020.11.28.14.41.28
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Sat, 28 Nov 2020 14:41:29 -0800 (PST)
Sender: Sam Ravnborg <sam.ravnborg@gmail.com>
From: Sam Ravnborg <sam@ravnborg.org>
To: linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org,
 Lee Jones <lee.jones@linaro.org>
Cc: Aditya Pakki <pakki001@umn.edu>,
 Alexander Klimov <grandmaster@al2klimov.de>,
 Alex Dewar <alex.dewar90@gmail.com>, Antonino Daplas <adaplas@gmail.com>,
 Arnd Bergmann <arnd@arndb.de>,
 Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
 Benjamin Herrenschmidt <benh@kernel.crashing.org>,
 Daniel Vetter <daniel.vetter@ffwll.ch>, Evgeny Novikov <novikov@ispras.ru>,
 Florian Tobias Schandinat <FlorianSchandinat@gmx.de>,
 George Kennedy <george.kennedy@oracle.com>,
 Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
 Gustavo Silva <gustavoars@kernel.org>,
 Jani Nikula <jani.nikula@intel.com>, Jason Yan <yanaijie@huawei.com>,
 Jingoo Han <jingoohan1@gmail.com>, Jiri Slaby <jirislaby@kernel.org>,
 Joe Perches <joe@perches.com>,
 Kristoffer Ericson <kristoffer.ericson@gmail.com>,
 Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
 Mike Rapoport <rppt@kernel.org>,
 Nathan Chancellor <natechancellor@gmail.com>,
 Peilin Ye <yepeilin.cs@gmail.com>, Peter Rosin <peda@axentia.se>,
 Qilong Zhang <zhangqilong3@huawei.com>,
 Randy Dunlap <rdunlap@infradead.org>,
 Saeed Mirzamohammadi <saeed.mirzamohammadi@oracle.com>,
 Sam Ravnborg <sam@ravnborg.org>,
 Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>,
 Thomas Winischhofer <thomas@winischhofer.net>,
 Thomas Zimemrmann <tzimmermann@suse.de>,
 Vaibhav Gupta <vaibhavgupta40@gmail.com>,
 Xiaofei Tan <tanxiaofei@huawei.com>
Subject: [PATCH v2 04/28] video: fbdev: aty: Delete unused variable in
 radeon_monitor
Date: Sat, 28 Nov 2020 23:40:50 +0100
Message-Id: <20201128224114.1033617-5-sam@ravnborg.org>
X-Mailer: git-send-email 2.27.0
In-Reply-To: <20201128224114.1033617-1-sam@ravnborg.org>
References: <20201128224114.1033617-1-sam@ravnborg.org>
MIME-Version: 1.0
Precedence: bulk
List-ID: <linux-fbdev.vger.kernel.org>
X-Mailing-List: linux-fbdev@vger.kernel.org

Fix warning about variable that is asssigned a value but never used.
The variable was indeed never used so delete it.

Keep the call to radeon_probe_i2c_connector() as it may have
side-effects. It is unlikely but I could not verify that is was safe to
drop the call.

Signed-off-by: Sam Ravnborg <sam@ravnborg.org>
Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Cc: linux-fbdev@vger.kernel.org
---
 drivers/video/fbdev/aty/radeon_monitor.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/video/fbdev/aty/radeon_monitor.c b/drivers/video/fbdev/aty/radeon_monitor.c
index 9966c58aa26c..df55e23b7a5a 100644
--- a/drivers/video/fbdev/aty/radeon_monitor.c
+++ b/drivers/video/fbdev/aty/radeon_monitor.c
@@ -488,12 +488,10 @@ void radeon_probe_screens(struct radeonfb_info *rinfo,
 #if defined(DEBUG) && defined(CONFIG_FB_RADEON_I2C)
 		{
 			u8 *EDIDs[4] = { NULL, NULL, NULL, NULL };
-			int mon_types[4] = {MT_NONE, MT_NONE, MT_NONE, MT_NONE};
 			int i;
 
 			for (i = 0; i < 4; i++)
-				mon_types[i] = radeon_probe_i2c_connector(rinfo,
-									  i+1, &EDIDs[i]);
+				radeon_probe_i2c_connector(rinfo, i + 1, &EDIDs[i]);
 		}
 #endif /* DEBUG */
 		/*

From patchwork Sat Nov 28 22:40:51 2020
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
X-Patchwork-Submitter: Sam Ravnborg <sam@ravnborg.org>
X-Patchwork-Id: 334265
Return-Path: <linux-fbdev-owner@kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
 aws-us-west-2-korg-lkml-1.web.codeaurora.org
X-Spam-Level: 
X-Spam-Status: No, score=-13.9 required=3.0 tests=BAYES_00,DKIM_SIGNED,
 DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,
 INCLUDES_PATCH, 
 MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,UNWANTED_LANGUAGE_BODY,
 URIBL_BLOCKED, USER_AGENT_GIT autolearn=unavailable autolearn_force=no
 version=3.4.0
Received: from mail.kernel.org (mail.kernel.org [198.145.29.99])
 by smtp.lore.kernel.org (Postfix) with ESMTP id 167DDC63777
 for <linux-fbdev@archiver.kernel.org>;
 Sat, 28 Nov 2020 22:43:00 +0000 (UTC)
Received: from vger.kernel.org (vger.kernel.org [23.128.96.18])
 by mail.kernel.org (Postfix) with ESMTP id D20EC20771
 for <linux-fbdev@archiver.kernel.org>;
 Sat, 28 Nov 2020 22:42:59 +0000 (UTC)
Authentication-Results: mail.kernel.org;
 dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com
 header.b="Rv/zkpFM"
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
 id S1728350AbgK1Wmo (ORCPT <rfc822; linux-fbdev@archiver.kernel.org>);
 Sat, 28 Nov 2020 17:42:44 -0500
Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49284 "EHLO
 lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by
 vger.kernel.org with ESMTP id S1726014AbgK1Wmn (ORCPT
 <rfc822;linux-fbdev@vger.kernel.org>);
 Sat, 28 Nov 2020 17:42:43 -0500
Received: from mail-lf1-x143.google.com (mail-lf1-x143.google.com
 [IPv6:2a00:1450:4864:20::143])
 by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 100C2C061A04
 for <linux-fbdev@vger.kernel.org>;
 Sat, 28 Nov 2020 14:41:34 -0800 (PST)
Received: by mail-lf1-x143.google.com with SMTP id s27so12748871lfp.5
 for <linux-fbdev@vger.kernel.org>;
 Sat, 28 Nov 2020 14:41:33 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;
 h=sender:from:to:cc:subject:date:message-id:in-reply-to:references
 :mime-version:content-transfer-encoding;
 bh=pEqxbCWX9q9yDbDvSbn0kwCSjD77LNJ8Br1S/hGjS4Y=;
 b=Rv/zkpFM80luzwk9qz8tKKHWMQ6AMMsclRVZq8PzkJM18cISEnSccV7Z8NIypZ1jW/
 UpJkema7xmGdArdEUTxR3gSPeu/62Fr6qy4keamZ0qJNqIQD4YRj1StMsnasqAFSSZ2i
 nF68Z1WHShiUim0pi8VvWJKFAcfN8Jfhke8fy9mYSrj/rvKau8xzj8LEJo+jBhVJUZeD
 Clfkv1bN3MyIy9fOm7S9V8Pc+2ayjfrjqSUkchx1EursTN5wqxO9Bb4YCYAyII3W9mYP
 nwn5OYVYnhEOLz4R7WWkyxFs8r+3ZzFCNbcB4d4Y9Fjkmr9TXb3rUL4DXvKhIu65S/qb
 vfjQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20161025;
 h=x-gm-message-state:sender:from:to:cc:subject:date:message-id
 :in-reply-to:references:mime-version:content-transfer-encoding;
 bh=pEqxbCWX9q9yDbDvSbn0kwCSjD77LNJ8Br1S/hGjS4Y=;
 b=iM/ZYCoEeC/qxPjZahIXQIKPKUh5RgdFSBb9SS1vzYhg564INaWfhjWryAEgqAlbnO
 vNdFpd9VqISUe1rkkSmEQRD7/oSdKqZmSEd6gky03S8gyb2QDUp7rcyYfQq7w6b2Ji1w
 9d1kC40LjHEQtn3m6fn6xK2yYbbXlPQRw72KiYVI4DP3IrUZj6HWIzS0cXyAPt6qSc19
 6717KQANaDQUqumaFZj8ItZSVV53ATqmkDEIc+wzgQnGOxd1oYnGiE3/pjqq0vRYqsDv
 AkyU++Jy6CdWbfPEEPkv4JnxC4H7q6+4FMYMLAy0NWsaBgHs96UOtJ7rar66IrXy006O
 JrKQ==
X-Gm-Message-State: AOAM531Ct5qw0NxFrlQJHUmWikr1znzNtG+xpbh8FLfu1Yib/yWYb6OH
 bVskH82wbHPKr8GWVIsOQT2JnwWEQwYlcQ==
X-Google-Smtp-Source: ABdhPJxCfP77M8/2JZ9sjq/1cfSJg2rs/6jPaUmktbALDcsy2SGRemB6E1qPPqvUpiL7ISv6YIEbXA==
X-Received: by 2002:a19:3817:: with SMTP id f23mr6381269lfa.587.1606603292296; 
 Sat, 28 Nov 2020 14:41:32 -0800 (PST)
Received: from saturn.localdomain ([2a00:fd00:8060:1c00:a4c7:9ff9:a160:aad0])
 by smtp.gmail.com with ESMTPSA id
 w21sm1236857lff.280.2020.11.28.14.41.30
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Sat, 28 Nov 2020 14:41:31 -0800 (PST)
Sender: Sam Ravnborg <sam.ravnborg@gmail.com>
From: Sam Ravnborg <sam@ravnborg.org>
To: linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org,
 Lee Jones <lee.jones@linaro.org>
Cc: Aditya Pakki <pakki001@umn.edu>,
 Alexander Klimov <grandmaster@al2klimov.de>,
 Alex Dewar <alex.dewar90@gmail.com>, Antonino Daplas <adaplas@gmail.com>,
 Arnd Bergmann <arnd@arndb.de>,
 Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
 Benjamin Herrenschmidt <benh@kernel.crashing.org>,
 Daniel Vetter <daniel.vetter@ffwll.ch>, Evgeny Novikov <novikov@ispras.ru>,
 Florian Tobias Schandinat <FlorianSchandinat@gmx.de>,
 George Kennedy <george.kennedy@oracle.com>,
 Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
 Gustavo Silva <gustavoars@kernel.org>,
 Jani Nikula <jani.nikula@intel.com>, Jason Yan <yanaijie@huawei.com>,
 Jingoo Han <jingoohan1@gmail.com>, Jiri Slaby <jirislaby@kernel.org>,
 Joe Perches <joe@perches.com>,
 Kristoffer Ericson <kristoffer.ericson@gmail.com>,
 Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
 Mike Rapoport <rppt@kernel.org>,
 Nathan Chancellor <natechancellor@gmail.com>,
 Peilin Ye <yepeilin.cs@gmail.com>, Peter Rosin <peda@axentia.se>,
 Qilong Zhang <zhangqilong3@huawei.com>,
 Randy Dunlap <rdunlap@infradead.org>,
 Saeed Mirzamohammadi <saeed.mirzamohammadi@oracle.com>,
 Sam Ravnborg <sam@ravnborg.org>,
 Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>,
 Thomas Winischhofer <thomas@winischhofer.net>,
 Thomas Zimemrmann <tzimmermann@suse.de>,
 Vaibhav Gupta <vaibhavgupta40@gmail.com>,
 Xiaofei Tan <tanxiaofei@huawei.com>, kernel test robot <lkp@intel.com>
Subject: [PATCH v2 05/28] video: fbdev: aty: Fix set but not used warnings
Date: Sat, 28 Nov 2020 23:40:51 +0100
Message-Id: <20201128224114.1033617-6-sam@ravnborg.org>
X-Mailer: git-send-email 2.27.0
In-Reply-To: <20201128224114.1033617-1-sam@ravnborg.org>
References: <20201128224114.1033617-1-sam@ravnborg.org>
MIME-Version: 1.0
Precedence: bulk
List-ID: <linux-fbdev.vger.kernel.org>
X-Mailing-List: linux-fbdev@vger.kernel.org

Fix W=1 warnings about variables assigned but never used.

- Drop variables that was set but never used
- Make variable definition conditional om ATARI

v2:
  - Fix m68k build error (kernel test robot)
  - Improve subject (Lee Jones)

Signed-off-by: Sam Ravnborg <sam@ravnborg.org>
Reported-by: kernel test robot <lkp@intel.com> # m68k build fix
Cc: Lee Jones <lee.jones@linaro.org>
Cc: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
Cc: Sam Ravnborg <sam@ravnborg.org>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
Cc: Joe Perches <joe@perches.com>
Cc: Vaibhav Gupta <vaibhavgupta40@gmail.com>
Cc: Jason Yan <yanaijie@huawei.com>
Cc: Randy Dunlap <rdunlap@infradead.org>
Cc: Jani Nikula <jani.nikula@intel.com>
---
 drivers/video/fbdev/aty/atyfb_base.c | 11 ++++-------
 1 file changed, 4 insertions(+), 7 deletions(-)

diff --git a/drivers/video/fbdev/aty/atyfb_base.c b/drivers/video/fbdev/aty/atyfb_base.c
index c8feff0ee8da..83c8e809955a 100644
--- a/drivers/video/fbdev/aty/atyfb_base.c
+++ b/drivers/video/fbdev/aty/atyfb_base.c
@@ -2353,6 +2353,9 @@ static int aty_init(struct fb_info *info)
 	int gtb_memsize, has_var = 0;
 	struct fb_var_screeninfo var;
 	int ret;
+#ifdef CONFIG_ATARI
+	u8 dac_type;
+#endif
 
 	init_waitqueue_head(&par->vblank.wait);
 	spin_lock_init(&par->int_lock);
@@ -2360,13 +2363,12 @@ static int aty_init(struct fb_info *info)
 #ifdef CONFIG_FB_ATY_GX
 	if (!M64_HAS(INTEGRATED)) {
 		u32 stat0;
-		u8 dac_type, dac_subtype, clk_type;
+		u8 dac_subtype, clk_type;
 		stat0 = aty_ld_le32(CNFG_STAT0, par);
 		par->bus_type = (stat0 >> 0) & 0x07;
 		par->ram_type = (stat0 >> 3) & 0x07;
 		ramname = aty_gx_ram[par->ram_type];
 		/* FIXME: clockchip/RAMDAC probing? */
-		dac_type = (aty_ld_le32(DAC_CNTL, par) >> 16) & 0x07;
 #ifdef CONFIG_ATARI
 		clk_type = CLK_ATI18818_1;
 		dac_type = (stat0 >> 9) & 0x07;
@@ -2375,7 +2377,6 @@ static int aty_init(struct fb_info *info)
 		else
 			dac_subtype = (aty_ld_8(SCRATCH_REG1 + 1, par) & 0xF0) | dac_type;
 #else
-		dac_type = DAC_IBMRGB514;
 		dac_subtype = DAC_IBMRGB514;
 		clk_type = CLK_IBMRGB514;
 #endif
@@ -3062,7 +3063,6 @@ static int atyfb_setup_sparc(struct pci_dev *pdev, struct fb_info *info,
 	if (dp == of_console_device) {
 		struct fb_var_screeninfo *var = &default_var;
 		unsigned int N, P, Q, M, T, R;
-		u32 v_total, h_total;
 		struct crtc crtc;
 		u8 pll_regs[16];
 		u8 clock_cntl;
@@ -3078,9 +3078,6 @@ static int atyfb_setup_sparc(struct pci_dev *pdev, struct fb_info *info,
 		crtc.gen_cntl = aty_ld_le32(CRTC_GEN_CNTL, par);
 		aty_crtc_to_var(&crtc, var);
 
-		h_total = var->xres + var->right_margin + var->hsync_len + var->left_margin;
-		v_total = var->yres + var->lower_margin + var->vsync_len + var->upper_margin;
-
 		/*
 		 * Read the PLL to figure actual Refresh Rate.
 		 */

From patchwork Sat Nov 28 22:40:52 2020
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
X-Patchwork-Submitter: Sam Ravnborg <sam@ravnborg.org>
X-Patchwork-Id: 334551
Return-Path: <linux-fbdev-owner@kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
 aws-us-west-2-korg-lkml-1.web.codeaurora.org
X-Spam-Level: 
X-Spam-Status: No, score=-16.7 required=3.0 tests=BAYES_00,DKIM_SIGNED,
 DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,
 INCLUDES_PATCH, 
 MAILING_LIST_MULTI, SPF_HELO_NONE, SPF_PASS, URIBL_BLOCKED,
 USER_AGENT_GIT
 autolearn=unavailable autolearn_force=no version=3.4.0
Received: from mail.kernel.org (mail.kernel.org [198.145.29.99])
 by smtp.lore.kernel.org (Postfix) with ESMTP id E2FDAC63798
 for <linux-fbdev@archiver.kernel.org>;
 Sat, 28 Nov 2020 22:42:59 +0000 (UTC)
Received: from vger.kernel.org (vger.kernel.org [23.128.96.18])
 by mail.kernel.org (Postfix) with ESMTP id AE66820702
 for <linux-fbdev@archiver.kernel.org>;
 Sat, 28 Nov 2020 22:42:59 +0000 (UTC)
Authentication-Results: mail.kernel.org;
 dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com
 header.b="nBaZDIVA"
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
 id S1729856AbgK1Wmo (ORCPT <rfc822; linux-fbdev@archiver.kernel.org>);
 Sat, 28 Nov 2020 17:42:44 -0500
Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49286 "EHLO
 lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by
 vger.kernel.org with ESMTP id S1728350AbgK1Wmn (ORCPT
 <rfc822;linux-fbdev@vger.kernel.org>);
 Sat, 28 Nov 2020 17:42:43 -0500
Received: from mail-lf1-x144.google.com (mail-lf1-x144.google.com
 [IPv6:2a00:1450:4864:20::144])
 by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C570AC061A47
 for <linux-fbdev@vger.kernel.org>;
 Sat, 28 Nov 2020 14:41:35 -0800 (PST)
Received: by mail-lf1-x144.google.com with SMTP id z21so12716456lfe.12
 for <linux-fbdev@vger.kernel.org>;
 Sat, 28 Nov 2020 14:41:35 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;
 h=sender:from:to:cc:subject:date:message-id:in-reply-to:references
 :mime-version:content-transfer-encoding;
 bh=FQt8Zy/RcRTV8RI+7xEG7mp4eH+bacz1GI81AvTRW6U=;
 b=nBaZDIVAfz80bCWu0yx2DfH3RI13Bv/U6WR5FSXtmNgxDUZXMLAKS8UEUBUWMDvuhH
 iSuHokAerrLo55ZyCEFz3mrNq97Efiej0UmE67ApNz9XOJhfmNvYS2iYP83fqoBPLROX
 BbHu6iprRb37DY6gDWPwEWKmzHulr1TV1D0BYXqNKnDt8u3DJFz/TytLcCZaol9EHDKK
 G3FYHO04RHFffxaqvqP24nuo6UMz2pKoXf5cvdLdbFdFRJLTFa92Yq2jg4aCfbX6v+YK
 /Mt7VGyqhY/26NVWBp0nAtKCVQ3YWvgLxqtlRAYSoa//bjwPkRu4sRtQb74AEgtPmqIl
 gJew==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20161025;
 h=x-gm-message-state:sender:from:to:cc:subject:date:message-id
 :in-reply-to:references:mime-version:content-transfer-encoding;
 bh=FQt8Zy/RcRTV8RI+7xEG7mp4eH+bacz1GI81AvTRW6U=;
 b=FO9coWsW9eUZ3X6YDc3QhpD+1iZ/hnlbPTbufHhyXq+2tpA5cqLEEPpk7n9wyiJXoO
 73oZsOPTNTEI1YKAbuqKNbPdJKXh4sVJHsuFGJdAjOw+ZYOPEhpz+IxLmqsA2S+63wNb
 AA0fQEsynMY4Um2FKLZ3wSigNimcRWzvWDmdkzRdHmVJiAyiiCF8bqhUlATwXTi8iHoS
 hQ4dDtyvKsxYphCOYoWNNu7lcQTca8qgYqZriAdSo7NWnmLu767YaVmM2Cpt9B6Ghf0+
 pilaFdTe+9hx8LV6rJDk160DKKh1PJ5F2RqZp+TvYrh2/y7kpBwm11Xx6F6qjvhuMoHW
 I76g==
X-Gm-Message-State: AOAM531GGCCoF6bMX3KH4wbXqGDXSkau2e5/0PgCcGufDN00uEK+a6QC
 9ZFD22pjllmfPEIKrIaNgqTX1HK6oCLv0w==
X-Google-Smtp-Source: ABdhPJzlQNjBNn705RJBUCQ/M55lwEEf/6mv51LCAvjVISvV38KZWfSsU8ScP0w3xaBDZ7N217vjFA==
X-Received: by 2002:ac2:5b88:: with SMTP id o8mr6729659lfn.265.1606603294085; 
 Sat, 28 Nov 2020 14:41:34 -0800 (PST)
Received: from saturn.localdomain ([2a00:fd00:8060:1c00:a4c7:9ff9:a160:aad0])
 by smtp.gmail.com with ESMTPSA id
 w21sm1236857lff.280.2020.11.28.14.41.32
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Sat, 28 Nov 2020 14:41:33 -0800 (PST)
Sender: Sam Ravnborg <sam.ravnborg@gmail.com>
From: Sam Ravnborg <sam@ravnborg.org>
To: linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org,
 Lee Jones <lee.jones@linaro.org>
Cc: Aditya Pakki <pakki001@umn.edu>,
 Alexander Klimov <grandmaster@al2klimov.de>,
 Alex Dewar <alex.dewar90@gmail.com>, Antonino Daplas <adaplas@gmail.com>,
 Arnd Bergmann <arnd@arndb.de>,
 Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
 Benjamin Herrenschmidt <benh@kernel.crashing.org>,
 Daniel Vetter <daniel.vetter@ffwll.ch>, Evgeny Novikov <novikov@ispras.ru>,
 Florian Tobias Schandinat <FlorianSchandinat@gmx.de>,
 George Kennedy <george.kennedy@oracle.com>,
 Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
 Gustavo Silva <gustavoars@kernel.org>,
 Jani Nikula <jani.nikula@intel.com>, Jason Yan <yanaijie@huawei.com>,
 Jingoo Han <jingoohan1@gmail.com>, Jiri Slaby <jirislaby@kernel.org>,
 Joe Perches <joe@perches.com>,
 Kristoffer Ericson <kristoffer.ericson@gmail.com>,
 Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
 Mike Rapoport <rppt@kernel.org>,
 Nathan Chancellor <natechancellor@gmail.com>,
 Peilin Ye <yepeilin.cs@gmail.com>, Peter Rosin <peda@axentia.se>,
 Qilong Zhang <zhangqilong3@huawei.com>,
 Randy Dunlap <rdunlap@infradead.org>,
 Saeed Mirzamohammadi <saeed.mirzamohammadi@oracle.com>,
 Sam Ravnborg <sam@ravnborg.org>,
 Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>,
 Thomas Winischhofer <thomas@winischhofer.net>,
 Thomas Zimemrmann <tzimmermann@suse.de>,
 Vaibhav Gupta <vaibhavgupta40@gmail.com>,
 Xiaofei Tan <tanxiaofei@huawei.com>
Subject: [PATCH v2 06/28] video: fbdev: aty: Fix set but not used warnings
 in mach64_ct
Date: Sat, 28 Nov 2020 23:40:52 +0100
Message-Id: <20201128224114.1033617-7-sam@ravnborg.org>
X-Mailer: git-send-email 2.27.0
In-Reply-To: <20201128224114.1033617-1-sam@ravnborg.org>
References: <20201128224114.1033617-1-sam@ravnborg.org>
MIME-Version: 1.0
Precedence: bulk
List-ID: <linux-fbdev.vger.kernel.org>
X-Mailing-List: linux-fbdev@vger.kernel.org

Fix W=1 warnings about variables assigned but never used.
- One variable is only used when CONFIG_FB_ATY_GENERIC_LCD is defined
  Fix so variable is only defined with CONFIG_FB_ATY_GENERIC_LCD
- Several variables was only assigned by a call to aty_ld_le32().
  Drop the variables but keep the call to aty_ld_le32() as it may
  have unexpected side-effects.

v2:
  - Updated subject (Lee)

Signed-off-by: Sam Ravnborg <sam@ravnborg.org>
Cc: Lee Jones <lee.jones@linaro.org>
Acked-by: Thomas Zimmermann <tzimmermann@suse.de>
---
 drivers/video/fbdev/aty/mach64_ct.c | 15 +++++++++------
 1 file changed, 9 insertions(+), 6 deletions(-)

diff --git a/drivers/video/fbdev/aty/mach64_ct.c b/drivers/video/fbdev/aty/mach64_ct.c
index f87cc81f4fa2..011b07e44e0d 100644
--- a/drivers/video/fbdev/aty/mach64_ct.c
+++ b/drivers/video/fbdev/aty/mach64_ct.c
@@ -281,10 +281,13 @@ static u32 aty_pll_to_var_ct(const struct fb_info *info, const union aty_pll *pl
 void aty_set_pll_ct(const struct fb_info *info, const union aty_pll *pll)
 {
 	struct atyfb_par *par = (struct atyfb_par *) info->par;
-	u32 crtc_gen_cntl, lcd_gen_cntrl;
+	u32 crtc_gen_cntl;
 	u8 tmp, tmp2;
 
-	lcd_gen_cntrl = 0;
+#ifdef CONFIG_FB_ATY_GENERIC_LCD
+	u32 lcd_gen_cntrl = 0;
+#endif
+
 #ifdef DEBUG
 	printk("atyfb(%s): about to program:\n"
 		"pll_ext_cntl=0x%02x pll_gen_cntl=0x%02x pll_vclk_cntl=0x%02x\n",
@@ -402,7 +405,7 @@ static int aty_init_pll_ct(const struct fb_info *info, union aty_pll *pll)
 	struct atyfb_par *par = (struct atyfb_par *) info->par;
 	u8 mpost_div, xpost_div, sclk_post_div_real;
 	u32 q, memcntl, trp;
-	u32 dsp_config, dsp_on_off, vga_dsp_config, vga_dsp_on_off;
+	u32 dsp_config;
 #ifdef DEBUG
 	int pllmclk, pllsclk;
 #endif
@@ -488,9 +491,9 @@ static int aty_init_pll_ct(const struct fb_info *info, union aty_pll *pll)
 
 	/* Allow BIOS to override */
 	dsp_config = aty_ld_le32(DSP_CONFIG, par);
-	dsp_on_off = aty_ld_le32(DSP_ON_OFF, par);
-	vga_dsp_config = aty_ld_le32(VGA_DSP_CONFIG, par);
-	vga_dsp_on_off = aty_ld_le32(VGA_DSP_ON_OFF, par);
+	aty_ld_le32(DSP_ON_OFF, par);
+	aty_ld_le32(VGA_DSP_CONFIG, par);
+	aty_ld_le32(VGA_DSP_ON_OFF, par);
 
 	if (dsp_config)
 		pll->ct.dsp_loop_latency = (dsp_config & DSP_LOOP_LATENCY) >> 16;

From patchwork Sat Nov 28 22:40:53 2020
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
X-Patchwork-Submitter: Sam Ravnborg <sam@ravnborg.org>
X-Patchwork-Id: 334550
Return-Path: <linux-fbdev-owner@kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
 aws-us-west-2-korg-lkml-1.web.codeaurora.org
X-Spam-Level: 
X-Spam-Status: No, score=-16.7 required=3.0 tests=BAYES_00,DKIM_SIGNED,
 DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,
 INCLUDES_PATCH, 
 MAILING_LIST_MULTI, SPF_HELO_NONE, SPF_PASS, URIBL_BLOCKED,
 USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0
Received: from mail.kernel.org (mail.kernel.org [198.145.29.99])
 by smtp.lore.kernel.org (Postfix) with ESMTP id 43C2EC64E7B
 for <linux-fbdev@archiver.kernel.org>;
 Sat, 28 Nov 2020 22:43:00 +0000 (UTC)
Received: from vger.kernel.org (vger.kernel.org [23.128.96.18])
 by mail.kernel.org (Postfix) with ESMTP id 0D72020702
 for <linux-fbdev@archiver.kernel.org>;
 Sat, 28 Nov 2020 22:43:00 +0000 (UTC)
Authentication-Results: mail.kernel.org;
 dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com
 header.b="rr082/bf"
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
 id S1731555AbgK1Wmt (ORCPT <rfc822; linux-fbdev@archiver.kernel.org>);
 Sat, 28 Nov 2020 17:42:49 -0500
Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49304 "EHLO
 lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by
 vger.kernel.org with ESMTP id S1726014AbgK1Wmt (ORCPT
 <rfc822;linux-fbdev@vger.kernel.org>);
 Sat, 28 Nov 2020 17:42:49 -0500
Received: from mail-lj1-x244.google.com (mail-lj1-x244.google.com
 [IPv6:2a00:1450:4864:20::244])
 by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A01BEC061A48
 for <linux-fbdev@vger.kernel.org>;
 Sat, 28 Nov 2020 14:41:37 -0800 (PST)
Received: by mail-lj1-x244.google.com with SMTP id 142so10557904ljj.10
 for <linux-fbdev@vger.kernel.org>;
 Sat, 28 Nov 2020 14:41:37 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;
 h=sender:from:to:cc:subject:date:message-id:in-reply-to:references
 :mime-version:content-transfer-encoding;
 bh=vo4cr0mfLt51Py8FoFo5ySrp+3Uu+WbwThawmdg5uCQ=;
 b=rr082/bfmcgQVh1oGNkvsycPHb7jgLYqu/HTlitaos9mo8dFk+MxNnQcAMKYhTOz1G
 nj1LrdF1YUNQ9IAMe2k6I+uAp+9pySXOyogw/6aYwtvF0oj11SXGTjG+hDZOVwfUW4Vh
 9LbkkP5yNUVSUdx21hrIgKOLXf+4I11SveX5JuUtwoT3jlqF5CiaXb9QZLtnQY8nZoW7
 qS7J1V4thgMvocrZcf/rGKX4zsMr7A3kx9KfFseFz/dT2giLnxQUxWawESs4WL+NuwP/
 6XE0j4Lm9xbpiCeaHhQgEO9SE8T9yzD83V6/YvBVED/MIr9LPm4A7pawwrUFNAhv83yN
 3ang==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20161025;
 h=x-gm-message-state:sender:from:to:cc:subject:date:message-id
 :in-reply-to:references:mime-version:content-transfer-encoding;
 bh=vo4cr0mfLt51Py8FoFo5ySrp+3Uu+WbwThawmdg5uCQ=;
 b=MlwnJVVwRJ1ayf39U/6Ca5eU6olUP2mTnakYtJ3p4IiaMJeGFLHI9Qf+8dG+fDo2Zv
 SDKmhLJqJYhhmA1olFgMwOdbsvegjNEZzyJsmRpicFgaFnG77i7nQTB2LYLUf8VoAVA1
 m4S8Ynlz+fa+A5/7lruErXdnay+EBG2mEB24jVr4XfS5IFjBJuomZBW4h7ypn6epDkaz
 YEnfYaGhLgKqPDBmGtYAnWY3HYRsUPQckCUFJny7OdcTecdwh/W4iMyzftk5IALJqKFg
 BaiDY6bSE+e58nvD9Nv7eCz9FFmcL1/c7oMVe80nhtE3q/DVmbiKdE7Y9KS75j2yjbPu
 tfbQ==
X-Gm-Message-State: AOAM530l+l+bBJ91IbBnzhKpjgr63hCuTvA24o2LYdLtYOEUh3T49hgS
 EIYNT6WyKCTJeMvpo3V/ImGI9Wzk9mHkTg==
X-Google-Smtp-Source: ABdhPJztBDdAKHiSNBdw1ZXYn1VBf8Peg+KZ0RY/iaTzhAAH+LYmPfiKXZsj0Hc9jhgaMObrsDNovA==
X-Received: by 2002:a2e:580d:: with SMTP id m13mr6673046ljb.141.1606603295928; 
 Sat, 28 Nov 2020 14:41:35 -0800 (PST)
Received: from saturn.localdomain ([2a00:fd00:8060:1c00:a4c7:9ff9:a160:aad0])
 by smtp.gmail.com with ESMTPSA id
 w21sm1236857lff.280.2020.11.28.14.41.34
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Sat, 28 Nov 2020 14:41:35 -0800 (PST)
Sender: Sam Ravnborg <sam.ravnborg@gmail.com>
From: Sam Ravnborg <sam@ravnborg.org>
To: linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org,
 Lee Jones <lee.jones@linaro.org>
Cc: Aditya Pakki <pakki001@umn.edu>,
 Alexander Klimov <grandmaster@al2klimov.de>,
 Alex Dewar <alex.dewar90@gmail.com>, Antonino Daplas <adaplas@gmail.com>,
 Arnd Bergmann <arnd@arndb.de>,
 Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
 Benjamin Herrenschmidt <benh@kernel.crashing.org>,
 Daniel Vetter <daniel.vetter@ffwll.ch>, Evgeny Novikov <novikov@ispras.ru>,
 Florian Tobias Schandinat <FlorianSchandinat@gmx.de>,
 George Kennedy <george.kennedy@oracle.com>,
 Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
 Gustavo Silva <gustavoars@kernel.org>,
 Jani Nikula <jani.nikula@intel.com>, Jason Yan <yanaijie@huawei.com>,
 Jingoo Han <jingoohan1@gmail.com>, Jiri Slaby <jirislaby@kernel.org>,
 Joe Perches <joe@perches.com>,
 Kristoffer Ericson <kristoffer.ericson@gmail.com>,
 Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
 Mike Rapoport <rppt@kernel.org>,
 Nathan Chancellor <natechancellor@gmail.com>,
 Peilin Ye <yepeilin.cs@gmail.com>, Peter Rosin <peda@axentia.se>,
 Qilong Zhang <zhangqilong3@huawei.com>,
 Randy Dunlap <rdunlap@infradead.org>,
 Saeed Mirzamohammadi <saeed.mirzamohammadi@oracle.com>,
 Sam Ravnborg <sam@ravnborg.org>,
 Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>,
 Thomas Winischhofer <thomas@winischhofer.net>,
 Thomas Zimemrmann <tzimmermann@suse.de>,
 Vaibhav Gupta <vaibhavgupta40@gmail.com>,
 Xiaofei Tan <tanxiaofei@huawei.com>
Subject: [PATCH v2 07/28] video: fbdev: sis: Fix defined but not used warnings
Date: Sat, 28 Nov 2020 23:40:53 +0100
Message-Id: <20201128224114.1033617-8-sam@ravnborg.org>
X-Mailer: git-send-email 2.27.0
In-Reply-To: <20201128224114.1033617-1-sam@ravnborg.org>
References: <20201128224114.1033617-1-sam@ravnborg.org>
MIME-Version: 1.0
Precedence: bulk
List-ID: <linux-fbdev.vger.kernel.org>
X-Mailing-List: linux-fbdev@vger.kernel.org

init.h define static symbols, so should only be included
once. Drop the include from sis.h as it is not needed.
This fixes a lot of warnings seen with a W=1 build.

v2:
  - Update subject (Lee)

Signed-off-by: Sam Ravnborg <sam@ravnborg.org>
Cc: Thomas Winischhofer <thomas@winischhofer.net>
Cc: Lee Jones <lee.jones@linaro.org>
---
 drivers/video/fbdev/sis/sis.h | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/video/fbdev/sis/sis.h b/drivers/video/fbdev/sis/sis.h
index 9f4c3093ccb3..d632f096083b 100644
--- a/drivers/video/fbdev/sis/sis.h
+++ b/drivers/video/fbdev/sis/sis.h
@@ -15,7 +15,6 @@
 
 #include "vgatypes.h"
 #include "vstruct.h"
-#include "init.h"
 
 #define VER_MAJOR		1
 #define VER_MINOR		8

From patchwork Sat Nov 28 22:40:54 2020
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
X-Patchwork-Submitter: Sam Ravnborg <sam@ravnborg.org>
X-Patchwork-Id: 334264
Return-Path: <linux-fbdev-owner@kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
 aws-us-west-2-korg-lkml-1.web.codeaurora.org
X-Spam-Level: 
X-Spam-Status: No, score=-16.7 required=3.0 tests=BAYES_00,DKIM_SIGNED,
 DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,
 INCLUDES_PATCH, 
 MAILING_LIST_MULTI, SPF_HELO_NONE, SPF_PASS, URIBL_BLOCKED,
 USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0
Received: from mail.kernel.org (mail.kernel.org [198.145.29.99])
 by smtp.lore.kernel.org (Postfix) with ESMTP id 6D4FBC64E8A
 for <linux-fbdev@archiver.kernel.org>;
 Sat, 28 Nov 2020 22:43:00 +0000 (UTC)
Received: from vger.kernel.org (vger.kernel.org [23.128.96.18])
 by mail.kernel.org (Postfix) with ESMTP id 33B0120771
 for <linux-fbdev@archiver.kernel.org>;
 Sat, 28 Nov 2020 22:43:00 +0000 (UTC)
Authentication-Results: mail.kernel.org;
 dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com
 header.b="myfU0/b/"
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
 id S1726014AbgK1Wmu (ORCPT <rfc822; linux-fbdev@archiver.kernel.org>);
 Sat, 28 Nov 2020 17:42:50 -0500
Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49306 "EHLO
 lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by
 vger.kernel.org with ESMTP id S1732694AbgK1Wmt (ORCPT
 <rfc822;linux-fbdev@vger.kernel.org>);
 Sat, 28 Nov 2020 17:42:49 -0500
Received: from mail-lf1-x141.google.com (mail-lf1-x141.google.com
 [IPv6:2a00:1450:4864:20::141])
 by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 63464C061A49
 for <linux-fbdev@vger.kernel.org>;
 Sat, 28 Nov 2020 14:41:39 -0800 (PST)
Received: by mail-lf1-x141.google.com with SMTP id j205so12743849lfj.6
 for <linux-fbdev@vger.kernel.org>;
 Sat, 28 Nov 2020 14:41:39 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;
 h=sender:from:to:cc:subject:date:message-id:in-reply-to:references
 :mime-version:content-transfer-encoding;
 bh=CkkKBlbXcP/dpbOfp8AnQrPHxu0MxowQOk9O/jfPEvM=;
 b=myfU0/b/5BFYwWjwwEIJ580+u3RvEPUA2rg/ubozChfVxxDlaoKNZhuFfnDH0A5lrG
 Tkjm6VvYHDbp+kfHTtLsrR5IB4+2ywduPgh/R6Lia2iz/HVW2S/38gl+oCUAbTF588SD
 pnYfdcRPs/vK8bODBe3Mi+MI9yGQSUya1bejxklUrGBtk1OmDAKhiYGGl3P+djpopBhr
 xGRQSWwMN4hU6eGB7OibLrx26ww6spt5XEdh/kEjzKPS4LzNmTmqv4Ud8s7leX6vmfsN
 BcwrEHhPrxkT7U6CrheID/979KvzyHVQUz9rayaWEtR4xuYTrMohfC9rgMyNx4iwnc1k
 0kIw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20161025;
 h=x-gm-message-state:sender:from:to:cc:subject:date:message-id
 :in-reply-to:references:mime-version:content-transfer-encoding;
 bh=CkkKBlbXcP/dpbOfp8AnQrPHxu0MxowQOk9O/jfPEvM=;
 b=sTPCVKsvIxbBiXFntKWHCKHiOHPTobeX65EfQwZ2pFUaNUv2I0gM4IBmMJv2fQTUyp
 gfpB4u67oS9OBelDA7XtVU0qUvypVSoh892Th2g9/TYzmvclt9u9aH9rIVJo5J69xgtp
 XYHa7ShUZR//A54ozc4T1aNlQJMOdU+QvpaYP3amcqGCMmlHnazDpMtpi4Y2hW0Se50c
 gg0TJ47pubXLh8p+V3erlncm4y9XPmrBo1yCQ8SZN//vC9bZkRjwf055DJgTF697f3d3
 CFuihJCA+gaVNVhzBiXDxeVKin7rdE41YYmJgdtUiWfKf71HD4JXlX5CchCWrZz7kpb5
 JaNw==
X-Gm-Message-State: AOAM533RYRBCaFWlPxEY1JlLX1VRi8OOHiiCIyQxyC6rGm2o0CIbLHmm
 9i+gsC3iuoeOR5ULX/cTv4nrmK5awwSqbA==
X-Google-Smtp-Source: ABdhPJw3xPU1N65OeV/W6wReXcoA9gIj8j2aMYlOo4jhEeadsqD44d7njz7QpKk4AOXAGGCfHn7uYg==
X-Received: by 2002:ac2:5486:: with SMTP id t6mr6432455lfk.138.1606603297672; 
 Sat, 28 Nov 2020 14:41:37 -0800 (PST)
Received: from saturn.localdomain ([2a00:fd00:8060:1c00:a4c7:9ff9:a160:aad0])
 by smtp.gmail.com with ESMTPSA id
 w21sm1236857lff.280.2020.11.28.14.41.36
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Sat, 28 Nov 2020 14:41:37 -0800 (PST)
Sender: Sam Ravnborg <sam.ravnborg@gmail.com>
From: Sam Ravnborg <sam@ravnborg.org>
To: linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org,
 Lee Jones <lee.jones@linaro.org>
Cc: Aditya Pakki <pakki001@umn.edu>,
 Alexander Klimov <grandmaster@al2klimov.de>,
 Alex Dewar <alex.dewar90@gmail.com>, Antonino Daplas <adaplas@gmail.com>,
 Arnd Bergmann <arnd@arndb.de>,
 Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
 Benjamin Herrenschmidt <benh@kernel.crashing.org>,
 Daniel Vetter <daniel.vetter@ffwll.ch>, Evgeny Novikov <novikov@ispras.ru>,
 Florian Tobias Schandinat <FlorianSchandinat@gmx.de>,
 George Kennedy <george.kennedy@oracle.com>,
 Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
 Gustavo Silva <gustavoars@kernel.org>,
 Jani Nikula <jani.nikula@intel.com>, Jason Yan <yanaijie@huawei.com>,
 Jingoo Han <jingoohan1@gmail.com>, Jiri Slaby <jirislaby@kernel.org>,
 Joe Perches <joe@perches.com>,
 Kristoffer Ericson <kristoffer.ericson@gmail.com>,
 Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
 Mike Rapoport <rppt@kernel.org>,
 Nathan Chancellor <natechancellor@gmail.com>,
 Peilin Ye <yepeilin.cs@gmail.com>, Peter Rosin <peda@axentia.se>,
 Qilong Zhang <zhangqilong3@huawei.com>,
 Randy Dunlap <rdunlap@infradead.org>,
 Saeed Mirzamohammadi <saeed.mirzamohammadi@oracle.com>,
 Sam Ravnborg <sam@ravnborg.org>,
 Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>,
 Thomas Winischhofer <thomas@winischhofer.net>,
 Thomas Zimemrmann <tzimmermann@suse.de>,
 Vaibhav Gupta <vaibhavgupta40@gmail.com>,
 Xiaofei Tan <tanxiaofei@huawei.com>
Subject: [PATCH v2 08/28] video: fbdev: sis: Fix defined but not used
 warning of SiS_TVDelay
Date: Sat, 28 Nov 2020 23:40:54 +0100
Message-Id: <20201128224114.1033617-9-sam@ravnborg.org>
X-Mailer: git-send-email 2.27.0
In-Reply-To: <20201128224114.1033617-1-sam@ravnborg.org>
References: <20201128224114.1033617-1-sam@ravnborg.org>
MIME-Version: 1.0
Precedence: bulk
List-ID: <linux-fbdev.vger.kernel.org>
X-Mailing-List: linux-fbdev@vger.kernel.org

Fix W=1 warning by commenting unused SiS_TVDelay* variables.

The SiS_TVDelay* variables seem to contain some magic numbers
so looks like data worth keeping around but not as code we build.

v2:
  - Update subject (Lee)

Signed-off-by: Sam Ravnborg <sam@ravnborg.org>
Cc: Thomas Winischhofer <thomas@winischhofer.net>
Cc: Lee Jones <lee.jones@linaro.org>
Acked-by: Thomas Zimemrmann <tzimmermann@suse.de>
---
 drivers/video/fbdev/sis/oem310.h | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/video/fbdev/sis/oem310.h b/drivers/video/fbdev/sis/oem310.h
index 8fce56e4482c..ed28755715ce 100644
--- a/drivers/video/fbdev/sis/oem310.h
+++ b/drivers/video/fbdev/sis/oem310.h
@@ -200,6 +200,7 @@ static const unsigned char SiS310_TVDelayCompensation_651302LV[] =	/* M650, 651,
 	0x33,0x33
 };
 
+#if 0 /* Not used */
 static const unsigned char SiS_TVDelay661_301[] =			/* 661, 301 */
 {
 	0x44,0x44,
@@ -219,6 +220,7 @@ static const unsigned char SiS_TVDelay661_301B[] =			/* 661, 301B et al */
 	0x44,0x44,
 	0x44,0x44
 };
+#endif
 
 static const unsigned char SiS310_TVDelayCompensation_LVDS[] =		/* LVDS */
 {

From patchwork Sat Nov 28 22:40:55 2020
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
X-Patchwork-Submitter: Sam Ravnborg <sam@ravnborg.org>
X-Patchwork-Id: 334549
Return-Path: <linux-fbdev-owner@kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
 aws-us-west-2-korg-lkml-1.web.codeaurora.org
X-Spam-Level: 
X-Spam-Status: No, score=-16.7 required=3.0 tests=BAYES_00,DKIM_SIGNED,
 DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,
 INCLUDES_PATCH, 
 MAILING_LIST_MULTI, SPF_HELO_NONE, SPF_PASS, URIBL_BLOCKED,
 USER_AGENT_GIT
 autolearn=unavailable autolearn_force=no version=3.4.0
Received: from mail.kernel.org (mail.kernel.org [198.145.29.99])
 by smtp.lore.kernel.org (Postfix) with ESMTP id 8E5A2C64E7D
 for <linux-fbdev@archiver.kernel.org>;
 Sat, 28 Nov 2020 22:43:00 +0000 (UTC)
Received: from vger.kernel.org (vger.kernel.org [23.128.96.18])
 by mail.kernel.org (Postfix) with ESMTP id 5A3DB20702
 for <linux-fbdev@archiver.kernel.org>;
 Sat, 28 Nov 2020 22:43:00 +0000 (UTC)
Authentication-Results: mail.kernel.org;
 dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com
 header.b="ofNdOjN3"
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
 id S2387994AbgK1Wmy (ORCPT <rfc822; linux-fbdev@archiver.kernel.org>);
 Sat, 28 Nov 2020 17:42:54 -0500
Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49320 "EHLO
 lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by
 vger.kernel.org with ESMTP id S2387760AbgK1Wmx (ORCPT
 <rfc822;linux-fbdev@vger.kernel.org>);
 Sat, 28 Nov 2020 17:42:53 -0500
Received: from mail-lj1-x243.google.com (mail-lj1-x243.google.com
 [IPv6:2a00:1450:4864:20::243])
 by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3B7E5C061A4A
 for <linux-fbdev@vger.kernel.org>;
 Sat, 28 Nov 2020 14:41:41 -0800 (PST)
Received: by mail-lj1-x243.google.com with SMTP id s9so10557046ljo.11
 for <linux-fbdev@vger.kernel.org>;
 Sat, 28 Nov 2020 14:41:41 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;
 h=sender:from:to:cc:subject:date:message-id:in-reply-to:references
 :mime-version:content-transfer-encoding;
 bh=X+z/W9959CxKgG4WcN4Iy85oHK/P3LJfjbdab6tB79s=;
 b=ofNdOjN3WlUdlrHX/axL+yDyfNp545lGepiNBKQTQhrGcpIvCOWIuIjmylzgvkYZo3
 zZ/ft8dSvifUehjxethC+jjHyVhbJbbjzOyZv7I45z0hMnk7U/WcWz59qqdRlHjau7Y8
 N/Jpsm0jU14ltV83pn3FBcOgxnP5ZObDgmQ6RYyZTh0MxWUufx5lZXZFbnPzAblh+b7X
 2aVq6lJPoySRtc8kJrl/DwvplCIv5AzOmCPoU306KRinlxOrwDWgnPpmXiseo/BiaShA
 zovEbZQ6radlpeQZs5vPGCcwjpAYs9QIKn569HPMbFl38taCFfnbhp/Lzbx7qFDcJnbG
 Z5MQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20161025;
 h=x-gm-message-state:sender:from:to:cc:subject:date:message-id
 :in-reply-to:references:mime-version:content-transfer-encoding;
 bh=X+z/W9959CxKgG4WcN4Iy85oHK/P3LJfjbdab6tB79s=;
 b=idjQvITCAnVyFLHsWKU5itVW9uQmYVeQRPVEwbeJNSE1FTKbZCWPDPMqgQKIWIk18j
 xBybEN4ns4Zh77LpyNIdR7oVqRRPZO+jCMKqWvf9fVPyM/6NLX3fAbvb4/POJHZ9Q6EY
 UXHoRmkWUTf2UxodKpiBdNJnv8He53T1510nt+vxKQFnqfuUt7f9HIRuwvi7NnK3zQs/
 kCM/cLW0cp3yWHv4bWFuZ3yGs+lT7c4rLYvcUPCUT0gom3Y/UKRTNT4yn+JtbaiuWorM
 k2I3SfhzS9cCftWIfxN+mxTRyFK7IvdGEhO7GZvMW492ybtTFuD1c53+pYZ55fNZd+g/
 Lubw==
X-Gm-Message-State: AOAM530Ob2eM4hcZ+hGYKlvheAd5gpZd6jHm2AP2Ut6USb6yhufktKSS
 S95wZ01Ye2zb+MQDCZAa0kL5/Za7w+K3wg==
X-Google-Smtp-Source: ABdhPJwNCw1BRqGWU4zvMymxV8jqichRChera60GIW5wRzO4XHUQq1DJ6DguS8QDaDBs7tzG3iq0Xg==
X-Received: by 2002:a2e:a376:: with SMTP id i22mr6714027ljn.217.1606603299518; 
 Sat, 28 Nov 2020 14:41:39 -0800 (PST)
Received: from saturn.localdomain ([2a00:fd00:8060:1c00:a4c7:9ff9:a160:aad0])
 by smtp.gmail.com with ESMTPSA id
 w21sm1236857lff.280.2020.11.28.14.41.37
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Sat, 28 Nov 2020 14:41:39 -0800 (PST)
Sender: Sam Ravnborg <sam.ravnborg@gmail.com>
From: Sam Ravnborg <sam@ravnborg.org>
To: linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org,
 Lee Jones <lee.jones@linaro.org>
Cc: Aditya Pakki <pakki001@umn.edu>,
 Alexander Klimov <grandmaster@al2klimov.de>,
 Alex Dewar <alex.dewar90@gmail.com>, Antonino Daplas <adaplas@gmail.com>,
 Arnd Bergmann <arnd@arndb.de>,
 Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
 Benjamin Herrenschmidt <benh@kernel.crashing.org>,
 Daniel Vetter <daniel.vetter@ffwll.ch>, Evgeny Novikov <novikov@ispras.ru>,
 Florian Tobias Schandinat <FlorianSchandinat@gmx.de>,
 George Kennedy <george.kennedy@oracle.com>,
 Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
 Gustavo Silva <gustavoars@kernel.org>,
 Jani Nikula <jani.nikula@intel.com>, Jason Yan <yanaijie@huawei.com>,
 Jingoo Han <jingoohan1@gmail.com>, Jiri Slaby <jirislaby@kernel.org>,
 Joe Perches <joe@perches.com>,
 Kristoffer Ericson <kristoffer.ericson@gmail.com>,
 Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
 Mike Rapoport <rppt@kernel.org>,
 Nathan Chancellor <natechancellor@gmail.com>,
 Peilin Ye <yepeilin.cs@gmail.com>, Peter Rosin <peda@axentia.se>,
 Qilong Zhang <zhangqilong3@huawei.com>,
 Randy Dunlap <rdunlap@infradead.org>,
 Saeed Mirzamohammadi <saeed.mirzamohammadi@oracle.com>,
 Sam Ravnborg <sam@ravnborg.org>,
 Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>,
 Thomas Winischhofer <thomas@winischhofer.net>,
 Thomas Zimemrmann <tzimmermann@suse.de>,
 Vaibhav Gupta <vaibhavgupta40@gmail.com>,
 Xiaofei Tan <tanxiaofei@huawei.com>
Subject: [PATCH v2 09/28] video: fbdev: sis: Fix set but not used warnings
 in init.c
Date: Sat, 28 Nov 2020 23:40:55 +0100
Message-Id: <20201128224114.1033617-10-sam@ravnborg.org>
X-Mailer: git-send-email 2.27.0
In-Reply-To: <20201128224114.1033617-1-sam@ravnborg.org>
References: <20201128224114.1033617-1-sam@ravnborg.org>
MIME-Version: 1.0
Precedence: bulk
List-ID: <linux-fbdev.vger.kernel.org>
X-Mailing-List: linux-fbdev@vger.kernel.org

Fix set bit not used warnings by removing the code the assign the
variables and the definition of the variables.
A register read is kept as it may have unknown side-effects.

This removes a lot of unused code - which is always a good thing to do.

v2:
  - Updated subject (Lee)

Signed-off-by: Sam Ravnborg <sam@ravnborg.org>
Cc: Thomas Winischhofer <thomas@winischhofer.net>
Cc: Lee Jones <lee.jones@linaro.org>
---
 drivers/video/fbdev/sis/init.c | 34 ++++++----------------------------
 1 file changed, 6 insertions(+), 28 deletions(-)

diff --git a/drivers/video/fbdev/sis/init.c b/drivers/video/fbdev/sis/init.c
index fde27feae5d0..b77ea1a8825a 100644
--- a/drivers/video/fbdev/sis/init.c
+++ b/drivers/video/fbdev/sis/init.c
@@ -2648,7 +2648,7 @@ static void
 SiS_SetCRT1ModeRegs(struct SiS_Private *SiS_Pr, unsigned short ModeNo,
 		unsigned short ModeIdIndex, unsigned short RRTI)
 {
-   unsigned short data, infoflag = 0, modeflag, resindex;
+   unsigned short data, infoflag = 0, modeflag;
 #ifdef CONFIG_FB_SIS_315
    unsigned char  *ROMAddr  = SiS_Pr->VirtualRomBase;
    unsigned short data2, data3;
@@ -2659,7 +2659,7 @@ SiS_SetCRT1ModeRegs(struct SiS_Private *SiS_Pr, unsigned short ModeNo,
    if(SiS_Pr->UseCustomMode) {
       infoflag = SiS_Pr->CInfoFlag;
    } else {
-      resindex = SiS_GetResInfo(SiS_Pr, ModeNo, ModeIdIndex);
+      SiS_GetResInfo(SiS_Pr, ModeNo, ModeIdIndex);
       if(ModeNo > 0x13) {
 	 infoflag = SiS_Pr->SiS_RefIndex[RRTI].Ext_InfoFlag;
       }
@@ -3538,17 +3538,13 @@ SiS_Generic_ConvertCRData(struct SiS_Private *SiS_Pr, unsigned char *crdata,
 			struct fb_var_screeninfo *var, bool writeres
 )
 {
-   unsigned short HRE, HBE, HRS, HBS, HDE, HT;
-   unsigned short VRE, VBE, VRS, VBS, VDE, VT;
-   unsigned char  sr_data, cr_data, cr_data2;
-   int            A, B, C, D, E, F, temp;
+   unsigned short HRE, HBE, HRS, HDE;
+   unsigned short VRE, VBE, VRS, VDE;
+   unsigned char  sr_data, cr_data;
+   int            B, C, D, E, F, temp;
 
    sr_data = crdata[14];
 
-   /* Horizontal total */
-   HT =  crdata[0] | ((unsigned short)(sr_data & 0x03) << 8);
-   A = HT + 5;
-
    /* Horizontal display enable end */
    HDE = crdata[1] | ((unsigned short)(sr_data & 0x0C) << 6);
    E = HDE + 1;
@@ -3557,9 +3553,6 @@ SiS_Generic_ConvertCRData(struct SiS_Private *SiS_Pr, unsigned char *crdata,
    HRS = crdata[4] | ((unsigned short)(sr_data & 0xC0) << 2);
    F = HRS - E - 3;
 
-   /* Horizontal blank start */
-   HBS = crdata[2] | ((unsigned short)(sr_data & 0x30) << 4);
-
    sr_data = crdata[15];
    cr_data = crdata[5];
 
@@ -3588,13 +3581,6 @@ SiS_Generic_ConvertCRData(struct SiS_Private *SiS_Pr, unsigned char *crdata,
    sr_data = crdata[13];
    cr_data = crdata[7];
 
-   /* Vertical total */
-   VT  = crdata[6] |
-	 ((unsigned short)(cr_data & 0x01) << 8) |
-	 ((unsigned short)(cr_data & 0x20) << 4) |
-	 ((unsigned short)(sr_data & 0x01) << 10);
-   A = VT + 2;
-
    /* Vertical display enable end */
    VDE = crdata[10] |
 	 ((unsigned short)(cr_data & 0x02) << 7) |
@@ -3609,14 +3595,6 @@ SiS_Generic_ConvertCRData(struct SiS_Private *SiS_Pr, unsigned char *crdata,
 	 ((unsigned short)(sr_data & 0x08) << 7);
    F = VRS + 1 - E;
 
-   cr_data2 = (crdata[16] & 0x01) << 5;
-
-   /* Vertical blank start */
-   VBS = crdata[11] |
-	 ((unsigned short)(cr_data  & 0x08) << 5) |
-	 ((unsigned short)(cr_data2 & 0x20) << 4) |
-	 ((unsigned short)(sr_data  & 0x04) << 8);
-
    /* Vertical blank end */
    VBE = crdata[12] | ((unsigned short)(sr_data & 0x10) << 4);
    temp = VBE - ((E - 1) & 511);

From patchwork Sat Nov 28 22:40:56 2020
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
X-Patchwork-Submitter: Sam Ravnborg <sam@ravnborg.org>
X-Patchwork-Id: 334263
Return-Path: <linux-fbdev-owner@kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
 aws-us-west-2-korg-lkml-1.web.codeaurora.org
X-Spam-Level: 
X-Spam-Status: No, score=-16.7 required=3.0 tests=BAYES_00,DKIM_SIGNED,
 DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,
 INCLUDES_PATCH, 
 MAILING_LIST_MULTI, SPF_HELO_NONE, SPF_PASS, URIBL_BLOCKED,
 USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0
Received: from mail.kernel.org (mail.kernel.org [198.145.29.99])
 by smtp.lore.kernel.org (Postfix) with ESMTP id BA20EC64E90
 for <linux-fbdev@archiver.kernel.org>;
 Sat, 28 Nov 2020 22:43:00 +0000 (UTC)
Received: from vger.kernel.org (vger.kernel.org [23.128.96.18])
 by mail.kernel.org (Postfix) with ESMTP id 7F96A20771
 for <linux-fbdev@archiver.kernel.org>;
 Sat, 28 Nov 2020 22:43:00 +0000 (UTC)
Authentication-Results: mail.kernel.org;
 dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com
 header.b="ZusRrASF"
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
 id S2387760AbgK1Wmy (ORCPT <rfc822; linux-fbdev@archiver.kernel.org>);
 Sat, 28 Nov 2020 17:42:54 -0500
Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49322 "EHLO
 lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by
 vger.kernel.org with ESMTP id S2387803AbgK1Wmx (ORCPT
 <rfc822;linux-fbdev@vger.kernel.org>);
 Sat, 28 Nov 2020 17:42:53 -0500
Received: from mail-lj1-x244.google.com (mail-lj1-x244.google.com
 [IPv6:2a00:1450:4864:20::244])
 by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0E9CBC061A4B
 for <linux-fbdev@vger.kernel.org>;
 Sat, 28 Nov 2020 14:41:43 -0800 (PST)
Received: by mail-lj1-x244.google.com with SMTP id i17so10604397ljd.3
 for <linux-fbdev@vger.kernel.org>;
 Sat, 28 Nov 2020 14:41:42 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;
 h=sender:from:to:cc:subject:date:message-id:in-reply-to:references
 :mime-version:content-transfer-encoding;
 bh=y9DoNLVD1VJdMvYkN8JAl3I/nCqyKUSn3u0XqPwML4w=;
 b=ZusRrASFECptUJSOveiHQvYDfWj66YcjXLdZqrYufzMQ6FYHpk5mUHtLtBasEaUMUE
 tw3OASadraNE+yTe0bzr7mJKOWcf8M0zyAc1AlYdy0g7uPnVc9LW2d2WYn3wNezvsPyB
 QmEwQkrcj+KR5Z5icz8mpns2eXNK1CM52JsAjkKg/uKNR3/BWr36Od2ITt2t23gaOKyx
 VR1X1oQFdNr0IqP9Omdsohq2d9SNWuvQbbm4GyVW+6+ADBlK6tb34hqdr1bczhPftGkR
 qlPSqQEseT3oYOQhcHciGAoFju1VPmS0k6OC5FuRRI/em0Z40+ynbJjbok+mAg1J5z4H
 a4LA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20161025;
 h=x-gm-message-state:sender:from:to:cc:subject:date:message-id
 :in-reply-to:references:mime-version:content-transfer-encoding;
 bh=y9DoNLVD1VJdMvYkN8JAl3I/nCqyKUSn3u0XqPwML4w=;
 b=aPu6hPshhKXZpqa2u4n8Dn3yopB8JTA7lUVxj4FH5ApO/UGgmYH6OzLEsu6SmyZwIb
 mkcSboLd/qVDUs3+3/dtvretRkq4Y6vpzqRh7U49Ff9MCX+70iQGgKCO1nw/5MgBUayP
 bad2VpRf9K1fo5I7J0DANknPa85V5kxpjMqT7xeq589gQwO/+t0giOfxAKb4ZoY+B/Xn
 vcGORcfgJ5ShTfZWMz0jH1gqY8HlDyQ96Ch3TfdTCtqKIIEOZo5N0U72VPHc99bZewuP
 cJ+seTVnI7fGTobZZ8D//9d/7drKEbdfyvQP4Mk0bmSmdvIy27Zn5VlX2727eQJqhdJe
 eYqQ==
X-Gm-Message-State: AOAM531Q1nLHokTJqEMHEBT3AvxEGLpD+BSlhF4GcxsQoMcO+9f9DEiL
 J2bZcviVuIz2DE30Ww/IVWc56hcUW23yvg==
X-Google-Smtp-Source: ABdhPJxKPuOqOji6HCC4m60UbiB34g5mjv+rMTRpJMjPkv/jqh0DDmlaT45tvr7TU3Qydah7YP0J+g==
X-Received: by 2002:a2e:894b:: with SMTP id b11mr6467359ljk.439.1606603301363; 
 Sat, 28 Nov 2020 14:41:41 -0800 (PST)
Received: from saturn.localdomain ([2a00:fd00:8060:1c00:a4c7:9ff9:a160:aad0])
 by smtp.gmail.com with ESMTPSA id
 w21sm1236857lff.280.2020.11.28.14.41.39
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Sat, 28 Nov 2020 14:41:40 -0800 (PST)
Sender: Sam Ravnborg <sam.ravnborg@gmail.com>
From: Sam Ravnborg <sam@ravnborg.org>
To: linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org,
 Lee Jones <lee.jones@linaro.org>
Cc: Aditya Pakki <pakki001@umn.edu>,
 Alexander Klimov <grandmaster@al2klimov.de>,
 Alex Dewar <alex.dewar90@gmail.com>, Antonino Daplas <adaplas@gmail.com>,
 Arnd Bergmann <arnd@arndb.de>,
 Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
 Benjamin Herrenschmidt <benh@kernel.crashing.org>,
 Daniel Vetter <daniel.vetter@ffwll.ch>, Evgeny Novikov <novikov@ispras.ru>,
 Florian Tobias Schandinat <FlorianSchandinat@gmx.de>,
 George Kennedy <george.kennedy@oracle.com>,
 Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
 Gustavo Silva <gustavoars@kernel.org>,
 Jani Nikula <jani.nikula@intel.com>, Jason Yan <yanaijie@huawei.com>,
 Jingoo Han <jingoohan1@gmail.com>, Jiri Slaby <jirislaby@kernel.org>,
 Joe Perches <joe@perches.com>,
 Kristoffer Ericson <kristoffer.ericson@gmail.com>,
 Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
 Mike Rapoport <rppt@kernel.org>,
 Nathan Chancellor <natechancellor@gmail.com>,
 Peilin Ye <yepeilin.cs@gmail.com>, Peter Rosin <peda@axentia.se>,
 Qilong Zhang <zhangqilong3@huawei.com>,
 Randy Dunlap <rdunlap@infradead.org>,
 Saeed Mirzamohammadi <saeed.mirzamohammadi@oracle.com>,
 Sam Ravnborg <sam@ravnborg.org>,
 Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>,
 Thomas Winischhofer <thomas@winischhofer.net>,
 Thomas Zimemrmann <tzimmermann@suse.de>,
 Vaibhav Gupta <vaibhavgupta40@gmail.com>,
 Xiaofei Tan <tanxiaofei@huawei.com>
Subject: [PATCH v2 10/28] video: fbdev: sis: Fix set but not used warnings
 in sis_main
Date: Sat, 28 Nov 2020 23:40:56 +0100
Message-Id: <20201128224114.1033617-11-sam@ravnborg.org>
X-Mailer: git-send-email 2.27.0
In-Reply-To: <20201128224114.1033617-1-sam@ravnborg.org>
References: <20201128224114.1033617-1-sam@ravnborg.org>
MIME-Version: 1.0
Precedence: bulk
List-ID: <linux-fbdev.vger.kernel.org>
X-Mailing-List: linux-fbdev@vger.kernel.org

Fix warnings by dropping unused variable and the
unused assignments.

v2:
  - Update subject (Lee)

Signed-off-by: Sam Ravnborg <sam@ravnborg.org>
Cc: Thomas Winischhofer <thomas@winischhofer.net>
Cc: Lee Jones <lee.jones@linaro.org>
Acked-by: Thomas Zimmermann <tzimmermann@suse.de>
---
 drivers/video/fbdev/sis/sis_main.c | 9 ++++-----
 1 file changed, 4 insertions(+), 5 deletions(-)

diff --git a/drivers/video/fbdev/sis/sis_main.c b/drivers/video/fbdev/sis/sis_main.c
index 03c736f6f3d0..266a5582f94d 100644
--- a/drivers/video/fbdev/sis/sis_main.c
+++ b/drivers/video/fbdev/sis/sis_main.c
@@ -5029,7 +5029,6 @@ static void sisfb_post_xgi_ddr2(struct sis_video_info *ivideo, u8 regb)
 	static const u8 cs168[8] = {
 		0x48, 0x78, 0x88, 0x00, 0x00, 0x00, 0x00, 0x00
 	};
-	u8 reg;
 	u8 v1;
 	u8 v2;
 	u8 v3;
@@ -5037,9 +5036,9 @@ static void sisfb_post_xgi_ddr2(struct sis_video_info *ivideo, u8 regb)
 	SiS_SetReg(SISCR, 0xb0, 0x80); /* DDR2 dual frequency mode */
 	SiS_SetReg(SISCR, 0x82, 0x77);
 	SiS_SetReg(SISCR, 0x86, 0x00);
-	reg = SiS_GetReg(SISCR, 0x86);
+	SiS_GetReg(SISCR, 0x86);
 	SiS_SetReg(SISCR, 0x86, 0x88);
-	reg = SiS_GetReg(SISCR, 0x86);
+	SiS_GetReg(SISCR, 0x86);
 	v1 = cs168[regb]; v2 = cs160[regb]; v3 = cs158[regb];
 	if (ivideo->haveXGIROM) {
 		v1 = bios[regb + 0x168];
@@ -5049,9 +5048,9 @@ static void sisfb_post_xgi_ddr2(struct sis_video_info *ivideo, u8 regb)
 	SiS_SetReg(SISCR, 0x86, v1);
 	SiS_SetReg(SISCR, 0x82, 0x77);
 	SiS_SetReg(SISCR, 0x85, 0x00);
-	reg = SiS_GetReg(SISCR, 0x85);
+	SiS_GetReg(SISCR, 0x85);
 	SiS_SetReg(SISCR, 0x85, 0x88);
-	reg = SiS_GetReg(SISCR, 0x85);
+	SiS_GetReg(SISCR, 0x85);
 	SiS_SetReg(SISCR, 0x85, v2);
 	SiS_SetReg(SISCR, 0x82, v3);
 	SiS_SetReg(SISCR, 0x98, 0x01);

From patchwork Sat Nov 28 22:40:57 2020
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
X-Patchwork-Submitter: Sam Ravnborg <sam@ravnborg.org>
X-Patchwork-Id: 334548
Return-Path: <linux-fbdev-owner@kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
 aws-us-west-2-korg-lkml-1.web.codeaurora.org
X-Spam-Level: 
X-Spam-Status: No, score=-16.7 required=3.0 tests=BAYES_00,DKIM_SIGNED,
 DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,
 INCLUDES_PATCH, 
 MAILING_LIST_MULTI, SPF_HELO_NONE, SPF_PASS, URIBL_BLOCKED,
 USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0
Received: from mail.kernel.org (mail.kernel.org [198.145.29.99])
 by smtp.lore.kernel.org (Postfix) with ESMTP id D7AD9C71155
 for <linux-fbdev@archiver.kernel.org>;
 Sat, 28 Nov 2020 22:43:00 +0000 (UTC)
Received: from vger.kernel.org (vger.kernel.org [23.128.96.18])
 by mail.kernel.org (Postfix) with ESMTP id A322720702
 for <linux-fbdev@archiver.kernel.org>;
 Sat, 28 Nov 2020 22:43:00 +0000 (UTC)
Authentication-Results: mail.kernel.org;
 dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com
 header.b="I6GqQD3f"
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
 id S2387803AbgK1Wmy (ORCPT <rfc822; linux-fbdev@archiver.kernel.org>);
 Sat, 28 Nov 2020 17:42:54 -0500
Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49326 "EHLO
 lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by
 vger.kernel.org with ESMTP id S2387804AbgK1Wmx (ORCPT
 <rfc822;linux-fbdev@vger.kernel.org>);
 Sat, 28 Nov 2020 17:42:53 -0500
Received: from mail-lj1-x241.google.com (mail-lj1-x241.google.com
 [IPv6:2a00:1450:4864:20::241])
 by lindbergh.monkeyblade.net (Postfix) with ESMTPS id ECB0FC061A4C
 for <linux-fbdev@vger.kernel.org>;
 Sat, 28 Nov 2020 14:41:44 -0800 (PST)
Received: by mail-lj1-x241.google.com with SMTP id y10so10588735ljc.7
 for <linux-fbdev@vger.kernel.org>;
 Sat, 28 Nov 2020 14:41:44 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;
 h=sender:from:to:cc:subject:date:message-id:in-reply-to:references
 :mime-version:content-transfer-encoding;
 bh=qQbdoMGfp7HI6Wmt4IR8iWJeCZkxPlinkDvEVc1r82A=;
 b=I6GqQD3fz1EqGD498t1GsLkIHDFsRv7/o3xRXWseWPdVQCKrCv2QN8njbKtX7/+cz+
 smvA7q0jnFm1q/Dd7pQ2F/L2yCX1fFZPKJj0Kw043RE5OWX9f2eAIn3tkU+6HpN70Cji
 AyBSZBvy9qs/unaX+yF8BwNQrOkMG/ffP2VFFu/g7pVCSjL9G+x7Q+Vup9KCo38ZNOIy
 VG2zGt8jy6PeULtQMpE8KtRVaMPR7wrdMa45Aho5tLl8Ai/h9m7nCT0zjkFDzxwxXw45
 bsU1QTW0NdlWDMGK4uCZL+WLbgDejqM9XOPK5RqZfGE7Vq/eMRQT9z11o0frnevy8AyM
 pZ4g==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20161025;
 h=x-gm-message-state:sender:from:to:cc:subject:date:message-id
 :in-reply-to:references:mime-version:content-transfer-encoding;
 bh=qQbdoMGfp7HI6Wmt4IR8iWJeCZkxPlinkDvEVc1r82A=;
 b=YKunubawUV7yE9Uwk3E21x9H0vz7aToArXGbqx8i4U6ahWQDeZ6ELsX914dKtcsEw8
 AzzX1vcPp+ReesYoV84WB6B5DMhyADDxTP3uOsfvgzct2O/FfFa+qpLAd9AT09xxffkS
 2dGQcfvWPosSVqwXgmYqw9V3DeX2WrQG1BjtW0D+pVmxJbSKuu1iV8gjfoigrUyLLSfe
 f3hgZD/8uiy9wz5WPyPUdhKvUQUQHTDeGaYeXxVJ2W+z+4qfxGe7q66SNtuaA/AIh9YF
 qWhMzLsims1afljq0wiQGpYtWod1QE+3O6BkI8qGQjbL4eAl3p3uYCEeyfuFext7dvDH
 Ch7A==
X-Gm-Message-State: AOAM530VzWa+1Rv1HjFuoAlbhwzu29TmfNPBuQx/nz/RiUoDaU32bwKz
 GM1ahTO6Gg2X7OiTYBjOrntIqpWux/7sgA==
X-Google-Smtp-Source: ABdhPJzFyXGSucNfx9yncv1e42W9SVj8LPo5R/vJS1rgbRNBov9ReHwMEZgrMKy4kizi21GFlNwCQA==
X-Received: by 2002:a2e:535a:: with SMTP id t26mr6393928ljd.87.1606603303293; 
 Sat, 28 Nov 2020 14:41:43 -0800 (PST)
Received: from saturn.localdomain ([2a00:fd00:8060:1c00:a4c7:9ff9:a160:aad0])
 by smtp.gmail.com with ESMTPSA id
 w21sm1236857lff.280.2020.11.28.14.41.41
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Sat, 28 Nov 2020 14:41:42 -0800 (PST)
Sender: Sam Ravnborg <sam.ravnborg@gmail.com>
From: Sam Ravnborg <sam@ravnborg.org>
To: linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org,
 Lee Jones <lee.jones@linaro.org>
Cc: Aditya Pakki <pakki001@umn.edu>,
 Alexander Klimov <grandmaster@al2klimov.de>,
 Alex Dewar <alex.dewar90@gmail.com>, Antonino Daplas <adaplas@gmail.com>,
 Arnd Bergmann <arnd@arndb.de>,
 Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
 Benjamin Herrenschmidt <benh@kernel.crashing.org>,
 Daniel Vetter <daniel.vetter@ffwll.ch>, Evgeny Novikov <novikov@ispras.ru>,
 Florian Tobias Schandinat <FlorianSchandinat@gmx.de>,
 George Kennedy <george.kennedy@oracle.com>,
 Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
 Gustavo Silva <gustavoars@kernel.org>,
 Jani Nikula <jani.nikula@intel.com>, Jason Yan <yanaijie@huawei.com>,
 Jingoo Han <jingoohan1@gmail.com>, Jiri Slaby <jirislaby@kernel.org>,
 Joe Perches <joe@perches.com>,
 Kristoffer Ericson <kristoffer.ericson@gmail.com>,
 Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
 Mike Rapoport <rppt@kernel.org>,
 Nathan Chancellor <natechancellor@gmail.com>,
 Peilin Ye <yepeilin.cs@gmail.com>, Peter Rosin <peda@axentia.se>,
 Qilong Zhang <zhangqilong3@huawei.com>,
 Randy Dunlap <rdunlap@infradead.org>,
 Saeed Mirzamohammadi <saeed.mirzamohammadi@oracle.com>,
 Sam Ravnborg <sam@ravnborg.org>,
 Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>,
 Thomas Winischhofer <thomas@winischhofer.net>,
 Thomas Zimemrmann <tzimmermann@suse.de>,
 Vaibhav Gupta <vaibhavgupta40@gmail.com>,
 Xiaofei Tan <tanxiaofei@huawei.com>
Subject: [PATCH v2 11/28] video: fbdev: via: Fix set but not used warning
 for mode_crt_table
Date: Sat, 28 Nov 2020 23:40:57 +0100
Message-Id: <20201128224114.1033617-12-sam@ravnborg.org>
X-Mailer: git-send-email 2.27.0
In-Reply-To: <20201128224114.1033617-1-sam@ravnborg.org>
References: <20201128224114.1033617-1-sam@ravnborg.org>
MIME-Version: 1.0
Precedence: bulk
List-ID: <linux-fbdev.vger.kernel.org>
X-Mailing-List: linux-fbdev@vger.kernel.org

Fix warning by deleting the variable. The function call
viafb_get_best_mode() were verified to have no side-effects,
and thus could be dropped too.

v2:
  - Update subject (Lee)

Signed-off-by: Sam Ravnborg <sam@ravnborg.org>
Cc: Florian Tobias Schandinat <FlorianSchandinat@gmx.de>
Cc: linux-fbdev@vger.kernel.org
Cc: Lee Jones <lee.jones@linaro.org>
---
 drivers/video/fbdev/via/lcd.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/video/fbdev/via/lcd.c b/drivers/video/fbdev/via/lcd.c
index 4a869402d120..088b962076b5 100644
--- a/drivers/video/fbdev/via/lcd.c
+++ b/drivers/video/fbdev/via/lcd.c
@@ -537,11 +537,9 @@ void viafb_lcd_set_mode(const struct fb_var_screeninfo *var, u16 cxres,
 	u32 clock;
 	struct via_display_timing timing;
 	struct fb_var_screeninfo panel_var;
-	const struct fb_videomode *mode_crt_table, *panel_crt_table;
+	const struct fb_videomode *panel_crt_table;
 
 	DEBUG_MSG(KERN_INFO "viafb_lcd_set_mode!!\n");
-	/* Get mode table */
-	mode_crt_table = viafb_get_best_mode(set_hres, set_vres, 60);
 	/* Get panel table Pointer */
 	panel_crt_table = viafb_get_best_mode(panel_hres, panel_vres, 60);
 	viafb_fill_var_timing_info(&panel_var, panel_crt_table);

From patchwork Sat Nov 28 22:40:58 2020
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
X-Patchwork-Submitter: Sam Ravnborg <sam@ravnborg.org>
X-Patchwork-Id: 334262
Return-Path: <linux-fbdev-owner@kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
 aws-us-west-2-korg-lkml-1.web.codeaurora.org
X-Spam-Level: 
X-Spam-Status: No, score=-16.7 required=3.0 tests=BAYES_00,DKIM_SIGNED,
 DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,
 INCLUDES_PATCH, 
 MAILING_LIST_MULTI, SPF_HELO_NONE, SPF_PASS, URIBL_BLOCKED,
 USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0
Received: from mail.kernel.org (mail.kernel.org [198.145.29.99])
 by smtp.lore.kernel.org (Postfix) with ESMTP id 0CCBAC71156
 for <linux-fbdev@archiver.kernel.org>;
 Sat, 28 Nov 2020 22:43:01 +0000 (UTC)
Received: from vger.kernel.org (vger.kernel.org [23.128.96.18])
 by mail.kernel.org (Postfix) with ESMTP id C8CFF20771
 for <linux-fbdev@archiver.kernel.org>;
 Sat, 28 Nov 2020 22:43:00 +0000 (UTC)
Authentication-Results: mail.kernel.org;
 dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com
 header.b="n+8fbCu6"
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
 id S2387804AbgK1Wmz (ORCPT <rfc822; linux-fbdev@archiver.kernel.org>);
 Sat, 28 Nov 2020 17:42:55 -0500
Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49328 "EHLO
 lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by
 vger.kernel.org with ESMTP id S2387814AbgK1Wmx (ORCPT
 <rfc822;linux-fbdev@vger.kernel.org>);
 Sat, 28 Nov 2020 17:42:53 -0500
Received: from mail-lj1-x243.google.com (mail-lj1-x243.google.com
 [IPv6:2a00:1450:4864:20::243])
 by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C1368C061A4F
 for <linux-fbdev@vger.kernel.org>;
 Sat, 28 Nov 2020 14:41:46 -0800 (PST)
Received: by mail-lj1-x243.google.com with SMTP id o24so10578040ljj.6
 for <linux-fbdev@vger.kernel.org>;
 Sat, 28 Nov 2020 14:41:46 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;
 h=sender:from:to:cc:subject:date:message-id:in-reply-to:references
 :mime-version:content-transfer-encoding;
 bh=if4pzrzCg3q6ofCtFvf6yx5yT56Fowc0s0Pn6h0Zotc=;
 b=n+8fbCu6wuPRFXEnwNsFn69z5xcEOmjQjYUGqkvFjrF9Oz2C7XLsj5B831CoAIPv7Y
 a40kM24PL2nZRS0LvIpGjGHGBeIh8iv2Mv2+Gqxa14fcXzINfbbCuECej+XJPknAZZQs
 /8Z8ZT6RbCfihIhMpVsrjqAoKDaDfVDuNfTDB+CrIHaReoZMc3aoZdpmWWkH/KqGuUD1
 L/x3DSWTEwgGLKR/oPR4rafJLUtHa/s6n5JDX3eN6Sy92VZtGrwt56i4LuJPklmR21RB
 JZmbXKkYy90cUr9l/P5trM9dzq6I559NeXapOEPQs6RL/SSqRIDLq34Cl5QCvYaI6CM7
 mZdg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20161025;
 h=x-gm-message-state:sender:from:to:cc:subject:date:message-id
 :in-reply-to:references:mime-version:content-transfer-encoding;
 bh=if4pzrzCg3q6ofCtFvf6yx5yT56Fowc0s0Pn6h0Zotc=;
 b=uSeYpmLv0deo/zumJjEqc2wZSeA8WpMCC4XLnsoMA046GnAi9Qijv1Hejv6yIUudKw
 IkkxiTOMLXA+b4YkLyQ4hLr0vb+F4/KFQ93kXU4C2IKnHMgHTLGfZ++sbshTpjpP+BqA
 7VkBEzxEZuWh3LPMaVljPTRdvd7DiQ/SLxoIvldoFXOaZU9hmJhM4c3XmG0Ll3VSL7bk
 gkEWzlD2SRRoRagJA4jjbwGSXpYeqqXPGY1hBwRvlboZ+oDbEBoFDSD1HilQ4Hz6CyII
 6jpQP9JMT52KoSVI/A1TxPSNWxUBoOM84nT71EGKTrGY3/JhnW4gX18iHLpB6GOekyDm
 +DFA==
X-Gm-Message-State: AOAM532IuN2+ErsO9jwJ90SkSjqrMl9BfyMqxOa+uooLclyLfTeIKlf+
 2agNcxw7/ffrGcP/g/G45JvQYrR5HEcaGA==
X-Google-Smtp-Source: ABdhPJxjEjieR1eWGnWmOrKK7EqGckvOLz6a81CIg52CDCjBQ0NqMQcG6SpsgadZ2EWXdh3aRqGGYQ==
X-Received: by 2002:a2e:9694:: with SMTP id q20mr6409864lji.279.1606603305138; 
 Sat, 28 Nov 2020 14:41:45 -0800 (PST)
Received: from saturn.localdomain ([2a00:fd00:8060:1c00:a4c7:9ff9:a160:aad0])
 by smtp.gmail.com with ESMTPSA id
 w21sm1236857lff.280.2020.11.28.14.41.43
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Sat, 28 Nov 2020 14:41:44 -0800 (PST)
Sender: Sam Ravnborg <sam.ravnborg@gmail.com>
From: Sam Ravnborg <sam@ravnborg.org>
To: linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org,
 Lee Jones <lee.jones@linaro.org>
Cc: Aditya Pakki <pakki001@umn.edu>,
 Alexander Klimov <grandmaster@al2klimov.de>,
 Alex Dewar <alex.dewar90@gmail.com>, Antonino Daplas <adaplas@gmail.com>,
 Arnd Bergmann <arnd@arndb.de>,
 Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
 Benjamin Herrenschmidt <benh@kernel.crashing.org>,
 Daniel Vetter <daniel.vetter@ffwll.ch>, Evgeny Novikov <novikov@ispras.ru>,
 Florian Tobias Schandinat <FlorianSchandinat@gmx.de>,
 George Kennedy <george.kennedy@oracle.com>,
 Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
 Gustavo Silva <gustavoars@kernel.org>,
 Jani Nikula <jani.nikula@intel.com>, Jason Yan <yanaijie@huawei.com>,
 Jingoo Han <jingoohan1@gmail.com>, Jiri Slaby <jirislaby@kernel.org>,
 Joe Perches <joe@perches.com>,
 Kristoffer Ericson <kristoffer.ericson@gmail.com>,
 Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
 Mike Rapoport <rppt@kernel.org>,
 Nathan Chancellor <natechancellor@gmail.com>,
 Peilin Ye <yepeilin.cs@gmail.com>, Peter Rosin <peda@axentia.se>,
 Qilong Zhang <zhangqilong3@huawei.com>,
 Randy Dunlap <rdunlap@infradead.org>,
 Saeed Mirzamohammadi <saeed.mirzamohammadi@oracle.com>,
 Sam Ravnborg <sam@ravnborg.org>,
 Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>,
 Thomas Winischhofer <thomas@winischhofer.net>,
 Thomas Zimemrmann <tzimmermann@suse.de>,
 Vaibhav Gupta <vaibhavgupta40@gmail.com>,
 Xiaofei Tan <tanxiaofei@huawei.com>
Subject: [PATCH v2 12/28] video: fbdev: tdfx: Fix set but not used warning
 in att_outb()
Date: Sat, 28 Nov 2020 23:40:58 +0100
Message-Id: <20201128224114.1033617-13-sam@ravnborg.org>
X-Mailer: git-send-email 2.27.0
In-Reply-To: <20201128224114.1033617-1-sam@ravnborg.org>
References: <20201128224114.1033617-1-sam@ravnborg.org>
MIME-Version: 1.0
Precedence: bulk
List-ID: <linux-fbdev.vger.kernel.org>
X-Mailing-List: linux-fbdev@vger.kernel.org

The tmp variable were assigned but the result was never used,
so delete the tmp variable.

v2:
  - Update subject (Lee)

Signed-off-by: Sam Ravnborg <sam@ravnborg.org>
Cc: "Gustavo A. R. Silva" <gustavoars@kernel.org>
Cc: Sam Ravnborg <sam@ravnborg.org>
Cc: Jani Nikula <jani.nikula@intel.com>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
Cc: Arnd Bergmann <arnd@arndb.de>
Cc: Lee Jones <lee.jones@linaro.org>
Acked-by: Thomas Zimmermann <tzimmermann@suse.de>
---
 drivers/video/fbdev/tdfxfb.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/video/fbdev/tdfxfb.c b/drivers/video/fbdev/tdfxfb.c
index f056d80f6359..67e37a62b07c 100644
--- a/drivers/video/fbdev/tdfxfb.c
+++ b/drivers/video/fbdev/tdfxfb.c
@@ -206,9 +206,7 @@ static inline u8 crt_inb(struct tdfx_par *par, u32 idx)
 
 static inline void att_outb(struct tdfx_par *par, u32 idx, u8 val)
 {
-	unsigned char tmp;
-
-	tmp = vga_inb(par, IS1_R);
+	vga_inb(par, IS1_R);
 	vga_outb(par, ATT_IW, idx);
 	vga_outb(par, ATT_IW, val);
 }

From patchwork Sat Nov 28 22:40:59 2020
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
X-Patchwork-Submitter: Sam Ravnborg <sam@ravnborg.org>
X-Patchwork-Id: 334547
Return-Path: <linux-fbdev-owner@kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
 aws-us-west-2-korg-lkml-1.web.codeaurora.org
X-Spam-Level: 
X-Spam-Status: No, score=-16.7 required=3.0 tests=BAYES_00,DKIM_SIGNED,
 DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,
 INCLUDES_PATCH, 
 MAILING_LIST_MULTI, SPF_HELO_NONE, SPF_PASS, URIBL_BLOCKED,
 USER_AGENT_GIT
 autolearn=unavailable autolearn_force=no version=3.4.0
Received: from mail.kernel.org (mail.kernel.org [198.145.29.99])
 by smtp.lore.kernel.org (Postfix) with ESMTP id 30B64C83010
 for <linux-fbdev@archiver.kernel.org>;
 Sat, 28 Nov 2020 22:43:01 +0000 (UTC)
Received: from vger.kernel.org (vger.kernel.org [23.128.96.18])
 by mail.kernel.org (Postfix) with ESMTP id F013420702
 for <linux-fbdev@archiver.kernel.org>;
 Sat, 28 Nov 2020 22:43:00 +0000 (UTC)
Authentication-Results: mail.kernel.org;
 dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com
 header.b="l+e7aw5u"
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
 id S2387999AbgK1Wm5 (ORCPT <rfc822; linux-fbdev@archiver.kernel.org>);
 Sat, 28 Nov 2020 17:42:57 -0500
Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49336 "EHLO
 lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by
 vger.kernel.org with ESMTP id S2387814AbgK1Wm4 (ORCPT
 <rfc822;linux-fbdev@vger.kernel.org>);
 Sat, 28 Nov 2020 17:42:56 -0500
Received: from mail-lf1-x144.google.com (mail-lf1-x144.google.com
 [IPv6:2a00:1450:4864:20::144])
 by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B5546C061A51
 for <linux-fbdev@vger.kernel.org>;
 Sat, 28 Nov 2020 14:41:48 -0800 (PST)
Received: by mail-lf1-x144.google.com with SMTP id a9so12760847lfh.2
 for <linux-fbdev@vger.kernel.org>;
 Sat, 28 Nov 2020 14:41:48 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;
 h=sender:from:to:cc:subject:date:message-id:in-reply-to:references
 :mime-version:content-transfer-encoding;
 bh=GO4HyonQKM+uiRKyJhgt5Ae8eU+jCIwu9BQ+Y1bEdq0=;
 b=l+e7aw5uXxHSu6BWfxEs9s+vt+LQqdRgEY7AVwx/9rFVC/UlPyCplyoadMVzY4btdI
 wWfAztM2iw9Zjnb5iyJoqjibcPyZSoK+W8uageWe9XEX5uaH6exFHhuoy4mIiwWd7i/H
 NAp90wUPSvDWPfpcfFWzbxBqAJ3T7M4MVNRu6AOixDEjfgEzAieEF5Ivx9tnLj2iux12
 IOLUuQ0fNyeQiFv2cInR4CBBkQHkUD0jULK1e9o1q74jpi1BLUq3CoHJILRlnWqKln3D
 kUaBSSoXiDSHmJZmVUkZwzakyojzy3AXh2bymPJA2b53gUPL/pGPOBjuc0YkC5LcaClc
 DkGA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20161025;
 h=x-gm-message-state:sender:from:to:cc:subject:date:message-id
 :in-reply-to:references:mime-version:content-transfer-encoding;
 bh=GO4HyonQKM+uiRKyJhgt5Ae8eU+jCIwu9BQ+Y1bEdq0=;
 b=JxGGQnLs1yEI7X+wRyoYxeOrVcJvajlrEIT3CbKtzN3bafZ7hAhoyyLZaqYFkDdE1v
 7r0aJBjtlBvnbu/HvH0DGT7+KC8P6NRgZ1BawMdbYrTGWBvtPpjvpfTjCMflFIkM1CNT
 4dt6s4s/Gc4I+h8MBLY1Nwf3bAQIKzk3b9Csfj6rdBYHdbnLz4Jy+9Hmib6sHX/Aaw6p
 fPg1N273AfH9q1RdCVyC4KLRcAJHcNNJq6otVGcA57iXPdy2/hsi52s3w3MVucpbUuvv
 bDgOZRw4a0jOrAbqmeEgceZFFI7ChAq4arH3fx0MZTFwW+RQp0HIreuFsejHQ8T9gKV6
 gq3w==
X-Gm-Message-State: AOAM531u7ztuANrk/U7klWytc0BFbBSazkZutD0nTF+Lk9x3lyKAKMqp
 y91Evg3uBnqRrxHIKIZ0CC2FYR+HEbZR0A==
X-Google-Smtp-Source: ABdhPJzf7rpIocaqr7UuHf7lkRCgNvHSRQYgfFjw/JeQSkuWTfMrys3Za/nY803MZlmSagJSSAnR0w==
X-Received: by 2002:a19:4815:: with SMTP id v21mr5654157lfa.368.1606603307034; 
 Sat, 28 Nov 2020 14:41:47 -0800 (PST)
Received: from saturn.localdomain ([2a00:fd00:8060:1c00:a4c7:9ff9:a160:aad0])
 by smtp.gmail.com with ESMTPSA id
 w21sm1236857lff.280.2020.11.28.14.41.45
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Sat, 28 Nov 2020 14:41:46 -0800 (PST)
Sender: Sam Ravnborg <sam.ravnborg@gmail.com>
From: Sam Ravnborg <sam@ravnborg.org>
To: linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org,
 Lee Jones <lee.jones@linaro.org>
Cc: Aditya Pakki <pakki001@umn.edu>,
 Alexander Klimov <grandmaster@al2klimov.de>,
 Alex Dewar <alex.dewar90@gmail.com>, Antonino Daplas <adaplas@gmail.com>,
 Arnd Bergmann <arnd@arndb.de>,
 Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
 Benjamin Herrenschmidt <benh@kernel.crashing.org>,
 Daniel Vetter <daniel.vetter@ffwll.ch>, Evgeny Novikov <novikov@ispras.ru>,
 Florian Tobias Schandinat <FlorianSchandinat@gmx.de>,
 George Kennedy <george.kennedy@oracle.com>,
 Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
 Gustavo Silva <gustavoars@kernel.org>,
 Jani Nikula <jani.nikula@intel.com>, Jason Yan <yanaijie@huawei.com>,
 Jingoo Han <jingoohan1@gmail.com>, Jiri Slaby <jirislaby@kernel.org>,
 Joe Perches <joe@perches.com>,
 Kristoffer Ericson <kristoffer.ericson@gmail.com>,
 Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
 Mike Rapoport <rppt@kernel.org>,
 Nathan Chancellor <natechancellor@gmail.com>,
 Peilin Ye <yepeilin.cs@gmail.com>, Peter Rosin <peda@axentia.se>,
 Qilong Zhang <zhangqilong3@huawei.com>,
 Randy Dunlap <rdunlap@infradead.org>,
 Saeed Mirzamohammadi <saeed.mirzamohammadi@oracle.com>,
 Sam Ravnborg <sam@ravnborg.org>,
 Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>,
 Thomas Winischhofer <thomas@winischhofer.net>,
 Thomas Zimemrmann <tzimmermann@suse.de>,
 Vaibhav Gupta <vaibhavgupta40@gmail.com>,
 Xiaofei Tan <tanxiaofei@huawei.com>
Subject: [PATCH v2 13/28] video: fbdev: riva: Fix kernel-doc and set but not
 used warnings
Date: Sat, 28 Nov 2020 23:40:59 +0100
Message-Id: <20201128224114.1033617-14-sam@ravnborg.org>
X-Mailer: git-send-email 2.27.0
In-Reply-To: <20201128224114.1033617-1-sam@ravnborg.org>
References: <20201128224114.1033617-1-sam@ravnborg.org>
MIME-Version: 1.0
Precedence: bulk
List-ID: <linux-fbdev.vger.kernel.org>
X-Mailing-List: linux-fbdev@vger.kernel.org

Fix W=1 warnings:
- Fix kernel-doc
- Drop unused variables/code

v2:
  - Updated subject (Lee)

Signed-off-by: Sam Ravnborg <sam@ravnborg.org>
Cc: Antonino Daplas <adaplas@gmail.com>
Cc: linux-fbdev@vger.kernel.org
Cc: Lee Jones <lee.jones@linaro.org>
---
 drivers/video/fbdev/riva/fbdev.c   |  9 ++++-----
 drivers/video/fbdev/riva/riva_hw.c | 28 ++++++++--------------------
 2 files changed, 12 insertions(+), 25 deletions(-)

diff --git a/drivers/video/fbdev/riva/fbdev.c b/drivers/video/fbdev/riva/fbdev.c
index ce55b9d2e862..55554b0433cb 100644
--- a/drivers/video/fbdev/riva/fbdev.c
+++ b/drivers/video/fbdev/riva/fbdev.c
@@ -464,7 +464,7 @@ static inline void reverse_order(u32 *l)
 
 /**
  * rivafb_load_cursor_image - load cursor image to hardware
- * @data: address to monochrome bitmap (1 = foreground color, 0 = background)
+ * @data8: address to monochrome bitmap (1 = foreground color, 0 = background)
  * @par:  pointer to private data
  * @w:    width of cursor image in pixels
  * @h:    height of cursor image in scanlines
@@ -843,9 +843,9 @@ static void riva_update_var(struct fb_var_screeninfo *var,
 /**
  * rivafb_do_maximize - 
  * @info: pointer to fb_info object containing info for current riva board
- * @var:
- * @nom:
- * @den:
+ * @var: standard kernel fb changeable data
+ * @nom: nom
+ * @den: den
  *
  * DESCRIPTION:
  * .
@@ -1214,7 +1214,6 @@ static int rivafb_set_par(struct fb_info *info)
 /**
  * rivafb_pan_display
  * @var: standard kernel fb changeable data
- * @con: TODO
  * @info: pointer to fb_info object containing info for current riva board
  *
  * DESCRIPTION:
diff --git a/drivers/video/fbdev/riva/riva_hw.c b/drivers/video/fbdev/riva/riva_hw.c
index bcf9c4b4de31..8b829b720064 100644
--- a/drivers/video/fbdev/riva/riva_hw.c
+++ b/drivers/video/fbdev/riva/riva_hw.c
@@ -836,17 +836,17 @@ static void nv10CalcArbitration
     nv10_sim_state *arb
 )
 {
-    int data, pagemiss, cas,width, video_enable, bpp;
-    int nvclks, mclks, pclks, vpagemiss, crtpagemiss, vbs;
-    int nvclk_fill, us_extra;
+    int data, pagemiss, width, video_enable, bpp;
+    int nvclks, mclks, pclks, vpagemiss, crtpagemiss;
+    int nvclk_fill;
     int found, mclk_extra, mclk_loop, cbs, m1;
     int mclk_freq, pclk_freq, nvclk_freq, mp_enable;
-    int us_m, us_m_min, us_n, us_p, video_drain_rate, crtc_drain_rate;
-    int vus_m, vus_n, vus_p;
-    int vpm_us, us_video, vlwm, cpm_us, us_crt,clwm;
+    int us_m, us_m_min, us_n, us_p, crtc_drain_rate;
+    int vus_m;
+    int vpm_us, us_video, cpm_us, us_crt,clwm;
     int clwm_rnd_down;
-    int craw, m2us, us_pipe, us_pipe_min, vus_pipe, p1clk, p2;
-    int pclks_2_top_fifo, min_mclk_extra;
+    int m2us, us_pipe_min, p1clk, p2;
+    int min_mclk_extra;
     int us_min_mclk_extra;
 
     fifo->valid = 1;
@@ -854,16 +854,13 @@ static void nv10CalcArbitration
     mclk_freq = arb->mclk_khz;
     nvclk_freq = arb->nvclk_khz;
     pagemiss = arb->mem_page_miss;
-    cas = arb->mem_latency;
     width = arb->memory_width/64;
     video_enable = arb->enable_video;
     bpp = arb->pix_bpp;
     mp_enable = arb->enable_mp;
     clwm = 0;
-    vlwm = 1024;
 
     cbs = 512;
-    vbs = 512;
 
     pclks = 4; /* lwm detect. */
 
@@ -924,17 +921,11 @@ static void nv10CalcArbitration
       us_min_mclk_extra = min_mclk_extra *1000*1000 / mclk_freq;
       us_n = nvclks*1000*1000 / nvclk_freq;/* nvclk latency in us */
       us_p = pclks*1000*1000 / pclk_freq;/* nvclk latency in us */
-      us_pipe = us_m + us_n + us_p;
       us_pipe_min = us_m_min + us_n + us_p;
-      us_extra = 0;
 
       vus_m = mclk_loop *1000*1000 / mclk_freq; /* Mclk latency in us */
-      vus_n = (4)*1000*1000 / nvclk_freq;/* nvclk latency in us */
-      vus_p = 0*1000*1000 / pclk_freq;/* pclk latency in us */
-      vus_pipe = vus_m + vus_n + vus_p;
 
       if(video_enable) {
-        video_drain_rate = pclk_freq * 4; /* MB/s */
         crtc_drain_rate = pclk_freq * bpp/8; /* MB/s */
 
         vpagemiss = 1; /* self generating page miss */
@@ -993,7 +984,6 @@ static void nv10CalcArbitration
               else if(crtc_drain_rate * 100  >= nvclk_fill * 98) {
                   clwm = 1024;
                   cbs = 512;
-                  us_extra = (cbs * 1000 * 1000)/ (8*width)/mclk_freq ;
               }
           }
       }
@@ -1010,7 +1000,6 @@ static void nv10CalcArbitration
 
       m1 = clwm + cbs -  1024; /* Amount of overfill */
       m2us = us_pipe_min + us_min_mclk_extra;
-      pclks_2_top_fifo = (1024-clwm)/(8*width);
 
       /* pclk cycles to drain */
       p1clk = m2us * pclk_freq/(1000*1000); 
@@ -1038,7 +1027,6 @@ static void nv10CalcArbitration
               min_mclk_extra--;
         }
       }
-      craw = clwm;
 
       if(clwm < (1024-cbs+8)) clwm = 1024-cbs+8;
       data = (int)(clwm);

From patchwork Sat Nov 28 22:41:00 2020
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
X-Patchwork-Submitter: Sam Ravnborg <sam@ravnborg.org>
X-Patchwork-Id: 334261
Return-Path: <linux-fbdev-owner@kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
 aws-us-west-2-korg-lkml-1.web.codeaurora.org
X-Spam-Level: 
X-Spam-Status: No, score=-16.7 required=3.0 tests=BAYES_00,DKIM_SIGNED,
 DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,
 INCLUDES_PATCH, 
 MAILING_LIST_MULTI, SPF_HELO_NONE, SPF_PASS, URIBL_BLOCKED,
 USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0
Received: from mail.kernel.org (mail.kernel.org [198.145.29.99])
 by smtp.lore.kernel.org (Postfix) with ESMTP id C616DC63777
 for <linux-fbdev@archiver.kernel.org>;
 Sat, 28 Nov 2020 22:43:03 +0000 (UTC)
Received: from vger.kernel.org (vger.kernel.org [23.128.96.18])
 by mail.kernel.org (Postfix) with ESMTP id 912D320702
 for <linux-fbdev@archiver.kernel.org>;
 Sat, 28 Nov 2020 22:43:03 +0000 (UTC)
Authentication-Results: mail.kernel.org;
 dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com
 header.b="jw0XiTnG"
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
 id S2388006AbgK1WnD (ORCPT <rfc822; linux-fbdev@archiver.kernel.org>);
 Sat, 28 Nov 2020 17:43:03 -0500
Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49338 "EHLO
 lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by
 vger.kernel.org with ESMTP id S2387814AbgK1WnC (ORCPT
 <rfc822;linux-fbdev@vger.kernel.org>);
 Sat, 28 Nov 2020 17:43:02 -0500
Received: from mail-lf1-x144.google.com (mail-lf1-x144.google.com
 [IPv6:2a00:1450:4864:20::144])
 by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 66C58C061A52
 for <linux-fbdev@vger.kernel.org>;
 Sat, 28 Nov 2020 14:41:50 -0800 (PST)
Received: by mail-lf1-x144.google.com with SMTP id u18so12724904lfd.9
 for <linux-fbdev@vger.kernel.org>;
 Sat, 28 Nov 2020 14:41:50 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;
 h=sender:from:to:cc:subject:date:message-id:in-reply-to:references
 :mime-version:content-transfer-encoding;
 bh=dJAdUrz4ca7tfhiVcvgtW18I/nrA8jkf6C7iRqjMNko=;
 b=jw0XiTnG1d1FmK/nuR/ygglGF41RFTNhbtqRR4OgEIBNX7fGeJyhCvlk/0UlZRGKhB
 hKpP8/sw22FxPKeVQnZXQTW3RcdeEsePU+TPneGrAY0HjyODWJqvkev+48AE+hMGHm5W
 eRm2UC+/iJNksDrQqhipr6yJhi0Vu3fyqdS+/buw7s9W2v8X8rtTtPDMNG1oPx5UxN9A
 DC0eByQ8YOtISYigmNx6DkpQyqREe+gFGr8aw4FOZS1rkq3bYIw0qJs1WX9/XdrbmAia
 LZ0ksCOKhZV7S2ujB+/VL2D+N/NV4dhmvHa/Sf55BIwWXlWB2f6QjbtQJd18M8dx+aUx
 08BA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20161025;
 h=x-gm-message-state:sender:from:to:cc:subject:date:message-id
 :in-reply-to:references:mime-version:content-transfer-encoding;
 bh=dJAdUrz4ca7tfhiVcvgtW18I/nrA8jkf6C7iRqjMNko=;
 b=JNAEoy4L7w96Hc7W00UWnezn7nxNl114zm4YhcjTlP7OYYEAqUJWF3yzAvN+z/vNmo
 qGkUImyA5WZrzm92nE02jJowXMjWV4Qf+MVeOGpab6DCZjpojwThFjBcasA7nrDB6+jX
 EvOViu4VqCq5tLjgcqSKjDrkHMN7DTkFf7sgQTpDRkfz1oI++rN6ep8QGTzTMgTe7hL6
 z3OBBtdiwT+akyFYGY47BDNEwE/y4QGq4HE80CA0vdroZemWUYK76hWAaBEP3tUTCEhF
 rKzzr1sfW1NFN2ynYf9S6fdDvVSngOHv9vkeFbjLZZSfc28EAYsJee3/RoNMmUTynMvU
 j4XQ==
X-Gm-Message-State: AOAM530UshfMPlv9y51XEWJ+Z380en94kVX08Ady4G+ioT6DYKEg4ND6
 +R/8678TG9KjC5zHL0n7kK/x+FNYFQYq2g==
X-Google-Smtp-Source: ABdhPJxVShbJ+jm3V2ncKID7nCBgc+IaHjlX3fKlU4tIxi1G3MqUw0FNx7BKk5v9g3hGKwWd3UTV4w==
X-Received: by 2002:a19:ac02:: with SMTP id g2mr6371043lfc.536.1606603308761; 
 Sat, 28 Nov 2020 14:41:48 -0800 (PST)
Received: from saturn.localdomain ([2a00:fd00:8060:1c00:a4c7:9ff9:a160:aad0])
 by smtp.gmail.com with ESMTPSA id
 w21sm1236857lff.280.2020.11.28.14.41.47
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Sat, 28 Nov 2020 14:41:48 -0800 (PST)
Sender: Sam Ravnborg <sam.ravnborg@gmail.com>
From: Sam Ravnborg <sam@ravnborg.org>
To: linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org,
 Lee Jones <lee.jones@linaro.org>
Cc: Aditya Pakki <pakki001@umn.edu>,
 Alexander Klimov <grandmaster@al2klimov.de>,
 Alex Dewar <alex.dewar90@gmail.com>, Antonino Daplas <adaplas@gmail.com>,
 Arnd Bergmann <arnd@arndb.de>,
 Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
 Benjamin Herrenschmidt <benh@kernel.crashing.org>,
 Daniel Vetter <daniel.vetter@ffwll.ch>, Evgeny Novikov <novikov@ispras.ru>,
 Florian Tobias Schandinat <FlorianSchandinat@gmx.de>,
 George Kennedy <george.kennedy@oracle.com>,
 Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
 Gustavo Silva <gustavoars@kernel.org>,
 Jani Nikula <jani.nikula@intel.com>, Jason Yan <yanaijie@huawei.com>,
 Jingoo Han <jingoohan1@gmail.com>, Jiri Slaby <jirislaby@kernel.org>,
 Joe Perches <joe@perches.com>,
 Kristoffer Ericson <kristoffer.ericson@gmail.com>,
 Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
 Mike Rapoport <rppt@kernel.org>,
 Nathan Chancellor <natechancellor@gmail.com>,
 Peilin Ye <yepeilin.cs@gmail.com>, Peter Rosin <peda@axentia.se>,
 Qilong Zhang <zhangqilong3@huawei.com>,
 Randy Dunlap <rdunlap@infradead.org>,
 Saeed Mirzamohammadi <saeed.mirzamohammadi@oracle.com>,
 Sam Ravnborg <sam@ravnborg.org>,
 Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>,
 Thomas Winischhofer <thomas@winischhofer.net>,
 Thomas Zimemrmann <tzimmermann@suse.de>,
 Vaibhav Gupta <vaibhavgupta40@gmail.com>,
 Xiaofei Tan <tanxiaofei@huawei.com>
Subject: [PATCH v2 14/28] video: fbdev: pm2fb: Fix kernel-doc warnings
Date: Sat, 28 Nov 2020 23:41:00 +0100
Message-Id: <20201128224114.1033617-15-sam@ravnborg.org>
X-Mailer: git-send-email 2.27.0
In-Reply-To: <20201128224114.1033617-1-sam@ravnborg.org>
References: <20201128224114.1033617-1-sam@ravnborg.org>
MIME-Version: 1.0
Precedence: bulk
List-ID: <linux-fbdev.vger.kernel.org>
X-Mailing-List: linux-fbdev@vger.kernel.org

Fixed a few kernel-doc issues to fix the warnings.

v2:
  - Updated subject (Lee)

Signed-off-by: Sam Ravnborg <sam@ravnborg.org>
Cc: Sam Ravnborg <sam@ravnborg.org>
Cc: "Gustavo A. R. Silva" <gustavoars@kernel.org>
Cc: Randy Dunlap <rdunlap@infradead.org>
Cc: Arnd Bergmann <arnd@arndb.de>
Cc: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
Cc: Jani Nikula <jani.nikula@intel.com>
Cc: Lee Jones <lee.jones@linaro.org>
Acked-by: Thomas Zimmermann <tzimmermann@suse.de>
---
 drivers/video/fbdev/pm2fb.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/video/fbdev/pm2fb.c b/drivers/video/fbdev/pm2fb.c
index 27893fa139b0..c68725eebee3 100644
--- a/drivers/video/fbdev/pm2fb.c
+++ b/drivers/video/fbdev/pm2fb.c
@@ -1508,8 +1508,8 @@ static const struct fb_ops pm2fb_ops = {
  *
  * Initialise and allocate resource for PCI device.
  *
- * @param	pdev	PCI device.
- * @param	id	PCI device ID.
+ * @pdev:	PCI device.
+ * @id:		PCI device ID.
  */
 static int pm2fb_probe(struct pci_dev *pdev, const struct pci_device_id *id)
 {
@@ -1715,7 +1715,7 @@ static int pm2fb_probe(struct pci_dev *pdev, const struct pci_device_id *id)
  *
  * Release all device resources.
  *
- * @param	pdev	PCI device to clean up.
+ * @pdev:	PCI device to clean up.
  */
 static void pm2fb_remove(struct pci_dev *pdev)
 {
@@ -1756,7 +1756,7 @@ MODULE_DEVICE_TABLE(pci, pm2fb_id_table);
 
 
 #ifndef MODULE
-/**
+/*
  * Parse user specified options.
  *
  * This is, comma-separated options following `video=pm2fb:'.

From patchwork Sat Nov 28 22:41:01 2020
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
X-Patchwork-Submitter: Sam Ravnborg <sam@ravnborg.org>
X-Patchwork-Id: 334260
Return-Path: <linux-fbdev-owner@kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
 aws-us-west-2-korg-lkml-1.web.codeaurora.org
X-Spam-Level: 
X-Spam-Status: No, score=-16.7 required=3.0 tests=BAYES_00,DKIM_SIGNED,
 DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,
 INCLUDES_PATCH, 
 MAILING_LIST_MULTI, SPF_HELO_NONE, SPF_PASS, URIBL_BLOCKED,
 USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0
Received: from mail.kernel.org (mail.kernel.org [198.145.29.99])
 by smtp.lore.kernel.org (Postfix) with ESMTP id 4784BC64E7B
 for <linux-fbdev@archiver.kernel.org>;
 Sat, 28 Nov 2020 22:43:06 +0000 (UTC)
Received: from vger.kernel.org (vger.kernel.org [23.128.96.18])
 by mail.kernel.org (Postfix) with ESMTP id 12FDC20702
 for <linux-fbdev@archiver.kernel.org>;
 Sat, 28 Nov 2020 22:43:06 +0000 (UTC)
Authentication-Results: mail.kernel.org;
 dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com
 header.b="NGdAgss+"
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
 id S2388283AbgK1WnF (ORCPT <rfc822; linux-fbdev@archiver.kernel.org>);
 Sat, 28 Nov 2020 17:43:05 -0500
Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49286 "EHLO
 lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by
 vger.kernel.org with ESMTP id S2387814AbgK1WnE (ORCPT
 <rfc822;linux-fbdev@vger.kernel.org>);
 Sat, 28 Nov 2020 17:43:04 -0500
Received: from mail-lj1-x242.google.com (mail-lj1-x242.google.com
 [IPv6:2a00:1450:4864:20::242])
 by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 672C8C061A53
 for <linux-fbdev@vger.kernel.org>;
 Sat, 28 Nov 2020 14:41:52 -0800 (PST)
Received: by mail-lj1-x242.google.com with SMTP id r18so10599478ljc.2
 for <linux-fbdev@vger.kernel.org>;
 Sat, 28 Nov 2020 14:41:52 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;
 h=sender:from:to:cc:subject:date:message-id:in-reply-to:references
 :mime-version:content-transfer-encoding;
 bh=RGE3ZlcEoP1SxPsiy77Qp2XR/URo401XNflyUfm64IE=;
 b=NGdAgss+FahUORm2x4DH9YzsRqcLgj0lXXnanlCNTpQqTfgaHVlZbqLKRsMQzZYxr9
 zoNveiLLa1iWP5JzNJVbw2lOPyrYB0Sr9ombxq1voQHGB0Oo0GL1KsoUzlrx5S5Zj56f
 vBruRLtiEHiE1X6vaJoYrf7Du6qhuS43Nd6BzkBFhTZF4pLxxowsP4uUsT58x6nym+Ky
 AznbSHvNNjj+pDf4WbGInBM6Ze0G+zZbUtGflnyzFIGPHXIiuUqYL8MYj+aFqwOMzb0e
 HT14qrtojp/d8CjY0HP3bmUNZP/E3NNfrZqdf5SXo4FDLbagOAzajk3oioHmWKIFT+FU
 UTXw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20161025;
 h=x-gm-message-state:sender:from:to:cc:subject:date:message-id
 :in-reply-to:references:mime-version:content-transfer-encoding;
 bh=RGE3ZlcEoP1SxPsiy77Qp2XR/URo401XNflyUfm64IE=;
 b=jC/hoatx0m3F5WLTokq3cE7r8NlxTpCfGj50A6pWnP1ekb8NwvuFpkFb+57DLWRzFB
 KnpledrXCumFNgvAb3g+MXNBKSTUxd/tlUbXZUs/u+Iy/k5xIetB6ohz6EQEjqNCvz2y
 EaBsrPRHmx0Oj5Qt6PYT6zcPqLyPVs/7LMmn/vrC7ic5upzcd+ZhwLv36ARwc8QdUTBx
 OF+k45Aw/vvzH8F6Qfy7ANzj3KLWo44lBw4UkDhB1OcsOhzKbYJFRlsZS84Ylm0M9o3F
 LbbLe8dk2gfP7M4AjoI/9IScKAQkZyozqcjoE0SZZXH71vivWa7mMMg3marqsQbehg9/
 A8hA==
X-Gm-Message-State: AOAM532UGKl3KYLL9K46ch7Y00rl2c+jub6GWQ3yl5IBoH8CuNCVEN2e
 0EXAv8EifhDyBjQIIkb3LJZJJdQ6Wj20RA==
X-Google-Smtp-Source: ABdhPJxpScsB3nbNJ7Ym+OnGnfIL7YQp8eOIXX03B8zty9uORsv85KSdCb7dN3BdLWsJa159Bj2Bxg==
X-Received: by 2002:a2e:99c8:: with SMTP id l8mr6101773ljj.469.1606603310634; 
 Sat, 28 Nov 2020 14:41:50 -0800 (PST)
Received: from saturn.localdomain ([2a00:fd00:8060:1c00:a4c7:9ff9:a160:aad0])
 by smtp.gmail.com with ESMTPSA id
 w21sm1236857lff.280.2020.11.28.14.41.48
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Sat, 28 Nov 2020 14:41:50 -0800 (PST)
Sender: Sam Ravnborg <sam.ravnborg@gmail.com>
From: Sam Ravnborg <sam@ravnborg.org>
To: linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org,
 Lee Jones <lee.jones@linaro.org>
Cc: Aditya Pakki <pakki001@umn.edu>,
 Alexander Klimov <grandmaster@al2klimov.de>,
 Alex Dewar <alex.dewar90@gmail.com>, Antonino Daplas <adaplas@gmail.com>,
 Arnd Bergmann <arnd@arndb.de>,
 Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
 Benjamin Herrenschmidt <benh@kernel.crashing.org>,
 Daniel Vetter <daniel.vetter@ffwll.ch>, Evgeny Novikov <novikov@ispras.ru>,
 Florian Tobias Schandinat <FlorianSchandinat@gmx.de>,
 George Kennedy <george.kennedy@oracle.com>,
 Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
 Gustavo Silva <gustavoars@kernel.org>,
 Jani Nikula <jani.nikula@intel.com>, Jason Yan <yanaijie@huawei.com>,
 Jingoo Han <jingoohan1@gmail.com>, Jiri Slaby <jirislaby@kernel.org>,
 Joe Perches <joe@perches.com>,
 Kristoffer Ericson <kristoffer.ericson@gmail.com>,
 Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
 Mike Rapoport <rppt@kernel.org>,
 Nathan Chancellor <natechancellor@gmail.com>,
 Peilin Ye <yepeilin.cs@gmail.com>, Peter Rosin <peda@axentia.se>,
 Qilong Zhang <zhangqilong3@huawei.com>,
 Randy Dunlap <rdunlap@infradead.org>,
 Saeed Mirzamohammadi <saeed.mirzamohammadi@oracle.com>,
 Sam Ravnborg <sam@ravnborg.org>,
 Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>,
 Thomas Winischhofer <thomas@winischhofer.net>,
 Thomas Zimemrmann <tzimmermann@suse.de>,
 Vaibhav Gupta <vaibhavgupta40@gmail.com>,
 Xiaofei Tan <tanxiaofei@huawei.com>,
 Andrew Morton <akpm@linux-foundation.org>
Subject: [PATCH v2 15/28] video: fbdev: neofb: Fix set but not used warning
 for CursorMem
Date: Sat, 28 Nov 2020 23:41:01 +0100
Message-Id: <20201128224114.1033617-16-sam@ravnborg.org>
X-Mailer: git-send-email 2.27.0
In-Reply-To: <20201128224114.1033617-1-sam@ravnborg.org>
References: <20201128224114.1033617-1-sam@ravnborg.org>
MIME-Version: 1.0
Precedence: bulk
List-ID: <linux-fbdev.vger.kernel.org>
X-Mailing-List: linux-fbdev@vger.kernel.org

Fix W=1 warnings by removing unused code

v2:
  - Updated subject (Lee)

Signed-off-by: Sam Ravnborg <sam@ravnborg.org>
Cc: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
Cc: Sam Ravnborg <sam@ravnborg.org>
Cc: Andrew Morton <akpm@linux-foundation.org>
Cc: Evgeny Novikov <novikov@ispras.ru>
Cc: Jani Nikula <jani.nikula@intel.com>
Cc: Mike Rapoport <rppt@kernel.org>
Cc: Lee Jones <lee.jones@linaro.org>
---
 drivers/video/fbdev/neofb.c | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/drivers/video/fbdev/neofb.c b/drivers/video/fbdev/neofb.c
index 09a20d4ab35f..c0f4f402da3f 100644
--- a/drivers/video/fbdev/neofb.c
+++ b/drivers/video/fbdev/neofb.c
@@ -1843,7 +1843,6 @@ static int neo_init_hw(struct fb_info *info)
 	struct neofb_par *par = info->par;
 	int videoRam = 896;
 	int maxClock = 65000;
-	int CursorMem = 1024;
 	int CursorOff = 0x100;
 
 	DBG("neo_init_hw");
@@ -1895,19 +1894,16 @@ static int neo_init_hw(struct fb_info *info)
 	case FB_ACCEL_NEOMAGIC_NM2070:
 	case FB_ACCEL_NEOMAGIC_NM2090:
 	case FB_ACCEL_NEOMAGIC_NM2093:
-		CursorMem = 2048;
 		CursorOff = 0x100;
 		break;
 	case FB_ACCEL_NEOMAGIC_NM2097:
 	case FB_ACCEL_NEOMAGIC_NM2160:
-		CursorMem = 1024;
 		CursorOff = 0x100;
 		break;
 	case FB_ACCEL_NEOMAGIC_NM2200:
 	case FB_ACCEL_NEOMAGIC_NM2230:
 	case FB_ACCEL_NEOMAGIC_NM2360:
 	case FB_ACCEL_NEOMAGIC_NM2380:
-		CursorMem = 1024;
 		CursorOff = 0x1000;
 
 		par->neo2200 = (Neo2200 __iomem *) par->mmio_vbase;

From patchwork Sat Nov 28 22:41:02 2020
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
X-Patchwork-Submitter: Sam Ravnborg <sam@ravnborg.org>
X-Patchwork-Id: 334256
Return-Path: <linux-fbdev-owner@kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
 aws-us-west-2-korg-lkml-1.web.codeaurora.org
X-Spam-Level: 
X-Spam-Status: No, score=-16.7 required=3.0 tests=BAYES_00,DKIM_SIGNED,
 DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,
 INCLUDES_PATCH, 
 MAILING_LIST_MULTI, SPF_HELO_NONE, SPF_PASS, URIBL_BLOCKED,
 USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0
Received: from mail.kernel.org (mail.kernel.org [198.145.29.99])
 by smtp.lore.kernel.org (Postfix) with ESMTP id 446ACC63798
 for <linux-fbdev@archiver.kernel.org>;
 Sat, 28 Nov 2020 22:43:32 +0000 (UTC)
Received: from vger.kernel.org (vger.kernel.org [23.128.96.18])
 by mail.kernel.org (Postfix) with ESMTP id 0C8ED20702
 for <linux-fbdev@archiver.kernel.org>;
 Sat, 28 Nov 2020 22:43:32 +0000 (UTC)
Authentication-Results: mail.kernel.org;
 dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com
 header.b="ceUf4brj"
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
 id S1730785AbgK1Wnb (ORCPT <rfc822; linux-fbdev@archiver.kernel.org>);
 Sat, 28 Nov 2020 17:43:31 -0500
Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49408 "EHLO
 lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by
 vger.kernel.org with ESMTP id S1729806AbgK1Wn3 (ORCPT
 <rfc822;linux-fbdev@vger.kernel.org>);
 Sat, 28 Nov 2020 17:43:29 -0500
Received: from mail-lf1-x144.google.com (mail-lf1-x144.google.com
 [IPv6:2a00:1450:4864:20::144])
 by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1F999C061A54
 for <linux-fbdev@vger.kernel.org>;
 Sat, 28 Nov 2020 14:41:54 -0800 (PST)
Received: by mail-lf1-x144.google.com with SMTP id a9so12761086lfh.2
 for <linux-fbdev@vger.kernel.org>;
 Sat, 28 Nov 2020 14:41:54 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;
 h=sender:from:to:cc:subject:date:message-id:in-reply-to:references
 :mime-version:content-transfer-encoding;
 bh=4zXtp5JJ5kL9W0YA7a9u1oFQEkf6mUNDsE89w8XSjbA=;
 b=ceUf4brj/n0hkaGfOYFJBYiH9gMwfM6dVxGXtjLzBxWUBrKdOiBcNBiwjbk6I+CgJ3
 gI3ZS4XqlBZrmis/msFG4cYvku2FAl7iT+pZd7mTwUN+sAvY3OKBBRI8R9jT3nIJnz7G
 Y/FXeJA1VgtIpovJ8bC2XO8Vnlg0CPuD4ZM9l35PmOSYNB1bQXK9UEHN4L7N79HhrjOP
 rIKTYGJ55Bze+4fEzcwZgzXaNWenxz1Ag47/z9ITXQIM1e9Jzek+YaNUqrBh9XmKyPAV
 QgbY8AzXHQZKAokd0sXKMHIrdzNHIcCwnfAp7pKAiG0Qss+kun1A28cwelQfUQqbkl8O
 dwSQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20161025;
 h=x-gm-message-state:sender:from:to:cc:subject:date:message-id
 :in-reply-to:references:mime-version:content-transfer-encoding;
 bh=4zXtp5JJ5kL9W0YA7a9u1oFQEkf6mUNDsE89w8XSjbA=;
 b=hIhm5Oi1sqal/pvJutdLPIJx95PIL/H26Tx+mdJmZoXk+o9u9rJU9A9eI+bEns3sIG
 ieiECImAUAn/eBnXWrs49PD026J1jMZpRUOq6fyG9o1OzJy6HQ26QhCDATjsDsQuFK6r
 arxAjKKPVCpEM8FhJ6qEd7NRbOfbrU/hFyqdtsIstaNIdCZvzKXnofzksVapFycxdSb/
 6KMhQcw+ku4H1uLfXUW6z7ZJQt8A7mRimqBYFTcoaKpV97df+X1EmWs70vyIxr31BUqU
 0aUiNO4q9NcJcd4PJ8ThH6DjY5t3IBUXr7VKuuBTZ6bt68xgC5k5Zu5wztVm3qaVrAXe
 J3yA==
X-Gm-Message-State: AOAM531tt0oC8uL/S7sW2OVlJWlBG6T/kLn8EvaYOn7KHzS+cQCQ5CNM
 iucn4bQ/L2OeKSzmlbfEppa4/KQikeq0rtQu
X-Google-Smtp-Source: ABdhPJxss28jpDvSr/X/2726RDiBKWZyfMpYr3Grt4ZkKPwJPMW1Lii9D2KCP4lz4rLxgbgJM2IM8g==
X-Received: by 2002:a19:8001:: with SMTP id b1mr6321877lfd.353.1606603312476; 
 Sat, 28 Nov 2020 14:41:52 -0800 (PST)
Received: from saturn.localdomain ([2a00:fd00:8060:1c00:a4c7:9ff9:a160:aad0])
 by smtp.gmail.com with ESMTPSA id
 w21sm1236857lff.280.2020.11.28.14.41.50
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Sat, 28 Nov 2020 14:41:52 -0800 (PST)
Sender: Sam Ravnborg <sam.ravnborg@gmail.com>
From: Sam Ravnborg <sam@ravnborg.org>
To: linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org,
 Lee Jones <lee.jones@linaro.org>
Cc: Aditya Pakki <pakki001@umn.edu>,
 Alexander Klimov <grandmaster@al2klimov.de>,
 Alex Dewar <alex.dewar90@gmail.com>, Antonino Daplas <adaplas@gmail.com>,
 Arnd Bergmann <arnd@arndb.de>,
 Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
 Benjamin Herrenschmidt <benh@kernel.crashing.org>,
 Daniel Vetter <daniel.vetter@ffwll.ch>, Evgeny Novikov <novikov@ispras.ru>,
 Florian Tobias Schandinat <FlorianSchandinat@gmx.de>,
 George Kennedy <george.kennedy@oracle.com>,
 Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
 Gustavo Silva <gustavoars@kernel.org>,
 Jani Nikula <jani.nikula@intel.com>, Jason Yan <yanaijie@huawei.com>,
 Jingoo Han <jingoohan1@gmail.com>, Jiri Slaby <jirislaby@kernel.org>,
 Joe Perches <joe@perches.com>,
 Kristoffer Ericson <kristoffer.ericson@gmail.com>,
 Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
 Mike Rapoport <rppt@kernel.org>,
 Nathan Chancellor <natechancellor@gmail.com>,
 Peilin Ye <yepeilin.cs@gmail.com>, Peter Rosin <peda@axentia.se>,
 Qilong Zhang <zhangqilong3@huawei.com>,
 Randy Dunlap <rdunlap@infradead.org>,
 Saeed Mirzamohammadi <saeed.mirzamohammadi@oracle.com>,
 Sam Ravnborg <sam@ravnborg.org>,
 Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>,
 Thomas Winischhofer <thomas@winischhofer.net>,
 Thomas Zimemrmann <tzimmermann@suse.de>,
 Vaibhav Gupta <vaibhavgupta40@gmail.com>,
 Xiaofei Tan <tanxiaofei@huawei.com>,
 Ferenc Bakonyi <fero@drama.obuda.kando.hu>,
 linux-nvidia@lists.surfsouth.com
Subject: [PATCH v2 16/28] video: fbdev: hgafb: Fix kernel-doc warnings
Date: Sat, 28 Nov 2020 23:41:02 +0100
Message-Id: <20201128224114.1033617-17-sam@ravnborg.org>
X-Mailer: git-send-email 2.27.0
In-Reply-To: <20201128224114.1033617-1-sam@ravnborg.org>
References: <20201128224114.1033617-1-sam@ravnborg.org>
MIME-Version: 1.0
Precedence: bulk
List-ID: <linux-fbdev.vger.kernel.org>
X-Mailing-List: linux-fbdev@vger.kernel.org

Fix kernel-doc comments.

v2:
  - Updated subject (Lee)

Signed-off-by: Sam Ravnborg <sam@ravnborg.org>
Cc: Ferenc Bakonyi <fero@drama.obuda.kando.hu>
Cc: linux-nvidia@lists.surfsouth.com
Cc: Lee Jones <lee.jones@linaro.org>
---
 drivers/video/fbdev/hgafb.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/video/fbdev/hgafb.c b/drivers/video/fbdev/hgafb.c
index a45fcff1461f..69af72937844 100644
--- a/drivers/video/fbdev/hgafb.c
+++ b/drivers/video/fbdev/hgafb.c
@@ -358,7 +358,7 @@ static int hga_card_detect(void)
 /**
  *	hgafb_open - open the framebuffer device
  *	@info:pointer to fb_info object containing info for current hga board
- *	@int:open by console system or userland.
+ *	@init:open by console system or userland.
  */
 
 static int hgafb_open(struct fb_info *info, int init)
@@ -372,7 +372,7 @@ static int hgafb_open(struct fb_info *info, int init)
 /**
  *	hgafb_open - open the framebuffer device
  *	@info:pointer to fb_info object containing info for current hga board
- *	@int:open by console system or userland.
+ *	@init:open by console system or userland.
  */
 
 static int hgafb_release(struct fb_info *info, int init)

From patchwork Sat Nov 28 22:41:03 2020
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
X-Patchwork-Submitter: Sam Ravnborg <sam@ravnborg.org>
X-Patchwork-Id: 334546
Return-Path: <linux-fbdev-owner@kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
 aws-us-west-2-korg-lkml-1.web.codeaurora.org
X-Spam-Level: 
X-Spam-Status: No, score=-16.7 required=3.0 tests=BAYES_00,DKIM_SIGNED,
 DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,
 INCLUDES_PATCH, 
 MAILING_LIST_MULTI, SPF_HELO_NONE, SPF_PASS, URIBL_BLOCKED,
 USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0
Received: from mail.kernel.org (mail.kernel.org [198.145.29.99])
 by smtp.lore.kernel.org (Postfix) with ESMTP id 51155C83012
 for <linux-fbdev@archiver.kernel.org>;
 Sat, 28 Nov 2020 22:43:01 +0000 (UTC)
Received: from vger.kernel.org (vger.kernel.org [23.128.96.18])
 by mail.kernel.org (Postfix) with ESMTP id 1E03720771
 for <linux-fbdev@archiver.kernel.org>;
 Sat, 28 Nov 2020 22:43:01 +0000 (UTC)
Authentication-Results: mail.kernel.org;
 dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com
 header.b="WSratFFt"
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
 id S2388003AbgK1Wm7 (ORCPT <rfc822; linux-fbdev@archiver.kernel.org>);
 Sat, 28 Nov 2020 17:42:59 -0500
Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49284 "EHLO
 lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by
 vger.kernel.org with ESMTP id S2387814AbgK1Wm6 (ORCPT
 <rfc822;linux-fbdev@vger.kernel.org>);
 Sat, 28 Nov 2020 17:42:58 -0500
Received: from mail-lf1-x141.google.com (mail-lf1-x141.google.com
 [IPv6:2a00:1450:4864:20::141])
 by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0878BC061A55
 for <linux-fbdev@vger.kernel.org>;
 Sat, 28 Nov 2020 14:41:56 -0800 (PST)
Received: by mail-lf1-x141.google.com with SMTP id u19so12752100lfr.7
 for <linux-fbdev@vger.kernel.org>;
 Sat, 28 Nov 2020 14:41:55 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;
 h=sender:from:to:cc:subject:date:message-id:in-reply-to:references
 :mime-version:content-transfer-encoding;
 bh=GX2d3CpgxJM36tqAcji4TF9AW0tELXUqa0FefTGKGkc=;
 b=WSratFFtrte4qjUbFg8xQAA6BVPAs2IyKsqMRnOQIDQGIrk/QEfbf7vQoIG+F6PFaE
 bHL2xZGJ53KoPsk5eeebn/EiGEL+0sQSATGEmLvqEf+OOaTz4qIuw0uStP36H2j8vzAx
 CqyoivsQCZFEqCmF7d5P4m+nJ5NxUSid3rmiuEyyaUn4E6z0TPGzGV0AgxE9PVVRmK0S
 ePHRG/qTw3Fq5fQy98aQauwSWFh1AyaJH4gB/wdxu0iPJxcBLMywNhlr9MkTG1FXPylN
 5B4ih+9iS9tBFHM7TBLFYfQ/q0SE9yK/M6c78cAHKoX1880iGpjeWywLXJSGegnCFnDc
 pHIA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20161025;
 h=x-gm-message-state:sender:from:to:cc:subject:date:message-id
 :in-reply-to:references:mime-version:content-transfer-encoding;
 bh=GX2d3CpgxJM36tqAcji4TF9AW0tELXUqa0FefTGKGkc=;
 b=bzN0KG4QaShm8lxSJAJo7331E3TbWV/j6JtIdjpm7UR6EkjBb9JFgW7SXu6vHrGLEM
 eI1ceNqVmvfi9SQMy9QyTU7+ZXo7MsORl95BHJrsdleG3sfM1neAX+8T86DzvP+w/CrK
 rxaWuLNC9Lo/OjMuq6xjROnjjVOV5m/+h2Jre2S7tKk7hkB7muZ8kroyxMfW0gBrdKoK
 Wy/xtQ4g6xvpZFiBYagUtsKsYj7q7OUj6/mnCUZSfPQeN4z+DnvAhx2iA8yu1vCKSoyr
 Xh0xB/6BkfQibQ/cQoAMYbQ2BgLHa11Ql/WAQmD7w+XGlpbdHtYntk8Ij0GYPP31m+L7
 coOw==
X-Gm-Message-State: AOAM533RZdhjWcpwAwdrYcRAt/nrfMyWNihcYkXmw8djwxKEZPFWYKrf
 GyuPftLb0tHFogS8AcHkvj/39/uZw6Yj7w==
X-Google-Smtp-Source: ABdhPJyYzVm54GMBy2SMwgj7Vizf5O6IZYm8/ahMTwfLskutoesZO7VJzcBldtutdNQrv4hcHdOPLQ==
X-Received: by 2002:a19:c70c:: with SMTP id x12mr6709305lff.474.1606603314364; 
 Sat, 28 Nov 2020 14:41:54 -0800 (PST)
Received: from saturn.localdomain ([2a00:fd00:8060:1c00:a4c7:9ff9:a160:aad0])
 by smtp.gmail.com with ESMTPSA id
 w21sm1236857lff.280.2020.11.28.14.41.52
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Sat, 28 Nov 2020 14:41:53 -0800 (PST)
Sender: Sam Ravnborg <sam.ravnborg@gmail.com>
From: Sam Ravnborg <sam@ravnborg.org>
To: linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org,
 Lee Jones <lee.jones@linaro.org>
Cc: Aditya Pakki <pakki001@umn.edu>,
 Alexander Klimov <grandmaster@al2klimov.de>,
 Alex Dewar <alex.dewar90@gmail.com>, Antonino Daplas <adaplas@gmail.com>,
 Arnd Bergmann <arnd@arndb.de>,
 Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
 Benjamin Herrenschmidt <benh@kernel.crashing.org>,
 Daniel Vetter <daniel.vetter@ffwll.ch>, Evgeny Novikov <novikov@ispras.ru>,
 Florian Tobias Schandinat <FlorianSchandinat@gmx.de>,
 George Kennedy <george.kennedy@oracle.com>,
 Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
 Gustavo Silva <gustavoars@kernel.org>,
 Jani Nikula <jani.nikula@intel.com>, Jason Yan <yanaijie@huawei.com>,
 Jingoo Han <jingoohan1@gmail.com>, Jiri Slaby <jirislaby@kernel.org>,
 Joe Perches <joe@perches.com>,
 Kristoffer Ericson <kristoffer.ericson@gmail.com>,
 Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
 Mike Rapoport <rppt@kernel.org>,
 Nathan Chancellor <natechancellor@gmail.com>,
 Peilin Ye <yepeilin.cs@gmail.com>, Peter Rosin <peda@axentia.se>,
 Qilong Zhang <zhangqilong3@huawei.com>,
 Randy Dunlap <rdunlap@infradead.org>,
 Saeed Mirzamohammadi <saeed.mirzamohammadi@oracle.com>,
 Sam Ravnborg <sam@ravnborg.org>,
 Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>,
 Thomas Winischhofer <thomas@winischhofer.net>,
 Thomas Zimemrmann <tzimmermann@suse.de>,
 Vaibhav Gupta <vaibhavgupta40@gmail.com>,
 Xiaofei Tan <tanxiaofei@huawei.com>
Subject: [PATCH v2 17/28] video: fbdev: tgafb: Fix kernel-doc and set but
 not used warnings
Date: Sat, 28 Nov 2020 23:41:03 +0100
Message-Id: <20201128224114.1033617-18-sam@ravnborg.org>
X-Mailer: git-send-email 2.27.0
In-Reply-To: <20201128224114.1033617-1-sam@ravnborg.org>
References: <20201128224114.1033617-1-sam@ravnborg.org>
MIME-Version: 1.0
Precedence: bulk
List-ID: <linux-fbdev.vger.kernel.org>
X-Mailing-List: linux-fbdev@vger.kernel.org

Fix W=1 warnings:
- Fix kernel-doc
- Drop unused code

v2:
  - Updated subject (Lee)

Signed-off-by: Sam Ravnborg <sam@ravnborg.org>
Cc: Sam Ravnborg <sam@ravnborg.org>
Cc: Jani Nikula <jani.nikula@intel.com>
Cc: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
Cc: Arnd Bergmann <arnd@arndb.de>
Cc: Joe Perches <joe@perches.com>
Cc: Lee Jones <lee.jones@linaro.org>
---
 drivers/video/fbdev/tgafb.c | 7 +++----
 1 file changed, 3 insertions(+), 4 deletions(-)

diff --git a/drivers/video/fbdev/tgafb.c b/drivers/video/fbdev/tgafb.c
index 666fbe2f671c..ae0cf5540636 100644
--- a/drivers/video/fbdev/tgafb.c
+++ b/drivers/video/fbdev/tgafb.c
@@ -555,7 +555,7 @@ tgafb_setcolreg(unsigned regno, unsigned red, unsigned green, unsigned blue,
 
 /**
  *      tgafb_blank - Optional function.  Blanks the display.
- *      @blank_mode: the blank mode we want.
+ *      @blank: the blank mode we want.
  *      @info: frame buffer structure that represents a single frame buffer
  */
 static int
@@ -837,7 +837,7 @@ tgafb_clut_imageblit(struct fb_info *info, const struct fb_image *image)
 	u32 *palette = ((u32 *)info->pseudo_palette);
 	unsigned long pos, line_length, i, j;
 	const unsigned char *data;
-	void __iomem *regs_base, *fb_base;
+	void __iomem *fb_base;
 
 	dx = image->dx;
 	dy = image->dy;
@@ -855,7 +855,6 @@ tgafb_clut_imageblit(struct fb_info *info, const struct fb_image *image)
 	if (dy + height > vyres)
 		height = vyres - dy;
 
-	regs_base = par->tga_regs_base;
 	fb_base = par->tga_fb_base;
 
 	pos = dy * line_length + (dx * 4);
@@ -1034,7 +1033,7 @@ tgafb_fillrect(struct fb_info *info, const struct fb_fillrect *rect)
 		     regs_base + TGA_MODE_REG);
 }
 
-/**
+/*
  *      tgafb_copyarea - REQUIRED function. Can use generic routines if
  *                       non acclerated hardware and packed pixel based.
  *                       Copies on area of the screen to another area.

From patchwork Sat Nov 28 22:41:04 2020
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
X-Patchwork-Submitter: Sam Ravnborg <sam@ravnborg.org>
X-Patchwork-Id: 334257
Return-Path: <linux-fbdev-owner@kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
 aws-us-west-2-korg-lkml-1.web.codeaurora.org
X-Spam-Level: 
X-Spam-Status: No, score=-16.7 required=3.0 tests=BAYES_00,DKIM_SIGNED,
 DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,
 INCLUDES_PATCH, 
 MAILING_LIST_MULTI, SPF_HELO_NONE, SPF_PASS, URIBL_BLOCKED,
 USER_AGENT_GIT
 autolearn=unavailable autolearn_force=no version=3.4.0
Received: from mail.kernel.org (mail.kernel.org [198.145.29.99])
 by smtp.lore.kernel.org (Postfix) with ESMTP id 5DE88C64E7B
 for <linux-fbdev@archiver.kernel.org>;
 Sat, 28 Nov 2020 22:43:26 +0000 (UTC)
Received: from vger.kernel.org (vger.kernel.org [23.128.96.18])
 by mail.kernel.org (Postfix) with ESMTP id 2995720702
 for <linux-fbdev@archiver.kernel.org>;
 Sat, 28 Nov 2020 22:43:26 +0000 (UTC)
Authentication-Results: mail.kernel.org;
 dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com
 header.b="ZuXVD4U+"
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
 id S1730594AbgK1WnY (ORCPT <rfc822; linux-fbdev@archiver.kernel.org>);
 Sat, 28 Nov 2020 17:43:24 -0500
Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49410 "EHLO
 lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by
 vger.kernel.org with ESMTP id S1729806AbgK1WnY (ORCPT
 <rfc822;linux-fbdev@vger.kernel.org>);
 Sat, 28 Nov 2020 17:43:24 -0500
Received: from mail-lj1-x241.google.com (mail-lj1-x241.google.com
 [IPv6:2a00:1450:4864:20::241])
 by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E1A8CC061A56
 for <linux-fbdev@vger.kernel.org>;
 Sat, 28 Nov 2020 14:41:57 -0800 (PST)
Received: by mail-lj1-x241.google.com with SMTP id i17so10604929ljd.3
 for <linux-fbdev@vger.kernel.org>;
 Sat, 28 Nov 2020 14:41:57 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;
 h=sender:from:to:cc:subject:date:message-id:in-reply-to:references
 :mime-version:content-transfer-encoding;
 bh=FUS2l8ow10S8HSMYNfPD1C147gZPvQOjrsInjizZFWo=;
 b=ZuXVD4U+vOHha9du/xh79eB8mXwGkHog3AcYCmOiX/kyAI0CkHLEW4enjKDEADRidd
 TEDCXyWF5O8L3obC0yEOfyv7VjYtT5EmyOXth8pyNpjR8iD+YMpeYLfMGXC2H+DIBzBf
 Z4XvUtva0NtPBnsOYAOpJ4N7uLjCl5fZItorbBSj/Qjir5m8IIKwCoEPaOX+826UL4bq
 pqXBJ/hdtIg19IZPJWrWPR7W3lQwOLMJADR5y9bMuFKcw0AwockLuPZgbW13duq6ezUN
 7kPQNGdRNwy6Pk5ZipS7fWaRqk/cctTHFv4Um1eRK1ATYLWt0wZppPuPWeprwXOhI22P
 i38Q==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20161025;
 h=x-gm-message-state:sender:from:to:cc:subject:date:message-id
 :in-reply-to:references:mime-version:content-transfer-encoding;
 bh=FUS2l8ow10S8HSMYNfPD1C147gZPvQOjrsInjizZFWo=;
 b=CgWgFP931cbt0HF+6ASUDmxfjrAxGY6fShSfRjskOe9wsJWgyuim4b1/m6UDsi9eVG
 oJ2JsFmg2IEFp3E2dk5IIuMe3xoXT2jUAXGqiSC6DNuDrY462P3PVtE8ft3wMxSNP2Jc
 rUHx2/WWN6ThsXOBajvYFN9yqK9iibgbC/lI6ei61IozaA2g/hKgufmoDEVtw8/6tE/P
 0F79wkuCgkjhpOaf0Usdy/3Hd5mqnJbpT+w7/pwK5XsHYZiqDfg+NMnntzHtUbOXs9fK
 cx599irq7TXlCP+TNkc+3mYTT6fB0bop+tB+7evHSFxngs4fdp705xmvMvbTATwGbctt
 9V0w==
X-Gm-Message-State: AOAM530Aekfi2mYuulG/Othw5YM6D6Ap/R+1nF1cFFbrIpus4l1UJ+KN
 /yYXT8KJIjxFLtcH9ayc94cLBCfZNnUNnA==
X-Google-Smtp-Source: ABdhPJwQp91sOBtClqT2B4BDuivw06O2VWWo97mJ17fzP30e5uvOsf2Sl/QfFQYeZZd1g8R+upOYhA==
X-Received: by 2002:a05:651c:48f:: with SMTP id
 s15mr6322341ljc.412.1606603316230; 
 Sat, 28 Nov 2020 14:41:56 -0800 (PST)
Received: from saturn.localdomain ([2a00:fd00:8060:1c00:a4c7:9ff9:a160:aad0])
 by smtp.gmail.com with ESMTPSA id
 w21sm1236857lff.280.2020.11.28.14.41.54
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Sat, 28 Nov 2020 14:41:55 -0800 (PST)
Sender: Sam Ravnborg <sam.ravnborg@gmail.com>
From: Sam Ravnborg <sam@ravnborg.org>
To: linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org,
 Lee Jones <lee.jones@linaro.org>
Cc: Aditya Pakki <pakki001@umn.edu>,
 Alexander Klimov <grandmaster@al2klimov.de>,
 Alex Dewar <alex.dewar90@gmail.com>, Antonino Daplas <adaplas@gmail.com>,
 Arnd Bergmann <arnd@arndb.de>,
 Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
 Benjamin Herrenschmidt <benh@kernel.crashing.org>,
 Daniel Vetter <daniel.vetter@ffwll.ch>, Evgeny Novikov <novikov@ispras.ru>,
 Florian Tobias Schandinat <FlorianSchandinat@gmx.de>,
 George Kennedy <george.kennedy@oracle.com>,
 Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
 Gustavo Silva <gustavoars@kernel.org>,
 Jani Nikula <jani.nikula@intel.com>, Jason Yan <yanaijie@huawei.com>,
 Jingoo Han <jingoohan1@gmail.com>, Jiri Slaby <jirislaby@kernel.org>,
 Joe Perches <joe@perches.com>,
 Kristoffer Ericson <kristoffer.ericson@gmail.com>,
 Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
 Mike Rapoport <rppt@kernel.org>,
 Nathan Chancellor <natechancellor@gmail.com>,
 Peilin Ye <yepeilin.cs@gmail.com>, Peter Rosin <peda@axentia.se>,
 Qilong Zhang <zhangqilong3@huawei.com>,
 Randy Dunlap <rdunlap@infradead.org>,
 Saeed Mirzamohammadi <saeed.mirzamohammadi@oracle.com>,
 Sam Ravnborg <sam@ravnborg.org>,
 Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>,
 Thomas Winischhofer <thomas@winischhofer.net>,
 Thomas Zimemrmann <tzimmermann@suse.de>,
 Vaibhav Gupta <vaibhavgupta40@gmail.com>,
 Xiaofei Tan <tanxiaofei@huawei.com>
Subject: [PATCH v2 18/28] video: fbdev: mx3fb: Fix kernel-doc,
 set but not used and string warnings
Date: Sat, 28 Nov 2020 23:41:04 +0100
Message-Id: <20201128224114.1033617-19-sam@ravnborg.org>
X-Mailer: git-send-email 2.27.0
In-Reply-To: <20201128224114.1033617-1-sam@ravnborg.org>
References: <20201128224114.1033617-1-sam@ravnborg.org>
MIME-Version: 1.0
Precedence: bulk
List-ID: <linux-fbdev.vger.kernel.org>
X-Mailing-List: linux-fbdev@vger.kernel.org

Fix W=1 warnings:
- Fix kernel-doc
- Drop unused code/variables
- Use memcpy to copy a string without zero-termination
  strncpy() generates a warning

v2:
  - Updated subject (Lee)

Signed-off-by: Sam Ravnborg <sam@ravnborg.org>
Cc: Sam Ravnborg <sam@ravnborg.org>
Cc: Jani Nikula <jani.nikula@intel.com>
Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
Cc: Xiaofei Tan <tanxiaofei@huawei.com>
Cc: Arnd Bergmann <arnd@arndb.de>
Cc: Lee Jones <lee.jones@linaro.org>
Acked-by: Thomas Zimmermann <tzimmermann@suse.de>
---
 drivers/video/fbdev/mx3fb.c | 13 ++++++++-----
 1 file changed, 8 insertions(+), 5 deletions(-)

diff --git a/drivers/video/fbdev/mx3fb.c b/drivers/video/fbdev/mx3fb.c
index 894617ddabcb..fabb271337ed 100644
--- a/drivers/video/fbdev/mx3fb.c
+++ b/drivers/video/fbdev/mx3fb.c
@@ -445,7 +445,6 @@ static void sdc_enable_channel(struct mx3fb_info *mx3_fbi)
 static void sdc_disable_channel(struct mx3fb_info *mx3_fbi)
 {
 	struct mx3fb_data *mx3fb = mx3_fbi->mx3fb;
-	uint32_t enabled;
 	unsigned long flags;
 
 	if (mx3_fbi->txd == NULL)
@@ -453,7 +452,7 @@ static void sdc_disable_channel(struct mx3fb_info *mx3_fbi)
 
 	spin_lock_irqsave(&mx3fb->lock, flags);
 
-	enabled = sdc_fb_uninit(mx3_fbi);
+	sdc_fb_uninit(mx3_fbi);
 
 	spin_unlock_irqrestore(&mx3fb->lock, flags);
 
@@ -732,7 +731,7 @@ static int mx3fb_unmap_video_memory(struct fb_info *fbi);
 
 /**
  * mx3fb_set_fix() - set fixed framebuffer parameters from variable settings.
- * @info:	framebuffer information pointer
+ * @fbi:	framebuffer information pointer
  * @return:	0 on success or negative error code on failure.
  */
 static int mx3fb_set_fix(struct fb_info *fbi)
@@ -740,7 +739,7 @@ static int mx3fb_set_fix(struct fb_info *fbi)
 	struct fb_fix_screeninfo *fix = &fbi->fix;
 	struct fb_var_screeninfo *var = &fbi->var;
 
-	strncpy(fix->id, "DISP3 BG", 8);
+	memcpy(fix->id, "DISP3 BG", 8);
 
 	fix->line_length = var->xres_virtual * var->bits_per_pixel / 8;
 
@@ -1105,6 +1104,8 @@ static void __blank(int blank, struct fb_info *fbi)
 
 /**
  * mx3fb_blank() - blank the display.
+ * @blank:	blank value for the panel
+ * @fbi:	framebuffer information pointer
  */
 static int mx3fb_blank(int blank, struct fb_info *fbi)
 {
@@ -1126,7 +1127,7 @@ static int mx3fb_blank(int blank, struct fb_info *fbi)
 /**
  * mx3fb_pan_display() - pan or wrap the display
  * @var:	variable screen buffer information.
- * @info:	framebuffer information pointer.
+ * @fbi:	framebuffer information pointer.
  *
  * We look only at xoffset, yoffset and the FB_VMODE_YWRAP flag
  */
@@ -1387,6 +1388,8 @@ static int mx3fb_unmap_video_memory(struct fb_info *fbi)
 
 /**
  * mx3fb_init_fbinfo() - initialize framebuffer information object.
+ * @dev: the device
+ * @ops:	framebuffer device operations
  * @return:	initialized framebuffer structure.
  */
 static struct fb_info *mx3fb_init_fbinfo(struct device *dev,

From patchwork Sat Nov 28 22:41:05 2020
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
X-Patchwork-Submitter: Sam Ravnborg <sam@ravnborg.org>
X-Patchwork-Id: 334259
Return-Path: <linux-fbdev-owner@kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
 aws-us-west-2-korg-lkml-1.web.codeaurora.org
X-Spam-Level: 
X-Spam-Status: No, score=-16.7 required=3.0 tests=BAYES_00,DKIM_SIGNED,
 DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,
 INCLUDES_PATCH, 
 MAILING_LIST_MULTI, SPF_HELO_NONE, SPF_PASS, URIBL_BLOCKED,
 USER_AGENT_GIT
 autolearn=unavailable autolearn_force=no version=3.4.0
Received: from mail.kernel.org (mail.kernel.org [198.145.29.99])
 by smtp.lore.kernel.org (Postfix) with ESMTP id D9228C63798
 for <linux-fbdev@archiver.kernel.org>;
 Sat, 28 Nov 2020 22:43:06 +0000 (UTC)
Received: from vger.kernel.org (vger.kernel.org [23.128.96.18])
 by mail.kernel.org (Postfix) with ESMTP id A1B9E20702
 for <linux-fbdev@archiver.kernel.org>;
 Sat, 28 Nov 2020 22:43:06 +0000 (UTC)
Authentication-Results: mail.kernel.org;
 dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com
 header.b="XdE+tpdR"
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
 id S2387814AbgK1WnG (ORCPT <rfc822; linux-fbdev@archiver.kernel.org>);
 Sat, 28 Nov 2020 17:43:06 -0500
Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49304 "EHLO
 lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by
 vger.kernel.org with ESMTP id S2388241AbgK1WnE (ORCPT
 <rfc822;linux-fbdev@vger.kernel.org>);
 Sat, 28 Nov 2020 17:43:04 -0500
Received: from mail-lj1-x242.google.com (mail-lj1-x242.google.com
 [IPv6:2a00:1450:4864:20::242])
 by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B6F98C08C5F2
 for <linux-fbdev@vger.kernel.org>;
 Sat, 28 Nov 2020 14:41:59 -0800 (PST)
Received: by mail-lj1-x242.google.com with SMTP id s9so10557821ljo.11
 for <linux-fbdev@vger.kernel.org>;
 Sat, 28 Nov 2020 14:41:59 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;
 h=sender:from:to:cc:subject:date:message-id:in-reply-to:references
 :mime-version:content-transfer-encoding;
 bh=6ly/Z1yYuSnGcVTY2GvWV0FTJyRU84GpNxZ//3QWCM8=;
 b=XdE+tpdRtCE6buzA19hei71zINn4l4fFqUFVe6IoD1/xcVmv3ktBz40TsQO/8S+Y5M
 KloOnjhUZh9VgpR+4eQIYrWDVFO8UbYu+nhrLggsPyJjRJXkiGlqREHjn4Xr/My8Gzj3
 yXsc07B+W64ChsaDNIxi0waUEMK9W3NJMvPP8XLizVCXXGYr2wFU5XiKXgKgmn6cJ+yc
 gaeT2zwHv/QLpbRyyUvcOVyeVIQu7fK3B7QU8ZUy8Jxb2l2dhdnCXo5t/wBry3pNXSPO
 YuN7G8+aKJj+KHnzSlscrc1hclR9raQgczphM2tw2h6Xx7tyTgQZajeYvbQ3R6Sf2O0o
 6ffw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20161025;
 h=x-gm-message-state:sender:from:to:cc:subject:date:message-id
 :in-reply-to:references:mime-version:content-transfer-encoding;
 bh=6ly/Z1yYuSnGcVTY2GvWV0FTJyRU84GpNxZ//3QWCM8=;
 b=md58JwC9cQp5vHqEZlYZQl8zx6Gn69OLP7ASyiyjb4hgMhkOD9AFR6oq3nvXSfCgbM
 AaWhe8pfg/3wLbqKrd6gm0PDjZSfDK02raqJ4KFc+C7Ustc23mMJ2XzSPqyfC5i2yRBa
 Ju7BtyM1Nwe+cjX15rlaYQQkDzDLXL2LgoMAXu/bEbQwoHQzmWw72yE78zfpSdS2ZwGY
 1+aE2qIpqiv4OcBEoD+boWXghTQ5SexaKRJ5L0Keb1MlVFG+O5Fe99tieJ+PNtecRc6l
 7GA03LYnlnA+VDX9YC9Nqesa0hbKv6YyHnwPeL8B3nT2ECs0PrFSWnK9lOjp3g2Bk3kJ
 CnOA==
X-Gm-Message-State: AOAM530/wvXrtvfelLKvKMZX1Lned2GOi6jvD5c5sUQ1Fy76iDCdYeTh
 mOvtk5uIkrghuTvuHC5YzGJ4CJpMpN+dXw==
X-Google-Smtp-Source: ABdhPJzxpWU9gC8X+uyFS5KiJHbVQ53c0gnB+Hw2Pp+j5BbMcnz5pe+A0pF19jy6LZS7IWaJHxicpw==
X-Received: by 2002:a2e:9652:: with SMTP id z18mr6752831ljh.106.1606603318096; 
 Sat, 28 Nov 2020 14:41:58 -0800 (PST)
Received: from saturn.localdomain ([2a00:fd00:8060:1c00:a4c7:9ff9:a160:aad0])
 by smtp.gmail.com with ESMTPSA id
 w21sm1236857lff.280.2020.11.28.14.41.56
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Sat, 28 Nov 2020 14:41:57 -0800 (PST)
Sender: Sam Ravnborg <sam.ravnborg@gmail.com>
From: Sam Ravnborg <sam@ravnborg.org>
To: linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org,
 Lee Jones <lee.jones@linaro.org>
Cc: Aditya Pakki <pakki001@umn.edu>,
 Alexander Klimov <grandmaster@al2klimov.de>,
 Alex Dewar <alex.dewar90@gmail.com>, Antonino Daplas <adaplas@gmail.com>,
 Arnd Bergmann <arnd@arndb.de>,
 Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
 Benjamin Herrenschmidt <benh@kernel.crashing.org>,
 Daniel Vetter <daniel.vetter@ffwll.ch>, Evgeny Novikov <novikov@ispras.ru>,
 Florian Tobias Schandinat <FlorianSchandinat@gmx.de>,
 George Kennedy <george.kennedy@oracle.com>,
 Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
 Gustavo Silva <gustavoars@kernel.org>,
 Jani Nikula <jani.nikula@intel.com>, Jason Yan <yanaijie@huawei.com>,
 Jingoo Han <jingoohan1@gmail.com>, Jiri Slaby <jirislaby@kernel.org>,
 Joe Perches <joe@perches.com>,
 Kristoffer Ericson <kristoffer.ericson@gmail.com>,
 Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
 Mike Rapoport <rppt@kernel.org>,
 Nathan Chancellor <natechancellor@gmail.com>,
 Peilin Ye <yepeilin.cs@gmail.com>, Peter Rosin <peda@axentia.se>,
 Qilong Zhang <zhangqilong3@huawei.com>,
 Randy Dunlap <rdunlap@infradead.org>,
 Saeed Mirzamohammadi <saeed.mirzamohammadi@oracle.com>,
 Sam Ravnborg <sam@ravnborg.org>,
 Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>,
 Thomas Winischhofer <thomas@winischhofer.net>,
 Thomas Zimemrmann <tzimmermann@suse.de>,
 Vaibhav Gupta <vaibhavgupta40@gmail.com>,
 Xiaofei Tan <tanxiaofei@huawei.com>
Subject: [PATCH v2 19/28] video: fbdev: sstfb: Updated logging to fix set
 but not used warnings
Date: Sat, 28 Nov 2020 23:41:05 +0100
Message-Id: <20201128224114.1033617-20-sam@ravnborg.org>
X-Mailer: git-send-email 2.27.0
In-Reply-To: <20201128224114.1033617-1-sam@ravnborg.org>
References: <20201128224114.1033617-1-sam@ravnborg.org>
MIME-Version: 1.0
Precedence: bulk
List-ID: <linux-fbdev.vger.kernel.org>
X-Mailing-List: linux-fbdev@vger.kernel.org

Fix set but not used warnings by introducing no_printk variants
for the internal logging system for this driver.

Fix a new warning that popped up now that logging was checked for
correct printf format strings.

A more invasive fix had been to replace all the internal logging with
standard logging primitives - thats for another day.

v2:
  - Update subject (Lee)

Signed-off-by: Sam Ravnborg <sam@ravnborg.org>
Cc: Sam Ravnborg <sam@ravnborg.org>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
Cc: Arnd Bergmann <arnd@arndb.de>
Cc: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
Cc: Alex Dewar <alex.dewar90@gmail.com>
Cc: Jani Nikula <jani.nikula@intel.com>
Cc: linux-fbdev@vger.kernel.org
Cc: Lee Jones <lee.jones@linaro.org>
---
 drivers/video/fbdev/sstfb.c | 2 +-
 include/video/sstfb.h       | 4 ++--
 2 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/video/fbdev/sstfb.c b/drivers/video/fbdev/sstfb.c
index c05cdabeb11c..27d4b0ace2d6 100644
--- a/drivers/video/fbdev/sstfb.c
+++ b/drivers/video/fbdev/sstfb.c
@@ -1390,7 +1390,7 @@ static int sstfb_probe(struct pci_dev *pdev, const struct pci_device_id *id)
 	        fix->smem_start, info->screen_base,
 	        fix->smem_len >> 20);
 
-	f_ddprintk("regbase_virt: %#lx\n", par->mmio_vbase);
+	f_ddprintk("regbase_virt: %p\n", par->mmio_vbase);
 	f_ddprintk("membase_phys: %#lx\n", fix->smem_start);
 	f_ddprintk("fbbase_virt: %p\n", info->screen_base);
 
diff --git a/include/video/sstfb.h b/include/video/sstfb.h
index 28384f354773..d4a5e41d1173 100644
--- a/include/video/sstfb.h
+++ b/include/video/sstfb.h
@@ -23,7 +23,7 @@
 #  define SST_DEBUG_FUNC 1
 #  define SST_DEBUG_VAR  1
 #else
-#  define dprintk(X...)
+#  define dprintk(X...)		no_printk(X)
 #  define SST_DEBUG_REG  0
 #  define SST_DEBUG_FUNC 0
 #  define SST_DEBUG_VAR  0
@@ -48,7 +48,7 @@
 #if (SST_DEBUG_FUNC > 1)
 #  define f_ddprintk(X...)	dprintk(" " X)
 #else
-#  define f_ddprintk(X...)
+#  define f_ddprintk(X...)	no_printk(X)
 #endif
 #if (SST_DEBUG_FUNC > 2)
 #  define f_dddprintk(X...)	dprintk(" " X)

From patchwork Sat Nov 28 22:41:06 2020
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
X-Patchwork-Submitter: Sam Ravnborg <sam@ravnborg.org>
X-Patchwork-Id: 334545
Return-Path: <linux-fbdev-owner@kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
 aws-us-west-2-korg-lkml-1.web.codeaurora.org
X-Spam-Level: 
X-Spam-Status: No, score=-16.7 required=3.0 tests=BAYES_00,DKIM_SIGNED,
 DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,
 INCLUDES_PATCH, 
 MAILING_LIST_MULTI, SPF_HELO_NONE, SPF_PASS, URIBL_BLOCKED,
 USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0
Received: from mail.kernel.org (mail.kernel.org [198.145.29.99])
 by smtp.lore.kernel.org (Postfix) with ESMTP id 2967AC63777
 for <linux-fbdev@archiver.kernel.org>;
 Sat, 28 Nov 2020 22:43:07 +0000 (UTC)
Received: from vger.kernel.org (vger.kernel.org [23.128.96.18])
 by mail.kernel.org (Postfix) with ESMTP id D860820771
 for <linux-fbdev@archiver.kernel.org>;
 Sat, 28 Nov 2020 22:43:06 +0000 (UTC)
Authentication-Results: mail.kernel.org;
 dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com
 header.b="roBw2ATo"
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
 id S2388241AbgK1WnG (ORCPT <rfc822; linux-fbdev@archiver.kernel.org>);
 Sat, 28 Nov 2020 17:43:06 -0500
Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49306 "EHLO
 lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by
 vger.kernel.org with ESMTP id S2388271AbgK1WnE (ORCPT
 <rfc822;linux-fbdev@vger.kernel.org>);
 Sat, 28 Nov 2020 17:43:04 -0500
Received: from mail-lj1-x242.google.com (mail-lj1-x242.google.com
 [IPv6:2a00:1450:4864:20::242])
 by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CAB6EC08E85E
 for <linux-fbdev@vger.kernel.org>;
 Sat, 28 Nov 2020 14:42:01 -0800 (PST)
Received: by mail-lj1-x242.google.com with SMTP id f18so10579763ljg.9
 for <linux-fbdev@vger.kernel.org>;
 Sat, 28 Nov 2020 14:42:01 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;
 h=sender:from:to:cc:subject:date:message-id:in-reply-to:references
 :mime-version:content-transfer-encoding;
 bh=mrtndvvG0M5u09IYAUmRgX+zXZ1Dkud8V3tonnF9qQM=;
 b=roBw2ATop181hwYHcBLwFp1eSYJ/3/IlOEUmM3XZ1UHyuImT3vGnihkTeWdY0tW/BR
 ZZLJkQCFGPYMa/9rFLwT7E9hMJB2ha1AP3M5hse1/JnNbV2HgbEJ/A2asaPZAFhoIYj+
 y/p9IFjpDDgMJy0ocfW+t9R7UN4xlxwToILq5UWaU29JuKYKgOLBBZLA+zzwfqDPSBxX
 TuaSidpPotdrN2+xi0bm6Y7APaz055RaavQDWBWtsDvi9t/4XGiWN5UfYM9alWp5N8kp
 Bx3AqdyWOfABLwLjIdxppZznIYAeDrTpoeCh4aLtegGE9We6EU9Ly/FLg2Mio1QnrhLW
 1vmQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20161025;
 h=x-gm-message-state:sender:from:to:cc:subject:date:message-id
 :in-reply-to:references:mime-version:content-transfer-encoding;
 bh=mrtndvvG0M5u09IYAUmRgX+zXZ1Dkud8V3tonnF9qQM=;
 b=SgDNmnvtReRbmw+E882q4ge4pW6MxLWOfmSYQIMo/TpAoUyB2BBXQNuf7hnJ9xrQLq
 6+sA63DlEyZNUDYM2u93pGomrDZTGCISg7WyU/XG3K3csDt2xk/5rq48FLti7oNrnu4D
 M0pMpUtO5u82T3ZkWidTyy487eRVeKEhqGNS4pIAT+UYQ//mcn79kyux/erpxY4eYliX
 m2hmr3e946aWSVhtBYeZrzimgv3DhpOJozwUBPfWNtfV6JXpCaybanI+vi3qCxcYuh/N
 +NOq7KM6NSH447wd+ImdwwE6vdG1KCQMBrgUdBPOLgrr1nZlYyzvXll4Wcn6Xi4ZscYd
 NIBA==
X-Gm-Message-State: AOAM5336e4XuD/ZILukzHGUgkngkM55KL+y88zibNeVVU3AjoCFJKMpK
 d1vdrWPejqGginhfkIPrdJTlM+EH+cSVZg==
X-Google-Smtp-Source: ABdhPJwNL3q+1JGxkJO+BEF4jOeWF1Djf3ezGNvxKzq2WbzTn2QNUr+I3reU8uOJYba+vVxHu5OrzA==
X-Received: by 2002:a2e:8e98:: with SMTP id z24mr6335837ljk.150.1606603320153; 
 Sat, 28 Nov 2020 14:42:00 -0800 (PST)
Received: from saturn.localdomain ([2a00:fd00:8060:1c00:a4c7:9ff9:a160:aad0])
 by smtp.gmail.com with ESMTPSA id
 w21sm1236857lff.280.2020.11.28.14.41.58
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Sat, 28 Nov 2020 14:41:59 -0800 (PST)
Sender: Sam Ravnborg <sam.ravnborg@gmail.com>
From: Sam Ravnborg <sam@ravnborg.org>
To: linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org,
 Lee Jones <lee.jones@linaro.org>
Cc: Aditya Pakki <pakki001@umn.edu>,
 Alexander Klimov <grandmaster@al2klimov.de>,
 Alex Dewar <alex.dewar90@gmail.com>, Antonino Daplas <adaplas@gmail.com>,
 Arnd Bergmann <arnd@arndb.de>,
 Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
 Benjamin Herrenschmidt <benh@kernel.crashing.org>,
 Daniel Vetter <daniel.vetter@ffwll.ch>, Evgeny Novikov <novikov@ispras.ru>,
 Florian Tobias Schandinat <FlorianSchandinat@gmx.de>,
 George Kennedy <george.kennedy@oracle.com>,
 Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
 Gustavo Silva <gustavoars@kernel.org>,
 Jani Nikula <jani.nikula@intel.com>, Jason Yan <yanaijie@huawei.com>,
 Jingoo Han <jingoohan1@gmail.com>, Jiri Slaby <jirislaby@kernel.org>,
 Joe Perches <joe@perches.com>,
 Kristoffer Ericson <kristoffer.ericson@gmail.com>,
 Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
 Mike Rapoport <rppt@kernel.org>,
 Nathan Chancellor <natechancellor@gmail.com>,
 Peilin Ye <yepeilin.cs@gmail.com>, Peter Rosin <peda@axentia.se>,
 Qilong Zhang <zhangqilong3@huawei.com>,
 Randy Dunlap <rdunlap@infradead.org>,
 Saeed Mirzamohammadi <saeed.mirzamohammadi@oracle.com>,
 Sam Ravnborg <sam@ravnborg.org>,
 Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>,
 Thomas Winischhofer <thomas@winischhofer.net>,
 Thomas Zimemrmann <tzimmermann@suse.de>,
 Vaibhav Gupta <vaibhavgupta40@gmail.com>,
 Xiaofei Tan <tanxiaofei@huawei.com>
Subject: [PATCH v2 20/28] video: fbdev: nvidia: Fix set but not used warnings
Date: Sat, 28 Nov 2020 23:41:06 +0100
Message-Id: <20201128224114.1033617-21-sam@ravnborg.org>
X-Mailer: git-send-email 2.27.0
In-Reply-To: <20201128224114.1033617-1-sam@ravnborg.org>
References: <20201128224114.1033617-1-sam@ravnborg.org>
MIME-Version: 1.0
Precedence: bulk
List-ID: <linux-fbdev.vger.kernel.org>
X-Mailing-List: linux-fbdev@vger.kernel.org

Fix warnings by deleting unused code. The register reads are
kept as it is unknown if there are any hidden side-effects.

v2:
  - Update subject (Lee)

Signed-off-by: Sam Ravnborg <sam@ravnborg.org>
Cc: Antonino Daplas <adaplas@gmail.com>
Cc: linux-fbdev@vger.kernel.org
Cc: Lee Jones <lee.jones@linaro.org>
---
 drivers/video/fbdev/nvidia/nv_setup.c | 7 ++-----
 1 file changed, 2 insertions(+), 5 deletions(-)

diff --git a/drivers/video/fbdev/nvidia/nv_setup.c b/drivers/video/fbdev/nvidia/nv_setup.c
index 2fa68669613a..5404017e6957 100644
--- a/drivers/video/fbdev/nvidia/nv_setup.c
+++ b/drivers/video/fbdev/nvidia/nv_setup.c
@@ -89,9 +89,8 @@ u8 NVReadSeq(struct nvidia_par *par, u8 index)
 }
 void NVWriteAttr(struct nvidia_par *par, u8 index, u8 value)
 {
-	volatile u8 tmp;
 
-	tmp = VGA_RD08(par->PCIO, par->IOBase + 0x0a);
+	VGA_RD08(par->PCIO, par->IOBase + 0x0a);
 	if (par->paletteEnabled)
 		index &= ~0x20;
 	else
@@ -101,9 +100,7 @@ void NVWriteAttr(struct nvidia_par *par, u8 index, u8 value)
 }
 u8 NVReadAttr(struct nvidia_par *par, u8 index)
 {
-	volatile u8 tmp;
-
-	tmp = VGA_RD08(par->PCIO, par->IOBase + 0x0a);
+	VGA_RD08(par->PCIO, par->IOBase + 0x0a);
 	if (par->paletteEnabled)
 		index &= ~0x20;
 	else

From patchwork Sat Nov 28 22:41:07 2020
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
X-Patchwork-Submitter: Sam Ravnborg <sam@ravnborg.org>
X-Patchwork-Id: 334542
Return-Path: <linux-fbdev-owner@kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
 aws-us-west-2-korg-lkml-1.web.codeaurora.org
X-Spam-Level: 
X-Spam-Status: No, score=-16.7 required=3.0 tests=BAYES_00,DKIM_SIGNED,
 DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,
 INCLUDES_PATCH, 
 MAILING_LIST_MULTI, SPF_HELO_NONE, SPF_PASS, URIBL_BLOCKED,
 USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0
Received: from mail.kernel.org (mail.kernel.org [198.145.29.99])
 by smtp.lore.kernel.org (Postfix) with ESMTP id 041B8C63777
 for <linux-fbdev@archiver.kernel.org>;
 Sat, 28 Nov 2020 22:43:32 +0000 (UTC)
Received: from vger.kernel.org (vger.kernel.org [23.128.96.18])
 by mail.kernel.org (Postfix) with ESMTP id C3DBD20702
 for <linux-fbdev@archiver.kernel.org>;
 Sat, 28 Nov 2020 22:43:31 +0000 (UTC)
Authentication-Results: mail.kernel.org;
 dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com
 header.b="tvzCFnaK"
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
 id S1732698AbgK1Wnb (ORCPT <rfc822; linux-fbdev@archiver.kernel.org>);
 Sat, 28 Nov 2020 17:43:31 -0500
Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49426 "EHLO
 lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by
 vger.kernel.org with ESMTP id S1730785AbgK1Wn3 (ORCPT
 <rfc822;linux-fbdev@vger.kernel.org>);
 Sat, 28 Nov 2020 17:43:29 -0500
Received: from mail-lf1-x142.google.com (mail-lf1-x142.google.com
 [IPv6:2a00:1450:4864:20::142])
 by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9DF0FC0613D1
 for <linux-fbdev@vger.kernel.org>;
 Sat, 28 Nov 2020 14:42:03 -0800 (PST)
Received: by mail-lf1-x142.google.com with SMTP id s27so12750239lfp.5
 for <linux-fbdev@vger.kernel.org>;
 Sat, 28 Nov 2020 14:42:03 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;
 h=sender:from:to:cc:subject:date:message-id:in-reply-to:references
 :mime-version:content-transfer-encoding;
 bh=5MJlaKcTS845wbNZGaIoS2kPxxU74n2R9tKR7IOQIuA=;
 b=tvzCFnaKarri4MrMt/OOBX4UYabnmocLUjuejQpGNQHUbU1DV6B8ZgY3G77V3kezjS
 TjZKXyvlQ9iCHDG6ntv/X/orBmg0DjjdkGE6hTXPdAuSBP2EYE1V8VsonslrBQw9+mGb
 FD854fbfMhhp0lNLk880C3CTN4ruQLvxeqY3O4+fCM8IRdEhz5qLr15AO69rFVOYqyzZ
 svz4z+Qz8nd4wmxP3lb28IIk1+Bl24bS8CGDh5JSpkdhBS0ouH65+e0hekQ5q/QfxGFC
 DNnmoyu4ginXvCr6uQdvL6yx9/fXSAVcuv+WiZz0VrA8PRDNzTrGcFt5rkgJYY29QCr7
 8upA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20161025;
 h=x-gm-message-state:sender:from:to:cc:subject:date:message-id
 :in-reply-to:references:mime-version:content-transfer-encoding;
 bh=5MJlaKcTS845wbNZGaIoS2kPxxU74n2R9tKR7IOQIuA=;
 b=mcekx80I/4T1FzhBXkkyIHM+v9XyiueGqwKxDKKQMgwMdih4v3AoW82yRt3+is8e7E
 Jp5VebJMEwlPzJy9fb9sfkL2OlbogjHpTBBjw7wT2eoX+Wse2u4pO/Ei8adU2UKXZSoE
 7Y3xjyTASsUr+PpQ/kb96R1g90xDcCydAoj15NgB/MnmdPQAPhu9HBZ6Q4KILHncB3pn
 uHVf5gwtXecB/y9+Mo+qTsqFKE19HTO5emZ1Jp2YXoXSTN8dktZ8KJa0yOgN0ok9W/jc
 yvcuJpeN3PZlq2y4CPqdRdfofdEZ8BXSBSukzqIA8DxoaDW0SOwWwxWF3h/S13kzuVGf
 /CyA==
X-Gm-Message-State: AOAM533SHNc4HvmMjV8LvzH8CYy85Nb/vhd1zcCkv0YFzNGuOyUr139m
 Iet10FasApQf1wxb7aWbi4+GBu48VCfSTA==
X-Google-Smtp-Source: ABdhPJxedjLhnAr5B6nJvt/A/46S2ueviNNylSrgyAirvdAVc5ST23a882taVbnarg8qv8rIuZvs4g==
X-Received: by 2002:ac2:446f:: with SMTP id y15mr6344891lfl.415.1606603321907; 
 Sat, 28 Nov 2020 14:42:01 -0800 (PST)
Received: from saturn.localdomain ([2a00:fd00:8060:1c00:a4c7:9ff9:a160:aad0])
 by smtp.gmail.com with ESMTPSA id
 w21sm1236857lff.280.2020.11.28.14.42.00
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Sat, 28 Nov 2020 14:42:01 -0800 (PST)
Sender: Sam Ravnborg <sam.ravnborg@gmail.com>
From: Sam Ravnborg <sam@ravnborg.org>
To: linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org,
 Lee Jones <lee.jones@linaro.org>
Cc: Aditya Pakki <pakki001@umn.edu>,
 Alexander Klimov <grandmaster@al2klimov.de>,
 Alex Dewar <alex.dewar90@gmail.com>, Antonino Daplas <adaplas@gmail.com>,
 Arnd Bergmann <arnd@arndb.de>,
 Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
 Benjamin Herrenschmidt <benh@kernel.crashing.org>,
 Daniel Vetter <daniel.vetter@ffwll.ch>, Evgeny Novikov <novikov@ispras.ru>,
 Florian Tobias Schandinat <FlorianSchandinat@gmx.de>,
 George Kennedy <george.kennedy@oracle.com>,
 Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
 Gustavo Silva <gustavoars@kernel.org>,
 Jani Nikula <jani.nikula@intel.com>, Jason Yan <yanaijie@huawei.com>,
 Jingoo Han <jingoohan1@gmail.com>, Jiri Slaby <jirislaby@kernel.org>,
 Joe Perches <joe@perches.com>,
 Kristoffer Ericson <kristoffer.ericson@gmail.com>,
 Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
 Mike Rapoport <rppt@kernel.org>,
 Nathan Chancellor <natechancellor@gmail.com>,
 Peilin Ye <yepeilin.cs@gmail.com>, Peter Rosin <peda@axentia.se>,
 Qilong Zhang <zhangqilong3@huawei.com>,
 Randy Dunlap <rdunlap@infradead.org>,
 Saeed Mirzamohammadi <saeed.mirzamohammadi@oracle.com>,
 Sam Ravnborg <sam@ravnborg.org>,
 Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>,
 Thomas Winischhofer <thomas@winischhofer.net>,
 Thomas Zimemrmann <tzimmermann@suse.de>,
 Vaibhav Gupta <vaibhavgupta40@gmail.com>,
 Xiaofei Tan <tanxiaofei@huawei.com>
Subject: [PATCH v2 21/28] video: fbdev: tmiofb: Fix set but not used warnings
Date: Sat, 28 Nov 2020 23:41:07 +0100
Message-Id: <20201128224114.1033617-22-sam@ravnborg.org>
X-Mailer: git-send-email 2.27.0
In-Reply-To: <20201128224114.1033617-1-sam@ravnborg.org>
References: <20201128224114.1033617-1-sam@ravnborg.org>
MIME-Version: 1.0
Precedence: bulk
List-ID: <linux-fbdev.vger.kernel.org>
X-Mailing-List: linux-fbdev@vger.kernel.org

Fix W=1 warnings by avoiding local variables and use direct references.

v2:
  - Updated subject (Lee)

Signed-off-by: Sam Ravnborg <sam@ravnborg.org>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
Cc: Sam Ravnborg <sam@ravnborg.org>
Cc: Jani Nikula <jani.nikula@intel.com>
Cc: Lee Jones <lee.jones@linaro.org>
---
 drivers/video/fbdev/tmiofb.c | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/drivers/video/fbdev/tmiofb.c b/drivers/video/fbdev/tmiofb.c
index 50111966c981..b70faa3850f2 100644
--- a/drivers/video/fbdev/tmiofb.c
+++ b/drivers/video/fbdev/tmiofb.c
@@ -802,10 +802,8 @@ static int tmiofb_remove(struct platform_device *dev)
 	const struct mfd_cell *cell = mfd_get_cell(dev);
 	struct fb_info *info = platform_get_drvdata(dev);
 	int irq = platform_get_irq(dev, 0);
-	struct tmiofb_par *par;
 
 	if (info) {
-		par = info->par;
 		unregister_framebuffer(info);
 
 		tmiofb_hw_stop(dev);
@@ -816,8 +814,8 @@ static int tmiofb_remove(struct platform_device *dev)
 		free_irq(irq, info);
 
 		iounmap(info->screen_base);
-		iounmap(par->lcr);
-		iounmap(par->ccr);
+		iounmap(((struct tmiofb_par *)info->par)->lcr);
+		iounmap(((struct tmiofb_par *)info->par)->ccr);
 
 		framebuffer_release(info);
 	}

From patchwork Sat Nov 28 22:41:08 2020
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
X-Patchwork-Submitter: Sam Ravnborg <sam@ravnborg.org>
X-Patchwork-Id: 334541
Return-Path: <linux-fbdev-owner@kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
 aws-us-west-2-korg-lkml-1.web.codeaurora.org
X-Spam-Level: 
X-Spam-Status: No, score=-16.7 required=3.0 tests=BAYES_00,DKIM_SIGNED,
 DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,
 INCLUDES_PATCH, 
 MAILING_LIST_MULTI, SPF_HELO_NONE, SPF_PASS, URIBL_BLOCKED,
 USER_AGENT_GIT
 autolearn=unavailable autolearn_force=no version=3.4.0
Received: from mail.kernel.org (mail.kernel.org [198.145.29.99])
 by smtp.lore.kernel.org (Postfix) with ESMTP id 6D58DC64E7B
 for <linux-fbdev@archiver.kernel.org>;
 Sat, 28 Nov 2020 22:43:32 +0000 (UTC)
Received: from vger.kernel.org (vger.kernel.org [23.128.96.18])
 by mail.kernel.org (Postfix) with ESMTP id 3AE3E20771
 for <linux-fbdev@archiver.kernel.org>;
 Sat, 28 Nov 2020 22:43:32 +0000 (UTC)
Authentication-Results: mail.kernel.org;
 dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com
 header.b="H1SQRZSr"
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
 id S1729806AbgK1Wnb (ORCPT <rfc822; linux-fbdev@archiver.kernel.org>);
 Sat, 28 Nov 2020 17:43:31 -0500
Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49428 "EHLO
 lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by
 vger.kernel.org with ESMTP id S1732694AbgK1Wn3 (ORCPT
 <rfc822;linux-fbdev@vger.kernel.org>);
 Sat, 28 Nov 2020 17:43:29 -0500
Received: from mail-lf1-x141.google.com (mail-lf1-x141.google.com
 [IPv6:2a00:1450:4864:20::141])
 by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7AF8AC08E85F
 for <linux-fbdev@vger.kernel.org>;
 Sat, 28 Nov 2020 14:42:05 -0800 (PST)
Received: by mail-lf1-x141.google.com with SMTP id d8so12778173lfa.1
 for <linux-fbdev@vger.kernel.org>;
 Sat, 28 Nov 2020 14:42:05 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;
 h=sender:from:to:cc:subject:date:message-id:in-reply-to:references
 :mime-version:content-transfer-encoding;
 bh=i/jzMmTNfIIHRAzbdgJUlI30eY/5E6v51csqIZVPdm8=;
 b=H1SQRZSraI92a5O8JSNe2407lQpbO/+p9TDZYNkqAVUoapJk9fO+eGsW9hEC0PhPwQ
 MpND47D0UvArbcEQ6WCBHFbfL+Yj82bjKGsmbi1NL9P+Drah4BbSv2KWIwjIa7VtDKSC
 HLFX0TiM836LhxAnGD8VZIcFRVe37KjZkVD8bly5ogDokaCOe6rZkpYUE9zBOXZwIJeP
 jHP0XeZr/46sh5nl2Uo7tv5amK8nJqhQe+6A7RJqP8KEyG7ZABXvV1PIT0/j9J/XvlFW
 Pgvazywpu8LHLmRdFfaCSXUNq84LG/HMHt9XKr3njllPiDQ6VOrnopdZ3PVQFeD4IFqZ
 mzZA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20161025;
 h=x-gm-message-state:sender:from:to:cc:subject:date:message-id
 :in-reply-to:references:mime-version:content-transfer-encoding;
 bh=i/jzMmTNfIIHRAzbdgJUlI30eY/5E6v51csqIZVPdm8=;
 b=Ka7HvpHX3Qqp1I32Sd8x4W94q7pTEArpvY1S+lcW+PwpvBdrtkhF3ni14PIFfBZEW/
 x++avLNm9nSrFc1BpKu4luDGwlkxBUOoaGeiDVRe7qe6XakxRdNGUV1Kacmi/yYyp7N/
 lwT2ZzOnarhZ5QlksALfbbMwjm/8PPLwTVu36Kcttsz5tM0Coc4NHHDG25tthybAAYmv
 lELyy3uQTRF7e+Ksg2bV5tJUYsDY9LiXdAppjxnralHsP12nNDIXiPj/NlmXzRQyFMJY
 p4G3327SEssn1hvNxcxdgGVjcMJW3Ulq1e4GwkNSoLqyvzKYL+AOotQnKAYaFyZypwH0
 y6bg==
X-Gm-Message-State: AOAM531SANIsRxTvTK8ZWkKQfBAM9VdkiJlzDAx0TFG+fQCVyS+dn5Eh
 XbellldqMoOVdOg69QpGATzCUBrbWCUYCQ==
X-Google-Smtp-Source: ABdhPJxtO7VXEd89T+Ciyiy6CaN38D1Nxk/voiHrw2OR7xLLx2fqYvJc1vd+oWe7rP3sXbswetx3Nw==
X-Received: by 2002:a19:fc0d:: with SMTP id a13mr6540657lfi.276.1606603323803; 
 Sat, 28 Nov 2020 14:42:03 -0800 (PST)
Received: from saturn.localdomain ([2a00:fd00:8060:1c00:a4c7:9ff9:a160:aad0])
 by smtp.gmail.com with ESMTPSA id
 w21sm1236857lff.280.2020.11.28.14.42.02
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Sat, 28 Nov 2020 14:42:03 -0800 (PST)
Sender: Sam Ravnborg <sam.ravnborg@gmail.com>
From: Sam Ravnborg <sam@ravnborg.org>
To: linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org,
 Lee Jones <lee.jones@linaro.org>
Cc: Aditya Pakki <pakki001@umn.edu>,
 Alexander Klimov <grandmaster@al2klimov.de>,
 Alex Dewar <alex.dewar90@gmail.com>, Antonino Daplas <adaplas@gmail.com>,
 Arnd Bergmann <arnd@arndb.de>,
 Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
 Benjamin Herrenschmidt <benh@kernel.crashing.org>,
 Daniel Vetter <daniel.vetter@ffwll.ch>, Evgeny Novikov <novikov@ispras.ru>,
 Florian Tobias Schandinat <FlorianSchandinat@gmx.de>,
 George Kennedy <george.kennedy@oracle.com>,
 Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
 Gustavo Silva <gustavoars@kernel.org>,
 Jani Nikula <jani.nikula@intel.com>, Jason Yan <yanaijie@huawei.com>,
 Jingoo Han <jingoohan1@gmail.com>, Jiri Slaby <jirislaby@kernel.org>,
 Joe Perches <joe@perches.com>,
 Kristoffer Ericson <kristoffer.ericson@gmail.com>,
 Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
 Mike Rapoport <rppt@kernel.org>,
 Nathan Chancellor <natechancellor@gmail.com>,
 Peilin Ye <yepeilin.cs@gmail.com>, Peter Rosin <peda@axentia.se>,
 Qilong Zhang <zhangqilong3@huawei.com>,
 Randy Dunlap <rdunlap@infradead.org>,
 Saeed Mirzamohammadi <saeed.mirzamohammadi@oracle.com>,
 Sam Ravnborg <sam@ravnborg.org>,
 Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>,
 Thomas Winischhofer <thomas@winischhofer.net>,
 Thomas Zimemrmann <tzimmermann@suse.de>,
 Vaibhav Gupta <vaibhavgupta40@gmail.com>,
 Xiaofei Tan <tanxiaofei@huawei.com>
Subject: [PATCH v2 22/28] video: fbdev: omapfb: Fix set but not used
 warnings in dsi
Date: Sat, 28 Nov 2020 23:41:08 +0100
Message-Id: <20201128224114.1033617-23-sam@ravnborg.org>
X-Mailer: git-send-email 2.27.0
In-Reply-To: <20201128224114.1033617-1-sam@ravnborg.org>
References: <20201128224114.1033617-1-sam@ravnborg.org>
MIME-Version: 1.0
Precedence: bulk
List-ID: <linux-fbdev.vger.kernel.org>
X-Mailing-List: linux-fbdev@vger.kernel.org

Fix several W=1 warnings.
This removes unused code and avoids an assignment by moving
the use inside the conditional block.

The register read FLD_GET(r, 15, 8) could be dropped as it was done a
few lines before too.

v2:
  - Updated subject (Lee)

Signed-off-by: Sam Ravnborg <sam@ravnborg.org>
Cc: Aditya Pakki <pakki001@umn.edu>
Cc: Sam Ravnborg <sam@ravnborg.org>
Cc: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
Cc: Lee Jones <lee.jones@linaro.org>
---
 drivers/video/fbdev/omap2/omapfb/dss/dsi.c | 12 +++---------
 1 file changed, 3 insertions(+), 9 deletions(-)

diff --git a/drivers/video/fbdev/omap2/omapfb/dss/dsi.c b/drivers/video/fbdev/omap2/omapfb/dss/dsi.c
index 6f9c25fec994..72d45a02c3ac 100644
--- a/drivers/video/fbdev/omap2/omapfb/dss/dsi.c
+++ b/drivers/video/fbdev/omap2/omapfb/dss/dsi.c
@@ -1178,13 +1178,12 @@ static int dsi_regulator_init(struct platform_device *dsidev)
 
 static void _dsi_print_reset_status(struct platform_device *dsidev)
 {
-	u32 l;
 	int b0, b1, b2;
 
 	/* A dummy read using the SCP interface to any DSIPHY register is
 	 * required after DSIPHY reset to complete the reset of the DSI complex
 	 * I/O. */
-	l = dsi_read_reg(dsidev, DSI_DSIPHY_CFG5);
+	dsi_read_reg(dsidev, DSI_DSIPHY_CFG5);
 
 	if (dss_has_feature(FEAT_DSI_REVERSE_TXCLKESC)) {
 		b0 = 28;
@@ -3627,7 +3626,7 @@ static int dsi_proto_config(struct platform_device *dsidev)
 static void dsi_proto_timings(struct platform_device *dsidev)
 {
 	struct dsi_data *dsi = dsi_get_dsidrv_data(dsidev);
-	unsigned tlpx, tclk_zero, tclk_prepare, tclk_trail;
+	unsigned tlpx, tclk_zero, tclk_prepare;
 	unsigned tclk_pre, tclk_post;
 	unsigned ths_prepare, ths_prepare_ths_zero, ths_zero;
 	unsigned ths_trail, ths_exit;
@@ -3646,7 +3645,6 @@ static void dsi_proto_timings(struct platform_device *dsidev)
 
 	r = dsi_read_reg(dsidev, DSI_DSIPHY_CFG1);
 	tlpx = FLD_GET(r, 20, 16) * 2;
-	tclk_trail = FLD_GET(r, 15, 8);
 	tclk_zero = FLD_GET(r, 7, 0);
 
 	r = dsi_read_reg(dsidev, DSI_DSIPHY_CFG2);
@@ -4040,7 +4038,6 @@ static int dsi_update(struct omap_dss_device *dssdev, int channel,
 {
 	struct platform_device *dsidev = dsi_get_dsidev_from_dssdev(dssdev);
 	struct dsi_data *dsi = dsi_get_dsidrv_data(dsidev);
-	u16 dw, dh;
 
 	dsi_perf_mark_setup(dsidev);
 
@@ -4049,11 +4046,8 @@ static int dsi_update(struct omap_dss_device *dssdev, int channel,
 	dsi->framedone_callback = callback;
 	dsi->framedone_data = data;
 
-	dw = dsi->timings.x_res;
-	dh = dsi->timings.y_res;
-
 #ifdef DSI_PERF_MEASURE
-	dsi->update_bytes = dw * dh *
+	dsi->update_bytes = dsi->timings.x_res * dsi->timings.y_res *
 		dsi_get_pixel_size(dsi->pix_fmt) / 8;
 #endif
 	dsi_update_screen_dispc(dsidev);

From patchwork Sat Nov 28 22:41:09 2020
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
X-Patchwork-Submitter: Sam Ravnborg <sam@ravnborg.org>
X-Patchwork-Id: 334544
Return-Path: <linux-fbdev-owner@kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
 aws-us-west-2-korg-lkml-1.web.codeaurora.org
X-Spam-Level: 
X-Spam-Status: No, score=-16.7 required=3.0 tests=BAYES_00,DKIM_SIGNED,
 DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,
 INCLUDES_PATCH, 
 MAILING_LIST_MULTI, SPF_HELO_NONE, SPF_PASS, URIBL_BLOCKED,
 USER_AGENT_GIT
 autolearn=unavailable autolearn_force=no version=3.4.0
Received: from mail.kernel.org (mail.kernel.org [198.145.29.99])
 by smtp.lore.kernel.org (Postfix) with ESMTP id 99FEBC63777
 for <linux-fbdev@archiver.kernel.org>;
 Sat, 28 Nov 2020 22:43:10 +0000 (UTC)
Received: from vger.kernel.org (vger.kernel.org [23.128.96.18])
 by mail.kernel.org (Postfix) with ESMTP id 6490E20702
 for <linux-fbdev@archiver.kernel.org>;
 Sat, 28 Nov 2020 22:43:10 +0000 (UTC)
Authentication-Results: mail.kernel.org;
 dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com
 header.b="db0u5+lE"
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
 id S2388318AbgK1WnJ (ORCPT <rfc822; linux-fbdev@archiver.kernel.org>);
 Sat, 28 Nov 2020 17:43:09 -0500
Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49320 "EHLO
 lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by
 vger.kernel.org with ESMTP id S2388271AbgK1WnJ (ORCPT
 <rfc822;linux-fbdev@vger.kernel.org>);
 Sat, 28 Nov 2020 17:43:09 -0500
Received: from mail-lj1-x243.google.com (mail-lj1-x243.google.com
 [IPv6:2a00:1450:4864:20::243])
 by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5E7B9C08E860
 for <linux-fbdev@vger.kernel.org>;
 Sat, 28 Nov 2020 14:42:07 -0800 (PST)
Received: by mail-lj1-x243.google.com with SMTP id z1so10598742ljn.4
 for <linux-fbdev@vger.kernel.org>;
 Sat, 28 Nov 2020 14:42:07 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;
 h=sender:from:to:cc:subject:date:message-id:in-reply-to:references
 :mime-version:content-transfer-encoding;
 bh=tdC3cUaEksOqJq+sL/p6xZwzgeMpzcgI0nIv+Qg+xyQ=;
 b=db0u5+lExLWY4Gcbn8xuBCD7WyKO6XHbkpd5i1lVs5fIGDjOE7f0rpUc+FMjmqXEvY
 oTKMaJ76x5pp5L0cRp9DinMl03rqVZzTwy/wQbxQOulOdsU/OT+hugE3Ay3GARU2/Ey7
 bpcTSl+DWpzTJsPEGmFjcNTGfmSL+C25VfjOi7TwjbUq9J/ZRdPLce5mJKrs4Br5TBjS
 Ro/DeNhpUC5x+Dne7yQG4Y2CnnEzBp0ACn3lptugY42ovFlK8e/qXx/Hcoxd+7qgOdbj
 21uQOll3f6Qwj6mOAm2uyQGZEWKBc9QGcaKz6PzMRPeBvFLaBaL4Wpnsi46LTikdD1rm
 94JA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20161025;
 h=x-gm-message-state:sender:from:to:cc:subject:date:message-id
 :in-reply-to:references:mime-version:content-transfer-encoding;
 bh=tdC3cUaEksOqJq+sL/p6xZwzgeMpzcgI0nIv+Qg+xyQ=;
 b=VL61BrDzRDwzFp2BYMLo69Qh365P4VM59qAtGvaC5Ie63xDwAUb5nLv2RdRHe5iThp
 +VUujn9SHoNU0dU2VJm5XeMTp+8BK3xrrvU0f238CJMW5xlKOWB2TRE9uliBiHTM5B7p
 wKGQAH+rlWJLGpZDfpLBzdYWyRGYTutxnbTYV644ex1FVmxYC1YLRobXdohCdbZpkQyy
 ++d9GomCLD6SsLZWPnqjFi16k+e4Py+q4Tsl6A1uu1q6f5qQdqQF2wZF0DyigzXsENsX
 5NIuub/PnntCO0jrmRfs4K7wYS6axfYkJ4gpF1VTPNc0OOE1COIEtlPPlgP2yAnAnFVr
 lvfw==
X-Gm-Message-State: AOAM531Mh33fIfF7H44sAKMuRqWV3xgQ7mJp/tDKeW1ud5NDKG1JOwf3
 1vyIRTAtiDuhdoFIOHw39Fpwcxi6xVarcw==
X-Google-Smtp-Source: ABdhPJx/J0hfsr/rR0D6AcWR9QDUgP6LXUVbit09Oa3JEO3/0y2BPi8pZg+WoICFuvvaeWhd3bZjMA==
X-Received: by 2002:a2e:6f04:: with SMTP id k4mr6716005ljc.220.1606603325686; 
 Sat, 28 Nov 2020 14:42:05 -0800 (PST)
Received: from saturn.localdomain ([2a00:fd00:8060:1c00:a4c7:9ff9:a160:aad0])
 by smtp.gmail.com with ESMTPSA id
 w21sm1236857lff.280.2020.11.28.14.42.04
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Sat, 28 Nov 2020 14:42:05 -0800 (PST)
Sender: Sam Ravnborg <sam.ravnborg@gmail.com>
From: Sam Ravnborg <sam@ravnborg.org>
To: linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org,
 Lee Jones <lee.jones@linaro.org>
Cc: Aditya Pakki <pakki001@umn.edu>,
 Alexander Klimov <grandmaster@al2klimov.de>,
 Alex Dewar <alex.dewar90@gmail.com>, Antonino Daplas <adaplas@gmail.com>,
 Arnd Bergmann <arnd@arndb.de>,
 Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
 Benjamin Herrenschmidt <benh@kernel.crashing.org>,
 Daniel Vetter <daniel.vetter@ffwll.ch>, Evgeny Novikov <novikov@ispras.ru>,
 Florian Tobias Schandinat <FlorianSchandinat@gmx.de>,
 George Kennedy <george.kennedy@oracle.com>,
 Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
 Gustavo Silva <gustavoars@kernel.org>,
 Jani Nikula <jani.nikula@intel.com>, Jason Yan <yanaijie@huawei.com>,
 Jingoo Han <jingoohan1@gmail.com>, Jiri Slaby <jirislaby@kernel.org>,
 Joe Perches <joe@perches.com>,
 Kristoffer Ericson <kristoffer.ericson@gmail.com>,
 Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
 Mike Rapoport <rppt@kernel.org>,
 Nathan Chancellor <natechancellor@gmail.com>,
 Peilin Ye <yepeilin.cs@gmail.com>, Peter Rosin <peda@axentia.se>,
 Qilong Zhang <zhangqilong3@huawei.com>,
 Randy Dunlap <rdunlap@infradead.org>,
 Saeed Mirzamohammadi <saeed.mirzamohammadi@oracle.com>,
 Sam Ravnborg <sam@ravnborg.org>,
 Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>,
 Thomas Winischhofer <thomas@winischhofer.net>,
 Thomas Zimemrmann <tzimmermann@suse.de>,
 Vaibhav Gupta <vaibhavgupta40@gmail.com>,
 Xiaofei Tan <tanxiaofei@huawei.com>
Subject: [PATCH v2 23/28] video: fbdev: omapfb: Fix set but not used
 warnings in hdmi*_core
Date: Sat, 28 Nov 2020 23:41:09 +0100
Message-Id: <20201128224114.1033617-24-sam@ravnborg.org>
X-Mailer: git-send-email 2.27.0
In-Reply-To: <20201128224114.1033617-1-sam@ravnborg.org>
References: <20201128224114.1033617-1-sam@ravnborg.org>
MIME-Version: 1.0
Precedence: bulk
List-ID: <linux-fbdev.vger.kernel.org>
X-Mailing-List: linux-fbdev@vger.kernel.org

Fix a few W=1 warnings about unused assignments.
Drop the unused error code.

v2:
  - Subject updated (Lee)

Signed-off-by: Sam Ravnborg <sam@ravnborg.org>
Cc: Sam Ravnborg <sam@ravnborg.org>
Cc: Qilong Zhang <zhangqilong3@huawei.com>
Cc: "Alexander A. Klimov" <grandmaster@al2klimov.de>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
Cc: Lee Jones <lee.jones@linaro.org>
---
 drivers/video/fbdev/omap2/omapfb/dss/hdmi4_core.c | 4 ++--
 drivers/video/fbdev/omap2/omapfb/dss/hdmi5_core.c | 4 ++--
 2 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/video/fbdev/omap2/omapfb/dss/hdmi4_core.c b/drivers/video/fbdev/omap2/omapfb/dss/hdmi4_core.c
index 726c190862d4..e6363a420933 100644
--- a/drivers/video/fbdev/omap2/omapfb/dss/hdmi4_core.c
+++ b/drivers/video/fbdev/omap2/omapfb/dss/hdmi4_core.c
@@ -679,7 +679,7 @@ int hdmi4_audio_config(struct hdmi_core_data *core, struct hdmi_wp_data *wp,
 	struct hdmi_audio_format audio_format;
 	struct hdmi_audio_dma audio_dma;
 	struct hdmi_core_audio_config acore;
-	int err, n, cts, channel_count;
+	int n, cts, channel_count;
 	unsigned int fs_nr;
 	bool word_length_16b = false;
 
@@ -741,7 +741,7 @@ int hdmi4_audio_config(struct hdmi_core_data *core, struct hdmi_wp_data *wp,
 		return -EINVAL;
 	}
 
-	err = hdmi_compute_acr(pclk, fs_nr, &n, &cts);
+	hdmi_compute_acr(pclk, fs_nr, &n, &cts);
 
 	/* Audio clock regeneration settings */
 	acore.n = n;
diff --git a/drivers/video/fbdev/omap2/omapfb/dss/hdmi5_core.c b/drivers/video/fbdev/omap2/omapfb/dss/hdmi5_core.c
index eda29d3032e1..cb63bc0e92ca 100644
--- a/drivers/video/fbdev/omap2/omapfb/dss/hdmi5_core.c
+++ b/drivers/video/fbdev/omap2/omapfb/dss/hdmi5_core.c
@@ -790,7 +790,7 @@ int hdmi5_audio_config(struct hdmi_core_data *core, struct hdmi_wp_data *wp,
 	struct hdmi_audio_format audio_format;
 	struct hdmi_audio_dma audio_dma;
 	struct hdmi_core_audio_config core_cfg;
-	int err, n, cts, channel_count;
+	int n, cts, channel_count;
 	unsigned int fs_nr;
 	bool word_length_16b = false;
 
@@ -833,7 +833,7 @@ int hdmi5_audio_config(struct hdmi_core_data *core, struct hdmi_wp_data *wp,
 		return -EINVAL;
 	}
 
-	err = hdmi_compute_acr(pclk, fs_nr, &n, &cts);
+	hdmi_compute_acr(pclk, fs_nr, &n, &cts);
 	core_cfg.n = n;
 	core_cfg.cts = cts;
 

From patchwork Sat Nov 28 22:41:10 2020
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
X-Patchwork-Submitter: Sam Ravnborg <sam@ravnborg.org>
X-Patchwork-Id: 334255
Return-Path: <linux-fbdev-owner@kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
 aws-us-west-2-korg-lkml-1.web.codeaurora.org
X-Spam-Level: 
X-Spam-Status: No, score=-16.7 required=3.0 tests=BAYES_00,DKIM_SIGNED,
 DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,
 INCLUDES_PATCH, 
 MAILING_LIST_MULTI, SPF_HELO_NONE, SPF_PASS, URIBL_BLOCKED,
 USER_AGENT_GIT
 autolearn=unavailable autolearn_force=no version=3.4.0
Received: from mail.kernel.org (mail.kernel.org [198.145.29.99])
 by smtp.lore.kernel.org (Postfix) with ESMTP id 3D0AAC63798
 for <linux-fbdev@archiver.kernel.org>;
 Sat, 28 Nov 2020 22:43:35 +0000 (UTC)
Received: from vger.kernel.org (vger.kernel.org [23.128.96.18])
 by mail.kernel.org (Postfix) with ESMTP id EBC2A20702
 for <linux-fbdev@archiver.kernel.org>;
 Sat, 28 Nov 2020 22:43:34 +0000 (UTC)
Authentication-Results: mail.kernel.org;
 dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com
 header.b="PKawE79X"
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
 id S1732760AbgK1Wne (ORCPT <rfc822; linux-fbdev@archiver.kernel.org>);
 Sat, 28 Nov 2020 17:43:34 -0500
Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49442 "EHLO
 lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by
 vger.kernel.org with ESMTP id S1732694AbgK1Wne (ORCPT
 <rfc822;linux-fbdev@vger.kernel.org>);
 Sat, 28 Nov 2020 17:43:34 -0500
Received: from mail-lf1-x141.google.com (mail-lf1-x141.google.com
 [IPv6:2a00:1450:4864:20::141])
 by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 26A14C0613D3
 for <linux-fbdev@vger.kernel.org>;
 Sat, 28 Nov 2020 14:42:09 -0800 (PST)
Received: by mail-lf1-x141.google.com with SMTP id l11so12775589lfg.0
 for <linux-fbdev@vger.kernel.org>;
 Sat, 28 Nov 2020 14:42:09 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;
 h=sender:from:to:cc:subject:date:message-id:in-reply-to:references
 :mime-version:content-transfer-encoding;
 bh=0pPTHqERS7Db2usuT7lO4tkoqSnyS5cN5YGCLj+Fnqg=;
 b=PKawE79XryLi4zuifJjjnLr4k/MrTK8XKcFzFUNADpiT32tcbDbQOGDm7rueG4LvbY
 xnp1B/IzFxU+vykBFz8NJc3CIa4ZJomruRxQUdfquPqbFmAe5TxDNchBNgMN9FCMpEF+
 xtuBii+5u1AER2CDYZcm7xq4IS/CLE76nbVndO/J6A0gSoq9QXsFJPLvv9B3l6qvr2/4
 0fxG1T07KMq/Kfw2OkfMEQymoZ3petqH792mymuMuJFomgJksH4LumtH79k6dY6S4bSD
 Ap2I6Fuw3ROcj8EU3q//Je9stNtrJavc2eHMHAsrQv/eCsXGa6NCLVwJCKDCaLsBbHri
 SHSg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20161025;
 h=x-gm-message-state:sender:from:to:cc:subject:date:message-id
 :in-reply-to:references:mime-version:content-transfer-encoding;
 bh=0pPTHqERS7Db2usuT7lO4tkoqSnyS5cN5YGCLj+Fnqg=;
 b=Nc0vWB5K+CuvDxXMnmdsgJchdTxA1W6H1JTlymDOEgSphEv66I1DolhIGXVa1MvLD4
 QOgEde4TQ5O3lM0K4f2fPnm6NVREnqeGpaYLNFsrFV5dKA+UAVQG/qB9sUrzw30QemPd
 6sGLkpWVjULV/HTeUav3EW1kXS3MQWacHNuP/L4BQ/nwgsx8aL3xTKFAJT9Bs/yTzq87
 guTspzvIS6Zwh0dOU1DYciUQ3txSp9hqK1l5EWJipFEdNph3kjEwu3E5N1QG/+Lv/mCM
 jI5ZroN5fzmhhC5rCwqX5r4Qlb8EXZ2lgNkXhOJ0jZpmL3iYTkY2Gcii8q8OKigg643w
 CqWA==
X-Gm-Message-State: AOAM530kILOokNco99GX6xsMAWl6PdEVVv+YDS4ztYgiAXjtis49upt5
 h/IquhqUHAj3kYBZXLb1SQXddCaf2YP2HA==
X-Google-Smtp-Source: ABdhPJyi5EcI5hKCEoOj5zps6qhDlRStsdBrXEaiHp5tWI49l5NwQ/SmqZx18kU/mYqiP8BA0w96VA==
X-Received: by 2002:ac2:5f92:: with SMTP id r18mr5907806lfe.507.1606603327479; 
 Sat, 28 Nov 2020 14:42:07 -0800 (PST)
Received: from saturn.localdomain ([2a00:fd00:8060:1c00:a4c7:9ff9:a160:aad0])
 by smtp.gmail.com with ESMTPSA id
 w21sm1236857lff.280.2020.11.28.14.42.05
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Sat, 28 Nov 2020 14:42:07 -0800 (PST)
Sender: Sam Ravnborg <sam.ravnborg@gmail.com>
From: Sam Ravnborg <sam@ravnborg.org>
To: linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org,
 Lee Jones <lee.jones@linaro.org>
Cc: Aditya Pakki <pakki001@umn.edu>,
 Alexander Klimov <grandmaster@al2klimov.de>,
 Alex Dewar <alex.dewar90@gmail.com>, Antonino Daplas <adaplas@gmail.com>,
 Arnd Bergmann <arnd@arndb.de>,
 Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
 Benjamin Herrenschmidt <benh@kernel.crashing.org>,
 Daniel Vetter <daniel.vetter@ffwll.ch>, Evgeny Novikov <novikov@ispras.ru>,
 Florian Tobias Schandinat <FlorianSchandinat@gmx.de>,
 George Kennedy <george.kennedy@oracle.com>,
 Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
 Gustavo Silva <gustavoars@kernel.org>,
 Jani Nikula <jani.nikula@intel.com>, Jason Yan <yanaijie@huawei.com>,
 Jingoo Han <jingoohan1@gmail.com>, Jiri Slaby <jirislaby@kernel.org>,
 Joe Perches <joe@perches.com>,
 Kristoffer Ericson <kristoffer.ericson@gmail.com>,
 Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
 Mike Rapoport <rppt@kernel.org>,
 Nathan Chancellor <natechancellor@gmail.com>,
 Peilin Ye <yepeilin.cs@gmail.com>, Peter Rosin <peda@axentia.se>,
 Qilong Zhang <zhangqilong3@huawei.com>,
 Randy Dunlap <rdunlap@infradead.org>,
 Saeed Mirzamohammadi <saeed.mirzamohammadi@oracle.com>,
 Sam Ravnborg <sam@ravnborg.org>,
 Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>,
 Thomas Winischhofer <thomas@winischhofer.net>,
 Thomas Zimemrmann <tzimmermann@suse.de>,
 Vaibhav Gupta <vaibhavgupta40@gmail.com>,
 Xiaofei Tan <tanxiaofei@huawei.com>
Subject: [PATCH v2 24/28] video: fbdev: s3c-fb: Fix kernel-doc and set but
 not used warnings
Date: Sat, 28 Nov 2020 23:41:10 +0100
Message-Id: <20201128224114.1033617-25-sam@ravnborg.org>
X-Mailer: git-send-email 2.27.0
In-Reply-To: <20201128224114.1033617-1-sam@ravnborg.org>
References: <20201128224114.1033617-1-sam@ravnborg.org>
MIME-Version: 1.0
Precedence: bulk
List-ID: <linux-fbdev.vger.kernel.org>
X-Mailing-List: linux-fbdev@vger.kernel.org

Fix several W=1 warnings
- Updated kernel-doc as needed
- Deleted unused local variable, it was assigned but never used

v2:
  - Updated subject (Lee)

Signed-off-by: Sam Ravnborg <sam@ravnborg.org>
Cc: Jingoo Han <jingoohan1@gmail.com>
Cc: linux-fbdev@vger.kernel.org
Cc: Lee Jones <lee.jones@linaro.org>
Acked-by: Thomas Zimmermann <tzimmermann@suse.de>
---
 drivers/video/fbdev/s3c-fb.c | 11 ++++++-----
 1 file changed, 6 insertions(+), 5 deletions(-)

diff --git a/drivers/video/fbdev/s3c-fb.c b/drivers/video/fbdev/s3c-fb.c
index ba316bd56efd..3b134e1bbc38 100644
--- a/drivers/video/fbdev/s3c-fb.c
+++ b/drivers/video/fbdev/s3c-fb.c
@@ -75,6 +75,7 @@ struct s3c_fb;
  * @buf_size: Offset of buffer size registers.
  * @buf_end: Offset of buffer end registers.
  * @osd: The base for the OSD registers.
+ * @osd_stride: stride of osd
  * @palette: Address of palette memory, or 0 if none.
  * @has_prtcon: Set if has PRTCON register.
  * @has_shadowcon: Set if has SHADOWCON register.
@@ -155,7 +156,7 @@ struct s3c_fb_palette {
  * @windata: The platform data supplied for the window configuration.
  * @parent: The hardware that this window is part of.
  * @fbinfo: Pointer pack to the framebuffer info for this window.
- * @varint: The variant information for this window.
+ * @variant: The variant information for this window.
  * @palette_buffer: Buffer/cache to hold palette entries.
  * @pseudo_palette: For use in TRUECOLOUR modes for entries 0..15/
  * @index: The window number of this window.
@@ -336,7 +337,7 @@ static int s3c_fb_check_var(struct fb_var_screeninfo *var,
 /**
  * s3c_fb_calc_pixclk() - calculate the divider to create the pixel clock.
  * @sfb: The hardware state.
- * @pixclock: The pixel clock wanted, in picoseconds.
+ * @pixclk: The pixel clock wanted, in picoseconds.
  *
  * Given the specified pixel clock, work out the necessary divider to get
  * close to the output frequency.
@@ -733,7 +734,7 @@ static inline unsigned int chan_to_field(unsigned int chan,
  * @red: The red field for the palette data.
  * @green: The green field for the palette data.
  * @blue: The blue field for the palette data.
- * @trans: The transparency (alpha) field for the palette data.
+ * @transp: The transparency (alpha) field for the palette data.
  * @info: The framebuffer being changed.
  */
 static int s3c_fb_setcolreg(unsigned regno,
@@ -1133,6 +1134,7 @@ static void s3c_fb_free_memory(struct s3c_fb *sfb, struct s3c_fb_win *win)
 
 /**
  * s3c_fb_release_win() - release resources for a framebuffer window.
+ * @sfb: The base resources for the hardware.
  * @win: The window to cleanup the resources for.
  *
  * Release the resources that where claimed for the hardware window,
@@ -1160,6 +1162,7 @@ static void s3c_fb_release_win(struct s3c_fb *sfb, struct s3c_fb_win *win)
 /**
  * s3c_fb_probe_win() - register an hardware window
  * @sfb: The base resources for the hardware
+ * @win_no: The window number
  * @variant: The variant information for this window.
  * @res: Pointer to where to place the resultant window.
  *
@@ -1170,7 +1173,6 @@ static int s3c_fb_probe_win(struct s3c_fb *sfb, unsigned int win_no,
 			    struct s3c_fb_win_variant *variant,
 			    struct s3c_fb_win **res)
 {
-	struct fb_var_screeninfo *var;
 	struct fb_videomode initmode;
 	struct s3c_fb_pd_win *windata;
 	struct s3c_fb_win *win;
@@ -1198,7 +1200,6 @@ static int s3c_fb_probe_win(struct s3c_fb *sfb, unsigned int win_no,
 
 	win = fbinfo->par;
 	*res = win;
-	var = &fbinfo->var;
 	win->variant = *variant;
 	win->fbinfo = fbinfo;
 	win->parent = sfb;

From patchwork Sat Nov 28 22:41:11 2020
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
X-Patchwork-Submitter: Sam Ravnborg <sam@ravnborg.org>
X-Patchwork-Id: 334543
Return-Path: <linux-fbdev-owner@kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
 aws-us-west-2-korg-lkml-1.web.codeaurora.org
X-Spam-Level: 
X-Spam-Status: No, score=-16.7 required=3.0 tests=BAYES_00,DKIM_SIGNED,
 DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,
 INCLUDES_PATCH, 
 MAILING_LIST_MULTI, SPF_HELO_NONE, SPF_PASS, URIBL_BLOCKED,
 USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0
Received: from mail.kernel.org (mail.kernel.org [198.145.29.99])
 by smtp.lore.kernel.org (Postfix) with ESMTP id 36AFAC63777
 for <linux-fbdev@archiver.kernel.org>;
 Sat, 28 Nov 2020 22:43:26 +0000 (UTC)
Received: from vger.kernel.org (vger.kernel.org [23.128.96.18])
 by mail.kernel.org (Postfix) with ESMTP id 04DE620771
 for <linux-fbdev@archiver.kernel.org>;
 Sat, 28 Nov 2020 22:43:25 +0000 (UTC)
Authentication-Results: mail.kernel.org;
 dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com
 header.b="kbvH5lO6"
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
 id S1730045AbgK1WnQ (ORCPT <rfc822; linux-fbdev@archiver.kernel.org>);
 Sat, 28 Nov 2020 17:43:16 -0500
Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49322 "EHLO
 lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by
 vger.kernel.org with ESMTP id S1729806AbgK1WnP (ORCPT
 <rfc822;linux-fbdev@vger.kernel.org>);
 Sat, 28 Nov 2020 17:43:15 -0500
Received: from mail-lf1-x144.google.com (mail-lf1-x144.google.com
 [IPv6:2a00:1450:4864:20::144])
 by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 23526C08E861
 for <linux-fbdev@vger.kernel.org>;
 Sat, 28 Nov 2020 14:42:11 -0800 (PST)
Received: by mail-lf1-x144.google.com with SMTP id d8so12778439lfa.1
 for <linux-fbdev@vger.kernel.org>;
 Sat, 28 Nov 2020 14:42:11 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;
 h=sender:from:to:cc:subject:date:message-id:in-reply-to:references
 :mime-version:content-transfer-encoding;
 bh=CjZfskooFlaX/DGp4t6swfhL0OZzCmQsrAHog/enb2E=;
 b=kbvH5lO6M/0b24ppZEXXjkELi137m8NHaDUi5sHcw9rgj9eEAMN+y8qSrVKSah43ZB
 kNzlmzEdaaOYOIiqJKn1QuTx4HECFGiNG5kIYtZVLjmzMMCYE8XksdHL9QrRejfF2L4k
 tc+pZ7F6yRNKZTfx/4k0M/8aHNQca6Le//TxOPNQg21tKPG0fpjao+tSkG0zUUx4C/p4
 Do2QuSanQTDFC5byyaFn272MmfSydSeWIcEeX7J1u6P/GHak3TWpJ9leOcXx3/rkepbU
 0rENcy6xxB0X63NjVUvqHntifA7cH13M+jadh0Cqw6o1lQjgi4jhld/Dj9XzIOnlgCBa
 Rg6g==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20161025;
 h=x-gm-message-state:sender:from:to:cc:subject:date:message-id
 :in-reply-to:references:mime-version:content-transfer-encoding;
 bh=CjZfskooFlaX/DGp4t6swfhL0OZzCmQsrAHog/enb2E=;
 b=c88pPIAdexRljtxSHPXZ8qwk2huLTDxDV8bpSoRPCAtvlzVblw6BuvlZvud0ec2K+z
 qanGkLulBFN5UKD9WzpWqsiO8A6a619PPH6QDZCfzH37O/vAzrmXUF9NxG4Wve/I+yl4
 Tt2k8IiE5FjVU4wPok+WJJt6yiFJihfC7ew/YlZyeiTzUCTQ5ucu9kqHrvHb04JIHt+p
 StCh6h0AVDrfiSx+a59/5KYkfjBlq6z0PUoScrSkFkeTuFFNZKg29Z03SFSqVaqsroaV
 j5YiT49IGlzHyRwQ5g+BslijYzhLje+s/7ktyRn2EFiNdGMnyEExHgcVRPGfoDzH87N4
 XJgA==
X-Gm-Message-State: AOAM5339PZ7KTkY47l1ETZb/gH8et6qvofIKvaRkosx321vwAwdpu7QR
 GrakIv0HHdZcQKMTtnkZLrRpNKuNsGoKyA==
X-Google-Smtp-Source: ABdhPJw+VsDQ4zX/JWQzp6JQylXffQeZeYKR1WVyqNC7V1IDBPsnpo4ION23xSBTKahJANEMfTaLxA==
X-Received: by 2002:a05:6512:5d7:: with SMTP id
 o23mr6317203lfo.272.1606603329464; 
 Sat, 28 Nov 2020 14:42:09 -0800 (PST)
Received: from saturn.localdomain ([2a00:fd00:8060:1c00:a4c7:9ff9:a160:aad0])
 by smtp.gmail.com with ESMTPSA id
 w21sm1236857lff.280.2020.11.28.14.42.07
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Sat, 28 Nov 2020 14:42:08 -0800 (PST)
Sender: Sam Ravnborg <sam.ravnborg@gmail.com>
From: Sam Ravnborg <sam@ravnborg.org>
To: linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org,
 Lee Jones <lee.jones@linaro.org>
Cc: Aditya Pakki <pakki001@umn.edu>,
 Alexander Klimov <grandmaster@al2klimov.de>,
 Alex Dewar <alex.dewar90@gmail.com>, Antonino Daplas <adaplas@gmail.com>,
 Arnd Bergmann <arnd@arndb.de>,
 Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
 Benjamin Herrenschmidt <benh@kernel.crashing.org>,
 Daniel Vetter <daniel.vetter@ffwll.ch>, Evgeny Novikov <novikov@ispras.ru>,
 Florian Tobias Schandinat <FlorianSchandinat@gmx.de>,
 George Kennedy <george.kennedy@oracle.com>,
 Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
 Gustavo Silva <gustavoars@kernel.org>,
 Jani Nikula <jani.nikula@intel.com>, Jason Yan <yanaijie@huawei.com>,
 Jingoo Han <jingoohan1@gmail.com>, Jiri Slaby <jirislaby@kernel.org>,
 Joe Perches <joe@perches.com>,
 Kristoffer Ericson <kristoffer.ericson@gmail.com>,
 Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
 Mike Rapoport <rppt@kernel.org>,
 Nathan Chancellor <natechancellor@gmail.com>,
 Peilin Ye <yepeilin.cs@gmail.com>, Peter Rosin <peda@axentia.se>,
 Qilong Zhang <zhangqilong3@huawei.com>,
 Randy Dunlap <rdunlap@infradead.org>,
 Saeed Mirzamohammadi <saeed.mirzamohammadi@oracle.com>,
 Sam Ravnborg <sam@ravnborg.org>,
 Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>,
 Thomas Winischhofer <thomas@winischhofer.net>,
 Thomas Zimemrmann <tzimmermann@suse.de>,
 Vaibhav Gupta <vaibhavgupta40@gmail.com>,
 Xiaofei Tan <tanxiaofei@huawei.com>, Michal Januszewski <spock@gentoo.org>
Subject: [PATCH v2 25/28] video: fbdev: uvesafb: Fix set but not used warning
Date: Sat, 28 Nov 2020 23:41:11 +0100
Message-Id: <20201128224114.1033617-26-sam@ravnborg.org>
X-Mailer: git-send-email 2.27.0
In-Reply-To: <20201128224114.1033617-1-sam@ravnborg.org>
References: <20201128224114.1033617-1-sam@ravnborg.org>
MIME-Version: 1.0
Precedence: bulk
List-ID: <linux-fbdev.vger.kernel.org>
X-Mailing-List: linux-fbdev@vger.kernel.org

Fix W=1 warning by deleting unused local variable.

v2:
  - Updated subject (Lee)

Signed-off-by: Sam Ravnborg <sam@ravnborg.org>
Cc: Michal Januszewski <spock@gentoo.org>
Cc: linux-fbdev@vger.kernel.org
Cc: Lee Jones <lee.jones@linaro.org>
---
 drivers/video/fbdev/uvesafb.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/video/fbdev/uvesafb.c b/drivers/video/fbdev/uvesafb.c
index def14ac0ebe1..8ee0fc9c63cf 100644
--- a/drivers/video/fbdev/uvesafb.c
+++ b/drivers/video/fbdev/uvesafb.c
@@ -554,12 +554,12 @@ static int uvesafb_vbe_getmodes(struct uvesafb_ktask *task,
 static int uvesafb_vbe_getpmi(struct uvesafb_ktask *task,
 			      struct uvesafb_par *par)
 {
-	int i, err;
+	int i;
 
 	uvesafb_reset(task);
 	task->t.regs.eax = 0x4f0a;
 	task->t.regs.ebx = 0x0;
-	err = uvesafb_exec(task);
+	uvesafb_exec(task);
 
 	if ((task->t.regs.eax & 0xffff) != 0x4f || task->t.regs.es < 0xc000) {
 		par->pmi_setpal = par->ypan = 0;

From patchwork Sat Nov 28 22:41:12 2020
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
X-Patchwork-Submitter: Sam Ravnborg <sam@ravnborg.org>
X-Patchwork-Id: 334540
Return-Path: <linux-fbdev-owner@kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
 aws-us-west-2-korg-lkml-1.web.codeaurora.org
X-Spam-Level: 
X-Spam-Status: No, score=-16.7 required=3.0 tests=BAYES_00,DKIM_SIGNED,
 DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,
 INCLUDES_PATCH, 
 MAILING_LIST_MULTI, SPF_HELO_NONE, SPF_PASS, URIBL_BLOCKED,
 USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0
Received: from mail.kernel.org (mail.kernel.org [198.145.29.99])
 by smtp.lore.kernel.org (Postfix) with ESMTP id 693B1C63777
 for <linux-fbdev@archiver.kernel.org>;
 Sat, 28 Nov 2020 22:43:35 +0000 (UTC)
Received: from vger.kernel.org (vger.kernel.org [23.128.96.18])
 by mail.kernel.org (Postfix) with ESMTP id 2D64F20771
 for <linux-fbdev@archiver.kernel.org>;
 Sat, 28 Nov 2020 22:43:35 +0000 (UTC)
Authentication-Results: mail.kernel.org;
 dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com
 header.b="VoeefBvO"
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
 id S1732694AbgK1Wne (ORCPT <rfc822; linux-fbdev@archiver.kernel.org>);
 Sat, 28 Nov 2020 17:43:34 -0500
Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49444 "EHLO
 lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by
 vger.kernel.org with ESMTP id S1732712AbgK1Wne (ORCPT
 <rfc822;linux-fbdev@vger.kernel.org>);
 Sat, 28 Nov 2020 17:43:34 -0500
Received: from mail-lj1-x241.google.com (mail-lj1-x241.google.com
 [IPv6:2a00:1450:4864:20::241])
 by lindbergh.monkeyblade.net (Postfix) with ESMTPS id F37F0C08E862
 for <linux-fbdev@vger.kernel.org>;
 Sat, 28 Nov 2020 14:42:12 -0800 (PST)
Received: by mail-lj1-x241.google.com with SMTP id f18so10580150ljg.9
 for <linux-fbdev@vger.kernel.org>;
 Sat, 28 Nov 2020 14:42:12 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;
 h=sender:from:to:cc:subject:date:message-id:in-reply-to:references
 :mime-version:content-transfer-encoding;
 bh=ZRt4lLEdkGpEheHIyz2EqOhIIOjIMs1Mga1VdLe78eQ=;
 b=VoeefBvOMOJ6OPNTHJueecfrE6MmXuxLmNAA7cf5fmmxdPCgKYiwLWmH2i/opDC6sb
 t2wUpQXZ0vl5Aq+uHV8XCavGj69kuY9c/wcywlu+r13J3tGkHyrSdt5gMtmDv1Or3Ieo
 yd4NDx9JHaO3gnY3c+ayBjJbt6aOVoHx11VW2VKsVwOOiaPXataGW/2aFjxZPHDZzRnR
 XWtn5MCmb/sz+kQbC/3AxqOkJtdleD6MXcqtqkossYU0oqoWKpofMfqz2eMEv2PIxj1k
 Gs2DOrVRDxy78Lc4rwOQt6RY8+A6k13+Er2FE81M5dM0UojhZULp9TpP5VCeNlliMwkz
 MosQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20161025;
 h=x-gm-message-state:sender:from:to:cc:subject:date:message-id
 :in-reply-to:references:mime-version:content-transfer-encoding;
 bh=ZRt4lLEdkGpEheHIyz2EqOhIIOjIMs1Mga1VdLe78eQ=;
 b=G2hN3cUBBoqqNLzTXNcmsBpovOEcUXPh9aLC3XfPtNms3hSHRQDWu96kVJoSHiRJ0r
 pqs9WBwPQsr3h6s3QJBzIm/hGSGFRntifmdi7/Sem9CM/EtbLwuhHlirrvcFVN1sBKYG
 I/hzh49KitLUbqyDmAINRSB3f6cqgD3TyauULqUezBn+o1avI0BWJwq1TPqjLm3NgZW2
 9Oc7dbxTmhi1BTYEyNIrZ0ZJnN45+OzSG0cGy90vZ2pQMTw8iLq6n308KV4KKZktk7F2
 KRifLHKMZBWo1EANaE3YW1RHUVVmAYng93nETzryTm7822qs3tCusIWkcEd3qIdTQsuu
 C/Mg==
X-Gm-Message-State: AOAM533FMZgs/zGrrwv8Rwuox2HLEEsxzG43pDsixs/H10fxLh6NNSr2
 XxbOzv+DTvGCR8tISH3es5uXWOzctjUCnA==
X-Google-Smtp-Source: ABdhPJw5sH53JFBNC5Ek0t8nEkH9FBrmhoJ3Sp4EDqPZMMaNkgPKGnG3059fsYGH0P8ePoAWQa4rXg==
X-Received: by 2002:a2e:2416:: with SMTP id k22mr6507511ljk.201.1606603331314; 
 Sat, 28 Nov 2020 14:42:11 -0800 (PST)
Received: from saturn.localdomain ([2a00:fd00:8060:1c00:a4c7:9ff9:a160:aad0])
 by smtp.gmail.com with ESMTPSA id
 w21sm1236857lff.280.2020.11.28.14.42.09
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Sat, 28 Nov 2020 14:42:10 -0800 (PST)
Sender: Sam Ravnborg <sam.ravnborg@gmail.com>
From: Sam Ravnborg <sam@ravnborg.org>
To: linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org,
 Lee Jones <lee.jones@linaro.org>
Cc: Aditya Pakki <pakki001@umn.edu>,
 Alexander Klimov <grandmaster@al2klimov.de>,
 Alex Dewar <alex.dewar90@gmail.com>, Antonino Daplas <adaplas@gmail.com>,
 Arnd Bergmann <arnd@arndb.de>,
 Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
 Benjamin Herrenschmidt <benh@kernel.crashing.org>,
 Daniel Vetter <daniel.vetter@ffwll.ch>, Evgeny Novikov <novikov@ispras.ru>,
 Florian Tobias Schandinat <FlorianSchandinat@gmx.de>,
 George Kennedy <george.kennedy@oracle.com>,
 Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
 Gustavo Silva <gustavoars@kernel.org>,
 Jani Nikula <jani.nikula@intel.com>, Jason Yan <yanaijie@huawei.com>,
 Jingoo Han <jingoohan1@gmail.com>, Jiri Slaby <jirislaby@kernel.org>,
 Joe Perches <joe@perches.com>,
 Kristoffer Ericson <kristoffer.ericson@gmail.com>,
 Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
 Mike Rapoport <rppt@kernel.org>,
 Nathan Chancellor <natechancellor@gmail.com>,
 Peilin Ye <yepeilin.cs@gmail.com>, Peter Rosin <peda@axentia.se>,
 Qilong Zhang <zhangqilong3@huawei.com>,
 Randy Dunlap <rdunlap@infradead.org>,
 Saeed Mirzamohammadi <saeed.mirzamohammadi@oracle.com>,
 Sam Ravnborg <sam@ravnborg.org>,
 Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>,
 Thomas Winischhofer <thomas@winischhofer.net>,
 Thomas Zimemrmann <tzimmermann@suse.de>,
 Vaibhav Gupta <vaibhavgupta40@gmail.com>,
 Xiaofei Tan <tanxiaofei@huawei.com>, Michal Januszewski <spock@gentoo.org>
Subject: [PATCH v2 26/28] video: fbdev: uvesafb: Fix string related warnings
Date: Sat, 28 Nov 2020 23:41:12 +0100
Message-Id: <20201128224114.1033617-27-sam@ravnborg.org>
X-Mailer: git-send-email 2.27.0
In-Reply-To: <20201128224114.1033617-1-sam@ravnborg.org>
References: <20201128224114.1033617-1-sam@ravnborg.org>
MIME-Version: 1.0
Precedence: bulk
List-ID: <linux-fbdev.vger.kernel.org>
X-Mailing-List: linux-fbdev@vger.kernel.org

Two W=1 string related warnings.
- Using strncpy to copy string without null-termination generates a
  warning.  Use memcpy to copy only the relevant chars

- Fix a potential bug with a very long string, subtract one from the
  length to make room for the termination null.

Signed-off-by: Sam Ravnborg <sam@ravnborg.org>
Cc: Michal Januszewski <spock@gentoo.org>
Cc: linux-fbdev@vger.kernel.org
---
 drivers/video/fbdev/uvesafb.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/video/fbdev/uvesafb.c b/drivers/video/fbdev/uvesafb.c
index 8ee0fc9c63cf..45dc8da191e4 100644
--- a/drivers/video/fbdev/uvesafb.c
+++ b/drivers/video/fbdev/uvesafb.c
@@ -423,7 +423,7 @@ static int uvesafb_vbe_getinfo(struct uvesafb_ktask *task,
 	task->t.flags = TF_VBEIB;
 	task->t.buf_len = sizeof(struct vbe_ib);
 	task->buf = &par->vbe_ib;
-	strncpy(par->vbe_ib.vbe_signature, "VBE2", 4);
+	memcpy(par->vbe_ib.vbe_signature, "VBE2", 4);
 
 	err = uvesafb_exec(task);
 	if (err || (task->t.regs.eax & 0xffff) != 0x004f) {
@@ -1871,7 +1871,7 @@ static ssize_t v86d_show(struct device_driver *dev, char *buf)
 static ssize_t v86d_store(struct device_driver *dev, const char *buf,
 		size_t count)
 {
-	strncpy(v86d_path, buf, PATH_MAX);
+	strncpy(v86d_path, buf, PATH_MAX - 1);
 	return count;
 }
 static DRIVER_ATTR_RW(v86d);

From patchwork Sat Nov 28 22:41:13 2020
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
X-Patchwork-Submitter: Sam Ravnborg <sam@ravnborg.org>
X-Patchwork-Id: 334258
Return-Path: <linux-fbdev-owner@kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
 aws-us-west-2-korg-lkml-1.web.codeaurora.org
X-Spam-Level: 
X-Spam-Status: No, score=-16.7 required=3.0 tests=BAYES_00,DKIM_SIGNED,
 DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,
 INCLUDES_PATCH, 
 MAILING_LIST_MULTI, SPF_HELO_NONE, SPF_PASS, URIBL_BLOCKED,
 USER_AGENT_GIT
 autolearn=unavailable autolearn_force=no version=3.4.0
Received: from mail.kernel.org (mail.kernel.org [198.145.29.99])
 by smtp.lore.kernel.org (Postfix) with ESMTP id 12E3DC63798
 for <linux-fbdev@archiver.kernel.org>;
 Sat, 28 Nov 2020 22:43:26 +0000 (UTC)
Received: from vger.kernel.org (vger.kernel.org [23.128.96.18])
 by mail.kernel.org (Postfix) with ESMTP id CEA9020702
 for <linux-fbdev@archiver.kernel.org>;
 Sat, 28 Nov 2020 22:43:25 +0000 (UTC)
Authentication-Results: mail.kernel.org;
 dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com
 header.b="A4+pA68y"
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
 id S2388271AbgK1WnK (ORCPT <rfc822; linux-fbdev@archiver.kernel.org>);
 Sat, 28 Nov 2020 17:43:10 -0500
Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49326 "EHLO
 lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by
 vger.kernel.org with ESMTP id S2388310AbgK1WnJ (ORCPT
 <rfc822;linux-fbdev@vger.kernel.org>);
 Sat, 28 Nov 2020 17:43:09 -0500
Received: from mail-lj1-x241.google.com (mail-lj1-x241.google.com
 [IPv6:2a00:1450:4864:20::241])
 by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D6CCDC0613D2
 for <linux-fbdev@vger.kernel.org>;
 Sat, 28 Nov 2020 14:42:14 -0800 (PST)
Received: by mail-lj1-x241.google.com with SMTP id s9so10558405ljo.11
 for <linux-fbdev@vger.kernel.org>;
 Sat, 28 Nov 2020 14:42:14 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;
 h=sender:from:to:cc:subject:date:message-id:in-reply-to:references
 :mime-version:content-transfer-encoding;
 bh=BP0tdGdOicm/g6FYqITXj/E741V7SOdfxHbuSnOa2vI=;
 b=A4+pA68yf5NQVAPnKHbZYVBDWIiXGs+Bvvu5J6D3tuTktlHbucucuyXSkvyUy1Z1ad
 qugn8GtpY2nk3MyGG1NB0/O+SXqhFzV50AwcMgZMDEIzlcPovhiNq/Vp3PCTW362qNUS
 akY1e5rXqcvvcDXERh7JZfSHWjcCL7TT1XmLL6eKoNkpqDIadVv/n/BApO2EhP/R519x
 Xwk9g4doicNQ+LGaenNYRm+DemOqIRzrgbI3ZIYi5/QYHt4ULU/wupW4572a5bKokc1P
 GCVqE5qF8LeEuIz06k9OEgsBZgfX2rLwP5Lto5zDv6y9chUDrSbEr65fc8MNx0jvyhTX
 Xoag==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20161025;
 h=x-gm-message-state:sender:from:to:cc:subject:date:message-id
 :in-reply-to:references:mime-version:content-transfer-encoding;
 bh=BP0tdGdOicm/g6FYqITXj/E741V7SOdfxHbuSnOa2vI=;
 b=LW4GJGtoMntx4KhtNm+tG+g57nO1EXwacXzeWdqQnQDW7DrW3fWmp0ndKd9jLcu8MU
 v96QfKvecSob9Kgjt0P5l8E4V90eDO+bZE6t2AelEcgU1JMQelpAIU4gMZJVr90SOAwc
 xihO1hTccjohy24gYLsuxnOTKHoY2uN8XsFV8dT/WKCYrFr9fo8NMyhrghvMAi7r62Ge
 99BZKtPTG9H7CHA0Gke0L2POYNVg2p1aw9cRbDQTJDXH993ReHbQhvLsM8F3rIcz2VS5
 AJyni3KduCR9rp6/XH7WsAsbPLopl2QBUdGP2eaxIOfnP74CwbN1PDtV6tor6palLQkD
 2Rlw==
X-Gm-Message-State: AOAM531HYFdv/rOzv0/YBqC4GmFeEnF34zuqut7s7O6VE4KH1CtsyryI
 oKoEQTj8gW9ZLXiKXiw0y5ZLpdaQbKIW1A==
X-Google-Smtp-Source: ABdhPJwwf1ZWhffUvstO1LtukDoI2Zp+qJq1Q3l5sM/werUk5+/LklnUG0w4Xy6qOp1ekvjP6B84Ew==
X-Received: by 2002:a2e:888a:: with SMTP id k10mr6395463lji.341.1606603333226; 
 Sat, 28 Nov 2020 14:42:13 -0800 (PST)
Received: from saturn.localdomain ([2a00:fd00:8060:1c00:a4c7:9ff9:a160:aad0])
 by smtp.gmail.com with ESMTPSA id
 w21sm1236857lff.280.2020.11.28.14.42.11
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Sat, 28 Nov 2020 14:42:12 -0800 (PST)
Sender: Sam Ravnborg <sam.ravnborg@gmail.com>
From: Sam Ravnborg <sam@ravnborg.org>
To: linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org,
 Lee Jones <lee.jones@linaro.org>
Cc: Aditya Pakki <pakki001@umn.edu>,
 Alexander Klimov <grandmaster@al2klimov.de>,
 Alex Dewar <alex.dewar90@gmail.com>, Antonino Daplas <adaplas@gmail.com>,
 Arnd Bergmann <arnd@arndb.de>,
 Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
 Benjamin Herrenschmidt <benh@kernel.crashing.org>,
 Daniel Vetter <daniel.vetter@ffwll.ch>, Evgeny Novikov <novikov@ispras.ru>,
 Florian Tobias Schandinat <FlorianSchandinat@gmx.de>,
 George Kennedy <george.kennedy@oracle.com>,
 Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
 Gustavo Silva <gustavoars@kernel.org>,
 Jani Nikula <jani.nikula@intel.com>, Jason Yan <yanaijie@huawei.com>,
 Jingoo Han <jingoohan1@gmail.com>, Jiri Slaby <jirislaby@kernel.org>,
 Joe Perches <joe@perches.com>,
 Kristoffer Ericson <kristoffer.ericson@gmail.com>,
 Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
 Mike Rapoport <rppt@kernel.org>,
 Nathan Chancellor <natechancellor@gmail.com>,
 Peilin Ye <yepeilin.cs@gmail.com>, Peter Rosin <peda@axentia.se>,
 Qilong Zhang <zhangqilong3@huawei.com>,
 Randy Dunlap <rdunlap@infradead.org>,
 Saeed Mirzamohammadi <saeed.mirzamohammadi@oracle.com>,
 Sam Ravnborg <sam@ravnborg.org>,
 Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>,
 Thomas Winischhofer <thomas@winischhofer.net>,
 Thomas Zimemrmann <tzimmermann@suse.de>,
 Vaibhav Gupta <vaibhavgupta40@gmail.com>,
 Xiaofei Tan <tanxiaofei@huawei.com>
Subject: [PATCH v2 27/28] video: fbdev: cirrusfb: Fix kernel-doc and set but
 not used warnings
Date: Sat, 28 Nov 2020 23:41:13 +0100
Message-Id: <20201128224114.1033617-28-sam@ravnborg.org>
X-Mailer: git-send-email 2.27.0
In-Reply-To: <20201128224114.1033617-1-sam@ravnborg.org>
References: <20201128224114.1033617-1-sam@ravnborg.org>
MIME-Version: 1.0
Precedence: bulk
List-ID: <linux-fbdev.vger.kernel.org>
X-Mailing-List: linux-fbdev@vger.kernel.org

Fix warnings:
- drop kernel-doc for the two debug functions to avoid the warnings
- delete unused code

v2:
  - Updated subject (Lee)

Signed-off-by: Sam Ravnborg <sam@ravnborg.org>
Cc: Thomas Zimemrmann <tzimmermann@suse.de>
Cc: Sam Ravnborg <sam@ravnborg.org>
Cc: "Gustavo A. R. Silva" <gustavoars@kernel.org>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
Cc: Saeed Mirzamohammadi <saeed.mirzamohammadi@oracle.com>
Cc: Jani Nikula <jani.nikula@intel.com>
Cc: Mike Rapoport <rppt@kernel.org>
Cc: Lee Jones <lee.jones@linaro.org>
Acked-by: Thomas Zimmermann <tzimmermann@suse.de>
---
 drivers/video/fbdev/cirrusfb.c | 20 +++++++++-----------
 1 file changed, 9 insertions(+), 11 deletions(-)

diff --git a/drivers/video/fbdev/cirrusfb.c b/drivers/video/fbdev/cirrusfb.c
index e9027172c0f5..93802abbbc72 100644
--- a/drivers/video/fbdev/cirrusfb.c
+++ b/drivers/video/fbdev/cirrusfb.c
@@ -2463,8 +2463,6 @@ static void AttrOn(const struct cirrusfb_info *cinfo)
  */
 static void WHDR(const struct cirrusfb_info *cinfo, unsigned char val)
 {
-	unsigned char dummy;
-
 	if (is_laguna(cinfo))
 		return;
 	if (cinfo->btype == BT_PICASSO) {
@@ -2473,18 +2471,18 @@ static void WHDR(const struct cirrusfb_info *cinfo, unsigned char val)
 		WGen(cinfo, VGA_PEL_MSK, 0x00);
 		udelay(200);
 		/* next read dummy from pixel address (3c8) */
-		dummy = RGen(cinfo, VGA_PEL_IW);
+		RGen(cinfo, VGA_PEL_IW);
 		udelay(200);
 	}
 	/* now do the usual stuff to access the HDR */
 
-	dummy = RGen(cinfo, VGA_PEL_MSK);
+	RGen(cinfo, VGA_PEL_MSK);
 	udelay(200);
-	dummy = RGen(cinfo, VGA_PEL_MSK);
+	RGen(cinfo, VGA_PEL_MSK);
 	udelay(200);
-	dummy = RGen(cinfo, VGA_PEL_MSK);
+	RGen(cinfo, VGA_PEL_MSK);
 	udelay(200);
-	dummy = RGen(cinfo, VGA_PEL_MSK);
+	RGen(cinfo, VGA_PEL_MSK);
 	udelay(200);
 
 	WGen(cinfo, VGA_PEL_MSK, val);
@@ -2492,7 +2490,7 @@ static void WHDR(const struct cirrusfb_info *cinfo, unsigned char val)
 
 	if (cinfo->btype == BT_PICASSO) {
 		/* now first reset HDR access counter */
-		dummy = RGen(cinfo, VGA_PEL_IW);
+		RGen(cinfo, VGA_PEL_IW);
 		udelay(200);
 
 		/* and at the end, restore the mask value */
@@ -2800,9 +2798,9 @@ static void bestclock(long freq, int *nom, int *den, int *div)
 
 #ifdef CIRRUSFB_DEBUG
 
-/**
+/*
  * cirrusfb_dbg_print_regs
- * @base: If using newmmio, the newmmio base address, otherwise %NULL
+ * @regbase: If using newmmio, the newmmio base address, otherwise %NULL
  * @reg_class: type of registers to read: %CRT, or %SEQ
  *
  * DESCRIPTION:
@@ -2847,7 +2845,7 @@ static void cirrusfb_dbg_print_regs(struct fb_info *info,
 	va_end(list);
 }
 
-/**
+/*
  * cirrusfb_dbg_reg_dump
  * @base: If using newmmio, the newmmio base address, otherwise %NULL
  *

From patchwork Sat Nov 28 22:41:14 2020
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
X-Patchwork-Submitter: Sam Ravnborg <sam@ravnborg.org>
X-Patchwork-Id: 334254
Return-Path: <linux-fbdev-owner@kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
 aws-us-west-2-korg-lkml-1.web.codeaurora.org
X-Spam-Level: 
X-Spam-Status: No, score=-16.7 required=3.0 tests=BAYES_00,DKIM_SIGNED,
 DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,
 INCLUDES_PATCH, 
 MAILING_LIST_MULTI, SPF_HELO_NONE, SPF_PASS, URIBL_BLOCKED,
 USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0
Received: from mail.kernel.org (mail.kernel.org [198.145.29.99])
 by smtp.lore.kernel.org (Postfix) with ESMTP id 95121C64E7B
 for <linux-fbdev@archiver.kernel.org>;
 Sat, 28 Nov 2020 22:43:35 +0000 (UTC)
Received: from vger.kernel.org (vger.kernel.org [23.128.96.18])
 by mail.kernel.org (Postfix) with ESMTP id 60E8620702
 for <linux-fbdev@archiver.kernel.org>;
 Sat, 28 Nov 2020 22:43:35 +0000 (UTC)
Authentication-Results: mail.kernel.org;
 dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com
 header.b="NZOYx0PX"
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
 id S1732712AbgK1Wnf (ORCPT <rfc822; linux-fbdev@archiver.kernel.org>);
 Sat, 28 Nov 2020 17:43:35 -0500
Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49446 "EHLO
 lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by
 vger.kernel.org with ESMTP id S1732750AbgK1Wne (ORCPT
 <rfc822;linux-fbdev@vger.kernel.org>);
 Sat, 28 Nov 2020 17:43:34 -0500
Received: from mail-lf1-x142.google.com (mail-lf1-x142.google.com
 [IPv6:2a00:1450:4864:20::142])
 by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DD7DCC0617A7
 for <linux-fbdev@vger.kernel.org>;
 Sat, 28 Nov 2020 14:42:16 -0800 (PST)
Received: by mail-lf1-x142.google.com with SMTP id d20so12700355lfe.11
 for <linux-fbdev@vger.kernel.org>;
 Sat, 28 Nov 2020 14:42:16 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;
 h=sender:from:to:cc:subject:date:message-id:in-reply-to:references
 :mime-version:content-transfer-encoding;
 bh=/wOYQm62UhJJiBuQwa5K2rYcXYPHs0L5tvvEbAmKSNM=;
 b=NZOYx0PXz29EI6oUGn7poLQOl3WKi1JE7XojDK9qkRt1BU3tYpqof835ajOsE3bAQz
 +N1wIFEeoMctj3+aSVd02EbL/iO5MbQVuFj2whjZCstGYrBcODFncMIVBgimHZ+3a5PL
 gVh6gU41uaM1BwqVOtKHmHqGlPGOQ4X7P1PPOgKr9hpd18xx2UTiyqDaCWiKF7JkhI60
 ce3lz2iYacfvWKV7RE3bylfc1eqtTkqO4UaaaJ0zedIeRGJxwA/8gGcBcCGT4qnx8cMp
 +qPPnntEcXBIsCrEs9J+ef8eLoYGcx9H2iK6p130Rw4ddHLBj1kB0XC70pVLiYc1F2sp
 hqkA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20161025;
 h=x-gm-message-state:sender:from:to:cc:subject:date:message-id
 :in-reply-to:references:mime-version:content-transfer-encoding;
 bh=/wOYQm62UhJJiBuQwa5K2rYcXYPHs0L5tvvEbAmKSNM=;
 b=Nd2dZCpAsMVICYjg3MjTTEbLf0eGGWr3dRBzqXkAWnT9niEt+s3MK8GwOYZBB9W5TC
 Xxzj7cHnKis8YZl0o2p+zU4UgsMshlv3eMSgG/NdQ76JkZt/118kFlheChyjq0w8TnNG
 XGzy2zajJ66+SgnrdaR43SUt6yiJMO3YhY+Fb1jl++eDEMUR60f5boWTBSbC7Z5BjU1Y
 PxaN8i2XP6gptDXW/rhNOpdjCJf1y4iKnAFx57S1IvBsbTPKJ1lxDuwtTFRJIiLV20Dk
 UV1/jRkqR3tXjqRSsXoan1WK2vZr/7P+U6mVI0KAThfk9OrWRGuoMpWposbQCLXaCf5Z
 Hu3w==
X-Gm-Message-State: AOAM530yEJi7kL6DFHpsXK3CxnKxwFG47hD4b4EwzzqlidwBcyLHxjqx
 cGeA/5nh1H4FIQL2ggS62QQ2s4s8W8SM+A==
X-Google-Smtp-Source: ABdhPJwgu41H0h4BWPxtxzUlLXhRkkdQIo57ciP/l1l7Li+YJUMCKjT0gBiawsB+TaPikmiXCZpNPg==
X-Received: by 2002:a19:4915:: with SMTP id w21mr6485130lfa.57.1606603335224; 
 Sat, 28 Nov 2020 14:42:15 -0800 (PST)
Received: from saturn.localdomain ([2a00:fd00:8060:1c00:a4c7:9ff9:a160:aad0])
 by smtp.gmail.com with ESMTPSA id
 w21sm1236857lff.280.2020.11.28.14.42.13
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Sat, 28 Nov 2020 14:42:14 -0800 (PST)
Sender: Sam Ravnborg <sam.ravnborg@gmail.com>
From: Sam Ravnborg <sam@ravnborg.org>
To: linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org,
 Lee Jones <lee.jones@linaro.org>
Cc: Aditya Pakki <pakki001@umn.edu>,
 Alexander Klimov <grandmaster@al2klimov.de>,
 Alex Dewar <alex.dewar90@gmail.com>, Antonino Daplas <adaplas@gmail.com>,
 Arnd Bergmann <arnd@arndb.de>,
 Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
 Benjamin Herrenschmidt <benh@kernel.crashing.org>,
 Daniel Vetter <daniel.vetter@ffwll.ch>, Evgeny Novikov <novikov@ispras.ru>,
 Florian Tobias Schandinat <FlorianSchandinat@gmx.de>,
 George Kennedy <george.kennedy@oracle.com>,
 Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
 Gustavo Silva <gustavoars@kernel.org>,
 Jani Nikula <jani.nikula@intel.com>, Jason Yan <yanaijie@huawei.com>,
 Jingoo Han <jingoohan1@gmail.com>, Jiri Slaby <jirislaby@kernel.org>,
 Joe Perches <joe@perches.com>,
 Kristoffer Ericson <kristoffer.ericson@gmail.com>,
 Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
 Mike Rapoport <rppt@kernel.org>,
 Nathan Chancellor <natechancellor@gmail.com>,
 Peilin Ye <yepeilin.cs@gmail.com>, Peter Rosin <peda@axentia.se>,
 Qilong Zhang <zhangqilong3@huawei.com>,
 Randy Dunlap <rdunlap@infradead.org>,
 Saeed Mirzamohammadi <saeed.mirzamohammadi@oracle.com>,
 Sam Ravnborg <sam@ravnborg.org>,
 Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>,
 Thomas Winischhofer <thomas@winischhofer.net>,
 Thomas Zimemrmann <tzimmermann@suse.de>,
 Vaibhav Gupta <vaibhavgupta40@gmail.com>,
 Xiaofei Tan <tanxiaofei@huawei.com>
Subject: [PATCH v2 28/28] video: fbdev: s1d13xxxfb: Fix kernel-doc and set
 but not used warnings
Date: Sat, 28 Nov 2020 23:41:14 +0100
Message-Id: <20201128224114.1033617-29-sam@ravnborg.org>
X-Mailer: git-send-email 2.27.0
In-Reply-To: <20201128224114.1033617-1-sam@ravnborg.org>
References: <20201128224114.1033617-1-sam@ravnborg.org>
MIME-Version: 1.0
Precedence: bulk
List-ID: <linux-fbdev.vger.kernel.org>
X-Mailing-List: linux-fbdev@vger.kernel.org

Fix following W=1 warnings:
- Fix set but not nused variables which was used only for logging.
  Fixed by introducing no_printk() to trick compiler to think variables
  are used
- Fix kernel-doc warning by deleting an empty comment line

v2:
  - Subject updated (Lee)

Signed-off-by: Sam Ravnborg <sam@ravnborg.org>
Cc: Kristoffer Ericson <kristoffer.ericson@gmail.com>
Cc: Lee Jones <lee.jones@linaro.org>
Reviewed-by: Thomas Zimmermann <tzimmermann@suse.de>
---
 drivers/video/fbdev/s1d13xxxfb.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/video/fbdev/s1d13xxxfb.c b/drivers/video/fbdev/s1d13xxxfb.c
index 4541afcf9386..d1b5f965bc96 100644
--- a/drivers/video/fbdev/s1d13xxxfb.c
+++ b/drivers/video/fbdev/s1d13xxxfb.c
@@ -45,7 +45,7 @@
 #if 0
 #define dbg(fmt, args...) do { printk(KERN_INFO fmt, ## args); } while(0)
 #else
-#define dbg(fmt, args...) do { } while (0)
+#define dbg(fmt, args...) do { no_printk(KERN_INFO fmt, ## args); } while (0)
 #endif
 
 /*
@@ -512,7 +512,6 @@ s1d13xxxfb_bitblt_copyarea(struct fb_info *info, const struct fb_copyarea *area)
 }
 
 /**
- *
  *	s1d13xxxfb_bitblt_solidfill - accelerated solidfill function
  *	@info : framebuffer structure
  *	@rect : fb_fillrect structure