From patchwork Mon Nov 23 21:44:38 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Linus Walleij X-Patchwork-Id: 330688 Delivered-To: patch@linaro.org Received: by 2002:a17:907:2110:0:0:0:0 with SMTP id qn16csp3860031ejb; Mon, 23 Nov 2020 13:44:52 -0800 (PST) X-Google-Smtp-Source: ABdhPJzsHBV45Wu+6DOnK3/miVNs9pyFqk0OXmF5g6yKSBhiHQOXRvvELPoc7b4WoU4rzbxmUTu6 X-Received: by 2002:aa7:c546:: with SMTP id s6mr1169359edr.114.1606167892676; Mon, 23 Nov 2020 13:44:52 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1606167892; cv=none; d=google.com; s=arc-20160816; b=x/xf8iPLQyO8JoYIXMdBIQod7AaTcAn1BfJ1WjhGxIupdSKM5o8I2k/Sa3Qp6FmWLk nN3t8LruuARomViv885fbLbhIqeImu99FaqF89HeednqsXayW1lQYey0WeLE2Dk04PI/ XPArJKvqVn4S5kKN790kzi5o+XVcpas/8/C0kaPBN+k6KPHP8Dvi+dqCiowHIharwA3Y swCdjpQ15KScZu7c/J5L4kNP94TOI8JlviBBAbZ0gKGv+8dV+Yv5Cd+Bn1j2b/ILTW1k ikTq5J5wOOKjvJ2vXy6EiXdEWcAADGFCiJgjNG1NBYtE7s7113mhEmIOkcsGrK/HnwI6 gWvg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=/YxkbAEJoDzP9KLF30Xn81dZ8K8UjGAlhsR7RpyDfp4=; b=PETjPhPu3ai0p/nZAa2jkJISd5SylM6UsdkYMt4fCR6kY3U0VDIVJS/mmeQN8Cgopu 2G5RM2xCT/0mznKbBBJyRDEj1nWD33bgU23V33Z4hDB9fkPO2DctBZ/o63pdTeeydS9R 8DDl1ne5Ei4QpG2ylo5WoRDw7HAy1j4UsEzXM1yEphoE8FHIKU4uobrrAst81+5Am+Qe Ea9Eb6XOcQm/MF1uoL7gyJHW+fuKWKJWGP/QPSvh2m2ZuoI6GBRaf3a9nzjm1I+/byzs +LbuC9qY39wtKnj0VcaRG+hTMuVDjJr0e3hBqwrY2YjViel9DuSVUhxNpGrvnM+w4GaN Q/dw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=v7A0H3RX; spf=pass (google.com: domain of linux-leds-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-leds-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id be11si7076134edb.164.2020.11.23.13.44.52 for ; Mon, 23 Nov 2020 13:44:52 -0800 (PST) Received-SPF: pass (google.com: domain of linux-leds-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=v7A0H3RX; spf=pass (google.com: domain of linux-leds-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-leds-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730786AbgKWVow (ORCPT ); Mon, 23 Nov 2020 16:44:52 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57222 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730374AbgKWVov (ORCPT ); Mon, 23 Nov 2020 16:44:51 -0500 Received: from mail-lj1-x22c.google.com (mail-lj1-x22c.google.com [IPv6:2a00:1450:4864:20::22c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 52D40C061A4D for ; Mon, 23 Nov 2020 13:44:51 -0800 (PST) Received: by mail-lj1-x22c.google.com with SMTP id s9so19635212ljo.11 for ; Mon, 23 Nov 2020 13:44:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=/YxkbAEJoDzP9KLF30Xn81dZ8K8UjGAlhsR7RpyDfp4=; b=v7A0H3RXtNZYr9EOXz4a+9Txd9mDTmUn0Nz0fBYinQdkwQKNtmz1OUA29Kxu7LEeav yhk1zGuY3AQ8R1aMBCiCB1eU4NoEMsrUEXJfJ64ShwRU4fzvt0rkLzjs+T2E1fte/2ei 3p7rB1R15gD1G4sTBkE5uT16EDO04351pPeQyspRQUoPcOfBSoSqEzEfZjCMmdmyZPGd an8lzLkposEDFz2o638PFOjZL2vNcw8X4Gsy1jHZBovW7qO9AxpJDNIASrmZE7JlHNFt Usww6CiOgpx8DZvwncgn+MfUT++X2twH3AjJUXNxSflKJ+Ywz5sAecLdnNEWuqO08CxO Wgzw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=/YxkbAEJoDzP9KLF30Xn81dZ8K8UjGAlhsR7RpyDfp4=; b=ojdb8e8OgZr1hOtbIhwEq/9hesR6rSYnBOteBkjKh2hHKI0TnOuADQlpUJcZ16hlP7 U7xoTqnwRz+4PgVQNXv8Ct/PdNJ5c5YT5zmEsgVWF1nQRqmxTzaZ+6swmFESSV8j7hOR sQ0bDnMe8ncWOel+PzItkmDwWHeuc4HQMFz342s7FquURGJDrQSz7w24Zm0oRalkxRsF BKQroNbh3q+3ctLFK/9N+WN6wIGzRdZwhNe3McQeZXiBdO9pn+KoPmZqEZgVj1dndd6y a/eQzTWvtqv6dqZcAnFxcPxdg3Zu3aDkIBhIZoiZ3Igy49dSKpoo3Rsup4dEI5RWIHub JGHg== X-Gm-Message-State: AOAM532TFu5sJlqKcXrIddOgt9KLYVPW2jALjKowx47KFUaeWoI3E3kM 6d2QX1vik35DmAeaei/WVmveOw== X-Received: by 2002:a05:651c:299:: with SMTP id b25mr598045ljo.16.1606167889784; Mon, 23 Nov 2020 13:44:49 -0800 (PST) Received: from localhost.bredbandsbolaget (c-92d7225c.014-348-6c756e10.bbcust.telenor.se. [92.34.215.146]) by smtp.gmail.com with ESMTPSA id 16sm1505036lfk.186.2020.11.23.13.44.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 23 Nov 2020 13:44:49 -0800 (PST) From: Linus Walleij To: Jacek Anaszewski , Pavel Machek , Dan Murphy Cc: linux-leds@vger.kernel.org, Linus Walleij , Sakari Ailus , newbytee@protonmail.com, Stephan Gerhold , phone-devel@vger.kernel.org, linux-media@vger.kernel.org, devicetree@vger.kernel.org Subject: [PATCH 1/2 v6] dt-bindings: leds: Add DT binding for Richtek RT8515 Date: Mon, 23 Nov 2020 22:44:38 +0100 Message-Id: <20201123214439.1279464-1-linus.walleij@linaro.org> X-Mailer: git-send-email 2.26.2 MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-leds@vger.kernel.org Add a YAML devicetree binding for the Richtek RT8515 dual channel flash/torch LED driver. Cc: Sakari Ailus Cc: newbytee@protonmail.com Cc: Stephan Gerhold Cc: phone-devel@vger.kernel.org Cc: linux-media@vger.kernel.org Cc: devicetree@vger.kernel.org Signed-off-by: Linus Walleij --- ChangeLog v5->v6: - Use the suffix -ohms for the resistor values as this gets recognized by default by dtschema and is nominal. ChangeLog v4->v5: - Fix the RFS/RTS resistors to reference the u32 schema. - Fix resisitor speling error. ChangeLog v3->v4: - Add DT attributes for the RFS and RTS resistors, so that the hardware-defined maximum current can be determined. - Add torch-max-microamp to the common bindings so we can set an attribute for the max microamp in torch mode. - Add flash-max-microamp and torch-max-microamp as optional to the LED node. - Slot in some elabortative descriptions of the new properties and describe what the hardware is doing. - Cc phone-devel@vger.kernel.org ChangeLog v2->v3: - Add Sakari to CC - Resend ChangeLog v1->v2: - Explicitly inherit function, color and flash-max-timeout-us from common.yaml - Add "led" node as required. --- .../devicetree/bindings/leds/common.yaml | 6 + .../bindings/leds/richtek,rt8515.yaml | 109 ++++++++++++++++++ 2 files changed, 115 insertions(+) create mode 100644 Documentation/devicetree/bindings/leds/richtek,rt8515.yaml -- 2.26.2 Reviewed-by: Sakari Ailus diff --git a/Documentation/devicetree/bindings/leds/common.yaml b/Documentation/devicetree/bindings/leds/common.yaml index f1211e7045f1..92fa90b4a671 100644 --- a/Documentation/devicetree/bindings/leds/common.yaml +++ b/Documentation/devicetree/bindings/leds/common.yaml @@ -151,6 +151,12 @@ properties: Maximum flash LED supply current in microamperes. Required for flash LED nodes with configurable current. + torch-max-microamp: + description: + Maximum flash LED supply current in microamperes, when the flash LED is + used as a torch (flashlight). This is usually lower than the flash mode + maximum current, if the LED supports torch mode. + flash-max-timeout-us: description: Maximum timeout in microseconds after which the flash LED is turned off. diff --git a/Documentation/devicetree/bindings/leds/richtek,rt8515.yaml b/Documentation/devicetree/bindings/leds/richtek,rt8515.yaml new file mode 100644 index 000000000000..b2022cb3ee1c --- /dev/null +++ b/Documentation/devicetree/bindings/leds/richtek,rt8515.yaml @@ -0,0 +1,109 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/leds/richtek,rt8515.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Richtek RT8515 1.5A dual channel LED driver + +maintainers: + - Linus Walleij + +description: | + The Richtek RT8515 is a dual channel (two mode) LED driver that + supports driving a white LED in flash or torch mode. The maximum + current for each mode is defined in hardware using two resistors + RFS and RTS. + +properties: + compatible: + const: richtek,rt8515 + + enf-gpios: + maxItems: 1 + description: A connection to the 'ENF' (enable flash) pin. + + ent-gpios: + maxItems: 1 + description: A connection to the 'ENT' (enable torch) pin. + + richtek,rfs-ohms: + minimum: 7680 + maximum: 367000 + description: The resistance value of the RFS resistor. This + resistors limits the maximum flash current. This must be set + for the property flash-max-microamp to work, the RFS resistor + defines the range of the dimmer setting (brightness) of the + flash LED. + + richtek,rts-ohms: + minimum: 7680 + maximum: 367000 + description: The resistance value of the RTS resistor. This + resistors limits the maximum torch current. This must be set + for the property torch-max-microamp to work, the RTS resistor + defines the range of the dimmer setting (brightness) of the + torch LED. + + led: + type: object + $ref: common.yaml# + properties: + function: true + color: true + flash-max-timeout-us: true + + flash-max-microamp: + maximum: 700000 + description: The maximum current for flash mode + is hardwired to the component using the RFS resistor to + ground. The maximum hardware current setting is calculated + according to the formula Imax = 5500 / RFS. The lowest + allowed resistance value is 7.86 kOhm giving an absolute + maximum current of 700mA. By setting this attribute in + the device tree, you can further restrict the maximum + current below the hardware limit. This requires the RFS + to be defined as it defines the maximum range. + + torch-max-microamp: + maximum: 700000 + description: The maximum current for torch mode + is hardwired to the component using the RTS resistor to + ground. The maximum hardware current setting is calculated + according to the formula Imax = 5500 / RTS. The lowest + allowed resistance value is 7.86 kOhm giving an absolute + maximum current of 700mA. By setting this attribute in + the device tree, you can further restrict the maximum + current below the hardware limit. This requires the RTS + to be defined as it defines the maximum range. + +required: + - compatible + - ent-gpios + - enf-gpios + - led + +additionalProperties: false + +examples: + - | + #include + #include + + led-controller { + compatible = "richtek,rt8515"; + enf-gpios = <&gpio4 12 GPIO_ACTIVE_HIGH>; + ent-gpios = <&gpio4 13 GPIO_ACTIVE_HIGH>; + richtek,rfs-ohms = <16000>; + richtek,rts-ohms = <100000>; + + led { + function = LED_FUNCTION_FLASH; + color = ; + flash-max-timeout-us = <250000>; + flash-max-microamp = <150000>; + torch-max-microamp = <25000>; + }; + }; + +... From patchwork Mon Nov 23 21:44:39 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Linus Walleij X-Patchwork-Id: 330689 Delivered-To: patch@linaro.org Received: by 2002:a17:907:2110:0:0:0:0 with SMTP id qn16csp3860061ejb; Mon, 23 Nov 2020 13:44:55 -0800 (PST) X-Google-Smtp-Source: ABdhPJzFA1ZmX49NabIo6zFUQ3dAdLwQyu6NIhWIn9OMlnl1/p5drmvtLr7AmZ0y/n/FGUecXUzp X-Received: by 2002:a17:906:2a0a:: with SMTP id j10mr1422613eje.307.1606167895613; Mon, 23 Nov 2020 13:44:55 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1606167895; cv=none; d=google.com; s=arc-20160816; b=yBJYdXHyOeCMbQvQOaouI2J0GsFUBNKg2TQ1z5JkaWEmJMa1yh0mX6DA+jp9OhLr6L OgQV58DZhcjCYzk10B3fSSuOxh7EYfcoGdiHOs5z/ROe4k+okq7mPNH1ujjkDFwxTQgh 7zJXGNOs62kvyzPFK5CA6h7ddo7SWzhbZHfzh6GTe+McWrCnB4eKIxrlM9PEloWSc2Ap 7pJgaqR+0Am7jq/K1zLWBMrnaAIXp5VCAAUOlSlN7nU5l4lISTVZtoDBts7FbBCcFKps +0K/JeUjgk0BCplHiAgq3ku88ngFBKvEIGWuppe9xe9Td/CfEfz6y1dLerc/ZqxpLlhb 1NVA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=NymYhgKMI4Ok2n6HYhVnh9q+dhpRWeihMnfgjE/dq/U=; b=VR/R4zxe8wa3KQa9JkoJDejmcfsLJ2NliqhoE2BB24j6+PJqOiiX+3REufABi0rNmz ey6gVWxUsteM37qHyn+Rtsz3JzgZjnf7vb5sDnc2AZYMmUpw9x6G6vdJfrY0mVlJy9aq 2oPg+SEMlpEBjo4PTUdLL0fytSarx0hTWxDcO1z11MqDQnioPTVALCRV7JTe0A0TwgNB DVg/j99RV1N6z9qdy4KT/Q+TSQwbzyy7yf0pOrWSgS45/vYw4mLZXYdRb0I/nynT996w FuzQldC67tTr0QXKIe2jzDhu3OnZkBvKnsa/8q3bBFEQoHvnHJF38gVGnW7fBWUDm2sz woUg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=A6ocJ4sj; spf=pass (google.com: domain of linux-leds-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-leds-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id be11si7076134edb.164.2020.11.23.13.44.55 for ; Mon, 23 Nov 2020 13:44:55 -0800 (PST) Received-SPF: pass (google.com: domain of linux-leds-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=A6ocJ4sj; spf=pass (google.com: domain of linux-leds-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-leds-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731699AbgKWVoy (ORCPT ); Mon, 23 Nov 2020 16:44:54 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57240 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731687AbgKWVoy (ORCPT ); Mon, 23 Nov 2020 16:44:54 -0500 Received: from mail-lj1-x243.google.com (mail-lj1-x243.google.com [IPv6:2a00:1450:4864:20::243]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E5634C061A4E for ; Mon, 23 Nov 2020 13:44:53 -0800 (PST) Received: by mail-lj1-x243.google.com with SMTP id s9so19635318ljo.11 for ; Mon, 23 Nov 2020 13:44:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=NymYhgKMI4Ok2n6HYhVnh9q+dhpRWeihMnfgjE/dq/U=; b=A6ocJ4sjzcOYadqQaiAlpPboJ3Ywpccr3SxTDWZZUABilvCVl0NKyBXcQMfJYDezOO O97qqsh2LaPfqm9CZTWCCT8HT0FMO3ziPR3kY9GoyoU0TzdCg1h4joI298bc9pBlTVim z7phWTTQ6ZIUfdqg5Nxs1aCtm+bfOLkSA/GB86DaB3hgFcXP6zP/DlxmBkf+Y7Bfjd61 62SPB3DWdosPJVs0SPRTwieVPwvwH0f2NUeXK20ULDAdO8BSdyX1TJ/vScXbVwbL0pFd C5GXLf7YaBR4Yvf9GcVM44NSWBslwnywaYcihG/eF8Kv0kw/KAp2PxGeFZKxPriYsh4F Ru8Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=NymYhgKMI4Ok2n6HYhVnh9q+dhpRWeihMnfgjE/dq/U=; b=aMeAOrHGe0eK6guaxuY7kcsNp0UDVYKwG50zJZJW7wJ9G9F30Ol0LA+klI1DfW0W8X 7IE720ap2prev2gCYmjWHyjL97vpNsApqsLvrHwl5uQSWVo1kXB50lBqiL5SMGFbeYUK xvce8NWdc5xS5iVLbwf9Ou94cqXq1/+jxfrqiqeS5Q8l/HtCj0jOpZyYpC3NdFMuH7mA Jno7o87yAps/P4UVE+q/dNYHbqrPr9nJPxG3CsA1WgiaIL5folBl6jnYBWSLiHyIPHgw JI7yUGsVhjSrkidDEzCxoM0D6BgSWfa5if+dpItRrN0JS0n5xXuQfC/q/zI0NuYAPvlo 62Aw== X-Gm-Message-State: AOAM530vRSHEWq8YXDmmo4QAoh7hIJy4jkT9GC+EF+lH5HY1EeAU6mLS 2qlnAvbvCpW0KOBzuYNEuCD8tA== X-Received: by 2002:a2e:8846:: with SMTP id z6mr554000ljj.311.1606167892350; Mon, 23 Nov 2020 13:44:52 -0800 (PST) Received: from localhost.bredbandsbolaget (c-92d7225c.014-348-6c756e10.bbcust.telenor.se. [92.34.215.146]) by smtp.gmail.com with ESMTPSA id 16sm1505036lfk.186.2020.11.23.13.44.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 23 Nov 2020 13:44:51 -0800 (PST) From: Linus Walleij To: Jacek Anaszewski , Pavel Machek , Dan Murphy Cc: linux-leds@vger.kernel.org, Linus Walleij , Sakari Ailus , newbytee@protonmail.com, Stephan Gerhold , linux-media@vger.kernel.org, phone-devel@vger.kernel.org Subject: [PATCH 2/2 v6] leds: rt8515: Add Richtek RT8515 LED driver Date: Mon, 23 Nov 2020 22:44:39 +0100 Message-Id: <20201123214439.1279464-2-linus.walleij@linaro.org> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20201123214439.1279464-1-linus.walleij@linaro.org> References: <20201123214439.1279464-1-linus.walleij@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-leds@vger.kernel.org This adds a driver for the Richtek RT8515 dual channel torch/flash white LED driver. This LED driver is found in some mobile phones from Samsung such as the GT-S7710 and GT-I8190. A V4L interface is added. We do not have a proper datasheet for the RT8515 but it turns out that RT9387A has a public datasheet and is essentially the same chip. We designed the driver in accordance with this datasheet. The day someone needs to drive a RT9387A this driver can probably easily be augmented to handle that chip too. Cc: Sakari Ailus Cc: newbytee@protonmail.com Cc: Stephan Gerhold Cc: linux-media@vger.kernel.org Cc: phone-devel@vger.kernel.org Signed-off-by: Linus Walleij --- ChangeLog v5->v6: - Use the configured max flash brightness instead of hardcoded "4". - Implement the new "-ohms" suffixes on the resistors. ChangeLog v4->v5: - Fix a missing static keyword, complaint from the kernel autobuilder robot. ChangeLog v3->v4: - Create a new subdirectory for flash LEDs under drivers/leds/flash as requested by Pavel, move the driver there and set up a kbuild structure for pure flash LEDs. (Others can follow the established pattern.) - Handle the new richtek,rfs and richtek,rts resistor values that make it possible to determine the current range configured in the hardware. - Handle the new flash-max-microamp and torch-max-microamp if present and optionally further restrict the current range using these. Otherwise fall back on the hardware defaults as specified by the RFS and RTS resistors. - Cc phone-devel@vger.kernel.org - License as GPL-2.0-or-later - Renable ent and enf gpio descriptors to enable_torch and enable_flash Changelog v2->v3: - Expand commit message. - Add Sakari to Cc. - Resend. ChangeLog v1->v2: - Break out routine to bitbang the brightness on a GPIO pin. - Do not hardcode the LED name so that the framework can name it from DT properties. --- drivers/leds/Kconfig | 3 + drivers/leds/Makefile | 3 + drivers/leds/flash/Kconfig | 15 ++ drivers/leds/flash/Makefile | 3 + drivers/leds/flash/leds-rt8515.c | 377 +++++++++++++++++++++++++++++++ 5 files changed, 401 insertions(+) create mode 100644 drivers/leds/flash/Kconfig create mode 100644 drivers/leds/flash/Makefile create mode 100644 drivers/leds/flash/leds-rt8515.c -- 2.26.2 diff --git a/drivers/leds/Kconfig b/drivers/leds/Kconfig index 849d3c5f908e..6c1d8b69a465 100644 --- a/drivers/leds/Kconfig +++ b/drivers/leds/Kconfig @@ -928,6 +928,9 @@ config LEDS_ACER_A500 This option enables support for the Power Button LED of Acer Iconia Tab A500. +comment "Flash and Torch LED drivers" +source "drivers/leds/flash/Kconfig" + comment "LED Triggers" source "drivers/leds/trigger/Kconfig" diff --git a/drivers/leds/Makefile b/drivers/leds/Makefile index 73e603e1727e..156c0b4e60d9 100644 --- a/drivers/leds/Makefile +++ b/drivers/leds/Makefile @@ -103,5 +103,8 @@ obj-$(CONFIG_LEDS_SPI_BYTE) += leds-spi-byte.o # LED Userspace Drivers obj-$(CONFIG_LEDS_USER) += uleds.o +# Flash and Torch LED Drivers +obj-$(CONFIG_LEDS_CLASS_FLASH) += flash/ + # LED Triggers obj-$(CONFIG_LEDS_TRIGGERS) += trigger/ diff --git a/drivers/leds/flash/Kconfig b/drivers/leds/flash/Kconfig new file mode 100644 index 000000000000..d21d273ef3da --- /dev/null +++ b/drivers/leds/flash/Kconfig @@ -0,0 +1,15 @@ +# SPDX-License-Identifier: GPL-2.0 + +if LEDS_CLASS_FLASH + +config LEDS_RT8515 + tristate "LED support for Richtek RT8515 flash/torch LED" + depends on GPIOLIB + help + This option enables support for the Richtek RT8515 flash + and torch LEDs found on some mobile phones. + + To compile this driver as a module, choose M here: the module + will be called leds-rt8515. + +endif # LEDS_CLASS_FLASH diff --git a/drivers/leds/flash/Makefile b/drivers/leds/flash/Makefile new file mode 100644 index 000000000000..e990e257f4d7 --- /dev/null +++ b/drivers/leds/flash/Makefile @@ -0,0 +1,3 @@ +# SPDX-License-Identifier: GPL-2.0 + +obj-$(CONFIG_LEDS_RT8515) += leds-rt8515.o diff --git a/drivers/leds/flash/leds-rt8515.c b/drivers/leds/flash/leds-rt8515.c new file mode 100644 index 000000000000..873f06116232 --- /dev/null +++ b/drivers/leds/flash/leds-rt8515.c @@ -0,0 +1,377 @@ +// SPDX-License-Identifier: GPL-2.0-or-later +/* + * LED driver for Richtek RT8515 flash/torch white LEDs + * found on some Samsung mobile phones. + * This is a 1.5A Boost dual channel driver produced around 2011. + * + * Linus Walleij + */ +#include +#include +#include +#include +#include +#include +#include +#include + +#include + +/* We can provide 15-700 mA out to the LED */ +#define RT8515_MIN_IOUT_MA 15 +#define RT8515_MAX_IOUT_MA 700 +/* The maximum intensity is 1-16 for flash and 1-100 for torch */ +#define RT8515_FLASH_MAX 16 +#define RT8515_TORCH_MAX 100 + +#define RT8515_TIMEOUT_DEFAULT 250000U /* 250ms */ +#define RT8515_MAX_TIMEOUT_DEFAULT 300000U /* 300ms */ + +struct rt8515 { + struct device *dev; + struct led_classdev_flash fled; + struct v4l2_flash *v4l2_flash; + struct mutex lock; + struct regulator *reg; + struct gpio_desc *enable_torch; + struct gpio_desc *enable_flash; + struct timer_list powerdown_timer; + u32 max_timeout; /* Flash max timeout */ + int flash_max_intensity; + int torch_max_intensity; +}; + +static struct rt8515 *to_rt8515(struct led_classdev_flash *fled) +{ + return container_of(fled, struct rt8515, fled); +} + +static void rt8515_gpio_brightness_commit(struct gpio_desc *gpiod, + int brightness) +{ + int i; + + /* + * Toggling a GPIO line with a small delay increases the + * brightness one step at a time. + */ + for (i = 0; i < brightness; i++) { + gpiod_set_value(gpiod, 0); + udelay(1); + gpiod_set_value(gpiod, 1); + udelay(1); + } +} + +/* This is setting the torch light level */ +static int rt8515_led_brightness_set(struct led_classdev *led, + enum led_brightness brightness) +{ + struct led_classdev_flash *fled = lcdev_to_flcdev(led); + struct rt8515 *rt = to_rt8515(fled); + + mutex_lock(&rt->lock); + + if (brightness == LED_OFF) { + /* Off */ + gpiod_set_value(rt->enable_flash, 0); + gpiod_set_value(rt->enable_torch, 0); + } else if (brightness < RT8515_TORCH_MAX) { + /* Step it up to movie mode brightness using the flash pin */ + rt8515_gpio_brightness_commit(rt->enable_torch, brightness); + } else { + /* Max torch brightness requested */ + gpiod_set_value(rt->enable_torch, 1); + } + + mutex_unlock(&rt->lock); + + return 0; +} + +static int rt8515_led_flash_strobe_set(struct led_classdev_flash *fled, + bool state) +{ + struct rt8515 *rt = to_rt8515(fled); + struct led_flash_setting *timeout = &fled->timeout; + int brightness = rt->flash_max_intensity; + + mutex_lock(&rt->lock); + + if (state) { + /* Enable LED flash mode and set brightness */ + rt8515_gpio_brightness_commit(rt->enable_flash, brightness); + /* Set timeout */ + mod_timer(&rt->powerdown_timer, + jiffies + usecs_to_jiffies(timeout->val)); + } else { + del_timer_sync(&rt->powerdown_timer); + /* Turn the LED off */ + gpiod_set_value(rt->enable_flash, 0); + gpiod_set_value(rt->enable_torch, 0); + } + + fled->led_cdev.brightness = LED_OFF; + /* After this the torch LED will be disabled */ + + mutex_unlock(&rt->lock); + + return 0; +} + +static int rt8515_led_flash_strobe_get(struct led_classdev_flash *fled, + bool *state) +{ + struct rt8515 *rt = to_rt8515(fled); + + *state = timer_pending(&rt->powerdown_timer); + + return 0; +} + +static int rt8515_led_flash_timeout_set(struct led_classdev_flash *fled, + u32 timeout) +{ + /* The timeout is stored in the led-class-flash core */ + return 0; +} + +static const struct led_flash_ops rt8515_flash_ops = { + .strobe_set = rt8515_led_flash_strobe_set, + .strobe_get = rt8515_led_flash_strobe_get, + .timeout_set = rt8515_led_flash_timeout_set, +}; + +static void rt8515_powerdown_timer(struct timer_list *t) +{ + struct rt8515 *rt = from_timer(rt, t, powerdown_timer); + + /* Turn the LED off */ + gpiod_set_value(rt->enable_flash, 0); + gpiod_set_value(rt->enable_torch, 0); +} + +static void rt8515_init_flash_timeout(struct rt8515 *rt) +{ + struct led_classdev_flash *fled = &rt->fled; + struct led_flash_setting *s; + + /* Init flash timeout setting */ + s = &fled->timeout; + s->min = 1; + s->max = rt->max_timeout; + s->step = 1; + /* + * Set default timeout to RT8515_DEFAULT_TIMEOUT except if + * max_timeout from DT is lower. + */ + s->val = min(rt->max_timeout, RT8515_TIMEOUT_DEFAULT); +} + +#if IS_ENABLED(CONFIG_V4L2_FLASH_LED_CLASS) +/* Configure the V2L2 flash subdevice */ +static void rt8515_init_v4l2_flash_config(struct rt8515 *rt, + struct v4l2_flash_config *v4l2_sd_cfg) +{ + struct led_classdev *led = &rt->fled.led_cdev; + struct led_flash_setting *s; + + strscpy(v4l2_sd_cfg->dev_name, led->dev->kobj.name, + sizeof(v4l2_sd_cfg->dev_name)); + + /* + * Init flash intensity setting: this is a linear scale + * capped from the device tree max intensity setting + * 1..flash_max_intensity + */ + s = &v4l2_sd_cfg->intensity; + s->min = 1; + s->max = rt->flash_max_intensity; + s->step = 1; + s->val = s->max; +} + +#else +static void rt8515_init_v4l2_flash_config(struct rt8515 *rt, + struct v4l2_flash_config *v4l2_sd_cfg) +{ +} +#endif + +static void rt8515_determine_max_intensity(struct rt8515 *rt, + struct fwnode_handle *led, + const char *resistance, + const char *max_ua_prop, int hw_max, + int *max_intensity_setting) +{ + u32 res; + u32 ua; + u32 max_ma; + int max_intensity; + int ret1, ret2; + + + ret1 = fwnode_property_read_u32(rt->dev->fwnode, resistance, &res); + ret2 = fwnode_property_read_u32(led, max_ua_prop, &ua); + + /* No info in DT, OK go with hardware maxima */ + if (ret1 && ret2) { + max_ma = RT8515_MAX_IOUT_MA; + max_intensity = hw_max; + goto out_assign_max; + } + + if (ret1 || ret2) { + dev_err(rt->dev, + "either %s or %s missing from DT, using HW max\n", + resistance, max_ua_prop); + max_ma = RT8515_MAX_IOUT_MA; + max_intensity = hw_max; + goto out_assign_max; + } + + /* + * Formula from datasheet, this is the maximum current + * defined by the hardware. + */ + max_ma = (5500 * 1000) / res; + /* + * Calculate max intensity (linear scaling) + * Formula is ((ua / 1000) / max_ma) * 100, then simplified + */ + max_intensity = (ua / 10) / max_ma; + + dev_info(rt->dev, + "current restricted from %u to %u mA, max intensity %d/100\n", + max_ma, (ua / 1000), max_intensity); + +out_assign_max: + dev_info(rt->dev, "max intensity %d/%d = %d mA\n", + max_intensity, hw_max, max_ma); + *max_intensity_setting = max_intensity; +} + +static int rt8515_probe(struct platform_device *pdev) +{ + struct device *dev = &pdev->dev; + struct fwnode_handle *child; + struct rt8515 *rt; + struct led_classdev *led; + struct led_classdev_flash *fled; + struct led_init_data init_data = {}; + struct v4l2_flash_config v4l2_sd_cfg = {}; + int ret; + + rt = devm_kzalloc(dev, sizeof(*rt), GFP_KERNEL); + if (!rt) + return -ENOMEM; + + rt->dev = dev; + fled = &rt->fled; + led = &fled->led_cdev; + + /* ENF - Enable Flash line */ + rt->enable_flash = devm_gpiod_get(dev, "enf", GPIOD_OUT_LOW); + if (IS_ERR(rt->enable_flash)) { + dev_err(dev, "cannot get ENF (enable flash) GPIO\n"); + return PTR_ERR(rt->enable_flash); + } + + /* ENT - Enable Torch line */ + rt->enable_torch = devm_gpiod_get(dev, "ent", GPIOD_OUT_LOW); + if (IS_ERR(rt->enable_torch)) { + dev_err(dev, "cannot get ENT (enable torch) GPIO\n"); + return PTR_ERR(rt->enable_torch); + } + + child = fwnode_get_next_available_child_node(dev->fwnode, NULL); + if (!child) { + dev_err(dev, + "No fwnode child node found for connected LED.\n"); + return -EINVAL; + } + init_data.fwnode = child; + + rt8515_determine_max_intensity(rt, child, "richtek,rfs-ohms", + "flash-max-microamp", + RT8515_FLASH_MAX, + &rt->flash_max_intensity); + rt8515_determine_max_intensity(rt, child, "richtek,rts-ohms", + "torch-max-microamp", + RT8515_TORCH_MAX, + &rt->torch_max_intensity); + + ret = fwnode_property_read_u32(child, "flash-max-timeout-us", + &rt->max_timeout); + if (ret) { + rt->max_timeout = RT8515_MAX_TIMEOUT_DEFAULT; + dev_warn(dev, + "flash-max-timeout-us property missing\n"); + } + timer_setup(&rt->powerdown_timer, rt8515_powerdown_timer, 0); + rt8515_init_flash_timeout(rt); + + fled->ops = &rt8515_flash_ops; + + led->max_brightness = rt->torch_max_intensity; + led->brightness_set_blocking = rt8515_led_brightness_set; + led->flags |= LED_CORE_SUSPENDRESUME | LED_DEV_CAP_FLASH; + + mutex_init(&rt->lock); + + platform_set_drvdata(pdev, rt); + + ret = devm_led_classdev_flash_register_ext(dev, fled, &init_data); + if (ret) { + dev_err(dev, "can't register LED %s\n", led->name); + mutex_destroy(&rt->lock); + return ret; + } + + rt8515_init_v4l2_flash_config(rt, &v4l2_sd_cfg); + + /* Create a V4L2 Flash device if V4L2 flash is enabled */ + rt->v4l2_flash = v4l2_flash_init(dev, child, fled, NULL, &v4l2_sd_cfg); + if (IS_ERR(rt->v4l2_flash)) { + ret = PTR_ERR(rt->v4l2_flash); + dev_err(dev, "failed to register V4L2 flash device (%d)\n", + ret); + /* + * Continue without the V4L2 flash + * (we still have the classdev) + */ + } + + return 0; +} + +static int rt8515_remove(struct platform_device *pdev) +{ + struct rt8515 *rt = platform_get_drvdata(pdev); + + v4l2_flash_release(rt->v4l2_flash); + del_timer_sync(&rt->powerdown_timer); + mutex_destroy(&rt->lock); + + return 0; +} + +static const struct of_device_id rt8515_match[] = { + { .compatible = "richtek,rt8515", }, + { /* sentinel */ }, +}; +MODULE_DEVICE_TABLE(of, rt8515_match); + +static struct platform_driver rt8515_driver = { + .driver = { + .name = "rt8515", + .of_match_table = rt8515_match, + }, + .probe = rt8515_probe, + .remove = rt8515_remove, +}; +module_platform_driver(rt8515_driver); + +MODULE_AUTHOR("Linus Walleij "); +MODULE_DESCRIPTION("Richtek RT8515 LED driver"); +MODULE_LICENSE("GPL v2");