From patchwork Sat Nov 21 06:33:02 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: John Stultz X-Patchwork-Id: 330039 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER, INCLUDES_PATCH, MAILING_LIST_MULTI, SPF_HELO_NONE, SPF_PASS, URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7067DC63798 for ; Sat, 21 Nov 2020 06:33:30 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 2196722206 for ; Sat, 21 Nov 2020 06:33:30 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="EdA2h3p8" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726581AbgKUGdI (ORCPT ); Sat, 21 Nov 2020 01:33:08 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40228 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726433AbgKUGdH (ORCPT ); Sat, 21 Nov 2020 01:33:07 -0500 Received: from mail-pg1-x541.google.com (mail-pg1-x541.google.com [IPv6:2607:f8b0:4864:20::541]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E890BC0613CF for ; Fri, 20 Nov 2020 22:33:05 -0800 (PST) Received: by mail-pg1-x541.google.com with SMTP id j19so9299632pgg.5 for ; Fri, 20 Nov 2020 22:33:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id; bh=/QcxfXErWWujy+nFNlFKMWzF0EXFpsGg4+Dh63UDNx4=; b=EdA2h3p87/J7Q4xNVksxAGFt1xTbDRs12kJw3waq/qrqWlgrQ+yK4fwbXqdE3I8EeY EejVAGVllbDov3IjWVlfSVCTz4orFfzGoXH+uxCMX8m5ezEyYJW08bKLp4rnbrNIrWvz slbygK3FIpgNQn/1Y2X8euXNLtlMi/eid7WpIpa1UEQy19sldi+I9K0bPZTG1yZwDkia nNy2mU3tZ2UsRZagnC7s4b1BMpRtF52GrV8HLNHVUyCXqJMZRl8WH1E+cR2J4yHy6iJK SivyHKufvTZNt8/s3107RWlRYSiKxYDRMT/Ol/HY3i0VVyvGjAu9/EAZQxslq+a1FWV9 JvGQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=/QcxfXErWWujy+nFNlFKMWzF0EXFpsGg4+Dh63UDNx4=; b=O9c2m8FcF91ulFTsfjfBuFbL4T0C0N0DTz3vO63sqNXi6Qui1w6d0fjRXuqTC741mz IbOnIF4yo+OIOqnZDiMOYgXZPmwKutp9Q5kz2/jlsHWZQkEpNLyJs5hxHBTdpxhdvYTJ DPp8GpQ1aiFGcnPKoqEL3IEvQaegwflv1A4GmC1bezQaFkZiJVrCKC0tIyG3en4kQIlP ze5uaBAmzDJrh5cX3WDKQIgJWPUJLwjq3edU0yajFoMS2wofAmpD9FQesaV8pLDbnVwU Gj9B+AbvJsRGzu6F5VYl8Mzhfm6MfrH/2OPAUC348qQZmPGipMAu8a5P03AdILWW+k+m anfw== X-Gm-Message-State: AOAM533RhvwYMptRtyqfDoQ+CBs5fcGNsOpkHgRZFKMhVJUMZ+6zykFk lLaCeE2L10bMK4MFJRasVx1NyQ== X-Google-Smtp-Source: ABdhPJwzT1WHUftegVeHBEHmL1+Lb0AS44SxEhcpfzWQqyrxoXeSsAtm5eLrRamw0mIW+nUj6+H3dA== X-Received: by 2002:a63:c749:: with SMTP id v9mr20013228pgg.451.1605940385315; Fri, 20 Nov 2020 22:33:05 -0800 (PST) Received: from localhost.localdomain ([2601:1c2:680:1319:692:26ff:feda:3a81]) by smtp.gmail.com with ESMTPSA id l7sm6471460pjg.29.2020.11.20.22.33.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 20 Nov 2020 22:33:04 -0800 (PST) From: John Stultz To: lkml Cc: John Stultz , Todd Kjos , Saravana Kannan , Andy Gross , Bjorn Andersson , Rajendra Nayak , Maulik Shah , Stephen Boyd , Liam Girdwood , Mark Brown , linux-arm-msm@vger.kernel.org Subject: [PATCH] regulator: Kconfig: Fix REGULATOR_QCOM_RPMH dependencies to avoid build error Date: Sat, 21 Nov 2020 06:33:02 +0000 Message-Id: <20201121063302.84090-1-john.stultz@linaro.org> X-Mailer: git-send-email 2.17.1 Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org The kernel test robot reported the following build error: All errors (new ones prefixed by >>): xtensa-linux-ld: drivers/regulator/qcom-rpmh-regulator.o: in function `rpmh_regulator_vrm_get_voltage_sel': qcom-rpmh-regulator.c:(.text+0x270): undefined reference to `rpmh_write' xtensa-linux-ld: drivers/regulator/qcom-rpmh-regulator.o: in function `rpmh_regulator_send_request': qcom-rpmh-regulator.c:(.text+0x2f2): undefined reference to `rpmh_write' xtensa-linux-ld: drivers/regulator/qcom-rpmh-regulator.o: in function `rpmh_regulator_vrm_get_voltage_sel': >> qcom-rpmh-regulator.c:(.text+0x274): undefined reference to `rpmh_write_async' xtensa-linux-ld: drivers/regulator/qcom-rpmh-regulator.o: in function `rpmh_regulator_send_request': qcom-rpmh-regulator.c:(.text+0x2fc): undefined reference to `rpmh_write_async' Which is due to REGULATOR_QCOM_RPMH depending on QCOM_RPMH || COMPILE_TEST. The problem is that QOM_RPMH can now be a module, which in that case requires REGULATOR_QCOM_RPMH=m to build. However, if COMPILE_TEST is enabled, REGULATOR_QCOM_RPMH can be set to =y while REGULATOR_QCOM_RPMH=m which will cause build failures. The easy fix here is to remove COMPILE_TEST. Feedback would be appreciated! Cc: Todd Kjos Cc: Saravana Kannan Cc: Andy Gross Cc: Bjorn Andersson Cc: Rajendra Nayak Cc: Maulik Shah Cc: Stephen Boyd Cc: Liam Girdwood Cc: Mark Brown Cc: linux-arm-msm@vger.kernel.org Reported-by: kernel test robot Signed-off-by: John Stultz --- drivers/regulator/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/regulator/Kconfig b/drivers/regulator/Kconfig index 020a00d6696b..9e4fc73ed5a1 100644 --- a/drivers/regulator/Kconfig +++ b/drivers/regulator/Kconfig @@ -843,7 +843,7 @@ config REGULATOR_QCOM_RPM config REGULATOR_QCOM_RPMH tristate "Qualcomm Technologies, Inc. RPMh regulator driver" - depends on QCOM_RPMH || COMPILE_TEST + depends on QCOM_RPMH help This driver supports control of PMIC regulators via the RPMh hardware block found on Qualcomm Technologies Inc. SoCs. RPMh regulator