From patchwork Thu Nov 19 14:07:07 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Linus Walleij X-Patchwork-Id: 328412 Delivered-To: patch@linaro.org Received: by 2002:a05:6e02:5ce:0:0:0:0 with SMTP id l14csp446148ils; Thu, 19 Nov 2020 06:07:41 -0800 (PST) X-Google-Smtp-Source: ABdhPJxjEC4//0ZielmDNW8AW+WtrtmI7hvbkLXO14RyQ96WEYKKd++NM0e3Aq/WR3mXMhL1lZH9 X-Received: by 2002:a17:902:9f87:b029:d9:e311:fc86 with SMTP id g7-20020a1709029f87b02900d9e311fc86mr877565plq.74.1605794861272; Thu, 19 Nov 2020 06:07:41 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1605794861; cv=none; d=google.com; s=arc-20160816; b=ZEUdfmz15zArI6+K4HfxH/Q6sl5SE57PZSVs5Ah4KGHfMfAjFcSC7kPRYUNywi172n U86Siy6kf49pkvLSXIGPrkP25/F0d+/Czyb1uHFZ6PqAb6xwFlgv9UB+9CB483FevU72 6IcmjP75X2n7lJQukJW1BhKT4yynE71LPckjnMkISgO3uttYXX8P4Wp0CMnt2TErvBJd zHcAO0rEX0XPLwSpOq3pi/7bNN1G+PmCV/tEi0UM80Dpt5rTAWZMtvxxa9jNWkEvFKwV iV1URma0FOAhNaikKQzSEJeSweacKAKbCY+wuDthDk6whtNpASfeFuSxQW19SYHd1ifQ rCng== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:cc:list-subscribe :list-help:list-post:list-archive:list-unsubscribe:list-id :precedence:mime-version:message-id:date:subject:to:from :dkim-signature:delivered-to; bh=xb6lUg4mvh8ABmqN+TKbBm4/JWIewYqlHH4s6J+Z15s=; b=UYi2VhZ05yYpiNNWhphRI6MdNYpDxymUcrW7d8ca+EWVesrxEh+zn+ArHTVtsfEYFP 57VC9q5STBIcSKEii6umIqzTPJvccv8DIeyCHQCYV/GXEKItOuo4iHFLeP2Wi4JhQWMx hds/UWQdLM1WjAItAp7JlkiUNgESlx7i6jiZrEi6X1FGse1PlpQoJKNJh3siXd9OmS3I BFDHNo32xVmPJBZYZyFiPf4AnlGrX0LwqjhY2UOjY/Uui97U1/EEgNIkiqtMDIzJD826 cfBXw9LY8gLNqnoo1f5W3qyR25zQxar2MtT668+jFDyf136WprYWciT8AeH/gWIngO9T IyKA== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=tWYBBjEy; spf=pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 131.252.210.177 as permitted sender) smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from gabe.freedesktop.org (gabe.freedesktop.org. [131.252.210.177]) by mx.google.com with ESMTPS id q13si7959704pls.282.2020.11.19.06.07.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 19 Nov 2020 06:07:41 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 131.252.210.177 as permitted sender) client-ip=131.252.210.177; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=tWYBBjEy; spf=pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 131.252.210.177 as permitted sender) smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 1C8366E52D; Thu, 19 Nov 2020 14:07:40 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mail-lf1-x141.google.com (mail-lf1-x141.google.com [IPv6:2a00:1450:4864:20::141]) by gabe.freedesktop.org (Postfix) with ESMTPS id C52EB6E52D for ; Thu, 19 Nov 2020 14:07:39 +0000 (UTC) Received: by mail-lf1-x141.google.com with SMTP id a9so8427523lfh.2 for ; Thu, 19 Nov 2020 06:07:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=by9rdaiSTNhh25rGcdMhydBPT1Ee6Q+Ur1BB4O7C4Tk=; b=tWYBBjEyHLLcUdZV3JTAQ8MKQEQ2kqZgcQ5MDERuYEGvL2/ppp2n5esSze20TLaGOi c4EhVEVoixCWm/H79N2t+a00SFj4PRlAhn5BU5e65yywr+THQA+MGDJqyzIRVwhJ8Ovm uuenvZ+v4MZ/Tuj/3VnUKDo/htf5Otr0n62kEZLRThkQDgNlKNTdj5+Lt89zis6Y48Lv VKggH458/phEKCV3+9wSUYCs9mvIZSPP8U8r8p0TMYcIEBjougHLM8NFPOtEww2hjN0h t5wynqI6UqxEPWEBxA6bevACRN1z9bg3enfgsJGGIa4kUDVQGT8ULyjpwrb0j5MFL5ir ZgyA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=by9rdaiSTNhh25rGcdMhydBPT1Ee6Q+Ur1BB4O7C4Tk=; b=EAFJq5LNaUPfVOc2iH/k7B5pm6pBDuqDxMzm5+2MbhmLpXmael5vgJusdpif6a4NwZ Q25j7c3x5elRRw8LAiTRgsgs61DzlHyCMZnSm5YVTzbDSDZuCWVfbGNyMhw958+xM6eb uayigOdb5ksVcrLgqgmys/q5WLxNteNnEpV/bBU2+8WbZ4HGnnKyC0DZW4akgFic/Tsj DbuVmpzbgEpSo7l5fzNt8IQEnj2WY85fah1Axp8+lWgWtATaD4c6Xk334tHCh2HAruQu A6PaftL9dTtNTUswA9jS4ox8WIUB+nX6Dk/WsV64/GG96Ldp1Bgb+sCSqF3F3QBy0R7o D3+A== X-Gm-Message-State: AOAM530FcX8wcfJQDnwKXyNBQAPOEHHXGHkXlKtfYZ3JlXYWBC3ZuYGi ebvrkUhNCCB9HVg6HkZR/LEgTczM13FVUNNN X-Received: by 2002:a05:6512:3048:: with SMTP id b8mr5524416lfb.575.1605794857954; Thu, 19 Nov 2020 06:07:37 -0800 (PST) Received: from localhost.bredbandsbolaget (c-92d7225c.014-348-6c756e10.bbcust.telenor.se. [92.34.215.146]) by smtp.gmail.com with ESMTPSA id r8sm3983292lff.238.2020.11.19.06.07.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 19 Nov 2020 06:07:29 -0800 (PST) From: Linus Walleij To: dri-devel@lists.freedesktop.org, Maarten Lankhorst , Maxime Ripard , Sean Paul Subject: [PATCH] drm/mcde: Fix uninitialized value Date: Thu, 19 Nov 2020 15:07:07 +0100 Message-Id: <20201119140707.1008407-1-linus.walleij@linaro.org> X-Mailer: git-send-email 2.26.2 MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Dan Carpenter , kernel test robot , linux-arm-kernel@lists.infradead.org Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" "val" isn't initialized on the default: errorpath. Just return from the function if this happens. Reported-by: kernel test robot Reported-by: Dan Carpenter Signed-off-by: Linus Walleij --- drivers/gpu/drm/mcde/mcde_display.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.26.2 _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel Reviewed-by: Sam Ravnborg diff --git a/drivers/gpu/drm/mcde/mcde_display.c b/drivers/gpu/drm/mcde/mcde_display.c index 192e11c88d72..d941026b940c 100644 --- a/drivers/gpu/drm/mcde/mcde_display.c +++ b/drivers/gpu/drm/mcde/mcde_display.c @@ -569,7 +569,7 @@ static void mcde_configure_channel(struct mcde *mcde, enum mcde_channel ch, default: dev_err(mcde->dev, "unknown flow mode %d\n", mcde->flow_mode); - break; + return; } writel(val, mcde->regs + sync);