From patchwork Mon Jan 8 12:17:37 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Xiongfeng Wang X-Patchwork-Id: 123695 Delivered-To: patch@linaro.org Received: by 10.140.22.227 with SMTP id 90csp2643768qgn; Mon, 8 Jan 2018 04:12:27 -0800 (PST) X-Google-Smtp-Source: ACJfBou+nQa1n3D8z8E2Yl1Jhh3wZM/5DSGTSwMwJdu+9lqEDLSg7rNj2IezWu9oZOoC3wegAWXr X-Received: by 10.84.130.7 with SMTP id 7mr11764703plc.183.1515413546936; Mon, 08 Jan 2018 04:12:26 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1515413546; cv=none; d=google.com; s=arc-20160816; b=FZfTW1OvCMlOAoQQjqxAUTvJHarOsdLJ92kPCMfFYiuHcWzsMHkL5Ym7v0eU0sIt07 so+nn82n8WEZv6otBSzZpzmzxs4uN6fQ9Ws22DIwEQ1E+GM3T1Rhy3jHBzYr4RADm7PO faAY4SvyV9+rCxNrY6QksvaLmxxcjFo4kLha5bhbb7dYeq2AeBglzQh7C+zQ6B4yyKQT jvJ/bclwMJL2T8Xq14qGmVecP4IesDldaI/f4oDJtH0FmPGUoYFtBJJD3XtiaSV0x6Ah rbKLgwWdRvMtlV9SepVR2TmbV83OgBRnHghRzxCUA1i0buStYnRKBE6QHpJ/RK18XjeD cztA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:message-id:date:subject:cc :to:from:arc-authentication-results; bh=YzFFr+PeTvlvE5+m1g2Q8ESTdpgQHa95ZU/RKziHMG0=; b=OAfmJsnPn+3Ispsfd0XGogVjgKQz3YyQNxNgilCrnh/QRO2M110ezncbY0CGpwnTvL oUXKyRdmiLyMGFfcvd7KF207P+u1CIIzGFbf02IGNakCe81cdp1FeJMghBSSobx6AP6j tPJT8GFwa5fvDALAbiXqoqHhG4v8e3XAEjjDqMtoQW7ioFmDcDAiA9RDw9qoYVLxT1te dAiRJjdcl9OgFFuexzV/9v/jEVtqvDT7KqBnvZzremLLmtoEdyCSnCG//S0WDMQMUDgV ZcYaw7cFLTdEwPju3PYKBIasnv80GmTI0K3HOzHIqizzIZEWjdnzQMpAQ/ziMDYTMC8G tNZQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id c19si8543951plo.595.2018.01.08.04.12.26; Mon, 08 Jan 2018 04:12:26 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756918AbeAHMMY (ORCPT + 28 others); Mon, 8 Jan 2018 07:12:24 -0500 Received: from szxga05-in.huawei.com ([45.249.212.191]:3755 "EHLO huawei.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1756426AbeAHMMW (ORCPT ); Mon, 8 Jan 2018 07:12:22 -0500 Received: from DGGEMS401-HUB.china.huawei.com (unknown [172.30.72.59]) by Forcepoint Email with ESMTP id 6B4BBC769EF80; Mon, 8 Jan 2018 20:12:08 +0800 (CST) Received: from localhost.localdomain.localdomain (10.175.113.25) by DGGEMS401-HUB.china.huawei.com (10.3.19.201) with Microsoft SMTP Server id 14.3.361.1; Mon, 8 Jan 2018 20:12:02 +0800 From: Xiongfeng Wang To: CC: , , Subject: [PATCH] fs/hfsplus: use memcpy() instead of strncpy() Date: Mon, 8 Jan 2018 20:17:37 +0800 Message-ID: <1515413857-48430-1-git-send-email-wangxiongfeng2@huawei.com> X-Mailer: git-send-email 1.8.3.1 MIME-Version: 1.0 X-Originating-IP: [10.175.113.25] X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Xiongfeng Wang gcc-8 reports inlined from 'copy_name' at fs/hfsplus/xattr.c:416:3: ./include/linux/string.h:245:9: warning: '__builtin_strncpy' output truncated before terminating nul copying 4 bytes from a string of the same length [-Wstringop-truncation] Since we don't need to copy '\0', we can just use memcpy() to avoid this warning. Signed-off-by: Xiongfeng Wang --- fs/hfsplus/xattr.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 1.8.3.1 Reviewed-by: Vyacheslav Dubeyko diff --git a/fs/hfsplus/xattr.c b/fs/hfsplus/xattr.c index e538b75..0dc8a65 100644 --- a/fs/hfsplus/xattr.c +++ b/fs/hfsplus/xattr.c @@ -413,7 +413,7 @@ static int copy_name(char *buffer, const char *xattr_name, int name_len) int offset = 0; if (!is_known_namespace(xattr_name)) { - strncpy(buffer, XATTR_MAC_OSX_PREFIX, XATTR_MAC_OSX_PREFIX_LEN); + memcpy(buffer, XATTR_MAC_OSX_PREFIX, XATTR_MAC_OSX_PREFIX_LEN); offset += XATTR_MAC_OSX_PREFIX_LEN; len += XATTR_MAC_OSX_PREFIX_LEN; }