From patchwork Mon Jan 8 12:01:32 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Xiongfeng Wang X-Patchwork-Id: 123693 Delivered-To: patch@linaro.org Received: by 10.140.22.227 with SMTP id 90csp2625265qgn; Mon, 8 Jan 2018 03:56:14 -0800 (PST) X-Google-Smtp-Source: ACJfBovtUJtAkvK1bH55JXGPYgKlZFWF6ipXj39rdxfWQdcrA7DV8o0fw3BQ4aOcMG2tWl9m6Ldd X-Received: by 10.101.83.9 with SMTP id m9mr9274086pgq.202.1515412573963; Mon, 08 Jan 2018 03:56:13 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1515412573; cv=none; d=google.com; s=arc-20160816; b=lxJUwk08uXONk3zFdoPbAJUk0HJO8v6BKG7wUWvyzI+Qg14UUI6r5eeYfAHYsiBYw3 FkVBCSqJ25f14/fZxDkx8bUFOruE3qAZyX3ylGXxuizL1cgMU2jj34KYejK6KAdprT1i Po/Y34mvue5PYV559N1D1C4O7DKo+w7/ASyLQvxUzWwIZvPOzRb3lJ2mlo0W5ekcZC22 XFTjf1X6iED3RztcqWFlSnGYBsuosvNvoXDl2j4BnhsyRvAptZGW2o/I2kwrYxk6bERb AkrnqgkLo+GUBCzW5Ba0fqQcaKd1NVt0D14tL1n3mFTDL3E2ugZ9OQoYXUgtnsVmUIJN W1Ag== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:message-id:date:subject:cc :to:from:arc-authentication-results; bh=zR0DMv8PlqBC6TkF74SEAdyXAGb03vlQSSgg+gcOeP4=; b=y7SdTujOMSQRl06YKqGXSwbMsYeBWGuxk/R1Dr+9jj43RlyJQNKBD2MZ4aLLUEu+xy 7xY9dgS9XenZuJf6CJ5pAAJdBEEMR1NpDRqJ+DYiv4jPFgN+WYecFxW6i2g6Yc+J67tD stu+K9oym5O2lV8R+O89rebb3D1YYivL6ytIZmegceX5mI/mITc9VF+7uYqx0R+1a3WI hWgSTVVwoFu/wrdLlyyNYfNWnR7HYru3nkhp2TVC9L9MpdbH0Zah3/7nOoTgPWCdYMCO Zy6CdtMDGQyVkDUoHN6ZokywYjrAz15OyYrjHuwj9jPeCkrM343zThEpa4tG2Kaj8toh /U/A== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id i7si8411252plt.427.2018.01.08.03.56.13; Mon, 08 Jan 2018 03:56:13 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932446AbeAHL4M (ORCPT + 28 others); Mon, 8 Jan 2018 06:56:12 -0500 Received: from szxga07-in.huawei.com ([45.249.212.35]:39052 "EHLO huawei.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S932413AbeAHL4I (ORCPT ); Mon, 8 Jan 2018 06:56:08 -0500 Received: from DGGEMS401-HUB.china.huawei.com (unknown [172.30.72.60]) by Forcepoint Email with ESMTP id 0F728A115B962; Mon, 8 Jan 2018 19:56:06 +0800 (CST) Received: from localhost.localdomain.localdomain (10.175.113.25) by DGGEMS401-HUB.china.huawei.com (10.3.19.201) with Microsoft SMTP Server id 14.3.361.1; Mon, 8 Jan 2018 19:55:57 +0800 From: Xiongfeng Wang To: CC: , , , Subject: [PATCH] ipmi: use correct string length Date: Mon, 8 Jan 2018 20:01:32 +0800 Message-ID: <1515412892-18741-1-git-send-email-wangxiongfeng2@huawei.com> X-Mailer: git-send-email 1.8.3.1 MIME-Version: 1.0 X-Originating-IP: [10.175.113.25] X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Xiongfeng Wang gcc-8 reports drivers/char/ipmi/ipmi_msghandler.c: In function 'panic_op_write_handler': ./include/linux/string.h:245:9: warning: '__builtin_strncpy' specified bound 16 equals destination size [-Wstringop-truncation] drivers/char/ipmi/ipmi_watchdog.c: In function 'set_param_str': ./include/linux/string.h:245:9: warning: '__builtin_strncpy' specified bound 16 equals destination size [-Wstringop-truncation] We need one less byte or call strlcpy() to make it a nul-terminated string. Signed-off-by: Xiongfeng Wang --- drivers/char/ipmi/ipmi_msghandler.c | 2 +- drivers/char/ipmi/ipmi_watchdog.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) -- 1.8.3.1 diff --git a/drivers/char/ipmi/ipmi_msghandler.c b/drivers/char/ipmi/ipmi_msghandler.c index f45732a..01fbffb 100644 --- a/drivers/char/ipmi/ipmi_msghandler.c +++ b/drivers/char/ipmi/ipmi_msghandler.c @@ -84,7 +84,7 @@ static int panic_op_write_handler(const char *val, char valcp[16]; char *s; - strncpy(valcp, val, 16); + strncpy(valcp, val, 15); valcp[15] = '\0'; s = strstrip(valcp); diff --git a/drivers/char/ipmi/ipmi_watchdog.c b/drivers/char/ipmi/ipmi_watchdog.c index 76b2706..6004851 100644 --- a/drivers/char/ipmi/ipmi_watchdog.c +++ b/drivers/char/ipmi/ipmi_watchdog.c @@ -232,7 +232,7 @@ static int set_param_str(const char *val, const struct kernel_param *kp) char valcp[16]; char *s; - strncpy(valcp, val, 16); + strncpy(valcp, val, 15); valcp[15] = '\0'; s = strstrip(valcp);