From patchwork Mon Jan 8 11:51:22 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Xiongfeng Wang X-Patchwork-Id: 123692 Delivered-To: patch@linaro.org Received: by 10.140.22.227 with SMTP id 90csp2616147qgn; Mon, 8 Jan 2018 03:46:16 -0800 (PST) X-Google-Smtp-Source: ACJfBothRnkXD2Uy0huY0Mv5/48lI1Q0Nk3o0aaOSCwEi1VyzDaVpFZ+ATs2k5DmHBZN8a71I1M0 X-Received: by 10.99.163.26 with SMTP id s26mr9090167pge.402.1515411976648; Mon, 08 Jan 2018 03:46:16 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1515411976; cv=none; d=google.com; s=arc-20160816; b=07/12oE/WMgZ8MJYjFpKyeYpf7O16NvPMFABxBJHEe5SlibFwUFXs6lnH59qF7sCw3 4Ek+jpBCdihsNWAcVis0mpPLPlE2pTygO75DDmuqs8rxtlS/NkpdR3Re8OinXHI16OYH UuNQlHuHZ9yaECrwYmpeH/nmdlz5PvVQGdP1kfkVfgWs9dotD/ynLcxcGdmDgFnXx6hI uwLoeUiiz2/XRleBhWCluRV/+5qpqRWNiXXQv3TFsfM0+vQhlAaEmmZsIoMXoZI5O9B5 7c66/dI4+dRxBEhHr9sI5CQK1gETW1G5SVTMUlwzw09Ugm0tjrraTxejlVPpvKLjErxn WXGw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:message-id:date:subject:cc :to:from:arc-authentication-results; bh=GM9Bh0yWGozxN90esTmzFkz+bmisumMoKHgdAYD9l9k=; b=YgmVaPRVlIHGvsUm14mgoRZgWeSxocqWgVFaNK4A/60bWvZpSXjO6f/WVXoCGQdMzh 2AcqCWl8lR+FNj+OA9v1hExdA82gZy0PUp60g+TatXzcWhW1kXUJGWPp9GWZSR0x7B3u llfrIiAEI9qf7bJPxlwCsPfrb7BUFLVfL+h+J14OEBy8prVUn/fFUVOdyu74EhHetaQz Ld20mcaeKCaYcQNOJUCh66rO3Wah0WVSYXW7v3g40pfWIQXO7GoQSPwWqriRoThJROHB /SwDVFkOfm8E7YTH0JwCP0/k5SV4krRFiCHtHaoDK9l/Xw4B8cHC8dfVyQCMb7ePg8Dh whAw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id e8si2427994plt.399.2018.01.08.03.46.16; Mon, 08 Jan 2018 03:46:16 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932216AbeAHLqP (ORCPT + 28 others); Mon, 8 Jan 2018 06:46:15 -0500 Received: from szxga05-in.huawei.com ([45.249.212.191]:3753 "EHLO huawei.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1756407AbeAHLqK (ORCPT ); Mon, 8 Jan 2018 06:46:10 -0500 Received: from DGGEMS409-HUB.china.huawei.com (unknown [172.30.72.60]) by Forcepoint Email with ESMTP id A0637D3ECC2BC; Mon, 8 Jan 2018 19:45:55 +0800 (CST) Received: from localhost.localdomain.localdomain (10.175.113.25) by DGGEMS409-HUB.china.huawei.com (10.3.19.209) with Microsoft SMTP Server id 14.3.361.1; Mon, 8 Jan 2018 19:45:47 +0800 From: Xiongfeng Wang To: , , CC: , , , Subject: [PATCH] btrfs: use correct string length Date: Mon, 8 Jan 2018 19:51:22 +0800 Message-ID: <1515412282-57381-1-git-send-email-wangxiongfeng2@huawei.com> X-Mailer: git-send-email 1.8.3.1 MIME-Version: 1.0 X-Originating-IP: [10.175.113.25] X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Xiongfeng Wang gcc-8 reports fs/btrfs/ioctl.c: In function 'btrfs_ioctl': ./include/linux/string.h:245:9: warning: '__builtin_strncpy' specified bound 1024 equals destination size [-Wstringop-truncation] We need one less byte or call strlcpy() to make it a nul-terminated string. Signed-off-by: Xiongfeng Wang --- fs/btrfs/ioctl.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 1.8.3.1 Reviewed-by: David Sterba diff --git a/fs/btrfs/ioctl.c b/fs/btrfs/ioctl.c index 2ef8aca..e88c9e8 100644 --- a/fs/btrfs/ioctl.c +++ b/fs/btrfs/ioctl.c @@ -2807,7 +2807,7 @@ static long btrfs_ioctl_dev_info(struct btrfs_fs_info *fs_info, rcu_read_lock(); name = rcu_dereference(dev->name); - strncpy(di_args->path, name->str, sizeof(di_args->path)); + strncpy(di_args->path, name->str, sizeof(di_args->path) - 1); rcu_read_unlock(); di_args->path[sizeof(di_args->path) - 1] = 0; } else {