From patchwork Sat Nov 7 08:11:32 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Nick Desaulniers X-Patchwork-Id: 320893 Delivered-To: patch@linaro.org Received: by 2002:a17:906:d156:0:0:0:0 with SMTP id br22csp1100225ejb; Sat, 7 Nov 2020 00:11:54 -0800 (PST) X-Google-Smtp-Source: ABdhPJx0xQSdaSnuPxD5kX9P9Ly2BAjXHz1jpCmshV3QjGN81B8dMtbmMFUmnGEGBIW1sfQNn2Bf X-Received: by 2002:a05:6402:31b6:: with SMTP id dj22mr6188779edb.348.1604736714369; Sat, 07 Nov 2020 00:11:54 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1604736714; cv=none; d=google.com; s=arc-20160816; b=HiuaL2sGEMeCIvRE6xoF1M9EO695F1Gnmytbm/3CCL34oiMjUFt62s8L7zbiWnoFM2 8r38hOArdleDDqT4/FpN5Q5LRSTZidG1gUvt1JS1NCPDxYNzyD3BSoHG+y5EpyCPh/lu cNY0731RY/Q2AFPsjA06mlRklQ6fpho/sALEb9MCRRGiNZnDSH57hIr0XqzTBzdwnAUA b2oPqfbAuv2YFFRXVj2o6Q+PQOHhLh9UDTq3Onu1LWN7PRBSGMYc1iTQT8w+vssZ5dYb Ssu6lkwCDGrhh89hYJ21FFF6PQyRAzCt1RJ6sk7X1LCP+bbye2dIMYAhSDy09rx8/6Zw 96fg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:from:subject:mime-version:message-id:date :sender:dkim-signature; bh=zIepqu5/kHd0BQ24VYrLjVuZ9zG/2BQ74NYjRDAUWZk=; b=bOCApkTMU/QZMUUMJwQq0DwyeStPPc4VU3V5CalTub4GqvcpopdlqTlrhofCpNnoOf /nydwJxRGWfgoe2Wt4x1x+4j7zFaafZwCHiFmHcDYpu66krX/vu+MDZgWqEjjUHSR/Cn vrJGXmQCsSWkrblv6v2LNQMxBMg5k40BFrJnkg2PzY26JqqrSYF/JpgfUTobroVH9w8J lQxTJY7rRqf9F9yV15eSzDjjeJsFVyLuZtRxw+UrGcDg3xHDorROPb4kNl7qpuIRdbh9 iO15OTy2X7WVFooAvuPMJhXWxbqrzUf8360KnU3zTufOXEJnN18Mr+8l+wUD6+RywENP iC9g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@google.com header.s=20161025 header.b=h9pkFZyL; spf=pass (google.com: domain of linux-scsi-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-scsi-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id g4si1388663edw.15.2020.11.07.00.11.54 for ; Sat, 07 Nov 2020 00:11:54 -0800 (PST) Received-SPF: pass (google.com: domain of linux-scsi-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@google.com header.s=20161025 header.b=h9pkFZyL; spf=pass (google.com: domain of linux-scsi-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-scsi-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727866AbgKGILx (ORCPT ); Sat, 7 Nov 2020 03:11:53 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39906 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727738AbgKGILx (ORCPT ); Sat, 7 Nov 2020 03:11:53 -0500 Received: from mail-pl1-x649.google.com (mail-pl1-x649.google.com [IPv6:2607:f8b0:4864:20::649]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8B59BC0613CF for ; Sat, 7 Nov 2020 00:11:53 -0800 (PST) Received: by mail-pl1-x649.google.com with SMTP id z11so2247869pln.0 for ; Sat, 07 Nov 2020 00:11:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=sender:date:message-id:mime-version:subject:from:to:cc; bh=zIepqu5/kHd0BQ24VYrLjVuZ9zG/2BQ74NYjRDAUWZk=; b=h9pkFZyLB00WFqfhQWIrex8QbgyMxv2aGiLaAQD6RWUvp1KCihBehoqFvRhmzkEaLz +PMY8hbu+9mOTcmczSVH2lXRLMEvG/LaOcKj2vY5XdvrXzqJrQJDabu9lm2kCONypsBU BDnF7HEiG1hiWUdyhCJnoS6m5qenuZhyLMA6QGUIh553vIK0g7R2zVKGNl8cJ1ILoKGm WkD3bf65biqhtohrgQssuBKC1UN/6Xujs1QE2LoJ+EZo8BXdZPtp8cNgt/xo0ZfC93t3 n+VJvZJMgu5CPZ101GTYuLwvUBeipGzdk+5ZUIi9Xisn+jRa3M/k51/DD+Dg3RPdfAm4 5SGQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:date:message-id:mime-version:subject:from :to:cc; bh=zIepqu5/kHd0BQ24VYrLjVuZ9zG/2BQ74NYjRDAUWZk=; b=ftMX9ousR+jSL4zABD5QTMKvn5za93gGotYn0JM7RxZLwLKRUILxqGR9v2YT3j6dTS Xr5yNV3YSYxJ7XnaNftK7lK4gG8VyVrWj2mJPYW4wHbioWVHrGTzP3MfNS3JCF/W5U0X puZU74MeLoWY8zbEkYnF140tu2jmZMa9FfhdhEK889nzt3qLQ8zF+WlAc0fnwHEBMvWR +sAiJIlJpPzp5X752izSk33idyEOKJdXSRA2k7twwyb+g0MSnCpZqKW6rhtnDw0AxmKo lm3m+WCQM3FB9gHjB/2HC+usmNxax9i2iA+k8DfVxrL4PjnTBc/2naNqCD17XCTZ9R+Y IcxQ== X-Gm-Message-State: AOAM533FV0r8NQyVkgCacoMyOIgZX46t+pAALlHiGbYUlo+w9qCI6Bb1 KviU+q0vcLDymRculh9MeU9oRJzMz2pThDmA1lA= Sender: "ndesaulniers via sendgmr" X-Received: from ndesaulniers1.mtv.corp.google.com ([2620:15c:211:202:f693:9fff:fef4:4d25]) (user=ndesaulniers job=sendgmr) by 2002:a17:90a:9dcb:: with SMTP id x11mr3322415pjv.132.1604736712313; Sat, 07 Nov 2020 00:11:52 -0800 (PST) Date: Sat, 7 Nov 2020 00:11:32 -0800 Message-Id: <20201107081132.2629071-1-ndesaulniers@google.com> Mime-Version: 1.0 X-Mailer: git-send-email 2.29.2.222.g5d2a92d10f8-goog Subject: [PATCH] scsi: core: fix -Wformat From: Nick Desaulniers To: "James E . J . Bottomley" , "Martin K . Petersen" Cc: Nick Desaulniers , Nathan Chancellor , linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org, clang-built-linux@googlegroups.com Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org Clang is more aggressive about -Wformat warnings when the format flag specifies a type smaller than the parameter. Turns out, struct Scsi_Host's member can_queue is actually an int. Fixes: warning: format specifies type 'short' but the argument has type 'int' [-Wformat] shost_rd_attr(can_queue, "%hd\n"); ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ %d Link: https://github.com/ClangBuiltLinux/linux/issues/378 Signed-off-by: Nick Desaulniers --- drivers/scsi/scsi_sysfs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.29.2.222.g5d2a92d10f8-goog Reviewed-by: Nathan Chancellor diff --git a/drivers/scsi/scsi_sysfs.c b/drivers/scsi/scsi_sysfs.c index d6e344fa33ad..b6378c8ca783 100644 --- a/drivers/scsi/scsi_sysfs.c +++ b/drivers/scsi/scsi_sysfs.c @@ -370,7 +370,7 @@ static DEVICE_ATTR(eh_deadline, S_IRUGO | S_IWUSR, show_shost_eh_deadline, store shost_rd_attr(unique_id, "%u\n"); shost_rd_attr(cmd_per_lun, "%hd\n"); -shost_rd_attr(can_queue, "%hd\n"); +shost_rd_attr(can_queue, "%d\n"); shost_rd_attr(sg_tablesize, "%hu\n"); shost_rd_attr(sg_prot_tablesize, "%hu\n"); shost_rd_attr(unchecked_isa_dma, "%d\n");