From patchwork Wed Nov 4 19:35:14 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 318324 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH, MAILING_LIST_MULTI, SIGNED_OFF_BY, SPF_HELO_NONE, SPF_PASS, URIBL_BLOCKED, USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0961FC2D0A3 for ; Wed, 4 Nov 2020 19:38:30 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id AE84B20679 for ; Wed, 4 Nov 2020 19:38:29 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="eDmsFAU7" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729162AbgKDTgB (ORCPT ); Wed, 4 Nov 2020 14:36:01 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37438 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728815AbgKDTf7 (ORCPT ); Wed, 4 Nov 2020 14:35:59 -0500 Received: from mail-wm1-x341.google.com (mail-wm1-x341.google.com [IPv6:2a00:1450:4864:20::341]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CFEFDC0613D4 for ; Wed, 4 Nov 2020 11:35:58 -0800 (PST) Received: by mail-wm1-x341.google.com with SMTP id p19so2555801wmg.0 for ; Wed, 04 Nov 2020 11:35:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=wH+6ay3ML2IZuG2ItERyIkPsniEGNFXIQf0sfM9xhn4=; b=eDmsFAU7R/9xFhQgOZLSoSX4Ozyo7emaZvpoFzlYhKNIkMDz+wFqWLCCvpdbQvhFq8 ru8XqVU6zE7B6/3rxJWElO0jg8aRU4ZGGMgcpUY/ybI4fJEJZtA5qHFG1/qPv3D5ao4l hvhhcYYE7pHbLhzxIlNiz78CcLLxGru7pDHJpWucJPZUkhA1yu5CK+VK047+eqUDGSCg zoLNP36tEymkyuyGc6kuetKvRHfnu1GgmFtvoZ6sIqj2pA3Hn171mu5/7KpEpFELkmDK OfeA39skAzWp4Kjb9IYniGlqNkpeZ310jPckyoU/haA5GL6VPZAAuQg1wr/tt5i+6xgW Qt/Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=wH+6ay3ML2IZuG2ItERyIkPsniEGNFXIQf0sfM9xhn4=; b=X1ELCZsZ11j3AFpeAxtyo1vYCdU/1ik5uWCNd+eo7SCjLCgIYF4y/9Bmcy9AsYw35c gpcQNPAUbpOOQrRuYHUEEFMcOGWbhNNy+UIEyVLLERPpIlqjReCpxPCjBFC/PDilYm5V OXkfDRPW0ehb94s3iXUb2oMidp2rtusyZkcIfbh/4Bn5WxBOGUYGMz1G1CX4mfeqx92v Ng5g0tXzQ+UOM+gWMBOFSzD5dCoYZAaX7+JibPEOUgJHTr4szKiSjYEsR/Mx9FIBPqTS 1GJg4Bxcw6miiRLb+7v2FS8XM5smw8gx8H4SjFec4dEr412zIaNNZxg3G/McDOnHJBFg 8SjA== X-Gm-Message-State: AOAM533pnIma4TZjj96hd1AWWh0Ncb6PDPzqmfHmEf/tVSQFGjMjoHG6 td7kwqKsvz9OnS0GWKXrpMk8jQ== X-Google-Smtp-Source: ABdhPJwv9KaK3YsFPmWngapSaiAdWGp0IVoe9eZG7kU0Utng+LM5h3HswS/vwkbPrp46bn+qVqtzSg== X-Received: by 2002:a1c:4b0c:: with SMTP id y12mr6696117wma.91.1604518557593; Wed, 04 Nov 2020 11:35:57 -0800 (PST) Received: from dell.default ([91.110.221.242]) by smtp.gmail.com with ESMTPSA id x10sm4034444wrp.62.2020.11.04.11.35.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 04 Nov 2020 11:35:55 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, Rob Herring , Greg Kroah-Hartman , Jiri Slaby , linux-serial@vger.kernel.org Subject: [PATCH 01/36] tty: serdev: core: Remove unused variable 'dummy' Date: Wed, 4 Nov 2020 19:35:14 +0000 Message-Id: <20201104193549.4026187-2-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20201104193549.4026187-1-lee.jones@linaro.org> References: <20201104193549.4026187-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-serial@vger.kernel.org No need to have a dummy variable here. Fixes the following W=1 kernel build warning(s): drivers/tty/serdev/core.c: In function ‘serdev_controller_remove’: drivers/tty/serdev/core.c:791:6: warning: variable ‘dummy’ set but not used [-Wunused-but-set-variable] Cc: Rob Herring Cc: Greg Kroah-Hartman Cc: Jiri Slaby Cc: linux-serial@vger.kernel.org Signed-off-by: Lee Jones --- drivers/tty/serdev/core.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/tty/serdev/core.c b/drivers/tty/serdev/core.c index c5f0d936b003a..fecc28a73b3b2 100644 --- a/drivers/tty/serdev/core.c +++ b/drivers/tty/serdev/core.c @@ -788,13 +788,10 @@ static int serdev_remove_device(struct device *dev, void *data) */ void serdev_controller_remove(struct serdev_controller *ctrl) { - int dummy; - if (!ctrl) return; - dummy = device_for_each_child(&ctrl->dev, NULL, - serdev_remove_device); + device_for_each_child(&ctrl->dev, NULL, serdev_remove_device); pm_runtime_disable(&ctrl->dev); device_del(&ctrl->dev); } From patchwork Wed Nov 4 19:35:15 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 318331 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH, MAILING_LIST_MULTI, SIGNED_OFF_BY, SPF_HELO_NONE, SPF_PASS, URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 54286C5517A for ; Wed, 4 Nov 2020 19:36:04 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id EC2E02083B for ; Wed, 4 Nov 2020 19:36:03 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="h+kQLTPY" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729796AbgKDTgD (ORCPT ); Wed, 4 Nov 2020 14:36:03 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37446 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729755AbgKDTgC (ORCPT ); Wed, 4 Nov 2020 14:36:02 -0500 Received: from mail-wm1-x342.google.com (mail-wm1-x342.google.com [IPv6:2a00:1450:4864:20::342]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D4918C0613D3 for ; Wed, 4 Nov 2020 11:36:00 -0800 (PST) Received: by mail-wm1-x342.google.com with SMTP id p19so2555851wmg.0 for ; Wed, 04 Nov 2020 11:36:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=JW70o12XNpg7Pls0I5UJqPceVTayC1ax5WqT/gg/jic=; b=h+kQLTPYyWmvEgFxKMgTNJi/nylDDDsXmcFqxjiOdqAtQTbAImcROA2sotobq6lpo0 jB0H1YTo4nlZXKC9Xj4RMUZEIy/3lnqtI7yaoXm5bxhbsqWp1+a7POtqn8vNktgu8O9T huZw1rD4AllsPMZt4Yj7JtJdBXacm4BGeEKBmeN4y4LHHIM/7Ixufip6hhIAHdd9I0/o sEep/7a4YxJxDSJAfi4NkZjpE/vmJR0x7KoX7hn/wkiPvD0EL2XB9D8CTptVi/BZ4Oa+ NH1zaio7VCrywiAveY81K+O6IKYbYaNIMb0U0L8tilugXC68rv3BthrU/O4l3eTSkns2 Lykw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=JW70o12XNpg7Pls0I5UJqPceVTayC1ax5WqT/gg/jic=; b=od0dnwnTXOoieIUBUKUg+Bu+1IYvy5N1EHntZ5vBo1UQi3nK5C3joD6K3WAGQQqZmO EgTLPPSW15CuTYsZ0fr323YvBc8/UtLXNJk72E7ABqDo8Q8Xow0UbC1axpRTHvKBbzoD cZfpj2+bzGf8QJY9Fw76VnNvUFoLAYDnq08g8MmHoGWGzb9PES4yPnHyWhtKlDr9NHVb kF4LvJrTn/JZ0uxvw7c31ZCRcXfljZsSVilg7tbeuXs3SG+bVQxtNKMu5hYWRjKlgQKD CnzCFm+Pc9UXvZMsQIxSi7QlrHGz4jgAIRWQ/RSRs73WpvnwYvH+YCh2GihDhAMh1oWt gtuw== X-Gm-Message-State: AOAM531hAHEZL1GSlLudHMbE4bPeTb9Bs0fyhSN1ftbAuSX9kOdU81OR fbxQC0jOqDVA/IIVZeKscu/vVA== X-Google-Smtp-Source: ABdhPJxOkOq8fS0a1MUngKpjjUe7WzFMXAF3FIw5qyC+UNLOlYzwjwI0W4E8s804WZN4+sp0661uhA== X-Received: by 2002:a7b:c14f:: with SMTP id z15mr6499816wmi.174.1604518559545; Wed, 04 Nov 2020 11:35:59 -0800 (PST) Received: from dell.default ([91.110.221.242]) by smtp.gmail.com with ESMTPSA id x10sm4034444wrp.62.2020.11.04.11.35.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 04 Nov 2020 11:35:58 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, Rob Herring , Greg Kroah-Hartman , Jiri Slaby , linux-serial@vger.kernel.org Subject: [PATCH 02/36] tty: serdev: core: Provide missing description for 'owner' Date: Wed, 4 Nov 2020 19:35:15 +0000 Message-Id: <20201104193549.4026187-3-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20201104193549.4026187-1-lee.jones@linaro.org> References: <20201104193549.4026187-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-serial@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/tty/serdev/core.c: In function ‘serdev_controller_remove’: drivers/tty/serdev/core.c:811: warning: Function parameter or member 'owner' not described in '__serdev_device_driver_register' Cc: Rob Herring Cc: Greg Kroah-Hartman Cc: Jiri Slaby Cc: linux-serial@vger.kernel.org Signed-off-by: Lee Jones --- drivers/tty/serdev/core.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/tty/serdev/core.c b/drivers/tty/serdev/core.c index fecc28a73b3b2..aead0c0c97966 100644 --- a/drivers/tty/serdev/core.c +++ b/drivers/tty/serdev/core.c @@ -800,6 +800,7 @@ EXPORT_SYMBOL_GPL(serdev_controller_remove); /** * serdev_driver_register() - Register client driver with serdev core * @sdrv: client driver to be associated with client-device. + * @owner: client driver owner to set. * * This API will register the client driver with the serdev framework. * It is typically called from the driver's module-init function. From patchwork Wed Nov 4 19:35:24 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 320579 Delivered-To: patch@linaro.org Received: by 2002:a92:7b12:0:0:0:0:0 with SMTP id w18csp5699210ilc; Wed, 4 Nov 2020 11:38:09 -0800 (PST) X-Google-Smtp-Source: ABdhPJzn8AWuepKnpBpLdU8OgP4y4i8PbWLLQhIXq72HvnxD2NZZgqNWanaLyC4/5DryCumyiQWB X-Received: by 2002:a17:906:3e08:: with SMTP id k8mr27248512eji.478.1604518689358; Wed, 04 Nov 2020 11:38:09 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1604518689; cv=none; d=google.com; s=arc-20160816; b=Mcwiahvd+wzieljvoAmiGscYNNnxJdyM8JMHtbc0Kv8GOjpMFWaPbP96GR+YOwViJU 7eY6EW77WKADyTLg8X6Fe2V54fJ1vF/o82fz+eETQUiXlDoOt2yZTJ3LsFBR/DRfPRWa Z09EbNSOzDsPkSbwhNdTzOoX7NkXMnDzHSG7sUkTxSdx+tPFZt5yH3gBucucnQCBRRIc jK3xv4/l9Py8TefEzsRI+ZPxNhltjsFh5EQyPjCZKB9FxC84fkyx6F0aNJK1rtx81tLK pc8c6z8Sn9xhf+zqCtMDGbKefJY0og9zJWLZDSHoiWR0Z9FLfDnHHl6CVhNxJcl0j4lW dzHQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=ADzQpX5A5QQGn5KGe8b3uSGzs1neIIdNiiTGg04Pmgw=; b=IESlciw37FggvYBhLkGawEPQEufXvHCldsSIwdCPv965Z9EvKuuoQeqVY/UZwFmv+P HcuMEOPw2qOPq5ugSELCT+X+pB0oelPacDqVKReUNki6VXPVw4/5cBD8Pq4HhyYQzUKH cgYwAK9VXnIWe6lTBBCiL9GtG39Zj+I1+bJdBK3+C2rGMHKTT58ZUwqBk6cwcjOZ3DN/ I7qPiuKQ5tcpeRgFD03oNzwx4QiYcyqjLXBUq7OfO0MyLpSiefnyhT0W9S8+BGGvjVZ5 GO86NUg/hYp20Rim2eKUjczadIzMxI4hury5CPkmkNFtq+94/De9S20ps5ezQljx5Rlf A6lg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=SrO3RCdI; spf=pass (google.com: domain of linux-serial-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-serial-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id bi9si2724376edb.4.2020.11.04.11.38.09; Wed, 04 Nov 2020 11:38:09 -0800 (PST) Received-SPF: pass (google.com: domain of linux-serial-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=SrO3RCdI; spf=pass (google.com: domain of linux-serial-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-serial-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730741AbgKDTgR (ORCPT + 2 others); Wed, 4 Nov 2020 14:36:17 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37508 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730732AbgKDTgQ (ORCPT ); Wed, 4 Nov 2020 14:36:16 -0500 Received: from mail-wr1-x444.google.com (mail-wr1-x444.google.com [IPv6:2a00:1450:4864:20::444]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 41ABEC0613D4 for ; Wed, 4 Nov 2020 11:36:16 -0800 (PST) Received: by mail-wr1-x444.google.com with SMTP id c17so3960172wrc.11 for ; Wed, 04 Nov 2020 11:36:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=ADzQpX5A5QQGn5KGe8b3uSGzs1neIIdNiiTGg04Pmgw=; b=SrO3RCdIyN9ljWbZI6XCZ7EywYfrOo1xL8zKsErdi7L1aIALt/FKwB1/2mjx1Kllud tuurfpjJWEkhKTaVoIke0qteXbRh8SibXQ7RlvzTiWJ4Z/zFCcHciaQaD237p5F5iMtz 8oet6e9lsDIJbHOWAHI5YM4v7zUdCc/A5kCSKH3JXgfIT8ZKrolGsKEPL952SPz4VoP+ ZM1UoOLhvqGsV3JcGZNnOLEONBkfa3yya5gfvRY8Xgda+F0JHN7ibRTsBge5yoB/rukI hvllAsPhVlwJI5kK767AMsXVF5HLO4GXv2jToESPDup0u4FMjQ3uabpPemajT9A1/yqI 0g9A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=ADzQpX5A5QQGn5KGe8b3uSGzs1neIIdNiiTGg04Pmgw=; b=KhuR/+S/gqowq8JWPATOlV9hCF8RUNx5R+L7oIQ5f02tKHwezMQW1T3JuRV7Ry9E1b TKNS6YwbUc3qOdZ8Gwem/P+qTmNkrcJCI8MyPR0mXyxu3uqzv3UsbkNeVVKRcA2NDe1D QljgHNuIHz7w0LxyA29BxrB64Am7L67YWQY46kEPsw5G+3KurbWGax24pPdn/E6ZciL1 DH2Cm2Vx5i0Vj6P/4oXvR5ZxKBsQGGmrF8juelgAajj5PNwjECRW0eeSz//9TnrAJafl Sy0uMXMlv5anSqtWi/Kmx+Hqdz8XKhiEg6ibm3AL3jdxAS27cf2NbiDyQ3lDiQkIfJc5 NZfw== X-Gm-Message-State: AOAM530LDAJkCtB+Xv5KmGWvSoatTHFxQOLaaQh+XTA+SQO9rJEqlPOz /Wqy4FemWhIOPdhD1ut3g+eUMx3UvJEko4id X-Received: by 2002:adf:e3c2:: with SMTP id k2mr33940946wrm.412.1604518574973; Wed, 04 Nov 2020 11:36:14 -0800 (PST) Received: from dell.default ([91.110.221.242]) by smtp.gmail.com with ESMTPSA id x10sm4034444wrp.62.2020.11.04.11.36.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 04 Nov 2020 11:36:14 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, Greg Kroah-Hartman , Jiri Slaby , linux-serial@vger.kernel.org Subject: [PATCH 11/36] tty: serial: jsm: jsm_cls: Remove unused variable 'discard' Date: Wed, 4 Nov 2020 19:35:24 +0000 Message-Id: <20201104193549.4026187-12-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20201104193549.4026187-1-lee.jones@linaro.org> References: <20201104193549.4026187-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-serial@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/tty/serial/jsm/jsm_cls.c: In function ‘cls_copy_data_from_uart_to_queue’: drivers/tty/serial/jsm/jsm_cls.c:400:7: warning: variable ‘discard’ set but not used [-Wunused-but-set-variable] Cc: Greg Kroah-Hartman Cc: Jiri Slaby Cc: linux-serial@vger.kernel.org Signed-off-by: Lee Jones --- drivers/tty/serial/jsm/jsm_cls.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) -- 2.25.1 diff --git a/drivers/tty/serial/jsm/jsm_cls.c b/drivers/tty/serial/jsm/jsm_cls.c index c061a7b7bd233..b507a2cec9269 100644 --- a/drivers/tty/serial/jsm/jsm_cls.c +++ b/drivers/tty/serial/jsm/jsm_cls.c @@ -397,10 +397,8 @@ static void cls_copy_data_from_uart_to_queue(struct jsm_channel *ch) * which in this case is the break signal. */ if (linestatus & error_mask) { - u8 discard; - linestatus = 0; - discard = readb(&ch->ch_cls_uart->txrx); + readb(&ch->ch_cls_uart->txrx); continue; } From patchwork Wed Nov 4 19:35:26 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 318325 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH, MAILING_LIST_MULTI, SIGNED_OFF_BY, SPF_HELO_NONE, SPF_PASS, URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EE671C4741F for ; Wed, 4 Nov 2020 19:38:07 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 984A1221FA for ; Wed, 4 Nov 2020 19:38:07 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="n+SGLyXN" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732011AbgKDTiF (ORCPT ); Wed, 4 Nov 2020 14:38:05 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37528 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730877AbgKDTgT (ORCPT ); Wed, 4 Nov 2020 14:36:19 -0500 Received: from mail-wm1-x342.google.com (mail-wm1-x342.google.com [IPv6:2a00:1450:4864:20::342]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D2CA1C061A4A for ; Wed, 4 Nov 2020 11:36:18 -0800 (PST) Received: by mail-wm1-x342.google.com with SMTP id c16so3418818wmd.2 for ; Wed, 04 Nov 2020 11:36:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=qTLE3fDx+u6VjTzT6dpTTPCm/8rHPP6boBELCTFmpBg=; b=n+SGLyXNvdQU4rjj4mubZsi4hwbLwsTcsnnLwzYDMPIhbwe63+nVO1NWaX3aS6dmUx 3L/2agKl25gvbYPSbv11aqzMRSZv7UekzcbL2Z9mLOgjzaBviP2JGHkvIB+ENAsZBE24 p+G+FPrfRxa40tohZRpg7hUd5mVHby44jPtaARISzVZpbjgyuZPQHOBKD5nTwEqQI0Vq gwqlnt1aDiKbnT7CSkc1eH3UIV2qVrmFfe3YtZAnDa/D9H5yuzEfaEHhkfLYk5ETcxc0 3JKmbCti5Dkc3YvISF1bIqsTEKyvNXpzwSmk+IOF2D2nIHjg2/CPkBhUfTe60fEefXKq h4XA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=qTLE3fDx+u6VjTzT6dpTTPCm/8rHPP6boBELCTFmpBg=; b=k5xf1QxAwV9WPRCsk0G+UHxGKHai0znZdpRGVORS6J3pXOXhGx+VPJYk3uOgouR8un 83R7uVJB/QNXa4AxfRzo80dCTWTOPTRetZBCyW5Nc6fNj3W6BdG/PKP/AMYIaFBk31cM dW2zF5ZmfpsKCrIGkyugMh/0l4qqoXT3Wf/DuEw/HgfMpkq0Y4C0qqKNpPCeNFU7tS9X 3Iqs7stvyHb+lXOM9gNtoLOkMOfzQ5mjgmM/jUPjCBonVH4KNqJVN8dWuVSXJEz7EM3o 1BS4d+IVXohIr41S+0le2nksUwxR0pgB0MUhcOo+ZQRCp+Y+WmSw5fwhLzWp/kYFui4p 819g== X-Gm-Message-State: AOAM532WE4iaZLFeeE82WZAbf5D45tWmrE6OaU1j+Pa9ynKGsFA7eUls Nmfg90ikSEeGDmFVhLozULT+Yg== X-Google-Smtp-Source: ABdhPJwiMgTaKQBz/vW+Q77lWF+7EeqsbsMelVL8C6QvCfsvxmsIndZmwUuB1UXHj60cFSp3ozaydA== X-Received: by 2002:a1c:bcd6:: with SMTP id m205mr6115133wmf.47.1604518577576; Wed, 04 Nov 2020 11:36:17 -0800 (PST) Received: from dell.default ([91.110.221.242]) by smtp.gmail.com with ESMTPSA id x10sm4034444wrp.62.2020.11.04.11.36.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 04 Nov 2020 11:36:16 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, Greg Kroah-Hartman , Jiri Slaby , Mike Hudson , linux-serial@vger.kernel.org Subject: [PATCH 13/36] tty: serial: 8250: 8250_port: Staticify functions referenced by pointers Date: Wed, 4 Nov 2020 19:35:26 +0000 Message-Id: <20201104193549.4026187-14-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20201104193549.4026187-1-lee.jones@linaro.org> References: <20201104193549.4026187-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-serial@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/tty/serial/8250/8250_port.c:349:14: warning: no previous prototype for ‘au_serial_in’ [-Wmissing-prototypes] drivers/tty/serial/8250/8250_port.c:359:6: warning: no previous prototype for ‘au_serial_out’ [-Wmissing-prototypes] Cc: Greg Kroah-Hartman Cc: Jiri Slaby Cc: Mike Hudson Cc: linux-serial@vger.kernel.org Signed-off-by: Lee Jones --- drivers/tty/serial/8250/8250_port.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/tty/serial/8250/8250_port.c b/drivers/tty/serial/8250/8250_port.c index b0af13074cd36..ebce4406dc289 100644 --- a/drivers/tty/serial/8250/8250_port.c +++ b/drivers/tty/serial/8250/8250_port.c @@ -346,7 +346,7 @@ static const s8 au_io_out_map[8] = { -1, /* UART_SCR (unmapped) */ }; -unsigned int au_serial_in(struct uart_port *p, int offset) +static unsigned int au_serial_in(struct uart_port *p, int offset) { if (offset >= ARRAY_SIZE(au_io_in_map)) return UINT_MAX; @@ -356,7 +356,7 @@ unsigned int au_serial_in(struct uart_port *p, int offset) return __raw_readl(p->membase + (offset << p->regshift)); } -void au_serial_out(struct uart_port *p, int offset, int value) +static void au_serial_out(struct uart_port *p, int offset, int value) { if (offset >= ARRAY_SIZE(au_io_out_map)) return; From patchwork Wed Nov 4 19:35:27 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 318330 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH, MAILING_LIST_MULTI, SIGNED_OFF_BY, SPF_HELO_NONE, SPF_PASS, URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 329D1C4742C for ; Wed, 4 Nov 2020 19:36:28 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C4E892080D for ; Wed, 4 Nov 2020 19:36:27 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="YHTiFMRk" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731106AbgKDTgX (ORCPT ); Wed, 4 Nov 2020 14:36:23 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37536 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730971AbgKDTgU (ORCPT ); Wed, 4 Nov 2020 14:36:20 -0500 Received: from mail-wr1-x443.google.com (mail-wr1-x443.google.com [IPv6:2a00:1450:4864:20::443]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2E0CBC0613D3 for ; Wed, 4 Nov 2020 11:36:20 -0800 (PST) Received: by mail-wr1-x443.google.com with SMTP id w1so23361862wrm.4 for ; Wed, 04 Nov 2020 11:36:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=ZRGBxzQtBfGTRe7EqXYUnIcL2t2WHoGJ4hWtx+aHv4c=; b=YHTiFMRkE/9n47TPA+A1i93yUz5O+ImX7W2Xhyx04uUSduApku9suwx2FzSaJonUjv a5PHQ0i/GK4CbcDeK70V1zA0ZOBWfJ3fk2Uv4lCIVFBs5FB5EQq+t3ocSxZLRV1r/XHO x6VwGq7e99bbQT4nil61aoKB0hqOdR4mlrIB5dxW6Cps44btfF82dRoyEb1OkrIYS8VX BfcindWv8Z9YWFBpW++7Sr22VbItLakxYMCWqAxVYZBPmYGoWSmEM9JKNH6ECbm8faHs qf5Ab9xOaLJGu7XkIhax8pLb5i7yP7YFn6q39FTKiOk0D+mQGZgEkeimJfS6FW5KLv8e dDQA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=ZRGBxzQtBfGTRe7EqXYUnIcL2t2WHoGJ4hWtx+aHv4c=; b=OqgK0Kv5coZ/0Pqe8gldhZIrXjeYqCmFcbSDhq2KNicyBi/D90nEUQLKN5lZzsWNXR GPWXBQzObpzD6k4/pTlfah+tkiAAfCTIuZ4p//TWVVZKKI4HgqJJBzoSjsrmYoNLgl84 /iAie0LdnHKTUBZ008HWLZkPJy7Xo90/fJ7Je1w2AAlruH51khw53ghrOSfaZY+5FsEa iX9kPPW0kZwvZOwhIBQz04lz217CHABj2LEN7SnjX+CxGLanKLpiQ5eG+fvin0xuzfhl FnA357OSewVsQ+nwYgQMsIxQ0UkVwdpQmV5AvDeVAAk1A4IzPiGplnq210HvOg9Uq/E6 zS2Q== X-Gm-Message-State: AOAM5319vvIeVrQVhYb5Arg3Fm/LvQ33aFvFBhuFp50zyWp+BF/PhA1y vbX02Ag2sZTXnooFpVQb/hHvbQ== X-Google-Smtp-Source: ABdhPJzjdlEHI3sL271W1qkBQa43pmdUJBTxOaZr9G05Uu6C1ihR+7MN/MOPLi/I6w4LuoxiC4k5Ng== X-Received: by 2002:adf:c101:: with SMTP id r1mr32418679wre.87.1604518578909; Wed, 04 Nov 2020 11:36:18 -0800 (PST) Received: from dell.default ([91.110.221.242]) by smtp.gmail.com with ESMTPSA id x10sm4034444wrp.62.2020.11.04.11.36.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 04 Nov 2020 11:36:18 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, Greg Kroah-Hartman , Jiri Slaby , Colin Ian King , "David A. Hinds" , linux-serial@vger.kernel.org Subject: [PATCH 14/36] tty: serial: 8250: serial_cs: Remove unused/unchecked variable 'err' Date: Wed, 4 Nov 2020 19:35:27 +0000 Message-Id: <20201104193549.4026187-15-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20201104193549.4026187-1-lee.jones@linaro.org> References: <20201104193549.4026187-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-serial@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/tty/serial/8250/serial_cs.c: In function ‘multi_config’: drivers/tty/serial/8250/serial_cs.c:562:7: warning: variable ‘err’ set but not used [-Wunused-but-set-variable] Cc: Greg Kroah-Hartman Cc: Jiri Slaby Cc: Colin Ian King Cc: "David A. Hinds" Cc: linux-serial@vger.kernel.org Signed-off-by: Lee Jones --- drivers/tty/serial/8250/serial_cs.c | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/drivers/tty/serial/8250/serial_cs.c b/drivers/tty/serial/8250/serial_cs.c index e3d10794dbba3..35ff6627c61be 100644 --- a/drivers/tty/serial/8250/serial_cs.c +++ b/drivers/tty/serial/8250/serial_cs.c @@ -559,16 +559,13 @@ static int multi_config(struct pcmcia_device *link) */ if (info->manfid == MANFID_OXSEMI || (info->manfid == MANFID_POSSIO && info->prodid == PRODID_POSSIO_GCC)) { - int err; - if (link->config_index == 1 || link->config_index == 3) { - err = setup_serial(link, info, base2, - link->irq); + setup_serial(link, info, base2, link->irq); base2 = link->resource[0]->start; } else { - err = setup_serial(link, info, link->resource[0]->start, - link->irq); + setup_serial(link, info, link->resource[0]->start, + link->irq); } info->c950ctrl = base2; From patchwork Wed Nov 4 19:35:30 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 320567 Delivered-To: patch@linaro.org Received: by 2002:a92:7b12:0:0:0:0:0 with SMTP id w18csp5698214ilc; Wed, 4 Nov 2020 11:36:27 -0800 (PST) X-Google-Smtp-Source: ABdhPJxR5Cx07NYN5Ab0FX5B4gxTTXRRsZvJ3NttwxL83F3YRam33PN+NWbwkf0lxMb+iUkaR2Ns X-Received: by 2002:a05:6402:3056:: with SMTP id bu22mr28164963edb.252.1604518587095; Wed, 04 Nov 2020 11:36:27 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1604518587; cv=none; d=google.com; s=arc-20160816; b=TWHcbUbtfReX26auOGnJAxpxQuB9H2mX7Cyv7EJoZc+7ICyjtJSbU+xSM0hK/tUOe2 xqzoBJZTieek1VEldP0b8NnheVtJ4sH6CfeAnJg6oDaafUWaRCUdSsi5COsNZqTsQQ+L huNDWgQrx3kxS1XCuCy9zwafOrrR3iAR8lT6H6nKQ1U8w6sVUT90HKT5CPbbMec0+67N HxJ2F8HZ8VVYRuWUEUB6xRiamgKHfWk/T12iYeSAFelTH2j25WRq+woxHG1zwmY72EVx 5o1vp/7M73CuZxfiZsdM3bSIAsUKG59UPMiNO69n1ULK9UUGQxuGtIvYu2fg2/pqAlxm usug== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=PCthp+iIayFdO+hk3LjcuMh49TMSV9TDkGCxD2U2U74=; b=NtIeSIb4yAFfPO7lLUJvKdHimLDXId+VWyu9rAlEpa+pooqbVa3RWS4H91NO+kfMNy NLFooulvCU9trvvjZ0ZBA2+nufxWX+NTrb/cB8QyLe+YQtd/k/8ASGjonYyUeAirC/rC K/b03qs4zPqZAU40neXFaiMsZXEnPiSgpJQknt2b5gJ1QdMEaMAlw97c4pK9ttVvBodi Czxc8oMf6ZaT8KXtTg7s61DJSib3xekOH3rno3dL0re4NBURsYFDhcE8DB3Taegwo5Vs wJvgHnlIdeF7Z9xezFRl/Xt/N1WvVo3puAJQffg/9qdZ/DMGydAAHdEMogN9yN6p73L4 UrLQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=tdLzplEr; spf=pass (google.com: domain of linux-serial-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-serial-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id q26si2019418ejb.105.2020.11.04.11.36.26; Wed, 04 Nov 2020 11:36:27 -0800 (PST) Received-SPF: pass (google.com: domain of linux-serial-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=tdLzplEr; spf=pass (google.com: domain of linux-serial-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-serial-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731047AbgKDTgZ (ORCPT + 2 others); Wed, 4 Nov 2020 14:36:25 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37554 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731018AbgKDTgY (ORCPT ); Wed, 4 Nov 2020 14:36:24 -0500 Received: from mail-wm1-x344.google.com (mail-wm1-x344.google.com [IPv6:2a00:1450:4864:20::344]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 74F65C0613D3 for ; Wed, 4 Nov 2020 11:36:24 -0800 (PST) Received: by mail-wm1-x344.google.com with SMTP id h2so881740wmm.0 for ; Wed, 04 Nov 2020 11:36:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=PCthp+iIayFdO+hk3LjcuMh49TMSV9TDkGCxD2U2U74=; b=tdLzplErGzlsTMvA24FKwL+xCV7IDZGYkhg0Ou03OOiOpukQUndtoqdN4Btssu+uh5 pHqlPj6YXHeaWY3svCwI+7BVuZnpLg9kcBdM3/i04heoyrJMQNzzUhmNBeh8Yx1aNXF9 zfq84NfJovwoP6B0NFVL4tsiXIWzvB3qmeFTQP1QCxQ/Jsk/MR9hKniaUp9Hnjz3XE88 pvWufpKWRjTPPVPfazBFWwYRfO50piv+Fff8KFd1J6zfTrJfwY9nT65ktGWC6K+/eWMX NMTU5EATHwcZAsh3okG6nCEDbMWxSQN4ts5Y5s9aEIz0sXJZ8GY2v+CtagQdWeVvYYyH ce5g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=PCthp+iIayFdO+hk3LjcuMh49TMSV9TDkGCxD2U2U74=; b=N2RSUH9MbU0+WkrM3BfAY8ijIVQSVbmikDGwzdmwxtz9flVTEQmj6/4mUw/rRMCaBb a9KFxFQjLPVoR2ZByLfoNRlz0JnV65NSBrRoVaCC+WBeZY2sdbqKEC2lg42npXkRn+9h kYi1cNlL2n4h4YGU+X17qWMb7IzAVR8qo5b4QvkfRVs8ZeJjA1bzQU4kv39CmDWpzexr gEYMlxjsSXXrmToWd3DGks5kCk2+/HxD67SlZKwFhMXnCkMM9yoG0gmh65fhbPAVGJjW C3RJo/BdykyJMinodcQ93IgUVshX4fvRXU0fH8ty2hsn1e7+BNPJRzhjtiy3YdFTL/yY n+Uw== X-Gm-Message-State: AOAM531I9a+24Fdj04gK6co6bTgWUi4f0RMyeiQBSrEswyDUVs5UfyLf gwOM13bzG7F4ehiEh3QfPguKcQ== X-Received: by 2002:a7b:c11a:: with SMTP id w26mr6582229wmi.78.1604518583103; Wed, 04 Nov 2020 11:36:23 -0800 (PST) Received: from dell.default ([91.110.221.242]) by smtp.gmail.com with ESMTPSA id x10sm4034444wrp.62.2020.11.04.11.36.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 04 Nov 2020 11:36:22 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, Russell King , Greg Kroah-Hartman , Jiri Slaby , linux-serial@vger.kernel.org Subject: [PATCH 17/36] tty: serial: amba-pl011: Mark 'sbsa_uart_acpi_match' as __maybe_unused Date: Wed, 4 Nov 2020 19:35:30 +0000 Message-Id: <20201104193549.4026187-18-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20201104193549.4026187-1-lee.jones@linaro.org> References: <20201104193549.4026187-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-serial@vger.kernel.org When !ACPI 'sbsa_uart_acpi_match' is not referenced. Fixes the following W=1 kernel build warning(s): drivers/tty/serial/amba-pl011.c:2792:36: warning: ‘sbsa_uart_acpi_match’ defined but not used [-Wunused-const-variable=] Cc: Russell King Cc: Greg Kroah-Hartman Cc: Jiri Slaby Cc: linux-serial@vger.kernel.org Signed-off-by: Lee Jones --- drivers/tty/serial/amba-pl011.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.25.1 diff --git a/drivers/tty/serial/amba-pl011.c b/drivers/tty/serial/amba-pl011.c index 87dc3fc15694a..c255476cce287 100644 --- a/drivers/tty/serial/amba-pl011.c +++ b/drivers/tty/serial/amba-pl011.c @@ -2789,7 +2789,7 @@ static const struct of_device_id sbsa_uart_of_match[] = { }; MODULE_DEVICE_TABLE(of, sbsa_uart_of_match); -static const struct acpi_device_id sbsa_uart_acpi_match[] = { +static const struct acpi_device_id __maybe_unused sbsa_uart_acpi_match[] = { { "ARMH0011", 0 }, {}, }; From patchwork Wed Nov 4 19:35:32 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 320577 Delivered-To: patch@linaro.org Received: by 2002:a92:7b12:0:0:0:0:0 with SMTP id w18csp5699021ilc; Wed, 4 Nov 2020 11:37:48 -0800 (PST) X-Google-Smtp-Source: ABdhPJwChOGeKGm39laP2S/xk27qPiUegEJeo1VNGvQDco9Euv97oSLK9O/Z6+N17zijeBfoD9+Z X-Received: by 2002:aa7:ce8c:: with SMTP id y12mr29719610edv.185.1604518668488; Wed, 04 Nov 2020 11:37:48 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1604518668; cv=none; d=google.com; s=arc-20160816; b=uiF6c8Gl7As/xY7oMqMEdxnpzmyfcJT7z5y/TKsJ8FnrpF4v5p7+5POGhpVvM5alrs idkikWxGT21+8H0oU9t5nXahJOQYduNNQq6cNyrlr5tIxMdFUuHjASB+JCMy6iQAs6fT viaC723qsFcDVTvC4DU5dFxLZ6sihW7zxC7G2q0rJjJWDrPLlFxrtwmj9EWFpxOqnGFD 1rLEKMdDL6I9cIjfCVdfn53iIHiH0dNTijgOtmvTaByx9idr7asQqWvbecvp/lNNsTaE aN0otlVYAbVFIc9v9T0aXR3dB7rwirjEA8FsOOC5uSlsjvOdCRf7+8Ih+oqO0U19pLpQ k6UQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=sjXTZO3THTknUKc+FF8iaHBvsw+0f6VMadCbFHOAPuM=; b=mHiqyWtezqa63j9w6Qono88VP5TMcMwRDXnAGQFPcL8oyYDHioUUWTXBzfm7CfHyVb inHvIBwTIC2jXO3fvkhrkp8jXYhlS8EtmQLQOx6GoIjW7Kgsb9wf70fMH1FvAh6YAtsC Y0JGtK1FP5RqEMG3p8EjPApEgWMeOFn4krTBfw0WyX0kSmUgFu6gOBw4sfpRQgi5IWA3 IwnpiT35+mE9C+OLdvA4vzhnDttnB4Q5WyuGvCYq9siLTIrlFNjNhejOp60xzv9/EkgW xg+7Xxf74Q+mS5f6MdPO5MiwEBUdCUwRZq/jDdL4Kbg85N9NyzUIs8ATFYwRnI2vvUWj f1hg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b="ms2JX/ol"; spf=pass (google.com: domain of linux-serial-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-serial-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id j16si1958150eja.72.2020.11.04.11.37.48; Wed, 04 Nov 2020 11:37:48 -0800 (PST) Received-SPF: pass (google.com: domain of linux-serial-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b="ms2JX/ol"; spf=pass (google.com: domain of linux-serial-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-serial-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730295AbgKDThr (ORCPT + 2 others); Wed, 4 Nov 2020 14:37:47 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37570 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731210AbgKDTg1 (ORCPT ); Wed, 4 Nov 2020 14:36:27 -0500 Received: from mail-wr1-x444.google.com (mail-wr1-x444.google.com [IPv6:2a00:1450:4864:20::444]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 22DC0C061A4C for ; Wed, 4 Nov 2020 11:36:27 -0800 (PST) Received: by mail-wr1-x444.google.com with SMTP id g12so23287943wrp.10 for ; Wed, 04 Nov 2020 11:36:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=sjXTZO3THTknUKc+FF8iaHBvsw+0f6VMadCbFHOAPuM=; b=ms2JX/olfhvXUd5gZU8GpM2AlBUdhsOVTqftJLAZsSd3S6CA4St9e8Z3GVUJOPmBH3 Wv+e5VL/yIgilU8EvaWEC11WiXxDDYSZTosDlw9sO3Gem/ACN7zcS+464DoBy798QAcH OPG1s6i1ZL6NhVvbs5YXlsbdqZEHIzc0+LOC4YSprETgdP0IUwxP1HatTFbZr3Q1gVcv i854ry1t+jafdMYbiPc8nv8BT3ro4yc3QyZESN0BlPVfflbvzS0u+2sy5v8ZA98Wm1GT r3s419fmQ+DJ0EwoWS+et3BfGfkP9LbKal++RpqWiA5dqdiTmztKyhwwOy9HGefmTbgE YXXg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=sjXTZO3THTknUKc+FF8iaHBvsw+0f6VMadCbFHOAPuM=; b=EKBWYpW1YVBCECYhotD7tPNivucPD61tRHu5lLHyK2xDzJaLT6YIuBJEGbb7KPqTcd T5r6rnW0GZtMJWovZQ4V5hRT6cdtLS+lxTv+NPXPguUc1zUJUCiXTPOUTJEI2pHS0mM2 gL74jPETV1zkkg3/VbyOfXsfEDyiCZn6y5t3RBWzaVvhNaFJ6dP/OyGpXaBdlESg4QLQ riJCMgWuV973W4U67fyN4GYlese5CkQoCp4uyvllPEX3N2Dzs6JU9i/1H9Ujh5ucPwZz /K4amw1p9do9L65R7Sefzaurdk8PzOUAQNcx4q3lGxT+lcktQPEhuxJogUEWlTlCddgu Au1A== X-Gm-Message-State: AOAM532lR7TetBo9Af9gS0FiYcnwgl7Wqe/dIvbKbeqcuqSOvnxFJb0+ L0zhfxMr55oPoI0fsdfT2uxu0w== X-Received: by 2002:a5d:4c4f:: with SMTP id n15mr32969818wrt.137.1604518585814; Wed, 04 Nov 2020 11:36:25 -0800 (PST) Received: from dell.default ([91.110.221.242]) by smtp.gmail.com with ESMTPSA id x10sm4034444wrp.62.2020.11.04.11.36.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 04 Nov 2020 11:36:25 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, Greg Kroah-Hartman , Jiri Slaby , Vladimir Zapolskiy , Sylvain Lemieux , Kevin Wells , Roland Stigge , linux-serial@vger.kernel.org Subject: [PATCH 19/36] tty: serial: lpc32xx_hs: Remove unused variable 'tmp' Date: Wed, 4 Nov 2020 19:35:32 +0000 Message-Id: <20201104193549.4026187-20-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20201104193549.4026187-1-lee.jones@linaro.org> References: <20201104193549.4026187-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-serial@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/tty/serial/lpc32xx_hs.c: In function ‘__serial_uart_flush’: drivers/tty/serial/lpc32xx_hs.c:244:6: warning: variable ‘tmp’ set but not used [-Wunused-but-set-variable] Cc: Greg Kroah-Hartman Cc: Jiri Slaby Cc: Vladimir Zapolskiy Cc: Sylvain Lemieux Cc: Kevin Wells Cc: Roland Stigge Cc: linux-serial@vger.kernel.org Signed-off-by: Lee Jones --- drivers/tty/serial/lpc32xx_hs.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) -- 2.25.1 Acked-by: Vladimir Zapolskiy diff --git a/drivers/tty/serial/lpc32xx_hs.c b/drivers/tty/serial/lpc32xx_hs.c index b5898c9320361..1fa098d7aec4b 100644 --- a/drivers/tty/serial/lpc32xx_hs.c +++ b/drivers/tty/serial/lpc32xx_hs.c @@ -241,12 +241,11 @@ static unsigned int __serial_get_clock_div(unsigned long uartclk, static void __serial_uart_flush(struct uart_port *port) { - u32 tmp; int cnt = 0; while ((readl(LPC32XX_HSUART_LEVEL(port->membase)) > 0) && (cnt++ < FIFO_READ_LIMIT)) - tmp = readl(LPC32XX_HSUART_FIFO(port->membase)); + readl(LPC32XX_HSUART_FIFO(port->membase)); } static void __serial_lpc32xx_rx(struct uart_port *port) From patchwork Wed Nov 4 19:35:33 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 320569 Delivered-To: patch@linaro.org Received: by 2002:a92:7b12:0:0:0:0:0 with SMTP id w18csp5698251ilc; Wed, 4 Nov 2020 11:36:30 -0800 (PST) X-Google-Smtp-Source: ABdhPJxNboDAU+UfgpX7IqlurKwm6+uGMv7eqouoRM+2JdpABh797pygGsAOUx1O5C+ZFC3klKOb X-Received: by 2002:a17:906:4cca:: with SMTP id q10mr571111ejt.181.1604518590630; Wed, 04 Nov 2020 11:36:30 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1604518590; cv=none; d=google.com; s=arc-20160816; b=E7EJSHerBCmWwJ3dRW7Fbmkky3/VkN7sQXhE815KvVMcGhQmOrwnzIKo529Q1HdTEi 3mBbTN3irp0E89w+IBK3yl3/jB8bi/ZchmKUTmk2hlSZNLUpQiS8QfcGRb2OyLXBLZy7 odsoLpbDsiZ34czdEXokOQgKiXQVy2AH6egoYs16b6KufbKV704NF3KaRORaLxxGedG3 MN6A9hDBc5Vusg6gtaYwMMYppP0p0cfO1xr2MsGjakMRBmWspY//CkNqa3G4Y5w5uODe qZb8kakczNZiIFp1jxknZsRUwXBzT28E7ogvhnXHo5gqiV23rrE3COKXBIAd1BGC8GEx Ds2Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=G/d/JA64CofWKuwESK8kGZX0uiDeowkGXadKVAnwo0c=; b=cua2jdTZ+SP0ix+z5Mg755hIU09LCUcImhevO1UcrL0Xhgw/4vz6UY1/22KXVmAAzO Cni/byjutYfa3UZ3oQ/FOLKJR6MmgDlMbD6VDj7cfN5YfCzwpoiJ/wpY7KgPaeIzF077 wh6hx1xEyo8zIVwsoSkxYvcbIXstpA6V3/fU05nWr/izBEuQNwq5bqn2FHJi5Nu9GAn4 N8hLnEKJYZRDWcudEvGYaKGRtkpIGhkPfd/cNCYQbM1jQRpRy0GnP/zusJN4am985y2P N4zZu76UhiqAm/sbZl36zAKRFoZjb6NkO9Rv5t7bSmEcVH09+E3WFfpOEP52TC1cM8Ez jeVg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=p7liMTCG; spf=pass (google.com: domain of linux-serial-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-serial-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id q26si2019418ejb.105.2020.11.04.11.36.30; Wed, 04 Nov 2020 11:36:30 -0800 (PST) Received-SPF: pass (google.com: domain of linux-serial-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=p7liMTCG; spf=pass (google.com: domain of linux-serial-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-serial-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731339AbgKDTg3 (ORCPT + 2 others); Wed, 4 Nov 2020 14:36:29 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37576 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731283AbgKDTg3 (ORCPT ); Wed, 4 Nov 2020 14:36:29 -0500 Received: from mail-wm1-x343.google.com (mail-wm1-x343.google.com [IPv6:2a00:1450:4864:20::343]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CB3EFC040201 for ; Wed, 4 Nov 2020 11:36:28 -0800 (PST) Received: by mail-wm1-x343.google.com with SMTP id p19so2556565wmg.0 for ; Wed, 04 Nov 2020 11:36:28 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=G/d/JA64CofWKuwESK8kGZX0uiDeowkGXadKVAnwo0c=; b=p7liMTCG1mLEWq/DKidLWgjNnOJKKwuTWcMv0KT6XCWEQ6mqWorLIKcFwmXjwYSwYR pufeisJvFXX7BesNLGZMehzMFIzDSfamBBW0lash/5ccGK1ZfP3v8EUeIAUIFY5FCIw5 nL8CdyXDQNvyOYaDDkvDTI2OrgXsCygs0nhWVKEl7ge7xZuULfHjJX08RBS1Qg2V9JKo hkTHEIKiOl80XiTYG9GAegV5C+V77Nk14gTIDOQrUMhgakn5xLxe/9KqWxKoFrMPvooX l5nGRgrGJ0hgtiqhFZ4hI+xiClHWte29GGYd4mKSFXJLHsacQftIfINr/mY8KbaTWcCq vBrw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=G/d/JA64CofWKuwESK8kGZX0uiDeowkGXadKVAnwo0c=; b=MBudXj/V2pt0ioSWkosGuDooRvV+dFfqSuWAXRv6VDaLMob7FR4jkKS9azOQDXdoj3 qDZDCRv5a3r5J1itqgXm1m+ICrfR2ULn5Vi3EWvFDJbgqS6TDQb75h+cHo+RRkU4K1rK 0JRJLF0Y75g0EtfiZxsvSm9sM4MfBRf/pxy7xVaoPnDeI5lmkzbyuV23SHVdhqOP5bfk aL49YQTcnHLxuRpT8E8JcHiSXsKBfyqMe3UZoaoa3rUolUIp0THJvjOZHTu3vB/jPtX+ JcQlGqLChUd6Sdcy8ErKYNZWEVbKPHqpTvIdWZdkDcuu/6/CNxJkbr1UGUz5NLd7jxXs QfnA== X-Gm-Message-State: AOAM533UYRMGSUjKEfN60BAWvXb6D8Dlzt9RjMhZPF6Lovbvl4sjFvnR ccRvHjU/y6OJtqFCPOJeHgvB3A== X-Received: by 2002:a1c:e90e:: with SMTP id q14mr5957290wmc.64.1604518587505; Wed, 04 Nov 2020 11:36:27 -0800 (PST) Received: from dell.default ([91.110.221.242]) by smtp.gmail.com with ESMTPSA id x10sm4034444wrp.62.2020.11.04.11.36.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 04 Nov 2020 11:36:26 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, Andy Gross , Bjorn Andersson , Greg Kroah-Hartman , Jiri Slaby , Robert Love , linux-arm-msm@vger.kernel.org, linux-serial@vger.kernel.org Subject: [PATCH 20/36] tty: serial: msm_serial: Remove set but unused variable 'status' Date: Wed, 4 Nov 2020 19:35:33 +0000 Message-Id: <20201104193549.4026187-21-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20201104193549.4026187-1-lee.jones@linaro.org> References: <20201104193549.4026187-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-serial@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/tty/serial/msm_serial.c: In function ‘msm_complete_tx_dma’: drivers/tty/serial/msm_serial.c:429:18: warning: variable ‘status’ set but not used [-Wunused-but-set-variable] Cc: Andy Gross Cc: Bjorn Andersson Cc: Greg Kroah-Hartman Cc: Jiri Slaby Cc: Robert Love Cc: linux-arm-msm@vger.kernel.org Cc: linux-serial@vger.kernel.org Signed-off-by: Lee Jones --- drivers/tty/serial/msm_serial.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) -- 2.25.1 Reviewed-by: Jeffrey Hugo diff --git a/drivers/tty/serial/msm_serial.c b/drivers/tty/serial/msm_serial.c index 87f005e5d2aff..ec31a809644a5 100644 --- a/drivers/tty/serial/msm_serial.c +++ b/drivers/tty/serial/msm_serial.c @@ -426,7 +426,6 @@ static void msm_complete_tx_dma(void *args) struct circ_buf *xmit = &port->state->xmit; struct msm_dma *dma = &msm_port->tx_dma; struct dma_tx_state state; - enum dma_status status; unsigned long flags; unsigned int count; u32 val; @@ -437,7 +436,7 @@ static void msm_complete_tx_dma(void *args) if (!dma->count) goto done; - status = dmaengine_tx_status(dma->chan, dma->cookie, &state); + dmaengine_tx_status(dma->chan, dma->cookie, &state); dma_unmap_single(port->dev, dma->phys, dma->count, dma->dir); From patchwork Wed Nov 4 19:35:34 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 318329 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH, MAILING_LIST_MULTI, SIGNED_OFF_BY, SPF_HELO_NONE, SPF_PASS, URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 31DD5C2D0A3 for ; Wed, 4 Nov 2020 19:36:35 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D044E2065D for ; Wed, 4 Nov 2020 19:36:34 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="VxWQRFEV" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731414AbgKDTgc (ORCPT ); Wed, 4 Nov 2020 14:36:32 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37582 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730983AbgKDTgb (ORCPT ); Wed, 4 Nov 2020 14:36:31 -0500 Received: from mail-wm1-x342.google.com (mail-wm1-x342.google.com [IPv6:2a00:1450:4864:20::342]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 31F36C0613D3 for ; Wed, 4 Nov 2020 11:36:30 -0800 (PST) Received: by mail-wm1-x342.google.com with SMTP id c16so3419302wmd.2 for ; Wed, 04 Nov 2020 11:36:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=+W+IzJVlcwSw8IRMXBzJb1dzB3GDzrAyqgcs95IwTfA=; b=VxWQRFEV0vC/Lf0jlmwNBvW8/0FLvKwzZEu+uH7X7FkNBGaGg76oETtihBzGB6HVq2 XK4SJALNsE0+8RJw6V9q4QjSsOGtnVDGq3e8I8p/X/R5VgutNA7Q50JpK+MLy1su0nFL WNHLL9q3oM3G68w/0/99xDzA24KWCw0JLP3sZb20mex9BpL1V3jUrsoCzosgJPpAH7t9 MAyfOM2MiBBC5vKlcUH05ngWxEKclBvMkAmwYQ15XI360iUMoZeNQTaLWxLFJvKsuOyC 3nE9SEcMceJi5iN9U9n45tzdaucar/krRG6kuL23V8brq8Q3XZqLmK1ix+SV4gvPnj9U llRw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=+W+IzJVlcwSw8IRMXBzJb1dzB3GDzrAyqgcs95IwTfA=; b=esFqyKSpDPg0R4/tNDxfR2HcByVbFZRzkSLzFuQ5a0Ktbzjl5STdP8hT2x43JhsgBu robUDUunaTQjbYBwW4OJMdt6KRpzyqdDjcDQb2K+XsaPFzU90ktsIxb1RzwbUbHpfFnA MsmsDu7UqTj+RxfIyhUFoVAGYghR1vOYooUscV4jzhTriqv2EYyzxGwMiu2qhk2VkcCk p6mAybqJymy91LMOdvFZmCIjto9CJt7SVL482mqCbhNN53dEgSHKHiRGSEJYHnLZMwr5 ZJ+o6EImy2gA2JAFwwd+3eLf8mjrEE6InC1O/hZyfJkrkS1SAABf3HJGydg6XYE5DD+y dDcA== X-Gm-Message-State: AOAM532kE+tUXxrofLT/4SNIw1reC6a2ozImVojRRyT5gVBnfIcxHsa7 sAasR+08Yq0uCQEnyWTINiOABw== X-Google-Smtp-Source: ABdhPJzdsHB0gRKZUlixDWWHCwavM98eiP6QAn36+VXXgHdWKN98UOhPp3e0gizULhrigHzF6tsHyA== X-Received: by 2002:a1c:81d7:: with SMTP id c206mr6119967wmd.140.1604518588914; Wed, 04 Nov 2020 11:36:28 -0800 (PST) Received: from dell.default ([91.110.221.242]) by smtp.gmail.com with ESMTPSA id x10sm4034444wrp.62.2020.11.04.11.36.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 04 Nov 2020 11:36:28 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, Greg Kroah-Hartman , Jiri Slaby , Filip Aben , Joseph Barrow , Jan Dumon , Russ Gorby , linux-serial@vger.kernel.org Subject: [PATCH 21/36] tty: serial: ifx6x60: Fix function documentation headers Date: Wed, 4 Nov 2020 19:35:34 +0000 Message-Id: <20201104193549.4026187-22-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20201104193549.4026187-1-lee.jones@linaro.org> References: <20201104193549.4026187-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-serial@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/tty/serial/ifx6x60.c:553: warning: Function parameter or member 'tty' not described in 'ifx_port_activate' drivers/tty/serial/ifx6x60.c:728: warning: Function parameter or member 't' not described in 'ifx_spi_io' drivers/tty/serial/ifx6x60.c:728: warning: Excess function parameter 'data' description in 'ifx_spi_io' Cc: Greg Kroah-Hartman Cc: Jiri Slaby Cc: Filip Aben Cc: Joseph Barrow Cc: Jan Dumon Cc: Russ Gorby Cc: linux-serial@vger.kernel.org Signed-off-by: Lee Jones --- drivers/tty/serial/ifx6x60.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/tty/serial/ifx6x60.c b/drivers/tty/serial/ifx6x60.c index 21d519c804cb9..182e0ccd60b2c 100644 --- a/drivers/tty/serial/ifx6x60.c +++ b/drivers/tty/serial/ifx6x60.c @@ -545,6 +545,7 @@ static void ifx_spi_hangup(struct tty_struct *tty) /** * ifx_port_activate * @port: our tty port + * @tty: our tty device * * tty port activate method - called for first open. Serialized * with hangup and shutdown by the tty layer. @@ -719,7 +720,7 @@ static void ifx_spi_complete(void *ctx) /** * ifx_spio_io - I/O tasklet - * @data: our SPI device + * @t: tasklet construct used to fetch the SPI device * * Queue data for transmission if possible and then kick off the * transfer. From patchwork Wed Nov 4 19:35:35 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 318328 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH, MAILING_LIST_MULTI, SIGNED_OFF_BY, SPF_HELO_NONE, SPF_PASS, URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B8BDCC4742C for ; Wed, 4 Nov 2020 19:36:45 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 57E1E20679 for ; Wed, 4 Nov 2020 19:36:45 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="G6g1v7xn" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731418AbgKDTge (ORCPT ); Wed, 4 Nov 2020 14:36:34 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37594 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731405AbgKDTgd (ORCPT ); Wed, 4 Nov 2020 14:36:33 -0500 Received: from mail-wr1-x442.google.com (mail-wr1-x442.google.com [IPv6:2a00:1450:4864:20::442]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 34EF6C0613D4 for ; Wed, 4 Nov 2020 11:36:32 -0800 (PST) Received: by mail-wr1-x442.google.com with SMTP id x7so23339439wrl.3 for ; Wed, 04 Nov 2020 11:36:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=l/gv0SsLI7CnshsO1g6Ee0CY3I2zGh9OhwtyHlvyxPI=; b=G6g1v7xnvTEazh/ppcd2E7jvCP9tnex3H3LMRF+WLiV7v1gqyiHTOFHoGlbEghWcLl M5Bn/Z403KWlOt57pmj2w0wXo66zrZj1cqd+ahq8abwgEqi7j+5i/2dfLxw++VpKI/Yn IiszaeGQ1N+99+Qc8wB7QcRfXvhOzY6Pt8rFbTG34hhUT0aa6Y/kKwHXONYUw+B3dNkd phbwSu2SMPbQkI8lwxuZOk9FkQ8KpFStZ9Sm0IrGkPV1I4MzC/2hp6Xp/Fp2sQplHP6l aUAaxtYKtbJN0hwUqQJZ02apn7dO8KuluGGFsK8zWngliqyMv+cl4ogsn0b/joa2Q2wt 1vag== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=l/gv0SsLI7CnshsO1g6Ee0CY3I2zGh9OhwtyHlvyxPI=; b=lVSOev5cj9/zPLWwOmt3gC/GcgcrRiO2A4u/w07dNRHdGmOfQfbT3dMmegvSi2bbx4 /wz/lq5McWJImx4n54Ff8R/Ei1RqLDpQl/fcE31Ktl3YON9kWbd/m46koW1T8chutB1E aTS+W1sykCCywDf/PyL60SIeodqnWWuzqxxte0q2kWXdjlRBqr70/h75q21+vgr4Yspu +U/eBFzt9Rz3acfVzqDHtFU6FamaQPzOe2cybptn9EBg+jC4hO0KRJvYcN91hS7Vo9v0 Q8cW4VhfEBz9Ed00ymKVXW4RmjJ0pqPtwlCUOGkUg1RAHXP+t80TfC63sUVxe2p4Smm6 UEGg== X-Gm-Message-State: AOAM533MMnrurCvBzlN/ag7Uzbt3eYURg7aPqmrEgD7GmSg5tx4jjziq sSQxXL07cOZz0ZZq656+5hb0PA== X-Google-Smtp-Source: ABdhPJzJvYOB3ZWklk3J/n/mJXGJhAX0H9YEbO+QG9lKvohw7OcHOpD65XMl0ZpyDLrHvlIL8OTU3Q== X-Received: by 2002:adf:8284:: with SMTP id 4mr9105007wrc.386.1604518590885; Wed, 04 Nov 2020 11:36:30 -0800 (PST) Received: from dell.default ([91.110.221.242]) by smtp.gmail.com with ESMTPSA id x10sm4034444wrp.62.2020.11.04.11.36.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 04 Nov 2020 11:36:30 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, Greg Kroah-Hartman , Jiri Slaby , Michal Simek , linux-serial@vger.kernel.org Subject: [PATCH 22/36] tty: serial: xilinx_uartps: Supply description for missing member 'cts_override' Date: Wed, 4 Nov 2020 19:35:35 +0000 Message-Id: <20201104193549.4026187-23-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20201104193549.4026187-1-lee.jones@linaro.org> References: <20201104193549.4026187-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-serial@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/tty/serial/xilinx_uartps.c:205: warning: Function parameter or member 'cts_override' not described in 'cdns_uart' Cc: Greg Kroah-Hartman Cc: Jiri Slaby Cc: Michal Simek Cc: linux-serial@vger.kernel.org Signed-off-by: Lee Jones --- drivers/tty/serial/xilinx_uartps.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/tty/serial/xilinx_uartps.c b/drivers/tty/serial/xilinx_uartps.c index a9b1ee27183a7..a14c5d9964739 100644 --- a/drivers/tty/serial/xilinx_uartps.c +++ b/drivers/tty/serial/xilinx_uartps.c @@ -192,6 +192,7 @@ MODULE_PARM_DESC(rx_timeout, "Rx timeout, 1-255"); * @baud: Current baud rate * @clk_rate_change_nb: Notifier block for clock changes * @quirks: Flags for RXBS support. + * @cts_override: Modem control state override */ struct cdns_uart { struct uart_port *port; From patchwork Wed Nov 4 19:35:38 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 318326 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH, MAILING_LIST_MULTI, SIGNED_OFF_BY, SPF_HELO_NONE, SPF_PASS, URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 013CDC4741F for ; Wed, 4 Nov 2020 19:37:35 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 948E020679 for ; Wed, 4 Nov 2020 19:37:34 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="jOvIce5Y" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731485AbgKDThd (ORCPT ); Wed, 4 Nov 2020 14:37:33 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37620 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731495AbgKDTgi (ORCPT ); Wed, 4 Nov 2020 14:36:38 -0500 Received: from mail-wr1-x442.google.com (mail-wr1-x442.google.com [IPv6:2a00:1450:4864:20::442]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3546AC0613D4 for ; Wed, 4 Nov 2020 11:36:38 -0800 (PST) Received: by mail-wr1-x442.google.com with SMTP id n15so23374199wrq.2 for ; Wed, 04 Nov 2020 11:36:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=qxIwRMD6TNBg9udmxGZqLaXn9yYcY9lwNa4w1OOgomY=; b=jOvIce5Y8cX6tbhY9L9KsU+MZChw1k/jcW944Xh2LDWfP2jwxOiW4gq2+Bawg47x9z bNE4CHODRlR5URrZecp9S23e5lzUQfpT3inK47e3MR7A9u2JyHP1M5Nu+flMLBMovr4X 4XuSxNmW2Ig982I82J5WyB5huHaeXoOCGUxU/+C0hOeCouFqYCUOSu7VHvBDKs4Hyycg ydDhqoQ9Bav7qws0Xzs9/iSiy3k+R6NSlYZ2rseiR47s64hWEF0pq5Zjd7FLYVnRCdDR NHSrZIOa5qvgwc3XTM+5JX8tmYoA3cGjK5D4IcJjYCNa5MRZmHCdUnAD/e4dR4spsuN2 e3+Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=qxIwRMD6TNBg9udmxGZqLaXn9yYcY9lwNa4w1OOgomY=; b=n4MkyCj4U4y1p9M+hEmUsZ2jlWtikXV0tMMPkAF2tL065FLPJQVJ6DgIVt4uiymD0K 9c1Bg0mxVOVRPChW5AoeHkuTcYwjYiiyRwSKCc7HHkTq60jFn0Mvzhv5CetDLueGGX8R dGveSgSpE+7l9p/AztxrxZj4kFeYlf3DhZFZgtNZcJKI/oGdTLu3Iej2PdfLsYDIW4J2 palztE5uaf/7/Xk6U4XWx9uaRjCqGLXHpVS0JDiKl8SszEw/L0jOmdXRuoHlwRUQv0KQ mALhWup5w+dSVRyrmrJaRhuOHzuA7tr+873UtSIHWcXyp7LbSTMlbi+eYgg5opFEZnub z8vA== X-Gm-Message-State: AOAM530kABzZzjj1vZSoHD8nLM4XCht4NDKT5Fbtc55Q1mzWMAq7sDd1 v5OFZQH/UgFhTdrTo3oFlf5LBQ== X-Google-Smtp-Source: ABdhPJxku7Y3Kg5JTrtXlnam3qROwaJDh/c2CuIvjzLZI/zWTYPrraJ+G80GnqYixVTfkfiagatmeA== X-Received: by 2002:a5d:490c:: with SMTP id x12mr33601906wrq.193.1604518596915; Wed, 04 Nov 2020 11:36:36 -0800 (PST) Received: from dell.default ([91.110.221.242]) by smtp.gmail.com with ESMTPSA id x10sm4034444wrp.62.2020.11.04.11.36.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 04 Nov 2020 11:36:36 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, Greg Kroah-Hartman , Jiri Slaby , Palmer Dabbelt , Paul Walmsley , linux-serial@vger.kernel.org, linux-riscv@lists.infradead.org Subject: [PATCH 25/36] tty: serial: sifive: Struct headers should start with 'struct ' Date: Wed, 4 Nov 2020 19:35:38 +0000 Message-Id: <20201104193549.4026187-26-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20201104193549.4026187-1-lee.jones@linaro.org> References: <20201104193549.4026187-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-serial@vger.kernel.org Also supply a missing member description. Fixes the following W=1 kernel build warning(s): drivers/tty/serial/sifive.c:157: warning: cannot understand function prototype: 'struct sifive_serial_port ' Cc: Greg Kroah-Hartman Cc: Jiri Slaby Cc: Palmer Dabbelt Cc: Paul Walmsley Cc: linux-serial@vger.kernel.org Cc: linux-riscv@lists.infradead.org Signed-off-by: Lee Jones Reviewed-by: Palmer Dabbelt Acked-by: Palmer Dabbelt --- drivers/tty/serial/sifive.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/tty/serial/sifive.c b/drivers/tty/serial/sifive.c index 13eadcb8aec4e..1066eebe3b28b 100644 --- a/drivers/tty/serial/sifive.c +++ b/drivers/tty/serial/sifive.c @@ -144,12 +144,13 @@ */ /** - * sifive_serial_port - driver-specific data extension to struct uart_port + * struct sifive_serial_port - driver-specific data extension to struct uart_port * @port: struct uart_port embedded in this struct * @dev: struct device * * @ier: shadowed copy of the interrupt enable register * @clkin_rate: input clock to the UART IP block. * @baud_rate: UART serial line rate (e.g., 115200 baud) + * @clk: reference to this device's clock * @clk_notifier: clock rate change notifier for upstream clock changes * * Configuration data specific to this SiFive UART. From patchwork Wed Nov 4 19:35:41 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 320575 Delivered-To: patch@linaro.org Received: by 2002:a92:7b12:0:0:0:0:0 with SMTP id w18csp5698869ilc; Wed, 4 Nov 2020 11:37:32 -0800 (PST) X-Google-Smtp-Source: ABdhPJxzhALhyO8lOwAXkUS2QN/z2PJIG9aFi5gtkyWD5/aX7icGr29donDvhJZKdTMvpYcxEt3L X-Received: by 2002:a05:6402:16d5:: with SMTP id r21mr18811458edx.358.1604518652759; Wed, 04 Nov 2020 11:37:32 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1604518652; cv=none; d=google.com; s=arc-20160816; b=xQw2FZTi6HC1AOnwWyXLC6GLbyO1979WSnCSisI2otK2JBio3sJ9FwaMySbEpa5qbc 1E/kKX1XSazU/8QkX96nR+CFHLvm2xHgZkFGPXCj4pouFYO4XX9VeBPVA/oW8uxZSUTJ KVDUAYq57KqFLqDz6hhiDJsKrjRpqJzN1Xd/8KX9+gdFzAdhfjqcIulENFIvKjy7RvIB b/X25O2KtaeP0krfpJQU/OnrsRKCaHTt5Pdo73IlNrRTu2kFbTlFK3DyepjADiKBQLNH SRa+XcKpLPaYtj1vhsbMk2fJjqNQwmbtqbaBxygjp89+5wEoIOtpzALX2Yr475h61NMc dpvw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=6fgb1IEzfMnPc6nqs8QP0jEqoyFf5EkN3W0LREp5eok=; b=S1JpghaDq/WTq3XzqC6SEtuWJFW8/Ti7p50x4yyulox49xCFkf9J6GNd6QdskZSlUy E68sqSCKbWQfaoYGH64T4DS+y/ZEYVU+6cRzQMoewOQTLBFss0u7PxYr2CwyTrCk/7ED BLnX13RKmoTtMgofKBH+eqQFsa0Co3eehJ0JjIj5wUZapnfWOltzscAoWKQioMPd1erS tYq5C3Eglx62XIsBNgpqX8IDb6mFcCXPLWxWkKkbtXwuz4i3PbmiKadJuByLGjloZhU/ 9fvi5OyBzwMJRKJv0AboTD+2nnuArgrDXY8H0im8Bx18VUNeDLxmJVd2FyzL0DS94woN Si3w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=dUki5RoA; spf=pass (google.com: domain of linux-serial-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-serial-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id g17si2410125ejr.134.2020.11.04.11.37.32; Wed, 04 Nov 2020 11:37:32 -0800 (PST) Received-SPF: pass (google.com: domain of linux-serial-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=dUki5RoA; spf=pass (google.com: domain of linux-serial-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-serial-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731481AbgKDThX (ORCPT + 2 others); Wed, 4 Nov 2020 14:37:23 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37640 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731540AbgKDTgm (ORCPT ); Wed, 4 Nov 2020 14:36:42 -0500 Received: from mail-wm1-x341.google.com (mail-wm1-x341.google.com [IPv6:2a00:1450:4864:20::341]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1A41FC040203 for ; Wed, 4 Nov 2020 11:36:42 -0800 (PST) Received: by mail-wm1-x341.google.com with SMTP id k18so3415721wmj.5 for ; Wed, 04 Nov 2020 11:36:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=6fgb1IEzfMnPc6nqs8QP0jEqoyFf5EkN3W0LREp5eok=; b=dUki5RoAgEUXeV68RfVBsjZNTcSI5/Puy7ll183zFMy88MFmsFDu++Lc+6nX6nS1AC f6R+u9/0cYkz9bE0iRfGya8+/e0t/t2FEmXyplh3cPVhWClmNbJpgnBPsGpWvSuWsKlb 9Yjo3MWCHUzlFjclnW2Ag4ZTN/eP2MEPGJsQzi/Rmk6b89US8uJYtsMHbpNTdNur/rAP +xugpeZt1Bzs2DaMfrknk/bKiy6as07x7eJzKM9o7RHXNN6rROFE0jYf/ylkFx6iPDa4 v2Sk+Vi/vHzMQHT2B8Xe+lbVvu8fbvl5bBn2n8yakmZw6QAO8IY8177O8vpbx9rtvWtk SEng== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=6fgb1IEzfMnPc6nqs8QP0jEqoyFf5EkN3W0LREp5eok=; b=ebTubSIM7aI5UfVBjwmj/6KRSN2uCZm5N3vuy5+4E/8Ayik+zE06jkNZ5jcjxiLIlr U8mvpv+WrHaX48XA2k3Ud6UNwAV/fhoe7PazP2Va8daVjDj8WWI7jhGChltYHPj7uUZB K7wNJqhbrx9pXREYvs0uRZBqqiLRIypx8WioBETuk4KH9tCpYZbL//Bn6qD3hr7kR6kB 7rttg308fBm/Yk30QAfaBv8HL48h7waxXTinGcb6vIUvvnQXVKX6X/Az5yZomyV6pbLm Pb4Ga35QaYcK0sYd/D8k+kNcGmV7kWn9QnJOC4VIx1lmO4C5OBh9gvnD2o8z4s0u6ZW8 BiBw== X-Gm-Message-State: AOAM530lPeoMthJ0hJlgA4w7f3WQgjULZWfBaihsTTVzLheH19t3JCs6 UwHlvz4yUuVZXSXcRRyWSukzpK5w9TfxzVuf X-Received: by 2002:a1c:1d51:: with SMTP id d78mr6192642wmd.60.1604518600809; Wed, 04 Nov 2020 11:36:40 -0800 (PST) Received: from dell.default ([91.110.221.242]) by smtp.gmail.com with ESMTPSA id x10sm4034444wrp.62.2020.11.04.11.36.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 04 Nov 2020 11:36:40 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, Greg Kroah-Hartman , Jiri Slaby , Maxime Coquelin , Alexandre Torgue , Gerald Baeza , linux-serial@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com Subject: [PATCH 28/36] tty: serial: stm32-usart: Remove set but unused 'cookie' variables Date: Wed, 4 Nov 2020 19:35:41 +0000 Message-Id: <20201104193549.4026187-29-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20201104193549.4026187-1-lee.jones@linaro.org> References: <20201104193549.4026187-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-serial@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/tty/serial/stm32-usart.c: In function ‘stm32_transmit_chars_dma’: drivers/tty/serial/stm32-usart.c:353:15: warning: variable ‘cookie’ set but not used [-Wunused-but-set-variable] drivers/tty/serial/stm32-usart.c: In function ‘stm32_of_dma_rx_probe’: drivers/tty/serial/stm32-usart.c:1090:15: warning: variable ‘cookie’ set but not used [-Wunused-but-set-variable] Cc: Greg Kroah-Hartman Cc: Jiri Slaby Cc: Maxime Coquelin Cc: Alexandre Torgue Cc: Gerald Baeza Cc: linux-serial@vger.kernel.org Cc: linux-stm32@st-md-mailman.stormreply.com Signed-off-by: Lee Jones --- drivers/tty/serial/stm32-usart.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) -- 2.25.1 diff --git a/drivers/tty/serial/stm32-usart.c b/drivers/tty/serial/stm32-usart.c index ee6c7762d3559..f4de32d3f2afe 100644 --- a/drivers/tty/serial/stm32-usart.c +++ b/drivers/tty/serial/stm32-usart.c @@ -350,7 +350,6 @@ static void stm32_transmit_chars_dma(struct uart_port *port) struct stm32_usart_offsets *ofs = &stm32port->info->ofs; struct circ_buf *xmit = &port->state->xmit; struct dma_async_tx_descriptor *desc = NULL; - dma_cookie_t cookie; unsigned int count, i; if (stm32port->tx_dma_busy) @@ -394,7 +393,7 @@ static void stm32_transmit_chars_dma(struct uart_port *port) desc->callback_param = port; /* Push current DMA TX transaction in the pending queue */ - cookie = dmaengine_submit(desc); + dmaengine_submit(desc); /* Issue pending DMA TX requests */ dma_async_issue_pending(stm32port->tx_ch); @@ -1087,7 +1086,6 @@ static int stm32_of_dma_rx_probe(struct stm32_port *stm32port, struct device *dev = &pdev->dev; struct dma_slave_config config; struct dma_async_tx_descriptor *desc = NULL; - dma_cookie_t cookie; int ret; /* Request DMA RX channel */ @@ -1132,7 +1130,7 @@ static int stm32_of_dma_rx_probe(struct stm32_port *stm32port, desc->callback_param = NULL; /* Push current DMA transaction in the pending queue */ - cookie = dmaengine_submit(desc); + dmaengine_submit(desc); /* Issue pending DMA requests */ dma_async_issue_pending(stm32port->rx_ch); From patchwork Wed Nov 4 19:35:43 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 318327 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH, MAILING_LIST_MULTI, SIGNED_OFF_BY, SPF_HELO_NONE, SPF_PASS, URIBL_BLOCKED, USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3567EC4741F for ; Wed, 4 Nov 2020 19:37:24 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C668E20657 for ; Wed, 4 Nov 2020 19:37:23 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="CDTWv8+b" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726737AbgKDThX (ORCPT ); Wed, 4 Nov 2020 14:37:23 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37628 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731565AbgKDTgq (ORCPT ); Wed, 4 Nov 2020 14:36:46 -0500 Received: from mail-wm1-x344.google.com (mail-wm1-x344.google.com [IPv6:2a00:1450:4864:20::344]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8541AC0401C2 for ; Wed, 4 Nov 2020 11:36:44 -0800 (PST) Received: by mail-wm1-x344.google.com with SMTP id s13so264619wmh.4 for ; Wed, 04 Nov 2020 11:36:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=QJlyn82FOfM7EXjR0q74MRu42lgfKXYpFARoLgEcKcw=; b=CDTWv8+b7Pc7euhcDEsYBH2s0hgrrGZ9dFeeb26B0gMt0vQRbHOkNYq12S81R2kSIb BkAZElbMwbidJp0VR2ZQrpMuxtaij6l4SS3iiFsKW8QQicUO0kgIo+9bHizDrHJSN/7i 8aOmvSrphp4pnAsk4raJf8eABmQqhcqbtF86lo5/LYL3HQ5u/y5vVtfwc19HNURBk39W TmrGK+eFMC0IBsAxiOCp5WoexunKFDgC+MdbkeMV3/YLnbC7GDLyFT1NlqdhgeAJKI2T ZxTy7SwCJ2VQzBXSlfn77lrnQBilU8LpnRRDY2CaseHey2g0t+xd3ZnRCPrqr5TSTd3/ jHPA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=QJlyn82FOfM7EXjR0q74MRu42lgfKXYpFARoLgEcKcw=; b=RXL13LF/XI91DKqBnTmcH98Ks6H27IldoKEBDD7p9nlKfC/h9VLaC0u0jlgejtD19r g2d8mKzfzV022F7LuTasWflTRnlxL4CGRFtdQMCZ4yWBg+46puKaJusLL2ZhZICDz7Mb SLAdWUqo97P+dItEAEfwoAenZOISSmDicI4arwb0P0VPiBn/BZVKETw0/AhPG3nvwuxR dT3lL/UKcMdQouIaZsLlkwLVNngNdUgVwZUSEsRONjS4lu/PlqxnZaW/ICOOWT1Dkc8K /uXDEnW6muthwQgbuLmnw4lhOGpw6vltsJBw+wfA7sR2Rvp4/7P/9qHmSMvxtjENZPBk T0oQ== X-Gm-Message-State: AOAM531Kr7quCn4GxF+804VTzpc9DCXsh8dp+x/nupcNdSaF7YkVL5XT Lji/Q2Qhp3RIxlXl7r+/wTAu9Q== X-Google-Smtp-Source: ABdhPJwCKoSo/a5+S17lYgSHyM7aF0XsUIOUlkwoI96HWyiOrIZnl0nWmrJK04DiKb1xktIaygjjXQ== X-Received: by 2002:a1c:4c0a:: with SMTP id z10mr5105765wmf.96.1604518603201; Wed, 04 Nov 2020 11:36:43 -0800 (PST) Received: from dell.default ([91.110.221.242]) by smtp.gmail.com with ESMTPSA id x10sm4034444wrp.62.2020.11.04.11.36.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 04 Nov 2020 11:36:42 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, Laxman Dewangan , Greg Kroah-Hartman , Jiri Slaby , Thierry Reding , Jonathan Hunter , Philipp Zabel , Sumit Semwal , =?utf-8?q?Christian_K=C3=B6nig?= , linux-serial@vger.kernel.org, linux-tegra@vger.kernel.org, linux-media@vger.kernel.org, dri-devel@lists.freedesktop.org, linaro-mm-sig@lists.linaro.org Subject: [PATCH 30/36] tty: serial: serial-tegra: Provide some missing struct member descriptions Date: Wed, 4 Nov 2020 19:35:43 +0000 Message-Id: <20201104193549.4026187-31-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20201104193549.4026187-1-lee.jones@linaro.org> References: <20201104193549.4026187-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-serial@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/tty/serial/serial-tegra.c:94: warning: Function parameter or member 'fifo_mode_enable_status' not described in 'tegra_uart_chip_data' drivers/tty/serial/serial-tegra.c:94: warning: Function parameter or member 'uart_max_port' not described in 'tegra_uart_chip_data' drivers/tty/serial/serial-tegra.c:94: warning: Function parameter or member 'max_dma_burst_bytes' not described in 'tegra_uart_chip_data' drivers/tty/serial/serial-tegra.c:94: warning: Function parameter or member 'error_tolerance_low_range' not described in 'tegra_uart_chip_data' drivers/tty/serial/serial-tegra.c:94: warning: Function parameter or member 'error_tolerance_high_range' not described in 'tegra_uart_chip_data' Cc: Laxman Dewangan Cc: Greg Kroah-Hartman Cc: Jiri Slaby Cc: Thierry Reding Cc: Jonathan Hunter Cc: Philipp Zabel Cc: Sumit Semwal Cc: "Christian König" Cc: linux-serial@vger.kernel.org Cc: linux-tegra@vger.kernel.org Cc: linux-media@vger.kernel.org Cc: dri-devel@lists.freedesktop.org Cc: linaro-mm-sig@lists.linaro.org Signed-off-by: Lee Jones --- drivers/tty/serial/serial-tegra.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/drivers/tty/serial/serial-tegra.c b/drivers/tty/serial/serial-tegra.c index c363ee0470f45..bbae072a125db 100644 --- a/drivers/tty/serial/serial-tegra.c +++ b/drivers/tty/serial/serial-tegra.c @@ -81,6 +81,11 @@ * @allow_txfifo_reset_fifo_mode: allow_tx fifo reset with fifo mode or not. * Tegra30 does not allow this. * @support_clk_src_div: Clock source support the clock divider. + * @fifo_mode_enable_status: Is FIFO mode enabled? + * @uart_max_port: Maximum number of UART ports + * @max_dma_burst_bytes: Maximum size of DMA bursts + * @error_tolerance_low_range: Lowest number in the error tolerance range + * @error_tolerance_high_range: Highest number in the error tolerance range */ struct tegra_uart_chip_data { bool tx_fifo_full_status; From patchwork Wed Nov 4 19:35:47 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 320574 Delivered-To: patch@linaro.org Received: by 2002:a92:7b12:0:0:0:0:0 with SMTP id w18csp5698653ilc; Wed, 4 Nov 2020 11:37:09 -0800 (PST) X-Google-Smtp-Source: ABdhPJz5LcmUZiLbTv9e8XHiInzDcmBYmAxWq+nRqsLxvgdrjcxfc1mCsK0GO2nQJUSUHVrvjJuO X-Received: by 2002:a05:6402:1f1:: with SMTP id i17mr13654528edy.60.1604518629547; Wed, 04 Nov 2020 11:37:09 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1604518629; cv=none; d=google.com; s=arc-20160816; b=N31krtnpoADk1zev7YhOl3IFhOIvIulD8xbT8wOUyMPq1uSvVJUe1ATYlCBn40xbC7 wfTjpDhhtrMqW3VxCHqojf1b2VSrR8X0iwhVO4ibYzey3sYUvyT899w64m7kizzIYQCF dtWSTY7yS2/vcpG6SpBMODH+HGgqU5GaSd4pcgA0ykUgPFbHGpXK8wwocxnBSQg8vlV3 gjzq6wM8uXmQKsjsqLfR7dCSn29T90N0N4B1UxZ5mJ4MxNEeJkB1sWEMBQqoFap/lUOs Rpm1PBcaz6G+xmYHIJYTAzjUKakwPoj+7QE2yiNW0JFPDLuug3bdgd+yUuYe3skihrU+ DdBQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=ErfYpYEPgr7SyR0IGrTLDHOPTVsMeF+NG57/GEyOHB0=; b=yr+inHc5pLkpfWsEynreoSjg2T/esfFRmMrj2hynDLWyG+3JK44vo8/NwyhRVsMC91 LPzTz7OMwgDT6+RyECCQyKR9yx06kYNmJHRyA3lky1zt68MxkKLmo+qu6vt8APqWIQDm NmXHDu+qAM7J5Do9NeipNTB09X8Wy3c+9zhIfR5RZiz54X9k5LjQ0AnYgLqcPfqus7ur FK6MH0ieko+x8ltKKt6sddNfg8Pj9bX0VOeqcCu1+goxtGIzLAd7I6kZAOg52KYPNhsR 532j3mEKYrFa7SmXT/cL9ABd9snZdMt3H8CRL76sDSJ/t3UkF3fzKNWdkr7SxNP1bYUC WuVQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=pX29kLlm; spf=pass (google.com: domain of linux-serial-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-serial-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id v7si2717792edj.516.2020.11.04.11.37.09; Wed, 04 Nov 2020 11:37:09 -0800 (PST) Received-SPF: pass (google.com: domain of linux-serial-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=pX29kLlm; spf=pass (google.com: domain of linux-serial-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-serial-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731555AbgKDThI (ORCPT + 2 others); Wed, 4 Nov 2020 14:37:08 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37666 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731673AbgKDTgu (ORCPT ); Wed, 4 Nov 2020 14:36:50 -0500 Received: from mail-wm1-x343.google.com (mail-wm1-x343.google.com [IPv6:2a00:1450:4864:20::343]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A5C6CC0613D4 for ; Wed, 4 Nov 2020 11:36:49 -0800 (PST) Received: by mail-wm1-x343.google.com with SMTP id h22so3447288wmb.0 for ; Wed, 04 Nov 2020 11:36:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=ErfYpYEPgr7SyR0IGrTLDHOPTVsMeF+NG57/GEyOHB0=; b=pX29kLlmBcSPTSQCXTO8Lo9d4QG+nqnnImw6YFxmstscNqOOswbExguUzzT4L2axlU D3GWk5jA11ZzA+AZVtegLCVhl2Ob2ZmAEEHVzMHCsciCYwyQTL8h89K8WzLvAsv7TRcu 7yI+7qd87nij+dGvWnf+2yyWANiI/xOXRymlotH13o1iY4W7M550ffyUTs+i/hqzxRcZ TKhz+VRg0g9MO6Q9omYUAHnyYyG0b/tNB7yPcru/BSqEkR7LGsnBTwhTnSMhBAoFeI05 ZFKQqxZhOGvRVRNlQ6UmnNU504R2+m9kxBQlMwaHA65WTwkPAt9WKivfMsX/iLNdWsoh CY8A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=ErfYpYEPgr7SyR0IGrTLDHOPTVsMeF+NG57/GEyOHB0=; b=kFmcCrdxutkRRVjGnUpDh97O2uGOWTVm4sSSJImwH78m1+JbHIHfDIEcehBu79ysW1 zbpUpF8QRT6yx/EgOhghZQyYzXeQHeW5AMcs2z1SXsx5ulnH4L6yXaL/BKSclbjso4/E pPomtT+f40491tQgtguyBAGXMIzC0gNgIrzJyjdqhZ9aefNsbUwu1JzcIzlUWALpsqKW 6HNguvd7FZhJAsv5FEN0P3WMw+oBDllLNDKJkVYZVyaaQ0wa4O7vP6LqJJ/HQHk5zjLL YqJKKumNiXfJbwL7g8NecP1iv73YwCymnpLBXdqk6fyu1MnpU5zbq5U+WIO3sFIeiqNY DeOQ== X-Gm-Message-State: AOAM533yqCH7ft2syV5LWgohF/lqegn/pe2ivnRNwhHTJ01Lz7JTzbSq cG4qLR8Lk6SvQSzOdH7/sciUqFix2ZezoZ8/ X-Received: by 2002:a1c:a90e:: with SMTP id s14mr6477604wme.46.1604518608351; Wed, 04 Nov 2020 11:36:48 -0800 (PST) Received: from dell.default ([91.110.221.242]) by smtp.gmail.com with ESMTPSA id x10sm4034444wrp.62.2020.11.04.11.36.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 04 Nov 2020 11:36:47 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, Greg Kroah-Hartman , Jiri Slaby , Michael Ellerman , Benjamin Herrenschmidt , Paul Mackerras , linux-serial@vger.kernel.org, linuxppc-dev@lists.ozlabs.org Subject: [PATCH 34/36] tty: serial: pmac_zilog: Make disposable variable __always_unused Date: Wed, 4 Nov 2020 19:35:47 +0000 Message-Id: <20201104193549.4026187-35-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20201104193549.4026187-1-lee.jones@linaro.org> References: <20201104193549.4026187-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-serial@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/tty/serial/pmac_zilog.h:365:58: warning: variable ‘garbage’ set but not used [-Wunused-but-set-variable] Cc: Greg Kroah-Hartman Cc: Jiri Slaby Cc: Michael Ellerman Cc: Benjamin Herrenschmidt Cc: Paul Mackerras Cc: linux-serial@vger.kernel.org Cc: linuxppc-dev@lists.ozlabs.org Signed-off-by: Lee Jones --- drivers/tty/serial/pmac_zilog.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.25.1 diff --git a/drivers/tty/serial/pmac_zilog.h b/drivers/tty/serial/pmac_zilog.h index bb874e76810e0..968aec7c1cf82 100644 --- a/drivers/tty/serial/pmac_zilog.h +++ b/drivers/tty/serial/pmac_zilog.h @@ -362,7 +362,7 @@ static inline void zssync(struct uart_pmac_port *port) /* Misc macros */ #define ZS_CLEARERR(port) (write_zsreg(port, 0, ERR_RES)) -#define ZS_CLEARFIFO(port) do { volatile unsigned char garbage; \ +#define ZS_CLEARFIFO(port) do { volatile unsigned char __always_unused garbage; \ garbage = read_zsdata(port); \ garbage = read_zsdata(port); \ garbage = read_zsdata(port); \