From patchwork Fri Oct 30 07:24:44 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Chunyan Zhang X-Patchwork-Id: 315484 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.6 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH, MAILING_LIST_MULTI, SIGNED_OFF_BY, SPF_HELO_NONE, SPF_PASS, URIBL_BLOCKED, USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 25B98C00A89 for ; Fri, 30 Oct 2020 07:25:13 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9D81B221E2 for ; Fri, 30 Oct 2020 07:25:12 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="mGOR8hd7" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725790AbgJ3HZM (ORCPT ); Fri, 30 Oct 2020 03:25:12 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53284 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725780AbgJ3HZL (ORCPT ); Fri, 30 Oct 2020 03:25:11 -0400 Received: from mail-pl1-x644.google.com (mail-pl1-x644.google.com [IPv6:2607:f8b0:4864:20::644]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6ED71C0613D3; Fri, 30 Oct 2020 00:25:10 -0700 (PDT) Received: by mail-pl1-x644.google.com with SMTP id t6so2527598plq.11; Fri, 30 Oct 2020 00:25:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=hw/KvprqF2aWL/drMKTS7o6ufRsuBx5x5vRDgirN2WY=; b=mGOR8hd7i0ta5xeu/n+B2eq8da3ixbJY2wWNH+Sk0jHMDG5oUDnhDEhRuRw/rTFBN7 LVPNhafi/GRSJJwI9lLrcEn2nYWJcXm2IbgsBayFQNobmyQ6rtQTVu0S3hEjkZB5P21W OhC6CkCW3Qbmor01eJpgXmRdyLlcudxhoqnbzQtmat4KMmL/3QOXW5Dm7cfWJaYPt1tl udqazUPqrtAfkKSR7ThsiU7qfRp9tERKA29pp/p64BFFGsU+wQzi5H2Fe62R4ZxnhSxd l2pjrxRtTcpCeQxAumJ6ZBDS6GwfII6gs/p5oGW/wI672SzKmhQhc/Ep+Qo/C832Eekd rSow== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=hw/KvprqF2aWL/drMKTS7o6ufRsuBx5x5vRDgirN2WY=; b=g4siQ0W5wGF2q1uzUZk0CqYQXr0USYpA6Zr8EbHcaFYg+wTSyLUU12EFv45sGV44lA AJOI0goXfdW6ch8uTQf5/WovIIbSDXaUdnNVykWZp12UWn0WWTiGFF1dGC58HagB4hby ejy1ak4lfErmFCfX9daEMmrslVacEWpjzXRBiKoXsFwZEoiDnxJCRcIdc73QW+zZgEW2 Fp326GHGwfoRhBkBJCpfW4N+pqK4ajlhLixgZ/9CB8itY021ABurMc67/URHJ1jB4+5V X0OSo52NtYv+0ATqSofFh6FQA4lVRZTrrpvempVo1jtZ5pepN6sJXrokqNR/XHJEI5xM 3zPQ== X-Gm-Message-State: AOAM532Toc+LMhqtrrP7gGQfEPYkUsRKcUuYZHVqhNtEflxKmseNKXiX JGgojHtCKvvb38KwU9i9VCE= X-Google-Smtp-Source: ABdhPJwwSDxlAVPNV6R9bvmn4/zwrH64JjCCMrXyWhUNz/DKEn4/f4wt2kdJC6/9SHjhTLGsSKH/5A== X-Received: by 2002:a17:902:bd03:b029:d6:89e2:5b5e with SMTP id p3-20020a170902bd03b02900d689e25b5emr6831929pls.70.1604042710013; Fri, 30 Oct 2020 00:25:10 -0700 (PDT) Received: from ubt.spreadtrum.com ([117.18.48.82]) by smtp.gmail.com with ESMTPSA id h2sm2126510pjv.15.2020.10.30.00.24.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 30 Oct 2020 00:25:09 -0700 (PDT) From: Chunyan Zhang To: Mark Brown Cc: linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org, Orson Zhai , Baolin Wang , Chunyan Zhang , Chunyan Zhang , Bangzheng Liu Subject: [PATCH] spi: sprd: add runtime pm for transfer message Date: Fri, 30 Oct 2020 15:24:44 +0800 Message-Id: <20201030072444.22122-1-zhang.lyra@gmail.com> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-spi@vger.kernel.org From: Bangzheng Liu Before transfer one message, spi core would set chipselect, sprd spi device should be resumed from runtime suspend, otherwise kernel would crash once access spi registers. The sprd spi device can be suspended until clearing chipselect which would be executed after transfer. Fixes: e7d973a31c24 ("spi: sprd: Add SPI driver for Spreadtrum SC9860") Signed-off-by: Bangzheng Liu Signed-off-by: Chunyan Zhang --- drivers/spi/spi-sprd.c | 16 +++++++++++++--- 1 file changed, 13 insertions(+), 3 deletions(-) diff --git a/drivers/spi/spi-sprd.c b/drivers/spi/spi-sprd.c index 635738f54c73..1733d10eb296 100644 --- a/drivers/spi/spi-sprd.c +++ b/drivers/spi/spi-sprd.c @@ -293,15 +293,25 @@ static void sprd_spi_chipselect(struct spi_device *sdev, bool cs) struct spi_controller *sctlr = sdev->controller; struct sprd_spi *ss = spi_controller_get_devdata(sctlr); u32 val; + int ret; - val = readl_relaxed(ss->base + SPRD_SPI_CTL0); /* The SPI controller will pull down CS pin if cs is 0 */ if (!cs) { - val &= ~SPRD_SPI_CS0_VALID; + ret = pm_runtime_get_sync(ss->dev); + if (ret < 0) { + pm_runtime_put_noidle(ss->dev); + dev_err(ss->dev, "Failed to power device: %d\n", ret); + return; + } + val = readl_relaxed(ss->base + SPRD_SPI_CTL0); + val &= ~SPRD_SPI_CS0_VALID; /* set cs0 valid */ writel_relaxed(val, ss->base + SPRD_SPI_CTL0); } else { - val |= SPRD_SPI_CSN_MASK; + val = readl_relaxed(ss->base + SPRD_SPI_CTL0); + val |= SPRD_SPI_CSN_MASK; /* set all cs invalid */ writel_relaxed(val, ss->base + SPRD_SPI_CTL0); + pm_runtime_mark_last_busy(ss->dev); + pm_runtime_put_autosuspend(ss->dev); } }