From patchwork Wed Dec 27 08:05:22 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ard Biesheuvel X-Patchwork-Id: 122758 Delivered-To: patch@linaro.org Received: by 10.140.22.227 with SMTP id 90csp1883759qgn; Wed, 27 Dec 2017 00:05:33 -0800 (PST) X-Google-Smtp-Source: ACJfBosQksXNM+WlPBA/bUJQRpIdlFu/tR4r4XlZPnETsKiR81Ft01FF+Kwd0QGg2zDjY3EunOL8 X-Received: by 10.84.128.197 with SMTP id a63mr27598114pla.210.1514361933819; Wed, 27 Dec 2017 00:05:33 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1514361933; cv=none; d=google.com; s=arc-20160816; b=KxPqLUvGjcV7XxUuofUMAbmXBxCA9/h7FKPTgrkyXGUytQ7RixcvfShpRf1YCxDVaw Z41OkcvD9+Es1c6dz2JoyNGBQqhrHMaaFX02PK83SDchOi6jD3BaWwMr45IamFy0dYgi MEDDBinUIzdpL2CctTMvfK94iEAjcKnpoymwhq7dboQs581zqsxfFeQf+YwGvulDKeVw YK1kL9TZ5sw7jUUSiqvI7/buGOYJVTFEpIkIGocNAovujtBwcKl8As2vKyh3BVrftA1I pbON+U7QYjTK93PbPSc2y2XYYSE2wpLPV14C5eTg7FqDpRRgro/m15o+2T9Da6vxFIqq cqBg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:mime-version:cc :list-subscribe:list-help:list-post:list-archive:list-unsubscribe :list-id:precedence:subject:message-id:date:to:from:dkim-signature :delivered-to:arc-authentication-results; bh=Bu8FcGNfL7Z2ev4gp3O/m4VrwBPK0IDIYojJZgx/dvo=; b=vTjpPutCbY/2mVUQnQMEAK58PfzklKFw70xjRmKldbxLTnGBhMDkrIVn2BGshXp33p Yy0OkMMec8g0fu5w3Vv2PTFJwssXs0Ss3YxN3pwoWLZToZCsZqNN+QKD/o7G4Ly+a4PC 1F6T5JeCbmJ1ECPrSA5cAmjzoZ/0eY8iQQdB42nUmYJNOUHTduESRseqaYVGA817y+wy yUtuakb+Ql8NDgFE83P18pKdiJMmXskTUZ3Vpp5YGMB4C9MvK26mN/RCnrIhSFh99ZDQ 5mJH02ThzZ1BfGsBpoLxSTdSWhhXGJxSifD8NZhNoXOQhzakUXVqfnUbFm2ac92K8v+G f7kg== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=JtDcSd/T; spf=pass (google.com: best guess record for domain of edk2-devel-bounces@lists.01.org designates 2001:19d0:306:5::1 as permitted sender) smtp.mailfrom=edk2-devel-bounces@lists.01.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from ml01.01.org (ml01.01.org. [2001:19d0:306:5::1]) by mx.google.com with ESMTPS id e3si24455392pfg.23.2017.12.27.00.05.33 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 27 Dec 2017 00:05:33 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of edk2-devel-bounces@lists.01.org designates 2001:19d0:306:5::1 as permitted sender) client-ip=2001:19d0:306:5::1; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=JtDcSd/T; spf=pass (google.com: best guess record for domain of edk2-devel-bounces@lists.01.org designates 2001:19d0:306:5::1 as permitted sender) smtp.mailfrom=edk2-devel-bounces@lists.01.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from [127.0.0.1] (localhost [IPv6:::1]) by ml01.01.org (Postfix) with ESMTP id 4030C22280C37; Wed, 27 Dec 2017 00:00:37 -0800 (PST) X-Original-To: edk2-devel@lists.01.org Delivered-To: edk2-devel@lists.01.org Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2a00:1450:400c:c09::242; helo=mail-wm0-x242.google.com; envelope-from=ard.biesheuvel@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-wm0-x242.google.com (mail-wm0-x242.google.com [IPv6:2a00:1450:400c:c09::242]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 01A6222280C2D for ; Wed, 27 Dec 2017 00:00:35 -0800 (PST) Received: by mail-wm0-x242.google.com with SMTP id b199so38278857wme.1 for ; Wed, 27 Dec 2017 00:05:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id; bh=0ysqrXjXKdnUSwkX/38m+tULMFd7/zIXX93wAlv5tTE=; b=JtDcSd/TPtQiMRIPA52q7bpTIEijNcUk8WsBHuKhxMuxyCo02OuYHz6ISAGwS4/C1y Z9YaDEPrgBwT1jln1umWdPWqtdHykY0U8ULrZCfEpDMnsZBrxNu1aly6CJ6Qj4v12yJX gK2g5vMZqnJGOyCpAMEJ6lRWj0we81KHB2eGg= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=0ysqrXjXKdnUSwkX/38m+tULMFd7/zIXX93wAlv5tTE=; b=YiPYCGoNKrfE3RdSPdlf8dcWNnIZZBDWAqV2nUJUJpWSp8TXjJ078pq0+z8dLfxRCe nmI2RppoH30iLPk/i4ZAtFtdP/OITE7Y++2gogybkX3tF9k0Wizd8+zMjaR57YJCTnAD Sbz+pSkfrjXO0HlQtm+w0X3+WtnULJHhj2K7cmfU0LhURoeQvsptzbEYSp8PZCSUMo5v vDye70ZEMVj5VnNRsKtBCJA8pXTTfWK4WyLgSrRJNPKHTfSoDpGNsZ2UZLF6tSsc2H1I XsE3TVCzep+ziEMZ1Ys+2QmUm4gcGhCFwnPSJE7Bw8dfMcS9aXcEk8KpH/o2JNj8RTeg ZZ3Q== X-Gm-Message-State: AKGB3mIzzubZdBEfxAgByuglS0hVggs5nft6HW3wJoBBNngX178Y+nVu 6yC7TM+Thb1JLg1sG6qY9bFbstr7cqU= X-Received: by 10.28.183.132 with SMTP id h126mr24617705wmf.17.1514361929230; Wed, 27 Dec 2017 00:05:29 -0800 (PST) Received: from localhost.localdomain ([105.137.110.132]) by smtp.gmail.com with ESMTPSA id f4sm42370255wra.75.2017.12.27.00.05.27 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 27 Dec 2017 00:05:28 -0800 (PST) From: Ard Biesheuvel To: edk2-devel@lists.01.org, qin.long@intel.com, ting.ye@intel.com Date: Wed, 27 Dec 2017 08:05:22 +0000 Message-Id: <20171227080522.10388-1-ard.biesheuvel@linaro.org> X-Mailer: git-send-email 2.11.0 Subject: [edk2] [PATCH] CryptoPkg/OpensslLib AARCH64: suppress format string warning X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Ard Biesheuvel MIME-Version: 1.0 Errors-To: edk2-devel-bounces@lists.01.org Sender: "edk2-devel" On GCC Build: openssl-1.1.0g introduced one additional build warning: ...\openssl\crypto\asn1\x_int64.c:105:32: error: format '%ld' expects argument of type 'long int', but argument 3 has type 'int64_t {aka long long int}' [-Werror=format=] return BIO_printf(out, "%"BIO_PRI64"d\n", **(int64_t **)pval); ^ Add "-Wno-error=format" to GCC build flags to suppress this warning, since we have no real printf usage in BaseCryptLib, and BIO_printf() was already wrapped as a dummy implementation in CryptoPkg. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Ard Biesheuvel --- CryptoPkg/Library/OpensslLib/OpensslLib.inf | 2 +- CryptoPkg/Library/OpensslLib/OpensslLibCrypto.inf | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) -- 2.11.0 _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel Reviewed-by: Long Qin Signed-off-by: Ard Biesheuvel diff --git a/CryptoPkg/Library/OpensslLib/OpensslLib.inf b/CryptoPkg/Library/OpensslLib/OpensslLib.inf index 5302ad7fb5ef..602953eefff7 100644 --- a/CryptoPkg/Library/OpensslLib/OpensslLib.inf +++ b/CryptoPkg/Library/OpensslLib/OpensslLib.inf @@ -560,7 +560,7 @@ [BuildOptions] GCC:*_*_X64_CC_FLAGS = -U_WIN32 -U_WIN64 $(OPENSSL_FLAGS) -Wno-error=maybe-uninitialized -Wno-error=format -DNO_MSABI_VA_FUNCS GCC:*_*_IPF_CC_FLAGS = -U_WIN32 -U_WIN64 $(OPENSSL_FLAGS) -Wno-error=maybe-uninitialized -Wno-error=format GCC:*_*_ARM_CC_FLAGS = $(OPENSSL_FLAGS) - GCC:*_*_AARCH64_CC_FLAGS = $(OPENSSL_FLAGS) + GCC:*_*_AARCH64_CC_FLAGS = $(OPENSSL_FLAGS) -Wno-error=format # suppress the following warnings in openssl so we don't break the build with warnings-as-errors: # 1295: Deprecated declaration - give arg types diff --git a/CryptoPkg/Library/OpensslLib/OpensslLibCrypto.inf b/CryptoPkg/Library/OpensslLib/OpensslLibCrypto.inf index 0c7f9e9e66f4..f697243f9787 100644 --- a/CryptoPkg/Library/OpensslLib/OpensslLibCrypto.inf +++ b/CryptoPkg/Library/OpensslLib/OpensslLibCrypto.inf @@ -521,7 +521,7 @@ [BuildOptions] GCC:*_*_X64_CC_FLAGS = -U_WIN32 -U_WIN64 $(OPENSSL_FLAGS) -Wno-error=maybe-uninitialized -Wno-error=format -DNO_MSABI_VA_FUNCS GCC:*_*_IPF_CC_FLAGS = -U_WIN32 -U_WIN64 $(OPENSSL_FLAGS) -Wno-error=maybe-uninitialized -Wno-error=format GCC:*_*_ARM_CC_FLAGS = $(OPENSSL_FLAGS) - GCC:*_*_AARCH64_CC_FLAGS = $(OPENSSL_FLAGS) + GCC:*_*_AARCH64_CC_FLAGS = $(OPENSSL_FLAGS) -Wno-error=format # suppress the following warnings in openssl so we don't break the build with warnings-as-errors: # 1295: Deprecated declaration - give arg types