From patchwork Tue Dec 19 10:12:57 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arnd Bergmann X-Patchwork-Id: 122361 Delivered-To: patch@linaro.org Received: by 10.80.152.193 with SMTP id j59csp3842355edb; Tue, 19 Dec 2017 02:13:43 -0800 (PST) X-Google-Smtp-Source: ACJfBovC3bm0qycWEBdIwXDomBAWkIQIoRZRVGtWx/Xm1oz/7yAv8/Hua7lAey/9TSpK0jeddbVq X-Received: by 10.98.64.21 with SMTP id n21mr2715080pfa.129.1513678423243; Tue, 19 Dec 2017 02:13:43 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1513678423; cv=none; d=google.com; s=arc-20160816; b=NrRJlw2S5XmDSKBhLW4SGYdATp2zOnvSYqWuSDrSUAAkYXFtifV50e+jFN/j13Y/vF XiBF8vR8MhrMYfLkqM9iqcZmIElKMrQbXV0L4mJzQZiRxCEPCaWtJZ7PAApDiepFm5hP YSUW26mqKOeelAdBCZJhEGdCD+PxmK4zpgIkjnnpV2ThWM/kBc2snRdONjmqRPoCRgbk wAYmMDOWtLwW6UFlUqppBqHcgYnMWn/JjPF1yEi9JVe8hgLFGWqR3TA5yv6GJkQM3U17 wCeYPQvE1agepecNddUC2n4UyjuEugbWYBYbhunjGzcCICbfP8Ez8tRD6YtOusHEUQZ8 STpQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:date:subject:cc:to:from :arc-authentication-results; bh=BaL11NfRE8RQjjou3D5Wlh61QEQVfpSfm6Zdo4Zxn9I=; b=k+sfp0MAE9cqF8YwywslfVKsuafIXq5oQ+YesmI8PuKyEG3C9O3OP8lgebXVRrPYbm dINuOJcZi+NFvM3ZnRkJjW0dCy6F1Qf+Ej74h04WTLafwDXX6UWOpk7ZD81rv6noNicl pAjMsWmNpwNA48jQG464TJ3irjfoN3p15OkD4hiL8pPFPGv+5FdNYy1qZ8m70pvBw8MD 4c/XzcGwgr0eU4AfgCWL6ejbBGJO4kS2HoUSPi2Le+O6cllbX5bvwTHl7Tec8bm8BLSK +ugltLb/T3Pv0WQgYYgGxRqn4026RP5gUZ3RHP5GuOESix+G3XYG9UdcwYVKQ5+AQmPL s6TQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id v40si10530639plg.599.2017.12.19.02.13.42; Tue, 19 Dec 2017 02:13:43 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1761713AbdLSKNj (ORCPT + 28 others); Tue, 19 Dec 2017 05:13:39 -0500 Received: from mout.kundenserver.de ([217.72.192.74]:51092 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1759262AbdLSKNe (ORCPT ); Tue, 19 Dec 2017 05:13:34 -0500 Received: from wuerfel.lan ([95.208.111.237]) by mrelayeu.kundenserver.de (mreue102 [212.227.15.145]) with ESMTPA (Nemesis) id 0MAdeV-1eH2Qt23Xn-00BrQr; Tue, 19 Dec 2017 11:13:28 +0100 From: Arnd Bergmann To: Steve French Cc: Arnd Bergmann , Pavel Shilovsky , Jean Delvare , Long Li , linux-cifs@vger.kernel.org, samba-technical@lists.samba.org, linux-kernel@vger.kernel.org Subject: [PATCH] CIFS: SMBD: fix configurations with INFINIBAND=m Date: Tue, 19 Dec 2017 11:12:57 +0100 Message-Id: <20171219101327.2165797-1-arnd@arndb.de> X-Mailer: git-send-email 2.9.0 X-Provags-ID: V03:K0:T5nPVjTrVEObPTz+xwZgl1yPYclRESP+T96GcI0Ju1BzTbQ0FKZ BV9k0skPyEpuxwTBvxRn89heBB2A5Wgr+AWwKu42rykkvQAYLjieW5Y1tiSR5BCZmjnRzk9 1y/BZheHf5ufFd/QSNNw9eK6oJ5XsTnytfkundLnsYTfZwIUcbgW2Y+LFf1awntAJK2nI7l M81koTTn6vsulPybBWfBA== X-UI-Out-Filterresults: notjunk:1; V01:K0:vpXcfPnxyNg=:XWDBAQsiZLoG+r23YRltXd hwyu0EkkJmSVXPo9r2n4fPAD4BUYNNISjNRWHrDqNCgIbHSaXTsQz4CjQ5QKEanMJzMoYTcCx sfpJ8ApigMg6Ll0mdT48DpNbWntZo8hQHyKaGzTxcL5lCcpGV2GzNL/bp83xDSycciLXr8tBT H3WMCUb9qDQ7hD8QFeI4KpZq5BRiknwBv3tScHUJ00fhhz5iFft+prahd9QhKK9LW15NGY18e sX+i2WudzAgfehcFp6SMbQ270AYTU7LnhKd0GLVWdWsMno9o+qtygB054NTU+rl7XQ60+7KU/ 45iay08y+BS3Jnj8ZMKLMib1R5MGINksAfCsLBrozas/8jGHWvx3Hh/KjS8BuKB/Y1sPIua6M YWR/L6QjrTiG63Jj1rR2g04ll9U7M0cTiG+eFuhNDn4kvfIxWaWsNviLu1g/Ua2zJjINOWhWv 3EkYy6L6so4y1r1o9xz4cvLL/Cn9Mpmfi+4/ng92dfRSbDYijFOMGfrmtIQSZf6yEPMwd0q61 Sw6pzM8290SRVey2R/KK6mkvTh7RCXllQOT8CGD51zncvxkeuTYu0AT829CDE7SL4HV/mE5ZL 1gzH6fHfulxjVmb9hdgqiqhDeiwamH82CL7Id1988HOkmfNzdcbcX0FfkD3h275OHS2TcPZkV 7+rdk48xAI7XCxgJWzfaHcUFx3Sk1nKjVw3aAkOquuzr3Rrth9w7k+mxUCqbc089UvCUdQn3/ ADNIwkgA73baT3xxyS7qniV3pqwvCpaSkd/JnQ== Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org A built-in SMB file system cannot link against a modular infiniband core module: fs/cifs/smbdirect.o: In function `smbd_destroy_rdma_work': smbdirect.c:(.text+0x28e3): undefined reference to `ib_drain_qp' smbdirect.c:(.text+0x2915): undefined reference to `rdma_destroy_qp' smbdirect.c:(.text+0x2d08): undefined reference to `ib_free_cq' smbdirect.c:(.text+0x2d3d): undefined reference to `ib_free_cq' smbdirect.c:(.text+0x2d6f): undefined reference to `ib_dealloc_pd' smbdirect.c:(.text+0x2d9a): undefined reference to `rdma_destroy_id' fs/cifs/smbdirect.o: In function `smbd_disconnect_rdma_work': smbdirect.c:(.text+0x3d3e): undefined reference to `rdma_disconnect' fs/cifs/smbdirect.o: In function `_smbd_get_connection': smbdirect.c:(.text+0x5bc2): undefined reference to `rdma_create_id' smbdirect.c:(.text+0x5cc5): undefined reference to `rdma_resolve_addr' smbdirect.c:(.text+0x5cda): undefined reference to `rdma_destroy_id' smbdirect.c:(.text+0x5da7): undefined reference to `rdma_destroy_id' smbdirect.c:(.text+0x5e89): undefined reference to `rdma_resolve_route' smbdirect.c:(.text+0x5f07): undefined reference to `rdma_destroy_id' This changes the Kconfig dependency to enforce selecting one of the valid configurations. Fixes: bbc50d2ad317 ("CIFS: SMBD: Introduce kernel config option CONFIG_CIFS_SMB_DIRECT") Signed-off-by: Arnd Bergmann --- fs/cifs/Kconfig | 1 + 1 file changed, 1 insertion(+) -- 2.9.0 Reviewed-by: Jean Delvare diff --git a/fs/cifs/Kconfig b/fs/cifs/Kconfig index 500fd69fb58b..3bfc55c08bef 100644 --- a/fs/cifs/Kconfig +++ b/fs/cifs/Kconfig @@ -199,6 +199,7 @@ config CIFS_SMB311 config CIFS_SMB_DIRECT bool "SMB Direct support (Experimental)" depends on CIFS && INFINIBAND + depends on CIFS=m || INFINIBAND=y help Enables SMB Direct experimental support for SMB 3.0, 3.02 and 3.1.1. SMB Direct allows transferring SMB packets over RDMA. If unsure,