From patchwork Thu Dec 14 00:57:54 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mathieu Poirier X-Patchwork-Id: 121878 Delivered-To: patch@linaro.org Received: by 10.140.22.227 with SMTP id 90csp6179009qgn; Wed, 13 Dec 2017 16:58:02 -0800 (PST) X-Google-Smtp-Source: ACJfBosvcw1bpwHsXBXh1BQhCakJodmVGylBvdRLZ9GIH1ymNhrSdTsuwaZdWQS30FAzZBAP0N95 X-Received: by 10.84.231.138 with SMTP id g10mr7715225plk.373.1513213082105; Wed, 13 Dec 2017 16:58:02 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1513213082; cv=none; d=google.com; s=arc-20160816; b=lhbJE3GneKkiWogNyvk1mJ8h1IKFECCXgz40kJiA+Ug86EuSCEbbANyNG1DOr9MK7H MSYNK2JMqQEF9qRFB+3xJ1SELnBdcjlvVvHQ8heFfK5XG0VDjKJh9C/NumSZ+IoytRPn /miGFU0v7BSfTwLxJilJh6rcuUicdYXkezoQ1FuKlMlCsTPE+uUtcv82Z87RGhGKoiWo rbxX17esDTnJJUEg1Z4XdVGDOi6SuljI6OPmVjnAqmXM8iBJSzXTW36x2hj1MVcz7bpE xCLVyOt7Xl1yk9o5uOqmwP/XvMkXQaA9jY/dZ5CsaxrU3TNDJZO74CW0lI9AGsQi9oza pLRg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:date:subject:cc:to:from :dkim-signature:arc-authentication-results; bh=/W6AS7TshGZwt0HDM6l6f5T1p51HaJbNiFarA6JUGWU=; b=jJDR90GYpPFlL3W0mMiX14ivjYRiND4fIYv6NSyB/qJ2Pb+G3qYeHDuFXH61c8MmkI GJYKG32IyB/ntUTU22SqnFmWJfWamqvcbHsLyHWeHhAQd4dUAjLb1XW7EPEna0dULVEL AUvO06/YrnjThjru2xK3FscCfhnd7dXn/KeQqL4NXDYAjUHGlTk8ylbVZEB1zhB4CUys js4/x4sbKhs5GoKSbC/2gqZCGTFLESwrKLap2IwD4LMXCf1rUiCIjjmkg4qWArHM4Oee 9QUbeQDDfC3KlKfQCs3ITOkq64nVZKpVtMCvvhxsxIqxTE+5pyeOt9XnCEnggcFips/x DMfA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=c0eNhp+F; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id z24si2208409plo.108.2017.12.13.16.58.01; Wed, 13 Dec 2017 16:58:02 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=c0eNhp+F; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751839AbdLNA56 (ORCPT + 22 others); Wed, 13 Dec 2017 19:57:58 -0500 Received: from mail-it0-f67.google.com ([209.85.214.67]:33699 "EHLO mail-it0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751524AbdLNA55 (ORCPT ); Wed, 13 Dec 2017 19:57:57 -0500 Received: by mail-it0-f67.google.com with SMTP id o130so22922341itg.0 for ; Wed, 13 Dec 2017 16:57:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id; bh=/W6AS7TshGZwt0HDM6l6f5T1p51HaJbNiFarA6JUGWU=; b=c0eNhp+FzIaHGxpdTfIMc48EhBvIS6t2aFYjLTpx9Zgi7PVeAKvgLZML8sM4AZRaVx gp7H/23JAW/vDYPQmuKIAKgKPwnVOzmlk3mrxD43XNYVauWJNwznrlWj8HoRTwsRIHKH k/A0GmSd8m/+Rsll/hP85RGnJyhHLovrTTvcw= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=/W6AS7TshGZwt0HDM6l6f5T1p51HaJbNiFarA6JUGWU=; b=fJWoeG93Ut8BetEqZl4ZMPbpFgbFhDqSaBAgZNA727D0PpxBZvHdUqFPi/r5GfqhL5 hc9Tfb5MjjpPLtrej5GISXyEU5I1YIDTslZmJ9jIsRWsbuiikDc51MPyoUlg0yQqO6B+ NMjlcC42HADi8mC6KT11nAc12H/dbjpzrMTRuI/Ysjl41EWcanYZDlSFiOgZXXfiAmp2 PhHdON6z6RMI+NvM9J99a18qIIRtVRTeluqbNVlkWwN/24CXetq/e77OpgESxxeCLW9d rsrimy55IIgo5Oj8aqtX2igjYW4VljpNbMqw5+husdRbQU6sMu9WAVLltzU4Z3NjwGgn k5NQ== X-Gm-Message-State: AKGB3mJamnfRo+sbg9Jp8TOjZ49WR9AnJMa6shpD+A0pbxUT7LLwlXe9 2wuPNFRZ5xa4eVYtplMHXsAypg== X-Received: by 10.36.60.212 with SMTP id m203mr1105785ita.96.1513213076809; Wed, 13 Dec 2017 16:57:56 -0800 (PST) Received: from xps15.cg.shawcable.net (S0106002369de4dac.cg.shawcable.net. [68.147.8.254]) by smtp.gmail.com with ESMTPSA id o73sm7244157ito.4.2017.12.13.16.57.55 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Wed, 13 Dec 2017 16:57:55 -0800 (PST) From: Mathieu Poirier To: jolsa@redhat.com Cc: peterz@infradead.org, mingo@redhat.com, acme@kernel.org, alexander.shishkin@linux.intel.com, linux-kernel@vger.kernel.org, mathieu.poirier@linaro.org Subject: [PATCH] perf report: Fix regression when decoding intelPT traces Date: Wed, 13 Dec 2017 17:57:54 -0700 Message-Id: <1513213074-25173-1-git-send-email-mathieu.poirier@linaro.org> X-Mailer: git-send-email 2.7.4 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Commit (93d10af26bb7 perf tools: Optimize sample parsing for ordered events) breaks intelPT trace decoding by invariably returning an error if the event type isn't a PERF_SAMPLE_TIME. With this patch the timestamp is initialised and processing is allowed to continue even if an error is returned by function perf_evlist__parse_sample_timestamp(). Signed-off-by: Mathieu Poirier --- tools/perf/util/session.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.7.4 diff --git a/tools/perf/util/session.c b/tools/perf/util/session.c index 54e30f1bcbd7..20cdcf14232b 100644 --- a/tools/perf/util/session.c +++ b/tools/perf/util/session.c @@ -1512,7 +1512,7 @@ static s64 perf_session__process_event(struct perf_session *session, ret = perf_evlist__parse_sample_timestamp(evlist, event, ×tamp); if (ret) - return ret; + timestamp = -1ULL; ret = perf_session__queue_event(session, event, timestamp, file_offset); if (ret != -ETIME)