From patchwork Wed Dec 13 08:55:03 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Quentin Schulz X-Patchwork-Id: 121723 Delivered-To: patch@linaro.org Received: by 10.140.22.227 with SMTP id 90csp5205549qgn; Wed, 13 Dec 2017 00:56:33 -0800 (PST) X-Google-Smtp-Source: ACJfBosbN0U+GQNFHrPEcbDlGhVyudti9fZKZXxHhDTHMoI6yPAEhCUEqsMXewW3mzZI0xdMuvCC X-Received: by 10.99.105.2 with SMTP id e2mr4744497pgc.219.1513155393651; Wed, 13 Dec 2017 00:56:33 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1513155393; cv=none; d=google.com; s=arc-20160816; b=CeK9vg4adrKlkUYUq4os0PHyf+6PwFagdUL1xAOjPFoRDyo9Cp0wZLtLd1/gfefTJw EyoqXYjHFijdfCfJsqvHbYT9cXlObvz/shwjfbFH6vQGgLp9lPx+pdiQcjfU6HqoVwnk rCOTl8LtVx+gQXsU5bOraXiOwwvXVduDaevnBL2PifYRPP2hJrWegpOavWG/Yt1oJvQL NzcwKgvMH9jUVjenIUyHDZdoL42AhWYp8mzu5G1Ij1e/FEin3X7KrtScBBNjpUxNivsK Hy7tO3gwlBJaYaOWh3w34gmtbMPHMGGQO1lUMD7lTYJ4E6Uq1kGbTwYcUFnDRGouEhBM GNCg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:arc-authentication-results; bh=b2/62Haq8CDjve/gNHrq4CEg7omwsZ9GLSEH9QbdVpg=; b=UwY/N3GywQQz95mrSizAhGrbecUEoHYfOoomRr1Ljw1GkvGYkA/RioNssY3MAowv8q YsUZKszo6a9rnR8KZ0N4zD7YY6QUe+f9UyZpJd2tp18MRaenQu5SfMD5DcL+eEIpNYIB rf+TEkxlklFkZrEsRILAb9c+rjIhkXI2XmJMkyiokr1GLg+AfXWVcEIoMWP9DhQdCNPv UJuTkhv+2ung4UEOP57LCny1M2PuydJmm4r6j6TtFIepdIZuWOjJGOipokyeVZzW7wlq 0GFghWVn3KBjRtgNJ5rkJfTu6AJpoxqGp08BfScGNcwrYr5Ak7gBOIGurft1SFHgXAv0 RpBQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id r26si949059pge.285.2017.12.13.00.56.33; Wed, 13 Dec 2017 00:56:33 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752155AbdLMI43 (ORCPT + 10 others); Wed, 13 Dec 2017 03:56:29 -0500 Received: from mail.free-electrons.com ([62.4.15.54]:55288 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751462AbdLMI41 (ORCPT ); Wed, 13 Dec 2017 03:56:27 -0500 Received: by mail.free-electrons.com (Postfix, from userid 110) id 7FDD62045B; Wed, 13 Dec 2017 09:56:25 +0100 (CET) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on mail.free-electrons.com X-Spam-Level: X-Spam-Status: No, score=-1.0 required=5.0 tests=ALL_TRUSTED,SHORTCIRCUIT shortcircuit=ham autolearn=disabled version=3.4.0 Received: from localhost.localdomain (LStLambert-657-1-97-87.w90-63.abo.wanadoo.fr [90.63.216.87]) by mail.free-electrons.com (Postfix) with ESMTPSA id A331A20850; Wed, 13 Dec 2017 09:56:05 +0100 (CET) From: Quentin Schulz To: linus.walleij@linaro.org, wens@csie.org, maxime.ripard@free-electrons.com Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, thomas.petazzoni@free-electrons.com, linux-sunxi@googlegroups.com, mylene.josserand@free-electrons.com, Quentin Schulz Subject: [PATCH] pinctrl: axp209: dereference pointer after it's been set Date: Wed, 13 Dec 2017 09:55:03 +0100 Message-Id: <20171213085503.31899-1-quentin.schulz@free-electrons.com> X-Mailer: git-send-email 2.14.1 MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The number of GPIOs is gotten from a field within the structure referenced in the of_device.data but it was actually read before it was retrieved, thus it was dereferencing a null pointer. Set the number of GPIOs after retrieving of_device.data. Fixes: e1190083b89b ("pinctrl: axp209: add support for AXP813 GPIOs") Signed-off-by: Quentin Schulz Reported-by: Mylène Josserand --- drivers/pinctrl/pinctrl-axp209.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) -- 2.14.1 diff --git a/drivers/pinctrl/pinctrl-axp209.c b/drivers/pinctrl/pinctrl-axp209.c index 22d3bb0bf927..510a2821e910 100644 --- a/drivers/pinctrl/pinctrl-axp209.c +++ b/drivers/pinctrl/pinctrl-axp209.c @@ -413,9 +413,11 @@ static int axp20x_pctl_probe(struct platform_device *pdev) pctl->chip.set = axp20x_gpio_set; pctl->chip.direction_input = axp20x_gpio_input; pctl->chip.direction_output = axp20x_gpio_output; - pctl->chip.ngpio = pctl->desc->npins; pctl->desc = (struct axp20x_pctrl_desc *)of_device_get_match_data(dev); + + pctl->chip.ngpio = pctl->desc->npins; + pctl->regmap = axp20x->regmap; pctl->dev = &pdev->dev;