From patchwork Tue Dec 12 18:58:04 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dan Murphy X-Patchwork-Id: 121623 Delivered-To: patch@linaro.org Received: by 10.140.22.227 with SMTP id 90csp4501168qgn; Tue, 12 Dec 2017 10:58:37 -0800 (PST) X-Google-Smtp-Source: ACJfBovNHDPKxA2YhLiMH2An/6YqQChBbNfq1IAko1siCf/e478JZB6U4KHJZ1MlPFzbyyPEwNvt X-Received: by 10.101.81.68 with SMTP id g4mr2920537pgq.166.1513105117406; Tue, 12 Dec 2017 10:58:37 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1513105117; cv=none; d=google.com; s=arc-20160816; b=eBCRB+ZzaPbnUJBEWl9RjSyJhg8rmmVCFg9/HijXPERCl2ObkoU/DMzDMOMGUIElXf sASeZ9MQrteNx3n0Bop4DP9F7ZRdeW/LXuz90Uv1HD9cSYVVOpL92a61Eb0cXfzeyu5T os+3m+bQ5t5AsWA5b/kb2Pca17BN52/4uRH+yidugrOlPk6b2Zj8W3zhAz2WtlMM21S5 BwwFgQkg3pW2EN9DyhtBhxPwKsvhh2owJh07FkBTOqO1vzDiMFsmH0zOlwM+sJqWcALy hwdYqulQo7WKvk55Edx68d1h8RepJVi+C2wgUrpmJXuePnxJR2AyA0sw/XkJZNLJZCVQ 2M3w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:dkim-signature :arc-authentication-results; bh=M3T1nH2RdkQWIDmJRw4GOqHdJ9koCRwKVFmWYww8lf8=; b=g8R3a8enahb4bLcpDLuxs2afkhdDQcAg3im5q+tQ6kfK/+G4zqHkZWHp5xg07gIHao /FLrz+OhNSdAngcmU3L/tgJZ1PEXFnxb6/IuPfNx304xyLRLandX01LxCsuAxSIzh8Mu F58owfjtijDnoO7Hbj3PN5kD8yzXnWetpiV1VPtZIuf5sxCjEfnJhY4dCYHBnckeUT21 6lW/WbtnJ83KO3ac/ngMn2hCw0AS5/8bj78oc0YzZOsQjl49RQAaj4xuBLZf2gMrFQ+8 r6tmv6mrmotpbpAX6KIZM8VPJFBKM4HpBcCwHVzqKP93Rqzherqe7SXF5ti7JIjYihgi LdSA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@ti.com header.s=ti-com-17Q1 header.b=pk5ZyGpt; spf=pass (google.com: best guess record for domain of linux-leds-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-leds-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=NONE dis=NONE) header.from=ti.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id bc11si3003890plb.84.2017.12.12.10.58.37 for ; Tue, 12 Dec 2017 10:58:37 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-leds-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@ti.com header.s=ti-com-17Q1 header.b=pk5ZyGpt; spf=pass (google.com: best guess record for domain of linux-leds-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-leds-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=NONE dis=NONE) header.from=ti.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752255AbdLLS6g (ORCPT ); Tue, 12 Dec 2017 13:58:36 -0500 Received: from lelnx194.ext.ti.com ([198.47.27.80]:30790 "EHLO lelnx194.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752204AbdLLS62 (ORCPT ); Tue, 12 Dec 2017 13:58:28 -0500 Received: from dflxv15.itg.ti.com ([128.247.5.124]) by lelnx194.ext.ti.com (8.15.1/8.15.1) with ESMTP id vBCIwEXe027857; Tue, 12 Dec 2017 12:58:14 -0600 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ti.com; s=ti-com-17Q1; t=1513105094; bh=HxMLE4wbVAOV2QTdz5uvSgfHSO18dsAR1W23rqTYp3o=; h=From:To:CC:Subject:Date:In-Reply-To:References; b=pk5ZyGptfMLxY1eOVoXnsVciRYjTFqvD5BYx52QTtqGVY++9PS8NrHTEIfOLaOoNo as8Yb4546gIwPaOrvbX+YNH++UoFP9OUMF7tMU3T2TvxTTpbg2d0t2MxIg1RuAnrQO iAmRIcfF3UWSoHSqX6x1nsvTs8Z/RfqGqr1bAHQk= Received: from DFLE110.ent.ti.com (dfle110.ent.ti.com [10.64.6.31]) by dflxv15.itg.ti.com (8.14.3/8.13.8) with ESMTP id vBCIwEo8002128; Tue, 12 Dec 2017 12:58:14 -0600 Received: from DFLE100.ent.ti.com (10.64.6.21) by DFLE110.ent.ti.com (10.64.6.31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.1.845.34; Tue, 12 Dec 2017 12:58:14 -0600 Received: from dflp33.itg.ti.com (10.64.6.16) by DFLE100.ent.ti.com (10.64.6.21) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_RSA_WITH_AES_256_CBC_SHA) id 15.1.845.34 via Frontend Transport; Tue, 12 Dec 2017 12:58:14 -0600 Received: from legion.dal.design.ti.com (legion.dal.design.ti.com [128.247.22.53]) by dflp33.itg.ti.com (8.14.3/8.13.8) with ESMTP id vBCIwEm4015110; Tue, 12 Dec 2017 12:58:14 -0600 Received: from localhost (a0272616local-lt.dhcp.ti.com [172.22.69.253]) by legion.dal.design.ti.com (8.11.7p1+Sun/8.11.7) with ESMTP id vBCIwDx25368; Tue, 12 Dec 2017 12:58:13 -0600 (CST) From: Dan Murphy To: , , , , CC: , , , Dan Murphy Subject: [PATCH v3 1/1] leds: lp8860: Various fixes to align with LED framework Date: Tue, 12 Dec 2017 12:58:04 -0600 Message-ID: <20171212185809.23880-3-dmurphy@ti.com> X-Mailer: git-send-email 2.12.2 In-Reply-To: <20171212185809.23880-1-dmurphy@ti.com> References: <20171212185809.23880-1-dmurphy@ti.com> MIME-Version: 1.0 X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 Sender: linux-leds-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-leds@vger.kernel.org Update the driver to conform with the LED framework. Use devm_led_classdev_register Destroy mutex on exit Remove dependency on CONFIG_OF in the driver and move to the Kconfig Update the MODULE_LICENSE to GPL v2 Remove setting of MAX brightness as the LED framework does this. Signed-off-by: Dan Murphy --- drivers/leds/Kconfig | 2 +- drivers/leds/leds-lp8860.c | 13 +++++-------- 2 files changed, 6 insertions(+), 9 deletions(-) -- 2.15.0.124.g7668cbc60 diff --git a/drivers/leds/Kconfig b/drivers/leds/Kconfig index 318a28fd58fe..ac4d9d8bf96b 100644 --- a/drivers/leds/Kconfig +++ b/drivers/leds/Kconfig @@ -347,7 +347,7 @@ config LEDS_LP8788 config LEDS_LP8860 tristate "LED support for the TI LP8860 4 channel LED driver" - depends on LEDS_CLASS && I2C + depends on LEDS_CLASS && I2C && OF select REGMAP_I2C help If you say yes here you get support for the TI LP8860 4 channel diff --git a/drivers/leds/leds-lp8860.c b/drivers/leds/leds-lp8860.c index 309a73a0c2dd..f38531c30185 100644 --- a/drivers/leds/leds-lp8860.c +++ b/drivers/leds/leds-lp8860.c @@ -399,7 +399,6 @@ static int lp8860_probe(struct i2c_client *client, led->client = client; led->led_dev.name = led->label; - led->led_dev.max_brightness = LED_FULL; led->led_dev.brightness_set_blocking = lp8860_brightness_set; mutex_init(&led->lock); @@ -426,7 +425,7 @@ static int lp8860_probe(struct i2c_client *client, if (ret) return ret; - ret = led_classdev_register(&client->dev, &led->led_dev); + ret = devm_led_classdev_register(&client->dev, &led->led_dev); if (ret) { dev_err(&client->dev, "led register err: %d\n", ret); return ret; @@ -440,8 +439,6 @@ static int lp8860_remove(struct i2c_client *client) struct lp8860_led *led = i2c_get_clientdata(client); int ret; - led_classdev_unregister(&led->led_dev); - if (led->enable_gpio) gpiod_direction_output(led->enable_gpio, 0); @@ -452,6 +449,8 @@ static int lp8860_remove(struct i2c_client *client) "Failed to disable regulator\n"); } + mutex_destroy(&led->lock); + return 0; } @@ -461,18 +460,16 @@ static const struct i2c_device_id lp8860_id[] = { }; MODULE_DEVICE_TABLE(i2c, lp8860_id); -#ifdef CONFIG_OF static const struct of_device_id of_lp8860_leds_match[] = { { .compatible = "ti,lp8860", }, {}, }; MODULE_DEVICE_TABLE(of, of_lp8860_leds_match); -#endif static struct i2c_driver lp8860_driver = { .driver = { .name = "lp8860", - .of_match_table = of_match_ptr(of_lp8860_leds_match), + .of_match_table = of_lp8860_leds_match, }, .probe = lp8860_probe, .remove = lp8860_remove, @@ -482,4 +479,4 @@ module_i2c_driver(lp8860_driver); MODULE_DESCRIPTION("Texas Instruments LP8860 LED driver"); MODULE_AUTHOR("Dan Murphy "); -MODULE_LICENSE("GPL"); +MODULE_LICENSE("GPL v2"); From patchwork Tue Dec 12 18:58:07 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dan Murphy X-Patchwork-Id: 121626 Delivered-To: patch@linaro.org Received: by 10.140.22.227 with SMTP id 90csp4501623qgn; Tue, 12 Dec 2017 10:59:08 -0800 (PST) X-Google-Smtp-Source: ACJfBotg/SJ1ZURbMib6wDWI/WDktOQcGlehRzUCBGr1hC5lLA4DwrbC1fDKOKwV5We/sfRucZBv X-Received: by 10.84.246.200 with SMTP id j8mr3176124plt.418.1513105148767; Tue, 12 Dec 2017 10:59:08 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1513105148; cv=none; d=google.com; s=arc-20160816; b=IyXNJCj2DXFNa4QydmElGNqZy4YskYQuaqEPkM6/5Ugx4ChtVmZoQX/AHe+ABVMvPd 74bBwMGleJ/trije0QgoM35a6eopffHiiG9rxoV5PQwc1uriXFoVWT7LXuy7Slo7mgDU 67ttDBxpGnunkfNHzqzJt4KstRyqpAprzc6FCKQMfxSsmVyCplcHvLygdZayeJll+q/i JhQN5Rtje7oymw/YUAQT8rWuqdsNPFfPrIIxND5HUNn+LMTdusJZ7Q2lpf7qn3HV+WeI qB/Xo4OypMtWNH5dh+8hLqLx5kB7HC8wU+9w/Ab7HSxz0Wzs7l/qw3lr3GMqyHzJZBAd 39GQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:dkim-signature :arc-authentication-results; bh=spFPLAszXqhyqaU5mbFFBJJ/DL3Ta7/1tEvhwM2nSm0=; b=SMh89aNYUPjke9aOB9s0MsSrysKWYetXmgdYwFZX8fsLT1nV6oeYoupPJrk7eSmFr+ yQAJUIM89ge/tzGMRrOLwTIuPUKhlUHjiG3/SpNTJpyGywqwdkSf0y3hZl9QaCoXV+A4 nRnt4MslYEDpn3cI9TpJi1zUfJ9p65CG2Dq9/D5309JKsxSbchTZglxbWq+O7pi5MBaJ qlW/QwrdzMrKKrt20RPECb9YXqrP8fKP5ie4vhSWR2Fx4cMc+r7Ap4Wq60aGjiwjn70z LfGYs/rnEYoazyyxRatQcZ7gNUbXNPpAcQenrXZntQBNGnljTUB4s+fI3mKMv65V4ROP Uj1g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@ti.com header.s=ti-com-17Q1 header.b=zV7yi/P4; spf=pass (google.com: best guess record for domain of linux-leds-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-leds-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=NONE dis=NONE) header.from=ti.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 30si12014786plb.782.2017.12.12.10.59.08 for ; Tue, 12 Dec 2017 10:59:08 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-leds-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@ti.com header.s=ti-com-17Q1 header.b=zV7yi/P4; spf=pass (google.com: best guess record for domain of linux-leds-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-leds-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=NONE dis=NONE) header.from=ti.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752134AbdLLS7H (ORCPT ); Tue, 12 Dec 2017 13:59:07 -0500 Received: from lelnx193.ext.ti.com ([198.47.27.77]:59512 "EHLO lelnx193.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752408AbdLLS6c (ORCPT ); Tue, 12 Dec 2017 13:58:32 -0500 Received: from dlelxv90.itg.ti.com ([172.17.2.17]) by lelnx193.ext.ti.com (8.15.1/8.15.1) with ESMTP id vBCIwGjm003339; Tue, 12 Dec 2017 12:58:16 -0600 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ti.com; s=ti-com-17Q1; t=1513105096; bh=ua+ZG2EPxx9/lVfzpTWdeMQnIirXQ6A8NxWXr7Jtumc=; h=From:To:CC:Subject:Date:In-Reply-To:References; b=zV7yi/P41Q1/OZ6Bwmm8uJNR2RNH+TvtU40qKWFxUtC0AOAwRKpbQQI4MGGsFVBqM 0rnpQIwo2D8l1YTL8PvE60Fh0HxiQ1Ta8nmPy7c+aX9kdbJwJxxodVXkHJH+Pe16tn OqYoJWZ3QnszXxmV0f400oVCWnIuKzA/MeY++arg= Received: from DFLE108.ent.ti.com (dfle108.ent.ti.com [10.64.6.29]) by dlelxv90.itg.ti.com (8.14.3/8.13.8) with ESMTP id vBCIwGEv019049; Tue, 12 Dec 2017 12:58:16 -0600 Received: from DFLE107.ent.ti.com (10.64.6.28) by DFLE108.ent.ti.com (10.64.6.29) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.1.845.34; Tue, 12 Dec 2017 12:58:15 -0600 Received: from dlep32.itg.ti.com (157.170.170.100) by DFLE107.ent.ti.com (10.64.6.28) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_RSA_WITH_AES_256_CBC_SHA) id 15.1.845.34 via Frontend Transport; Tue, 12 Dec 2017 12:58:15 -0600 Received: from legion.dal.design.ti.com (legion.dal.design.ti.com [128.247.22.53]) by dlep32.itg.ti.com (8.14.3/8.13.8) with ESMTP id vBCIwFsn002997; Tue, 12 Dec 2017 12:58:15 -0600 Received: from localhost (a0272616local-lt.dhcp.ti.com [172.22.69.253]) by legion.dal.design.ti.com (8.11.7p1+Sun/8.11.7) with ESMTP id vBCIwFx25380; Tue, 12 Dec 2017 12:58:15 -0600 (CST) From: Dan Murphy To: , , , , CC: , , , Dan Murphy Subject: [PATCH v3 4/6] dt: bindings: lp8860: Add trigger binding to the lp8860 Date: Tue, 12 Dec 2017 12:58:07 -0600 Message-ID: <20171212185809.23880-6-dmurphy@ti.com> X-Mailer: git-send-email 2.12.2 In-Reply-To: <20171212185809.23880-1-dmurphy@ti.com> References: <20171212185809.23880-1-dmurphy@ti.com> MIME-Version: 1.0 X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 Sender: linux-leds-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-leds@vger.kernel.org Add a default trigger optional node to the child node. This will allow the driver to set the trigger for a backlight. Signed-off-by: Dan Murphy --- v3 - Removed optional and rebased - https://patchwork.kernel.org/patch/10093755/ v2 - Moved binding changes to first patch in the series. Documentation/devicetree/bindings/leds/leds-lp8860.txt | 3 +++ 1 file changed, 3 insertions(+) -- 2.15.0.124.g7668cbc60 diff --git a/Documentation/devicetree/bindings/leds/leds-lp8860.txt b/Documentation/devicetree/bindings/leds/leds-lp8860.txt index c3d64ade1e26..cdb9e12bd0aa 100644 --- a/Documentation/devicetree/bindings/leds/leds-lp8860.txt +++ b/Documentation/devicetree/bindings/leds/leds-lp8860.txt @@ -21,6 +21,8 @@ Required child properties: Optional child properties: - label : see Documentation/devicetree/bindings/leds/common.txt + - linux,default-trigger : + see Documentation/devicetree/bindings/leds/common.txt Example: @@ -35,6 +37,7 @@ led-controller@2d { led@0 { reg = <0>; label = "white:display_cluster"; + linux,default-trigger = "backlight"; }; }