From patchwork Tue Oct 6 16:06:30 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Matthieu Baerts X-Patchwork-Id: 299412 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH, MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 75A36C4727D for ; Tue, 6 Oct 2020 16:06:39 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 21EDE2075A for ; Tue, 6 Oct 2020 16:06:39 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=tessares-net.20150623.gappssmtp.com header.i=@tessares-net.20150623.gappssmtp.com header.b="jf88Ccrj" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726267AbgJFQGi (ORCPT ); Tue, 6 Oct 2020 12:06:38 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50620 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726127AbgJFQGi (ORCPT ); Tue, 6 Oct 2020 12:06:38 -0400 Received: from mail-ej1-x644.google.com (mail-ej1-x644.google.com [IPv6:2a00:1450:4864:20::644]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 26970C0613D2 for ; Tue, 6 Oct 2020 09:06:38 -0700 (PDT) Received: by mail-ej1-x644.google.com with SMTP id t25so3132694ejd.13 for ; Tue, 06 Oct 2020 09:06:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tessares-net.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=q+y9F2HEpHR7lpSOgScZpt3aZTxZ1exfih7MMVF+3Hw=; b=jf88Ccrjz6JfstZvP1H6vKpUwaTbdYZQWbaqcorUPs55gtjmyI3fseCArUh1epVqS3 4eYNRt440ub75D4QaXWpqP8ARoht8EmKsdCjpkhEIHbxaEiablFizXmgczRurfzefJaY zHLPbvcCYjtcnCnQUd+ADgEZcRIHNZrjL53518daGtLB6NDrV9XNi8ab5/Kmg7WBizOK egSWWtXN9UmDmdu/uHETlYZsUpP5g/rIPVYVi8wWudAApcmJy5zAxn1vKXvoMZ91HADg CH4TGBFnVr2ZxtiL9Dg1jVYUTLNPXugnvf+aOl77pBULkmJm+Zmahy+rlgX5ebxHRGwS xwXA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=q+y9F2HEpHR7lpSOgScZpt3aZTxZ1exfih7MMVF+3Hw=; b=UhjgKpDLIc+Dg5IxBCdPwk869jYhnVbg8b7mDck52sD8SVCADh9Mm9gQvxSV4Rp7/a T95noFtAiK08zmZ3bM/umOgDiDAypRtA09iV1/2X1H7ojezsqnqACFg+ymToBPddgKle VrjcrWHACz28HcqLQojvCdcol6KTTjLwCaG/e6RCCXZvKgAC2pGzd4Vl6APC1A+Hpsmg pLJ7zc7arQ+AsFAgX/72Ut6R6VFN4VUd2D4ZXwW/uD+jeTjEoBLnTJjTlmd+1YHEocH2 xTrH9bnpYvoj9hyhofr9PGm4Piu+Zbquy2VuU0JikHIXUngoFEqO1C4V0RUPr+24x8Co zqtQ== X-Gm-Message-State: AOAM532r8DfwhZK2koHbds1D9WqHPB6AT1nslHQeMncg2qznXeyJdpAh Y49EnHnrTtbVr82HWxtBDkjuVg== X-Google-Smtp-Source: ABdhPJyzjVYRacyR1diWDrgUya8FodDmT9FCiesreDN+9KHyafL2720b1WgbdyuWdfsIk2q8a1ZJlw== X-Received: by 2002:a17:906:441:: with SMTP id e1mr213966eja.396.1602000396693; Tue, 06 Oct 2020 09:06:36 -0700 (PDT) Received: from tsr-vdi-mbaerts.nix.tessares.net (static.23.216.130.94.clients.your-server.de. [94.130.216.23]) by smtp.gmail.com with ESMTPSA id jw9sm2412039ejb.33.2020.10.06.09.06.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 06 Oct 2020 09:06:36 -0700 (PDT) From: Matthieu Baerts To: Mat Martineau , Matthieu Baerts , "David S. Miller" , Jakub Kicinski , Shuah Khan , Paolo Abeni Cc: netdev@vger.kernel.org, mptcp@lists.01.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH net-next] selftests: mptcp: interpret \n as a new line Date: Tue, 6 Oct 2020 18:06:30 +0200 Message-Id: <20201006160631.3987766-1-matthieu.baerts@tessares.net> X-Mailer: git-send-email 2.27.0 MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org In case of errors, this message was printed: (...) balanced bwidth with unbalanced delay 5233 max 5005 [ fail ] client exit code 0, server 0 \nnetns ns3-0-EwnkPH socket stat for 10003: (...) Obviously, the idea was to add a new line before the socket stat and not print "\nnetns". The commit 8b974778f998 ("selftests: mptcp: interpret \n as a new line") is very similar to this one. But the modification in simult_flows.sh was missed because this commit above was done in parallel to one here below. Fixes: 1a418cb8e888 ("mptcp: simult flow self-tests") Signed-off-by: Matthieu Baerts Acked-by: Paolo Abeni --- tools/testing/selftests/net/mptcp/simult_flows.sh | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tools/testing/selftests/net/mptcp/simult_flows.sh b/tools/testing/selftests/net/mptcp/simult_flows.sh index 0d88225daa02..2f649b431456 100755 --- a/tools/testing/selftests/net/mptcp/simult_flows.sh +++ b/tools/testing/selftests/net/mptcp/simult_flows.sh @@ -200,9 +200,9 @@ do_transfer() echo " [ fail ]" echo "client exit code $retc, server $rets" 1>&2 - echo "\nnetns ${ns3} socket stat for $port:" 1>&2 + echo -e "\nnetns ${ns3} socket stat for $port:" 1>&2 ip netns exec ${ns3} ss -nita 1>&2 -o "sport = :$port" - echo "\nnetns ${ns1} socket stat for $port:" 1>&2 + echo -e "\nnetns ${ns1} socket stat for $port:" 1>&2 ip netns exec ${ns1} ss -nita 1>&2 -o "dport = :$port" ls -l $sin $cout ls -l $cin $sout