From patchwork Wed Dec 6 14:19:03 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arnd Bergmann X-Patchwork-Id: 120852 Delivered-To: patch@linaro.org Received: by 10.140.22.227 with SMTP id 90csp7114595qgn; Wed, 6 Dec 2017 06:19:55 -0800 (PST) X-Google-Smtp-Source: AGs4zMZBgMJWYBxtC2BwljSBMDszPcM/4vxros9gWVOhG7fgNACY/I6cADAIaRQUNeBm+i2AUJc+ X-Received: by 10.99.109.73 with SMTP id i70mr21280939pgc.258.1512569995805; Wed, 06 Dec 2017 06:19:55 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1512569995; cv=none; d=google.com; s=arc-20160816; b=iGv8brDJ2gx7C4vYo8yJbeK9UedwH2X67/MM/OfN8hAXQRWXdFsHPujXDlsGe44WlB iM19kN5cVo7XWHVGiNOGZuYy0UNaDY7Ny55Gwtn/+f9HX/pmT/Z6YzUb2KnERuOg8FM6 rSmSh/1iXggd5dN7m3iYk7OZveNYbdm0NZJ0VWbtXmyk5oIyBFuO6vtk1/AuIyxTM8CJ 6p4f39uk6qTHMNfPk2knIEVQfdtuaVJiF5XuNp5AdouzDr1X2HMI4UQ61ycxvRS4hvE9 8v7qHoHaC61XpSNHBiJz+38yZi0bu9zHXwn/H6rbSGV2LDfyR1nc//sr8DYZ+G3B5Z9d MDqw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:date:subject:cc:to:from :arc-authentication-results; bh=0dBxyR26h963dkF4rbW4qA0SNpjm8HJuIPDGS46IMPc=; b=pdtbSDLPOLj8uaQqpHjNF9LM80jL9QTbziXZykVhbGrfN+Xchfv7+G5HUPXghKhv// egaACaxvPmQY9reflxW9uYagEfZE3tm97fkkQm6CKWcE1drVhoqBWfiCo3WIyu+ZzXDr TkTQHwMT8Fm0VBYojyVzNm1A/akXKVhhzrzsg1njmUCbtbz10sfr5R2vrgyYAyFAlTEM DqqIrglyta1qeC/BwFD9MA4UG9wHcDK6ew4CwgOeDc6HEC3/qf/sRe/t8kaHaVCiZN9l Ay4KbYp6URBibI/WtYhcdrH1PuduaE4AvJ7LCLw9xUK2olWWHxQulT4AHtAUV67S71qq iULw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id h70si2157065pfc.186.2017.12.06.06.19.53; Wed, 06 Dec 2017 06:19:55 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752565AbdLFOTv (ORCPT + 28 others); Wed, 6 Dec 2017 09:19:51 -0500 Received: from mout.kundenserver.de ([212.227.126.133]:59290 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752524AbdLFOTt (ORCPT ); Wed, 6 Dec 2017 09:19:49 -0500 Received: from wuerfel.lan ([149.172.96.106]) by mrelayeu.kundenserver.de (mreue001 [212.227.15.129]) with ESMTPA (Nemesis) id 0LzCr3-1f8SBt0isj-014UfW; Wed, 06 Dec 2017 15:19:28 +0100 From: Arnd Bergmann To: Kurt Schwemmer , Logan Gunthorpe , Jon Mason , Dave Jiang , Allen Hubbe Cc: Arnd Bergmann , Stephen Bates , Colin Ian King , Doug Meyer , Kelvin Cao , linux-pci@vger.kernel.org, linux-ntb@googlegroups.com, linux-kernel@vger.kernel.org Subject: [PATCH] ntb_hw_switchtec: fix logic error Date: Wed, 6 Dec 2017 15:19:03 +0100 Message-Id: <20171206141923.817850-1-arnd@arndb.de> X-Mailer: git-send-email 2.9.0 X-Provags-ID: V03:K0:/oPS/8y23KJZ24Fq+4fXaMtW0dTp9sdN/shapwXSkAzv5ZkDyL2 +CMqnV+9Cn8fVO9jzttPvQYz2i9y2loBhXK6029+W9nZ987w9mGzhxjdbZEgcHqDpeRl3s8 H28KBpKE2Y+1Na8uIPXbFidEO6IUFFspXuZorD0Q+dh/WSWuAgLD3MvPT1Dl8K5eqwO4i01 5lGsFcJsCzOM+V0YgaAvg== X-UI-Out-Filterresults: notjunk:1; V01:K0:M/RK+iP46mE=:QzW8u9kdCKwgvJozIsbmjf upBGCaWoBpxot54qDwIfSHZojRHvShOVSxFbT4Fp2Za9psn/B+RkFwxzicUahnQE6GNjr0S7i E50oXRZitj+yA2hsHMF/lFGYVBUQfeE1b/v0tKuuF85ZN6jUKr1r8KkYRM2/CybYZz05xKBWf JBB/wexuON4ORAY3fEWKCEFSEkC0frPQ9thltod0DYO2i8w7Zd8T1qJQOgx8Czcx41vtHBWmY aUeFVbENihyH9OTm7aOPlKkp/lSqwUpJ+XZbBDhF37TKkuBxRHoOnCnSyo1Q4A0JtrN9GCn06 NXZ6huGampaYHmoR0S03GzdJyKIavzv57QKGY2REohrzyFqKWP+bHHesCpJn4sFK7HwPi6YmX 5ZbtxSnPt2CzwCc6lNaOhPZkuLM2PD9Ct50XEZ8xGw8p5ejjdeQgq4VBh9kUhrTYPFI97SRqp PBn6HxxyC+PAahNpnWHQOTrMPmxtWsRBh9TvxneM/+JxV0WMX+LcqM75oICP/OTaQgJCOyq/e USt9Nj3veFgLkEAxO6ZCrgMbhIRsAlk0o54O34PKR2CZwkkIWVsKCP0wpGuWcqhc5yNVs2RvI cAP2goeW3f7oHSeCkygQe4I5R32iuyT31UoC7xeHyYuPF+9OoK0y5himWN2LP1zus9NyqQjqw nLghjc4Ns+xXghKCfT0AUAyixxYSRBRY7yvu4zE72rdKGrIIAPRkIxoG4CYYY/YWwc61x8SwH T/4f8QW+qnbwnpyQBsUcT5vLE3Akt1OA87wq3A== Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Newer gcc (version 7 and 8 presumably) warn about a statement mixing the << operator with logical and: drivers/ntb/hw/mscc/ntb_hw_switchtec.c: In function 'switchtec_ntb_init_sndev': drivers/ntb/hw/mscc/ntb_hw_switchtec.c:888:24: error: '<<' in boolean context, did you mean '<' ? [-Werror=int-in-bool-context] My interpretation here is that the author must have intended a bitmask rather than a comparison, so I'm changing the '&&' to '&', which makes a lot more sense in the context. Fixes: 1b249475275d ("ntb_hw_switchtec: Allow using Switchtec NTB in multi-partition setups") Signed-off-by: Arnd Bergmann --- drivers/ntb/hw/mscc/ntb_hw_switchtec.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.9.0 Reviewed-by: Logan Gunthorpe diff --git a/drivers/ntb/hw/mscc/ntb_hw_switchtec.c b/drivers/ntb/hw/mscc/ntb_hw_switchtec.c index bcd5b6fb3800..76acb8bba3f2 100644 --- a/drivers/ntb/hw/mscc/ntb_hw_switchtec.c +++ b/drivers/ntb/hw/mscc/ntb_hw_switchtec.c @@ -885,7 +885,7 @@ static int switchtec_ntb_init_sndev(struct switchtec_ntb *sndev) } sndev->peer_partition = ffs(tpart_vec) - 1; - if (!(part_map && (1 << sndev->peer_partition))) { + if (!(part_map & (1 << sndev->peer_partition))) { dev_err(&sndev->stdev->dev, "ntb target partition is not NT partition\n"); return -ENODEV;