From patchwork Mon Dec 4 13:33:08 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ard Biesheuvel X-Patchwork-Id: 120535 Delivered-To: patch@linaro.org Received: by 10.140.22.227 with SMTP id 90csp4438582qgn; Mon, 4 Dec 2017 05:33:20 -0800 (PST) X-Google-Smtp-Source: AGs4zMax9kLGvK1Z220HsTdTqZg9ElYOJUunTOJv+hac9qmABLmStHtsqWKNmrXoxAFPmLPgK193 X-Received: by 10.101.73.74 with SMTP id q10mr13911092pgs.127.1512394400415; Mon, 04 Dec 2017 05:33:20 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1512394400; cv=none; d=google.com; s=arc-20160816; b=YTioUanSvq0n4zSxVnapH0qwbYURjm9GVAA3ydEZa/5ylV62Rtsf8yzf4vSkiALv4N h8ecKbS0o/BWLD+DoX0vbU9cVHG0Zxr/gIbswCKY0ppXOQlNNX4OXag3jwL9gr19ZNop gdFNXJ1LvxNaOE7leJbQc6B7RNIOmUc4qiVTDr8xHECy8j0G+6fqsXkSdg42YXfn7J/9 QX+ISlrxOwK1/eSl/Xaoj4h3CXARO1NpRz6jqJBkKLHcEdoEM5UuNDtajvtHzI0aHbNo joTORFNpo++Ie+fSSKb81Qq9oD5ATbZcEsAWJdSk9Zmc+VlvPC+9sIgzig6nARAafB+1 +31Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:mime-version:cc :list-subscribe:list-help:list-post:list-archive:list-unsubscribe :list-id:precedence:subject:message-id:date:to:from:dkim-signature :delivered-to:arc-authentication-results; bh=udJGa355xc7xjjGmnukScjEs0Hv0dKCHb6mxccCaEQY=; b=Crs+cD8CIHI/qaxFtWItOCqPtBSbjXI72udUFrXK2G/fnZrV1oUpN8B0PFBWlhHkoP TiLZbbJ9Qlb5YaFs/D16IU+g/20yTg7fHqphzeOu2/53eOBgYeLBjp5CedvNzG249Qkp 0xzd5/0qJZIn91yZyCNqe0E5LAiA4c9CLWOxTds9vvps7wNoTyi4YTwx2Fi2gHmGdFO3 st26l+bZqo8pgXEZvf7ak1MWKVuf5o6gxEU/eYnzQBf4RoQJCIFrpIj6uAnGll9+zWWQ V7ZIKd9SxeNkHijT+QCGi42sbckDRF7BUyQHBeVlbjB3sA5EK/qEB1Z0Kp1vNzBi/+ZG PAgA== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=SiSLWH50; spf=pass (google.com: best guess record for domain of edk2-devel-bounces@lists.01.org designates 2001:19d0:306:5::1 as permitted sender) smtp.mailfrom=edk2-devel-bounces@lists.01.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from ml01.01.org (ml01.01.org. [2001:19d0:306:5::1]) by mx.google.com with ESMTPS id l3si9428819pgr.804.2017.12.04.05.33.20 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 04 Dec 2017 05:33:20 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of edk2-devel-bounces@lists.01.org designates 2001:19d0:306:5::1 as permitted sender) client-ip=2001:19d0:306:5::1; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=SiSLWH50; spf=pass (google.com: best guess record for domain of edk2-devel-bounces@lists.01.org designates 2001:19d0:306:5::1 as permitted sender) smtp.mailfrom=edk2-devel-bounces@lists.01.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from [127.0.0.1] (localhost [IPv6:::1]) by ml01.01.org (Postfix) with ESMTP id 1EC5B22152386; Mon, 4 Dec 2017 05:28:50 -0800 (PST) X-Original-To: edk2-devel@lists.01.org Delivered-To: edk2-devel@lists.01.org Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2a00:1450:400c:c09::244; helo=mail-wm0-x244.google.com; envelope-from=ard.biesheuvel@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-wm0-x244.google.com (mail-wm0-x244.google.com [IPv6:2a00:1450:400c:c09::244]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 1BE9922152383 for ; Mon, 4 Dec 2017 05:28:49 -0800 (PST) Received: by mail-wm0-x244.google.com with SMTP id b76so14355688wmg.1 for ; Mon, 04 Dec 2017 05:33:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id; bh=wKxr3nC8mi21t8tig/07551kVTS5zKdWr4uktZN30+M=; b=SiSLWH50JOcUT2l6U6VYF9WIZsF6NC3aFRrHFZZpHVFVLQkqcbpVN8zDzwDlyRfLYg afoR8FLL9nHJW2mL0u0IvaPYcj9JBlyGqHcGV4LtZ4QpnKhus0ijy14eBg1J77TSJs6z bh8G41sEvGUTkULbJcoNm5Pn+SpaPgQ/l8oec= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=wKxr3nC8mi21t8tig/07551kVTS5zKdWr4uktZN30+M=; b=KyPV6KKebtqMf4ZpwqNq/Cj36Nwa5reQch25tTHrSg1Th6gehytG/lHmR6egsQELmn GDe0gr7Awea7inBB5GZT0rjqzo6STLcziz1Do4qRyvRt9jm6vf1lx1UTal+p2ULTB4uv i448QyS2gCJcgDujtFoGeTMA+O3eD5nFS9ooRITBXA7S/6uipLgnpJ8LENaW7a5VL7yN ABgptjALJKCLUgdgVtrHcWUEoF2BA7x3vSNyn24iTQ0srwGjf4eVLAdFWHwDRF4endWr kqbKwYSI4ZisU3yZjeLi0ns+SLL5G43BhF9x67+Qb96Vf7qoq7kysVbUgJ+FO60xVDlA cgZw== X-Gm-Message-State: AKGB3mIjgsWluwd94xHmgYLOG6gn2AswM+ZQcv2s3I414YYn0pSoy0iq ChWV9Ho/a4DslAsCXu97aCpTs85n8lo= X-Received: by 10.28.15.201 with SMTP id 192mr2839031wmp.97.1512394397267; Mon, 04 Dec 2017 05:33:17 -0800 (PST) Received: from localhost.localdomain ([105.150.171.234]) by smtp.gmail.com with ESMTPSA id w76sm20549854wrc.79.2017.12.04.05.33.15 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 04 Dec 2017 05:33:16 -0800 (PST) From: Ard Biesheuvel To: edk2-devel@lists.01.org Date: Mon, 4 Dec 2017 13:33:08 +0000 Message-Id: <20171204133308.32012-1-ard.biesheuvel@linaro.org> X-Mailer: git-send-email 2.11.0 Subject: [edk2] [PATCH edk2-platforms] Silicon/SynQuacerI2CDxe: add missing __FUNCTION__ argument to %a specifier X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: masahisa.kojima@Linaro.org, daniel.thompson@linaro.org, masami.hiramatsu@linaro.org, leif.lindholm@linaro.org, Ard Biesheuvel MIME-Version: 1.0 Errors-To: edk2-devel-bounces@lists.01.org Sender: "edk2-devel" The I2C driver prints a warning under DEBUG when a I2C transaction times out. This will occur on the rev 0.1 DeveloperBox boards due to a board level error in the I2C routing (unless the MCU has been lifted off the bus). Currently, this will trigger a crash due to a missing __FUNCTION__ argument to a %a specifier in a DEBUG string, because instead, the code will attempt to dereference a EFI_STATUS variable as a char pointer. So add the missing __FUNCTION__ argument. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Ard Biesheuvel --- Silicon/Socionext/SynQuacer/Drivers/SynQuacerI2cDxe/SynQuacerI2cDxe.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.11.0 _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel Reviewed-by: Leif Lindholm diff --git a/Silicon/Socionext/SynQuacer/Drivers/SynQuacerI2cDxe/SynQuacerI2cDxe.c b/Silicon/Socionext/SynQuacer/Drivers/SynQuacerI2cDxe/SynQuacerI2cDxe.c index fb404b17f93c..c3703dfb6c33 100644 --- a/Silicon/Socionext/SynQuacer/Drivers/SynQuacerI2cDxe/SynQuacerI2cDxe.c +++ b/Silicon/Socionext/SynQuacer/Drivers/SynQuacerI2cDxe/SynQuacerI2cDxe.c @@ -330,7 +330,7 @@ SynQuacerI2cStartRequest ( Status = WaitForInterrupt (I2c); if (EFI_ERROR (Status)) { BOOTTIME_DEBUG ((DEBUG_WARN, "%a: Timeout waiting for interrupt - %r\n", - Status)); + __FUNCTION__, Status)); break; }