From patchwork Mon Oct 19 18:10:59 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Randy Dunlap X-Patchwork-Id: 288313 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0E9B7C43457 for ; Mon, 19 Oct 2020 18:11:14 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 96ECD2225F for ; Mon, 19 Oct 2020 18:11:13 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="Wj/6tvk0" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730428AbgJSSLL (ORCPT ); Mon, 19 Oct 2020 14:11:11 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48418 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729556AbgJSSLL (ORCPT ); Mon, 19 Oct 2020 14:11:11 -0400 Received: from merlin.infradead.org (merlin.infradead.org [IPv6:2001:8b0:10b:1231::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AF194C0613CE; Mon, 19 Oct 2020 11:11:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=merlin.20170209; h=Content-Transfer-Encoding:MIME-Version: Message-Id:Date:Subject:Cc:To:From:Sender:Reply-To:Content-Type:Content-ID: Content-Description:In-Reply-To:References; bh=xiyanDep+kM10bm251knyIvRDseYDKXVsobmd7uBQ64=; b=Wj/6tvk0GUjQsZaURi1lej23zE JQzUi5xMTS5dvzUyFmFSNp0CDaLuqHdPYrB9JiHDrlKyLmAVsNHYtTH6NbNW03WD667aovUckVMaT 4U0aelY4FO4hm7BTEAfcfEpvIc35Jp1xDnzr5cvf/LNoTvVEmKtTIhlbEoOYYW9Vtm3d2W2AP8JwC xxw97Hy3PrCSF6fTGG2/4W0cSFueccxe+/49WRIECayRIlmca77JH0iTSbl+7qw9/lIIuQa0Xey04 ErC6H31dm2cYSWbCv6B6mc2ZXOQ5HPV56r9QYZDnqp1jgpHy40alrWmH7YNk26GJ8EhxzDOo1Lrc1 ItY9NyZw==; Received: from [2601:1c0:6280:3f0::507c] (helo=smtpauth.infradead.org) by merlin.infradead.org with esmtpsa (Exim 4.92.3 #3 (Red Hat Linux)) id 1kUZce-0000jK-JZ; Mon, 19 Oct 2020 18:11:05 +0000 From: Randy Dunlap To: linux-kernel@vger.kernel.org Cc: Randy Dunlap , kernel test robot , Vinay Kumar Yadav , netdev@vger.kernel.org, Ayush Sawal , Rohit Maheshwari , "David S. Miller" , Jakub Kicinski Subject: [PATCH] net: chelsio: inline_crypto: fix Kconfig and build errors Date: Mon, 19 Oct 2020 11:10:59 -0700 Message-Id: <20201019181059.22634-1-rdunlap@infradead.org> X-Mailer: git-send-email 2.26.2 MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Fix build errors when TLS=m, TLS_TOE=y, and CRYPTO_DEV_CHELSIO_TLS=y. Having (tristate) CRYPTO_DEV_CHELSIO_TLS depend on (bool) TLS_TOE is not strong enough to prevent the bad combination of TLS=m and CRYPTO_DEV_CHELSIO_TLS=y, so add a dependency on TLS to prevent the problematic kconfig combination. Fixes these build errors: hppa-linux-ld: drivers/net/ethernet/chelsio/inline_crypto/chtls/chtls_main.o: in function `chtls_free_uld': drivers/net/ethernet/chelsio/inline_crypto/chtls/chtls_main.c:165: undefined reference to `tls_toe_unregister_device' hppa-linux-ld: drivers/net/ethernet/chelsio/inline_crypto/chtls/chtls_main.o: in function `chtls_register_dev': drivers/net/ethernet/chelsio/inline_crypto/chtls/chtls_main.c:204: undefined reference to `tls_toe_register_device' Fixes: 44fd1c1fd821 ("chelsio/chtls: separate chelsio tls driver from crypto driver") Reported-by: kernel test robot Signed-off-by: Randy Dunlap Cc: Vinay Kumar Yadav Cc: netdev@vger.kernel.org Cc: Ayush Sawal Cc: Rohit Maheshwari Cc: "David S. Miller" Cc: Jakub Kicinski --- drivers/net/ethernet/chelsio/inline_crypto/Kconfig | 1 + 1 file changed, 1 insertion(+) --- linux-next-20201016.orig/drivers/net/ethernet/chelsio/inline_crypto/Kconfig +++ linux-next-20201016/drivers/net/ethernet/chelsio/inline_crypto/Kconfig @@ -16,6 +16,7 @@ if CHELSIO_INLINE_CRYPTO config CRYPTO_DEV_CHELSIO_TLS tristate "Chelsio Crypto Inline TLS Driver" depends on CHELSIO_T4 + depends on TLS depends on TLS_TOE help Support Chelsio Inline TLS with Chelsio crypto accelerator.