From patchwork Mon Oct 26 08:09:18 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Chunyan Zhang X-Patchwork-Id: 287713 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.6 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH, MAILING_LIST_MULTI, SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 12814C388F9 for ; Mon, 26 Oct 2020 08:09:52 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B4419223B0 for ; Mon, 26 Oct 2020 08:09:51 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="o/S0pKmc" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1771223AbgJZIJu (ORCPT ); Mon, 26 Oct 2020 04:09:50 -0400 Received: from mail-pf1-f169.google.com ([209.85.210.169]:45390 "EHLO mail-pf1-f169.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1771221AbgJZIJu (ORCPT ); Mon, 26 Oct 2020 04:09:50 -0400 Received: by mail-pf1-f169.google.com with SMTP id e7so5747729pfn.12; Mon, 26 Oct 2020 01:09:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=PyCGWsOQRaRBz3bX2fA1LoPk8Xi0fdZXGJLF+2HpK0Q=; b=o/S0pKmc5aE/Z6ROq/vvk5oQat8R9FKogg7pijW9KwyM17j85pEcgg4NhV4yPjfC1h F8M23asWC52BxJt5ZYgVPmua8mBtFq2ImfdpbpCNH2Q5mWyti8OyuAyRY+DeTJcgXErx RpCsKNNvBx+V/Jb8V7XhFQ9OvwGjgzzAHtx+xbb1bYffJ794RepW0JYNFBHuNyEM/erH fH4AGcMQW3N6DEsRdQQwBfB6zZjF/agTAT5rNMg15YxM9B5NqKQ2RaaYgSaqEe4qazuv HAlwEYY4aCN9RrA3hgr7ApUpWWYvEVI5R2cr4Dn2+rEznyoS4OWbM5+00l75M7wIA2O3 O8ZA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=PyCGWsOQRaRBz3bX2fA1LoPk8Xi0fdZXGJLF+2HpK0Q=; b=Z30cwunLFr8S3QGR82uT60U3MiR+HP4AbC4RBagUU0C6cMPXdnBv32fh4A2SXceHUh qCJtQmz/fdx1+8HxfkqmzNQVnI6283jRc/je/bWDGU+KNOMGwcwfbfOUjbILscZ4alpI AXgDhGrIAI5Fs6UzQv3iu0HTd15MHM7ub7d0zZ9cdQLNayzQAN93l8jtRkkg2nENeGro qALx68P0v1sOMLNajXGYyouryetdGv8Avjsje+d4qemoj5i0YZzNQuuknBUm2sgOhRXQ W5tmF/LOMBkbL5lXJDp2yBFllY3bD21T5zs4pHW4fIhsajYUXsS/HmuDAOhs69ePyHXp NXoQ== X-Gm-Message-State: AOAM533H7YpXoEipTVgnTHFyoJth8oNNnJIZjOwGIzxZexQXWSKXQLRp MdzwuzheBviXrIa4ZTEqGbhUJMzzoTo= X-Google-Smtp-Source: ABdhPJyfaU8JVwHNQPjVpv/HCZHqRuDrcijxAXpih76vx/00Q8i2TFcQ8iGZd7p9YWmDG+1kRsW+Kw== X-Received: by 2002:a05:6a00:23c6:b029:158:1257:de73 with SMTP id g6-20020a056a0023c6b02901581257de73mr12496047pfc.10.1603699789347; Mon, 26 Oct 2020 01:09:49 -0700 (PDT) Received: from ubt.spreadtrum.com ([117.18.48.82]) by smtp.gmail.com with ESMTPSA id j2sm542825pgi.48.2020.10.26.01.09.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 26 Oct 2020 01:09:48 -0700 (PDT) From: Chunyan Zhang To: Wim Van Sebroeck , Guenter Roeck Cc: linux-watchdog@vger.kernel.org, linux-kernel@vger.kernel.org, Orson Zhai , Baolin Wang , Chunyan Zhang , Chunyan Zhang Subject: [PATCH 2/3] watchdog: sprd: change timeout value from 1000 to 2000 Date: Mon, 26 Oct 2020 16:09:18 +0800 Message-Id: <20201026080919.28413-3-zhang.lyra@gmail.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20201026080919.28413-1-zhang.lyra@gmail.com> References: <20201026080919.28413-1-zhang.lyra@gmail.com> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-watchdog@vger.kernel.org From: Lingling Xu Because cpu_relax() takes different time on different SoCs, for some rare cases, it would take more than 1000 cycles for waitting load operation finished. The result of many times testing verified that changing the timeout value to 2000 can solve the issue. Fixes: 477603467009 ("watchdog: Add Spreadtrum watchdog driver") Signed-off-by: Lingling Xu Signed-off-by: Chunyan Zhang --- drivers/watchdog/sprd_wdt.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/watchdog/sprd_wdt.c b/drivers/watchdog/sprd_wdt.c index f3c90b4afead..4f2a8c6d6485 100644 --- a/drivers/watchdog/sprd_wdt.c +++ b/drivers/watchdog/sprd_wdt.c @@ -53,7 +53,7 @@ #define SPRD_WDT_CNT_HIGH_SHIFT 16 #define SPRD_WDT_LOW_VALUE_MASK GENMASK(15, 0) -#define SPRD_WDT_LOAD_TIMEOUT 1000 +#define SPRD_WDT_LOAD_TIMEOUT 2000 struct sprd_wdt { void __iomem *base;