From patchwork Tue Nov 21 14:00:05 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Github ODP bot X-Patchwork-Id: 119364 Delivered-To: patch@linaro.org Received: by 10.80.225.132 with SMTP id k4csp5135270edl; Tue, 21 Nov 2017 06:04:49 -0800 (PST) X-Google-Smtp-Source: AGs4zMYrbwnk8tQh7/TxBjV+vvSz9Z9duJ8iWkJg9Dsto9d5xy603ZQPjmtHkRs6HFxlzRvzxYIJ X-Received: by 10.55.21.39 with SMTP id f39mr27047001qkh.263.1511273088783; Tue, 21 Nov 2017 06:04:48 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1511273088; cv=none; d=google.com; s=arc-20160816; b=yL1axTY2QeuhVQdfUEubnEi2wHJo8hEgTRsNwhF7fkMtFh6UFEdSGAHeHKMyhKmtkk /sYM/YZtRGOV45CpI088kGWEpPvhRyqEE0mprx604/h0QVPKzRoCJe/ZX4DW1jZeAZG4 SKvbwpoWnnoO7ppHaDohuqwFUm976ZxoWeQacp4GD12fG9DYil5LKPG9dS1tpsat8ifo oljmseWf+sGPGa/8PMwRnPBrRyX2te4KMSVBevgAvDj0hQ0MMKdsE3oO711ZzyBusTNg GuI74cjZoa6RYOOQHxMQHcRQEgvPAzWYh4eeu8ZXNKICniAcBd8r1XeUppbhDOJe0aNe q/Eg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:subject:github-pr-num :references:in-reply-to:message-id:date:to:from:delivered-to :arc-authentication-results; bh=Pko/aOrxpubNXcNxYM0PGa8kq2JX5ps6WwwhB20quw0=; b=T2gC4oVEfphHyrY3Yt/nNkx2TcB8GNcXInbpB9mqDcyTvhoO4bCJcyhry/hXveQkks ohx80qV9y+QJcYW4D89dEBEzWCriBATI3gZcOGgNQ2j8MJzj13dBMu+q8X31/1WBST08 MwwLR6/Zp1PQxazxP3IubowxReeXTIUQ+cokNgfrSl0KeO2xsLLlavbnF5LVUJcU7xfm xOHwL9mJLfBtcbLn10odxwt5eHQIKuf6AVOoWOMIQxxJCK+lcblpd5NRHVLDmQb/TYku LHzbwvdJb3f50r+HdgVQxfecqnq0J8j/YCNwsfmwddHebfHqE5UdFjpLsb/Gwd1bFTId zEHA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of lng-odp-bounces@lists.linaro.org designates 54.197.127.237 as permitted sender) smtp.mailfrom=lng-odp-bounces@lists.linaro.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=yandex.ru Return-Path: Received: from lists.linaro.org (ec2-54-197-127-237.compute-1.amazonaws.com. [54.197.127.237]) by mx.google.com with ESMTP id k11si7475468qti.287.2017.11.21.06.04.48; Tue, 21 Nov 2017 06:04:48 -0800 (PST) Received-SPF: pass (google.com: domain of lng-odp-bounces@lists.linaro.org designates 54.197.127.237 as permitted sender) client-ip=54.197.127.237; Authentication-Results: mx.google.com; spf=pass (google.com: domain of lng-odp-bounces@lists.linaro.org designates 54.197.127.237 as permitted sender) smtp.mailfrom=lng-odp-bounces@lists.linaro.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=yandex.ru Received: by lists.linaro.org (Postfix, from userid 109) id 2E0EE60862; Tue, 21 Nov 2017 14:04:48 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on ip-10-142-244-252 X-Spam-Level: X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00,FREEMAIL_FROM, RCVD_IN_DNSWL_LOW,URIBL_BLOCKED autolearn=disabled version=3.4.0 Received: from [127.0.0.1] (localhost [127.0.0.1]) by lists.linaro.org (Postfix) with ESMTP id 4517F608EE; Tue, 21 Nov 2017 14:01:28 +0000 (UTC) X-Original-To: lng-odp@lists.linaro.org Delivered-To: lng-odp@lists.linaro.org Received: by lists.linaro.org (Postfix, from userid 109) id 780E660879; Tue, 21 Nov 2017 14:01:09 +0000 (UTC) Received: from forward101j.mail.yandex.net (forward101j.mail.yandex.net [5.45.198.241]) by lists.linaro.org (Postfix) with ESMTPS id 4D1D160888 for ; Tue, 21 Nov 2017 14:00:25 +0000 (UTC) Received: from mxback19j.mail.yandex.net (mxback19j.mail.yandex.net [IPv6:2a02:6b8:0:1619::95]) by forward101j.mail.yandex.net (Yandex) with ESMTP id BDC4D1244E2E for ; Tue, 21 Nov 2017 17:00:23 +0300 (MSK) Received: from smtp3p.mail.yandex.net (smtp3p.mail.yandex.net [2a02:6b8:0:1472:2741:0:8b6:8]) by mxback19j.mail.yandex.net (nwsmtp/Yandex) with ESMTP id u7CNlqYhNI-0N1WgHV5; Tue, 21 Nov 2017 17:00:23 +0300 Received: by smtp3p.mail.yandex.net (nwsmtp/Yandex) with ESMTPSA id SmkHtcb890-0N80e0wY; Tue, 21 Nov 2017 17:00:23 +0300 (using TLSv1.2 with cipher ECDHE-RSA-AES128-SHA256 (128/128 bits)) (Client certificate not present) From: Github ODP bot To: lng-odp@lists.linaro.org Date: Tue, 21 Nov 2017 17:00:05 +0300 Message-Id: <1511272816-6367-2-git-send-email-odpbot@yandex.ru> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1511272816-6367-1-git-send-email-odpbot@yandex.ru> References: <1511272816-6367-1-git-send-email-odpbot@yandex.ru> Github-pr-num: 301 Subject: [lng-odp] [PATCH API-NEXT v2 1/12] doxygen: remove drv types X-BeenThere: lng-odp@lists.linaro.org X-Mailman-Version: 2.1.16 Precedence: list List-Id: "The OpenDataPlane \(ODP\) List" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: lng-odp-bounces@lists.linaro.org Sender: "lng-odp" From: Maxim Uvarov Signed-off-by: Maxim Uvarov --- /** Email created from pull request 301 (muvarov:api-next) ** https://github.com/Linaro/odp/pull/301 ** Patch: https://github.com/Linaro/odp/pull/301.patch ** Base sha: d4b364849c4abb4c71e0c5260e1a793ebb8dc97d ** Merge commit sha: 36cef9760e8883bbd6641af08c7d0ecdac085e79 **/ doc/Doxyfile_common | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/doc/Doxyfile_common b/doc/Doxyfile_common index 0471dcf3c..779442d00 100644 --- a/doc/Doxyfile_common +++ b/doc/Doxyfile_common @@ -33,12 +33,9 @@ DOT_IMAGE_FORMAT = svg PREDEFINED = __GNUC__ \ __attribute__(x)= \ ODP_ALIGNED(x)= \ - ODPDRV_ALIGNED(x)= \ __BIG_ENDIAN_BITFIELD \ __LITTLE_ENDIAN_BITFIELD \ __x86_64__ \ ODP_PACKED \ - ODPDRV_PACKED \ ODP_DEPRECATE(x)=x \ - "ODP_HANDLE_T(type)=odp_handle_t type" \ - "ODPDRV_HANDLE_T(type)=odpdrv_handle_t type" + "ODP_HANDLE_T(type)=odp_handle_t type" From patchwork Tue Nov 21 14:00:06 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Github ODP bot X-Patchwork-Id: 119366 Delivered-To: patch@linaro.org Received: by 10.140.22.164 with SMTP id 33csp5311276qgn; Tue, 21 Nov 2017 06:07:24 -0800 (PST) X-Google-Smtp-Source: AGs4zMYQE2Yc1w3zG1dNqhBCzG1pCaI9lSgn9cKCG5QCXF9Mwq7NRRemPoI8k8eZFfusIDik6Hmn X-Received: by 10.237.37.47 with SMTP id v44mr28439940qtc.55.1511273244102; Tue, 21 Nov 2017 06:07:24 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1511273244; cv=none; d=google.com; s=arc-20160816; b=B9/FQWv/7lrflwBN6w2rM8Rmw8vxLEJ5A8nY3R7eA6TNsoJftcyl4JGQSjaYegZxmR 9h06ICOEota8pme+gKBEYLkFIDHTdvtcBDOSYDnp6VSy25/62HmgeT0C4hsiiIAEqZkS YUXsS6lDqaE6zpEXso0rBwWxTsKPGehMB5psgWL4F4zv6UbcLClJPZ2HXMpKVeRA584a Jr9SmG0hWgzVJu31NT7RHPqAOLpoawxknJ/3s/H8Tq0pFgyXwvh9sauExU22prKvl9vS TPrtXyOV4Iv4hnLZ0U3Uu9oHOaEF5NQZ0ATIb4c8hGJ+Sm/W1klEl1JhciZi1kcExx3L TDWQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:subject:github-pr-num :references:in-reply-to:message-id:date:to:from:delivered-to :arc-authentication-results; bh=G+g4nGfJ8BFBFX5Mtn+xrhXtJpPUh8qdgSjYmRwMOjk=; b=QWt/8ImtAjs37ZxECgp2xiXn1S+HT8F3I+vzmhDGGeTGYSjpJrd0SvSLqc7yf+gKbg KLHO2B5P1Ym9wAXM1P22yOl24ktCqNbq1bHq7wXAx1g7DTQS7lzWhIX+YADT9WbtRcgP /JWFIZqHOXIPhUh5Q7jFemsh2p8PP4MMXIZpq4GkDN1eW0baVf8Ywn2ePPxlyO3O0+IK WtDc8N596/nL7RNdEybLl8rA1zyC01RndP5JHeqX1p4m+W++zphXkH0vaavYzJbHFs/C CK1dPnpnqpx6Lq4N1xkYAs8+DlINTsxhhZydSm29/cCsNmJO+YNcxu93nsAvDucEQbTy 5SOw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of lng-odp-bounces@lists.linaro.org designates 54.197.127.237 as permitted sender) smtp.mailfrom=lng-odp-bounces@lists.linaro.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=yandex.ru Return-Path: Received: from lists.linaro.org (ec2-54-197-127-237.compute-1.amazonaws.com. [54.197.127.237]) by mx.google.com with ESMTP id b20si3007316qta.182.2017.11.21.06.07.23; Tue, 21 Nov 2017 06:07:24 -0800 (PST) Received-SPF: pass (google.com: domain of lng-odp-bounces@lists.linaro.org designates 54.197.127.237 as permitted sender) client-ip=54.197.127.237; Authentication-Results: mx.google.com; spf=pass (google.com: domain of lng-odp-bounces@lists.linaro.org designates 54.197.127.237 as permitted sender) smtp.mailfrom=lng-odp-bounces@lists.linaro.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=yandex.ru Received: by lists.linaro.org (Postfix, from userid 109) id BE2EC608EE; Tue, 21 Nov 2017 14:07:23 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on ip-10-142-244-252 X-Spam-Level: X-Spam-Status: No, score=-5.4 required=5.0 tests=BAYES_00,FREEMAIL_FROM, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H2, URIBL_BLOCKED autolearn=disabled version=3.4.0 Received: from [127.0.0.1] (localhost [127.0.0.1]) by lists.linaro.org (Postfix) with ESMTP id 161FC60940; Tue, 21 Nov 2017 14:01:50 +0000 (UTC) X-Original-To: lng-odp@lists.linaro.org Delivered-To: lng-odp@lists.linaro.org Received: by lists.linaro.org (Postfix, from userid 109) id E02F260879; Tue, 21 Nov 2017 14:01:10 +0000 (UTC) Received: from forward106p.mail.yandex.net (forward106p.mail.yandex.net [77.88.28.109]) by lists.linaro.org (Postfix) with ESMTPS id 5417F6088C for ; Tue, 21 Nov 2017 14:00:25 +0000 (UTC) Received: from mxback8j.mail.yandex.net (mxback8j.mail.yandex.net [IPv6:2a02:6b8:0:1619::111]) by forward106p.mail.yandex.net (Yandex) with ESMTP id 531012D83B5B for ; Tue, 21 Nov 2017 17:00:24 +0300 (MSK) Received: from smtp3p.mail.yandex.net (smtp3p.mail.yandex.net [2a02:6b8:0:1472:2741:0:8b6:8]) by mxback8j.mail.yandex.net (nwsmtp/Yandex) with ESMTP id r4uxQjMnzO-0O9GVuRO; Tue, 21 Nov 2017 17:00:24 +0300 Received: by smtp3p.mail.yandex.net (nwsmtp/Yandex) with ESMTPSA id SmkHtcb890-0N845NdO; Tue, 21 Nov 2017 17:00:23 +0300 (using TLSv1.2 with cipher ECDHE-RSA-AES128-SHA256 (128/128 bits)) (Client certificate not present) From: Github ODP bot To: lng-odp@lists.linaro.org Date: Tue, 21 Nov 2017 17:00:06 +0300 Message-Id: <1511272816-6367-3-git-send-email-odpbot@yandex.ru> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1511272816-6367-1-git-send-email-odpbot@yandex.ru> References: <1511272816-6367-1-git-send-email-odpbot@yandex.ru> Github-pr-num: 301 Subject: [lng-odp] [PATCH API-NEXT v2 2/12] linux-gen: crypto: drop DES-CBC support X-BeenThere: lng-odp@lists.linaro.org X-Mailman-Version: 2.1.16 Precedence: list List-Id: "The OpenDataPlane \(ODP\) List" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: lng-odp-bounces@lists.linaro.org Sender: "lng-odp" From: Dmitry Eremin-Solenikov DES-CBC (not 3DES-CBC) support is invalid (DES should use 8 bytes key, not 24 bytes), it is not covered by testsuite and DES is cracable/deprecated/etc since long ago. Stop providing single-key DES support. In case one really needs it, it can be emulated through supplying same key triple times to 3DES-CBC. Signed-off-by: Dmitry Eremin-Solenikov Reviewed-by: Bill Fischofer Signed-off-by: Maxim Uvarov --- /** Email created from pull request 301 (muvarov:api-next) ** https://github.com/Linaro/odp/pull/301 ** Patch: https://github.com/Linaro/odp/pull/301.patch ** Base sha: d4b364849c4abb4c71e0c5260e1a793ebb8dc97d ** Merge commit sha: 36cef9760e8883bbd6641af08c7d0ecdac085e79 **/ platform/linux-generic/odp_crypto.c | 10 ---------- 1 file changed, 10 deletions(-) diff --git a/platform/linux-generic/odp_crypto.c b/platform/linux-generic/odp_crypto.c index 9cf903d03..4c708931a 100644 --- a/platform/linux-generic/odp_crypto.c +++ b/platform/linux-generic/odp_crypto.c @@ -25,7 +25,6 @@ #include #include -#include #include #include #include @@ -40,9 +39,6 @@ static const odp_crypto_cipher_capability_t cipher_capa_null[] = { {.key_len = 0, .iv_len = 0} }; -static const odp_crypto_cipher_capability_t cipher_capa_des[] = { -{.key_len = 24, .iv_len = 8} }; - static const odp_crypto_cipher_capability_t cipher_capa_trides_cbc[] = { {.key_len = 24, .iv_len = 8} }; @@ -582,7 +578,6 @@ int odp_crypto_capability(odp_crypto_capability_t *capa) memset(capa, 0, sizeof(odp_crypto_capability_t)); capa->ciphers.bit.null = 1; - capa->ciphers.bit.des = 1; capa->ciphers.bit.trides_cbc = 1; capa->ciphers.bit.aes_cbc = 1; capa->ciphers.bit.aes_gcm = 1; @@ -620,10 +615,6 @@ int odp_crypto_cipher_capability(odp_cipher_alg_t cipher, src = cipher_capa_null; num = sizeof(cipher_capa_null) / size; break; - case ODP_CIPHER_ALG_DES: - src = cipher_capa_des; - num = sizeof(cipher_capa_des) / size; - break; case ODP_CIPHER_ALG_3DES_CBC: src = cipher_capa_trides_cbc; num = sizeof(cipher_capa_trides_cbc) / size; @@ -737,7 +728,6 @@ odp_crypto_session_create(odp_crypto_session_param_t *param, session->cipher.func = null_crypto_routine; rc = 0; break; - case ODP_CIPHER_ALG_DES: case ODP_CIPHER_ALG_3DES_CBC: rc = process_cipher_param(session, EVP_des_ede3_cbc()); break;