From patchwork Tue Nov 21 08:59:58 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Github ODP bot X-Patchwork-Id: 119344 Delivered-To: patch@linaro.org Received: by 10.140.22.164 with SMTP id 33csp4990432qgn; Tue, 21 Nov 2017 01:01:39 -0800 (PST) X-Google-Smtp-Source: AGs4zMZ/Fb0hn1iSIxN6awelWgdrXVU9eqs1WIjh4OlRaAexsQS8KXKoVkBJ5jDJGyLYWc442+mM X-Received: by 10.55.142.4 with SMTP id q4mr1169979qkd.35.1511254899345; Tue, 21 Nov 2017 01:01:39 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1511254899; cv=none; d=google.com; s=arc-20160816; b=jpNZ2s6Qn5nuhXYkL4Yt6g5QO8dWQpWF5QIr566Mwqk00hMZlGMoSa5J6qw+WxbnY9 ve21i2/bPETD7Ar0k95UPYj2qzrn2G5d2hWMEjDmab3GGtxAeYf5PaRQgwoAC2kg3gYP qm7E2ep6b19AiAM463sRpo5MQM0mtSWxFs+oRwbLWNW9sRe9a1pJXX/3wxPh0JLzRQ1Y va/RuTSr8Vigk2Xbz89Heh8oi7XcmBsqVd84Ba1ZOqfemm4ND+bqMih5/YwzbEZ9itML JOWQHuzDxtCRrMKTfJFlGxUC/pMAexdTRdEIJ6/a4sOlZhRxC7W9GzvOiAHuzLS97qLl riRA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:subject:github-pr-num :references:in-reply-to:message-id:date:to:from:delivered-to :arc-authentication-results; bh=R8aMM8QKoJ1IlvI74584FmhKX1Qe7eAa9gODbKx2EGs=; b=GPfC3NJOeypb/qhcFayiC6p07G4TN8MIE+fWbDGYnWOqsFILe2SSPkGt/2zlnTVVNC G4t/wI3XP1fs+TsfwE+WSJAb+kd4fKBYa73RswKizUgOdIDxiZr5SPuclOFlY/UoeA9H z1Zs/8v+M8QL7aA04oOdzUB1NOhuyAECqfb1u82Ap5CMEJmJGMSIM+G1OXMe3DD2k6Jd geDCtqcNX69gRi8EJKqqqPgOe/EvgKencylBWPbay2meSc55f4JZ63AvRuEVGGXWeT8C cMl6gHJxOi5ihGf81ae0ggVgsz8CO8+XI33opRHr5UWb+5Ef3ONxg7Pnl1wq+RosT2wc RQlg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of lng-odp-bounces@lists.linaro.org designates 54.197.127.237 as permitted sender) smtp.mailfrom=lng-odp-bounces@lists.linaro.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=yandex.ru Return-Path: Received: from lists.linaro.org (ec2-54-197-127-237.compute-1.amazonaws.com. [54.197.127.237]) by mx.google.com with ESMTP id 32si2341930qth.422.2017.11.21.01.01.39; Tue, 21 Nov 2017 01:01:39 -0800 (PST) Received-SPF: pass (google.com: domain of lng-odp-bounces@lists.linaro.org designates 54.197.127.237 as permitted sender) client-ip=54.197.127.237; Authentication-Results: mx.google.com; spf=pass (google.com: domain of lng-odp-bounces@lists.linaro.org designates 54.197.127.237 as permitted sender) smtp.mailfrom=lng-odp-bounces@lists.linaro.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=yandex.ru Received: by lists.linaro.org (Postfix, from userid 109) id 0B5CD60922; Tue, 21 Nov 2017 09:01:39 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on ip-10-142-244-252 X-Spam-Level: X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00,FREEMAIL_FROM, RCVD_IN_DNSWL_LOW,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,URIBL_BLOCKED autolearn=disabled version=3.4.0 Received: from [127.0.0.1] (localhost [127.0.0.1]) by lists.linaro.org (Postfix) with ESMTP id D2B9360890; Tue, 21 Nov 2017 09:00:28 +0000 (UTC) X-Original-To: lng-odp@lists.linaro.org Delivered-To: lng-odp@lists.linaro.org Received: by lists.linaro.org (Postfix, from userid 109) id 6C9766086F; Tue, 21 Nov 2017 09:00:19 +0000 (UTC) Received: from forward103p.mail.yandex.net (forward103p.mail.yandex.net [77.88.28.106]) by lists.linaro.org (Postfix) with ESMTPS id 68C8A60593 for ; Tue, 21 Nov 2017 09:00:13 +0000 (UTC) Received: from mxback10j.mail.yandex.net (mxback10j.mail.yandex.net [IPv6:2a02:6b8:0:1619::113]) by forward103p.mail.yandex.net (Yandex) with ESMTP id 713242183C11 for ; Tue, 21 Nov 2017 12:00:11 +0300 (MSK) Received: from smtp3p.mail.yandex.net (smtp3p.mail.yandex.net [2a02:6b8:0:1472:2741:0:8b6:8]) by mxback10j.mail.yandex.net (nwsmtp/Yandex) with ESMTP id Q4hurwBr1L-0BkamxuN; Tue, 21 Nov 2017 12:00:11 +0300 Received: by smtp3p.mail.yandex.net (nwsmtp/Yandex) with ESMTPSA id uqOthKDEgj-0A8GcaaO; Tue, 21 Nov 2017 12:00:10 +0300 (using TLSv1.2 with cipher ECDHE-RSA-AES128-SHA256 (128/128 bits)) (Client certificate not present) From: Github ODP bot To: lng-odp@lists.linaro.org Date: Tue, 21 Nov 2017 11:59:58 +0300 Message-Id: <1511254809-21207-2-git-send-email-odpbot@yandex.ru> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1511254809-21207-1-git-send-email-odpbot@yandex.ru> References: <1511254809-21207-1-git-send-email-odpbot@yandex.ru> Github-pr-num: 301 Subject: [lng-odp] [PATCH API-NEXT v1 1/12] doxygen: remove drv types X-BeenThere: lng-odp@lists.linaro.org X-Mailman-Version: 2.1.16 Precedence: list List-Id: "The OpenDataPlane \(ODP\) List" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: lng-odp-bounces@lists.linaro.org Sender: "lng-odp" From: Maxim Uvarov Signed-off-by: Maxim Uvarov --- /** Email created from pull request 301 (muvarov:api-next) ** https://github.com/Linaro/odp/pull/301 ** Patch: https://github.com/Linaro/odp/pull/301.patch ** Base sha: d4b364849c4abb4c71e0c5260e1a793ebb8dc97d ** Merge commit sha: 390c09cfddb8e938a4bef428fb46ce575f22c984 **/ doc/Doxyfile_common | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/doc/Doxyfile_common b/doc/Doxyfile_common index 0471dcf3c..779442d00 100644 --- a/doc/Doxyfile_common +++ b/doc/Doxyfile_common @@ -33,12 +33,9 @@ DOT_IMAGE_FORMAT = svg PREDEFINED = __GNUC__ \ __attribute__(x)= \ ODP_ALIGNED(x)= \ - ODPDRV_ALIGNED(x)= \ __BIG_ENDIAN_BITFIELD \ __LITTLE_ENDIAN_BITFIELD \ __x86_64__ \ ODP_PACKED \ - ODPDRV_PACKED \ ODP_DEPRECATE(x)=x \ - "ODP_HANDLE_T(type)=odp_handle_t type" \ - "ODPDRV_HANDLE_T(type)=odpdrv_handle_t type" + "ODP_HANDLE_T(type)=odp_handle_t type" From patchwork Tue Nov 21 08:59:59 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Github ODP bot X-Patchwork-Id: 119345 Delivered-To: patch@linaro.org Received: by 10.140.22.164 with SMTP id 33csp4991516qgn; Tue, 21 Nov 2017 01:02:33 -0800 (PST) X-Google-Smtp-Source: AGs4zMYPrdzg3dMNa9HSo79bag4o3Ap0Qm9mhDwGONSf2SGSzOsAK/Opye0Bs9L6elvzzSaQP2kv X-Received: by 10.237.62.4 with SMTP id l4mr25972673qtf.331.1511254953163; Tue, 21 Nov 2017 01:02:33 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1511254953; cv=none; d=google.com; s=arc-20160816; b=eSyVVE07t1cAFcmBo0rI4t0c2oWdOB3WVgvG21u5nIcbmD7BsOB/Sj8E5NXPatQqLB LACdOEBiNN38OD8SPVLgmGf8dJrWjasTjezNInCh2xoayrbbEihp2wbHGBEtou40pqU1 avpN6dEcnxA0SC7UY+iXyrdaepYSIm6dlUKrfFoulvpJ7gMFHbsF6jEAIu8CmxDDyDfF Rpt0D8ug0Jpy9XGHDLzAdDPABGAqgCJSJkTSXQ4jy3c9iZpZYiGbxmlCBKQcCcfofKxq Epw+BemKu7REz+TOXlykrYEVaTdv6+2zK+0AxihslbjDToMTJa+wj0nxSf3nrUbcvKTL fE7w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:subject:github-pr-num :references:in-reply-to:message-id:date:to:from:delivered-to :arc-authentication-results; bh=f67H9oLCWYLp06AzojzknNz5dM/qBveF+nErPFxfCoE=; b=hw0Q3iID+/+Ip99b2spAsa+MTkdHxcMUkJkLObuqT6dfg6FY+aFIGH099+mYwIk+Jh pYr9y7T3veHt94lFpLfCut1prn9YN3gkK6tyEOFArbJ2t/y5f5zogHnSsPbxVX0LW7yt 2KhD5r0ifXD9hV0RNNYpysTcFa0GeoRw5pfk8dm2It+2D6rsU+4IVigfGz0pvYDesT2n +Y6FK1HRPX3xwubnGywdslAewS0IrjQFBYAYXoADZNcT+ySmdDZq7Wnp3/j2cOCQILr4 YzLyKbVLb9CZyEqvKKWs0umTTeXB8pE/nVzMZkYDTkhGzjYLtRL1p4N0eaNLG7VmUQy0 G7DQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of lng-odp-bounces@lists.linaro.org designates 54.197.127.237 as permitted sender) smtp.mailfrom=lng-odp-bounces@lists.linaro.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=yandex.ru Return-Path: Received: from lists.linaro.org (ec2-54-197-127-237.compute-1.amazonaws.com. [54.197.127.237]) by mx.google.com with ESMTP id j24si204465qtk.9.2017.11.21.01.02.32; Tue, 21 Nov 2017 01:02:33 -0800 (PST) Received-SPF: pass (google.com: domain of lng-odp-bounces@lists.linaro.org designates 54.197.127.237 as permitted sender) client-ip=54.197.127.237; Authentication-Results: mx.google.com; spf=pass (google.com: domain of lng-odp-bounces@lists.linaro.org designates 54.197.127.237 as permitted sender) smtp.mailfrom=lng-odp-bounces@lists.linaro.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=yandex.ru Received: by lists.linaro.org (Postfix, from userid 109) id D54DB60972; Tue, 21 Nov 2017 09:02:32 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on ip-10-142-244-252 X-Spam-Level: X-Spam-Status: No, score=-5.4 required=5.0 tests=BAYES_00,FREEMAIL_FROM, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H2, URIBL_BLOCKED autolearn=disabled version=3.4.0 Received: from [127.0.0.1] (localhost [127.0.0.1]) by lists.linaro.org (Postfix) with ESMTP id 44B94608BC; Tue, 21 Nov 2017 09:00:37 +0000 (UTC) X-Original-To: lng-odp@lists.linaro.org Delivered-To: lng-odp@lists.linaro.org Received: by lists.linaro.org (Postfix, from userid 109) id 614AF60843; Tue, 21 Nov 2017 09:00:20 +0000 (UTC) Received: from forward104p.mail.yandex.net (forward104p.mail.yandex.net [77.88.28.107]) by lists.linaro.org (Postfix) with ESMTPS id CBEA760655 for ; Tue, 21 Nov 2017 09:00:13 +0000 (UTC) Received: from mxback3g.mail.yandex.net (mxback3g.mail.yandex.net [IPv6:2a02:6b8:0:1472:2741:0:8b7:164]) by forward104p.mail.yandex.net (Yandex) with ESMTP id 5C796184592 for ; Tue, 21 Nov 2017 12:00:12 +0300 (MSK) Received: from smtp3p.mail.yandex.net (smtp3p.mail.yandex.net [2a02:6b8:0:1472:2741:0:8b6:8]) by mxback3g.mail.yandex.net (nwsmtp/Yandex) with ESMTP id V1ZYJspnDz-0CkuEeir; Tue, 21 Nov 2017 12:00:12 +0300 Received: by smtp3p.mail.yandex.net (nwsmtp/Yandex) with ESMTPSA id uqOthKDEgj-0B8q66xc; Tue, 21 Nov 2017 12:00:11 +0300 (using TLSv1.2 with cipher ECDHE-RSA-AES128-SHA256 (128/128 bits)) (Client certificate not present) From: Github ODP bot To: lng-odp@lists.linaro.org Date: Tue, 21 Nov 2017 11:59:59 +0300 Message-Id: <1511254809-21207-3-git-send-email-odpbot@yandex.ru> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1511254809-21207-1-git-send-email-odpbot@yandex.ru> References: <1511254809-21207-1-git-send-email-odpbot@yandex.ru> Github-pr-num: 301 Subject: [lng-odp] [PATCH API-NEXT v1 2/12] linux-gen: crypto: drop DES-CBC support X-BeenThere: lng-odp@lists.linaro.org X-Mailman-Version: 2.1.16 Precedence: list List-Id: "The OpenDataPlane \(ODP\) List" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: lng-odp-bounces@lists.linaro.org Sender: "lng-odp" From: Dmitry Eremin-Solenikov DES-CBC (not 3DES-CBC) support is invalid (DES should use 8 bytes key, not 24 bytes), it is not covered by testsuite and DES is cracable/deprecated/etc since long ago. Stop providing single-key DES support. In case one really needs it, it can be emulated through supplying same key triple times to 3DES-CBC. Signed-off-by: Dmitry Eremin-Solenikov Reviewed-by: Bill Fischofer Signed-off-by: Maxim Uvarov --- /** Email created from pull request 301 (muvarov:api-next) ** https://github.com/Linaro/odp/pull/301 ** Patch: https://github.com/Linaro/odp/pull/301.patch ** Base sha: d4b364849c4abb4c71e0c5260e1a793ebb8dc97d ** Merge commit sha: 390c09cfddb8e938a4bef428fb46ce575f22c984 **/ platform/linux-generic/odp_crypto.c | 10 ---------- 1 file changed, 10 deletions(-) diff --git a/platform/linux-generic/odp_crypto.c b/platform/linux-generic/odp_crypto.c index 9cf903d03..4c708931a 100644 --- a/platform/linux-generic/odp_crypto.c +++ b/platform/linux-generic/odp_crypto.c @@ -25,7 +25,6 @@ #include #include -#include #include #include #include @@ -40,9 +39,6 @@ static const odp_crypto_cipher_capability_t cipher_capa_null[] = { {.key_len = 0, .iv_len = 0} }; -static const odp_crypto_cipher_capability_t cipher_capa_des[] = { -{.key_len = 24, .iv_len = 8} }; - static const odp_crypto_cipher_capability_t cipher_capa_trides_cbc[] = { {.key_len = 24, .iv_len = 8} }; @@ -582,7 +578,6 @@ int odp_crypto_capability(odp_crypto_capability_t *capa) memset(capa, 0, sizeof(odp_crypto_capability_t)); capa->ciphers.bit.null = 1; - capa->ciphers.bit.des = 1; capa->ciphers.bit.trides_cbc = 1; capa->ciphers.bit.aes_cbc = 1; capa->ciphers.bit.aes_gcm = 1; @@ -620,10 +615,6 @@ int odp_crypto_cipher_capability(odp_cipher_alg_t cipher, src = cipher_capa_null; num = sizeof(cipher_capa_null) / size; break; - case ODP_CIPHER_ALG_DES: - src = cipher_capa_des; - num = sizeof(cipher_capa_des) / size; - break; case ODP_CIPHER_ALG_3DES_CBC: src = cipher_capa_trides_cbc; num = sizeof(cipher_capa_trides_cbc) / size; @@ -737,7 +728,6 @@ odp_crypto_session_create(odp_crypto_session_param_t *param, session->cipher.func = null_crypto_routine; rc = 0; break; - case ODP_CIPHER_ALG_DES: case ODP_CIPHER_ALG_3DES_CBC: rc = process_cipher_param(session, EVP_des_ede3_cbc()); break;