From patchwork Wed Nov 15 14:20:48 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ard Biesheuvel X-Patchwork-Id: 118969 Delivered-To: patch@linaro.org Received: by 10.140.22.164 with SMTP id 33csp4374803qgn; Wed, 15 Nov 2017 06:21:12 -0800 (PST) X-Google-Smtp-Source: AGs4zMZbOY/6ot1hBgiBdbzYhxTbpWG5tr9LQIQQDpiBzbkIg2/B/O9HSHom4bzTz30c/ol6qeTV X-Received: by 10.84.237.9 with SMTP id s9mr15824760plk.417.1510755672653; Wed, 15 Nov 2017 06:21:12 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1510755672; cv=none; d=google.com; s=arc-20160816; b=WWfNqjqUHMlMF1imQaOGQb8ZZ4gIT3PWra/vmXQZYlSsPuWd3G2e+9peueR9WCz6KN ydV4zj126oTu2qwmee9OGm0Hac2Toag5eTlk3ZRVRmvg5qv5qiJfPVTPmR0YmiawQNya Lnb6GhBkRWayf54rwa4uGzs55H4+MYzPxD6RFsYo3rroRq3cIMwsvf8VOgwxNJjLAqPm v3PRR2q/vAsJyEkiIc6PmmK8HbMQOeBYJXylOoIPa17RUR4bUJES1tskqPjAhxItP8ZZ 7Qi/Mn6bXzrU+WQTp+//xuZdmAsORTdMBpz5fYAWWDU1ZI46mbnzDhcRzWl8jntiLzW2 6rzA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:mime-version:cc :list-subscribe:list-help:list-post:list-archive:list-unsubscribe :list-id:precedence:subject:message-id:date:to:from:dkim-signature :delivered-to:arc-authentication-results; bh=EPSs4Fvsy6AEQDE9oXPs9epVvcYHijdQze1I1ixxkRc=; b=a9Brvn4APBxyRKyp68A+bACS6GWUuwMDRS6DFQ0bd6dkg61qw2Agr/13Amtn3LIWcQ nkcbYFlEDUxjuSF6Kuvbzo7XWGXzjA+wjx4a4oVDJ6nh+ITzIVvmvPVoqT5Q0/6OY1GJ xMJa7zlAV4UJT3tPCwuxufvchao8gNGzL58QlQCbwO67pf2Q1RT/EzrLXodrDfZslqAm knJ9LbQ5QatTlHrQ113kN2eKY3cEQbNP+TnbYtrt2ZXvIqxviDGJGfiYWYf8nh7L4kP2 Kz2BYK892X0mF0azIyYGhXyWyzETdN0ifYe/04zcZYuycroarPMoiVxscox9+cBp0M1J xuaw== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=ZUu30boX; spf=pass (google.com: best guess record for domain of edk2-devel-bounces@lists.01.org designates 2001:19d0:306:5::1 as permitted sender) smtp.mailfrom=edk2-devel-bounces@lists.01.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from ml01.01.org (ml01.01.org. [2001:19d0:306:5::1]) by mx.google.com with ESMTPS id bh1si17975722plb.93.2017.11.15.06.21.12 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 15 Nov 2017 06:21:12 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of edk2-devel-bounces@lists.01.org designates 2001:19d0:306:5::1 as permitted sender) client-ip=2001:19d0:306:5::1; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=ZUu30boX; spf=pass (google.com: best guess record for domain of edk2-devel-bounces@lists.01.org designates 2001:19d0:306:5::1 as permitted sender) smtp.mailfrom=edk2-devel-bounces@lists.01.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from [127.0.0.1] (localhost [IPv6:::1]) by ml01.01.org (Postfix) with ESMTP id 3D47020355204; Wed, 15 Nov 2017 06:17:03 -0800 (PST) X-Original-To: edk2-devel@lists.01.org Delivered-To: edk2-devel@lists.01.org Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2a00:1450:400c:c0c::242; helo=mail-wr0-x242.google.com; envelope-from=ard.biesheuvel@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-wr0-x242.google.com (mail-wr0-x242.google.com [IPv6:2a00:1450:400c:c0c::242]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id F342D2034BBC7 for ; Wed, 15 Nov 2017 06:17:01 -0800 (PST) Received: by mail-wr0-x242.google.com with SMTP id 15so20579049wrb.5 for ; Wed, 15 Nov 2017 06:21:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id; bh=ZcYl/GLqu6Sqh6qdgmxmi+L23TfsNJ0iIKhPIZ7Z0qM=; b=ZUu30boXI8Gf8qlkJ0HIhialkYGuqAIaHeeHJYyfS8LDUSFCmG5FN/kRgZhlCdd494 +7ih0HmBatgYUOIwpLUWwNG50yLQvKmhWihObqU9mSJhp5vkm6w0kfaSQ22c8swMkxi6 jQWJH0sz0XRUJ+bmNELyGNST8l6EfaTbJCafE= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=ZcYl/GLqu6Sqh6qdgmxmi+L23TfsNJ0iIKhPIZ7Z0qM=; b=O4rzLwuq60y92JL+m6E6PkGB6Pj0QxS9olHZOebgQWwSRz86i0ZEFOXmcX9zNbTEbO GgXrDyU0Y9xRgKRmukIJDPnp1twNEfVZy7LvV93F3GpHokQfF8xt50RtRSPw+TWWNHP/ 8d4OGkLpUn8RhJgVyc08SQCXas7puXpsEnTqIzqywOS4WheQ2KPUHZIQjMjb9hMPnj7J Zs1HsmgAGRaJGZiMSnTavkPz7czWaxqfSfGrgPD25NlfeDJLfNRI6Otgc9ti7EiHOkwQ DH/B94cf5olM0pL8jgztnVetfMOpghg6KAwJA2WT+3joHVQZMPrB8ib2m2ssUrJVYPT+ aEdg== X-Gm-Message-State: AJaThX75bhGTvniR5NieCR68qFC4MP5ZIgSs/Q/+MUG+7+j31Dff8geB 93fK5cD54iQCuoOGstgZPiJPta7X2QU= X-Received: by 10.223.189.13 with SMTP id j13mr13850295wrh.94.1510755668526; Wed, 15 Nov 2017 06:21:08 -0800 (PST) Received: from localhost.localdomain ([160.167.170.128]) by smtp.gmail.com with ESMTPSA id m198sm30861748wmg.20.2017.11.15.06.21.06 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 15 Nov 2017 06:21:07 -0800 (PST) From: Ard Biesheuvel To: edk2-devel@lists.01.org Date: Wed, 15 Nov 2017 14:20:48 +0000 Message-Id: <20171115142048.9928-1-ard.biesheuvel@linaro.org> X-Mailer: git-send-email 2.11.0 Subject: [edk2] [PATCH] ArmPlatformPkg: remove ArmGetCpuCountPerCluster () from ArmPlatformLib X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: leif.lindholm@linaro.org, Ard Biesheuvel MIME-Version: 1.0 Errors-To: edk2-devel-bounces@lists.01.org Sender: "edk2-devel" The only user of ArmPlatformLib's ArmGetCpuCountPerCluster () is itself an ArmPlatformLib implementation, i.e., ArmVExpressLibRTSM. Given that we'd prefer to get rid of ArmPlatformLib entirely, let's remove ArmGetCpuCountPerCluster () from the API as a first step. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Ard Biesheuvel --- This is another prerequisite of the edk2-platforms series I am about to post. After that, I will follow up with a couple of cleanup patches that get rid of a lot of ArmPlatformPkg cruft. ArmPlatformPkg/ArmVExpressPkg/Library/ArmVExpressLibRTSM/RTSM.c | 13 +++++++++++++ ArmPlatformPkg/Include/Library/ArmPlatformLib.h | 13 ------------- 2 files changed, 13 insertions(+), 13 deletions(-) -- 2.11.0 _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel Reviewed-by: Leif Lindholm diff --git a/ArmPlatformPkg/ArmVExpressPkg/Library/ArmVExpressLibRTSM/RTSM.c b/ArmPlatformPkg/ArmVExpressPkg/Library/ArmVExpressLibRTSM/RTSM.c index d8d1c9ac26dd..11dd7ff1bfb0 100644 --- a/ArmPlatformPkg/ArmVExpressPkg/Library/ArmVExpressLibRTSM/RTSM.c +++ b/ArmPlatformPkg/ArmVExpressPkg/Library/ArmVExpressLibRTSM/RTSM.c @@ -21,6 +21,19 @@ #include +/** + Return the core per cluster. The method may differ per core type + + This function might be called from assembler before any stack is set. + + @return Return the core count per cluster + +**/ +UINTN +ArmGetCpuCountPerCluster ( + VOID + ); + ARM_CORE_INFO mVersatileExpressMpCoreInfoTable[] = { { // Cluster 0, Core 0 diff --git a/ArmPlatformPkg/Include/Library/ArmPlatformLib.h b/ArmPlatformPkg/Include/Library/ArmPlatformLib.h index fe3bc4bb8e6c..77561a3d05b3 100644 --- a/ArmPlatformPkg/Include/Library/ArmPlatformLib.h +++ b/ArmPlatformPkg/Include/Library/ArmPlatformLib.h @@ -41,19 +41,6 @@ typedef struct { } ARM_SYSTEM_MEMORY_REGION_DESCRIPTOR; /** - Return the core per cluster. The method may differ per core type - - This function might be called from assembler before any stack is set. - - @return Return the core count per cluster - -**/ -UINTN -ArmGetCpuCountPerCluster ( - VOID - ); - -/** Return the core position from the value of its MpId register This function returns the core position from the position 0 in the processor.