From patchwork Thu Nov 2 12:00:05 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Github ODP bot X-Patchwork-Id: 117806 Delivered-To: patch@linaro.org Received: by 10.140.22.164 with SMTP id 33csp2073732qgn; Thu, 2 Nov 2017 05:03:21 -0700 (PDT) X-Google-Smtp-Source: ABhQp+SRHD7or6SIC/yE7a06ER4GKzWhufzohaJ7m8Ku+i3GKg9eNRbFC4VZHKKHx0u7/wx8MebY X-Received: by 10.200.23.220 with SMTP id r28mr4476126qtk.247.1509624200999; Thu, 02 Nov 2017 05:03:20 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1509624200; cv=none; d=google.com; s=arc-20160816; b=FLRZJtIcSWtm9IV0m0hL074IT6BocXJvovmjUIZBpzaPE16IXMMelKEdf0oHfoQjGp UcXCUU6lcRt54Hnp0Dp8nBpkYLqD/kDaHHAw6hQK4T7vU3k1HpE/oYZkz8G5Fi0RdgxK W5ZdzAvOfBd6kleFy9bw/jt/7jAmdyHNqcOcIugJZOoUW9yMCiC2mCfMZK7YU0/VIYwX mmLDYYiKwsHT7cVVm3ToDBtouPaLv3aGH4HUfmx6hRxGFlHuJGQx0XrX1T6I5uWWX+n1 Ln1Aok+dUTO0xAkWyslwPqB93MpHY+ZdCosdJP8bwlgkwyc/KAF2LW8k4fn6uqk6iooo NakQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:subject:github-pr-num :references:in-reply-to:message-id:date:to:from:delivered-to :arc-authentication-results; bh=0yZy7cynR91vnPtPJOr7BUS7Sijxt70YckKICDJopIY=; b=txXY3sauOtGWi2LqkR8wluAY24z7GSejPjHisEAbtVlCg+/EE8oISDuI688Lj6oX6u i63B9iXqFTMBXWxPhLyfs4w7zLASs5AjI7V2yocB3xtyfTw0RMdPe06ahLlAR2wa1bqo R2PzOS38J8zDc/YjeI7ow/dQNXCFxc6ka5MsEyop0/rfjA2sRH31HU3j8arpm2AqlgRt 9/pMskaTrbyXsMLfXmMC+fyl7CATtiEWlUxKniuiL59VDfdiFP/LZ3zGK9z30vnQ5vZD htLYMdlBQfpZw62fSK9c9LJ2dnYqgHJS1pdOpotgkGZgFWCukBw6ybKmFUQhp1brJUGv 2PBQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of lng-odp-bounces@lists.linaro.org designates 54.197.127.237 as permitted sender) smtp.mailfrom=lng-odp-bounces@lists.linaro.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=yandex.ru Return-Path: Received: from lists.linaro.org (ec2-54-197-127-237.compute-1.amazonaws.com. [54.197.127.237]) by mx.google.com with ESMTP id l51si1175828qtl.448.2017.11.02.05.03.20; Thu, 02 Nov 2017 05:03:20 -0700 (PDT) Received-SPF: pass (google.com: domain of lng-odp-bounces@lists.linaro.org designates 54.197.127.237 as permitted sender) client-ip=54.197.127.237; Authentication-Results: mx.google.com; spf=pass (google.com: domain of lng-odp-bounces@lists.linaro.org designates 54.197.127.237 as permitted sender) smtp.mailfrom=lng-odp-bounces@lists.linaro.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=yandex.ru Received: by lists.linaro.org (Postfix, from userid 109) id 744F360BE3; Thu, 2 Nov 2017 12:03:20 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on ip-10-142-244-252 X-Spam-Level: X-Spam-Status: No, score=-5.4 required=5.0 tests=BAYES_00,FREEMAIL_FROM, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H2 autolearn=disabled version=3.4.0 Received: from [127.0.0.1] (localhost [127.0.0.1]) by lists.linaro.org (Postfix) with ESMTP id 411526082A; Thu, 2 Nov 2017 12:02:29 +0000 (UTC) X-Original-To: lng-odp@lists.linaro.org Delivered-To: lng-odp@lists.linaro.org Received: by lists.linaro.org (Postfix, from userid 109) id 0DDA560647; Thu, 2 Nov 2017 12:02:15 +0000 (UTC) Received: from forward104p.mail.yandex.net (forward104p.mail.yandex.net [77.88.28.107]) by lists.linaro.org (Postfix) with ESMTPS id 3747E60FFD for ; Thu, 2 Nov 2017 12:00:12 +0000 (UTC) Received: from mxback8o.mail.yandex.net (mxback8o.mail.yandex.net [IPv6:2a02:6b8:0:1a2d::22]) by forward104p.mail.yandex.net (Yandex) with ESMTP id 27019184431 for ; Thu, 2 Nov 2017 15:00:10 +0300 (MSK) Received: from smtp2p.mail.yandex.net (smtp2p.mail.yandex.net [2a02:6b8:0:1472:2741:0:8b6:7]) by mxback8o.mail.yandex.net (nwsmtp/Yandex) with ESMTP id Eg6lMc3EzH-0AA4x620; Thu, 02 Nov 2017 15:00:10 +0300 Received: by smtp2p.mail.yandex.net (nwsmtp/Yandex) with ESMTPSA id 0qgpfauOww-0938cQiR; Thu, 02 Nov 2017 15:00:09 +0300 (using TLSv1.2 with cipher ECDHE-RSA-AES128-SHA256 (128/128 bits)) (Client certificate not present) From: Github ODP bot To: lng-odp@lists.linaro.org Date: Thu, 2 Nov 2017 15:00:05 +0300 Message-Id: <1509624008-24783-2-git-send-email-odpbot@yandex.ru> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1509624008-24783-1-git-send-email-odpbot@yandex.ru> References: <1509624008-24783-1-git-send-email-odpbot@yandex.ru> Github-pr-num: 269 Subject: [lng-odp] [PATCH API-NEXT v1 1/4] linux-gen: packet: add L3/L4 checksum validation flags X-BeenThere: lng-odp@lists.linaro.org X-Mailman-Version: 2.1.16 Precedence: list List-Id: "The OpenDataPlane \(ODP\) List" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: lng-odp-bounces@lists.linaro.org Sender: "lng-odp" From: Bogdan Pricope Add L3/L4 checksum validation flags to signal if operation was performed by the platform and its result. Signed-off-by: Bogdan Pricope --- /** Email created from pull request 269 (bogdanPricope:api_next_csum_status_pr) ** https://github.com/Linaro/odp/pull/269 ** Patch: https://github.com/Linaro/odp/pull/269.patch ** Base sha: d22c949cc466bf28de559855a1cb525740578137 ** Merge commit sha: 7076ea1cebe42326de76e8bb07709715222f2958 **/ platform/linux-generic/include/odp/api/plat/packet_types.h | 3 +++ platform/linux-generic/include/odp_packet_internal.h | 2 ++ 2 files changed, 5 insertions(+) diff --git a/platform/linux-generic/include/odp/api/plat/packet_types.h b/platform/linux-generic/include/odp/api/plat/packet_types.h index 68c66312b..050f69dc5 100644 --- a/platform/linux-generic/include/odp/api/plat/packet_types.h +++ b/platform/linux-generic/include/odp/api/plat/packet_types.h @@ -150,6 +150,9 @@ typedef union { uint64_t color:2; /**< Packet color for traffic mgmt */ uint64_t nodrop:1; /**< Drop eligibility status */ + + uint64_t l3_chksum_done:1; /**< L3 checksum validation done */ + uint64_t l4_chksum_done:1; /**< L4 checksum validation done */ }; } _odp_packet_input_flags_t; diff --git a/platform/linux-generic/include/odp_packet_internal.h b/platform/linux-generic/include/odp_packet_internal.h index fed562aa3..950e1bb5c 100644 --- a/platform/linux-generic/include/odp_packet_internal.h +++ b/platform/linux-generic/include/odp_packet_internal.h @@ -51,8 +51,10 @@ typedef union { uint32_t snap_len:1; /**< Snap length error */ uint32_t l2_chksum:1; /**< L2 checksum error, checks TBD */ uint32_t ip_err:1; /**< IP error, checks TBD */ + uint32_t l3_chksum:1; /**< L3 checksum error */ uint32_t tcp_err:1; /**< TCP error, checks TBD */ uint32_t udp_err:1; /**< UDP error, checks TBD */ + uint32_t l4_chksum:1; /**< L4 checksum error */ }; } error_flags_t; From patchwork Thu Nov 2 12:00:06 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Github ODP bot X-Patchwork-Id: 117807 Delivered-To: patch@linaro.org Received: by 10.140.22.164 with SMTP id 33csp2074574qgn; Thu, 2 Nov 2017 05:03:58 -0700 (PDT) X-Google-Smtp-Source: ABhQp+Ry/VNGwF2N68Afld35nqlKUyVsJ5dl+NHVoEzFsyZJ35KjRyZ+v/+WXVGv5fUfUpA5hw9X X-Received: by 10.200.9.73 with SMTP id z9mr4300995qth.43.1509624238262; Thu, 02 Nov 2017 05:03:58 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1509624238; cv=none; d=google.com; s=arc-20160816; b=z0QAdCPNLuRm5/bXpLjMZQ+JMcz02s2PJnEAE8bWKGaqKWjFZMu+UKBHc2aEwBf39s Z1x6xQuhYDIZZShbUS3JY/mJzfcAe7cUnfj1PYFpSuYFSrE/4010hERtcRy5bhwpA19F 8VcDIRxgOzSH3rSBrKjPNCWQWstFbqeS4OgjUlFXPILQyb5CWmNb8PZxft6rcQFrrV6m SlDKig2bk5Vx0HptlUPxr83C2fGl1TD8DFKj3uMD/jc8NLjoDKg0UYFFC5VCnLL0cbME 3W6nuKM7Sc6d0NMFsIeye8JEH8IEN6ItqUaR+JTd5qlxR5jroEkI8zECWiamGFIdbTIN wFFQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:subject:github-pr-num :references:in-reply-to:message-id:date:to:from:delivered-to :arc-authentication-results; bh=BZyhoEMtr0inByWshbZu/oUi6zkQOUr9fL58vji+ORU=; b=J5tqClBO4WoaGPsEHhhdqscTOKzcXpzExWXrExE7egIDmfxt/8Z3FvVVFstcMeZ5GR ZWDuHPic7XS6iVblthzxVJ2vJ0TD/tHCRJMesqoVatzRnd6NlQJnZEmcy4t+cfvF5X9L 3Hqox/LOiJ5tmz58aVL35zqSBJGYXTEK6BgAh1AQ8aHY3o0YVrcNXstTnZgttBQl4ZYJ NkdGSJ5dfyn6E8aocS3KhayV8ZFkf+65tMmCQBbqcYlc86KHPLoVzfFuyFTmtRLbFG3J ejbPXDLKj+FMlYUoNTY/5R7qZWDSeTOuWZpMXLyvvdcb/68DKyY3AoOzxSB13vOUVuTU exJg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of lng-odp-bounces@lists.linaro.org designates 54.197.127.237 as permitted sender) smtp.mailfrom=lng-odp-bounces@lists.linaro.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=yandex.ru Return-Path: Received: from lists.linaro.org (ec2-54-197-127-237.compute-1.amazonaws.com. [54.197.127.237]) by mx.google.com with ESMTP id z75si2858673qkb.322.2017.11.02.05.03.57; Thu, 02 Nov 2017 05:03:58 -0700 (PDT) Received-SPF: pass (google.com: domain of lng-odp-bounces@lists.linaro.org designates 54.197.127.237 as permitted sender) client-ip=54.197.127.237; Authentication-Results: mx.google.com; spf=pass (google.com: domain of lng-odp-bounces@lists.linaro.org designates 54.197.127.237 as permitted sender) smtp.mailfrom=lng-odp-bounces@lists.linaro.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=yandex.ru Received: by lists.linaro.org (Postfix, from userid 109) id DFB2560BE3; Thu, 2 Nov 2017 12:03:57 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on ip-10-142-244-252 X-Spam-Level: X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00,FREEMAIL_FROM, RCVD_IN_DNSWL_LOW autolearn=disabled version=3.4.0 Received: from [127.0.0.1] (localhost [127.0.0.1]) by lists.linaro.org (Postfix) with ESMTP id 96E5460B14; Thu, 2 Nov 2017 12:02:36 +0000 (UTC) X-Original-To: lng-odp@lists.linaro.org Delivered-To: lng-odp@lists.linaro.org Received: by lists.linaro.org (Postfix, from userid 109) id 9160F60647; Thu, 2 Nov 2017 12:02:15 +0000 (UTC) Received: from forward103j.mail.yandex.net (forward103j.mail.yandex.net [5.45.198.246]) by lists.linaro.org (Postfix) with ESMTPS id 59B4661000 for ; Thu, 2 Nov 2017 12:00:12 +0000 (UTC) Received: from mxback8j.mail.yandex.net (mxback8j.mail.yandex.net [IPv6:2a02:6b8:0:1619::111]) by forward103j.mail.yandex.net (Yandex) with ESMTP id DC7A934C34B8 for ; Thu, 2 Nov 2017 15:00:10 +0300 (MSK) Received: from smtp2p.mail.yandex.net (smtp2p.mail.yandex.net [2a02:6b8:0:1472:2741:0:8b6:7]) by mxback8j.mail.yandex.net (nwsmtp/Yandex) with ESMTP id 249DhD7ISD-0At47rvn; Thu, 02 Nov 2017 15:00:10 +0300 Received: by smtp2p.mail.yandex.net (nwsmtp/Yandex) with ESMTPSA id 0qgpfauOww-0A3WNoh4; Thu, 02 Nov 2017 15:00:10 +0300 (using TLSv1.2 with cipher ECDHE-RSA-AES128-SHA256 (128/128 bits)) (Client certificate not present) From: Github ODP bot To: lng-odp@lists.linaro.org Date: Thu, 2 Nov 2017 15:00:06 +0300 Message-Id: <1509624008-24783-3-git-send-email-odpbot@yandex.ru> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1509624008-24783-1-git-send-email-odpbot@yandex.ru> References: <1509624008-24783-1-git-send-email-odpbot@yandex.ru> Github-pr-num: 269 Subject: [lng-odp] [PATCH API-NEXT v1 2/4] linux-gen: packet: implement checksum validation status functions X-BeenThere: lng-odp@lists.linaro.org X-Mailman-Version: 2.1.16 Precedence: list List-Id: "The OpenDataPlane \(ODP\) List" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: lng-odp-bounces@lists.linaro.org Sender: "lng-odp" From: Bogdan Pricope Checksum validation status functions return the status of the latest checksum check done for the packet based on packet input flags and packet error flags. Signed-off-by: Bogdan Pricope --- /** Email created from pull request 269 (bogdanPricope:api_next_csum_status_pr) ** https://github.com/Linaro/odp/pull/269 ** Patch: https://github.com/Linaro/odp/pull/269.patch ** Base sha: d22c949cc466bf28de559855a1cb525740578137 ** Merge commit sha: 7076ea1cebe42326de76e8bb07709715222f2958 **/ platform/linux-generic/odp_packet.c | 26 ++++++++++++++++++++++++++ 1 file changed, 26 insertions(+) diff --git a/platform/linux-generic/odp_packet.c b/platform/linux-generic/odp_packet.c index 3b2fac212..59b943637 100644 --- a/platform/linux-generic/odp_packet.c +++ b/platform/linux-generic/odp_packet.c @@ -1284,6 +1284,32 @@ int odp_packet_l4_offset_set(odp_packet_t pkt, uint32_t offset) return 0; } +odp_packet_chksum_status_t odp_packet_l3_chksum_status(odp_packet_t pkt) +{ + odp_packet_hdr_t *pkt_hdr = packet_hdr(pkt); + + if (!pkt_hdr->p.input_flags.l3_chksum_done) + return ODP_PACKET_CHKSUM_UNKNOWN; + + if (pkt_hdr->p.error_flags.l3_chksum) + return ODP_PACKET_CHKSUM_BAD; + + return ODP_PACKET_CHKSUM_OK; +} + +odp_packet_chksum_status_t odp_packet_l4_chksum_status(odp_packet_t pkt) +{ + odp_packet_hdr_t *pkt_hdr = packet_hdr(pkt); + + if (!pkt_hdr->p.input_flags.l4_chksum_done) + return ODP_PACKET_CHKSUM_UNKNOWN; + + if (pkt_hdr->p.error_flags.l4_chksum) + return ODP_PACKET_CHKSUM_BAD; + + return ODP_PACKET_CHKSUM_OK; +} + void odp_packet_flow_hash_set(odp_packet_t pkt, uint32_t flow_hash) { odp_packet_hdr_t *pkt_hdr = packet_hdr(pkt); From patchwork Thu Nov 2 12:00:07 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Github ODP bot X-Patchwork-Id: 117809 Delivered-To: patch@linaro.org Received: by 10.140.22.164 with SMTP id 33csp2077175qgn; Thu, 2 Nov 2017 05:05:52 -0700 (PDT) X-Google-Smtp-Source: ABhQp+S6S05sIryo4U3xu76LmkeDlsxhg7mldZHs4gZuupvdzpIFSjH0LupFVZa3Wp9f/mh9uGcz X-Received: by 10.157.63.165 with SMTP id r34mr2052109otc.266.1509624352444; Thu, 02 Nov 2017 05:05:52 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1509624352; cv=none; d=google.com; s=arc-20160816; b=IWgsO0ofcMkG8uMHsT8etkDxfXyE9HCKlek0g3CzKyYhNTMbT0yByIQcJekYxq/egZ 0Ux5bZpejcWweYsqE120WKeodnIuaT1T57eWYgDtOL2ieM4crA79CAlBo9VY35FXVRRZ KkHzoNjmw1vNVkFu1qWrjWRecdogQqNkF/4aLdgND+wefnrjlyb3LWywa5KUMVzO40Rn aPREOiJSwnFYqPkVR1Q/LRUhBpt83m+wQhRYCPSP8awO6LXzCfzGa+4Q4Y2W1pPZ0aOQ uBT0aQKJvcd52SLwh17w9YWIAzS7ebvPMv/X5pUzS9wt7WShLIjJAEZ8sEdNEQ4vEkJC 2AWw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:subject:github-pr-num :references:in-reply-to:message-id:date:to:from:delivered-to :arc-authentication-results; bh=uTF0n+KfEq4fZbzF8BRqNlay71xHW3pY0pQraJB6KIk=; b=M2i6kpgd6arMoYXa+cP1JVeR7mh9ggjChtOfju63vuF59nUxdZNZa1qqMAg3GF2yF+ i8376AZH7SfqpWBkgAZTP3QBEw+l54up/qeO0ypMaV3nAa7Nxn0RaLi/a5VRZqm55EZw Vpp/Fp6ttKfalrkFzGHO4HMfzBCO2yYdYAitlpfaGgAYVb48kMTA6G9pOPkl2LvBYExl AYTjlQpgJSUmvxh9P/n58D6zdfGFoZzMtOy7fgRmD1s1VuuVXQiq3z3jF8o2t0A1pcRS qttODWv8IeKANBAWEUohZH6f+56zZaXenrvcTlgeA4Upa5fLK5WSrnuqKkjQvpYgO3Tr eesQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of lng-odp-bounces@lists.linaro.org designates 54.197.127.237 as permitted sender) smtp.mailfrom=lng-odp-bounces@lists.linaro.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=yandex.ru Return-Path: Received: from lists.linaro.org (ec2-54-197-127-237.compute-1.amazonaws.com. [54.197.127.237]) by mx.google.com with ESMTP id 38si1652882otb.534.2017.11.02.05.05.52; Thu, 02 Nov 2017 05:05:52 -0700 (PDT) Received-SPF: pass (google.com: domain of lng-odp-bounces@lists.linaro.org designates 54.197.127.237 as permitted sender) client-ip=54.197.127.237; Authentication-Results: mx.google.com; spf=pass (google.com: domain of lng-odp-bounces@lists.linaro.org designates 54.197.127.237 as permitted sender) smtp.mailfrom=lng-odp-bounces@lists.linaro.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=yandex.ru Received: by lists.linaro.org (Postfix, from userid 109) id C330161006; Thu, 2 Nov 2017 12:05:51 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on ip-10-142-244-252 X-Spam-Level: X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00,FREEMAIL_FROM, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL autolearn=disabled version=3.4.0 Received: from [127.0.0.1] (localhost [127.0.0.1]) by lists.linaro.org (Postfix) with ESMTP id 2EDCC60D6F; Thu, 2 Nov 2017 12:02:45 +0000 (UTC) X-Original-To: lng-odp@lists.linaro.org Delivered-To: lng-odp@lists.linaro.org Received: by lists.linaro.org (Postfix, from userid 109) id 2C79460973; Thu, 2 Nov 2017 12:02:26 +0000 (UTC) Received: from forward100o.mail.yandex.net (forward100o.mail.yandex.net [37.140.190.180]) by lists.linaro.org (Postfix) with ESMTPS id 709D761006 for ; Thu, 2 Nov 2017 12:00:12 +0000 (UTC) Received: from mxback1o.mail.yandex.net (mxback1o.mail.yandex.net [IPv6:2a02:6b8:0:1a2d::1b]) by forward100o.mail.yandex.net (Yandex) with ESMTP id 615252A24076 for ; Thu, 2 Nov 2017 15:00:11 +0300 (MSK) Received: from smtp2p.mail.yandex.net (smtp2p.mail.yandex.net [2a02:6b8:0:1472:2741:0:8b6:7]) by mxback1o.mail.yandex.net (nwsmtp/Yandex) with ESMTP id XvWlBXYTr9-0BmeBOTu; Thu, 02 Nov 2017 15:00:11 +0300 Received: by smtp2p.mail.yandex.net (nwsmtp/Yandex) with ESMTPSA id 0qgpfauOww-0A3OfBsN; Thu, 02 Nov 2017 15:00:10 +0300 (using TLSv1.2 with cipher ECDHE-RSA-AES128-SHA256 (128/128 bits)) (Client certificate not present) From: Github ODP bot To: lng-odp@lists.linaro.org Date: Thu, 2 Nov 2017 15:00:07 +0300 Message-Id: <1509624008-24783-4-git-send-email-odpbot@yandex.ru> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1509624008-24783-1-git-send-email-odpbot@yandex.ru> References: <1509624008-24783-1-git-send-email-odpbot@yandex.ru> Github-pr-num: 269 Subject: [lng-odp] [PATCH API-NEXT v1 3/4] linux-gen: pktio: dpdk: set L3/L4 checksum validation flags X-BeenThere: lng-odp@lists.linaro.org X-Mailman-Version: 2.1.16 Precedence: list List-Id: "The OpenDataPlane \(ODP\) List" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: lng-odp-bounces@lists.linaro.org Sender: "lng-odp" From: Bogdan Pricope L3/L4 checksum validation flags are used to report L3/L4 checksum check status for the incoming packets. Signed-off-by: Bogdan Pricope --- /** Email created from pull request 269 (bogdanPricope:api_next_csum_status_pr) ** https://github.com/Linaro/odp/pull/269 ** Patch: https://github.com/Linaro/odp/pull/269.patch ** Base sha: d22c949cc466bf28de559855a1cb525740578137 ** Merge commit sha: 7076ea1cebe42326de76e8bb07709715222f2958 **/ platform/linux-generic/pktio/dpdk.c | 57 ++++++++++++++++++++++++++----------- 1 file changed, 40 insertions(+), 17 deletions(-) diff --git a/platform/linux-generic/pktio/dpdk.c b/platform/linux-generic/pktio/dpdk.c index 9782d60c4..1611a211a 100644 --- a/platform/linux-generic/pktio/dpdk.c +++ b/platform/linux-generic/pktio/dpdk.c @@ -337,9 +337,9 @@ static struct rte_mempool_ops ops_stack = { MEMPOOL_REGISTER_OPS(ops_stack); -#define HAS_IP4_CSUM_FLAG(m, f) ((m->ol_flags & PKT_RX_IP_CKSUM_MASK) == f) +#define IP4_CSUM_RESULT(m) (m->ol_flags & PKT_RX_IP_CKSUM_MASK) +#define L4_CSUM_RESULT(m) (m->ol_flags & PKT_RX_L4_CKSUM_MASK) #define HAS_L4_PROTO(m, proto) ((m->packet_type & RTE_PTYPE_L4_MASK) == proto) -#define HAS_L4_CSUM_FLAG(m, f) ((m->ol_flags & PKT_RX_L4_CKSUM_MASK) == f) #define PKTIN_CSUM_BITS 0x1C @@ -347,29 +347,52 @@ static inline int pkt_set_ol_rx(odp_pktin_config_opt_t *pktin_cfg, odp_packet_hdr_t *pkt_hdr, struct rte_mbuf *mbuf) { + uint32_t packet_csum_result; + if (pktin_cfg->bit.ipv4_chksum && - RTE_ETH_IS_IPV4_HDR(mbuf->packet_type) && - HAS_IP4_CSUM_FLAG(mbuf, PKT_RX_IP_CKSUM_BAD)) { - if (pktin_cfg->bit.drop_ipv4_err) - return -1; + RTE_ETH_IS_IPV4_HDR(mbuf->packet_type)) { + packet_csum_result = IP4_CSUM_RESULT(mbuf); + + if (packet_csum_result == PKT_RX_IP_CKSUM_GOOD) { + pkt_hdr->p.input_flags.l3_chksum_done = 1; + } else if (packet_csum_result != PKT_RX_IP_CKSUM_UNKNOWN) { + if (pktin_cfg->bit.drop_ipv4_err) + return -1; - pkt_hdr->p.error_flags.ip_err = 1; + pkt_hdr->p.input_flags.l3_chksum_done = 1; + pkt_hdr->p.error_flags.ip_err = 1; + pkt_hdr->p.error_flags.l3_chksum = 1; + } } if (pktin_cfg->bit.udp_chksum && - HAS_L4_PROTO(mbuf, RTE_PTYPE_L4_UDP) && - HAS_L4_CSUM_FLAG(mbuf, PKT_RX_L4_CKSUM_BAD)) { - if (pktin_cfg->bit.drop_udp_err) - return -1; + HAS_L4_PROTO(mbuf, RTE_PTYPE_L4_UDP)) { + packet_csum_result = L4_CSUM_RESULT(mbuf); - pkt_hdr->p.error_flags.udp_err = 1; + if (packet_csum_result == PKT_RX_L4_CKSUM_GOOD) { + pkt_hdr->p.input_flags.l4_chksum_done = 1; + } else if (packet_csum_result != PKT_RX_L4_CKSUM_UNKNOWN) { + if (pktin_cfg->bit.drop_udp_err) + return -1; + + pkt_hdr->p.input_flags.l4_chksum_done = 1; + pkt_hdr->p.error_flags.udp_err = 1; + pkt_hdr->p.error_flags.l4_chksum = 1; + } } else if (pktin_cfg->bit.tcp_chksum && - HAS_L4_PROTO(mbuf, RTE_PTYPE_L4_TCP) && - HAS_L4_CSUM_FLAG(mbuf, PKT_RX_L4_CKSUM_BAD)) { - if (pktin_cfg->bit.drop_tcp_err) - return -1; + HAS_L4_PROTO(mbuf, RTE_PTYPE_L4_TCP)) { + packet_csum_result = L4_CSUM_RESULT(mbuf); - pkt_hdr->p.error_flags.tcp_err = 1; + if (packet_csum_result == PKT_RX_L4_CKSUM_GOOD) { + pkt_hdr->p.input_flags.l4_chksum_done = 1; + } else if (packet_csum_result != PKT_RX_L4_CKSUM_UNKNOWN) { + if (pktin_cfg->bit.drop_tcp_err) + return -1; + + pkt_hdr->p.input_flags.l4_chksum_done = 1; + pkt_hdr->p.error_flags.tcp_err = 1; + pkt_hdr->p.error_flags.l4_chksum = 1; + } } return 0; From patchwork Thu Nov 2 12:00:08 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Github ODP bot X-Patchwork-Id: 117808 Delivered-To: patch@linaro.org Received: by 10.140.22.164 with SMTP id 33csp2075814qgn; Thu, 2 Nov 2017 05:04:50 -0700 (PDT) X-Google-Smtp-Source: ABhQp+Txpa8FLru6rhmBB9yE6iLCZDX1T3UAReSqTkLNDxPszHmlPOtRBrv3cXrRzcg6BfEdn0D6 X-Received: by 10.55.217.29 with SMTP id u29mr4263876qki.148.1509624290116; Thu, 02 Nov 2017 05:04:50 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1509624290; cv=none; d=google.com; s=arc-20160816; b=CeXRpgtYjt4YZL4IY7uaBWB+JEnwnwo9m45sNAoaU9+hqkTxedJYwAIhqBwl2xhtLN WcDVnSn0g6KhPkipfuYtBhVYTN1Y4NU7n/cd/5SQ2tN+hu+jsHa7bE/suVlyViazAJnW QbZlXWDtqSGKArJsF+r1yjteXGx1vBvRDwTTAMW3aHXnSSdijEMgk3t8qtU07lJJGOQq XdNA/HC4M12AJchxGPpbE7WTdrk/AnjTopuRdsGCdWlX2+k2dkRBZyKKcvQ6/jyMWAlg TqQ1pNj3pDa7vk4XbbnQlKnBO9BN5hQ6W7Xyq+a+ynks2Hxn4ux1DjwP/cB8SDCy1aH2 dwxQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:subject:github-pr-num :references:in-reply-to:message-id:date:to:from:delivered-to :arc-authentication-results; bh=j0JsH73gerdpkM9U6kutoOtOknB07QYCdTRR5w8/grg=; b=aKHdIx5RPnZizw9Swyae5PbjXaAVeXkBGG6HjclDV4AC/o2rDlsRRSgTP+UOdHDipX 15XIRtBrZPXVZR7fhfK2DlpO+fEq2WAg2qhPBVwL+qJfARqiS9tY+qlu0dFtQCGyc2tz 0HzrLrj8wCcj1VArTFnHK9N3jMj4EfS0FK+G5NMHZ2nRrWqyB4bkonMlLj90nwIRcmVU 2fQueuVE5mYm+U/VGJsEb9QCqEWprPHBmsHuzTd0y35eA4yYG77C7TYbv8Ftt8XRf74T m4Qpz8VQfnRld9HNF1IhH79CVgD28zwDjETRzUuwfqAJXY54q3izkFaxP0ExnRYZlz09 Fcuw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of lng-odp-bounces@lists.linaro.org designates 54.197.127.237 as permitted sender) smtp.mailfrom=lng-odp-bounces@lists.linaro.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=yandex.ru Return-Path: Received: from lists.linaro.org (ec2-54-197-127-237.compute-1.amazonaws.com. [54.197.127.237]) by mx.google.com with ESMTP id p39si2936370qtc.218.2017.11.02.05.04.49; Thu, 02 Nov 2017 05:04:50 -0700 (PDT) Received-SPF: pass (google.com: domain of lng-odp-bounces@lists.linaro.org designates 54.197.127.237 as permitted sender) client-ip=54.197.127.237; Authentication-Results: mx.google.com; spf=pass (google.com: domain of lng-odp-bounces@lists.linaro.org designates 54.197.127.237 as permitted sender) smtp.mailfrom=lng-odp-bounces@lists.linaro.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=yandex.ru Received: by lists.linaro.org (Postfix, from userid 109) id C03F961008; Thu, 2 Nov 2017 12:04:49 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on ip-10-142-244-252 X-Spam-Level: X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00,FREEMAIL_FROM, RCVD_IN_DNSWL_LOW autolearn=disabled version=3.4.0 Received: from [127.0.0.1] (localhost [127.0.0.1]) by lists.linaro.org (Postfix) with ESMTP id E22DD60C1C; Thu, 2 Nov 2017 12:02:42 +0000 (UTC) X-Original-To: lng-odp@lists.linaro.org Delivered-To: lng-odp@lists.linaro.org Received: by lists.linaro.org (Postfix, from userid 109) id 8CA0C60B14; Thu, 2 Nov 2017 12:02:21 +0000 (UTC) Received: from forward101j.mail.yandex.net (forward101j.mail.yandex.net [5.45.198.241]) by lists.linaro.org (Postfix) with ESMTPS id 8D0A260973 for ; Thu, 2 Nov 2017 12:00:14 +0000 (UTC) Received: from mxback3j.mail.yandex.net (mxback3j.mail.yandex.net [IPv6:2a02:6b8:0:1619::10c]) by forward101j.mail.yandex.net (Yandex) with ESMTP id F1DA61244A5C for ; Thu, 2 Nov 2017 15:00:12 +0300 (MSK) Received: from smtp2p.mail.yandex.net (smtp2p.mail.yandex.net [2a02:6b8:0:1472:2741:0:8b6:7]) by mxback3j.mail.yandex.net (nwsmtp/Yandex) with ESMTP id giFpGjwaBj-0CxeY3Mr; Thu, 02 Nov 2017 15:00:12 +0300 Received: by smtp2p.mail.yandex.net (nwsmtp/Yandex) with ESMTPSA id 0qgpfauOww-0B38kx10; Thu, 02 Nov 2017 15:00:11 +0300 (using TLSv1.2 with cipher ECDHE-RSA-AES128-SHA256 (128/128 bits)) (Client certificate not present) From: Github ODP bot To: lng-odp@lists.linaro.org Date: Thu, 2 Nov 2017 15:00:08 +0300 Message-Id: <1509624008-24783-5-git-send-email-odpbot@yandex.ru> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1509624008-24783-1-git-send-email-odpbot@yandex.ru> References: <1509624008-24783-1-git-send-email-odpbot@yandex.ru> Github-pr-num: 269 Subject: [lng-odp] [PATCH API-NEXT v1 4/4] example: generator: use L3/L4 checksum validation status functions X-BeenThere: lng-odp@lists.linaro.org X-Mailman-Version: 2.1.16 Precedence: list List-Id: "The OpenDataPlane \(ODP\) List" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: lng-odp-bounces@lists.linaro.org Sender: "lng-odp" From: Bogdan Pricope Update odp_generator example application to use L3/L4 checksum validation status functions. Signed-off-by: Bogdan Pricope --- /** Email created from pull request 269 (bogdanPricope:api_next_csum_status_pr) ** https://github.com/Linaro/odp/pull/269 ** Patch: https://github.com/Linaro/odp/pull/269.patch ** Base sha: d22c949cc466bf28de559855a1cb525740578137 ** Merge commit sha: 7076ea1cebe42326de76e8bb07709715222f2958 **/ example/generator/odp_generator.c | 25 ++++++++----------------- 1 file changed, 8 insertions(+), 17 deletions(-) diff --git a/example/generator/odp_generator.c b/example/generator/odp_generator.c index 771bd1a2e..912fe7e9e 100644 --- a/example/generator/odp_generator.c +++ b/example/generator/odp_generator.c @@ -784,15 +784,13 @@ static void print_pkts(int thr, odp_packet_t pkt_tbl[], unsigned len) static int gen_recv_thread(void *arg) { int thr; - thread_args_t *thr_args; odp_packet_t pkts[MAX_RX_BURST], pkt; odp_event_t events[MAX_RX_BURST]; int pkt_cnt, ev_cnt, i; - interface_t *itfs, *itf; + odp_packet_chksum_status_t csum_status; + (void)arg; thr = odp_thread_id(); - thr_args = (thread_args_t *)arg; - itfs = thr_args->rx.ifs; printf(" [%02i] created mode: RECEIVE\n", thr); odp_barrier_wait(&barrier); @@ -811,21 +809,14 @@ static int gen_recv_thread(void *arg) continue; for (i = 0, pkt_cnt = 0; i < ev_cnt; i++) { pkt = odp_packet_from_event(events[i]); - itf = &itfs[odp_pktio_index(odp_packet_input(pkt))]; - if (odp_packet_has_ipv4(pkt)) { - if (itf->config.pktin.bit.ipv4_chksum) { - if (odp_packet_has_l3_error(pkt)) - printf("HW detected L3 error\n"); - } - } + csum_status = odp_packet_l3_chksum_status(pkt); + if (csum_status == ODP_PACKET_CHKSUM_BAD) + printf("L3 checksum error detected.\n"); - if (odp_packet_has_udp(pkt)) { - if (itf->config.pktin.bit.udp_chksum) { - if (odp_packet_has_l4_error(pkt)) - printf("HW detected L4 error\n"); - } - } + csum_status = odp_packet_l4_chksum_status(pkt); + if (csum_status == ODP_PACKET_CHKSUM_BAD) + printf("L4 checksum error detected.\n"); /* Drop packets with errors */ if (odp_unlikely(odp_packet_has_error(pkt))) {